[00:02:11] <wikibugs>	 3VisualEditor: VisualEditor:  Some links to URLs are being displayed as red - 10https://bugzilla.wikimedia.org/72287 (10WhatamIdoing) 3NEW p:3Unprio s:3normal a:3None This may only be happening to links inside templates or refs.    Steps to reproduce:  1.  Click on https://en.wikipedia.org/wiki/HOSxP?v...
[00:02:38] <wikibugs>	 3VisualEditor: VisualEditor: Some links to URLs are being displayed as red - 10https://bugzilla.wikimedia.org/72287#c1 (10James Forrester) 5NEW>3RESO/DUP   *** This bug has been marked as a duplicate of bug 72251 ***
[00:02:38] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression wmf3] External links are rendered as red links now - 10https://bugzilla.wikimedia.org/72251#c2 (10James Forrester) *** Bug 72287 has been marked as a duplicate of this bug. ***
[00:18:51] <grrrit-wm1>	 (03CR) 10Trevor Parscal: [C: 032] Display keyboard shortcuts in right gutter of toolbar menus [oojs/ui] - 10https://gerrit.wikimedia.org/r/166627 (https://bugzilla.wikimedia.org/71855) (owner: 10Bartosz Dziewoński)
[00:21:19] <grrrit-wm1>	 (03Merged) 10jenkins-bot: Display keyboard shortcuts in right gutter of toolbar menus [oojs/ui] - 10https://gerrit.wikimedia.org/r/166627 (https://bugzilla.wikimedia.org/71855) (owner: 10Bartosz Dziewoński)
[00:29:14] <grrrit-wm1>	 (03PS3) 10Divec: WIP: Refactor SurfaceObserver pollOnceInternal [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166188 
[00:31:02] <grrrit-wm1>	 (03CR) 10jenkins-bot: [V: 04-1] WIP: Refactor SurfaceObserver pollOnceInternal [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166188 (owner: 10Divec)
[00:31:32] <TrevorParscal>	 MatmaRex: do you have things to work on for tomorrow?
[00:31:45] <TrevorParscal>	 Are you in need of any work, or do you have enough to keep you busy?
[00:32:38] <MatmaRex>	 TrevorParscal: i have quite an abundance
[00:32:48] <TrevorParscal>	 good, no worries then
[00:32:55] <MatmaRex>	 :)
[00:32:57] <TrevorParscal>	 I'm going to email you about https://gerrit.wikimedia.org/r/#/c/165922/ and where we need to take it
[00:33:05] <TrevorParscal>	 but, probably tomorrow
[00:33:27] <MatmaRex>	 uhm, okay
[00:37:42] <MatmaRex>	 night
[00:45:01] <grrrit-wm1>	 (03PS4) 10Divec: WIP: Show entire expandable call tree in ve.Filibuster [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167021 
[01:13:00] <grrrit-wm1>	 (03PS1) 10SuchetaG: Fixing the delay in the spinner to appear on clicking edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167736 
[01:14:43] <grrrit-wm1>	 (03CR) 10jenkins-bot: [V: 04-1] Fixing the delay in the spinner to appear on clicking edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167736 (owner: 10SuchetaG)
[01:18:09] <grrrit-wm1>	 (03CR) 10Catrope: [C: 04-1] Fixing the delay in the spinner to appear on clicking edit (034 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167736 (owner: 10SuchetaG)
[01:24:52] <grrrit-wm1>	 (03PS4) 10Divec: WIP: Refactor SurfaceObserver pollOnceInternal [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166188 
[02:28:02] <grrrit-wm1>	 (03CR) 10Catrope: [C: 04-1] Data model implementation for tables (0343 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159310 (owner: 10Oliverb)
[02:28:09] <RoanKattouw>	 (Is that a record?)
[02:31:49] <James_F>	 RoanKattouw: Probably not. :-)
[02:32:04] <James_F>	 RoanKattouw: How much more of the stack do you have to review?
[02:32:33] <RoanKattouw>	 That was almost half of it AIUI
[02:33:19] <James_F>	 Yay.
[02:37:13] <RoanKattouw>	 Hmph or maybe more like 1/3
[02:51:54] <James_F>	 RoanKattouw: https://meta.wikimedia.org/wiki/Schema:Edit
[04:17:41] <grrrit-wm1>	 (03PS2) 10SuchetaG: Fixing the delay in the spinner to appear and the change in the URL on clicking edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167736 (https://bugzilla.wikimedia.org/65453) 
[04:19:17] <grrrit-wm1>	 (03CR) 10jenkins-bot: [V: 04-1] Fixing the delay in the spinner to appear and the change in the URL on clicking edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167736 (https://bugzilla.wikimedia.org/65453) (owner: 10SuchetaG)
[04:26:59] <grrrit-wm1>	 (03PS3) 10SuchetaG: Fixing the delay in the spinner to appear and the change in the URL on clicking edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167736 (https://bugzilla.wikimedia.org/65453) 
[04:49:19] <quiddity>	 RoanKattouw_away, re: "(Is that a record?)"  -  there were 58 comments in patchset 13 of https://gerrit.wikimedia.org/r/#/c/165756/   (that was from Friday, hence I remembered, and could find in -corefeatures scrollback ;)
[05:50:55] <wikibugs>	 3VisualEditor / 3Editing Tools: Možná hledáte at cs.wp - 10https://bugzilla.wikimedia.org/72293 (10Juan de Vojníkov) 3NEW p:3Unprio s:3normal a:3None While some templates are easy to use in VE, this is not. At first VE doesnt load automatically its parameters, at second you need to enter hyperling to...
[07:30:35] <grrrit-wm1>	 (03CR) 10Catrope: [C: 04-1] "This commit introduces some code duplication with the spinner code, but there's already lots of duplicated code in the init file, so it's " (036 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167736 (https://bugzilla.wikimedia.org/65453) (owner: 10SuchetaG)
[07:45:54] <wikibugs>	 3VisualEditor / 3Editing Tools: "Možná hledáte" template on cs.wp not easy to use with VE - 10https://bugzilla.wikimedia.org/72293#c1 (10Andre Klapper) (In reply to Juan de Vojníkov from comment #0) > At first VE doesnt load automatically its parameters  Is that bug 69734?
[08:41:13] <wikibugs>	 3VisualEditor / 3Editing Tools: "Možná hledáte" template on cs.wp not easy to use with VE - 10https://bugzilla.wikimedia.org/72293#c2 (10Elitre) I don't think so. It seems to me this template lacks TemplateData information (https://www.mediawiki.org/wiki/Help:TemplateData ). That's easier to add now (see my...
[09:42:34] <grrrit-wm1>	 (03PS3) 10Mvolz: maps added as allowed value in TD JSON root [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167389 
[09:46:18] <grrrit-wm1>	 (03PS4) 10Mvolz: maps added as allowed value in TD JSON root [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167389 
[10:48:06] <grrrit-wm1>	 (03PS1) 10Mvolz: Methods for new TD maps added to TemplateSpecModel [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167772 
[11:32:52] <grrrit-wm1>	 (03CR) 10Esanders: Data model implementation for tables (0333 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159310 (owner: 10Oliverb)
[11:43:36] <grrrit-wm1>	 (03PS35) 10Esanders: Data model implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159310 (owner: 10Oliverb)
[11:43:38] <grrrit-wm1>	 (03PS37) 10Esanders: ContentEditable implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159311 (owner: 10Oliverb)
[11:43:40] <grrrit-wm1>	 (03PS4) 10Esanders: Merge cells tool [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167631 
[11:43:42] <grrrit-wm1>	 (03PS5) 10Esanders: Supporting copy paste of single table cells [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167559 
[11:43:44] <grrrit-wm1>	 (03PS12) 10Esanders: Support annotation tool on table selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166774 
[11:43:46] <grrrit-wm1>	 (03PS42) 10Esanders: Actions and context menus for manipulating tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb)
[11:43:48] <grrrit-wm1>	 (03CR) 10jenkins-bot: [V: 04-1] Merge cells tool [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167631 (owner: 10Esanders)
[11:43:50] <grrrit-wm1>	 (03CR) 10jenkins-bot: [V: 04-1] Supporting copy paste of single table cells [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167559 (owner: 10Esanders)
[11:43:52] <grrrit-wm1>	 (03CR) 10jenkins-bot: [V: 04-1] Support annotation tool on table selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166774 (owner: 10Esanders)
[11:43:54] <grrrit-wm1>	 (03CR) 10jenkins-bot: [V: 04-1] Actions and context menus for manipulating tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb)
[11:45:21] <grrrit-wm1>	 (03CR) 10jenkins-bot: [V: 04-1] Data model implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159310 (owner: 10Oliverb)
[11:45:27] <grrrit-wm1>	 (03CR) 10jenkins-bot: [V: 04-1] ContentEditable implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159311 (owner: 10Oliverb)
[11:52:37] <grrrit-wm1>	 (03PS5) 10Esanders: Merge cells tool [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167631 
[11:52:39] <grrrit-wm1>	 (03CR) 10jenkins-bot: [V: 04-1] Merge cells tool [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167631 (owner: 10Esanders)
[12:13:12] <grrrit-wm1>	 (03PS36) 10Esanders: Data model implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159310 (owner: 10Oliverb)
[12:13:14] <grrrit-wm1>	 (03PS38) 10Esanders: ContentEditable implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159311 (owner: 10Oliverb)
[12:13:16] <grrrit-wm1>	 (03PS6) 10Esanders: Merge cells tool [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167631 
[12:13:18] <grrrit-wm1>	 (03PS6) 10Esanders: Supporting copy paste of single table cells [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167559 
[12:13:20] <grrrit-wm1>	 (03PS13) 10Esanders: Support annotation tool on table selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166774 
[12:13:22] <grrrit-wm1>	 (03PS43) 10Esanders: Actions and context menus for manipulating tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb)
[12:14:47] <grrrit-wm1>	 (03CR) 10jenkins-bot: [V: 04-1] Actions and context menus for manipulating tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb)
[12:16:59] <grrrit-wm1>	 (03CR) 10jenkins-bot: [V: 04-1] Merge cells tool [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167631 (owner: 10Esanders)
[12:17:01] <grrrit-wm1>	 (03CR) 10jenkins-bot: [V: 04-1] Data model implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159310 (owner: 10Oliverb)
[12:33:37] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: Some categories not showing up in category dialog on a category page - 10https://bugzilla.wikimedia.org/61921 (10Elitre)
[12:34:55] <wikibugs>	 3VisualEditor: VisualEditor: Categories not showing up in category dialog on a category page - 10https://bugzilla.wikimedia.org/72303 (10Elitre) 3NEW p:3Unprio s:3normal a:3None Open https://it.wikipedia.org/wiki/Categoria:Personalità_del_buddhismo?veaction=edit . Notice that no categories appear in th...
[12:35:08] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: Some categories not showing up in category dialog on a category page - 10https://bugzilla.wikimedia.org/61921 (10Elitre)
[12:35:08] <wikibugs>	 3VisualEditor: VisualEditor: Categories not showing up in category dialog on a category page - 10https://bugzilla.wikimedia.org/72303 (10Elitre)
[12:44:55] <wikibugs>	 3VisualEditor / 3Editing Tools: Parsoid 0.1.15 generates 500 errors when editing pages - 10https://bugzilla.wikimedia.org/72304 (10Chris C) 3NEW p:3Unprio s:3major a:3None This site, https://wiki.transitionnetwork.org/ is running on amd64 Debian Wheezy with Parsoid installed using apt as per the inst...
[13:43:27] <grrrit-wm1>	 (03PS54) 10Paladox: WikiEditor: Convert .css to .less and also fixes SVG issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) 
[14:45:52] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: Some categories not showing up in category dialog on a category page - 10https://bugzilla.wikimedia.org/61921#c2 (10Alex Monk) 5ASSI>3RESO/INV The only two categories on this page directly are listed by VE. Obviously, we can't include transcluded cate...
[15:05:55] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor:[pre-wmf5]Context menu label, first changes to read “Comment” before undoing any comment. - 10https://bugzilla.wikimedia.org/72315 (10Ritu Swain) 3UNCO p:3Unprio s:3minor a:3None Environment- beta.  1> In VE, insert a comment. Click done. 2> click to undo...
[15:10:22] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor:[pre-wmf5]Context menu label,  first changes to read “Comment” before undoing any comment. - 10https://bugzilla.wikimedia.org/72315#c1 (10Ritu Swain) http://youtu.be/ws3ObsyZijc
[15:35:21] <grrrit-wm1>	 (03PS1) 10Zfilipin: [BrowserTest] Prepare repository for running RuboCop after every push to Gerrit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167823 (https://bugzilla.wikimedia.org/69245) 
[15:37:08] <grrrit-wm1>	 (03CR) 10Zfilipin: "check experimental" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167823 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin)
[16:22:29] <grrrit-wm1>	 (03CR) 10Jforrester: [C: 032] [BrowserTest] Prepare repository for running RuboCop after every push to Gerrit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167823 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin)
[16:22:59] <grrrit-wm1>	 (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167631 (owner: 10Esanders)
[16:23:44] <grrrit-wm1>	 (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb)
[16:24:12] <grrrit-wm1>	 (03Merged) 10jenkins-bot: [BrowserTest] Prepare repository for running RuboCop after every push to Gerrit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167823 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin)
[16:29:42] <grrrit-wm1>	 (03CR) 10Esanders: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159310 (owner: 10Oliverb)
[16:31:04] <grrrit-wm1>	 (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167389 (owner: 10Mvolz)
[16:31:07] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=108378978
[16:31:08] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=108379059
[16:31:08] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=108379794
[16:31:08] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=108380208
[16:31:08] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=108383535
[16:31:08] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=108403899
[16:31:08] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=33036904
[16:31:09] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=66344262
[16:31:09] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=66352919
[16:31:10] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on plwiki: https://pl.wikipedia.org/?diff=40749357
[16:31:10] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on plwiki: https://pl.wikipedia.org/?diff=40755517
[16:31:11] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on plwiki: https://pl.wikipedia.org/?diff=40756148
[16:31:12] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on itwiki: https://it.wikipedia.org/?diff=68762099
[16:52:06] <grrrit-wm1>	 (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/163029 (https://bugzilla.wikimedia.org/67621) (owner: 10Jforrester)
[16:52:53] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Cursor moves to the end of the line, if comment,link and language are present . - 10https://bugzilla.wikimedia.org/69438#c2 (10etonkovidova) 5UNCO>3NEW Confirmed in Betalabs and test2.   After inserting a comment and a link, a cursor is moved at the end of...
[17:33:18] <grrrit-wm1>	 (03PS37) 10Esanders: Data model implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159310 (owner: 10Oliverb)
[17:33:20] <grrrit-wm1>	 (03PS39) 10Esanders: ContentEditable implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159311 (owner: 10Oliverb)
[17:33:22] <grrrit-wm1>	 (03PS7) 10Esanders: Merge cells tool [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167631 
[17:33:24] <grrrit-wm1>	 (03PS7) 10Esanders: Supporting copy paste of single table cells [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167559 
[17:33:26] <grrrit-wm1>	 (03PS14) 10Esanders: Support annotation tool on table selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166774 
[17:33:28] <grrrit-wm1>	 (03PS44) 10Esanders: Actions and context menus for manipulating tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb)
[17:35:07] <grrrit-wm1>	 (03CR) 10jenkins-bot: [V: 04-1] Actions and context menus for manipulating tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb)
[17:35:47] <grrrit-wm1>	 (03CR) 10Catrope: Data model implementation for tables (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159310 (owner: 10Oliverb)
[17:36:14] <grrrit-wm1>	 (03CR) 10Catrope: Data model implementation for tables (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159310 (owner: 10Oliverb)
[17:39:07] <James_F>	 mooeypoo: Could you +2 https://gerrit.wikimedia.org/r/#/c/163029/ and its antecedent? :-)
[17:40:55] <mooeypoo>	 James_F, sure thang. But there's a comment there, I assume it was resolved by the followup comment https://gerrit.wikimedia.org/r/#/c/163028/1/i18n/en.json
[17:40:56] <mooeypoo>	 ?
[17:41:11] <mooeypoo>	 'cause Siebrand -1'ed
[17:41:34] <James_F>	 mooeypoo: In this case, it's advice I'm choosing to ignore, per community wishes.
[17:41:47] * mooeypoo nods
[17:41:56] <mooeypoo>	 do I need to do something when I +2 because it's -1'ed ?
[17:42:57] <mooeypoo>	 Isa there a way to un-1 or do I just +2 regardless of that -1?
[17:43:55] <James_F>	 Only the reviewer can change their review.
[17:44:06] <James_F>	 Just comment saying that we're choosing to ignore per community request.
[17:44:18] * mooeypoo nods
[17:46:29] <grrrit-wm1>	 (03CR) 10Mooeypoo: [C: 032] "Mergine despite Seibrand's comment, as per community request." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/163028 (https://bugzilla.wikimedia.org/63389) (owner: 10Jforrester)
[17:47:07] <grrrit-wm1>	 (03Merged) 10jenkins-bot: Re-label "Manage template documentation" to "Manage TemplateData" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/163028 (https://bugzilla.wikimedia.org/63389) (owner: 10Jforrester)
[17:47:56] <mooeypoo>	 wow I can't believe I didn't think about 163029 when I made that link in the first place... it's as if I didn't know there are any other languages than English
[17:48:01] <grrrit-wm1>	 (03CR) 10Siebrand: "I call BS on merging this with the current motivation." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/163028 (https://bugzilla.wikimedia.org/63389) (owner: 10Jforrester)
[17:48:14] <mooeypoo>	 oh, wonderful. James_F ? ^^
[17:48:24] <wikibugs>	 3MediaWiki extensions / 3TemplateData: TemplateData: Re-label "Manage template documentation" to something else - 10https://bugzilla.wikimedia.org/63389 (10James Forrester) 5PATC>3RESO/FIX a:3James Forrester
[17:48:31] <James_F>	 mooeypoo: He's sitting next to me at "your" desk… :-)
[17:48:47] <mooeypoo>	 rofl
[17:48:51] <mooeypoo>	 smartass.
[17:49:58] <grrrit-wm1>	 (03CR) 10Cscott: "Woot!" [oojs/ui] - 10https://gerrit.wikimedia.org/r/167706 (owner: 10Esanders)
[17:50:43] <grrrit-wm1>	 (03CR) 10Mooeypoo: [C: 032] "Yes! Good point, and good fix." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/163029 (https://bugzilla.wikimedia.org/67621) (owner: 10Jforrester)
[17:50:52] <James_F>	 :-)
[17:51:00] <cscott>	 RoanKattouw, edsanders: so, what's the oojs/ui deployment schedule?  now that https://gerrit.wikimedia.org/r/167706 is merged, how long do i have to wait before i can use it in the collection extension deployed on enwiki?
[17:51:19] <RoanKattouw>	 It needs to be pulled through into MW core I think
[17:51:29] <RoanKattouw>	 MW core contains a distribution of oojs-ui that is periodically updated
[17:51:34] <RoanKattouw>	 at least once a week
[17:51:50] <RoanKattouw>	 So this widget will be in the new wmf branch (wmf5?) that gets cut on Thursday
[17:51:59] <cscott>	 and then it rides the train after that.  so in two weeks i'd expect that code to work on all wikis, more or less.
[17:52:18] <RoanKattouw>	 So you can start writing Collection code against it right now as long as it also rides the train
[17:52:38] <cscott>	 but mw core hasn't gotten an oojs-ui update yet has it?
[17:52:46] <cscott>	 i should really wait until that happens
[17:52:50] <RoanKattouw>	 Yeah
[17:52:52] <RoanKattouw>	 I'll do one
[17:53:07] <cscott>	 you're removing all my excuses for now working on this Right Now. ;)
[17:53:13] <RoanKattouw>	 haha
[17:53:15] <James_F>	 RoanKattouw: Wait for Ed's patches.
[17:53:19] <RoanKattouw>	 Yeah...
[17:53:24] <cscott>	 James_F: thank you!
[17:53:27] <RoanKattouw>	 cscott: OK I will definitely do one by tomorrow
[17:53:36] <RoanKattouw>	 I want to get TrevorParscal to merge some more stuff first
[17:53:42] <cscott>	 ok, tomorrow i'll take a look at oojs/ui madness then.
[17:53:45] <James_F>	 RoanKattouw: Or I will. ;-)
[17:53:52] <grrrit-wm1>	 (03Merged) 10jenkins-bot: Let help link target be locally over-ridden; default to the MW help page [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/163029 (https://bugzilla.wikimedia.org/67621) (owner: 10Jforrester)
[17:53:54] <cscott>	 ping me when you do the merge, if you remember
[17:54:00] <RoanKattouw>	 Sure
[17:54:33] <cscott>	 and i think i asked yesterday if there were any friendly "so you want to migrate your widgets to oojs/ui" docs written, and you said "not really"
[17:54:53] <wikibugs>	 3MediaWiki extensions / 3TemplateData: TemplateData: add tooltip/quick link to TD help page near new TD editor button - 10https://bugzilla.wikimedia.org/67621 (10James Forrester) 5PATC>3RESO/FIX
[17:55:38] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Cursor moves to the end of the line, if comment,link and language are present . - 10https://bugzilla.wikimedia.org/69438 (10etonkovidova) p:5Unprio>3Normal
[17:56:26] <James_F>	 cscott: Yeah, sadly.
[17:57:05] <cscott>	 maybe someone will write one by tomorrow ;)
[17:58:39] <James_F>	 RoanKattouw: Please stop getting louder and louder. You're now shouting at your desk. :-)
[17:58:49] <James_F>	 RoanKattouw: Even if it is very exciting. :-)
[18:03:29] * cscott is curious
[18:05:38] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: After inserting a comment and a link, a cursor is moved at the end of the line, but typed text gets inserted between the comment and the link - 10https://bugzilla.wikimedia.org/69438 (10James Forrester) 5NEW>3ASSI p:5Normal>3High
[18:06:52] * legoktm is curious too :o
[18:07:37] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: Categories set in wikitext not showing up in category dialog on a category page - 10https://bugzilla.wikimedia.org/72303 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal s:5normal>3minor
[18:07:52] <James_F>	 legoktm: RoanKattouw is have a Hangout meeting at-desk and was bellowing into the microphone. :-)
[18:08:05] <cscott>	 i was hoping for something more sporting
[18:08:20] <legoktm>	 haha
[18:08:51] <James_F>	 This is what happens when people use active-dampening headphones.
[18:10:25] <James_F>	 Krenair: ^^^ Sorry for giving you yet another one. :-(
[18:10:28] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression] Adding category sort keys no longer working - 10https://bugzilla.wikimedia.org/72168 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High a:3Alex Monk
[18:11:53] <wikibugs>	 3VisualEditor / 3Data Model: VisualEditor: [Regression] VE corruption issue(?) causing new categories to be put in the middle not at the end of the page - 10https://bugzilla.wikimedia.org/72048 (10James Forrester) 5NEW>3ASSI
[18:13:09] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: When auto-filling citations using citoid, don't add any empty parameters - 10https://bugzilla.wikimedia.org/72007#c1 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal s:5minor>3enhanc a:3marielle.volz There isn't any VE code using citoid yet, just a...
[18:14:37] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor:  New and changed citations display with blank lines before and after the citation in <references />, if using citation templates - 10https://bugzilla.wikimedia.org/72006#c1 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High Is this caused by our recent chan...
[18:16:37] <mooeypoo>	 Eh. Anyone remembers how I can get the wiki default language tag in mw js? I can check the body language tag, but there's got to be a mw variable for it. Not UI, though. Wiki language. I can't find it.
[18:16:40] <mooeypoo>	 Krenair, any ideas?
[18:16:58] <RoanKattouw>	 wgLang or wgUserLang or something?
[18:17:13] <mooeypoo>	 there's a php way, but I can't figure out the javascript one.
[18:17:17] <mooeypoo>	 docs are really quite annoying.
[18:17:22] <wikibugs>	 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression] Link icon is missing in from the toolbar - 10https://bugzilla.wikimedia.org/71903 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High s:5normal>3minor
[18:17:44] <mooeypoo>	 Ah! wgContentLanguage
[18:19:07] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Proposed external links should be validated before being created - 10https://bugzilla.wikimedia.org/71795 (10James Forrester) 5UNCO>3ASSI p:5Unprio>3Lowest
[18:20:35] <grrrit-wm1>	 (03PS1) 10Catrope: Followup fbc7ecb: make mediawiki.mobile depend on core.mobile, not core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167850 (https://bugzilla.wikimedia.org/72282) 
[18:22:53] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor:[pre-wmf5]Context menu label,  first changes to read “Comment” before undoing any comment. - 10https://bugzilla.wikimedia.org/72315#c2 (10etonkovidova) 5UNCO>3NEW p:5Unprio>3Low s:5minor>3normal Confirmed in Beta(test2 and production do not have that i...
[18:23:07] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression] Link searching broken in reference and media dialogs - 10https://bugzilla.wikimedia.org/72121 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal s:5normal>3major
[18:23:39] <James_F>	 Krenair: ^^^ Is a much more interesting (and important) one, and not to do with categories. :-)
[18:23:54] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression] Link searching broken in reference and media dialogs - 10https://bugzilla.wikimedia.org/72121 (10James Forrester) a:3Alex Monk
[18:27:37] <wikibugs>	 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression] Link icon is missing in from the toolbar - 10https://bugzilla.wikimedia.org/71903#c1 (10Jon) Which browser? Link icon appears to be showing for me...
[18:29:37] <wikibugs>	 3OOjs UI: OOjs UI: Dialog height initially mis-measured in Safari 7.1 - 10https://bugzilla.wikimedia.org/71736#c1 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High Confirmed in Safari 7.1; this looks like an OOjs UI issue mis-measuring the height of the screen space for the window. If you make the window...
[18:31:09] <wikibugs>	 3OOjs UI: OOjs UI: Dialog height initially mis-measured in Safari 7.1 - 10https://bugzilla.wikimedia.org/71736#c2 (10Roan Kattouw) (In reply to James Forrester from comment #1) > If you make the window (viewport) > size as large as the *page* it suddenly snaps to the right size.  This makes me suspect there's...
[18:31:52] <grrrit-wm1>	 (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (44db8292bf) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167854 
[18:32:55] <grrrit-wm1>	 (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (44db8292bf) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167854 (owner: 10Jforrester)
[18:33:12] <RoanKattouw>	 James_F: No core pull-through yet?
[18:34:40] <James_F>	 RoanKattouw: https://gerrit.wikimedia.org/r/167855
[18:34:48] <grrrit-wm1>	 (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (44db8292bf) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167854 (owner: 10Jforrester)
[18:35:44] <cscott>	 whoo
[18:36:02] <James_F>	 Also, ping cscott. ;-)
[18:41:07] <mooeypoo>	 hm, James_F any parameter property in templatedata that is "interfaceText" is allowing for multiple languages, right?
[18:45:40] <grrrit-wm1>	 (03CR) 10Siebrand: "i18n/L10n reviewed." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167631 (owner: 10Esanders)
[18:45:52] <grrrit-wm1>	 (03CR) 10Siebrand: "i18n/L10n reviewed." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb)
[18:50:53] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression ?wmf3] Non-normalised category names cause "Uncaught TypeError: Cannot read property 'hidden' of undefined" to be thrown - 10https://bugzilla.wikimedia.org/72080#c3 (10Alex Monk) *** Bug 72303 has been marked as a duplicate of this bug. ***
[18:50:53] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: Categories set in wikitext not showing up in category dialog on a category page - 10https://bugzilla.wikimedia.org/72303#c1 (10Alex Monk) 5ASSI>3RESO/DUP   *** This bug has been marked as a duplicate of bug 72080 ***
[18:51:39] <James_F>	 mooeypoo: Yes?
[18:51:55] * mooeypoo is doing some language magic 
[18:52:02] <James_F>	 mooeypoo: Sounds good. :-)
[18:52:09] <mooeypoo>	 If it works, it will be!
[18:52:11] <mooeypoo>	 :D
[18:52:16] <mooeypoo>	 I mean *when* it works.
[18:52:17] <mooeypoo>	 When.
[18:52:30] <mooeypoo>	 Speaking of which, I should take a break from templatedata and go fix the bugs.
[18:56:12] * James_F grins.
[18:56:24] <wikibugs>	 3OOjs UI: OOjs UI: Dialog height initially mis-measured in Safari 7.1 - 10https://bugzilla.wikimedia.org/71736#c3 (10James Forrester) (In reply to Roan Kattouw from comment #2) > (In reply to James Forrester from comment #1) > > If you make the window (viewport) > > size as large as the *page* it suddenly snap...
[18:57:07] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor:  Make it easy to identify the file type (e.g., .png versus .svg) when adding an image - 10https://bugzilla.wikimedia.org/72061 (10James Forrester)
[18:57:28] <James_F>	 mooeypoo: You prioritising https://bugzilla.wikimedia.org/show_bug.cgi?id=71065 or https://bugzilla.wikimedia.org/show_bug.cgi?id=72155 ?
[18:58:20] <mooeypoo>	 I'm working on this one now -- https://bugzilla.wikimedia.org/show_bug.cgi?id=72155
[18:58:29] * James_F nods.
[18:58:39] <wikibugs>	 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression] Link icon is missing in from the toolbar - 10https://bugzilla.wikimedia.org/71903#c2 (10James Forrester) 5ASSI>3RESO/FIX a:3Roan Kattouw Argh, yes, this was fixed in wmf3 I believe.
[18:58:49] <mooeypoo>	 BTW, 71065 is in surfaces in general. I was going to take a look; for some reason it doesn't trigger the hasBeenChanged() status change. 
[18:58:56] <James_F>	 71065 is probably a … yeah.
[18:59:01] <James_F>	 For all annotations?
[18:59:10] <mooeypoo>	 I think so
[18:59:24] <mooeypoo>	 Which is a bit weird, because annotations still change the model
[18:59:58] <mooeypoo>	 I'd have expected this to happen with references or something like tha.
[19:00:00] <mooeypoo>	 +t
[19:00:24] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Edit  comment dialog turns blank, when applying a text style, Uncaught TypeError:Cannot Read Property 'getSurface of null'. - 10https://bugzilla.wikimedia.org/69262#c5 (10etonkovidova) p:5Unprio>3Low In addition to my previous comment: the edit comment pop-up...
[19:02:45] <Krenair>	 Is there some way to turn off git's addition of 'a/' and 'b/' to file paths in diffs?
[19:04:23] <mooeypoo>	 RoanKattouw, remember I've changed the way 'changed' event is emitted in MediaSizeWidget and you said you're merging it under protest?
[19:04:29] <mooeypoo>	 RoanKattouw, so, about that....
[19:04:31] <RoanKattouw>	 Krenair: Do you need it to be stripped for the purposes of feeding to the 'patch' command, or for some other reason?
[19:04:35] <mooeypoo>	 :P 
[19:04:41] <RoanKattouw>	 mooeypoo: ...was I right?
[19:04:54] <mooeypoo>	 ... maybe.
[19:04:59] <mooeypoo>	 And by "maybe" I mean "Absolutely."
[19:05:12] <Krenair>	 So I can double click file paths and have it select only the file path :p
[19:05:18] <RoanKattouw>	 Krenair: Ugh, right
[19:05:41] <Krenair>	 (yeah, not that important. just a minor annoyance)
[19:05:43] <mooeypoo>	 I'm working on a different approach here on emitting the events, and adding another event type, too. I hope that will sort it out logically *and* functionally.
[19:05:44] <RoanKattouw>	 mooeypoo: "Trevor, isn't it .css( 'direction' ) instead of .css( 'dir' )?"  "No! ... Maybe? ... Yes. ... It worked in LTR."
[19:06:00] <mooeypoo>	 :D
[19:07:05] <mooeypoo>	 oh, boo, I'm conflicting names
[19:07:06] <grrrit-wm1>	 (03PS1) 10Cmcmahon: [BrowserTest] create simple test for Basic Citation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167869 
[19:08:44] <Krenair>	 So https://bugzilla.wikimedia.org/show_bug.cgi?id=72168 looks to be caused by MWCategoryPopupWidget#onHide never being called
[19:09:13] <Krenair>	 That's just the handler for the 'hide' event that the parent class (PopupWidget) is supposed to run
[19:09:35] <Krenair>	 Supposed to.
[19:10:37] <grrrit-wm1>	 (03PS2) 10Cmcmahon: [BrowserTest] create simple test for Basic Citation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167869 
[19:10:39] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Inserting a comment before the last word in a Language (RTL direction)Text moves the word to the start of the line. - 10https://bugzilla.wikimedia.org/71320 (10etonkovidova) p:5Unprio>3Normal
[19:12:15] <Krenair>	 Looks like that event was killed by the dialog refactor, but remains documented
[19:14:58] <grrrit-wm1>	 (03CR) 10Ryasmeen: [C: 04-1] "Chris, you made a mistake" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167869 (owner: 10Cmcmahon)
[19:15:18] <grrrit-wm1>	 (03CR) 10Ryasmeen: "You need more steps!" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167869 (owner: 10Cmcmahon)
[19:17:06] <grrrit-wm1>	 (03CR) 10Ryasmeen: [C: 032] "Chris and Rummana paired on this patch" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167869 (owner: 10Cmcmahon)
[19:17:23] <wikibugs>	 3VisualEditor / 3Data Model: VisualEditor: [Regression] VE corruption issue(?) moving pre-existing categories to the middle of the page - 10https://bugzilla.wikimedia.org/72048 (10WhatamIdoing)
[19:18:48] <grrrit-wm1>	 (03Merged) 10jenkins-bot: [BrowserTest] create simple test for Basic Citation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167869 (owner: 10Cmcmahon)
[19:20:51] <grrrit-wm1>	 (03PS1) 10Alex Monk: CategoryPopupWidget: Track popup hiding again so sortkey changes are applied [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167876 (https://bugzilla.wikimedia.org/72168) 
[19:22:27] <grrrit-wm1>	 (03PS1) 10Alex Monk: PopupWidget: Remove references to 'show' and 'hide' events [oojs/ui] - 10https://gerrit.wikimedia.org/r/167877 (https://bugzilla.wikimedia.org/72168) 
[19:25:51] <Krenair>	 James_F, so the meeting I mentioned earlier actually clashes with KIT
[19:25:55] <Krenair>	 (thanks, DST)
[19:26:09] <grrrit-wm1>	 (03CR) 10Catrope: [C: 04-1] CategoryPopupWidget: Track popup hiding again so sortkey changes are applied (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167876 (https://bugzilla.wikimedia.org/72168) (owner: 10Alex Monk)
[19:26:19] <Krenair>	 I had thought it was an hour beforehand. Sigh.
[19:27:56] <RoanKattouw>	 FYI in case this is a recurring thing: DST is going to make the meeting time weird next week
[19:28:02] <grrrit-wm1>	 (03PS2) 10Alex Monk: CategoryPopupWidget: Track popup hiding again so sortkey changes are applied [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167876 (https://bugzilla.wikimedia.org/72168) 
[19:28:10] <Krenair>	 Yeah.
[19:28:12] <RoanKattouw>	 Because the meeting time is anchored to SF time, but DST changes in Europe this Sunday and in the US the Sunday after
[19:29:03] <Krenair>	 I might miss a KIT one day due to it clashing with college things. Should be fine once SF goes back though.
[19:29:51] <RoanKattouw>	 Right
[19:29:59] <grrrit-wm1>	 (03PS4) 10SuchetaG: Fixing the delay in the spinner to appear and the change in the URL on clicking edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167736 (https://bugzilla.wikimedia.org/65453) 
[19:30:01] <RoanKattouw>	 And it's only off for one week, so that's only one KIT, so not a big deal
[19:30:53] <Krenair>	 IIRC a similar thing happened in March
[19:33:14] <Krenair>	 DST starts again 29th March for me, but 8th of March for SF
[19:35:53] <grrrit-wm1>	 (03CR) 10Catrope: [C: 04-1] Fixing the delay in the spinner to appear and the change in the URL on clicking edit (033 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167736 (https://bugzilla.wikimedia.org/65453) (owner: 10SuchetaG)
[19:36:00] <RoanKattouw>	 Yes
[19:36:11] <RoanKattouw>	 It's usually 2 weeks in March
[19:36:17] <RoanKattouw>	 Except if there are five Sundays in March, then it's 3 weeks
[19:36:48] <RoanKattouw>	 The US switches to DST on the 2nd Sunday of March, and the EU on the last Sunday, so those are either 2 or 3 weeks apart depending on the year
[19:37:08] <RoanKattouw>	 Switching away from DST happens on the last Sunday in October in the EU and the first Sunday in November in the US, so those are always one week apart
[19:38:09] <RoanKattouw>	 There are / used to be countries that switched on a Friday or Saturday instead, but I think Israel cleaned up its act recently so I don't know if any of those are left
[19:38:59] <RoanKattouw>	 Also DST is reversed in the southern hemisphere, and they (or at least Australia) switch in April and ... early October or late September, I forget
[19:43:18] <sucheta>	 ARGH. 
[19:45:24] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: Some categories not showing up in category dialog on a category page - 10https://bugzilla.wikimedia.org/61921#c3 (10Elitre) So... is there a bug about how VE needs to be doing that yet?
[19:46:55] <aharoni>	 Hallo.
[19:47:56] <aharoni>	 There's a weirdish MediaWiki feature: Putting a space in the beginning of a paragraph makes that paragraph into a <pre>.
[19:48:05] <RoanKattouw>	 Yes
[19:48:05] <aharoni>	 Does the VE handle that in any way?
[19:48:05] <James_F>	 aharoni: Yes.
[19:48:15] <James_F>	 aharoni: We handle it perfectly.
[19:48:21] <RoanKattouw>	 If people put a space at the beginning of a paragraph, you'll end up with <nowiki> </nowiki>text
[19:48:25] <James_F>	 aharoni: By <nowiki>ing paragraphs that… yeah.
[19:48:27] <RoanKattouw>	 Which is "perfect" handling
[19:48:37] <RoanKattouw>	 Although really what I think we should do is ignore the fact that the user put that space there
[19:48:45] <RoanKattouw>	 but that's comparatively hard to do
[19:49:09] <aharoni>	 What if the article had that space and the user wants to remove it?
[19:49:24] <RoanKattouw>	 A nowiki-ed space?
[19:49:48] <aharoni>	 No, just a space that was inserted there in source editing.
[19:50:12] <RoanKattouw>	 Then it's a <pre>
[19:50:14] <RoanKattouw>	 right?
[19:50:19] <aharoni>	 Yes.
[19:50:27] <RoanKattouw>	 So then it'll appear as a <pre> in VE
[19:50:42] <aharoni>	 It does. What if I want it to become whatever it would be without the space?
[19:50:43] <RoanKattouw>	 and you can use the toolbar to change it to a paragraph if you like
[19:50:58] <aharoni>	 Oh. Let's see.
[19:51:27] <aharoni>	 OK, makes sense.
[19:52:05] <aharoni>	 There's a (probably rarer) case where it begins with " *", and then the DWIMmy thing would be to turn it into a list item.
[19:54:02] <Krenair>	 RoanKattouw, also, not every DST system moves 1 hour. Lord Howe Island, Australia, moves half an hour.
[19:54:10] <RoanKattouw>	 Krenair:  .......
[19:56:25] <James_F>	 Also there's the 45 minute one in Pennsylvania.
[19:56:52] <RoanKattouw>	 aharoni: That only makes sense if you speak wikitext though
[19:57:42] <wikibugs>	 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression] Link icon is missing in from the toolbar - 10https://bugzilla.wikimedia.org/71903 (10Rummana Yasmeen) 5RESO/?>3VERI
[19:59:47] <aharoni>	 RoanKattouw: yeah... such errors are probably better fixed using something like the https://en.wikipedia.org/wiki/Wikipedia:WikiProject_Check_Wikipedia tools.
[20:00:55] <aharoni>	 This questions comes from the Hebrew VE feedback page, and here's another one:
[20:01:15] <aharoni>	 Is there a plan to make windows such as the Save dialog draggable?
[20:01:38] * RoanKattouw has to go to lunch now, will be back
[20:01:45] <RoanKattouw>	 aharoni: That's a question for TrevorParscal and/or James_F 
[20:02:06] <James_F>	 aharoni: Yes.
[20:02:13] <TrevorParscal>	 James_F: really?
[20:02:15] <TrevorParscal>	 draggable?
[20:02:17] <TrevorParscal>	 why?
[20:02:23] <TrevorParscal>	 seems like a bad idea
[20:02:25] <James_F>	 TrevorParscal: … we've had this argument.
[20:02:37] <James_F>	 aharoni: Apparently there's a plan but the developer who agreed now doesn't. :-)
[20:03:05] <TrevorParscal>	 even if they are draggable, you still have to look at the content underneeth through a semi-opaque white mask, and can't scroll
[20:03:12] <James_F>	 TrevorParscal: Often the window is modal in action but not in information.
[20:03:13] <TrevorParscal>	 this seems like a bad UI to try and support
[20:03:16] <TrevorParscal>	 modal is modal
[20:03:33] <MatmaRex>	 there's a bug filed at least
[20:03:41] <MatmaRex>	 it's also assigned to me, i believe
[20:03:46] <TrevorParscal>	 if we need them to be able to continue referencing the information underneeth, we need to make the process non-modal
[20:03:48] <TrevorParscal>	 simple
[20:03:53] <MatmaRex>	 https://bugzilla.wikimedia.org/show_bug.cgi?id=49969
[20:03:59] <TrevorParscal>	 and I support making the process non-modal
[20:04:13] <TrevorParscal>	 not making the process less-but-still-mostly-modal
[20:05:15] <MatmaRex>	 save dialog could use being non-modal
[20:05:50] <MatmaRex>	 (and being less modal in general, i also find it silly that edit summary field and diff are shown on different panes)
[20:06:12] <MatmaRex>	 i tend to refer back to the things i wrote when summarizing them, you know ;)
[20:11:53] <wikibugs>	 3OOjs UI: OOjs UI: Dialogs should be repositionable/draggable - 10https://bugzilla.wikimedia.org/49969#c22 (10Trevor Parscal) I would like to avoid adding moving and resizing to dialogs, because I believe it solving the problem in the wrong way. At it's root, this is a workflow problem. Making the dialog resiz...
[20:13:54] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: Inherited categories not showing up in category dialog on a category page (should show up clearly differentiated) - 10https://bugzilla.wikimedia.org/61921#c4 (10James Forrester) 5RESO/INV>3REOP s:5normal>3enhanc (In reply to Elitre from comment #3...
[20:14:07] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: Inherited categories not showing up in category dialog on a category page (should show up clearly differentiated) - 10https://bugzilla.wikimedia.org/61921 (10James Forrester) 5REOP>3ASSI
[20:16:38] <grrrit-wm1>	 (03CR) 10Jforrester: [C: 032] Followup fbc7ecb: make mediawiki.mobile depend on core.mobile, not core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167850 (https://bugzilla.wikimedia.org/72282) (owner: 10Catrope)
[20:17:09] <wikibugs>	 3VisualEditor / 3Mobile: VisualEditor: [Regression pre-wmf5] Cannot open Mobile VE in Betalabs , in the console "TypeError: Cannot set property 'MWMobileContext' of undefined" appears - 10https://bugzilla.wikimedia.org/72282 (10James Forrester) 5PATC>3RESO/FIX
[20:20:32] <grrrit-wm1>	 (03Merged) 10jenkins-bot: Followup fbc7ecb: make mediawiki.mobile depend on core.mobile, not core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167850 (https://bugzilla.wikimedia.org/72282) (owner: 10Catrope)
[20:24:38] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf5] Context menu label, first changes to read “Comment” before undoing any comment - 10https://bugzilla.wikimedia.org/72315 (10James Forrester) 5NEW>3ASSI
[20:28:04] <grrrit-wm1>	 (03CR) 10Jforrester: [C: 032] "I38fa56aa is merged and pulled." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167456 (owner: 10Bartosz Dziewoński)
[20:28:22] <grrrit-wm1>	 (03CR) 10Jforrester: [C: 032] "I38fa56aa is merged and pulled." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167455 (owner: 10Bartosz Dziewoński)
[20:28:53] <wikibugs>	 3OOjs UI: OOjs UI: Toolbar menus should let you show keyboard shortcuts in a right gutter - 10https://bugzilla.wikimedia.org/71855 (10James Forrester) 5PATC>3RESO/FIX
[20:30:01] <grrrit-wm1>	 (03Merged) 10jenkins-bot: ve.ui.MWFormatTool: Update heading size CSS for new OOUI version [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167455 (owner: 10Bartosz Dziewoński)
[20:30:10] <grrrit-wm1>	 (03Merged) 10jenkins-bot: ve.ui.FormatTool: Update heading size CSS for new OOUI version [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167456 (owner: 10Bartosz Dziewoński)
[20:56:40] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor:[Regression Pre-wmf15] Template Suggestions are not appearing while searching for it inside "Add Template" dialog - 10https://bugzilla.wikimedia.org/72332 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 16833   --> https://bugzilla....
[20:56:53] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor:[Regression Pre-wmf15] Template Suggestions are not appearing while searching for it inside "Add Template" dialog - 10https://bugzilla.wikimedia.org/72332 (10Rummana Yasmeen)
[21:03:08] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: [Regression] Can't cut or (sometimes) paste in Firefox - 10https://bugzilla.wikimedia.org/72164#c4 (10etonkovidova) Confirmed the fix(es) on Betalabs.
[21:04:27] <grrrit-wm1>	 (03PS1) 10Cmcmahon: [BrowserTest] WIP add Then steps to Cite Basic test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167946 
[21:06:37] <wikibugs>	 3VisualEditor / 3Data Model: VisualEditor: [Regression] References created in media item captions no longer appear in reference lists - 10https://bugzilla.wikimedia.org/57228#c1 (10Alex Monk) 5ASSI>3RESO/FIX Looks like this got fixed at some point because it works for me.
[21:07:05] <grrrit-wm1>	 (03CR) 10Siebrand: "i18n/L10n reviewed." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/102076 (https://bugzilla.wikimedia.org/57727) (owner: 10TTO)
[21:11:45] <grrrit-wm1>	 (03PS55) 10Paladox: WikiEditor: Convert .css to .less and also fixes SVG issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) 
[21:18:11] <mooeypoo>	 damnit, Chrome is being extremely annoying
[21:19:29] <RoanKattouw>	 Without having context, I agree with that statement
[21:19:48] <mooeypoo>	 RoanKattouw, my console debugging is completely off.
[21:20:09] <mooeypoo>	 I am putting breakpoints and they move down to illogical places like }; or return {} and such
[21:20:14] <RoanKattouw>	 Oh, yeah
[21:20:19] <RoanKattouw>	 That happens sometimes
[21:20:21] <mooeypoo>	 when I reload, which makes debugging almost impossible
[21:20:24] <RoanKattouw>	 You should see what happens to David
[21:20:38] <mooeypoo>	 it happens all the time... I've restarted, updated Chrome, nothing works.
[21:20:48] <RoanKattouw>	 He relatively frequently gets into situations where the call stack stops making sense halfway down and it turns into something else's call stack
[21:20:56] <mooeypoo>	 I am using "debugger;" statements and console.log() but it's really really annoying to work like that :(
[21:21:05] <mooeypoo>	 ha
[21:22:18] <RoanKattouw>	 My understanding is that Chrome normalizes the position of breakpoints
[21:22:38] <RoanKattouw>	 But sometimes it has an outdated model of the source code
[21:22:44] <RoanKattouw>	 and you get weird behavior like that
[21:22:47] <RoanKattouw>	 At least that's my guess
[21:22:57] <mooeypoo>	 How do I fix it? :\
[21:23:29] <MatmaRex>	 i also found that happen with source maps
[21:23:48] <MatmaRex>	 i'd click to place a breakpoint, and it's be placed in the file the map points to (or something) that i didn't even have open
[21:23:55] <RoanKattouw>	 haha
[21:23:58] <RoanKattouw>	 Good job, Chrome
[21:24:13] <RoanKattouw>	 mooeypoo: I am not aware of a workaround :(
[21:24:19] * mooeypoo meh's
[21:24:20] <MatmaRex>	 mooeypoo: ctrl+f5, i guess
[21:24:27] <MatmaRex>	 or ctlr+r, or whatever
[21:25:04] <mooeypoo>	 refreshing doesn't help.
[21:26:24] <mooeypoo>	 where do I allow/disallow emulation in chrome again?
[21:26:30] <mooeypoo>	 I think this started when i enabled it
[21:26:40] <RoanKattouw>	 Gear icon in the top right of the inspector
[21:26:47] <MatmaRex>	 off-and-on-again? :D
[21:27:08] <mooeypoo>	 RoanKattouw, yeah, I can't find the setting to cancel
[21:27:22] <grrrit-wm1>	 (03PS38) 10Catrope: Data model implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159310 (owner: 10Oliverb)
[21:27:29] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: [Regression wmf16] Opening link inspector/comment box in an empty line, opens them at the end of the previous line - 10https://bugzilla.wikimedia.org/69122#c16 (10Alex Monk) Can't reproduce...
[21:27:49] <Krenair>	 wikibugs slow today?
[21:28:10] <grrrit-wm1>	 (03CR) 10Catrope: [C: 031] "Looks good now, holding this back for now though because I want to merge the whole stack at once." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159310 (owner: 10Oliverb)
[21:30:48] <grrrit-wm1>	 (03PS5) 10SuchetaG: Make spinner appear immediately when clicking edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167736 (https://bugzilla.wikimedia.org/65453) 
[21:31:17] * mooeypoo shakes fist at scalable
[21:31:22] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf5] Template Suggestions are not appearing while searching for it inside "Add Template" dialog - 10https://bugzilla.wikimedia.org/72332#c1 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High Presuming this is pre-wmf5 not pre-wmf15. :-)
[21:31:23] <mooeypoo>	 okay, the plot thickens. <sighs>
[21:32:02] <mooeypoo>	 I'm going to have to do something a lot more complicated for the hasBeenChanged() method than "just" compare the two hashes.
[21:32:32] <grrrit-wm1>	 (03CR) 10jenkins-bot: [V: 04-1] Make spinner appear immediately when clicking edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167736 (https://bugzilla.wikimedia.org/65453) (owner: 10SuchetaG)
[21:32:40] <mooeypoo>	 RoanKattouw, you have a second to help me with sanity check for my brain?
[21:32:53] <RoanKattouw>	 mooeypoo: Not right this second
[21:32:59] * mooeypoo nods
[21:35:51] <grrrit-wm1>	 (03CR) 10Catrope: Make spinner appear immediately when clicking edit (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167736 (https://bugzilla.wikimedia.org/65453) (owner: 10SuchetaG)
[21:37:08] <wikibugs>	 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression pre-wmf15] Pressing backspace to delete  the link target inside link inspector closes the inspector - 10https://bugzilla.wikimedia.org/68195 (10James Forrester) p:5High>3Low
[21:37:22] <wikibugs>	 3VisualEditor / 3Mobile: VisualEditor Mobile: Getting stuck inside Link inspector while trying to clear the link text when there was no match for it in the inspector - 10https://bugzilla.wikimedia.org/66696 (10James Forrester) p:5High>3Low
[21:37:26] <wikibugs>	 3VisualEditor / 3Mobile: VisualEditor Mobile: Text should remain selected after leaving link dialogue in iOS Safari - 10https://bugzilla.wikimedia.org/64580 (10James Forrester) p:5High>3Low
[21:37:26] <wikibugs>	 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression wmf16] Cannot scroll the link suggestions inside link inspector - 10https://bugzilla.wikimedia.org/69038 (10James Forrester) p:5High>3Low
[21:37:26] <wikibugs>	 3VisualEditor / 3Data Model: VisualEditor: Make transaction processing exception-safe - 10https://bugzilla.wikimedia.org/68892 (10James Forrester) p:5High>3Normal s:5major>3enhanc
[21:37:27] <wikibugs>	 3VisualEditor / 3Mobile: VisualEditor Mobile: Toolbar does not float while tapping towards the end of the screen - 10https://bugzilla.wikimedia.org/68832 (10James Forrester) p:5High>3Low
[21:37:37] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor:[Regression pre-wmf5] The "Show Options" inside Transclusion dialog box is not bringing up the other options to add parameter/template/content - 10https://bugzilla.wikimedia.org/72278 (10James Forrester) 5NEW>3ASSI
[21:38:07] <grrrit-wm1>	 (03PS6) 10SuchetaG: Make spinner appear immediately when clicking edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167736 (https://bugzilla.wikimedia.org/65453) 
[21:38:37] <wikibugs>	 3VisualEditor / 3Initialisation: VisualEditor: From a cold start using debug=true, there's no indication VE is loading for a few seconds; move some init stuff further up? - 10https://bugzilla.wikimedia.org/65453 (10James Forrester)
[21:39:30] <grrrit-wm1>	 (03PS2) 10Ryasmeen: [BrowserTest] WIP add Then steps to Cite Basic test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167946 (owner: 10Cmcmahon)
[21:43:06] <edsanders>	 James_F, TrevorParscal I'm here btw
[21:43:13] <TrevorParscal>	 edsanders: howdy
[21:43:15] <James_F>	 edsanders: Cool. :-)
[21:43:28] <James_F>	 edsanders: I won't be, but TrevorParscal/RoanKattouw/kaity will be.
[21:44:23] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: [Regression wmf4] Selecting and replacing a link by typing clears all annotations from DM, but CE thinks it's still a link for the first character - 10https://bugzilla.wikimedia.org/72108 (10James Forrester)
[21:44:52] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf5] The "Show Options" inside Transclusion dialog box is blank, not bringing up the other options to add parameter/template/content - 10https://bugzilla.wikimedia.org/72278 (10James Forrester)
[21:46:11] <James_F>	 edsanders: BTW, there's a few nasty bugs if you want to run away from table editing for a bit. :-) https://bugzilla.wikimedia.org/show_bug.cgi?id=72332 https://bugzilla.wikimedia.org/show_bug.cgi?id=72278 https://bugzilla.wikimedia.org/show_bug.cgi?id=72259 https://bugzilla.wikimedia.org/show_bug.cgi?id=72258
[21:46:24] <wikibugs>	 3VisualEditor / 3Data Model: VisualEditor: [Regression wmf4] "Uncaught TypeError: Cannot read property 'resolve' of null" when applying language annotation to an image, the inspector remains open - 10https://bugzilla.wikimedia.org/72259 (10James Forrester)
[21:46:25] <wikibugs>	 3VisualEditor / 3Data Model: VisualEditor: [Regression wmf4] Applying link to an image gives "Uncaught TypeError: Cannot read property 'from' of null ",  inspector stays open - 10https://bugzilla.wikimedia.org/72258 (10James Forrester)
[21:50:51] <grrrit-wm1>	 (03PS7) 10SuchetaG: Make spinner appear immediately when clicking edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167736 (https://bugzilla.wikimedia.org/65453) 
[21:52:19] <grrrit-wm1>	 (03CR) 10Catrope: [C: 032] Make spinner appear immediately when clicking edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167736 (https://bugzilla.wikimedia.org/65453) (owner: 10SuchetaG)
[21:53:56] <grrrit-wm1>	 (03Merged) 10jenkins-bot: Make spinner appear immediately when clicking edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167736 (https://bugzilla.wikimedia.org/65453) (owner: 10SuchetaG)
[21:54:40] <wikibugs>	 3VisualEditor / 3Initialisation: VisualEditor: From a cold start using debug=true, there's no indication VE is loading for a few seconds; move some init stuff further up? - 10https://bugzilla.wikimedia.org/65453 (10James Forrester) 5PATC>3RESO/FIX
[21:55:22] <grrrit-wm1>	 (03PS3) 10Ryasmeen: [BrowserTest] WIP add Then steps to Cite Basic test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167946 (owner: 10Cmcmahon)
[21:57:11] <grrrit-wm1>	 (03CR) 10Catrope: [C: 04-1] [BrowserTest] WIP add Then steps to Cite Basic test (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167946 (owner: 10Cmcmahon)
[21:57:16] <grrrit-wm1>	 (03PS4) 10Ryasmeen: [BrowserTest] WIP add Then steps to Cite Basic test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167946 (owner: 10Cmcmahon)
[21:58:51] <grrrit-wm1>	 (03PS5) 10Ryasmeen: [BrowserTest] WIP add Then steps to Cite Basic test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167946 (owner: 10Cmcmahon)
[21:59:38] <grrrit-wm1>	 (03CR) 10Cmcmahon: [C: 032] "Paired with Rummana in San Francisco" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167946 (owner: 10Cmcmahon)
[22:01:02] <grrrit-wm1>	 (03CR) 10Jforrester: [C: 04-1] "It's marked WIP still…" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167946 (owner: 10Cmcmahon)
[22:10:09] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf5] The "Show Options" inside Transclusion dialog box is blank, not bringing up the other options to add parameter/template/content - 10https://bugzilla.wikimedia.org/72278 (10Alex Monk) a:3Alex Monk
[22:11:07] <grrrit-wm1>	 (03PS1) 10Mooeypoo: Add 'valid' event to MediaSizeWidget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167964 
[22:12:16] <grrrit-wm1>	 (03CR) 10jenkins-bot: [V: 04-1] Add 'valid' event to MediaSizeWidget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167964 (owner: 10Mooeypoo)
[22:14:46] <grrrit-wm1>	 (03PS2) 10Mooeypoo: Add 'valid' event to MediaSizeWidget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167964 
[22:20:12] <grrrit-wm1>	 (03PS1) 10Mooeypoo: Update initialHash after getting defaultDimensions in image model [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167966 
[22:20:27] <grrrit-wm1>	 (03CR) 10jenkins-bot: [V: 04-1] Update initialHash after getting defaultDimensions in image model [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167966 (owner: 10Mooeypoo)
[22:21:04] <grrrit-wm1>	 (03PS3) 10Mooeypoo: Add 'valid' event to MediaSizeWidget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167964 (https://bugzilla.wikimedia.org/72155) 
[22:21:24] <mooeypoo>	 eh meh, lib/ve
[22:23:26] <mooeypoo>	 James_F, the 'valid' event one fixes that bug but those two together fix another annoying bug i discovered
[22:23:35] <mooeypoo>	 by accident, since my wiki, apparently, has really annoying settings
[22:32:29] <grrrit-wm1>	 (03PS6) 10Cmcmahon: [BrowserTest] add Then steps to Cite Basic test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167946 
[22:34:22] <grrrit-wm1>	 (03CR) 10Alex Monk: OOUI PHP: Layouts: Field, Fieldset, Form, Panel, Grid (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/166191 (owner: 10Bartosz Dziewoński)
[22:34:53] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf5] The "Show Options" inside Transclusion dialog box is blank, not bringing up the other options to add parameter/template/content - 10https://bugzilla.wikimedia.org/72278#c1 (10Alex Monk) Caused by Gerrit change 166191
[22:35:30] <MatmaRex>	 ow :(
[22:37:00] <grrrit-wm1>	 (03PS1) 10Alex Monk: GridLayout: Set dimensions.visibility = '' again if we have a height and a width [oojs/ui] - 10https://gerrit.wikimedia.org/r/167973 (https://bugzilla.wikimedia.org/72278) 
[22:43:53] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor:[Regression pre-wmf5] Scroll bar is appearing while opening a link inspector - 10https://bugzilla.wikimedia.org/72338 (10Rummana Yasmeen)
[22:43:55] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor:[Regression pre-wmf5] Scroll bar is appearing while opening a link inspector - 10https://bugzilla.wikimedia.org/72338 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 16835   --> https://bugzilla.wikimedia.org/attachment.cgi?id=16835...
[22:44:56] <Krenair>	 there's definitely something up with wikibugs. those last two lines appear in the wrong order
[22:46:08] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: [Regression wmf16] Opening link inspector/comment box in an empty line, opens them at the end of the previous line - 10https://bugzilla.wikimedia.org/69122#c17 (10Rummana Yasmeen) 5ASSI>3RESO/FIX Got fixed with Ed's selection re-write I believe? I have not...
[22:56:21] <grrrit-wm1>	 (03PS1) 10Catrope: Update VE core submodule to master (1835848) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167976 
[22:56:43] <RoanKattouw>	 James_F: ---^^
[22:56:58] <grrrit-wm1>	 (03CR) 10Jforrester: [C: 032] Update VE core submodule to master (1835848) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167976 (owner: 10Catrope)
[22:58:50] <grrrit-wm1>	 (03Merged) 10jenkins-bot: Update VE core submodule to master (1835848) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167976 (owner: 10Catrope)
[22:59:45] <James_F>	 RoanKattouw: Anything needed for SWAT?
[22:59:53] <RoanKattouw>	 Not that I know of
[23:00:03] <James_F>	 Good. :-)
[23:00:05] <RoanKattouw>	 That pull-through was so that the keyboard shortcuts thing would stop looking horrible in beta labs
[23:00:08] * James_F nods.
[23:00:17] <James_F>	 RoanKattouw: Did the table design meeting happen?
[23:00:22] <RoanKattouw>	 Yes
[23:00:57] <RoanKattouw>	 Ed found a bug related to the slug that appears when you have a nested table
[23:01:17] <RoanKattouw>	 We discussed doing highlight or other differentiation in the table context menu
[23:02:07] <RoanKattouw>	 There was some broader discussion about the (normal) context menu, depressed states of tools, and the check mark in the format dropdown (Trevor's opinion: depressed states should be replaced with check marks, check marks in the format dropdown should be replaced with dots)
[23:02:22] <wikibugs>	 3VisualEditor / 3Mobile: VisualEditor: [Regression pre-wmf5] Cannot open Mobile VE in Betalabs , in the console "TypeError: Cannot set property 'MWMobileContext' of undefined" appears - 10https://bugzilla.wikimedia.org/72282#c5 (10Rummana Yasmeen) Verified the fix in Betalabs
[23:02:31] <RoanKattouw>	 Ed showed off the merge cells thing, which also does double-duty as a split cells tool: when selecting a merged cell, it's depressed, and clicking it splits the cell
[23:02:44] <James_F>	 RoanKattouw: Dots? Eww.
[23:02:52] <James_F>	 RoanKattouw: Yeah.
[23:03:18] <RoanKattouw>	 Yeah I'm not sure about the dots thing either. But I pointed out to Trevor that you can't use check marks for multivalue stuff given that we're already using it for mutually exclusive things
[23:03:47] <RoanKattouw>	 (Not just in the format dropdown now I think of it; also for vanilla OOUI SelectWidgets, which are used virtually nowhere because they don't look very good)
[23:04:10] <RoanKattouw>	 Anyway, Kaity showed designs that involve a blue bar along the selection rather than just an arrow centered at the selection
[23:04:39] <RoanKattouw>	 There were issues with both Ed's approach and Kaity's design to do with the center of the selection being either in the middle of a cell or at a cell boundary depending on whether you selected an odd or even number
[23:05:23] <RoanKattouw>	 Oh and we decided that the "make these cells header cells" tool should be killed and that instead you should be able to use the format dropdown (currently disabled when selecting table stuff) to switch between td and th
[23:06:26] <RoanKattouw>	 Also exploring whether to keep the table-specific tools dropdown in the toolbar (currently contains merge cells, delete table, and header, latter will be moved) or inline the 2 tools remaining in it
[23:07:14] <grrrit-wm1>	 (03CR) 10Catrope: "You probably didn't mean to put a lib/ve change in here?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167966 (owner: 10Mooeypoo)
[23:15:33] <grrrit-wm1>	 (03CR) 10Trevor Parscal: [C: 032] GridLayout: Set dimensions.visibility = '' again if we have a height and a width [oojs/ui] - 10https://gerrit.wikimedia.org/r/167973 (https://bugzilla.wikimedia.org/72278) (owner: 10Alex Monk)
[23:15:58] <grrrit-wm1>	 (03CR) 10Trevor Parscal: [C: 032] PopupWidget: Remove references to 'show' and 'hide' events [oojs/ui] - 10https://gerrit.wikimedia.org/r/167877 (https://bugzilla.wikimedia.org/72168) (owner: 10Alex Monk)
[23:16:19] <RoanKattouw>	 TrevorParscal: Are you interested in doing a bit more code review?
[23:16:41] <TrevorParscal>	 i'm currently busy reviewing ooui stuff
[23:16:42] <TrevorParscal>	 why?
[23:16:47] <RoanKattouw>	 Oh OK
[23:16:57] <grrrit-wm1>	 (03CR) 10Trevor Parscal: [C: 032] Fix anchor positioning on popups [oojs/ui] - 10https://gerrit.wikimedia.org/r/167543 (owner: 10Esanders)
[23:16:59] <RoanKattouw>	 Yes please review outstanding things in OOUI, that's what I was going to ask you to do
[23:17:05] <RoanKattouw>	 Actually for that specific one, well done
[23:17:30] <grrrit-wm1>	 (03CR) 10Trevor Parscal: [C: 032] Make padding between popup and container configurable [oojs/ui] - 10https://gerrit.wikimedia.org/r/167541 (owner: 10Esanders)
[23:17:32] <grrrit-wm1>	 (03Merged) 10jenkins-bot: GridLayout: Set dimensions.visibility = '' again if we have a height and a width [oojs/ui] - 10https://gerrit.wikimedia.org/r/167973 (https://bugzilla.wikimedia.org/72278) (owner: 10Alex Monk)
[23:18:11] <grrrit-wm1>	 (03CR) 10Trevor Parscal: [C: 032] build: Introduce 'quick-build' task [oojs/ui] - 10https://gerrit.wikimedia.org/r/167449 (owner: 10Bartosz Dziewoński)
[23:18:22] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf5] The "Show Options" inside Transclusion dialog box is blank, not bringing up the other options to add parameter/template/content - 10https://bugzilla.wikimedia.org/72278 (10Alex Monk) 5PATC>3RESO/FIX
[23:19:13] <grrrit-wm1>	 (03CR) 10Trevor Parscal: [C: 032] OOUI PHP: Unbreak ButtonWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/167348 (owner: 10Bartosz Dziewoński)
[23:19:23] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf5] The "Show Options" inside Transclusion dialog box is blank, not bringing up the other options to add parameter/template/content - 10https://bugzilla.wikimedia.org/72278 (10Alex Monk)
[23:20:22] <grrrit-wm1>	 (03Merged) 10jenkins-bot: PopupWidget: Remove references to 'show' and 'hide' events [oojs/ui] - 10https://gerrit.wikimedia.org/r/167877 (https://bugzilla.wikimedia.org/72168) (owner: 10Alex Monk)
[23:20:31] <grrrit-wm1>	 (03Merged) 10jenkins-bot: Fix anchor positioning on popups [oojs/ui] - 10https://gerrit.wikimedia.org/r/167543 (owner: 10Esanders)
[23:20:33] <grrrit-wm1>	 (03Merged) 10jenkins-bot: Make padding between popup and container configurable [oojs/ui] - 10https://gerrit.wikimedia.org/r/167541 (owner: 10Esanders)
[23:22:13] <grrrit-wm1>	 (03CR) 10Trevor Parscal: [C: 032] TextInputWidget: Allow changing 'type' attribute (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/167311 (owner: 10Bartosz Dziewoński)
[23:23:09] <grrrit-wm1>	 (03Merged) 10jenkins-bot: build: Introduce 'quick-build' task [oojs/ui] - 10https://gerrit.wikimedia.org/r/167449 (owner: 10Bartosz Dziewoński)
[23:23:11] <grrrit-wm1>	 (03Merged) 10jenkins-bot: OOUI PHP: Unbreak ButtonWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/167348 (owner: 10Bartosz Dziewoński)
[23:23:40] <grrrit-wm1>	 (03CR) 10Trevor Parscal: [C: 032] FormLayout: Accept HTML form attributes as config options [oojs/ui] - 10https://gerrit.wikimedia.org/r/167307 (owner: 10Bartosz Dziewoński)
[23:24:03] <grrrit-wm1>	 (03Merged) 10jenkins-bot: TextInputWidget: Allow changing 'type' attribute [oojs/ui] - 10https://gerrit.wikimedia.org/r/167311 (owner: 10Bartosz Dziewoński)
[23:25:57] <grrrit-wm1>	 (03Merged) 10jenkins-bot: FormLayout: Accept HTML form attributes as config options [oojs/ui] - 10https://gerrit.wikimedia.org/r/167307 (owner: 10Bartosz Dziewoński)
[23:45:15] <mooeypoo>	 RoanKattouw, I don't mean to put lib/ve in there,but my attempts to get it out meet resistance.
[23:45:46] <RoanKattouw>	 mooeypoo: git reset HEAD^ lib/ve ; git commit --amend
[23:45:55] <mooeypoo>	 oh HEAD^ is what I was missing
[23:46:06] <mooeypoo>	 ... damnit. I need to print myself a quick cheat sheet
[23:46:12] <mooeypoo>	 tape it to my glasses.
[23:47:07] <mooeypoo>	 ... yes, me, I'm just a genius. git reset etc, and then git commit --amend --all. Like a champ. 
[23:47:12] * mooeypoo curses muscle memory typing
[23:47:33] <grrrit-wm1>	 (03PS2) 10Mooeypoo: Update initialHash after getting defaultDimensions in image model [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167966 
[23:50:37] <James_F>	 mooeypoo: Did you want to add the bug number to that, or should I?
[23:50:38] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf5] Scroll bar is appearing while opening a link inspector - 10https://bugzilla.wikimedia.org/72338 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal a:3Roan Kattouw
[23:51:04] <James_F>	 mooeypoo: It's bug 71065, right?
[23:54:23] <grrrit-wm1>	 (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (531d497d3b) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167988 
[23:55:54] <mooeypoo>	 James_F, I put the bug in
[23:55:58] <mooeypoo>	 it's the other one
[23:56:08] <mooeypoo>	 James_F, https://gerrit.wikimedia.org/r/#/c/167964/
[23:56:20] <grrrit-wm1>	 (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (531d497d3b) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167988 (owner: 10Jforrester)
[23:56:22] <mooeypoo>	 well, I guess it's both of those fixes
[23:56:38] <mooeypoo>	 but the other fix is mostly about something else
[23:58:26] <grrrit-wm1>	 (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (531d497d3b) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167988 (owner: 10Jforrester)