[00:00:25] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf5] Scroll bar is appearing while opening a link inspector - 10https://bugzilla.wikimedia.org/72338#c1 (10Roan Kattouw) Proximate cause is https://gerrit.wikimedia.org/r/#/c/167446/ , it was working before that change. What seems to be going on... [00:00:55] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf5] Scroll bar is appearing while opening a link inspector - 10https://bugzilla.wikimedia.org/72338 (10Roan Kattouw) a:5Roan Kattouw>3Ed Sanders [00:01:04] (03PS2) 10Jforrester: Apex, MediaWiki themes: Move colour definitions into LESS variables [oojs/ui] - 10https://gerrit.wikimedia.org/r/164389 [00:01:12] (03CR) 10Jforrester: "PS2 is a rebase." [oojs/ui] - 10https://gerrit.wikimedia.org/r/164389 (owner: 10Jforrester) [00:01:34] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/167964/ [00:01:58] mooeypoo: Ah, yeah, sorry. [00:02:18] (03CR) 10Catrope: [C: 032] Add 'valid' event to MediaSizeWidget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167964 (https://bugzilla.wikimedia.org/72155) (owner: 10Mooeypoo) [00:02:34] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/167443/ OK to go? [00:03:27] (03CR) 10Catrope: [C: 04-1] "Unaddressed comment on PS2" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167443 (owner: 10Esanders) [00:04:40] (03Merged) 10jenkins-bot: Add 'valid' event to MediaSizeWidget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167964 (https://bugzilla.wikimedia.org/72155) (owner: 10Mooeypoo) [00:06:22] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression] "Make full size" is not enabling "Apply Changes" button when the image has been set to a custom size - 10https://bugzilla.wikimedia.org/72155 (10James Forrester) 5PATC>3RESO/FIX [00:06:50] (03PS1) 10Jforrester: Update VE core submodule to master (f753058) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167990 [00:06:55] (03CR) 10Catrope: [C: 04-1] "Nothing wrong with the code, but I have a few nags about the formatting of the commit message." (033 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167772 (owner: 10Mvolz) [00:08:28] RoanKattouw: Oh and https://gerrit.wikimedia.org/r/#/c/167876/ [00:36:04] (03PS1) 10Jforrester: MWLinkNodeInspector: Provide an open button here too [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168007 (https://bugzilla.wikimedia.org/71904) [00:36:25] 3VisualEditor / 3Editing Tools: VisualEditor: Add an "open" button for link nodes too - 10https://bugzilla.wikimedia.org/71904 (10James Forrester) a:3James Forrester [01:00:10] (03PS7) 10Jforrester: [BrowserTest] Add "Then…" steps to Cite Basic test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167946 (owner: 10Cmcmahon) [01:00:23] (03CR) 10Jforrester: [C: 032] "Per Chris." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167946 (owner: 10Cmcmahon) [01:02:00] (03Merged) 10jenkins-bot: [BrowserTest] Add "Then…" steps to Cite Basic test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167946 (owner: 10Cmcmahon) [01:02:24] 3VisualEditor / 3ContentEditable: VisualEditor: [Regression wmf4] Selecting and replacing a link by typing clears all annotations from DM, but CE thinks it's still a link for the first character - 10https://bugzilla.wikimedia.org/72108#c2 (10Roan Kattouw) Yes, this is related to unicorning. There are several... [01:07:53] 3VisualEditor / 3ContentEditable: VisualEditor: [Regression wmf4] Link continuation is broken - 10https://bugzilla.wikimedia.org/72108#c3 (10Roan Kattouw) Oh also: the bug as filed (select link, start typing, replacement text is linked in CE but not in DM) also appears to be caused by the unicorn change, pre... [01:10:23] 3VisualEditor / 3ContentEditable: VisualEditor: [Regression wmf4] Link continuation is broken - 10https://bugzilla.wikimedia.org/72108#c4 (10Roan Kattouw) *** Bug 72261 has been marked as a duplicate of this bug. *** [01:10:23] 3VisualEditor / 3ContentEditable: VisualEditor: [Regression wmf4] Annotation continuation is working but the browser styles it wrongly (i.e., not at all) - 10https://bugzilla.wikimedia.org/72261#c2 (10Roan Kattouw) 5ASSI>3RESO/DUP I widened the scope of bug 72108 to include this bug without realizing thi... [01:11:37] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf5] Template Suggestions are not appearing while searching for it inside "Add Template" dialog - 10https://bugzilla.wikimedia.org/72332#c2 (10Roan Kattouw) Yeah searches on beta labs are very slow right now. This is also true for the link inspec... [01:13:54] 3VisualEditor / 3Language: VisualEditor: Pawning prevention code in ve.ce.Surface sometimes prevents some legit keypresses from being handled (e.g. typing “ą” in Polish on a new line) - 10https://bugzilla.wikimedia.org/67367#c5 (10Roan Kattouw) a:3David Chan Hmph, we can't kill this code yet. It's not just... [01:28:07] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf5] Template Suggestions are not appearing while searching for it inside "Add Template" dialog - 10https://bugzilla.wikimedia.org/72332#c3 (10Roan Kattouw) I have confirmed that search suggestions are working in production, but are very slow on... [01:34:18] (03PS1) 10Catrope: Disable the reuse citation tool when selection is null [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168013 [01:34:57] (03CR) 10Jforrester: [C: 032] Disable the reuse citation tool when selection is null [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168013 (owner: 10Catrope) [01:36:07] (03PS1) 10Catrope: Drop nonexistent &redirect= parameter from API requests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168014 [01:36:33] (03Merged) 10jenkins-bot: Disable the reuse citation tool when selection is null [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168013 (owner: 10Catrope) [01:36:55] (03CR) 10Jforrester: [C: 032] Drop nonexistent &redirect= parameter from API requests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168014 (owner: 10Catrope) [01:38:08] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression] Link searching broken in reference and media dialogs - 10https://bugzilla.wikimedia.org/72121#c1 (10Roan Kattouw) The links are autocompleting just fine, it's just that the dropdown is so small that you only see one suggestion, and the rest can be ac... [01:38:33] (03Merged) 10jenkins-bot: Drop nonexistent &redirect= parameter from API requests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168014 (owner: 10Catrope) [01:38:37] 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector inside dialog is clipped against dialog boundary, which makes it too small - 10https://bugzilla.wikimedia.org/72121 (10Roan Kattouw) [01:45:09] 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector inside dialog is clipped against dialog boundary, which makes it too small - 10https://bugzilla.wikimedia.org/72121#c2 (10Roan Kattouw) I need to pick Trevor's brain about this. Right now the WindowManager for inspectors is in the localOverlay, whi... [01:45:26] 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector inside dialog is clipped against dialog boundary, which makes it too small - 10https://bugzilla.wikimedia.org/72121 (10Roan Kattouw) a:5Alex Monk>3Trevor Parscal [01:55:55] (03PS1) 10Catrope: Prevent JS error in getNativeRange() [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168021 (https://bugzilla.wikimedia.org/72259) [01:56:30] (03PS2) 10Jforrester: Prevent JS error in getNativeRange() [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168021 (https://bugzilla.wikimedia.org/72258) (owner: 10Catrope) [01:57:10] (03CR) 10Jforrester: [C: 032] Prevent JS error in getNativeRange() [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168021 (https://bugzilla.wikimedia.org/72258) (owner: 10Catrope) [01:57:54] 3VisualEditor / 3Data Model: VisualEditor: [Regression wmf4] "Uncaught TypeError: Cannot read property 'resolve' of null" when applying language annotation to an image, the inspector remains open - 10https://bugzilla.wikimedia.org/72259 (10James Forrester) 5PATC>3RESO/FIX a:3Roan Kattouw [01:57:55] 3VisualEditor / 3Data Model: VisualEditor: [Regression wmf4] Applying link to an image gives "Uncaught TypeError: Cannot read property 'from' of null ", inspector stays open - 10https://bugzilla.wikimedia.org/72258 (10James Forrester) 5PATC>3RESO/FIX a:3Roan Kattouw [01:58:08] 3VisualEditor / 3Data Model: VisualEditor: [Regression wmf4] "Uncaught TypeError: Cannot read property 'resolve' of null" when applying language annotation to an image, the inspector remains open - 10https://bugzilla.wikimedia.org/72259 (10James Forrester) [01:59:18] (03Merged) 10jenkins-bot: Prevent JS error in getNativeRange() [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168021 (https://bugzilla.wikimedia.org/72258) (owner: 10Catrope) [02:00:14] eh [02:00:18] >>> !!undefined [02:00:18] <32NAAN1VL> mooeypoo: (boolean) false [02:00:18] mooeypoo: (boolean) false [02:00:18] <6A4AA4527> mooeypoo: (boolean) false [02:00:34] ... so why are you complaining it's undefined, code? [02:03:16] Also, why are there three ecmabots in here? :-) [02:03:39] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf5] Comment inspector closes and saves empty comment when tool is used - 10https://bugzilla.wikimedia.org/71706#c1 (10Roan Kattouw) a:3Ed Sanders This isn't as bad any more (no JS errors), probably thanks to Ed's change making the comment insp... [02:04:09] >> 'And stay away' [02:04:10] RoanKattouw: (string) 'And stay away' [02:04:14] :-) [02:09:24] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression] Clicking the link tool or Ctrl+K keyboard command on an auto-numbered external link triggers the wrong (annotation) link inspector - 10https://bugzilla.wikimedia.org/72150 (10James Forrester) a:5Alex Monk>3Roan Kattouw [02:16:43] (03CR) 10Catrope: [C: 032] Add button to debug bar to enable input debugging [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167366 (owner: 10Esanders) [02:16:59] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/167990/ [02:18:35] (03Merged) 10jenkins-bot: Add button to debug bar to enable input debugging [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167366 (owner: 10Esanders) [02:19:38] (03PS2) 10Jforrester: Update VE core submodule to master (5fed7c4) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167990 [02:19:50] (03PS2) 10Jforrester: MWLinkNodeInspector: Provide an open button here too [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168007 (https://bugzilla.wikimedia.org/71904) [02:20:04] RoanKattouw: Also https://gerrit.wikimedia.org/r/#/c/168007/ would be a nice trivial fix. :-) [02:21:11] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (5fed7c4) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167990 (owner: 10Jforrester) [02:22:48] (03Merged) 10jenkins-bot: Update VE core submodule to master (5fed7c4) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167990 (owner: 10Jforrester) [02:26:41] (03CR) 10Catrope: [C: 04-1] MWLinkNodeInspector: Provide an open button here too (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168007 (https://bugzilla.wikimedia.org/71904) (owner: 10Jforrester) [02:29:27] (03CR) 10Jforrester: MWLinkNodeInspector: Provide an open button here too (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168007 (https://bugzilla.wikimedia.org/71904) (owner: 10Jforrester) [02:29:29] (03PS3) 10Jforrester: MWLinkNodeInspector: Provide an open button here too [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168007 (https://bugzilla.wikimedia.org/71904) [02:48:13] (03PS1) 10Catrope: Open the linkNode inspector when pressing Ctrl+K on a link node [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168030 (https://bugzilla.wikimedia.org/72150) [03:01:05] (03PS4) 10Catrope: MWLinkNodeInspector: Provide an open button here too [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168007 (https://bugzilla.wikimedia.org/71904) (owner: 10Jforrester) [03:01:52] (03CR) 10Jforrester: [C: 032] "Yay, first ever MW action." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168030 (https://bugzilla.wikimedia.org/72150) (owner: 10Catrope) [03:02:09] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression] Clicking the link tool or Ctrl+K keyboard command on an auto-numbered external link triggers the wrong (annotation) link inspector - 10https://bugzilla.wikimedia.org/72150 (10James Forrester) 5PATC>3RESO/FIX [03:02:12] (03PS1) 10Catrope: Remove crazy space exception from link validity regex [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168033 [03:02:40] (03CR) 10Jforrester: [C: 032] "'Cos I'm the urban spaceman, baby…" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168033 (owner: 10Catrope) [03:02:42] (03CR) 10Catrope: [C: 032] MWLinkNodeInspector: Provide an open button here too [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168007 (https://bugzilla.wikimedia.org/71904) (owner: 10Jforrester) [03:02:44] (03CR) 10jenkins-bot: [V: 04-1] MWLinkNodeInspector: Provide an open button here too [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168007 (https://bugzilla.wikimedia.org/71904) (owner: 10Jforrester) [03:03:33] (03Merged) 10jenkins-bot: Open the linkNode inspector when pressing Ctrl+K on a link node [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168030 (https://bugzilla.wikimedia.org/72150) (owner: 10Catrope) [03:04:16] (03Merged) 10jenkins-bot: MWLinkNodeInspector: Provide an open button here too [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168007 (https://bugzilla.wikimedia.org/71904) (owner: 10Jforrester) [03:04:39] (03Merged) 10jenkins-bot: Remove crazy space exception from link validity regex [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168033 (owner: 10Catrope) [03:08:39] 3VisualEditor / 3Editing Tools: VisualEditor: Add an "open" button for link nodes too - 10https://bugzilla.wikimedia.org/71904 (10James Forrester) 5PATC>3RESO/FIX [03:10:52] 3VisualEditor / 3ContentEditable: VisualEditor: [Regression wmf4] Annotation continuation is working but the browser styles it wrongly (i.e., not at all) - 10https://bugzilla.wikimedia.org/72261 (10James Forrester) [04:36:55] 3MediaWiki / 3Page editing: Double unclosed table tags cause user input to be lost on page preview - 10https://bugzilla.wikimedia.org/72343 (10Mr. Stradivarius) 3NEW p:3Unprio s:3normal a:3None Using two unclosed tags on a page sometimes causes MediaWiki to lose user input on page preview. S... [08:51:23] 3MediaWiki / 3Page editing: Double unclosed table tags cause user input to be lost on page preview - 10https://bugzilla.wikimedia.org/72343#c1 (10Mr. Stradivarius) Also, I was using HHVM when I saw this happen, which might be relevant. And it might be related to bug 72345. [09:06:52] 3MediaWiki / 3Page editing: Double unclosed table tags cause user input to be lost on page preview - 10https://bugzilla.wikimedia.org/72343#c2 (10Mr. Stradivarius) After further testing, I've found that this only occurs when I have HHVM enabled, so I'm adding the HHVM keyword. [09:44:40] 3MediaWiki / 3Page editing: Give a hint there is a save button in action=edit - 10https://bugzilla.wikimedia.org/72350 (10Nemo) 3NEW p:3Unprio s:3enhanc a:3None While observing three librarians editing each their own page, I noticed that they had uncertainties when asked to save their edit. I had to... [09:45:07] 3MediaWiki / 3Page editing: Give a hint there is a save button in action=edit - 10https://bugzilla.wikimedia.org/72350#c1 (10Nemo) Created attachment 16839 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16839&action=edit Save buttons outside of screen [10:16:53] 3MediaWiki / 3Page editing: Double unclosed table tags cause user input to be lost on page preview - 10https://bugzilla.wikimedia.org/72343#c3 (10Kevin Israel (PleaseStand)) Yes, I also tried this without HHVM on and I didn't see the problem. After turning it on (by setting the hhvm=true cookie), I do see it... [11:16:28] (03PS8) 10Esanders: Merge cells tool [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167631 [11:16:30] (03PS8) 10Esanders: Supporting copy paste of single table cells [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167559 [11:16:32] (03PS15) 10Esanders: Support annotation tool on table selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166774 [11:16:34] (03PS45) 10Esanders: Actions and context menus for manipulating tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb) [11:16:36] (03PS1) 10Esanders: Table header/data format tools [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168060 [11:31:17] (03PS9) 10Esanders: Merge cells tool [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167631 [12:07:53] 3MediaWiki / 3Page editing: Unclosed table tags cause user input to be lost on page preview with HHVM - 10https://bugzilla.wikimedia.org/72343 (10Mr. Stradivarius) [12:39:37] 3MediaWiki / 3Page editing: Provide editintro that depends on section name - 10https://bugzilla.wikimedia.org/12551#c2 (10Andre Klapper) This sounds like a lot of overkill, especially somewhere maintaining which string(s)/regular expression for some single section name should match with which editintro. Ene... [12:40:23] 3MediaWiki / 3Page editing: Give a hint there is a save button in action=edit - 10https://bugzilla.wikimedia.org/72350 (10Andre Klapper) p:5Unprio>3Normal [12:51:54] RoanKattouw_away: No, it didn't mean $widget. $widget is a global variable for the browser console (made to look like $0, $1, $_ etc. in Chrome) [12:52:17] RoanKattouw_away: 'widget' is predefined in the html-console for the local widget. Whereas $global is only for the one you opened last, widget works for each of them. [12:52:30] That worked last I tested it, so someone broke it. It didn't have a scope issue afaik. BUt I'll check [14:29:11] (03PS2) 10Esanders: Files and messages for table editing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167189 [14:30:17] (03CR) 10jenkins-bot: [V: 04-1] Files and messages for table editing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167189 (owner: 10Esanders) [14:52:05] (03PS1) 10Esanders: Mute text color of accelerators in tool groups [oojs/ui] - 10https://gerrit.wikimedia.org/r/168078 [14:57:46] (03PS2) 10Esanders: Table header/data format tools [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168060 [14:57:48] (03PS39) 10Esanders: Data model implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159310 (owner: 10Oliverb) [14:57:50] (03PS40) 10Esanders: ContentEditable implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159311 (owner: 10Oliverb) [14:57:52] (03PS10) 10Esanders: Merge cells tool [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167631 [14:57:54] (03PS9) 10Esanders: Supporting copy paste of single table cells [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167559 [14:57:56] (03PS16) 10Esanders: Support annotation tool on table selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166774 [14:57:58] (03PS46) 10Esanders: Actions and context menus for manipulating tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb) [15:29:24] (03PS1) 10Esanders: Work around *another* browser bug in getBoundingClientRect [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168085 [15:34:32] (03PS2) 10Esanders: Work around *another* browser bug in getBoundingClientRect [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168085 [15:55:35] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167631 (owner: 10Esanders) [15:57:43] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb) [15:59:15] (03CR) 10Siebrand: Table header/data format tools (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168060 (owner: 10Esanders) [16:00:24] 3VisualEditor / 3Data Model: VisualEditor: [Regression wmf4] Applying link to an image gives "Uncaught TypeError: Cannot read property 'from' of null ", inspector stays open - 10https://bugzilla.wikimedia.org/72258#c3 (10Ritu Swain) verified the fix in beta. [16:01:38] 3VisualEditor / 3Data Model: VisualEditor: [Regression wmf4] "Uncaught TypeError: Cannot read property 'resolve' of null" when applying language annotation to an image, the inspector remains open - 10https://bugzilla.wikimedia.org/72259#c4 (10Ritu Swain) verified the fix in beta. [16:16:55] (03PS3) 10Esanders: Files and messages for table editing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167189 [16:18:06] (03CR) 10jenkins-bot: [V: 04-1] Files and messages for table editing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167189 (owner: 10Esanders) [16:30:38] Corruption alert: visualeditor-needcheck on nowiki: https://no.wikipedia.org/?diff=13470886 [16:30:38] Corruption alert: visualeditor-needcheck on nowiki: https://no.wikipedia.org/?diff=13471184 [16:30:38] Corruption alert: visualeditor-needcheck on nowiki: https://no.wikipedia.org/?diff=13471310 [16:30:38] Corruption alert: visualeditor-needcheck on nowiki: https://no.wikipedia.org/?diff=13471411 [16:30:38] Corruption alert: visualeditor-needcheck on nowiki: https://no.wikipedia.org/?diff=13471431 [16:30:39] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=108431077 [16:30:39] Corruption alert: visualeditor-needcheck on ukwiki: https://uk.wikipedia.org/?diff=15032192 [16:30:39] (03CR) 10Jforrester: Table header/data format tools (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168060 (owner: 10Esanders) [16:33:12] (03CR) 10Jforrester: [C: 032] Mute text color of accelerators in tool groups [oojs/ui] - 10https://gerrit.wikimedia.org/r/168078 (owner: 10Esanders) [16:34:02] (03PS4) 10Esanders: Remove insertion inspector class [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167443 [16:36:33] (03Merged) 10jenkins-bot: Mute text color of accelerators in tool groups [oojs/ui] - 10https://gerrit.wikimedia.org/r/168078 (owner: 10Esanders) [17:12:45] (03CR) 10Mooeypoo: Update initialHash after getting defaultDimensions in image model (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167966 (owner: 10Mooeypoo) [17:28:33] (03CR) 10Catrope: [C: 04-1] Work around *another* browser bug in getBoundingClientRect (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168085 (owner: 10Esanders) [17:46:23] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf3] In Firefox, Cursor is appearing in Read mode at the end of the document after saving a page and after discarding the current edit in Firefox - 10https://bugzilla.wikimedia.org/71852 (10Rummana Yasmeen) 5REOP>3ASSI [17:52:37] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf5] The "Show Options" inside Transclusion dialog box is blank, not bringing up the other options to add parameter/template/content - 10https://bugzilla.wikimedia.org/72278#c4 (10Rummana Yasmeen) Verified the fix in Betalabs [18:03:21] (03PS3) 10Esanders: Work around *another* browser bug in getBoundingClientRect [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168085 [18:19:52] RoanKattouw: You're so awesome that our Android app wants more than one of you: http://i.imgur.com/K1uM4uS.png [18:34:55] 3VisualEditor / 3Editing Tools: VisualEditor: “Uncaught Error: Unable to parse title” when entering space as a template - 10https://bugzilla.wikimedia.org/71998 (10James Forrester) a:3Sucheta Ghoshal [18:35:54] 3VisualEditor / 3Editing Tools: VisualEditor: Transclusion dialog should truncate spaces from parameter input - 10https://bugzilla.wikimedia.org/50439 (10Roan Kattouw) a:3Sucheta Ghoshal [18:38:24] 3VisualEditor / 3ContentEditable: VisualEditor: [Regression wmf4] Language context menu appears outside the Content Editor - 10https://bugzilla.wikimedia.org/72273#c2 (10James Forrester) 5ASSI>3RESO/FIX a:3Ed Sanders Fixed by Ed. [18:39:09] 3VisualEditor / 3Initialisation: VisualEditor: From a cold start using debug=true, there's no indication VE is loading for a few seconds; move some init stuff further up? - 10https://bugzilla.wikimedia.org/65453 (10James Forrester) a:3Sucheta Ghoshal [18:39:25] 3VisualEditor / 3Data Model: VisualEditor: Undoing a change of group on a reference throws "Uncaught TypeError: Cannot read property 'length' of undefined" - 10https://bugzilla.wikimedia.org/69119 (10James Forrester) a:3Ed Sanders [18:39:25] 3VisualEditor / 3ContentEditable: VisualEditor: New and changed citations display with blank lines before and after the citation in , if using citation templates - 10https://bugzilla.wikimedia.org/72006 (10James Forrester) a:3Ed Sanders [18:39:25] 3VisualEditor / 3ContentEditable: VisualEditor: Safari scrolls one line for every character typed - 10https://bugzilla.wikimedia.org/71561 (10James Forrester) a:3Ed Sanders [18:39:26] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression] Clicking in the document where an inspector was opened doesn't close the inspector - 10https://bugzilla.wikimedia.org/68679 (10James Forrester) a:3Ed Sanders [18:54:40] 3VisualEditor / 3Editing Tools: VisualEditor: Use the local namespace for files, instead of the English default - 10https://bugzilla.wikimedia.org/72370 (10WhatamIdoing) 3NEW p:3Unprio s:3minor a:3None If you add a file in VisualEditor, then it sometimes adds the file using the English namespace or... [19:07:53] 3VisualEditor / 3Editing Tools: VisualEditor: Transclusion dialog should truncate spaces from parameter input - 10https://bugzilla.wikimedia.org/50439#c2 (10Roan Kattouw) 5ASSI>3RESO/FIX This appears to be fixed now. You can't create both "foo" and "foo " any more. [19:09:52] 3MediaWiki / 3Page editing: Unclosed table tags cause user input to be lost on page preview with HHVM - 10https://bugzilla.wikimedia.org/72343#c4 (10Brad Jorsch) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 72345 *** [19:11:12] legoktm: hey, so... when you added require_once '../vendor/autoload.php' to widgets.php [19:11:19] (and I merged it... :( ) [19:11:31] You don't seem to have added vendor/autoload.php [19:11:46] legoktm: so... what should that file look like? [19:21:06] edsanders: you there? [19:21:16] what's this about CSS/GPU emails? [19:26:48] legoktm: ping [19:38:25] 3VisualEditor: templates which display a parameter as a link show as redlinks - 10https://bugzilla.wikimedia.org/72376 (10Spinningspark) 3NEW p:3Unprio s:3normal a:3None Intention: Add templates to articles Steps to Reproduce: 1. Paste the following examples into a page on en.wiki {{US patent|1730425... [19:47:43] that feels like a dupe [19:47:48] was fixed in https://gerrit.wikimedia.org/r/#/c/167249/ [19:48:02] TrevorP|Away: it's some composer nastiness [19:49:11] TrevorP|Away: i *think* you *probably* need to install composer, then run `composer install` in ooui repo root [19:49:38] 3VisualEditor: templates which display a parameter as a link show as redlinks - 10https://bugzilla.wikimedia.org/72376#c1 (10Alex Monk) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 72251 *** [19:49:38] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression wmf3] External links are rendered as red links now - 10https://bugzilla.wikimedia.org/72251#c3 (10Alex Monk) *** Bug 72376 has been marked as a duplicate of this bug. *** [19:51:08] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression wmf3] External links in templates are rendered as red links now - 10https://bugzilla.wikimedia.org/72251 (10Alex Monk) [20:05:42] TrevorParscal: hey [20:05:43] TrevorParscal: you need to use composer to generate the autoload.php [20:05:46] https://getcomposer.org/download/ [20:05:51] yeah, installing now [20:06:02] and then in the oojs-ui root, run "composer install" [20:06:06] seems like this autoload.php should be in the repo, no? [20:07:12] well, it depends on how you want people to use it [20:07:55] so in mediawiki core, we'd add a dependency upon oojs/ui, and then run "composer install", which will generate an autoload.php which contains all the stuff necessary for phpunit, monolog, oojs/ui, etc. [20:09:29] you can think of the vendor directory like node_modules I guess [20:13:54] 3VisualEditor / 3MediaWiki integration: VisualEditor:Editing and saving a page , then pressing back browser button takes to previously saved page. - 10https://bugzilla.wikimedia.org/71917#c1 (10James Forrester) I can't reproduce this; can you confirm it's still an issue? (Test environment: Beta Labs, Chrome... [20:14:12] legoktm: ok, well maybe I will make the error on widget.php not so mysterious [20:14:58] yeah, that would probably be a good idea [20:16:10] 3VisualEditor / 3ContentEditable: VisualEditor: "TypeError: undefined is not a function" when saving after pasting an external link into a basic citation - 10https://bugzilla.wikimedia.org/69709#c3 (10James Forrester) 5NEW>3RESO/FIX p:5Unprio>3Normal a:3Ed Sanders I just followed these steps exactl... [20:17:51] James_F, I looked at https://bugzilla.wikimedia.org/show_bug.cgi?id=43335 [20:17:53] tried a few times [20:17:57] could not reproduce issue [20:18:15] Krenair: Yeah, it feels like a race condition or something odd. [20:18:55] do you remember how often it would come up? [20:18:59] can you still reproduce it? [20:19:39] I've not gone looking for it recently, but I think I've seen it in the last month or so. [20:19:52] It would come up ~1 in 10 edit impressions. [20:19:53] Ish. [20:23:57] James_F, I tried ~15ish times, nothing [20:25:04] Krenair: Hmm. Maybe mark as WFM and we can re-open? [20:25:36] (03PS1) 10Trevor Parscal: Remind people to run composer install [oojs/ui] - 10https://gerrit.wikimedia.org/r/168174 [20:25:56] (03CR) 10Jforrester: [C: 032] Remind people to run composer install [oojs/ui] - 10https://gerrit.wikimedia.org/r/168174 (owner: 10Trevor Parscal) [20:26:08] 3VisualEditor / 3MediaWiki integration: VisualEditor: Sometimes the HotCat gadget appears at the top of the CE surface - 10https://bugzilla.wikimedia.org/43335#c7 (10Alex Monk) 5ASSI>3RESO/WOR I can't reproduce this issue... If anyone still sees this, please reopen. [20:28:30] (03CR) 10jenkins-bot: [V: 04-1] Remind people to run composer install [oojs/ui] - 10https://gerrit.wikimedia.org/r/168174 (owner: 10Trevor Parscal) [20:29:13] no () around require_once I think. [20:29:31] Ha. Oh, PHP, how crap art thee? [20:30:05] well, () is valid syntax, but I'm pretty sure Krin.kle has said no () [20:30:23] also, probably a good idea to use stream_resolve_include_path or whatever it's called [20:31:33] (03PS2) 10Legoktm: Remind people to run composer install [oojs/ui] - 10https://gerrit.wikimedia.org/r/168174 (owner: 10Trevor Parscal) [20:32:39] (03PS3) 10Legoktm: Remind people to run composer install [oojs/ui] - 10https://gerrit.wikimedia.org/r/168174 (owner: 10Trevor Parscal) [20:32:42] no, file_exists is better [20:33:11] James_F: WP:VE/User_guide says "You can click on the common edit summaries options" but I don't see any such thing. What am I missing? [20:36:09] hexmode: I think this might be a Gadget or a local customization or something? [20:36:39] hexmode: https://en.wikipedia.org/wiki/MediaWiki:Gadget-defaultsummaries.js [20:36:49] RoanKattouw: makes sense. I was just wondering. Client asked. [20:37:08] legoktm: awesome, tyvm [20:38:24] James_F: re +2 https://gerrit.wikimedia.org/r/#/c/168174/ ? [20:45:53] (03CR) 10Jforrester: [C: 032] Remind people to run composer install [oojs/ui] - 10https://gerrit.wikimedia.org/r/168174 (owner: 10Trevor Parscal) [20:47:36] (03Merged) 10jenkins-bot: Remind people to run composer install [oojs/ui] - 10https://gerrit.wikimedia.org/r/168174 (owner: 10Trevor Parscal) [20:53:11] 3VisualEditor / 3ContentEditable: VisualEditor: Pasting invalidly parented
throws "Uncaught TypeError: Cannot read property 'type' of undefined" in ve.dm.LinearData.static.getType - 10https://bugzilla.wikimedia.org/72385 (10James Forrester) 3ASSI p:3Unprio s:3normal a:3None 1. Copy to th... [20:53:53] 3VisualEditor / 3ContentEditable: VisualEditor: It should not be possible to paste images from external websites into the references dialog - 10https://bugzilla.wikimedia.org/60780#c1 (10James Forrester) 5NEW>3RESO/FIX p:5Unprio>3High AFAICT this is now completely fixed; however, in testing this I un... [20:58:22] 3VisualEditor / 3ContentEditable: VisualEditor: Pasting plain text from external sources inserts spurious double new lines between paragraphs in Safari - 10https://bugzilla.wikimedia.org/65021#c1 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal Confirmed in Safari 8.0. [21:04:08] 3VisualEditor / 3ContentEditable: VisualEditor: Pasting invalidly parented
throws "Uncaught TypeError: Cannot read property 'type' of undefined" in ve.dm.LinearData.static.getType - 10https://bugzilla.wikimedia.org/72385 (10James Forrester) p:5Unprio>3High [21:06:23] 3VisualEditor / 3MediaWiki integration: VisualEditor: Pasting of MediaWiki article title H1 should paste as a

instead of an

- 10https://bugzilla.wikimedia.org/70519#c1 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Low (In reply to Amir E. Aharoni from comment #0) > A thing that happens to me fre... [21:34:07] 3VisualEditor / 3ContentEditable: VisualEditor: New and changed citations display with blank lines before and after the citation in , if using citation templates - 10https://bugzilla.wikimedia.org/72006#c2 (10Roan Kattouw) 5ASSI>3RESO/FIX I can't reproduce this (any more?). [21:36:21] (03CR) 10Catrope: [C: 032] Work around *another* browser bug in getBoundingClientRect [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168085 (owner: 10Esanders) [21:37:19] edsanders: Did you ever end up committing that translate3D thing? [21:37:55] edsanders: Because that bug needs to be fixed one way or another by the end of the day [21:38:23] (03Merged) 10jenkins-bot: Work around *another* browser bug in getBoundingClientRect [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168085 (owner: 10Esanders) [21:46:08] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf5] Context menu label, first changes to read “Comment” before undoing any comment - 10https://bugzilla.wikimedia.org/72315#c3 (10Alex Monk) This seems to be because the first undo you make only clears the comment -text- change. The second undo... [21:49:54] 3VisualEditor: Pasting in text containing a tab character causes VE to scroll to the top - 10https://bugzilla.wikimedia.org/72390 (10Spinningspark) 3NEW p:3Unprio s:3normal a:3None Intention: Paste bibliographic information from Google books Steps to Reproduce: 1. Almost any book will do for this, but... [21:52:08] 3VisualEditor / 3Editing Tools: VisualEditor: Support tables (tracking) - 10https://bugzilla.wikimedia.org/39596 (10James Forrester) [21:55:37] 3VisualEditor / 3ContentEditable: VisualEditor: Pasting annotated text causes space to be removed at annotation seperators - 10https://bugzilla.wikimedia.org/71718 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High [21:55:52] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf1] The subst: autovalue for a template field does not return any value (Parsoid issue?) - 10https://bugzilla.wikimedia.org/71157#c1 (10Roan Kattouw) Definitely VE's fault. We're somehow not sending the parameter value to Parsoid when saving. [21:56:23] 3VisualEditor / 3ContentEditable: VisualEditor: Paste from Microsoft Word converting spaces to line breaks - 10https://bugzilla.wikimedia.org/71067 (10James Forrester) 5UNCO>3ASSI p:5Unprio>3Low [21:56:55] 3VisualEditor / 3ContentEditable: Visual Editor: IE11 - cannot insert/edit links - 10https://bugzilla.wikimedia.org/72392 (10etonkovidova) 3NEW p:3Unprio s:3major a:3None IE11 test2 and betalabs Steps to reproduce: 1. Open VE-> try to insert a link(via a shortcut or by clicking on the option) - th... [21:58:24] 3VisualEditor / 3ContentEditable: Visual Editor: Link inspector closes itself immediately in IE11 - 10https://bugzilla.wikimedia.org/72392 (10Roan Kattouw) [21:58:24] 3VisualEditor / 3Editing Tools: Visual Editor: Link inspector closes itself immediately in IE11 - 10https://bugzilla.wikimedia.org/72392 (10Roan Kattouw) [21:59:58] Hopefully https://bugzilla.wikimedia.org/show_bug.cgi?id=72315#c3 makes some sense. [22:01:29] Are the creation of a comment node and the initial text supposed to be getting merged into one change for the purposes of undo? [22:02:16] Krenair: Yes IMO ,see the comment I just left [22:02:17] Krenair: Yes. [22:02:24] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf5] Context menu label, first changes to read “Comment” before undoing any comment - 10https://bugzilla.wikimedia.org/72315#c4 (10Roan Kattouw) a:3Ed Sanders (In reply to Alex Monk from comment #3) > This seems to be because the first undo yo... [22:06:07] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf5] Have to undo twice to reverse comment creation - 10https://bugzilla.wikimedia.org/72315 (10Alex Monk) [22:07:08] 3VisualEditor: Inconsistent behaviour when copy/pasting text with a link - 10https://bugzilla.wikimedia.org/69340#c4 (10James Forrester) 5NEW>3RESO/WOR I can't reproduce this now; did you accidentally switch after the first test (which is as expected from what I can read) to a VE copy of the link (which is... [22:09:42] (03CR) 10Catrope: [C: 032] Remove insertion inspector class [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167443 (owner: 10Esanders) [22:11:33] (03Merged) 10jenkins-bot: Remove insertion inspector class [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167443 (owner: 10Esanders) [22:13:38] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf1] Template parameter autovalues are not saved - 10https://bugzilla.wikimedia.org/71157 (10Roan Kattouw) [22:17:55] 3VisualEditor: VisualEditor: Hide items in the Advanced settings of the Page options menu when they are inappropriate for the namespace - 10https://bugzilla.wikimedia.org/72396 (10WhatamIdoing) 3NEW p:3Unprio s:3normal a:3None Under "Advanced settings" in the Page options menu, there are two items:... [22:20:54] 3VisualEditor: VisualEditor: Rearrange contents of the Page options menu - 10https://bugzilla.wikimedia.org/72397 (10WhatamIdoing) 3NEW p:3Unprio s:3minor a:3None Fram says that the "Page settings" item should be the three items most commonly wanted by encyclopedia article editors: * redirect * disam... [22:21:23] 3VisualEditor: VisualEditor: Hide items in the Advanced settings of the Page options menu when they are inappropriate for the namespace - 10https://bugzilla.wikimedia.org/72396 (10WhatamIdoing) s:5normal>3minor [22:21:24] 3VisualEditor / 3Technical Debt: VisualEditor: Actually run tests for MWHeadingNode / MWPreformattedNode - 10https://bugzilla.wikimedia.org/72398 (10Roan Kattouw) 3NEW p:3Unprio s:3normal a:3Ed Sanders Right now we have a hack in ve.test.utils.js that reregisters the core versions of HeadingNode and... [22:22:27] RoanKattouw, I did not [22:22:37] 3VisualEditor / 3MediaWiki integration: VisualEditor: Provide a way to configure per-wiki which meta dialog items are available for each namespace - 10https://bugzilla.wikimedia.org/72396#c1 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Low s:5minor>3enhanc Do-able. Hard and messy, but do-able. [22:23:07] 3VisualEditor / 3Technical Debt: VisualEditor: Actually run tests for MWHeadingNode / MWPreformattedNode - 10https://bugzilla.wikimedia.org/72398 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High s:5normal>3enhanc [22:23:08] edsanders: What do you want to do, then? Is a quick hack do-able? [22:23:24] Just working out where to put the hack [22:23:56] 3VisualEditor: VisualEditor: Move the Categories item (in Page options menu) - 10https://bugzilla.wikimedia.org/72399 (10WhatamIdoing) 3NEW p:3Unprio s:3minor a:3None Two suggestions: (1) Wikipedia editors use "Categories" more than other items in the Page options menu, so put it first in the menu.... [22:25:03] * James_F nods. [22:26:38] 3VisualEditor / 3MediaWiki integration: VisualEditor: Banish the TOC and section edit link controls from the main page settings page, and show the display title one instead - 10https://bugzilla.wikimedia.org/72397#c1 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Low s:5minor>3enhanc (In reply to What... [22:28:40] 3VisualEditor: VisualEditor: Opening a very large complex transclusion sometimes hangs in Firefox - 10https://bugzilla.wikimedia.org/72401 (10WhatamIdoing) 3NEW p:3Unprio s:3normal a:3None Created attachment 16857 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16857&action=edit Firefox with th... [22:38:23] 3VisualEditor / 3MediaWiki integration: VisualEditor: Move the Categories item to the top of the Page options menu because it's used more - 10https://bugzilla.wikimedia.org/72399#c1 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal s:5minor>3enhanc (In reply to WhatamIdoing from comment #0) > Two... [22:38:40] 3VisualEditor / 3Mobile: VisualEditor Mobile: Link suggestions are appearing in a broken way inside Link Inspector in mobile - 10https://bugzilla.wikimedia.org/72402 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 16858 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16... [22:42:08] 3VisualEditor / 3Mobile: VisualEditor Mobile:[Regression wmf4] Link suggestions are appearing in a broken way inside Link Inspector in mobile - 10https://bugzilla.wikimedia.org/72402 (10Rummana Yasmeen) [22:42:24] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression] Link inspector closes itself immediately in IE11 - 10https://bugzilla.wikimedia.org/72392 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High a:3Roan Kattouw [22:42:24] 3VisualEditor / 3Mobile: VisualEditor Mobile:[Regression wmf4] Link suggestions are appearing in a broken way inside Link Inspector in mobile - 10https://bugzilla.wikimedia.org/72402 (10Rummana Yasmeen) 5NEW>3ASSI a:3Roan Kattouw [22:43:22] 3VisualEditor / 3ContentEditable: VisualEditor: New and changed citations display with blank lines before and after the citation in , if using citation templates - 10https://bugzilla.wikimedia.org/72006 (10James Forrester) [22:48:14] (03PS1) 10Catrope: Actually set parameter autoValues as values [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168204 (https://bugzilla.wikimedia.org/71157) [22:48:20] (03PS1) 10Catrope: Apply pre-save transform to template previews [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168205 (https://bugzilla.wikimedia.org/71157) [22:48:26] TrevorParscal: https://gerrit.wikimedia.org/r/168204 [22:48:33] (03PS1) 10Esanders: Increase inspector height by 1 to deal with Chrome opacity bug [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168206 (https://bugzilla.wikimedia.org/72338) [22:48:34] Can't get the GPU thing to work [22:48:56] seems to depend on order of application [22:49:47] This hack addresses the symptom not the cause ^^^ [22:52:14] (03CR) 10Trevor Parscal: [C: 032] Actually set parameter autoValues as values [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168204 (https://bugzilla.wikimedia.org/71157) (owner: 10Catrope) [22:53:29] hm RoanKattouw [22:53:51] RoanKattouw: so autovalue is *not* supposed to be auto-substed, and one needs to hack that up in templatedata itself? [22:53:52] (03Merged) 10jenkins-bot: Actually set parameter autoValues as values [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168204 (https://bugzilla.wikimedia.org/71157) (owner: 10Catrope) [22:54:13] (there's a bug filed about this, https://bugzilla.wikimedia.org/show_bug.cgi?id=71789) [22:55:36] MatmaRex: What? [22:56:21] MatmaRex: The examples I've seen have had autoValue set to values like "{{subst:CURRENTMONTH}} {{subst:CURRENTYEAR}}" [22:56:46] RoanKattouw: i read your commit summary and was reminded of https://bugzilla.wikimedia.org/show_bug.cgi?id=71789 [22:57:03] if they're supposed to be like that, then that's not documented anywhere [22:57:46] (personally i assumed they would always be expanded, and show up in VE in expanded forms) [23:06:13] Dude I just work here [23:06:18] I have no clue about TemplateData :P [23:07:23] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf1] Template parameter autovalues are not saved - 10https://bugzilla.wikimedia.org/71157 (10James Forrester) 5PATC>3RESO/FIX [23:07:25] 3VisualEditor / 3Technical Debt: VisualEditor: Move default value and autoValue code from MWParameterPage (UI) to MWParameterModel (DM) - 10https://bugzilla.wikimedia.org/72404 (10Roan Kattouw) 3ASSI p:3Unprio s:3normal a:3Sucheta Ghoshal Half of dm.MWParameterModel is dedicated to looking things up... [23:10:12] 3VisualEditor / 3Mobile: VisualEditor Mobile: The label for "Re-use" button is not greyed out only the icon for it, even if there is no reference in the page for mobile - 10https://bugzilla.wikimedia.org/72405 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 16859 --> https:/... [23:16:38] 3VisualEditor / 3Technical Debt: VisualEditor: Move default value and autoValue code from MWParameterPage (UI) to MWParameterModel (DM) - 10https://bugzilla.wikimedia.org/72404 (10James Forrester) p:5Unprio>3Normal s:5normal>3enhanc [23:16:52] 3VisualEditor / 3Technical Debt: VisualEditor: Move default value and autoValue code from MWParameterPage (UI) to MWParameterModel (DM) - 10https://bugzilla.wikimedia.org/72404 (10James Forrester) [23:17:09] RoanKattouw: https://bugzilla.wikimedia.org/show_bug.cgi?id=69512 [23:19:07] 3MediaWiki extensions / 3TemplateData: Autovalue doesn't substitute - 10https://bugzilla.wikimedia.org/71789#c1 (10James Forrester) s:5normal>3enhanc Hmm. Interesting idea. I'm not sure going through the wikitext and auto-putting in "subst:" where things look like templates is sanely doable… [23:20:17] RoanKattouw: could you please look for the examples you mentioned? I mean autovalue set to {{subst:current...}} [23:21:19] TarLocesilion: http://en.wikipedia.beta.wmflabs.org/wiki/Template:Citation_needed [23:22:17] TarLocesilion: http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Template:Citation_needed/doc&diff=131318&oldid=86048 Done by me. [23:22:43] thank you, James_F. hm, how it is done. our similar template https://pl.wikipedia.org/w/index.php?title=Szablon%3ADopracowa%C4%87%2Fopis&diff=40769744&oldid=40634957 - doesn't work: https://pl.wikipedia.org/w/index.php?title=Orzecznictwo_o_niepe%C5%82nosprawno%C5%9Bci&diff=40769753&oldid=19220404 [23:23:23] TarLocesilion: Yeah, that's a bug in VisualEditor that we're just fixing now. [23:23:31] great, thx [23:23:37] TarLocesilion: This is why I didn't announce that this functionality was available yet. :-) [23:24:10] 3VisualEditor / 3Mobile: VisualEditor Mobile: The context menu for Citations are not appearing after tapping on it when the keyboard is closed - 10https://bugzilla.wikimedia.org/72406 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 16860 --> https://bugzilla.wikimedia.org/at... [23:25:16] TrevorParscal: Were you OK to merge https://gerrit.wikimedia.org/r/#/c/168205/ too? [23:26:02] (03CR) 10Jforrester: [C: 031] Apply pre-save transform to template previews [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168205 (https://bugzilla.wikimedia.org/71157) (owner: 10Catrope) [23:26:16] (03CR) 10Jforrester: [C: 032] Increase inspector height by 1 to deal with Chrome opacity bug [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168206 (https://bugzilla.wikimedia.org/72338) (owner: 10Esanders) [23:27:51] (03Merged) 10jenkins-bot: Increase inspector height by 1 to deal with Chrome opacity bug [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168206 (https://bugzilla.wikimedia.org/72338) (owner: 10Esanders) [23:43:07] 3VisualEditor / 3Editing Tools: "Možná hledáte" template on cs.wp not easy to use with VE - 10https://bugzilla.wikimedia.org/72293 (10Alex Monk) 5NEW>3RESO/INV [23:43:38] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (40de4dabe6) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168215 [23:44:26] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (40de4dabe6) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168215 (owner: 10Jforrester) [23:46:42] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (40de4dabe6) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168215 (owner: 10Jforrester) [23:49:07] 3MediaWiki extensions / 3TemplateData: Autovalue doesn't substitute - 10https://bugzilla.wikimedia.org/71789#c2 (10Jackmcbarn) It's not. If users want it, they should put the subst: themselves. [23:51:10] (03PS1) 10Jforrester: Update VE core submodule to master (9e387da) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168218 [23:51:22] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (9e387da) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168218 (owner: 10Jforrester) [23:52:33] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (9e387da) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168218 (owner: 10Jforrester) [23:55:07] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf5] Scroll bar is appearing while opening a link inspector - 10https://bugzilla.wikimedia.org/72338 (10James Forrester) 5PATC>3RESO/FIX [23:57:24] 3VisualEditor / 3Mobile: VisualEditor Mobile: Double clicking on citation note in Mobile using desktop Safari opens up the Basic reference dialog which was explicitly disabled for Mobile - 10https://bugzilla.wikimedia.org/72407 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 1...