[00:07:40] 3VisualEditor / 3Mobile: VisualEditor Mobile: Misaligned "Cancel" and "Ok" button in the confirmation dialogs for abandoning edit and switching to Edit Source mode - 10https://bugzilla.wikimedia.org/72408 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 16862 --> https://bugz... [00:07:51] (03PS1) 10Jforrester: Follow-up I2f34448: ve.ui.InsertionInspector.js was deleted, so remove from manifest [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168221 [00:08:13] (03CR) 10Catrope: [C: 032] Follow-up I2f34448: ve.ui.InsertionInspector.js was deleted, so remove from manifest [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168221 (owner: 10Jforrester) [00:10:26] (03Merged) 10jenkins-bot: Follow-up I2f34448: ve.ui.InsertionInspector.js was deleted, so remove from manifest [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168221 (owner: 10Jforrester) [00:14:38] (03PS2) 10Jforrester: Update VE core submodule to master (27de0c4) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168218 [00:19:23] 3MediaWiki extensions / 3TemplateData: Autovalue doesn't substitute - 10https://bugzilla.wikimedia.org/71789#c3 (10James Forrester) 5UNCO>3RESO/WON In that case, I'll update the documentation and mark this as WONTFIX. [00:20:55] 3VisualEditor / 3Mobile: VisualEditor Mobile:Cannot overwrite a text entered in CE in mobile VE using desktop Firefox - 10https://bugzilla.wikimedia.org/72409 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce: 1.Open any page with mobile VE 2.Type a text 3.Select the text and t... [00:28:08] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf3] In Firefox, Cursor is appearing in Read mode at the end of the document after saving a page and after discarding the current edit in Firefox - 10https://bugzilla.wikimedia.org/71852 (10James Forrester) [00:28:23] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf21] "Uncaught TypeError: undefined is not a function", when using media search dialog - 10https://bugzilla.wikimedia.org/70860 (10James Forrester) [00:29:54] 3VisualEditor / 3Mobile: VisualEditor Mobile: The Citation icon does not get highlighted upon clicking or tapping on it in Mobile VE using desktop Safari and iOS safari - 10https://bugzilla.wikimedia.org/72410 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 16863 --> https:/... [00:30:25] 3VisualEditor / 3ContentEditable: VE: inserted images overlap preformatted text box - 10https://bugzilla.wikimedia.org/72411 (10etonkovidova) 3NEW p:3Unprio s:3normal a:3None Created attachment 16864 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16864&action=edit images overlap preformatted... [00:32:32] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (27de0c4) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168218 (owner: 10Jforrester) [00:34:12] (03Merged) 10jenkins-bot: Update VE core submodule to master (27de0c4) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168218 (owner: 10Jforrester) [00:42:06] Krinkle: Heya. How's London? [00:44:17] hmmm. Quick question -- I've relied a bit on a method from StackOverflow in one of my methods; is there a proper way to credit, or do I just add it in the description of the method, or...? [00:45:28] It's a fairly useful method for merging multiple arrays without duplication in O(n) instead of O(n^2) that I had in my brute-force one. I cleaned it up a bit, but it's still relying on that answer. [00:49:56] mooeypoo: Isn't there a util in ve.js for that? [00:50:17] Oh it's in oojs [00:50:20] oo.simpleArrayUnion [01:09:42] RoanKattouw_away, oh, there is? ha [01:09:53] I can't use ve stuff, but I can oojs utils [01:10:00] :-) [01:10:49] ha, it's pretty much the same thing i have [01:10:52] * mooeypoo uses that [01:17:18] James_F: Good good [01:17:39] Krinkle: Any chance you'll come to a KIT any time soon? ;-) [01:17:46] James_F: Took a nap in the in the afternoon as I got up at 6 today. [01:17:56] Krinkle: 06:00? Why? [01:18:26] I had slept only 3 or 4 hours the two nights before last in which I got 6. [01:18:30] I just woke up. [01:19:08] I was in yesteday's kit [01:45:45] err, I'm getting jshint errors that are annoying. "^ Expected an identifier and instead saw 'super' (a reserved word)." for all the oojs 'super' stuff and the same for 'static' [01:46:02] Krinkle ^^ ? [01:46:06] Are you using the grunt task or something built-in to your editor? [01:46:19] 'Cos that sounds like it's ignoring the .jshintrc configuration. [01:46:21] grunt task, but it's TemplateData's and I think we set it up anew [01:46:26] ah, that's what's missing [01:46:29] I'll bring it from VE [01:46:34] Right. :-) [01:46:37] mooey|away: TemplateData is not for modern browsers only [01:46:43] it requires es3 support [01:46:58] Krinkle, well, it's going to use oojs soon [01:47:00] super is a reserved word and in older js engines, reserved words are not allowed in dot position [01:47:13] I see. We're going to have to change its requirements? [01:47:19] if it's using oojs [01:47:28] Krinkle: As long as this is the GUI it's fine to depend on OOjs UI. [01:47:32] I don't know about tdg using oojs, if so, yaeh, browser support is gonna have to change. [01:47:38] Krinkle: Because that ship sailed. :-) [01:47:42] * mooey|away nods [01:47:53] but use .parent instead of .super in that case [01:48:05] oh [01:48:22] * mooey|away copied hierarchy stuff off VE code [02:06:54] 3VisualEditor / 3ContentEditable: VisualEditor: Inserted images overlap preformatted text box - 10https://bugzilla.wikimedia.org/72411 (10Rummana Yasmeen) [03:16:03] * werdna waves [03:16:08] hey Krinkle, are you about? [03:16:24] werdna: I am, but not for long [03:16:34] I'm looking to extend VE with a new dialog to insert some stuff. Where should I get started? [03:17:14] I honestly don't know. [03:17:34] any pointers for where to look? or whom to ask? [03:17:35] werdna: register RL module, add moduel name to ve plugins array. That I do know. [03:17:42] well, that's a good start [03:17:52] werdna: btu the actual js code I'm not sure. [03:18:03] werdna: There should be one or two extensions that provide VE plugins. [03:18:07] I think Math is one. [03:18:55] ooh, that's helpful [03:18:59] VE is a bit of a giant monolith [03:19:13] well, it's well structured, just intimidating :p [03:19:14] It's quite modular actually. [03:19:30] nod, I notice, but then I have to get inside and figure out where to start [03:19:34] No extensions or even medaiwiki-core related stuff in VE core [03:19:54] Well, I guess more to the point is it does a lot of things [03:20:09] And there's good APIs as well. Though still in iteration, they are well-documented too (doc.wikimedia.org). [03:20:18] oh really? [03:20:20] * werdna looks [03:20:24] But we need high level documentation telling you which classes and methods to use for the typical case. [03:20:26] I've been looking around Extension:VisualEditor [03:20:30] right, yeah, that would be helpful [03:20:49] Ve extension is just the MW bridge and a few extra plugins for MW specific elements (like templates and parser functions) [03:21:10] https://github.com/wikimedia/VisualEditor (or gerrit:VisualEditor/VisualEditor) [03:21:18] https://doc.wikimedia.org/VisualEditor/master/ [03:22:08] yeah, found the latter now [03:22:15] I'm mostly looking to just be able to edit a template [03:22:21] so I'm trying to figure out how Math integrates [03:23:51] though it will be a bit different I guess [03:23:59] btw, I thought you might appreciate something I said a few weeks ago: I love having JSHint in my editor, it's like having a little Timo on my shoulder whispering advice into my ear. [03:24:40] :) [03:24:55] werdna: What editor is that? Little Timo might not like that. [03:25:06] Sublime Text [03:25:15] Ah, heaven is a place on earth indeed. [03:25:21] I think Trevor put me onto ST [03:25:36] Yeah, me too. [03:25:36] I also followed your lead and sync my dotfiles (including my Sublime Text Packages/User directory) [03:25:50] so now if I install a package on my laptop, it also goes onto my other computers [03:25:52] I want to switch to Atom (complete rip-off of Sublime but without being donation-ware). But it's a bit too immature still for me. [03:26:06] yeah I saw that, looks neat [03:26:11] yeah, and I really like the json config files of Sublime [03:26:14] I'm only just getting to how powerful ST is [03:26:27] ST + Package Control + synced dotfiles + etc = amazing [03:26:32] https://github.com/Krinkle/dotfiles/tree/master/hosts/KrinkleMac/SublimeProjects [03:26:33] https://github.com/Krinkle/dotfiles/blob/master/hosts/KrinkleMac/SublimePreferences.json [03:26:52] B) [03:27:07] https://github.com/Krinkle/dotfiles/blob/master/hosts/KrinkleMac/init.bash#L238-L250 [03:27:10] )plugins) [03:28:20] I have a different setup for editing over SSH [03:28:30] I have managed to find the right incantations to set up SSHFS in a reliable way [03:28:36] Whcih one? I'm interested in leaving rmate, I hate it. [03:28:41] SSHFS -o reconnect + autossh [03:28:56] I found sshfs insanely slow to use. [03:28:57] sshfs cca-crucial:/srv ~/cca-srv \ [03:28:57] -o reconnect \ [03:28:57] -o transform_symlinks \ [03:28:57] -o defer_permissions \ [03:28:58] -o compression=yes \ [03:29:00] -o ServerAliveInterval=15 \ [03:29:02] -o ServerAliveCountMax=3 \ [03:29:04] With like sidebar navigation in Sublime [03:29:05] -o ssh_command='autossh -M 0' [03:29:14] it still is a bit unreliable sometimes [03:29:20] I was thinking of writing my own SSHFS that didn't suck [03:29:29] but then I realised I'd probably be better contributing to SSHFS or so [03:29:46] (yes, ofzo has entered and remained in my English vocabulary for some reason) [03:29:54] it's just a very apt expression [03:30:19] haha, yeah, the Dutch ofzo is quite infectious [03:30:23] It just fits [03:30:35] feels right [03:30:38] :) [03:30:45] I like autossh with the appropriate ServerAlive* options [03:30:50] it tends to self-heal, which is nice [03:30:52] werdna: Mac OS? [03:30:55] yeah [03:31:00] homebrew? [03:31:27] of course [03:31:32] have you heard of homebrew casks? [03:32:07] I do thoroughly recommend this guide that I found the other day: http://lapwinglabs.com/ [03:32:29] http://giridhar-mb.blogspot.co.uk/2013/05/persistent-ssh-sessions-using-sshfs-and.html [03:32:30] okay so it looks like this is the main piece I should be looking at: https://phabricator.wikimedia.org/P37 [03:33:16] it's pretty much my setup [03:33:28] werdna: lol http://caskroom.io/ [03:33:44] okay looks like that link isn't right: https://phabricator.wikimedia.org/P37 [03:33:46] oops [03:33:57] I found myself drying to drag the header and see if maybe html5 drag-and-drop enter event triggered a popup with bash install instructions [03:34:16] then I read "no more" [03:34:22] install is on the bottom of the page [03:34:24] ugh [03:34:27] lapwinglabs.com/blog/hacker-guide-to-setting-up-your-mac [03:34:28] there we go [03:46:32] Krinkle: hmm, how do I turn on the citation functionality for VE anyway? [03:47:00] Do you have it installed in MW? [03:47:45] the Cite extension? Yeah [03:48:47] figured it out, I think. It's MediaWiki:Visualeditor-cite-tool-definition.json, not just MediaWiki:Visualeditor-cite-tool-definition [03:49:34] Oh that [03:49:46] itself works fine by default [03:49:56] You you mean cite templates, not cite extension. [03:49:56] O [03:49:57] K [03:51:52] werdna: cite-tool-definition doesn't exist afaik. It's only .json [03:52:01] yeah, right. [03:52:19] doc in ve.init.mw.Target.js is out of date [03:52:21] https://www.mediawiki.org/wiki/VisualEditor/Citation_tool#Citation_Tool_Definition [03:52:24] OK [04:26:15] (03CR) 10Krinkle: [C: 04-1] "A few points, and there's also trailing whitespace (I'd recommend configuring your editor to either trim these or point them out to you wh" (032 comments) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167389 (owner: 10Mvolz) [04:27:43] okay, I am getting completely lost [04:32:35] (03CR) 10Krinkle: maps added as allowed value in TD JSON root (033 comments) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167389 (owner: 10Mvolz) [04:37:24] (03CR) 10Krinkle: maps added as allowed value in TD JSON root (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167389 (owner: 10Mvolz) [04:43:08] InezK: do *you* know anything about writing custom dialogs? [05:19:22] 3VisualEditor / 3MediaWiki integration: VisualEditor:Editing and saving a page , then pressing back browser button takes to previously saved page. - 10https://bugzilla.wikimedia.org/71917#c2 (10Ritu Swain) (In reply to James Forrester from comment #1) > I can't reproduce this; can you confirm it's still an i... [07:49:15] werdna: I think so. What exactly do you have in mind? [07:58:25] 3VisualEditor / 3ContentEditable: VisualEditor: "TypeError: undefined is not a function" when saving after pasting an external link into a basic citation - 10https://bugzilla.wikimedia.org/69709#c4 (10Bartosz Dziewoński) Indeed, works for me too now. [08:08:15] (03CR) 10Bartosz Dziewoński: TextInputWidget: Allow changing 'type' attribute (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/167311 (owner: 10Bartosz Dziewoński) [09:35:55] (03PS4) 10Esanders: Add some sanity checks in newFromReplacement, pushInsertion and pushRemoval [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118371 (owner: 10Catrope) [09:38:00] (03CR) 10jenkins-bot: [V: 04-1] Add some sanity checks in newFromReplacement, pushInsertion and pushRemoval [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118371 (owner: 10Catrope) [10:10:08] 3VisualEditor / 3Language: VisualEditor: IME detection should not use useragent sniffing - 10https://bugzilla.wikimedia.org/65077#c5 (10David Chan) 5ASSI>3RESO/FIX Was fixed by https://gerrit.wikimedia.org/r/#/c/141457 . [10:41:47] (03PS1) 10Zfilipin: WIP Prepare repository for running RuboCop after every push to Gerrit [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168267 (https://bugzilla.wikimedia.org/69245) [10:42:52] 3VisualEditor / 3ContentEditable: VisualEditor: [Regression wmf4] Link continuation is broken - 10https://bugzilla.wikimedia.org/72108#c5 (10D Chan) (In reply to Roan Kattouw from comment #3) > Oh also: the bug as filed (select link, start typing, replacement text is > linked in CE but not in DM) also appear... [10:52:47] (03CR) 10Zfilipin: "check experimental" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168267 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [10:54:25] (03PS2) 10Zfilipin: Prepare repository for running RuboCop after every push to Gerrit [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168267 (https://bugzilla.wikimedia.org/69245) [10:57:15] (03CR) 10Zfilipin: "For some reason, rubocop does not want to inspect .docs/CustomTags.rb" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168267 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [12:53:07] 3MediaWiki extensions / 3TemplateData: TemplateData: If TemplateData is added to a template page (not a /doc subpage), then it needs to be wrapped in tags - 10https://bugzilla.wikimedia.org/69149#c10 (10JAn Dudík) really fixed? https://cs.wikipedia.org/w/index.php?title=%C5%A0ablona:Infobox_-_s%... [13:43:11] 3VisualEditor / 3Editing Tools: Escape brackets in URLs added via link dialogs - 10https://bugzilla.wikimedia.org/72425 (10Nemo) 3NEW p:3Unprio s:3enhanc a:3None It would be nice if the VisualEditor dialogs were able to escape (percent-encode) URLs as this one in a way that makes them work in wikitex... [14:16:25] 3VisualEditor: copy paste of tables does not preserve true copy of wiki markup - 10https://bugzilla.wikimedia.org/72426 (10Spinningspark) 3NEW p:3Unprio s:3normal a:3None Intention: Copy a table within an article to use as a template for a similar table with different data Steps to Reproduce: 1. Paste... [14:49:01] edsanders/oojs gurus: the collection extension currently has code of the form: [14:49:01] $out->addHTML( [14:49:01] Xml::tags( 'div', [14:49:01] array( [14:49:02] 'style' => 'margin: 10px 0;', [14:49:03] ), [14:49:04] Xml::tags( 'div', [14:49:05] array( [14:49:07] 'class' => 'collection-button ok', [14:49:08] ), [14:49:09] Xml::element( 'a', [14:49:10] array( [14:49:12] 'href' => SkinTemplate::makeSpecialUrl(....etc....etc... [14:49:13] what's the recommended way to OOJS/UI-ify this? The widget demo just uses 'echo'. Is there a way to get an Xml::tags view of a widget? [14:49:14] Or should I be replacing the entire this with `$layout = new OoUiPanelLayout(); /* etc */ $out->addHtml( $layout );` ? [14:50:25] I don't really know about OOuiPHP [14:50:38] Although my recommendation would be to do as much as possible in the frontend [14:51:18] I think OOuiPHP is to encourage adoption amongst backend devs who are scared of JS [14:52:27] Since this is my first use, I'm trying to start small and make as few architectural changes to the code as possible. So I guess I get to document OOuiPHP! [14:53:26] I suspect '$layout = new OoUiPanelLayout(); /* etc */ $out->addHtml( $layout );' is the right thing, even though/because it means i'll need to replace all the div-based layout with OOjs/ui layout, instead of just surgically replacing the Xml::element('a'..) with an oojs/ui button. [14:53:52] are there autogenerated docs for the PHP side? [14:55:03] um [14:55:11] the doc-able comments [14:55:55] right -- but i thought we autogenerated docs from php code somewhere? maybe i'm imagining things. [14:56:15] I'm sure if you pointed a doc generator at the folder it would work [14:56:48] uses the same style as MW [14:57:11] OOuiPHP is so new I didn't know it was in the repo until yesterday [14:57:27] shiny! [14:57:33] you get to set up doc build scripts as well I guess [14:57:48] well, i do have Jenkins/Zuul Powers now, I suppose [14:58:43] TrevorP|Away, and matmarex will know if they plan on adding output support beyond __toSting() giving you raw html [14:59:37] it would probably be hard to implement Xml::tags support without dragging in mediawiki dependencies. [14:59:58] but i'm not an expert on the PHP side. [15:18:29] edsanders: added a bit of PHP docs to https://www.mediawiki.org/wiki/OOjs_UI [15:21:23] nice [15:21:42] i'll try to add more once i'm sure that what i wrote is correct ;) [15:21:54] the README.md needs some composer instructions as well [15:22:08] but i'm don't really understand that well enough to write it myself. [15:22:32] I guess we'd need to use traits to mixin methods like setLabel [15:22:58] documentation is Krinkle|detached 's thing [15:23:46] but traits are php 5.4 [15:26:17] i'm just noticing that the php side uses some magic mixin stuff, so setLabel looks like it already exists somehow magically. [15:26:50] $this->mixin( new OoUiLabelElement( $this, $config ) ); [15:27:42] ah, there's a magic php __call() method defined on OoUiElement.php [15:27:43] does it use __call or something? [15:27:48] yep [15:28:01] basically the hacky way of doing traits [15:28:09] works for me [15:28:38] so... are the oojs/ui php classes included in mediawiki/core? i wonder what magic i need to do in order to use them in my extension. [15:29:08] there might event be a way to document it (by pretending we're using traits??) [15:29:19] well ooui is in core [15:29:41] so.. nothing, I guess? [15:30:04] maybe php isn't in core yet though.. [15:30:11] but they should be [15:31:44] yeah, the last update by James_F|Away seemed to touch only js code. [15:31:53] TrevorP|Away or James_F|Away will know when/how that's going to happen [15:32:51] although he listed "fadc51d OOUI PHP: Unbreak ButtonWidget" in the update summary, no php code was included in 75a5ef872ae4c4c7c1080bbb220ad2d1be33c165 [15:33:05] so maybe James_F|Away himself doesn't fully realize that the PHP side isn't being included ;) [15:34:01] yeah - well the update script will selective pull the concatenated files from the /dist folder [15:34:07] and then include all history [15:34:18] I'm guessing he just needs to fix the update script [15:34:38] then it will go in includes/oojsui (????) [15:35:50] the script being update-oojsui.sh in maintenance [15:36:35] i'll poke James_F|Away about it when he wakes up [15:47:04] James_F, prod ^^^ [15:53:53] 3VisualEditor / 3ContentEditable: VisualEditor: [Regression wmf4] Link continuation is broken - 10https://bugzilla.wikimedia.org/72108#c6 (10D Chan) I tell a lie, in Chromium the behaviour is as Roan describes for the first letter, i.e. linked in the DOM but not in DM (but then subsequent letters are not lin... [15:54:23] 3VisualEditor: Pasting in text containing a tab character causes VE to scroll to the top - 10https://bugzilla.wikimedia.org/72390#c1 (10etonkovidova) Confirmed in test2 and betalbs. Steps to reproduce: 1. Copy all(or part of) Bibliographic information on http://books.google.co.uk/books?id=VYvS7MyaEE8C. It's... [16:18:54] (03PS1) 10Esanders: Move core/MW messages in correct sections [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168312 [16:20:22] 3MediaWiki extensions / 3TemplateData: TemplateData: If TemplateData is added to a template page (not a /doc subpage), then it needs to be wrapped in tags - 10https://bugzilla.wikimedia.org/69149#c11 (10James Forrester) (In reply to JAn Dudík from comment #10) > really fixed? > https://cs.wikipe... [16:30:41] Corruption alert: visualeditor-needcheck on rowiki: https://ro.wikipedia.org/?diff=8884881 [16:30:41] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=108439242 [16:30:41] Corruption alert: visualeditor-needcheck on ptwiki: https://pt.wikipedia.org/?diff=40344113 [16:30:41] Corruption alert: visualeditor-needcheck on plwiki: https://pl.wikipedia.org/?diff=40771237 [16:30:41] Corruption alert: visualeditor-needcheck on itwiki: https://it.wikipedia.org/?diff=68796656 [16:30:42] Corruption alert: visualeditor-needcheck on skwiki: https://sk.wikipedia.org/?diff=5878132 [16:36:55] 3VisualEditor / 3Editing Tools: VisualEditor:[Regression pre-wmf5] Unable to apply Link and language annotations to images. - 10https://bugzilla.wikimedia.org/72431 (10Ritu Swain) 3UNCO p:3Unprio s:3normal a:3None Created attachment 16866 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16866&a... [16:40:42] sigh [16:40:49] the reverter of that frwiki entry thinks VE put it there [16:44:59] :-( [16:53:38] 3VisualEditor / 3Editing Tools: VisualEditor: If you can't use a button, please display it as disabled/grayed out - 10https://bugzilla.wikimedia.org/69359#c1 (10Alex Monk) Open button was bug 70015 [16:54:38] 3VisualEditor / 3Editing Tools: VisualEditor: Disable "Remove" button in link inspector if there is no link in the document - 10https://bugzilla.wikimedia.org/69359 (10Alex Monk) [16:56:23] 3VisualEditor: copy paste of tables does not preserve true copy of wiki markup - 10https://bugzilla.wikimedia.org/72426#c1 (10etonkovidova) betalbs - the pasted table does not have inserted - the pasted table has for the title:

3VisualEditor / 3Editing Tools: VisualEditor: Reconsider template tool tabbing behaviour to go to the next field (not the info or remove buttons) - 10https://bugzilla.wikimedia.org/68768 (10Alex Monk) [17:07:54] 3VisualEditor / 3Editing Tools: VisualEditor: Too much tabbing in the Template dialog - 10https://bugzilla.wikimedia.org/69512#c4 (10Alex Monk) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 68768 *** [17:07:54] 3VisualEditor / 3Editing Tools: VisualEditor: Reconsider template tool tabbing behaviour to go to the next field (not the info or remove buttons) - 10https://bugzilla.wikimedia.org/68768#c2 (10Alex Monk) *** Bug 69512 has been marked as a duplicate of this bug. *** [17:20:59] James_F, you should've come a week earlier, I have a spare comp for ISIHAC in Richmond [17:26:58] James_F: Finally doing a limited deploy for VE tonight. Made it available only to people in the VE group. So, we'll soon see some good third party feedback. Or we'll see how much I suck at deploying VE. Either way: new data! [17:31:08] 3VisualEditor / 3Editing Tools: VisualEditor: Show the "*" mark beside the required parameter in the Add Parameter section - 10https://bugzilla.wikimedia.org/62161#c1 (10Alex Monk) 5ASSI>3RESO/INV (In reply to Rummana Yasmeen from comment #0) > because if a user accidentally deletes a required parameter... [17:36:38] 3VisualEditor: copy paste of tables does not preserve true copy of wiki markup - 10https://bugzilla.wikimedia.org/72426#c2 (10Spinningspark) Created attachment 16867 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16867&action=edit Screenshot of test case tables [17:38:37] 3VisualEditor / 3Editing Tools: VisualEditor: Applying link to the caption of an image does not enable "Apply Changes" button - 10https://bugzilla.wikimedia.org/71065#c1 (10WhatamIdoing) This was also reported in Mac OS X 10.9.5 in both Firefox and Safari. [17:39:38] 3VisualEditor: copy paste of tables does not preserve true copy of wiki markup - 10https://bugzilla.wikimedia.org/72426#c3 (10Spinningspark) Created attachment 16868 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16868&action=edit Screenshot of test case tables after saving [17:40:53] 3VisualEditor / 3ContentEditable: VisualEditor: [Regression wmf4] Link continuation is broken - 10https://bugzilla.wikimedia.org/72108#c7 (10D Chan) https://gerrit.wikimedia.org/r/168327/ is a POC fix to the problem of right-cursoring to a continuation position, and it also illustrates the general issues in... [17:46:23] 3VisualEditor / 3ContentEditable: VisualEditor: [Regression wmf4] Link continuation is broken - 10https://bugzilla.wikimedia.org/72108#c8 (10Roan Kattouw) (In reply to D Chan from comment #7) > 1. Unicorning is triggered by DM selection changes only if ve.dm.Surface > 'insertionAnnotationsChange' is fired: t... [17:46:40] 3VisualEditor / 3Editing Tools: VisualEditor: Category input box is too small (sometimes) - 10https://bugzilla.wikimedia.org/69574#c1 (10Alex Monk) *** Bug 71657 has been marked as a duplicate of this bug. *** [17:46:40] 3VisualEditor / 3Editing Tools: Category editor is not usable for long categories - 10https://bugzilla.wikimedia.org/71657#c1 (10Alex Monk) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 69574 *** [17:52:08] 3VisualEditor / 3Editing Tools: VisualEditor: Disable "Remove" button in link inspector if in link creation mode - 10https://bugzilla.wikimedia.org/69359#c2 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Low s:5normal>3enhanc (In reply to WhatamIdoing from comment #0) > For example, if you open the li... [17:59:47] RoanKattouw, you have a second to talk about this: https://gerrit.wikimedia.org/r/#/c/167966/ ? [18:01:27] mooeypoo: OOOH [18:01:34] I just read your comment [18:02:08] RoanKattouw, your "eew" was justified, but misplaced. [18:02:15] James_F: I spoke to divec and it sounds like we are likely to have an initial short-term fix for the worst link replacement/continuation problems for the 4pm SWAT [18:02:52] And I can see why the confusion happened; it looks like I'm updateing "THE" scalable; but the hash object just has a sub-object called "scalable" for clarity, that's what I'm actually changing. [18:03:00] mooeypoo: So, once the default dimensions are known, does scalable's getCurrentDimensions() switch to returning those instead? [18:03:02] RoanKattouw: OK, good. [18:03:22] RoanKattouw, only if the image is default [18:03:27] and yes [18:03:42] If it's not default, we don't have a problem anyways [18:04:16] that's why the two options were either change the base initialHash *or* change the hasBeenChanged method to ignore currentDimensions *if* the hash says the image is default [18:04:20] (03CR) 10Jforrester: [C: 04-1] Move core/MW messages in correct sections (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168312 (owner: 10Esanders) [18:04:26] Both f those are ugly solutions. [18:04:55] for James_F: #72426 - do you see the difference in screenshots - between two saved tables? [18:05:06] etonkovi_: Yes. [18:05:08] RoanKattouw, also, I'm starting to re-strategize how we're calling for image info for all images that already exist in the page. I think that we could do it better and have a *single* call on load that returns everything we need, including the information for the scalable [18:05:15] etonkovi_: But that's just the bug I mentioned. [18:05:26] mooeypoo: OK so my recommendation would be to just do .currentDimensions = getCurrentDimensions() then [18:05:36] but that would require a bit of a (massive) change, and some strategizing. For now, the fix should at least get the initialHash to synchronize with what "it should be" [18:05:38] And let the getter deal with the "if default, then defaultDimensions" logic [18:05:46] Because right now you're duplicating that logic [18:06:13] oh, good point; I figured I'd avoid touching the hash unless absolutely necessary, hence the 'if' before changing the initial hash at all [18:06:17] James_F: and that small difference in display justifies fixing it? [18:06:18] but you have a point [18:06:38] etonkovi_: The difference is a result of the bug, not the reason we want to fix it. [18:06:54] etonkovi_: But also yes, display glitches can be minor but still worth fixing. [18:07:16] mooeypoo: Yes I definitely want to combine imageinfo requests [18:07:26] James_F: hmm... looked really minor to me. Ok. [18:07:46] RoanKattouw, technically, the information should already exist inside the images themselves, since they are supposed to call the information on load [18:07:51] that's not perfect but it does happen [18:08:13] My first attempt at fixing this annoying bug was to clone the image scalable into the model [18:09:21] but that produced a bunch of problems, since the code re-requests information. So, ideally we *shouldn't* have the model re-ask for the information, but it isn't as smple as just attaching the right scalable--- I need to sit and think about the best way to ask for the entire information and store it so it's available [18:09:42] RoanKattouw, we should make this a tech debt [18:09:50] is that just a matter of opening a new bug? [18:10:11] Yes [18:11:46] Yeah it sounds like there might be multiple problems [18:11:54] So let's make it a tech debt bug about "clean up this damn mess" [18:12:11] We could potentially pair on that in November [18:12:16] RoanKattouw, scalablemess [18:12:24] smess. [18:12:34] smessable [18:12:41] We'll smess this out [18:15:53] 3VisualEditor / 3Editing Tools: VisualEditor: Cannot open VE in test 2 as it is throwing error: TypeError: undefined is not a function TypeError {stack: (...), message: "undefined is not a function"} - 10https://bugzilla.wikimedia.org/63645#c1 (10Alex Monk) 5NEW>3RESO/WOR Looks like this got fixed at som... [18:18:38] (03PS2) 10Esanders: Move core/MW messages in correct sections [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168312 [18:21:00] 3VisualEditor / 3Technical Debt: Reorganize and restrategize how Scalable information works with all existing images - 10https://bugzilla.wikimedia.org/72439 (10Moriel Schottlender) 3NEW p:3Unprio s:3normal a:3None Make the API call for scalable information unified on load, and make sure the call onl... [18:21:12] 3VisualEditor / 3Technical Debt: Reorganize and restrategize how Scalable information works with all existing images - 10https://bugzilla.wikimedia.org/72439 (10Moriel Schottlender) a:3Moriel Schottlender [18:21:38] (03PS1) 10Esanders: Remove mw-specific message [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168355 [18:24:57] ryasmeen: #72431 - should we be able to apply link(s) and language to the images from toolbar options? I thought it's only limited to media settings inspector [18:26:03] RoanKattouw, crap, no, 'getCurrentDimensions()' is not set to default if the image is default. I'm looking at the logic; the image checks itself if it's default and *uses* default rather thn sets it. I'm including that to the scalable mess [18:29:31] OK so you're saying that that logic is currently in ImageModel already, as opposed to Scalable? [18:30:08] the logic is split up between being in MWImageNode to being in the Scalable [18:30:14] the scalable doesn't set anything automatically [18:30:30] so, it has 'current dimensions' and 'is default' but it sets them without correlating them [18:30:43] which is probably not a good thing [18:31:13] Well, you're not the only one who does stuff like that [18:31:14] but then MWImageNode that stores/builds the scalable per image does all the calculation, mainly because htat calculation of default and such depend on the *type* of the image [18:31:19] RoanKattouw: Neat: https://phabricator.wikimedia.org/diffusion/MW/history/master/resources/lib/oojs-ui/ [18:31:28] so that calculation kinda makes sense to be in the node itself [18:31:31] mooeypoo: https://bugzilla.wikimedia.org/show_bug.cgi?id=72404 ---> that was Trevor, I discovered this yesterday [18:31:39] but it's not updating currentDimensions at all, which is an oversight [18:31:44] (03CR) 10jenkins-bot: [V: 04-1] Move core/MW messages in correct sections [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168312 (owner: 10Esanders) [18:31:49] the scalable should really do it internally [18:32:03] ha [18:32:15] oh, some of that logic makes sense to be outside the scalable [18:32:33] the scalable should only be a sizing model, really, so it stores stuff and validates stuff [18:32:39] it shouldn't have the image's attributes [18:32:40] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168355 (owner: 10Esanders) [18:32:51] in fact, it should be independent of images, even. It should work on anything [18:33:02] so the "what is the actual default value" calculation makes sense to be *external* to the scalable. [18:33:47] but the scalable should really update itself that if it's default, then the current dimensions return default. I think one of the reasons it didn't, is that if you click "default" and then *undefault* it you want to know what the original dimensions were [18:33:51] so I didn't want to override them [18:34:20] but I can fix it easily by changing the getCurrentDimensions() method to return either currentDimensions or defaultDimensions *OR* by storing the current dimensions if they are set to default [18:34:44] RoanKattouw, but since these questions keep coming up, that's why I think it's probably best to do all these fixups in one concentrated well-strategized go [18:35:11] Sure, yeah [18:36:00] The reason I was suspicious is because currentDimensions = getDefaultDimenisions() looked like you were updating the wrong property [18:36:14] * mooeypoo nods [18:36:18] I technically am :\ [18:36:21] But it makes sense for now [18:36:41] (Also is defaultDimensions not part of the hash? I guess it makes sense for it not to be?) [18:36:43] I shouldn't need to do it if we could have user settings properly and parsoid returned the correct values [18:36:50] no, there's no need to compare it [18:36:55] it never changes [18:37:11] well, for the image. If you change an image, the src would chnage anyways [18:37:16] change* [18:37:38] I just put in the information that can change between actions, isDefault / currentDimensions and all the image-specific attributes [18:38:23] I didn't include defaultDimensions and originalDimensions. First, these don't really change, but also I was trying not to update the initialHash after the API call (which I am now unfortunately) [18:38:26] 3VisualEditor / 3Editing Tools: VisualEditor: Parameter add icon remains enabled in empty transclusion dialog box - 10https://bugzilla.wikimedia.org/63158 (10Alex Monk) a:3Alex Monk [18:39:22] 3VisualEditor / 3Editing Tools: VisualEditor: Parameter add icon remains enabled in empty transclusion dialog box - 10https://bugzilla.wikimedia.org/63158 (10James Forrester) [18:42:08] 3VisualEditor / 3Technical Debt: VisualEditor: Reorganize and restrategize how Scalable information works with all existing images - 10https://bugzilla.wikimedia.org/72439 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal s:5normal>3enhanc [18:43:10] btw, RoanKattouw, happy Mole day. [18:50:11] 3VisualEditor / 3MediaWiki integration: At nowiki the nowiki-tag shows up in some edits done with VisualEditor - 10https://bugzilla.wikimedia.org/72442 (10jeblad) 3NEW p:3Unprio s:3normal a:3None It seems like nowiki-tags shows up at edits done at nowiki with VisualEditor. The first of the two examp... [18:51:42] (03PS1) 10Alex Monk: Disable parameter add icon when there's no transclusion parts [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168379 (https://bugzilla.wikimedia.org/63158) [18:54:29] edsanders: meeting in 6 minutes? [18:58:18] ryasmeen, hey, around? [18:58:34] Hey Krenair [18:58:52] I saw https://bugzilla.wikimedia.org/show_bug.cgi?id=63341 [19:00:05] By "Insert transclusion" button do you mean the "Add template" button? [19:00:58] Oh, you mean you shouldn't be able to insert a transclusion with only blank content parts in? [19:01:24] Ah yeah!When I reported this bug , I think the label was "Insert Transclusion" but now it's just "Insert" [19:02:49] Yeah , I mean if there is no content or no template then inserting it does not make much sense to me, i guess [19:03:15] On top of that, now I see there is an error in the console when I try to do that: Uncaught TypeError: Cannot read property 'length' of null [19:04:53] 3VisualEditor / 3Editing Tools: VisualEditor: Transclusion dialog's Insert button is enabled even if the parts are just empty content - 10https://bugzilla.wikimedia.org/63341 (10Alex Monk) [19:05:39] 3VisualEditor / 3Editing Tools: VisualEditor: Transclusion dialog's Insert button is enabled even if the parts are just empty content - 10https://bugzilla.wikimedia.org/63341 (10Roan Kattouw) a:3Sucheta Ghoshal [19:06:08] James_F: so... how can I use OOui/PHP in a deployed mediawiki extension? [19:06:19] cscott: You can't yet. [19:06:26] * cscott apparently likes being a guinea pig [19:06:28] cscott: MatmaRex and TrevorP|Away are about to set it up. [19:06:29] when can i? [19:06:35] I have no idea, sorry. :-) [19:06:40] * cscott hopes the answer is "later this afternoon" [19:06:42] cscott: Also we have a meeting about VE OT now [19:06:55] orly, sorry i was still thinking that was tomorrow [19:07:07] 3VisualEditor / 3Editing Tools: VisualEditor: Transclusion dialog's Insert button is enabled even if the parts are just empty content - 10https://bugzilla.wikimedia.org/63341#c2 (10Rummana Yasmeen) Also, there is an error in the console: Uncaught TypeError: Cannot read property 'length' of null [19:07:24] We had to move it so edsanders could make it [19:07:45] But don't worry, we're in a room where no one understands the A/V equipment so we havent' actually made it to our own meeting yet [19:07:58] cscott: if you included the repo as a submodule, or copy-pasted the files as a library, then you could probably use it now if you don't mind the api breaking every other week [19:08:22] cscott: the plan is probably to includes it in mediawiki/core via composer… probably. [19:08:26] to include* [19:08:50] RoanKattouw, can I join? [19:08:58] Yes please [19:09:05] (also, i like how every person has their own spelling variant of oouiphp) [19:09:13] :-) [19:09:14] Oh the meeting doesn't have a hangout attached [19:09:16] Because OIT [19:09:27] yeah [19:09:29] And I don't have permission to add one [19:09:32] We'll just invite you guys [19:09:36] MatmaRex: You mean mediawiki/vendor? :-) [19:09:50] James_F: yes [19:10:18] i guess copy-and-paste is it then [19:10:57] i wonder how many bugs there are, we haven't gotten around to writing any tests for JS/PHP output comparison yet :D [19:11:09] 3VisualEditor / 3ContentEditable: VisualEditor: Preserve `data-parsoid` attribute on internal copy-paste so that Parsoid preserves e.g. syntax layout. - 10https://bugzilla.wikimedia.org/72426#c13 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High a:5Parsoid Team>3None Per discussion with Parsoid team... [19:12:55] MatmaRex: The smoke tests work for eyeballing, though. [19:13:28] James_F: yeah, but i missed ButtonWidget's TitledElement mixin being busted, for example [19:13:36] * James_F nods. [19:13:40] Proper tests would be great. [19:14:29] i was wondering how to go about this, actually [19:14:45] i don't know if we can run OOUI in a non-browser environment? probably not [19:15:05] JS unit tests against the HTML structure from the PHP stuff. [19:15:12] in which case the sanest option seems to be, try to make it a QUnit test suite [19:15:17] assert that each item appears, has the right title… [19:15:19] Yeah. [19:15:42] have a .php page that dumps the HTML for various PHP widgets/stuffs, have JS tests that compare this to JS output [19:16:17] i have no idea if it can be hooked to the current CI system, but it can't possibly be hard to rewire stuff a bit until it can be hooked once the tests exist [19:16:53] right, i might take a stab at this today, then, after i'm done reviewing RL stuff [19:28:44] James_F, what's left for https://bugzilla.wikimedia.org/show_bug.cgi?id=50881 ? suggest section links for target page? [19:29:20] Krenair: Yes. [19:29:52] 3VisualEditor / 3Editing Tools: VisualEditor: Link input widget should suggest section links - 10https://bugzilla.wikimedia.org/50881 (10Alex Monk) [19:39:17] ryasmeen, https://bugzilla.wikimedia.org/show_bug.cgi?id=65318 works for me... [19:42:06] (03PS3) 10Jforrester: tests: Prepare repository for running RuboCop after every push to Gerrit [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168267 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [19:42:11] (03CR) 10Jforrester: [C: 032] tests: Prepare repository for running RuboCop after every push to Gerrit [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168267 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [19:44:37] (03Merged) 10jenkins-bot: tests: Prepare repository for running RuboCop after every push to Gerrit [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168267 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [19:45:08] 3VisualEditor / 3Language: VisualEditor: IME detection should not use useragent sniffing - 10https://bugzilla.wikimedia.org/65077 (10James Forrester) [19:46:53] 3VisualEditor / 3ContentEditable: VisualEditor: It should not be possible to paste images from external websites into the references dialog - 10https://bugzilla.wikimedia.org/60780#c2 (10etonkovidova) Verified in betalabs. [19:55:47] (03CR) 10Catrope: [C: 032] Update initialHash after getting defaultDimensions in image model [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167966 (owner: 10Mooeypoo) [19:56:14] (03CR) 10Catrope: "Merging because this is fine as a hack, and Moriel is filing (or has filed?) a tech debt bug about a larger cleanup initiative." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167966 (owner: 10Mooeypoo) [19:57:41] RoanKattouw, https://bugzilla.wikimedia.org/show_bug.cgi?id=72439 [19:59:05] Aha [19:59:07] thanks [20:00:21] (03Merged) 10jenkins-bot: Update initialHash after getting defaultDimensions in image model [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167966 (owner: 10Mooeypoo) [20:06:22] 3VisualEditor / 3Editing Tools: VisualEditor: The Advanced Settings opens up as a default tab for an image if that was the tab user opened for the last edited image - 10https://bugzilla.wikimedia.org/65318#c2 (10Alex Monk) 5NEW>3RESO/WOR Seems to have been fixed at some point. [20:10:48] https://github.com/cscott/mediawiki-extensions-togetherjs/blob/master/js/ext.togetherjs.ve.js#L86 [20:10:53] edsanders, RoanKattouw, et al: ^^ [20:15:04] (03CR) 10Catrope: [C: 04-1] POC: setSelection emits if continuation unicorns are needed (033 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168327 (owner: 10Divec) [20:17:52] 3VisualEditor / 3Editing Tools: VisualEditor: The suggestion dropdown box gets stuck inside the transclusion dialog box in Firefox when you click on Add template button as soon as the dropdown box appears - 10https://bugzilla.wikimedia.org/64982#c1 (10Alex Monk) 5NEW>3RESO/WOR Can't reproduce [20:20:28] James_F, question regarding the templatedata editor languages [20:20:35] Yes? [20:21:03] so we're allowing for descriptions and a couple of other properties to be in multiple languages. Krinkle said that if a certain language has partial values, the rest falls back on the default wiki language [20:21:06] so far so good [20:21:49] but the question is how will the editor work in terms of display : when you pick a language, the values are filled in. If there's no value in that language, should the value be filled up in the default language or remain empty to show the user this value is not available in that language yet? [20:22:48] I think #2 is better for the user, but it runs the risk of not being consistent with later behavior of the templatedata dialog [20:22:54] or rather the template dialog in VE [20:25:50] mooeypoo: Remain empty. [20:25:58] mooeypoo: This is how e.g. Wikidata does it. [20:26:21] * mooeypoo nods [20:27:53] 3VisualEditor / 3Editing Tools: VisualEditor: Category input box is too small (sometimes) - 10https://bugzilla.wikimedia.org/69574 (10Alex Monk) [20:27:53] 3VisualEditor / 3Editing Tools: VisualEditor: Long links are not shown in full in the link searcher - 10https://bugzilla.wikimedia.org/57200 (10Alex Monk) [20:30:52] 3VisualEditor / 3Editing Tools: VisualEditor: "Insert Transclusion" button becomes enabled after adding a second empty template - 10https://bugzilla.wikimedia.org/63340#c1 (10Alex Monk) Is this the same as bug 63341? [20:42:22] 3VisualEditor / 3Editing Tools: VisualEditor: Transclusion editor should should give an "are you sure?" message if an unknown template is selected - 10https://bugzilla.wikimedia.org/52449#c2 (10Alex Monk) Unknown template = template with no TemplateData? [20:44:37] 3VisualEditor / 3Editing Tools: VisualEditor: "Insert Transclusion" button becomes enabled after adding a second empty template - 10https://bugzilla.wikimedia.org/63340#c2 (10Rummana Yasmeen) Yeah , this one I filed for adding empty template and bug 63341 was specifically for adding empty content,but they m... [20:48:23] 3VisualEditor / 3Editing Tools: VisualEditor: Transclusion editor should should give an "are you sure?" message if an unknown template is selected - 10https://bugzilla.wikimedia.org/52449#c3 (10Alex Monk) Non-existent? [20:58:55] 3OOjs UI: PHP docs should be autogenerated. - 10https://bugzilla.wikimedia.org/72454 (10C. Scott Ananian) 3NEW p:3Unprio s:3normal a:3None Mediawiki has autogenerated JS and PHP docs at: http://doc.wikimedia.org/mediawiki-core/master/php http://doc.wikimedia.org/mediawiki-core/master/js OOjs UI curren... [21:10:25] 3OOjs UI: OOUI: Synchronise JS and PHP docs better - 10https://bugzilla.wikimedia.org/72455 (10Bartosz Dziewoński) 3NEW p:3Unprio s:3normal a:3None We should synchronise JS and PHP docs better, and preferably not by hand. PHP docs are missing most class and constructor documentation. JS docs are missi... [21:10:41] 3VisualEditor / 3ContentEditable: Visual Editor: wmf5 - cannot paste text with new lines into preformatted area - 10https://bugzilla.wikimedia.org/72456 (10etonkovidova) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce: 1. Open VE - select Preformatted text option 2. Type some text that has se... [21:15:09] 3VisualEditor / 3Editing Tools: VisualEditor: Transclusion dialog's Insert button is enabled even if the parts are just empty content - 10https://bugzilla.wikimedia.org/63341#c3 (10Alex Monk) *** Bug 63340 has been marked as a duplicate of this bug. *** [21:15:09] 3VisualEditor / 3Editing Tools: VisualEditor: "Insert Transclusion" button becomes enabled after adding a second empty template - 10https://bugzilla.wikimedia.org/63340#c3 (10Alex Monk) 5ASSI>3RESO/DUP *** This bug has been marked as a duplicate of bug 63341 *** [21:16:53] 3VisualEditor / 3ContentEditable: Visual Editor: wmf5 - cannot paste text with new lines into preformatted area - 10https://bugzilla.wikimedia.org/72456#c1 (10etonkovidova) Found in test2 - Safari, Chrome, FF. [21:18:38] 3VisualEditor / 3Editing Tools: VisualEditor: Transclusion editor should should give an "are you sure?" message if an unknown template is selected - 10https://bugzilla.wikimedia.org/52449#c4 (10Elitre) See comment #1? [21:24:14] (03PS2) 10Divec: POC: setSelection emits activeAnnotationChange if continuation unicorns may be needed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168327 [21:24:17] (03CR) 10jenkins-bot: [V: 04-1] POC: setSelection emits activeAnnotationChange if continuation unicorns may be needed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168327 (owner: 10Divec) [21:26:08] (03PS24) 10Divec: Use a single unicorn-like instead of  in inline slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151046 (owner: 10Catrope) [21:26:14] (03PS5) 10Divec: WIP: Show entire expandable call tree in ve.Filibuster [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167021 [21:27:28] okay this is super embarrassing but I can't find this online ... I forgot a word in English to name my variable .. help.. ehh.. what do you call the separator character in joined arrays? omg it's like, on the tip of my tongue and won't come out. It's not a divider. Dal--something. Help, you guys! [21:28:28] mooeypoo: delimiter [21:28:35] !!!!! thank you! [21:28:40] and now forget this happened. [21:28:44] * mooeypoo waves her magic wand [21:36:40] (03PS3) 10Divec: POC: setSelection emits activeAnnotationChange if continuation unicorns may be needed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168327 [21:36:43] (03CR) 10jenkins-bot: [V: 04-1] POC: setSelection emits activeAnnotationChange if continuation unicorns may be needed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168327 (owner: 10Divec) [21:38:45] (03PS1) 10Hashar: Conf for doxygen based PHP doc [oojs/ui] - 10https://gerrit.wikimedia.org/r/168490 [21:39:19] (03CR) 10Hashar: "Suggested by C. Scott on IRC :-]" [oojs/ui] - 10https://gerrit.wikimedia.org/r/168490 (owner: 10Hashar) [21:45:03] (03CR) 10Catrope: [C: 04-1] POC: setSelection emits activeAnnotationChange if continuation unicorns may be needed (033 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168327 (owner: 10Divec) [21:49:22] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf3] Cannot open the dropdown box for "Use this group" field inside References List dialog box - 10https://bugzilla.wikimedia.org/72100#c5 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production [21:49:52] 3VisualEditor / 3Editing Tools: VisualEditor: The icons for Media and Comment are appearing a bit darker in Insert menu - 10https://bugzilla.wikimedia.org/71541#c6 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production [21:51:07] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf4] “Uncaught TypeError: undefined is not a function” when Citation dialog opens - 10https://bugzilla.wikimedia.org/71997#c5 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production [21:52:37] 3VisualEditor / 3ContentEditable: VisualEditor: Trying to insert anything in the slug inside a media dialog box throws Uncaught Error: Offset could not be translated to a DOM element and offset: 63 - 10https://bugzilla.wikimedia.org/63025#c10 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production [21:53:40] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf3] The dropdown box for "Use this group" field inside Reference dialog is not closing upon de-focusing - 10https://bugzilla.wikimedia.org/72099#c7 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production [21:54:23] 3VisualEditor / 3Editing Tools: VisualEditor: Highlight missing parameters in template dialog when complaining about them - 10https://bugzilla.wikimedia.org/70957#c8 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production [21:55:23] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf4] After placing the cursor on a slug, placing it anywhere in the page which follows that particular slug throws "TypeError: Cannot read property 'getSelection' of null" - 10https://bugzilla.wikimedia.org/72095#c6 (10Rummana Yasmeen) Verified t... [21:55:52] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf4] After placing the cursor on a slug, placing it anywhere in the page which follows that particular slug throws "TypeError: Cannot read property 'getSelection' of null" - 10https://bugzilla.wikimedia.org/72095 (10Rummana Yasmeen) 5RESO/?>3V... [22:00:39] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf5] Scroll bar is appearing while opening a link inspector - 10https://bugzilla.wikimedia.org/72338#c4 (10Rummana Yasmeen) Verified the fix in test2 [22:01:02] (03PS2) 10Cscott: Conf for doxygen based PHP doc [oojs/ui] - 10https://gerrit.wikimedia.org/r/168490 (https://bugzilla.wikimedia.org/72454) (owner: 10Hashar) [22:01:33] (03PS4) 10Divec: POC: setSelection emits activeAnnotationChange if continuation unicorns may be needed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168327 [22:01:35] (03CR) 10jenkins-bot: [V: 04-1] POC: setSelection emits activeAnnotationChange if continuation unicorns may be needed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168327 (owner: 10Divec) [22:11:48] TrevorParscal: https://gerrit.wikimedia.org/r/#/q/project:mediawiki/skins/apex,n,z [22:11:52] Hello humanity. [22:13:13] RoanKattouw: https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/skins/apex,access [22:16:39] (03PS3) 10Esanders: Move core/MW messages in correct sections [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168312 [22:22:53] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf5] The "Show Options" inside Transclusion dialog box is blank, not bringing up the other options to add parameter/template/content - 10https://bugzilla.wikimedia.org/72278#c5 (10Rummana Yasmeen) Verified the fix in test2 [22:23:24] 3OOjs UI: OOjs UI: PHP docs should be auto-generated - 10https://bugzilla.wikimedia.org/72454 (10James Forrester) p:5Unprio>3Normal a:3C. Scott Ananian [22:24:08] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression] "Make full size" is not enabling "Apply Changes" button when the image has been set to a custom size - 10https://bugzilla.wikimedia.org/72155#c3 (10Rummana Yasmeen) Verified the fix in test2 [22:24:54] 3OOjs UI: OOUI: Synchronise JS and PHP docs better - 10https://bugzilla.wikimedia.org/72455 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal a:3Bartosz Dziewoński [22:25:31] (03PS3) 10Esanders: Table header/data format tools [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168060 [22:25:33] (03PS40) 10Esanders: Data model implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159310 (owner: 10Oliverb) [22:25:35] (03PS41) 10Esanders: ContentEditable implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159311 (owner: 10Oliverb) [22:25:37] (03PS11) 10Esanders: Merge cells tool [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167631 [22:25:37] 3VisualEditor / 3Mobile: VisualEditor: [Regression pre-wmf5] Cannot open Mobile VE in Betalabs , in the console "TypeError: Cannot set property 'MWMobileContext' of undefined" appears - 10https://bugzilla.wikimedia.org/72282#c6 (10Rummana Yasmeen) Verified the fix in test2 [22:25:39] (03PS10) 10Esanders: Supporting copy paste of single table cells [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167559 [22:25:41] (03PS17) 10Esanders: Support annotation tool on table selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166774 [22:25:43] (03PS47) 10Esanders: Actions and context menus for manipulating tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb) [22:26:08] 3VisualEditor / 3Editing Tools: VisualEditor: Transclusion editor should should give an "are you sure?" message if an unknown template is selected - 10https://bugzilla.wikimedia.org/52449#c5 (10James Forrester) (In reply to Alex Monk from comment #2) > Unknown template = template with no TemplateData? (In r... [22:27:08] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf4] Red border is appearing around required parameters before focus moves away - 10https://bugzilla.wikimedia.org/72096#c7 (10Rummana Yasmeen) Verified the fix in test2 [22:28:22] (03PS4) 10Esanders: Move core/MW messages to correct sections [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168312 [22:39:08] 3VisualEditor / 3ContentEditable: VisualEditor: [Regression] Can't cut or (sometimes) paste in Firefox - 10https://bugzilla.wikimedia.org/72164#c5 (10etonkovidova) Confirmed - the issue is fixed in test2 (wmf5). [22:41:38] 3VisualEditor / 3Editing Tools: VisualEditor: Automatic naming scheme for references produces meaningless names like - 10https://bugzilla.wikimedia.org/57459#c5 (10Alex Monk) 5ASSI>3RESO/DUP *** This bug has been marked as a duplicate of bug 50568 *** [22:41:38] 3VisualEditor / 3Editing Tools: VisualEditor: Be able to name references manually in the reference dialog - 10https://bugzilla.wikimedia.org/50568#c5 (10Alex Monk) *** Bug 57459 has been marked as a duplicate of this bug. *** [22:44:39] 3VisualEditor / 3ContentEditable: VisualEditor: Dispaly the contextual menu for templates much more visibly - 10https://bugzilla.wikimedia.org/50854#c2 (10James Forrester) 5NEW>3RESO/FIX p:5Unprio>3High a:3Trevor Parscal Sorry for having not responded on this ticket; we fixed this ages ago with the... [22:45:07] 3VisualEditor / 3ContentEditable: VisualEditor: Display the contextual menu for templates much more visibly - 10https://bugzilla.wikimedia.org/50854 (10James Forrester) [22:46:38] 3VisualEditor / 3ContentEditable: VisualEditor: Let template's navboxes (VTE links) be used in VE edit move - 10https://bugzilla.wikimedia.org/53099 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Lowest s:5normal>3enhanc [22:47:05] (03PS5) 10Divec: POC: setSelection emits activeAnnotationChange if continuation unicorns may be needed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168327 [22:47:08] (03CR) 10jenkins-bot: [V: 04-1] POC: setSelection emits activeAnnotationChange if continuation unicorns may be needed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168327 (owner: 10Divec) [22:47:09] 3VisualEditor / 3ContentEditable: VisualEditor: [Regression] Can't cut or (sometimes) paste in Firefox - 10https://bugzilla.wikimedia.org/72164#c6 (10etonkovidova) Safari does not handle Paste smoothly - when some text is pasted, the page swiftly(but noticeably) scrolls to the top and back to the place when... [22:51:52] 3VisualEditor / 3Initialisation: VisualEditor:Editing and saving a page , then pressing back browser button takes to previously saved page. - 10https://bugzilla.wikimedia.org/71917#c3 (10James Forrester) 5UNCO>3RESO/FIX (In reply to Ritu Swain from comment #2) > (In reply to James Forrester from comment... [22:54:34] (03CR) 10Jforrester: [C: 04-1] "Isn't this shown in the stand-alone toolbar any more? Can we add it back? Am I just imagining that it was shown?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168355 (owner: 10Esanders) [23:05:09] (03PS6) 10Catrope: Make setSelection emit activeAnnotationChange if continuation unicorns may be needed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168327 (https://bugzilla.wikimedia.org/72108) (owner: 10Divec) [23:05:11] (03CR) 10jenkins-bot: [V: 04-1] Make setSelection emit activeAnnotationChange if continuation unicorns may be needed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168327 (https://bugzilla.wikimedia.org/72108) (owner: 10Divec) [23:05:26] (03PS7) 10Catrope: Make setSelection emit activeAnnotationChange if continuation unicorns may be needed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168327 (https://bugzilla.wikimedia.org/72108) (owner: 10Divec) [23:05:28] James_F, https://bugzilla.wikimedia.org/show_bug.cgi?id=67794 [23:05:28] (03CR) 10jenkins-bot: [V: 04-1] Make setSelection emit activeAnnotationChange if continuation unicorns may be needed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168327 (https://bugzilla.wikimedia.org/72108) (owner: 10Divec) [23:05:34] .. isn't this a templatedata bug? [23:06:00] Krenair: Whoops, yes. [23:06:26] 3MediaWiki extensions / 3TemplateData: TemplateData: Deprecated param w/out description text "no description" isn't in italic grey - 10https://bugzilla.wikimedia.org/67794 (10James Forrester) [23:10:53] 3VisualEditor / 3Data Model: VisualEditor: [Regression wmf4] "Uncaught TypeError: Cannot read property 'resolve' of null" when applying language annotation to an image, the inspector remains open - 10https://bugzilla.wikimedia.org/72259#c5 (10etonkovidova) Verified the fix in test2. [23:11:26] (03PS8) 10Catrope: Make setSelection emit activeAnnotationChange if continuation unicorns may be needed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168327 (https://bugzilla.wikimedia.org/72108) (owner: 10Divec) [23:13:20] (03CR) 10jenkins-bot: [V: 04-1] Make setSelection emit activeAnnotationChange if continuation unicorns may be needed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168327 (https://bugzilla.wikimedia.org/72108) (owner: 10Divec) [23:14:55] 3VisualEditor / 3MediaWiki integration: Oldid in navigation links isn't updated after saving - 10https://bugzilla.wikimedia.org/72461 (10Arlo Breault) 3NEW p:3Unprio s:3normal a:3None Noticed on permalink link and download as pdf. [23:15:02] James_F, TemplateData is explicitly checking whether the parameter is deprecated or not before applying that mw-templatedata-doc-muted class which makes it grey and italic [23:16:17] 'mw-templatedata-doc-muted' => ( $paramObj->description === null && $paramObj->deprecated === false ) [23:16:45] how do I emit an event with multiple parameters through oojs event emitter? not through an array, I assume? [23:16:50] I'm getting bad behavior with it [23:18:38] Krenair: So style it with a different style in that case? [23:19:07] I'm missing something. [23:19:39] 3VisualEditor / 3MediaWiki integration: VisualEditor: Oldid in navigation links isn't updated after saving - 10https://bugzilla.wikimedia.org/72461 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal [23:21:22] I don't know why it does this [23:21:29] was in the initial commit [23:24:45] 'mw-templatedata-doc-param-empty' => $paramObj->description === '' && $paramObj->deprecated === false [23:25:50] Krenair: Yeah. [23:29:08] 3VisualEditor / 3Data Model: VisualEditor: [Regression wmf4] Applying link to an image gives "Uncaught TypeError: Cannot read property 'from' of null ", inspector stays open - 10https://bugzilla.wikimedia.org/72258#c4 (10etonkovidova) Verified in test2(wmf5) - FF, Chrome are fine. Safari does not display...