[01:02:40] 3VisualEditor / 3Mobile: VE: new links are displayed as normal text in Read view - 10https://bugzilla.wikimedia.org/72467 (10etonkovidova) 3NEW p:3Unprio s:3normal a:3None Created attachment 16872 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16872&action=edit Mobile Read mode displays only... [01:03:53] 3VisualEditor / 3Mobile: VE: new links are displayed as normal text in Read view - 10https://bugzilla.wikimedia.org/72467#c1 (10etonkovidova) Created attachment 16873 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16873&action=edit Mobile Edit mode displays red and blue links [01:24:06] (03PS1) 10SuchetaG: Add template button remains disabled when entering space as a template [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168531 (https://bugzilla.wikimedia.org/71998) [01:27:39] (03CR) 10Siebrand: "PS2 comments need follow-up." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168060 (owner: 10Esanders) [01:34:58] (03CR) 10Catrope: [C: 032] Add template button remains disabled when entering space as a template [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168531 (https://bugzilla.wikimedia.org/71998) (owner: 10SuchetaG) [01:36:12] (03Merged) 10jenkins-bot: Add template button remains disabled when entering space as a template [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168531 (https://bugzilla.wikimedia.org/71998) (owner: 10SuchetaG) [01:36:28] (03CR) 10Catrope: "This doesn't fix the wider issue of 1) the template dialog accepting invalid titles ("Talk:" still breaks) and 2) the broader issue that w" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168531 (https://bugzilla.wikimedia.org/71998) (owner: 10SuchetaG) [01:41:39] 3VisualEditor / 3Editing Tools: VisualEditor: “Uncaught Error: Unable to parse title” when entering space as a template - 10https://bugzilla.wikimedia.org/71998 (10Roan Kattouw) [01:41:41] 3VisualEditor / 3Technical Debt: VisualEditor: MWTitleInputWidget should return titles - 10https://bugzilla.wikimedia.org/72468 (10Roan Kattouw) 3NEW p:3Unprio s:3normal a:3None MWTitleInputWidget should have a .getTitle() getter (which can return null, if the value isn't a valid title). Using this g... [01:43:07] 3VisualEditor / 3Editing Tools: VisualEditor: “Uncaught Error: Unable to parse title” when entering space as a template - 10https://bugzilla.wikimedia.org/71998#c4 (10Roan Kattouw) 5PATC>3ASSI (In reply to Gerrit Notification Bot from comment #3) > Change 168531 merged by jenkins-bot: > Add template butt... [01:43:54] 3VisualEditor / 3Technical Debt: VisualEditor: MWTitleInputWidget should return titles - 10https://bugzilla.wikimedia.org/72468 (10Roan Kattouw) 5NEW>3ASSI p:5Unprio>3Normal a:3Sucheta Ghoshal [01:46:53] 3VisualEditor / 3Editing Tools: VisualEditor: “Uncaught Error: Unable to parse title” when entering "Talk:" as a template - 10https://bugzilla.wikimedia.org/71998 (10Roan Kattouw) [01:51:23] 3VisualEditor / 3Technical Debt: VisualEditor: MWTitleInputWidget should return titles - 10https://bugzilla.wikimedia.org/72468 (10Roan Kattouw) [01:51:23] 3VisualEditor / 3Editing Tools: VisualEditor: TitleInputWidget should validate inputs - 10https://bugzilla.wikimedia.org/71249#c5 (10Roan Kattouw) This is scarily close to what I filed bug 72468 about. While filing it I was thinking that an isValid() implementation should also be provided. I'll add that to t... [02:24:38] 3VisualEditor / 3Technical Debt: VisualEditor: MWTitleInputWidget should return titles - 10https://bugzilla.wikimedia.org/72468#c1 (10Roan Kattouw) Also, per bug 71249, now that we have isValid() in TextInputWidget, it makes sense for MWTitleInputWidget to reimplement isValid() as a check for getTitle() not... [02:24:53] 3VisualEditor / 3Editing Tools: VisualEditor: TitleInputWidget should validate inputs - 10https://bugzilla.wikimedia.org/71249 (10Roan Kattouw) a:5Alex Monk>3Sucheta Ghoshal [02:25:39] 3VisualEditor / 3MediaWiki integration: VisualEditor: It's not possible to "Apply changes" from the transclusion dialog after it has been emptied - 10https://bugzilla.wikimedia.org/72191 (10Roan Kattouw) a:5Sucheta Ghoshal>3Alex Monk [02:26:54] 3VisualEditor / 3Editing Tools: VisualEditor: Transclusion dialog's Insert button is enabled even if the parts are just empty content - 10https://bugzilla.wikimedia.org/63341#c4 (10Roan Kattouw) a:5Sucheta Ghoshal>3Alex Monk See also bug 63340, which was duped to this one but is actually subtly different... [02:28:24] 3VisualEditor / 3Technical Debt: VisualEditor: Move default value and autoValue code from MWParameterPage (UI) to MWParameterModel (DM) - 10https://bugzilla.wikimedia.org/72404 (10Roan Kattouw) a:5Sucheta Ghoshal>3Alex Monk [02:49:54] 3VisualEditor / 3Editing Tools: OOjs UI: Dialogs should disable "Apply changes" until a change is present - 10https://bugzilla.wikimedia.org/55976#c1 (10Roan Kattouw) 5ASSI>3UNCO a:5Trevor Parscal>3None This is not an OOUI bug, moving back to VE. Rather, it's a bug in the individual dialogs in VE tha... [06:27:53] 3OOjs UI: OOjs UI: Selected text in readonly/disabled TextInputWidget is hard to read on Chrome on Linux - 10https://bugzilla.wikimedia.org/63840#c3 (10Roan Kattouw) I got confused for a bit trying to reproduce this. Turns out it only happens for readonly and disabled TextInputWidgets. [07:25:09] 3VisualEditor / 3Editing Tools: VisualEditor: Fly-out wikitext editor for unsupported extensions' source blocks ("alienated content") - 10https://bugzilla.wikimedia.org/43133#c11 (10Roan Kattouw) 5ASSI>3RESO/FIX a:3Ed Sanders Fixed by Ed last year in https://gerrit.wikimedia.org/r/#/c/78035/ [07:35:23] 3VisualEditor / 3Editing Tools: VisualEditor: Dialogs should disable "Apply changes" until a change is present - 10https://bugzilla.wikimedia.org/55976 (10Roan Kattouw) [07:43:10] 3VisualEditor / 3Editing Tools: VisualEditor: No Language selected in the Language Selector shows “$1” - 10https://bugzilla.wikimedia.org/68202#c3 (10Roan Kattouw) 5NEW>3RESO/FIX a:3Roan Kattouw Fixed as a side effect of https://gerrit.wikimedia.org/r/#/c/160098/ [07:52:07] 3VisualEditor: VisualEditor: The References List dialog looks too big, much unnecessary empty space - 10https://bugzilla.wikimedia.org/70601#c1 (10Roan Kattouw) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 70016 *** [07:52:23] 3VisualEditor / 3Editing Tools: VisualEditor: Shrink back the Basic Reference dialog size - 10https://bugzilla.wikimedia.org/70016#c7 (10Roan Kattouw) *** Bug 70601 has been marked as a duplicate of this bug. *** [07:57:53] 3VisualEditor: VisualEditor mistakes the first sentence of an article as part of the template - 10https://bugzilla.wikimedia.org/67554#c1 (10Roan Kattouw) I have observed this kind of behavior pretty frequently. It appears that if a template outputs a newline at the end (which is common, and easy to do by acci... [08:12:08] 3VisualEditor / 3Editing Tools: VisualEditor:When the cursor is in the middle of a text the formatting (Bold/Italic/No format) does not work properly - 10https://bugzilla.wikimedia.org/57554#c2 (10Roan Kattouw) 5NEW>3RESO/INV That's supposed to do nothing initially, then when you start typing, the text y... [10:52:20] (03CR) 10Mvolz: "Re: this bit, "It allowing all three variations seems odd. Especially the third one since that implies there can be a grouping of sorts, w" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167389 (owner: 10Mvolz) [12:41:53] 3VisualEditor: VisualEditor: Copy/pasting causes and tags to appear - 10https://bugzilla.wikimedia.org/68928#c2 (10Elitre) Looking at this again, I believe VE used to add those nowiki tags to prevent the line being displayed differently from the others because of the space at its beginning; and V... [12:55:08] 3VisualEditor: VisualEditor: opening square brackets can sometimes disappear - 10https://bugzilla.wikimedia.org/57207#c11 (10Elitre) Happening again. In https://fr.wikipedia.org/w/index.php?title=Utilisateur:Elitre_(WMF)/Prove2&oldid=108482122 I tried to start a new line precisely under the first one (the one... [12:59:47] (03PS5) 10Mvolz: Implement new "maps" property in Root [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167389 [13:08:13] 3VisualEditor: VisualEditor: Wikitext warning not showing up anymore? - 10https://bugzilla.wikimedia.org/72475 (10Elitre) 3NEW p:3Unprio s:3normal a:3None I don't seem to be able to trigger the warning with anything on any production wiki today. [13:10:09] 3VisualEditor: VisualEditor: opening square brackets can sometimes disappear - 10https://bugzilla.wikimedia.org/57207#c12 (10Elitre) Also happening at https://test.wikipedia.org/w/index.php?title=User:Elitre_(WMF)/Sandbox&oldid=203117 when trying to add a new point under "simpler". [13:17:23] 3VisualEditor / 3MediaWiki integration: At nowiki the nowiki-tag shows up in some edits done with VisualEditor - 10https://bugzilla.wikimedia.org/72442#c1 (10Elitre) Allow me to underline the irony of a nowiki at no.wiki :D I don't think the first case is related to that bug - that simply looks like wikicod... [13:17:31] (03CR) 10Mvolz: "Specification.md:" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167389 (owner: 10Mvolz) [13:18:07] (03CR) 10Mvolz: "Random comments:" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167389 (owner: 10Mvolz) [13:28:17] (03PS2) 10Mvolz: Methods for new "maps" property in TD Root [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167772 [13:37:09] 3MediaWiki / 3Page editing: Separate edit summaries when adding comments to a page - 10https://bugzilla.wikimedia.org/8341#c3 (10PRO) The new section header field is still the same as the edit summary field as described. What is there not to understand? You can also simple prove them in the HTML-source as th... [13:45:08] 3MediaWiki / 3Page editing: Separate edit summaries when adding comments to a page - 10https://bugzilla.wikimedia.org/8341 (10Andre Klapper) [14:05:48] Hello. I see you guys finally started doing something about table editing, but so far it seems this is only in master/REL_1.24 branches? Will it ever reach 1.23 branch? [15:21:23] 3VisualEditor / 3Editing Tools: VisualEditor:[Regression wmf5] Unable to apply Link and language annotations to images. - 10https://bugzilla.wikimedia.org/72431#c1 (10Ritu Swain) Now reproducible in test2. 1> insert a media with no captions.Highlight the image and select to apply link or language. 2> Link o... [15:25:40] 3VisualEditor: Adding items to lists sometimes generates spurious line feeds - 10https://bugzilla.wikimedia.org/72479 (10Spinningspark) 3NEW p:3Unprio s:3enhanc a:3None Intention: Add an item to a bibliographic list Actual Results: Line feeds are added, before, or after, the item, or both. Sorry,... [15:34:26] 3VisualEditor: Work around IE's caching of errors? - 10https://bugzilla.wikimedia.org/72480 (10Mark A. Hershberger) 3NEW p:3Unprio s:3normal a:3None IE 11 seems to cache faulty parsoid responses. I had a misconfigured server and, even after I fixed the problem and other browsers were able to continue... [15:37:09] 3VisualEditor / 3ContentEditable: VisualEditor: Thai Wikipedia's coordinates template displays badly in tables - 10https://bugzilla.wikimedia.org/52653#c1 (10James Forrester) 5NEW>3RESO/FIX p:5Unprio>3Normal a:3Ed Sanders Not sure when, but this is now fixed, probably because of Ed's work on templa... [16:10:55] 3VisualEditor: VisualEditor: Wikitext warning not showing up anymore? - 10https://bugzilla.wikimedia.org/72475 (10Alex Monk) 5NEW>3ASSI a:3Alex Monk [16:15:38] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression] Wikitext warning not showing up anymore? - 10https://bugzilla.wikimedia.org/72475 (10James Forrester) p:5Unprio>3High [16:18:24] (03PS1) 10Alex Monk: Fix wikitext warning: Get range from selection before trying to find start [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168608 (https://bugzilla.wikimedia.org/72475) [16:19:05] (03CR) 10Alex Monk: "See bug 72475" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163873 (owner: 10Esanders) [16:19:35] (03CR) 10Jforrester: [C: 031] Fix wikitext warning: Get range from selection before trying to find start [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168608 (https://bugzilla.wikimedia.org/72475) (owner: 10Alex Monk) [16:30:42] Corruption alert: visualeditor-needcheck on nowiki: https://no.wikipedia.org/?diff=13474857 [16:30:42] Corruption alert: visualeditor-needcheck on nowiki: https://no.wikipedia.org/?diff=13474874 [16:30:42] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=33067123 [16:30:42] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=33067241 [16:30:42] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=66400016 [16:30:43] Corruption alert: visualeditor-needcheck on plwiki: https://pl.wikipedia.org/?diff=40778107 [16:30:43] Corruption alert: visualeditor-needcheck on enwiki: https://en.wikipedia.org/?diff=630885186 [17:12:37] (03PS9) 10Divec: Make setSelection emit activeAnnotationChange if continuation unicorns may be needed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168327 (https://bugzilla.wikimedia.org/72108) [17:13:48] (03CR) 10jenkins-bot: [V: 04-1] Make setSelection emit activeAnnotationChange if continuation unicorns may be needed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168327 (https://bugzilla.wikimedia.org/72108) (owner: 10Divec) [17:26:22] (03CR) 10Catrope: [C: 032] Fix wikitext warning: Get range from selection before trying to find start [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168608 (https://bugzilla.wikimedia.org/72475) (owner: 10Alex Monk) [17:26:37] RoanKattouw: + cherry-pick? [17:26:45] Was about to ask [17:26:55] It's a wmf3 regression [17:27:23] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression wmf3] Wikitext warning not showing up anymore? - 10https://bugzilla.wikimedia.org/72475 (10Roan Kattouw) 5PATC>3RESO/FIX [17:27:33] So I was going to ask if you thought I should cherry-pick to wmf4&5 but I'll take that as a yes [17:27:37] Yeah, let's. [17:27:40] (03PS1) 10Catrope: Fix wikitext warning: Get range from selection before trying to find start [extensions/VisualEditor] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/168619 (https://bugzilla.wikimedia.org/72475) [17:27:45] (03Merged) 10jenkins-bot: Fix wikitext warning: Get range from selection before trying to find start [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168608 (https://bugzilla.wikimedia.org/72475) (owner: 10Alex Monk) [17:28:00] (03PS1) 10Catrope: Fix wikitext warning: Get range from selection before trying to find start [extensions/VisualEditor] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/168620 (https://bugzilla.wikimedia.org/72475) [17:29:15] James_F: Are you listing those for Monday's SWAT or should I? [17:29:50] RoanKattouw: Could you? [17:29:56] Will do [17:30:00] Also, "data data data" [17:30:11] Yes? [17:30:26] That's the name of a meeting you and I supposedly have right now [17:30:34] I said I would put time in your calendar. I'm not part of it. :-) [17:30:52] Right [17:30:55] 3VisualEditor / 3Mobile: VE: new links are displayed as normal text in Read view - 10https://bugzilla.wikimedia.org/72467#c2 (10Jon) 5NEW>3UNCO Red links are purposely disabled on mobile in view mode so I doubt there is an issue here in VE. [17:30:57] And I'm supposed to... review your schema, right? [17:31:34] Yeah, and maybe kick the tyres on implementing a couple of bits of it as a WIP [17:43:23] 3VisualEditor / 3Mobile: VE: new links are displayed as normal text in Read view - 10https://bugzilla.wikimedia.org/72467#c3 (10James Forrester) 5UNCO>3RESO/DUP Yeah, merging this into bug 69849. *** This bug has been marked as a duplicate of bug 69849 *** [17:43:36] James_F:There's some inconsistent naming here and there. There's a nochange and a nochanges, there's switchwith (all lowercase) but abandonMidsave (semi-camelcase) but navigate-back (hyphenated) [17:43:45] I just edited it to fix some typos but apart from that it looks fine [17:43:58] I will have to find out how the sessionid thing works, I think there might be a utility for that somewhere [17:47:07] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression wmf3] Wikitext warning not showing up anymore? - 10https://bugzilla.wikimedia.org/72475 (10Alex Monk) 5PATC>3RESO/FIX [17:49:03] RoanKattouw: halfak is suggesting that 0NF is the wrong approach. [18:41:22] 3VisualEditor / 3ContentEditable: VisualEditor: [Regression] Can't cut or (sometimes) paste in Firefox - 10https://bugzilla.wikimedia.org/72164#c7 (10WhatamIdoing) In case this needs to be re-opened in the futre: I can't cut text in Safari today. I'm going to assume that this is fixed in the next release... [18:43:09] 3OOjs UI: OOjs UI: Selected text in readonly/disabled TextInputWidget is hard to read on Chrome on Linux - 10https://bugzilla.wikimedia.org/63840#c4 (10Roan Kattouw) a:3Sucheta Ghoshal So I had a chat with Trevor and we decided that the text shadow should be removed for readonly TextInputWidgets (like the ex... [18:46:38] 3VisualEditor / 3Editing Tools: VisualEditor: Improvements and behaviour changes to the link input widget (tracking) - 10https://bugzilla.wikimedia.org/48789 (10Roan Kattouw) [18:46:38] 3VisualEditor / 3ContentEditable: VisualEditor: Internal links should display the page's URL in the status bar on the browsers that do that - 10https://bugzilla.wikimedia.org/50646 (10Roan Kattouw) [19:52:31] Does a VE rollout require community consensus or just a bug? [20:11:55] 3VisualEditor: Snowman (☃) added to article - 10https://bugzilla.wikimedia.org/72491 (10Helder) 3NEW p:3Unprio s:3normal a:3None https://pt.wikipedia.org/w/index.php?title=Par%C3%A1bola&diff=40360024 [20:12:24] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf6] "TypeError: Cannot read property 'isDefault' of undefined" appears when Media Settings dialog appears while adding a new image - 10https://bugzilla.wikimedia.org/72492 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Created atta... [20:12:52] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf6] "TypeError: Cannot read property 'isDefault' of undefined" appears when Media Settings dialog appears while adding a new image - 10https://bugzilla.wikimedia.org/72492 (10Rummana Yasmeen) [20:13:38] * mooey|food shoots Chrome [20:14:18] oh.. bah [20:20:12] (03PS1) 10Mooeypoo: Make sure initialHash exists before checking its value [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168675 (https://bugzilla.wikimedia.org/72492) [20:44:30] (03PS1) 10Bartosz Dziewoński: Fix a number of documentation issues throughout the codebase [oojs/ui] - 10https://gerrit.wikimedia.org/r/168693 [20:47:28] (03CR) 10jenkins-bot: [V: 04-1] Fix a number of documentation issues throughout the codebase [oojs/ui] - 10https://gerrit.wikimedia.org/r/168693 (owner: 10Bartosz Dziewoński) [20:49:10] 3VisualEditor / 3Editing Tools: VisualEditor: Clicking on somewhere else in the document after opening a link inspector inside a slug throws error "TypeError: Cannot read property 'previousSibling' of undefined" - 10https://bugzilla.wikimedia.org/72494 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3N... [20:50:36] (03PS2) 10Bartosz Dziewoński: Fix a number of documentation issues throughout the codebase [oojs/ui] - 10https://gerrit.wikimedia.org/r/168693 [21:06:41] 3VisualEditor / 3Editing Tools: VisualEditor:Link inspector opens with an animation from top while trying to open it for the first time in an edit session - 10https://bugzilla.wikimedia.org/72495 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 16891 --> https://bugzilla.wiki... [21:10:27] RoanKattouw, I feel like I should apologize for this, but it's just one more example for the smess. https://gerrit.wikimedia.org/r/#/c/168675/ [21:10:47] Yeah just looking at it now [21:11:11] So wait, initialHash will be {} rather than undefined for a new image? [21:11:13] What's going on there? [21:20:54] ( mooeypoo --^^ ) [21:33:41] (03CR) 10Catrope: ContentEditable implementation for tables (0314 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159311 (owner: 10Oliverb) [21:33:50] (03CR) 10Catrope: [C: 04-1] "Comments on PS40" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159311 (owner: 10Oliverb) [21:41:08] 3VisualEditor / 3ContentEditable: VisualEditor: Inserted images overlap preformatted text box - 10https://bugzilla.wikimedia.org/72411#c1 (10etonkovidova) Created attachment 16892 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16892&action=edit desktop - image overlap preformatted area Added attachm... [22:08:59] wooooooo neverending event loop [22:10:12] I think it's the first time I've created such an impressive event loop in chrome, that I get a nondescript in the console. [22:10:20] Personal record. [22:10:22] wow [22:10:26] Chrome usually knows what's up [22:10:37] I have managed to get browsers into infinite loops before [22:11:09] But if I was lucky they'd eventually end with Error: Maximum call stack size exceeded or Error: Too much recursion or something sensible [22:11:18] Well, when you open it up you can see a 5-page-long repeating "oo.EventEmitter.emit / something something / oo.EentEmitter.emit / something something / ..." in the stack [22:11:23] lol [22:11:26] Very loopy [22:12:34] * marktraceur rimshots [22:12:38] haha [22:12:40] I missed that [22:12:51] :D [22:14:22] RoanKattouw, http://oi62.tinypic.com/rh781j.jpg [22:14:30] (it keeps going, too) [22:14:54] Ah yes [22:15:05] Presumably it's oscillating between two values? [22:15:08] I find it amusing I also managed to *break* ooui's protection against this [22:15:11] 3VisualEditor / 3Editing Tools: VE: Failed to parse(lexing error) when pasting special character into formula - 10https://bugzilla.wikimedia.org/72499 (10etonkovidova) 3NEW p:3Unprio s:3normal a:3None Created attachment 16896 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16896&action=edit Le... [22:15:14] no, it's better! [22:15:16] Because OO.ui.InputWidget.setValue knows better [22:15:30] Indeed, it should, but see, I am sending it an object. (oops) [22:15:38] wat [22:15:39] I suspect at least [22:15:57] Oh so even if they're all hash-identical, none of them will be reference-identical [22:16:04] yes [22:16:18] And also in hte input it appears as [Object object] [22:16:26] Also if this loop were to ever finish you would presumably see ... yeah that [22:16:36] so even if it's stringified, the next check is not catching it [22:17:03] Maaybe OOUI should be casting the value to a string [22:17:05] setValue could probably use a defensive "$.type( value ) === string " [22:17:14] or that [22:17:22] either verify it's a string, or cast it [22:17:25] probably casting is better. [22:17:42] But I also need to make sure I don't update a text input with an Object. [22:17:47] :P [22:41:43] oh I found out what it is, but now Chrome is so stuck, it won't even shut down. [22:42:10] How bad is it that I am actually kind of proud of myself? [22:44:36] mooeypoo: you have a bright future in QA :-) [22:44:43] :D [22:53:22] [14:10] RoanKattouw Yeah just looking at it now [22:53:24] [14:11] RoanKattouw So wait, initialHash will be {} rather than undefined for a new image? [22:53:25] [14:11] RoanKattouw What's going on there? [22:53:27] mooeypoo: ----^^ [22:53:29] re https://gerrit.wikimedia.org/r/#/c/168675/1/modules/ve-mw/dm/models/ve.dm.MWImageModel.js [22:53:53] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167389 (owner: 10Mvolz) [23:00:30] RoanKattouw, yes, mostly because ve.compare() couldn't really handle undefined very well [23:00:43] Oh right [23:00:47] I can change it into undefined, but the if() statement will still have to check -- either if it exists at all, or if it's not empty [23:00:58] I think the ve.compare() was fixed? not sure [23:01:51] If it wasn't, I created a method that compares my values that deals with undefined, empty, strings and arrays that might be good [23:02:36] omg I found out how I broke Chrome. ha [23:03:46] I keep going this.emit( 'myevent', [ multiple, stuff, here ] ) ; instead of this.emit( 'myevent', multiple, stuff, here ) ; --> so the value was an array, *but* it was translated by setValue to text and then shot back -- so I ended up having a string going "en" and then "en,en" and "en,en,en" ... "en,en,en,en" etc [23:03:59] HA [23:04:37] I know we're usually prefering to not go defensive, but should we maybe verify that setValue() is only given a string? [23:05:08] well, maybe not.. I can see how if you're doing it right, you'd want an array to be casted into a string. [23:14:22] (03PS1) 10Alex Monk: Allow removing all parts from a transclusion to remove the transclusion [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168721 (https://bugzilla.wikimedia.org/72191) [23:18:37] 3VisualEditor / 3Editing Tools: VisualEditor: Dialogs should disable "Apply changes" until a change is present - 10https://bugzilla.wikimedia.org/55976#c2 (10Alex Monk) No, I think this still applies to the places mentioned in the description (transclusions and references). [23:30:43] (03CR) 10Catrope: [C: 04-1] Actions and context menus for manipulating tables (0336 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb) [23:31:23] So, parent nodes get 'update' events before child nodes get them, correct? [23:31:29] Ahm [23:31:33] Really? [23:31:36] * RoanKattouw looks [23:31:38] I think so [23:31:49] even the childUpdate is emitted very early on [23:32:05] basically I won't to do something in a parent, after my children are finished updating [23:32:21] I want! not won't! [23:32:29] Yeah I feel like the order should be that way around, not the way it currently is [23:33:26] But I'm reluctant to change that for obvious reasons [23:35:40] InezK: If you want to play with this: change the order of operations in ve.dm.Node#setLength [23:35:59] As you can see it adjusts the parent's length (which emits events on the parent) before emitting its own events [23:36:06] You could experiment with swapping those tow [23:48:05] (03CR) 10Catrope: [C: 04-1] Support annotation tool on table selections (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166774 (owner: 10Esanders)