[00:01:52] 3OOjs UI: OOUI PHP: No simple way to add HTML-escaped text to a Element - 10https://bugzilla.wikimedia.org/72542#c1 (10Bartosz Dziewoński) We currently have some bugs where JS and PHP escape things differently because of this. [00:17:17] bah [00:17:33] i just spent way too much time debugging why JS and PHP themes behave differently [00:17:41] turns out i was comparing different themes [00:17:47] go, me. [00:24:44] Ha [00:55:19] (03PS4) 10Bartosz Dziewoński: [WIP] Generate and run a JS/PHP comparison test suite [oojs/ui] - 10https://gerrit.wikimedia.org/r/168910 [00:55:21] (03PS1) 10Bartosz Dziewoński: ButtonInputWidget: Treat 'readOnly' is 'disabled' [oojs/ui] - 10https://gerrit.wikimedia.org/r/168920 [00:55:31] whoo, most of these tests actually pass now. [00:57:20] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Generate and run a JS/PHP comparison test suite [oojs/ui] - 10https://gerrit.wikimedia.org/r/168910 (owner: 10Bartosz Dziewoński) [01:42:09] 3VisualEditor / 3MediaWiki integration: At nowiki the nowiki-tag shows up in some edits done with VisualEditor - 10https://bugzilla.wikimedia.org/72442#c2 (10jeblad) This should perhaps be a feature request as it seems to be about additional warning messages. [03:23:50] (03CR) 10Catrope: [C: 032] Make sure initialHash exists before checking its value [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168675 (https://bugzilla.wikimedia.org/72492) (owner: 10Mooeypoo) [03:25:11] (03Merged) 10jenkins-bot: Make sure initialHash exists before checking its value [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168675 (https://bugzilla.wikimedia.org/72492) (owner: 10Mooeypoo) [03:32:51] (03PS1) 10Alex Monk: Move autoValue logic from ui.MWParameterPage to dm.MWParameterModel [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168926 (https://bugzilla.wikimedia.org/72404) [05:45:23] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 (owner: 10Mooeypoo) [09:41:07] 3VisualEditor: Math code turned into snowmen symbols (☃) - 10https://bugzilla.wikimedia.org/72491#c1 (10Elitre) I sent a note to the editor to see if we can get steps to reproduce. I re-labelled this bug according to what I /think/ was the issue there. [11:19:46] (03CR) 10Esanders: Actions and context menus for manipulating tables (0336 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb) [11:20:43] (03Abandoned) 10Esanders: Provisional fix to prevent structural changes to a table via delete+merge [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159317 (owner: 10Oliverb) [11:22:44] (03CR) 10Esanders: Support annotation tool on table selections (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166774 (owner: 10Esanders) [11:23:52] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression] Link inspector closes itself immediately in IE11 - 10https://bugzilla.wikimedia.org/72392#c1 (10Elitre) Affecting IE10 as well, as per fi.wp report. [11:29:49] (03CR) 10Esanders: Table header/data format tools (034 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168060 (owner: 10Esanders) [12:06:41] (03PS4) 10Esanders: Table header/data format tools [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168060 [12:06:43] (03PS42) 10Esanders: ContentEditable implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159311 (owner: 10Oliverb) [12:06:45] (03PS12) 10Esanders: Merge cells tool [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167631 [12:06:47] (03PS11) 10Esanders: Supporting copy paste of single table cells [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167559 [12:06:49] (03PS18) 10Esanders: Support annotation tool on table selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166774 [12:06:51] (03PS48) 10Esanders: Actions and context menus for manipulating tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb) [12:16:19] (03PS1) 10Esanders: Use primary colours for progress bar [oojs/ui] - 10https://gerrit.wikimedia.org/r/168951 [12:31:33] (03CR) 10Esanders: [C: 04-1] [WIP] Use TempateData to insert citations (0316 comments) [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/168746 (owner: 10Mvolz) [13:00:20] (03PS5) 10Esanders: Table header/data format tools [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168060 [13:00:22] (03PS13) 10Esanders: Merge cells tool [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167631 [14:21:09] 3VisualEditor / 3Data Model: VisualEditor:[Regression wmf5] “Uncaught Error: offset -1 out of bounds” when adding bullet/numbered list with link inspector open. - 10https://bugzilla.wikimedia.org/72558 (10Ritu Swain) 3UNCO p:3Unprio s:3normal a:3None Created attachment 16907 --> https://bugzilla.wi... [14:21:24] 3VisualEditor / 3Data Model: VisualEditor:[Regression wmf5] “Uncaught Error: offset -1 out of bounds” when adding bullet/numbered list with link inspector open. - 10https://bugzilla.wikimedia.org/72558 (10Ritu Swain) [14:26:07] (03PS6) 10Esanders: Table header/data format tools [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168060 [14:26:09] (03PS14) 10Esanders: Merge cells tool [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167631 [14:26:12] (03PS12) 10Esanders: Supporting copy paste of single table cells [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167559 [14:26:14] (03PS19) 10Esanders: Support annotation tool on table selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166774 [14:26:15] (03PS1) 10Esanders: Allow custom (html)attributes when creating a table [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168960 [14:27:36] (03PS4) 10Esanders: Files and messages for table editing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167189 [14:27:38] (03PS1) 10Esanders: Create tables with class=wikitable by default [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168961 [14:28:48] (03CR) 10jenkins-bot: [V: 04-1] Files and messages for table editing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167189 (owner: 10Esanders) [14:29:42] (03CR) 10jenkins-bot: [V: 04-1] Create tables with class=wikitable by default [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168961 (owner: 10Esanders) [14:50:40] 3VisualEditor / 3Editing Tools: VisualEditor:[Regression wmf5]White spaces are not preserved in whitespaces only comments. - 10https://bugzilla.wikimedia.org/72561 (10Ritu Swain) 3UNCO p:3Unprio s:3normal a:3None Created attachment 16908 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16908&ac... [14:50:52] 3VisualEditor / 3Editing Tools: VisualEditor:[Regression wmf5]White spaces are not preserved in whitespaces only comments. - 10https://bugzilla.wikimedia.org/72561 (10Ritu Swain) [15:15:40] 3VisualEditor / 3Editing Tools: VisualEditor:[Regression wmf5] Inserting a Link target after a text,instead gets added in between the typed text. - 10https://bugzilla.wikimedia.org/72562 (10Ritu Swain) 3UNCO p:3Unprio s:3normal a:3None Environment- beta, test2,production 1>In a blank page in VE,type... [15:17:52] 3VisualEditor / 3Editing Tools: VisualEditor:[Regression wmf5] Inserting a Link target after a text,instead gets added in between the typed text. - 10https://bugzilla.wikimedia.org/72562#c1 (10Ritu Swain) http://youtu.be/RwVvvlI9rcI [15:54:56] (03CR) 10Jforrester: [C: 04-1] Allow custom (html)attributes when creating a table (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168960 (owner: 10Esanders) [16:16:22] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168060 (owner: 10Esanders) [16:18:03] (03CR) 10Siebrand: "i18n/L10n reviewed." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167631 (owner: 10Esanders) [16:21:56] (03PS2) 10Esanders: Create tables with class=wikitable by default [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168961 [16:21:58] (03PS5) 10Esanders: Files and messages for table editing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167189 [16:22:00] (03PS1) 10Esanders: Fix selection check in wikitext warning [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168982 [16:23:09] (03CR) 10jenkins-bot: [V: 04-1] Create tables with class=wikitable by default [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168961 (owner: 10Esanders) [16:23:13] (03CR) 10jenkins-bot: [V: 04-1] Files and messages for table editing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167189 (owner: 10Esanders) [16:30:52] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=108564645 [16:30:52] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=108564841 [16:30:52] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=66449181 [16:30:52] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=66454893 [16:30:53] Corruption alert: visualeditor-needcheck on plwiki: https://pl.wikipedia.org/?diff=40815385 [16:30:53] Corruption alert: visualeditor-needcheck on itwiki: https://it.wikipedia.org/?diff=68859071 [16:31:10] (03PS7) 10Esanders: Table header/data format tools [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168060 [16:31:12] (03PS2) 10Esanders: Allow custom (html)attributes when creating a table [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168960 [16:31:14] (03PS43) 10Esanders: ContentEditable implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159311 (owner: 10Oliverb) [16:31:16] (03PS15) 10Esanders: Merge cells tool [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167631 [16:31:18] (03PS13) 10Esanders: Supporting copy paste of single table cells [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167559 [16:31:20] (03PS20) 10Esanders: Support annotation tool on table selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166774 [16:31:22] (03PS49) 10Esanders: Actions and context menus for manipulating tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb) [16:38:09] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf6] "TypeError: Cannot read property 'isDefault' of undefined" appears when Media Settings dialog appears while adding a new image - 10https://bugzilla.wikimedia.org/72492 (10James Forrester) 5PATC>3RESO/FIX p:5Unprio>3Normal a:3Moriel... [16:42:23] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression] Link inspector closes itself immediately in Internet Explorer - 10https://bugzilla.wikimedia.org/72392 (10James Forrester) [16:42:41] (03CR) 10Jforrester: [C: 032] Remove mw-specific message [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168355 (owner: 10Esanders) [16:44:34] (03Merged) 10jenkins-bot: Remove mw-specific message [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168355 (owner: 10Esanders) [16:45:21] (03CR) 10Jforrester: [C: 032] Fix a number of documentation syntax issues throughout the codebase [oojs/ui] - 10https://gerrit.wikimedia.org/r/168693 (https://bugzilla.wikimedia.org/72455) (owner: 10Bartosz Dziewoński) [16:47:25] (03Merged) 10jenkins-bot: Fix a number of documentation syntax issues throughout the codebase [oojs/ui] - 10https://gerrit.wikimedia.org/r/168693 (https://bugzilla.wikimedia.org/72455) (owner: 10Bartosz Dziewoński) [16:56:15] (03PS2) 10Bartosz Dziewoński: ButtonInputWidget: Treat 'readOnly' as 'disabled' [oojs/ui] - 10https://gerrit.wikimedia.org/r/168920 [17:15:11] 3OOjs UI: OOUI PHP: No simple way to add HTML-escaped text to a Element - 10https://bugzilla.wikimedia.org/72542 (10Bartosz Dziewoński) 5NEW>3ASSI a:3Bartosz Dziewoński [17:25:20] RoanKattouw_away: ping [17:25:21] :) [17:32:36] (03PS1) 10Catrope: Prevent observeration during copy and paste [VisualEditor/VisualEditor] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/169003 [17:32:53] (03CR) 10Catrope: [C: 032 V: 032] Prevent observeration during copy and paste [VisualEditor/VisualEditor] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/169003 (owner: 10Catrope) [17:33:36] (03PS1) 10Catrope: Update VE core for cherry-pick of I2b368b0d0 [extensions/VisualEditor] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/169004 [17:35:30] RoanKattouw_away, when you get a couple of minutes, I need help. I'm stumped. The problem is this: I read the templatedata string into my data model on dialog load. Then I store the *original* object (the one right off of $.parseJSON) and then duplicate some of it (with $.extend( true, {}, original) ) to the model I work with. But the model I work with has a *slightly* differen structure, it uses language objects. Thin [17:35:30] g is -- by the time I click "apply" I need to compare original to model, and my *original* is changed [17:35:38] And for the life of me I can't figure out how or why [17:36:24] (03CR) 10Catrope: [C: 032] Fix selection check in wikitext warning [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168982 (owner: 10Esanders) [17:36:30] The duplication should mean that all my changes happen on a new object, not touching the original, and yet here it is, changed. [17:37:42] (03Merged) 10jenkins-bot: Fix selection check in wikitext warning [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168982 (owner: 10Esanders) [17:39:55] * mooeypoo shakes fist at the templatedata model [17:40:05] It's just mocking me now. [17:40:17] mvolz: Sorry, was distracted, I blame James. I'm here now [17:40:37] mvolz: You said in your email: "And then of course after all that we need to add "search" functionality to both citoid and the VE front-end... i.e. expand beyond URLs... lots to do there. " [17:40:50] mvolz: What did you mean by that exactly? I think I have a rough idea but I'm not quite up to speed on that [17:41:36] mooeypoo: Yeah $.extend( true, {}, original ) should deep-clone it I believe [17:41:41] Yes. [17:41:44] It should. [17:41:57] So either I'm changing the original somewhere, or it's just mocking me. [17:42:19] So, one thing you could try is clone = $.extend( true, {}, original ); then clone.some.deep.property = 123; and see if original.some.deep.property changed [17:42:37] If it did then maybe $.extend doesn't work the way we think you did, and you might want oo.copy or whatever it's called [17:43:33] RoanKattouw, (this isn't urgent, work with mvolz before she goes to sleep, but I'm putting it up for your reading later when you get time) -- The model *always* has language objects. So { params: blah: description: en: "some description" } while the original templatedata may only have "somedescription" without the "en" lang. In order for the model to know if it should output WITH language or without, it must compare to [17:43:33] the initial object. And that's poopoo'ed. [17:43:42] oh there's oo.copy! [17:43:50] I knew ve.copy... I forgot about oo.copy [17:44:47] btw, RoanKattouw, I also changed the mergeSimpleUnion method in my code to ignore empty strings. I did that so it works directly for me, but we might want to add that fix to oojs directly too [17:45:48] mooeypoo: Re simpleUnion, yeah please submit a patch to oojs [17:46:55] RoanKattouw, should we completely ignore empty strings (I do in mine) or make sure we only add them once if we do? [17:47:05] RoanKattouw: so right now, one URL, one citation [17:47:10] I think Union allows for empty? [17:47:23] but potentially a URL could have multiple citations [17:47:37] for instance, you could have a page of google books search results [17:47:41] that have multiple books [17:47:47] or they could search for the title of a work [17:48:01] and of course there you can't guarantee only one citation returning for each title search [17:48:38] Right [17:48:59] RoanKattouw: https://groups.google.com/a/wikimedia.org/forum/#!managemembers/editing-team/add [17:48:59] so basically: add the ability to put multiple things in the field [17:49:10] and add the ability to have multiple things returned [17:49:55] OK, so [17:49:57] Hmm. Interesting. [17:50:02] Is that frequent? [17:50:08] I don't have kaity's designs on hand, she was gonna put them up on mw.org [17:50:15] But IIRC they seem to assume one citation -> one URL [17:50:47] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb) [17:51:13] Now this is something we should do at the end, (James mumbled "MVP"), but ideally the design wouldn't preclude it :| [17:51:24] (03CR) 10Siebrand: "i18n/L10n reviewed." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167631 (owner: 10Esanders) [17:51:47] RoanKattouw, I think you wanted to speak to me after I suggested I was going to look into doing https://bugzilla.wikimedia.org/show_bug.cgi?id=52792 ? [17:51:55] mvolz: James_F I think we talked about only showing the first result even if the search finds multiple results [17:51:56] or was it something else? [17:52:16] so for URL or DOI or PMID that works pretty well [17:52:30] for titles not so much. [17:52:40] except in the case maybe of journal articles [17:52:46] those are pretty unique. [17:52:49] mvolz: what happens currently? [17:52:53] nothing! [17:52:57] we only allow URLs [17:53:04] mvolz: haha oh I see [17:53:07] and if there's a list of results, we do take the first one [17:53:12] but that almost never happens [17:53:30] because in google books, theoretically it takes search results pages, but actually it dies, lol [17:53:38] which is the only case where that really happens :) [17:53:41] mvolz: how will titles work? what database is it searching? [17:53:51] OCLC hypothetically [17:54:25] oh thats a library database? [17:54:27] or at least that's the easiest way to do it, since they perform the actual search for you [17:54:29] yeah [17:54:36] but we actually have to get some sort of contract withthem [17:54:40] which mwalker was working on [17:54:50] and I don't have an NDA so I can't work with legal [17:54:55] although maybe I could get one. [17:55:08] so since mwalker left, it hasn't gone anywhere. [17:55:37] mvolz: Right now I'd like us to avoid using privileged APIs as much as possible. [17:55:47] Krenair: OK so looking at that bug, I think that might actually be feasible with our current internalList infrastructure (ask edsanders for details). I was checking to see if it was something that's best deferred until my subdocument idea turns into actual code to replace internalList [17:55:55] But it looks like this can probably go ahead without tha [17:57:07] is OCLC just for books? [17:57:53] mvolz, you need an NDA to work with legal...? [17:57:58] James_F: so... technically Zotero uses OCLC as well [17:58:03] but with no agreement [17:58:13] which is weird? but I guess the way they use it doesn't violate ToS [17:58:23] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression] Adding category sort keys no longer working - 10https://bugzilla.wikimedia.org/72168#c5 (10etonkovidova) Verified in betalabs, test2, and wikimedia - e.g. a Category gets added as [[Category:Cat2|Sort_added]] [17:58:37] Krenair: I dunno, that's just what mwalker said, could be a myth :) [17:59:16] mvolz: Yeah, that's OK. [17:59:35] mvolz: But contracts have a way of turning toxic, and are fundamentally uncool (re-use limited). [17:59:41] (03PS2) 10Mvolz: [WIP] Use TempateData to insert citations [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/168746 [17:59:58] RoanKattouw: https://phabricator.wikimedia.org/diffusion/VE/ [17:59:58] James_F: I fundementally agree with you [18:00:07] Zotero had a problem with using Amazon's API [18:01:45] Ouch. [18:03:51] so I sign in with ldap then it asks me to verify my email address!? [18:06:24] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf6] "TypeError: Cannot read property 'isDefault' of undefined" appears when Media Settings dialog appears while adding a new image - 10https://bugzilla.wikimedia.org/72492#c3 (10Rummana Yasmeen) Verified the fix in Betalabs [18:06:35] edsanders: Yes. [18:07:02] edsanders: It doesn't trust MW because I don't think it can be set to trust an LDAP source implicitly. [18:07:44] do we store whether the email was verified or not in ldap? [18:08:26] I'm pretty sure there's no such thing as an LDAP account with a non-verified email [18:08:34] Although... hmm [18:08:40] LDAP is in more places than I realize so maybe that's not true [18:11:09] 3VisualEditor / 3Data Model: VisualEditor:[Regression] “Uncaught Error: offset -1 out of bounds” when adding bullet/numbered list with link inspector open. - 10https://bugzilla.wikimedia.org/72558 (10Rummana Yasmeen) [18:11:38] 3VisualEditor / 3Editing Tools: VisualEditor: Clicking on somewhere else in the document after opening a link inspector inside a slug throws error "TypeError: Cannot read property 'previousSibling' of undefined" - 10https://bugzilla.wikimedia.org/72494 (10Rummana Yasmeen) [18:11:38] 3VisualEditor / 3Data Model: VisualEditor:[Regression] “Uncaught Error: offset -1 out of bounds” when adding bullet/numbered list with link inspector open. - 10https://bugzilla.wikimedia.org/72558 (10Rummana Yasmeen) [18:11:52] (03CR) 10Catrope: [C: 032] Allow removing all parts from a transclusion to remove the transclusion [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168721 (https://bugzilla.wikimedia.org/72191) (owner: 10Alex Monk) [18:13:10] (03Merged) 10jenkins-bot: Allow removing all parts from a transclusion to remove the transclusion [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168721 (https://bugzilla.wikimedia.org/72191) (owner: 10Alex Monk) [18:13:53] (03CR) 10Catrope: [C: 032] Move autoValue logic from ui.MWParameterPage to dm.MWParameterModel [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168926 (https://bugzilla.wikimedia.org/72404) (owner: 10Alex Monk) [18:14:07] 3OOjs UI: OOUI PHP: No simple way to add HTML-escaped text to a Element - 10https://bugzilla.wikimedia.org/72542 (10James Forrester) p:5Unprio>3High [18:14:53] 3VisualEditor / 3MediaWiki integration: VisualEditor: It's not possible to "Apply changes" from the transclusion dialog after it has been emptied - 10https://bugzilla.wikimedia.org/72191 (10James Forrester) 5PATC>3RESO/FIX [18:15:09] (03Merged) 10jenkins-bot: Move autoValue logic from ui.MWParameterPage to dm.MWParameterModel [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168926 (https://bugzilla.wikimedia.org/72404) (owner: 10Alex Monk) [18:15:35] (03CR) 10Trevor Parscal: [C: 032] Use primary colours for progress bar [oojs/ui] - 10https://gerrit.wikimedia.org/r/168951 (owner: 10Esanders) [18:17:49] (03Merged) 10jenkins-bot: Use primary colours for progress bar [oojs/ui] - 10https://gerrit.wikimedia.org/r/168951 (owner: 10Esanders) [18:17:54] 3VisualEditor / 3Technical Debt: VisualEditor: Move default value and autoValue code from MWParameterPage (UI) to MWParameterModel (DM) - 10https://bugzilla.wikimedia.org/72404 (10James Forrester) 5PATC>3RESO/FIX [18:18:39] Krenair: Could you review https://gerrit.wikimedia.org/r/#/c/168205/1 ? [18:19:39] (03CR) 10Trevor Parscal: "Shouldn't we just be moving the readOnly to TextInputWidget? Perhaps a new class that sits between InputWidget and TextInputWidget called " [oojs/ui] - 10https://gerrit.wikimedia.org/r/168920 (owner: 10Bartosz Dziewoński) [18:19:58] (03CR) 10Catrope: [C: 04-1] Disable parameter add icon when there's no transclusion parts (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168379 (https://bugzilla.wikimedia.org/63158) (owner: 10Alex Monk) [18:20:09] (03CR) 10Esanders: [C: 04-1] "Should the definitions go the in the "// Theme variables" sections of respective common.less files." [oojs/ui] - 10https://gerrit.wikimedia.org/r/164389 (owner: 10Jforrester) [18:20:42] (03CR) 10Jforrester: "I don't know, should they?" [oojs/ui] - 10https://gerrit.wikimedia.org/r/164389 (owner: 10Jforrester) [18:22:30] RoanKattouw, looking.. [18:25:59] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Indeed, only text input can be made readonly. I was under the impression that it applied to other inputs as well, but it apparently doesn'" [oojs/ui] - 10https://gerrit.wikimedia.org/r/168920 (owner: 10Bartosz Dziewoński) [18:29:34] urgh, why does the bug's case for this include wikipedia templates? [18:30:31] Krenair: Because complexity. [18:31:45] (03CR) 10Esanders: "If you rebase you'll see there are colours in widgets.less for the progress bar which could re-use these, so I'd suggest yes." [oojs/ui] - 10https://gerrit.wikimedia.org/r/164389 (owner: 10Jforrester) [18:32:10] edsanders: Aha, new code. Yay. [18:32:18] (03CR) 10Catrope: ContentEditable implementation for tables (033 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159311 (owner: 10Oliverb) [18:32:24] edsanders: Unfortunately we've been waiting for a few weeks for Prateek to review. [18:32:33] why? [18:32:55] (in general we may want to use defined colours anywhere: tools, dialogs etc.) [18:33:40] edsanders: Because TrevorP|Away wanted him to take ownership of this. [18:35:13] (03CR) 10Catrope: [C: 031] "Looks fine, holding this until the entire stack is ready to merge at once. (Wednesday after the wmf6 cut, at the earliest.)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159311 (owner: 10Oliverb) [18:36:08] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression wmf3] External links in templates are rendered as red links now - 10https://bugzilla.wikimedia.org/72251#c4 (10etonkovidova) Verified in test2 and betalabs(with 'Cite web' template). [18:37:28] (03CR) 10Alex Monk: [C: 032] Apply pre-save transform to template previews [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168205 (https://bugzilla.wikimedia.org/71157) (owner: 10Catrope) [18:37:45] James_F: product review requested for https://gerrit.wikimedia.org/r/#/c/168835/2 , aka how mad you're at me for writing the thing in Ruby ;) [18:38:43] (03Merged) 10jenkins-bot: Apply pre-save transform to template previews [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168205 (https://bugzilla.wikimedia.org/71157) (owner: 10Catrope) [18:39:02] MatmaRex: If it makes TrevorP|Away happy I don't care. :-) [18:39:22] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf1] Template parameter autovalues are not saved - 10https://bugzilla.wikimedia.org/71157 (10Alex Monk) [18:39:37] Krenair: Umm. [18:39:57] Krenair: That merge didn't change when the fix for the bug happened. [18:40:03] Krenair: It was wmf5 for a reason. :-) [18:40:22] Krenair: https://gerrit.wikimedia.org/r/#/c/168204/ fixed the bug, https://gerrit.wikimedia.org/r/168205 just made it a lot less ugly. [18:40:24] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf1] Template parameter autovalues are not saved - 10https://bugzilla.wikimedia.org/71157 (10Alex Monk) [18:40:29] ah :) [18:40:34] * James_F grins. [18:45:57] (03PS3) 10Bartosz Dziewoński: Move 'readOnly' from InputWidget to TextInputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/168920 [18:47:39] (03CR) 10Catrope: [C: 04-1] Actions and context menus for manipulating tables (034 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb) [18:49:25] (03PS4) 10Bartosz Dziewoński: Move 'readOnly' from InputWidget to TextInputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/168920 [18:49:27] (03CR) 10Catrope: [C: 031] Support annotation tool on table selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166774 (owner: 10Esanders) [18:50:07] (03CR) 10Esanders: Allow custom (html)attributes when creating a table (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168960 (owner: 10Esanders) [18:53:24] (03PS8) 10Esanders: Table header/data format tools [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168060 [18:53:26] (03PS3) 10Esanders: Allow custom (html)attributes when creating a table [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168960 [18:53:29] (03PS16) 10Esanders: Merge cells tool [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167631 [18:53:30] (03PS14) 10Esanders: Supporting copy paste of single table cells [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167559 [18:53:32] (03PS21) 10Esanders: Support annotation tool on table selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166774 [18:53:50] (03CR) 10jenkins-bot: [V: 04-1] Merge cells tool [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167631 (owner: 10Esanders) [18:57:10] 3VisualEditor / 3Mobile: VisualEditor Mobile: When the context menu appears in mobile the button alignment for "Next" and "Page Settings" option at the top right gets a bit lower - 10https://bugzilla.wikimedia.org/72570 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 16911 -... [18:57:22] 3VisualEditor / 3Mobile: VisualEditor Mobile: When the context menu appears in mobile, the button alignment for "Next" and "Page Settings" option at the top right gets a bit lower - 10https://bugzilla.wikimedia.org/72570 (10Rummana Yasmeen) [18:57:37] 3VisualEditor / 3Editing Tools: VisualEditor: Dialogs should disable "Apply changes" until a change is present - 10https://bugzilla.wikimedia.org/55976 (10James Forrester) 5UNCO>3ASSI [19:00:50] (03CR) 10Catrope: [C: 04-1] "htmlAttributes is meant for preservation only, and is dropped on copy-paste for instance. Anything that is meaningful to or understood by " [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168960 (owner: 10Esanders) [19:11:02] (03PS9) 10Esanders: Table header/data format tools [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168060 [19:11:04] (03PS4) 10Esanders: Allow custom (html)attributes when creating a table [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168960 [19:11:06] (03PS17) 10Esanders: Merge cells tool [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167631 [19:11:10] (03PS15) 10Esanders: Supporting copy paste of single table cells [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167559 [19:11:12] (03PS22) 10Esanders: Support annotation tool on table selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166774 [19:11:14] (03PS50) 10Esanders: Actions and context menus for manipulating tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb) [19:11:35] (03CR) 10jenkins-bot: [V: 04-1] Merge cells tool [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167631 (owner: 10Esanders) [19:12:08] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf1] Template parameter autovalues are not saved - 10https://bugzilla.wikimedia.org/71157#c6 (10etonkovidova) Verified in betalabs. [19:12:39] (03PS1) 10Bartosz Dziewoński: OoUiTag: HTML-escape everything by default [oojs/ui] - 10https://gerrit.wikimedia.org/r/169106 (https://bugzilla.wikimedia.org/72542) [19:13:20] (03PS10) 10Esanders: Table header/data format tools [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168060 [19:13:22] (03PS41) 10Esanders: Data model implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159310 (owner: 10Oliverb) [19:13:24] (03PS5) 10Esanders: Allow custom (html)attributes when creating a table [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168960 [19:13:26] (03PS44) 10Esanders: ContentEditable implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159311 (owner: 10Oliverb) [19:13:28] (03PS16) 10Esanders: Supporting copy paste of single table cells [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167559 [19:13:30] (03PS23) 10Esanders: Support annotation tool on table selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166774 [19:13:32] (03PS51) 10Esanders: Actions and context menus for manipulating tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb) [19:13:39] (03CR) 10Esanders: Actions and context menus for manipulating tables (034 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb) [19:17:23] (03CR) 10Catrope: [C: 04-1] Actions and context menus for manipulating tables (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb) [19:26:09] 3VisualEditor / 3Mobile: VisualEditor Mobile:[Regression wmf5]The wikitext editor does not show any wikitext for any page for mobile in test2 and Betalabs - 10https://bugzilla.wikimedia.org/72571 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 16912 --> https://bugzilla.wiki... [19:32:21] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb) [19:32:35] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168060 (owner: 10Esanders) [19:36:20] (03CR) 10Catrope: [C: 04-1] "There's a bunch of bleed-through from the merge cells commit into this one, but since they'll all land together I don't care all that much" (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168060 (owner: 10Esanders) [19:45:16] (03PS3) 10Jforrester: Apex, MediaWiki themes: Move colour definitions into LESS variables [oojs/ui] - 10https://gerrit.wikimedia.org/r/164389 [19:45:44] (03PS4) 10Jforrester: Apex, MediaWiki themes: Move colour definitions into LESS variables [oojs/ui] - 10https://gerrit.wikimedia.org/r/164389 [19:46:18] (03CR) 10Jforrester: "PS3 is a rebase. PS4 expands the items variable-ised and moves definitions to {theme}/common.less per Ed." [oojs/ui] - 10https://gerrit.wikimedia.org/r/164389 (owner: 10Jforrester) [19:49:03] eh can anyone remind me what oojs and ooui's mediawiki git repos are? [19:49:29] I can't find them and instead of reorganizing my folders I accidentally deleted it :( [19:50:07] mooeypoo: https://gerrit.wikimedia.org/r/#/q/status:open+project:oojs/ui,n,z and https://gerrit.wikimedia.org/r/#/q/status:open+project:oojs/core,n,z [19:58:30] aaah [19:58:33] this is terrible [19:58:35] >> $('
')[0].textContent [19:58:36] <7GHAACEWB> MatmaRex: ReferenceError: $ is not defined [19:58:36] MatmaRex: ReferenceError: $ is not defined [19:58:49] it's "Foo", ecmabot-wm. [19:59:15] MatmaRex: Apparently it isn't. [19:59:40] 3VisualEditor / 3Editing Tools: VisualEditor: Parameter add icon remains enabled in empty transclusion dialog box - 10https://bugzilla.wikimedia.org/63158#c2 (10etonkovidova) Confirmed in betalabs and test2. [20:00:16] (03PS11) 10Esanders: Table header/data format tools [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168060 [20:00:19] (03PS42) 10Esanders: Data model implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159310 (owner: 10Oliverb) [20:00:20] (03PS6) 10Esanders: Allow custom attributes when creating a table [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168960 [20:00:22] (03PS45) 10Esanders: ContentEditable implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159311 (owner: 10Oliverb) [20:00:24] (03PS18) 10Esanders: Merge cells tool [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167631 [20:00:27] (03PS17) 10Esanders: Supporting copy paste of single table cells [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167559 [20:00:28] (03PS24) 10Esanders: Support annotation tool on table selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166774 [20:00:30] (03PS52) 10Esanders: Actions and context menus for manipulating tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb) [20:00:32] (03CR) 10jenkins-bot: [V: 04-1] Table header/data format tools [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168060 (owner: 10Esanders) [20:00:35] (03CR) 10jenkins-bot: [V: 04-1] Allow custom attributes when creating a table [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168960 (owner: 10Esanders) [20:00:37] (03CR) 10jenkins-bot: [V: 04-1] Merge cells tool [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167631 (owner: 10Esanders) [20:00:39] (03CR) 10jenkins-bot: [V: 04-1] Supporting copy paste of single table cells [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167559 (owner: 10Esanders) [20:00:41] (03CR) 10jenkins-bot: [V: 04-1] Support annotation tool on table selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166774 (owner: 10Esanders) [20:00:45] (03CR) 10jenkins-bot: [V: 04-1] Actions and context menus for manipulating tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb) [20:01:54] (03PS1) 10Mooeypoo: Ignore empty strings in array union [oojs/core] - 10https://gerrit.wikimedia.org/r/169201 [20:02:53] whee, 2495 assertions of 2495 passed, 0 failed. [20:04:05] MatmaRex: Nice. [20:12:39] Oh 7GHAACEWB left already, OK [20:16:47] ... what? [20:17:36] oh, a duplicate ecmabot [20:19:22] 3VisualEditor / 3ContentEditable: VisualEditor: Applying a rich annotation to an image causes inspector to open then close quickly in Chrome; die in Firefox - 10https://bugzilla.wikimedia.org/72431#c2 (10James Forrester) 5UNCO>3ASSI p:5Unprio>3Normal s:5normal>3minor I believe that this is descri... [20:19:26] (03CR) 10Esanders: Actions and context menus for manipulating tables (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb) [20:21:24] (03PS5) 10Bartosz Dziewoński: Generate and run a JS/PHP comparison test suite [oojs/ui] - 10https://gerrit.wikimedia.org/r/168910 [20:21:26] (03PS1) 10Bartosz Dziewoński: ButtonInputWidget: Explicitly disallow setting value when using [oojs/ui] - 10https://gerrit.wikimedia.org/r/169206 [20:23:01] (03CR) 10jenkins-bot: [V: 04-1] Generate and run a JS/PHP comparison test suite [oojs/ui] - 10https://gerrit.wikimedia.org/r/168910 (owner: 10Bartosz Dziewoński) [20:25:17] (03PS12) 10Esanders: Table header/data format tools [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168060 [20:25:19] (03PS43) 10Esanders: Data model implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159310 (owner: 10Oliverb) [20:25:21] (03PS7) 10Esanders: Allow custom attributes when creating a table [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168960 [20:25:23] (03PS46) 10Esanders: ContentEditable implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159311 (owner: 10Oliverb) [20:25:26] (03PS19) 10Esanders: Merge cells tool [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167631 [20:25:27] (03PS18) 10Esanders: Supporting copy paste of single table cells [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167559 [20:25:29] (03PS25) 10Esanders: Support annotation tool on table selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166774 [20:25:31] (03PS53) 10Esanders: Actions and context menus for manipulating tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb) [20:25:39] MatmaRex: We'll beat the multiple-var-statements-in-one-context out of you with Jenkins's V-1. ;-) [20:26:42] James_F: haha [20:26:51] * James_F grins. [20:26:53] 3OOjs UI: OOUI: Synchronise JS and PHP docs better - 10https://bugzilla.wikimedia.org/72455 (10Bartosz Dziewoński) [20:26:55] 3OOjs UI / 3Technical Debt: OOUI: It's unclear which class membes (properties) are public/private/internal - 10https://bugzilla.wikimedia.org/72578 (10Bartosz Dziewoński) 3NEW p:3Unprio s:3minor a:3None It's unclear which class membes (properties) are public/private/internal, as we document none of t... [20:28:28] 3MediaWiki / 3Page editing: Provide a way to set page meta-data flags ("featured article", "protected", etc.), configure which ones are available for a wiki, and display icons indicating these statuses - 10https://bugzilla.wikimedia.org/23796#c65 (10James Forrester) 5PATC>3RESO/FIX Done. Thanks, Bartosz! [20:30:23] 3VisualEditor / 3MediaWiki integration: VisualEditor: Create a meta dialog panel for setting page status indicators - 10https://bugzilla.wikimedia.org/72199 (10James Forrester) [20:30:24] 3VisualEditor / 3Editing Tools: VisualEditor: Provide some way for out-of-skin places icons (e.g. featured star) to appear where they "should" and be editable - 10https://bugzilla.wikimedia.org/51420#c7 (10James Forrester) Now that bug 23796 is fixed, we "just" need to work out a way to let the user set/unse... [20:31:15] (03PS6) 10Bartosz Dziewoński: Generate and run a JS/PHP comparison test suite [oojs/ui] - 10https://gerrit.wikimedia.org/r/168910 [20:32:48] (03CR) 10Alex Monk: Disable parameter add icon when there's no transclusion parts (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168379 (https://bugzilla.wikimedia.org/63158) (owner: 10Alex Monk) [20:32:58] (03CR) 10jenkins-bot: [V: 04-1] Generate and run a JS/PHP comparison test suite [oojs/ui] - 10https://gerrit.wikimedia.org/r/168910 (owner: 10Bartosz Dziewoński) [20:33:23] hmph [20:33:25] "Constructor functions should be capitalized" [20:33:34] klass = expandClass( test.class ); [20:33:37] instance = new klass( test.config ); [20:33:46] how do i work around this baby, eh? [20:33:55] i could name the variable in uppercase, but that'd be silly [20:34:00] and i bet there's a check against that, too [20:34:14] No I think that's what it wants you to do [20:34:25] 3VisualEditor: VE gets stuck when trying to delete the last sentence from ref to previous ref - 10https://bugzilla.wikimedia.org/72579 (10Stryn) 3NEW p:3Unprio s:3normal a:3None Reproduce: 1. go to https://fi.wikipedia.org/wiki/User:Stryn/VE?veaction=edit 2. highlight all texts from the end of "This i... [20:34:32] that's stupid [20:34:51] uppercase is for constants, this is a variable [20:34:58] I agree [20:35:12] You could put in one of those "shut up" comments [20:36:32] There's a "shut up" comment? [20:37:02] I mean stuff like /*jshint loopfunc:false */ [20:37:06] I call that a shut up comment [20:37:17] I like that name. [20:37:20] yeah, i'm trying to figure out how [20:37:32] (03PS2) 10Alex Monk: Disable parameter add icon when there's no transclusion parts [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168379 (https://bugzilla.wikimedia.org/63158) [20:37:51] // jscs:disable requireCapitalizedConstructors [20:38:07] (03PS7) 10Bartosz Dziewoński: Generate and run a JS/PHP comparison test suite [oojs/ui] - 10https://gerrit.wikimedia.org/r/168910 [20:38:25] (03CR) 10Catrope: [C: 032] Disable parameter add icon when there's no transclusion parts [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168379 (https://bugzilla.wikimedia.org/63158) (owner: 10Alex Monk) [20:38:32] (03CR) 10Catrope: Disable parameter add icon when there's no transclusion parts (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168379 (https://bugzilla.wikimedia.org/63158) (owner: 10Alex Monk) [20:39:47] (03Merged) 10jenkins-bot: Disable parameter add icon when there's no transclusion parts [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168379 (https://bugzilla.wikimedia.org/63158) (owner: 10Alex Monk) [20:39:49] haaaaaaaaaaaaaa [20:39:57] * mooeypoo shakes fist at templatedata model [20:40:23] 3VisualEditor / 3Editing Tools: VisualEditor: Parameter add icon remains enabled in empty transclusion dialog box - 10https://bugzilla.wikimedia.org/63158 (10James Forrester) 5PATC>3RESO/FIX [20:40:42] also, does jenkins not run QUnit tests for OOUI? [20:41:12] I.... don't know? [20:41:12] MatmaRex: It did. [20:41:19] MatmaRex: If they're in npm then yes. [20:41:20] I think it runs them from the npm task [20:41:32] oh yeah, it's that karma thing? [20:42:08] (03CR) 10Krinkle: Generate and run a JS/PHP comparison test suite (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/168910 (owner: 10Bartosz Dziewoński) [20:42:09] Yes [20:42:14] (03CR) 10Krinkle: "CRLF -> LF" [oojs/ui] - 10https://gerrit.wikimedia.org/r/168910 (owner: 10Bartosz Dziewoński) [20:42:20] hmm, but it doesn't seem to have picked up the new ones in https://gerrit.wikimedia.org/r/#/c/168910/. i guess it doesn't like that i moved the file [20:42:54] Nice approach overall. I like where it is going (/me peeks randomly for a few seconds) [20:43:53] (03CR) 10Bartosz Dziewoński: "Krinkle, if you've already commented :D, can you make the Karma task pick up the new tests? They don't seem be have been ran by Jenkins fo" [oojs/ui] - 10https://gerrit.wikimedia.org/r/168910 (owner: 10Bartosz Dziewoński) [20:44:23] yay [20:44:51] Krinkle: :-) [20:45:13] I'm not sure that npm runs in an environment with a PHP server, does it? [20:45:19] (03CR) 10Krinkle: "QUnit tests run from static files independent from a web server. They can't use PHP. Check the Gruntfile. The html file is not used by kar" [oojs/ui] - 10https://gerrit.wikimedia.org/r/168910 (owner: 10Bartosz Dziewoński) [20:46:00] James_F: MatmaRex: Youll want to use a build script for now, just like buildloader. Part of the grunt run before the test runs. [20:46:01] hey, i never said that's easy to do [20:46:07] Probably don't want to use ruby or php. [20:46:08] 3OOjs UI / 3Technical Debt: OOUI: It's unclear which class members (properties) are public/private/internal - 10https://bugzilla.wikimedia.org/72578 (10Bartosz Dziewoński) [20:47:23] 3VisualEditor / 3MediaWiki integration: VisualEditor: It's not possible to "Apply changes" from the transclusion dialog after it has been emptied - 10https://bugzilla.wikimedia.org/72191#c4 (10etonkovidova) Verified in betalabs. [20:54:18] James_F: do we want to convert the remaining items from http://etherpad.wikimedia.org/p/OOUIPHP to bugs? [20:55:36] MatmaRex: That would be a good idea. [20:55:56] MatmaRex: Especially the "Missing major-and-implementable features" section. [20:58:42] MatmaRex, are there any javascript hooks when we switch between HD & SD skins in vector, or is it all just media queries? [20:59:03] edsanders: only media queries [20:59:28] edsanders: there are some other JS things that listen to the 'resize' event [20:59:36] (collapsible tabs) [20:59:38] yes [20:59:52] but HD/SD is done in CSS only [21:00:00] the toolbar needs to reposition when we make that switch [21:00:11] or rather, recalculate some cached offsets [21:07:29] The toolbar emits a position event, but I can't see anything listening to it, does anyone want to claim this as useful? [21:08:16] Maybe something used to listen to it once? [21:08:16] edsanders: Isn't that for the floating behaviour? [21:08:53] James_F, the toolbar floats itself, this is something else caring that the toolbar is moving [21:09:04] RoanKattouw, that's my guess [21:09:16] edsanders: Didn't the integration used to position the toolbar? [21:09:32] Yeah maybe it was something like that? [21:09:44] I've searched in the ve/ve-mw [21:09:51] the only other thing could be mobile? [21:09:52] I think the target listened (maybe still listens?) to that event [21:09:59] I guess if you grepped there then that is past tense [21:10:14] Maybe mobile, I doubt it but it's worth checking [21:11:18] doesn't look like it [21:12:34] (03PS2) 10Bartosz Dziewoński: OoUiTag: HTML-escape everything by default [oojs/ui] - 10https://gerrit.wikimedia.org/r/169106 (https://bugzilla.wikimedia.org/72542) [21:12:36] (03PS2) 10Bartosz Dziewoński: ButtonInputWidget: Explicitly disallow setting value when using [oojs/ui] - 10https://gerrit.wikimedia.org/r/169206 [21:12:38] (03PS8) 10Bartosz Dziewoński: Generate and run a JS/PHP comparison test suite [oojs/ui] - 10https://gerrit.wikimedia.org/r/168910 [21:12:40] (03PS1) 10Bartosz Dziewoński: Turn FieldLayout into a