[00:22:19] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169270 (https://bugzilla.wikimedia.org/52792) (owner: 10Alex Monk) [00:23:56] (03PS1) 10Catrope: [BREAKING CHANGE] If no $overlay is specified, default to this.$element [oojs/ui] - 10https://gerrit.wikimedia.org/r/169277 [00:26:46] (03PS1) 10Catrope: [BREAKING CHANGE] Apply font-size: 0.8em; to non-isolated windows too [oojs/ui] - 10https://gerrit.wikimedia.org/r/169279 [00:28:25] (03PS2) 10Catrope: [BREAKING CHANGE] Apply font-size: 0.8em; to non-isolated windows too [oojs/ui] - 10https://gerrit.wikimedia.org/r/169279 [00:29:26] (03PS1) 10Catrope: Remove font-size: 0.8em; rule for OOUI change [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/169280 [00:37:41] (03PS1) 10Catrope: Pass $overlay to widgets that need it [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169281 [00:39:24] (03PS1) 10Catrope: Sprinke some child selectors around in MWTransclusionDialog.css [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169285 [00:41:02] (03PS1) 10Catrope: [WIP] Unisolate dialogs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/169286 [00:48:40] (03PS1) 10Catrope: Put icons back in template parameter search [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169293 [00:50:19] (03PS1) 10Catrope: Remove oo-ui-{ltr,rtl} special-casing for parameter icons [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169296 [00:53:07] (03PS1) 10Catrope: Override overflow: hidden; for

s in the command help dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169298 [00:56:04] (03PS2) 10Catrope: [WIP] Unisolate dialogs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/169286 [00:56:15] (03PS3) 10Catrope: Unisolate dialogs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/169286 [01:00:11] (03PS4) 10Catrope: Unisolate dialogs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/169286 [01:04:56] (03PS1) 10Catrope: Update VE core submodule to master (07b2eda) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169301 [01:06:12] (03CR) 10Catrope: [C: 031] Allow custom attributes when creating a table [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168960 (owner: 10Esanders) [01:08:07] (03CR) 10Catrope: [C: 04-1] Merge cells tool (033 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167631 (owner: 10Esanders) [01:09:02] (03CR) 10Catrope: Merge cells tool (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167631 (owner: 10Esanders) [01:16:55] (03CR) 10Catrope: [C: 04-1] Show warning on reference dialog when editing a reference used in more than one place (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169270 (https://bugzilla.wikimedia.org/52792) (owner: 10Alex Monk) [01:23:17] (03CR) 10Siebrand: Show warning on reference dialog when editing a reference used in more than one place (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169270 (https://bugzilla.wikimedia.org/52792) (owner: 10Alex Monk) [01:29:34] (03PS2) 10Catrope: [BREAKING CHANGE] If no $overlay is specified, default to this.$element [oojs/ui] - 10https://gerrit.wikimedia.org/r/169277 [01:31:22] (03CR) 10Catrope: [C: 04-2] "Do not merge until dependencies in commit message have been merged. Also do not merge before the wmf6 cut on Wednesday." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/169286 (owner: 10Catrope) [01:32:23] (03PS2) 10Catrope: Put icons back in template parameter search [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169293 [01:35:28] (03CR) 10Catrope: "We talked about this briefly on IRC, but why is this needed again? An empty string is a reasonable value to have in an array of strings, a" [oojs/core] - 10https://gerrit.wikimedia.org/r/169201 (owner: 10Mooeypoo) [01:35:55] (03CR) 10Catrope: [C: 04-1] "(-1 pending justification; right now this looks like a bug not a feature to me)" [oojs/core] - 10https://gerrit.wikimedia.org/r/169201 (owner: 10Mooeypoo) [01:42:18] (03CR) 10Catrope: [C: 04-1] "Provisional -1 pending Trevor taking a closer look." [oojs/ui] - 10https://gerrit.wikimedia.org/r/169218 (https://bugzilla.wikimedia.org/72587) (owner: 10Bartosz Dziewoński) [01:43:27] (03CR) 10Catrope: [C: 04-2] "Do not merge until oojs-ui change is merged" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/169280 (owner: 10Catrope) [05:18:11] (03PS3) 10Mooeypoo: [Extremely WIP] Eventify TemplateDataGenerator and use oojs-ui [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 [05:18:14] (03CR) 10jenkins-bot: [V: 04-1] [Extremely WIP] Eventify TemplateDataGenerator and use oojs-ui [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 (owner: 10Mooeypoo) [07:16:20] (03PS4) 10Mooeypoo: [Extremely WIP] Eventify TemplateDataGenerator and use oojs-ui [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 [07:16:23] (03CR) 10jenkins-bot: [V: 04-1] [Extremely WIP] Eventify TemplateDataGenerator and use oojs-ui [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 (owner: 10Mooeypoo) [09:47:33] (03CR) 10Esanders: "VE core is a dependency of VE-MW, never the other way around. Just mark this as a breaking change if MW needs updating after." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/169286 (owner: 10Catrope) [09:48:54] (03CR) 10Esanders: [C: 032] [BREAKING CHANGE] If no $overlay is specified, default to this.$element [oojs/ui] - 10https://gerrit.wikimedia.org/r/169277 (owner: 10Catrope) [09:50:02] (03CR) 10Esanders: [C: 032] [BREAKING CHANGE] Apply font-size: 0.8em; to non-isolated windows too [oojs/ui] - 10https://gerrit.wikimedia.org/r/169279 (owner: 10Catrope) [09:50:52] (03Merged) 10jenkins-bot: [BREAKING CHANGE] If no $overlay is specified, default to this.$element [oojs/ui] - 10https://gerrit.wikimedia.org/r/169277 (owner: 10Catrope) [09:51:13] (03CR) 10Esanders: [C: 04-1] Unisolate dialogs (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/169286 (owner: 10Catrope) [09:52:00] (03Merged) 10jenkins-bot: [BREAKING CHANGE] Apply font-size: 0.8em; to non-isolated windows too [oojs/ui] - 10https://gerrit.wikimedia.org/r/169279 (owner: 10Catrope) [09:55:21] (03CR) 10Esanders: [C: 032] Remove oo-ui-{ltr,rtl} special-casing for parameter icons [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169296 (owner: 10Catrope) [09:56:41] (03Merged) 10jenkins-bot: Remove oo-ui-{ltr,rtl} special-casing for parameter icons [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169296 (owner: 10Catrope) [09:56:48] (03CR) 10Esanders: [C: 032] Override overflow: hidden; for

s in the command help dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169298 (owner: 10Catrope) [09:58:05] (03Merged) 10jenkins-bot: Override overflow: hidden; for

s in the command help dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169298 (owner: 10Catrope) [10:18:22] (03CR) 10Esanders: Merge cells tool (034 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167631 (owner: 10Esanders) [10:30:19] (03PS57) 10Paladox: WikiEditor: Convert .css to .less and also fixes SVG issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) [11:08:40] (03CR) 10Mvolz: "Re: line 65 partPromise.done stuff- ideally the parameters should be added *before* the transclusion is inserted, but the problem is that " [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/168746 (owner: 10Mvolz) [11:21:17] Ugh. https://en.wikipedia.org/wiki/Category:CS1_maint:_English_language_specified [11:22:16] basically, you get an error if you use the original language field in the same language as the wiki you're on. [11:22:48] so the option is to either not have that field at all in the td map [11:23:02] or to have errors every time the source is in english on en wiki [11:23:47] I guess I could handle that extension-side but I'd have to hard code in what field it was -_- [11:24:37] (or in french on fr wiki, etc, if they're using the CS catgory error) [11:28:35] hmm. I guess it's not so bad, they don't actually show an error, just add the page to a category. [11:56:55] 3VisualEditor: VisualEditor: Text in Japanese disappears - 10https://bugzilla.wikimedia.org/72619 (10Elitre) 3NEW p:3Unprio s:3normal a:3None First reported by miya at ja.wp: write something in Japanese; press Enter; the whole line disappears. This also happens when adding a picture - in the Caption fi... [11:57:08] 3VisualEditor: VisualEditor: Text in Japanese disappears - 10https://bugzilla.wikimedia.org/72619 (10Elitre) [11:57:08] 3VisualEditor / 3Language: VisualEditor: a line started with Japanese input disappear when I switch to and start non-Japanese (latin) input - 10https://bugzilla.wikimedia.org/72508 (10Elitre) [12:04:31] (03CR) 10Mvolz: "(Actually, line 35 stays as is, it's necessary b/c otherwise things come through urlencoded and break)." [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/168746 (owner: 10Mvolz) [12:32:33] (03PS8) 10Esanders: Allow custom type and attributes when creating a table [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168960 [12:32:35] (03PS20) 10Esanders: Merge cells tool [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167631 [12:59:15] (03PS2) 10Alex Monk: Show warning on reference dialog when editing a reference used in more than one place [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169270 (https://bugzilla.wikimedia.org/52792) [13:07:44] (03PS1) 10Esanders: Add table to test node hack as MWTable is coming [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/169351 [14:43:18] (03CR) 10Hashar: "I wrote this in a rush using my local Doxygen 1.8.8. Some of the settings might be deprecated though." [oojs/ui] - 10https://gerrit.wikimedia.org/r/168490 (https://bugzilla.wikimedia.org/72454) (owner: 10Hashar) [14:50:08] 3VisualEditor / 3Editing Tools: VisualEditor:[Regression] After saving the page, external link in media always takes preference in auto-numbering irrespective of its location. - 10https://bugzilla.wikimedia.org/72625 (10Ritu Swain) [14:50:10] 3VisualEditor / 3Editing Tools: VisualEditor:[Regression] After saving the page,external link in media always takes preference in auto-numbering irrespective of its location. - 10https://bugzilla.wikimedia.org/72625 (10Ritu Swain) 3UNCO p:3Unprio s:3normal a:3None Environment- test2, beta, production... [14:56:07] 3VisualEditor / 3Editing Tools: VisualEditor:[Regression] After saving the page, external link in media always takes preference in auto-numbering irrespective of its location. - 10https://bugzilla.wikimedia.org/72625#c1 (10Ritu Swain) See screenshots. [14:57:22] 3VisualEditor / 3Editing Tools: VisualEditor:[Regression] After saving the page, external link in media always takes preference in auto-numbering irrespective of its location. - 10https://bugzilla.wikimedia.org/72625#c2 (10Ritu Swain) Created attachment 16927 --> https://bugzilla.wikimedia.org/attachment.c... [14:58:38] 3VisualEditor / 3Editing Tools: VisualEditor:[Regression] After saving the page, external link in media always takes preference in auto-numbering irrespective of its location. - 10https://bugzilla.wikimedia.org/72625#c3 (10Ritu Swain) Created attachment 16928 --> https://bugzilla.wikimedia.org/attachment.c... [15:54:58] * James_F waves. [16:10:26] hey [16:12:21] (03PS3) 10Esanders: Create mwTables with wikitable attribute by default [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168961 [16:12:23] (03PS6) 10Esanders: Files and messages for table editing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167189 [16:12:25] (03PS1) 10Esanders: Factor out class <-> attribute mappings from BlockImageNode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169517 [16:13:33] (03CR) 10jenkins-bot: [V: 04-1] Create mwTables with wikitable attribute by default [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168961 (owner: 10Esanders) [16:13:36] (03CR) 10jenkins-bot: [V: 04-1] Files and messages for table editing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167189 (owner: 10Esanders) [16:31:00] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=108576287 [16:31:00] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=108577280 [16:31:00] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=108594962 [16:31:00] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=33099326 [16:31:00] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=66464406 [16:31:00] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=66469511 [16:31:00] Corruption alert: visualeditor-needcheck on plwiki: https://pl.wikipedia.org/?diff=40828420 [16:37:53] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression] Link inspector closes itself immediately in Internet Explorer - 10https://bugzilla.wikimedia.org/72392#c8 (10etonkovidova) Verified in test2 and production(en.wikipedia.org) - inserting a link with a menu option - OK - editing an existing link wiht... [16:38:07] (03PS4) 10Esanders: Create mwTables with wikitable attribute by default [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168961 [16:38:09] (03PS7) 10Esanders: Files and messages for table editing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167189 [16:39:12] (03CR) 10jenkins-bot: [V: 04-1] Create mwTables with wikitable attribute by default [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168961 (owner: 10Esanders) [16:39:44] (03CR) 10jenkins-bot: [V: 04-1] Files and messages for table editing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167189 (owner: 10Esanders) [16:47:32] (03CR) 10Jforrester: [C: 032] Put icons back in template parameter search [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169293 (owner: 10Catrope) [16:47:42] (03CR) 10Jforrester: [C: 032] Update VE core submodule to master (07b2eda) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169301 (owner: 10Catrope) [16:48:28] (03CR) 10Jforrester: [C: 032] Sprinke some child selectors around in MWTransclusionDialog.css [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169285 (owner: 10Catrope) [16:48:54] (03Merged) 10jenkins-bot: Put icons back in template parameter search [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169293 (owner: 10Catrope) [16:48:58] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169270 (https://bugzilla.wikimedia.org/52792) (owner: 10Alex Monk) [16:49:53] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167631 (owner: 10Esanders) [16:51:26] (03CR) 10Esanders: [C: 04-1] [WIP] Use TempateData to insert citations (0310 comments) [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/168746 (owner: 10Mvolz) [16:52:10] 3VisualEditor / 3Editing Tools: VE: IE11 - when tables are pasted, class="wikitable" is dropped - 10https://bugzilla.wikimedia.org/72599 (10etonkovidova) a:3Ed Sanders [16:53:23] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (deccd11549) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/169524 [16:55:27] (03Merged) 10jenkins-bot: Update VE core submodule to master (07b2eda) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169301 (owner: 10Catrope) [16:55:29] (03Merged) 10jenkins-bot: Sprinke some child selectors around in MWTransclusionDialog.css [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169285 (owner: 10Catrope) [16:57:10] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 (owner: 10Mooeypoo) [16:58:21] (03CR) 10Catrope: [C: 031] Merge cells tool [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167631 (owner: 10Esanders) [17:24:33] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (deccd11549) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/169524 (owner: 10Jforrester) [17:25:11] (03CR) 10Jforrester: [C: 032] Pass $overlay to widgets that need it [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169281 (owner: 10Catrope) [17:26:39] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (deccd11549) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/169524 (owner: 10Jforrester) [17:26:53] (03CR) 10Catrope: Remove font-size: 0.8em; rule for OOUI change [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/169280 (owner: 10Catrope) [17:27:02] (03CR) 10Catrope: Unisolate dialogs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/169286 (owner: 10Catrope) [17:27:06] (03CR) 10Jforrester: [C: 032] Remove font-size: 0.8em; rule for OOUI change [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/169280 (owner: 10Catrope) [17:27:09] (03CR) 10Catrope: [C: 04-2] Unisolate dialogs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/169286 (owner: 10Catrope) [17:27:12] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/169280/ [17:27:32] (03PS5) 10Catrope: [BREAKING CHANGE] Unisolate dialogs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/169286 [17:28:39] (03Merged) 10jenkins-bot: Remove font-size: 0.8em; rule for OOUI change [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/169280 (owner: 10Catrope) [17:29:20] (03PS1) 10Jforrester: Update VE core submodule to master (ce4ee02) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169530 [17:29:30] (03CR) 10Esanders: "Remove mw-specific message breaks ve-mw, and is fixed by I91ceba0e05" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169301 (owner: 10Catrope) [17:29:49] James_F, RoanKattouw ^^ [17:30:14] edsanders: Yeah, already on it. [17:30:21] (03PS5) 10Jforrester: Move core/MW messages to correct sections [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168312 (owner: 10Esanders) [17:30:28] (03CR) 10Jforrester: [C: 032] Move core/MW messages to correct sections [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168312 (owner: 10Esanders) [17:30:48] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (ce4ee02) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169530 (owner: 10Jforrester) [17:30:51] (03CR) 10Catrope: [C: 032] Move core/MW messages to correct sections [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168312 (owner: 10Esanders) [17:30:59] (03Merged) 10jenkins-bot: Pass $overlay to widgets that need it [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169281 (owner: 10Catrope) [17:31:25] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (ce4ee02) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169530 (owner: 10Jforrester) [17:31:43] (03CR) 10jenkins-bot: [V: 04-1] Move core/MW messages to correct sections [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168312 (owner: 10Esanders) [17:31:51] (03Merged) 10jenkins-bot: Move core/MW messages to correct sections [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168312 (owner: 10Esanders) [17:33:23] (03CR) 10Catrope: [C: 032] Show warning on reference dialog when editing a reference used in more than one place [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169270 (https://bugzilla.wikimedia.org/52792) (owner: 10Alex Monk) [17:34:38] (03Merged) 10jenkins-bot: Update VE core submodule to master (ce4ee02) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169530 (owner: 10Jforrester) [17:34:59] (03CR) 10Catrope: [C: 032] Show warning on reference dialog when editing a reference used in more than one place [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169270 (https://bugzilla.wikimedia.org/52792) (owner: 10Alex Monk) [17:36:09] (03Merged) 10jenkins-bot: Show warning on reference dialog when editing a reference used in more than one place [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169270 (https://bugzilla.wikimedia.org/52792) (owner: 10Alex Monk) [17:36:11] (03PS13) 10Esanders: Table header/data format tools [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168060 [17:36:13] (03PS9) 10Esanders: Allow custom type and attributes when creating a table [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168960 [17:36:15] (03PS21) 10Esanders: Merge cells tool [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167631 [17:36:54] 3VisualEditor / 3Editing Tools: VisualEditor: Warn if editing a reference that is used multiple times - 10https://bugzilla.wikimedia.org/52792 (10Alex Monk) 5PATC>3RESO/FIX [17:38:32] (03CR) 10jenkins-bot: [V: 04-1] Table header/data format tools [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168060 (owner: 10Esanders) [17:41:38] 3VisualEditor / 3Editing Tools: VE: IE11 - when tables are pasted, class="wikitable" is dropped - 10https://bugzilla.wikimedia.org/72599 (10etonkovidova) p:5Unprio>3Normal [17:50:32] edsanders: https://gerrit.wikimedia.org/r/164389 [17:58:00] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168060 (owner: 10Esanders) [18:18:12] 3VisualEditor: Typing immediately after a link is in wrong colour - 10https://bugzilla.wikimedia.org/72638 (10Spinningspark) 3NEW p:3Unprio s:3normal a:3None Intention: To add some text after a link Steps to Reproduce: See this example edit https://en.wikipedia.org/w/index.php?title=Lava_%28soap%29&di... [18:23:30] (03PS1) 10Catrope: Clear selection after tearing down surface to work around Firefox bug [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169546 (https://bugzilla.wikimedia.org/71852) [18:27:12] (03CR) 10Esanders: Apex, MediaWiki themes: Move colour definitions into LESS variables (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/164389 (owner: 10Jforrester) [18:27:27] James_F, light/heavy -> start/end ? [18:29:21] edsanders: They're meant to be semantic about the colour's meaning rather than about their current use. [18:29:44] edsanders: Light/heavy would remain the same even if we decided (for some reason) to invert the order of which colour is on top. [18:29:48] edsanders: Eh. I don't know. [18:32:29] (03CR) 10Catrope: [C: 04-1] Factor out class <-> attribute mappings from BlockImageNode (033 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169517 (owner: 10Esanders) [18:36:27] (03CR) 10Catrope: [C: 031] Create mwTables with wikitable attribute by default [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168961 (owner: 10Esanders) [18:38:09] (03CR) 10Catrope: [C: 032] Add table to test node hack as MWTable is coming [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/169351 (owner: 10Esanders) [18:38:23] (03CR) 10Jforrester: "Boo technical debt." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/169351 (owner: 10Esanders) [18:39:39] (03CR) 10Catrope: Actions and context menus for manipulating tables (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb) [18:39:59] (03Merged) 10jenkins-bot: Add table to test node hack as MWTable is coming [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/169351 (owner: 10Esanders) [18:42:45] (03CR) 10Catrope: [C: 04-2] "Will merge this after the wmf6 branch is cut tomorrow. +2ing all the other commits on top of this one so the whole stack will go at once w" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159310 (owner: 10Oliverb) [18:42:53] (03CR) 10Catrope: [C: 032] ContentEditable implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159311 (owner: 10Oliverb) [18:43:00] (03CR) 10Catrope: [C: 032] Actions and context menus for manipulating tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb) [18:43:08] (03CR) 10Catrope: [C: 032] Support annotation tool on table selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166774 (owner: 10Esanders) [18:43:30] (03CR) 10Catrope: [C: 032] Supporting copy paste of single table cells [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167559 (owner: 10Esanders) [18:44:04] 17:37:58 npm ERR! addPlacedTarball Could not unpack "/mnt/home/jenkins-deploy/.npm/socket.io-client/0.9.16/package.tgz" to "/mnt/home/jenkins-deploy/.npm/socket.io-client/0.9.16" [18:44:05] 17:38:01 npm ERR! Error: ENOENT, open '/mnt/home/jenkins-deploy/.npm/socket.io-client/0.9.16/package/package.json' [18:44:07] Hadn't seen that one before [18:44:20] Hmm. [18:44:25] (03CR) 10Catrope: [C: 032] Table header/data format tools [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168060 (owner: 10Esanders) [18:44:34] (03CR) 10Catrope: [C: 032] Merge cells tool [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167631 (owner: 10Esanders) [18:44:42] (03CR) 10Catrope: [C: 032] Allow custom type and attributes when creating a table [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168960 (owner: 10Esanders) [18:47:08] 3VisualEditor / 3Editing Tools: VisualEditor: Be able to add or remove tables, table rows and table columns - 10https://bugzilla.wikimedia.org/52181#c7 (10James Forrester) 5ASSI>3RESO/FIX Done in gerrit 159310 and related stack. [18:49:55] (03CR) 10Esanders: Make setSelection emit activeAnnotationChange if continuation unicorns may be needed (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168327 (https://bugzilla.wikimedia.org/72108) (owner: 10Divec) [18:52:52] 3VisualEditor / 3Editing Tools: VisualEditor: Table with some template-generated rows appears with additional jumbled empty table cells – enwiki's {{Singlechart}} template - 10https://bugzilla.wikimedia.org/68306 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal [18:54:42] (03CR) 10Jforrester: [C: 031] "Now deployed." [extensions/Cite] - 10https://gerrit.wikimedia.org/r/149593 (owner: 10Jforrester) [18:54:51] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/149593/ ^^^ +2 please. [18:56:17] RoanKattouw, so, just to clarify since I think I misunderstood -- In TemplateData model, I need a union method that *ignores* empty string values. We talked about that briefly and I thought you meant I should add thta to the oojs array union, but that sounds like I misunderstood now. [18:56:49] (03CR) 10Catrope: [C: 032] Remove Special:Cite, now moved to its own repository [extensions/Cite] - 10https://gerrit.wikimedia.org/r/149593 (owner: 10Jforrester) [18:56:54] (03CR) 10jenkins-bot: [V: 04-1] Remove Special:Cite, now moved to its own repository [extensions/Cite] - 10https://gerrit.wikimedia.org/r/149593 (owner: 10Jforrester) [18:57:03] mooeypoo: I wasn't too focused at the time, sorry [18:57:15] Union in general could have empty values in it, right? So I can either abandon that fix or maybe add a boolean "allowEmptyStrings" or something to it? [18:57:21] Now that I actually see what you did in terms of real code, I'm thinking it's probably not something that should be in union in general [18:57:38] Also what kind of handling for empty strings do you need exactly? It sounds like maybe you could just .filter() the result [18:58:08] Empty strings should go away and burn in a fire in my TemplateData arrays [18:58:20] so I could either do union and then filter, or do the union while filtering [18:58:27] Both work. [18:58:34] The first seemed faster [18:59:13] RoanKattouw, remember my loop-de-loop event extravaganza with chrome? That was somewhat due to arrays with empty values. [19:00:15] So I would recommend doing the union, then .filter( function ( value ) { return value !== ''; } ); or something similar [19:00:34] hmm okay. [19:02:36] (03PS4) 10Jforrester: Remove Special:Cite, now moved to its own repository [extensions/Cite] - 10https://gerrit.wikimedia.org/r/149593 [19:03:16] (03CR) 10Jforrester: "PS4 is a rebase." [extensions/Cite] - 10https://gerrit.wikimedia.org/r/149593 (owner: 10Jforrester) [19:04:07] (03CR) 10Catrope: [C: 032] Remove Special:Cite, now moved to its own repository [extensions/Cite] - 10https://gerrit.wikimedia.org/r/149593 (owner: 10Jforrester) [19:04:27] (03Merged) 10jenkins-bot: Remove Special:Cite, now moved to its own repository [extensions/Cite] - 10https://gerrit.wikimedia.org/r/149593 (owner: 10Jforrester) [19:05:16] (03PS1) 10Jforrester: Add Special:CiteThisPage to the 'pagetools' group of Special:SpecialPages [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/169555 [19:06:35] (03PS2) 10Jforrester: Replace == with isset [extensions/Cite] - 10https://gerrit.wikimedia.org/r/164085 (owner: 10Amire80) [19:06:43] (03CR) 10Jforrester: [C: 032] Replace == with isset [extensions/Cite] - 10https://gerrit.wikimedia.org/r/164085 (owner: 10Amire80) [19:06:53] (03Merged) 10jenkins-bot: Replace == with isset [extensions/Cite] - 10https://gerrit.wikimedia.org/r/164085 (owner: 10Amire80) [19:07:07] 3VisualEditor / 3Editing Tools: VisualEditor: Typed text is ignored after moving cursor from link inspector back to document - 10https://bugzilla.wikimedia.org/68590#c7 (10Krinkle) (In reply to Bartosz Dziewoński from comment #6) > To be clear, I suggest WONTFIX. The original major issue here (broken undo) >... [19:07:26] (03PS4) 10Jforrester: Replace == with test for isset and empty string [extensions/Cite] - 10https://gerrit.wikimedia.org/r/164086 (owner: 10Amire80) [19:07:33] (03CR) 10Jforrester: [C: 032] Replace == with test for isset and empty string [extensions/Cite] - 10https://gerrit.wikimedia.org/r/164086 (owner: 10Amire80) [19:07:44] James_F: Can you reproduce the first/second/third character behaviour I described at https://bugzilla.wikimedia.org/68590#c7 ? [19:07:57] (03Merged) 10jenkins-bot: Replace == with test for isset and empty string [extensions/Cite] - 10https://gerrit.wikimedia.org/r/164086 (owner: 10Amire80) [19:08:11] Krinkle: Not now. [19:08:12] Empty paragraph -> insert link to Main Page -> focus document -> type abc -> [[Main_Page|b]]c [19:08:21] Krinkle: Dupe of another bug, lemme find it [19:09:08] 3VisualEditor / 3Editing Tools: VisualEditor: Typed text is ignored after moving cursor from link inspector back to document - 10https://bugzilla.wikimedia.org/68590#c8 (10Krinkle) Simplified: Empty paragraph -> insert link to Main Page -> focus document (observe nothing changing, so user expects its safe t... [19:09:19] Krinkle: Well, not even really a duplicate [19:09:36] You're commenting on bug X about Y, but Y is 1) not related to X and 2) already filed as bug Z [19:09:54] 3VisualEditor / 3ContentEditable: VE: IE11 - 'Page options' drop down menu has unnecessary horizontal scroll bar - 10https://bugzilla.wikimedia.org/72640 (10etonkovidova) 3NEW p:3Unprio s:3normal a:3None Created attachment 16931 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16931&action=edit... [19:10:37] Comment 4 explains this perfectly [19:12:07] 3VisualEditor / 3Editing Tools: VisualEditor: If you click out of a link inspector to somewhere else in the document, the link gets inserted and selected, moving your cursor away from where you clicked - 10https://bugzilla.wikimedia.org/68590#c9 (10Roan Kattouw) (In reply to Krinkle from comment #7) > (In re... [19:12:38] 3VisualEditor / 3ContentEditable: VE: IE11 - 'Page options' drop down menu has unnecessary horizontal scroll bar - 10https://bugzilla.wikimedia.org/72640 (10etonkovidova) p:5Unprio>3Low [19:15:48] James_F, you resolved https://bugzilla.wikimedia.org/show_bug.cgi?id=52181#c7 ..? [19:19:37] James_F, I don't think start/end implies any direction. Also light/heavy implies lightness, which isn't semantic [19:22:53] Krenair: Yes. No point waiting and doing it in 12 hours instead. [19:25:33] Krenair: I marked it for next week's release. [19:28:25] 3MediaWiki extensions / 3Cite: split Cite extension into two: citations and SpecialCite - 10https://bugzilla.wikimedia.org/18081#c4 (10James Forrester) 5REOP>3RESO/FIX a:3James Forrester Done for REL1_25; now called Cite and CiteThisPage. [19:29:10] edsanders: I feel it does, but happy for you to alter if you'd prefer. [19:32:26] 3VisualEditor / 3ContentEditable: VE: IE11 - 'Page options' drop down menu has unnecessary horizontal scroll bar - 10https://bugzilla.wikimedia.org/72640#c1 (10etonkovidova) As it was described in 56713 - the bug "alternates" i.e. IE11 test2: Open a page in VE and click on the 'Page options' icon - the dr... [19:38:33] (03PS15) 10Jforrester: [WIP] Provide move left/right quick action buttons for images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141091 [19:38:40] (03PS7) 10Jforrester: [WIP] Provide tools to make text bigger or smaller [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141617 (https://bugzilla.wikimedia.org/51613) [19:39:06] (03PS4) 10Jforrester: [WIP] Add a "Remove" context button to all Focusable nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163662 (https://bugzilla.wikimedia.org/60110) [19:51:24] 3VisualEditor / 3Editing Tools: VisualEditor: If you click out of a link inspector to somewhere else in the document, the link gets inserted and selected, moving your cursor away from where you clicked - 10https://bugzilla.wikimedia.org/68590#c10 (10James Forrester) a:5Ed Sanders>3Roan Kattouw Moving ove... [19:51:40] (03CR) 10Jforrester: [C: 04-1] [BREAKING CHANGE] Unisolate dialogs (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/169286 (owner: 10Catrope) [19:56:26] (03PS5) 10Esanders: Apex, MediaWiki themes: Move colour definitions into LESS variables [oojs/ui] - 10https://gerrit.wikimedia.org/r/164389 (owner: 10Jforrester) [19:57:01] (03CR) 10Esanders: "LGTM but I touched it." [oojs/ui] - 10https://gerrit.wikimedia.org/r/164389 (owner: 10Jforrester) [20:02:40] 3VisualEditor / 3ContentEditable: VE: IE11 - opacity is flawed - 10https://bugzilla.wikimedia.org/72643 (10etonkovidova) 3NEW p:3Unprio s:3normal a:3None Created attachment 16933 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16933&action=edit IE11 transparency flaws Steps to reproduce: 1... [20:03:13] (03CR) 10Jforrester: [C: 031] Apex, MediaWiki themes: Move colour definitions into LESS variables [oojs/ui] - 10https://gerrit.wikimedia.org/r/164389 (owner: 10Jforrester) [20:03:23] edsanders: Go for it. [20:03:34] done [20:04:23] 3VisualEditor / 3ContentEditable: VE: IE11 - opacity is flawed - 10https://bugzilla.wikimedia.org/72643#c1 (10etonkovidova) Created attachment 16934 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16934&action=edit Chrome shows correct transparency - to compare [20:04:38] 3VisualEditor / 3ContentEditable: VE: IE11 - opacity is flawed - 10https://bugzilla.wikimedia.org/72643 (10etonkovidova) p:5Unprio>3High [20:38:09] (03CR) 10Krinkle: build: Check for files' existence before building using grunt-file-exists (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/155630 (https://bugzilla.wikimedia.org/63743) (owner: 10Jforrester) [20:42:25] Today I learned about the existence of a lovely JS variable [20:42:28] Called wgIsProbablyEditable [20:43:24] 3MediaWiki / 3Page editing: maintenance script edit.php doesn't update link tables properly (seen when user has "Auto-number headings" set) - 10https://bugzilla.wikimedia.org/29585#c30 (10Bawolff (Brian Wolff)) *** Bug 72594 has been marked as a duplicate of this bug. *** [20:46:46] haha [20:47:18] RoanKattouw, is its guess statistically significant? [20:48:22] (03PS5) 10Esanders: Create mwTables with wikitable attribute by default [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168961 [20:48:24] (03PS8) 10Esanders: Files and messages for table editing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167189 [20:48:26] (03PS2) 10Esanders: Factor out class <-> attribute mappings from BlockImageNode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169517 [20:48:30] (03CR) 10jenkins-bot: [V: 04-1] Create mwTables with wikitable attribute by default [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168961 (owner: 10Esanders) [20:48:34] (03CR) 10jenkins-bot: [V: 04-1] Files and messages for table editing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167189 (owner: 10Esanders) [20:49:57] (03CR) 10jenkins-bot: [V: 04-1] Factor out class <-> attribute mappings from BlockImageNode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169517 (owner: 10Esanders) [20:50:23] 3VisualEditor / 3ContentEditable: VE: IE11 - opacity is flawed - 10https://bugzilla.wikimedia.org/72643#c2 (10etonkovidova) The dialog box 'Are you sure?' which appears when switching from Edit mode to Read is transparent too. [20:50:55] Hey RoanKattouw, Betalabs seems to be still throwing 503 error for me [20:51:24] ryasmeen: Oh crap I promised Elena I'd look at that [20:52:01] yeah, we cant really test anything on Betalabs now [20:53:19] I'll look at it now [20:53:29] okay thanks :) [21:00:41] 3VisualEditor / 3ContentEditable: VE: IE 11 - editing with keyboard Backspace causes the screen scroll up - 10https://bugzilla.wikimedia.org/72646 (10etonkovidova) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce: Open any page in VE with IE11 - scroll to the bottom of the page and try to delete... [21:11:46] ryasmeen: OK so Parsoid in labs is seriously screwed up. I'm going to eat lunch and then I'm going to try to build a new Parsoid server and switch over to it [21:16:23] 3VisualEditor / 3ContentEditable: VE: IE 11 - editing with keyboard Backspace causes the screen scroll up - 10https://bugzilla.wikimedia.org/72646#c1 (10Bartosz Dziewoński) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 71119 *** [21:16:23] 3VisualEditor / 3ContentEditable: VisualEditor: Pressing "Backspace" causes the page to abruptly scroll up on IE 11 - 10https://bugzilla.wikimedia.org/71119#c6 (10Bartosz Dziewoński) *** Bug 72646 has been marked as a duplicate of this bug. *** [21:18:33] okay thanks a lot RoanKattouw! [21:49:00] (03PS1) 10Jforrester: Remove font-size: 0.8em; rule for OOUI change [VisualEditor/VisualEditor] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/169589 [21:49:20] (03Abandoned) 10Jforrester: Remove font-size: 0.8em; rule for OOUI change [VisualEditor/VisualEditor] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/169589 (owner: 10Jforrester) [22:16:41] (03PS1) 10SuchetaG: Introducing getTitle() in MWTitleInputWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169603 (https://bugzilla.wikimedia.org/72468) [22:21:35] (03CR) 10Catrope: [C: 04-1] Introducing getTitle() in MWTitleInputWidget (034 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169603 (https://bugzilla.wikimedia.org/72468) (owner: 10SuchetaG) [22:22:02] (03CR) 10jenkins-bot: [V: 04-1] Introducing getTitle() in MWTitleInputWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169603 (https://bugzilla.wikimedia.org/72468) (owner: 10SuchetaG) [22:27:21] RoanKattouw: I'm interested in your opinion about this: I need a functionality of getFilename method of ve.dm.MWImageNode - but it is not static (cause it needs this) [22:27:33] so, I'm thinking about galling it in this way: ve.dm.MWImageNode.prototype.getFilename.apply( itemModel ) [22:27:34] thoughts? [22:28:16] What kind of object is itemModel? [22:28:38] It's a GalleryItem - very similar to BlockImageNode [22:28:52] It is even initialized from same Parsoid DOM node [22:29:52] Ooh of course, right [22:30:22] Hmm it's probably best to break the logic out into a static function, then make getFilename() do return this.constructor.static.whatever( this.getAttribute( 'resource' ) ) ; [22:32:14] (03PS2) 10SuchetaG: Introducing getTitle() in MWTitleInputWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169603 (https://bugzilla.wikimedia.org/72468) [22:32:33] probably sounds good [22:32:40] and I like the name "whatever" [22:32:42] good call [22:33:30] (03CR) 10jenkins-bot: [V: 04-1] Introducing getTitle() in MWTitleInputWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169603 (https://bugzilla.wikimedia.org/72468) (owner: 10SuchetaG) [22:34:47] 22:33:11 Warning: /srv/ssd/jenkins-slave/workspace/mwext-VisualEditor-doc-test/modules/ve-mw/ui/widgets/ve.ui.MWTitleInputWidget.js:129: Unknown type mw.Title|null [22:34:52] Oh FFS jsduck you gotta be kidding me [22:35:19] Do we really have no other code that's documented as @returns {mw.Title} ?! [22:35:34] * RoanKattouw grumbles loudly and tries to fix it [22:35:36] ( sucheta --^^ ) [22:40:27] Well. -.- [22:41:22] @return {Object} [22:41:24] solved! [22:41:25] :> [22:42:17] Yeah I'm trying to convince jsduck that mw.Title exists, I think I'm almost there [22:42:24] @return {Something} [22:43:04] @return {ve.NoneOfYourBusiness} [22:43:38] :D [22:45:13] OK I have a jsduck fix [22:47:02] (03PS1) 10Catrope: Convince jsduck mw.Title exists [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169617 [22:47:57] Krinkle: Could you review https://gerrit.wikimedia.org/r/169617 ? I'm sure I did something wrong somewhere [22:48:06] (03PS3) 10SuchetaG: Introducing getTitle() in MWTitleInputWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169603 (https://bugzilla.wikimedia.org/72468) [22:48:08] I appear to have created two categories called "Upstream", for one thing :( [22:48:16] (03CR) 10jenkins-bot: [V: 04-1] Convince jsduck mw.Title exists [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169617 (owner: 10Catrope) [22:48:23] Oh and it V-1s [22:48:25] Well that's bad news [22:48:39] Oh the irony [22:48:45] Indeed. [22:48:52] It's a double line break [22:48:55] Thanks jscs [22:49:01] And when I say "thanks" I mean FU [22:49:22] (03CR) 10jenkins-bot: [V: 04-1] Introducing getTitle() in MWTitleInputWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169603 (https://bugzilla.wikimedia.org/72468) (owner: 10SuchetaG) [22:49:27] (03PS2) 10Catrope: Convince jsduck mw.Title exists [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169617 [22:50:03] sucheta: If you rebase your commit on top of mine it should stop V-1ing [22:50:05] Hopefully [22:50:16] * RoanKattouw is not particularly trusting of his Jenkins mastery today [22:52:13] Also, titleObj looks weirdly placed in the changeset... [22:53:17] Looks fine to me [22:53:26] But then I'm one of those old-fashioned people who uses tab size 8 [22:53:54] Oh, hey hold on, I do see something else weird [22:54:18] (03CR) 10Catrope: [C: 04-1] Introducing getTitle() in MWTitleInputWidget (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169603 (https://bugzilla.wikimedia.org/72468) (owner: 10SuchetaG) [22:55:01] RoanKattouw: well, there is already an Upstream group defined in categories.json, below [22:55:17] Oh, right [22:56:09] MatmaRex: Yeah I was hoping it would merge them [22:56:22] But apparently the grunt step doesn't have smartness for that, and neither does jsduck itself [23:01:31] RoanKattouw: What do you mean? [23:01:57] RoanKattouw: Ah, I see. I was confused since tests are passing on master (for jsduck) [23:02:03] should probably be moved to the relevant patch set [23:02:07] RoanKattouw: Yeah, this won't wor [23:02:21] add it to ignored externals instead of defining in external.js [23:02:35] like the browser globals etc. [23:02:57] Hm.. or not. Let me see what works best here [23:04:05] Dang, the puppetization for Parsoid in labs is pretty broken [23:10:58] (03CR) 10Krinkle: Convince jsduck mw.Title exists (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169617 (owner: 10Catrope) [23:11:38] (03PS4) 10SuchetaG: Introducing getTitle() in MWTitleInputWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169603 (https://bugzilla.wikimedia.org/72468) [23:13:14] (03CR) 10Krinkle: [C: 04-1] Convince jsduck mw.Title exists (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169617 (owner: 10Catrope) [23:13:47] (03CR) 10jenkins-bot: [V: 04-1] Introducing getTitle() in MWTitleInputWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169603 (https://bugzilla.wikimedia.org/72468) (owner: 10SuchetaG) [23:16:29] (03PS5) 10SuchetaG: Introducing getTitle() in MWTitleInputWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169603 (https://bugzilla.wikimedia.org/72468) [23:22:45] (03CR) 10Catrope: Convince jsduck mw.Title exists (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169617 (owner: 10Catrope) [23:29:16] ryasmeen: I'm getting close to fixing Parsoid in beta here, probably another ~15 mins or so [23:29:30] It was completely broken beyond repair so I had to rebuild it from scratch [23:29:34] and rediscover a few horrible things about it [23:41:28] (03PS1) 10SuchetaG: Introducing isValid() in MWTitileInputWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169623 (https://bugzilla.wikimedia.org/71249) [23:44:32] (03PS2) 10SuchetaG: Introducing isValid() in MWTitileInputWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169623 (https://bugzilla.wikimedia.org/71249) [23:45:04] (03CR) 10Catrope: Introducing isValid() in MWTitileInputWidget (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169623 (https://bugzilla.wikimedia.org/71249) (owner: 10SuchetaG) [23:45:09] sucheta: Hah, you're too fast for me :P [23:45:28] I know, right :P [23:45:29] The class name thing you fixed in PS2 happens all the time [23:45:37] It's in like 25% of James's patches [23:46:42] (03CR) 10Cmcmahon: "add Zeljko and Dan as reviewers" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169251 (owner: 10Ryasmeen) [23:48:53] (03PS3) 10SuchetaG: Introducing isValid() in MWTitileInputWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169623 (https://bugzilla.wikimedia.org/71249) [23:49:32] Kinda sorta embarrassing [23:50:26] But whatever embarrassing thing I do at 5:19am, doesn't count [23:50:31] Well, also [23:50:37] If everybody else does it, it doesn't count [23:50:40] ;) [23:50:51] I'm pretty sure literally every team member has done this at least once [23:51:17] (03CR) 10Catrope: [C: 032] Introducing getTitle() in MWTitleInputWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169603 (https://bugzilla.wikimedia.org/72468) (owner: 10SuchetaG) [23:51:18] K then, cheers to all! :P [23:51:22] (03CR) 10Catrope: [C: 032] Introducing isValid() in MWTitileInputWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169623 (https://bugzilla.wikimedia.org/71249) (owner: 10SuchetaG) [23:51:33] Now I just have to fix my jsduck thing to Krinkle's satisfaction [23:51:40] And bring Parsoid in beta back, maybe I should do that first [23:52:06] Isn't it awesome when unit tests show you not only that your code sucks, but exactly where? [23:52:17] * mooeypoo mutters and blames $.extend() [23:52:49] And so colorfully [23:53:07] (03Abandoned) 10Mooeypoo: Ignore empty strings in array union [oojs/core] - 10https://gerrit.wikimedia.org/r/169201 (owner: 10Mooeypoo) [23:53:19] sucheta, yes, there's that! That is a nice plus, indeed. [23:53:43] sucheta, isn't it like... 6am or something? [23:53:55] mooeypoo, 5:23 [23:53:58] I thought i was the only one who stayed up to those wee hours of the morning. [23:54:33] mooeypoo, I have like, absolutely _ no_ sleep pattern. [23:55:17] sucheta, I had that too, and then I settled for a bad sleep pattern \o/ [23:56:31] mooeypoo: Noooo [23:56:35] Everyone in the team does that [23:56:38] Except James [23:56:47] James has a bad weekend pattern. [23:56:56] Working at, like, 8am on a Sunday. [23:57:06] I usually talk to David between midnight and 2am [23:57:20] He'll sometimes message me at 3am apologizing that he fell asleep at 10pm or something [23:57:26] haha [23:57:51] The first time he was here in SF, he had bad jetlag and wrote most of his code at 4am [23:58:23] ryasmeen|Away: I know it's a bit late, but just so you know, Parsoid is back in beta now. Finally. Sigh. [23:58:25] Yeah jetlag will do that [23:58:45] So weekends, hah: Saturday I woke up at 2:30am, and Sunday at 3:30pm [23:59:06] Yeah I have done that before [23:59:12] I don't even know...what cycle was that [23:59:18] For some reason that sounds a lot better than waking up at 7am on a Sunday [23:59:22] "Yay it's the weekend! Now I can stay up till 4am! ... and then ruin the daytime" [23:59:35] "Daytime" is an interesting concept. [23:59:37] 2:30am! [23:59:39] sucheta: Was that a typo for 2:30pm? [23:59:42] Or actually 2:30am? [23:59:47] No! [23:59:50] WHAT