[00:00:15] <RoanKattouw>	 So your wakeup time shifted 13 hours in one day?
[00:00:24] <RoanKattouw>	 That's more than the time difference between India and SF
[00:00:35] <sucheta>	 I don't really calculate anymore 
[00:00:40] <RoanKattouw>	 Were you practicing for beating jetlag? :P
[00:01:18] <sucheta>	 I am actually intrigues to see how jetlag is going to affect me this time
[00:01:38] <sucheta>	 *intrigued 
[00:01:57] <RoanKattouw>	 Well as you requested I will be keeping you awake
[00:01:59] <RoanKattouw>	 (and active)
[00:02:52] <sucheta>	 Yes! Seafood!
[00:03:16] <RoanKattouw>	 Yes!
[00:03:22] <mooeypoo>	 Yes!
[00:03:27] <mooeypoo>	 oh.. sorry, just wanted to join in.
[00:03:29] <RoanKattouw>	 ...they also have non-seafood there, but if you get excited about seafood, then yes, seafood!
[00:03:42] <sucheta>	 mooeypoo, Please do. 
[00:03:56] <RoanKattouw>	 mooeypoo will be leading me from restaurant to restaurant the week after next actually
[00:04:01] * mooeypoo nods
[00:04:07] <RoanKattouw>	 The week after I do the same to sucheta 
[00:04:46] <mooeypoo>	 We're switching hosting roles
[00:05:16] <RoanKattouw>	 Yup
[00:06:31] <sucheta>	 The universe gets a shade brighter when I think about good food. Oh joy 
[00:06:34] <RoanKattouw>	 mooeypoo: BTW just to confirm I will be showing up at JFK at 3:27pm on November 8th with the plan of staying at your place that night
[00:06:43] * mooeypoo nods
[00:06:56] <mooeypoo>	 Do you need me to pick you up from JFK ?
[00:06:56] <RoanKattouw>	 So could you send me transit directions or an address or something (in private obviously) some time before that?
[00:07:01] <mooeypoo>	 yup
[00:08:34] <sucheta>	 Maybe mooeypoo should make a trip to Boston as well 
[00:08:46] <sucheta>	 ^_^
[00:09:58] <mooeypoo>	 When are you in Boston sucheta ?
[00:10:09] <sucheta>	 Nov 7 - Nov 23
[00:10:26] <sucheta>	 Nov 8 - Nov 23
[00:10:52] <mooeypoo>	 ooo
[00:10:54] <RoanKattouw>	 I was thinking of Boltbussing up for a day
[00:11:01] <mooeypoo>	 That's when Roan's here. Partially
[00:11:01] <RoanKattouw>	 Like, maybe Nov 12 or 13
[00:11:25] <RoanKattouw>	 But I have been lazy about asking people if I can crash
[00:14:41] <sucheta>	 I should send out an email to all our Boston folks; add RoanKattouw and mooeypoo to the list; figure out a date when we could have some wmf fun
[00:14:59] <RoanKattouw>	 Yeah
[00:15:40] <RoanKattouw>	 That would be cool
[00:15:52] <sucheta>	 I'll do that 
[00:16:27] <Krenair>	 RoanKattouw, so for https://bugzilla.wikimedia.org/show_bug.cgi?id=63341 I'm wondering if we actually just want to remove the transclusion node if it contains only empty content parts
[00:16:34] <RoanKattouw>	 I just messaged a mutual friend of ours in Boston; if the response is good then I think I'll have crash plans for both myself and mooeypoo 
[00:16:50] <mooeypoo>	 ooh 
[00:16:54] <mooeypoo>	 Boston is beautiful
[00:17:02] <mooeypoo>	 also, sucheta, it ALSO has seafood!
[00:17:18] <RoanKattouw>	 Krenair: My idea there was that such transclusions should not be insertable from scratch, but if you apply changes it should remove the node
[00:17:27] <Krenair>	 ok
[00:17:46] <RoanKattouw>	 Krenair: I think that's the same as what you already did for when there are 0 parts?
[00:18:14] <Krenair>	 to make it remove an existing node like that...
[00:18:59] <RoanKattouw>	 It's similar to inspectors where, say, setting a comment's contents to empty removes the comment
[00:19:28] <Krenair>	 MWTransclusionModel#updateTransclusionNode removes if getPlainObject returns null. getPlainObject will return null if all parts serialize to undefined (or there were no parts). could make an empty content part serialize to undefined?
[00:19:41] <RoanKattouw>	 I guess so?
[00:19:48] <RoanKattouw>	 But why would anything ever serialize to undefined?
[00:19:55] <RoanKattouw>	 Seems like a strange value to unserialize to
[00:19:58] <Krenair>	 yeah...
[00:20:30] <RoanKattouw>	 mooeypoo: Alternatively, if you're also interested in going to Boston, then car rental might be cheaper than Boltbus and then we wouldn't have to stay the night
[00:21:37] <Krenair>	 template placeholders do that, actually
[00:22:10] <RoanKattouw>	 Ooh rigth
[00:22:13] <RoanKattouw>	 That's clever
[00:22:34] <RoanKattouw>	 Yeah in that spirit, maybe templates with no params, and content parts with no content should serialize to undefined?
[00:22:43] <Krenair>	 (MWTransclusionPartModel#serialize returns undefined, and template placeholders don't override this)
[00:22:45] <RoanKattouw>	 Sorry, not templates with no params obviously
[00:22:47] <RoanKattouw>	 Ignore that
[00:22:58] <Krenair>	 :)
[00:22:58] <RoanKattouw>	 (You need to be able to do {{done}})
[00:23:27] <Krenair>	 or we can make getPlainObject check for serialize returning ''
[00:23:40] <RoanKattouw>	 Yes
[00:23:43] <RoanKattouw>	 That would probably be better
[00:24:33] <Krenair>	 as for preventing you from inserting a new transclusion containing only empty content parts, by disabling the 'Insert' button...
[00:24:35] <grrrit-wm>	 (03PS3) 10Catrope: Convince jsduck mw.Title exists [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169617 
[00:24:57] <RoanKattouw>	 Wouldn't that all fall in the same category?
[00:25:21] <RoanKattouw>	 The parts all serialize to '' or undefined, so we both disable insert, and make apply changes remove
[00:25:28] <RoanKattouw>	 I feel like the former was done like last week?
[00:25:52] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Convince jsduck mw.Title exists [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169617 (owner: 10Catrope)
[00:26:43] <Krenair>	 I was only checking number of parts
[00:29:01] <Krenair>	 and wouldn't we need to check this on every content part input change..?
[00:31:06] <RoanKattouw>	 Urgh I guess so
[00:31:18] <RoanKattouw>	 Which I guess we don't currently have the event infrastructure for?
[00:32:37] <Krenair>	 I don't think so
[01:05:58] <grrrit-wm>	 (03PS4) 10Jforrester: [WIP] MWHeading: Don't put self in output if contents are blank or whitespace [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/162310 (https://bugzilla.wikimedia.org/49452) 
[01:07:17] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [WIP] MWHeading: Don't put self in output if contents are blank or whitespace [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/162310 (https://bugzilla.wikimedia.org/49452) (owner: 10Jforrester)
[01:08:38] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Remove transclusion node if we were just going to set it to empty content - 10https://bugzilla.wikimedia.org/63341 (10Alex Monk)
[01:10:20] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] "Code looks good, but:" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169517 (owner: 10Esanders)
[01:10:35] <grrrit-wm>	 (03PS1) 10Alex Monk: MWTransclusionModel: Exclude parts serialising to '' from the plain object [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169638 (https://bugzilla.wikimedia.org/63341) 
[01:16:55] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] "I present to you, the most nitpicky -1 of all time" (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169623 (https://bugzilla.wikimedia.org/71249) (owner: 10SuchetaG)
[01:20:24] <grrrit-wm>	 (03PS4) 10Catrope: Convince jsduck mw.Title exists [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169617 
[01:46:00] <grrrit-wm>	 (03PS1) 10Alex Monk: Remove more references to ve.bind [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169644 (https://bugzilla.wikimedia.org/72156) 
[02:24:53] <wikibugs>	 3VisualEditor / 3Technical Debt: VisualEditor: Remove ve.bind() - 10https://bugzilla.wikimedia.org/72156 (10James Forrester)
[02:42:08] <wikibugs>	 3VisualEditor / 3Editing Tools: In HTML+RDFa DOM, make the 'params' block give a 'normalised' version of the parameter name (like done for template) - 10https://bugzilla.wikimedia.org/67657 (10James Forrester) a:3Alex Monk
[02:45:42] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: When user is saving a page subsequently deleted after they started editing, show them <confirmrecreate‎> - 10https://bugzilla.wikimedia.org/52073 (10James Forrester) a:3Alex Monk
[02:46:54] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: Invocation of "lastmodifiedat" message is not updated when page is saved - 10https://bugzilla.wikimedia.org/52403 (10James Forrester) a:3Alex Monk
[02:47:40] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: When editing a file/category page, show the non-page composite components outside the VE surface in their "normal" place - 10https://bugzilla.wikimedia.org/56289 (10James Forrester) a:3Alex Monk
[02:48:55] <James_F>	 RoanKattouw: https://gerrit.wikimedia.org/r/#/c/123875/2
[02:51:38] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: Implement some form of auto-save - 10https://bugzilla.wikimedia.org/55370 (10James Forrester)
[02:51:40] <wikibugs>	 3VisualEditor / 3Data Model: VisualEditor: Be able to serialise the linear model - 10https://bugzilla.wikimedia.org/72658 (10James Forrester) 3ASSI p:3Unprio s:3enhanc a:3None For bug 55370 and others.
[02:51:53] <wikibugs>	 3VisualEditor / 3Data Model: VisualEditor: Be able to serialise the linear model - 10https://bugzilla.wikimedia.org/72658 (10James Forrester) p:5Unprio>3High
[03:04:09] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Create dedicated input methods for transclusion parameters (using "Param#type" from TemplateData) - 10https://bugzilla.wikimedia.org/53613 (10Alex Monk) a:3Alex Monk
[03:37:05] <grrrit-wm>	 (03CR) 10Krinkle: [C: 032] Convince jsduck mw.Title exists [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169617 (owner: 10Catrope)
[03:38:18] <grrrit-wm>	 (03Merged) 10jenkins-bot: Convince jsduck mw.Title exists [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169617 (owner: 10Catrope)
[03:49:01] <grrrit-wm>	 (03CR) 10Krinkle: [C: 04-1] Remove more references to ve.bind (034 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169644 (https://bugzilla.wikimedia.org/72156) (owner: 10Alex Monk)
[04:26:09] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Applying a rich annotation to an image causes inspector to open then close quickly in Chrome; die in Firefox - 10https://bugzilla.wikimedia.org/72431#c3 (10Ritu Swain) (In reply to James Forrester from comment #2) > I believe that this is describing intentional...
[04:27:39] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Applying a rich annotation to an image causes inspector to open then close quickly in Chrome; die in Firefox - 10https://bugzilla.wikimedia.org/72431#c4 (10Ritu Swain) Created attachment 16939   --> https://bugzilla.wikimedia.org/attachment.cgi?id=16939&action=...
[04:49:55] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor:[Regression]clicking on an image with wikilink , opens up link inspector - 10https://bugzilla.wikimedia.org/72660 (10Ritu Swain) 3UNCO p:3Unprio s:3normal a:3None Created attachment 16940   --> https://bugzilla.wikimedia.org/attachment.cgi?id=16940&actio...
[04:50:08] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor:[Regression]clicking on an image with wikilink , opens up link inspector - 10https://bugzilla.wikimedia.org/72660 (10Ritu Swain)
[04:50:23] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor:[Regression]clicking on an image with wikilink , opens up link inspector - 10https://bugzilla.wikimedia.org/72660#c1 (10Ritu Swain) Also see 72431.
[04:50:52] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor:[Regression]clicking on an image with wikilink , opens up link inspector - 10https://bugzilla.wikimedia.org/72660#c2 (10Ritu Swain) (In reply to Ritu Swain from comment #1) > Also see 72431. https://bugzilla.wikimedia.org/show_bug.cgi?id=72431
[04:51:37] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Applying a rich annotation to an image causes inspector to open then close quickly in Chrome; die in Firefox - 10https://bugzilla.wikimedia.org/72431#c5 (10Ritu Swain) Also see 72660, https://bugzilla.wikimedia.org/show_bug.cgi?id=72660
[05:58:54] <grrrit-wm>	 (03PS6) 10Divec: WIP: Show entire expandable call tree in ve.Filibuster [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167021 
[06:48:02] <grrrit-wm>	 (03PS5) 10Mooeypoo: [Extremely WIP] Eventify TemplateDataGenerator and use oojs-ui [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 
[06:48:05] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [Extremely WIP] Eventify TemplateDataGenerator and use oojs-ui [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 (owner: 10Mooeypoo)
[07:45:56] <grrrit-wm>	 (03PS12) 10Divec: Make setSelection emit activeAnnotationChange if continuation unicorns may be needed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168327 (https://bugzilla.wikimedia.org/72108) 
[08:18:44] <grrrit-wm>	 (03PS13) 10Divec: Make setSelection emit activeAnnotationChange if continuation unicorns may be needed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168327 (https://bugzilla.wikimedia.org/72108) 
[09:03:08] <grrrit-wm>	 (03CR) 10Esanders: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168060 (owner: 10Esanders)
[09:04:33] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] Apex, MediaWiki themes: Move colour definitions into LESS variables [oojs/ui] - 10https://gerrit.wikimedia.org/r/164389 (owner: 10Jforrester)
[09:06:34] <grrrit-wm>	 (03Merged) 10jenkins-bot: Apex, MediaWiki themes: Move colour definitions into LESS variables [oojs/ui] - 10https://gerrit.wikimedia.org/r/164389 (owner: 10Jforrester)
[09:07:26] <grrrit-wm>	 (03CR) 10Esanders: [C: 031] "LGTM but Roan doesn't want to merge yet?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/169286 (owner: 10Catrope)
[09:08:19] <grrrit-wm>	 (03CR) 10Esanders: Factor out class <-> attribute mappings from BlockImageNode (033 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169517 (owner: 10Esanders)
[09:14:10] <wikibugs>	 3VisualEditor: make page titles editable - 10https://bugzilla.wikimedia.org/72665 (10Martijn Hoekstra) 3NEW p:3Unprio s:3enhanc a:3None An often encountered hurdle for new editors is that they can't find out how to move a page. Generally they ask how to "change the title". Apparently - and understandab...
[09:17:21] <grrrit-wm>	 (03PS1) 10Esanders: Provide a generic mechanism for mapping classes to attributes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/169661 
[09:20:15] <grrrit-wm>	 (03PS2) 10Esanders: Provide a generic mechanism for mapping classes to attributes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/169661 
[09:25:13] <grrrit-wm>	 (03PS6) 10Esanders: Create mwTables with wikitable attribute by default [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168961 
[09:25:15] <grrrit-wm>	 (03PS9) 10Esanders: Files and messages for table editing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167189 
[09:25:17] <grrrit-wm>	 (03PS3) 10Esanders: Use ClassAttributeNode mixin in MWBlockImageNode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169517 
[09:25:21] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Create mwTables with wikitable attribute by default [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168961 (owner: 10Esanders)
[09:25:25] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Files and messages for table editing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167189 (owner: 10Esanders)
[09:26:28] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Use ClassAttributeNode mixin in MWBlockImageNode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169517 (owner: 10Esanders)
[09:28:39] <grrrit-wm>	 (03CR) 10Esanders: [C: 04-1] "comment on PS11 (ve.ce.surface.js)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168327 (https://bugzilla.wikimedia.org/72108) (owner: 10Divec)
[09:37:25] <grrrit-wm>	 (03CR) 10Esanders: Make setSelection emit activeAnnotationChange if continuation unicorns may be needed (033 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168327 (https://bugzilla.wikimedia.org/72108) (owner: 10Divec)
[09:41:07] <grrrit-wm>	 (03CR) 10Esanders: Make setSelection emit activeAnnotationChange if continuation unicorns may be needed (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168327 (https://bugzilla.wikimedia.org/72108) (owner: 10Divec)
[09:43:02] <grrrit-wm>	 (03PS1) 10Amire80: Disable two failing scenarios [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169664 
[09:44:56] <grrrit-wm>	 (03PS2) 10Zfilipin: [BrowserTest] Disable two failing scenarios [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169664 (owner: 10Amire80)
[09:45:10] <grrrit-wm>	 (03CR) 10Zfilipin: [C: 032] [BrowserTest] Disable two failing scenarios [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169664 (owner: 10Amire80)
[09:46:24] <grrrit-wm>	 (03Merged) 10jenkins-bot: [BrowserTest] Disable two failing scenarios [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169664 (owner: 10Amire80)
[10:21:39] <Silke_WMDE>	 Hello!
[10:21:41] <Silke_WMDE>	 :)
[10:22:00] <Silke_WMDE>	 Guess who can't get Visual Editor to work.
[10:23:06] <Silke_WMDE>	 If there is anyone around with some advice for further debugging, that would be cool and it would WMDE staff happy because it's for the internal wiki.
[10:24:00] <Silke_WMDE>	 I did a successful edit yesterday, but it no longer works now.
[10:35:06] <Silke_WMDE>	 (Alternatively, thanks for pointing me at any sort of help place which is not the talk page with dozens ofquestions and no answers. ;)
[10:50:26] <edsanders>	 Hi
[10:50:34] <edsanders>	 Silke_WMDE, what's the problem?
[10:54:35] <Silke_WMDE>	 hi edsanders.
[10:55:19] <Silke_WMDE>	 the editor tries to load but fails. I read the debugging hints and the 
[10:55:30] <Silke_WMDE>	 curl -L http://127.0.0.1:8142/localhost/Hauptseite fails
[10:55:32] <grrrit-wm>	 (03CR) 10Zfilipin: [BrowserTest] WIP adding cases to test other options under Page Settings to options.feature (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169251 (owner: 10Ryasmeen)
[10:55:56] <Silke_WMDE>	 it says API response is missing query for: Hauptseite
[10:56:28] <Silke_WMDE>	 it's a private wiki, parsoid is running on the same server as the wiki
[10:56:40] <Silke_WMDE>	 the cookie setting is turned on
[10:57:08] <wikibugs>	 3VisualEditor / 3Language: VisualEditor: Support for right-to-left (rtl) / bidirectional content (tracking) - 10https://bugzilla.wikimedia.org/33126 (10Amir E. Aharoni)
[10:57:10] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: A template editing bubble appears off-screen for a left-aligned infobox in the Hebrew Wikipedia - 10https://bugzilla.wikimedia.org/72668 (10Amir E. Aharoni) 3NEW p:3Unprio s:3normal a:3None To reproduce:  1. Edit the Hebrew Wikipedia article about...
[11:01:38] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: automatically convert URLs to readable links - 10https://bugzilla.wikimedia.org/65540#c2 (10marielle.volz) This could potentially inform the VE UI for citoid;  I.e. we could have have one reference dialog, (i.e. the basic reference dialog) and then if a user past...
[11:01:39] <Silke_WMDE>	 right now, I'm reading the parsoid talk page to make the api accessible on localhost
[11:04:49] <edsanders>	 hmm
[11:05:20] <edsanders>	 is the parsoid web service working?
[11:05:40] <Silke_WMDE>	 yes
[11:06:16] <Silke_WMDE>	 erm... I think so.
[11:08:22] <Silke_WMDE>	 edsanders: how do I check that? parsoid is running, but what web service?
[11:08:48] <edsanders>	 I think the default is port 8000
[11:08:52] <edsanders>	 localhost:8000
[11:12:44] <Silke_WMDE>	 ah. so no. not working
[11:15:19] <Silke_WMDE>	 edsanders: I followed the Ubuntu instructions, so I'm on port 8142 -> if that's the thing we are talking about.
[11:15:34] <Silke_WMDE>	 and that one is working
[11:22:58] <Silke_WMDE>	 edsanders: parsoid log tells me that it parses the page I'm trying to edit. I see bits of the content so it can access the wiki at least.
[11:23:32] <edsanders>	 sounds promising
[11:23:51] <edsanders>	 what is the exact error message?
[11:25:56] <Silke_WMDE>	 I don't get any error message. The last thing is "[info][localhost/Benutzer:Silke_Meyer/Notizen?oldid=75607] completed parsing in 65 ms"
[11:26:30] <Silke_WMDE>	 then the editor loads and loads but no more messages
[12:26:17] <burntsushi__>	 Silke_WMDE: were you able to get it working? if not, are there any javascript errors reported in the browser when you try to edit a page?
[12:29:00] <Silke_WMDE>	 burntsushi__: yes. "TypeError: $(...).inputAutoExpand is not a function"  (load.php:7)
[12:31:40] <burntsushi__>	 Silke_WMDE: that's strange. i haven't seen that one before. what version of mediawiki/VE are you running?
[12:32:00] <grrrit-wm>	 (03PS58) 10Paladox: WikiEditor: Convert .css to .less and also fixes SVG issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) 
[12:34:47] <Silke_WMDE>	 burntsushi__: mediawiki 1.23.5 (tag) and VE REL1_23 branch
[12:36:13] <burntsushi__>	 Silke_WMDE: ah, yeah, i've never been able to get REL1_23 working. i'm running everything on 1.25wmf3.
[12:36:22] <Silke_WMDE>	 lol
[12:36:27] <burntsushi__>	 (i try to keep pace with Wikipedia)
[12:37:06] <Silke_WMDE>	 ok, so maybe I'll switch versions, too.
[12:37:27] <Silke_WMDE>	 (I did ONE edit yesterday, though.)
[12:38:26] <wikibugs>	 3VisualEditor / 3Language: VisualEditor: Support for right-to-left (rtl) / bidirectional content (tracking) - 10https://bugzilla.wikimedia.org/33126 (10Amir E. Aharoni)
[12:38:28] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Edit notices popup shows out of screen in RTL - 10https://bugzilla.wikimedia.org/72673 (10Amir E. Aharoni) 3NEW p:3Unprio s:3normal a:3None Created attachment 16941   --> https://bugzilla.wikimedia.org/attachment.cgi?id=16941&action=edit a screenshot with...
[12:57:05] <grrrit-wm>	 (03PS1) 10Mvolz: Restructured url endpoint calls, fixed unshorten [services/citoid] - 10https://gerrit.wikimedia.org/r/169690 
[13:37:09] <Silke_WMDE>	 "non-standard systems like Windows or Debian" is an interesting wording btw. 
[13:40:20] <grrrit-wm>	 (03PS1) 10Esanders: Replace native range rectangle hacks with RangeFix library [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/169696 
[13:43:08] <grrrit-wm>	 (03PS2) 10Esanders: Replace native range rectangle hacks with RangeFix library [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/169696 
[13:49:29] <grrrit-wm>	 (03CR) 10Esanders: "Maybe I should call this library Rangier?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/169696 (owner: 10Esanders)
[14:13:07] <grrrit-wm>	 (03PS2) 10Alex Monk: Remove more references to ve.bind [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169644 (https://bugzilla.wikimedia.org/72156) 
[15:45:54] <Elitre>	 hello. is anybody around to help me add a character to a special character list?
[15:51:17] <Krenair>	 Elitre, hi
[15:52:43] <Elitre>	 hi :)
[15:53:55] <Krenair>	 Isn't that a case of simply modifying MediaWiki:MediaWiki:Visualeditor-specialcharinspector-characterlist-insert? (I haven't had to do this myself before...)
[15:54:23] <Elitre>	 I must have done something horribly wrong at https://de.wikipedia.org/wiki/MediaWiki:Visualeditor-specialcharinspector-characterlist-insert though...
[15:55:59] <Elitre>	 I mean, it works, but the code doesn't look right.
[15:58:02] <Krenair>	 well, if it works...
[15:59:47] <Elitre>	 I'm sure James_F|Away will take a look when he's back and if he needs to change anything there, he'll scold me in the edit summary :)
[16:15:44] * James_F waves.
[16:16:06] <James_F>	 Elitre: Looks fine from my POV… what's wrong about it?
[16:30:45] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on nowiki: https://no.wikipedia.org/?diff=13487851
[16:30:45] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=108607536
[16:30:45] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=108632549
[16:30:45] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=33113171
[16:30:45] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=33113246
[16:30:46] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=33114185
[16:30:46] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=33114204
[16:30:47] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=33114220
[16:30:47] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=66480316
[16:30:48] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=66484569
[16:30:48] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on ptwiki: https://pt.wikipedia.org/?diff=40400835
[16:30:49] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on ptwiki: https://pt.wikipedia.org/?diff=40406528
[16:31:14] * James_F sighs.
[16:33:23] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: Provide a way to move pages through interacting with the displayed title - 10https://bugzilla.wikimedia.org/72665#c1 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal Hmm. I like this idea. Could get a bit complicated where "sometimes" it is moving...
[16:34:23] <Krenair>	 that first ptwiki one with <nowiki>s is strange
[16:34:56] <James_F>	 You mean "<ref><nowiki>[http://www.centrofic.org/intencionalidade/ |Intencionalidade – John Searle]</nowiki>  -  Edição brasileira: Intencionalidade, São Paulo, Mar­tins Fontes, 1995.  Estudo: F. Recanati, <em>Les enoncés performatifs</em>, Éd. de Minuit, 1983.</ref>"?
[16:35:16] * Elitre pats James_F back.
[16:35:34] <James_F>	 It looks to me like they pasted in some content (<em>s are a clue), and that content broke somehow?
[16:35:45] <James_F>	 Or they literally pasted in some pre-written wikitext.
[16:36:30] <Elitre>	 James_F: https://de.wikipedia.org/w/index.php?title=MediaWiki%3AVisualeditor-specialcharinspector-characterlist-insert&diff=135331574&oldid=131793525 looked "odd" to me. but if you say it's fine, it's fine.
[16:37:23] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Edit notices popup shows out of screen in RTL - 10https://bugzilla.wikimedia.org/72673#c1 (10etonkovidova) p:5Unprio>3Normal Confirmed on https://he.wikipedia.org/w/index.php?title=ASCII&oldid=15904477&veaction=edit   Both 'Page options' and 'Help' boxes are...
[16:37:32] <James_F>	 Elitre: Oh, that's just the JSON editor being fussy.
[16:37:47] <James_F>	 Elitre: We should probably investigate and fix, I suppose.
[16:37:50] * James_F sighs.
[16:39:29] <Elitre>	 it was too good to be true :(
[16:44:04] <James_F>	 Elitre: It's fine, just clunky.
[16:55:05] <grrrit-wm>	 (03PS14) 10Divec: Make setSelection emit activeAnnotationChange if continuation unicorns may be needed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168327 (https://bugzilla.wikimedia.org/72108) 
[17:34:26] <grrrit-wm>	 (03CR) 10Esanders: "Bill and Ted guessed my patch number." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/169696 (owner: 10Esanders)
[17:36:40] <James_F>	 edsanders: :-)
[17:37:23] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor:  Category input box is too small (sometimes) - 10https://bugzilla.wikimedia.org/69574 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal
[17:40:16] <grrrit-wm>	 (03CR) 10Divec: "Greatly improves readability :-)" (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/169696 (owner: 10Esanders)
[17:50:51] <RoanKattouw>	 Krinkle|detached: Do we still need @static @inheritable for static properties?
[17:50:56] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Provide a generic mechanism for mapping classes to attributes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/169661 (owner: 10Esanders)
[17:52:49] <grrrit-wm>	 (03Merged) 10jenkins-bot: Provide a generic mechanism for mapping classes to attributes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/169661 (owner: 10Esanders)
[17:53:31] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] Replace native range rectangle hacks with RangeFix library (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/169696 (owner: 10Esanders)
[18:04:25] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor:[Regression]clicking on an image with wikilink , opens up link inspector - 10https://bugzilla.wikimedia.org/72660#c3 (10etonkovidova) 5UNCO>3NEW p:5Unprio>3Normal Confirmed that the bug exists in betalabs and test2.
[18:04:25] <wikibugs>	 3VisualEditor: Backspace key at end of document moves the cursor up a line - 10https://bugzilla.wikimedia.org/72689#c1 (10Adam Wight) Correction to the previous comment: this is the <backspace> key I'm talking about.
[18:04:25] <wikibugs>	 3VisualEditor: Delete key at end of document moves the cursor up a line - 10https://bugzilla.wikimedia.org/72689 (10Adam Wight) 3NEW p:3Unprio s:3normal a:3None * Document contains lots of text.  The last two lines are a heading, then one line of body. * Place the cursor at the end of the final line, a...
[18:04:27] <wikibugs>	 3VisualEditor: Forward delete key does crazy things - 10https://bugzilla.wikimedia.org/72690 (10Adam Wight) 3NEW p:3Unprio s:3major a:3None Pressing forward delete start randomly undoing my changes (with no way to redo them) and causing other bad crap to happen.  My document is trashed...  Hence I'm ma...
[18:04:28] <wikibugs>	 3VisualEditor: Backspace key at end of document moves the cursor up a line - 10https://bugzilla.wikimedia.org/72689 (10Adam Wight)
[18:10:19] <grrrit-wm>	 (03CR) 10Catrope: "Removing -2 because wmf6 branch has been cut now" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/169286 (owner: 10Catrope)
[18:10:49] <grrrit-wm>	 (03CR) 10Catrope: [BREAKING CHANGE] Unisolate dialogs (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/169286 (owner: 10Catrope)
[18:11:34] <grrrit-wm>	 (03CR) 10Catrope: [BREAKING CHANGE] Unisolate dialogs (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/169286 (owner: 10Catrope)
[18:12:06] <grrrit-wm>	 (03PS6) 10Catrope: Introducing getTitle() in MWTitleInputWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169603 (https://bugzilla.wikimedia.org/72468) (owner: 10SuchetaG)
[18:12:34] <grrrit-wm>	 (03PS4) 10Catrope: Introducing isValid() in MWTitileInputWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169623 (https://bugzilla.wikimedia.org/71249) (owner: 10SuchetaG)
[18:12:50] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Introducing getTitle() in MWTitleInputWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169603 (https://bugzilla.wikimedia.org/72468) (owner: 10SuchetaG)
[18:13:12] <grrrit-wm>	 (03CR) 10Esanders: [C: 04-1] "same as 13" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168327 (https://bugzilla.wikimedia.org/72108) (owner: 10Divec)
[18:13:59] <grrrit-wm>	 (03PS5) 10Catrope: Introducing isValid() in MWTitileInputWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169623 (https://bugzilla.wikimedia.org/71249) (owner: 10SuchetaG)
[18:14:07] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Introducing isValid() in MWTitileInputWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169623 (https://bugzilla.wikimedia.org/71249) (owner: 10SuchetaG)
[18:14:09] <grrrit-wm>	 (03Merged) 10jenkins-bot: Introducing getTitle() in MWTitleInputWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169603 (https://bugzilla.wikimedia.org/72468) (owner: 10SuchetaG)
[18:15:24] <grrrit-wm>	 (03Merged) 10jenkins-bot: Introducing isValid() in MWTitileInputWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169623 (https://bugzilla.wikimedia.org/71249) (owner: 10SuchetaG)
[18:16:01] <grrrit-wm>	 (03CR) 10Esanders: Replace native range rectangle hacks with RangeFix library (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/169696 (owner: 10Esanders)
[18:16:23] <grrrit-wm>	 (03PS1) 10Catrope: Update VE core submodule to master (545d8db) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169764 
[18:16:40] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Update VE core submodule to master (545d8db) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169764 (owner: 10Catrope)
[18:16:44] <grrrit-wm>	 (03PS3) 10Esanders: Replace native range rectangle hacks with RangeFix library [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/169696 
[18:17:23] <wikibugs>	 3VisualEditor: Backspace key at end of document moves the cursor up a line - 10https://bugzilla.wikimedia.org/72689#c2 (10Adam Wight) Page being edited: https://www.mediawiki.org/w/index.php?title=Extension:CentralNotice/Banner_loading&veaction=edit  Browser: Linux, FireFox 30.0
[18:17:39] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: TitleInputWidget should validate inputs - 10https://bugzilla.wikimedia.org/71249 (10James Forrester) 5PATC>3RESO/FIX
[18:17:48] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (545d8db) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169764 (owner: 10Catrope)
[18:18:00] <James_F>	 Bah.
[18:18:10] <wikibugs>	 3VisualEditor: Forward delete key does crazy things - 10https://bugzilla.wikimedia.org/72690#c1 (10Adam Wight) Page being edited: https://www.mediawiki.org/w/index.php?title=Extension:CentralNotice/Banner_loading&veaction=edit  Browser: Linux, FireFox 30.0
[18:19:41] <grrrit-wm>	 (03PS2) 10Jforrester: Update VE core submodule to master (545d8db) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169764 (owner: 10Catrope)
[18:20:58] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] "PS2 fixes the pull-through." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169764 (owner: 10Catrope)
[18:22:18] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (545d8db) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169764 (owner: 10Catrope)
[18:23:35] * James_F grumbles at mw.cookie.
[18:24:23] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] "Go go Jenkins" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169764 (owner: 10Catrope)
[18:25:37] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update VE core submodule to master (545d8db) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169764 (owner: 10Catrope)
[18:26:02] <wikibugs>	 3VisualEditor / 3Technical Debt: VisualEditor: MWTitleInputWidget should return titles - 10https://bugzilla.wikimedia.org/72468 (10James Forrester) 5PATC>3RESO/FIX
[18:27:16] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: A template editing bubble appears off-screen for a left-aligned infobox in the Hebrew Wikipedia - 10https://bugzilla.wikimedia.org/72668 (10etonkovidova) p:5Unprio>3Normal
[18:28:35] <grrrit-wm>	 (03PS4) 10Jforrester: Use ClassAttributeNode mixin in MWBlockImageNode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169517 (owner: 10Esanders)
[18:29:12] <grrrit-wm>	 (03CR) 10Jforrester: [C: 031] "Ah, sorry, misunderstanding." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/169286 (owner: 10Catrope)
[18:36:19] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Use ClassAttributeNode mixin in MWBlockImageNode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169517 (owner: 10Esanders)
[18:37:34] <grrrit-wm>	 (03Merged) 10jenkins-bot: Use ClassAttributeNode mixin in MWBlockImageNode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169517 (owner: 10Esanders)
[18:38:46] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Data model implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159310 (owner: 10Oliverb)
[18:39:10] <RoanKattouw>	 There goes nothing...
[18:41:05] <grrrit-wm>	 (03Merged) 10jenkins-bot: Data model implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159310 (owner: 10Oliverb)
[18:42:50] <grrrit-wm>	 (03Merged) 10jenkins-bot: ContentEditable implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159311 (owner: 10Oliverb)
[18:43:36] <grrrit-wm>	 (03Merged) 10jenkins-bot: Actions and context menus for manipulating tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb)
[18:43:39] <grrrit-wm>	 (03Merged) 10jenkins-bot: Support annotation tool on table selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166774 (owner: 10Esanders)
[18:43:41] <grrrit-wm>	 (03Merged) 10jenkins-bot: Supporting copy paste of single table cells [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167559 (owner: 10Esanders)
[18:43:43] <grrrit-wm>	 (03Merged) 10jenkins-bot: Table header/data format tools [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168060 (owner: 10Esanders)
[18:43:45] <grrrit-wm>	 (03Merged) 10jenkins-bot: Merge cells tool [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167631 (owner: 10Esanders)
[18:43:47] <grrrit-wm>	 (03Merged) 10jenkins-bot: Allow custom type and attributes when creating a table [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168960 (owner: 10Esanders)
[18:44:14] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor:[Regression wmf6]There is an extra space appearing at the top of the toolbar inside VE - 10https://bugzilla.wikimedia.org/72693 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 16945   --> https://bugzilla.wikimedia.org/attachment.cg...
[18:49:28] <grrrit-wm>	 (03PS10) 10Jforrester: Update VE core submodule to master (f4ff1d6) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167189 (owner: 10Esanders)
[18:50:28] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor:[Regression wmf6]There is an extra space appearing at the top of the toolbar inside VE - 10https://bugzilla.wikimedia.org/72693#c1 (10Roan Kattouw) a:3Bartosz Dziewoński This is because of the mw-indicators div. It's empty if there are no indicators, but the fac...
[18:51:08] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] Update VE core submodule to master (f4ff1d6) (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167189 (owner: 10Esanders)
[18:52:13] <grrrit-wm>	 (03PS11) 10Jforrester: Update VE core submodule to master (f4ff1d6) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167189 (owner: 10Esanders)
[18:52:42] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor:[Regression wmf6]There is an extra space appearing at the top of the toolbar inside VE - 10https://bugzilla.wikimedia.org/72693#c2 (10Bartosz Dziewoński) Butbutbut wasn't that supposed to be fixed with c81ed82f?
[18:56:58] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf6] There is an extra space appearing at the top of the toolbar inside VE - 10https://bugzilla.wikimedia.org/72693#c3 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High s:5normal>3minor (In reply to Bartosz Dziewoński from comment #2) > Butb...
[19:03:12] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: When auto-filling citations using citoid, don't add any empty parameters - 10https://bugzilla.wikimedia.org/72007 (10James Forrester)
[19:04:29] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Be able to merge table cells (setting colspan/rowspan as appropriate) - 10https://bugzilla.wikimedia.org/52179 (10James Forrester) 5ASSI>3PATC a:3Ed Sanders
[19:10:27] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Content menu is embedding off-screen for left-floated node in RTL environment - 10https://bugzilla.wikimedia.org/72668#c1 (10James Forrester) 5NEW>3ASSI Did we fix this in master? It looks "fine" (different breakage) on http://he.wikipedia.beta.wmflabs.org/...
[19:12:37] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Update VE core submodule to master (f4ff1d6) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167189 (owner: 10Esanders)
[19:13:04] <James_F>	 RoanKattouw: Fun.
[19:14:01] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update VE core submodule to master (f4ff1d6) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167189 (owner: 10Esanders)
[19:25:11] <mooeypoo>	 Sooo I need to make sure I delete all my "I'm with stupid: <var>" console comments I shoved into my code to debug, since Chrome's been a real annoyance with the debugger lately.
[19:33:16] <Krinkle>	 RoanKattouw_away: RE needing @static @inheritable, Yes. Unless I'm missing something, why would it not need that / how would it know?
[19:34:56] <wikibugs>	 3VisualEditor / 3ContentEditable: [Regression] VisualEditor: Clicking on an image with wikilink opens up link inspector - 10https://bugzilla.wikimedia.org/72660 (10Krinkle)
[19:37:27] <wikibugs>	 3VisualEditor / 3Data Model: VisualEditor: [Regression] Clicking on an image with wikilink opens up link inspector - 10https://bugzilla.wikimedia.org/72660 (10James Forrester) 5NEW>3ASSI
[19:38:58] <grrrit-wm>	 (03PS7) 10Jforrester: Create mwTables with wikitable attribute by default [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168961 (owner: 10Esanders)
[19:39:21] <grrrit-wm>	 (03CR) 10Jforrester: [C: 031] Create mwTables with wikitable attribute by default [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168961 (owner: 10Esanders)
[19:40:02] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Create mwTables with wikitable attribute by default [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168961 (owner: 10Esanders)
[19:47:49] <grrrit-wm>	 (03PS8) 10Jforrester: Create mwTables with wikitable attribute by default [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168961 (owner: 10Esanders)
[19:48:16] <RoanKattouw>	 edsanders: https://gerrit.wikimedia.org/r/#/c/169546/
[19:49:09] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Create mwTables with wikitable attribute by default [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168961 (owner: 10Esanders)
[19:49:11] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Create mwTables with wikitable attribute by default [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168961 (owner: 10Esanders)
[19:49:27] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf3] In Firefox, Cursor is appearing in Read mode at the end of the document after saving a page and after discarding the current edit in Firefox - 10https://bugzilla.wikimedia.org/71852 (10James Forrester) p:5Highes>3Normal
[19:50:28] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Create mwTables with wikitable attribute by default [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168961 (owner: 10Esanders)
[19:50:35] <James_F>	 Eurgh.
[19:51:42] <grrrit-wm>	 (03PS1) 10Catrope: Don't create tables with a thead [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/169784 
[19:51:47] <RoanKattouw>	 edsanders: ---^^
[19:53:20] <grrrit-wm>	 (03PS9) 10Jforrester: Create mwTables with wikitable attribute by default [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168961 (owner: 10Esanders)
[19:53:35] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Create mwTables with wikitable attribute by default [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168961 (owner: 10Esanders)
[19:54:55] <grrrit-wm>	 (03Merged) 10jenkins-bot: Create mwTables with wikitable attribute by default [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168961 (owner: 10Esanders)
[20:08:14] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf5] Scroll bar is appearing while opening a link inspector - 10https://bugzilla.wikimedia.org/72338#c5 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production
[20:13:12] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf4] Red border is appearing around required parameters before focus moves away - 10https://bugzilla.wikimedia.org/72096#c8 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production
[20:17:28] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression] "Make full size" is not enabling "Apply Changes" button when the image has been set to a custom size - 10https://bugzilla.wikimedia.org/72155#c4 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production
[20:21:27] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf5] The "Show Options" inside Transclusion dialog box is blank, not bringing up the other options to add parameter/template/content - 10https://bugzilla.wikimedia.org/72278#c6 (10Rummana Yasmeen) Verified the fix in production
[20:21:42] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf5] The "Show Options" inside Transclusion dialog box is blank, not bringing up the other options to add parameter/template/content - 10https://bugzilla.wikimedia.org/72278 (10Rummana Yasmeen) 5RESO/?>3VERI
[20:24:16] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: [Regression wmf6] deleting text formatted as computer code produces: Failed to load resource: The operation couldn’t be completed. (kCFErrorDomainCFNetwork error -10.) - 10https://bugzilla.wikimedia.org/72698 (10etonkovidova) 3NEW p:3Unprio s:3normal a:3...
[20:27:12] <Krenair>	 James_F, I wonder what an OOUI NumberInputWidget would look like
[20:28:36] <James_F>	 Krenair: Yeah, I was thinking that too. Maybe leave off for now? TrevorParscal?
[20:28:59] <James_F>	 On mobiles I guess it could trigger the numbers-only keyboard.
[20:29:02] <Krenair>	 because it's probably not like how chrome shows <input type="number"> :)
[20:29:14] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: [Regression wmf6] deleting text formatted as computer code produces: Failed to load resource: The operation couldn’t be completed. (kCFErrorDomainCFNetwork error -10.) - 10https://bugzilla.wikimedia.org/72698#c1 (10etonkovidova) Actually, the console error: "Fa...
[20:29:58] <TrevorParscal>	 Krenair: http://caniuse.com/#feat=input-number
[20:30:07] <TrevorParscal>	 we are aiming OOjs UI to work on IE8
[20:30:12] <TrevorParscal>	 (not saying it does yet)
[20:30:16] * James_F nods.
[20:30:23] <TrevorParscal>	 so, we can totally do a number input type
[20:30:45] <TrevorParscal>	 but remember that you need to come up with a way to check if that's supported in the browser, and select the type based on that
[20:30:48] <TrevorParscal>	 falling back to text
[20:31:13] <Krenair>	 Isn't that what browsers which don't support type=number will do?
[20:31:52] <Krenair>	 since type=text is the default
[20:32:58] <TrevorParscal>	 well, there are bugs around that
[20:33:08] <TrevorParscal>	 technically yes, but it's freaking IE man
[20:33:14] <TrevorParscal>	 in any case
[20:33:27] <TrevorParscal>	 our general approach to adding widgets in the past has been, when someone needs it
[20:33:51] <TrevorParscal>	 because otherwise it adds resistance to system-wide changes and widgets that don't get used get ignored, and then when they are finally used they don't work
[20:33:59] <wikibugs>	 3VisualEditor / 3Mobile: VisualEditor Mobile: Disable the context menu for the Basic reference - 10https://bugzilla.wikimedia.org/68897#c7 (10Rummana Yasmeen) 5VERI>3REOP a:5Juliusz Gonera>3Ed Sanders This is again appearing in mobile.
[20:34:00] <TrevorParscal>	 so, don't bother unless we are going to use it somewhere
[20:34:29] <TrevorParscal>	 and there are some existing exceptions, like the toggle crap, but we used them at one point and I didn't want to delete them given how complex they were to build
[20:35:07] <Krenair>	 I'm looking at https://bugzilla.wikimedia.org/show_bug.cgi?id=53613
[20:35:20] <Krenair>	 and one of the types TD provides is 'number'
[20:36:27] <wikibugs>	 3VisualEditor / 3Mobile: VisualEditor Mobile: Disable the context menu for the Basic reference - 10https://bugzilla.wikimedia.org/68897#c8 (10Rummana Yasmeen) 5REOP>3ASSI The context menu for math and references list started appearing too.
[20:36:57] <wikibugs>	 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression]Disable the context menu for the Basic reference/Group Reference/Math/Reference list for mobile - 10https://bugzilla.wikimedia.org/68897 (10Rummana Yasmeen)
[20:37:12] <wikibugs>	 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression]Disable the context menu for the Basic reference/Group Reference/Math/Reference list for mobile - 10https://bugzilla.wikimedia.org/68897 (10Rummana Yasmeen)
[20:48:43] <grrrit-wm>	 (03PS1) 10Anomie: Add i18n for API module help [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/169837 
[20:49:05] <grrrit-wm>	 (03PS1) 10Anomie: Add i18n for API module help [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169846 
[20:50:49] <greg-g>	 ryasmeen: heya, I might be a few minutes late, my usb ports aren't working on my laptop right now (so no external keyboard nor camera, which is annoying when working at home at my desk).
[20:51:39] <grrrit-wm>	 (03CR) 10Jforrester: [C: 04-1] "i18n files should be in alphabetical order, per coding conventions." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169846 (owner: 10Anomie)
[20:52:56] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: Hide page status indicators even if they aren't :visible [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169860 (https://bugzilla.wikimedia.org/72693) 
[20:53:31] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Hide page status indicators even if they aren't :visible [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169860 (https://bugzilla.wikimedia.org/72693) (owner: 10Bartosz Dziewoński)
[20:54:09] <grrrit-wm>	 (03PS1) 10Jforrester: Hide page status indicators even if they aren't :visible [extensions/VisualEditor] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/169861 (https://bugzilla.wikimedia.org/72693) 
[20:54:47] <grrrit-wm>	 (03CR) 10Anomie: "Note: If any reviewer sees any errors that need fixing, please feel free to fix it and upload a new patchset." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169846 (owner: 10Anomie)
[20:58:07] <greg-g>	 ryasmeen|Away: fixed it :) be there on time
[20:58:36] <grrrit-wm>	 (03CR) 10Anomie: "Note: If any reviewer sees any errors that need fixing, please feel free to fix it and upload a new patchset." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/169837 (owner: 10Anomie)
[20:59:04] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hide page status indicators even if they aren't :visible [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169860 (https://bugzilla.wikimedia.org/72693) (owner: 10Bartosz Dziewoński)
[20:59:59] <grrrit-wm>	 (03PS2) 10Jforrester: Add i18n for API module help [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169846 (owner: 10Anomie)
[21:01:36] <grrrit-wm>	 (03CR) 10Jforrester: [C: 04-1] Add i18n for API module help (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/169837 (owner: 10Anomie)
[21:09:04] <grrrit-wm>	 (03CR) 10Catrope: "Because of https://bugzilla.wikimedia.org/show_bug.cgi?id=72702" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/169784 (owner: 10Catrope)
[21:09:53] <grrrit-wm>	 (03CR) 10Anomie: Add i18n for API module help (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/169837 (owner: 10Anomie)
[21:09:55] <InezK>	 do you guys remember ve-no-shield? what was it replaced with?
[21:11:35] <mooeypoo>	 RoanKattouw, hm, I think ther'es an unexpected bonus from my code
[21:12:20] <RoanKattouw>	 InezK: There's something like that I think...
[21:12:31] <mooeypoo>	 RoanKattouw, OO.compare( undefined, [] ); <-- true (meh!) 
[21:12:45] <mooeypoo>	 also true with pairs of null, undefined or null anything
[21:12:46] <RoanKattouw>	 InezK: ve-ce-noHighlight
[21:13:03] <RoanKattouw>	 mooeypoo: Yeah that is really horrible
[21:13:07] <mooeypoo>	 however, TemplateDataModel.static.compare( undefined, [] ); <-- false
[21:13:09] <RoanKattouw>	 I've been trying to convince Krinkle that this is a bug
[21:13:14] <mooeypoo>	 and also false with the undefined and null
[21:13:17] <Krinkle>	 What is?
[21:13:27] <RoanKattouw>	 Or maybe it was edsanders that disagrees with me
[21:13:29] <mooeypoo>	 i had to find a way to do this right for TDG comparisons since a lot of the input is written by hand
[21:13:39] <InezK>	 RoanKattouw: thx
[21:14:12] <Krinkle>	 RoanKattouw: I think I considered it a bug, but you or Ed convinced me because you wanted to tolerate null/undefined in some cases for some reason. 
[21:14:21] <RoanKattouw>	 I think undefined should not cause a crash
[21:14:24] <RoanKattouw>	 ideally
[21:14:29] <Krinkle>	 I recall thinking that's sloppy code, but that ship already sailed and you needed a way to tolerate it
[21:14:37] <RoanKattouw>	 But I also think that claiming that undefined and [] are the same is unreasonable
[21:14:46] <Krinkle>	 to compare the existing models that had that value in it
[21:14:49] <Krinkle>	 Indeed
[21:14:51] <TrevorParscal>	 MatmaRex: how's it going?
[21:14:55] <Krinkle>	 RoanKattouw: What is making them equal?
[21:15:00] <RoanKattouw>	 I don't know!
[21:15:07] <RoanKattouw>	 Maybe it's because both contain 0 sub-values?
[21:15:15] <Krinkle>	 https://github.com/wikimedia/oojs/blob/master/src/core.js#L220-L252
[21:15:16] <mooeypoo>	 RoanKattouw, well, mine seems to cover those cases
[21:15:22] <RoanKattouw>	 And OO.compare() at the top level only descends and doesn't do any other comparison
[21:15:28] <Krinkle>	 RoanKattouw: Falsye values cast to empty object
[21:15:32] <mooeypoo>	 RoanKattouw, Krinkle as far as I saw it's not really checking types propely
[21:15:37] <MatmaRex>	 hi TrevorParscal. you have a stack of OOUI PHP changes to review, that's how ;)
[21:15:49] <Krinkle>	 mooeypoo: It is.
[21:15:49] <TrevorParscal>	 nice
[21:16:00] <grrrit-wm>	 (03PS6) 10Mooeypoo: [Just WIP] Eventify TemplateDataGenerator and use oojs-ui [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 
[21:16:03] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [Just WIP] Eventify TemplateDataGenerator and use oojs-ui [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 (owner: 10Mooeypoo)
[21:16:15] <MatmaRex>	 there are JS/PHP comparison tests in there, and they pass
[21:16:17] <Krinkle>	 RoanKattouw: So there's your answer. I support making it not cast falsy to empty object, and instead do a falsy check around the for-loop and make it not loop or whatever.
[21:16:36] <mooeypoo>	 RoanKattouw, Krinkle see line #85 https://gerrit.wikimedia.org/r/#/c/167046/6/modules/ext.templateDataGenerator.data.js
[21:16:38] <Krinkle>	 for-in on null/undefined throws
[21:16:48] <Krinkle>	 actually, it doesn't
[21:17:02] <Krinkle>	 >> for ( key in undefined ) { return 1; } return 2;
[21:17:02] <ecmabot-wm>	 Krinkle: SyntaxError: Illegal return statement
[21:17:08] <Krinkle>	 >> for ( key in undefined ) { 1; } 2;
[21:17:08] <ecmabot-wm>	 Krinkle: (number) 2
[21:17:10] <RoanKattouw>	 lol
[21:17:17] <RoanKattouw>	 Krinkle: That always returns 2
[21:17:24] <Krinkle>	 I Know
[21:17:32] <RoanKattouw>	 >> var obj = { 1: 2 }; for ( key in undefined ) { 1; } 2;
[21:17:32] <ecmabot-wm>	 RoanKattouw: (number) 2
[21:17:38] <Krinkle>	 >> (function(){ for ( key in undefined ) { return 1; } return 2; }());
[21:17:39] <ecmabot-wm>	 Krinkle: (number) 2
[21:17:40] <RoanKattouw>	 Oh you're pointing out there's no error
[21:17:48] <Krinkle>	 Indeed
[21:18:00] <Krinkle>	 I think Ed was trying to reduce the error handling and just cast it to avoid extra code
[21:18:03] <Krinkle>	 but it's not needed
[21:18:03] <mooeypoo>	 There might not be an error, but it means we can't compare values that might be undefined
[21:18:13] <mooeypoo>	 or null
[21:18:25] <Krinkle>	 RoanKattouw: https://github.com/wikimedia/oojs/commit/b6f3320aa7fa0250eb1cc1dffbe0db7c0175ca59
[21:18:27] <mooeypoo>	 and that's just inconvenient, hence me making another comparison method for templatedata 
[21:18:57] <Krinkle>	 RoanKattouw: I think you had some models in VE where a proprety might not exist, so you can do compare( foo.thing, bar.thing ) where one of foo or bar might not even have .thing
[21:19:06] <RoanKattouw>	 That might be right
[21:19:09] <Krinkle>	 I think that's sloppy code, but it was already established and needed a way to check it
[21:19:32] <mooeypoo>	 Well, best example is the image dialog initHash
[21:19:35] <InezK>	 RoanKattouw: In ve.ce.FocusableNode.prototype.computeRects you use this.$element.find( '*' ) - it would be nice to use recursion, and if node has class ve-ce-noHighlight then do not go into it's children
[21:19:36] <Krinkle>	 since the method is recursive, you screw yourself in the end
[21:19:44] <Krinkle>	 https://gerrit.wikimedia.org/r/#/c/155047/
[21:19:53] <mooeypoo>	 it's supposed to be undefined if the image is brand new (no 'old' hash to compare to) but I can' tmake it undefined because then compare fails
[21:20:01] <Krinkle>	 then don't compare in that case?
[21:20:11] <RoanKattouw>	 InezK: AIUI that's not what noHighlight is for. Instead it makes it so that it isn't highlighted but its children are. Or something. Ask edsanders 
[21:20:15] <mooeypoo>	 Well, I need to figure out if it changed in hasBeenChanged()
[21:20:33] <mooeypoo>	 I could not compare, but I don't quite understand why not have a comparison method that actually compares values, whether they're set or not
[21:20:38] <Krinkle>	 it shouldn't be up to the compare method to fix that code, if you're not initalised yet, there should be no reason to compare any values. seems like a case of specialising for a use case for inappropiate convenience.
[21:20:49] <mooeypoo>	 comparing undefined to anything else is false; comparing undefined to null is false... why is that a problem?
[21:20:51] * Krinkle stack.pop()
[21:21:17] <mooeypoo>	 It makes sense that a comparison will return a proper comparison, imho... not sure I understand why not?
[21:21:32] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] "I'm approving this because label, unlike fieldset and legend, has no special rendering - it's a very generic container, and is equivalent " [oojs/ui] - 10https://gerrit.wikimedia.org/r/169218 (https://bugzilla.wikimedia.org/72587) (owner: 10Bartosz Dziewoński)
[21:22:00] <mooeypoo>	 as in, how is it a good comparison method if it returns *true* to comparing anything with undefined?
[21:22:01] <TrevorParscal>	 MatmaRex: so, I'm ready to +2 https://gerrit.wikimedia.org/r/#/c/169218/
[21:22:09] <TrevorParscal>	 I have, but your -2 is blocking of course
[21:22:13] <MatmaRex>	 TrevorParscal: i have literally not tested it at all
[21:22:24] <MatmaRex>	 well, i checked whether the widgets.php page blows up
[21:22:37] <MatmaRex>	 but it's a proof-of-concept
[21:22:39] <TrevorParscal>	 label is the same as span, it's not like fieldset and legend with all it's tricky crap
[21:22:54] <TrevorParscal>	 i'll do some testing to prove it
[21:22:58] <MatmaRex>	 i know we have simulateLabelClick() function somewhere that does its things, i don't know if they cooperate
[21:23:17] <MatmaRex>	 i am pretty sure this should be harmless, but i haven't verified it anywhere near well enough
[21:24:07] <TrevorParscal>	 simulateLabelClick may be able to go away, but we need to audit it's use
[21:24:16] <MatmaRex>	 (if we find this to actually cause problems, we could probaly do <label/> in PHP and <div/> in JS)
[21:24:50] <MatmaRex>	 yeah, another problem is that this is in FieldLayout rather than LabelElement, so if anything else uses labels for form inputs, we need to keep the simulateLabelClick(0 stuff
[21:25:05] <TrevorParscal>	 the problems would most certainly be CSS anyway, would affect both
[21:25:29] <MatmaRex>	 i am still not convinced that doing this by just generating matching id and for attributes is worse
[21:26:25] <TrevorParscal>	 well, HTML is designed this way for a reason
[21:26:40] <TrevorParscal>	 the for crap is designed to be used with forms in tables
[21:26:57] <TrevorParscal>	 when you can wrap, it's much simpler
[21:27:03] <TrevorParscal>	 and imo less error prone
[21:27:54] <TrevorParscal>	 testing looks great
[21:27:56] <TrevorParscal>	 as expected
[21:28:04] <TrevorParscal>	 I want to merge it
[21:28:27] <MatmaRex>	 …alright
[21:28:39] <MatmaRex>	 it's on top of the stack, but can probably be "detached"
[21:28:53] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: Turn FieldLayout into a <label/> [oojs/ui] - 10https://gerrit.wikimedia.org/r/169218 (https://bugzilla.wikimedia.org/72587) (owner: 10Bartosz Dziewoński)
[21:29:01] <grrrit-wm>	 (03PS4) 10Bartosz Dziewoński: Turn FieldLayout into a <label/> [oojs/ui] - 10https://gerrit.wikimedia.org/r/169218 (https://bugzilla.wikimedia.org/72587) 
[21:29:48] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] Turn FieldLayout into a <label/> [oojs/ui] - 10https://gerrit.wikimedia.org/r/169218 (https://bugzilla.wikimedia.org/72587) (owner: 10Bartosz Dziewoński)
[21:32:09] <MatmaRex>	 TrevorParscal: have you looked at the rest of the stuff yet?
[21:33:08] <MatmaRex>	 TrevorParscal: there's this thing that PHP doesn't support having a static and non-static class member with the same name, and we do that a lot in JS. it popped up when i did my documentation comparer thingy.
[21:33:21] <TrevorParscal>	 dude, I'm having a great time reviewing this stuff
[21:33:40] <TrevorParscal>	 looking at https://gerrit.wikimedia.org/r/#/c/168910/ now actually
[21:33:41] <MatmaRex>	 and i wonder if we want to do anything about this. so far we were lucky not to run into any real conflicts, since enough of this stuff isn't implemented
[21:33:43] <grrrit-wm>	 (03Merged) 10jenkins-bot: Turn FieldLayout into a <label/> [oojs/ui] - 10https://gerrit.wikimedia.org/r/169218 (https://bugzilla.wikimedia.org/72587) (owner: 10Bartosz Dziewoński)
[21:34:19] <TrevorParscal>	 so, we have static and non-static methods with the same names eh? examples?
[21:34:24] <TrevorParscal>	 how do I run this test btw?
[21:34:44] <MatmaRex>	 visit tests/index.php with your browser
[21:34:52] <MatmaRex>	 it's a QUnit test suite
[21:35:16] <MatmaRex>	 TrevorParscal: we do, TitleElement with it's two titles, for example
[21:35:28] <MatmaRex>	 TitledElement*
[21:35:54] <TrevorParscal>	 oh, you mean how we have the static property as the default config?
[21:35:57] <TrevorParscal>	 ugh..
[21:36:14] <TrevorParscal>	 I really want to clean that up tbh
[21:36:14] <TrevorParscal>	 we need to have a defaultConfig static property
[21:36:22] <TrevorParscal>	 and compose it with config (at some point)
[21:36:56] <TrevorParscal>	 the trouble is that it's not easy to know when to extend the config
[21:37:12] <TrevorParscal>	 or make extending the default config work through subclasses
[21:37:47] <TrevorParscal>	 it's really quite messy
[21:37:52] <TrevorParscal>	 in any case
[21:38:09] <TrevorParscal>	 static.title is probably the wrong property name, we should be using static.defaultTitle instead
[21:38:14] <TrevorParscal>	 in all of these cases
[21:38:23] <TrevorParscal>	 because they are overridden using instance config objects
[21:38:23] <MatmaRex>	 also icon, indicator, label elements
[21:38:26] <TrevorParscal>	 yes
[21:38:32] <MatmaRex>	 (and maybe more, but these pop up in my script)
[21:38:34] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] Don't create tables with a thead [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/169784 (owner: 10Catrope)
[21:38:53] <TrevorParscal>	 i downloaded the patchset and ran grunt build, but the test suite seems broken
[21:39:03] <RoanKattouw>	 TrevorParscal: ChildClass.static.defaultConfig = $.extend( { title: 'foo' }, ChildClass.super.static.defaultConfig ); could be shortened to something like OO.extendStatic( ChildClass, 'defaultConfig', { ... } ); or whatever
[21:39:17] <MatmaRex>	 TrevorParscal: it's not hooked up to the normal test suite, sadly
[21:39:26] <TrevorParscal>	 just a white screen, but the title is set to "✖ OOjs UI Test Suite" so it failed for sure
[21:39:31] <MatmaRex>	 oh
[21:39:37] <MatmaRex>	 `composer install`, maybe?
[21:40:17] <grrrit-wm>	 (03Merged) 10jenkins-bot: Don't create tables with a thead [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/169784 (owner: 10Catrope)
[21:40:34] <MatmaRex>	 TrevorParscal: and yeah, these tests don't run with the existing QUnit suite when ran through Grunt (karma), because they need the dynamic PHP page and that's not possible apparently
[21:40:36] <TrevorParscal>	 yeah, was missing require-dev aparently
[21:42:05] <MatmaRex>	 i added a PHP class earlier in the stack, perhaps that's what was failing
[21:42:13] <TrevorParscal>	 it's working now
[21:43:03] <TrevorParscal>	 Krinkle: when we get this test suite passing, perhaps you could help us come up with a way to run it in jenkins?
[21:43:50] <Krenair>	 James_F, so I think for this I'm just going to begin by using MWTitleInputWidget for wiki-page-name, a new MWUserInputWidget for wiki-user-name, otherwise falling back to TextInputWidget
[21:43:54] <RoanKattouw>	 TrevorParscal: Did you see hashar's commit submitted to OOUI?
[21:43:58] <RoanKattouw>	 It sounds like it does just that
[21:44:00] <Krinkle>	 TrevorParscal: I have no idea what test suite this is about, I'm in the RFC meeting, juggling dinner and property searches. Email me if it's important, buffer is not saved.
[21:44:39] <Krenair>	 James_F, I was wondering about wiki-file-name, but I figure we'd probably want something more like what the media dialog uses for that
[21:46:29] <James_F>	 RoanKattouw: http://en.wikipedia.beta.wmflabs.org/wiki/User:Jdforrester_(WMF)/Sandbox?veaction=edit
[21:46:33] <James_F>	 Krenair: Yes.
[21:47:44] <wikibugs>	 3OOjs UI: OOUI PHP: Use <label> for LabelElement to make clicking on labels work without JavaScript - 10https://bugzilla.wikimedia.org/72587 (10James Forrester) 5PATC>3RESO/FIX p:5Unprio>3High
[21:48:28] <MatmaRex>	 TrevorParscal: also, i've been meaning to ask you - reasons for using OoUi prefix rather than a namespace? (i have no opinion on this, just wondering)
[21:48:44] <Krenair>	 there are MWMediaSearchWidget/MWMediaResultWidget, probably wouldn't fit nicely in the transclusion dialog though
[21:49:18] <TrevorParscal>	 MatmaRex: namespace would be awesome
[21:49:24] <James_F>	 Krenair: It'd need to flyout, yeah.
[21:49:33] <TrevorParscal>	 I think the last time I wrote PHP that was an experimental feature
[21:49:40] <James_F>	 Krenair: mooeypoo will be keen to help you, I'm sure. :-) Doesn't need to be done all at once.
[21:49:42] <MatmaRex>	 :D
[21:49:42] <TrevorParscal>	 so, namesapce away man!
[21:49:54] * MatmaRex files tech debt bug
[21:50:19] <MatmaRex>	 i haven't written any namespace PHP code, either, i'm just aware that folks actually use them these days ;)
[21:50:27] <TrevorParscal>	 I've used them before (omg, really, backslash?!!) but I just didn't instinctively go there because of old habbits with PHP limitations that MediaWiki used to have
[21:50:39] <mooeypoo>	 what? who? me? where? 
[21:51:40] <grrrit-wm>	 (03PS1) 10Catrope: Followup e0981a3: don't pass undefined to getClassAttrFromAttributes() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169933 
[21:51:42] <mooeypoo>	 Krenair, mediaSearchWidget should fit in its own panel in a dialog.
[21:51:57] <MatmaRex>	 good thing namespaces are case-insensitive, no need to worry too much about capitalization :D
[21:51:59] <mooeypoo>	 Krenair, it will also soon be adjusted somewhat, but that shouldn't really stop you
[21:52:15] <wikibugs>	 3VisualEditor / 3Editing Tools: Feature Request: <pre> or <code> entire selected block - 10https://bugzilla.wikimedia.org/72706 (10dr0ptp4kt) 3NEW p:3Unprio s:3normal a:3None I was wondering if we could have a feature whereby multiline selected text could be enveloped in one <pre> or <code> when the...
[21:52:26] <MatmaRex>	 wikibugs, are you there? i just filed https://bugzilla.wikimedia.org/show_bug.cgi?id=72705
[21:52:40] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Followup e0981a3: don't pass undefined to getClassAttrFromAttributes() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169933 (owner: 10Catrope)
[21:52:44] <wikibugs>	 3OOjs UI / 3Technical Debt: OOUI PHP: Use a namespace for our classes - 10https://bugzilla.wikimedia.org/72705 (10Bartosz Dziewoński) a:3Bartosz Dziewoński
[21:52:52] <RoanKattouw>	 MatmaRex: Yeah it's always a bit slow
[21:53:03] <MatmaRex>	 yeah, but it missed that one entirely
[21:53:11] <MatmaRex>	 perhaps because of empty description?
[21:54:03] <grrrit-wm>	 (03Merged) 10jenkins-bot: Followup e0981a3: don't pass undefined to getClassAttrFromAttributes() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169933 (owner: 10Catrope)
[21:57:42] <wikibugs>	 3OOjs UI / 3Technical Debt: OOUI PHP: Use a namespace for our classes - 10https://bugzilla.wikimedia.org/72705 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High s:5normal>3enhanc
[21:57:49] <grrrit-wm>	 (03CR) 10Jforrester: Add i18n for API module help (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/169837 (owner: 10Anomie)
[21:59:35] <grrrit-wm>	 (03PS2) 10Jforrester: Add i18n for API module help [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/169837 (owner: 10Anomie)
[22:00:05] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Add i18n for API module help [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/169837 (owner: 10Anomie)
[22:00:37] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add i18n for API module help [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/169837 (owner: 10Anomie)
[22:04:26] <grrrit-wm>	 (03PS1) 10Alex Monk: Use MWTitleInputWidget for wiki-page-name parameters, add MWUserInputWidget for wiki-user-name [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169936 (https://bugzilla.wikimedia.org/53613) 
[22:05:42] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Use MWTitleInputWidget for wiki-page-name parameters, add MWUserInputWidget for wiki-user-name [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169936 (https://bugzilla.wikimedia.org/53613) (owner: 10Alex Monk)
[22:07:35] <grrrit-wm>	 (03PS2) 10Alex Monk: Use MWTitleInputWidget for wiki-page-name parameters, add MWUserInputWidget for wiki-user-name [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169936 (https://bugzilla.wikimedia.org/53613) 
[22:19:14] <mooeypoo>	 anyone knows if there is (and what it is) a reverse for 'errorbox' class on MW ?
[22:19:18] <mooeypoo>	 a successbox or something
[22:19:28] <mooeypoo>	 Can't find it, and I can't manage to gte a success message to show up 
[22:21:03] <mooeypoo>	 ah, got it. It's actually called 'successbox'. \o/
[22:21:04] <Krenair>	 there is literally a 'successbox'
[22:21:25] <Krenair>	 This stuff is all under mediawiki.legacy though, so don't depend on it
[22:22:13] <Krenair>	 also warningbox
[22:25:21] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] Use MWTitleInputWidget for wiki-page-name parameters, add MWUserInputWidget for wiki-user-name (035 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169936 (https://bugzilla.wikimedia.org/53613) (owner: 10Alex Monk)
[22:29:59] <wikibugs>	 3OOjs UI: OOUI: Get OOUI PHP to be good to go (tracking) - 10https://bugzilla.wikimedia.org/72713 (10James Forrester) 3ASSI p:3Unprio s:3normal a:3Trevor Parscal Part of "front-end standardisation" Q2 priority project.
[22:31:58] <wikibugs>	 3OOjs UI: OOUI: Get OOUI PHP to be good to go (tracking) - 10https://bugzilla.wikimedia.org/72713 (10James Forrester)
[22:33:27] <Krenair>	 RoanKattouw, LookupInputWidget doesn't define getLookupCacheItemFromData, just call it
[22:33:35] <RoanKattouw>	 wtf
[22:33:47] <RoanKattouw>	 Then it should define it as an abstract method and document it
[22:33:52] <Krenair>	 If the subclass doesn't set it, oops, call to undefined function
[22:33:59] <wikibugs>	 3OOjs UI: OOUI: Get OOUI PHP to be good to go (tracking) - 10https://bugzilla.wikimedia.org/72713 (10James Forrester)
[22:34:02] <wikibugs>	 3OOjs UI: OOjs UI: Be able to resurrect OOUI PHP widgets into OOjs UI widgets - 10https://bugzilla.wikimedia.org/72716 (10James Forrester) 3ASSI p:3Unprio s:3enhanc a:3Trevor Parscal Part of "front-end standardisation" Q2 priority project.
[22:34:13] <RoanKattouw>	 Well also, that means there's no documentation on how to use LookupInputWidget properly in LIW itself
[22:34:25] <RoanKattouw>	 only in random subclasses of it in a *different repository*
[22:34:33] * RoanKattouw sighs heavily in the general direction of our documentation
[22:35:31] <wikibugs>	 3OOjs UI: OOjs UI: PHP docs should be auto-generated - 10https://bugzilla.wikimedia.org/72454 (10James Forrester)
[22:35:31] <wikibugs>	 3OOjs UI: OOUI PHP: GridLayout RTL support - 10https://bugzilla.wikimedia.org/72584 (10James Forrester)
[22:35:36] <wikibugs>	 3OOjs UI: OOUI: Get OOUI PHP to be good to go (tracking) - 10https://bugzilla.wikimedia.org/72713 (10James Forrester)
[22:35:36] <wikibugs>	 3OOjs UI: OOUI: Synchronise JS and PHP docs better - 10https://bugzilla.wikimedia.org/72455 (10James Forrester)
[22:35:36] <wikibugs>	 3OOjs UI: OOUI PHP: No simple way to add HTML-escaped text to a Element - 10https://bugzilla.wikimedia.org/72542 (10James Forrester)
[22:35:43] <wikibugs>	 3OOjs UI / 3Technical Debt: OOUI PHP: Use a namespace for our classes - 10https://bugzilla.wikimedia.org/72705 (10James Forrester)
[22:35:43] <wikibugs>	 3OOjs UI: OOUI: Unit tests to ensure comparable JS and PHP output for the same configs - 10https://bugzilla.wikimedia.org/72588 (10James Forrester)
[22:37:12] <wikibugs>	 3VisualEditor / 3Mobile: VisualEditor: [Regression pre-wmf5] Cannot open Mobile VE in Betalabs , in the console "TypeError: Cannot set property 'MWMobileContext' of undefined" appears - 10https://bugzilla.wikimedia.org/72282 (10Rummana Yasmeen) 5RESO/?>3VERI
[22:37:46] <Krenair>	 RoanKattouw, I guess I'll upload a fix for that separately then
[22:39:30] <wikibugs>	 3VisualEditor / 3Data Model: VisualEditor: Clicking in a table that contains templated rows causes JS error - 10https://bugzilla.wikimedia.org/72717 (10Roan Kattouw) 3ASSI p:3Unprio s:3critic a:3Ed Sanders 1. Go to http://en.wikipedia.beta.wmflabs.org/wiki/User:RoanKattouw/Evil_table?veaction=edit 2....
[22:40:57] <wikibugs>	 3VisualEditor / 3Data Model: VisualEditor: Clicking in a table that contains templated rows causes JS error - 10https://bugzilla.wikimedia.org/72717 (10Roan Kattouw) p:5Unprio>3Highes
[22:41:35] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Add i18n for API module help [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169846 (owner: 10Anomie)
[22:41:51] <grrrit-wm>	 (03PS1) 10Alex Monk: Provide abstract getLookupCacheItemFromData in LookupInputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/169947 
[22:42:58] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add i18n for API module help [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169846 (owner: 10Anomie)
[22:43:10] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Provide abstract getLookupCacheItemFromData in LookupInputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/169947 (owner: 10Alex Monk)
[22:44:42] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Be able to merge table cells (setting colspan/rowspan as appropriate) - 10https://bugzilla.wikimedia.org/52179 (10James Forrester) 5PATC>3RESO/FIX
[22:45:05] <grrrit-wm>	 (03PS3) 10Alex Monk: Use MWTitleInputWidget for wiki-page-name parameters, add MWUserInputWidget for wiki-user-name [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169936 (https://bugzilla.wikimedia.org/53613) 
[22:45:22] <grrrit-wm>	 (03Merged) 10jenkins-bot: Provide abstract getLookupCacheItemFromData in LookupInputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/169947 (owner: 10Alex Monk)
[22:46:29] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Use MWTitleInputWidget for wiki-page-name parameters, add MWUserInputWidget for wiki-user-name [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169936 (https://bugzilla.wikimedia.org/53613) (owner: 10Alex Monk)
[22:47:43] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Pressing "Backspace" causes the page to abruptly scroll up on IE 11 - 10https://bugzilla.wikimedia.org/71119 (10James Forrester)
[22:47:48] <grrrit-wm>	 (03CR) 10Alex Monk: "(doc error should go away when Idfff140a is included)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169936 (https://bugzilla.wikimedia.org/53613) (owner: 10Alex Monk)
[22:48:14] <wikibugs>	 3OOjs UI: OOUI PHP: GridLayout RTL support - 10https://bugzilla.wikimedia.org/72584 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal a:3Bartosz Dziewoński
[22:48:27] <wikibugs>	 3OOjs UI: OOUI: Unit tests to ensure comparable JS and PHP output for the same configs - 10https://bugzilla.wikimedia.org/72588 (10James Forrester) p:5Unprio>3High
[22:48:43] <wikibugs>	 3OOjs UI: OOUI: Get OOUI PHP to be good to go (tracking) - 10https://bugzilla.wikimedia.org/72713 (10James Forrester) p:5Unprio>3High s:5normal>3major
[22:48:57] <wikibugs>	 3OOjs UI: OOjs UI: Be able to resurrect OOUI PHP widgets into OOjs UI widgets - 10https://bugzilla.wikimedia.org/72716 (10James Forrester) p:5Unprio>3High
[22:48:58] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor:[Regression pre-wmf7] Empty Add Template dialog appearing upon trying to open an existing template from a page - 10https://bugzilla.wikimedia.org/72719 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 16948   --> https://bugzilla.wik...
[23:00:59] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Hide page status indicators even if they aren't :visible [extensions/VisualEditor] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/169861 (https://bugzilla.wikimedia.org/72693) (owner: 10Jforrester)
[23:02:12] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hide page status indicators even if they aren't :visible [extensions/VisualEditor] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/169861 (https://bugzilla.wikimedia.org/72693) (owner: 10Jforrester)
[23:04:41] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf1] Template parameter autovalues are not saved - 10https://bugzilla.wikimedia.org/71157 (10Rummana Yasmeen) 5REOP>3ASSI
[23:04:43] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf1] Template parameter autovalues are not saved - 10https://bugzilla.wikimedia.org/71157#c7 (10Rummana Yasmeen) 5RESO/FIX>3REOP This seem to be not working in production (en.wiki).I dont even see the substitute values {{subst:CURRENTMONTHNAME}}...
[23:04:44] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Edit notices popup shows out of screen in RTL - 10https://bugzilla.wikimedia.org/72673#c2 (10James Forrester) 5NEW>3RESO/FIX a:3Roan Kattouw This was fixed in wmf5 by Roan.
[23:04:47] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: In the media adding dialog LTR direction is forced on the description field even in RTL wikis - 10https://bugzilla.wikimedia.org/69969#c1 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High a:3Roan Kattouw Ouch.
[23:06:12] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: FocusableNodes not selectable when surface is blurred - 10https://bugzilla.wikimedia.org/72721 (10James Forrester) p:5Unprio>3High
[23:08:43] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Please let me drop the cursor into the table caption if it exists. Please? - 10https://bugzilla.wikimedia.org/72724 (10James Forrester) p:5Unprio>3Normal
[23:08:46] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Please let me drop the cursor into the table caption if it exists. Please? - 10https://bugzilla.wikimedia.org/72724 (10James Forrester) 3ASSI p:3Unprio s:3normal a:3Ed Sanders See e.g. the table in section 0 of the link.
[23:09:12] <wikibugs>	 3OOjs UI: OOUI PHP: TextInputWidget HTML5 pattern validations - 10https://bugzilla.wikimedia.org/72585 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Lowest
[23:09:28] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf7] Empty Add Template dialog appearing upon trying to open an existing template from a page - 10https://bugzilla.wikimedia.org/72719 (10James Forrester)
[23:09:44] <wikibugs>	 3VisualEditor: Typing immediately after a link is in wrong colour - 10https://bugzilla.wikimedia.org/72638#c1 (10James Forrester) 5NEW>3RESO/DUP Yeah, this is a bad regression, sorry. :-(  *** This bug has been marked as a duplicate of bug 72108 ***
[23:09:46] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor:[Regression pre-wmf7] Empty Add Template dialog appearing upon trying to open an existing template from a page - 10https://bugzilla.wikimedia.org/72719 (10Rummana Yasmeen) 5NEW>3ASSI p:5Unprio>3Highes s:5normal>3major a:3Roan Kattouw
[23:09:58] <wikibugs>	 3OOjs UI / 3Technical Debt: OOjs UI: PopupWidget needs to have its body positioned absolutely and anchor relatively to it, and not vice versa - 10https://bugzilla.wikimedia.org/71644 (10James Forrester) 5NEW>3ASSI s:5normal>3enhanc
[23:10:23] <grrrit-wm>	 (03PS7) 10Mooeypoo: Eventify TemplateDataGenerator and use oojs-ui [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 
[23:10:26] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Eventify TemplateDataGenerator and use oojs-ui [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 (owner: 10Mooeypoo)
[23:10:29] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: [Regression wmf6] deleting text formatted as computer code produces: Failed to load resource: The operation couldn’t be completed. (kCFErrorDomainCFNetwork error -10.) - 10https://bugzilla.wikimedia.org/72698#c2 (10James Forrester) 5NEW>3ASSI p:5Unprio>3...
[23:10:44] <wikibugs>	 3OOjs UI / 3Technical Debt: OOjs UI: InlineMenuWidget should behave as a menu widget - 10https://bugzilla.wikimedia.org/70968#c2 (10James Forrester) 5UNCO>3ASSI Renaming seems sane.
[23:10:44] <wikibugs>	 3VisualEditor / 3Data Model: VisualEditor: [Regression] “Uncaught Error: offset -1 out of bounds” when adding bullet/numbered list with link inspector open - 10https://bugzilla.wikimedia.org/72558 (10James Forrester) 5UNCO>3ASSI p:5Unprio>3High
[23:10:58] <wikibugs>	 3OOjs UI / 3Technical Debt: OOUI: It's unclear which class members (properties) are public/private/internal - 10https://bugzilla.wikimedia.org/72578 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Low
[23:11:14] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: [Regression wmf4] Link continuation is broken - 10https://bugzilla.wikimedia.org/72108#c10 (10James Forrester) *** Bug 72638 has been marked as a duplicate of this bug. ***
[23:11:28] <wikibugs>	 3OOjs UI: OOjs UI: optionWidget with check icon should not appear for invalid entries in the category input field. - 10https://bugzilla.wikimedia.org/72000 (10James Forrester) 5UNCO>3ASSI p:5Unprio>3Normal
[23:11:45] <wikibugs>	 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression wmf5] The wikitext editor does not show any wikitext for any page for mobile in test2 and Beta Labs - 10https://bugzilla.wikimedia.org/72571 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High
[23:11:47] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: FocusableNodes not selectable when surface is blurred - 10https://bugzilla.wikimedia.org/72721 (10Roan Kattouw) 3ASSI p:3Unprio s:3major a:3Ed Sanders 1. Open VE on a page that contains a focusable node 2. Click out of the surface so it's blurred and th...
[23:11:58] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf7] Empty Add Template dialog appearing upon trying to open an existing template from a page - 10https://bugzilla.wikimedia.org/72719 (10Roan Kattouw)
[23:12:15] <wikibugs>	 3OOjs UI: OOUI: Implement radio buttons - 10https://bugzilla.wikimedia.org/72586 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High a:3Bartosz Dziewoński
[23:12:29] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Clicking on somewhere else in the document after opening a link inspector inside a slug throws error "TypeError: Cannot read property 'previousSibling' of undefined" - 10https://bugzilla.wikimedia.org/72494 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal
[23:12:31] <wikibugs>	 3OOjs UI: OOUI PHP: FieldLayout is missing the 'help' config option - 10https://bugzilla.wikimedia.org/72583 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal a:3Bartosz Dziewoński
[23:12:44] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: [Regression] Ctrl+A. Why you no work no more? Please? - 10https://bugzilla.wikimedia.org/72725 (10James Forrester) p:5Unprio>3High
[23:12:47] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: [Regression] Ctrl+A. Why you no work no more? Please? - 10https://bugzilla.wikimedia.org/72725 (10James Forrester) 3ASSI p:3Unprio s:3normal a:3Ed Sanders Please.
[23:12:51] <grrrit-wm>	 (03PS8) 10Mooeypoo: Eventify TemplateDataGenerator and use oojs-ui [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 
[23:14:12] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Tables drop their class when pasted in IE11 - 10https://bugzilla.wikimedia.org/72599#c1 (10James Forrester) 5NEW>3ASSI Is this fixed now that table editing has landed?
[23:14:47] * mooeypoo does the "IT PASSES QUnit TESTS!" dance
[23:14:55] <RoanKattouw>	 YAY
[23:15:07] <RoanKattouw>	 mooeypoo: Quote from last year: "Wait, why are my tests PASSING?!"
[23:15:28] <wikibugs>	 3VisualEditor: VisualEditor: Text in Insert menu and in Option menu displays differently - 10https://bugzilla.wikimedia.org/61150 (10James Forrester) 5NEW>3RESO/WOR
[23:16:54] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] MWTransclusionModel: Exclude parts serialising to '' from the plain object [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169638 (https://bugzilla.wikimedia.org/63341) (owner: 10Alex Monk)
[23:17:02] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Reference numbers do not display properly on fr.wp - 10https://bugzilla.wikimedia.org/60280#c2 (10James Forrester) 5NEW>3RESO/FIX Fixed ages ago, I think.
[23:17:13] <RoanKattouw>	 TrevorParscal: https://gerrit.wikimedia.org/r/169546
[23:18:12] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: After saving a page, the FlaggedRevs notice "1 change in this version is pending review ..." is not shown - 10https://bugzilla.wikimedia.org/60718 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal
[23:18:20] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] Clear selection after tearing down surface to work around Firefox bug [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169546 (https://bugzilla.wikimedia.org/71852) (owner: 10Catrope)
[23:18:51] <mooeypoo>	 RoanKattouw, actually, I just found a bug in my code, but in this case, the unit tests couldn't have figured it out. Not sure if I can have a test for that, since it requirest the API and I can't automatically assume wikis will have a specific page response.
[23:18:57] <wikibugs>	 3VisualEditor: VisualEditor: crashing when trying to save a reference? - 10https://bugzilla.wikimedia.org/63992#c1 (10James Forrester) 5UNCO>3RESO/WOR Insufficient information to triage.
[23:19:26] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Remove transclusion node if we were just going to set it to empty content - 10https://bugzilla.wikimedia.org/63341 (10Alex Monk) 5PATC>3RESO/FIX
[23:19:42] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Remove transclusion node if we were just going to set it to empty content - 10https://bugzilla.wikimedia.org/63341 (10Alex Monk)
[23:19:52] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] ButtonInputWidget: Explicitly disallow setting value when using <input/> [oojs/ui] - 10https://gerrit.wikimedia.org/r/169206 (owner: 10Bartosz Dziewoński)
[23:20:28] <wikibugs>	 3VisualEditor: When a template is in a section title, VE consider what is on the same line after as if it was into the template - 10https://bugzilla.wikimedia.org/63289 (10James Forrester) 5NEW>3RESO/FIX
[23:20:50] <grrrit-wm>	 (03Merged) 10jenkins-bot: MWTransclusionModel: Exclude parts serialising to '' from the plain object [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169638 (https://bugzilla.wikimedia.org/63341) (owner: 10Alex Monk)
[23:21:27] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] OoUiTag: HTML-escape everything by default [oojs/ui] - 10https://gerrit.wikimedia.org/r/169106 (https://bugzilla.wikimedia.org/72542) (owner: 10Bartosz Dziewoński)
[23:21:38] <grrrit-wm>	 (03Merged) 10jenkins-bot: Clear selection after tearing down surface to work around Firefox bug [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169546 (https://bugzilla.wikimedia.org/71852) (owner: 10Catrope)
[23:22:08] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] Move 'readOnly' from InputWidget to TextInputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/168920 (owner: 10Bartosz Dziewoński)
[23:24:28] <wikibugs>	 3VisualEditor: VisualEditor: JS parse error appears while enabling few gadgets for editors - 10https://bugzilla.wikimedia.org/56806 (10James Forrester) 5UNCO>3RESO/INV
[23:25:44] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: Math rendering 2.0 does not work in edit mode - 10https://bugzilla.wikimedia.org/72539 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal a:3Ed Sanders
[23:26:33] <grrrit-wm>	 (03PS9) 10Mooeypoo: Eventify TemplateDataGenerator and use oojs-ui [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 
[23:26:38] <mooeypoo>	 There.
[23:26:42] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] Semiautomatically compare and synchronise JS and PHP docs [oojs/ui] - 10https://gerrit.wikimedia.org/r/168835 (https://bugzilla.wikimedia.org/72455) (owner: 10Bartosz Dziewoński)
[23:26:43] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: Math rendering 2.0 does not work in edit mode - 10https://bugzilla.wikimedia.org/72539#c1 (10James Forrester) Isn't this what gerrit 130828 was for?
[23:26:44] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: [Regression wmf5] FocusableNodes not selectable when surface is blurred - 10https://bugzilla.wikimedia.org/72721 (10Roan Kattouw)
[23:26:49] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] Generate and run a JS/PHP comparison test suite [oojs/ui] - 10https://gerrit.wikimedia.org/r/168910 (https://bugzilla.wikimedia.org/72588) (owner: 10Bartosz Dziewoński)
[23:27:26] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] Conf for doxygen based PHP doc [oojs/ui] - 10https://gerrit.wikimedia.org/r/168490 (https://bugzilla.wikimedia.org/72454) (owner: 10Hashar)
[23:27:44] <mooeypoo>	 Krinkle, it's ready for your review, oh javascript master. I hope you don't completely dislike what I did there with 'compare'; though I think you're going to like my handling of languages. We planned that for a while, I think I found a decent solution for it.
[23:28:13] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Cut+paste of {{convert}} and {{cite web}} unleashes invasion of snowman clone army in endless loop - 10https://bugzilla.wikimedia.org/72512#c2 (10James Forrester) 5NEW>3RESO/FIX p:5Unprio>3Highes s:5normal>3major Yeah, sorry for this; fixed and back...
[23:29:53] <grrrit-wm>	 (03Merged) 10jenkins-bot: Semiautomatically compare and synchronise JS and PHP docs [oojs/ui] - 10https://gerrit.wikimedia.org/r/168835 (https://bugzilla.wikimedia.org/72455) (owner: 10Bartosz Dziewoński)
[23:31:13] <wikibugs>	 3VisualEditor / 3Editing Tools: VE: Failed to parse(lexing error) when pasting special character into formula - 10https://bugzilla.wikimedia.org/72499#c1 (10James Forrester) 5NEW>3RESO/WOR This is because LaTeX doesn't allow non-ASCII characters. :-(
[23:31:24] <grrrit-wm>	 (03Merged) 10jenkins-bot: Move 'readOnly' from InputWidget to TextInputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/168920 (owner: 10Bartosz Dziewoński)
[23:31:26] <grrrit-wm>	 (03Merged) 10jenkins-bot: OoUiTag: HTML-escape everything by default [oojs/ui] - 10https://gerrit.wikimedia.org/r/169106 (https://bugzilla.wikimedia.org/72542) (owner: 10Bartosz Dziewoński)
[23:31:29] <wikibugs>	 3VisualEditor / 3Data Model: VisualEditor: [Regression wmf4] "Uncaught TypeError: Cannot read property 'resolve' of null" when applying language annotation to an image, the inspector remains open - 10https://bugzilla.wikimedia.org/72259#c6 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production
[23:32:57] <wikibugs>	 3VisualEditor: Math code turned into snowmen symbols (☃) - 10https://bugzilla.wikimedia.org/72491#c2 (10James Forrester) 5NEW>3RESO/WOR Can't reproduce as written. :-(
[23:33:00] <grrrit-wm>	 (03Merged) 10jenkins-bot: Generate and run a JS/PHP comparison test suite [oojs/ui] - 10https://gerrit.wikimedia.org/r/168910 (https://bugzilla.wikimedia.org/72588) (owner: 10Bartosz Dziewoński)
[23:33:17] <grrrit-wm>	 (03Merged) 10jenkins-bot: ButtonInputWidget: Explicitly disallow setting value when using <input/> [oojs/ui] - 10https://gerrit.wikimedia.org/r/169206 (owner: 10Bartosz Dziewoński)
[23:33:19] <grrrit-wm>	 (03Merged) 10jenkins-bot: Conf for doxygen based PHP doc [oojs/ui] - 10https://gerrit.wikimedia.org/r/168490 (https://bugzilla.wikimedia.org/72454) (owner: 10Hashar)
[23:34:28] <wikibugs>	 3VisualEditor / 3Initialisation: VisualEditor: Magically work around Internet Explorer's caching of HTTP errors somehow - 10https://bugzilla.wikimedia.org/72480#c1 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal s:5normal>3enhanc Not sure how we could work around browser-intentional behaviour li...
[23:37:28] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression wmf3] External links in templates are rendered as red links now - 10https://bugzilla.wikimedia.org/72251#c5 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in en.wiki
[23:37:40] <Krinkle>	 mooeypoo: Hm. shoulnd't need to do the functinal code path with $.type() for simple primitive types as you have it. Native typeof should perform better for that and works just as well
[23:40:03] <mooeypoo>	 Krinkle, the only problem I had with typeof is that it didn't distinguish between array and object
[23:40:11] <mooeypoo>	 and I needed to distinguish between those
[23:40:24] <Krinkle>	 mooeypoo: You're not using object and array anywhere.
[23:40:33] <Krinkle>	 with typeof or $.type
[23:41:07] <Krinkle>	 (I;m referring to .static.compare)
[23:41:21] <Krinkle>	 That's from a quick scan. will check further tomorrow.
[23:41:27] <Krinkle>	 I'm excited by the .core file being removed
[23:42:34] * mooeypoo nods
[23:42:47] <mooeypoo>	 Krinkle, I'm dealing with arrays and objects differently in compare
[23:42:58] <mooeypoo>	 I had a big problem when arrays were recognized as "objects" 
[23:43:22] <mooeypoo>	 We had a discussion here a couple of days ago about it iirc -- thta's why I switched to $.type()
[23:43:45] <Krinkle>	 Yeah
[23:43:58] <Krinkle>	 at the time you had it in a variable and needed to get a single value and compare it
[23:44:00] <mooeypoo>	 $.type( obj1 ) !== $.type( obj2 ) <-- this was the culprit
[23:44:03] <Krinkle>	 then $.type makes sense
[23:44:04] <Krinkle>	 Yeah
[23:44:14] * mooeypoo nods
[23:44:26] <Krinkle>	 but if you're comparing directly, better bypass it (stirng, numner, boolean, undefined)
[23:44:36] <mooeypoo>	 I see
[23:44:47] <mooeypoo>	 okay, cool. I thought it was a better test, but I can fix it
[23:45:04] <Krinkle>	 be careful with $.type "object" that doesn't include Array, Date, Function, RegExp or Error
[23:45:15] * mooeypoo nods
[23:45:16] <Krinkle>	 those objects have their own $.type
[23:45:27] <mooeypoo>	 Yeah, I know.
[23:45:32] <Krinkle>	 so if you use 'object' beware the other native objects  need to be handled elsewhere
[23:45:51] <mooeypoo>	 In tihs case, we're comparing templatedata property values, these can be numbers, strings, objects and arrays
[23:46:00] <Krinkle>	 Right
[23:46:08] <mooeypoo>	 and even the numbers and strings are usually just strings, since I don't cast for numeric
[23:46:10] <mooeypoo>	 oh, and boolean
[23:46:24] <mooeypoo>	 so this *should* be safe. I just needed a specific way to differentiate simple objects from arrays
[23:46:41] <mooeypoo>	 I might add (soon, with the paramOrder fix on top) a way to compare array order too
[23:46:52] <Krinkle>	 Hm.. OK. It looks a bit odd to have the last case be isPlainObject in that case, looks like it's implicit there won't be any other types of values. It doesn't decect or handle that
[23:46:55] <Krinkle>	 and just returns true
[23:46:56] <mooeypoo>	 not sure if I should include it in the same method, but we'll see. If it makes sense, maybe
[23:47:13] <Krinkle>	 ideally a function wouldn't end like that
[23:47:34] <mooeypoo>	 Ah, yes, I thought I accounted for all the cases where the conditions for false are met
[23:47:36] <mooeypoo>	 but you have a point
[23:47:37] <Krinkle>	 maybe treat all other objects the same as plain object. so they're not unhandled.
[23:47:55] <Krinkle>	 I mean, I get that would "never happen"
[23:48:16] <mooeypoo>	 the idea was to prevent lots of "else" clauses
[23:48:36] <mooeypoo>	 But yes, you're right
[23:49:08] <mooeypoo>	 and I should add 'null' too
[23:49:14] <mooeypoo>	 same as undefined in my case
[23:49:39] <mooeypoo>	 or... is it. hm.
[23:49:54] <mooeypoo>	 well, in templatedata case it's the "same" (non value) but logically, null is a value
[23:50:57] <wikibugs>	 3VisualEditor / 3Data Model: VisualEditor: [Regression wmf4] Applying link to an image gives "Uncaught TypeError: Cannot read property 'from' of null ",  inspector stays open - 10https://bugzilla.wikimedia.org/72258#c5 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production.
[23:51:04] <mooeypoo>	 Why does this work?
[23:51:43] <mooeypoo>	 Krinkle, TemplateDataModel.static.compare( null, null ) --> true; TemplateDataModel.static.compare( null, [] ); --> false; TemplateDataModel.static.compare( null, undefined ); --> false; TemplateDataModel.static.compare( null, {} ); --> false
[23:51:48] <mooeypoo>	 ... it works...
[23:52:13] <mooeypoo>	 ah! $.type() !== $.type()
[23:52:14] <mooeypoo>	 right
[23:52:23] <RoanKattouw>	 mooeypoo: And {}, [] ?
[23:52:29] <RoanKattouw>	 That's always a nice test case
[23:52:31] <mooeypoo>	 false
[23:52:38] <mooeypoo>	 I have it in my unit tests
[23:52:41] <mooeypoo>	 first test!
[23:53:27] <mooeypoo>	 Hm, so the first test is nice and fixes 90% of my stuff EXCEPT for subsets
[23:53:31] <mooeypoo>	 this actually kinda kills it
[23:53:33] <mooeypoo>	 i should fix that
[23:53:36] <Krinkle>	 :)
[23:54:09] <mooeypoo>	 ohhhhhh
[23:54:26] <mooeypoo>	 TemplateDataModel.static.compare( null, undefined ); ( false )
[23:54:31] <mooeypoo>	 TemplateDataModel.static.compare( null, undefined, true ); ( TRUE )
[23:54:38] <mooeypoo>	 oi!
[23:54:47] <mooeypoo>	 them damn subsets!
[23:55:00] <RoanKattouw>	 What does ,true do?
[23:55:16] <mooeypoo>	 actually ... that should be true, but {} [], true shouldn't.
[23:55:20] * mooeypoo needs to recheck these
[23:55:24] <mooeypoo>	 RoanKattouw, "allow subsets"
[23:55:54] <mooeypoo>	 so, allows for the second object to be a subset of the first
[23:56:56] <Krinkle>	 I bet ", true" invokes Math.random()
[23:56:58] <Krinkle>	 :P
[23:57:12] <Krinkle>	 That'd be fun
[23:57:45] <Krinkle>	 if (x==true) { Math.random( case 0: get another random and cast to bool, case 1: return actual result)
[23:58:45] <grrrit-wm>	 (03PS1) 10Catrope: Fix selection transitions between FocusableNodes and non-linear selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/169966 (https://bugzilla.wikimedia.org/72721) 
[23:58:46] <Krenair>	 ryasmeen, did you retry https://bugzilla.wikimedia.org/show_bug.cgi?id=71157#c7 in beta?
[23:59:05] <mooeypoo>	 haha
[23:59:09] <mooeypoo>	 i should totally do that
[23:59:23] <RoanKattouw>	 ryasmeen: https://gerrit.wikimedia.org/r/169966 :D
[23:59:48] <mooeypoo>	 Krinkle, RoanKattouw, actually, with subsets, "null, undefined" should return true (null is a value, undefined is a subset, mathematically speaking) but undefined, null should return false
[23:59:56] * mooeypoo should add more unit tests for those