[00:00:28] Krenair: https://bugzilla.wikimedia.org/show_bug.cgi?id=71157#c8 [00:00:28] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf1] Template parameter autovalues are not saved - 10https://bugzilla.wikimedia.org/71157#c8 (10Roan Kattouw) (In reply to Rummana Yasmeen from comment #7) > This seem to be not working in production (en.wiki).I dont even see the > substitute values... [00:00:38] Krenair: (we discussed this in person but I forgot to log it on the bug) [00:00:58] Hey Krenair, yeah it is auto-saving the parameter values in Beta properlybut not in production because the parameter values are set as empty in the template data for Citation needed [00:01:25] oh thanks RoanKattouw for the fix :) [00:01:42] ok, set it back to fixed then [00:01:47] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf1] Template parameter autovalues are not saved - 10https://bugzilla.wikimedia.org/71157 (10Alex Monk) 5ASSI>3RESO/FIX [00:01:50] ryasmeen: Unfortunately it's in wmf5 :( at least the non-table part of the bug [00:02:04] In fact it was caused by the Great Selection Rewrite, and I think that might have been wmf4 or wmf3? [00:02:21] Yeah, wmf4 [00:02:34] oh no! really? [00:02:36] (03CR) 10Catrope: "Regression from the Great Selection Rewrite: https://gerrit.wikimedia.org/r/#/c/163850/" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/169966 (https://bugzilla.wikimedia.org/72721) (owner: 10Catrope) [00:02:39] Yeah :S [00:02:59] Also as I said in the last paragraph of the commit summary, I found and fixed a related bug too [00:03:12] If you clicked a reference or a comment or whatever, then clicked into a table, it didn't unselect the reference [00:04:04] But wait, I dont see it wmf5 in production neither on wmf 6 [00:04:30] RoanKattouw: I mean https://bugzilla.wikimedia.org/72721 [00:04:45] Wait really? [00:05:15] (03PS1) 10Jforrester: Set input/menu widgets to have a max-width expanding to 100% rather than hard-coded [oojs/ui] - 10https://gerrit.wikimedia.org/r/169968 (https://bugzilla.wikimedia.org/72112) [00:06:14] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression wmf3] The fields inside Citations dialog are appearing at a fixed rather than whole-screen width in mobile VE - 10https://bugzilla.wikimedia.org/72112 (10James Forrester) a:3James Forrester [00:06:54] (03CR) 10Trevor Parscal: [C: 032] Set input/menu widgets to have a max-width expanding to 100% rather than hard-coded [oojs/ui] - 10https://gerrit.wikimedia.org/r/169968 (https://bugzilla.wikimedia.org/72112) (owner: 10Jforrester) [00:08:44] (03Merged) 10jenkins-bot: Set input/menu widgets to have a max-width expanding to 100% rather than hard-coded [oojs/ui] - 10https://gerrit.wikimedia.org/r/169968 (https://bugzilla.wikimedia.org/72112) (owner: 10Jforrester) [00:10:29] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (da4b0d5c14) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/169969 [00:12:28] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression] Adding category sort keys no longer working - 10https://bugzilla.wikimedia.org/72168#c6 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production [00:49:18] (03PS1) 10Alex Monk: Catch pagedeleted errors and give the ability to re-create the page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169976 (https://bugzilla.wikimedia.org/52073) [01:21:00] 3VisualEditor: Cite URL when clicked should open in new page - 10https://bugzilla.wikimedia.org/72730 (10Chris McMahon) 3NEW p:3Unprio s:3enhanc a:3None Cite URL when clicked should open in new page. Cyndy Eng-Dinsel (cynthetic@gmail.com) created this page at GTAC2014. http://test2.wikipedia.org/wiki... [01:39:16] 3VisualEditor: Cite URL when clicked should open in new page - 10https://bugzilla.wikimedia.org/72730#c1 (10James Forrester) I don't see the bug? It opens in a new tab for me in Chrome and Firefox. What browser is this in? [01:41:42] 3OOjs UI: OOjs UI: PHP docs should be auto-generated - 10https://bugzilla.wikimedia.org/72454#c3 (10James Forrester) 5PATC>3ASSI Does this now need a jenkins config change? [01:41:58] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression wmf3] The fields inside Citations dialog are appearing at a fixed rather than whole-screen width in mobile VE - 10https://bugzilla.wikimedia.org/72112 (10James Forrester) 5PATC>3RESO/FIX [01:41:58] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression wmf3] The fields inside Citations dialog are appearing at a fixed rather than whole-screen width in mobile VE - 10https://bugzilla.wikimedia.org/72112 (10James Forrester) [01:42:31] 3OOjs UI: OOUI PHP: No simple way to add HTML-escaped text to a Element - 10https://bugzilla.wikimedia.org/72542 (10James Forrester) 5PATC>3RESO/FIX [01:42:31] 3OOjs UI: OOUI: Unit tests to ensure comparable JS and PHP output for the same configs - 10https://bugzilla.wikimedia.org/72588 (10James Forrester) 5PATC>3RESO/FIX [01:42:59] 3OOjs UI: OOUI: Synchronise JS and PHP docs better - 10https://bugzilla.wikimedia.org/72455 (10James Forrester) 5PATC>3RESO/FIX [01:43:42] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf3] In Firefox, Cursor is appearing in Read mode at the end of the document after saving a page and after discarding the current edit in Firefox - 10https://bugzilla.wikimedia.org/71852 (10James Forrester) 5PATC>3RESO/FIX [01:44:59] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf6] There is an extra space appearing at the top of the toolbar inside VE - 10https://bugzilla.wikimedia.org/72693 (10James Forrester) 5PATC>3RESO/FIX [01:49:34] (03CR) 10Jforrester: [C: 031] Remove more references to ve.bind [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169644 (https://bugzilla.wikimedia.org/72156) (owner: 10Alex Monk) [01:51:16] (03PS10) 10Mooeypoo: Eventify TemplateDataGenerator and use oojs-ui [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 [01:51:48] (03CR) 10jenkins-bot: [V: 04-1] Eventify TemplateDataGenerator and use oojs-ui [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 (owner: 10Mooeypoo) [01:51:57] (03PS11) 10Mooeypoo: Eventify TemplateDataGenerator and use oojs-ui [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 [01:52:02] bah [07:54:23] Good morning. Can anyone help me with this: [07:54:48] I have installed a Visual Editor on a MediaWiki 1.23.3 it works, but not completely: [07:55:18] it can not access any media anywhere in the wiki - neither the uploaded files are being shown, nor the already linked files in the articles [07:55:46] the offline-page for integration tests has similar issues, but at least that one sees the images already linked [07:56:33] so what I'd want to know is: is this normal and is there a way to work around this, so the editor can access the stored media? [07:57:09] the wiki is private, however setting the read permissions for * to true did not produce the expected result [07:59:32] addition: the errorlog shows a failed API-Request when trying to parse a page [08:18:29] 3VisualEditor: Editing an Image transclusion, lost the "link" parameter - 10https://bugzilla.wikimedia.org/72750 (10Adam Wight) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce: * Went to my user page, mw:User:Adamw . * Clicked "Edit" to use the VisualEditor. * Clicked the thumbnail at the top, to e... [08:20:41] 3VisualEditor: Editing an Image transclusion, lost the "link" parameter - 10https://bugzilla.wikimedia.org/72750#c1 (10Adam Wight) I gave it a second try, and went to add the missing parameter with VE. It was not supported anywhere... [08:30:50] another add: newly uploaded images are not seen as well [08:38:57] and another: added pictures from the commons are being accepted by the VE. Trying to copy the settings of those pictures to other, already linked pictures or other media yielded no results as well [09:09:19] (03CR) 10Esanders: [C: 032] Fix selection transitions between FocusableNodes and non-linear selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/169966 (https://bugzilla.wikimedia.org/72721) (owner: 10Catrope) [09:11:21] (03Merged) 10jenkins-bot: Fix selection transitions between FocusableNodes and non-linear selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/169966 (https://bugzilla.wikimedia.org/72721) (owner: 10Catrope) [09:30:54] Retry [09:32:37] Good morning. Can anyone help me with this: I have installed a Visual Editor on a MediaWiki 1.23.3 it works, but not completely: [09:32:49] it can not access any media anywhere in the wiki - neither the uploaded files are being shown, nor the already linked files in the articles the offline-page for integration tests has similar issues, but at least that one sees the images already linked [09:33:03] so what I'd want to know is: is this normal and is there a way to work around this, so the editor can access the stored media? the wiki is private, however setting the read permissions for * to true did not produce the expected result addition: the errorlog shows a failed API-Request when trying to parse a page [09:33:15] another add: newly uploaded images are not seen as well and another: added pictures from the commons are being accepted by the VE. Trying to copy the settings of those pictures to other, already linked pictures or other media yielded no results as well [09:33:49] hm. may need to reformat that text. [10:04:54] (03CR) 10Zfilipin: [C: 04-1] "Voting -1 (until the question is answered) so it shows as reviewed in my Gerrit dashboard." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169251 (owner: 10Ryasmeen) [10:13:09] (03CR) 10Esanders: "Is this related to I051ef92ee?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169546 (https://bugzilla.wikimedia.org/71852) (owner: 10Catrope) [10:57:22] (03CR) 10Krinkle: "Why is this script written in ruby? I don't see any upstream dependencies or complicated built-ins that would make it an obvious choice. W" [oojs/ui] - 10https://gerrit.wikimedia.org/r/168910 (https://bugzilla.wikimedia.org/72588) (owner: 10Bartosz Dziewoński) [10:58:07] (03CR) 10Krinkle: "From patch set 7 about JSPHP.test: Why is this function re-defined each iteration? I think this is what loopfunc is supposed to discourage" [oojs/ui] - 10https://gerrit.wikimedia.org/r/168910 (https://bugzilla.wikimedia.org/72588) (owner: 10Bartosz Dziewoński) [11:05:10] (03CR) 10Krinkle: "FIXME: By using PHP for our js tests, our tests are no longer runnable without a server. These newly added tests are not run from npm-test" [oojs/ui] - 10https://gerrit.wikimedia.org/r/168910 (https://bugzilla.wikimedia.org/72588) (owner: 10Bartosz Dziewoński) [11:10:43] 3OOjs UI: OOjs UI: PHP docs should be auto-generated - 10https://bugzilla.wikimedia.org/72454#c4 (10Antoine "hashar" Musso (WMF)) (In reply to James Forrester from comment #3) > Does this now need a jenkins config change? Definitely :-) I wrote an overview of the architecture we are using to generate docume... [11:14:58] 3OOjs UI: OOjs UI: PHP docs should be auto-generated - 10https://bugzilla.wikimedia.org/72454#c5 (10Antoine "hashar" Musso (WMF)) And I just found out on stackoverflow that we can probably override the destination directory used by doxygen using something like: ( cd $WORKSPACE/src/$ZUUL_PROJECT; cat Doxyfile... [11:54:27] 3VisualEditor / 3Editing Tools: VisualEditor: 
 or  entire selected block - 10https://bugzilla.wikimedia.org/72706 (10Elitre)
[11:55:41] 	 3VisualEditor / 3Editing Tools: VisualEditor: 
 or  entire selected block - 10https://bugzilla.wikimedia.org/72706#c1 (10Elitre) s:5normal>3enhanc (If I select multiple lines, I'm able to wrap them in code tags using the corresponding option in the toolbar. How is this different from your reque...
[11:57:12] 	 RoanKattouw_away, InezK_away indeed - noHighlight was previously used to prevent highlighting of parent wrappers we didn't consider to be part of the main shape
[11:57:44] 	 We don't actually use it anywhere at the moment. The last place it was used (galleries) we just changed the wrapper to use display: inline-block
[12:08:00] 	 3VisualEditor: VisualEditor does not display Files, and can not access the local files - 10https://bugzilla.wikimedia.org/72760 (10Lhug) 3UNCO p:3Unprio s:3normal a:3None Intention: Trying to edit a page with linked files on a private wiki. Mainly to test if the Visual Editor functions are usable.  Ste...
[12:15:12] 	 3VisualEditor: Math code turned into snowmen symbols (☃) - 10https://bugzilla.wikimedia.org/72491#c3 (10Elitre) 5RESO/WOR>3REOP It's a copy/pasting issue, according to the user: "When I try to copy/paste some line which has formulas I've got the line duplicated: one line with "snowmen" at the formulas and...
[12:43:41] 	 3VisualEditor: VisualEditor does not display Files, and can not access the local files - 10https://bugzilla.wikimedia.org/72760#c1 (10Lhug) A direct call of the api query the VE starts shows definite parsing errors. https://dpaste.de/8AhK is the result of the API-Query on the live system.  https://dpaste.de/DK...
[12:45:55] 	 (03PS1) 10Esanders: Refactor and fix table cell editing code [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170014 
[13:11:56] 	 3VisualEditor: VisualEditor does not display Files, and can not access the local files - 10https://bugzilla.wikimedia.org/72760#c2 (10Lhug) Created attachment 16956   --> https://bugzilla.wikimedia.org/attachment.cgi?id=16956&action=edit Parsoid Log w. debug  This is the Parsoid log with debugging info when op...
[13:53:19] 	 (03PS1) 10Zfilipin: WIP [BrowserTest] Trying to fix language screenshots [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170026 
[14:04:00] 	 (03PS1) 10Esanders: Store intended table selection before expansion and use when translating [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170027 
[14:51:33] 	 (03PS2) 10Esanders: Refactor and fix table cell editing code [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170014 
[14:51:35] 	 (03PS1) 10Esanders: Support editing of caption nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170043 
[15:18:19] 	 (03PS1) 10Esanders: Always emit context change on null selection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170048 
[15:47:21] 	 (03PS1) 10Esanders: Table caption tool [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170053 
[16:15:12] 	 3VisualEditor / 3Editing Tools: VisualEditor: 
 or  entire selected block - 10https://bugzilla.wikimedia.org/72706#c2 (10dr0ptp4kt) Suppose one visits an article using Google Chrome for Mac OS. After selecting two consecutive paragraphs in the "Viewing Profile Info" section, then choosing either "P...
[16:15:26] 	 3VisualEditor / 3Editing Tools: VisualEditor: 
 or  entire selected block - 10https://bugzilla.wikimedia.org/72706#c3 (10dr0ptp4kt) Ignore the "Viewing Profile Info" part. It could be any section :)
[16:17:26] 	 3VisualEditor / 3ContentEditable: VisualEditor: [Regression] Ctrl+A. Why you no work no more? Please? - 10https://bugzilla.wikimedia.org/72725#c1 (10Ed Sanders) Chromium bug, has been around for a year, but maybe we've made it more common by having ce=false slugs?  https://code.google.com/p/chromium/issues/d...
[16:24:26] 	 3VisualEditor / 3ContentEditable: VisualEditor: [Regression] Ctrl+A. Why you no work no more? Please? - 10https://bugzilla.wikimedia.org/72725#c2 (10Ed Sanders) Solutions:  1. Book-end the document with selectable but invisible content. Have to make sure this doesn't break ve.ce.getOffset.  2. Register CTRL+...
[16:27:44] 	 (03PS1) 10SuchetaG: Replacing MWTitleInputWidget.getvalue() with MWTitleInputWidget.getTitle() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170071 
[16:30:29] 	 Corruption alert: visualeditor-needcheck on nowiki: https://no.wikipedia.org/?diff=13490021
[16:30:29] 	 Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=108667760
[16:30:29] 	 Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=33119637
[16:30:29] 	 Corruption alert: visualeditor-needcheck on hewiki: https://he.wikipedia.org/?diff=16137061
[17:04:46] 	 (03PS2) 10SuchetaG: Replacing MWTitleInputWidget.getvalue() with MWTitleInputWidget.getTitle() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170071 
[17:26:14] 	 RoanKattouw_away, programmatic ctrl+a would let us do something sensible with table selections too
[17:26:30] 	 and when focusables are selected
[17:27:12] 	 also we have a hack in place to stop FF putting the cursor to the left of the first 
 when you press ctrl+a, which can go
[17:28:27] 	 Yeah I like it
[17:33:46] 	 RoanKattouw, now I can't find said hack
[17:34:08] 	 and FF is broken again (selects to 0)
[17:34:13] 	 someone must have deleted it
[17:35:03] 	 ah, it's it surfacefragment.delete
[17:40:22] 	 (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (da4b0d5c14) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/169969 (owner: 10Jforrester)
[17:43:10] 	 (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (da4b0d5c14) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/169969 (owner: 10Jforrester)
[17:43:34] 	 (03CR) 10Catrope: "Oooh, good find! Yes, almost certainly." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169546 (https://bugzilla.wikimedia.org/71852) (owner: 10Catrope)
[17:44:19] 	 (03CR) 10Catrope: "I'll see if that commit fixes it, and if so I'll revert this." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169546 (https://bugzilla.wikimedia.org/71852) (owner: 10Catrope)
[17:47:13] 	 RoanKattouw, divec so in this slug rewrite, slugs are unreachable by keyboard and programmatically?
[17:47:19] 	 (only mouse events can trigger them)
[17:48:00] * edsanders observes that setSelection( [0,0] ) does nothing to the view
[17:50:11] 	 oh wait - that only happens in Chrome
[17:50:19] 	 and it's because of this same bug
[17:50:27] 	 lol
[17:50:41] 	 not only does select all not work - it's literally impossible to create a selection over all the content if it starts with ce=false
[17:50:50] 	 which means we *have* to book-end
[17:51:00] * edsanders is angry
[17:56:19] 	 Really?
[17:56:21] 	 *sigh*
[18:01:31] 	 RoanKattouw: https://en.wikipedia.org/w/index.php?title=Strange_Tales_(pulp_magazine)&diff=prev&oldid=631732045
[18:03:27] 	 3VisualEditor: Math code turned into snowmen symbols (☃) - 10https://bugzilla.wikimedia.org/72491#c4 (10James Forrester) (In reply to Elitre from comment #3) > It's a copy/pasting issue, according to the user: "When I try to copy/paste > some line which has formulas I've got the line duplicated: one line with...
[18:05:41] 	 3VisualEditor: Math code turned into snowmen symbols (☃) - 10https://bugzilla.wikimedia.org/72491#c5 (10Elitre) If you think that's the same issue behind https://bugzilla.wikimedia.org/show_bug.cgi?id=72512 , I guess you did?
[18:15:41] 	 3VisualEditor / 3Editing Tools: VisualEditor: Switching out the image clears the "link" parameter - 10https://bugzilla.wikimedia.org/72750#c2 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Low s:5normal>3minor (In reply to Adam Wight from comment #1) > I gave it a second try, and went to add the missi...
[18:16:42] 	 3VisualEditor / 3ContentEditable: VisualEditor: Cut+paste of {{convert}} and {{cite web}} unleashes invasion of snowman clone army in endless loop - 10https://bugzilla.wikimedia.org/72512#c3 (10James Forrester) *** Bug 72491 has been marked as a duplicate of this bug. ***
[18:16:42] 	 3VisualEditor: Math code turned into snowmen symbols (☃) - 10https://bugzilla.wikimedia.org/72491#c6 (10James Forrester) 5REOP>3RESO/DUP Yeah… duping for now.  *** This bug has been marked as a duplicate of bug 72512 ***
[18:18:43] 	 3VisualEditor / 3ContentEditable: VisualEditor: [Regression wmf5] FocusableNodes not selectable when surface is blurred - 10https://bugzilla.wikimedia.org/72721 (10James Forrester) 5PATC>3RESO/FIX a:5Ed Sanders>3Roan Kattouw
[18:24:16] 	 (03CR) 10Catrope: [C: 04-1] Always emit context change on null selection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170048 (owner: 10Esanders)
[18:24:29] 	 (03CR) 10Catrope: [C: 032] "Whoops I meant +2 instead of -1" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170048 (owner: 10Esanders)
[18:26:28] 	 (03Merged) 10jenkins-bot: Always emit context change on null selection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170048 (owner: 10Esanders)
[18:26:29] 	 3VisualEditor / 3ContentEditable: Visual Editor: editing links for images will silently fail  if it is performed from link inspector - 10https://bugzilla.wikimedia.org/72769 (10etonkovidova) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce:   1. Open a page in VE - insert an image and apply a link...
[18:27:19] 	 (03CR) 10Catrope: [C: 04-1] Refactor and fix table cell editing code (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170014 (owner: 10Esanders)
[18:28:25] 	 (03PS2) 10Catrope: Support editing of caption nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170043 (owner: 10Esanders)
[18:29:11] 	 3VisualEditor / 3Editing Tools: VisualEditor: Automatically convert inserted external URLs to readable links - 10https://bugzilla.wikimedia.org/65540#c3 (10James Forrester) p:5Normal>3Low Hmm. Right now we're taking newly-created external links and displaying them as auto-numbered link nodes; having this...
[18:29:43] 	 (03CR) 10Catrope: [C: 032] Support editing of caption nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170043 (owner: 10Esanders)
[18:31:53] 	 RoanKattouw, I just added tests for comparing null/undefined with and without subsets, and it seems to pass properly. 
[18:32:03] 	 (03PS1) 10Esanders: Add table selection support to clear annotation tool [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170109 
[18:32:29] 	 RoanKattouw, so.. I'm waiting for a more specific commentary from you and Krinkle|detached about the code/behavior when you review it
[18:33:54] 	 (03PS2) 10Jforrester: Table caption tool [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170053 (owner: 10Esanders)
[18:33:58] 	 mooeypoo: Link?
[18:34:00] 	 (03CR) 10Jforrester: [C: 032] Table caption tool [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170053 (owner: 10Esanders)
[18:36:48] 	 RoanKattouw, https://gerrit.wikimedia.org/r/#/c/167046/
[18:37:52] 	 eh I'm in an overlaying branch, so I'll actually add the tests to this commit when I commit this one -- but comparing null/undefined with subsets = true; without subsets = false
[18:38:45] 	 (03PS1) 10Catrope: Also add tableCaption to mwTable parentNodeTypes hack [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170111 
[18:38:51] * edsanders has one Inbox invite left
[18:39:03] 	 RoanKattouw?
[18:39:12] 	 I already have one
[18:39:15] 	 3VisualEditor: VisualEditor: Some Table editor menus are hard to find - 10https://bugzilla.wikimedia.org/72770 (10Quiddity) 3NEW p:3Unprio s:3normal a:3None Created attachment 16959   --> https://bugzilla.wikimedia.org/attachment.cgi?id=16959&action=edit screenshot  (On beta.wmflabs) I had a very hard...
[18:39:26] 	 Haven't used it much yet
[18:39:28] 	 3VisualEditor / 3Editing Tools: VisualEditor: In the transclusion dialog, show the normalised parameter name if available - 10https://bugzilla.wikimedia.org/72771 (10James Forrester) 3ASSI p:3Unprio s:3normal a:3Alex Monk Per bug 67657, there's now key.wt going to be available in the Parsoid output;...
[18:39:42] * James_F has some spares too.
[18:39:56] 	 3VisualEditor / 3Editing Tools: VisualEditor: In the transclusion dialog, show the normalised parameter name if available - 10https://bugzilla.wikimedia.org/72771 (10James Forrester) p:5Unprio>3Normal
[18:41:57] 	 3VisualEditor / 3Editing Tools: VisualEditor: In the transclusion dialog, show the normalised parameter name if available - 10https://bugzilla.wikimedia.org/72771#c1 (10Marc Ordinas i Llopis) I think it's the other way around: Now the same code would show "foobar", and if you want to display "foob...
[18:42:26] 	 3VisualEditor / 3Editing Tools: VisualEditor: Some table editor menus are hard to find - 10https://bugzilla.wikimedia.org/72770#c1 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High s:5normal>3enhanc Yeah, I agree. Over-riding the formatting menu is clever but entirely non-obvious, and completely bre...
[18:42:29] 	 James_F: I also get confused :)
[18:42:42] 	 marcoil: Oh. In that case, I might close this. :-)
[18:43:12] 	 It was a very easy bug to fix on the VE side ;)
[18:43:57] 	 3VisualEditor / 3Editing Tools: VisualEditor: In the transclusion dialog, show the non-normalised parameter name if available? - 10https://bugzilla.wikimedia.org/72771#c2 (10James Forrester) p:5Normal>3Lowest s:5normal>3minor a:5Alex Monk>3None Aha, yes.  Still, the comment might be important in...
[18:44:04] * James_F grins.
[18:46:49] 	 Ahm
[18:47:04] 	 Does VE actually preserve the paramWt thing or whatever it's called?
[18:47:16] 	 It should, but I wouldn't just assume that it does that already
[18:53:10] 	 (03PS1) 10Catrope: Update VE core submodule to master (f9f51a5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170115 
[18:53:50] 	 (03CR) 10Jforrester: [C: 032] Update VE core submodule to master (f9f51a5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170115 (owner: 10Catrope)
[18:55:23] 	 (03Merged) 10jenkins-bot: Update VE core submodule to master (f9f51a5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170115 (owner: 10Catrope)
[18:56:02] 	 MatmaRex: how's it going?
[18:56:54] 	 i had a long day today. didn't do anything interesting, alas
[18:57:02] 	 :(
[18:58:13] 	 so, I'm coming up with a list of things we need to do, and it includes things like make OOjs UI themes no longer need to be part of the core OOjs UI repo, start using semver, update/publish packages to npm/bower
[18:58:23] 	 i'll respond to krinkle's tests comments later today probably, and i have a day off university tomorrow, so i'll probably spend the day doing some useful stuff
[18:58:33] 	 cool
[18:59:49] 	 (03PS1) 10Catrope: Preserve original data inside parameter objects too [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170119 
[19:00:15] 	 (03CR) 10Catrope: [C: 032] Add table selection support to clear annotation tool [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170109 (owner: 10Esanders)
[19:02:04] 	 (03Merged) 10jenkins-bot: Add table selection support to clear annotation tool [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170109 (owner: 10Esanders)
[19:03:11] 	 TrevorParscal, I noticed that in OOUI toolbars, the 'catchAll' group gets calculated on tools that haven't been used *yet*
[19:03:30] 	 so that if your catchAll group isn't the right-most group, you're going to have a bad time
[19:03:39] 	 Hah
[19:03:46] 	 e.g. in VE, where table is to the right of insert
[19:04:11] 	 edsanders: yeah... that's not a good design is it?
[19:04:12] 	 as it happens we superfluously label all the table tools as non-catchall
[19:04:32] 	 also the 'insert' menu probably shouldn't be catchAll
[19:04:43] 	 in fact - I'm not sure catchAll should exist at all
[19:04:46] 	 we need to redo the toolbar, I have some ideas about using a tree-like model and view/controller
[19:05:26] 	 yeah, it hasn't been completely rewritten in well over 6 months, what gives
[19:05:44] 	 3VisualEditor: VisualEditor: No indication in the toolbar that text formatting has been changed - 10https://bugzilla.wikimedia.org/72772 (10Quiddity) 3NEW p:3Unprio s:3normal a:3None Created attachment 16960   --> https://bugzilla.wikimedia.org/attachment.cgi?id=16960&action=edit screenshot  Screenshot...
[19:07:27] 	 edsanders: it's long due!
[19:08:25] 	 (03PS3) 10Esanders: Support editing of caption nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170043 
[19:08:27] 	 (03PS3) 10Esanders: Refactor and fix table cell editing code [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170014 
[19:08:29] 	 (03PS3) 10Esanders: Table caption tool [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170053 
[19:12:15] 	 (03CR) 10Catrope: [C: 032] Store intended table selection before expansion and use when translating [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170027 (owner: 10Esanders)
[19:12:33] 	 (03CR) 10Catrope: [C: 032] Refactor and fix table cell editing code [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170014 (owner: 10Esanders)
[19:12:39] 	 (03CR) 10Catrope: [C: 032] Support editing of caption nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170043 (owner: 10Esanders)
[19:12:45] 	 (03CR) 10Catrope: [C: 032] Table caption tool [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170053 (owner: 10Esanders)
[19:13:09] 	 edsanders: https://gerrit.wikimedia.org/r/170111 is needed for that stuff ----^^ to go into VE-MW though
[19:14:03] 	 (03Merged) 10jenkins-bot: Store intended table selection before expansion and use when translating [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170027 (owner: 10Esanders)
[19:14:39] 	 (03CR) 10Esanders: [C: 032] Also add tableCaption to mwTable parentNodeTypes hack [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170111 (owner: 10Catrope)
[19:15:10] 	 (03Merged) 10jenkins-bot: Refactor and fix table cell editing code [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170014 (owner: 10Esanders)
[19:15:12] 	 (03Merged) 10jenkins-bot: Support editing of caption nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170043 (owner: 10Esanders)
[19:15:34] 	 (03Merged) 10jenkins-bot: Table caption tool [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170053 (owner: 10Esanders)
[19:19:28] 	 (03Merged) 10jenkins-bot: Also add tableCaption to mwTable parentNodeTypes hack [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170111 (owner: 10Catrope)
[19:24:04] 	 edsanders: We could put the table structural controls into the structure menu, I guess?
[19:24:44] 	 we're kidding ourselves that that's a structure menu
[19:24:53] 	 Eh.
[19:25:44] 	 I don't think people would mentally group lists and tables together anyway - even if you did think of an icon which encompassed them both
[19:25:54] 	 Perhaps.
[19:26:23] 	 But I think a table-only control on the toolbar which only works when there's a table selected is exceptionally confusing.
[19:26:37] 	 I suggested auto-hide
[19:26:50] 	 That's worse. :-)
[19:27:04] 	 I still don't understand what was wrong with the context menu.
[19:27:21] 	 (03PS1) 10Jforrester: Toolbar: Make styling and insert menus collapsible [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170126 
[19:28:34] 	 James_F, it didn't exist
[19:28:41] 	 (03PS1) 10Jforrester: Update VE core submodule to master (260d6c5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170127 
[19:28:48] 	 OK, rephrase:
[19:28:54] 	 also we've trained the user to use a toolbar
[19:29:07] 	 I still don't understand what was wrong with using the context menu whenever the cursor is in a table.
[19:29:59] 	 a context menu with three items? that's positioned magically somewhere that might interfere with the row/column context?
[19:30:07] 	 and what about merge cells
[19:30:11] 	 Four items.
[19:30:24] 	 Merge cells (disabled when not a merged cell or multiple selection)
[19:30:32] 	 Header (on/off toggle)
[19:30:32] 	 there's a lot of problems to make that work right
[19:30:49] 	 I'm open to working on it, but I don't think we were anywhere near solving that problem
[19:31:18] 	 Don't show the menu on active-cursor, just when selected.
[19:31:51] 	 I missed one meeting and all my objections were ignored. :-(
[19:33:58] 	 placing the context menu over the content makes sense for templates because they're not editable
[19:34:14] 	 for tables you can't really do that as it gets in the way of selection
[19:34:27] 	 Does it?
[19:34:34] 	 placing outside of the table is also problematic if you have a full-width multi-height table
[19:34:45] 	 yes, how do you click on a cell that's obscured by a context menu?
[19:35:07] 	 Press down? Click around the menu widget? Select elsewhere then click where you want? Click-drag to it?
[19:35:10] 	 There are a few ways…
[19:35:31] 	 that's horrible
[19:35:44] 	 the first table in tables.html would be completely obscured by a context menu (and then some)
[19:35:55] 	 Less horrible than the current solution.
[19:36:11] 	 We're talking about a context menu with two items right now.
[19:36:23] 	 that's where you would've been out voted 4-1, even if you did turn up
[19:36:53] 	 Productive. :-P
[19:36:54] 	 already 3 (captions)
[19:36:58] 	 and may grow
[19:37:04] 	 No, we're talking about cell-level functions here.
[19:37:08] 	 Header yes/no.
[19:37:14] 	 Merged yes/no.
[19:37:22] 	 Maybe later "advanced formatting".
[19:37:34] 	 also even two would blot out almost all of a small table
[19:37:38] 	 The /table level/ controls should be somewhere else, obviously, as I've been saying all along.
[19:37:48] 	 Psh. Uncommon issue.
[19:37:54] 	 Most tables are gargantuan.
[19:38:05] 	 in every case they would cover at least one or two cells
[19:38:24] 	 making selecting those cells a pain
[19:38:58] 	 3VisualEditor / 3Mobile: VisualEditor Mobile: The label for "Re-use" tool is not greyed out when the tool is disabled (icon is greyed out) - 10https://bugzilla.wikimedia.org/72405 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal
[19:41:03] 	 I'm sure there are solutions to these problems, and the way we have probably it isn't the best - but we've used stuff that we know works reasonably well and exists.
[19:41:19] 	 well well well James_F mooey|food and everyone involved
[19:41:32] 	 I'm seeing table-related messages in translatewiki \o/
[19:52:11] 	 (03CR) 10Trevor Parscal: [C: 032] Toolbar: Make styling and insert menus collapsible [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170126 (owner: 10Jforrester)
[19:52:42] 	 aharoni: en.wikipedia.beta.wmflabs.org/wiki/User:Jdforrester_(WMF)/Sandbox?veaction=edit
[19:53:14] 	 edsanders: In every case it would cover at least part of at least one cell. In most real-world tables it wouldn't cover an entire width of any one cell.
[19:53:35] 	 edsanders: But you're right, there's not an obvious solution. :-(
[19:56:11] 	 (03Merged) 10jenkins-bot: Toolbar: Make styling and insert menus collapsible [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170126 (owner: 10Jforrester)
[19:58:21] 	 edsanders: Unmerging behaviour with mixed header/nonheader cells looks a bit odd.
[19:59:38] 	 James_F, TrevorParscal why do we need collapsing toolbar menus?
[19:59:49] 	 edsanders: Simplification of UX.
[20:00:16] 	 It doesn't make any task simpler
[20:00:42] 	 edsanders: It allows us to un-hide gallery and hieroglyphics.
[20:00:49] 	 edsanders: And add a bunch more "insert" controls.
[20:01:04] 	 edsanders: And  and  and …
[20:01:12] 	 just promote them and put the others below a spacer
[20:01:40] 	 Sub-grouping is coming, eventually.
[20:01:41] 	 But for now.
[20:02:35] 	 it makes the advanced tools less discoverable, but also when searching for a basic tool you have to click twice in the menus to make sure it isn't there
[20:03:31] 	 also there's no visual difference between 'more' and real buttons
[20:09:29] 	 also when you expand the new items don't all appear below, so I have no idea what I just revealed, unless I have a photographic memory
[20:10:15] 	 edsanders: I think it's a stop-gap solution
[20:10:43] 	 we need to come up with a better way to organize the tools so that they are discoverable, but also not intimidating
[20:11:15] 	 we know that some tools are more commonly needed than others, and ideally those will also be the most commonly used - and thus most prominently placed
[20:11:52] 	 (03PS1) 10Esanders: Missing message from table merge [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170139 
[20:12:39] 	 I want to come up with a direction for VE controls (toolbar, context, inspectors, dialogs) that is may be a little blue-sky, and then iterate toward that
[20:12:56] 	 I think right now we are fiddling a bit, making progress in one place, maybe regressing in another
[20:13:12] 	 yeah
[20:13:37] 	 TrevorParscal: That's good to hear, because I dislike collapsible tool menus
[20:13:50] 	 I think they're an antipattern of Microsoft Word proportions
[20:14:02] 	 (03CR) 10Catrope: [C: 032] Missing message from table merge [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170139 (owner: 10Esanders)
[20:15:29] 	 (03Merged) 10jenkins-bot: Missing message from table merge [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170139 (owner: 10Esanders)
[20:31:18] 	 (03CR) 10Catrope: [C: 04-1] Replacing MWTitleInputWidget.getvalue() with MWTitleInputWidget.getTitle() (033 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170071 (owner: 10SuchetaG)
[20:35:30] 	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf7] Make full size button is slightly over lapping with the input fields of Custom size values  inside Media Settings dialog - 10https://bugzilla.wikimedia.org/72782 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment...
[20:39:14] 	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf7] The group names inside "Use this group" field is appearing in a short form like "g..." for both "References list" and "Basic Reference" dialog when you open these dialogs first time in a session - 10https://bugzilla.wikimedia.org/72783 (10Rum...
[20:39:41] 	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf7] The group names inside "Use this group" field are appearing in a short form like "g..." for both "References list" and "Basic Reference" dialog when you open these dialogs first time in a session - 10https://bugzilla.wikimedia.org/72783 (10Ru...
[20:42:58] 	 3VisualEditor / 3ContentEditable: Visual Editor: Tables - saved table look much smaller than in VE and display grayish background - 10https://bugzilla.wikimedia.org/72784 (10etonkovidova) 3NEW p:3Unprio s:3normal a:3None Created attachment 16963   --> https://bugzilla.wikimedia.org/attachment.cgi?id=...
[20:45:29] 	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf7] For a re-used reference dialog the group names for reference lists are not at all visible in the "Use this group" combo box - 10https://bugzilla.wikimedia.org/72785 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachm...
[20:45:35] 	 TrevorParscal: https://gerrit.wikimedia.org/r/170119
[20:45:50] 	 hey RoanKattouw_away
[20:46:12] 	 (03CR) 10Trevor Parscal: [C: 032] Preserve original data inside parameter objects too [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170119 (owner: 10Catrope)
[20:46:37] 	 When I re-use an existing reference, I am seeing this warning(!) message on top of the dialog that this reference has been used n times, is that something new we are doing for this week?
[20:46:44] 	 Yes
[20:47:34] 	 (03Merged) 10jenkins-bot: Preserve original data inside parameter objects too [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170119 (owner: 10Catrope)
[20:47:44] 	 I guess thats causing https://bugzilla.wikimedia.org/72785 ?
[20:47:58] 	 3VisualEditor / 3ContentEditable: VisualEditor: [Regression] Ctrl+A. Why you no work no more? Please? - 10https://bugzilla.wikimedia.org/72725#c3 (10Ed Sanders) *sigh* Chrome doesn't even let you set such a selection programmatically, so it appears book-ending is required. Although I'd like to do programmati...
[20:48:05] 	 I can't think why it would
[20:48:14] 	 Nooo.... that's me
[20:48:44] 	 3VisualEditor / 3ContentEditable: Visual Editor: Tables - saved tables look much smaller than in VE and display grayish background - 10https://bugzilla.wikimedia.org/72784#c1 (10etonkovidova) After saving an inserted table and then returning to Edit mode - the table still displays the same gray background co...
[20:49:00] 	 :)
[20:49:08] 	 (03CR) 10Bartosz Dziewoński: "> Why is this script written in ruby? I don't see any upstream dependencies or complicated built-ins that would make it an obvious choice." [oojs/ui] - 10https://gerrit.wikimedia.org/r/168910 (https://bugzilla.wikimedia.org/72588) (owner: 10Bartosz Dziewoński)
[20:50:20] 	 RoanKattouw_away, what's you?
[20:50:23] 	 RoanKattouw_away, I was just telling James_F|Away his patch was a bad idea, but "Microsoft Word" bad... that's a bit much!
[20:50:32] 	 you caused the bug ryasmeen linked?
[20:50:48] 	 Yeah probably
[20:51:28] 	 (03PS3) 10Krinkle: Remove more references to ve.bind [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169644 (https://bugzilla.wikimedia.org/72156) (owner: 10Alex Monk)
[20:52:01] 	 ryasmeen: Is that a regression in wmf6?
[20:52:12] 	 Or pre-wmf6, or wmf5?
[20:53:31] 	 (03CR) 10Esanders: "We should avoid language-creep in our projects unless there's a compelling reason. You may find it easier but it raises the barrier to col" [oojs/ui] - 10https://gerrit.wikimedia.org/r/168910 (https://bugzilla.wikimedia.org/72588) (owner: 10Bartosz Dziewoński)
[20:54:31] 	 I am sorry RoanKattouw, its regression wmf 6, I mistakenly tagged as pre-wmf7
[20:54:35] 	 let me correct that
[20:54:46] 	 No worries
[20:55:04] 	 (03PS1) 10Bartosz Dziewoński: JS/PHP comparison test suite tweaks [oojs/ui] - 10https://gerrit.wikimedia.org/r/170155 
[20:55:07] 	 Regression wmf6 makes me happy because then it's at least possible that it was caused by what I think it was caused by :)
[20:55:14] 	 (03CR) 10Bartosz Dziewoński: "Follow-up for CRLF and loopfunc: https://gerrit.wikimedia.org/r/170155" [oojs/ui] - 10https://gerrit.wikimedia.org/r/168910 (https://bugzilla.wikimedia.org/72588) (owner: 10Bartosz Dziewoński)
[20:55:56] 	 (03PS4) 10Krinkle: Remove more references to ve.bind [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169644 (https://bugzilla.wikimedia.org/72156) (owner: 10Alex Monk)
[20:55:57] 	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf6] For a re-used reference dialog the group names for reference lists are not at all visible in the "Use this group" combo box - 10https://bugzilla.wikimedia.org/72785 (10Rummana Yasmeen)
[20:56:13] 	  haha good! :)
[20:56:23] 	 (03CR) 10Krinkle: "variable assignment on separate line." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169644 (https://bugzilla.wikimedia.org/72156) (owner: 10Alex Monk)
[20:56:29] 	 (03CR) 10Krinkle: [C: 032] Remove more references to ve.bind [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169644 (https://bugzilla.wikimedia.org/72156) (owner: 10Alex Monk)
[20:58:52] 	 (03CR) 10Bartosz Dziewoński: "Ed, if you think rewriting these scripts in JS is a valuable use of time, file a tech debt bug and I'll get around to it some time when I " [oojs/ui] - 10https://gerrit.wikimedia.org/r/168910 (https://bugzilla.wikimedia.org/72588) (owner: 10Bartosz Dziewoński)
[21:00:41] 	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf6] There is an extra space appearing at the top of the toolbar inside VE - 10https://bugzilla.wikimedia.org/72693#c8 (10Rummana Yasmeen) Verified the fix in Betalabs and test2
[21:01:04] 	 (03CR) 10Esanders: "Possibly not, but worth bearing in mind for the future." [oojs/ui] - 10https://gerrit.wikimedia.org/r/168910 (https://bugzilla.wikimedia.org/72588) (owner: 10Bartosz Dziewoński)
[21:01:33] 	 (03CR) 10Krinkle: "For future reference, I do not think "writing in language x is easier, do now, and file tech debt later" is acceptable." [oojs/ui] - 10https://gerrit.wikimedia.org/r/168910 (https://bugzilla.wikimedia.org/72588) (owner: 10Bartosz Dziewoński)
[21:04:32] 	 (03Merged) 10jenkins-bot: Remove more references to ve.bind [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169644 (https://bugzilla.wikimedia.org/72156) (owner: 10Alex Monk)
[21:06:11] 	 3VisualEditor / 3ContentEditable: VisualEditor: [Regression wmf5] FocusableNodes not selectable when surface is blurred - 10https://bugzilla.wikimedia.org/72721#c3 (10Rummana Yasmeen) Verified the fix in Betalabs
[21:06:43] 	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf7] Empty Add Template dialog appearing upon trying to open an existing template from a page - 10https://bugzilla.wikimedia.org/72719#c1 (10Rummana Yasmeen) 5ASSI>3RESO/FIX Fixed by: https://gerrit.wikimedia.org/r/169966
[21:06:58] 	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf7] Empty Add Template dialog appearing upon trying to open an existing template from a page - 10https://bugzilla.wikimedia.org/72719#c2 (10Rummana Yasmeen) Verified the fix in Betalabs
[21:11:45] 	 (03CR) 10Bartosz Dziewoński: "Krinkle, as for the tests, they can't be "written perfectly fine without use of PHP" because the code that is being tested is PHP code. Of" [oojs/ui] - 10https://gerrit.wikimedia.org/r/168910 (https://bugzilla.wikimedia.org/72588) (owner: 10Bartosz Dziewoński)
[21:21:29] 	 3VisualEditor / 3Editing Tools: VisualEditor: The dropdown box for search results in Insert Template dialog sticks to the dialog if you click on "Show Options" button without closing the dropdown - 10https://bugzilla.wikimedia.org/72789 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Created att...
[21:31:34] 	 (03CR) 10Catrope: [C: 032] Update VE core submodule to master (260d6c5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170127 (owner: 10Jforrester)
[21:32:30] 	 3VisualEditor / 3Editing Tools: VisualEditor: Tables - multiple colspan and rowspan are not dislayed correctly - 10https://bugzilla.wikimedia.org/72790 (10etonkovidova) 3NEW p:3Unprio s:3normal a:3None Created attachment 16967   --> https://bugzilla.wikimedia.org/attachment.cgi?id=16967&action=edit C...
[21:32:55] 	 (03Merged) 10jenkins-bot: Update VE core submodule to master (260d6c5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170127 (owner: 10Jforrester)
[21:35:26] 	 (03PS1) 10Bartosz Dziewoński: [BREAKING CHANGE] Rename InlineMenuWidget → DropdownWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/170171 (https://bugzilla.wikimedia.org/70968) 
[21:38:12] 	 3VisualEditor / 3Editing Tools: VisualEditor: Tables - multiple colspan and rowspan are not dislayed correctly - 10https://bugzilla.wikimedia.org/72790#c1 (10etonkovidova) Created attachment 16968   --> https://bugzilla.wikimedia.org/attachment.cgi?id=16968&action=edit Saved table with multiple colspan and r...
[21:39:59] 	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf7] The options under Page Settings and Advances Settings of Page Options dialog are appearing very cramped - 10https://bugzilla.wikimedia.org/72792 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 16969   --> http...
[21:40:27] 	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf7] The options under Page Settings and Advances Settings of Page Options dialog are appearing very cramped - 10https://bugzilla.wikimedia.org/72792#c1 (10Rummana Yasmeen) Created attachment 16970   --> https://bugzilla.wikimedia.org/attachment....
[21:46:30] 	 (03PS1) 10Bartosz Dziewoński: Update OOjs UI to v0.1.0-pre (d6dbeb1ce6) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170175 
[21:48:58] 	 MatmaRex: MultimediaViewer uses InlineMenuWidget and will need to be updated
[21:49:09] 	 When this change is pulled through into MW core that is
[21:50:56] 	 (03PS1) 10Catrope: Add forgotten $overlay pass-through in MWReferenceDialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170176 (https://bugzilla.wikimedia.org/72785) 
[21:52:26] 	 RoanKattouw: oh. let me just fix that
[21:52:39] 	 hmm, they also call it a pulldown menu, rather than dropdown.
[21:54:32] 	 (03PS2) 10Bartosz Dziewoński: Update OOjs UI to v0.1.0-pre (d6dbeb1ce6) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170175 (https://bugzilla.wikimedia.org/70968) 
[22:07:33] 	 (03PS1) 10Esanders: Fix selection when inserting a caption [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170183 
[22:08:29] 	 (03CR) 10Catrope: [C: 032] Fix selection when inserting a caption [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170183 (owner: 10Esanders)
[22:10:40] 	 (03Merged) 10jenkins-bot: Fix selection when inserting a caption [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170183 (owner: 10Esanders)
[22:14:28] 	 3OOjs UI: OOUI PHP: GridLayout RTL support - 10https://bugzilla.wikimedia.org/72584#c1 (10Bartosz Dziewoński) In JS, there's a static method OO.ui.Element.getDir that is used to determine direction. It goes like this:  OO.ui.Element.getDir = function ( obj ) {          <'obj' is usually 'document.bo...
[22:16:56] 	 3OOjs UI / 3Technical Debt: OOjs UI: InlineMenuWidget is not a kind of MenuWidget and should be renamed - 10https://bugzilla.wikimedia.org/70968 (10Bartosz Dziewoński)
[22:23:11] 	 3VisualEditor / 3MediaWiki integration: VisualEditor: Invocation of "lastmodifiedat" message is not updated when page is saved - 10https://bugzilla.wikimedia.org/52403#c4 (10Alex Monk) 5PATC>3ASSI (... I had assumed this was for the LastModified extension without checking the message name.)
[22:39:39] 	 (03PS1) 10Esanders: Add sparse table demo and fix related selection bug [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170235 
[23:02:17] 	 (03CR) 10Catrope: [C: 032] Add sparse table demo and fix related selection bug [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170235 (owner: 10Esanders)
[23:04:32] 	 (03PS1) 10Esanders: Add support for non-table nodes in tables (e.g. aliens) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170245 (https://bugzilla.wikimedia.org/72717) 
[23:04:53] 	 (03Merged) 10jenkins-bot: Add sparse table demo and fix related selection bug [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170235 (owner: 10Esanders)
[23:41:14] 	 James_F|Away: you in meetings?
[23:52:27] 	 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression wmf3] The fields inside Citations dialog are appearing at a fixed rather than whole-screen width in mobile VE - 10https://bugzilla.wikimedia.org/72112#c4 (10etonkovidova) confirmed in betalabs.   Previously it was:  oo-ui-textInputWidget {     .    
w...
[23:55:49] 	 TrevorParscal, is there a way to listen to events from all individual items in OO.ui.GroupWidget items by the "parent" widget?
[23:56:04] 	 (03CR) 10Esanders: "This doesn't yet fix all the edge cases in Roan's evil table. WIP." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170245 (https://bugzilla.wikimedia.org/72717) (owner: 10Esanders)
[23:56:31] 	 mooeypoo: have you seen .aggregate() ?
[23:56:33] 	 so, an item will emit "selected" (or in my case "dragend") event and the parent will intercept it? I can't figure out how to do that without attaching the event to each item when 'addItems()' is called
[23:56:39] 	 so, I've seen it, but I'm a bit confused?
[23:56:40] 	 OO.ui.GroupElement.prototype.aggregate
[23:56:45] 	 ok
[23:57:13] 	 I think it might be a config option instead? But whatever it is, it's definitely called aggregate
[23:57:36] 	 OK TrevorParscal is right because he was actually looking at the code :D
[23:58:55] * mooeypoo nods
[23:59:05] 	 I saw it, and I started looking at the code, I also saw it inside the addItems method
[23:59:23] 	 Sorrry, in 'mousedown' 
[23:59:42] 	 so, on the group, you can say group.aggregate( { 'click': 'itemWasClicked' } ) and then when the items emit 'click' the group emits 'itemWasClicked' with the item as the first argument and the original event arguments after that