[00:00:06] so, here's my problem ... I might be missing something, though -- I have seen it in "mousedown" but my event is "dragstart" and "dragend". [00:00:07] oooh [00:00:10] oooooooo. [00:01:13] * mooeypoo tries [00:04:26] \o/ [00:04:37] * mooeypoo does the "IT WORKS" dance [00:04:39] TrevorParscal, thanks! [00:04:48] ha ha [00:04:53] glad it worked [00:12:04] So I was looking at the bug dealing with updating the "This page was last modified on 27 October 2014, at 22:45." line at the bottom of each article [00:14:11] but users can have a bunch of different date formats and everything :/ [00:16:23] guess I'll just have to stick that stuff in the api response [00:17:34] Users could also have their clocks be off [00:17:48] so you'd want to use the server clock [00:18:12] yeah [00:18:16] And you really do not want to deal with reimplementing timezone conversion either (because there is a user preference for what timezone to display timestamps in) [00:29:26] (03PS1) 10Alex Monk: Update "page was last modified on date, at time" footer line when saving [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170264 (https://bugzilla.wikimedia.org/52403) [00:35:18] (03CR) 10Catrope: [C: 04-1] Update "page was last modified on date, at time" footer line when saving (033 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170264 (https://bugzilla.wikimedia.org/52403) (owner: 10Alex Monk) [00:38:55] RoanKattouw, well obviously API modules are context sources, but ContextSource provides getOutput which returns an OutputPage object [00:39:21] Yeah that's what I figured. But why would we ever use an OutputPage object in an API module? [00:39:42] Also how is the OutputPage's value even up-to-date? Is there some magical thing that puts the new timestamp there [00:39:44] ? [00:42:19] I wonder if we get it in $saveresult.... [00:58:22] RoanKattouw, looks like that had been returning null, which made userDate/userTime give us valid-looking results [00:58:29] ha [00:59:28] but technically not the exact revision time, I guess [05:28:14] 3VisualEditor / 3Editing Tools: VisualEditor: Clicking on the link added inside the content cell of a table scrolls the page to the down and shows the context menu for link inspector at the bottom left corner of CE - 10https://bugzilla.wikimedia.org/72802 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:... [05:29:41] 3VisualEditor / 3Editing Tools: VisualEditor: Clicking on the link added inside the content cell of a table scrolls the page to the down and shows the context menu for link inspector at the bottom left corner of CE - 10https://bugzilla.wikimedia.org/72802#c1 (10Rummana Yasmeen) In fact, after that point on,... [05:39:58] 3VisualEditor / 3Editing Tools: VisualEditor: When the cursor is active inside a content cell , cannot insert any additional row or column to the table (or should we disable the row/column operator while user is inside a content cell?) - 10https://bugzilla.wikimedia.org/72803 (10Rummana Yasmeen) 3NEW p:3U... [05:46:14] 3VisualEditor / 3Editing Tools: VisualEditor:After adding a focusable node inside a content cell , placing cursor at the end of the table scrolls the page down - 10https://bugzilla.wikimedia.org/72804 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce: 1.Insert a table 2.Add any... [09:23:40] fyi won't make it to KIT today due to trick or treating [11:14:38] (03PS2) 10Esanders: Add support for non-table nodes in tables (e.g. aliens) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170245 (https://bugzilla.wikimedia.org/72717) [11:15:21] (03CR) 10Esanders: "The handles all the cases in EvilTable reasonably well, ready for review." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170245 (https://bugzilla.wikimedia.org/72717) (owner: 10Esanders) [11:24:15] (03PS3) 10Esanders: Add support for non-table nodes in tables (e.g. aliens) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170245 (https://bugzilla.wikimedia.org/72717) [15:29:42] 3VisualEditor / 3MediaWiki integration: VisualEditor: Invocation of "lastmodifiedat" message is not updated when page is saved - 10https://bugzilla.wikimedia.org/52403 (10Alex Monk) 5PATC>3RESO/FIX [15:30:10] mvolz: Enjoy! [15:42:52] (03CR) 10Jforrester: [C: 04-1] "Suggested tweak to the copy." (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169976 (https://bugzilla.wikimedia.org/52073) (owner: 10Alex Monk) [15:55:23] (03PS1) 10Esanders: Disable cell editing when a context is opened [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170339 (https://bugzilla.wikimedia.org/72803) [16:06:14] 3VisualEditor / 3ContentEditable: VisualEditor: Tables - adding formatted headings to displays Uncaught TypeError - 10https://bugzilla.wikimedia.org/72816 (10etonkovidova) 3NEW p:3Unprio s:3normal a:3None 1. In VE highlight any portion of an inserted table and add (03PS1) 10Bartosz Dziewoński: OOUI PHP: Support RTL text direction [oojs/ui] - 10https://gerrit.wikimedia.org/r/170341 (https://bugzilla.wikimedia.org/72584) [16:30:28] Corruption alert: visualeditor-needcheck on cswiki: https://cs.wikipedia.org/?diff=11968285 [16:30:28] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=108694114 [16:30:28] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=108694339 [16:30:28] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=108695220 [16:30:28] Corruption alert: visualeditor-needcheck on viwiki: https://vi.wikipedia.org/?diff=19934621 [16:30:29] Corruption alert: visualeditor-needcheck on itwiki: https://it.wikipedia.org/?diff=68920785 [16:30:29] Corruption alert: visualeditor-needcheck on itwiki: https://it.wikipedia.org/?diff=68922039 [16:31:51] (03PS1) 10Jforrester: AUTHORS.txt: Re-update for late 2014 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170345 [16:32:48] (03PS1) 10Esanders: Prevent clicks on focusable nodes in tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170346 [16:36:19] (03PS1) 10Bartosz Dziewoński: FieldLayout: Add 'help' config option support to PHP [oojs/ui] - 10https://gerrit.wikimedia.org/r/170347 (https://bugzilla.wikimedia.org/72583) [16:36:44] (03PS1) 10Jforrester: AUTHORS.txt: Re-update for late 2014 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170348 [16:45:12] 3VisualEditor / 3Editing Tools: VisualEditor: No indication in the toolbar what text styles are active because they're in a menu - 10https://bugzilla.wikimedia.org/72772#c1 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Low s:5normal>3minor The button also appears pressed in VisualEditor, it's just th... [16:46:14] 3VisualEditor / 3Mobile: VisualEditor: editing tables in Mobile - Edit mode displays broken tables - 10https://bugzilla.wikimedia.org/72819 (10etonkovidova) 3NEW p:3Unprio s:3normal a:3None Created attachment 16973 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16973&action=edit Mobile edit m... [16:46:59] 3VisualEditor / 3Mobile: VisualEditor: editing tables in Mobile - Edit mode displays broken tables - 10https://bugzilla.wikimedia.org/72819#c1 (10etonkovidova) Created attachment 16974 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16974&action=edit Mobile view tables - correct [16:47:20] anyone know where Timo is? jenkins needs him. [16:49:32] cscott: Busy IRL with housing stuff. [16:49:53] ok, godog is helping me figure it out on #ops. [16:50:00] i wonder who that is IRL ;) [16:50:37] (03PS1) 10Bartosz Dziewoński: ButtonElement: Add 'font-family: inherit;' to support ButtonInputWidgets [oojs/ui] - 10https://gerrit.wikimedia.org/r/170352 [16:50:39] (03PS1) 10Bartosz Dziewoński: More documentation tweaks [oojs/ui] - 10https://gerrit.wikimedia.org/r/170353 [16:52:25] (03PS2) 10Bartosz Dziewoński: More documentation tweaks [oojs/ui] - 10https://gerrit.wikimedia.org/r/170353 [17:18:18] (03CR) 10Cscott: [C: 031] "Woot! I'm famous!" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170345 (owner: 10Jforrester) [17:20:29] (03CR) 10jenkins-bot: [V: 04-1] FieldLayout: Add 'help' config option support to PHP [oojs/ui] - 10https://gerrit.wikimedia.org/r/170347 (https://bugzilla.wikimedia.org/72583) (owner: 10Bartosz Dziewoński) [17:22:05] (03CR) 10jenkins-bot: [V: 04-1] OOUI PHP: Support RTL text direction [oojs/ui] - 10https://gerrit.wikimedia.org/r/170341 (https://bugzilla.wikimedia.org/72584) (owner: 10Bartosz Dziewoński) [17:22:49] (03PS2) 10Bartosz Dziewoński: FieldLayout: Add 'help' config option support to PHP [oojs/ui] - 10https://gerrit.wikimedia.org/r/170347 (https://bugzilla.wikimedia.org/72583) [17:22:54] (03CR) 10He7d3r: AUTHORS.txt: Re-update for late 2014 (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170348 (owner: 10Jforrester) [17:26:37] (03PS2) 10Bartosz Dziewoński: OOUI PHP: Support RTL text direction [oojs/ui] - 10https://gerrit.wikimedia.org/r/170341 (https://bugzilla.wikimedia.org/72584) [17:30:36] (03PS2) 10Jforrester: AUTHORS.txt: Re-update for late 2014 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170348 [17:31:15] (03CR) 10Jforrester: AUTHORS.txt: Re-update for late 2014 (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170348 (owner: 10Jforrester) [17:31:34] http://www.bbc.co.uk/news/uk-29851285 [17:32:02] (translation: 74F instead of 50) [17:33:16] (03CR) 10Krinkle: [C: 031] AUTHORS.txt: Re-update for late 2014 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170345 (owner: 10Jforrester) [17:35:49] (03CR) 10Esanders: [C: 032] [BREAKING CHANGE] Unisolate dialogs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/169286 (owner: 10Catrope) [17:36:03] (03CR) 10Oliverb: [C: 031] "Fine." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170345 (owner: 10Jforrester) [17:36:38] Krenair: howdy [17:36:43] so, about that warning thing [17:36:44] hey [17:36:59] (context: https://gerrit.wikimedia.org/r/#/c/169976/1/modules/ve-mw/i18n/en.json ) [17:37:47] OO.ui.Error provides no way to do this (we'd have to reach into the save dialog and set a new retryButton label, and then put it back afterwards) [17:37:49] (03Merged) 10jenkins-bot: [BREAKING CHANGE] Unisolate dialogs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/169286 (owner: 10Catrope) [17:38:00] So, we could add a warning: true/false flag to the config of OO.ui.Error's constructor, and an isWarning method [17:38:02] if it did, I'm not sure how that would work when ProcessDialog wants to show multiple errors [17:38:22] then in the dialog, we could check if it's a warning or not (just as we already check if it's recoverable or not) [17:38:25] what ... the hell. I added a comment to MatmaRex's code but it didn't go through... :\ [17:38:33] and show continue instead of retry [17:38:42] :o [17:38:43] mooeypoo, did you review the change? [17:38:49] yeah [17:38:52] or just leave a comment in draft? [17:39:03] mooeypoo: https://gerrit.wikimedia.org/r/#/q/has:draft,n,z [17:39:11] no no I had it in draft and then went to "review" [17:39:12] weird [17:39:42] (03CR) 10Mooeypoo: OOUI PHP: Support RTL text direction (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/170341 (https://bugzilla.wikimedia.org/72584) (owner: 10Bartosz Dziewoński) [17:39:45] There it is [17:39:48] Krenair: my question is: the code path that was taken which caused the warning - would taking that code path again ignore the warning or do we need a different path? [17:40:56] why wouldn't it be the same as the error retry? [17:41:06] MatmaRex, are we limiting the same in js too? We are, aren't we? We might want to think about that in general. Hm. [17:41:21] well, retry just executes the action again, as if you clicked the original button again [17:41:26] mooeypoo: hmm. all i want there is to match how JS-side works [17:41:39] i believe we do only support ltr and rtl, not auto [17:41:41] so, clicking save producing an error, clicking retry just does the same thing as clicking save again [17:41:43] Yeah I just thought about the fact that this is probably how we do it in JS [17:42:06] in JS we depend on the 'direction' CSS property, and it can be only ltr or rtl [17:42:11] no [17:42:17] css prperty is translated [17:42:29] so עברית [17:42:35] ^^ that css direction=rtl [17:42:38] but the dir is auto [17:42:43] Krenair: my point is, if the error thrown in JS because we need to alert the user to a condition, then the retry probably needs to pass an argument of some sort to indicate that we want to ignore warnings [17:42:59] if you switch the same span to english, css direction will be ltr [17:43:00] yes, that's what i meant, sorry [17:43:15] MatmaRex, oh, yes, right, indeed. The issues are when you go into the property itself. [17:43:24] we use $(stuff).css('direction'), and AFAIK that's guaranteed to return 'ltr' ot 'rtl' [17:43:25] TrevorParscal, any warnings? I'm not sure... [17:43:30] MatmaRex, indeed [17:43:34] and promises don't give us warnings, they either resolve or fail, so we are abusing the error system to introduce a warning concept [17:43:39] but in the php you control the output of the [17:43:44] hmm [17:43:45] no [17:43:52] that's not output anywhere [17:44:00] well [17:44:02] not directly [17:44:08] well, it can't be dynamic, is what I'm saying [17:44:21] currently it's only used in GridLayout, where it switches us between using 'left:' and 'right:' in CSS [17:44:26] (inline CSS) [17:44:35] so in JS since we read the css direction, then we could have dir=auto in the html and the css direction will always match whatever is inside the span/div/whatever [17:44:58] oh. eek [17:45:07] but in the php it's more complicated, we seem to expect the user to decide in advance ltr/rtl for the entire element [17:45:10] no auto option [17:45:28] mooeypoo: entire document, even. and i agree that's poopy [17:45:34] * mooeypoo nods [17:45:47] we should, ideally, give the user the option to have an auto direction at least inline [17:45:48] i contemplated making getDir() a non-static method, in PHP and JS alike [17:45:58] (03CR) 10Catrope: [C: 031] "Code looks fine, needs product review from James" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169936 (https://bugzilla.wikimedia.org/53613) (owner: 10Alex Monk) [17:46:00] And we should also give the user an option to set one widget LTR and another RTL [17:46:05] but then we'd limit it to working on OOUI Elements, and right now it's used on all kinds of random stuff [17:46:09] Krenair: so, any ideas on how to resubmit without warnings? how are you doing it now? [17:46:13] that's actually pretty major. [17:46:18] (getDir() and setDir()) [17:46:21] yeah [17:46:35] well, in VE those are in the surfaces and iframes [17:46:43] and then you have annotatoins for inline [17:46:53] (and at some point directionality for blocks in the text) [17:47:01] okay, so the question is, can we assume that all things inside a OOUI Element will have the same direcitonality, unless they are other Elements? [17:47:32] TrevorParscal, I'm not just suppressing all warnings [17:47:33] we don't really have any existing use cases of switching dir within a widget [17:47:36] that sounds like a bad idea [17:47:39] if yes, then we could probably make getDir() and setDir() regular non-static methods in both PHP and JS, and special-case the iframes maybe [17:47:47] I think so? I'm trying to come up with edge cases where that's not true, but they will really be edge cases [17:47:47] Krenair: how did the warning occur? [17:47:52] I set a couple of variables internally so the warning doesn't reoccur [17:48:03] MatmaRex, most likely we can assume each widget/element will have a set direction [17:48:13] What I'm a little concerned with is the ability to have dynamic direction [17:48:13] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf7] The group names inside "Use this group" field are appearing in a short form like "g..." for both "References list" and "Basic Reference" dialog when you open these dialogs first time in a session - 10https://bugzilla.wikimedia.org/72783#c1 (1... [17:48:13] mooeypoo: yeah, in the worst case you can just wrap whatever content in an Element [17:48:22] * mooeypoo nods [17:48:22] Krenair: ok, that seems evil too [17:48:42] you do that anywasy with inline because of isolation (another problem but not ooui for now at least) [17:48:48] see https://gerrit.wikimedia.org/r/#/c/169976/1/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js [17:48:53] the JS behavior wouldn't be changed and it would permit dynamic (auto) direction, as it does now [17:49:04] MW uses a wpRecreate field to achieve this, I just set that [17:49:04] the PHP behavior right now hardcodes LTR, so anything is an improvement [17:49:06] JS allows for auto [17:49:10] * mooeypoo nods [17:49:30] (03CR) 10Bartosz Dziewoński: [C: 04-1] OOUI PHP: Support RTL text direction [oojs/ui] - 10https://gerrit.wikimedia.org/r/170341 (https://bugzilla.wikimedia.org/72584) (owner: 10Bartosz Dziewoński) [17:49:33] JS allows for auto mainly because we read the direction through the css [17:49:40] PHP will be a bit more complicated [17:50:14] I'm not entirely sure we *can* do this in PHP now that I think of it. It really depends on the dynamic direction, and you can get that in JS, not so sure you can in php [17:50:17] i think we can figure that out later on as-needed basis [17:50:54] it's a hard problem indeed, but if it was necessary for us, then we could probably analyze the contents of eveyrthing PHP-side and figure out what alphabet they use, and such [17:50:58] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf7] The group names inside "Use this group" field are appearing in a short form like "g..." for both "References list" and "Basic Reference" dialog when you open these dialogs first time in a session - 10https://bugzilla.wikimedia.org/72783#c2 (1... [17:51:07]

this will resolve to css direction=ltr

and

עברית

<-- that will resolve to css direction=rtl [17:51:24] Yeah, good point [17:51:37] and yeah, it sounds like it's going to be a lot more complicated than "just" allowing for another option [17:51:39] but for now, requiring the user to know whether their widgets should be formatted as RTL or LTR sounds okay to me [17:51:46] becaus eyou do need to know in the *calculations* whether it's ltr or rtl [17:51:51] yeah [17:52:02] MatmaRex, we're allowing the user to set this direction per widget? [17:52:05] or for the whole document? [17:52:15] per element [17:52:56] Looks like that from the code, but just verifying. [17:52:57] mooeypoo: right now, PHP hardcodes ltr for everything, JS just reads CSS direction, so you can set directionality per-Element [17:53:23] PHP hardcodes ltr now but it's possible to change that through setDir() no? [17:53:36] yeah [17:53:36] wait [17:53:37] from the code [17:53:49] before that change: PHP hardcodes ltr, JS is per-Element [17:53:58] after that change: PHP is per-document, JS is per-Element [17:53:58] so I can setDir() for individual ooui Elements [17:54:04] which is broken [17:54:07] i didn't realize before [17:54:21] wait, I'm confused. We're looking at the OoUiElement code [17:54:24] this definitely needs some rewriting [17:54:34] mooeypoo: yes, but it's a static method and static property [17:54:40] oh, static, i didn't notice [17:54:49] * mooeypoo nods [17:55:24] the ideal would be to let the elements inherit some global direction of the document, but be able to override it [17:56:07] yeah. in JS we can figure out the global direction, but in PHP we can't, so we need to ask the user for it [17:56:11] i think that makes sense [17:56:14] * mooeypoo nods [17:56:34] so i say, in PHP we'd have per-element getDir()/setDir(), and static setDefaultDir()? [17:56:45] In js we can also figure out the inline direction, actually. It's a lot simpler like that, but yes. The php version will be a tad more complicated to plan, I think. [17:57:35] and in JS we'd just have getDir(), with setDir(dir) being a wrapper for .css('direction', dir) for consistency? [17:57:44] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf7] The group names inside "Use this group" field are appearing in a short form like "g..." for both "References list" and "Basic Reference" dialog when you open these dialogs first time in a session - 10https://bugzilla.wikimedia.org/72783#c3 (1... [17:57:58] We don't have setDir in js [17:58:09] yeah, but we could [17:58:18] I don't think we need to, though. We could, but no need. [17:58:39] In JS, you can wrap some element in

[17:58:43] inside a ltr document [17:58:53] this really is the question of, do we want to support per-element directionality in OOUI, or only per-document [17:58:57] and then the internal ooui element automatically gets the rtl direction [17:59:08] right now per-element works in JS, but only by chance as i understand it, it wasn't really intended [17:59:19] There's also the oo-ui-ltr and oo-ui-rtl classes that have CSS like .oo-ui-rtl { direction: rtl; } [17:59:35] Yeah [17:59:49] Hm. [18:00:16] RoanKattouw, but it doesn't automatically applies to all elements in ooui [18:00:31] (03PS15) 10Divec: Make setSelection emit activeAnnotationChange if continuation unicorns may be needed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168327 (https://bugzilla.wikimedia.org/72108) [18:00:31] True, it's only windows I think [18:00:37] so I could have some html document with

[18:00:38] (03CR) 10jenkins-bot: [V: 04-1] Make setSelection emit activeAnnotationChange if continuation unicorns may be needed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168327 (https://bugzilla.wikimedia.org/72108) (owner: 10Divec) [18:00:45] and then have 1 and 2 be buttons [18:00:54] ooui button widgets [18:01:03] in JS they'll automatically inherit the direction [18:01:07] I don't need to say "setDir" [18:01:19] In PHP they won't. That's the issue [18:01:59] …do we want to implement inheriting direction in PHP? that's starting to sound hairy [18:02:12] No no [18:02:32] But since php doesn't have that inheritance, it would be nice to have some sort of 'setDir' ability [18:02:54] So the question is do we add "setDir" to php because otherwise we lose the feature, but we don't touch the JS because there's no real need that I can tell to have a forced "setDir" (*except* for windows which do get the explicit oo-ui-ltr/rtl, maybe?) [18:03:16] there's no real need *right now* in JS, so I am weary of touching it atm. But in PHP it jumped at me that this might be a problem [18:03:40] but I am not sure if we're not getting into shaky territory, too. Maybe we should figure out a more strategic way of handling direcitonality and inline/block UI direction in general? [18:03:56] okay, either way, one thing that is clear is that we need *at least* per-document direction in PHP [18:04:05] Yes. Indeed. [18:04:17] so let's do that now and not break anything else [18:04:22] * mooeypoo nods [18:04:45] i'll try to make it easy to extend to support per-element in PHP later [18:04:52] thanks, this was helpful :D [18:05:07] Just take this issue into account. We might want to make it some tech debt or you may get a sudden creative idea on how to fix it up. Or we may decide we don't want to let users have separate directionalities, that might be a solution too. [18:05:09] no problemos [18:05:21] or in rtlism - אין בעיה [18:05:23] ;) [18:06:45] (03CR) 10Bartosz Dziewoński: OOUI PHP: Support RTL text direction (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/170341 (https://bugzilla.wikimedia.org/72584) (owner: 10Bartosz Dziewoński) [18:06:56] 3OOjs UI: OOUI PHP: Be able to set widgets' direction to RTL/LTR - 10https://bugzilla.wikimedia.org/72584 (10Bartosz Dziewoński) [18:11:18] (03PS1) 10Catrope: Preserve original data inside parameter objects too [extensions/VisualEditor] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/170364 [18:11:29] (03PS1) 10Catrope: Preserve original data inside parameter objects too [extensions/VisualEditor] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/170365 [18:12:11] 3OOjs UI: OOUI PHP: Be able to set widgets' direction to RTL/LTR - 10https://bugzilla.wikimedia.org/72584#c3 (10Bartosz Dziewoński) There's also the bigger question of whether we want to support per-document or per-element directionality. Currently JS sorta-kinda supports per-element directionality, but it's... [18:12:29] mooeypoo: i summarized ^ [18:17:36] (03PS1) 10Esanders: Rename focusedNode to relocatingNode in drop [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170366 [18:17:41] MatmaRex, awesomesauce [18:19:01] I actually did try this in JS a while back, but you're right that it was mostly an unintended consequence. I can create a test page if you want, for the javascript part, but we can just keep this under wraps until the need comes up [18:19:46] (03PS3) 10Bartosz Dziewoński: OOUI PHP: Support RTL text direction [oojs/ui] - 10https://gerrit.wikimedia.org/r/170341 (https://bugzilla.wikimedia.org/72584) [18:20:15] mooeypoo: that'd probably be interesting [18:20:19] updated the patch ^ [18:22:58] (03PS1) 10Jforrester: Update VE core submodule to master (b7b56dd) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170367 [18:26:27] (03PS1) 10Catrope: Fix selection transitions between FocusableNodes and non-linear selections [VisualEditor/VisualEditor] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/170370 (https://bugzilla.wikimedia.org/72721) [18:26:47] (03PS1) 10Catrope: Fix selection transitions between FocusableNodes and non-linear selections [VisualEditor/VisualEditor] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/170371 (https://bugzilla.wikimedia.org/72721) [18:27:27] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (b7b56dd) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170367 (owner: 10Jforrester) [18:28:49] (03Merged) 10jenkins-bot: Update VE core submodule to master (b7b56dd) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170367 (owner: 10Jforrester) [18:32:20] MatmaRex, meh, I can't manage to load the demos locally [18:32:29] the code looks good, I wanted to test [18:32:57] 3VisualEditor / 3ContentEditable: VisualEditor: [Regression wmf5] FocusableNodes not selectable when surface is blurred - 10https://bugzilla.wikimedia.org/72721 (10James Forrester) 5PATC>3RESO/FIX [18:33:59] (03CR) 10Esanders: [C: 031] "on behalf of Thal" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170345 (owner: 10Jforrester) [18:34:05] edsanders: :-) [18:34:54] (03PS16) 10Divec: Make setSelection emit activeAnnotationChange if continuation unicorns may be needed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168327 (https://bugzilla.wikimedia.org/72108) [18:34:57] (03CR) 10jenkins-bot: [V: 04-1] Make setSelection emit activeAnnotationChange if continuation unicorns may be needed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168327 (https://bugzilla.wikimedia.org/72108) (owner: 10Divec) [18:43:43] 3VisualEditor / 3Technical Debt: VisualEditor: Remove ve.bind() - 10https://bugzilla.wikimedia.org/72156 (10James Forrester) 5PATC>3ASSI [18:44:22] mooeypoo: run `composer install` first [18:44:27] oh [18:44:29] 3VisualEditor / 3Editing Tools: VisualEditor: Pressing tab inside a cell when the cursor is active , takes the cursor to beginning of the document instead of taking it to the next cell - 10https://bugzilla.wikimedia.org/72823 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce: 1... [18:44:30] that's what I was missing [18:50:09] MatmaRex, ok, now the page loads but it looks bad. I am sure I'm missing somtehing :\ [18:50:35] how bad? screenshot? [18:50:53] hm looks like the css files aren't read. Just demo.css [18:51:10] have you ran `grunt build` too? [18:51:27] oh hmm, or maybe i broke something [18:52:05] http://s867.photobucket.com/user/mooeypoo/media/ooui-php-screenshot.png.html [18:53:13] i dunno, it works for me :/ [18:53:17] ahh I didn't do grunt build [18:53:44] now it works! [18:54:16] hm [18:54:18] yay [18:54:24] widgets.php?dir=rtl <-- no change [18:55:12] D: [18:55:17] You should also flip the body direction in th widgets.php page, if we're already allowing for rtl demo [18:55:35] either or tag. I think body is better [18:55:45] http://i.imgur.com/zlWpBmt.png [18:55:59] i do , i followed the JS demo [18:56:04] hm [18:56:07] yep [18:56:09] but I don't see that [18:56:18] ... oh my god. Ignore everything I said [18:56:24] * mooeypoo forgot to pull the patch [18:56:49] mooeypoo: :-D [18:56:57] Minor... minor detail. [18:56:59] 3VisualEditor / 3Editing Tools: VisualEditor: IME selector shows up at the bottom-right corner of the table while selecting a cell on a table or placing a cursor into it - 10https://bugzilla.wikimedia.org/72824 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 16980 --> https:... [18:57:20] mooeypoo: Indeed! [18:58:17] \o/ MatmaRex that looks good [18:58:29] :D [18:58:36] Do we use messages for the demo? I can quickly translate or something [18:58:40] oh.. no it's static. Forget it. [19:00:53] WOW that's idiotic, chrome [19:01:22] So... chrome auto-filled the inputs in the user/pass fields thinking it's my wiki (both on localhost) [19:01:37] and then I play around, clicking "submit" and here is my password, in plaintext, in the GET vars [19:02:21] James_F: #72599 - it seems that we do not allow anymore to copy/paste tables in Edit? true? [19:02:35] I thought Chrome security features said it sholdn't autofill if the form has method="GET" [19:02:44] mooeypoo: Some web sites use for your CVC code, so then Chrome goes "would you like Chrome to remember the password for 4388NNNNNNNNNNNN" [19:03:00] ha [19:03:08] oi [19:03:12] etonkovidova: You can paste whole tables, single cells, and the contents of a cell, but not multiple cells. [19:03:13] To which the response is OH HELL NO [19:03:15] etonkovidova: I think. [19:03:26] mooeypoo: heh [19:04:01] mooeypoo: does chrome not remember the 'name' attributes of inputs it remembers the password for? [19:04:29] (03PS1) 10Catrope: Clean up horrible things in LookupInputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/170376 [19:04:30] It's looking for username and pass [19:04:37] or user/pass or username/password [19:04:47] mediawiki uses wpName and wpPassword for its login form [19:04:58] well, that's stupid then. *my* browser is smarter. :) [19:05:01] James_F: then #72599 should be closed - not relevant anymore [19:05:07] hm so maybe it's not the login for the wiki [19:05:11] I have a couple of sites on local host [19:05:21] it's my throwaway local password, really, but still [19:05:34] etonkovidova: No no, I think that's now fixed? [19:06:22] James_F: hmm... I cannot copy/paste tables at all [19:06:31] only in Edit source [19:06:34] etonkovidova: You need to select either side of them. [19:07:20] (03PS5) 10Divec: WIP: Refactor SurfaceObserver pollOnceInternal [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166188 [19:07:23] (03CR) 10jenkins-bot: [V: 04-1] WIP: Refactor SurfaceObserver pollOnceInternal [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166188 (owner: 10Divec) [19:07:59] James_F: does not work for me hmm... [19:10:23] MatmaRex, I even changed one of the button titles to hebrew with ! at the end to verify everything is RTL. [19:14:45] James_F: tables cut/paste works in test2 not in betalabs [19:15:20] etonkovidova: Yes, as I said the new code works differently. [19:16:27] etonkovidova: But you can cut an entire table, as long as you select either side of it. [19:16:32] (03PS1) 10Catrope: Clean up LookupInputWidget subclasses and use new functionality [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170379 [19:17:14] James_F: ok [19:17:29] etonkovidova: But it is a mess. [19:18:18] James_F: at least it's not my hallucinations - sigh [19:18:28] (03CR) 10Catrope: [C: 032] AUTHORS.txt: Re-update for late 2014 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170345 (owner: 10Jforrester) [19:20:11] (03Merged) 10jenkins-bot: AUTHORS.txt: Re-update for late 2014 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170345 (owner: 10Jforrester) [19:20:23] (03CR) 10Catrope: [C: 032] AUTHORS.txt: Re-update for late 2014 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170348 (owner: 10Jforrester) [19:20:36] James_F, I think the reason I wasn't in the VE core authors.txt is because I basically only touch ve-mw [19:21:00] Krenair: You appeared often enough in git shortlog to gain a place. :-) [19:21:46] (03Merged) 10jenkins-bot: AUTHORS.txt: Re-update for late 2014 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170348 (owner: 10Jforrester) [19:21:54] I have 5 commits to VE core - one of which is bind changes, another is updating OOjs UI [19:22:53] Krenair: We can find you more things to do in VE core, I suppose. [19:23:30] Compared to around 150 commits to VE-MW.... [19:23:45] Yeah. [19:24:45] and around 25 to OOjs UI [19:26:03] MatmaRex, nice going on the LRM character, it actually baffled me then for a second why the button titles didn't get screwed up when you switch to rtl, then I looked at the patchset again [19:28:44] 3VisualEditor / 3Editing Tools: VisualEditor: Applying text formatting to empty cell does not format the text entered afterwards - 10https://bugzilla.wikimedia.org/72825 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce: 1.Insert a table 2.Select an empty cell 3.Observe the tex... [19:29:14] Hmm. Can I grab a quick +2 on https://gerrit.wikimedia.org/r/#/c/169555/ ? [19:34:05] (03PS5) 10Catrope: Use MWTitleInputWidget for wiki-page-name parameters, add MWUserInputWidget for wiki-user-name [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169936 (https://bugzilla.wikimedia.org/53613) (owner: 10Alex Monk) [19:34:23] (03CR) 10Catrope: [C: 032] Add Special:CiteThisPage to the 'pagetools' group of Special:SpecialPages [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/169555 (owner: 10Jforrester) [19:38:07] (03CR) 10Mooeypoo: [C: 032] "Works and looks great." [oojs/ui] - 10https://gerrit.wikimedia.org/r/170341 (https://bugzilla.wikimedia.org/72584) (owner: 10Bartosz Dziewoński) [19:38:31] Bonus points for LRM character. C-C-C-COMBO. [19:39:01] (03Merged) 10jenkins-bot: Add Special:CiteThisPage to the 'pagetools' group of Special:SpecialPages [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/169555 (owner: 10Jforrester) [19:39:53] (03Merged) 10jenkins-bot: OOUI PHP: Support RTL text direction [oojs/ui] - 10https://gerrit.wikimedia.org/r/170341 (https://bugzilla.wikimedia.org/72584) (owner: 10Bartosz Dziewoński) [19:47:59] 3VisualEditor / 3Editing Tools: VisualEditor: Allowing creation of empty caption moves the column editing icon at the top of the empty space which looks odd - 10https://bugzilla.wikimedia.org/72829 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 16982 --> https://bugzilla.wi... [19:49:27] 3MediaWiki extensions / 3WikiEditor: Media selector doesn't find local media in private wiki - 10https://bugzilla.wikimedia.org/63282#c5 (10Gabriel Stelmach) Hello there, I just face this issue in my installation. There are any news about solution for this? In time. Thank you Stephan for the workaround. []s [19:52:14] 3VisualEditor / 3Editing Tools: VisualEditor: Overwriting the text inside a cell does not retain the text format applied to that cell previously - 10https://bugzilla.wikimedia.org/72831 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce: 1.Insert a table 2.Insert some text insid... [20:02:58] 3OOjs UI: OOUI PHP: Be able to set widgets' direction to RTL/LTR - 10https://bugzilla.wikimedia.org/72584 (10James Forrester) 5PATC>3RESO/FIX [20:03:13] 3OOjs UI: OOjs UI: PHP docs should be auto-generated - 10https://bugzilla.wikimedia.org/72454 (10James Forrester) 5PATC>3ASSI [20:03:42] Krinkle: hey man [20:03:48] there y'are [20:09:29] 3VisualEditor / 3Editing Tools: VisualEditor: After saving, the order of the texts gets reversed while adding some content in a slug created inside the caption field - 10https://bugzilla.wikimedia.org/72833 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 16983 --> https://bu... [20:11:41] 3VisualEditor / 3Editing Tools: VisualEditor: After saving, the order of the texts gets reversed while adding some content in a slug created inside the caption field of a table - 10https://bugzilla.wikimedia.org/72833 (10Rummana Yasmeen) [20:16:20] hm James_F MatmaRex not sure if this should be marked fixed or if we should add a tech debt bug? https://bugzilla.wikimedia.org/show_bug.cgi?id=72584 [20:16:40] * James_F is happy to go either way. [20:17:32] mooeypoo: i'd keep it as FIXED, i think we probably will not need/want per-element directionality [20:17:57] i can't think of a reason to have different directionalities of UI elements [20:21:52] * James_F neither. [20:23:42] I can, but it's not *widely* used. [20:24:02] There are quite a number of Hebrew pages with mixed elements [20:24:37] But usually those are visible content elements, not necessarily buttons and menus. [20:24:45] We can leave it as-is and see if the need arises. [20:30:44] 3VisualEditor: VisualEditor: I can't select multiple refs in Firefox from the keyboard, going backwards - 10https://bugzilla.wikimedia.org/72835 (10WhatamIdoing) 3NEW p:3Unprio s:3minor a:3None Steps to reproduce: 1. Open a page in Firefox (v. 32.0.3 on Mac 10.8.5) that contains several refs in a ro... [20:36:22] (03PS6) 10Divec: Refactor SurfaceObserver pollOnceInternal [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166188 [20:36:26] (03CR) 10jenkins-bot: [V: 04-1] Refactor SurfaceObserver pollOnceInternal [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166188 (owner: 10Divec) [20:38:58] 3VisualEditor / 3ContentEditable: VisualEditor: Tables - when editing content cell a blue cell border does not expand - 10https://bugzilla.wikimedia.org/72836 (10etonkovidova) 3NEW p:3Unprio s:3normal a:3None Created attachment 16984 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16984&actio... [20:48:47] etonkovidova, ryasmeen: The dialogs-without-iframes change is in beta labs now, finally [20:52:15] ...as of 11:28am, it turns out [20:52:22] RoanKattouw: :-) [20:57:51] RoanKattouw: yay! checking it . [21:14:45] 3VisualEditor / 3ContentEditable: VisualEditor: Page Settings dialog box - an opacity issue - 10https://bugzilla.wikimedia.org/72838 (10etonkovidova) 3NEW p:3Unprio s:3normal a:3None Created attachment 16985 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16985&action=edit Page settings box op... [21:30:54] (03PS25) 10Divec: Use a single unicorn-like instead of in inline slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151046 (owner: 10Catrope) [21:36:04] (03PS7) 10Divec: Refactor SurfaceObserver pollOnceInternal [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166188 [21:54:58] (03CR) 10Catrope: [C: 032] Fix selection transitions between FocusableNodes and non-linear selections [VisualEditor/VisualEditor] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/170371 (https://bugzilla.wikimedia.org/72721) (owner: 10Catrope) [21:55:06] (03CR) 10Catrope: [C: 032] Fix selection transitions between FocusableNodes and non-linear selections [VisualEditor/VisualEditor] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/170370 (https://bugzilla.wikimedia.org/72721) (owner: 10Catrope) [21:57:17] (03Merged) 10jenkins-bot: Fix selection transitions between FocusableNodes and non-linear selections [VisualEditor/VisualEditor] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/170371 (https://bugzilla.wikimedia.org/72721) (owner: 10Catrope) [21:57:22] (03Merged) 10jenkins-bot: Fix selection transitions between FocusableNodes and non-linear selections [VisualEditor/VisualEditor] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/170370 (https://bugzilla.wikimedia.org/72721) (owner: 10Catrope) [21:58:41] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression wmf3] The fields inside Citations dialog are appearing at a fixed rather than whole-screen width in mobile VE - 10https://bugzilla.wikimedia.org/72112#c5 (10Rummana Yasmeen) Created attachment 16986 --> https://bugzilla.wikimedia.org/attachment.cgi?... [21:58:56] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression wmf3] The fields inside Citations dialog are appearing at a fixed rather than whole-screen width in mobile VE - 10https://bugzilla.wikimedia.org/72112 (10Rummana Yasmeen) 5RESO/FIX>3REOP [21:59:11] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression wmf3] The fields inside Citations dialog are appearing at a fixed rather than whole-screen width in mobile VE - 10https://bugzilla.wikimedia.org/72112 (10Rummana Yasmeen) 5REOP>3ASSI [22:05:56] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression wmf3] The fields inside Citations dialog are appearing at a fixed rather than whole-screen width in mobile VE - 10https://bugzilla.wikimedia.org/72112#c6 (10James Forrester) 5ASSI>3RESO/FIX It's not meant to. This is wide enough for tablets and ph... [22:10:27] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression wmf3] The fields inside Citations dialog are appearing at a fixed rather than whole-screen width in mobile VE - 10https://bugzilla.wikimedia.org/72112#c7 (10Rummana Yasmeen) Created attachment 16987 --> https://bugzilla.wikimedia.org/attachment.cgi?... [22:11:21] James_F: this is the right link for the TemplateData GUI thingy, right? https://en.wikipedia.org/wiki/Wikipedia:TemplateData [22:11:36] or is there a mw.org page? [22:12:55] greg-g: Well, there's https://www.mediawiki.org/wiki/Extension:TemplateData but there's nothing there about the GUI. [22:13:09] you're choice :) [22:13:12] gah [22:13:13] your [22:13:14] greg-g: https://www.mediawiki.org/wiki/Help:TemplateData is probably best. [22:13:16] * greg-g hangs head [22:13:21] greg-g: Also, I judge you. :-) [22:13:22] ty [22:13:27] :P [22:17:57] RoanKattouw: so i'm reviewing your lookupinput thingy, and i have a fundamental question [22:18:34] RoanKattouw: why does the constructor accept an `input` parameter if it is always identical to `this` in all usages i see, and if the code indeed assumes it to be? [22:18:44] I was wondering the same thing [22:18:51] I'll ask Trevor that once I'm done walking him through this thing [22:19:23]