[00:16:28] 3OOjs UI / 3Technical Debt: OOUI PHP: Switch to using traits when we drop support for PHP 5.3 - 10https://bugzilla.wikimedia.org/72892 (10Bartosz Dziewoński) 3NEW p:3Unprio s:3normal a:3None Let's switch to using traits instead of our custom mixin system when we drop support for PHP 5.3. I think ther... [00:17:57] 3OOjs UI / 3Technical Debt: OOUI PHP: Switch to using traits when we drop support for PHP 5.3 - 10https://bugzilla.wikimedia.org/72892 (10Bartosz Dziewoński) p:5Unprio>3Lowest s:5normal>3trivia [05:25:10] James_F|Away: http://www.adamhyde.net/building-book-production-platforms-p3/ [05:32:19] (03PS1) 10Mooeypoo: [wip] Adding paramOrder widget to TemplateData editor [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/170655 [05:32:55] (03CR) 10jenkins-bot: [V: 04-1] [wip] Adding paramOrder widget to TemplateData editor [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/170655 (owner: 10Mooeypoo) [06:20:27] (03PS1) 10Nemo bis: Revert translations by Paladox [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/170658 [06:43:41] 3MediaWiki extensions / 3Cite: Add back an error message for missing - 10https://bugzilla.wikimedia.org/72858 (10Andre Klapper) p:5Unprio>3Normal [08:15:11] 3VisualEditor / 3Editing Tools: VisualEditor: Tables - multiple colspan and rowspan are not displayed correctly - 10https://bugzilla.wikimedia.org/72790 (10Elitre) [08:18:26] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf7] The group names inside "Use this group" field are appearing in a short form like "g..." for both "References list" and "Basic Reference" dialog when you open these dialogs first time in a session - 10https://bugzilla.wikimedia.org/72783#c4 (1... [08:27:52] (03CR) 10Raimond Spekking: [C: 032] Revert translations by Paladox [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/170658 (owner: 10Nemo bis) [08:27:57] (03Merged) 10jenkins-bot: Revert translations by Paladox [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/170658 (owner: 10Nemo bis) [13:05:56] 3VisualEditor: Can't copy template or media with Safari - 10https://bugzilla.wikimedia.org/70143#c1 (10Elitre) 5UNCO>3NEW Confirming the issue in Safari. [13:08:31] (03PS8) 10Divec: Refactor SurfaceObserver pollOnceInternal [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166188 [13:14:12] 3VisualEditor / 3ContentEditable: VisualEditor: Can't copy/paste a reference or template unless you select text either side - 10https://bugzilla.wikimedia.org/49396#c12 (10Elitre) 5RESO/FIX>3REOP I think this is still occurring (https://it.wikipedia.org/w/index.php?title=Utente%3AElitre_%28WMF%29%2FSandb... [13:24:41] 3VisualEditor / 3ContentEditable: VisualEditor: Tables - when editing content cell a blue cell border does not expand - 10https://bugzilla.wikimedia.org/72836#c1 (10Ed Sanders) 5NEW>3RESO/WOR Works for me in Chrome & FF [13:28:43] (03PS1) 10Esanders: Add support for dropping text/html from external sources [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170690 [13:37:10] (03PS1) 10Esanders: Set insertion annotations when typing over cell contents [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170692 (https://bugzilla.wikimedia.org/72831) [13:48:19] (03PS1) 10Esanders: Fix width of demo page dropdown [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170696 [13:58:41] 3VisualEditor / 3ContentEditable: VisualEditor: Pasting annotated text causes space to be removed at annotation separators - 10https://bugzilla.wikimedia.org/71718 (10Elitre) [14:04:42] (03PS1) 10Esanders: Catch backwards selection error in Firefox [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170697 (https://bugzilla.wikimedia.org/72835) [14:23:40] 3VisualEditor / 3Editing Tools: VisualEditor: After saving, the order of the texts gets reversed while adding some content in a slug created inside the caption field of a table - 10https://bugzilla.wikimedia.org/72833#c1 (10Ed Sanders) Works for me in Chrome & FF. [14:24:13] 3VisualEditor: VisualEditor: unexpected results while copy/pasting reference contents - 10https://bugzilla.wikimedia.org/72901 (10Elitre) 3NEW p:3Unprio s:3normal a:3None See https://www.mediawiki.org/w/index.php?title=User:Elitre_(WMF)/sandbox&diff=prev&oldid=1249997 . References at the words "this"... [14:27:41] 3VisualEditor / 3Editing Tools: VisualEditor: Applying text formatting to empty cell does not format the text entered afterwards - 10https://bugzilla.wikimedia.org/72825#c1 (10Ed Sanders) We don't have the concept of insertion annotations at a cell level. Not sure we need to either. [14:29:40] 3VisualEditor / 3Editing Tools: VisualEditor: Pressing tab inside a cell when the cursor is active , takes the cursor to beginning of the document instead of taking it to the next cell - 10https://bugzilla.wikimedia.org/72823#c1 (10Ed Sanders) Tab is not used yet in VE anywhere, and we've haven't fully decid... [14:31:26] (03PS2) 10Mvolz: [WIP] Change everything [services/citoid] - 10https://gerrit.wikimedia.org/r/169690 [14:34:55] 3VisualEditor / 3Editing Tools: VisualEditor:After adding a focusable node inside a content cell , placing cursor at the end of the table scrolls the page down - 10https://bugzilla.wikimedia.org/72804#c1 (10Ed Sanders) 5NEW>3RESO/WOR Works for me in Chrome & FF [15:06:58] 3VisualEditor / 3Editing Tools: VisualEditor:[Regression wmf6]A Label appears momentarily, showing all "Use this Group" options, when Re-Using a Reference - 10https://bugzilla.wikimedia.org/72904 (10Ritu Swain) 3UNCO p:3Unprio s:3normal a:3None Environment- production, beta 1> Cite -> Basic. Type a... [15:09:56] 3VisualEditor / 3Editing Tools: VisualEditor:[Regression wmf6]A Label appears momentarily, showing all "Use this Group" options, when Re-Using a Reference - 10https://bugzilla.wikimedia.org/72904#c1 (10Ritu Swain) http://youtu.be/a8rgrcU7Bns [15:14:40] 3VisualEditor / 3Editing Tools: VisualEditor: Citations appear broken for a few moments, before getting inserted in a Basic Reference dialog . - 10https://bugzilla.wikimedia.org/70884#c1 (10Ritu Swain) Please close this issue, i cannot reproduce it anymore. [15:25:27] (03PS1) 10Esanders: Move selection restrictions from tools to commands [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170711 [15:25:29] (03PS1) 10Esanders: [BREAKING CHANGE] Move selection restrictions from tools to commands [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170712 [15:28:25] 3VisualEditor / 3Editing Tools: VisualEditor: Clicking on the link added inside the content cell of a table scrolls the page to the down and shows the context menu for link inspector at the bottom left corner of CE - 10https://bugzilla.wikimedia.org/72802#c2 (10Ed Sanders) I couldn't get any strange behaviou... [15:38:29] 3VisualEditor / 3Data Model: VisualEditor:[Regression]Multiple Categories with the same title can be created. - 10https://bugzilla.wikimedia.org/72906 (10Ritu Swain) 3UNCO p:3Unprio s:3normal a:3None Created attachment 17001 --> https://bugzilla.wikimedia.org/attachment.cgi?id=17001&action=edit scr... [15:38:40] 3VisualEditor / 3Data Model: VisualEditor:[Regression]Multiple Categories with the same title can be created. - 10https://bugzilla.wikimedia.org/72906 (10Ritu Swain) [15:38:51] (03PS1) 10Esanders: Further mute keyboard shortcuts when disabled [oojs/ui] - 10https://gerrit.wikimedia.org/r/170713 [15:40:12] 3VisualEditor: Cite URL when clicked should open in new page - 10https://bugzilla.wikimedia.org/72730#c2 (10Chris McMahon) Chris here. In Firefox and in Chromium. On the page at http://test2.wikipedia.org/wiki/0.7119148577383078 at the bottom of the page the link specified by "cnn" at the end of the stri... [15:44:56] 3VisualEditor: Cite URL when clicked should open in new page - 10https://bugzilla.wikimedia.org/72730#c3 (10Elitre) Isn't this a browser-related setting? [15:54:11] 3OOjs UI / 3Technical Debt: OOUI PHP: Switch to using traits when we drop support for PHP 5.3 - 10https://bugzilla.wikimedia.org/72892#c1 (10James Forrester) 5NEW>3ASSI s:5trivia>3enhanc All technical debt bugs are by definition enhancements. :-) [16:00:23] (03CR) 10Esanders: [C: 04-1] Refactor SurfaceObserver pollOnceInternal (033 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166188 (owner: 10Divec) [16:00:56] (03PS2) 10Esanders: More random documentation fixes [oojs/ui] - 10https://gerrit.wikimedia.org/r/170502 (owner: 10Bartosz Dziewoński) [16:01:03] (03CR) 10Esanders: [C: 032] More random documentation fixes [oojs/ui] - 10https://gerrit.wikimedia.org/r/170502 (owner: 10Bartosz Dziewoński) [16:03:26] 3VisualEditor / 3ContentEditable: VisualEditor: Pressing tab inside a cell when the cursor is active should taking it to the next cell, not to beginning of the document - 10https://bugzilla.wikimedia.org/72823#c2 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal s:5normal>3enhanc (In reply to Ed S... [16:04:14] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf7] The group names inside "Use this group" field are appearing in a short form like "g..." for both "References list" and "Basic Reference" dialog when you open these dialogs first time in a session - 10https://bugzilla.wikimedia.org/72783#c5 (1... [16:05:26] 3VisualEditor / 3MediaWiki integration: VisualEditor: Deal with Translate extension's save abort hooks - 10https://bugzilla.wikimedia.org/65653#c2 (10James Forrester) (In reply to Nemo from comment #1) > (In reply to James Forrester from comment #0) > > "Translation unit markers in unexpected position." can... [16:08:58] 3VisualEditor / 3ContentEditable: VisualEditor: Can't copy/paste a reference or template unless you select text either side - 10https://bugzilla.wikimedia.org/49396#c13 (10James Forrester) 5REOP>3RESO/FIX No, this was and remains fixed. Test in Chrome or Firefox, for example. [16:09:40] 3VisualEditor / 3ContentEditable: VisualEditor: Can't copy template or media with Safari - 10https://bugzilla.wikimedia.org/70143 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High s:5normal>3major [16:11:41] 3VisualEditor / 3ContentEditable: VisualEditor: Applying text formatting to empty cell does not format the text entered afterwards - 10https://bugzilla.wikimedia.org/72825#c2 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal (In reply to Ed Sanders from comment #1) > We don't have the concept of inser... [16:13:12] 3VisualEditor / 3Mobile: VisualEditor Mobile: Support Android (tracking) - 10https://bugzilla.wikimedia.org/70372#c2 (10James Forrester) (In reply to Alex Monk from comment #1) > Is this a tracking bug? Yes. [16:13:13] 3VisualEditor: VisualEditor: Tracking bugs for VisualEditor (tracking) - 10https://bugzilla.wikimedia.org/54363 (10James Forrester) [16:13:27] 3VisualEditor / 3MediaWiki integration: VisualEditor: Deal with Translate extension's save abort hooks - 10https://bugzilla.wikimedia.org/65653#c3 (10Nemo) (In reply to James Forrester from comment #2) > I don't know. You're the Translate extension expert. :-) Ok. That error probably just means that some ne... [16:14:41] 3VisualEditor / 3Mobile: VisualEditor Mobile: The label for "Re-use" tool is not greyed out when the tool is disabled (icon is greyed out) - 10https://bugzilla.wikimedia.org/72405#c2 (10James Forrester) (In reply to Alex Monk from comment #1) > Looks like this is caused by MobileFrontend's > less/modules/edi... [16:15:11] 3VisualEditor / 3Editing Tools: VisualEditor: Citations appear broken for a few moments, before getting inserted in a Basic Reference dialog . - 10https://bugzilla.wikimedia.org/70884#c2 (10James Forrester) 5UNCO>3RESO/WOR Done. [16:16:58] 3VisualEditor / 3MediaWiki integration: VisualEditor: Deal with Translate extension's save abort hooks - 10https://bugzilla.wikimedia.org/65653#c4 (10James Forrester) (In reply to Nemo from comment #3) > (In reply to James Forrester from comment #2) > > I don't know. You're the Translate extension expert. :-... [16:19:56] 3VisualEditor / 3Editing Tools: VisualEditor: Transclusion dialogs panes should include a link to the template's definition page (for further documentation), even if there is TemplateData to document it - 10https://bugzilla.wikimedia.org/49772 (10James Forrester) 5REOP>3ASSI p:5Normal>3Lowest [16:20:12] 3MediaWiki / 3Page editing: "Templates used on this page" on section edit should show templates used in the section at initial edit as well as preview - 10https://bugzilla.wikimedia.org/878 (10James Forrester) [16:21:41] 3VisualEditor / 3Initialisation: VisualEditor: Browser blacklist issues (tracking) - 10https://bugzilla.wikimedia.org/50781#c2 (10James Forrester) There's no real point adding Bugzilla aliases, as Phabricator doesn't support them so they're going to get dropped in a matter of weeks. [16:22:25] 3VisualEditor / 3MediaWiki integration: VisualEditor: avoid causing "Translation unit markers in unexpected position" edit abort - 10https://bugzilla.wikimedia.org/65653#c5 (10Nemo) I guess it can also be put that way. :) Does this new summary reflect the aim? [16:23:57] 3VisualEditor / 3Editing Tools: Links to Draft namespace show as red links in link inspector search - 10https://bugzilla.wikimedia.org/71659#c2 (10James Forrester) 5NEW>3RESO/FIX p:5Unprio>3Normal Indeed, this was probably fixed when we modified MW's API return to always give the exact value. [16:24:10] 3VisualEditor / 3Editing Tools: VisualEditor: Links to Draft namespace show as red links in link inspector search - 10https://bugzilla.wikimedia.org/71659 (10James Forrester) [16:24:28] 3VisualEditor: VisualEditor: Work correctly in Draft namespace (tracking) - 10https://bugzilla.wikimedia.org/59885#c2 (10James Forrester) 5ASSI>3RESO/FIX Indeed. All known issues fixed. Marking as such. [16:25:55] 3VisualEditor / 3MediaWiki integration: VisualEditor: avoid causing "Translation unit markers in unexpected position" edit abort - 10https://bugzilla.wikimedia.org/65653#c6 (10James Forrester) (In reply to Nemo from comment #5) > I guess it can also be put that way. :) Does this new summary reflect the > aim... [16:29:58] 3VisualEditor / 3Editing Tools: VisualEditor: When using citation templates, the page title and access date fields should be filled automatically - 10https://bugzilla.wikimedia.org/56772#c5 (10James Forrester) 5REOP>3ASSI a:5James Forrester>3None (In reply to Alex Monk from comment #3) > It should be... [16:30:30] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=108764786 [16:30:30] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=108767078 [16:30:30] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=108788075 [16:30:30] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=108788204 [16:30:30] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=108795036 [16:30:31] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=108796202 [16:30:31] Corruption alert: visualeditor-needcheck on ptwiki: https://pt.wikipedia.org/?diff=40463401 [16:30:32] Corruption alert: visualeditor-needcheck on itwiki: https://it.wikipedia.org/?diff=68968184 [16:30:32] Corruption alert: visualeditor-needcheck on trwiki: https://tr.wikipedia.org/?diff=14824959 [16:30:33] Corruption alert: visualeditor-needcheck on dawiki: https://da.wikipedia.org/?diff=7838325 [16:40:41] 3VisualEditor / 3Editing Tools: VisualEditor: When using citation templates, the page title and access date fields should be filled automatically - 10https://bugzilla.wikimedia.org/56772#c6 (10Jackmcbarn) I created https://gerrit.wikimedia.org/r/#/c/137824/ a while ago. I'll try to get around to reworking it... [17:05:55] 3VisualEditor / 3Mobile: VisualEditor Mobile: Support Android (tracking) - 10https://bugzilla.wikimedia.org/70372 (10Alex Monk) [17:08:48] * James_F waves. [17:10:50] hi James_F [17:11:24] James_F, I set another tracker's alias, and then later got to your message about it being relatively pointless due to phabricator [17:11:37] Krenair: Yeah. :-( [17:11:52] (dealing with a backlog of ~80 emails) [17:12:12] Krenair: Is that all? ;-) [17:13:07] James_F, I ran across that mobile bug and the VE code in MobileFrontend [17:13:20] … yeah. :-( [17:13:34] Should I bother looking through the Mobile component and seeing if I can deal with any of them? [17:13:41] hi. [17:13:58] Or does the mobile team do that? Don't think I've actually touched VE mobile stuff before. [17:16:14] Krenair: It's our job, now, yes. edsanders is the lead on mobile stuff. [17:16:15] MatmaRex: Hey. That patch didn't get merged, so no cherry-picks for SWAT. :_( [17:16:17] Some stuff in MobileFrontend. Okay... [17:16:17] MatmaRex: I can do it at 16:00 if you get someone to merge it in core. [17:17:30] James_F: yeah, i saw. chris replied to me that he will look at it today and hopefully swat it in the second window. [17:18:27] MatmaRex: Cool. [17:27:12] 3VisualEditor / 3Editing Tools: VisualEditor: Tables - multiple colspan and rowspan are not displayed correctly - 10https://bugzilla.wikimedia.org/72790 (10etonkovidova) p:5Unprio>3High [17:31:29] (03PS1) 10Cmcmahon: [BrowserTest] stuff moved out of the iframe to the main page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170728 [17:32:02] (03CR) 10Jforrester: [C: 031] [BrowserTest] stuff moved out of the iframe to the main page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170728 (owner: 10Cmcmahon) [17:32:22] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170728 (owner: 10Cmcmahon) [17:33:10] 3VisualEditor / 3ContentEditable: VisualEditor: Clicking on Edit link beside a section heading does not take user to that specific heading rather takes to the beginning of the article - 10https://bugzilla.wikimedia.org/65928#c11 (10Tony Thomas) This still happens. Check https://www.mediawiki.org/w/index.php?... [17:33:51] (03Merged) 10jenkins-bot: [BrowserTest] stuff moved out of the iframe to the main page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170728 (owner: 10Cmcmahon) [17:51:53] (03PS1) 10Esanders: Add missing focus call to pasteTarget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170738 [17:54:32] (03CR) 10Jforrester: [C: 032] Fix width of demo page dropdown [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170696 (owner: 10Esanders) [17:56:22] (03Merged) 10jenkins-bot: Fix width of demo page dropdown [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170696 (owner: 10Esanders) [17:58:28] 3VisualEditor / 3Editing Tools: VE not in edit mode after clicking "Resume editing" - 10https://bugzilla.wikimedia.org/72911 (10Chris McMahon) 3NEW p:3Unprio s:3normal a:3None Edit any page in beta labs e.g. http://en.wikipedia.beta.wmflabs.org/wiki/Media_Interface_VisualEditor_Test?veaction=edit Pe... [17:58:41] hey guys - simple question: how can I get the parsoid-generated HTML for, say, https://mail.google.com/mail/u/0/#inbox [17:58:47] lol, oops [17:58:56] I mean: https://en.wikipedia.org/wiki/Biology [18:02:25] (03PS1) 10Cmcmahon: [BrowserTest] Resume Editing no longer in iframe [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170742 [18:02:56] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170742 (owner: 10Cmcmahon) [18:04:22] (03Merged) 10jenkins-bot: [BrowserTest] Resume Editing no longer in iframe [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170742 (owner: 10Cmcmahon) [18:09:45] milimetric: http://parsoid.wmflabs.org/enwiki/Biology [18:13:02] thanks MatmaRex! [18:36:44] (03CR) 10Catrope: [C: 032] Pass $overlay to redirectTargetInput in MWSettingsPage [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170508 (https://bugzilla.wikimedia.org/72838) (owner: 10Alex Monk) [18:38:07] (03Merged) 10jenkins-bot: Pass $overlay to redirectTargetInput in MWSettingsPage [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170508 (https://bugzilla.wikimedia.org/72838) (owner: 10Alex Monk) [18:38:42] 3VisualEditor / 3Editing Tools: VisualEditor: Page Settings dialog box - an opacity issue - 10https://bugzilla.wikimedia.org/72838 (10James Forrester) 5PATC>3RESO/FIX p:5Unprio>3High [18:38:56] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf7] Page Settings dialog box - an opacity issue - 10https://bugzilla.wikimedia.org/72838 (10James Forrester) [18:39:10] (03PS3) 10Catrope: Clean up LookupInputWidget subclasses and use new functionality [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170379 [18:40:06] (03CR) 10Catrope: [C: 032] Add missing focus call to pasteTarget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170738 (owner: 10Esanders) [18:40:29] (03CR) 10Jforrester: [C: 032] Clean up LookupInputWidget subclasses and use new functionality [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170379 (owner: 10Catrope) [18:41:24] (03CR) 10Catrope: [C: 032] Catch backwards selection error in Firefox [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170697 (https://bugzilla.wikimedia.org/72835) (owner: 10Esanders) [18:41:49] (03Merged) 10jenkins-bot: Clean up LookupInputWidget subclasses and use new functionality [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170379 (owner: 10Catrope) [18:41:53] (03Merged) 10jenkins-bot: Add missing focus call to pasteTarget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170738 (owner: 10Esanders) [18:43:13] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/170245/ is the priority. :-) [18:43:17] (03Merged) 10jenkins-bot: Catch backwards selection error in Firefox [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170697 (https://bugzilla.wikimedia.org/72835) (owner: 10Esanders) [18:43:35] (03CR) 10Catrope: [C: 032] Set insertion annotations when typing over cell contents [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170692 (https://bugzilla.wikimedia.org/72831) (owner: 10Esanders) [18:44:27] 3VisualEditor / 3ContentEditable: VisualEditor: I can't select multiple refs when going backwards from the keyboard in Firefox - 10https://bugzilla.wikimedia.org/72835 (10James Forrester) 5PATC>3RESO/FIX a:3Ed Sanders [18:44:57] 3VisualEditor / 3ContentEditable: VisualEditor: Overwriting the text inside a cell does not retain the text format applied to that cell previously - 10https://bugzilla.wikimedia.org/72831 (10James Forrester) 5PATC>3RESO/FIX p:5Unprio>3Normal a:3Ed Sanders [18:45:23] (03Merged) 10jenkins-bot: Set insertion annotations when typing over cell contents [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170692 (https://bugzilla.wikimedia.org/72831) (owner: 10Esanders) [18:48:31] ryasmeen: https://bugzilla.wikimedia.org/show_bug.cgi?id=39596 [18:48:55] Thanks James_F :) [18:48:55] 3VisualEditor / 3ContentEditable: VisualEditor: Please let me drop the cursor into the table caption if it exists. Please? - 10https://bugzilla.wikimedia.org/72724#c1 (10James Forrester) 5ASSI>3RESO/FIX p:5Normal>3High Thanks! [18:49:21] (03CR) 10Catrope: [C: 04-1] Add support for non-table nodes in tables (e.g. aliens) (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170245 (https://bugzilla.wikimedia.org/72717) (owner: 10Esanders) [18:50:11] James_F: so i had a look at kaity's redesign [18:50:20] are we still going to stick with the extension thing? [18:50:42] or should supportive code go into ve? [18:50:52] if the former i need to write a loader for the message. [18:51:03] right now I'm cheating and using VE's resource loader. [18:52:28] (03PS4) 10Jforrester: Add support for non-table nodes in tables (e.g. aliens) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170245 (https://bugzilla.wikimedia.org/72717) (owner: 10Esanders) [18:52:40] (03CR) 10Jforrester: Add support for non-table nodes in tables (e.g. aliens) (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170245 (https://bugzilla.wikimedia.org/72717) (owner: 10Esanders) [18:52:55] mvolz: Doing it in VE for now is fine. [18:53:00] mvolz: We can always move it out later. [18:53:20] mvolz: That's what we did for editing formulæ and hieroglyphics, for instance. [18:54:07] (03CR) 10Catrope: [C: 04-1] Fixes to onDocumentDrop (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170366 (owner: 10Esanders) [18:54:57] James_F: sounds good to me! [18:57:57] (03PS1) 10Cmcmahon: [BrowserTest] no more iframes for Cite test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170762 [18:58:05] (03CR) 10Catrope: [C: 031] Add support for dropping text/html from external sources (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170690 (owner: 10Esanders) [18:58:45] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170762 (owner: 10Cmcmahon) [18:59:25] (03CR) 10Catrope: [C: 032] Prevent clicks on focusable nodes in tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170346 (owner: 10Esanders) [18:59:31] James_F: are you or any other people going to do google code in stuff? [18:59:40] mvolz: Not this year, no. [18:59:57] (03CR) 10Catrope: [C: 032] Disable cell editing when a context is opened [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170339 (https://bugzilla.wikimedia.org/72803) (owner: 10Esanders) [19:00:03] mvolz: VE has a really steep learning curve with relatively few things that we could consider "easy". [19:00:12] yeah [19:00:23] mvolz: It wouldn't be fair to try to get people to learn VE just to do a GCI task which is meant to take up to a day. [19:00:31] i was thinking about adding citoid service stuff. there are lots of little super easy things to do [19:00:46] (03CR) 10Catrope: [C: 032] Add support for non-table nodes in tables (e.g. aliens) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170245 (https://bugzilla.wikimedia.org/72717) (owner: 10Esanders) [19:00:57] 3VisualEditor / 3Editing Tools: VisualEditor: When the cursor is active inside a content cell , cannot insert any additional row or column to the table (or should we disable the row/column operator while user is inside a content cell?) - 10https://bugzilla.wikimedia.org/72803 (10James Forrester) 5PATC>3RE... [19:01:09] eh, you can get around in VE's code without understanding how it all really works. i know i used to ;) [19:01:12] 3VisualEditor / 3Data Model: VisualEditor: Clicking in a table that contains templated rows causes JS error - 10https://bugzilla.wikimedia.org/72717 (10James Forrester) 5PATC>3RESO/FIX [19:01:12] 3VisualEditor / 3Data Model: VisualEditor: Clicking in a table that contains templated rows causes JS error - 10https://bugzilla.wikimedia.org/72717 (10James Forrester) 5PATC>3RESO/FIX [19:01:20] MatmaRex: :-D [19:01:27] (03Merged) 10jenkins-bot: Prevent clicks on focusable nodes in tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170346 (owner: 10Esanders) [19:01:29] mvolz: Hmm. Maybe. It might be a bit premature? [19:01:46] are you saying my code isn't mature enough? :) [19:01:57] haha I know that. [19:02:00] mvolz: Yes. ;-) [19:02:22] i don't know if we have any 'easy' tasks up for taking, but GCI people could probably manage after being given a 200-word primer - what is the surface, what are models/views, why the VE/MW split [19:02:32] (03Merged) 10jenkins-bot: Disable cell editing when a context is opened [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170339 (https://bugzilla.wikimedia.org/72803) (owner: 10Esanders) [19:03:00] MatmaRex: Yeah, I was thinking that we really need to devote some time to creating easy bugs, but… [19:03:15] MatmaRex: Also, a 200-word primer on VE sounds wonderful. Are you offering? :-) [19:03:34] 200 words? Hah, good luck with that. Maybe in Navajo [19:04:10] i could try, but i'm not sure i understand it all well enough not to sneak in subtle lies :) [19:04:21] (03Merged) 10jenkins-bot: Add support for non-table nodes in tables (e.g. aliens) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170245 (https://bugzilla.wikimedia.org/72717) (owner: 10Esanders) [19:04:58] i still don't quite get how the bloody references work, for one. but that kind of living hell is probably not something we want to drag GCI students through, anyway ;) [19:05:05] MatmaRex: Subtle lies are the best kind. [19:05:07] No you don't [19:05:15] * James_F nods. [19:05:19] How references work needs to change anyway [19:06:50] we could probably make at least a very brief try at GCI? surely there are five or ten bugs in VE that could be solved by a smart high school student in an hour or two, we have thousands to choose from [19:09:44] (03CR) 10Catrope: [C: 032] Replace native range rectangle hacks with RangeFix library [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/169696 (owner: 10Esanders) [19:10:09] (03CR) 10Legoktm: "If you're going to use namespaces, it should follow the directory layout, so \OOUI\Elements\Button or \OOUI\Layouts\Form IMO" [oojs/ui] - 10https://gerrit.wikimedia.org/r/170501 (https://bugzilla.wikimedia.org/72705) (owner: 10Bartosz Dziewoński) [19:11:40] (03Merged) 10jenkins-bot: Replace native range rectangle hacks with RangeFix library [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/169696 (owner: 10Esanders) [19:11:49] (03Merged) 10jenkins-bot: [BrowserTest] no more iframes for Cite test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170762 (owner: 10Cmcmahon) [19:12:55] chrismcmalunch: (Yay.) [19:15:23] (03CR) 10Bartosz Dziewoński: "We're aiming to keep the APIs as close as possible between JS and PHP, and I don't think changing the JS code to match that scheme would b" [oojs/ui] - 10https://gerrit.wikimedia.org/r/170501 (https://bugzilla.wikimedia.org/72705) (owner: 10Bartosz Dziewoński) [19:16:58] RoanKattouw: [19:16:59] https://gerrit.wikimedia.org/r/170765 [19:19:33] (03CR) 10Catrope: [C: 032] Preserve original data inside parameter objects too [extensions/VisualEditor] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/170364 (owner: 10Catrope) [19:19:37] (03CR) 10Catrope: [C: 032] Preserve original data inside parameter objects too [extensions/VisualEditor] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/170365 (owner: 10Catrope) [19:19:57] (03PS1) 10Jforrester: MWGalleryInspectorTool: Provide the tool in the toolbar [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170766 [19:21:04] (03Merged) 10jenkins-bot: Preserve original data inside parameter objects too [extensions/VisualEditor] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/170364 (owner: 10Catrope) [19:21:07] (03Merged) 10jenkins-bot: Preserve original data inside parameter objects too [extensions/VisualEditor] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/170365 (owner: 10Catrope) [19:21:09] (03PS1) 10Catrope: Update VisualEditor core for cherry-pick [extensions/VisualEditor] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/170767 [19:22:22] (03PS1) 10Catrope: Update VisualEditor core for cherry-pick [extensions/VisualEditor] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/170769 [19:22:37] James_F: Can haz +2 ? ---^^ [19:23:08] (03CR) 10Catrope: [C: 032] Update VisualEditor core for cherry-pick [extensions/VisualEditor] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/170769 (owner: 10Catrope) [19:23:13] (03CR) 10Catrope: [C: 032] Update VisualEditor core for cherry-pick [extensions/VisualEditor] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/170767 (owner: 10Catrope) [19:24:29] (03Merged) 10jenkins-bot: Update VisualEditor core for cherry-pick [extensions/VisualEditor] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/170769 (owner: 10Catrope) [19:24:31] (03Merged) 10jenkins-bot: Update VisualEditor core for cherry-pick [extensions/VisualEditor] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/170767 (owner: 10Catrope) [19:28:31] MatmaRex: is there really much difference between prefixing with "OoUi" or "OOUI\" ? [19:29:10] legoktm: no. it just seemed cleaner. [19:30:01] 3VisualEditor / 3Editing Tools: VisualEditor: Tables drop their class when pasted in IE11 - 10https://bugzilla.wikimedia.org/72599#c2 (10etonkovidova) Verified in betalabs that now it works in IE11(and in Chrome too). [19:31:38] (03PS2) 10Esanders: Add support for dropping text/html from external sources [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170690 [19:31:40] (03PS3) 10Esanders: Fixes to onDocumentDrop [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170366 [19:31:57] MatmaRex: howdy [19:32:13] (03CR) 10Catrope: [C: 032] Fixes to onDocumentDrop [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170366 (owner: 10Esanders) [19:32:30] sup [19:32:32] (03CR) 10Catrope: [C: 032] Add support for dropping text/html from external sources [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170690 (owner: 10Esanders) [19:32:49] TrevorParscal: https://gerrit.wikimedia.org/r/170712 [19:35:08] (03Merged) 10jenkins-bot: Fixes to onDocumentDrop [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170366 (owner: 10Esanders) [19:36:30] (03CR) 10Catrope: [C: 032] "Go go Jenkins" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170690 (owner: 10Esanders) [19:37:11] 3VisualEditor / 3MediaWiki integration: VisualEditor: Restore selection when user exits the save dialog (on clicking "Resume editing") - 10https://bugzilla.wikimedia.org/72911 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal s:5normal>3minor [19:37:32] (03Merged) 10jenkins-bot: Add support for dropping text/html from external sources [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170690 (owner: 10Esanders) [19:38:34] (03CR) 10Trevor Parscal: [C: 04-1] "I think that injecting an argument in the constructor between the first three required arguments and the final list of variadic arguments " [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170712 (owner: 10Esanders) [19:39:52] (03PS1) 10Jforrester: Update VE core submodule to master (dc8cf63) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170773 [19:47:41] 3VisualEditor / 3ContentEditable: VisualEditor: CSS to add numbers to reference list items it vertically misaligned (should be top not bottom?) - 10https://bugzilla.wikimedia.org/61423 (10James Forrester) [19:47:41] 3VisualEditor / 3Initialisation: VisualEditor: Gracefully handle when available browser UI features are disabled (rather than refusing to load) - 10https://bugzilla.wikimedia.org/52008 (10James Forrester) [19:49:25] (03PS3) 10Ryasmeen: [BrowserTest] WIP adding cases to test other options under Page Settings to options.feature Fixed a typo in options_steps.rb [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169251 [19:57:32] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (dc8cf63) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170773 (owner: 10Jforrester) [19:58:49] (03Merged) 10jenkins-bot: Update VE core submodule to master (dc8cf63) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170773 (owner: 10Jforrester) [19:58:56] 3VisualEditor / 3ContentEditable: VE: IE11 - Insert and Bullet drop down options overflow - 10https://bugzilla.wikimedia.org/72592#c2 (10etonkovidova) p:5Unprio>3Normal The same issue(overflow) is for the Font formatting drop down options. [20:06:27] 3VisualEditor / 3Editing Tools: VisualEditor: When the cursor is active inside a content cell , cannot insert any additional row or column to the table (or should we disable the row/column operator while user is inside a content cell?) - 10https://bugzilla.wikimedia.org/72803 (10Rummana Yasmeen) [20:06:27] 3VisualEditor / 3Editing Tools: VisualEditor: Support tables (tracking) - 10https://bugzilla.wikimedia.org/39596 (10Rummana Yasmeen) [20:06:40] 3VisualEditor / 3ContentEditable: VisualEditor: Overwriting the text inside a cell does not retain the text format applied to that cell previously - 10https://bugzilla.wikimedia.org/72831 (10Rummana Yasmeen) [20:08:14] (03PS1) 10Catrope: Recompute ComboBox selection when adding/removing items [oojs/ui] - 10https://gerrit.wikimedia.org/r/170781 [20:10:25] 3VisualEditor / 3Editing Tools: VisualEditor:After adding a focusable node inside a content cell , placing cursor at the end of the table scrolls the page down - 10https://bugzilla.wikimedia.org/72804#c2 (10Rummana Yasmeen) Created attachment 17002 --> https://bugzilla.wikimedia.org/attachment.cgi?id=17002... [20:10:40] 3VisualEditor / 3Editing Tools: VisualEditor:After adding a focusable node inside a content cell , placing cursor at the end of the table scrolls the page down - 10https://bugzilla.wikimedia.org/72804 (10Rummana Yasmeen) 5RESO/WOR>3REOP [20:10:56] 3VisualEditor / 3Editing Tools: VisualEditor:After adding a focusable node inside a content cell , placing cursor at the end of the table scrolls the page down - 10https://bugzilla.wikimedia.org/72804 (10Rummana Yasmeen) 5REOP>3ASSI [20:11:28] 3VisualEditor / 3Editing Tools: VisualEditor:After adding a focusable node inside a content cell , placing cursor at the end of the table scrolls the page down - 10https://bugzilla.wikimedia.org/72804 (10Rummana Yasmeen) [20:11:28] 3VisualEditor / 3Editing Tools: VisualEditor: Support tables (tracking) - 10https://bugzilla.wikimedia.org/39596 (10Rummana Yasmeen) [20:14:27] 3VisualEditor / 3Editing Tools: VisualEditor: Scroll to item when it has been newly-inserted - 10https://bugzilla.wikimedia.org/51911 (10James Forrester) [20:14:27] 3VisualEditor / 3Editing Tools: VisualEditor: History actions should scroll the location of the transaction into view (unless it's a meta-data transaction which has no location?) - 10https://bugzilla.wikimedia.org/58091#c2 (10James Forrester) (In reply to Alex Monk from comment #1) > Hmm... Shouldn't this be... [20:14:57] 3VisualEditor / 3ContentEditable: VisualEditor: IE11 - Save page Edit summary text box is black - 10https://bugzilla.wikimedia.org/72917 (10etonkovidova) 3NEW p:3Unprio s:3normal a:3None Created attachment 17003 --> https://bugzilla.wikimedia.org/attachment.cgi?id=17003&action=edit Edit summary tex... [20:17:41] 3VisualEditor / 3Editing Tools: VisualEditor: After saving, the order of the texts gets reversed while adding some content in a slug created inside the caption field of a table - 10https://bugzilla.wikimedia.org/72833#c2 (10Rummana Yasmeen) Created attachment 17004 --> https://bugzilla.wikimedia.org/attach... [20:18:12] 3VisualEditor / 3Editing Tools: VisualEditor: After saving, the order of the texts gets reversed while adding some content in a slug created inside the caption field of a table - 10https://bugzilla.wikimedia.org/72833 (10Rummana Yasmeen) [20:18:12] 3VisualEditor / 3Editing Tools: VisualEditor: Support tables (tracking) - 10https://bugzilla.wikimedia.org/39596 (10Rummana Yasmeen) [20:18:28] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression] Scroll into view of section on section edit link click has stopped working - 10https://bugzilla.wikimedia.org/72919 (10James Forrester) 3ASSI p:3Unprio s:3normal a:3None In bug 65928 we got VE to scroll into view the section you click... [20:19:42] 3VisualEditor / 3ContentEditable: VisualEditor: Clicking on Edit link beside a section heading does not take user to that specific heading rather takes to the beginning of the article - 10https://bugzilla.wikimedia.org/65928#c12 (10James Forrester) (In reply to Tony Thomas from comment #11) > This still happ... [20:19:42] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression] Scroll into view of section on section edit link click has stopped working - 10https://bugzilla.wikimedia.org/72919 (10James Forrester) p:5Unprio>3Low [20:19:42] 3VisualEditor / 3Editing Tools: VisualEditor: History actions should scroll the location of the transaction into view (unless it's a meta-data transaction which has no location?) - 10https://bugzilla.wikimedia.org/58091#c3 (10Alex Monk) Dupe then? [20:22:44] mooeypoo: how's it going in drag and drop land? [20:23:04] TrevorParscal, I'm working on making TemplateDataDialog adhere to it so we have a base working version [20:23:07] (03PS1) 10Catrope: MWReferenceGroupInputWidget: Remove dummy call to onInputChange() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170784 (https://bugzilla.wikimedia.org/72783) [20:23:11] 3VisualEditor / 3Editing Tools: VisualEditor: History actions should scroll the location of the transaction into view (unless it's a meta-data transaction which has no location?) - 10https://bugzilla.wikimedia.org/58091#c4 (10James Forrester) (In reply to Alex Monk from comment #3) > Dupe then? Doing it for... [20:24:00] the widget itself is working, minus a few minor issues -- I need to figure out how to indicate "drop zones" properly. I added a div that appears after whatever you hover over while dragging, but it seems to show up *under* the item instead of to its right [20:24:09] it's probably just silly css things that I'm not doing right [20:25:31] so, you have a case where your items are arranged horizontally? [20:25:41] TrevorParscal: https://gerrit.wikimedia.org/r/170781 https://gerrit.wikimedia.org/r/170784 [20:26:04] woot td works. [20:26:09] TrevorParscal, yes, let me push this code so you can see [20:26:54] (03PS2) 10Mooeypoo: [wip] Adding paramOrder widget to TemplateData editor [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/170655 [20:26:59] TrevorParscal, ^^ [20:27:30] (03CR) 10jenkins-bot: [V: 04-1] [wip] Adding paramOrder widget to TemplateData editor [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/170655 (owner: 10Mooeypoo) [20:27:35] mooeypoo: take a look at this: http://demo.collabkit.org/ [20:27:41] 3VisualEditor / 3ContentEditable: VisualEditor: Applying text formatting to empty cell does not format the text entered afterwards - 10https://bugzilla.wikimedia.org/72825 (10Rummana Yasmeen) [20:27:41] 3VisualEditor / 3Editing Tools: VisualEditor: Support tables (tracking) - 10https://bugzilla.wikimedia.org/39596 (10Rummana Yasmeen) [20:28:23] oopsie, I forgot to add to the order when adding new param [20:28:42] 3VisualEditor / 3ContentEditable: VisualEditor: Typing more words into a ==Section heading== adds them into the next line, characters out of order - 10https://bugzilla.wikimedia.org/71364#c2 (10James Forrester) 5NEW>3RESO/FIX p:5Unprio>3High a:3Ed Sanders Looks like the issue we had in Safari sele... [20:29:09] mooeypoo: that site is a demo I did AGES ago, but it is drag and drop (HTML5 native) + mobile touch event support [20:29:22] hmm [20:29:24] and has a placeholder effect (using margins) [20:29:30] rather than inserting divs [20:29:41] haa [20:29:43] nice [20:29:49] I tried to do the same with a div that shows up [20:29:53] there are lots of tricks, you are welcome to look at the source (it's on github) [20:30:09] (I even called it 'placeholder' ... but yes, this is much better. [20:30:26] 3VisualEditor / 3MediaWiki integration: VisualEditor: When editing a file/category page, show the non-page composite components outside the VE surface in their "normal" place - 10https://bugzilla.wikimedia.org/56289#c3 (10James Forrester) *** Bug 70821 has been marked as a duplicate of this bug. *** [20:30:26] 3VisualEditor: Category description not displayed after save - 10https://bugzilla.wikimedia.org/70821#c1 (10James Forrester) 5NEW>3RESO/DUP Merging this with bug 56289. *** This bug has been marked as a duplicate of bug 56289 *** [20:30:27] hm [20:31:02] TrevorParscal, where's the github code? I can't find a link [20:31:08] my advice, when dragging over an item, you can figure out if you are dragging over the right or left half (or top/bottom half) and then add space (using margins) to represent where the drop-point would be if you dropped [20:31:21] https://github.com/collabkit [20:31:28] Yeah [20:31:37] https://github.com/collabkit/future/tree/master/brie/lib/client/ux.gridList [20:31:49] The only problem I have with this is that the widget items are doing their own drag/drop and emitting their event [20:32:00] it also supports drag and drop uploading and dragging out [20:32:45] Okay, so here's the issue I had with this -- Each item can be dragged and can be dropped "into"; when a drop occurs, the item that was dropped *into* emits a 'drop' event specifying the two items, dropped and droppee [20:33:09] so my issue was that if I add a left/right zone, the individual item can't know about it's "left" brother to emit that [20:33:17] .... wait, I just realized I don't have to do it this way. [20:33:28] I can just say the 2 items + direction and let the top widget figure it out [20:33:51] Don't you love it when explaining where you're stuck actually solves your issues? [20:33:54] you need to handle these events at the group level [20:33:55] 3VisualEditor / 3Editing Tools: VisualEditor: Clicking on the link added inside the content cell of a table scrolls the page to the down and shows the context menu for link inspector at the bottom left corner of CE - 10https://bugzilla.wikimedia.org/72802#c3 (10Rummana Yasmeen) Created attachment 17005 -->... [20:34:11] TrevorParscal, I do in general, I just emit "wrong". I emit as if there's only one way to drop -- "after". [20:34:14] if that makes sense. [20:34:26] 3VisualEditor / 3ContentEditable: VisualEditor: Pressing tab inside a cell when the cursor is active should taking it to the next cell, not to beginning of the document - 10https://bugzilla.wikimedia.org/72823 (10Rummana Yasmeen) [20:34:27] 3VisualEditor / 3Editing Tools: VisualEditor: Clicking on the link added inside the content cell of a table scrolls the page to the down and shows the context menu for link inspector at the bottom left corner of CE - 10https://bugzilla.wikimedia.org/72802 (10Rummana Yasmeen) [20:34:28] 3VisualEditor / 3Editing Tools: VisualEditor: Support tables (tracking) - 10https://bugzilla.wikimedia.org/39596 (10Rummana Yasmeen) [20:34:28] 3VisualEditor / 3Editing Tools: VisualEditor: IME selector shows up at the bottom-right corner of the table while selecting a cell on a table or placing a cursor into it - 10https://bugzilla.wikimedia.org/72824 (10Rummana Yasmeen) [20:34:29] see line 192 of https://github.com/collabkit/future/blob/master/brie/lib/client/ux.gridList/ux.gridList.js [20:34:33] I should have 3 parameters instead of just two. Dropped item, droppee, and direction - left/right [20:34:44] or rather "before/after" to be RTL-worthy too [20:35:16] oooh [20:35:32] hm [20:35:46] TrevorParscal, i can't call the group widget from the item can I? [20:36:13] the item is oblivious to its parent, they "communicate" through events, and the group widget can call the item directly, but not the other way around. [20:36:16] Or am I missing something? [20:36:57] 3VisualEditor / 3Editing Tools: VisualEditor: Tables drop their class when pasted in IE11 - 10https://bugzilla.wikimedia.org/72599 (10Rummana Yasmeen) 5ASSI>3RESO/FIX [20:38:51] (03PS1) 10Catrope: Followup d3367bb: make FieldsetLayout