[00:00:21] Krinkle, the mouse hooks make sense, but the event for 'dragover' doesn't have pageX or clientX -- all of those are inside originalEvent [00:00:23] Thanks RoanKattouw [00:00:28] * mooeypoo is confused [00:00:41] mooeypoo: Maybe they're non-standard? [00:00:47] Maybe? :\ [00:00:48] Or not cross-browser reliable [00:01:01] It works in both chrome and firefox, but that doesn't mean much. [00:01:10] If they're standard in HTML5 and only one browser implements them, jQuery won't copy them to event since that would make for unreliable code. [00:01:31] (or any browsers other than all the ones that jQuery supports that support dragover event) [00:01:41] Krinkle, so, the safer way would be to go with mousemove I guess. It sucks, because then I need to listen to another event and make it conditional ('if drag started, get the mouse location, etc') [00:01:49] * mooeypoo nods [00:02:00] mooeypoo: Well, It's fine to use the originalEvent. [00:02:07] I wouldn't compromise on that. [00:02:16] yeah. Seems that would be the safer way, then, if that's the case. It works when I use originalEvent, but if you say it's not safe for crossbrowser... meh? [00:02:24] Just be sure to test it well :) [00:02:55] Yeah. Will do. I'm also reading up about it in various documentation places. [00:03:04] and have an if statement that accounts for what happens if the event is fired but no pageX/clientX is present (e.g. abort the action or fallback then) [00:03:13] I imagine this has been invented before. [00:04:03] One possibilty that comes to mind is to have a cheap mousemove event listener that does nothing other than set a locally-scoped variable to the pageX [00:04:14] and then read that from the next dragover event that has no pageX [00:04:26] (assuming both fire) [00:05:11] mooeypoo: [00:05:19] sorry, i was away for AGES [00:05:30] no probs, TrevorParscal [00:05:31] what I was trying to say about dealing with the events at the group level [00:05:34] i'm mainly ranting [00:05:45] is to LISTEN to them on the group element, not the child elemnts [00:05:55] (03PS2) 10Alex Monk: Follow normalisation response from category status query [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166863 (https://bugzilla.wikimedia.org/72080) [00:05:56] while reading documentation and trying to apply your method to the widget. [00:06:01] (03CR) 10jenkins-bot: [V: 04-1] Follow normalisation response from category status query [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166863 (https://bugzilla.wikimedia.org/72080) (owner: 10Alex Monk) [00:06:08] if you look at line 192 of https://github.com/collabkit/future/blob/master/brie/lib/client/ux.gridList/ux.gridList.js [00:06:08] hmmm [00:06:14] yeah I saw that. [00:06:14] i bind these event hanlders to the container [00:06:33] the gridList not the gridListItem [00:06:40] (03CR) 10Alex Monk: [C: 04-1] "This breaks other things as well (like moving existing categories, for some reason). And probably overcomplicates things." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166863 (https://bugzilla.wikimedia.org/72080) (owner: 10Alex Monk) [00:06:42] TrevorParscal, isn't it easier, though, to do this on the individual item, though? The parent would only get an event "dropped" with params "from" "to" and "side" or something? [00:06:59] use $( e.target ) to get the item it was actually droped on [00:07:12] 3VisualEditor / 3ContentEditable: VisualEditor: Cut+paste of {{convert}} and {{cite web}} unleashes invasion of snowman clone army in endless loop - 10https://bugzilla.wikimedia.org/72512#c4 (10etonkovidova) Checked in betalabs and test2 - seems to be fixed. [00:07:21] hm [00:07:29] Krenair: Also, did you see https://bugzilla.wikimedia.org/show_bug.cgi?id=72906 ? (Sorry. :-() [00:07:43] it's more efficient to delegate the event handling to the parent [00:07:52] Then the item deals with its own "base" events, and only emits when an actual switch happens. This would also allow the item to be used in other widgets; instead of reorder, something else with drag/drop. [00:08:05] That was, at least, my attempt. Your way is easier, though. [00:08:11] and you can also easily catch drops on the group that didn't nessecarily land on an item (in the case of margins) [00:08:12] 3VisualEditor / 3Mobile: VisualEditor Mobile: The label for "Re-use" tool is not greyed out when the tool is disabled (icon is greyed out) - 10https://bugzilla.wikimedia.org/72405#c5 (10Rummana Yasmeen) Verified the fix in Betalabs [00:08:29] * mooeypoo nods [00:08:29] James_F, yes, I saw that bug. [00:08:30] and track which item was most recently dragged over [00:08:39] TrevorParscal, yeah, you're right. [00:09:14] okay. I'll redo. It sounded so much easier to have the items deal with their own events and the widget dealing only with the final "switched" event or something. But yes. [00:09:16] I spent like 2 weeks banging my head against this problem back in... 2011 [00:09:21] * mooeypoo nods [00:09:39] Krenair: Hate dumping these on you. [00:09:39] notice also that SelectWidget handles mouse events, not OptionWidget [00:09:47] this is a common pattern that has value [00:09:51] Yeah I saw that [00:10:13] James_F, my experience so far with the juggling around of names in the category widgets has not been great. [00:10:43] Especially when I've tried to introduce changes such as normalisation and redirects to it. [00:11:02] TrevorParscal, But in there, the're just one kind of "action" done, so I thought it made sense. In drag/drop, you have complex evnts -- start dragging, dragging over stuff, dropping, drag-end, etc. That's why I thought of splitting it, making the top parent widget not care about the "small" things like movement, and just listen to the end of the process to handle the changes. [00:11:42] Krenair: Yeah, though who better to know how deep the mud lies? [00:11:43] TrevorParscal, *But* the more I am trying, the more issues I discover, so yes. Thank you for saving me bashing my head into the desk :D I'll redo this to have the parent widget listen for the events. [00:11:56] I think you will find that the complexity is far more manageable by centralizing the events in the group [00:12:12] Yeah I was thinking of the API as well [00:12:34] (03PS4) 10Alex Monk: Follow redirects in the category input widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163996 [00:12:48] I was hoping to make this generalized -- so, the items would be drag/drop but the *widget* is "reorder". So, you could theoretically use the same items for something like switch or whatever else that requires drag/drop, if that makes sense. [00:12:53] but i think that's no longer worth it [00:13:08] sigh [00:13:17] this doesn't even work [00:14:11] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf7] The group names inside "Use this group" field are appearing in a short form like "g..." for both "References list" and "Basic Reference" dialog when you open these dialogs first time in a session - 10https://bugzilla.wikimedia.org/72783#c9 (1... [00:14:30] (03PS5) 10Alex Monk: Follow redirects in the category input widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163996 [00:14:31] ryasmeen: SWAT just went out, so all those three bugs should be fixed in wmf6 now and 72721 should be fixed in both wmf5 and wmf6 [00:15:09] RoanKattouw: got it!:) [00:15:29] (03PS3) 10Alex Monk: Follow normalisation response from category status query [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166863 (https://bugzilla.wikimedia.org/72080) [00:16:47] (03CR) 10jenkins-bot: [V: 04-1] Follow normalisation response from category status query [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166863 (https://bugzilla.wikimedia.org/72080) (owner: 10Alex Monk) [00:16:53] ffs, what now? [00:18:13] MatmaRex, sorry about that somewhat incoherent review on the indicators parser tests patch .. but, it is late in the day and i am about to head home .. but, i have to understand how parsoid and indicators interact. [00:18:28] (03PS4) 10Alex Monk: Follow normalisation response from category status query [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166863 (https://bugzilla.wikimedia.org/72080) [00:18:43] subbu: that's something i also need to think about, eh [00:19:05] ok. [00:19:44] (03CR) 10jenkins-bot: [V: 04-1] Follow normalisation response from category status query [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166863 (https://bugzilla.wikimedia.org/72080) (owner: 10Alex Monk) [00:19:46] Missing semi-colon. Rage. [00:20:34] (03PS5) 10Alex Monk: Follow normalisation response from category status query [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166863 (https://bugzilla.wikimedia.org/72080) [00:21:11] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf7] The options under Page Settings and Advances Settings of Page Options dialog are appearing very cramped - 10https://bugzilla.wikimedia.org/72792#c4 (10Rummana Yasmeen) Verified the fix in Betalabs [00:26:25] (03CR) 10Alex Monk: [C: 04-1] "see previous comment" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166863 (https://bugzilla.wikimedia.org/72080) (owner: 10Alex Monk) [00:28:42] 3VisualEditor / 3Mobile: VisualEditor: editing tables in Mobile - Edit mode displays broken tables - 10https://bugzilla.wikimedia.org/72819 (10Rummana Yasmeen) 5NEW>3ASSI a:3Ed Sanders [00:36:19] (03PS5) 10SuchetaG: Replacing MWTitleInputWidget.getValue() with MWTitleInputWidget.getTitle() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170071 (https://bugzilla.wikimedia.org/71998) [00:37:56] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf6] For a re-used reference dialog the group names for reference lists are not at all visible in the "Use this group" combo box - 10https://bugzilla.wikimedia.org/72785#c3 (10Rummana Yasmeen) Verified the fix in Betalabs and test2 [00:41:55] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf6] The dropdown box for search results in Insert Template dialog sticks to the dialog if you click on "Show Options" button without closing the dropdown - 10https://bugzilla.wikimedia.org/72789#c3 (10Rummana Yasmeen) Verified the fix in Betalabs an... [00:44:04] (03CR) 10Catrope: [C: 04-1] Replacing MWTitleInputWidget.getValue() with MWTitleInputWidget.getTitle() (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170071 (https://bugzilla.wikimedia.org/71998) (owner: 10SuchetaG) [00:44:55] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression wmf5] The wikitext editor does not show any wikitext for any page when switching from VE in test2 and Beta Labs - 10https://bugzilla.wikimedia.org/72571 (10James Forrester) [00:45:43] 3VisualEditor / 3ContentEditable: VisualEditor: When highlighting and replacing a text, VE starts typing by itself - 10https://bugzilla.wikimedia.org/68278#c4 (10etonkovidova) Seems to be fixed - not reproducible. [00:51:55] 3VisualEditor / 3ContentEditable: VisualEditor: [Regression wmf5] FocusableNodes not selectable when surface is blurred - 10https://bugzilla.wikimedia.org/72721#c8 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in test2 and production (en.wiki) [00:54:41] 3VisualEditor / 3MediaWiki integration: VisualEditor: User should be able to add gallery inside reference - 10https://bugzilla.wikimedia.org/63022 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Low s:5normal>3enhanc [00:55:55] 3VisualEditor / 3Editing Tools: VisualEditor: Sidebar button "Add more information" in template dialog is cut off / too long - 10https://bugzilla.wikimedia.org/68496#c1 (10James Forrester) 5NEW>3RESO/WON Width is fine in en/fr/de/nl, and appears in response to user action, selected at first. [00:56:12] ryasmeen, hi [00:56:22] hi Krenair [00:56:30] ryasmeen, I was looking at https://bug-attachment.wikimedia.org/attachment.cgi?id=16862 [00:56:42] 3VisualEditor / 3Technical Debt: VisualEditor: Copying of styles to dialog frame is dirty - 10https://bugzilla.wikimedia.org/52486#c3 (10James Forrester) 5ASSI>3RESO/FIX a:3Roan Kattouw Effectively fixed for dialogs by expedient of not doing this any more… [00:56:42] yup [00:56:46] What is misaligned on this? [00:57:24] oh, the buttons "Cancel" and "Ok" , they used to be centre aligned [00:57:43] That's a browser window, isn't it? [00:57:49] Yes [00:57:57] This seems to be the normal native confirm dialog [00:58:04] Firefox upstream issue? [00:58:11] Safari. [00:58:12] Or are we doing something to make it unaligned? [00:58:15] Ah. [00:58:25] Krenair: Not Safari I think? Look at the console. [00:58:42] Bug says Safari. [00:58:55] (03CR) 10Trevor Parscal: [C: 04-1] [BREAKING CHANGE] Move selection restrictions from tools to commands (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170712 (owner: 10Esanders) [00:59:01] My eyes say Firefox. :-) [00:59:03] ( https://bugzilla.wikimedia.org/show_bug.cgi?id=72408 ) [00:59:14] ryasmeen, was this Firefox or Safari? [00:59:46] (03CR) 10Trevor Parscal: [C: 032] Further mute keyboard shortcuts when disabled [oojs/ui] - 10https://gerrit.wikimedia.org/r/170713 (owner: 10Esanders) [01:00:12] 3VisualEditor / 3Data Model: VisualEditor: Whitespace-only headings should be collapsed to (blank) paragraphs - 10https://bugzilla.wikimedia.org/49452 (10James Forrester) [01:00:13] 3VisualEditor / 3ContentEditable: VisualEditor: Copying and pasting results in new blank section heading: "== ==" - 10https://bugzilla.wikimedia.org/55769 (10James Forrester) [01:01:08] (03CR) 10Trevor Parscal: [C: 032] Allow errors to be warnings, and give continue rather than retry button [oojs/ui] - 10https://gerrit.wikimedia.org/r/170845 (owner: 10Alex Monk) [01:01:42] (03Merged) 10jenkins-bot: Further mute keyboard shortcuts when disabled [oojs/ui] - 10https://gerrit.wikimedia.org/r/170713 (owner: 10Esanders) [01:03:08] (03Merged) 10jenkins-bot: Allow errors to be warnings, and give continue rather than retry button [oojs/ui] - 10https://gerrit.wikimedia.org/r/170845 (owner: 10Alex Monk) [01:03:14] Krenair, sorry it was on Firefox :P [01:03:34] :) [01:04:06] (I don't actually use Firefox or Safari so was relying on what you wrote in the bug.) [01:04:26] 3VisualEditor / 3ContentEditable: VisualEditor: Can't copy a single node selection (e.g. template / media / reference) in Safari - 10https://bugzilla.wikimedia.org/70143#c2 (10James Forrester) p:5High>3Normal Browser bugs are fun, aren't they? :-( [01:05:19] (03PS1) 10Catrope: Move most of ve.js to ve.utils.js [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170874 [01:05:58] 3VisualEditor / 3ContentEditable: VisualEditor: Rich content copied from sub-documents (image captions, references, etc.) down-cast to plain text when the sub-document is closed - 10https://bugzilla.wikimedia.org/51725 (10James Forrester) [01:05:58] 3VisualEditor / 3Technical Debt: VisualEditor: Internal nodes should eventually be in a separate document ("sub-documents") - 10https://bugzilla.wikimedia.org/47344 (10James Forrester) [01:06:00] (03PS6) 10SuchetaG: Replacing MWTitleInputWidget.getValue() with MWTitleInputWidget.getTitle() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170071 (https://bugzilla.wikimedia.org/71998) [01:06:56] 3VisualEditor / 3ContentEditable: VisualEditor: Can't cut or copy citation template in Reference dialog - 10https://bugzilla.wikimedia.org/65593#c2 (10James Forrester) 5ASSI>3RESO/DUP It's possible to cut/copy things from references, but you can't then paste them back into VE once you shut the dialog –... [01:06:56] 3VisualEditor / 3ContentEditable: VisualEditor: Rich content copied from sub-documents (image captions, references, etc.) down-cast to plain text when the sub-document is closed - 10https://bugzilla.wikimedia.org/51725#c5 (10James Forrester) *** Bug 65593 has been marked as a duplicate of this bug. *** [01:07:06] TrevorParscal, I was probably supposed to add qqq docs for that new message... [01:07:07] (03CR) 10jenkins-bot: [V: 04-1] Move most of ve.js to ve.utils.js [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170874 (owner: 10Catrope) [01:14:12] 3VisualEditor: VisualEditor: unexpected results while copy/pasting reference contents - 10https://bugzilla.wikimedia.org/72901#c1 (10James Forrester) 5NEW>3RESO/DUP (In reply to Elitre from comment #0) > See > https://www.mediawiki.org/w/index.php?title=User:Elitre_(WMF)/ > sandbox&diff=prev&oldid=1249997... [01:14:12] 3VisualEditor / 3ContentEditable: VisualEditor: Pasting annotated text causes space to be removed at annotation separators - 10https://bugzilla.wikimedia.org/71718#c1 (10James Forrester) *** Bug 72901 has been marked as a duplicate of this bug. *** [01:17:24] (03CR) 10Catrope: [C: 032] Replacing MWTitleInputWidget.getValue() with MWTitleInputWidget.getTitle() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170071 (https://bugzilla.wikimedia.org/71998) (owner: 10SuchetaG) [01:18:40] (03Merged) 10jenkins-bot: Replacing MWTitleInputWidget.getValue() with MWTitleInputWidget.getTitle() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170071 (https://bugzilla.wikimedia.org/71998) (owner: 10SuchetaG) [01:22:56] 3VisualEditor / 3Editing Tools: VisualEditor: “Uncaught Error: Unable to parse title” when entering "Talk:" as a template - 10https://bugzilla.wikimedia.org/71998 (10James Forrester) 5PATC>3RESO/FIX [01:28:45] 3OOjs: v8 warns it won't optimize oo.Factory.create or oo.EventEmitter.emit - 10https://bugzilla.wikimedia.org/72933 (10Ori Livneh) 3NEW p:3Unprio s:3normal a:3None To reproduce: - Navigate to an article - Open Chrome's Developer Tools - Click 'Profiles' - Select 'Collect JavaScript CPU Profile' - Cli... [02:14:42] 3VisualEditor / 3Mobile: VisualEditor Mobile: The Citation icon does not get highlighted upon clicking or tapping on it in Mobile VE using desktop Safari and iOS safari - 10https://bugzilla.wikimedia.org/72410 (10Alex Monk) [02:22:40] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression pre-wmf15] Pressing backspace to delete the link target inside link inspector closes the inspector - 10https://bugzilla.wikimedia.org/68195#c7 (10Alex Monk) Can't reproduce... [02:27:11] 3VisualEditor / 3Mobile: VisualEditor Mobile: Misaligned "Cancel" and "Ok" button in the confirmation dialogs for abandoning edit and switching to Edit Source mode - 10https://bugzilla.wikimedia.org/72408#c1 (10Alex Monk) These are native confirm dialogs, so this bug is upstream or invalid... [02:35:55] 3VisualEditor / 3Mobile: VisualEditor Mobile:[Regression wmf4] Link suggestions are appearing in a broken way inside Link Inspector in mobile - 10https://bugzilla.wikimedia.org/72402#c1 (10Alex Monk) Cannot reproduce. [03:02:11] 3VisualEditor / 3Mobile: VisualEditor Mobile: Misaligned "Cancel" and "Ok" button in the confirmation dialogs for abandoning edit and switching to Edit Source mode - 10https://bugzilla.wikimedia.org/72408#c2 (10James Forrester) 5NEW>3RESO/INV Going with the latter for now. [04:32:11] 3VisualEditor / 3ContentEditable: VisualEditor: Can't cut or copy citation template in Reference dialog - 10https://bugzilla.wikimedia.org/65593#c3 (10WhatamIdoing) Created attachment 17008 --> https://bugzilla.wikimedia.org/attachment.cgi?id=17008&action=edit Screenshot showing grayed-out "Cut" item in E... [04:37:40] 3VisualEditor / 3ContentEditable: VisualEditor: Can't cut or copy citation template in Reference dialog - 10https://bugzilla.wikimedia.org/65593#c4 (10WhatamIdoing) 5RESO/DUP>3REOP See attached screenshot. On the screenshot you can see that the citation template is selected and that Edit > Cut is graye... [09:03:42] (03CR) 10Esanders: "You've now twice suggested the thing I was in half a mind to do :)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170712 (owner: 10Esanders) [09:11:59] (03PS1) 10Prtksxna: Style mediawiki theme checkbox [oojs/ui] - 10https://gerrit.wikimedia.org/r/170893 [09:14:40] (03PS2) 10Prtksxna: Style mediawiki theme checkbox [oojs/ui] - 10https://gerrit.wikimedia.org/r/170893 [09:32:28] (03PS4) 10Esanders: [BREAKING CHANGE] Move selection restrictions from tools to commands [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170712 [09:33:25] (03PS3) 10Esanders: Move selection restrictions from tools to commands [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170711 [09:51:16] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Can you do the corresponding change in php/InputWidget.php?" (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/170893 (owner: 10Prtksxna) [09:56:40] 3VisualEditor / 3Editing Tools: VisualEditor: Regular context menu trying to render on TableSelections - 10https://bugzilla.wikimedia.org/72802#c4 (10Ed Sanders) Found the problem here. If the cell contains *only* a link then getAvailableTools says the whole cell is annotated and so tries to render the link... [10:10:14] (03PS1) 10Esanders: Disable desktop context on table selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170896 (https://bugzilla.wikimedia.org/72802) [10:14:28] (03PS1) 10Esanders: Missed function rename from RangeFix change [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170898 [10:26:28] 3MediaWiki / 3Page editing: Enter in edit summary does nothing when preview is forced - 10https://bugzilla.wikimedia.org/72945 (10Nemo) [10:26:34] 3MediaWiki / 3Page editing: Enter in edit summary does nothing when preview is forced - 10https://bugzilla.wikimedia.org/72945 (10Nemo) 3NEW p:3Unprio s:3normal a:3None 1) Visit a random page on zh.wiki as non.autoconfirmed user 2) Reach action=edit 3) Press tab or otherwise move the cursor in edit s... [10:46:04] (03Abandoned) 10Zfilipin: WIP [BrowserTest] Use rspec-expectations expect syntax instead of should syntax [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146712 (https://bugzilla.wikimedia.org/66369) (owner: 10Jagori79) [10:46:51] (03Abandoned) 10Zfilipin: WIP: [Browser Test] Reworked step definition and links file basis input [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/122400 (owner: 10Jagori79) [11:24:33] (03PS4) 10Zfilipin: [BrowserTest] WIP adding cases to test other options under Page Settings to options.feature [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169251 (owner: 10Ryasmeen) [11:24:40] (03CR) 10jenkins-bot: [V: 04-1] [BrowserTest] WIP adding cases to test other options under Page Settings to options.feature [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169251 (owner: 10Ryasmeen) [11:31:45] hey guys :P [11:33:19] is ve allready build into mediawiki? [11:48:56] 3MediaWiki / 3Page editing: Enter in edit summary does nothing when preview is forced - 10https://bugzilla.wikimedia.org/72945 (10Andre Klapper) p:5Unprio>3Normal [11:57:22] (03PS5) 10Zfilipin: [BrowserTest] WIP adding cases to test other options under Page Settings to options.feature [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169251 (owner: 10Ryasmeen) [12:15:29] (03PS3) 10Prtksxna: Style mediawiki theme checkbox [oojs/ui] - 10https://gerrit.wikimedia.org/r/170893 [12:18:07] (03PS4) 10Prtksxna: Style mediawiki theme checkbox [oojs/ui] - 10https://gerrit.wikimedia.org/r/170893 [12:18:31] (03CR) 10Prtksxna: "Bartosz, how do I test my PHP changes?" [oojs/ui] - 10https://gerrit.wikimedia.org/r/170893 (owner: 10Prtksxna) [12:22:14] (03PS1) 10Esanders: Support for generic file drop handlers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170907 [12:24:06] (03CR) 10jenkins-bot: [V: 04-1] Support for generic file drop handlers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170907 (owner: 10Esanders) [12:32:04] (03CR) 10Bartosz Dziewoński: "Run `composer install` in repository root to rebuild, then look at demos/widgets.php with your browser." [oojs/ui] - 10https://gerrit.wikimedia.org/r/170893 (owner: 10Prtksxna) [12:44:22] (03PS2) 10Esanders: Support for generic file drop handlers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170907 [12:46:21] (03CR) 10jenkins-bot: [V: 04-1] Support for generic file drop handlers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170907 (owner: 10Esanders) [13:16:09] (03PS2) 10Zfilipin: [BrowserTest] Fix language screenshots [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170026 [13:37:11] 3VisualEditor / 3Editing Tools: VisualEditor: Style texts when selected with Language inspector open, turns the drop-down selection blank. - 10https://bugzilla.wikimedia.org/70451#c5 (10Ritu Swain) Not reproducible. [14:12:46] (03CR) 10Esanders: "Ping" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167191 (owner: 10Esanders) [14:30:57] (03CR) 10Zfilipin: "Rebased." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169251 (owner: 10Ryasmeen) [14:31:15] 3VisualEditor / 3Editing Tools: Cite link is busted - 10https://bugzilla.wikimedia.org/72948 (10Chris McMahon) 3NEW p:3Unprio s:3major a:3None On any page in beta labs e.g. http://en.wikipedia.beta.wmflabs.org/wiki/Media_Interface_VisualEditor_Test?veaction=edit Click Cite/Website or any other Cite... [14:43:50] (03CR) 10Zfilipin: [C: 04-1] "I am not sure if my rebase broke something, but this is what I get:" (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169251 (owner: 10Ryasmeen) [14:46:26] (03PS1) 10Cmcmahon: [BrowserTest] no more iframes for "no review" message [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170923 [14:55:31] 3VisualEditor / 3Editing Tools: Cite link is busted - 10https://bugzilla.wikimedia.org/72948#c1 (10Chris McMahon) js error is "TypeError: title is undefined" [14:56:16] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170923 (owner: 10Cmcmahon) [14:57:54] (03Merged) 10jenkins-bot: [BrowserTest] no more iframes for "no review" message [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170923 (owner: 10Cmcmahon) [15:06:36] (03PS1) 10Cmcmahon: [BrowserTest] no iframes for switch mode test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170927 [15:07:14] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170927 (owner: 10Cmcmahon) [15:08:34] (03Merged) 10jenkins-bot: [BrowserTest] no iframes for switch mode test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170927 (owner: 10Cmcmahon) [15:13:26] 3VisualEditor / 3Editing Tools: VisualEditor:[Regression pre-wmf7]Disable Bold from Annotations sub menu , if cursor is in tableCellNode-header. - 10https://bugzilla.wikimedia.org/72949 (10Ritu Swain) [15:13:33] 3VisualEditor / 3Editing Tools: VisualEditor:[Regression pre-wmf7]Disable Bold from Annotations sub menu , if cursor is in tableCellNode-header. - 10https://bugzilla.wikimedia.org/72949 (10Ritu Swain) 3UNCO p:3Unprio s:3trivia a:3None Environment- beta 1> insert a table 2> click on the Header cell.... [15:40:43] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf6]“Uncaught Error: Inserted data is trying to close the root node (at index 0)” when applying heading formats with language inspector open. - 10https://bugzilla.wikimedia.org/72950 (10Ritu Swain) 3UNCO p:3Unprio s:3major a:3None Created att... [15:40:56] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf6]“Uncaught Error: Inserted data is trying to close the root node (at index 0)” when applying heading formats with language inspector open. - 10https://bugzilla.wikimedia.org/72950 (10Ritu Swain) [15:48:00] (03PS3) 10Esanders: Support for generic file drop handlers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170907 [16:08:57] (03PS11) 10Krinkle: Add a clean-up script for use as a pre-commit hook [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118758 (owner: 10Jforrester) [16:21:50] (03CR) 10Esanders: [C: 04-2] "wip" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170907 (owner: 10Esanders) [16:25:10] mooey|away: Which TemplateData change do you want me to look at? [16:26:08] o hi Krinkle. can you sanity-check me about RL image module stuff? [16:26:16] link? [16:26:55] Krinkle: no link, just a question. so far, a core assumption of RL was that you can generate output for multiple modules at once, each composed of multiple source files. outputting images from load.php would break both of these assumptions. does this sound sane to you? [16:27:29] MatmaRex: how would it break those assumptions, they're not modules, right? [16:28:11] you're referring to generating an individual png over load.php, right? [16:28:12] they would belong to modules, at least; or we'd have a module for each image we want to serve. [16:28:24] yes, a single PNG generated from SVG on-the-fly [16:28:28] No, that's a definite no go and I'm sure nobody suggested that [16:28:43] it also wouldn't be loadable or implementable [16:29:00] i'm pretty sure that's what we mostly agreed on with trevor, and it looks implementable to me. what do you suggest? [16:29:25] I was in that meeting too, what we settled on was generating the PNG over a load.php request. It's in load.php because it's part of ResourceLoader, it's not a module. [16:29:32] It might as well be getpng.php [16:29:48] It's a separate code path for handling the generation of one individual image [16:29:54] that just happens to be hitting the same entry point. [16:29:59] unrelated to modules otherwise [16:30:27] Corruption alert: visualeditor-needcheck on svwiki: https://sv.wikipedia.org/?diff=28441532 [16:30:27] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=108805297 [16:30:27] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=108824651 [16:30:27] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=108835205 [16:30:27] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=33171896 [16:30:28] Corruption alert: visualeditor-needcheck on simplewiki: https://simple.wikipedia.org/?diff=4929540 [16:30:28] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=66581109 [16:30:29] Corruption alert: visualeditor-needcheck on cawiki: https://ca.wikipedia.org/?diff=14251516 [16:30:29] Corruption alert: visualeditor-needcheck on cawiki: https://ca.wikipedia.org/?diff=14251568 [16:30:30] Corruption alert: visualeditor-needcheck on cawiki: https://ca.wikipedia.org/?diff=14251589 [16:30:30] Corruption alert: visualeditor-needcheck on cawiki: https://ca.wikipedia.org/?diff=14251675 [16:30:30] identifying the image by some set of parameters (e.g. load.php action=image, module=x, image=y, variant=z or whatever) [16:30:44] or even action=image&image=x/y/z [16:31:32] which is lazy-compiled, cached, and in a separate parallel request, and in a request that can be combined by varnish with other incoming cache misses to avoid stamepede [16:31:36] we would still need an instance of RLImageModule to figure out what to load, it seemed natural to use something like load.php?modules=…&only=image&… [16:31:54] (or we need to have the parsing logic in two places) [16:32:08] I'm not sure I get what the meaning of an image module would be. [16:32:20] I mean, it'd provide the css [16:32:41] and non-embedded, it would provide urls to load.php/getpng/x/y/z [16:32:49] or png fallback [16:33:00] for* [16:33:11] That's what we last discussed [16:33:16] and tehre seemed to be consensus [16:33:23] I don't know what the code is currently at, haven't looked at it [16:33:36] What's the status / what's your angle here today? [16:35:31] hmm. okay. [16:36:13] the status is that trevor's https://gerrit.wikimedia.org/r/#/c/165922/ exists, which implements a minimal scaffold [16:36:42] 3MediaWiki extensions / 3WikiEditor: WikiEditor: Add SVG versions of editing toolbar icons - 10https://bugzilla.wikimedia.org/35342#c61 (10Krinkle) Okay, this is getting ridiculous. M4tx made a commit that added SVG files (a low priority enhancement). The commit accidentally mutilated the "B" icon (visible r... [16:36:49] there's no image handling code written yet, and i'm apparnetly going to write it [16:39:11] 3MediaWiki extensions / 3WikiEditor: WikiEditor: Add SVG versions of editing toolbar icons - 10https://bugzilla.wikimedia.org/35342#c62 (10paladox2015) Hi I have one of the images that were fixed by a user here and fixed the other ones to. the patch is at https://gerrit.wikimedia.org/r/#/c/151611/ [16:43:26] MatmaRex: Right [16:43:40] James_F: WikiEditor is our area now? https://bugzilla.wikimedia.org/show_bug.cgi?id=35342 [16:47:27] 3OOjs: OOjs: v8 warns it won't optimize oo.Factory.create or oo.EventEmitter.emit - 10https://bugzilla.wikimedia.org/72933 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High s:5normal>3enhanc [16:50:13] hey VE guys -- any plans to enable VE on wikimediafoundation.org ? [16:50:37] someone tried to use OCG over there, and it didn't work because parsoid doesn't know about it... because VE isn't turned on. [16:51:03] Isn't foundationwiki using raw html? [16:51:11] i dunno anything about it [16:51:45] yes [16:52:03] wgRawHtml true on donatewiki, foundationwiki, internalwiki, collabwiki, zerowiki [16:52:57] Krenair: parsoid supports collabwiki though. [16:53:04] yeah... [16:53:17] I'm not actually sure how Parsoid/VE handle wgRawHtml. [16:57:45] I guess I could create a sandbox page in my collabwiki userspace and try it out... [17:08:50] James_F: any progress on adding OOjsUI/PHP to mediawiki/core? [17:11:10] RoanKattouw_away: You gave me .connect( this, { 'files-changed': [ 'emit', 'files-changed', files ] } ) as an equivalent for .on( 'files-changed', function ( files ) { upload.emit( 'files-changed', files ); } );, that can't be right though [17:11:21] The files variable doesn't exist at the time of the connect acll [17:11:23] call* [17:21:32] Krinkle: Eurgh. Yeah. [17:22:06] cscott: We could enable VE on WMFwiki but it seems a bit odd. If it's urgent… Note that VE isn't enabled on ~600 wikis.. [17:22:24] cscott: MatmaRex is working on it, but it's not done quite yet. [17:22:58] cscott: James_F: we could package ooui as a composer package basically whenever, as far as i can tell [17:23:48] cscott: James_F: not everything is implemented yet, but it should be usable and fairly stable, from the user's perspective [17:24:36] MatmaRex: Surely https://bugzilla.wikimedia.org/show_bug.cgi?id=72716 should be fixed first? [17:25:24] James_F: probably, but you can use the PHP part already. if that's all you need, then it's there [17:27:51] MatmaRex: I think cscott wants the magic. :-) [17:28:08] i don't know, he never mentioned that. :) [17:28:11] * James_F grins. [17:28:24] MatmaRex: Well, if you want to fix bug 72714 now, be my guest. :-) [17:29:38] i'd rather someone else messed with composer. :) [17:29:45] * James_F grins. [17:29:55] Nominate someone working on OOUI with more experience. ;-) [17:30:05] legoktm: job for you! [17:34:41] MatmaRex: i'd like to use OOui/PHP in Extension:Collection. Ideally this wouldn't involve copy-and-paste of all of OOui/PHP [17:35:03] Krinkle, this one: https://gerrit.wikimedia.org/r/#/c/167046/ [17:35:48] (03CR) 10Jforrester: [C: 04-2] "Still waiting for bug 72159 to be done so this change can be made properly." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167191 (owner: 10Esanders) [17:35:59] i don't think i need bug 72716 fixed; Extension:Collection has a "no JS" path and a "JS" path. I'd be using OOui/PHP on the "no JS" path. [17:36:15] just trying to make sure that the layout and widgets match the rest of the front end. [17:36:25] cscott: The idea is that you'd be able to have both client types served in one path. [17:36:50] That's always attractive, but not necessary for my first step [17:36:53] cscott: But we could release it 'early' for you, I suppose. [17:36:59] cscott: right now you can use it as git submodule, i guess [17:37:03] Anyone else know about connect? [17:37:08] As a first step I'm trying just to do the boring mechanical translation, as much as possible. [17:37:14] marktraceur: You should wait for Roan to get back. :-) [17:37:16] you'll be able to use it as a composer package when it's released, but don't ask me how to do that [17:37:21] MatmaRex: that might work -- will the extension bundling tools Do The Right Thing? [17:37:39] (03PS6) 10Cmcmahon: [BrowserTest] WIP adding cases to test other options under Page Settings to options.feature [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169251 (owner: 10Ryasmeen) [17:37:42] i'm pretty sure we could release it whenever, i just don't know how [17:37:49] legoktm probably would know [17:38:01] since he actually composerified it… [17:38:11] (03PS1) 10Esanders: Support toDomElements returning an empty array [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170958 [17:38:11] cscott: extension bundling? [17:38:50] https://www.mediawiki.org/wiki/Extension:Collection has "download snapshot" links, and it's automagically installed onto production wikis through some process I don't fully understand. [17:38:57] (03PS1) 10Esanders: Placholder -> placeholder [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170959 [17:39:01] James_F: Curse him and his lateness [17:39:03] if i add a git submodule to the repo, will the snapshots and deploy process Just Work? [17:39:07] cscott: No, that breaks with submodules. [17:39:21] it probably breaks with composer, too, i'm guessing? [17:39:22] cscott: Or… did? legoktm did some magic, but I can't remember if it's automatic. [17:39:25] VE somehow manages [17:39:33] (03PS4) 10Esanders: Support for generic file drop handlers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170907 [17:39:40] MatmaRex: With an over-ride or something. [17:39:42] yeah, i want to be like VE ;) [17:39:43] so WMF deployment will probably work, if you're careful and ask people [17:40:04] Special:ExtensionDistributor will also work, legoktm actually fixed that some time ago i think [17:40:11] OK. [17:40:29] sounds like maybe i should start by just cut-and-pasting? and graduate to something proper later? [17:41:13] i don't want ot be the person to say 'yes', but in my experience that has always worked flawlessly ;) [17:41:34] (03CR) 10Alex Monk: [C: 032] Placholder -> placeholder [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170959 (owner: 10Esanders) [17:41:57] * James_F tsks. [17:42:00] But… yes. :-( [17:42:06] (03CR) 10Esanders: Support for generic file drop handlers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170907 (owner: 10Esanders) [17:44:04] (03Merged) 10jenkins-bot: Placholder -> placeholder [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170959 (owner: 10Esanders) [17:46:33] (03CR) 10Esanders: [V: 032] Protect against offset=-1 in insertContent() [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170855 (https://bugzilla.wikimedia.org/72558) (owner: 10Catrope) [17:49:19] (03CR) 10Esanders: "Is this related to I3b4f0f75?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/144089 (owner: 10Inez) [17:49:41] (03CR) 10Jforrester: "Yes." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/144089 (owner: 10Inez) [17:50:50] marktraceur, what's the problem? [17:51:04] edsanders: RoanKattouw_away is looking mighty silly today: https://gerrit.wikimedia.org/r/#/c/170131/5/resources/mw.UploadWizardUpload.js [17:51:51] There's a few problems [17:52:16] actually [17:52:30] I was going to say you need to connect to upload, not this, but they're the same [17:52:32] as for 'files' [17:52:38] that should be omitted [17:52:51] an variables provided by the event should be added on the end automatically [17:52:54] Oh, and it'll just get...yeah [17:52:57] OK, easy enough, ta [17:53:57] I think... [17:54:03] It sounds right [17:54:05] I'll test 'er [17:54:21] Seems to work fine [17:58:24] (03CR) 10Catrope: [C: 032] Disable desktop context on table selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170896 (https://bugzilla.wikimedia.org/72802) (owner: 10Esanders) [17:58:37] (03CR) 10Catrope: [C: 032] Missed function rename from RangeFix change [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170898 (owner: 10Esanders) [18:00:13] 3VisualEditor / 3Editing Tools: VisualEditor: Regular context menu trying to render on TableSelections - 10https://bugzilla.wikimedia.org/72802 (10James Forrester) 5PATC>3RESO/FIX p:5Unprio>3Normal [18:00:48] (03Merged) 10jenkins-bot: Disable desktop context on table selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170896 (https://bugzilla.wikimedia.org/72802) (owner: 10Esanders) [18:00:52] (03Merged) 10jenkins-bot: Missed function rename from RangeFix change [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170898 (owner: 10Esanders) [18:01:28] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf6]“Uncaught Error: Inserted data is trying to close the root node (at index 0)” when applying heading formats with language inspector open. - 10https://bugzilla.wikimedia.org/72950#c1 (10etonkovidova) 5UNCO>3NEW p:5Unprio>3Normal Confirmed... [18:21:17] (03CR) 10Esanders: "As I said in my previous comment - fixing that bug would only make a few pixels difference." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167191 (owner: 10Esanders) [18:23:39] (03CR) 10Krinkle: [C: 031] Restore basic styling to toolbar in core target (only) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167191 (owner: 10Esanders) [18:24:05] (03CR) 10Krinkle: Restore basic styling to toolbar in core target (only) (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167191 (owner: 10Esanders) [18:24:58] (03CR) 10Esanders: "Specifically: http://i.imgur.com/u5x07pP.png (although looking at that there's a follow-up commit to make underline and text style icons l" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167191 (owner: 10Esanders) [18:25:42] edsanders: Umm. What? Your mock-up is totally wrong… [18:25:56] edsanders: The icon for the rest of the menu won't show at all… [18:28:27] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf7] Disable "Bold" from text styling control if the cursor is in a table header cell where MediaWiki's "wikitable" class or similar is used for that styling effect - 10https://bugzilla.wikimedia.org/72949#c1 (10James Forrester) 5UNCO>3ASSI p... [18:29:38] (03CR) 10Esanders: Restore basic styling to toolbar in core target (only) (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167191 (owner: 10Esanders) [18:30:56] (03CR) 10Catrope: [C: 032] Support toDomElements returning an empty array [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170958 (owner: 10Esanders) [18:32:08] MatmaRex: I set up https://packagist.org/packages/oojs/ui a few weeks ago :) [18:33:17] (03Merged) 10jenkins-bot: Support toDomElements returning an empty array [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170958 (owner: 10Esanders) [18:33:20] legoktm: didn't show up when i searched… [18:33:31] https://packagist.org/search/?q=oojs%2Fui [18:33:39] helpful [18:34:03] cscott: ^ [18:38:05] James_F, so how will they access the rest of the menu> [18:42:23] Is there a VE team email address? [18:43:28] (03PS5) 10Esanders: Support for generic file drop handlers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170907 [18:44:43] 3VisualEditor / 3Editing Tools: VisualEditor:[Regression pre-wmf7] Link Suggestions are not appearing on placing the cursor inside it - 10https://bugzilla.wikimedia.org/72959 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce: 1.Select a text 2.Press command+k 3.When the link in... [18:47:50] marcoil: editing-team@ [18:48:09] RoanKattouw: thanks! [18:48:30] cscott: The eventual plan is to bring oojs/ui-php into core, so I'd recommend just waiting until then if it's not super urgent. [18:48:43] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf7] Cannot add any Citations or Basic reference in a page , throwing Typeerror " Cannot read property 'replace' of undefined " - 10https://bugzilla.wikimedia.org/72948 (10Rummana Yasmeen) p:5Unprio>3Highes [18:48:56] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf7] Cannot add any Citations or Basic reference in a page , throwing Typeerror " Cannot read property 'replace' of undefined " - 10https://bugzilla.wikimedia.org/72948 (10Rummana Yasmeen) [18:50:00] edsanders: https://gerrit.wikimedia.org/r/170855 [18:52:12] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf6] A Label appears momentarily, showing all "Use this Group" options, when Re-Using a Reference - 10https://bugzilla.wikimedia.org/72904#c6 (10etonkovidova) It looks as the issue is gone - checked it in betalabs on Safari, FF, Chrome, and IE11. [18:53:40] edsanders: By clicking the down-arrow? [18:53:57] legoktm: "Eventual" ~= next week, right? [18:54:14] I have no idea [18:54:36] (03PS1) 10Catrope: Followup 0165a53: fix typo causing undefined to be passed to mw.Title [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170985 (https://bugzilla.wikimedia.org/72948) [18:54:39] legoktm: MatmaRex and TrevorParscal seem to be hoping you'll do it. :-) [18:54:52] (03CR) 10Jforrester: [C: 032] Followup 0165a53: fix typo causing undefined to be passed to mw.Title [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170985 (https://bugzilla.wikimedia.org/72948) (owner: 10Catrope) [18:55:29] D: [18:55:30] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf7] VisualEditor gets unresponsive after adding a template - 10https://bugzilla.wikimedia.org/72961 (10Rummana Yasmeen) 3NEW p:3Unprio s:3critic a:3None Steps to reproduce: 1.Insert any template in the page Observed Result: VE gets com... [18:55:43] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf7] VisualEditor gets unresponsive after adding a template - 10https://bugzilla.wikimedia.org/72961 (10Rummana Yasmeen) p:5Unprio>3Highes [18:56:17] (03Merged) 10jenkins-bot: Followup 0165a53: fix typo causing undefined to be passed to mw.Title [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170985 (https://bugzilla.wikimedia.org/72948) (owner: 10Catrope) [18:56:51] ryasmeen: 72961 === 72948 I think? [18:56:58] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf7] Cannot add any Citations or Basic reference in a page , throwing Typeerror " Cannot read property 'replace' of undefined " - 10https://bugzilla.wikimedia.org/72948 (10James Forrester) 5PATC>3RESO/FIX a:3Roan Kattouw [18:57:15] ryasmeen: Apparently not. [18:57:17] Bah. [18:57:43] yeah its not only for citation template but all [18:57:43] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf7] VisualEditor gets unresponsive after adding a template - 10https://bugzilla.wikimedia.org/72961 (10James Forrester) 5NEW>3ASSI a:3Roan Kattouw [19:00:29] (03PS1) 10Catrope: Followup 0165a53: don't store an mw.Title object instead of a string in TemplateModel [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170991 (https://bugzilla.wikimedia.org/72961) [19:01:29] (03CR) 10Jforrester: [C: 032] "Oh, eww." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170991 (https://bugzilla.wikimedia.org/72961) (owner: 10Catrope) [19:01:57] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf7] VisualEditor gets unresponsive after adding a template - 10https://bugzilla.wikimedia.org/72961 (10James Forrester) 5PATC>3RESO/FIX [19:02:43] (03Merged) 10jenkins-bot: Followup 0165a53: don't store an mw.Title object instead of a string in TemplateModel [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170991 (https://bugzilla.wikimedia.org/72961) (owner: 10Catrope) [19:03:41] 3VisualEditor / 3Editing Tools: VisualEditor: When the cursor is active inside a content cell , cannot insert any additional row or column to the table (or should we disable the row/column operator while user is inside a content cell?) - 10https://bugzilla.wikimedia.org/72803#c3 (10Rummana Yasmeen) Verified... [19:12:12] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf7] Cannot add any Citations or Basic reference in a page , throwing Typeerror " Cannot read property 'replace' of undefined " - 10https://bugzilla.wikimedia.org/72948#c4 (10etonkovidova) Verified in betalabs - Safari, Chrome, and FF. [19:12:58] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf7] The down arrow to bring up the context menu for Categories is not center aligned - 10https://bugzilla.wikimedia.org/72962 (10Rummana Yasmeen) 3NEW p:3Unprio s:3minor a:3None Created attachment 17014 --> https://bugzilla.wikimedia.o... [19:13:56] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf7] The down arrow to bring up the context menu for Categories is not center aligned - 10https://bugzilla.wikimedia.org/72962#c1 (10Rummana Yasmeen) Created attachment 17015 --> https://bugzilla.wikimedia.org/attachment.cgi?id=17015&action=edi... [19:15:55] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf7] VisualEditor gets unresponsive after adding a template - 10https://bugzilla.wikimedia.org/72961#c3 (10Rummana Yasmeen) Verified the fix in Betalabs [19:16:34] (03PS1) 10Jforrester: [BREAKING CHANGE] Remove the ve.bind function [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/171002 (https://bugzilla.wikimedia.org/72156) [19:19:27] 3VisualEditor / 3Editing Tools: VisualEditor: Support tables (tracking) - 10https://bugzilla.wikimedia.org/39596 (10Rummana Yasmeen) [19:19:41] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf7] Disable "Bold" from text styling control if the cursor is in a table header cell where MediaWiki's "wikitable" class or similar is used for that styling effect - 10https://bugzilla.wikimedia.org/72949 (10Rummana Yasmeen) [19:21:16] 3VisualEditor: VisualEditor: featured article template is hidden and easy to accidently delete - 10https://bugzilla.wikimedia.org/72963 (10Jared Zimmerman (WMF)) 3NEW p:3Unprio s:3normal a:3None Created attachment 17016 --> https://bugzilla.wikimedia.org/attachment.cgi?id=17016&action=edit icon not s... [19:22:44] 3VisualEditor: VisualEditor: line height in intro message is wrong causes collusions - 10https://bugzilla.wikimedia.org/72964 (10Jared Zimmerman (WMF)) 3NEW p:3Unprio s:3normal a:3None Created attachment 17017 --> https://bugzilla.wikimedia.org/attachment.cgi?id=17017&action=edit text collisions lin... [19:24:11] 3VisualEditor / 3ContentEditable: VisualEditor: Hidden templates should display as an icon in-page so they can be interacted with (e.g. a puzzle piece?) - 10https://bugzilla.wikimedia.org/49806#c27 (10James Forrester) *** Bug 72963 has been marked as a duplicate of this bug. *** [19:24:12] 3VisualEditor: VisualEditor: featured article template is hidden and easy to accidently delete - 10https://bugzilla.wikimedia.org/72963#c1 (10James Forrester) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 49806 *** [19:25:42] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf7] Link Suggestions are not appearing on placing the cursor inside it - 10https://bugzilla.wikimedia.org/72959 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High a:3Roan Kattouw [19:26:55] James_F, umm... is that featured article thing supposed to be hidden? [19:27:20] (03CR) 10Esanders: [C: 032] "oops" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170855 (https://bugzilla.wikimedia.org/72558) (owner: 10Catrope) [19:27:38] (03CR) 10Esanders: [V: 032] Protect against offset=-1 in insertContent() [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170855 (https://bugzilla.wikimedia.org/72558) (owner: 10Catrope) [19:28:14] James_F, if there's a down arrow - what distinguishes it from being attached to the rightmost icon? [19:29:35] (03Merged) 10jenkins-bot: Protect against offset=-1 in insertContent() [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170855 (https://bugzilla.wikimedia.org/72558) (owner: 10Catrope) [19:30:28] edsanders: Spacing. [19:30:48] edsanders: And the wider styling of the toolbars needs improvement, I agree. [19:30:54] So it's [ B I U v ] [19:31:08] that's hardly much better than [ B I U Av ] [19:31:28] 3VisualEditor / 3Data Model: VisualEditor: [Regression] “Uncaught Error: offset -1 out of bounds” when adding bullet/numbered list with link inspector open - 10https://bugzilla.wikimedia.org/72558 (10James Forrester) 5PATC>3RESO/FIX a:3Roan Kattouw [19:31:32] also this is an incremental improvement [19:31:46] (03PS1) 10Catrope: Populate LookupInputWidget on mousedown too [oojs/ui] - 10https://gerrit.wikimedia.org/r/171006 (https://bugzilla.wikimedia.org/72959) [19:31:49] No, it's [ B I v ] rather than [ B I Av ] better than [ B I ] [ Av ] [19:32:29] yes [19:32:43] But [ B I v ] looks like [ B Iv ] [19:33:01] (also the [] are invisible until hover, so it's subtler than you state) [19:33:31] either way having BI(U) visible is closer to what we're working towards [19:33:40] so +2 already! [19:33:50] Invisible on non-hover too, in MediaWiki. :-( [19:34:01] I'll +2 if you agree we're not putting underline in there. :-) [19:34:19] deal [19:34:25] OK. [19:34:55] (03CR) 10Jforrester: [C: 032] "Very well." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167191 (owner: 10Esanders) [19:35:11] hm, we don't have oo.bind in oojs ? [19:35:12] (03PS2) 10Jforrester: Restore basic styling to toolbar in core target (only) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167191 (owner: 10Esanders) [19:35:55] (03PS3) 10Esanders: Restore basic styling to toolbar in core target (only) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167191 [19:36:31] (03CR) 10Jforrester: [C: 032] Restore basic styling to toolbar in core target (only) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167191 (owner: 10Esanders) [19:38:54] meh this is crazy [19:38:58] (03Merged) 10jenkins-bot: Restore basic styling to toolbar in core target (only) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167191 (owner: 10Esanders) [19:39:13] TrevorParscal, "mousemove" is not emitting if I'm in a drag process. [19:40:33] okay ,I have an idea on how to fix it according to your code [19:40:50] But someone should flog Javascript. [19:42:40] 3VisualEditor: VisualEditor: line height in intro message is wrong causes collusions - 10https://bugzilla.wikimedia.org/72964#c1 (10James Forrester) 5NEW>3RESO/INV Local per-wiki templates need to be fixed locally… [19:47:13] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf7] Empty Add Template dialog appearing upon trying to open an existing template from a page - 10https://bugzilla.wikimedia.org/72719 (10James Forrester) [19:47:56] 3VisualEditor / 3Editing Tools: VisualEditor: Tables drop their class when pasted in IE11 - 10https://bugzilla.wikimedia.org/72599 (10James Forrester) [19:58:03] mooeypoo: try listening to mousemove on the document [19:58:09] line 186 https://github.com/collabkit/future/blob/master/brie/lib/client/ux.gridList/ux.gridList.js [19:58:24] * mooeypoo nods [19:58:26] TrevorParscal, I do [19:58:30] hmm [19:58:36] han gon I think I know why this happens [19:58:54] then yeah, it's because you are supposed to be listening to dragover events instead [19:58:59] line 202 [19:59:36] meh. [19:59:46] But then dragover doesn't have pageX and pageY [19:59:51] * mooeypoo reverts to the first problem again [20:00:00] well, it does in originalEvent [20:00:12] 3OOjs: OOjs: v8 warns it won't optimize oo.Factory.create or oo.EventEmitter.emit - 10https://bugzilla.wikimedia.org/72933#c1 (10Roan Kattouw) For oo.Factory.create, my version of Chrome tells me "Not optimized: Bad value context for arguments value" which seems to be a consequence of doing args = Array.protot... [20:00:12] * mooeypoo beats Javascript into draggable submission [20:00:38] What I don't get is this -- *you* are using mousemove. [20:00:42] James_F, RoanKattouw: https://bugzilla.wikimedia.org/show_bug.cgi?id=72906 seems to be another OOjs UI LookupInputWidget issue.... [20:00:43] ... how are you using mousemove [20:01:01] MWCategoryWidget#onLookupMenuItemChoose isn't getting called when it should [20:01:22] (03PS2) 10Jforrester: Move most of ve.js to ve.utils.js [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170874 (owner: 10Catrope) [20:01:26] That's weird [20:01:55] (03CR) 10Jforrester: [C: 031] "PS2 fixes the documentation with a @class." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170874 (owner: 10Catrope) [20:06:58] RoanKattouw, or... maybe not. hm [20:08:48] $ make dependencies [20:08:50] svn checkout --force http://gyp.googlecode.com/svn/trunk build/gyp \ [20:08:51] --revision 1831 [20:08:53] make: svn: Command not found [20:08:56] gj Google [20:08:59] Way to go for using latest technology [20:13:23] Is this a known ♙-bug? https://pt.wikipedia.org/w/index.php?diff=40479873 [20:14:52] RoanKattouw, so I think this is the case where we know the category the user typed is already there [20:15:10] but we ignore this because it's the last category there, no point saying 'move... to the current location' [20:15:13] so no menu entry [20:15:30] so when you press enter, no choose event [20:15:54] But... it still goes in? hmm [20:17:50] Helder: A "♙-bug" is a browser hiccup during pawning. They're endlessly unreproducible. :-( But we're removing pawning so in future it won't recurr. [20:19:51] RoanKattouw, why are we handling enter events separately in the category widget, bypassing the lookup menu? If I kill that code, enter still works to select lookup items (MenuWidget handles it) [20:20:02] and the bug is gone too... [20:20:18] wtf? We're handling enter separately? [20:20:20] * RoanKattouw looks [20:20:43] We are. WTF [20:21:28] Krenair: Old code, I think. [20:21:37] ... Did I write this...? [20:21:46] Krenair: Perhaps. :-) [20:22:52] James_F: so, no need to report on bugzilla? [20:23:16] I wonder why it recently broke though [20:23:25] 718db58f modules/ve/ui/widgets/ve.ui.MWCategoryWidget.js (Trevor Parscal 2013-04-29 14:01:56 -0700 91) ve.ui.MWCategoryWidget.prototype.onLookupInputKeyDown = function ( e ) { [20:23:30] 3VisualEditor / 3Editing Tools: VisualEditor: Style invalid MWTitleInputWidgets? - 10https://bugzilla.wikimedia.org/72970 (10Roan Kattouw) 3NEW p:3Unprio s:3normal a:3None Should we style MWTitleInputWidgets with invalid contents with a red border, like we do in some other places? [20:23:31] Helder: Probably not worth it. [20:23:40] ok [20:24:28] There was https://gerrit.wikimedia.org/r/#/c/166135/ but that should have been fine... [20:24:43] 3VisualEditor / 3Editing Tools: VisualEditor: Handle invalid input for redirect title in meta dialog - 10https://bugzilla.wikimedia.org/72971 (10Roan Kattouw) 3NEW p:3Unprio s:3normal a:3None If someone puts an invalid title in the redirect field in the meta dialog (like "Talk:" or something with a p... [20:26:11] (03PS1) 10SuchetaG: Removing text-shadow from readonly/disabled text in TextInputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/171030 (https://bugzilla.wikimedia.org/63840) [20:27:07] (03CR) 10Catrope: [C: 04-1] Removing text-shadow from readonly/disabled text in TextInputWidget (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/171030 (https://bugzilla.wikimedia.org/63840) (owner: 10SuchetaG) [20:27:16] nope, that doesn't appear to have caused the issue. . . [20:28:08] ... ignore that last message. Wtf? [20:34:09] RoanKattouw, so this code seems to be no longer needed. And is just breaking things. [20:34:21] Yup [20:34:31] (03PS3) 10Catrope: Move most of ve.js to ve.utils.js [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170874 [20:34:31] I recommend killing it [20:34:35] If that appears to have no ill side effects [20:34:38] I'll upload a commit to simply remove it [20:34:57] 3VisualEditor / 3Editing Tools: VisualEditor: “Uncaught Error: Unable to parse title” when entering "Talk:" as a template - 10https://bugzilla.wikimedia.org/71998#c7 (10etonkovidova) Fixed for validating template titles - verified in betalabs FF [20:36:22] (03PS2) 10SuchetaG: Removing text-shadow from readonly/disabled text in TextInputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/171030 (https://bugzilla.wikimedia.org/63840) [20:36:45] (03CR) 10Catrope: [C: 032] Removing text-shadow from readonly/disabled text in TextInputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/171030 (https://bugzilla.wikimedia.org/63840) (owner: 10SuchetaG) [20:37:11] 3OOjs UI: OOjs UI: Selected text in readonly/disabled TextInputWidget is hard to read on Chrome on Linux - 10https://bugzilla.wikimedia.org/63840 (10James Forrester) 5PATC>3RESO/FIX [20:37:17] (03PS1) 10Alex Monk: Kill MWCategoryWidget#onLookupEnter [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/171033 (https://bugzilla.wikimedia.org/72906) [20:39:52] (03Merged) 10jenkins-bot: Removing text-shadow from readonly/disabled text in TextInputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/171030 (https://bugzilla.wikimedia.org/63840) (owner: 10SuchetaG) [21:02:14] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf7] The down arrow to bring up the context menu for Categories is not center-aligned, again - 10https://bugzilla.wikimedia.org/72962 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Low [21:06:59] 3VisualEditor / 3ContentEditable: VisualEditor: Tables - using keyboard to move cursor throws "TypeError: surfaceView.getNativeRangeBoundingClientRect is not a function" - 10https://bugzilla.wikimedia.org/72978 (10etonkovidova) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce: 1. In VE insert a... [21:10:56] 3VisualEditor / 3ContentEditable: VisualEditor: Tables - using keyboard to move cursor throws "TypeError: surfaceView.getNativeRangeBoundingClientRect is not a function" - 10https://bugzilla.wikimedia.org/72978#c1 (10Alex Monk) Can't reproduce in beta... [21:11:56] 3VisualEditor / 3ContentEditable: VisualEditor: Tables - using keyboard to move cursor throws "TypeError: surfaceView.getNativeRangeBoundingClientRect is not a function" - 10https://bugzilla.wikimedia.org/72978#c2 (10Alex Monk) Oh, around in the cell itself, not to move to different cells. Sorry. [21:15:45] (03PS1) 10Alex Monk: Add missing message docs for ooui-dialog-process-continue [oojs/ui] - 10https://gerrit.wikimedia.org/r/171043 [21:25:48] James_F: Do you recall problem with performance in template dialog? [21:26:13] In our version it seems extremely slow when there is a lot of params (>50) - it's not because of the API call, but because of the ParameterPages [21:40:14] InezK: I have heard of this problem [21:40:21] As in, someone told me about it at a reception at Wikimania [21:44:27] 3VisualEditor: VisualEditor: Cannot enable or disable formatting of lines starting with semicolon markup - 10https://bugzilla.wikimedia.org/71721#c1 (10etonkovidova) In 'Edit source' - adding ; in front of a word makes a block displayed in bold in VE You cannot un-bold it in VE.
<... [21:46:51] TrevorParscal: https://www.mediawiki.org/w/index.php?title=OOjs%2FInheritance&diff=1251833&oldid=1090807 [22:00:04] (03CR) 10Trevor Parscal: [C: 04-1] "Just a couple of small nags, otherwise gtg." (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170907 (owner: 10Esanders) [22:01:30] (03CR) 10Trevor Parscal: [C: 032] [BREAKING CHANGE] Move selection restrictions from tools to commands [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170712 (owner: 10Esanders) [22:01:49] TrevorParscal: Did you mean to +2? [22:01:59] oops [22:02:01] lol [22:02:08] um [22:02:10] * James_F sighs. :-) [22:02:11] yes, I did [22:02:20] I thought you meant I accidentally -2 [22:02:24] Ha. OK. [22:02:25] dude, that change is gtg [22:02:35] looking at the followup in ve [22:04:35] (03CR) 10Jforrester: "Hmm. How did banana linter let it through?" [oojs/ui] - 10https://gerrit.wikimedia.org/r/171043 (owner: 10Alex Monk) [22:04:37] (03Merged) 10jenkins-bot: [BREAKING CHANGE] Move selection restrictions from tools to commands [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170712 (owner: 10Esanders) [22:05:35] James_F: am I safe to merge the vemw follow up now that the ve patch is in? [22:05:41] this one: https://gerrit.wikimedia.org/r/#/c/170711/ [22:06:58] (03CR) 10Trevor Parscal: "Good to go after pull through of I957a798" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170711 (owner: 10Esanders) [22:11:46] (03PS4) 10Jforrester: Update VE core submodule to master (a942301) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170711 (owner: 10Esanders) [22:12:22] (03CR) 10Jforrester: [C: 032] "Per Trevor." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170711 (owner: 10Esanders) [22:13:51] (03Merged) 10jenkins-bot: Update VE core submodule to master (a942301) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170711 (owner: 10Esanders) [22:14:55] (03PS5) 10Jforrester: Blur contentEditable node while destroying surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/144089 (https://bugzilla.wikimedia.org/71852) (owner: 10Inez) [22:15:11] (03CR) 10Jforrester: "PS5 is a rebase and fix to the commit message." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/144089 (https://bugzilla.wikimedia.org/71852) (owner: 10Inez) [22:21:06] (03PS2) 10Jforrester: Revert "Add SVG versions of toolbar icons" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/168821 (https://bugzilla.wikimedia.org/35342) (owner: 10TheDJ) [22:21:19] James_F, looked at TemplateData param types again. [22:21:27] (03CR) 10Jforrester: [C: 032] "Let's land this for now for damage avoidance, and then we'll fix up the icons and try again in the follow-ups." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/168821 (https://bugzilla.wikimedia.org/35342) (owner: 10TheDJ) [22:21:31] (03Merged) 10jenkins-bot: Revert "Add SVG versions of toolbar icons" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/168821 (https://bugzilla.wikimedia.org/35342) (owner: 10TheDJ) [22:21:48] for boolean perhaps we could use ToggleButtonWidget? would need to find a reasonable label... [22:22:26] 3VisualEditor: VisualEditor: line height in intro message is wrong causes collusions - 10https://bugzilla.wikimedia.org/72964#c2 (10Andre Klapper) ...and in general, steps to reproduce (which site is this about?) are welcome. [22:24:25] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf3] In Firefox, Cursor is appearing in Read mode at the end of the document after saving a page and after discarding the current edit in Firefox - 10https://bugzilla.wikimedia.org/71852#c8 (10James Forrester) Still fixed, we're just moving it to a b... [22:25:20] (03CR) 10Jforrester: [C: 032] Add missing message docs for ooui-dialog-process-continue [oojs/ui] - 10https://gerrit.wikimedia.org/r/171043 (owner: 10Alex Monk) [22:27:40] (03Merged) 10jenkins-bot: Add missing message docs for ooui-dialog-process-continue [oojs/ui] - 10https://gerrit.wikimedia.org/r/171043 (owner: 10Alex Monk) [22:29:51] TrevorParscal: https://gerrit.wikimedia.org/r/171006 [22:30:30] (03CR) 10Trevor Parscal: [C: 032] Populate LookupInputWidget on mousedown too [oojs/ui] - 10https://gerrit.wikimedia.org/r/171006 (https://bugzilla.wikimedia.org/72959) (owner: 10Catrope) [22:30:41] (03PS7) 10Cmcmahon: [BrowserTest] WIP adding cases to test other options under Page Settings to options.feature [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169251 (owner: 10Ryasmeen) [22:31:11] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf7] Link Suggestions are not appearing on placing the cursor inside it - 10https://bugzilla.wikimedia.org/72959 (10James Forrester) 5PATC>3RESO/FIX [22:31:16] what do you think, James_F? [22:31:39] Krenair: So… yeah, I've been neglecting getting back to you on that. [22:32:08] Krenair: Part of the issue is that the types are informative, not normative. They shouldn't /force/ you to do the right thing, just make it easier, IYSWIM. [22:32:25] Krenair: But I'm not sure how we should show that. [22:32:27] Ah. [22:32:47] (03Merged) 10jenkins-bot: Populate LookupInputWidget on mousedown too [oojs/ui] - 10https://gerrit.wikimedia.org/r/171006 (https://bugzilla.wikimedia.org/72959) (owner: 10Catrope) [22:32:49] Maybe an "override" checkbox which shows a wikitext entry box if people insist? [22:33:03] And if the current value is "wrong" for some reason, picking the right value… [22:33:08] Eh. [22:33:47] E.g. parameter type is boolean, so values are "true" and "false"; current value is "yes" – should that be shown as an enabled toggle widget (how?) or something else? [22:36:51] that's what I had in mind, yes [22:37:15] oh, "yes" instead of "true"... [22:42:09] Yeah. [22:42:26] Or an enum with values "one", "two", "more" having a value of "fish". [22:43:09] (03Abandoned) 10Jforrester: Localisation updates from https://translatewiki.net. [oojs/ui] - 10https://gerrit.wikimedia.org/r/171104 (owner: 10L10n-bot) [22:43:36] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (b38d485723) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/171143 [22:44:01] Krenair: Could I grab a quick +2 on https://gerrit.wikimedia.org/r/#/q/Ie55491851f7509295fdddbc5229bab2a32e83e8e,n,z ? [22:44:17] (03CR) 10Trevor Parscal: [C: 032] Style mediawiki theme checkbox [oojs/ui] - 10https://gerrit.wikimedia.org/r/170893 (owner: 10Prtksxna) [22:45:25] (03CR) 10Alex Monk: [C: 032] Update OOjs UI to v0.1.0-pre (b38d485723) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/171143 (owner: 10Jforrester) [22:45:49] Krenair: Thanks. :-) [22:47:24] (03Merged) 10jenkins-bot: Style mediawiki theme checkbox [oojs/ui] - 10https://gerrit.wikimedia.org/r/170893 (owner: 10Prtksxna) [22:47:26] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (b38d485723) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/171143 (owner: 10Jforrester) [22:50:16] (03PS6) 10Alex Monk: Use MWTitleInputWidget for wiki-page-name parameters, add MWUserInputWidget for wiki-user-name [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169936 (https://bugzilla.wikimedia.org/53613) [22:53:32] aaaaaaaaaa. [22:53:33] That is all. [22:54:32] * mooeypoo is going to get something sweet and non draggable [22:58:35] (03PS8) 10Ryasmeen: [BrowserTest] WIP adding cases to test other options under Page Settings to options.feature [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169251 [23:00:28] 3VisualEditor / 3ContentEditable: VisualEditor: Tables - multiple colspan and rowspan are not displayed correctly - 10https://bugzilla.wikimedia.org/72790#c3 (10etonkovidova) Basically a table's cells cannot be unmerged via Table menu when multiple merge actions have been applied. Applying un-merge action re... [23:02:00] (03PS9) 10Ryasmeen: [BrowserTest] WIP adding cases to test other options under Page Settings to options.feature [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169251 [23:03:22] (03CR) 10Cmcmahon: [C: 032] "paired with Rummana. cleaned up one assertion, created a second assertion, refactored for Background" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169251 (owner: 10Ryasmeen) [23:04:42] (03Merged) 10jenkins-bot: [BrowserTest] WIP adding cases to test other options under Page Settings to options.feature [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169251 (owner: 10Ryasmeen) [23:07:29] 3VisualEditor / 3ContentEditable: VisualEditor: Tables - using keyboard to move cursor throws "TypeError: surfaceView.getNativeRangeBoundingClientRect is not a function" - 10https://bugzilla.wikimedia.org/72978 (10Rummana Yasmeen) [23:07:30] 3VisualEditor / 3Editing Tools: VisualEditor: Support tables (tracking) - 10https://bugzilla.wikimedia.org/39596 (10Rummana Yasmeen) [23:07:43] hey James_F let me know when youre free! [23:11:42] 3VisualEditor / 3ContentEditable: Visual Editor: Tables - saved tables look much smaller than in VE and display grayish background - 10https://bugzilla.wikimedia.org/72784 (10James Forrester) [23:11:42] 3VisualEditor / 3Editing Tools: VisualEditor: Tables drop their class when pasted in IE11 - 10https://bugzilla.wikimedia.org/72599 (10James Forrester) [23:11:48] 3VisualEditor / 3Editing Tools: VisualEditor: Support tables (tracking) - 10https://bugzilla.wikimedia.org/39596 (10James Forrester) [23:11:48] 3VisualEditor / 3ContentEditable: VisualEditor: Tables - multiple colspan and rowspan are not displayed correctly - 10https://bugzilla.wikimedia.org/72790 (10James Forrester) [23:11:48] 3VisualEditor / 3Editing Tools: VisualEditor: When the cursor is active inside a content cell , cannot insert any additional row or column to the table (or should we disable the row/column operator while user is inside a content cell?) - 10https://bugzilla.wikimedia.org/72803 (10James Forrester) [23:11:48] 3VisualEditor / 3Editing Tools: VisualEditor: Regular context menu trying to render on TableSelections - 10https://bugzilla.wikimedia.org/72802 (10James Forrester) [23:12:09] 3VisualEditor / 3ContentEditable: VisualEditor: Overwriting the text inside a cell does not retain the text format applied to that cell previously - 10https://bugzilla.wikimedia.org/72831 (10James Forrester) [23:12:09] 3VisualEditor / 3ContentEditable: VisualEditor: Pressing tab inside a cell when the cursor is active should taking it to the next cell, not to beginning of the document - 10https://bugzilla.wikimedia.org/72823 (10James Forrester) [23:12:09] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf7] Disable "Bold" from text styling control if the cursor is in a table header cell where MediaWiki's "wikitable" class or similar is used for that styling effect - 10https://bugzilla.wikimedia.org/72949 (10James Forrester) [23:12:09] 3VisualEditor / 3Mobile: VisualEditor: editing tables in Mobile - Edit mode displays broken tables - 10https://bugzilla.wikimedia.org/72819 (10James Forrester) [23:12:10] 3VisualEditor / 3ContentEditable: VisualEditor: Tables - when editing content cell a blue cell border does not expand - 10https://bugzilla.wikimedia.org/72836 (10James Forrester) [23:12:11] 3VisualEditor / 3Editing Tools: VisualEditor:After adding a focusable node inside a content cell , placing cursor at the end of the table scrolls the page down - 10https://bugzilla.wikimedia.org/72804 (10James Forrester) [23:12:12] 3VisualEditor / 3ContentEditable: VisualEditor: Tables - adding formatted headings to displays Uncaught TypeError - 10https://bugzilla.wikimedia.org/72816 (10James Forrester) [23:12:13] 3VisualEditor / 3ContentEditable: VisualEditor: Applying text formatting to empty cell does not format the text entered afterwards - 10https://bugzilla.wikimedia.org/72825 (10James Forrester) [23:12:14] 3VisualEditor / 3Editing Tools: VisualEditor: IME selector shows up at the bottom-right corner of the table while selecting a cell on a table or placing a cursor into it - 10https://bugzilla.wikimedia.org/72824 (10James Forrester) [23:12:15] 3VisualEditor / 3Editing Tools: VisualEditor: After saving, the order of the texts gets reversed while adding some content in a slug created inside the caption field of a table - 10https://bugzilla.wikimedia.org/72833 (10James Forrester) [23:12:16] 3VisualEditor / 3ContentEditable: VisualEditor: Tables - using keyboard to move cursor throws "TypeError: surfaceView.getNativeRangeBoundingClientRect is not a function" - 10https://bugzilla.wikimedia.org/72978 (10James Forrester) [23:14:39] (03CR) 10Jforrester: "… but still marked WIP. :-)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169251 (owner: 10Ryasmeen) [23:17:56] 3VisualEditor / 3Editing Tools: VisualEditor: Style texts when selected with Language inspector open, turns the drop-down selection blank. - 10https://bugzilla.wikimedia.org/70451#c6 (10James Forrester) 5UNCO>3RESO/WOR Per submitter. [23:18:26] RoanKattouw_away: You were going to look at https://bugzilla.wikimedia.org/show_bug.cgi?id=72962 and https://gerrit.wikimedia.org/r/#/c/144089/ [23:26:13] 3VisualEditor / 3ContentEditable: VisualEditor: Tables - applying headings format to table cells will split the table - 10https://bugzilla.wikimedia.org/72990 (10etonkovidova) 3NEW p:3Unprio s:3normal a:3None Created attachment 17022 --> https://bugzilla.wikimedia.org/attachment.cgi?id=17022&action... [23:29:40] (03PS1) 10Catrope: Add the RangeFix library to VisualEditor.php [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/171150 [23:30:21] (03CR) 10Jforrester: [C: 032] Add the RangeFix library to VisualEditor.php [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/171150 (owner: 10Catrope) [23:31:17] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/144089/ [23:31:51] (03Merged) 10jenkins-bot: Add the RangeFix library to VisualEditor.php [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/171150 (owner: 10Catrope) [23:58:54] James_F: do you know which is the best channel to talk about mw-ui? [23:59:45] (03PS1) 10Alex Monk: [WIP] Show non-editable parts of pages in their normal places [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/171155 (https://bugzilla.wikimedia.org/56289)