[00:00:54] (03PS2) 10Esanders: Generic progress dialog for drag and drop uploads [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/171770 [00:27:25] 3VisualEditor / 3ContentEditable: VisualEditor: Drag-and-drop an inserted image slices a table - 10https://bugzilla.wikimedia.org/72995#c3 (10etonkovidova) Created attachment 17066 --> https://bugzilla.wikimedia.org/attachment.cgi?id=17066&action=edit Dragging images to table I added a screen recording -... [00:46:46] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf7] The cursor stays active on CE even after opening the dialog for Basic Reference/Citation/Reference list/Page Settings - 10https://bugzilla.wikimedia.org/73097#c6 (10Rummana Yasmeen) 5RESO/FIX>3REOP This is still happening for all other dialo... [00:47:04] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf7] The cursor stays active on CE even after opening the dialog for Basic Reference/Citation/Reference list/Page Settings - 10https://bugzilla.wikimedia.org/73097 (10Rummana Yasmeen) 5REOP>3ASSI [00:53:47] 3VisualEditor / 3ContentEditable: VisualEditor: [Regression] Can't cut or (sometimes) paste in multiple browsers - 10https://bugzilla.wikimedia.org/72164#c10 (10etonkovidova) 5RESO/?>3VERI Re-verified in Chrome, FF, IE11, and Safari - cut/copy/paste look fine. [01:04:26] (03PS1) 10Jforrester: Update VE core submodule to master (bb67705) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/171785 [02:14:41] 3VisualEditor / 3MediaWiki integration: VisualEditor: After saving a page, the FlaggedRevs notice "1 change in this version is pending review ..." is not shown - 10https://bugzilla.wikimedia.org/60718#c1 (10Alex Monk) I took a look into this today... Seems that the review notice is not being made available e... [05:23:13] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (bb67705) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/171785 (owner: 10Jforrester) [05:24:41] (03Merged) 10jenkins-bot: Update VE core submodule to master (bb67705) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/171785 (owner: 10Jforrester) [11:47:39] (03PS4) 10Mvolz: [WIP] Adds GET endpoint /api, takes URL & DOI [services/citoid] - 10https://gerrit.wikimedia.org/r/169690 [11:58:28] 3MediaWiki / 3ResourceLoader: Rights icon doesn't appear when $wgResourceBasePath is used - 10https://bugzilla.wikimedia.org/73031 (10Andre Klapper) p:5Unprio>3Low [12:40:04] (03PS1) 10Esanders: Show the modal overlay as soon as openWindow is called [oojs/ui] - 10https://gerrit.wikimedia.org/r/171823 [13:20:47] Hmm. What should be the behaviour of the citoid extension/ve when the templatedata is wrong... [13:21:17] should try to work around it as gracefully as possible I suppose [13:21:38] if most users got an error about templatedata issues it wouldn't really help them much. [13:22:02] the problem is then there's actually no place those errors show up [13:22:14] because we can't validate it TD side because it depends on the service itself [13:22:53] the only place we can know anything about the service itself is in the user script/ve that is using the service... [13:23:36] maybe I can use the debug=true flag to show service related TD errors? [13:24:51] edsanders: do you know where the debug=true stuff lives in VE? does that seem a reasonable approach? [13:26:54] it passes through to ve.debug [13:27:43] nb running debug=true on the live site is very slow (downloading 100+ js/css assets from the server) [13:33:15] hmm [13:34:37] maybe have it as a warning? and then hopefully someone would fix it soon so not too many people get freaked out? :) [13:34:59] it will be mostly be the case where the equivalent template data is the wrong type for the service [13:35:20] i.e. the service is giving an array but TD is telling us it's a string [13:37:00] i.e. if I try to insert an array as a parameter instead of a string VE is *very* unhappy but I might just pick the 0th element of the array if that's a string as a fall back for that kind of thing or something. [13:37:33] briefly thought about recursively picking the 0th element of an infinitely nested Array but then decided that was a hilarious but bad idea and better to actually insert nothing in that case :) [13:38:14] [[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[["muahahaha"]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]] [13:54:57] 3VisualEditor / 3Editing Tools: Unable to delete empty parametrs in templates - 10https://bugzilla.wikimedia.org/73134 (10Manuel) 3UNCO p:3Unprio s:3normal a:3None When I click on the "Bin" icon to delete an empty parameter from a template, the system doesn't delete it. [13:57:10] 3VisualEditor / 3Editing Tools: Unable to delete parametrs in templates - 10https://bugzilla.wikimedia.org/73134 (10Manuel) [13:57:26] 3VisualEditor / 3Editing Tools: Unable to delete parameters in templates - 10https://bugzilla.wikimedia.org/73134 (10Manuel) [14:04:10] 3VisualEditor / 3Editing Tools: Unable to delete parameters in templates - 10https://bugzilla.wikimedia.org/73134#c1 (10mvolz) I'm unable to duplicate this on master. I tried emptying the field and then deleting it, which worked. I also tried adding an empty field in wikitext, saving, and then opening it up... [14:14:10] 3VisualEditor / 3Editing Tools: Unable to delete parameters in templates - 10https://bugzilla.wikimedia.org/73134#c2 (10Manuel) I tried to delete the field on [https://it.wikipedia.org/wiki/Atletica_leggera_ai_Giochi_della_XXV_Olimpiade_-_100_metri_ostacoli this page] with Chrome and Firefox, but I couldn't... [14:25:41] 3VisualEditor / 3Editing Tools: Unable to delete parameters in templates - 10https://bugzilla.wikimedia.org/73134#c3 (10mvolz) Ok, on both of those templates I was able to delete the missing fields while using Chrome on Ubuntu. You could try opening up the javascript console in Chrome (Ctrl+Shift+J) and se... [14:29:39] 3VisualEditor / 3Editing Tools: Unable to delete parameters in templates - 10https://bugzilla.wikimedia.org/73134#c4 (10Manuel) I got no error. [15:44:47] (03PS1) 10Esanders: Support pre's in tables [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/171835 (https://bugzilla.wikimedia.org/73100) [15:46:03] (03PS1) 10Cmcmahon: [BrowserTest] update Ruby gems for se-webdriver 2.44 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/171836 [15:47:55] (03PS2) 10Zfilipin: [BrowserTest] Update RubyGems to get the latest version of Selenium [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/171836 (owner: 10Cmcmahon) [15:48:33] (03CR) 10Zfilipin: [C: 032] [BrowserTest] Update RubyGems to get the latest version of Selenium [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/171836 (owner: 10Cmcmahon) [15:50:30] (03Merged) 10jenkins-bot: [BrowserTest] Update RubyGems to get the latest version of Selenium [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/171836 (owner: 10Cmcmahon) [16:06:51] (03CR) 10Esanders: "FIXME: When you open the template dialog (insert -> template) the input is no longer focused because of this." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170280 (https://bugzilla.wikimedia.org/72789) (owner: 10Catrope) [16:08:12] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression] Template dialog no longer takes focus on load - 10https://bugzilla.wikimedia.org/73138 (10Ed Sanders) 3NEW p:3Unprio s:3normal a:3None This is due to the fix applied in https://gerrit.wikimedia.org/r/#/c/170280/ [16:27:40] 3MediaWiki / 3Page editing: On article creation in mainspace, please alert editors about existing articles in draft namespace - 10https://bugzilla.wikimedia.org/73132 (10Andre Klapper) p:5Unprio>3Low s:5normal>3enhanc [16:30:28] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=108897582 [16:30:29] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=108908950 [16:30:29] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=108909076 [16:30:29] Corruption alert: visualeditor-needcheck on napwiki: https://nap.wikipedia.org/?diff=636979 [16:31:46] (03PS45) 10Paladox: WikiEditor: Fix issue with SVG [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151611 (https://bugzilla.wikimedia.org/35342) [17:03:25] TrevorP|Away: status update on mediawiki/core integration of OOjsUI/PHP? [17:14:19] (03PS3) 10Mvolz: [WIP] Use TempateData to insert citations [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/168746 [17:15:10] (03PS5) 10Mvolz: [WIP] Adds GET endpoint /api, takes URL & DOI [services/citoid] - 10https://gerrit.wikimedia.org/r/169690 [17:18:46] (03CR) 10Mvolz: "FYI all three use cases- string, array, and 2d array- are now in use (I changed the citoid service so that ISBN and ISSN are arrays since " [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167389 (owner: 10Mvolz) [17:28:23] (03PS1) 10Esanders: Remove and restore selection for non-isolated dialogs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/171852 (https://bugzilla.wikimedia.org/73097) [17:35:57] 3VisualEditor / 3ContentEditable: VisualEditor: inserting Media displays "Uncaught TypeError: undefined is not a function " - 10https://bugzilla.wikimedia.org/73141 (10etonkovidova) 3NEW p:3Unprio s:3normal a:3None In test2 and production(betalabs does not display the error). In VE, open any page fo... [17:38:27] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression wmf3] Wikitext warning not showing up anymore? - 10https://bugzilla.wikimedia.org/72475#c7 (10etonkovidova) 5RESO/?>3VERI Verified in production, betalabs, and test2. [17:54:49] (03CR) 10Catrope: [C: 032] Support pre's in tables [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/171835 (https://bugzilla.wikimedia.org/73100) (owner: 10Esanders) [17:55:40] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression wmf7] Template dialog no longer takes focus on load - 10https://bugzilla.wikimedia.org/73138 (10Roan Kattouw) [17:56:12] (03Merged) 10jenkins-bot: Support pre's in tables [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/171835 (https://bugzilla.wikimedia.org/73100) (owner: 10Esanders) [17:56:26] 3VisualEditor / 3ContentEditable: VisualEditor: Display the contextual menu for templates much more visibly - 10https://bugzilla.wikimedia.org/50854#c3 (10etonkovidova) 5RESO/?>3VERI Confirmed the fix in production - the templates' contextual menu is displayed either on the far right of the screen or at... [17:58:06] (03CR) 10Catrope: [C: 032] Remove and restore selection for non-isolated dialogs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/171852 (https://bugzilla.wikimedia.org/73097) (owner: 10Esanders) [17:58:25] (03CR) 10Catrope: "Awesome. This code is going to make unisolating inspectors much easier." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/171852 (https://bugzilla.wikimedia.org/73097) (owner: 10Esanders) [17:59:57] (03Merged) 10jenkins-bot: Remove and restore selection for non-isolated dialogs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/171852 (https://bugzilla.wikimedia.org/73097) (owner: 10Esanders) [18:00:27] 3VisualEditor / 3ContentEditable: VisualEditor: inserting Media displays "Uncaught TypeError: undefined is not a function " - 10https://bugzilla.wikimedia.org/73141#c1 (10Roan Kattouw) Works fine for me in production (enwiki), test2 and beta labs. [18:31:42] TrevorP|Away: I want VE-core's spinner.gif (31x31) in 16x16 and 24x24 versions. [18:32:08] edsanders: Feel like doing three quick bold/italics icons? [18:44:40] 3MediaWiki / 3Page editing: First line in edit window is sometimes hidden in Safari - 10https://bugzilla.wikimedia.org/71909#c1 (10Elitre) Actually, I just had this again in Chrome, while trying to update https://meta.wikimedia.org/wiki/VisualEditor/Newsletter/Sandbox :( [18:45:44] Krinkle: want to talk about CSSMin::encodeImageAsDataURI()? can we kill the $sizeLimit parameter and replace it with $ie8Compat=true? [18:46:43] MatmaRex: I'll check it out in a minute. What would the impact be? [18:47:10] probably none, i doubt anyone uses that method [18:50:11] 3VisualEditor / 3Editing Tools: Unable to delete parameters in templates - 10https://bugzilla.wikimedia.org/73134#c5 (10etonkovidova) Could not confirm - tried both mentioned links - [https://it.wikipedia.org/wiki/Atletica_leggera_ai_Giochi_della_XXV_Olimpiade_-_100_metri_ostacoli] and[https://it.wikipedia.o... [18:52:53] (03PS2) 10Catrope: Show the modal overlay as soon as openWindow is called [oojs/ui] - 10https://gerrit.wikimedia.org/r/171823 (https://bugzilla.wikimedia.org/68669) (owner: 10Esanders) [18:53:22] TrevorParscal: https://gerrit.wikimedia.org/r/#/c/171823/ [18:56:10] 3VisualEditor / 3Editing Tools: Unable to delete parameters in templates - 10https://bugzilla.wikimedia.org/73134#c6 (10Elitre) Can confirm in Chrome and FF. What happens is that clicking on the bin makes the field disappear in the dialog, but when you save it's still in the template, as if you hadn't change... [18:56:25] 3VisualEditor / 3Editing Tools: Unable to delete parameters in templates - 10https://bugzilla.wikimedia.org/73134 (10Elitre) 5UNCO>3NEW [19:02:00] RoanKattouw: what time are you and Sucheta meeting? [19:02:07] (03CR) 10Trevor Parscal: [C: 032] Show the modal overlay as soon as openWindow is called [oojs/ui] - 10https://gerrit.wikimedia.org/r/171823 (https://bugzilla.wikimedia.org/68669) (owner: 10Esanders) [19:02:12] I just sent you an invite [19:02:12] kaity, 3:30 [19:02:18] Trevor, Sucheta and I are meeting at 3 [19:02:20] oh nvm I just got your invite! [19:02:25] But you have a 3-3:30 meeting with Abbey [19:02:48] So I figured we would do the tech braindumping part 3-3:30 and the brainstorming part 3:30-4 [19:02:57] sounds good [19:03:08] Sorry, subtract an hour from everything I just said [19:03:14] So 2-2:30 and 2:30-3 [19:03:30] * RoanKattouw isn't mathing well today [19:04:03] haha got it [19:05:07] (03Merged) 10jenkins-bot: Show the modal overlay as soon as openWindow is called [oojs/ui] - 10https://gerrit.wikimedia.org/r/171823 (https://bugzilla.wikimedia.org/68669) (owner: 10Esanders) [19:08:13] 3VisualEditor / 3Initialisation: VisualEditor:Editing and saving a page , then pressing back browser button takes to previously saved page. - 10https://bugzilla.wikimedia.org/71917#c4 (10etonkovidova) 5RESO/?>3VERI Re-checked it in test2 and betalabs - seems to be working fine. [19:10:21] James_F, language icons? send them over [19:10:46] James_F, I'm trying to deprecate spinner.gif in favour of an indeterminate progress bar where possible [19:11:14] edsanders: Maybe don't do that in init init though? [19:11:22] Because then we'd have to make a bunch of OOUI stuff part of the initial payload [19:11:33] (OTOH I guess MW core is moving in the direction where that'll be happening anyway) [19:11:43] RoanKattouw, yeah - I have a patch ready for that day [19:11:58] edsanders: Doing so. [19:19:20] hmmm. [19:19:45] i just realized that we don't embed SVG images greater than 32K in CSS, even though we technically could freely do it. [19:22:04] yeah, so how close are we on that? [19:22:19] like, do we have any SVG files that are approaching that size after base64 encoding? [19:22:28] or is that so far off that we need not worry? [19:22:46] and, of course we should decide what the behavior is if that limit is reached [19:23:55] The largest icon in Apex, for instance is 1090 bytes (advanced.svg) [19:24:47] That grows to 1457 bytes after base64 encoding [19:24:56] no, nothing approaches that limit [19:25:02] yeah, we are WAY under [19:25:03] nothing in core at least [19:25:06] so, I'm not worried [19:25:18] there's that massive world map in ULS that used to be way over it, but i think it was nerfed ;) [19:25:53] just an observation, Krinkle|detached made me do https://gerrit.wikimedia.org/r/171880 and it catched my eye [19:25:59] when somebody makes an SVG icon that reaches 32k after base64 encoding, I think that will be a sign they are doing something wrong [19:26:43] MatmaRex: Oh finally. That potential issue has bothered me for a while but I kept forgetting to do something about it [19:26:48] you can usually simplify paths a lot without noticable degradation when rendering at smaller sizes [19:26:58] (checking post-expansion URI length rather than pre-expansion data length) [19:28:37] I have a path simplification algorithm I wrote based on calculating the surface area of triangles made by consecutive points and removing the mid point when it's under a given threshold - if I ran that on that map I bet I could get it down really small without the map looking much different at all [19:29:07] TrevorParscal: :o [19:29:17] i just press Ctrl+L in Inkscape :D [19:30:40] (03CR) 10Catrope: [C: 04-1] Refactor SurfaceObserver pollOnceInternal (036 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166188 (owner: 10Divec) [19:32:03] Yeah, that algorithm is a based on density (afaik) and has some issues, also they are using a catmull-rom conversion to re-smooth the shape after simplification which kills details [19:32:15] in any case [19:32:38] (03PS1) 10Catrope: Remove and restore selection for non-isolated dialogs [VisualEditor/VisualEditor] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/171882 (https://bugzilla.wikimedia.org/73097) [19:33:11] 3VisualEditor: Adding items to lists sometimes generates spurious line feeds - 10https://bugzilla.wikimedia.org/72479#c1 (10etonkovidova) Created attachment 17073 --> https://bugzilla.wikimedia.org/attachment.cgi?id=17073&action=edit Tab and newline symbols displayed [19:33:14] TrevorParscal: it amuses me that you can control th "granularity" of that simplification using zoom percentage [19:33:21] i can't tell if that's a bug or feature [19:33:53] (the more you zoom in, the less it simplifies) [19:36:13] I think we are safe, but if you just add a check that the data size isn't too large, something like if ( ceil( bytes / 3 ) * 4 > 32768 ) { /* OMG? WTF! */ } [19:36:39] I think we will be fine [19:38:41] TrevorParscal, quick question -- something's wrong with my "removeItem()" (it doesn't remove the item) *but* I'm also thinking that I shouldn't use removeItem and addItems() at all in this case... the removeItem method leaves the item existing for reattachment *but* they both go through unhooking and rehooking the events [19:38:50] in this case it doesn't seem to be necessary, I just ned to switch them around [19:39:30] (03PS1) 10Jforrester: Apex, MediaWiki themes: Drop explicit width and height attributes [oojs/ui] - 10https://gerrit.wikimedia.org/r/171884 [19:39:47] my initial idea was simply to switch data and labels between them -- but that's not as generalized. So I can just work directly with the "this.items" array and rarrange it, not going through any event handling (aggregation/de-aggregation etc) [19:39:56] TrevorParscal, you think that is okay to do or am I missing something? [19:40:56] just go through a simple reorder-array method with the existing items seems to be the most straight forward non-wasteful way to me [19:44:33] TrevorParscal, also (I'm aggregating questions for you :D ) -- another potential issue with making this a mixin is that it *must* be paired with the drag items. We can have two mixins (the items don't actually have to be OptionWidgets, but the bigger parent widget must be extending the GroupElement mixin) -- but is that okay? A mixin that must go with another? If so, is there a good way of documenting that? @musthave or something? [19:49:10] 3VisualEditor / 3ContentEditable: VisualEditor: inserting Media displays "Uncaught TypeError: undefined is not a function " - 10https://bugzilla.wikimedia.org/73141#c2 (10Roan Kattouw) Elena showed me that if you open the media dialog on a new page after typing some text and going to a new paragraph, the usu... [19:49:25] 3VisualEditor / 3ContentEditable: VisualEditor: Insert media dialog appears to immediately abort request - 10https://bugzilla.wikimedia.org/73141 (10Roan Kattouw) 5NEW>3ASSI [19:52:40] mooeypoo: reading.... [19:53:38] mooeypoo: so... [19:53:55] 3VisualEditor / 3ContentEditable: VisualEditor: Insert media dialog appears to immediately abort request - 10https://bugzilla.wikimedia.org/73141#c3 (10Moriel Schottlender) (In reply to Roan Kattouw from comment #2) > Elena showed me that if you open the media dialog on a new page after typing > some text an... [19:53:59] first off, if you've found a bug in GroupElement, maybe you could write a really simple test case and I will fix it [19:54:08] * mooeypoo nods [19:54:23] second, don't remove and insert, just insert at a given offset, it will move the item for you [19:54:35] TrevorParscal, but I need to remove the dragged item [19:54:46] and insert it in a new location [19:54:52] right [19:54:53] I do that [19:54:58] addItems handles the removal for you [19:55:01] oh [19:55:12] are you saying you need a gap in time between removal and add? [19:55:24] oh it does? Ahh. Okay, that might explain things. I went 'removeItem( item ) -> addItems( [item], index) [19:55:28] because if not, just insert (like you would with DOM nodes, they can't be in 2 places at the same time) [19:55:49] I don't want a gap. The item we dragged needs to be in 1 place in the list -- the new place. [19:56:03] It needs to be removed from its old place. That's why I thought 'removeItem()' first and then addItems [19:56:05] additems will notice the item is already in the group, remove it first, adjust the index, then insert it [19:56:09] Gotcha [19:56:13] I missed that. [19:56:25] remember, once you remove it, the index may change (if it's being moved to a greater index than originally) [19:56:35] aye I have a 'correct the index' method [19:56:39] which apparently I don't need :D [19:58:28] 3VisualEditor / 3ContentEditable: VisualEditor: IE11- inserting a link with a shortcut(Cmd+K) opens and closes the link inspector momentarily - 10https://bugzilla.wikimedia.org/73154 (10etonkovidova) 3NEW p:3Unprio s:3normal a:3None Splitting the bug from 72392. Open a page in VE and insert a link... [19:59:42] lol [19:59:44] 3VisualEditor / 3ContentEditable: VisualEditor: IE11- inserting a link with a shortcut(Cmd+K) opens and closes the link inspector momentarily - 10https://bugzilla.wikimedia.org/73154#c1 (10Roan Kattouw) Wait, the link inspector actually closes? I thought it was just the error... [20:00:31] hee! it works! [20:09:41] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression] Link inspector closes itself immediately in Internet Explorer - 10https://bugzilla.wikimedia.org/72392#c10 (10etonkovidova) 5RESO/?>3VERI The previous comment was filed as a separate bug: 73154 Besides bug 73154 - the fix re-verified in betalbs/... [21:03:25] Krinkle|detached: you 'round? [21:09:07] (03PS1) 10Esanders: Bold & italic icons for Armenian [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/171906 [21:47:59] hm [21:50:10] TrevorP|Away, when I add a file to ooui src do I need to do something to add it to the 'grunt build' task? I can't see anything in the gruntfile so I assumed it goes by folder, but my file isn't included in the oojs-ui.js file after I run "grunt build" [21:50:18] * mooeypoo is trying to test her mixins [21:50:25] and prepare a commit for ooui [21:52:07] ah! build/modules.json [21:52:21] (03PS3) 10Esanders: Generic progress dialog for drag and drop uploads [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/171770 [22:31:40] 3VisualEditor / 3Editing Tools: VisualEditor: Matching pages list in link dialog should support right-click / ctrl+click to open page in a new window/tab - 10https://bugzilla.wikimedia.org/51205#c7 (10etonkovidova) The fix is verified in betalabs(beware of a difference between Link and Simple link!). The fix... [23:08:40] 3VisualEditor: Unreadable input box text with dark colour schemes - 10https://bugzilla.wikimedia.org/72848#c1 (10etonkovidova) Is it duplicate to 72192? Tried it with Chrome(Mac) and with 'Cite web' template - it's not reproducible. [23:20:25] 3VisualEditor / 3MediaWiki integration: VisualEditor: Create a meta dialog panel for setting page status indicators - 10https://bugzilla.wikimedia.org/72199#c1 (10Ed Sanders) PSI's can contain arbitrary wikitext so ideally their contents would be editable in a SurfaceWidget, however I suspect in most situati... [23:43:41] 3VisualEditor / 3Editing Tools: VisualEditor: Sub-heading 4 font, does not match with the other heading style fonts, in Monobook - 10https://bugzilla.wikimedia.org/70559#c1 (10etonkovidova) Created attachment 17076 --> https://bugzilla.wikimedia.org/attachment.cgi?id=17076&action=edit monobook Sub-heading... [23:44:55] 3VisualEditor / 3Editing Tools: VisualEditor: Sub-heading 4 font, does not match with the other heading style fonts, in Monobook - 10https://bugzilla.wikimedia.org/70559#c2 (10etonkovidova) Confirmed - Sub-headings(started with Sub-heading 1) are decreasing proportionally like this: 130, 115, 100(for Sub-hea... [23:54:40] 3VisualEditor / 3Editing Tools: VisualEditor: Sub-heading 4 font, does not match with the other heading style fonts, in Monobook - 10https://bugzilla.wikimedia.org/70559 (10etonkovidova) 5UNCO>3NEW