[00:08:27] 3MediaWiki extensions / 3WikiEditor: [Regression] ext.wikiEditor.toolbar.hideSig.js stopped working - 10https://bugzilla.wikimedia.org/40972#c9 (10George Orwell III) Regression - a return to a former or less developed state. bug 28149 was the report that set off the changes that first introduced the hideSig... [01:09:56] 3VisualEditor / 3Editing Tools: VisualEditor: Allowing creation of empty caption moves the column editing icon at the top of the empty space which looks odd - 10https://bugzilla.wikimedia.org/72829#c1 (10Bartosz Dziewoński) (In reply to Rummana Yasmeen from comment #0) > 3.Save the page > 4.Now select any ce... [01:12:27] 3VisualEditor / 3ContentEditable: VisualEditor: handling preformatted text in tables - 10https://bugzilla.wikimedia.org/73100#c3 (10Bartosz Dziewoński) 5PATC>3RESO/FIX a:3Ed Sanders Definitely fixed, I ran into this in prod today, wanted to file a bug and couldn't reproduce on master. Now I know why. :) [01:15:28] 3VisualEditor / 3Editing Tools: VisualEditor: "Insert table" tool should be (also?) in the "Table" menu, not (or in addition to?) "Insert" menu - 10https://bugzilla.wikimedia.org/73212 (10Bartosz Dziewoński) 3NEW p:3Unprio s:3normal a:3None VisualEditor: "Insert table" tool should be (also?) in the "... [01:21:16] 3VisualEditor: VisualEditor: Removing table row where rowspanned cell starts un-merges the remaining spanned cells - 10https://bugzilla.wikimedia.org/73213 (10Bartosz Dziewoński) 3NEW p:3Unprio s:3normal a:3None Removing the table row where rowspanned cell starts un-merges the remaining spanned cells.... [01:38:56] 3VisualEditor / 3Editing Tools: VisualEditor: "Insert table" tool should be (also?) in the "Table" menu, not (or in addition to?) "Insert" menu - 10https://bugzilla.wikimedia.org/73212#c1 (10Tar Lócesilion) +1. When user wants to create a new table, he can see the icon in the toolbar, but it's marked as disp... [01:56:12] wow [01:56:24] there is a CSS property caption-side, that does exactly what you think it does [01:56:38] but more curiously, it has at least twelve valid values [01:56:57] modern browsers seem to implement somewhere between 2 and 6 [02:01:58] 3VisualEditor / 3Editing Tools: VisualEditor: Allowing creation of empty caption moves the column editing icon at the top of the empty space which looks odd - 10https://bugzilla.wikimedia.org/72829#c2 (10Bartosz Dziewoński) To the unfortunate soul tasked with resolving this: there exists a CSS 'caption-side'... [02:36:54] (03PS1) 10Bartosz Dziewoński: TableNode, TableContext: Position row/column overlays better when caption is present [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172191 (https://bugzilla.wikimedia.org/72829) [02:38:42] 3VisualEditor / 3Editing Tools: VisualEditor: Allowing creation of empty caption moves the column editing icon at the top of the empty space which looks odd - 10https://bugzilla.wikimedia.org/72829#c4 (10Bartosz Dziewoński) p:5Unprio>3Normal a:3Bartosz Dziewoński (In reply to Bartosz Dziewoński from co... [02:40:19] edsanders|away: i am in love with your table manipulation code, i didn't expect that this can be done so neatly [03:22:05] (03PS1) 10Bartosz Dziewoński: [WIP] Don't un-merge spanned cells when spanned cell is removed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172193 (https://bugzilla.wikimedia.org/73213) [03:23:11] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Don't un-merge spanned cells when spanned cell is removed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172193 (https://bugzilla.wikimedia.org/73213) (owner: 10Bartosz Dziewoński) [03:27:30] (03PS2) 10Bartosz Dziewoński: [WIP] Don't un-merge spanned cells when spanned cell is removed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172193 (https://bugzilla.wikimedia.org/73213) [04:00:21] (03PS3) 10Bartosz Dziewoński: Don't unmerge spanned cells when spanned cell is removed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172193 (https://bugzilla.wikimedia.org/73213) [04:00:24] (03CR) 10jenkins-bot: [V: 04-1] Don't unmerge spanned cells when spanned cell is removed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172193 (https://bugzilla.wikimedia.org/73213) (owner: 10Bartosz Dziewoński) [04:03:38] (03PS4) 10Bartosz Dziewoński: Don't unmerge spanned cells when spanned cell is removed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172193 (https://bugzilla.wikimedia.org/73213) [04:06:36] (03PS2) 10Bartosz Dziewoński: TableNode: Position row/column overlays better when caption is present [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172191 (https://bugzilla.wikimedia.org/72829) [05:26:38] RoanKattouw: Hey, Do you know how can I insert content into article and metadata (meta placeholder) at the same time? [05:26:48] So it is a one transaction - and one item in the undo stack [07:52:41] 3VisualEditor: VisualEditor: Annotation on top of a link produces inefficient wikitext ([[asd|''asd'']]) - 10https://bugzilla.wikimedia.org/73201#c1 (10Elitre) bug 50098 ? [08:10:40] 3VisualEditor / 3Editing Tools: VisualEditor: "Insert table" tool should be (also?) in the "Table" menu, not (or in addition to?) "Insert" menu - 10https://bugzilla.wikimedia.org/73212#c2 (10Elitre) The current option is highly temporary, AFAIK. [08:43:28] 3VisualEditor: VisualEditor: Tables wikitext can be inconsistent - 10https://bugzilla.wikimedia.org/73215 (10Elitre) 3NEW p:3Unprio s:3normal a:3None In wikitext editor, you can separate cells with a double bar "||" on the same line : |Cell 1 || Cell 2 || Cell 3 (same thing for headers, except two ex... [09:02:02] (03CR) 10Esanders: [C: 04-1] TableNode: Position row/column overlays better when caption is present (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172191 (https://bugzilla.wikimedia.org/72829) (owner: 10Bartosz Dziewoński) [09:05:13] 3VisualEditor: VisualEditor: Can't delete text... which is actually not there - 10https://bugzilla.wikimedia.org/73216 (10Elitre) 3NEW p:3Unprio s:3normal a:3None User added the words "La mui" to https://fr.wikipedia.org/wiki/Audiomachine#Utilisations_de_leurs_musiques . Then proceeded to edit elsewher... [09:33:28] * James_F waves. [09:34:04] (03CR) 10Jforrester: [C: 032] Match 'color' rules to 'background-color' rules for accessibility [oojs/ui] - 10https://gerrit.wikimedia.org/r/172174 (https://bugzilla.wikimedia.org/72848) (owner: 10Bartosz Dziewoński) [09:34:41] 3OOjs UI: OOjs UI: Unreadable input box text with dark colour schemes - 10https://bugzilla.wikimedia.org/72848 (10James Forrester) 5PATC>3RESO/FIX [09:36:16] (03Merged) 10jenkins-bot: Match 'color' rules to 'background-color' rules for accessibility [oojs/ui] - 10https://gerrit.wikimedia.org/r/172174 (https://bugzilla.wikimedia.org/72848) (owner: 10Bartosz Dziewoński) [10:16:55] 3VisualEditor / 3ContentEditable: VisualEditor: handling preformatted text in tables - 10https://bugzilla.wikimedia.org/73100 (10James Forrester) p:5Unprio>3Normal [10:22:11] (03Abandoned) 10Zfilipin: [BrowserTest] Fix language screenshots [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/170026 (owner: 10Zfilipin) [10:51:25] (03CR) 10Zfilipin: [C: 04-1] "In general, the commit looks good to me. Voting -1 because RuboCop is complaining. Let me know if you need help with fixing the problem." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/171531 (https://bugzilla.wikimedia.org/73033) (owner: 10Vikassy) [10:58:57] (03PS3) 10Vikassy: [BrowserTest] Fixed failing language screenshot browser tests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/171531 (https://bugzilla.wikimedia.org/73033) [11:02:28] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression wmf7] Template dialog no longer takes focus on load - 10https://bugzilla.wikimedia.org/73138 (10James Forrester) 5PATC>3RESO/FIX p:5Unprio>3High a:3Roan Kattouw [11:03:06] (03PS4) 10Vikassy: [BrowserTest] Fixed failing language screenshot browser tests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/171531 (https://bugzilla.wikimedia.org/73033) [11:04:25] 3VisualEditor / 3Editing Tools: VisualEditor: Link, Formula and Text Styles etc. should be disabled when focus is inside the comment editor - 10https://bugzilla.wikimedia.org/70343 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Low [11:07:50] (03PS5) 10Vikassy: [BrowserTest] Fixed failing language screenshot browser tests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/171531 (https://bugzilla.wikimedia.org/73033) [11:13:40] 3OOjs UI: OOjs UI: Windows have no visual loading state - 10https://bugzilla.wikimedia.org/68669 (10James Forrester) 5PATC>3RESO/FIX [11:14:39] (03CR) 10Jforrester: [C: 032] Remove and restore selection for non-isolated dialogs [VisualEditor/VisualEditor] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/171882 (https://bugzilla.wikimedia.org/73097) (owner: 10Catrope) [11:15:27] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf7] The cursor stays active on CE even after opening the dialog for Basic Reference/Citation/Reference list/Page Settings - 10https://bugzilla.wikimedia.org/73097 (10James Forrester) 5PATC>3RESO/FIX [11:16:38] (03Merged) 10jenkins-bot: Remove and restore selection for non-isolated dialogs [VisualEditor/VisualEditor] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/171882 (https://bugzilla.wikimedia.org/73097) (owner: 10Catrope) [11:17:25] 3VisualEditor / 3Data Model: VisualEditor: Ordered application of annotations to avoid fragmentation (e.g. ''[[Foo|Fo]]''[[Foo|o]]) - 10https://bugzilla.wikimedia.org/50098#c12 (10James Forrester) *** Bug 73201 has been marked as a duplicate of this bug. *** [11:17:26] 3VisualEditor: VisualEditor: Annotation on top of a link produces inefficient wikitext ([[asd|''asd'']]) - 10https://bugzilla.wikimedia.org/73201#c2 (10James Forrester) 5NEW>3RESO/DUP Yeah, merging with bug 50098. *** This bug has been marked as a duplicate of bug 50098 *** [11:17:36] (03CR) 10Esanders: [C: 04-1] Don't unmerge spanned cells when spanned cell is removed (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172193 (https://bugzilla.wikimedia.org/73213) (owner: 10Bartosz Dziewoński) [11:18:26] 3VisualEditor / 3Data Model: VisualEditor: Ordered application of annotations to avoid fragmentation (e.g. ''[[Foo|Fo]]''[[Foo|o]]) - 10https://bugzilla.wikimedia.org/50098 (10James Forrester) [11:18:26] 3VisualEditor / 3Data Model: VisualEditor: Link annotations can be split into two adjacent ones when other annotations overlap - 10https://bugzilla.wikimedia.org/73202#c2 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Low This is essentially also a duplicate of bug 50098; marking as a subsidiary though in... [11:19:33] (03CR) 10Esanders: "Everything else seems to work well." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172193 (https://bugzilla.wikimedia.org/73213) (owner: 10Bartosz Dziewoński) [11:20:25] 3VisualEditor: VisualEditor: Tables wikitext can be inconsistent - 10https://bugzilla.wikimedia.org/73215#c1 (10James Forrester) 5NEW>3RESO/DUP Merging into bug 63356; ideally we'd want Parsoid to use inline or per-line syntax per precedent in the context, which sounds messy. *** This bug has been marked... [11:22:40] 3VisualEditor / 3Editing Tools: VisualEditor: Insert media dialog appears to immediately abort request - 10https://bugzilla.wikimedia.org/73141 (10James Forrester) p:5Unprio>3Lowest s:5normal>3trivia [11:36:52] (03PS1) 10Jforrester: spinner.gif: Update with new version from Trevor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172217 [11:40:55] 3VisualEditor / 3MediaWiki integration: VisualEditor: Sub-heading 4 font, does not match with the other heading style fonts, in Monobook - 10https://bugzilla.wikimedia.org/70559 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Low [11:53:56] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression ?wmf6] Deleted template parameters aren't actually deleted - 10https://bugzilla.wikimedia.org/73134#c7 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High s:5normal>3major a:3Roan Kattouw Did we break something when we re-wrote the template p... [12:14:29] (03CR) 10Esanders: [C: 04-1] [WIP] Use TempateData to insert citations (0311 comments) [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/168746 (owner: 10Mvolz) [12:27:27] 3VisualEditor: VisualEditor: Removing table row where rowspanned cell starts un-merges the remaining spanned cells - 10https://bugzilla.wikimedia.org/73213 (10Bartosz Dziewoński) a:3Bartosz Dziewoński [12:33:34] (03CR) 10Esanders: TableNode: Position row/column overlays better when caption is present (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172191 (https://bugzilla.wikimedia.org/72829) (owner: 10Bartosz Dziewoński) [12:38:52] (03PS1) 10Esanders: Position the table context relative to the first section node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172225 (https://bugzilla.wikimedia.org/72829) [12:39:21] (03CR) 10Esanders: [C: 04-2] "I3d790d71 is probably a better approach. Abandon if that is merged." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172191 (https://bugzilla.wikimedia.org/72829) (owner: 10Bartosz Dziewoński) [12:39:53] edsanders: Want to build a context in the top-left too, whilst you're at it? :-) [12:40:42] I haven't see any designs [12:41:09] We've discussed it out loud a few times. Want me to mock it up for you? [12:41:28] I remember thinking it was a bad idea [12:41:40] it would have to be tiny to fit [12:42:04] whereas the toolbar menu is more obvious [12:42:12] Same size as the column and row controls. [12:42:15] Hardly tiny. [12:44:24] those expand to the width/height of the selection so are usually 8x20+. This would be 8x8 [12:44:57] 11x11. [12:44:59] they are also visually tied to the col/row, this would be in the corner and wouldn't necessarily be obviously a 'whole table' control [12:45:07] With the current selection size. [12:45:51] in every other editor you have to go to the toolbar to do merge cells [12:46:00] (or right click, but mobile) [12:46:05] Let's not be merely as bad as them. [12:50:42] 3VisualEditor / 3Data Model: VisualEditor: Support discontiguous table selections - 10https://bugzilla.wikimedia.org/73217 (10Ed Sanders) 3NEW p:3Unprio s:3normal a:3None We currently sort of support this is that row/col deletion skips over merged cells, but the user should probably be able to create... [12:52:10] 3VisualEditor / 3Data Model: VisualEditor: Support discontiguous table selections - 10https://bugzilla.wikimedia.org/73217 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal s:5normal>3enhanc [12:52:17] edsanders: Do you think we should support discontinuous non-table selections too? [12:53:56] (03PS1) 10Jforrester: Update VE core submodule to master (bc4355a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/172229 [12:54:18] (03PS2) 10Jforrester: Update VE core submodule to master (bc4355a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/172229 [12:55:31] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (bc4355a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/172229 (owner: 10Jforrester) [12:57:07] (03PS5) 10Jforrester: Update VE core submodule to master (bc4355a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/171498 (owner: 10Catrope) [12:57:14] I think it's hard [12:57:23] (03Abandoned) 10Jforrester: Update VE core submodule to master (bc4355a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/172229 (owner: 10Jforrester) [12:57:43] edsanders: I agree. I'm inclined to ignore this issue for a year or so. :-) [13:02:06] (03PS5) 10Jforrester: Add instrumentation for edit schema [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/171499 (owner: 10Catrope) [13:02:37] (03CR) 10Jforrester: [C: 032] Update VE core submodule to master (bc4355a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/171498 (owner: 10Catrope) [13:04:01] (03Merged) 10jenkins-bot: Update VE core submodule to master (bc4355a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/171498 (owner: 10Catrope) [13:04:30] (03PS2) 10Jforrester: All themes: Drop SVGs' explicit width and height attributes [oojs/ui] - 10https://gerrit.wikimedia.org/r/171884 [13:04:38] edsanders: Want to merge https://gerrit.wikimedia.org/r/#/c/171884/ ? [13:05:23] (03CR) 10Zfilipin: [C: 032] "The commit fixed the build:" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/171531 (https://bugzilla.wikimedia.org/73033) (owner: 10Vikassy) [13:06:49] (03Merged) 10jenkins-bot: [BrowserTest] Fixed failing language screenshot browser tests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/171531 (https://bugzilla.wikimedia.org/73033) (owner: 10Vikassy) [13:13:15] Have you tested the SVGs in IE [13:13:21] and with different base font sizes [13:13:43] I know IE has problems with SVG sizes [13:18:37] I don't have IE around, sorry. Trevor was of the belief that this was a no-brainer change, but… good question. [13:50:00] (03CR) 10Esanders: "Should be tested in IE versions which "support" SVG as they have known issues with natural size." [oojs/ui] - 10https://gerrit.wikimedia.org/r/171884 (owner: 10Jforrester) [13:51:28] 3VisualEditor / 3ContentEditable: VisualEditor:[Regression]Add text and a space before language annotation, then delete space, text looses language style - 10https://bugzilla.wikimedia.org/73218 (10Ritu Swain) 3UNCO p:3Unprio s:3normal a:3None Enviornment-test2, beta 1> Select language and click don... [13:56:38] (03PS1) 10Vikassy: Auto corrected rubocop errors [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/172245 [13:57:31] (03PS2) 10Vikassy: [BrowserTest] Auto corrected rubocop errors [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/172245 [14:06:01] (03CR) 10Jforrester: [C: 032] .theme-oo-ui-textInputWidget cleanup [oojs/ui] - 10https://gerrit.wikimedia.org/r/172177 (owner: 10Bartosz Dziewoński) [14:08:03] (03Merged) 10jenkins-bot: .theme-oo-ui-textInputWidget cleanup [oojs/ui] - 10https://gerrit.wikimedia.org/r/172177 (owner: 10Bartosz Dziewoński) [14:15:39] (03PS1) 10Esanders: Fix logic for ignoring (col|row)span=1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172246 [14:17:47] James_F|Away, https://bugzilla.wikimedia.org/show_bug.cgi?id=73212 ? [14:21:05] (03CR) 10Zfilipin: [C: 04-1] "You have forgot to include .rubocop_todo.yml file in the commit. See how the commit should look like" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/172245 (owner: 10Vikassy) [14:25:34] (03PS5) 10Bartosz Dziewoński: Don't unmerge spanned cells when spanned cell is removed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172193 (https://bugzilla.wikimedia.org/73213) [14:25:43] (03CR) 10Bartosz Dziewoński: Don't unmerge spanned cells when spanned cell is removed (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172193 (https://bugzilla.wikimedia.org/73213) (owner: 10Bartosz Dziewoński) [14:27:19] (03PS6) 10Bartosz Dziewoński: Don't unmerge spanned cells when spanned cell is removed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172193 (https://bugzilla.wikimedia.org/73213) [14:37:53] (03CR) 10Bartosz Dziewoński: TableNode: Position row/column overlays better when caption is present (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172191 (https://bugzilla.wikimedia.org/72829) (owner: 10Bartosz Dziewoński) [14:44:55] 3VisualEditor / 3ContentEditable: VisualEditor:[Regression]Add text and a space before language annotation, then delete space, text looses language style - 10https://bugzilla.wikimedia.org/73218#c1 (10Ritu Swain) http://youtu.be/qzzJDdPJGQY [14:50:25] 3VisualEditor / 3ContentEditable: VisualEditor:[Regression]Add text and a space before language annotation, then delete space, text looses language style - 10https://bugzilla.wikimedia.org/73218#c2 (10Ritu Swain) Also found in FF 33.1. [14:52:27] 3VisualEditor: VisualEditor: Merging cells across table sections causes some cells to disappear - 10https://bugzilla.wikimedia.org/73222 (10Bartosz Dziewoński) 3NEW p:3Unprio s:3minor a:3None HTML: ... [14:55:29] 3VisualEditor: VisualEditor: "Uncaught TypeError: Cannot read property 'getRange' of undefined" when unmerging cells - 10https://bugzilla.wikimedia.org/73223 (10Bartosz Dziewoński) 3NEW p:3Unprio s:3normal a:3None I get "Uncaught TypeError: Cannot read property 'getRange' of undefined" when unmerging c... [14:56:25] (03PS1) 10Esanders: Make caption tool available when caption selected [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172249 [14:56:45] (03Abandoned) 10Bartosz Dziewoński: TableNode: Position row/column overlays better when caption is present [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172191 (https://bugzilla.wikimedia.org/72829) (owner: 10Bartosz Dziewoński) [15:09:14] (03PS1) 10Bartosz Dziewoński: TableContext: Simplify row/column overlays styles [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172250 [15:09:36] (03CR) 10Bartosz Dziewoński: "Submitted CSS changes separately as https://gerrit.wikimedia.org/r/172250 , I think they're still worthwhile." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172191 (https://bugzilla.wikimedia.org/72829) (owner: 10Bartosz Dziewoński) [15:13:21] (03PS2) 10Bartosz Dziewoński: TableContext: Simplify row/column overlays styles [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172250 [15:13:57] 3VisualEditor / 3Editing Tools: VisualEditor:[Regression wmf7] Uncaught TypeError: Cannot read property 'nodeType' of undefined ,on deleting the content in the Gallery inspector and clicking done - 10https://bugzilla.wikimedia.org/73224 (10Ritu Swain) 3UNCO p:3Unprio s:3normal a:3None Created attachm... [15:14:10] 3VisualEditor / 3Editing Tools: VisualEditor:[Regression wmf7] Uncaught TypeError: Cannot read property 'nodeType' of undefined , on deleting the content in the Gallery inspector and clicking done - 10https://bugzilla.wikimedia.org/73224 (10Ritu Swain) [16:22:20] (03PS3) 10Vikassy: [BrowserTest] Fixed Style/CommentAnnotation RuboCop offense [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/172245 (https://bugzilla.wikimedia.org/63307) [16:22:44] 3VisualEditor / 3Editing Tools: VisualEditor: Annotations can conflict with local CSS rules, e.g. bold text in headings - 10https://bugzilla.wikimedia.org/72949#c3 (10Bartosz Dziewoński) (In reply to Ed Sanders from comment #2) > but with our WYSIWYG editor, there's no visual cue for 'double bold'. CSS has... [16:25:41] 3VisualEditor / 3Editing Tools: VisualEditor:[Regression wmf7] Uncaught TypeError: Cannot read property 'nodeType' of undefined , on deleting the content in the Gallery inspector and clicking done - 10https://bugzilla.wikimedia.org/73224#c1 (10etonkovidova) 5UNCO>3NEW Confirmed - the error displayed in... [16:26:31] (03PS4) 10Vikassy: [BrowserTest] Fixed Style/CommentAnnotation RuboCop offense [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/172245 (https://bugzilla.wikimedia.org/63307) [16:28:47] (03CR) 10Zfilipin: [C: 04-1] "Please abandon this commit, make a topic branch and submit one commit per offense fixed. Let me know if you need help with that." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/172245 (https://bugzilla.wikimedia.org/63307) (owner: 10Vikassy) [16:30:56] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=109005674 [16:30:57] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=33246801 [16:30:57] Corruption alert: visualeditor-needcheck on ukwiki: https://uk.wikipedia.org/?diff=15112222 [16:30:57] Corruption alert: visualeditor-needcheck on ukwiki: https://uk.wikipedia.org/?diff=15112585 [16:30:57] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=66697043 [16:30:57] Corruption alert: visualeditor-needcheck on dewiki: https://de.wikipedia.org/?diff=135675084 [16:30:57] Corruption alert: visualeditor-needcheck on dewiki: https://de.wikipedia.org/?diff=135675192 [16:30:58] 3VisualEditor / 3Editing Tools: VisualEditor:[Regression wmf7] Inserting media, while Gallery inspector is open, makes the cursor active in the main editor - 10https://bugzilla.wikimedia.org/73226 (10Ritu Swain) 3UNCO p:3Unprio s:3normal a:3None Environment- test2, beta 1> Select to insert a gallery... [16:35:10] 3VisualEditor / 3Editing Tools: VisualEditor:[Regression wmf7] Inserting media, while Gallery inspector is open, makes the cursor active in the main editor - 10https://bugzilla.wikimedia.org/73226#c1 (10Ritu Swain) http://youtu.be/m6BeEEnrKtc . Also found in FF 33.1. [16:43:12] 3VisualEditor / 3Editing Tools: Insert above/below more than 1 column/row - 10https://bugzilla.wikimedia.org/73227 (10Tar Lócesilion) 3UNCO p:3Unprio s:3normal a:3None The number of columns/rows added above/below should be the same as number of selected ones, not necessarily always 1. [16:46:58] 3VisualEditor / 3Editing Tools: "Merge cells" option should be in context menu, not (or in addition to?) the toolbar - 10https://bugzilla.wikimedia.org/73228 (10Tar Lócesilion) 3UNCO p:3Unprio s:3normal a:3None I think it'd be easier. Options in context menu should be related to individual cells when... [16:47:25] 3VisualEditor / 3Editing Tools: VisualEditor: "Merge cells" option should be in context menu, not (or in addition to?) the toolbar - 10https://bugzilla.wikimedia.org/73228 (10Tar Lócesilion) [16:47:55] 3VisualEditor / 3Editing Tools: VisualEditor: Insert above/below more than 1 column/row - 10https://bugzilla.wikimedia.org/73227 (10Tar Lócesilion) [17:06:26] 3VisualEditor / 3Editing Tools: VisualEditor:[Regression wmf7] Inserting media, while Gallery inspector is open, makes the cursor active in the main editor - 10https://bugzilla.wikimedia.org/73226#c2 (10etonkovidova) 5UNCO>3NEW Confirmed - an inserted Gallery should be the first element on a page to dis... [17:14:35] (03PS1) 10Esanders: Move disabling logic from tools to commands [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172277 [17:16:31] (03CR) 10jenkins-bot: [V: 04-1] Move disabling logic from tools to commands [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172277 (owner: 10Esanders) [17:21:40] 3VisualEditor: VisualEditor: "Uncaught TypeError: Cannot read property 'getRange' of undefined" when unmerging cells - 10https://bugzilla.wikimedia.org/73223#c1 (10etonkovidova) I can merge all cells but cannot un-merge them. Uncaught TypeError: Cannot read property 'isPlaceholder' of null Note: Undo - Cmd... [17:24:39] (03PS1) 10Esanders: Move disabling logic from tools to commands [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/172281 [17:25:33] (03PS1) 10Esanders: New command files in core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/172282 [17:26:19] (03CR) 10jenkins-bot: [V: 04-1] Move disabling logic from tools to commands [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/172281 (owner: 10Esanders) [17:26:41] (03CR) 10jenkins-bot: [V: 04-1] New command files in core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/172282 (owner: 10Esanders) [17:34:17] (03PS2) 10Esanders: Move disabling logic from tools to commands [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172277 [17:35:01] (03PS2) 10Esanders: New command files in core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/172282 [17:36:09] (03CR) 10jenkins-bot: [V: 04-1] New command files in core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/172282 (owner: 10Esanders) [17:36:17] (03CR) 10jenkins-bot: [V: 04-1] Move disabling logic from tools to commands [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172277 (owner: 10Esanders) [17:40:27] 3VisualEditor / 3Editing Tools: VisualEditor:[Regression wmf7] Invalid characters as gallery caption, creates an empty node. - 10https://bugzilla.wikimedia.org/73230 (10Ritu Swain) 3UNCO p:3Unprio s:3normal a:3None Created attachment 17085 --> https://bugzilla.wikimedia.org/attachment.cgi?id=17085&... [17:41:10] 3VisualEditor / 3Editing Tools: VisualEditor:[Regression wmf7] Invalid characters as gallery caption, creates an empty node. - 10https://bugzilla.wikimedia.org/73230#c1 (10Ritu Swain) Also found in FF 33.1. [17:47:32] James_F, https://bugzilla.wikimedia.org/show_bug.cgi?id=73212 ? [17:49:52] (03PS3) 10Esanders: Move disabling logic from tools to commands [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172277 [17:51:01] (03PS2) 10Esanders: Move disabling logic from tools to commands [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/172281 [17:52:26] (03CR) 10jenkins-bot: [V: 04-1] Move disabling logic from tools to commands [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/172281 (owner: 10Esanders) [17:52:52] edsanders: Yes? [17:53:28] 3VisualEditor / 3Editing Tools: VisualEditor: "Insert table" tool should be (also?) in the "Table" menu, not (or in addition to?) "Insert" menu - 10https://bugzilla.wikimedia.org/73212 (10James Forrester) 5NEW>3ASSI [17:53:28] 3VisualEditor / 3Editing Tools: VisualEditor: "Insert table" tool should be (also?) in the "Table" menu, not (or in addition to?) "Insert" menu - 10https://bugzilla.wikimedia.org/73212 (10James Forrester) p:5Unprio>3High s:5normal>3enhanc [17:53:28] Yes, you agree with them? [17:54:04] edsanders: Not with the proposed solution, but it is a pain point. [17:54:10] 3VisualEditor / 3Editing Tools: VisualEditor: "Insert table" tool should be (also?) in the "Table" menu, not (or in addition to?) "Insert" menu - 10https://bugzilla.wikimedia.org/73212#c3 (10James Forrester) Alternatively, we could put the table inspector in the proper place (i.e., on the table) rather than... [17:54:55] 3VisualEditor / 3Data Model: VisualEditor: Removing table row where rowspanned cell starts un-merges the remaining spanned cells - 10https://bugzilla.wikimedia.org/73213 (10James Forrester) p:5Unprio>3Normal [17:59:27] 3VisualEditor / 3Editing Tools: VisualEditor:[Regression wmf7] Inconsistent behavior in Chrome compared to FF, on applying a link or language annotation to a gallery. - 10https://bugzilla.wikimedia.org/73233 (10Ritu Swain) 3UNCO p:3Unprio s:3normal a:3None Environment- test2, beta Just like media f... [18:01:10] 3VisualEditor / 3Editing Tools: VisualEditor:[Regression wmf7] Inconsistent behavior in Chrome compared to FF, on applying a link or language annotation to a gallery. - 10https://bugzilla.wikimedia.org/73233 (10Ritu Swain) [18:02:26] 3VisualEditor / 3Editing Tools: VisualEditor:[Regression wmf7] Invalid characters as gallery caption, creates an empty node. - 10https://bugzilla.wikimedia.org/73230#c2 (10etonkovidova) 5UNCO>3NEW Confirmed. In addition to the scenario described abotve: If ">>" is entered - the gallery will be saved... [18:03:11] 3VisualEditor / 3Editing Tools: VisualEditor: Link icon stays selected but is not inserted, with language style text. - 10https://bugzilla.wikimedia.org/70562#c2 (10Ritu Swain) (In reply to etonkovidova from comment #1) > Checked in test2 on Chrome - cannot confirm. Not reproducible. close the issue. [18:18:12] 3VisualEditor / 3Editing Tools: VisualEditor:[Regression wmf7] Inconsistent behavior in Chrome compared to FF, on applying a link or language annotation to a gallery. - 10https://bugzilla.wikimedia.org/73233#c1 (10etonkovidova) 5UNCO>3NEW Confirmed - and as in bug 73226 - an inserted Gallery should be... [18:21:12] 3VisualEditor / 3Editing Tools: VisualEditor: Link icon stays selected but is not inserted, with language style text. - 10https://bugzilla.wikimedia.org/70562 (10etonkovidova) 5UNCO>3RESO/WOR [18:29:20] (03PS1) 10Jforrester: Fix craziness in template dialog focusing [extensions/VisualEditor] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/172298 (https://bugzilla.wikimedia.org/73138) [18:31:46] I've never been hung over, but the way people describe it sometimes, I'm like "you mean waking up?" [18:32:25] maybe that's just what happens when you have 3 kids, you are permanently hung over, every morning, for the next 20+ years [18:32:37] * MatmaRex hugs TrevorParscal [18:32:46] :) [18:33:23] I'm not saying not to have kids, but be sure you do it on deliberately :) [18:33:38] that's my life advice for now [18:33:39] heh [18:33:42] How's it going y'all? [18:38:10] (03CR) 10Catrope: [C: 04-1] "Still need to do abort events, but would appreciate review" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/171499 (owner: 10Catrope) [18:39:40] (03CR) 10Jforrester: [C: 04-1] "Per discussion. We need some way for people to enter non-standard values (so not just the options, but also "fish" or "{{echo|fish}}" or …" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169936 (https://bugzilla.wikimedia.org/53613) (owner: 10Alex Monk) [18:43:40] 3VisualEditor / 3ContentEditable: VisualEditor: Internal links should display the page's URL in the status bar on the browsers that do that - 10https://bugzilla.wikimedia.org/50646 (10James Forrester) [18:48:52] edsanders: Could you review https://gerrit.wikimedia.org/r/172193 and https://gerrit.wikimedia.org/r/172250, and think about better ways than full traversal to accomplish https://gerrit.wikimedia.org/r/149117 and https://gerrit.wikimedia.org/r/#/c/159006/ ? [18:50:50] (03CR) 10Esanders: [C: 032] Don't unmerge spanned cells when spanned cell is removed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172193 (https://bugzilla.wikimedia.org/73213) (owner: 10Bartosz Dziewoński) [18:51:40] 3VisualEditor / 3Data Model: VisualEditor: Removing table row where rowspanned cell starts un-merges the remaining spanned cells - 10https://bugzilla.wikimedia.org/73213 (10James Forrester) 5PATC>3RESO/FIX [18:53:19] (03CR) 10jenkins-bot: [V: 04-1] Don't unmerge spanned cells when spanned cell is removed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172193 (https://bugzilla.wikimedia.org/73213) (owner: 10Bartosz Dziewoński) [18:53:28] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression wmf7] Template dialog no longer takes focus on load - 10https://bugzilla.wikimedia.org/73138 (10James Forrester) 5PATC>3RESO/FIX [18:56:11] (03CR) 10Bartosz Dziewoński: [C: 032] "Lies" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172193 (https://bugzilla.wikimedia.org/73213) (owner: 10Bartosz Dziewoński) [18:56:25] (03CR) 10Bartosz Dziewoński: Don't unmerge spanned cells when spanned cell is removed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172193 (https://bugzilla.wikimedia.org/73213) (owner: 10Bartosz Dziewoński) [18:58:37] (03Merged) 10jenkins-bot: Don't unmerge spanned cells when spanned cell is removed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172193 (https://bugzilla.wikimedia.org/73213) (owner: 10Bartosz Dziewoński) [19:04:36] brb [19:08:25] (03CR) 10Esanders: [C: 032] TableContext: Simplify row/column overlays styles [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172250 (owner: 10Bartosz Dziewoński) [19:10:56] 3VisualEditor / 3ContentEditable: VisualEditor:[Regression]Add text and a space before language annotation, then delete space, text looses language style - 10https://bugzilla.wikimedia.org/73218#c3 (10etonkovidova) Confirmed. The scenario for the issue is actually simpler. 1. Select language and click do... [19:16:11] 3MediaWiki / 3ResourceLoader: CSSJanus fails to flip with !important - 10https://bugzilla.wikimedia.org/61440 (10Kunal Mehta (Legoktm)) [19:16:25] 3MediaWiki / 3ResourceLoader: CSSJanus only supports flipping one text-shadow or border-shadow in RTL languages while the CSS syntax allows multiple - 10https://bugzilla.wikimedia.org/60805 (10Kunal Mehta (Legoktm)) [19:24:14] RoanKattouw, is editing old versions broken? [19:26:52] Editing old versions of what? [19:27:13] https://fr.wikipedia.org/w/index.php?title=Audiomachine&oldid=108397229#Utilisations_de_leurs_musiques [19:27:27] not the contents of that paragraph (ends site officiel) [19:27:29] then edit [19:29:04] ostensibly the URL it generates in the address bar is wrong [19:29:48] if you do "open in new tab" to ensure you get the actual link contents (https://fr.wikipedia.org/w/index.php?title=Audiomachine&oldid=108397229&veaction=edit) then it works [19:29:50] Oooh [19:30:03] but if you just click you redirect to /wiki/PageName?veaction=edit [19:30:08] I know what broke this and why [19:30:10] I'll fix it [19:30:49] (03CR) 10Bartosz Dziewoński: [C: 032] Position the table context relative to the first section node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172225 (https://bugzilla.wikimedia.org/72829) (owner: 10Esanders) [19:33:42] 3VisualEditor / 3Editing Tools: VisualEditor:[Regression pre-wmf8] Button in Add a Template dialog is labeled as "Hide Options", instead of "Show Options" - 10https://bugzilla.wikimedia.org/73235 (10Ritu Swain) 3UNCO p:3Unprio s:3minor a:3None Created attachment 17086 --> https://bugzilla.wikimedia... [19:34:04] (03Merged) 10jenkins-bot: Position the table context relative to the first section node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172225 (https://bugzilla.wikimedia.org/72829) (owner: 10Esanders) [19:34:08] (03Merged) 10jenkins-bot: TableContext: Simplify row/column overlays styles [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172250 (owner: 10Bartosz Dziewoński) [19:34:26] 3VisualEditor / 3Editing Tools: VisualEditor:[Regression pre-wmf8] Button in Add a Template dialog is labeled as "Hide Options", instead of "Show Options" - 10https://bugzilla.wikimedia.org/73235 (10Ritu Swain) [19:35:25] 3VisualEditor: VisualEditor: Can't delete text... which is actually not there - 10https://bugzilla.wikimedia.org/73216#c1 (10Ed Sanders) Can't reproduce this. [19:45:40] 3VisualEditor / 3Editing Tools: VisualEditor:[Regression pre-wmf8] Button in Add a Template dialog is labeled as "Hide Options", instead of "Show Options" - 10https://bugzilla.wikimedia.org/73235#c1 (10etonkovidova) 5UNCO>3NEW Good finding! It's in betalabs only. test2 and production display 'Show opti... [19:46:41] 3VisualEditor / 3Editing Tools: VisualEditor:[Regression pre-wmf8] Button in Add a Template dialog is labeled as "Hide Options", instead of "Show Options" - 10https://bugzilla.wikimedia.org/73235 (10etonkovidova) p:5Unprio>3High s:5minor>3major [19:48:45] RoanKattouw, do you know what James is talking about on https://gerrit.wikimedia.org/r/#/c/169936/ ? [19:49:28] What discussion? Was it during the meeting today? [19:49:42] I thought it still allowed non-standard values. [19:49:54] pls, somebody take a look at bug 73235 [19:51:43] Krenair: I don't know [19:51:47] We didn't talk about it today [19:52:50] They are often discussions he has with himself as he finds himself very agreeable [19:58:10] etonkovidova: Yeah... that's the third thing today that's my fault :| [19:58:33] It looks like I have a fix for bug 73134 [19:59:06] RoanKattouw: ok then :) [19:59:22] I'll look into this one next [19:59:30] I'm pretty sure I know what broke it [20:00:18] ...and I found another bug while testing my change. Lovely [20:01:19] (03PS1) 10Catrope: Followup a054a75: don't reintroduce removed template parameters [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/172317 [20:02:29] etonkovidova, 73235 - caused by https://gerrit.wikimedia.org/r/#/c/171997/ [20:03:41] (03PS1) 10TheDJ: Preview: Add content clears after side-by-side preview [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/172318 [20:04:14] (03PS1) 10Catrope: Followup c232083: use getRelativeTitle for template titles [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/172319 [20:04:20] Krenair: Yeah that's what I suspected [20:04:56] (03PS2) 10Catrope: Followup a054a75: don't reintroduce removed template parameters [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/172317 (https://bugzilla.wikimedia.org/73134) [20:05:31] Krenair: OOOOOH WOW [20:05:34] I AM SUCH A MORON [20:05:38] :) [20:05:54] this.mode === 'single' ? [20:05:55] ve.msg( 'visualeditor-dialog-transclusion-multiple-mode' ) : [20:05:57] ve.msg( 'visualeditor-dialog-transclusion-single-mode' ) [20:05:58] Spot the mistake :P [20:06:50] backwards? [20:07:18] (03PS1) 10Catrope: Followup a86d824: fix stupid stupid logic inversion [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/172320 (https://bugzilla.wikimedia.org/73235) [20:08:16] (03PS1) 10Mooeypoo: [wip] Adding DragGroupElement and DragElement mixins [oojs/ui] - 10https://gerrit.wikimedia.org/r/172321 [20:08:33] \o/ [20:09:35] ryasmeen: OK, so what's the situation with cursors and dialogs? [20:10:07] (03CR) 10jenkins-bot: [V: 04-1] [wip] Adding DragGroupElement and DragElement mixins [oojs/ui] - 10https://gerrit.wikimedia.org/r/172321 (owner: 10Mooeypoo) [20:10:34] Are you sure that fixes it RoanKattouw? [20:11:04] ... [20:11:25] Krenair: Am I sure that what fixes what? [20:11:34] sorry, https://gerrit.wikimedia.org/r/#/c/172320/1 [20:11:35] Sorry I just wrote and submitted three bugfixes while eating, so... :D [20:11:53] To be fair I haven't tested, let me do that [20:11:57] I open the options, and it still says "Show options" [20:12:16] hah [20:12:21] And now for me it's stuck at Hide Options [20:12:23] OK so my code doesn't work [20:13:10] Hmm... [20:14:00] The "stupid logic inversion" was in the original code... ? [20:14:00] I guess it makes sense... [20:14:00] If the mode is single, show the "go to multiple mode" message [20:14:11] mooeypoo: just a bike-shed-like comment, probably should be DraggableElement and DragableGroupElement, since it adds behavior, not content - we use adjectives for behaviors and nouns for creating new content [20:15:51] http://caniuse.com/dragndrop -- is lack of .setDragImage support going to keep drag-n-drop from working in VE for IE? [20:16:03] or is this a bigger issue? [20:16:37] (03CR) 10Trevor Parscal: [C: 032] Support for generic file drop handlers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170907 (owner: 10Esanders) [20:18:03] RoanKattouw: ^^ ie d&d? [20:18:37] (03Merged) 10jenkins-bot: Support for generic file drop handlers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/170907 (owner: 10Esanders) [20:20:37] TrevorParscal, good point. Changing. [20:21:28] hexmode: I don't think we use setDragImage? [20:21:46] hexmode: That's only a visual thing anyway [20:21:48] D'OH [20:21:49] this.actions.forEach( { actions: [ 'mode' ] }, function ( action ) { [20:21:51] action.setLabel( [20:21:52] this.mode === 'single' ? ..... [20:21:54] Guess what [20:21:55] this.mode is undefined [20:21:57] Because I'm in a forEach callback so there is no this [20:22:54] RoanKattouw: so there is some other issue? 'Cause d&d works for us in Chrome but not IE. [20:23:08] (03PS2) 10Catrope: Followup a86d824: fix reference to this in foreach callback [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/172320 (https://bugzilla.wikimedia.org/73235) [20:23:27] It sounds plausible that D&D might not work in IE [20:23:36] Probably for other reasons than setDragImage thogh [20:23:54] yeah, ok. [20:25:15] setDragImage is crap [20:26:00] ok, Let me see if I can track it down. [20:26:07] you can only use an image object, or a DOM element that is completely visible - if part of it is not visible it will only show the visible part, if it's off screen completely, it will be invisible [20:26:13] it's a really useless interface [20:27:03] hexmode: There are different ways to get the drop data, I suspect that's where it goes wrong [20:27:10] edsanders would probably know more [20:28:07] (03CR) 10Alex Monk: [C: 032] Followup a86d824: fix reference to this in foreach callback [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/172320 (https://bugzilla.wikimedia.org/73235) (owner: 10Catrope) [20:28:25] (03PS1) 10Mooeypoo: [wip] Adding DraggableGroupElement and DraggableElement mixins [oojs/ui] - 10https://gerrit.wikimedia.org/r/172325 [20:29:12] 3VisualEditor / 3Editing Tools: VisualEditor:[Regression pre-wmf8] Button in Add a Template dialog is labeled as "Hide Options", instead of "Show Options" - 10https://bugzilla.wikimedia.org/73235 (10Alex Monk) a:3Roan Kattouw [20:29:22] I skipped most of the dataTransfer stuff [20:29:26] (03Merged) 10jenkins-bot: Followup a86d824: fix reference to this in foreach callback [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/172320 (https://bugzilla.wikimedia.org/73235) (owner: 10Catrope) [20:29:38] Trying to make it not depend on dataTransfer since it seems some browsers don't fully support it [20:29:50] I went for getting the informaiton communicated between the item/widget instead. [20:29:51] hexmode, what sort of drag and drop to achieve what? [20:30:29] edsanders: I'm just now responding to the end user's complaint. Will get you more info. [20:31:11] 3VisualEditor / 3Editing Tools: VisualEditor:[Regression pre-wmf8] Button in Add a Template dialog is labeled as "Hide Options", instead of "Show Options" - 10https://bugzilla.wikimedia.org/73235 (10Alex Monk) 5PATC>3RESO/FIX [20:33:15] edsanders: at first blush, moving an object (just tried gallery) on the page [20:33:34] (03CR) 10Alex Monk: [C: 032] Followup c232083: use getRelativeTitle for template titles [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/172319 (owner: 10Catrope) [20:33:38] Krinkle|detached: When you're around, I'd like to pick your brain about fixing the mixin inheritance bug in oojs [20:34:57] (03Merged) 10jenkins-bot: Followup c232083: use getRelativeTitle for template titles [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/172319 (owner: 10Catrope) [20:35:02] (03CR) 10Catrope: [C: 032] Fix craziness in template dialog focusing [extensions/VisualEditor] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/172298 (https://bugzilla.wikimedia.org/73138) (owner: 10Jforrester) [20:35:15] (03PS1) 10Catrope: Followup c232083: use getRelativeTitle for template titles [extensions/VisualEditor] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/172328 [20:35:34] TrevorP|Away: https://gerrit.wikimedia.org/r/#/c/172317/2 [20:35:37] (03CR) 10Alex Monk: "What discussion? That should still be possible with this commit." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169936 (https://bugzilla.wikimedia.org/53613) (owner: 10Alex Monk) [20:35:41] Urhg [20:36:19] mooeypoo: Yeah that works for internal drag&drop like in your thing, not for drag&drop from arbitrary sources though [20:36:29] (03Merged) 10jenkins-bot: Fix craziness in template dialog focusing [extensions/VisualEditor] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/172298 (https://bugzilla.wikimedia.org/73138) (owner: 10Jforrester) [20:37:37] (03PS1) 10Catrope: Followup a86d824: fix reference to this in foreach callback [extensions/VisualEditor] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/172329 (https://bugzilla.wikimedia.org/73235) [20:39:11] 3VisualEditor: VisualEditor: Viewport sometimes scrolls to bottom when loading some pages - 10https://bugzilla.wikimedia.org/73208#c1 (10etonkovidova) Chrome remembers a scroll position on the page - if a a content at the bottom of the page was viewed/edited, and Back/Forward buttons then were used, loading th... [20:39:46] RoanKattouw: The situation is..it got merged and working now [20:39:52] edsanders: on chrome & ff, when I drag from one section of the page to another, I see a line indicating where the object will go if dropped. no such indication on ie [20:40:02] ryasmeen: OK cool [20:40:09] We have a backport to wmf7 pending for this afternoon [20:40:13] Along with a pile of other stuff [20:40:25] I've been causing an embarrassing number of bugs last week [20:40:48] hehe no worries! [20:41:02] So it's probably still broken in test2 but it should be fixed in the 4pm deploy [20:41:08] right! [20:41:11] TrevorParscal: https://gerrit.wikimedia.org/r/#/c/172317/2 [20:41:24] yup [20:41:26] lookin [20:41:54] edsanders: RoanKattouw: filing bug :) [20:42:12] Thanks hexmode [20:43:11] (03CR) 10Trevor Parscal: [C: 032] Followup a054a75: don't reintroduce removed template parameters [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/172317 (https://bugzilla.wikimedia.org/73134) (owner: 10Catrope) [20:43:27] brb [20:43:28] lunch [20:44:17] Thanks TrevorParscal [20:44:30] (03Merged) 10jenkins-bot: Followup a054a75: don't reintroduce removed template parameters [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/172317 (https://bugzilla.wikimedia.org/73134) (owner: 10Catrope) [20:45:22] (03PS1) 10Catrope: Remove last usage of ve.bind() in VE-MW [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/172334 [20:46:19] (03CR) 10Catrope: [C: 032] Fix pasteSpecial command [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172038 (owner: 10Esanders) [20:48:15] (03Merged) 10jenkins-bot: Fix pasteSpecial command [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172038 (owner: 10Esanders) [20:50:22] urgh, where did that ve.bind call come from? I thought we killed them all... [20:50:29] Yeah I did too [20:50:33] But that's some pretty old code AFAIK... [20:52:03] nope, looks like we missed another one somehow [20:53:44] (03CR) 10Alex Monk: [C: 032] Remove last usage of ve.bind() in VE-MW [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/172334 (owner: 10Catrope) [20:54:05] TrevorParscal: Why the hell does .oo-ui-optionWidget have display: block; ? [20:54:12] Aren't OptionWidgets divs? [20:54:31] That rule is fighting Moriel's attempts to have inline-block OptionWidgets in her drag-n-drop thing [20:55:04] (03Merged) 10jenkins-bot: Remove last usage of ve.bind() in VE-MW [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/172334 (owner: 10Catrope) [20:55:11] 3VisualEditor / 3Editing Tools: VisualEditor:[Regression pre-wmf8] Button in Add a Template dialog is labeled as "Hide Options", instead of "Show Options" - 10https://bugzilla.wikimedia.org/73235 (10Alex Monk) 5PATC>3RESO/FIX [20:55:53] I guess maybe there are OptionWidget subclasses that are spans or whatever and need the display: block; rule, but then that should be down in those subclasses, not in OptionWidget itself [20:56:22] if they are divs, it shouldn't do that [20:56:31] and it's just something that crept in over time [20:57:10] Well I guess we can't just remove it, we'd have to audit subclasses [20:57:12] Is it safe to remove? [20:58:01] TrevorParscal: Do you mind if I make that your problem? :) [20:58:12] i can peek at it [20:58:17] OK cool [20:58:51] For now she's going to put .css( 'display', 'inline-block' ) in her constructor [20:59:04] And then once the OptionWidget crap is cleaned up, that can be removed and replaced with CSS [20:59:28] why can't she write a powerful rule? [20:59:31] anyway [20:59:35] it's all just temporary [20:59:58] just, that sound especially evil [21:00:48] sure [21:00:59] You mean something like div.oo-ui-draggableElement ? [21:01:00] how do you make a powerful rule about display: inline-block? [21:01:05] oh [21:01:20] Or .oo-ui-draggableElement.oo-ui-optionWidget ? Or !important? Or what? [21:01:38] .oo-ui-draggableElement.oo-ui-optionWidget [21:01:59] that seems like it's safe no matter what other CSS changes are made [21:02:04] Right [21:02:31] because if you don't assert it, and knowing that it MUST be inline block or it will break, you just open yourself up to someone unknowingly breaking it again [21:05:11] (03CR) 10Trevor Parscal: [C: 04-1] Add 'indeterminate' state to progress bar widget (032 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/171548 (owner: 10Esanders) [21:05:28] (03PS1) 10Catrope: Followup d4c133b: ve.js depends on oojs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/172339 [21:06:24] Wow I was not very intelligent last week, was I [21:06:57] 3VisualEditor / 3Editing Tools: VisualEditor: drag-n-drop in IE doesn't work - 10https://bugzilla.wikimedia.org/73240 (10Mark A. Hershberger) 3NEW p:3Unprio s:3normal a:3None I can successfully drag-n-drop an image from one part of the page to another in VE while using Chrome and Firefox, but not IE.... [21:07:08] RoanKattouw: maybe you need more sleep [21:07:34] Heh, yeah maybe [21:07:47] Right now I'm in NYC while kind of still on Pacific TIme [21:07:55] 3MediaWiki / 3Page editing: Changes lost when submitting an edit after the session has expired - 10https://bugzilla.wikimedia.org/9749 (10Nemo) [21:08:13] Going to sleep before 3am might be good [21:08:20] oh! That's like next door! Only a train ride away. :) [21:08:59] (03CR) 10Catrope: [C: 04-1] "This makes the command help dialog overflow in VE-MW (but not in VE core). I know that's a bug in the command help dialog, but its layout " [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172039 (owner: 10Esanders) [21:09:04] don't worry, I'm too busy to visit you, though ;) [21:09:14] I won't be here tomorrow anyway ;) [21:09:44] Taking advantage of the holiday tomorrow to visit Boston [21:10:35] oh, I forgot all about holidays [21:12:35] RoanKattouw, what in lib/ve/src/ve.js depends on oojs? [21:12:49] Krenair: Argh [21:12:51] Nothing, of course [21:13:04] Sorry I was looking at mismatched versions of VE-MW and VE core [21:13:25] :) [21:13:32] (03Abandoned) 10Catrope: Followup d4c133b: ve.js depends on oojs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/172339 (owner: 10Catrope) [21:16:59] 3MediaWiki / 3Page editing: Auto-save to increase chances of lost edits recovery - 10https://bugzilla.wikimedia.org/73241 (10Nemo) 3NEW p:3Unprio s:3enhanc a:3Derk-Jan Hartman As a use who is preparing an edit, I'd like to be confident that if some bad interruption happens before I save it (e.g. powe... [21:17:28] 3VisualEditor / 3MediaWiki integration: VisualEditor: Implement some form of auto-save - 10https://bugzilla.wikimedia.org/55370 (10Nemo) [21:17:28] 3MediaWiki / 3Page editing: Auto-save to increase chances of lost edits recovery - 10https://bugzilla.wikimedia.org/73241 (10Nemo) 5NEW>3PATC p:5Unprio>3Normal [21:17:50] (03PS1) 10Catrope: Fix pasteSpecial command [VisualEditor/VisualEditor] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/172403 [21:19:40] 3MediaWiki / 3Page editing: Auto-save to increase chances of lost edits recovery - 10https://bugzilla.wikimedia.org/73241 (10Nemo) [21:19:41] 3MediaWiki / 3Page editing: Changes lost when submitting an edit after the session has expired - 10https://bugzilla.wikimedia.org/9749 (10Nemo) [21:22:55] Hmm I found a context flicker bug [21:26:42] 3VisualEditor / 3Editing Tools: VisualEditor: Links to Draft namespace show as red links in link inspector search - 10https://bugzilla.wikimedia.org/71659#c3 (10etonkovidova) Verified in en.wiki - not reproducible. [21:27:11] 3VisualEditor / 3Editing Tools: VisualEditor: Links to Draft namespace show as red links in link inspector search - 10https://bugzilla.wikimedia.org/71659 (10etonkovidova) 5RESO/?>3VERI [21:29:42] 3VisualEditor / 3Editing Tools: VisualEditor: When selecting FocusableNode with arrow keys, context flickers at position of last mouse click - 10https://bugzilla.wikimedia.org/73242 (10Roan Kattouw) 3ASSI p:3Unprio s:3normal a:3Ed Sanders 1. Open a document that contains a line of plain (not linked)... [21:30:37] RoanKattouw, did you get a chance to look at the FlaggedRevs gist I posted on.. friday? [21:31:06] Krenair: I don't even remember you posted one :| [21:31:20] Although I do remember you having a question relating to FR and me being too busy to answer [21:37:54] A question? huh... [21:38:08] I posted https://gist.github.com/Krenair/c1520fbe230b3f7f9393 [21:41:18] Which I don't really want to upload for CR... [21:45:56] 3VisualEditor / 3ContentEditable: VisualEditor: Typing more words into a ==Section heading== adds them into the next line, characters out of order - 10https://bugzilla.wikimedia.org/71364#c3 (10etonkovidova) Checked Safari/Chrome - cannot reproduce. [21:46:15] Krenair: lol, that is pretty ugly [21:46:19] Why does that check need to be defeated? [21:46:48] so it thinks we're looking at the page [21:47:26] rather than in api.php?action=visualeditoredit [21:47:37] otherwise it doesn't add the notice [21:47:55] 3VisualEditor / 3ContentEditable: VisualEditor: Typing more words into a ==Section heading== adds them into the next line, characters out of order - 10https://bugzilla.wikimedia.org/71364#c4 (10Roan Kattouw) This is almost certainly a duplicate of the bug that was fixed by https://gerrit.wikimedia.org/r/#/c... [21:48:01] Ugh [21:49:18] Oh and then you get the subtitle from OutputPage [21:49:25] Wow that's horrible [21:51:18] Krenair: Hmm, well it does seem like this is what we would have to do [21:51:40] Unless there's a more generic way to cause the subtitle to be regenerated with faked request values [21:51:54] Yeah but I don't want to do this :( [21:52:38] I mean we do a lot of nasty things already, but we don't yet have direct calls to FlaggedRevs [21:52:55] Instead we call generic things that we know will only be used by FR in practice [21:52:59] Like EditPage::getCheckboxes() [21:54:40] (03CR) 10Catrope: [C: 032] Fix up/down arrowing off a focusable node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172109 (owner: 10Esanders) [21:55:40] (03CR) 10Catrope: [C: 032] Fix logic for ignoring (col|row)span=1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172246 (owner: 10Esanders) [21:57:01] (03Merged) 10jenkins-bot: Fix up/down arrowing off a focusable node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172109 (owner: 10Esanders) [21:57:49] (03Merged) 10jenkins-bot: Fix logic for ignoring (col|row)span=1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172246 (owner: 10Esanders) [22:00:22] (03CR) 10Alex Monk: "Probably fixed bug 71364" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164514 (owner: 10Catrope) [22:02:56] 3VisualEditor: VisualEditor: Viewport sometimes scrolls to bottom when loading some pages - 10https://bugzilla.wikimedia.org/73208#c2 (10Erik Moeller) Note that I am able to reproduce the incorrect scroll position in Chrome in a private browser window. [22:03:08] RoanKattouw, wonder if we could make a new DerivativeContext and get it that way [22:03:35] DerivativeRequest, even [22:07:18] Yeah I was thinking that too [22:07:56] 3VisualEditor / 3Editing Tools: VisualEditor:[Regression pre-wmf8] Button in Add a Template dialog is labeled as "Hide Options", instead of "Show Options" - 10https://bugzilla.wikimedia.org/73235#c5 (10etonkovidova) Verified the fix in betalabs. [22:11:25] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf7] The cursor stays active on CE even after opening the dialog for Basic Reference/Citation/Reference list/Page Settings - 10https://bugzilla.wikimedia.org/73097#c11 (10Rummana Yasmeen) Verified the fix in Betalabs [22:16:55] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf7] Cite command not working (but cite-tranclusion does?) - 10https://bugzilla.wikimedia.org/73001#c6 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in Betalabs,test2 and production. [22:17:57] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression wmf7] Template dialog no longer takes focus on load - 10https://bugzilla.wikimedia.org/73138#c5 (10etonkovidova) Verified the fix in betalabs. [22:20:04] (03CR) 10Catrope: [C: 04-1] Make caption tool available when caption selected (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172249 (owner: 10Esanders) [22:27:02] RoanKattouw: fixing inheritance bug in oojs, elaborate [22:27:22] Krinkle: When you have a mixin that inherits from another mixin [22:27:35] Like, GroupWidget inheriting from GroupElement [22:27:50] Then everywhere you use the mixin, you have to remember to also mix in its parent [22:27:53] Which sucks [22:28:03] Is there a way to fix that in oojs, or a way to work around this problem? [22:28:18] (I have to move in a minute but I'll be back on IRC in 5-10 mins to see your response) [22:28:57] 3VisualEditor / 3ContentEditable: VisualEditor: handling preformatted text in tables - 10https://bugzilla.wikimedia.org/73100#c4 (10etonkovidova) Verified the fix in Betalabs. [22:31:23] (03CR) 10Esanders: Make caption tool available when caption selected (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172249 (owner: 10Esanders) [22:36:11] (03PS4) 10Esanders: Move disabling logic from tools to commands [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172277 [22:36:13] (03PS2) 10Esanders: Make caption tool available when caption selected [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172249 [22:36:18] (03CR) 10jenkins-bot: [V: 04-1] Move disabling logic from tools to commands [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172277 (owner: 10Esanders) [22:40:20] RoanKattouw_away: We've talked about this a few times before [22:40:36] RoanKattouw_away: Including a feature request on github/trevor/oojs and later again on bugzilla [22:40:46] mixins cannot and should not have any inheritance. [22:41:00] mixins are mixed into their target, there is no live inheritance. [22:41:16] if you want to use a mixin in another mixin, just mix it in. Don't use inheritance. [22:42:01] You won't have to mix in the "parent" [22:42:10] that's undesirable indeed. [22:42:25] Krinkle: So you're saying that if I have a mixin called A, and a specialized mixin called SpecialA, then SpecialA should mixin A? [22:42:27] So that I can then mixin SpecialA into something without also having to mixin A [22:42:34] Yep [22:42:40] (i.e. SpecialA should mixin A as an alternative to SpecialA inherits A) [22:42:45] OK that makes some amount of sense [22:43:03] We could do that for GroupWidget (existing) and DragDropElement (new mixin Moriel wrote) [22:43:19] The same way that mixing in Thingable into ThingyThing makes ThingyThing standalone and no longer dependent on Thingable because it has it copied over. [22:43:32] That same principle (one-time copy, breaking any link) applies to the composing phase of mixins as well. [22:43:43] A mixin having inheritance should be a compile error. [22:44:56] If you mixin Focusable into ImageNode that makes ImageNode standalone, anything extending ImageNode wouldn't be worried about Focusable. The same applies regardless of whether the class is directly for "end-users" or itself another mixin. [22:45:03] Right [22:46:21] (03PS4) 10Esanders: Register select all as a command and perform programmatically [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172039 [22:46:30] (03CR) 10Esanders: "added an em" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172039 (owner: 10Esanders) [22:49:20] (03PS5) 10Esanders: Move disabling logic from tools to commands [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172277 [22:49:22] (03PS3) 10Esanders: Make caption tool available when caption selected [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172249 [22:52:26] 3VisualEditor / 3ContentEditable: VisualEditor: Typing more words into a ==Section heading== adds them into the next line, characters out of order - 10https://bugzilla.wikimedia.org/71364 (10James Forrester) a:5Ed Sanders>3Roan Kattouw [22:52:55] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression pre-wmf7] "Uncaught Error: Unknown dependency: rangefix" appears while trying to load mobile VE - 10https://bugzilla.wikimedia.org/73038#c6 (10Chris McMahon) 5RESO/FIX>3REOP new js error from logged in user e.g. http://en.m.wikipedia.beta.wmflabs.... [22:56:11] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression pre-wmf7] "Uncaught Error: Unknown dependency: rangefix" appears while trying to load mobile VE - 10https://bugzilla.wikimedia.org/73038#c7 (10Chris McMahon) latest failures is https://integration.wikimedia.org/ci/job/browsertests-MobileFrontend-en.m.... [22:58:13] (03PS1) 10Catrope: Followup d4c133b: also make TargetEvents depend on ve.track() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/172431 (https://bugzilla.wikimedia.org/73038) [22:59:29] (03CR) 10Catrope: [C: 032] Make caption tool available when caption selected [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172249 (owner: 10Esanders) [23:01:23] (03Merged) 10jenkins-bot: Make caption tool available when caption selected [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172249 (owner: 10Esanders) [23:03:40] edsanders: https://gerrit.wikimedia.org/r/172431 [23:09:24] (03CR) 10Catrope: [C: 032] Register select all as a command and perform programmatically [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172039 (owner: 10Esanders) [23:09:56] (03CR) 10Catrope: [C: 032] spinner.gif: Update with new version from Trevor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172217 (owner: 10Jforrester) [23:10:12] 3VisualEditor: VisualEditor: Can't delete text... which is actually not there - 10https://bugzilla.wikimedia.org/73216#c2 (10NemesisIII) (In reply to Ed Sanders from comment #1) > Can't reproduce this. I am the user to which it happened. I actually don't know how it happened, I did nothing special as far as I... [23:11:20] (03Merged) 10jenkins-bot: Register select all as a command and perform programmatically [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172039 (owner: 10Esanders) [23:11:49] (03Merged) 10jenkins-bot: spinner.gif: Update with new version from Trevor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172217 (owner: 10Jforrester) [23:21:10] (03PS1) 10Catrope: Followup 5c0c117: make the edit tab work with oldid= again [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/172435 [23:21:29] edsanders|away: https://gerrit.wikimedia.org/r/172435 fixes the bug you found earlier [23:21:31] Ugh, he's away [23:21:42] Krinkle: Maybe you could review this? ---^^ I'd like to SWAT it [23:22:28] Krinkle: And also https://gerrit.wikimedia.org/r/172431 [23:22:40] 3MediaWiki / 3ResourceLoader: CSSJanus fails to flip with !important - 10https://bugzilla.wikimedia.org/61440 (10Bartosz Dziewoński) [23:22:47] (03CR) 10Catrope: [C: 032] Fix pasteSpecial command [VisualEditor/VisualEditor] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/172403 (owner: 10Catrope) [23:23:38] (03CR) 10Alex Monk: "nitpicking, otherwise looks good" (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/172435 (owner: 10Catrope) [23:24:47] (03Merged) 10jenkins-bot: Fix pasteSpecial command [VisualEditor/VisualEditor] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/172403 (owner: 10Catrope) [23:24:49] (03PS2) 10Catrope: Followup 5c0c117: make the edit tab work with oldid= again [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/172435 [23:25:02] Hmm, why did I expect "git checkout fix-[TAB}" to work on my machine [23:25:13] RoanKattouw: checking [23:25:25] I only have 6 branches starting with "fix-" [23:26:44] (03CR) 10Alex Monk: [C: 032] Followup 5c0c117: make the edit tab work with oldid= again [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/172435 (owner: 10Catrope) [23:28:00] Thanks Krenair [23:28:01] (03Merged) 10jenkins-bot: Followup 5c0c117: make the edit tab work with oldid= again [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/172435 (owner: 10Catrope) [23:28:08] Krenair: So I'm looking at your "redirects in category input widget" change [23:28:10] And I'm confused [23:28:34] ok... [23:28:49] RoanKattouw: Why is ext.visualEditor.track its own module [23:28:50] Hold on I may not have done this right, let me test some more [23:28:58] Krinkle: Because I need it in init init [23:29:02] Would we ever addModules() it? [23:29:15] or mw.loader.load it directly [23:29:20] It's a dependency of init init as well as TargetEvents [23:29:53] RoanKattouw: Isn't there a common module to those already? [23:29:57] like base [23:30:02] No, base is too big [23:30:06] init init depends on pretty much nothing [23:30:21] oh init init [23:30:26] why would that need ve.track [23:30:30] wouldn't that use mw.track? [23:30:31] Well, it depends on a bunch of MW stuff, but not on any VE things [23:30:43] It could theoretically use mw.track() [23:30:58] But we have centralized logic for mapping ve.track() to mw.track() in ve.init.mw.trackSubscriber.js (unmerged) [23:31:10] This mapping involves adding eleventy thousand fields [23:31:35] See https://gerrit.wikimedia.org/r/171499 [23:31:39] I'm hoping not too long from now anything in mediawiki/extensions/VisualEditor applies "No touching" to ve.* and puts everything in mw.* js namespace [23:31:48] all this ve.*.mw* is making me itchy [23:32:06] it might feel weird at first, but it makes sense. [23:32:10] That would be nice, I guess [23:32:14] But it doesn't help here [23:32:18] ve.track() is in VE core [23:32:20] we do the same for everything else (we don't have OO.ui.VEDialog) [23:32:40] And ve.init.mw.trackSubscriber.js doesn't create a class, it's just a ve.trackSubscribe() handler [23:32:54] Delegating to mw.track? [23:33:01] Yes [23:33:04] Great [23:33:13] But with different delegation patterns for different prefixes [23:33:20] sure [23:33:26] And filling in a bunch of computed properties [23:34:13] In any case, https://gerrit.wikimedia.org/r/172431 fixes a JS error on mobile in master [23:34:41] Because I screwed up when splitting off ve.track and only made init init depend on it, but mobile doesn't use init init but does call ve.track() by way of TargetEvents [23:35:32] (03CR) 10Krinkle: [C: 032] Followup d4c133b: also make TargetEvents depend on ve.track() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/172431 (https://bugzilla.wikimedia.org/73038) (owner: 10Catrope) [23:35:44] What's TargetEvents again? [23:36:25] Hm... our mw integration keeps being akward, from one soup into the next... Bit unfortunate, but one sprint at a time. [23:36:42] Right, TargetEvents is the abstract handling [23:36:50] (03Merged) 10jenkins-bot: Followup d4c133b: also make TargetEvents depend on ve.track() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/172431 (https://bugzilla.wikimedia.org/73038) (owner: 10Catrope) [23:37:02] https://bugzilla.wikimedia.org/show_bug.cgi?id=55557 [23:37:25] Krinkle: Yeah init init is a pile of manure [23:37:28] (I HATE MANURE) [23:37:33] :) [23:38:56] 3OOjs: OOjs: Split core utilities up into object-specific singletons - 10https://bugzilla.wikimedia.org/56977#c2 (10Krinkle) 5ASSI>3RESO/WON This is nice for a framework design, but for OOjs. We use native methods instead, more with es5-shim. We don't need many utility methods or an extendable base like th... [23:39:43] One week from today, I will be on a flight and init init will fear the Wrath of the Roan [23:44:47] (03CR) 10Catrope: [C: 032] Follow redirects in the category input widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163996 (owner: 10Alex Monk) [23:44:55] (03CR) 10jenkins-bot: [V: 04-1] Follow redirects in the category input widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163996 (owner: 10Alex Monk) [23:45:00] (03CR) 10Catrope: [C: 032] Followup c232083: use getRelativeTitle for template titles [extensions/VisualEditor] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/172328 (owner: 10Catrope) [23:45:04] (03CR) 10Catrope: [C: 032] Followup a86d824: fix reference to this in foreach callback [extensions/VisualEditor] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/172329 (https://bugzilla.wikimedia.org/73235) (owner: 10Catrope) [23:45:17] (03PS1) 10Catrope: Followup d4c133b: also make TargetEvents depend on ve.track() [extensions/VisualEditor] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/172440 (https://bugzilla.wikimedia.org/73038) [23:45:24] Krinkle: Thanks for +2ing [23:45:31] I have a pile of stuff for SWAT today and that was one of them [23:45:39] (03CR) 10Catrope: [C: 032] Followup d4c133b: also make TargetEvents depend on ve.track() [extensions/VisualEditor] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/172440 (https://bugzilla.wikimedia.org/73038) (owner: 10Catrope) [23:46:33] (03Merged) 10jenkins-bot: Followup c232083: use getRelativeTitle for template titles [extensions/VisualEditor] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/172328 (owner: 10Catrope) [23:46:35] (03Merged) 10jenkins-bot: Followup a86d824: fix reference to this in foreach callback [extensions/VisualEditor] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/172329 (https://bugzilla.wikimedia.org/73235) (owner: 10Catrope) [23:46:41] (03CR) 10jenkins-bot: [V: 04-1] Followup d4c133b: also make TargetEvents depend on ve.track() [extensions/VisualEditor] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/172440 (https://bugzilla.wikimedia.org/73038) (owner: 10Catrope) [23:46:57] (03PS1) 10Catrope: Update VE core for cherry-picks [extensions/VisualEditor] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/172441 [23:47:52] Or.... maybe it wasn't one of them [23:47:58] That's why the cherry-pick is V-1ing :P [23:48:12] (03Abandoned) 10Catrope: Followup d4c133b: also make TargetEvents depend on ve.track() [extensions/VisualEditor] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/172440 (https://bugzilla.wikimedia.org/73038) (owner: 10Catrope) [23:48:40] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression pre-wmf7] "Uncaught Error: Unknown dependency: rangefix" appears while trying to load mobile VE - 10https://bugzilla.wikimedia.org/73038 (10Roan Kattouw) 5PATC>3RESO/FIX [23:48:54] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression pre-wmf8] "Uncaught Error: Unknown dependency: rangefix" appears while trying to load mobile VE - 10https://bugzilla.wikimedia.org/73038 (10Roan Kattouw) [23:49:10] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression pre-wmf7] "Uncaught Error: Unknown dependency: rangefix" appears while trying to load mobile VE - 10https://bugzilla.wikimedia.org/73038 (10Roan Kattouw) [23:49:41] 3VisualEditor / 3MediaWiki integration: VisualEditor: Categories without description pages don't show as red - 10https://bugzilla.wikimedia.org/65517#c4 (10etonkovidova) Verified the fix in Betalabs. [23:49:45] (03CR) 10Catrope: [C: 032] Update VE core for cherry-picks [extensions/VisualEditor] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/172441 (owner: 10Catrope) [23:51:05] (03Merged) 10jenkins-bot: Update VE core for cherry-picks [extensions/VisualEditor] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/172441 (owner: 10Catrope) [23:51:29] (03CR) 10Catrope: "This has a logical merge conflict (master switched to allcategories). Alex, could you rebase and address the conflict?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163996 (owner: 10Alex Monk) [23:58:26] (03PS1) 10Catrope: Followup a054a75: don't reintroduce removed template parameters [extensions/VisualEditor] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/172446 (https://bugzilla.wikimedia.org/73134) [23:58:37] (03CR) 10Catrope: [C: 032] Followup a054a75: don't reintroduce removed template parameters [extensions/VisualEditor] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/172446 (https://bugzilla.wikimedia.org/73134) (owner: 10Catrope)
ABCD