[00:00:24] sucheta: so, this check icon [00:00:30] and the evil therein [00:00:54] sucheta, we should practice phrasing our questions in valid JavaScript strings. [00:02:05] You mean like: [00:02:13] There he goes^ [00:02:38] >>> String.fromCharCode([67, 97, 110, 32, 121, 111, 117, 32, 104, 101, 97, 114, 32, 109, 101, 63]) [00:02:39] RoanKattouw: (string) '\u0000' [00:02:42] Well crap [00:02:49] Neeever mind [00:03:21] (03PS1) 10Catrope: Update VE core for cherry-pick [extensions/VisualEditor] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/173204 [00:03:34] (03CR) 10Catrope: [C: 032] Update VE core for cherry-pick [extensions/VisualEditor] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/173204 (owner: 10Catrope) [00:04:18] (03PS1) 10Catrope: Update VE core for cherry-pick [extensions/VisualEditor] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/173205 [00:04:26] (03CR) 10Catrope: [C: 032] Update VE core for cherry-pick [extensions/VisualEditor] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/173205 (owner: 10Catrope) [00:05:12] (03CR) 10jenkins-bot: [V: 04-1] Update VE core for cherry-pick [extensions/VisualEditor] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/173204 (owner: 10Catrope) [00:06:03] (03CR) 10Catrope: [C: 032] Update VE core for cherry-pick [extensions/VisualEditor] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/173204 (owner: 10Catrope) [00:07:01] 3VisualEditor / 3ContentEditable: VisualEditor: shortcut(Ctrl+1) for Page Title does not work on Mac - 10https://bugzilla.wikimedia.org/73340#c2 (10etonkovidova) 5RESO/WOR>3VERI Ctrl+1 does not work in any of browsers on my Mac - Safari7, Chrome, and FF 38. And I did not see any shortcuts assigned to... [00:08:39] (03CR) 10Catrope: [V: 032] Update VE core for cherry-pick [extensions/VisualEditor] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/173205 (owner: 10Catrope) [00:09:23] (03CR) 10Catrope: [V: 032] Update VE core for cherry-pick [extensions/VisualEditor] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/173204 (owner: 10Catrope) [02:14:45] 3MediaWiki / 3Page editing: Changes lost when submitting an edit after the session has expired - 10https://bugzilla.wikimedia.org/9749#c4 (10Matthew Flaschen) 5NEW>3RESO/FIX I think this is fixed (a long time ago). I did the following (locally): 1. Log in. 2. Go to an edit page. 3. Make some changes 4.... [02:32:15] (03PS1) 10Alex Monk: Remove upstreamed ve.contains function [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173230 [03:21:53] (03CR) 10Alex Monk: [wip] Adding paramOrder widget to TemplateData editor (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/170655 (owner: 10Mooeypoo) [05:32:12] (03CR) 10Catrope: [C: 032] Remove upstreamed ve.contains function [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173230 (owner: 10Alex Monk) [05:33:59] (03Merged) 10jenkins-bot: Remove upstreamed ve.contains function [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173230 (owner: 10Alex Monk) [06:23:24] (03PS1) 10Catrope: Use strict comparison for insertionAnnotationsChange [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173240 [06:27:08] (03PS2) 10Catrope: Use strict comparison for insertionAnnotationsChange [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173240 [07:58:02] 3MediaWiki / 3Page editing: Changes lost when submitting an edit after the session has expired - 10https://bugzilla.wikimedia.org/9749#c5 (10Nemo) 5RESO/FIX>3REOP (In reply to Matthew Flaschen from comment #4) > I think this is fixed (a long time ago). As far as I remember the "Sorry! We could not proce... [08:53:55] Where can I find an example of a gadget registering/adding itself to the "Insert" dropdown menu? [09:49:02] TrevorP|Away, or KemoSabe [09:49:18] Ridiculous Chrome bug of the week: http://jsfiddle.net/edg2s/qkef4fxo/ [10:47:37] (03PS2) 10Esanders: Update RangeFix library 0.1.0 -> 0.1.1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173007 (https://bugzilla.wikimedia.org/73336) [10:47:39] (03PS1) 10Esanders: Safari copy-paste fix [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173256 (https://bugzilla.wikimedia.org/71718) [10:48:01] (03CR) 10Esanders: Update RangeFix library 0.1.0 -> 0.1.1 (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173007 (https://bugzilla.wikimedia.org/73336) (owner: 10Esanders) [10:49:20] (03CR) 10jenkins-bot: [V: 04-1] Safari copy-paste fix [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173256 (https://bugzilla.wikimedia.org/71718) (owner: 10Esanders) [12:01:41] (03CR) 10Alex Monk: "(Removed from VE in I3c7532d9)" [oojs/ui] - 10https://gerrit.wikimedia.org/r/172723 (https://bugzilla.wikimedia.org/65774) (owner: 10Alex Monk) [12:03:55] (03PS2) 10Jforrester: Safari copy-paste fix [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173256 (https://bugzilla.wikimedia.org/71718) (owner: 10Esanders) [12:04:32] (03CR) 10Jforrester: [C: 04-1] "PS2 fixes the jscs issue, but this fails the copy/paste tests in Chrome locally." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173256 (https://bugzilla.wikimedia.org/71718) (owner: 10Esanders) [12:06:16] (03CR) 10jenkins-bot: [V: 04-1] Safari copy-paste fix [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173256 (https://bugzilla.wikimedia.org/71718) (owner: 10Esanders) [12:43:09] (03PS3) 10Esanders: Safari copy-paste fix [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173256 (https://bugzilla.wikimedia.org/71718) [12:47:30] (03CR) 10Esanders: [C: 031] "LGTM, but then I dictated most of it. Will let Roan +2." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172748 (owner: 10Jforrester) [12:47:44] edsanders: :-) [12:55:27] (03CR) 10Esanders: [C: 04-1] "naming suggestions." (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173240 (owner: 10Catrope) [13:11:24] edsanders: +2 https://gerrit.wikimedia.org/r/#/c/173180/ for me/ [13:41:26] (03CR) 10Esanders: [C: 032] Update VE core submodule to master (0a42f21) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173180 (owner: 10Jforrester) [13:42:57] (03Merged) 10jenkins-bot: Update VE core submodule to master (0a42f21) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173180 (owner: 10Jforrester) [14:16:10] (03CR) 10Krinkle: [C: 04-1] "setProp and getProp are cool. I'm not entirely sure whether isInstanceOfAny is something we should incorporate though. I feel it's similar" (036 comments) [oojs/core] - 10https://gerrit.wikimedia.org/r/172939 (owner: 10Catrope) [15:09:52] (03CR) 10Esanders: [C: 032] Provide a FileDropHandler for HTML files [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172749 (owner: 10Jforrester) [15:10:16] edsanders: Maybe we should have TSV/CSV files magically converted into tables? [15:10:31] * James_F ponders CSV parsing in JS. [15:10:59] I'm sure there's a lib but it's not really core functionality [15:11:47] Sure, but if VE could load such modules on-demand it wouldn't add to the payload whilst adding to the "magic". [15:14:51] CSV is exceptionally simple to parse… [15:22:21] you can have different delimeters and escaping [15:27:05] Sure, but that's what the MIME type is for. [15:27:11] The escaping is pretty simple. [15:27:19] Also, there's a library which claims to work well. [15:34:44] James_F, I took a quick look at the draggable stuff for the categorywidget yesterday [15:35:15] took me a bit to figure out the weird mixin inheritance thing [15:35:20] left a comment in gerrit about that [15:35:31] * James_F nods. [15:35:50] it doesn't work just with the mixins though, moved categories don't disappear from their old positions IIRC [15:40:43] didn't even try saving though [15:44:23] can't delete a category that was moved [16:05:16] (03PS2) 10Cmcmahon: [BrowserTest] hygiene changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173023 [16:05:26] (03CR) 10Cmcmahon: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173023 (owner: 10Cmcmahon) [16:07:43] (03CR) 10Esanders: Adding DraggableGroupElement and DraggableElement mixins (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/172325 (owner: 10Mooeypoo) [16:07:58] (03CR) 10Esanders: Adding DraggableGroupElement and DraggableElement mixins (033 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/172325 (owner: 10Mooeypoo) [16:08:09] (03CR) 10Esanders: "comments on PS3 & 4" [oojs/ui] - 10https://gerrit.wikimedia.org/r/172325 (owner: 10Mooeypoo) [16:09:05] (03CR) 10Zfilipin: [C: 032] [BrowserTest] hygiene changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173023 (owner: 10Cmcmahon) [16:09:30] Krenair: Hmm. :-( [16:10:25] (03Merged) 10jenkins-bot: [BrowserTest] hygiene changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173023 (owner: 10Cmcmahon) [16:11:07] I think I almost have it working, with an extra line in DraggableGroupElement#placeItemAtIndex to remove the item before adding it again [16:11:36] though this should not be necessary. hm... [16:17:17] (03PS1) 10Esanders: Give table overlay width so row context positions correctly in RTL [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173288 [16:23:01] 3VisualEditor / 3Editing Tools: VisualEditor: rtl tables: columns adding icon must be flipped - 10https://bugzilla.wikimedia.org/73379 (10Ed Sanders) a:3Ed Sanders [16:23:52] mooeypoo, ? [16:39:43] (03PS1) 10Jforrester: Provide a FileDropHandler for CSV and TSV files [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173296 [16:41:15] 3VisualEditor / 3Data Model: VisualEditor: [Regression]Gallery gets added to the table inside the image - 10https://bugzilla.wikimedia.org/73368#c3 (10Ritu Swain) Gallery(with just caption) can be added to a table in the main editor. Gallery cannot be added to an image otherwise and is also not available as... [16:46:54] (03PS1) 10Jforrester: Follow-up 2075a46: Fix RTL image build by embedding after flipping [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173300 [16:51:34] (03PS1) 10Esanders: Fix getDirectionFromSelection to work with table selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173305 [16:55:16] (03CR) 10Esanders: [C: 04-1] "Doesn't work. The solution is trivial but is left as an exercise to the reader." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173300 (owner: 10Jforrester) [17:04:01] (03PS1) 10Esanders: Make table inserts directional [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173310 [17:12:47] 3VisualEditor / 3Editing Tools: small race condition in Links inspector - 10https://bugzilla.wikimedia.org/73421 (10Chris McMahon) 3NEW p:3Unprio s:3normal a:3None Edit a page on beta labs e.g. http://en.wikipedia.beta.wmflabs.org/wiki/Links_VisualEditor_Test?vehidebetadialog=true&veaction=edit Clic... [17:17:33] (03PS2) 10Esanders: Make table inserts directional [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173310 (https://bugzilla.wikimedia.org/73379) [17:18:33] 3VisualEditor / 3Editing Tools: Link inspector does not function correctly after clicking Remove - 10https://bugzilla.wikimedia.org/73423 (10Chris McMahon) 3NEW p:3Unprio s:3normal a:3None edit a page on beta labs e.g. http://en.wikipedia.beta.wmflabs.org/wiki/Media_Interface_VisualEditor_Test?veacti... [17:22:15] 3VisualEditor / 3Editing Tools: Link inspector does not function correctly after clicking Remove - 10https://bugzilla.wikimedia.org/73423#c1 (10Chris McMahon) Note: this behavior is seen in Firefox. Chrome seems to be OK. [17:22:31] 3VisualEditor / 3Editing Tools: Link inspector does not function correctly after clicking Remove in Firefox - 10https://bugzilla.wikimedia.org/73423 (10Chris McMahon) [17:30:33] Corruption alert: visualeditor-needcheck on ptwikiversity: https://pt.wikiversity.org/?diff=75131 [17:30:33] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=109093891 [17:30:33] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=109114947 [17:30:33] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=33312273 [17:30:33] Corruption alert: visualeditor-needcheck on idwiki: https://id.wikipedia.org/?diff=8268591 [17:30:33] Corruption alert: visualeditor-needcheck on hewiki: https://he.wikipedia.org/?diff=16201952 [17:30:33] Corruption alert: visualeditor-needcheck on plwiki: https://pl.wikipedia.org/?diff=40942666 [17:30:34] Corruption alert: visualeditor-needcheck on plwiki: https://pl.wikipedia.org/?diff=40945762 [17:30:34] Corruption alert: visualeditor-needcheck on itwiki: https://it.wikipedia.org/?diff=69156741 [17:33:02] Krenair, no need to remove the item before placing it again, "addItems" does that automatically for you. If it doesn't, it's a bug in GroupElement. [17:33:30] But I've tested it and it woked for me.. what error are you getting? [17:33:54] It doesn't, but I'm not sure it's a bug in GroupElement [17:33:58] no error [17:34:03] Okay [17:34:09] The $.inArray check fails [17:34:21] addItems( item, index ) moves the item if the item already exists [17:34:46] I took a look through and it appears a different object with the same value is in the array [17:35:03] oh [17:35:12] okay, so you need a value check [17:35:17] the SelectWidget does that iirc [17:35:24] same value property I mean, see MWCategoryItemWidget [17:35:33] I actually talked about that with RoanKattouw yesterday [17:36:14] one of the differences I saw was the index property, IIRC [17:36:59] yeah, but the generalized state is comparing by reference, which is why i just used addItems directly. SelectWidget, though, iirc, uses another removal check for *value* based things, so if it isn't removed, you can extend the addItems method to first remove by equal value and then call the parent [17:37:02] that's what SelectWidget does [17:37:09] not sure about the rest of the issues without seeing them [17:37:54] Categories are OptionWidgets right? [17:38:05] (03CR) 10Catrope: "I feel like getProp and setProp definitely belong here, but the case for isInstanceOfAny() is shakier. We use it in VE because we have thi" [oojs/core] - 10https://gerrit.wikimedia.org/r/172939 (owner: 10Catrope) [17:40:56] (03PS3) 10Esanders: Make table inserts directional [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173310 (https://bugzilla.wikimedia.org/73379) [17:40:58] (03PS2) 10Esanders: Fix getDirectionFromSelection to work with table selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173305 [17:41:00] (03PS2) 10Esanders: Give table overlay width so row context positions correctly in RTL [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173288 (https://bugzilla.wikimedia.org/73378) [17:41:16] mooeypoo, MWCategoryItemWidgets are just Widgets [17:43:03] Hmm [17:43:21] Krenair, also, about the mixin inheritance, you're not alone :\ [17:43:36] That's part of the reason I was thinking of making an empty widget [17:44:22] (03CR) 10Catrope: "Responded to inline comments (all this code was pre-existing in VE core, but we should fix it up while we're at it)" (036 comments) [oojs/core] - 10https://gerrit.wikimedia.org/r/172939 (owner: 10Catrope) [17:44:28] But nayways, I'll have to check into it -- I'll take a look at the categories after standup [17:52:19] RoanKattouw, are those NaN attribute values being set by VE caused by Parsoid? [17:52:54] UHm [17:52:56] Maybe? [17:53:01] I haven't reviewed needcheck in a while [17:53:14] e.g. https://fr.wikipedia.org/?diff=109114947 or https://id.wikipedia.org/?diff=8268591 [17:53:30] Oooh [17:53:33] That's definitely our fault [17:53:38] Well, almost certainly [17:59:43] (03PS2) 10Jforrester: Follow-up 2075a46: Fix RTL image build by embedding after flipping [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173300 [18:00:58] hi ryasmeen are you aware of strange behavior in the Link inspector at this time? besides https://bugzilla.wikimedia.org/show_bug.cgi?id=73423 I am starting to see some odd things in Chrome also. [18:02:56] and now I can't repro :( [18:16:46] 3VisualEditor / 3Editing Tools: Link inspector does not function correctly after clicking Remove in Firefox - 10https://bugzilla.wikimedia.org/73423#c2 (10etonkovidova) On http://en.wikipedia.beta.wmflabs.org/wiki/Media_Interface_VisualEditor_Test?veaction=edit - the link was applied to a specific word(s)?... [18:28:02] hi etonkovidova I'm not sure I understand your comment on https://bugzilla.wikimedia.org/show_bug.cgi?id=73423 [18:29:43] chrismcmahon: how the link was inserted? [18:30:17] on the empty line? or it was applied to a word(s)? [18:30:30] etonkovidova: if you don't select anything, the first word on the page is used as a link [18:30:54] ok [18:32:31] so it's the word Media on http://en.wikipedia.beta.wmflabs.org/wiki/Media_Interface_VisualEditor_Test?veaction=edit [18:33:09] RoanKattouw: what is the read-only version of ssh://tparscal@gerrit.wikimedia.org:29418/oojs/core.git ? http://gerrit.wikimedia.org:29418/oojs/core.git ? [18:33:21] (03Abandoned) 10Catrope: Update VE core submodule to cherry-pick (ed45b77) [extensions/VisualEditor] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/173183 (owner: 10Jforrester) [18:33:32] RoanKattouw: Oh, yeah, why didn't you merge those? [18:33:32] TrevorParscal: https://gerrit.wikimedia.org/r/p/oojs/core.git [18:33:41] James_F: See abandonment message [18:33:48] why r/p/ ? [18:34:04] (03Abandoned) 10Catrope: Update VE core submodule to cherry-pick (c48de3e) [extensions/VisualEditor] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/173184 (owner: 10Jforrester) [18:34:10] TrevorParscal: Because. :P [18:34:12] TrevorParscal: Welcome to gerrit. [18:34:20] RoanKattouw: Fool. :-) [18:34:26] and this will change once we change to phabricator? [18:34:45] TrevorParscal: Actual answer: /r/ is the prefix path for all Gerrit web stuff, /p/ is the sub-path within that to separate UI stuff from git stuff [18:35:00] (Remember that https://gerrit.wikimedia.org/r/ serves both the web UI and git repos) [18:36:55] (03CR) 10Catrope: Use strict comparison for insertionAnnotationsChange (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173240 (owner: 10Catrope) [18:37:28] TrevorParscal: Yes, the Phabricator links will be different. [18:38:06] TrevorParscal: Both the gitblit and the gerrit links. [18:38:10] James_F: right, and that switch is happening... some day? [18:38:31] Krinkle|detached: Thanks for reviewing the getProp change. Could you also look at https://gerrit.wikimedia.org/r/#/c/172929/ ? [18:38:33] TrevorParscal: "Eventually". Probably January/February at the earliest. [18:38:51] Phabricator for bugs is happening soon, Nov 20 or 21 IIRC [18:38:54] right [18:38:56] Phabricator for code review will take longer [18:41:32] 3VisualEditor / 3Editing Tools: Link inspector does not function correctly after clicking Remove in Firefox - 10https://bugzilla.wikimedia.org/73423#c3 (10Rummana Yasmeen) I cannot reproduce this issue following these steps either. [18:43:31] edsanders: Re that jsfiddle, so the ONLY difference is the width? That's amazing and horrible. Amazingly horrible [18:44:03] RoanKattouw, yeah - if you read the bug, it's basically when it thinks that a new line has started with a new node [18:44:36] https://code.google.com/p/chromium/issues/detail?id=318925 [18:45:43] the renderer removes spaces at the start of lines, so you don't see "Foo Bar", but "FooBar" [18:45:54] but the copy code uses the latter not the former [18:46:34] because Google hire only the best of the best [18:47:15] 3OOjs UI: OOjs UI: You can't click on a scrollbar to move down a suggestions list (MenuWidget result) to pick a lower item (because it closes on click) - 10https://bugzilla.wikimedia.org/65774#c11 (10Rummana Yasmeen) Verified the fix in Betalabs [18:47:26] lol [18:47:35] Looks like it was a Webkit bug and there's a patch against Webkit [18:48:03] But it's not merged and it's 8 months old :( [18:54:02] 3VisualEditor / 3Editing Tools: Link inspector does not function correctly after clicking Remove in Firefox - 10https://bugzilla.wikimedia.org/73423#c4 (10Chris McMahon) Created attachment 17124 --> https://bugzilla.wikimedia.org/attachment.cgi?id=17124&action=edit after invoking Link inspector the first t... [18:55:01] 3VisualEditor / 3Editing Tools: Link inspector does not function correctly after clicking Remove in Firefox - 10https://bugzilla.wikimedia.org/73423#c5 (10Chris McMahon) Created attachment 17125 --> https://bugzilla.wikimedia.org/attachment.cgi?id=17125&action=edit after clicking Remove and then clicking L... [18:56:00] 3VisualEditor / 3Editing Tools: Link inspector does not function correctly after clicking Remove in Firefox - 10https://bugzilla.wikimedia.org/73423#c6 (10Chris McMahon) Created attachment 17126 --> https://bugzilla.wikimedia.org/attachment.cgi?id=17126&action=edit clicking Link no longer invokes the Link... [18:56:49] etonkovidova: ryasmeen I added screen shots to https://bugzilla.wikimedia.org/show_bug.cgi?id=73423 [18:57:03] etonkovidova: ryasmeen hopefully that will help to repro [18:59:47] 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector is appearing broken in Firefox when created as a bullet item but not on the first attempt - 10https://bugzilla.wikimedia.org/73428 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 17127 --> https://bugzilla.wikimedi... [19:03:11] kirstenMA: howdy [19:03:15] was trying to video call you [19:05:18] (03PS1) 10Esanders: Change document order of tools and actions to fix floating [oojs/ui] - 10https://gerrit.wikimedia.org/r/173331 [19:06:28] (03CR) 10Esanders: [C: 032] Follow-up 2075a46: Fix RTL image build by embedding after flipping [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173300 (owner: 10Jforrester) [19:08:34] (03Merged) 10jenkins-bot: Follow-up 2075a46: Fix RTL image build by embedding after flipping [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173300 (owner: 10Jforrester) [19:09:15] chrismcmahon: yeah, the screenshot certainly does not look right! But following the steps mentioned in the bug is not reproducing it. [19:10:49] ryasmeen: hmm. you are using Firefox? I have version 32.0.3 [19:11:36] okay I am using 33.0.2 [19:12:58] ryasmeen: and it definitely depends on not clicking in the main edit field at all to begin with, then explictly clicking the red Remove [19:14:00] 3VisualEditor / 3Editing Tools: Link inspector does not function correctly after clicking Remove in Firefox - 10https://bugzilla.wikimedia.org/73423#c7 (10Chris McMahon) FWIW, I can repro this consistently in Firefox 32.0.3 [19:14:42] ryasmeen also, I was able to mess up the styling for the Link inspector itself badly in Chrome but I do not have a consistent repro for that [19:15:32] chrismcmahon: okay! yeah there is one reported for Firefox [19:21:39] chrismcmahon: reproduced it, but it has nothing to do with remove button [19:22:07] also , you have to open the link inspector from the toolbar, opening from context menu works fine [19:22:17] so thats what was missing [19:22:25] ah, thanks! [19:22:34] I am updating the bug with the narrowed down steps, thanks! [19:22:58] ryasmeen: thank you, sorry my original report wasn't better [19:24:10] chrismcmahon: hehe, no worries! there are just so many ways to try a bug actually :) [19:27:05] hm [19:27:27] (03PS1) 10Cmcmahon: [BrowserTest] WIP remove sleeps from links test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173334 [19:28:36] edsanders, TrevorParscal hm, I'm trying to add a demo to ooui but DraggableElement and DraggableGroupElement are mixins, which means I need to add them into a new widget instance... how do I do that for the demo? Should I add empty widgets to ooui (that will not be mixins) in general and then demo those? if not, I need to create a new class, where ? [19:30:01] (03CR) 10Cmcmahon: "I am not sure this is the best approach. I have a lot of duplicated code in links_steps.rb lines 20-42. OTOH, this might be the most read" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173334 (owner: 10Cmcmahon) [19:30:25] (03PS2) 10Cmcmahon: [BrowserTest] remove sleeps from links test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173334 [19:31:46] 3VisualEditor / 3Editing Tools: Link inspector does not function correctly after clicking Remove in Firefox - 10https://bugzilla.wikimedia.org/73423#c8 (10Rummana Yasmeen) Steps to reproduce: 1.Go to this page:http://en.wikipedia.beta.wmflabs.org/wiki/Media_Interface_VisualEditor_Test?veaction=edit 2.Click... [19:32:22] (03PS1) 10Trevor Parscal: Fix documentation for getRelativeSelectableItem [oojs/ui] - 10https://gerrit.wikimedia.org/r/173335 [19:33:06] mooeypoo: I'm on the phone with Kirsten, but if you want to +2 that ^^ I'll be back in few and I can help you [19:33:10] we can video chat [19:33:20] poke Roan if you need, but it's a 1 line comment fix [19:33:27] * mooeypoo nods [19:33:30] 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector does not function correctly after closing it using "Done"/"Remove" button in Firefox while the cursor is never active on CE - 10https://bugzilla.wikimedia.org/73423 (10Rummana Yasmeen) [19:33:53] (03CR) 10Mooeypoo: [C: 032] Fix documentation for getRelativeSelectableItem [oojs/ui] - 10https://gerrit.wikimedia.org/r/173335 (owner: 10Trevor Parscal) [19:34:31] TrevorParscal, done, and not urgent with the demo, just wondering what's the best way to do it in the demo itself [19:35:49] (03Merged) 10jenkins-bot: Fix documentation for getRelativeSelectableItem [oojs/ui] - 10https://gerrit.wikimedia.org/r/173335 (owner: 10Trevor Parscal) [19:35:56] mooeypoo: ok, i'm free [19:36:28] kirstenMA: see: https://gerrit.wikimedia.org/r/173335 - fixed the docs to be a little clearer as per our convo [19:36:43] great. Thanks! [19:36:43] see: https://gerrit.wikimedia.org/r/#/c/173335/1/src/widgets/SelectWidget.js,unified [19:36:48] mooeypoo: how's it going? [19:36:55] (reading backlog) [19:37:27] mooeypoo: yeah, it's totally sensible to have a mock widget [19:37:31] or whatever [19:37:43] we do this for ProcessDialog, which is an abstract baseclass [19:38:12] at some point I guess you could make the draggable stuff be an option for SelectWidget [19:38:26] and then you could just instantiate one of those with that option [19:38:55] but for now, just make a very simple example class that uses the mixin - which will honestly be valuable for documenting how to use the mixin anyway [19:39:03] mooeypoo: yeah? [19:42:04] (03CR) 10Dduvall: [C: 031] "Looks good to me. I usually favor readability over DRY in tests (not that they're at all mutually exclusive) and I think you've struck the" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173334 (owner: 10Cmcmahon) [19:44:45] TrevorParscal, yeah I just saw that with dialog [19:45:18] 3VisualEditor / 3Data Model: VisualEditor: [Regression]Gallery gets added to the table inside the image - 10https://bugzilla.wikimedia.org/73368#c4 (10Ed Sanders) Tables inside captions are okay. They probably shouldn't be encouraged but in the cases where they exist, we need to provide the tools to edit them. [19:45:28] TrevorParscal, which do you prefer ? Should I create a SelectWidget option in ooui itself and then use it in the demo, or start out by making a mock widget in the demo and if we need to make a widget later? [19:45:43] I'm wonderin if that kind of widget may help with Category stuff but I didn't yet look at it deeply enough [19:45:52] (03CR) 10Cmcmahon: [C: 032] "merge after +1 from Dan" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173334 (owner: 10Cmcmahon) [19:47:13] (03Merged) 10jenkins-bot: [BrowserTest] remove sleeps from links test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173334 (owner: 10Cmcmahon) [19:47:23] just make the mock first [19:47:48] we need to have a use case for the select widget + draggable or we will probably screw it up and make more work for ourselves [19:47:56] * mooeypoo nods [19:48:16] TrevorParscal, the second thing that a base widget might be good for is what Krenair was talking about, regarding the addItems feature with comparison of data [19:48:28] SearchWidget does that (extends the original addItems feature) but not the others [19:48:49] So I was thinking either making this a featue in DragDropWidget *or* create yet another mixin for DataWidget or something like that [19:49:03] for all the OptionWidgets or such that require having data in them [19:49:03] I favor splitting the data part of OptionWidget into DataWidget or whatever [19:49:19] So you can have a widget with data without having to have selectable and highlightable and all that stuff [19:49:32] in the draggable element for instance, I instantiate it later (in templatedata) as an OptionWidget for the *data* feature -- but I don't use all the 'selectable' / highlight features [19:49:41] so, it works, but a DataWidget might be a better way [19:49:43] yep [19:54:29] well, all options have data [19:54:59] so, what is not an option and needs data? [19:55:17] Well, something that you want to drag and drop maybe? [19:55:37] Those things don't necessarily want to be selected or highlighted [19:57:28] (03PS1) 10Cmcmahon: [BrowserTest] modern RSpec syntax and making regexes nicer [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173345 [19:57:30] DragDrop Widget needs data but not all the other fucntionality of the optionwidget [19:59:09] (03CR) 10Catrope: [C: 032] Give table overlay width so row context positions correctly in RTL [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173288 (https://bugzilla.wikimedia.org/73378) (owner: 10Esanders) [19:59:18] 3VisualEditor / 3Data Model: VisualEditor: Non-numeric colspan/rowspan values are corrupted to NaN - 10https://bugzilla.wikimedia.org/73430 (10Roan Kattouw) 3ASSI p:3Unprio s:3normal a:3Roan Kattouw See e.g. https://fr.wikipedia.org/?diff=109114947 [19:59:37] Also, iirc, the data comparison of addItems is in SelectWidget, which for drag/drop isn't always needed.. for Categories or for the parameter order in templatedata, there's nothing actually selected -- but the comparison based on *data* is useful. That's why the idea of splitting the data functionality might be a good idea? [19:59:45] 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector is appearing broken in Firefox when created as a bullet item but not on the first attempt - 10https://bugzilla.wikimedia.org/73428#c1 (10Rummana Yasmeen) Environment:Betalabs,test2,en.wiki [20:00:07] 3VisualEditor / 3Editing Tools: VisualEditor: Table row selector is shown incorrectly in RTL - 10https://bugzilla.wikimedia.org/73378 (10James Forrester) 5PATC>3RESO/FIX p:5Unprio>3High a:3Ed Sanders [20:00:12] (03CR) 10Catrope: [C: 04-1] Fix getDirectionFromSelection to work with table selections (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173305 (owner: 10Esanders) [20:00:31] 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector does not function correctly after closing it using "Done"/"Remove" button in Firefox while the cursor is never active on CE - 10https://bugzilla.wikimedia.org/73423#c9 (10Rummana Yasmeen) Environment:betalabs,test2, en.wiki [20:01:15] (03Merged) 10jenkins-bot: Give table overlay width so row context positions correctly in RTL [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173288 (https://bugzilla.wikimedia.org/73378) (owner: 10Esanders) [20:01:20] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf4] All inspector dialog UI is broken when added inside Reference/Media Settings dialog box - 10https://bugzilla.wikimedia.org/64761 (10Rummana Yasmeen) 5VERI>3REOP [20:01:34] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf4] All inspector dialog UI is broken when added inside Reference/Media Settings dialog box - 10https://bugzilla.wikimedia.org/64761 (10Rummana Yasmeen) 5REOP>3ASSI [20:02:58] (03PS1) 10Esanders: Move hasSignificantWhitespace and handlesOwnChildren abstracts to ve.Node. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173346 [20:03:00] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf4] All inspector dialog UI is broken when added inside Reference/Media Settings dialog box - 10https://bugzilla.wikimedia.org/64761 (10Rummana Yasmeen) [20:04:08] (03CR) 10Catrope: [C: 032] Make table inserts directional [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173310 (https://bugzilla.wikimedia.org/73379) (owner: 10Esanders) [20:04:45] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf8] All inspector dialog UI is broken when added inside Reference/Media Settings dialog box - 10https://bugzilla.wikimedia.org/64761 (10Rummana Yasmeen) [20:04:49] (03CR) 10jenkins-bot: [V: 04-1] Move hasSignificantWhitespace and handlesOwnChildren abstracts to ve.Node. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173346 (owner: 10Esanders) [20:06:00] 3MediaWiki / 3ResourceLoader: CSSJanus fails to flip with !important - 10https://bugzilla.wikimedia.org/61440#c9 (10Matthew Flaschen) Step 1 is done. It's fixed in the CSSJanus upstream node.js repository. However, I realized we also need to do a node.js release and tag, since the PHP version imports the t... [20:06:59] (03PS2) 10Cmcmahon: [BrowserTest] modern RSpec syntax and making regexes nicer [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173345 [20:09:20] Right, I had forgotten how annoying JS is sometimes [20:09:23] >>> NaN === NaN [20:09:23] RoanKattouw: (boolean) false [20:09:52] (03PS5) 10Mooeypoo: Adding DraggableGroupElement and DraggableElement mixins [oojs/ui] - 10https://gerrit.wikimedia.org/r/172325 [20:09:56] (03CR) 10jenkins-bot: [V: 04-1] Adding DraggableGroupElement and DraggableElement mixins [oojs/ui] - 10https://gerrit.wikimedia.org/r/172325 (owner: 10Mooeypoo) [20:09:59] TrevorParscal, edsanders ^^ demo working [20:10:32] >>> var a = NaN; a === a; [20:10:33] Krenair: (boolean) false [20:11:06] >>> var a = NaN; a == a; [20:11:06] Krenair: (boolean) false [20:11:24] >>> !!NaN; [20:11:25] Krenair: (boolean) false [20:11:53] Krenair: So I found there is an isNaN() function [20:11:55] >>> isNaN(NaN) [20:11:55] RoanKattouw: (boolean) true [20:11:59] hah [20:12:09] But MDN warns me that it's broken, because if coerces to number first [20:12:13] >>> isNaN("23") [20:12:13] RoanKattouw: (boolean) false [20:12:15] sigh [20:12:19] >>> isNaN("23ab45") [20:12:19] RoanKattouw: (boolean) true [20:12:33] ES6 has Number.isNaN() [20:12:41] And for now they recommend simply checking x !== x [20:15:15] (03CR) 10Esanders: "getter doesn't exist yet :(" (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173305 (owner: 10Esanders) [20:16:01] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173345 (owner: 10Cmcmahon) [20:17:28] (03CR) 10jenkins-bot: [V: 04-1] [BrowserTest] modern RSpec syntax and making regexes nicer [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173345 (owner: 10Cmcmahon) [20:17:56] RoanKattouw, nor do TableSelection.fromCol, TableSelection.fromRow, Range.from, Range.start etc... [20:18:00] (03CR) 10Cmcmahon: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173345 (owner: 10Cmcmahon) [20:18:15] edsanders: Right, OK, that's fair [20:18:26] edsanders: And the tableRange is not a lazy-computed property? [20:20:09] (03CR) 10Cmcmahon: "+2 again" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173345 (owner: 10Cmcmahon) [20:20:57] that's tablenode [20:20:57] RoanKattouw: Tell edsanders what dates you wanted him to come to SF again in January as he doesn't know. I don't have anything in my e-mail… [20:21:41] James_F: Tomasz has a spreadsheet somewhere... [20:21:47] But I think I remember [20:21:55] * RoanKattouw looks at calendar [20:21:57] RoanKattouw: I'm sure he does, but I don't have it. [20:22:11] Jan 20-30 I think [20:22:30] (+ a travel day either side probably) [20:22:47] Jan 19 is MLK Day although under the new policy that's now an optional holiday [20:23:24] 19–31st WFM. [20:23:36] (03PS6) 10Mooeypoo: Adding DraggableGroupElement and DraggableElement mixins [oojs/ui] - 10https://gerrit.wikimedia.org/r/172325 [20:24:25] IIRC 20-30 (or 19-31 with travel days) was what was being discussed as the default dates for all-staff/dev summit attendees [20:24:46] Oh, that reminds me [20:25:01] I need to tell Tomasz to take mooeypoo off that list because she's booked her flight to SF now [20:25:30] He had put her on the list even though she's supposed to be local by that time, just in case [20:25:56] Oh hah I guess she hasn't actually booked them yet. Once she does, I will do that then [20:27:01] RoanKattouw: Ha. Yeah. [20:27:12] mooeypoo: Book flights! [20:27:20] * James_F grins. [20:27:22] (Moriel is sitting next to me and went "crap! I haven't done that yet, I should talk to travel") [20:27:26] Yeah she's writing an email right now [20:29:21] hey all [20:29:42] did i miss anything important? [20:32:11] (03Abandoned) 10Cmcmahon: [BrowserTest] modern RSpec syntax and making regexes nicer [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173345 (owner: 10Cmcmahon) [20:32:55] So we have this var called existingCategoryItem in MWCategoryWidget#addItems [20:33:02] (03PS1) 10Cmcmahon: [BrowserTest] RSpec update [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173355 [20:33:18] (03CR) 10Cmcmahon: [C: 032] [BrowserTest] RSpec update [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173355 (owner: 10Cmcmahon) [20:33:33] one of the issues with this function is that we don't actually assign existingCategoryItem a value other than the initial null [20:33:42] (03PS1) 10Trevor Parscal: [BREAKING CHANGE] Rename *Menu and *MenuItem widgets [oojs/ui] - 10https://gerrit.wikimedia.org/r/173356 [20:33:49] but we do check its value [20:34:00] MatmaRex: could you take a look at that ^^ [20:34:41] it's a rename of 6 things that affects 33 files [20:34:42] (03Merged) 10jenkins-bot: [BrowserTest] RSpec update [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173355 (owner: 10Cmcmahon) [20:34:55] I'll need to make some ve and vemw follow ups too [20:36:20] James_F: maybe that sounds like fun for you? lol [20:36:49] it came out in documentation writing that some of these class names are very confusing [20:36:58] TrevorParscal: woah. will give it a look [20:37:08] thanks man [20:37:20] maybe a script could be written to convert from one to the other [20:37:52] would be really helpful in generating the ve and vemw commits, as well as other commits - maybe MediaViewer is using it? not sure [20:43:34] (03PS1) 10Cmcmahon: [BrowserTest] simple upate to a nice test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173358 [20:44:14] (03CR) 10Cmcmahon: [C: 032] [BrowserTest] simple upate to a nice test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173358 (owner: 10Cmcmahon) [20:45:34] (03Merged) 10jenkins-bot: [BrowserTest] simple upate to a nice test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173358 (owner: 10Cmcmahon) [20:46:52] Krenair, you should take a loot at OO.ui.SelectWidget#addItems [20:47:25] I see that the category widget has a more complex addItems method, but SelectWidget seems to at least do the comparison of data/value before adding new items (so, the deletion is done by value) [20:47:34] I made it work, I think [20:47:46] (03PS1) 10Alex Monk: Make category widget items draggable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173360 [20:47:47] 3VisualEditor: VisualEditor: Ctrl-v of text into a pre-formatted area ends up with
added to each line - 10https://bugzilla.wikimedia.org/73433 (10Mark A. Hershberger) 3NEW p:3Unprio s:3normal a:3None I was inserting log lines into a preformatted area. It looked fine on the page, but after saving,... [20:48:24] Krenair, the ooui commit isn't merged yet, so probably good idea to state it depends on it first [20:48:40] yeah [20:49:17] (03CR) 10jenkins-bot: [V: 04-1] Make category widget items draggable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173360 (owner: 10Alex Monk) [20:49:50] (03CR) 10Alex Monk: [C: 04-2] "Depends on I859ff276" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173360 (owner: 10Alex Monk) [20:49:50] haha I love your // TODO: WTF? [20:49:54] RoanKattouw: in case no one has patted you on the back for it, working with VE is SO MUCH NICER without the iframes [20:50:16] 3VisualEditor / 3Editing Tools: VisualEditor: Table row selector is shown incorrectly in RTL - 10https://bugzilla.wikimedia.org/73378#c3 (10etonkovidova) Checked the fix in betalabs - the horizontal arrow reflect rtl and inserting columns is correct for rtl. [20:50:41] chrismcmahon: Thanks :) [20:50:49] chrismcmahon: The eventual goal is death to all the iframes [20:50:53] It'll make our code nicer too [20:51:23] also i didn't update @mixins, mooeypoo [20:51:36] RoanKattouw: awesome. I'm refactoring the whole browser test repo, it makes a big difference. I bet the code is easier to work with also [20:52:52] (03PS2) 10Alex Monk: Make category widget items draggable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173360 [20:53:16] Krenair, yeah the whole mixin thing is weird [20:53:34] it's because DraggableGroupElemenet inherits GroupElement [20:53:59] (03CR) 10jenkins-bot: [V: 04-1] Make category widget items draggable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173360 (owner: 10Alex Monk) [20:55:43] (03PS3) 10Alex Monk: Make category widget items draggable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173360 [20:56:53] (03CR) 10jenkins-bot: [V: 04-1] Make category widget items draggable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173360 (owner: 10Alex Monk) [21:04:54] (03PS1) 10Catrope: Restore original rowspan/colspan rather than normalizing or overwriting with NaN [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173363 (https://bugzilla.wikimedia.org/73430) [21:05:02] edsanders|away: ---^^ [21:07:32] 3VisualEditor / 3Data Model: VisualEditor: Non-numeric colspan/rowspan values are normalized, or corrupted to NaN - 10https://bugzilla.wikimedia.org/73430#c2 (10Roan Kattouw) It turned out there were two corruption problems: colspan="02" was normalized to colspan="2", and colspan="2 garbage" was normalized t... [21:07:53] (03CR) 10Catrope: "Once merged, this should be cherry-picked to wmf7 and wmf8" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173363 (https://bugzilla.wikimedia.org/73430) (owner: 10Catrope) [21:15:46] 3VisualEditor / 3MediaWiki integration: VisualEditor: Long lines in preformatted paragraphs should not wrap in VE - 10https://bugzilla.wikimedia.org/54381#c2 (10etonkovidova) Created attachment 17129 --> https://bugzilla.wikimedia.org/attachment.cgi?id=17129&action=edit Preformatted text in Edit- word wrap... [21:16:46] 3VisualEditor / 3MediaWiki integration: VisualEditor: Long lines in preformatted paragraphs should not wrap in VE - 10https://bugzilla.wikimedia.org/54381#c3 (10etonkovidova) Created attachment 17130 --> https://bugzilla.wikimedia.org/attachment.cgi?id=17130&action=edit Read - no word wrapping [21:17:49] James_F: Would you be OK being listed for the 4pm SWAT on Monday while I'm on a plane [21:17:50] ? [21:20:35] (03Abandoned) 10Mooeypoo: Separate appendItems from addItems in GroupElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/173105 (owner: 10Mooeypoo) [21:24:13] James_F: I've listed you https://wikitech.wikimedia.org/w/index.php?title=Deployments&diff=134560&oldid=134558 , let me know if that doesn't work for you [21:24:49] mooeypoo, also I broke other things with that commit [21:24:49] sigh [21:24:56] Krenair, oh? [21:24:58] I'm testing it now [21:25:10] I can't move categories the normal way [21:25:29] Krenair, Also, it doesn't retain the new order [21:26:02] when saving? [21:26:12] Krenair, in TemplateData I added another method to the DragGroupWidget to return an array of the *data* values of the drag objects, but that's specific for TemplateData paramOrder [21:26:37] I am not sure how the categories read their order when save [21:26:40] yeah, on save [21:32:04] (03PS1) 10Cmcmahon: [BrowserTest] remove sleep from multiedit test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173426 [21:36:12] (03PS3) 10Catrope: Use strict comparison for insertionAnnotationsChange [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173240 [21:36:39] (03PS2) 10Cmcmahon: [BrowserTest] remove sleep from multiedit test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173426 [21:37:19] (03PS47) 10Paladox: WikiEditor: Fix issue with SVG [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151611 (https://bugzilla.wikimedia.org/35342) [21:38:01] (03CR) 10jenkins-bot: [V: 04-1] Use strict comparison for insertionAnnotationsChange [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173240 (owner: 10Catrope) [21:39:04] 3VisualEditor / 3ContentEditable: VisualEditor: Tables that are inserted into Media captions will display Table caption below the table - 10https://bugzilla.wikimedia.org/73435 (10etonkovidova) 3NEW p:3Unprio s:3normal a:3None Created attachment 17131 --> https://bugzilla.wikimedia.org/attachment.c... [21:39:41] (03PS4) 10Catrope: Use strict comparison for insertionAnnotationsChange [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173240 [21:39:52] hm [21:40:30] 3VisualEditor / 3ContentEditable: VisualEditor: Tables that are inserted into Media captions will display Table caption below the table - 10https://bugzilla.wikimedia.org/73435 (10etonkovidova) p:5Unprio>3Low s:5normal>3minor [21:45:46] (03PS3) 10Cmcmahon: [BrowserTest] remove sleep from multiedit test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173426 [21:48:37] (03PS4) 10Cmcmahon: [BrowserTest] remove sleep from multiedit test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173426 [21:52:59] (03PS2) 10Catrope: Replace ve.getProp() and ve.setProp() with OO aliases [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172940 [21:53:40] (03PS1) 10Catrope: Add tests for ve.instanceOfAny() [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173432 [21:54:04] (03PS2) 10Catrope: Add getProp() and setProp() [oojs/core] - 10https://gerrit.wikimedia.org/r/172939 [21:54:25] (03CR) 10Catrope: Add getProp() and setProp() (031 comment) [oojs/core] - 10https://gerrit.wikimedia.org/r/172939 (owner: 10Catrope) [21:55:06] (03CR) 10jenkins-bot: [V: 04-1] Replace ve.getProp() and ve.setProp() with OO aliases [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172940 (owner: 10Catrope) [21:55:14] (03PS3) 10Catrope: Add getProp() and setProp() [oojs/core] - 10https://gerrit.wikimedia.org/r/172939 [21:57:43] (03PS5) 10Cmcmahon: [BrowserTest] remove sleep from multiedit test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173426 [22:02:50] RoanKattouw: Sure. [22:04:40] (03CR) 10Krinkle: [C: 04-1] Add getProp() and setProp() (031 comment) [oojs/core] - 10https://gerrit.wikimedia.org/r/172939 (owner: 10Catrope) [22:07:24] 3VisualEditor / 3Data Model: VisualEditor: [Regression]Gallery gets added to the table inside the image - 10https://bugzilla.wikimedia.org/73368#c5 (10etonkovidova) Yes, I checked the functionality of inserted tables - all is fine(a tiny bug 73435 was filed). Btw, Gallery can be dragged to a Media's Caption. [22:08:08] 3VisualEditor / 3ContentEditable: VisualEditor: Tables that are inserted into Media captions will display Table caption below the table - 10https://bugzilla.wikimedia.org/73435#c1 (10etonkovidova) Found in test2 and beta. [22:12:56] (03CR) 10Dduvall: [C: 04-1] "Looks good, aside from a minor indentation issue." (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173426 (owner: 10Cmcmahon) [22:15:24] (03CR) 10Catrope: Add getProp() and setProp() (031 comment) [oojs/core] - 10https://gerrit.wikimedia.org/r/172939 (owner: 10Catrope) [22:17:25] (03PS4) 10Catrope: Add getProp() and setProp() [oojs/core] - 10https://gerrit.wikimedia.org/r/172939 [22:18:12] (03CR) 10Catrope: Add getProp() and setProp() (031 comment) [oojs/core] - 10https://gerrit.wikimedia.org/r/172939 (owner: 10Catrope) [22:22:51] RoanKattouw: For https://gerrit.wikimedia.org/r/#/c/173305/ Ed suggested +2ing and filing as tech debt. [22:23:05] Oh, ys [22:23:08] Sorry [22:23:11] I agreed but I forgot to +2 [22:23:17] (03CR) 10Catrope: [C: 032] Fix getDirectionFromSelection to work with table selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173305 (owner: 10Esanders) [22:23:27] Thanks. :-) [22:24:02] (03CR) 10Esanders: [C: 032] Restore original rowspan/colspan rather than normalizing or overwriting with NaN [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173363 (https://bugzilla.wikimedia.org/73430) (owner: 10Catrope) [22:25:59] edsanders: Why are FileDropHandlers in ve.ui, rather than ve.dm or ve.ce? [22:26:43] RoanKattouw: I asked the same. [22:26:48] in theory they could launch a ui process (e.g. upload wizard) and only resolve when that finishes [22:26:58] Oh OK right yeah [22:27:04] * James_F nods. [22:27:08] Also currently they call createProgress on the UI surface [22:27:15] currently the take a UI.surface [22:27:16] right [22:27:58] James_F: I've found Ed's new inpsector [22:28:01] "progess" [22:28:02] (03PS2) 10Esanders: Move hasSignificantWhitespace and handlesOwnChildren abstracts to ve.Node. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173346 [22:28:06] RoanKattouw: Ha. ;-) [22:28:24] RoanKattouw: Maybe we should do an Ops-style "common typos" file and V-1 against that? [22:28:40] (I've just signed myself up for this, haven't I?) [22:29:15] Waaait [22:29:27] Why is this.reader.abort() in the child class's abort method? Why is it not in the base class? [22:30:18] (03PS6) 10Cmcmahon: [BrowserTest] remove sleep from multiedit test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173426 [22:30:52] (03CR) 10Cmcmahon: "Fixed the indent" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173426 (owner: 10Cmcmahon) [22:31:20] (03Merged) 10jenkins-bot: Fix getDirectionFromSelection to work with table selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173305 (owner: 10Esanders) [22:32:20] (03CR) 10Dduvall: [C: 031] [BrowserTest] remove sleep from multiedit test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173426 (owner: 10Cmcmahon) [22:32:30] (03Merged) 10jenkins-bot: Make table inserts directional [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173310 (https://bugzilla.wikimedia.org/73379) (owner: 10Esanders) [22:32:35] 3VisualEditor / 3Editing Tools: VisualEditor: Table column adding icon must be flipped for RTL - 10https://bugzilla.wikimedia.org/73379 (10James Forrester) 5PATC>3RESO/FIX p:5Unprio>3High [22:34:12] (03CR) 10Cmcmahon: [C: 032] "merged after +1 from Dan" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173426 (owner: 10Cmcmahon) [22:35:32] (03Merged) 10jenkins-bot: [BrowserTest] remove sleep from multiedit test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173426 (owner: 10Cmcmahon) [22:37:11] (03Merged) 10jenkins-bot: Restore original rowspan/colspan rather than normalizing or overwriting with NaN [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173363 (https://bugzilla.wikimedia.org/73430) (owner: 10Catrope) [22:37:13] Finally! [22:37:22] (03PS1) 10Jforrester: Restore original rowspan/colspan rather than normalizing or overwriting with NaN [VisualEditor/VisualEditor] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/173439 [22:37:34] RoanKattouw_away: ^^^ Doesn't neatly cherry-pick to wmf/1.25wmf7 [22:37:39] * James_F tries it manually. [22:40:12] (03PS1) 10Esanders: Don't allow dropping inside a handlesOwnChildren node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173442 [22:48:06] (03PS1) 10Jforrester: Restore original rowspan/colspan rather than normalizing or overwriting with NaN [VisualEditor/VisualEditor] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/173443 [22:48:53] RoanKattouw_away: There, https://gerrit.wikimedia.org/r/#/c/173439/ and https://gerrit.wikimedia.org/r/#/c/173443/ – please review and +2 as appropriate. Note that the latter is manually made by me so needs extra review. ;-) [22:52:54] (03PS1) 10Cmcmahon: [BrowserTest] update references test for modern RSpec syntax [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173444 [22:54:09] James_F, an Ops-style "common typos" file? [22:54:33] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173444 (owner: 10Cmcmahon) [22:54:39] (03PS4) 10Alex Monk: [WIP] Make category widget items draggable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173360 [22:55:53] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Make category widget items draggable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173360 (owner: 10Alex Monk) [22:56:05] (03Merged) 10jenkins-bot: [BrowserTest] update references test for modern RSpec syntax [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173444 (owner: 10Cmcmahon) [22:56:28] (03CR) 10Esanders: [C: 032] Use strict comparison for insertionAnnotationsChange [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173240 (owner: 10Catrope) [22:58:26] (03Merged) 10jenkins-bot: Use strict comparison for insertionAnnotationsChange [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173240 (owner: 10Catrope) [23:00:34] 3VisualEditor / 3ContentEditable: VisualEditor: Inserted Media caption is not displayed correctly - 10https://bugzilla.wikimedia.org/73441 (10etonkovidova) 3NEW p:3Unprio s:3normal a:3None Created attachment 17133 --> https://bugzilla.wikimedia.org/attachment.cgi?id=17133&action=edit Caption withou... [23:00:38] 3VisualEditor / 3Data Model: VisualEditor: Non-numeric colspan/rowspan values are normalized, or corrupted to NaN - 10https://bugzilla.wikimedia.org/73430#c4 (10James Forrester) 5PATC>3RESO/FIX p:5Unprio>3High s:5normal>3major To go out in Monday's SWAT. [23:55:45] kirstenMA: fyi, I replaced OO.js UI with OOjs UI [23:55:52] technically the . is not part of the name [23:56:05] okay. thanks! [23:59:21] 3VisualEditor / 3Data Model: VisualEditor: Non-numeric colspan/rowspan values are normalized, or corrupted to NaN - 10https://bugzilla.wikimedia.org/73430#c5 (10etonkovidova) Verified the fix in beta.