[00:07:21] 3VisualEditor: VisualEditor: Letters getting added and duplicated on pages featuring chess templates - 10https://bugzilla.wikimedia.org/71404#c2 (10Alex Monk) 5NEW>3RESO/WOR Please reopen if you manage to reproduce this issue again. [00:09:52] 3VisualEditor / 3ContentEditable: VisualEditor: Copy paste is not working for Math elements - 10https://bugzilla.wikimedia.org/58981#c3 (10Alex Monk) 5ASSI>3RESO/FIX This... Appears to work now. [00:13:20] 3VisualEditor / 3Editing Tools: VisualEditor: Disable "Remove" button in link inspector if in link creation mode - 10https://bugzilla.wikimedia.org/69359#c3 (10Alex Monk) Maybe relabel it "Cancel" instead in this case? [00:14:35] 3VisualEditor / 3Editing Tools: VisualEditor: There should be help links in every context - dialog boxes, inspectors, etc. - 10https://bugzilla.wikimedia.org/51798#c17 (10Alex Monk) Did we get any feedback? [00:16:51] 3MediaWiki / 3Page editing: doesn't respect DISPLAYTITLE - 10https://bugzilla.wikimedia.org/49667#c4 (10Alex Monk) a:3None Moving to MW core. [00:17:20] <wikibugs> 3MediaWiki / 3Page editing: <title> of editing page doesn't respect DISPLAYTITLE - 10https://bugzilla.wikimedia.org/49667 (10Alex Monk) [00:18:36] <wikibugs> 3VisualEditor: VisualEditor won't start - With correct config - 10https://bugzilla.wikimedia.org/64428 (10Alex Monk) 5UNCO>3RESO/WOR [00:23:36] <wikibugs> 3VisualEditor: VisualEditor: Removal of template when adding reference list - 10https://bugzilla.wikimedia.org/53114#c2 (10Alex Monk) 5NEW>3RESO/FIX Cannot reproduce. This must have been fixed at some point. I wonder if it was a Parsoid issue... [00:29:51] <wikibugs> 3VisualEditor / 3ContentEditable: VisualEditor: Pawn ♙ appears after deleting the text preceding and following a link by "undo" action - 10https://bugzilla.wikimedia.org/61521#c5 (10Alex Monk) 5REOP>3RESO/FIX Tried again, seems fixed. [00:31:07] <wikibugs> 3VisualEditor: FlaggablePageView::setPageContent() called incorrectly - 10https://bugzilla.wikimedia.org/73469 (10Alex Monk) [00:31:09] <wikibugs> 3VisualEditor: FlaggablePageView::setPageContent() called incorrectly - 10https://bugzilla.wikimedia.org/73469 (10Alex Monk) 5NEW>3ASSI a:3Alex Monk [00:57:07] <wikibugs> 3VisualEditor: PHP notice in hhvm.log - 10https://bugzilla.wikimedia.org/73463 (10Alex Monk) [00:57:08] <wikibugs> 3VisualEditor: PHP notice in hhvm.log - 10https://bugzilla.wikimedia.org/73463 (10Alex Monk) 5NEW>3ASSI a:3Alex Monk [01:10:18] <grrrit-wm> (03PS1) 10Alex Monk: Don't try to get newtimestamp from edit if no change was made [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173747 (https://bugzilla.wikimedia.org/73463) [01:19:55] <grrrit-wm> (03PS1) 10Alex Monk: On save, if there was no 'last modified' text at the bottom of the page, add it [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173748 [01:29:17] <grrrit-wm> (03PS1) 10Alex Monk: Stop warnings about calling FlaggablePageView::setPageContent with no parameters [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173749 (https://bugzilla.wikimedia.org/73469) [01:33:20] <wikibugs> 3VisualEditor / 3Data Model: VisualEditor: "Uncaught TypeError: Cannot read property 'getRange' of undefined" when unmerging cells - 10https://bugzilla.wikimedia.org/73223 (10Alex Monk) 5NEW>3ASSI [01:33:40] <grrrit-wm> (03CR) 10Bartosz Dziewoński: [C: 032] Preview: Add content clears after side-by-side preview [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/172318 (owner: 10TheDJ) [01:33:45] <grrrit-wm> (03Merged) 10jenkins-bot: Preview: Add content clears after side-by-side preview [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/172318 (owner: 10TheDJ) [01:35:42] <wikibugs> 3VisualEditor: VisualEditor: Newly added template added with "Template:" prefix - 10https://bugzilla.wikimedia.org/73179#c1 (10Alex Monk) 5NEW>3RESO/FIX a:3Roan Kattouw Should've been fixed by Roan in Gerrit change 172319. [01:35:44] <grrrit-wm> (03CR) 10Alex Monk: "Fixed bug 73179" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/172319 (owner: 10Catrope) [01:44:22] <wikibugs> 3VisualEditor / 3Editing Tools: VisualEditor: Permit sorting of categories (drag-and-drop?) - 10https://bugzilla.wikimedia.org/50809#c2 (10Alex Monk) Is this Gerrit change 173360 ? [02:01:21] <wikibugs> 3VisualEditor / 3Data Model: VisualEditor: <u><u> created, and meta-data removed, from [[Bahá'u'lláh]] on edit - 10https://bugzilla.wikimedia.org/50481#c2 (10Alex Monk) Do we know how this was caused, how to reproduce the issue, if VE was even responsible for it (rather than Parsoid), or if it's since been f... [02:20:50] <wikibugs> 3VisualEditor / 3ContentEditable: VisualEditor: Display name of transclusions as a tool-tip when selected - 10https://bugzilla.wikimedia.org/51824#c3 (10Alex Monk) Don't we have this now? What to do about this bug? [10:25:21] <grrrit-wm> (03PS1) 10Amire80: Add lang and dir attributes to the accelerator element [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173772 [10:26:20] <grrrit-wm> (03PS2) 10Amire80: Add lang and dir attributes to the accelerator element [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173772 [10:55:22] <grrrit-wm> (03PS3) 10Amire80: Add lang and dir attributes to the accelerator element [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173772 [11:42:31] <grrrit-wm> (03PS48) 10Paladox: WikiEditor: Fix issue with SVG [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151611 (https://bugzilla.wikimedia.org/35342) [11:44:36] <grrrit-wm> (03PS49) 10Paladox: WikiEditor: Re add SVG [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151611 (https://bugzilla.wikimedia.org/35342) [11:44:52] <grrrit-wm> (03PS50) 10Paladox: WikiEditor: Re add SVG [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151611 [11:45:00] <grrrit-wm> (03PS51) 10Paladox: WikiEditor: Re add SVG [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151611 (https://bugzilla.wikimedia.org/35342) [11:47:41] <grrrit-wm> (03PS9) 10Paladox: Added "search and replace within selection" functionality [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/87322 (owner: 10Netbrain) [11:48:03] <grrrit-wm> (03PS10) 10Paladox: Added "search and replace within selection" functionality [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/87322 (https://bugzilla.wikimedia.org/54961) (owner: 10Netbrain) [11:48:28] <grrrit-wm> (03PS11) 10Paladox: Added "search and replace within selection" functionality [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/87322 (https://bugzilla.wikimedia.org/54961) (owner: 10Netbrain) [12:05:12] <grrrit-wm> (03PS3) 10Paladox: Reformat the license warning only if available [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/98249 (owner: 10Dev-zero) [12:05:28] <grrrit-wm> (03PS4) 10Paladox: Reformat the license warning only if available [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/98249 (owner: 10Dev-zero) [12:52:06] <grrrit-wm> (03CR) 10Paladox: "this can be closed was added in https://gerrit.wikimedia.org/r/#/c/115349/" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/115378 (https://bugzilla.wikimedia.org/61910) (owner: 10Gerrit Patch Uploader) [12:58:05] <grrrit-wm> (03CR) 10Paladox: [C: 04-1] Workaround for a scrolling bug in IE8 on resize [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/115378 (https://bugzilla.wikimedia.org/61910) (owner: 10Gerrit Patch Uploader) [12:59:07] <wikibugs> 3VisualEditor: Selecting huge chunks of text with Shift + arrow up/down is broken or works inconsistently - 10https://bugzilla.wikimedia.org/73512 (10Elitre) 3NEW p:3Unprio s:3normal a:3None See video made by de.wp user:Gnom: https://www.youtube.com/watch?v=Dm_WyFfMC1M "Trying to mark a big chunk of t... [12:59:17] <grrrit-wm> (03PS4) 10Paladox: Change location of Search-Replace Link adjacent to Insert Links [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/149925 (https://bugzilla.wikimedia.org/23824) (owner: 10Gerrit Patch Uploader) [13:02:05] <wikibugs> 3VisualEditor: Selecting huge chunks of text with Shift + arrow up/down is broken or works inconsistently - 10https://bugzilla.wikimedia.org/73512#c1 (10Elitre) *after the 3rd time or so you /hit/ the up or down arrows. [13:02:52] <wikibugs> 3VisualEditor: Selecting huge chunks of text with Shift + arrow up/down is broken or works inconsistently - 10https://bugzilla.wikimedia.org/73512#c2 (10Elitre) *I'm not entirely /sure/ of what should be the expected outcome there. [13:12:02] <grrrit-wm> (03PS1) 10Esanders: Don't always use updateDimensionsDebounced [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173804 (https://bugzilla.wikimedia.org/73242) [13:16:04] <grrrit-wm> (03PS1) 10Esanders: Remove data-parsoid removal hack [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173805 (https://bugzilla.wikimedia.org/72426) [13:36:57] <grrrit-wm> (03PS1) 10Esanders: Create 'preserveGenerated' mode for cloneElements and use in copy [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173807 (https://bugzilla.wikimedia.org/72426) [13:39:48] <grrrit-wm> (03PS1) 10Esanders: Make changes to comment node before apply staging stack [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173808 (https://bugzilla.wikimedia.org/72315) [13:40:50] <grrrit-wm> (03Abandoned) 10Zfilipin: Fixed whitespace that RuboCop did not ignore [oojs/ui] - 10https://gerrit.wikimedia.org/r/172719 (https://bugzilla.wikimedia.org/72841) (owner: 10Zfilipin) [13:41:52] <grrrit-wm> (03Abandoned) 10Zfilipin: Fixed RuboCop Style/CommentIndentation offense [oojs/ui] - 10https://gerrit.wikimedia.org/r/172738 (https://bugzilla.wikimedia.org/72841) (owner: 10Zfilipin) [13:46:15] <grrrit-wm> (03PS4) 10Esanders: Safari copy-paste fix [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173256 (https://bugzilla.wikimedia.org/71718) [13:54:01] <grrrit-wm> (03PS1) 10Esanders: Apply comment changes using fragment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173812 (https://bugzilla.wikimedia.org/71706) [14:06:26] <grrrit-wm> (03CR) 10Zfilipin: "Done: https://gerrit.wikimedia.org/r/#/c/173813/" [oojs/ui] - 10https://gerrit.wikimedia.org/r/172716 (https://bugzilla.wikimedia.org/72841) (owner: 10Zfilipin) [14:27:24] <grrrit-wm> (03CR) 10Fomafix: "https://gerrit.wikimedia.org/r/115349 solves a different bug." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/115378 (https://bugzilla.wikimedia.org/61910) (owner: 10Gerrit Patch Uploader) [14:45:31] <grrrit-wm> (03CR) 10Paladox: "Oh ok" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/115378 (https://bugzilla.wikimedia.org/61910) (owner: 10Gerrit Patch Uploader) [15:18:50] <wikibugs> 3VisualEditor / 3Data Model: VisualEditor: [Regression wmf1] Increasing indentation to a bullet/numbered list is also adding a slug with a new bullet/numbered point each time - 10https://bugzilla.wikimedia.org/71134#c8 (10Ed Sanders) Recommend wontfix. There's no regular case to start a list at double indent... [15:19:07] <grrrit-wm> (03PS3) 10Esanders: WIP Failing test case [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158662 (https://bugzilla.wikimedia.org/70375) [15:21:17] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] WIP Failing test case [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158662 (https://bugzilla.wikimedia.org/70375) (owner: 10Esanders) [15:26:03] <grrrit-wm> (03PS1) 10Esanders: Initialize mobile context as visible [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173829 [16:08:06] * James_F waves [16:09:08] <grrrit-wm> (03PS1) 10Cmcmahon: [BrowserTest] interim step to alphabetize [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173835 [16:10:33] <grrrit-wm> (03CR) 10Jforrester: "recheck" [oojs/ui] - 10https://gerrit.wikimedia.org/r/172716 (https://bugzilla.wikimedia.org/72841) (owner: 10Zfilipin) [16:10:49] <James_F> Ha, I'm a fool. [16:12:11] <grrrit-wm> (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173835 (owner: 10Cmcmahon) [16:13:35] <grrrit-wm> (03Merged) 10jenkins-bot: [BrowserTest] interim step to alphabetize [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173835 (owner: 10Cmcmahon) [16:20:43] <grrrit-wm> (03PS1) 10Cmcmahon: [BrowserTest] update for RSpec3 syntax [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173838 [16:23:50] <wikibugs> 3VisualEditor / 3ContentEditable: VisualEditor: Editing window does not scroll when dragging - 10https://bugzilla.wikimedia.org/51669#c11 (10Elitre) So I'm not sure I'm adding to the right bug, but I don't seem to be able to drag templates or images beyond the bottom of the window (and even beyond the top wh... [16:24:05] <wikibugs> 3VisualEditor / 3ContentEditable: VisualEditor: Editing window does not scroll when dragging - 10https://bugzilla.wikimedia.org/51669 (10Elitre) [16:24:07] <wikibugs> 3VisualEditor / 3ContentEditable: VisualEditor: Drag-and-drop in IE doesn't work (?) - 10https://bugzilla.wikimedia.org/73240 (10Elitre) [16:27:46] <grrrit-wm> (03CR) 10Hashar: "check experimental" [oojs/ui] - 10https://gerrit.wikimedia.org/r/172716 (https://bugzilla.wikimedia.org/72841) (owner: 10Zfilipin) [16:28:28] <grrrit-wm> (03CR) 10Hashar: "Needs to be rebased and whatever issue has been introduced to be ignored again :)" [oojs/ui] - 10https://gerrit.wikimedia.org/r/172716 (https://bugzilla.wikimedia.org/72841) (owner: 10Zfilipin) [16:39:36] <grrrit-wm> (03PS2) 10Jforrester: Prepare repository for RuboCop [oojs/ui] - 10https://gerrit.wikimedia.org/r/172716 (https://bugzilla.wikimedia.org/72841) (owner: 10Zfilipin) [16:48:01] <grrrit-wm> (03CR) 10Jforrester: "check experimental" [oojs/ui] - 10https://gerrit.wikimedia.org/r/172716 (https://bugzilla.wikimedia.org/72841) (owner: 10Zfilipin) [16:57:18] <Krenair> edsanders, maybe I'm missing something, but in https://gerrit.wikimedia.org/r/#/c/173808/1 what is that extra parameter to cloneElements supposed to do? [16:58:02] <Krenair> Isn't that call to ve.dm.ElementLinearData#cloneElements, which takes no parameters? [17:06:36] <wikibugs> 3VisualEditor / 3Data Model: VisualEditor: [Regression wmf1] Increasing indentation to a bullet/numbered list is also adding a slug with a new bullet/numbered point each time - 10https://bugzilla.wikimedia.org/71134#c9 (10James Forrester) 5ASSI>3RESO/WON (In reply to Ed Sanders from comment #8) > Recomme... [17:10:51] <grrrit-wm> (03CR) 10Cmcmahon: [C: 031] "Suggestions for improving the last two Then steps welcome. I don't really have any good ideas, I am willing to merge as is." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173838 (owner: 10Cmcmahon) [17:22:31] <mooeypoo> James_F, is there an already known problem with CheckboxInputWidget (or ooui in general? seems perhaps SVG?) in Opera? [17:22:52] <wikibugs> 3VisualEditor / 3Editing Tools: VisualEditor: Permit sorting of categories (drag-and-drop?) - 10https://bugzilla.wikimedia.org/50809#c3 (10James Forrester) a:3Alex Monk (In reply to Alex Monk from comment #2) > Is this Gerrit change #173360 ? Yes. [17:22:57] <mooeypoo> I'm not finding it on bugzilla easily [17:23:03] <James_F> mooeypoo: Beyond "Opera sucks"? [17:23:19] <James_F> mooeypoo: (Not really.) [17:23:45] <grrrit-wm> (03CR) 10Jforrester: [WIP] Make category widget items draggable (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173360 (owner: 10Alex Monk) [17:24:01] <mooeypoo> James_F, there seems to be issues with CSS in opera? I'm trying to make sense of what's going on here: https://hu.wikipedia.org/wiki/Wikip%C3%A9dia:Kocsmafal_(m%C5%B1szaki)#Hiba (see the log) [17:24:22] <mooeypoo> "Invalid value for property: transform" [17:24:35] <mooeypoo> "Invalid value for property: -webkit-transform" etc [17:24:48] <mooeypoo> seems an issue with css rules... which.. I think is not surprising [17:29:10] <mooeypoo> RoanKattouw, ah! you're there. [17:29:15] <mooeypoo> RoanKattouw, arrived on time, I assume? [17:29:33] <RoanKattouw> mooeypoo: Yeah [17:29:35] <RoanKattouw> Also, free AirTrain ride :) [17:29:37] <RoanKattouw> And therefore a $0 MetroCard [17:29:41] <mooeypoo> ooh! [17:29:45] <mooeypoo> free? really? how? [17:29:57] <RoanKattouw> (AirTrain within the airport was down, so they gave free rides from Jamaica to Federal Circle then put people on buses to the terminals) [17:30:04] <James_F> RoanKattouw: Ha. [17:30:04] <mooeypoo> Good that you didn't pay for it yesterday [17:30:11] <RoanKattouw> Yeah! [17:30:11] <mooeypoo> oh nice [17:30:28] <James_F> RoanKattouw: BTW, https://gerrit.wikimedia.org/r/#/q/status:open+project:VisualEditor/VisualEditor+-branch:master,n,z *cough* [17:30:40] <wm-ve-needcheck> Corruption alert: visualeditor-needcheck on svwiki: https://sv.wikipedia.org/?diff=28734122 [17:30:40] <wm-ve-needcheck> Corruption alert: visualeditor-needcheck on svwiki: https://sv.wikipedia.org/?diff=28734131 [17:30:40] <wm-ve-needcheck> Corruption alert: visualeditor-needcheck on lawiki: https://la.wikipedia.org/?diff=2806415 [17:30:40] <wm-ve-needcheck> Corruption alert: visualeditor-needcheck on lawiki: https://la.wikipedia.org/?diff=2806416 [17:30:40] <wm-ve-needcheck> Corruption alert: visualeditor-needcheck on lawiki: https://la.wikipedia.org/?diff=2806417 [17:30:41] <wm-ve-needcheck> Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=66830004 [17:30:41] <wm-ve-needcheck> Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=66845280 [17:30:42] <wm-ve-needcheck> Corruption alert: visualeditor-needcheck on cawiki: https://ca.wikipedia.org/?diff=14303264 [17:30:42] <wm-ve-needcheck> Corruption alert: visualeditor-needcheck on plwiki: https://pl.wikipedia.org/?diff=40973147 [17:30:43] <wm-ve-needcheck> Corruption alert: visualeditor-needcheck on plwiki: https://pl.wikipedia.org/?diff=40980180 [17:30:43] <wm-ve-needcheck> Corruption alert: visualeditor-needcheck on itwiki: https://it.wikipedia.org/?diff=69190720 [17:30:44] <wm-ve-needcheck> Corruption alert: visualeditor-needcheck on itwiki: https://it.wikipedia.org/?diff=69193241 [17:30:44] <wm-ve-needcheck> Corruption alert: visualeditor-needcheck on itwiki: https://it.wikipedia.org/?diff=69199002 [17:30:45] <wm-ve-needcheck> Corruption alert: visualeditor-needcheck on itwiki: https://it.wikipedia.org/?diff=69199053 [17:30:51] <James_F> Eurgh. [17:30:55] <mooeypoo> whoops [17:34:53] <wikibugs> 3OOjs UI: OOjs UI: trouble with CheckboxInputWidget in Opera - 10https://bugzilla.wikimedia.org/73517 (10Elitre) 3NEW p:3Unprio s:3normal a:3None User:Tacsipacsi at the Hungarian Wikipedia reports issues with "the new buttons" and provides the following log: [2014.11.15. 14:41:15] CSS - https://tools.... [17:38:38] <RoanKattouw> mooeypoo: It's quite common for browsers to complain about "invalid" CSS, especially when using vendor prefixes or CSS that's newer than what they understand [17:39:01] <mooeypoo> RoanKattouw, hm, yeah, but in this case the user seems to complain that the widget isn't working [17:39:03] <RoanKattouw> It's harmless though. As long as the CSS is syntactically valid (i.e. property: value;), browsers skip things they don't understand and still process everything else [17:39:09] <RoanKattouw> OK that would be bad [17:40:11] <mooeypoo> yeah he's saying he can't use the CheckboxInputWidget in Opera, and attaches the log... the log may be not the souce of the issue, though. [17:41:57] <RoanKattouw> James_F: That cherry-pick conflict, was it something trivial? From the diff I can't quite tell what it would have been [17:42:53] <grrrit-wm> (03CR) 10Catrope: [C: 032] Restore original rowspan/colspan rather than normalizing or overwriting with NaN [VisualEditor/VisualEditor] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/173443 (owner: 10Jforrester) [17:42:57] <grrrit-wm> (03CR) 10Catrope: [C: 032] Restore original rowspan/colspan rather than normalizing or overwriting with NaN [VisualEditor/VisualEditor] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/173439 (owner: 10Jforrester) [17:45:03] <grrrit-wm> (03Merged) 10jenkins-bot: Restore original rowspan/colspan rather than normalizing or overwriting with NaN [VisualEditor/VisualEditor] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/173443 (owner: 10Jforrester) [17:45:10] <grrrit-wm> (03Merged) 10jenkins-bot: Restore original rowspan/colspan rather than normalizing or overwriting with NaN [VisualEditor/VisualEditor] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/173439 (owner: 10Jforrester) [17:45:15] <grrrit-wm> (03CR) 10Catrope: [C: 032] core: Add getProp() and setProp() methods [oojs/core] - 10https://gerrit.wikimedia.org/r/172939 (owner: 10Catrope) [17:46:11] <grrrit-wm> (03CR) 10Catrope: [C: 032] Stop warnings about calling FlaggablePageView::setPageContent with no parameters [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173749 (https://bugzilla.wikimedia.org/73469) (owner: 10Alex Monk) [17:46:55] <grrrit-wm> (03CR) 10Catrope: [C: 032] On save, if there was no 'last modified' text at the bottom of the page, add it [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173748 (owner: 10Alex Monk) [17:47:15] <grrrit-wm> (03CR) 10Catrope: [C: 032] Don't try to get newtimestamp from edit if no change was made [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173747 (https://bugzilla.wikimedia.org/73463) (owner: 10Alex Monk) [17:47:21] <wikibugs> 3VisualEditor / 3MediaWiki integration: VisualEditor: FlaggablePageView::setPageC ontent() called incorrectly - 10https://bugzilla.wikimedia.org/73469 (10James Forrester) 5PATC>3RESO/FIX p:5Unprio>3Low s:5normal>3trivia [17:47:38] <James_F> RoanKattouw: It was pretty trivial, yeah; Ed changed the check from ! foo to foo !== 1. [17:47:38] <grrrit-wm> (03Merged) 10jenkins-bot: Stop warnings about calling FlaggablePageView::setPageContent with no parameters [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173749 (https://bugzilla.wikimedia.org/73469) (owner: 10Alex Monk) [17:47:40] <grrrit-wm> (03CR) 10Catrope: [C: 032] Initialize mobile context as visible [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173829 (owner: 10Esanders) [17:47:47] <RoanKattouw> James_F: Aaah OK [17:48:04] <RoanKattouw> James_F: Also https://gerrit.wikimedia.org/r/173829 should possibly be cherry-picked? It looks like it fixes a regression from a commit that IIRC was cherry-picked [17:48:35] * James_F looks. [17:48:36] <wikibugs> 3VisualEditor / 3MediaWiki integration: VisualEditor: Undefined index: newtimestamp in …/ApiVisualEditorEdit.php - 10https://bugzilla.wikimedia.org/73463 (10James Forrester) 5PATC>3RESO/FIX p:5Unprio>3Normal s:5normal>3minor [17:48:46] <grrrit-wm> (03Merged) 10jenkins-bot: Don't try to get newtimestamp from edit if no change was made [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173747 (https://bugzilla.wikimedia.org/73463) (owner: 10Alex Monk) [17:48:51] <James_F> RoanKattouw: I guess. [17:48:52] <grrrit-wm> (03Merged) 10jenkins-bot: On save, if there was no 'last modified' text at the bottom of the page, add it [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173748 (owner: 10Alex Monk) [17:49:01] <grrrit-wm> (03PS1) 10Jforrester: Initialize mobile context as visible [VisualEditor/VisualEditor] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/173853 [17:49:08] <grrrit-wm> (03PS1) 10Jforrester: Initialize mobile context as visible [VisualEditor/VisualEditor] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/173854 [17:49:10] <grrrit-wm> (03CR) 10Catrope: [C: 04-1] Make changes to comment node before apply staging stack (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173808 (https://bugzilla.wikimedia.org/72315) (owner: 10Esanders) [17:49:17] <grrrit-wm> (03CR) 10Catrope: [C: 032] Initialize mobile context as visible [VisualEditor/VisualEditor] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/173853 (owner: 10Jforrester) [17:49:25] <grrrit-wm> (03CR) 10Catrope: [C: 032] Initialize mobile context as visible [VisualEditor/VisualEditor] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/173854 (owner: 10Jforrester) [17:49:34] <grrrit-wm> (03Merged) 10jenkins-bot: core: Add getProp() and setProp() methods [oojs/core] - 10https://gerrit.wikimedia.org/r/172939 (owner: 10Catrope) [17:49:54] <grrrit-wm> (03Merged) 10jenkins-bot: Initialize mobile context as visible [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173829 (owner: 10Esanders) [17:50:02] <grrrit-wm> (03CR) 10Catrope: [C: 032] Update RangeFix library 0.1.0 -> 0.1.1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173007 (https://bugzilla.wikimedia.org/73336) (owner: 10Esanders) [17:53:15] <grrrit-wm> (03Merged) 10jenkins-bot: Initialize mobile context as visible [VisualEditor/VisualEditor] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/173853 (owner: 10Jforrester) [17:53:17] <grrrit-wm> (03Merged) 10jenkins-bot: Initialize mobile context as visible [VisualEditor/VisualEditor] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/173854 (owner: 10Jforrester) [17:53:20] <grrrit-wm> (03Merged) 10jenkins-bot: Update RangeFix library 0.1.0 -> 0.1.1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173007 (https://bugzilla.wikimedia.org/73336) (owner: 10Esanders) [17:53:52] <wikibugs> 3VisualEditor / 3ContentEditable: VisualEditor: Link inspector opens in a upper left corner in Safari - 10https://bugzilla.wikimedia.org/73336 (10James Forrester) 5PATC>3RESO/FIX p:5Unprio>3Normal [17:54:31] <James_F> RoanKattouw: You going to write a text update for the team? [17:55:13] <RoanKattouw> No I found a cell phone use / changing room in the lounge [17:55:24] <RoanKattouw> And no one is using it because a changing room with a broken lock is not very useful :D [17:55:44] <grrrit-wm> (03PS1) 10Jforrester: Update VE core submodule to master (d418c99) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173859 [17:55:53] <James_F> RoanKattouw: Ha. [17:55:59] <James_F> RoanKattouw: ^^^ Please +2. [17:56:56] <grrrit-wm> (03CR) 10Catrope: [C: 032] Update VE core submodule to master (d418c99) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173859 (owner: 10Jforrester) [17:57:17] <James_F> Ta. [17:57:34] <James_F> RoanKattouw: https://gerrit.wikimedia.org/r/#/c/172748/ :-) [17:57:45] <RoanKattouw> Yes :) [17:58:01] <grrrit-wm> (03CR) 10Jforrester: [C: 032] Document hasOwn optimisation [oojs/core] - 10https://gerrit.wikimedia.org/r/173521 (owner: 10Krinkle) [17:58:13] <James_F> RoanKattouw: Is https://gerrit.wikimedia.org/r/#/c/172929/ going to make release? [17:58:17] <RoanKattouw> I got 1/5 of the way through reviewing one of the other commits in that stack on Friday, will finish on the plane [17:58:22] <grrrit-wm> (03Merged) 10jenkins-bot: Update VE core submodule to master (d418c99) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173859 (owner: 10Jforrester) [17:58:24] <James_F> OK. [17:58:31] <RoanKattouw> James_F: I would like it to, but bug Timo [17:58:35] <James_F> It's not a tall stack. :-) [17:58:43] <RoanKattouw> He hasn't even looked at that change yet [17:58:47] <James_F> RoanKattouw: Sure. Oi, edsanders? [17:58:53] <MatmaRex_mobile> hi. [17:59:21] <edsanders> wat [18:02:47] <grrrit-wm> (03Merged) 10jenkins-bot: Document hasOwn optimisation [oojs/core] - 10https://gerrit.wikimedia.org/r/173521 (owner: 10Krinkle) [18:09:25] <grrrit-wm> (03CR) 10Catrope: [C: 032] Apply comment changes using fragment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173812 (https://bugzilla.wikimedia.org/71706) (owner: 10Esanders) [18:10:09] <grrrit-wm> (03CR) 10Esanders: Make changes to comment node before apply staging stack (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173808 (https://bugzilla.wikimedia.org/72315) (owner: 10Esanders) [18:10:21] <grrrit-wm> (03PS1) 10Esanders: Move mobile ContextItemWidget hacks into separate class [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173865 [18:11:36] <grrrit-wm> (03PS2) 10Esanders: Make changes to comment node before apply staging stack [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173808 (https://bugzilla.wikimedia.org/72315) [18:11:38] <grrrit-wm> (03PS2) 10Esanders: Apply comment changes using fragment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173812 (https://bugzilla.wikimedia.org/71706) [18:12:15] <grrrit-wm> (03PS2) 10Esanders: Create 'preserveGenerated' mode for cloneElements and use in copy [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173807 (https://bugzilla.wikimedia.org/72426) [18:12:27] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Move mobile ContextItemWidget hacks into separate class [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173865 (owner: 10Esanders) [18:13:39] <grrrit-wm> (03CR) 10Catrope: [C: 032] Make changes to comment node before apply staging stack [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173808 (https://bugzilla.wikimedia.org/72315) (owner: 10Esanders) [18:15:54] <grrrit-wm> (03Merged) 10jenkins-bot: Make changes to comment node before apply staging stack [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173808 (https://bugzilla.wikimedia.org/72315) (owner: 10Esanders) [18:15:59] <grrrit-wm> (03Merged) 10jenkins-bot: Apply comment changes using fragment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173812 (https://bugzilla.wikimedia.org/71706) (owner: 10Esanders) [18:18:22] <RoanKattouw> For those of you that missed the standup or missed me saying it in the standup: [18:18:44] <RoanKattouw> It's airplane time! Allegedly there will be wifi on the plane, so I will attempt to be on line, but it will be text-only and possibly flaky [18:19:31] <RoanKattouw> I should be on IRC from the air from about 11:30am until 5pm PST [18:19:51] <mooeypoo> Is this the mile hi-r-c club? [18:20:36] <grrrit-wm> (03CR) 10Trevor Parscal: [C: 032] Explicitly bypass undefined values in oo.compare() [oojs/core] - 10https://gerrit.wikimedia.org/r/172929 (owner: 10Catrope) [18:20:43] <MatmaRex_mobile> groan [18:24:35] <grrrit-wm> (03Merged) 10jenkins-bot: Explicitly bypass undefined values in oo.compare() [oojs/core] - 10https://gerrit.wikimedia.org/r/172929 (owner: 10Catrope) [18:25:28] <James_F> OK-dokies. [18:25:51] <wikibugs> 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf5] Comment inspector closes and saves empty comment when tool is used - 10https://bugzilla.wikimedia.org/71706 (10James Forrester) 5PATC>3RESO/FIX [18:26:05] <wikibugs> 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf5] Comment inspector closes and saves empty comment when tool is used - 10https://bugzilla.wikimedia.org/71706 (10James Forrester) [18:26:21] <wikibugs> 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf5] Have to undo twice to reverse comment creation - 10https://bugzilla.wikimedia.org/72315 (10James Forrester) 5PATC>3RESO/FIX [18:30:40] <grrrit-wm> (03PS1) 10Jforrester: Tag v1.1.3 [oojs/core] - 10https://gerrit.wikimedia.org/r/173868 [18:30:55] <James_F> TrevorParscal: Want to +2 https://gerrit.wikimedia.org/r/173868 ? [18:33:36] <wikibugs> 3OOjs UI: OO.ui.ButtonWidget default target should not be "_blank" - 10https://bugzilla.wikimedia.org/73452#c1 (10Richhiey) Created attachment 17148 --> https://bugzilla.wikimedia.org/attachment.cgi?id=17148&action=edit Changed the config for target to '_self'. Is this okay? [18:46:38] <wikibugs> 3VisualEditor / 3ContentEditable: VisualEditor: Display name of transclusions as a tool-tip when selected - 10https://bugzilla.wikimedia.org/51824#c4 (10James Forrester) 5ASSI>3RESO/FIX a:3Trevor Parscal (In reply to Alex Monk from comment #3) > Don't we have this now? What to do about this bug? Yes,... [18:47:02] <grrrit-wm> (03Abandoned) 10Jforrester: Add lang and dir attributes to the accelerator element [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173772 (owner: 10Amire80) [18:50:30] <aharoni> James_F: bah [18:50:39] <aharoni> didn't realize it's downstream [18:50:46] <aharoni> where should I submit the lang/dir thing? [18:50:56] <James_F> aharoni: oojs/ui.git [18:51:03] <aharoni> github? [18:51:13] <aharoni> or gerrit? [18:51:15] <James_F> aharoni: No, gerrit. [18:51:17] <James_F> https://gerrit.wikimedia.org/r/#/q/status:open+project:oojs/ui+-limit:10,n,z [18:51:17] <aharoni> ok [18:56:29] <grrrit-wm> (03PS1) 10Amire80: Add lang and dir attributes to the accelerator element [oojs/ui] - 10https://gerrit.wikimedia.org/r/173872 [18:57:25] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Add lang and dir attributes to the accelerator element [oojs/ui] - 10https://gerrit.wikimedia.org/r/173872 (owner: 10Amire80) [18:59:46] <grrrit-wm> (03PS2) 10Amire80: Add lang and dir attributes to the accelerator element [oojs/ui] - 10https://gerrit.wikimedia.org/r/173872 [19:05:52] <wikibugs> 3VisualEditor / 3ContentEditable: VisualEditor: Copying and pasting results in new blank section heading: "== <nowiki /> ==" - 10https://bugzilla.wikimedia.org/55769 (10James Forrester) a:3James Forrester [19:06:25] <wikibugs> 3VisualEditor / 3Data Model: VisualEditor: "Uncaught TypeError: Cannot read property 'getRange' of undefined" when unmerging cells - 10https://bugzilla.wikimedia.org/73223 (10James Forrester) p:5Unprio>3High a:3Ed Sanders [19:07:13] <grrrit-wm> (03CR) 10Jforrester: [C: 031] Safari copy-paste fix [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173256 (https://bugzilla.wikimedia.org/71718) (owner: 10Esanders) [19:09:03] <grrrit-wm> (03CR) 10Jforrester: [C: 032] Add "sortable" class to display table [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/173528 (https://bugzilla.wikimedia.org/50435) (owner: 10Glaisher) [19:09:35] <wikibugs> 3MediaWiki extensions / 3TemplateData: TempateData: Make the display table sortable - 10https://bugzilla.wikimedia.org/50435#c4 (10James Forrester) 5PATC>3RESO/FIX Thanks! [19:09:41] <grrrit-wm> (03Merged) 10jenkins-bot: Add "sortable" class to display table [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/173528 (https://bugzilla.wikimedia.org/50435) (owner: 10Glaisher) [19:11:12] <grrrit-wm> (03PS3) 10Trevor Parscal: [BREAKING CHANGE] Rename *Menu and *MenuItem widgets [oojs/ui] - 10https://gerrit.wikimedia.org/r/173356 [19:12:01] <James_F> TrevorParscal: https://gerrit.wikimedia.org/r/173868 [19:12:28] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Rename *Menu and *MenuItem widgets [oojs/ui] - 10https://gerrit.wikimedia.org/r/173356 (owner: 10Trevor Parscal) [19:12:30] <grrrit-wm> (03CR) 10Trevor Parscal: [C: 032] Tag v1.1.3 [oojs/core] - 10https://gerrit.wikimedia.org/r/173868 (owner: 10Jforrester) [19:16:11] <grrrit-wm> (03Merged) 10jenkins-bot: Tag v1.1.3 [oojs/core] - 10https://gerrit.wikimedia.org/r/173868 (owner: 10Jforrester) [19:17:32] <grrrit-wm> (03PS1) 10Cmcmahon: [BrowserTest] interim step to sort G/W/T statements properly [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173877 [19:17:39] <wikibugs> 3OOjs UI: OOjs UI: trouble with CheckboxInputWidget in Opera - 10https://bugzilla.wikimedia.org/73517#c1 (10tacsipacsi) The problem is that there's no visual difference between the checked and unchecked status of the buttons. I tested and I can use it, but I don't know whether it's in checked or unchecked stat... [19:21:36] <wikibugs> 3VisualEditor: Selecting huge chunks of text with Shift + arrow up/down is broken or works inconsistently - 10https://bugzilla.wikimedia.org/73512#c3 (10etonkovidova) The same issue with IE11 on Windows8 - along with Chrome/FF there: while highlighting the text with Shift+arrows, the page does not scroll down... [19:22:03] <github> [13oojs.github.io] 15jdforrester created 06publish-1.1.3 (+1 new commit): 02https://github.com/oojs/oojs.github.io/commit/aa872a1c55a5 [19:22:04] <github> 13oojs.github.io/06publish-1.1.3 14aa872a1 15James D. Forrester: Publish v1.1.3 release from npm [19:22:48] <github> [13oojs.github.io] 15jdforrester opened pull request #6: Publish v1.1.3 release from npm (06master...06publish-1.1.3) 02https://github.com/oojs/oojs.github.io/pull/6 [19:27:14] <grrrit-wm> (03PS2) 10Cmcmahon: [BrowserTest] interim step to sort G/W/T statements properly [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173877 [19:27:35] <grrrit-wm> (03CR) 10Cmcmahon: [C: 032] [BrowserTest] interim step to sort G/W/T statements properly [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173877 (owner: 10Cmcmahon) [19:27:56] <grrrit-wm> (03PS1) 10Jforrester: Update OOjs to v1.1.3 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173885 [19:29:05] <grrrit-wm> (03PS1) 10Jforrester: Update OOjs to v1.1.3 [oojs/ui] - 10https://gerrit.wikimedia.org/r/173886 [19:29:13] <grrrit-wm> (03Merged) 10jenkins-bot: [BrowserTest] interim step to sort G/W/T statements properly [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173877 (owner: 10Cmcmahon) [19:50:06] <RoanKattouw> [14:49] mooeypoo [2014-11-17 10:17:05] Is this the mile hi-r-c club? [19:50:08] <RoanKattouw> lol [19:50:10] <RoanKattouw> Yes it is [19:50:11] <RoanKattouw> The mile hi-r-c club is expensive though [19:50:34] <RoanKattouw> On normal United flights you pay $1/hr for basic mobile access, and $2/hr for laptop access [19:50:36] <RoanKattouw> And that's satellite wifi [19:50:52] <RoanKattouw> On this flight there's Gogo wifi (cell towers rather than satellite, so faster) which is $30/flight [19:55:55] <grrrit-wm> (03PS4) 10Trevor Parscal: [BREAKING CHANGE] Rename *Menu and *MenuItem widgets [oojs/ui] - 10https://gerrit.wikimedia.org/r/173356 [19:56:50] <wikibugs> 3VisualEditor / 3ContentEditable: VisualEditor: Preserve `data-parsoid` attribute on internal copy-paste so that Parsoid preserves e.g. syntax layout - 10https://bugzilla.wikimedia.org/72426#c17 (10Roan Kattouw) (In reply to ssastry from comment #12) > To summarize the discussion from IRC, we figured out tha... [19:57:21] <grrrit-wm> (03CR) 10Catrope: [C: 04-2] "Code looks fine; but blocking merge awaiting response to https://bugzilla.wikimedia.org/show_bug.cgi?id=72426#c17" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173805 (https://bugzilla.wikimedia.org/72426) (owner: 10Esanders) [19:58:14] <TrevorParscal> RoanKattouw: when will https://gerrit.wikimedia.org/r/#/c/73368/ be deployed to test? [19:58:26] <TrevorParscal> i mean beta labs [19:58:56] <RoanKattouw> TrevorParscal: Was that the right link? [19:59:07] <RoanKattouw> You linked me to a commit in the Parsoid extension from July 2013 [20:00:23] <TrevorParscal> um, sorry [20:00:27] <TrevorParscal> helping Alena [20:00:36] <TrevorParscal> had the bug number and rev number confused there [20:00:50] <TrevorParscal> actually she's trying to test https://gerrit.wikimedia.org/r/#/c/173442/ on beta labs, but it's not merged yet [20:00:54] <TrevorParscal> so, nevermind [20:01:31] <RoanKattouw> TrevorParscal: As a rule, commits in VE-MW (mediawiki/extensions/VisualEditor) are deployed to beta labs as soon as they are merged, give or take 5 mins [20:02:20] <RoanKattouw> Commits in VE core (VisualEditor/VisualEditor) are deployed when their pull-through commit into VE-MW is merged. We do pull-throughs every couple days, or more frequently when necessary/requested [20:02:42] <RoanKattouw> (I would address those messages to Elena but she's not on IRC right now) [20:03:16] <RoanKattouw> TrevorParscal: Also, could you ask Elena if that commit ( https://gerrit.wikimedia.org/r/#/c/173442/ ) is related to a bug, and if so, which one? [20:03:22] <RoanKattouw> Because then I can tag it [20:08:52] <RoanKattouw> etonkovidova: Is there a bug related to https://gerrit.wikimedia.org/r/#/c/173442/ ? Perhaps something to do with drag&dropping into an image caption? I ask because Trevor says you were trying to test that code, and it's not tagged against any bug [20:11:00] <etonkovidova> RoanKattouw: it turned out that https://gerrit.wikimedia.org/r/#/c/173442/ is with status Review in Progress [20:11:23] <etonkovidova> and it's about bug 73368 [20:12:48] <RoanKattouw> Aha [20:12:49] <RoanKattouw> Thanks [20:12:56] <RoanKattouw> I'll tag the change with the bug [20:13:11] <grrrit-wm> (03PS2) 10Catrope: Don't allow dropping inside a handlesOwnChildren node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173442 (https://bugzilla.wikimedia.org/73368) (owner: 10Esanders) [20:13:28] <grrrit-wm> (03CR) 10Catrope: [C: 032] Don't allow dropping inside a handlesOwnChildren node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173442 (https://bugzilla.wikimedia.org/73368) (owner: 10Esanders) [20:13:30] <grrrit-wm> (03PS1) 10Cmcmahon: [BrowserTest] remove sleep() from template test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173905 [20:15:17] <grrrit-wm> (03CR) 10Cmcmahon: [C: 032] [BrowserTest] remove sleep() from template test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173905 (owner: 10Cmcmahon) [20:15:38] <wikibugs> 3VisualEditor / 3ContentEditable: VisualEditor: [Regression] Gallery gets added into media, if there is/was something in the media's caption - 10https://bugzilla.wikimedia.org/73368 (10James Forrester) p:5Unprio>3Normal a:3Ed Sanders [20:16:37] <grrrit-wm> (03Merged) 10jenkins-bot: [BrowserTest] remove sleep() from template test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173905 (owner: 10Cmcmahon) [20:20:33] <James_F> Heya Krinkle. [20:24:35] <wikibugs> 3VisualEditor / 3Editing Tools: VisualEditor: Label the "Remove" button in link inspector as "Cancel" if in link creation mode - 10https://bugzilla.wikimedia.org/69359#c4 (10James Forrester) (In reply to Alex Monk from comment #3) > Maybe relabel it "Cancel" instead in this case? Maybe. [20:26:01] <grrrit-wm> (03CR) 10Catrope: [C: 04-1] Create 'preserveGenerated' mode for cloneElements and use in copy (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173807 (https://bugzilla.wikimedia.org/72426) (owner: 10Esanders) [20:26:15] <etonkovidova> edsanders: https://gerrit.wikimedia.org/r/#/c/173808/ marked as merged but bug 72315(undo comment in "two steps") is still present [20:26:53] <edsanders> I'm guessing the code hasn't been pulled through yet [20:26:58] <RoanKattouw> Yeah that's right [20:27:05] <RoanKattouw> I'll do a pull-through in ~30 mins [20:27:12] <Krinkle> James_F: Hey [20:27:13] <github> [13oojs.github.io] 15Krinkle 04deleted 06publish-1.1.3 at 14aa872a1: 02https://github.com/oojs/oojs.github.io/commit/aa872a1 [20:27:14] <edsanders> If the "project" is 'VisualEditor/VisualEditor' [20:27:26] <Krinkle> Just arrived in my 4th and final London Airbnb place. [20:27:33] <James_F> Krinkle: Nice. [20:27:40] <edsanders> then you need to wait for a commit to 'mediawiki/extensions/VisualEditor' that pulls through the changes [20:27:55] <James_F> etonkovidova: We're waiting for Roan to finish merging Ed's code to pull through, sorry. [20:28:02] <etonkovidova> thanks! [20:29:40] <grrrit-wm> (03CR) 10Catrope: [C: 032] Safari copy-paste fix [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173256 (https://bugzilla.wikimedia.org/71718) (owner: 10Esanders) [20:29:54] <grrrit-wm> (03PS3) 10Esanders: Create 'preserveGenerated' mode for cloneElements and use in copy [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173807 (https://bugzilla.wikimedia.org/72426) [20:30:05] <James_F> RoanKattouw: Think we should cherry-pick? [20:30:06] <wikibugs> 3VisualEditor / 3ContentEditable: VisualEditor: Pawn ♙ appears after deleting the text preceding and following a link by "undo" action - 10https://bugzilla.wikimedia.org/61521 (10James Forrester) p:5Unprio>3High [20:30:50] <wikibugs> 3VisualEditor / 3ContentEditable: VisualEditor: Pasting annotated text causes space to be removed at annotation separators - 10https://bugzilla.wikimedia.org/71718 (10James Forrester) 5PATC>3RESO/FIX [20:31:19] <grrrit-wm> (03CR) 10Catrope: [C: 032] Update OOjs to v1.1.3 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173885 (owner: 10Jforrester) [20:31:32] <grrrit-wm> (03PS1) 10Cmcmahon: [BrowserTest] update Cite test for RSpec3 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173909 [20:31:42] <grrrit-wm> (03Merged) 10jenkins-bot: Safari copy-paste fix [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173256 (https://bugzilla.wikimedia.org/71718) (owner: 10Esanders) [20:32:03] <grrrit-wm> (03CR) 10Catrope: [C: 032] Update OOjs to v1.1.3 [oojs/ui] - 10https://gerrit.wikimedia.org/r/173886 (owner: 10Jforrester) [20:33:18] <grrrit-wm> (03PS2) 10Esanders: Move mobile ContextItemWidget hacks into separate class [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173865 [20:33:25] <grrrit-wm> (03Merged) 10jenkins-bot: Update OOjs to v1.1.3 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173885 (owner: 10Jforrester) [20:33:55] <grrrit-wm> (03CR) 10Cmcmahon: [C: 032] [BrowserTest] update Cite test for RSpec3 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173909 (owner: 10Cmcmahon) [20:33:57] <grrrit-wm> (03PS3) 10Jforrester: Replace ve.getProp() and ve.setProp() with OO aliases [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172940 (owner: 10Catrope) [20:34:31] <grrrit-wm> (03CR) 10Catrope: [C: 032] Create 'preserveGenerated' mode for cloneElements and use in copy [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173807 (https://bugzilla.wikimedia.org/72426) (owner: 10Esanders) [20:34:46] <grrrit-wm> (03Merged) 10jenkins-bot: Update OOjs to v1.1.3 [oojs/ui] - 10https://gerrit.wikimedia.org/r/173886 (owner: 10Jforrester) [20:35:42] <grrrit-wm> (03CR) 10Catrope: [C: 032] Don't always use updateDimensionsDebounced [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173804 (https://bugzilla.wikimedia.org/73242) (owner: 10Esanders) [20:36:15] <grrrit-wm> (03CR) 10Catrope: [C: 032] Move hasSignificantWhitespace and handlesOwnChildren abstracts to ve.Node. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173346 (owner: 10Esanders) [20:37:05] <wikibugs> 3VisualEditor / 3Editing Tools: VisualEditor: When selecting FocusableNode with arrow keys, context flickers at position of last mouse click - 10https://bugzilla.wikimedia.org/73242 (10James Forrester) 5PATC>3RESO/FIX p:5Unprio>3Normal s:5normal>3minor [20:40:44] <grrrit-wm> (03CR) 10Catrope: [C: 032] Move mobile ContextItemWidget hacks into separate class [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173865 (owner: 10Esanders) [20:41:19] <joshrees> Is there a guide on how to make a custom skin compatible with VisualEditor? Thank you [20:42:05] <grrrit-wm> (03Merged) 10jenkins-bot: Don't always use updateDimensionsDebounced [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173804 (https://bugzilla.wikimedia.org/73242) (owner: 10Esanders) [20:42:09] <grrrit-wm> (03Merged) 10jenkins-bot: Move hasSignificantWhitespace and handlesOwnChildren abstracts to ve.Node. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173346 (owner: 10Esanders) [20:42:11] <grrrit-wm> (03Merged) 10jenkins-bot: Don't allow dropping inside a handlesOwnChildren node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173442 (https://bugzilla.wikimedia.org/73368) (owner: 10Esanders) [20:42:50] <grrrit-wm> (03CR) 10Jforrester: [C: 032] Replace ve.getProp() and ve.setProp() with OO aliases [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172940 (owner: 10Catrope) [20:42:55] <grrrit-wm> (03PS1) 10Trevor Parscal: Update OOjs UI to v0.1.0-pre (549ff9ab7d) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173912 [20:43:38] <grrrit-wm> (03Merged) 10jenkins-bot: [BrowserTest] update Cite test for RSpec3 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173909 (owner: 10Cmcmahon) [20:44:05] <wikibugs> 3VisualEditor / 3ContentEditable: VisualEditor: [Regression] Ctrl+A no longer working since staging of slugs because a selection starting from a CE=false node in Chrome - 10https://bugzilla.wikimedia.org/72725#c4 (10James Forrester) (In reply to Ed Sanders from comment #3) > *sigh* Chrome doesn't even let yo... [20:44:19] <grrrit-wm> (03Merged) 10jenkins-bot: Move mobile ContextItemWidget hacks into separate class [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173865 (owner: 10Esanders) [20:45:28] <grrrit-wm> (03Merged) 10jenkins-bot: Replace ve.getProp() and ve.setProp() with OO aliases [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172940 (owner: 10Catrope) [20:46:03] <grrrit-wm> (03PS5) 10Jforrester: ve.ce.Surface: Move insert HTML path to DM [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172748 [20:46:09] <grrrit-wm> (03PS5) 10Jforrester: Provide a FileDropHandler for HTML files [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172749 [20:46:15] <grrrit-wm> (03PS2) 10Jforrester: Provide a FileDropHandler for CSV and TSV files [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173296 [20:47:58] <grrrit-wm> (03CR) 10Catrope: "(submitting old comments on outdated patchset)" (033 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173296 (owner: 10Jforrester) [20:49:09] <grrrit-wm> (03PS1) 10Cmcmahon: [BrowserTest] more update to Cite test for RSpec3 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173917 [20:50:28] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] [BrowserTest] more update to Cite test for RSpec3 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173917 (owner: 10Cmcmahon) [20:51:21] <wikibugs> 3VisualEditor / 3ContentEditable: VisualEditor: [Regression] Gallery gets added into media, if there is/was something in the media's caption - 10https://bugzilla.wikimedia.org/73368 (10James Forrester) 5PATC>3RESO/FIX [20:52:04] <grrrit-wm> (03PS1) 10Jforrester: Update VE core submodule to master (fa572a5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173919 [20:52:42] <grrrit-wm> (03CR) 10Catrope: [C: 032] Update VE core submodule to master (fa572a5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173919 (owner: 10Jforrester) [20:54:06] <grrrit-wm> (03Merged) 10jenkins-bot: Update VE core submodule to master (fa572a5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173919 (owner: 10Jforrester) [20:55:29] <grrrit-wm> (03CR) 10Catrope: [C: 032] Methods for new "maps" property in TD Root [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167772 (owner: 10Mvolz) [20:56:16] <grrrit-wm> (03PS2) 10Cmcmahon: [BrowserTest] more update to Cite test for RSpec3 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173917 [20:56:51] <grrrit-wm> (03Merged) 10jenkins-bot: Methods for new "maps" property in TD Root [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167772 (owner: 10Mvolz) [20:57:51] <grrrit-wm> (03CR) 10Cmcmahon: [C: 032] [BrowserTest] more update to Cite test for RSpec3 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173917 (owner: 10Cmcmahon) [20:58:15] <edsanders> oooh, lollipop ota! [20:58:37] <James_F> edsanders: What? [20:58:49] <James_F> edsanders: Oh, Android 5 OS update finally landed? [20:59:14] <grrrit-wm> (03Merged) 10jenkins-bot: [BrowserTest] more update to Cite test for RSpec3 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173917 (owner: 10Cmcmahon) [21:01:00] <RoanKattouw> James_F: Apparently it's proven stable enough to OTA to more than ~0.1% of users [21:01:16] <James_F> RoanKattouw: Or Ed is part of the 0.1%? [21:01:18] <RoanKattouw> I wonder if I'll get it when I land; it might be a few more days depending on how they bucket me [21:01:21] <James_F> #OccupyAndroid. [21:01:25] <RoanKattouw> haha [21:07:18] <grrrit-wm> (03PS1) 10Cmcmahon: [BrowserTest] minor violation of Page Object design pattern [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173929 [21:08:36] <grrrit-wm> (03PS3) 10Jforrester: Provide a FileDropHandler for CSV and TSV files [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173296 [21:09:01] <grrrit-wm> (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173929 (owner: 10Cmcmahon) [21:09:26] <grrrit-wm> (03CR) 10Catrope: [C: 04-1] ve.ce.Surface: Move insert HTML path to DM (035 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172748 (owner: 10Jforrester) [21:10:18] <grrrit-wm> (03Merged) 10jenkins-bot: [BrowserTest] minor violation of Page Object design pattern [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173929 (owner: 10Cmcmahon) [21:11:32] <grrrit-wm> (03CR) 10Jforrester: Provide a FileDropHandler for CSV and TSV files (033 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173296 (owner: 10Jforrester) [21:11:54] <James_F> edsanders: Thoughts on https://gerrit.wikimedia.org/r/#/c/172748/ ? [21:12:33] <mooeypoo> Hmm. I found the way *not* to do the vertical drag drop. [21:13:02] <grrrit-wm> (03CR) 10Jforrester: [C: 032] Add tests for ve.instanceOfAny() [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173432 (owner: 10Catrope) [21:14:59] <grrrit-wm> (03Merged) 10jenkins-bot: Add tests for ve.instanceOfAny() [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173432 (owner: 10Catrope) [21:15:30] <grrrit-wm> (03CR) 10Zfilipin: [C: 031] "Looks good to me in general. I had one minor comment." (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173838 (owner: 10Cmcmahon) [21:15:52] <grrrit-wm> (03PS3) 10Hashar: Prepare repository for RuboCop [oojs/ui] - 10https://gerrit.wikimedia.org/r/172716 (https://bugzilla.wikimedia.org/72841) (owner: 10Zfilipin) [21:16:11] <grrrit-wm> (03CR) 10Hashar: "check experimental" [oojs/ui] - 10https://gerrit.wikimedia.org/r/172716 (https://bugzilla.wikimedia.org/72841) (owner: 10Zfilipin) [21:17:27] <grrrit-wm> (03CR) 10Hashar: [C: 032] "rubocop 0.27.1 --auto-gen-config has a bug which causes it to set the style "Style/MultilineOperationIndentation" enabled :/" [oojs/ui] - 10https://gerrit.wikimedia.org/r/172716 (https://bugzilla.wikimedia.org/72841) (owner: 10Zfilipin) [21:18:17] <grrrit-wm> (03PS1) 10Cmcmahon: [BrowserTest] fix minor Page Object design violation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173937 [21:19:49] <grrrit-wm> (03Merged) 10jenkins-bot: Prepare repository for RuboCop [oojs/ui] - 10https://gerrit.wikimedia.org/r/172716 (https://bugzilla.wikimedia.org/72841) (owner: 10Zfilipin) [21:23:37] <grrrit-wm> (03CR) 10Hashar: "Zuul made voting with https://gerrit.wikimedia.org/r/#/c/173939/" [oojs/ui] - 10https://gerrit.wikimedia.org/r/172716 (https://bugzilla.wikimedia.org/72841) (owner: 10Zfilipin) [21:24:12] <grrrit-wm> (03CR) 10Cmcmahon: [C: 032] "maintenanance" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173937 (owner: 10Cmcmahon) [21:25:11] <wikibugs> 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf8] All inspector dialog UI is broken when added inside Reference/Media Settings dialog box - 10https://bugzilla.wikimedia.org/64761 (10Rummana Yasmeen) a:5Trevor Parscal>3Roan Kattouw [21:26:51] <grrrit-wm> (03Merged) 10jenkins-bot: [BrowserTest] fix minor Page Object design violation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173937 (owner: 10Cmcmahon) [21:27:09] <grrrit-wm> (03CR) 10Hashar: "That is a bug upstream https://github.com/bbatsov/rubocop/issues/1449" [oojs/ui] - 10https://gerrit.wikimedia.org/r/172719 (https://bugzilla.wikimedia.org/72841) (owner: 10Zfilipin) [21:27:40] <grrrit-wm> (03PS2) 10Hashar: Fixed RuboCop Style/AndOr offense [oojs/ui] - 10https://gerrit.wikimedia.org/r/172722 (https://bugzilla.wikimedia.org/72841) (owner: 10Zfilipin) [21:27:48] <ryasmeen> Hey RoanKattouw, https://bugzilla.wikimedia.org/show_bug.cgi?id=64761 is also in wmf8 by the way [21:27:51] <grrrit-wm> (03PS2) 10Hashar: Fixed RuboCop Style/AsciiComments offense [oojs/ui] - 10https://gerrit.wikimedia.org/r/172726 (https://bugzilla.wikimedia.org/72841) (owner: 10Zfilipin) [21:28:20] <grrrit-wm> (03PS2) 10Hashar: Fixed RuboCop Style/EmptyLineBetweenDefs offence [oojs/ui] - 10https://gerrit.wikimedia.org/r/172730 (https://bugzilla.wikimedia.org/72841) (owner: 10Zfilipin) [21:28:29] <grrrit-wm> (03PS2) 10Hashar: Fixed RuboCop Style/EmptyLines offense [oojs/ui] - 10https://gerrit.wikimedia.org/r/172731 (https://bugzilla.wikimedia.org/72841) (owner: 10Zfilipin) [21:28:38] <grrrit-wm> (03PS2) 10Hashar: Fixed RuboCop Style/NegatedIf offense [oojs/ui] - 10https://gerrit.wikimedia.org/r/172732 (https://bugzilla.wikimedia.org/72841) (owner: 10Zfilipin) [21:28:47] <grrrit-wm> (03PS2) 10Hashar: Fixed RuboCop Style/SignalException offense [oojs/ui] - 10https://gerrit.wikimedia.org/r/172733 (https://bugzilla.wikimedia.org/72841) (owner: 10Zfilipin) [21:28:58] <grrrit-wm> (03PS2) 10Hashar: Fixed RuboCop Style/SpaceAroundEqualsInParameterDefault offense [oojs/ui] - 10https://gerrit.wikimedia.org/r/172734 (https://bugzilla.wikimedia.org/72841) (owner: 10Zfilipin) [21:29:22] <grrrit-wm> (03PS2) 10Hashar: Fixed RuboCop Style/NilComparison offense [oojs/ui] - 10https://gerrit.wikimedia.org/r/172739 (https://bugzilla.wikimedia.org/72841) (owner: 10Zfilipin) [21:30:58] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Fixed RuboCop Style/AndOr offense [oojs/ui] - 10https://gerrit.wikimedia.org/r/172722 (https://bugzilla.wikimedia.org/72841) (owner: 10Zfilipin) [21:31:00] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Fixed RuboCop Style/EmptyLines offense [oojs/ui] - 10https://gerrit.wikimedia.org/r/172731 (https://bugzilla.wikimedia.org/72841) (owner: 10Zfilipin) [21:31:09] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Fixed RuboCop Style/NegatedIf offense [oojs/ui] - 10https://gerrit.wikimedia.org/r/172732 (https://bugzilla.wikimedia.org/72841) (owner: 10Zfilipin) [21:31:53] <wikibugs> 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf7] While opening the "Citation needed" dialog for the first time in a session, the "Add more information" link is appearing twice in the dialog - 10https://bugzilla.wikimedia.org/73099 (10Rummana Yasmeen) [21:31:53] <wikibugs> 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf7] While opening the "Citation needed" dialog for the first time in a session, the "Add more information" link is appearing twice in the dialog - 10https://bugzilla.wikimedia.org/73099 (10Rummana Yasmeen) [21:34:04] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Fixed RuboCop Style/AsciiComments offense [oojs/ui] - 10https://gerrit.wikimedia.org/r/172726 (https://bugzilla.wikimedia.org/72841) (owner: 10Zfilipin) [21:34:43] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Fixed RuboCop Style/EmptyLineBetweenDefs offence [oojs/ui] - 10https://gerrit.wikimedia.org/r/172730 (https://bugzilla.wikimedia.org/72841) (owner: 10Zfilipin) [21:34:58] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Fixed RuboCop Style/SignalException offense [oojs/ui] - 10https://gerrit.wikimedia.org/r/172733 (https://bugzilla.wikimedia.org/72841) (owner: 10Zfilipin) [21:35:05] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Fixed RuboCop Style/SpaceAroundEqualsInParameterDefault offense [oojs/ui] - 10https://gerrit.wikimedia.org/r/172734 (https://bugzilla.wikimedia.org/72841) (owner: 10Zfilipin) [21:35:08] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Fixed RuboCop Style/NilComparison offense [oojs/ui] - 10https://gerrit.wikimedia.org/r/172739 (https://bugzilla.wikimedia.org/72841) (owner: 10Zfilipin) [21:35:36] <grrrit-wm> (03Abandoned) 10Cmcmahon: [BrowserTest] update for RSpec3 syntax [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173838 (owner: 10Cmcmahon) [21:35:50] <RoanKattouw> ryasmeen: Argh. Will look [21:36:14] <ryasmeen> Thanks RoanKattouw [21:36:44] <grrrit-wm> (03CR) 10Catrope: [C: 032] Provide a FileDropHandler for CSV and TSV files [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173296 (owner: 10Jforrester) [21:37:00] <ryasmeen> RoanKattouw: and also https://bugzilla.wikimedia.org/show_bug.cgi?id=73099 :) [21:37:20] <ryasmeen> this was from wmf7 though [21:41:28] <grrrit-wm> (03PS1) 10Krinkle: Replaces spaces with tabs in en.json [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173969 (https://bugzilla.wikimedia.org/72132) [21:43:03] <grrrit-wm> (03PS1) 10Cmcmahon: [BrowserTest] update switch-edit-mode test for RSpec3 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173970 [21:43:22] <wikibugs> 3VisualEditor: VisualEditor: Newly added template added with "Template:" prefix - 10https://bugzilla.wikimedia.org/73179#c2 (10etonkovidova) Verified on www.mediawiki.org - the Bug template added as {{Bug|73179}}. [21:45:20] <grrrit-wm> (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173970 (owner: 10Cmcmahon) [21:46:42] <grrrit-wm> (03Merged) 10jenkins-bot: [BrowserTest] update switch-edit-mode test for RSpec3 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173970 (owner: 10Cmcmahon) [21:55:06] <grrrit-wm> (03PS1) 10Cmcmahon: [BrowserTest] update transclusion test for Page Object vio and RS [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173976 [21:55:43] <grrrit-wm> (03PS1) 10Catrope: Followup ca6a16f: use parent selector both for hiding and showing windows [oojs/ui] - 10https://gerrit.wikimedia.org/r/173977 (https://bugzilla.wikimedia.org/64761) [21:56:26] <grrrit-wm> (03CR) 10Catrope: "Needs backport to wmf8" [oojs/ui] - 10https://gerrit.wikimedia.org/r/173977 (https://bugzilla.wikimedia.org/64761) (owner: 10Catrope) [21:56:33] <RoanKattouw> edsanders: https://gerrit.wikimedia.org/r/#/c/173977/ [21:57:09] <grrrit-wm> (03PS2) 10Trevor Parscal: Update OOjs UI to v0.1.0-pre (549ff9ab7d) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173912 [21:59:21] <grrrit-wm> (03PS2) 10Cmcmahon: [BrowserTest] update transclusion test for Page Object vio and RS [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173976 [22:00:04] <grrrit-wm> (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173976 (owner: 10Cmcmahon) [22:00:09] <RoanKattouw> ryasmeen: I have a fix for https://bugzilla.wikimedia.org/64761 , but I cannot reproduce https://bugzilla.wikimedia.org/show_bug.cgi?id=73099 on enwiki or test2wiki [22:00:45] <RoanKattouw> Nor beta labs, nor locally [22:00:51] <RoanKattouw> Am I missing another reproduction step or something? [22:00:58] <ryasmeen> Umm okay, it happens only on the first time of the session [22:01:23] <ryasmeen> RoanKattouw: Did you check for "Citation needed" template? [22:01:25] <grrrit-wm> (03Merged) 10jenkins-bot: [BrowserTest] update transclusion test for Page Object vio and RS [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173976 (owner: 10Cmcmahon) [22:01:29] <RoanKattouw> Yes [22:02:05] <RoanKattouw> Insert -> Template, type citation needed, click Add Template [22:02:16] <RoanKattouw> Only one "Add more information" appeared for me [22:02:59] <ryasmeen> ha! thats weird! why would it be different for me :( [22:05:42] <grrrit-wm> (03PS1) 10Trevor Parscal: Update VE core submodule to 4d56fc2a92ee56308e72ee77f724f6ae890d4e3c [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173982 [22:05:59] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to 4d56fc2a92ee56308e72ee77f724f6ae890d4e3c [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173982 (owner: 10Trevor Parscal) [22:06:49] <TrevorParscal> RoanKattouw: could to peek at https://gerrit.wikimedia.org/r/#/c/173356/ https://gerrit.wikimedia.org/r/#/c/173912/ and https://gerrit.wikimedia.org/r/#/c/173982/ please? [22:07:29] <grrrit-wm> (03PS3) 10Trevor Parscal: Update OOjs UI to v0.1.0-pre (549ff9ab7d) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173912 [22:07:56] <RoanKattouw> Krinkle: How merge-ready is https://gerrit.wikimedia.org/r/#/c/167389 ? It's +1ed by you, is that because you deem it ready to merge but need someone else to review the changes you've made? [22:08:10] <TrevorParscal> RoanKattouw: they can be regenerated using the scripts linked to in the commit messages [22:08:19] <TrevorParscal> but, ideally these won't get too stale [22:08:43] <TrevorParscal> and we may also need to update multimedia's code [22:09:25] <RoanKattouw> TrevorParscal: Sure, I will look [22:09:29] <TrevorParscal> thanks [22:09:36] <RoanKattouw> TrevorParscal: Could you review https://gerrit.wikimedia.org/r/173977? [22:09:37] <TrevorParscal> there's no hand-editing in those commits [22:10:03] <TrevorParscal> they are 100% generated by the scripts, so if you find an issue, it will be to do with how the script works, so feel free to also ready my bash scripts (scary!) [22:10:30] <grrrit-wm> (03CR) 10Trevor Parscal: [C: 032] Followup ca6a16f: use parent selector both for hiding and showing windows [oojs/ui] - 10https://gerrit.wikimedia.org/r/173977 (https://bugzilla.wikimedia.org/64761) (owner: 10Catrope) [22:10:38] <RoanKattouw> Thanks [22:11:08] <RoanKattouw> TrevorParscal: Wait, you scripted the renames? [22:11:23] <RoanKattouw> So you did [22:11:27] <TrevorParscal> yes [22:11:46] <TrevorParscal> I wanted to do this in a robust and repeatable way [22:12:22] <TrevorParscal> in case we needed to regenerate them (if they didn't get merged quickly) or reused parts of the scripts for other extensions (looking at multimedia's mediaviewer now) [22:12:29] <grrrit-wm> (03Merged) 10jenkins-bot: Followup ca6a16f: use parent selector both for hiding and showing windows [oojs/ui] - 10https://gerrit.wikimedia.org/r/173977 (https://bugzilla.wikimedia.org/64761) (owner: 10Catrope) [22:12:32] <RoanKattouw> Awesome [22:14:34] <grrrit-wm> (03PS1) 10Cmcmahon: [BrowserTest] interim step, no functional change [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173984 [22:15:17] <grrrit-wm> (03CR) 10Cmcmahon: [C: 032] "interim step, no functional change" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173984 (owner: 10Cmcmahon) [22:15:24] <wikibugs> 3VisualEditor / 3ContentEditable: VisualEditor: [Regression] Gallery gets added into media, if there is/was something in the media's caption - 10https://bugzilla.wikimedia.org/73368#c10 (10etonkovidova) Verified the fix in betalabs. [22:17:10] <grrrit-wm> (03Merged) 10jenkins-bot: [BrowserTest] interim step, no functional change [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173984 (owner: 10Cmcmahon) [22:19:24] <TrevorParscal> RoanKattouw: also this: https://gerrit.wikimedia.org/r/#/c/173987/ [22:22:26] <TrevorParscal> RoanKattouw: I've tested it all (at each step, demos, standalone, ve init, multimedia viewer), but of course I encourage you to verify [22:22:57] <RoanKattouw> Right [22:23:29] <RoanKattouw> I will look at it, but I won't merge it until after the branch cut happens on Wednesday morning [22:23:37] <TrevorParscal> that's fine [22:24:11] <TrevorParscal> given how they are regeneratable, it's not a problem if we have to wait a tick to merge [22:24:18] <MatmaRex> hey all, sorry for missing the hangout (again). did i miss anything important? did y'all get my report? [22:24:21] <TrevorParscal> but, yeah - the sooner the better with sweeping changes like that [22:24:25] <TrevorParscal> MatmaRex: howdy! [22:25:55] <RoanKattouw> TrevorParscal: Yeah I want to merge this soon, but Monday afternoon is not the best time to Merge All The Things, and 38,000 ft above Pierre, South Dakota is not the best place [22:32:13] <wikibugs> 3VisualEditor / 3ContentEditable: VisualEditor: ve-ce-focusableNode-dropMarker is displayed as a horizontal line when Gallery is dragged-drop to Media Caption - 10https://bugzilla.wikimedia.org/73528 (10etonkovidova) 3NEW p:3Unprio s:3normal a:3None Created attachment 17149 --> https://bugzilla.wik... [22:37:37] <grrrit-wm> (03CR) 10Catrope: [C: 032] Add lang and dir attributes to the accelerator element [oojs/ui] - 10https://gerrit.wikimedia.org/r/173872 (owner: 10Amire80) [22:38:30] <RoanKattouw> TrevorParscal: Could you review https://gerrit.wikimedia.org/r/#/c/173331/? [22:39:16] <mooeypoo> what in the name of all that is draggable is going on here. [22:39:40] <grrrit-wm> (03Merged) 10jenkins-bot: Add lang and dir attributes to the accelerator element [oojs/ui] - 10https://gerrit.wikimedia.org/r/173872 (owner: 10Amire80) [22:39:59] <mooeypoo> This is ridiculous. All I've done was added a conditional class to draggableGroupElement and changed the display:inline-block rule. Now no item (with and without that class) is dragging at all. [22:40:15] * mooeypoo shakes her fist at dragdrop [22:41:30] <TrevorParscal> MatmaRex: report? [22:42:04] <MatmaRex> TrevorParscal: um, summary of stuff i did and am going to do i typed up [22:42:09] <grrrit-wm> (03CR) 10Trevor Parscal: [C: 032] Change document order of tools and actions to fix floating [oojs/ui] - 10https://gerrit.wikimedia.org/r/173331 (owner: 10Esanders) [22:42:20] <MatmaRex> Stuff I wanna do next: [22:42:20] <MatmaRex> * Mangling our icons to be parseable by rsvg; it was mentioned on wikitech-l by Amir, by the way [22:42:20] <MatmaRex> * Magical RTL support in RLImageModule? [22:42:27] <MatmaRex> TrevorParscal: this make sense to you? ^ [22:42:38] <MatmaRex> or, are you perhaps working on any of these? [22:42:48] <RoanKattouw> TrevorParscal: Do you remember the rich feature set for icon localization we talked about a while ago? I put it in a gist somewhere [22:42:56] <TrevorParscal> MatmaRex: sweet - no I'm not touching any of those bits atm [22:43:24] <RoanKattouw> Maybe that could be part of the "magical RTL support" MatmaRex is talking about? [22:43:24] <TrevorParscal> RoanKattouw: I included it in an email, I need to look a the icon module config to see how far away we are [22:43:41] <TrevorParscal> yeah, we never did figure out a nice way to specify "flip me automatically plz" [22:44:00] <TrevorParscal> https://gist.github.com/catrope/70117fa069eb7cec314a [22:44:03] <grrrit-wm> (03Merged) 10jenkins-bot: Change document order of tools and actions to fix floating [oojs/ui] - 10https://gerrit.wikimedia.org/r/173331 (owner: 10Esanders) [22:44:11] <TrevorParscal> maybe we did [22:44:12] <TrevorParscal> 'rtlflip' => true [22:44:32] <RoanKattouw> Did you find my gist? [22:44:37] <RoanKattouw> We put a lot of stuff in there [22:44:45] <TrevorParscal> this API is nice, because it's flexible, but it seems like it will need some good documentation [22:44:53] <RoanKattouw> Yes [22:44:54] <TrevorParscal> kirstenMA to the resuce! [22:45:01] <TrevorParscal> kirstenMA: how's it going by the way? [22:45:11] <TrevorParscal> did you see some of my changes from Friday? [22:45:13] <kirstenMA> hi [22:45:26] <TrevorParscal> I need to get back into the document and go through more of it [22:45:56] <kirstenMA> I haven't gone through closely yet, but I noticed a bunch of changes and comments. [22:46:14] <kirstenMA> I've been plugging away.. [22:46:34] <TrevorParscal> awesome [22:46:47] <TrevorParscal> MatmaRex: how close are you following the config options in that gist? [22:46:53] <TrevorParscal> I need to look at your code again [22:47:31] <MatmaRex> TrevorParscal: not RTL support at all yet [22:47:36] <TrevorParscal> ok [22:47:44] <MatmaRex> so, only this: 'remove' => array( 'image' => 'remove.png', 'variants' => array( 'destructive' ) ), [22:47:55] <TrevorParscal> i think the gist just shows a few things in different combinations [22:48:02] <MatmaRex> yep [22:48:24] <MatmaRex> still, the above is all that the code currently handles [22:48:33] <MatmaRex> well, "'help' => 'help.png'," too, i guess [22:49:12] <TrevorParscal> right, that's sort of the "file.png" is shorthand for array( "image" => "file.png" ) [22:49:56] <TrevorParscal> then there's just language and direction support [22:50:03] <TrevorParscal> and making it work so you can mix and match those things [22:50:29] <MatmaRex> hmm, actually i don't think that'll work, only plain "'help.png'," will… i guess that's another thing to do [22:50:30] <TrevorParscal> MatmaRex: tell me about the SVG mangling for rsvg support? [22:51:05] <MatmaRex> TrevorParscal: i'm going to Figure It Out™ [22:51:10] <TrevorParscal> oh [22:51:12] <MatmaRex> can't possible be that difficult to do, can it? :D [22:51:15] <MatmaRex> possibly* [22:51:19] <TrevorParscal> ok, well when you do, I'd love to have story time [22:51:30] <TrevorParscal> I'll get some popcorn and a cozy blanket [22:51:48] <MatmaRex> i plan to write some tiny script to post-process svgo's output and put it up somewhere [22:51:49] <TrevorParscal> we can all huddle around our computers and listen to the frightening tales [22:51:56] <TrevorParscal> cool [22:52:06] <TrevorParscal> just a github repo or whatever is fine [22:52:41] <TrevorParscal> MatmaRex: I redid my rename commits by the way [22:52:53] <TrevorParscal> I wrote shell scripts that generate them [22:53:06] <TrevorParscal> and made sure i was doing case sensitive replacements [22:53:12] <MatmaRex> seen it, neat [22:53:17] <TrevorParscal> there were more issues than just that, but thank you for the review there [22:53:27] <TrevorParscal> these are always sort of frightening changes [22:53:28] <MatmaRex> (roan mentioned he wants to merge it later?) [22:53:44] <RoanKattouw> Yeah after wmf9 is cut [22:53:47] <TrevorParscal> but I want to be aggressive in improving the cleanliness of the library [22:53:47] <RoanKattouw> So it goes into wmf10 [22:54:08] <TrevorParscal> and as more people start using we will have to slow that down [22:54:18] <TrevorParscal> so, I'm sort of rushing to ensure that things don't suck too badly [22:54:22] <wikibugs> 3VisualEditor / 3ContentEditable: VisualEditor: Pasting annotated text causes space to be removed at annotation separators - 10https://bugzilla.wikimedia.org/71718#c5 (10etonkovidova) Verified the fix in betalabs and test2. [22:54:38] <TrevorParscal> and when documenting things with kirstenMA I'm finding odd stuff that needs love [22:54:40] <wikibugs> 3VisualEditor / 3Editing Tools: VisualEditor: Switching browser tab/window changes the tab selection from Advanced Settings tab to General Settings - 10https://bugzilla.wikimedia.org/61062#c5 (10Rummana Yasmeen) 5ASSI>3RESO/FIX yeah! Not reproducible anymore at my end as well. [22:54:49] <MatmaRex> yep [22:55:08] <MatmaRex> i still need to do the RadioInputWidget thingy [22:55:43] <MatmaRex> i think for now i'll just do it like CheckboxInputWidget, we'll probably want a RadioInputWidgetGroup or something later, but i doubt that we're going to need it soon [22:55:57] <TrevorParscal> I left the search (a composition of an input and a select) and result (a kind of option) thing alone for now, wanting to see how that all panned out with mooeypoo's work [22:56:32] <TrevorParscal> MatmaRex: yeah, and also of course the thing with radios is that they are associated by name, not by structure [22:56:46] <TrevorParscal> so, we could get into trouble assuming structural relationships exist [22:57:46] <MatmaRex> yeah. usually we will just want to place them all one after another, quite like a <select> list's <option>s, but not always [22:58:06] <MatmaRex> (if you want a practical example, there's one in MW's installer that i regret having had to write) [22:59:27] <TrevorParscal> best to just use the name option, and then make a getSelectedValue method [22:59:57] <TrevorParscal> it's not uncommon to require additional markup, and our library should avoid making that a problem [23:03:50] <wikibugs> 3VisualEditor / 3Editing Tools: VisualEditor: Allowing creation of empty caption moves the column editing icon at the top of the empty space which looks odd - 10https://bugzilla.wikimedia.org/72829#c8 (10Rummana Yasmeen) Verified the fix in Betalabs and test2 [23:04:37] <wikibugs> 3VisualEditor / 3Editing Tools: VisualEditor: Allowing creation of empty caption moves the column editing icon at the top of the empty space which looks odd - 10https://bugzilla.wikimedia.org/72829 (10Rummana Yasmeen) [23:06:08] <wikibugs> 3VisualEditor / 3ContentEditable: VisualEditor: Safari - white spaces are dropped for copied formatted text - 10https://bugzilla.wikimedia.org/73333#c4 (10etonkovidova) This was verified in betalabs. It is sort of a test case for the bug fix for 71718. [23:10:45] <TrevorParscal> mooeypoo: what should I use to see the UI of TemplateData? [23:12:01] <TrevorParscal> https://gerrit.wikimedia.org/r/#/c/167046/ ? [23:12:50] <wikibugs> 3VisualEditor / 3ContentEditable: VisualEditor: Pawn ♙ appears after deleting the text preceding and following a link by "undo" action - 10https://bugzilla.wikimedia.org/61521#c6 (10Rummana Yasmeen) 5RESO/FIX>3REOP I just reproduced this on Chrome in Betalabs [23:14:06] <wikibugs> 3VisualEditor / 3ContentEditable: VisualEditor: Pawn ♙ appears after deleting the text preceding and following a link by "undo" action - 10https://bugzilla.wikimedia.org/61521#c7 (10Rummana Yasmeen) Created attachment 17150 --> https://bugzilla.wikimedia.org/attachment.cgi?id=17150&action=edit video captur... [23:14:36] <wikibugs> 3VisualEditor / 3ContentEditable: VisualEditor: Pawn ♙ appears after deleting the text preceding and following a link by "undo" action - 10https://bugzilla.wikimedia.org/61521 (10Rummana Yasmeen) 5REOP>3ASSI a:3Alex Monk [23:19:20] <wikibugs> 3VisualEditor / 3ContentEditable: VisualEditor: Copy paste is not working for Math elements - 10https://bugzilla.wikimedia.org/58981#c4 (10Rummana Yasmeen) 5RESO/FIX>3REOP you mean, its fine if the copied math math function does render on the other page? [23:20:35] <wikibugs> 3VisualEditor / 3ContentEditable: VisualEditor: Copy paste is not working for Math elements - 10https://bugzilla.wikimedia.org/58981#c5 (10Rummana Yasmeen) (In reply to Rummana Yasmeen from comment #4) > you mean, its fine if the copied math math function does not render on the other > page? *Does not* Bec... [23:21:51] <wikibugs> 3VisualEditor / 3ContentEditable: VisualEditor: Copy paste is not working for Math elements - 10https://bugzilla.wikimedia.org/58981 (10Rummana Yasmeen) 5REOP>3ASSI a:3Alex Monk [23:31:51] <TrevorParscal> mooeypoo: you three? [23:31:54] <TrevorParscal> *there [23:38:36] <grrrit-wm> (03CR) 10Catrope: [C: 04-2] "Looks good. Blocking merge until the wmf9 cut has happened." [oojs/ui] - 10https://gerrit.wikimedia.org/r/173356 (owner: 10Trevor Parscal) [23:40:57] <mooeypoo> I am two. [23:41:28] <mooeypoo> TrevorParscal, do you have the TemplateData extension installed? [23:41:48] <mooeypoo> Sorry, went to bring myself some tea [23:42:39] <mooeypoo> TrevorParscal, so, install the TemplateData extension: http://www.mediawiki.org/wiki/Extension:TemplateData then pull that fix ( https://gerrit.wikimedia.org/r/#/c/167046/ ) [23:43:04] <mooeypoo> TrevorParscal, then go to any template page.. like Template:Test or something, and you should have "Edit TemplateData" button above the edit box. [23:43:47] <grrrit-wm> (03PS1) 10Catrope: Update OOjs UI to v0.1.0-pre (f1abca8e82) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/174008 [23:44:58] <wikibugs> 3VisualEditor / 3Editing Tools: VisualEditor: The style of error message for invalid page title for link should be more apparent in style - 10https://bugzilla.wikimedia.org/62761#c8 (10Rummana Yasmeen) 5RESO/?>3VERI Nice! [23:46:15] <grrrit-wm> (03CR) 10Krinkle: [C: 032] "maintenance" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173969 (https://bugzilla.wikimedia.org/72132) (owner: 10Krinkle) [23:47:08] <Krinkle> RoanKattouw: Indeed. Review my changes, and run a final test locally that it works properly overal (since we have very few tests in tempaltedata) [23:47:40] <grrrit-wm> (03Merged) 10jenkins-bot: Replaces spaces with tabs in en.json [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173969 (https://bugzilla.wikimedia.org/72132) (owner: 10Krinkle) [23:48:15] <James_F> RoanKattouw: Were you going to do a https://gerrit.wikimedia.org/r/174008 for MW-core? [23:49:00] <RoanKattouw> James_F: Yes, but the script is still running [23:49:12] <James_F> RoanKattouw: ?! What did you do? :-) [23:49:13] <RoanKattouw> 'git fetch origin' in MW core on this connection is taking forever [23:49:18] <RoanKattouw> Oh there it goes [23:49:24] <James_F> RoanKattouw: Ooooh. You could have just asked me to do it… -) [23:53:10] <RoanKattouw> James_F: Could you create pull-throughs for the SWAT though? [23:54:01] <RoanKattouw> James_F: I'll start with 8, you start with 7? [23:55:18] <grrrit-wm> (03PS1) 10Catrope: Update VE core for cherry-picks [extensions/VisualEditor] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/174013 [23:55:27] <grrrit-wm> (03PS52) 10Paladox: WikiEditor: Re add SVG [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151611 (https://bugzilla.wikimedia.org/35342) [23:55:55] <grrrit-wm> (03CR) 10Jforrester: [C: 032] Update OOjs UI to v0.1.0-pre (f1abca8e82) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/174008 (owner: 10Catrope) [23:56:03] <grrrit-wm> (03CR) 10Catrope: [C: 032 V: 032] Update VE core for cherry-picks [extensions/VisualEditor] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/174013 (owner: 10Catrope) [23:57:34] <grrrit-wm> (03CR) 10Esanders: [C: 04-1] Provide a FileDropHandler for CSV and TSV files (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173296 (owner: 10Jforrester) [23:58:18] <grrrit-wm> (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (f1abca8e82) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/174008 (owner: 10Catrope) [23:59:57] <grrrit-wm> (03PS1) 10Jforrester: Update VE core for cherry-picks (7819523) [extensions/VisualEditor] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/174016