[00:05:26] (03CR) 10Trevor Parscal: [C: 04-1] Adding DraggableGroupElement and DraggableElement mixins (036 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/172325 (owner: 10Mooeypoo) [00:05:39] mooeypoo: see comments [00:05:44] * mooeypoo shall [00:05:46] thnks TrevorParscal [00:05:51] n/p [00:06:07] when are you moving btw? late december? january? [00:16:27] (03PS1) 10Krinkle: util: Fix typo "siuch" in comment [oojs/core] - 10https://gerrit.wikimedia.org/r/174322 [00:17:21] (03CR) 10Jforrester: [C: 031] util: Fix typo "siuch" in comment [oojs/core] - 10https://gerrit.wikimedia.org/r/174322 (owner: 10Krinkle) [00:17:36] 3VisualEditor / 3Editing Tools: VisualEditor: Insert Media - "Error creating thumbnail" - 500 server error - 10https://bugzilla.wikimedia.org/73584 (10Alex Monk) [00:19:38] (03PS1) 10Bartosz Dziewoński: Fix typos [oojs/ui] - 10https://gerrit.wikimedia.org/r/174323 [00:20:02] the top comment here is "give it to wikipedia": http://www.reddit.com/r/AskReddit/comments/2moyiz/serious_how_should_reddit_inc_distribute_a/ [00:20:06] 3VisualEditor / 3Editing Tools: VisualEditor: IE11 - Save page Edit summary text box is black - 10https://bugzilla.wikimedia.org/72917 (10Alex Monk) [00:20:16] (03PS1) 10Krinkle: Consistently use location as global, and location.href for full url [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174324 [00:20:21] MatmaRex: Tsk, add items to the fix-typos tool patch too. :-) [00:21:48] James_F: too lazy. also, fewer imaginary internet points. :) [00:22:32] MatmaRex: :-P [00:23:10] i'm off for tonight. sleep well [00:23:41] MatmaRex: See you. [00:23:42] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/172751/5 [00:27:14] James_F, is https://bugzilla.wikimedia.org/show_bug.cgi?id=73376 a duplicate of something? [00:27:20] Thought I saw a bug for this already... [00:27:49] though perhaps it was this one [00:31:06] Krenair: Looking. [00:31:26] Krenair: Oh, yeah, OOUI bug that's been getting worse over time. [00:31:44] ah, I haven't searched OOUI's product :) [00:32:33] https://bugzilla.wikimedia.org/show_bug.cgi?id=70061 [00:32:50] 3VisualEditor / 3ContentEditable: VisualEditor: Switching to Edit source warning dialog box displays misaligned labels - 10https://bugzilla.wikimedia.org/73376#c1 (10James Forrester) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 70061 *** [00:33:05] 3OOjs UI: OOjs UI: Issues with button placement and sizing on first open - 10https://bugzilla.wikimedia.org/70061#c6 (10James Forrester) *** Bug 73376 has been marked as a duplicate of this bug. *** [00:33:20] https://bugzilla.wikimedia.org/show_bug.cgi?id=58231 is https://bugzilla.wikimedia.org/show_bug.cgi?id=55976 [00:33:23] 3OOjs UI: OOjs UI: Issues with button placement and sizing on first open - 10https://bugzilla.wikimedia.org/70061#c7 (10James Forrester) p:5Low>3High s:5normal>3major This has got a lot worse. :-( [00:34:48] Krenair: Yes. [00:34:50] 3VisualEditor / 3Editing Tools: VisualEditor:"Apply changes" on the transclusion dialog box and "Save Page" button on the page remains active even though there is no change on the transclusion dialog box - 10https://bugzilla.wikimedia.org/58231#c2 (10James Forrester) 5NEW>3RESO/DUP Merging into 55976. *... [00:35:06] 3VisualEditor / 3Editing Tools: VisualEditor: Dialogs should disable "Apply changes" until a change is present - 10https://bugzilla.wikimedia.org/55976#c3 (10James Forrester) *** Bug 58231 has been marked as a duplicate of this bug. *** [00:35:10] Krenair: No need to work on bug triage; code is harder. :-) [00:35:36] 3VisualEditor / 3MediaWiki integration: VisualEditor: Please mention a way of reporting bugs in the Save dialog - 10https://bugzilla.wikimedia.org/68692 (10Alex Monk) [00:36:30] James_F, heh. Is https://bugzilla.wikimedia.org/show_bug.cgi?id=72782 also that OOUI bug? [00:36:44] Krenair: No. [00:37:39] 3VisualEditor / 3MediaWiki integration: VisualEditor: Save page dialog's edit summary text box is black in Internet Explorer 11 - 10https://bugzilla.wikimedia.org/72917 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High [00:37:39] 3VisualEditor / 3Initialisation: VisualEditor: Internet Explorer compatibility (tracking) - 10https://bugzilla.wikimedia.org/50085 (10James Forrester) [00:39:08] 3VisualEditor / 3ContentEditable: VisualEditor:[Regression pre-wmf9] Inserted Media caption is not displayed correctly - 10https://bugzilla.wikimedia.org/73441 (10Rummana Yasmeen) [00:44:20] 3VisualEditor: VisualEditor: Some dialogs are showing with transparent backgrounds in IE11 - 10https://bugzilla.wikimedia.org/72643 (10Alex Monk) [01:01:22] (03CR) 10Alex Monk: "Discussion about the issues preventing this from recording moves:" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173360 (https://bugzilla.wikimedia.org/50809) (owner: 10Alex Monk) [01:02:07] James_F: What're you waiting for from me besides the qunit migration at the moment? [01:03:10] As for that one, I'll finish deployment of migration to labs tonight. And creating a grunt-lib-chromium (to complement grunt-lib-phantomjs as used by grunt-contrib-qunit), is something I'll have to look into. I'm hoping I can ask someone upstream to write it. [01:03:48] Krinkle: I slung a "new" bug at you just today about closures around VE that Roan said you'd be the only person in the world for. [01:03:53] Mean reason is that we can't use Karma because that requires static file setup. it supports proxy for individual js resources, but not for the bootstrapping, and it fundamentally can't support such a thing because of how it works. [01:04:08] Yeah, I recall that, but lost the reference. [01:04:23] RoanKattouw: [2014-11-18 21:18:04 +00:00] I was just about to ping Krinkle|detached with https://gerrit.wikimedia.org/r/174270 [01:04:34] Nope, not that one [01:05:03] Sorruy. [01:05:25] James_F, with https://bugzilla.wikimedia.org/show_bug.cgi?id=73565 do you know why "We need to chose a method for selectively loading styles in core, either conditional stylesheet tags or a body class."? [01:05:44] Nope, I wonder where that sling was. Can you link me again? [01:06:13] Is VE core not able to load stylesheets conditionally? [01:08:12] seems so... Guess this shows how little I know about core :/ [01:09:23] (03CR) 10Mooeypoo: "Changes comming up in the next patchset." (036 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/172325 (owner: 10Mooeypoo) [01:09:33] Krinkle: Not right now. [01:09:50] And it's IE stuff. :/ [01:10:40] (03PS9) 10Mooeypoo: Adding DraggableGroupElement and DraggableElement mixins [oojs/ui] - 10https://gerrit.wikimedia.org/r/172325 [01:11:39] (03PS1) 10Krinkle: Use history as as global [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/174340 [01:12:16] (03PS1) 10Krinkle: Use history as global instead of via window [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174341 [01:15:44] (03CR) 10Krinkle: "The "depends on" commit has not been merged yet." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167772 (owner: 10Mvolz) [01:16:01] Krinkle: Roan was going to do so. [01:16:50] (03CR) 10Krinkle: Methods for new "maps" property in TD Root (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167772 (owner: 10Mvolz) [01:17:13] James_F: The name may change to something else depending on outcome of pending thread. [01:17:32] E.g. "consumers" instead of "maps" and allowing any config instead of just parameter names. Which seems rather arbitrary and specific. [01:17:58] Anyway, nothing final on that front. It was merely a suggestion. [01:22:03] (03CR) 10Krinkle: "Follows-up Ica33de675." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/171564 (owner: 10Esanders) [01:22:06] (03CR) 10Krinkle: "Follows-up Ica33de675." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/171429 (owner: 10Catrope) [01:24:35] 3VisualEditor / 3Data Model: VisualEditor: Revive Inez's way of doing sub-surfaces - 10https://bugzilla.wikimedia.org/49565#c1 (10James Forrester) 5ASSI>3RESO/WON Instead we're going to go with sub-documents directly. [01:27:38] 3VisualEditor / 3ContentEditable: VisualEditor: Preserve `data-parsoid` attribute on internal copy-paste so that Parsoid preserves e.g. syntax layout - 10https://bugzilla.wikimedia.org/72426#c20 (10ssastry) This is what edsanders had said: "also you should be aware that the user agent may randomly mangle att... [01:41:56] (03PS1) 10Krinkle: mw.ViewPageTarget.init: Simplify hideLoading and pushState [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174345 [01:42:13] (03CR) 10Krinkle: Refactor out show/hide loading spinner (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/171564 (owner: 10Esanders) [01:46:44] (03PS1) 10Krinkle: test: Omit 'window' in mw-preload.js [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174346 [01:47:58] (03CR) 10Catrope: "Conflicts with https://gerrit.wikimedia.org/r/174270" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174345 (owner: 10Krinkle) [01:48:21] [17:04] Krinkle RoanKattouw: [2014-11-18 21:18:04 +00:00] I was just about to ping Krinkle|detached with https://gerrit.wikimedia.org/r/174270 [01:48:37] Krinkle: You know, I pinged you to review that code *and then* you went ahead and wrote code that conflicts with it :P [01:48:43] ( https://gerrit.wikimedia.org/r/#/c/174345/ ) [01:48:46] So I have no pity for you ;) [01:50:10] RoanKattouw: Conflicts when it is merged, yes, but it isn't. We'll rebase when it comes to it. [01:50:50] I prefer to keep my commits atomic and quick local. On my current connection, fetching that first would've taken longer than just writing that up and pushing it. [01:50:56] Sure [01:50:58] Krinkle: Top tip. Your commit won't get merged first. :-) [01:51:05] I know, and I don't care. [01:51:11] I knew that before I wrote it [01:51:15] OK cool [01:51:20] In any case -- mind reviewing my code? :) [01:51:23] It fixes a bug [01:53:01] RoanKattouw: Sure; Wanna pick up a few simple ones from here? https://gerrit.wikimedia.org/r/#/q/owner:Krinkle+status:open+branch:master+topic:cleanup,n,z [01:53:16] Krinkle: Not tonight. Roan's got code to land. [01:54:01] Krinkle: I'll pick up a few of those, sure [01:54:05] But I'll point you to the topic [01:54:08] "cleanup" [01:54:15] Whereas mine is "fix bug" :) [01:54:22] I'm not dealing. [01:54:40] Good, I'm a teetotaler anyway :P [01:54:47] (the most ridiculous word in the English language) [01:57:15] (03CR) 10Catrope: [C: 032] test: Omit 'window' in mw-preload.js [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174346 (owner: 10Krinkle) [01:57:41] Krinkle: https://bugzilla.wikimedia.org/show_bug.cgi?id=48885 was the bug I wanted you to work on. [01:57:42] (03CR) 10Catrope: [C: 032] Use history as as global [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/174340 (owner: 10Krinkle) [01:57:53] 3VisualEditor / 3Technical Debt: VisualEditor: Load visualeditor modules in a closure mapping $/mw/ve to their globals - 10https://bugzilla.wikimedia.org/48885 (10James Forrester) p:5Low>3High [01:58:09] (03CR) 10Catrope: [C: 032] Use history as global instead of via window [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174341 (owner: 10Krinkle) [01:58:32] (03Merged) 10jenkins-bot: test: Omit 'window' in mw-preload.js [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174346 (owner: 10Krinkle) [01:58:40] James_F: OK. Can you point out in a few words why it's prio? [01:59:03] RoanKattouw: I'm reproducing that bug now, patch LGTM. [01:59:15] (03CR) 10Catrope: [C: 032] Consistently use location as global, and location.href for full url [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174324 (owner: 10Krinkle) [01:59:20] Cool, thanks [01:59:21] Krinkle: Stability of code against breakage? [01:59:27] (03Merged) 10jenkins-bot: Use history as global instead of via window [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174341 (owner: 10Krinkle) [01:59:27] Krinkle: Also, did you see my comment on https://gerrit.wikimedia.org/r/#/c/174306/ ? [01:59:37] I accidentally already +2ed something that conflicts with it, but we can handle that [01:59:39] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/174322/ [01:59:53] (03CR) 10Catrope: [C: 032] util: Fix typo "siuch" in comment [oojs/core] - 10https://gerrit.wikimedia.org/r/174322 (owner: 10Krinkle) [01:59:58] (03Merged) 10jenkins-bot: Use history as as global [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/174340 (owner: 10Krinkle) [02:00:03] Krinkle, if properties of window are globals, why do we have both? to do with frames? [02:00:38] (03Merged) 10jenkins-bot: Consistently use location as global, and location.href for full url [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174324 (owner: 10Krinkle) [02:01:21] Krenair: No, it's because some guy somewhere in the 90s misunderstood it and used window everywhere and everyone copied it (butterfly effect). Usage of 'document' and libraries is more common and tends to be disinfected quicker when someone uses 'window' for them. [02:01:51] I think people tend to think that somehow history and location are magical and need window because loads of other people do [02:01:54] There is no reason for it. [02:02:35] James_F: I did see that. Haven't reproduced it locally, but shouldn't matter. Its' just tech debt being cleaned up (assuming you want to keep that task in generarl) [02:03:52] (03Merged) 10jenkins-bot: util: Fix typo "siuch" in comment [oojs/core] - 10https://gerrit.wikimedia.org/r/174322 (owner: 10Krinkle) [02:05:53] Krenair: You have to kind of go against your gut in javascript and assume every recommendation, stackoverflow, mdn, blogpost is written by someone who didn't scrutinise the code in question for why it is that way. People tend to stop fiddling when it starts working no matter the weird frankenstein state it might have ended up in. [02:06:12] Okay, thanks Krinkle :) [02:06:20] and things spread fast and widely :D [02:06:35] I even defended window.location at some point in the past. [02:06:46] Tried to anyway :P [02:08:25] (03PS2) 10Krinkle: Fix back button not exiting VE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174270 (owner: 10Catrope) [02:09:19] (03CR) 10Krinkle: "Rebased to resolve conflict." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174270 (owner: 10Catrope) [02:09:36] (03CR) 10Krinkle: [C: 032] Fix back button not exiting VE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174270 (owner: 10Catrope) [02:09:46] Nice. I see a table button in the toolbar :) [02:10:18] And no doubt, it was James_F who made sure the menu says "Fewer" after "More" [02:10:27] Krinkle: I do, but if we're touching it we should actually make it work. [02:10:58] (03Merged) 10jenkins-bot: Fix back button not exiting VE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174270 (owner: 10Catrope) [02:11:04] Thanks Krinkle [02:11:06] Krinkle: ;-) [02:12:13] Hm.. I hadn't seen the table code at all (only the original PoC from the third-party committers). Quite nice [02:12:36] Hm.. the inspector on a cell (with add row etc.) seems to not have a hover state when hovering the items. [02:12:38] Yeah Ed refactored a lot of selection-related VE to make that work [02:12:44] Krinkle: Yes :( [02:12:47] Welcome to ContextItemWidget [02:13:02] Right. This is a context menu. [02:13:08] To be fair there is a good reason why we don't have that hover state on a context menu with a single item [02:13:17] But this is still one of the things I go "damn you Trevor" over [02:13:23] It looks disabled. The text is greyer as well. [02:13:54] Isn't there a hover effect for opacity? [02:13:59] No [02:14:00] I think it goes from 80% to 100% on hover, or something [02:14:32] And I'm curious why this is a context menu. It's not liek a table cell has three nodes applies to it ( a new row, new column and delete column node), like for text that has multipel annotatoins (link and language or something) [02:14:42] Krenair: Can you please stop moving bugs into "General"? It's a "no-one who knows anything has worked out where this bug is" component. No real triaged bugs should ever be in it. [02:15:23] 3VisualEditor / 3Editing Tools: VisualEditor: Some dialogs are showing with transparent backgrounds in IE11 - 10https://bugzilla.wikimedia.org/72643 (10James Forrester) [02:16:37] James_F, these the bugs I was moving out of ContentEditable earlier? [02:17:11] Krenair: Yeah. [02:17:17] lol, this is not good. Somehow inserted tables stay there when I switch to read mode! [02:17:29] Krenair: It just means someone has to come and move them to the right place instead. :-) [02:17:40] James_F: Edit page, insert table, save page, review edits (this step is required), resume editing, read mode, observe the new table still being there, and you can even highlight cells. [02:17:48] Krinkle: Bug report with detailed step-by-step instructions and a patch or it didn't happen. [02:18:31] James_F, I think that was the point. But maybe those component descriptions could be better [02:22:13] Krenair: You're capable of putting it in the right place. :-) [02:23:38] 3VisualEditor / 3Initialisation: VisualEditor: Viewing the diff before exiting to read mode without saving leaves the editor active - 10https://bugzilla.wikimedia.org/73589 (10James Forrester) 3ASSI p:3Unprio s:3normal a:3None 1. Edit page 2. Insert table 3. Load save dialog 4. Review diff 5. Resume... [02:23:39] 3VisualEditor / 3Initialisation: VisualEditor: Viewing the diff before exiting to read mode without saving leaves the editor active - 10https://bugzilla.wikimedia.org/73589 (10James Forrester) p:5Unprio>3Normal [02:24:37] 3VisualEditor / 3MediaWiki integration: VisualEditor: Switching to read mode after rendering diff leaves ve.ce.Surface behind - 10https://bugzilla.wikimedia.org/73590 (10Krinkle) 3NEW p:3Unprio s:3normal a:3None Created attachment 17168 --> https://bugzilla.wikimedia.org/attachment.cgi?id=17168&act... [02:24:50] 3VisualEditor / 3MediaWiki integration: [Regression] VisualEditor: Switching to read mode after rendering diff leaves ve.ce.Surface behind - 10https://bugzilla.wikimedia.org/73590 (10Krinkle) [02:25:00] Krinkle: Ha, you created it after all. [02:25:20] James_F: Sorry it took me all of 1 minute longer. [02:25:23] Krinkle: You sure it's a regression? [02:25:24] :D [02:25:29] Yes, most certainly. [02:25:32] It worked last year :P [02:25:48] Krinkle: Are you sure? Table editing introduced new ways to show it not working. [02:25:48] I would've noticed sooner. I'd say less than a month. [02:25:53] Not related to tables [02:25:56] See my bug [02:26:12] Krinkle: Your bug gives no evidence that it's a regression. [02:26:47] Krinkle: Tables' special controls provide the ability to convert from ce=false to ce=true which other controls never did, so… [02:26:57] We never do that. I'm not even sure what you mean by evidence. It worked last month. what else do you need for regression marking? [02:27:20] James_F: regularly inserted text also persists, and I can highlight headings, too. [02:27:25] Krinkle: Generally you need to actually have a branch where it worked. [02:27:34] My bug filing is done. [02:28:22] 3VisualEditor / 3MediaWiki integration: [Regression] VisualEditor: Switching to read mode after rendering diff leaves ve.ce.Surface behind - 10https://bugzilla.wikimedia.org/73590#c1 (10James Forrester) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 73589 *** [02:28:22] 3VisualEditor / 3Initialisation: VisualEditor: Viewing the diff before exiting to read mode without saving leaves the editor active - 10https://bugzilla.wikimedia.org/73589#c1 (10James Forrester) *** Bug 73590 has been marked as a duplicate of this bug. *** [02:29:31] James_F: Referering to a wmf branch for regressions is something we've only done in the past few months, and afaik only in QA context and only for VisualEditor from what I've seen. We've had the concept of regressions longer than that. [02:29:51] and wmf branches are abitrary anyway, since it's just a week cut. [02:30:10] * Krinkle moves on and goes back to what he was working on before being distracted by a regression and taking the time to tell you :) [02:30:12] Krinkle: It's more the "it's a regression!" is a claim people frequently make wrongly. [02:31:02] I know my steps to reproduce did not result in this behaviour last month. And if I checkout master@{1 month ago} locally, it will work as expected. I'm not the one fixing it right now so doing that seems like wasted effort at this point. [02:32:02] I'd argue it's already more usable than most reported bug in its current state. something about balance of input effort and individual productivity. [02:32:40] Krinkle: I thought you'd moved on? [02:33:00] I run into regressions like these at least 10 times every day. I can't file them all or I'd be creating a new job position. [02:33:53] What use is it to notice but not mention regressions? [02:35:26] #not-my-job maybe? Sometimes I'm just a user and wanna get stuff done I'm working on and not get side-tracked for an hour trying to narrow down a bug so that it's not a useless report. [02:35:48] Krinkle: Isn't fixing code all of our jobs? [02:36:58] Yes. But you missed my point. Ask me some other time. [02:37:17] I didn't miss your point. You missed mine. [02:37:26] Story of my life. [02:38:33] (03PS5) 10Jforrester: Add some sanity checks in newFromReplacement, pushInsertion and pushRemoval [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118371 (owner: 10Catrope) [02:38:37] (03PS6) 10Jforrester: Add some sanity checks in newFromReplacement, pushInsertion and pushRemoval [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118371 (owner: 10Catrope) [02:38:44] (03CR) 10Jforrester: Add some sanity checks in newFromReplacement, pushInsertion and pushRemoval (034 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118371 (owner: 10Catrope) [02:39:07] (03CR) 10Jforrester: [C: 04-1] "Needs unit tests, and fixes to existing tests so it passes." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118371 (owner: 10Catrope) [02:39:34] (03PS2) 10Jforrester: [WIP] Add cloneWithData() utility [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155655 (owner: 10Catrope) [02:39:52] (03CR) 10Jforrester: [C: 04-1] "Needs unit tests." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155655 (owner: 10Catrope) [02:41:30] (03CR) 10Krinkle: build: Create a 'typos' task and fix a remaining @returns to be @return (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/174147 (owner: 10Jforrester) [02:42:30] (03CR) 10jenkins-bot: [V: 04-1] Add some sanity checks in newFromReplacement, pushInsertion and pushRemoval [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118371 (owner: 10Catrope) [02:42:51] (03CR) 10Jforrester: [C: 04-1] "Needs rebasing, tests." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140244 (owner: 10Catrope) [02:43:17] (03CR) 10Jforrester: [C: 04-1] "Needs splitting, rebasing, reality check, tests." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/74084 (https://bugzilla.wikimedia.org/37835) (owner: 10Catrope) [02:44:07] 3VisualEditor / 3Technical Debt: VisualEditor: Decide whether this.active should be in mw.Target or mw.ViewPageTarget - 10https://bugzilla.wikimedia.org/73591 (10Roan Kattouw) 3NEW p:3Unprio s:3normal a:3None Right now ViewPageTarget defines this.active, but it's set to true by mw.Target. This is hor... [02:45:50] 3VisualEditor / 3Technical Debt: VisualEditor: Decide whether this.active should be in mw.Target or mw.ViewPageTarget - 10https://bugzilla.wikimedia.org/73591 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal s:5normal>3enhanc [02:57:41] 3VisualEditor / 3Technical Debt: VisualEditor: Separate ve.init and ve.platform - 10https://bugzilla.wikimedia.org/50707 (10James Forrester) [02:57:41] 3VisualEditor / 3MediaWiki integration: VisualEditor: mw.Target / ViewPageTarget re-write (tracking) - 10https://bugzilla.wikimedia.org/73593 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal s:5normal>3enhanc [02:57:41] 3VisualEditor / 3Technical Debt: VisualEditor: Use mw.Api library in mw.Target instead of our own functions - 10https://bugzilla.wikimedia.org/56659 (10James Forrester) [02:57:58] 3VisualEditor / 3Technical Debt: VisualEditor: Decide whether this.active should be in mw.Target or mw.ViewPageTarget - 10https://bugzilla.wikimedia.org/73591 (10James Forrester) [02:57:58] 3VisualEditor / 3Technical Debt: VisualEditor: Disentangle MWSaveDialog and ViewPageTarget - 10https://bugzilla.wikimedia.org/65513 (10James Forrester) [02:57:58] 3VisualEditor: VisualEditor: Tracking bugs for VisualEditor (tracking) - 10https://bugzilla.wikimedia.org/54363 (10James Forrester) [02:57:58] 3VisualEditor / 3Technical Debt: VisualEditor: ResourcesTest::testUnsatisfiableDependencies: The module 'mobile.editor.ve' must not have target 'desktop' - 10https://bugzilla.wikimedia.org/68956 (10James Forrester) [02:58:18] (03PS2) 10Jforrester: mw.ViewPageTarget.init: Simplify hideLoading and pushState [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174345 (owner: 10Krinkle) [03:00:02] (03CR) 10Jforrester: [C: 031] mw.ViewPageTarget.init: Simplify hideLoading and pushState [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174345 (owner: 10Krinkle) [03:04:40] (03PS3) 10Jforrester: build: Create a 'typos' task and fix a remaining @returns to be @return [oojs/ui] - 10https://gerrit.wikimedia.org/r/174147 [03:05:10] (03CR) 10Jforrester: build: Create a 'typos' task and fix a remaining @returns to be @return (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/174147 (owner: 10Jforrester) [03:06:49] (03PS7) 10Catrope: Add instrumentation for edit schema [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/171499 [03:06:51] (03PS1) 10Catrope: Prevent JS errors when surfaceReady fires after deactivation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174357 [03:06:53] (03PS1) 10Catrope: Move tearDownBeforeUnloadHandler() to cancel() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174358 [03:06:59] (03CR) 10jenkins-bot: [V: 04-1] Add instrumentation for edit schema [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/171499 (owner: 10Catrope) [03:07:05] (03CR) 10jenkins-bot: [V: 04-1] Prevent JS errors when surfaceReady fires after deactivation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174357 (owner: 10Catrope) [03:07:12] (03CR) 10jenkins-bot: [V: 04-1] Move tearDownBeforeUnloadHandler() to cancel() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174358 (owner: 10Catrope) [03:07:14] (03CR) 10Catrope: [C: 032] mw.ViewPageTarget.init: Simplify hideLoading and pushState [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174345 (owner: 10Krinkle) [03:07:31] (03PS2) 10Jforrester: Fix typos [oojs/ui] - 10https://gerrit.wikimedia.org/r/174323 (owner: 10Bartosz Dziewoński) [03:08:51] (03CR) 10Jforrester: [C: 032] Fix typos [oojs/ui] - 10https://gerrit.wikimedia.org/r/174323 (owner: 10Bartosz Dziewoński) [03:08:55] (03CR) 10Krinkle: "Maybe make it case-insensitive? Should be easier now that it's a regex." [oojs/ui] - 10https://gerrit.wikimedia.org/r/174147 (owner: 10Jforrester) [03:08:58] (03Merged) 10jenkins-bot: mw.ViewPageTarget.init: Simplify hideLoading and pushState [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174345 (owner: 10Krinkle) [03:09:53] (03CR) 10Jforrester: "I left it as sensitive so we could detect e.g. OOjs vs OoJs, but maybe we don't care as much about those?" [oojs/ui] - 10https://gerrit.wikimedia.org/r/174147 (owner: 10Jforrester) [03:14:20] (03PS2) 10Jforrester: Prevent JS errors when surfaceReady fires after deactivation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174357 (owner: 10Catrope) [03:15:02] (03PS2) 10Jforrester: Move tearDownBeforeUnloadHandler() to cancel() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174358 (owner: 10Catrope) [03:26:36] 3OOjs UI: OOjs UI: Tab character in option boxes should pick the current selection (like Enter does) - 10https://bugzilla.wikimedia.org/51229 (10James Forrester) s:5trivia>3enhanc [03:27:08] Oh git, how I love thine obscure ways: [03:27:11] git rebase --onto HEAD@{1} HEAD~1 [03:27:16] (03CR) 10Krinkle: build: Create a 'typos' task and fix a remaining @returns to be @return (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/174147 (owner: 10Jforrester) [03:28:57] (03CR) 10Jforrester: build: Create a 'typos' task and fix a remaining @returns to be @return (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/174147 (owner: 10Jforrester) [03:28:59] (03PS4) 10Jforrester: build: Create a 'typos' task and fix a remaining @returns to be @return [oojs/ui] - 10https://gerrit.wikimedia.org/r/174147 [03:29:19] James_F: mwext-VisualEditor-qunit is on labs as of now. [03:29:39] Krinkle: Nice. Pity it isn't mwext-VisualEditor-karma-Chrome. ;-) [03:30:00] it'll never be karma for mw-hosted test suites. [03:30:38] I wanted it to be, but doubt it's going to be possible. [03:30:40] Krinkle: Not possible? [03:30:42] Boo. [03:30:47] So no test coverage etc. [03:31:03] that's done by instanbul, not karma [03:31:07] which grunt-qunit uses as well [03:31:11] (03PS8) 10Catrope: Add instrumentation for edit schema [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/171499 [03:31:13] we've had coverage before as well [03:31:27] Fair. [03:32:20] James_F: The problem is that Karma uses its own page and then fetches the js. We can't make it serve a Special page. So it won't have startup module, mw.loader.load(test modules) call, and mw.config settings. [03:32:39] Krinkle: No way to over-ride that? [03:32:52] It using its own page is not an implementation detail, it's a design. [03:33:02] Which is actually very good. [03:33:11] No way to insert stuff into it? [03:33:13] It makes they're communication layer is excelent and free of race conditons. [03:33:23] means their* [03:33:34] They setup a socket.io.js script and then load it once its setup. [03:33:52] * James_F nods. [03:33:54] Whereas grunt-lib-phantomjs has to inject itself into a foreign html page, thus potentially being too late. [03:34:15] (03CR) 10Jforrester: [C: 031] Prevent JS errors when surfaceReady fires after deactivation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174357 (owner: 10Catrope) [03:34:23] (03CR) 10Jforrester: [C: 031] Move tearDownBeforeUnloadHandler() to cancel() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174358 (owner: 10Catrope) [03:34:40] Tomorrow I'll evaluate the options 1) Provide a pure-js mode for our special page, like special:javascipttest/qunit.js that would concat startup module, mwconfig, mw.loaderload calls and build a minimal html tree. [03:34:58] in 1) we'd use Karma as long as we export that with curl into a local file and load that first. [03:35:15] or 2) See about getting grunt-contrib-qunit/grunt-lib-chrome made. [03:35:35] * James_F nods. [03:35:54] (03CR) 10jenkins-bot: [V: 04-1] Add instrumentation for edit schema [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/171499 (owner: 10Catrope) [03:35:58] Anyway. Great work. :-) [03:36:05] or 3) Try and hack karma upstream and provide a way to proxy the main html request through a separate server (meidiawiki) and have it insert its own stuff into the static html before excucuting. [03:36:21] Oh no, not "Unfinished animations" again?! [03:36:42] Krinkle: ^^^ mwext-VisualEditor-qunit playing up or something else? [03:38:08] (03PS1) 10Jforrester: Update VE core submodule to master (cdd2691) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174362 [03:40:46] Note, the first build for these on each slave is slower as its having to fetch the git repos for the first time [03:40:57] that shouldt' cause slow down during the actual test though [03:41:15] (hence it took 4m instead of 1m on - https://gerrit.wikimedia.org/r/171499 ) [03:42:46] Hmm. [03:42:49] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (cdd2691) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174362 (owner: 10Jforrester) [03:43:05] (03CR) 10Jforrester: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/171499 (owner: 10Catrope) [03:43:31] James_F: Yeah, I think that's just an unlucky race condition. SNAFU. Hasn't hit VE in a long time though. [03:43:52] Krinkle: Yeah, hence my "oh no, not again". :-) [03:44:37] (03Merged) 10jenkins-bot: Update VE core submodule to master (cdd2691) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174362 (owner: 10Jforrester) [03:45:28] Yay, only took 1m :) [03:45:37] Woo. [03:48:04] (03CR) 10Jforrester: [C: 032] Implement new "maps" property in Root [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167389 (owner: 10Mvolz) [03:48:44] (03Merged) 10jenkins-bot: Implement new "maps" property in Root [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167389 (owner: 10Mvolz) [03:48:56] Krinkle: Time to do a new announcement e-mail about https://gerrit.wikimedia.org/r/#/c/137168/ ? [03:49:25] After I've glued myself back together overnight. [03:49:27] o/ [03:50:29] Krinkle|detached: Sure. See you. [03:52:05] 3VisualEditor / 3MediaWiki integration: VisualEditor: WT create tab on Special:Undelete when looking at a page is changed to "Edit source" rather than "create source", but VE tab is correct - 10https://bugzilla.wikimedia.org/66885#c3 (10James Forrester) Dependency now merged. Let's get this done? [03:54:10] (03CR) 10Jforrester: [C: 032] "Fine." [oojs/ui] - 10https://gerrit.wikimedia.org/r/174306 (owner: 10Krinkle) [03:57:06] (03Merged) 10jenkins-bot: build: Clean up fileExists config [oojs/ui] - 10https://gerrit.wikimedia.org/r/174306 (owner: 10Krinkle) [04:19:12] (03CR) 10Jforrester: [C: 032] "Last cut is in the past. Good to go." [oojs/ui] - 10https://gerrit.wikimedia.org/r/173356 (owner: 10Trevor Parscal) [08:34:01] (03CR) 10Hashar: "Upstream fixed Style/MultilineOperationIndentation being set enabled instead of disabled: https://github.com/bbatsov/rubocop/issues/1449 " [oojs/ui] - 10https://gerrit.wikimedia.org/r/172716 (https://bugzilla.wikimedia.org/72841) (owner: 10Zfilipin) [09:01:16] (03Abandoned) 10Zfilipin: Fixed RuboCop Style/WordArray offense [oojs/ui] - 10https://gerrit.wikimedia.org/r/172742 (https://bugzilla.wikimedia.org/72841) (owner: 10Zfilipin) [11:04:11] (03CR) 10Alex Monk: [C: 032] ViewPageTarget#onSaveErrorSpamBlacklist: Use mw.language.listToText now it exists [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174301 (owner: 10Jforrester) [11:06:02] (03Merged) 10jenkins-bot: ViewPageTarget#onSaveErrorSpamBlacklist: Use mw.language.listToText now it exists [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174301 (owner: 10Jforrester) [11:10:07] 3OOjs UI: OOjs UI: OO.ui.ButtonWidget default target should not be "_blank" - 10https://bugzilla.wikimedia.org/73452#c3 (10Richhiey) Yes sure. Thanks :) [11:12:10] (03CR) 10Alex Monk: [C: 032] ve.ce.MWTransclusionNode: Replace last use of ', ' in VE-MW with [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174302 (https://bugzilla.wikimedia.org/66894) (owner: 10Jforrester) [11:13:51] (03CR) 10jenkins-bot: [V: 04-1] ve.ce.MWTransclusionNode: Replace last use of ', ' in VE-MW with [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174302 (https://bugzilla.wikimedia.org/66894) (owner: 10Jforrester) [11:19:52] (03PS2) 10Alex Monk: ve.ce.MWTransclusionNode: Replace last use of ', ' in VE-MW with [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174302 (https://bugzilla.wikimedia.org/66894) (owner: 10Jforrester) [11:20:09] (03CR) 10Alex Monk: [C: 031] ve.ce.MWTransclusionNode: Replace last use of ', ' in VE-MW with [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174302 (https://bugzilla.wikimedia.org/66894) (owner: 10Jforrester) [11:20:15] (03CR) 10Alex Monk: [C: 032] ve.ce.MWTransclusionNode: Replace last use of ', ' in VE-MW with [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174302 (https://bugzilla.wikimedia.org/66894) (owner: 10Jforrester) [11:21:57] (03Merged) 10jenkins-bot: ve.ce.MWTransclusionNode: Replace last use of ', ' in VE-MW with [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174302 (https://bugzilla.wikimedia.org/66894) (owner: 10Jforrester) [12:52:20] 3MediaWiki / 3ResourceLoader: PHP Notice: Uninitialized string offset: includes/libs/JavaScriptMinifier.php on line 571 - 10https://bugzilla.wikimedia.org/73556 (10Andre Klapper) p:5Unprio>3Normal [14:55:51] (03PS1) 10Lokal Profil: Fix consistency in messages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174415 [15:38:51] (03CR) 10Nemo bis: [C: 031] "Thanks!" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174415 (owner: 10Lokal Profil) [15:39:38] 3VisualEditor / 3Editing Tools: Tab in tables - 10https://bugzilla.wikimedia.org/73612 (10Nik Everett) 3NEW p:3Unprio s:3normal a:3None In Excel tab moves you to the next cell. In Visual Editor tab moves you to the language select link. I know its never a good idea to override browser default behav... [15:44:38] 3VisualEditor / 3Editing Tools: Tab in tables - 10https://bugzilla.wikimedia.org/73612#c1 (10Elitre) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 72823 *** [15:44:39] 3VisualEditor / 3ContentEditable: VisualEditor: Pressing tab inside a cell when the cursor is active should taking it to the next cell, not to beginning of the document - 10https://bugzilla.wikimedia.org/72823#c3 (10Elitre) *** Bug 73612 has been marked as a duplicate of this bug. *** [15:46:23] (03PS2) 10Jforrester: API i18n: Fix consistency in messages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174415 (owner: 10Lokal Profil) [15:46:31] (03CR) 10Jforrester: [C: 032] "Thank you!" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174415 (owner: 10Lokal Profil) [15:48:28] (03CR) 10jenkins-bot: [V: 04-1] API i18n: Fix consistency in messages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174415 (owner: 10Lokal Profil) [15:49:52] Heya. [17:06:19] (03CR) 10Jforrester: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174415 (owner: 10Lokal Profil) [17:08:57] (03CR) 10Jforrester: [C: 032] "Try again…" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174415 (owner: 10Lokal Profil) [17:10:09] 3VisualEditor / 3ContentEditable: VisualEditor: Pressing tab inside a cell when the cursor is active should taking it to the next cell, not to beginning of the document - 10https://bugzilla.wikimedia.org/72823 (10James Forrester) p:5Normal>3High a:3Ed Sanders [17:10:38] (03Merged) 10jenkins-bot: API i18n: Fix consistency in messages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174415 (owner: 10Lokal Profil) [17:30:38] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=109235172 [17:30:38] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=109259866 [17:30:38] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=33353065 [17:30:38] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=33361573 [17:30:38] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=66877495 [17:30:38] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=66877790 [17:30:38] Corruption alert: visualeditor-needcheck on cawiki: https://ca.wikipedia.org/?diff=14318527 [17:30:39] Corruption alert: visualeditor-needcheck on ptwiki: https://pt.wikipedia.org/?diff=40649698 [17:30:39] Corruption alert: visualeditor-needcheck on elwiki: https://el.wikipedia.org/?diff=4934292 [17:30:40] Corruption alert: visualeditor-needcheck on elwiki: https://el.wikipedia.org/?diff=4934301 [17:30:40] Corruption alert: visualeditor-needcheck on elwiki: https://el.wikipedia.org/?diff=4934328 [17:30:41] Corruption alert: visualeditor-needcheck on enwiki: https://en.wikipedia.org/?diff=634552462 [17:36:27] edsanders:sorry to bother - Bug 73336 - VisualEditor: Link inspector opens in a upper left corner in Safari - do not see the fix... [17:37:38] RoanKattouw_away, more rowspan stuff in the second frwiki entry... rowspan="" being removed [17:37:44] (03PS1) 10Cmcmahon: [BrowserTest] WIP sort the VE page object [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174446 [17:38:26] etonkovidova, which server? [17:38:35] betalabs [17:39:24] 3MediaWiki / 3ResourceLoader: ResourceLoader: Implement support for LESS in wiki modules (user and site), supporting e.g. MediaWiki:Common.less - 10https://bugzilla.wikimedia.org/54864#c5 (10paladox2015) Why not add https://github.com/leafo/lessphp/blob/011afcca8e6f1000a6e789921ba805fa578271a3/lessify.inc.ph... [17:39:57] (03PS2) 10Cmcmahon: [BrowserTest] sort the VE page object [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174446 [17:43:51] 3VisualEditor / 3MediaWiki integration: VisualEditor: mw.Target / ViewPageTarget re-write (tracking) - 10https://bugzilla.wikimedia.org/73593 (10Andre Klapper) [17:43:51] 3OOjs UI: OOUI: Get OOUI PHP to be good to go (tracking) - 10https://bugzilla.wikimedia.org/72713 (10Andre Klapper) [17:47:50] (03CR) 10Cmcmahon: [C: 032] "refactoring, no change to function" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174446 (owner: 10Cmcmahon) [17:49:28] (03CR) 10jenkins-bot: [V: 04-1] [BrowserTest] sort the VE page object [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174446 (owner: 10Cmcmahon) [18:28:32] RoanKattouw_away, are you looking for rowspan changes? I've got on at en.wp: https://en.wikipedia.org/w/index.php?title=Kajal_Aggarwal&curid=14850733&diff=634552462&oldid=634551254 [18:30:57] Krenair: Urgh, right, I think I know why rowspan="" would be removed [18:31:00] whatami: Thanks! Looks like it's the same as what Krenair reported [18:31:18] You're welcome. [18:33:05] 3VisualEditor / 3Technical Debt: VisualEditor: Disentangle MWSaveDialog and mw.ViewPageTarget - 10https://bugzilla.wikimedia.org/65513 (10Krinkle) [18:34:20] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf7] Cite command not working (but cite-tranclusion does) - 10https://bugzilla.wikimedia.org/73001 (10James Forrester) [18:35:16] (03PS5) 10Jforrester: [WIP] Editable blockquotes in MW [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134838 (https://bugzilla.wikimedia.org/51009) (owner: 10Esanders) [18:35:28] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Editable blockquotes in MW [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134838 (https://bugzilla.wikimedia.org/51009) (owner: 10Esanders) [18:36:51] 3VisualEditor / 3Data Model: VisualEditor: Clicking in a table that contains templated rows causes JS error - 10https://bugzilla.wikimedia.org/72717 (10etonkovidova) 5RESO/?>3VERI [18:43:51] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf7] Cannot add any Citations or Basic reference in a page , throwing Typeerror " Cannot read property 'replace' of undefined " - 10https://bugzilla.wikimedia.org/72948 (10etonkovidova) 5RESO/?>3VERI [18:46:43] edsanders: any news on bug73336? - it has 1.25wmf9 deploy target [18:48:51] 3VisualEditor / 3ContentEditable: VisualEditor: Please let me drop the cursor into the table caption if it exists. Please? - 10https://bugzilla.wikimedia.org/72724#c3 (10etonkovidova) 5RESO/?>3VERI Verified in production. [18:49:32] RoanKattouw, want to start now if the room is free? [18:50:09] edsanders: He's in the SoS meeting. [18:53:04] etonkovidova, Safari 8? [18:53:22] 3VisualEditor / 3Data Model: VisualEditor: [Regression] “Uncaught Error: offset -1 out of bounds” when adding bullet/numbered list with link inspector open - 10https://bugzilla.wikimedia.org/72558#c4 (10etonkovidova) 5RESO/?>3VERI Verified in production. [18:53:23] edsanders: safari 7 [18:54:10] http://en.wikipedia.beta.wmflabs.org/wiki/Main_Page?veaction=edit on Safari 7 works for me [18:54:19] browser cache> [18:54:21] ? [18:54:52] edsanders: I did clear the browser cache - ok will try again [18:55:52] edsanders: btw, how did you clear the cache? I use Develop->Empty caches and just cmd+R [18:56:09] edsanders: maybe you got a better method? :) [18:56:19] I don't actually have Safari locally so I didn't [18:56:32] I'm using crossbrowsertesting.com [18:56:38] which connects me to a virtual machine [18:57:10] edsanders: I see. Will try again - thx [19:19:28] TrevorP|Away, this isn't really urgent, but I just remembered an idea/concern/need I had when working on ooui-fying TemplateData. In the language panel, I have a TextInputWidget for language name and a ButtonWidget for adding the langauge. I couldn't make them be one next to the other, because FieldsetLayout only takes one widget and attaches it a label. I ran into this in another place, too, iirc, in the media dialog, when there wa [19:19:28] s an idea to put a checkbox enabling a textbox. [19:19:53] TrevorP|Away, is this something you think we should add? a sort of grid for two (or more?) widgets [19:27:08] 3VisualEditor / 3Editing Tools: VisualEditor: TitleInputWidget should validate inputs - 10https://bugzilla.wikimedia.org/71249 (10etonkovidova) 5RESO/?>3VERI [19:29:33] edsanders: Can you make me a member of https://github.com/edg2s/rangefix so I can mark the releases? [19:36:11] James_F: upstream grunt-file-exists is response to patches [19:36:15] https://github.com/alexeiskachykhin/grunt-file-exists [19:36:22] Just had my patch merged within a few hours [19:36:29] Not a bug fix though [19:36:34] That was before you told me its broken [19:39:51] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression] Don't let the user insert the same category multiple times - 10https://bugzilla.wikimedia.org/72906#c6 (10etonkovidova) 5RESO/?>3VERI Verified in production. [19:42:07] (03CR) 10Mooeypoo: "Everything fixed for next patchset -- however, take a look at the UX concern I've raised regarding autosize:true in the multiline inputs. " (034 comments) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 (owner: 10Mooeypoo) [19:43:10] (03PS14) 10Mooeypoo: Eventify TemplateDataGenerator and use oojs-ui [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 [19:43:13] (03CR) 10jenkins-bot: [V: 04-1] Eventify TemplateDataGenerator and use oojs-ui [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 (owner: 10Mooeypoo) [19:45:57] (03PS15) 10Mooeypoo: Eventify TemplateDataGenerator and use oojs-ui [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 [19:48:39] Krinkle: Response to what patches? [19:48:52] is responsive, I meant [19:48:58] i.e. we can fix it. [19:49:15] and have it released quickly [19:49:31] That isn't obvious since it isn't a gruntjs/ project, but a third party [19:49:40] Krinkle: Oh, cool. [19:49:55] Krinkle: Yeah. So, should we work with them on it? [19:50:17] James_F: Yeah. Would be cool if you could file a bug to start with. [19:50:24] Hemight even fix it for us :) [19:50:25] * James_F nods. [19:50:40] I'll have to spend some time building a minimal test case if it's going external, though. [19:50:49] As opposed to "this is broken, dev please fix". :-) [19:51:05] mooeypoo: mixins [19:51:11] (03PS6) 10Mooeypoo: [wip] Adding paramOrder widget to TemplateData editor [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/170655 [19:51:25] 3VisualEditor / 3ContentEditable: VisualEditor: I can't select multiple refs when going backwards from the keyboard in Firefox - 10https://bugzilla.wikimedia.org/72835#c5 (10etonkovidova) 5RESO/?>3VERI Verified the fix in production(in FF) - backward selection(highlighting) works smoothly and no js erro... [19:51:40] Krinkle, yep, so I created DraggableGroupElement that extends GroupElement [19:51:55] but then when I use it as a mixin to a widget, I have to *also* mixin the GroupElement [19:52:14] mooeypoo: Read https://bugzilla.wikimedia.org/show_bug.cgi?id=55557 first [19:52:16] In case its the same [19:52:26] we have that in other places in the code [19:52:28] oh, reading, hang on [19:52:50] Ha. [19:53:41] Krinkle, it is indeed the same. Okay, but in this case I do want to add *both* methods from both mixins... so I should have DraggableGroupElement *mixin* the GroupElement rather than inherit it... if I understand correctly. Right? [19:54:02] mooeypoo: if said parent (groupelement) is a mixin, mix it in instead of inheriting. if it isn't a mixin, remove it and embrace your workaround (inheriting in the child) as the "right" way and not a workarund. [19:54:39] Both are a mixin, yeah. I'll mix it in, then. [19:54:59] since mixin is not live, but substituted, it'll work as expected [19:55:06] I see. [19:55:09] without needing to do it again in the child [19:55:41] It's confusing, but I think I see what you mean. [19:55:54] Well, I see what I need to do, but the confusing part is why this is by design. [19:56:44] mooeypoo: Basically, you use building blocks to make bigger building blocks [19:57:09] so your intend (have one mixin, DraggableGroupElement, that does it all at once) will still work. [19:57:11] The multiple inheritance makes sense that it shouldn't happen, but in this case, isn't it mostly semantics? If I mixin the GroupElement into my DraggableGroupElement, I essentially grouped both behaviors, so I can then use the "bigger" mixin (the DraggableGroupElement) as a mixin in other widgets -- isn't that conceptually the same as having DraggableGroupElement *inherit* from GroupElement ? [19:57:37] just by using a mixin internally instead of inheritance. Afterall, GroupElement isn't a usable class, you don't want to inherit from it. Other classes use it as mixin as well, not inherited, right? [19:58:09] mooeypoo: No, because inheritance in this context means live inheritance. [19:58:33] I think I need to understand more about live inheritance vs.. uh.. what's the contrast to that? I assume not dead inheritance [19:58:38] As opposed to re-using over a bag of methods to build a larger class. [19:58:54] I'll show you in a brief console log [19:58:56] >> 1 [19:58:56] Krinkle: (number) 1 [19:59:00] Okay, ecmabot-wm is not dead :) [19:59:12] That would've been dead inheritance? :p [20:00:55] Hey, so I'm trying to get table editting with 1.24. How reasonable is it to run the last commit before the version requirement bump? (It seems to be working ok so far…) [20:01:06] >> var a = { foo: 1, bar: 1 }; var live = Object.create(a); live.bar = 'x'; a.foo = 2; a.bar = 2; a.quux = 2; console.log(a, live); [20:01:06] Krinkle: undefined; Console: {bar: 2, foo: 2, quux: 2}, {bar: 'x'} [20:01:20] 3VisualEditor / 3Technical Debt: VisualEditor: Use comma-separator interface message - 10https://bugzilla.wikimedia.org/66894 (10James Forrester) 5PATC>3RESO/FIX [20:01:26] bad output, that's not useful [20:01:27] hold on [20:02:11] i think I see where you're going with this, though [20:02:42] mooeypoo: point is, live inheritance means the original can have its properties changed, added or removed and will reflect down the chain. [20:02:44] wait... what? [20:03:11] so when you inherit, nothing is copied. It just means whenever you acccess a property, and no such property is found, it'll check the parent. [20:03:12] var a = { foo: 1, bar: 1 }; var live = Object.create(a); <-- what?? how is live not having foo and bar ? [20:03:39] mooeypoo: It does. It's just that ecmabot-wm only shows own properites here for brevity [20:03:45] oh [20:03:50] worried there for a moment. [20:04:00] >> var a ={}; [ a.constructor, a.valueOf, a.hasOwnProperty, a.toString ] [20:04:00] Krinkle: (object) [(function) Object, (function) valueOf, (function) hasOwnProperty, (function) toString] [20:04:07] remember those are all just inherited as well [20:04:16] because {} -> Object.create(Object.prototype) [20:04:33] But I see what you mean. This is weird, though, conceptually, after getting used to languages that don't do that. [20:04:44] Krinkle: circleci is free now, you can build 1 private and 3 public repos simultaneously [20:04:58] James_F, done [20:05:04] edsanders: Thanks! [20:05:08] hm [20:05:08] mooeypoo: other languages do it too, conceptually, but they tend to optimise by substituting at run time, since they can't change anyway. E.g. a class is immutable in pretty much every language. [20:05:31] so there's no point in keeping only a link and falling back during run time, might as well copy over right away. [20:05:35] they emailed me and asked why we switched away, and I told them it was too pricey and we switched to someone who gave us basically that exact feature set for free - I'm guessing that other people told them the same [20:05:37] 3VisualEditor / 3Editing Tools: VisualEditor: “Uncaught Error: Unable to parse title” when entering "Talk:" as a template - 10https://bugzilla.wikimedia.org/71998#c9 (10etonkovidova) 5RESO/?>3VERI Verified the fix in production along with the bug fix for 71249. [20:05:40] Hmm' [20:05:52] whereas in javascript, there is no such thing as a class. There are only objects with values, some of which can be functions. And objects can change at any time. [20:06:48] so a mixin is just like array_merge in php or $.extend in jquery. It copies them when you declare "mixin". So you now have a flat object. [20:06:48] edsanders: OK with https://github.com/edg2s/rangefix/releases x2? [20:07:02] Right... right. Ha. Interesting. [20:07:11] OK. I'll leave it at that for now :) Feel free to ask more though :) [20:07:22] Krinkle, yeah no that was awesome. Thanks! [20:09:51] 3VisualEditor / 3MediaWiki integration: VisualEditor: Invocation of "lastmodifiedat" message is not updated when page is saved - 10https://bugzilla.wikimedia.org/52403#c8 (10etonkovidova) 5RESO/?>3VERI Verified in production. [20:11:39] (03PS1) 10Esanders: WIP Find and replace [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/174491 [20:11:47] ^^ fun times [20:12:16] James_F, sure, w/e [20:13:21] (03PS10) 10Mooeypoo: Adding DraggableGroupElement and DraggableElement mixins [oojs/ui] - 10https://gerrit.wikimedia.org/r/172325 [20:13:46] Krinkle, ^^ mixin instead of inherit -- works great (not that you'd be surprised... ;) [20:14:58] (03CR) 10jenkins-bot: [V: 04-1] WIP Find and replace [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/174491 (owner: 10Esanders) [20:22:13] edsanders: Thanks. [20:32:21] (03CR) 10Cmcmahon: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174446 (owner: 10Cmcmahon) [20:36:36] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf6] A Label appears momentarily, showing all "Use this Group" options, when Re-Using a Reference - 10https://bugzilla.wikimedia.org/72904#c10 (10etonkovidova) 5RESO/FIX>3REOP Re-tested it - the bug still exists in test2 and production. The best... [20:38:35] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf6] A Label appears momentarily, showing all "Use this Group" options, when Re-Using a Reference - 10https://bugzilla.wikimedia.org/72904#c11 (10Rummana Yasmeen) Elena, so it does not appear in Betalabs? [20:39:03] good question - hold on a sec [20:39:52] D: [20:40:55] bug 72904 is in beta and better to view it in Chrome - will add a comment [20:41:06] (03CR) 10Cmcmahon: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174446 (owner: 10Cmcmahon) [20:42:51] (03CR) 10jenkins-bot: [V: 04-1] [BrowserTest] sort the VE page object [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174446 (owner: 10Cmcmahon) [20:42:53] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf9] "Uncaught TypeError: Cannot read property 'previousSibling' of undefined" appears when trying to open page settings dialog while the cursor is on a slug in the middle of two References lists - 10https://bugzilla.wikimedia.org/73620 (10Rummana Yas... [20:43:06] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf6] A Label appears momentarily, showing all "Use this Group" options, when Re-Using a Reference - 10https://bugzilla.wikimedia.org/72904#c12 (10etonkovidova) It turned out that Chrome displays the issue even better than FF. So, better see it there. [20:49:29] mooeypoo, yay it works [20:49:40] a simple reorder event handler does the trick [20:49:55] (03CR) 10Cmcmahon: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174446 (owner: 10Cmcmahon) [20:51:19] mooeypoo, the placeholder thing is the wrong way now though [20:51:41] (03CR) 10jenkins-bot: [V: 04-1] [BrowserTest] sort the VE page object [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174446 (owner: 10Cmcmahon) [20:53:00] (03PS6) 10Alex Monk: Make category widget items draggable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173360 (https://bugzilla.wikimedia.org/50809) [20:53:11] (03CR) 10Alex Monk: Make category widget items draggable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173360 (https://bugzilla.wikimedia.org/50809) (owner: 10Alex Monk) [20:53:35] Krenair, wrong way? [20:53:52] Krenair, use { orientation: 'horizontal' } in the config [20:54:11] (03CR) 10jenkins-bot: [V: 04-1] Make category widget items draggable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173360 (https://bugzilla.wikimedia.org/50809) (owner: 10Alex Monk) [20:54:43] I chose 'vertical' as the default since optionwidget is usually vertical.. maybe I should switch it the other way around? Anyways, 'horizontal' as orientation *should* fix that [20:55:38] that works [20:56:40] hm, actually I think the category stuff is still buggy [20:56:54] how so? [20:57:24] the first move works [20:57:42] then the second time, it duplicates... [20:57:56] also, you don't have to use the GroupElement mixin anymore [20:58:02] ... really? [20:58:04] :\ hmm [20:58:45] DraggableGroupElement now *should* follow the data model, so maybe it's an issue there? Either that, or the references to the items are wonky? [21:02:53] FSG meeting: http://etherpad.wikimedia.org/p/FrontEndStandardsGroup [21:02:55] MatmaRex: you 'round? [21:05:14] 3VisualEditor / 3ContentEditable: VisualEditor: shortcut(Ctrl+1) for Page Title does not work on Mac - 10https://bugzilla.wikimedia.org/73340#c3 (10Rummana Yasmeen) 5VERI>3RESO/? So, it was actually set as one of your shortcuts as we have seen yesterday.Changing Status back to Resolved Invalid. [21:05:14] 3MediaWiki / 3ResourceLoader: CSSJanus fails to flip with !important - 10https://bugzilla.wikimedia.org/61440#c10 (10Matthew Flaschen) (In reply to Matthew Flaschen from comment #9) > node.js change to set up the release: > https://github.com/cssjanus/cssjanus/pull/30 Krinkle tweaked and merged this. > Upd... [21:05:16] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf6] A Label appears momentarily, showing all "Use this Group" options, when Re-Using a Reference - 10https://bugzilla.wikimedia.org/72904#c13 (10etonkovidova) The bug exists in beta, test, and production. I've attached the screenrecording - it shows... [21:06:19] mooey|food, it's to do with stupid title normalisation [21:07:05] the one I was having issues with has some weird characters... [21:08:32] TrevorParscal: oh huh, it's wednesday today [21:08:37] bah [21:08:45] (03PS1) 10Cmcmahon: [BrowserTest] sort the VE page object [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174504 [21:09:16] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174504 (owner: 10Cmcmahon) [21:09:28] (03Abandoned) 10Cmcmahon: [BrowserTest] sort the VE page object [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174446 (owner: 10Cmcmahon) [21:09:49] mooey|food, ok so my event handler is also broken [21:10:29] doc... isn't inheriting from anywhere, I should fix that. [21:10:32] (03CR) 10jenkins-bot: [V: 04-1] [BrowserTest] sort the VE page object [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174504 (owner: 10Cmcmahon) [21:11:07] doesn't handle the index, which causes some issues but I'm not sure how to handle it since the addItems call only happens in response to the model event [21:16:13] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf6] A Label appears momentarily, showing all "Use this Group" options, when Re-Using a Reference - 10https://bugzilla.wikimedia.org/72904#c14 (10etonkovidova) Created attachment 17173 --> https://bugzilla.wikimedia.org/attachment.cgi?id=17173&acti... [21:19:39] (03CR) 10Cmcmahon: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174504 (owner: 10Cmcmahon) [21:20:03] This is maybe the fourth time I've tried to merge that patch [21:23:49] chrismcmahon: Yeah, Krinkle|detached was looking at it. [21:24:42] James_F: is there any way to force a merge? [21:25:07] chrismcmahon: No; shouting at Krinkle|detached is best IME. [21:27:22] 3VisualEditor / 3ContentEditable: VisualEditor: Link inspector opens in a upper left corner in Safari - 10https://bugzilla.wikimedia.org/73336#c4 (10etonkovidova) Created attachment 17174 --> https://bugzilla.wikimedia.org/attachment.cgi?id=17174&action=edit Safari link inspector [21:29:15] (03PS1) 10Cmcmahon: [BrowserTest] sort the VE page object [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174514 [21:29:57] RoanKattouw, please see my last message [21:30:05] (03CR) 10Cmcmahon: [C: 032] "please merge please merge please merge" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174514 (owner: 10Cmcmahon) [21:30:10] Krenair: [13:11] Krenair doesn't handle the index, which causes some issues but I'm not sure how to handle it since the addItems call only happens in response to the model event ? [21:30:14] I don't understand that message [21:30:20] Krenair, what do you mean doesn't handle the index? [21:30:23] (03Abandoned) 10Cmcmahon: [BrowserTest] sort the VE page object [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174504 (owner: 10Cmcmahon) [21:30:28] the event emits the new index of the item [21:30:35] yes [21:30:52] It's even supposed to be fixed to before/after [21:31:30] Krenair, so, if after you rearranged things in the modle you don't have the new index anymore, you can theoretically just go addItems( [allItemsInNewOrder] ) [21:31:35] is that the issue? [21:31:38] In that event handler I then this.emit( 'newCategory', item );, which will cause the meta item to be inserted [21:31:44] (03CR) 10jenkins-bot: [V: 04-1] [BrowserTest] sort the VE page object [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174514 (owner: 10Cmcmahon) [21:31:47] but it will not have the index [21:31:53] Krenair: Oh, but you're not able to tell it where to go [21:31:54] That sucks [21:31:57] hm [21:32:03] The fact that you're emitting an event to cause something else to move it also sucks [21:32:15] wait, can you not add it to the end? [21:32:16] (Not your fault; I blame Trevor) [21:32:31] mooey|food: What if index !== numItems-1? Then it *shouldn't* go at the end [21:32:49] well if there's no index provided, it's added at the end [21:32:54] addItems() does that anyways [21:33:09] code that touches addItems will never get the index [21:33:09] it also checks the range of the index, iirc [21:33:17] it's only called in response to the meta item being inserted [21:33:36] Yeah [21:33:42] the meta item is inserted when an event is fired by code that knows the index [21:33:47] So the problem is, your communication channel with the model does not allow you to specify an index [21:33:58] Also your communication channel with the model is an event, which is not ideal [21:34:01] you mean after rearranging? [21:34:09] Also, ahm, hold on [21:34:13] * mooey|food is a little confused [21:34:15] this is all taking place after onReorder [21:34:21] How would rearranging a category even be done in DM? [21:34:44] The categories are not in a single list at the end of the page, necessarily, they can be all over the page [21:35:16] So I guess you could implement it as "move category in index N" means "put it right before the category at index N+1" [21:40:55] (03CR) 10Cmcmahon: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174514 (owner: 10Cmcmahon) [21:41:16] What I don't quite understand is this -- even if you don't have an index, if you go addItem( [ itemAlreadyExistsSomewhereInTheItemsList ] ) the GroupElement will rearrange it [21:41:29] the only case where it will be added is if the item is *not* the same, or the reference to the item is not the same [21:41:39] No? [21:42:07] Without an index, the item will go to the end, and with an index, it will be inserted wherever the index indicates. [21:43:55] (03PS1) 10Cmcmahon: [BrowserTest] sort the VE page object [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174573 [21:44:08] (03CR) 10Cmcmahon: [C: 032] [BrowserTest] sort the VE page object [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174573 (owner: 10Cmcmahon) [21:44:27] (03Abandoned) 10Cmcmahon: [BrowserTest] sort the VE page object [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174514 (owner: 10Cmcmahon) [21:45:38] (03CR) 10jenkins-bot: [V: 04-1] [BrowserTest] sort the VE page object [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174573 (owner: 10Cmcmahon) [21:48:06] 3VisualEditor / 3ContentEditable: VisualEditor:[Regression pre-wmf9] Inserted Media caption is not displayed correctly - 10https://bugzilla.wikimedia.org/73441#c1 (10James Forrester) 5NEW>3RESO/INV This is how Beta Labs is configured, irritatingly. [21:49:35] (03PS2) 10Cmcmahon: [BrowserTest] sort the VE page object [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174573 [21:49:43] (03CR) 10Cmcmahon: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174573 (owner: 10Cmcmahon) [21:50:24] 3VisualEditor / 3Editing Tools: VisualEditor: Matching pages list in link dialog should support right-click / ctrl+click to open page in a new window/tab - 10https://bugzilla.wikimedia.org/51205#c8 (10etonkovidova) 5RESO/?>3VERI Verified the fix in test2 and production. [21:50:45] 3VisualEditor / 3ContentEditable: VisualEditor:[Regression pre-wmf9] Inserted Media caption is not displayed correctly - 10https://bugzilla.wikimedia.org/73441 (10James Forrester) [21:51:13] (03CR) 10jenkins-bot: [V: 04-1] [BrowserTest] sort the VE page object [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174573 (owner: 10Cmcmahon) [21:53:37] (03PS1) 10Cmcmahon: [BrowserTest] once more [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174575 [21:53:58] (03Abandoned) 10Cmcmahon: [BrowserTest] sort the VE page object [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174573 (owner: 10Cmcmahon) [21:54:14] (03CR) 10Cmcmahon: [C: 032] [BrowserTest] once more [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174575 (owner: 10Cmcmahon) [21:56:15] (03Merged) 10jenkins-bot: [BrowserTest] once more [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174575 (owner: 10Cmcmahon) [21:56:40] chrismcmahon: Finally! [21:57:24] James_F: bothersome that voting qunit tests fail more than they pass [21:58:04] chrismcmahon: That's infrastructure changes for you; they'll settle down in a bit. [21:58:37] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression wmf7] Template dialog no longer takes focus on load - 10https://bugzilla.wikimedia.org/73138#c7 (10etonkovidova) 5RESO/?>3VERI Verified in test2 and production. [22:01:25] 3VisualEditor / 3ContentEditable: VisualEditor: Drag-and-drop an inserted image slices a table - 10https://bugzilla.wikimedia.org/72995#c7 (10etonkovidova) 5RESO/?>3VERI Verified the fix in production. [22:06:22] 3VisualEditor / 3ContentEditable: VisualEditor: handling preformatted text in tables - 10https://bugzilla.wikimedia.org/73100#c5 (10etonkovidova) 5RESO/?>3VERI Verified the fix in test2 and production. [22:09:37] 3VisualEditor / 3ContentEditable: VisualEditor: Tables - applying headings format to table cells will split the table - 10https://bugzilla.wikimedia.org/72990#c5 (10etonkovidova) 5RESO/?>3VERI Verified the fix in test2 and production [22:15:07] 3VisualEditor / 3ContentEditable: VisualEditor: Tables - adding formatted headings to displays Uncaught TypeError - 10https://bugzilla.wikimedia.org/72816#c3 (10etonkovidova) 5RESO/?>3VERI Verified the fix in production. [22:21:08] (03PS7) 10Mooeypoo: [wip] Adding paramOrder widget to TemplateData editor [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/170655 [22:30:07] 3VisualEditor: VisualEditor: Tracking bugs for VisualEditor (tracking) - 10https://bugzilla.wikimedia.org/54363 (10James Forrester) [22:30:10] 3VisualEditor / 3MediaWiki integration: VisualEditor: mw.Target / ViewPageTarget re-write - 10https://bugzilla.wikimedia.org/73593#c1 (10James Forrester) p:5Normal>3High Not really a tracking bug, on reflection. [22:33:18] RoanKattouw_away: https://www.mediawiki.org/wiki/Editing/Phabricator_project_plan [22:41:22] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf7] Button in Add a Template dialog is labeled as "Hide Options", instead of "Show Options" - 10https://bugzilla.wikimedia.org/73235#c9 (10etonkovidova) 5RESO/?>3VERI Checked in production. [22:46:01] (03PS1) 10Alex Monk: Check wgRelevantArticleId to determine relevant page existence even on special pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174582 (https://bugzilla.wikimedia.org/66885) [22:46:24] 3VisualEditor / 3Editing Tools: VisualEditor: Table row selector is shown incorrectly in RTL - 10https://bugzilla.wikimedia.org/73378#c4 (10etonkovidova) Verified in test2. [22:52:26] (03CR) 10Bartosz Dziewoński: "Roan?" [oojs/ui] - 10https://gerrit.wikimedia.org/r/173356 (owner: 10Trevor Parscal) [22:57:49] hmmm. so you know how, in TemplateData, we support the 'autovalue' parameter [22:58:08] and how we encourage people to add "subst:" in it, if they want something substed on save [22:58:27] and how we handle citation templates within tags [22:58:47] and how subst: does not work within tags? that's kinda poopy. [22:59:02] https://pl.wikipedia.org/w/index.php?title=Edward_Os%C3%B3bka-Morawski&diff=40993498&oldid=40975856 [22:59:13] MatmaRex: Bug 2700. [22:59:22] MatmaRex: The documentation pretty clearly says [22:59:26] i know. but it's causing issues with VE/TemplateData. [22:59:30] "don't use this in references". [22:59:46] that's pretty clearly very stupid, though, isn't it? [22:59:48] Only if people have set a reference template with an autovalue contrary to the guidance. [23:00:00] Fixes for bug 2700 welcome. [23:00:02] ;-) [23:00:03] both you and i know that people will do this, because that's how citation templates work. [23:00:13] last time i tried to fix something in the parser, it got a -2 [23:00:26] (because it would require effort to deploy) [23:00:42] Yeah. :-( [23:00:48] We should talk to the Parsoid team, I suppose. [23:00:53] James_F: i was thinking more of a patch to VE to expand templates in 'autovalue'. [23:01:10] (or substed templates, i guess) [23:01:17] MatmaRex: So VE goes to execute the subst on its own behalf? [23:01:48] yeah. pst currently only works by chance, right? we should do it explicitly [23:01:56] No, it's done explicitly. [23:01:59] It just doesn't work. [23:02:30] wait, you're saying that parsoid support pst now? [23:02:34] supports* [23:02:36] See ve.ce.MWTransclusionNode#generateContents etc. [23:02:40] It passes it through. [23:02:52] yeah. so it doesn't. that's what i meant by "by chance". [23:03:25] I don't understand. [23:03:33] Parsoid changed how it worked to pass through the PST flag. [23:03:39] There's no "chance" involved. [23:04:06] okay, that's reassuring. :) [23:04:59] i still think we should do pst client-side; and if not, then we *could*. and there's value in doing that for 'autovalue' parameters, imo. [23:05:41] Could work, I suppose. [23:05:52] Once OOUI is in MediaWiki, want to give it a try? [23:06:07] 3VisualEditor / 3Editing Tools: VisualEditor: Table column adding icon must be flipped for RTL - 10https://bugzilla.wikimedia.org/73379#c6 (10etonkovidova) The fix is in betalabs. [23:06:12] (03PS1) 10Ryasmeen: [BrowserTest] [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174587 [23:07:57] (03CR) 10jenkins-bot: [V: 04-1] [BrowserTest] [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174587 (owner: 10Ryasmeen) [23:09:21] (03CR) 10Catrope: [C: 032] [BREAKING CHANGE] Rename *Menu and *MenuItem widgets [oojs/ui] - 10https://gerrit.wikimedia.org/r/173356 (owner: 10Trevor Parscal) [23:12:22] (03Merged) 10jenkins-bot: [BREAKING CHANGE] Rename *Menu and *MenuItem widgets [oojs/ui] - 10https://gerrit.wikimedia.org/r/173356 (owner: 10Trevor Parscal) [23:18:05] (03PS1) 10Catrope: Update OOjs UI to v0.1.0-pre (7922a50558) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/174589 [23:18:22] James_F: Clean pull-through without the breaking change ---^^ [23:19:36] 3VisualEditor / 3MediaWiki integration: VisualEditor: Restore selection when user exits the save dialog (on clicking "Resume editing") - 10https://bugzilla.wikimedia.org/72911#c3 (10etonkovidova) Verified in test2. [23:25:51] (03PS2) 10Cmcmahon: [BrowserTest] Extent options test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174587 (owner: 10Ryasmeen) [23:26:24] (03PS3) 10Cmcmahon: [BrowserTest] Extend options test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174587 (owner: 10Ryasmeen) [23:27:02] (03CR) 10Jforrester: [C: 032] Update OOjs UI to v0.1.0-pre (7922a50558) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/174589 (owner: 10Catrope) [23:28:05] (03CR) 10jenkins-bot: [V: 04-1] [BrowserTest] Extend options test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174587 (owner: 10Ryasmeen) [23:28:08] (03CR) 10Cmcmahon: [C: 032] "Paired with Rummana" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174587 (owner: 10Ryasmeen) [23:29:17] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (7922a50558) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/174589 (owner: 10Catrope) [23:32:52] (03Merged) 10jenkins-bot: [BrowserTest] Extend options test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174587 (owner: 10Ryasmeen) [23:38:41] (03CR) 10Alex Monk: [C: 04-1] "more issues" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173360 (https://bugzilla.wikimedia.org/50809) (owner: 10Alex Monk) [23:38:51] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf5] Comment inspector closes and saves empty comment when tool is used - 10https://bugzilla.wikimedia.org/71706#c4 (10etonkovidova) test2 - checked both scenarios - no js errors. [23:41:15] (03PS4) 10Catrope: Update OOjs UI to v0.1.0-pre (1fa4eb7a73) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173912 (owner: 10Trevor Parscal) [23:41:36] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf5] Have to undo twice to reverse comment creation - 10https://bugzilla.wikimedia.org/72315#c8 (10etonkovidova) Verified the fix in test2. [23:50:07] 3VisualEditor / 3Editing Tools: VisualEditor: In Firefox, while typing inside Basic reference dialog for the first time in a session , the letters gets garbled and "Insert" button remains disabled - 10https://bugzilla.wikimedia.org/73625 (10Rummana Yasmeen) 3NEW p:3Unprio s:3major a:3None Created att... [23:50:22] 3VisualEditor / 3Editing Tools: VisualEditor: In Firefox, while typing inside Basic reference dialog for the first time in a session , the letters gets garbled and "Insert" button remains disabled - 10https://bugzilla.wikimedia.org/73625 (10Rummana Yasmeen) p:5Unprio>3High a:3Roan Kattouw [23:50:35] 3VisualEditor / 3Editing Tools: VisualEditor: In Firefox, while typing inside Basic reference dialog for the first time in a session , the letters gets garbled and "Insert" button remains disabled - 10https://bugzilla.wikimedia.org/73625 (10Rummana Yasmeen) 5NEW>3ASSI [23:50:47] RoanKattouw: Can you please look into this one https://bugzilla.wikimedia.org/show_bug.cgi?id=73625 [23:50:55] (03PS1) 10Alex Monk: Load visualeditor-content-select-all message [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174596 [23:51:14] ryasmeen: Argh, again? :( [23:51:23] Krenair: Whoops. [23:51:25] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (1fa4eb7a73) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173912 (owner: 10Trevor Parscal) [23:51:27] yeah! :( and I dont know since when [23:51:38] its in en.wiki right now [23:51:42] (03CR) 10Alex Monk: "I4cd8de95" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172039 (owner: 10Esanders) [23:52:48] definitely in wmf 8 , that i can tell [23:53:37] 3VisualEditor / 3Editing Tools: VisualEditor:[Regression wmf8] In Firefox, while typing inside Basic reference dialog for the first time in a session , the letters gets garbled and "Insert" button remains disabled - 10https://bugzilla.wikimedia.org/73625 (10Rummana Yasmeen) [23:54:04] (03PS2) 10Jforrester: Follow-up Icdeaa4c: Load visualeditor-content-select-all message [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174596 (owner: 10Alex Monk) [23:54:21] (03CR) 10Jforrester: [C: 032] Follow-up Icdeaa4c: Load visualeditor-content-select-all message [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174596 (owner: 10Alex Monk) [23:54:30] (03PS1) 10Jforrester: Follow-up Icdeaa4c: Load visualeditor-content-select-all message [extensions/VisualEditor] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/174597 [23:54:38] (03PS1) 10Jforrester: Follow-up Icdeaa4c: Load visualeditor-content-select-all message [extensions/VisualEditor] (wmf/1.25wmf9) - 10https://gerrit.wikimedia.org/r/174598 [23:55:57] (03Merged) 10jenkins-bot: Follow-up Icdeaa4c: Load visualeditor-content-select-all message [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174596 (owner: 10Alex Monk) [23:57:52] (03PS5) 10Catrope: Update OOjs UI to v0.1.0-pre (1fa4eb7a73) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173912 (owner: 10Trevor Parscal) [23:59:21] (03CR) 10Jforrester: [C: 032] Update OOjs UI to v0.1.0-pre (1fa4eb7a73) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173912 (owner: 10Trevor Parscal) [23:59:45] (03PS1) 10Jforrester: Update VE core submodule to master (c79929b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174600 [23:59:58] https://gerrit.wikimedia.org/r/174597 https://gerrit.wikimedia.org/r/174598