[00:00:03] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Update VE core submodule to master (c79929b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174600 (owner: 10Jforrester)
[00:01:47] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update VE core submodule to master (c79929b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174600 (owner: 10Jforrester)
[00:01:50] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (1fa4eb7a73) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173912 (owner: 10Trevor Parscal)
[00:05:06] <ryasmeen>	 Also RoanKattouw, did we change the background color of all toolbars to white?
[00:05:18] <RoanKattouw>	 Uhm, not that I know of?
[00:05:24] <Krinkle>	 TrevorParscal: Yep, I got feedback mail from CircieCI after we closed out trial. I told them shippable is free. They said they'd do the same.
[00:05:49] <ryasmeen>	 Okay , then its not a feature 
[00:06:01] <ryasmeen>	 RoanKattouw: filing a bug on that
[00:06:11] <RoanKattouw>	 OK
[00:06:15] <RoanKattouw>	 When did it change?
[00:06:34] <grrrit-wm>	 (03CR) 10Krinkle: [BrowserTest] sort the VE page object (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174514 (owner: 10Cmcmahon)
[00:06:56] <James_F>	 Krinkle: Neat.
[00:07:06] <James_F>	 ryasmeen: Is this on Beta Labs?
[00:07:11] <ryasmeen>	 RoanKattouw:as of today, I guess
[00:07:18] <ryasmeen>	 James_F: yeah!
[00:07:28] <ryasmeen>	 James_F: the white toolbar?
[00:07:29] <James_F>	 ryasmeen: Lots of graphical breakage there. I think someone's been muddying around with Common.css
[00:07:37] <ryasmeen>	 argh!
[00:07:41] <James_F>	 ryasmeen: Not bugs, just a need to hit colleagues. :-(
[00:07:52] <ryasmeen>	 umm okay!
[00:08:38] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: [Regression wmf8] inserting formulas give's TypeError: 'undefined - 10https://bugzilla.wikimedia.org/73627 (10etonkovidova) 3NEW p:3Unprio s:3normal a:3None test2 - insert a formula: type some simple formula or paste it.   [Error] TypeError: 'undefined'...
[00:10:06] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: [Regression] Gallery gets added into media, if there is/was something in the media's caption - 10https://bugzilla.wikimedia.org/73368#c11 (10etonkovidova) Verified the fix in test2.
[00:13:38] <Krenair>	 James_F, so https://bugzilla.wikimedia.org/show_bug.cgi?id=73363... is a cancel button but triggered by the escape key instead?
[00:13:56] <James_F>	 Krenair: The "read" link but triggered by escape key, yes.
[00:14:11] <Krenair>	 didn't we get rid of the cancel button?
[00:14:46] <James_F>	 Krenair: Because it duplicated functionality and took up room. This does neither.
[00:17:34] <Krenair>	 I wonder if VE provides any nice way to handle an escape key event or if I'm going to have to resort to sticking horrible things in init.mw
[00:17:50] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Follow-up Icdeaa4c: Load visualeditor-content-select-all message [extensions/VisualEditor] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/174597 (owner: 10Jforrester)
[00:17:53] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Follow-up Icdeaa4c: Load visualeditor-content-select-all message [extensions/VisualEditor] (wmf/1.25wmf9) - 10https://gerrit.wikimedia.org/r/174598 (owner: 10Jforrester)
[00:18:33] <MatmaRex>	 James_F: (re autovalue earlier, sure, as soon as we're done with the current stuff)
[00:18:58] <James_F>	 MatmaRex: Kk.
[00:22:20] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor:[Regression wmf8] In Firefox, while typing inside Basic reference dialog/Media Settings for the first time in a session , the letters gets garbled and "Insert" button remains disabled - 10https://bugzilla.wikimedia.org/73625#c1 (10Rummana Yasmeen) It also happens...
[00:23:22] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Follow-up Icdeaa4c: Load visualeditor-content-select-all message [extensions/VisualEditor] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/174597 (owner: 10Jforrester)
[00:23:24] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Follow-up Icdeaa4c: Load visualeditor-content-select-all message [extensions/VisualEditor] (wmf/1.25wmf9) - 10https://gerrit.wikimedia.org/r/174598 (owner: 10Jforrester)
[00:24:33] <grrrit-wm>	 (03CR) 10Catrope: [V: 032] Follow-up Icdeaa4c: Load visualeditor-content-select-all message [extensions/VisualEditor] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/174597 (owner: 10Jforrester)
[00:24:51] <grrrit-wm>	 (03CR) 10Catrope: [V: 032] Follow-up Icdeaa4c: Load visualeditor-content-select-all message [extensions/VisualEditor] (wmf/1.25wmf9) - 10https://gerrit.wikimedia.org/r/174598 (owner: 10Jforrester)
[00:25:06] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: When selecting FocusableNode with arrow keys, context flickers at position of last mouse click - 10https://bugzilla.wikimedia.org/73242#c3 (10etonkovidova) Verified the fix in beta.
[00:29:23] <mooey|away>	 TrevorParscal, are you around?
[00:29:30] <TrevorParscal>	 hi
[00:29:34] <TrevorParscal>	 see my email
[00:29:37] <mooeypoo>	 Got a second -- oh
[00:30:07] * mooeypoo nods
[00:30:10] <mooeypoo>	 yeah that's what I had in mind too
[00:30:18] <mooeypoo>	 TrevorParscal, another question regarding implementing the design, though
[00:30:29] <mooeypoo>	 this relates to an earlier quesrtion I asked today but was probably buried in backlog
[00:30:51] <TrevorParscal>	 k
[00:30:59] <mooeypoo>	 So, the way kaity arranged the language buttons, they're all in one line: Language: [ select ] [ button ]
[00:31:21] <mooeypoo>	 I couldn't find a way to put 2 widgets one next to the other without creating my own divs and such
[00:31:30] <Krenair>	 https://gerrit.wikimedia.org/r/#/c/169976/2
[00:31:31] <Krenair>	 sigh
[00:31:31] <mooeypoo>	 the FieldsetLayout accepts 1 widget and attaches a label to it
[00:31:36] <wikibugs>	 3VisualEditor / 3Data Model: VisualEditor: Non-numeric colspan/rowspan values are normalized, or corrupted to NaN - 10https://bugzilla.wikimedia.org/73430#c6 (10etonkovidova) Verified the fix in test2.
[00:31:56] <Krenair>	 So I need to run some code to ignore warnings if they press continue, but not if they press dismiss
[00:31:58] <mooeypoo>	 TrevorParscal, can we add a fieldset that has 2 or more widgets one next to the other (or even a widget + button, instead of just widget + label) ?
[00:32:15] <mooeypoo>	 Also, i tried nesting fieldsets but that just breaks everything
[00:32:17] <Krenair>	 and only run it if the only error currently showing is due to page deletion
[00:32:47] <mooeypoo>	 The FieldsetLayout expects a widget specifically. Best I could do is use it for label + label, since label is a widget too
[00:33:08] <mooeypoo>	 TrevorParscal, am I missing a layout or something? or should we / can we add this?
[00:35:48] <TrevorParscal>	 i think we do need a way to layout controls horizontally
[00:36:00] <TrevorParscal>	 the most common case is an input with a button
[00:36:45] * mooeypoo nods
[00:36:54] <mooeypoo>	 or potentially a checkbox with another widget
[00:36:55] <mooeypoo>	 ?
[00:36:56] <TrevorParscal>	 so, like an ActionFieldLayout or something, which is a special field layout that takes a widget, but provides a button instead of a label
[00:37:01] <mooeypoo>	 like, enable this widget type thing
[00:37:16] * mooeypoo nods
[00:37:26] <TrevorParscal>	 that's actually a different, and very interesting design idea we could add to all FieldLayouts
[00:37:41] <mooeypoo>	 Ah, enable the field layout in general?
[00:37:42] <TrevorParscal>	 an enable/disable control that's consistently placed on the left
[00:37:45] * mooeypoo nods
[00:37:58] <TrevorParscal>	 do you have the need for both right now?
[00:38:03] <mooeypoo>	 no no
[00:38:07] <mooeypoo>	 just the button one for now
[00:38:23] <mooeypoo>	 the checkbox one came up when I was working on the media dialog, but there's no need for it anymore
[00:38:30] <mooeypoo>	 we went with "none" choice
[00:38:37] <mooeypoo>	 (though w emight want to revisit that at some point)
[00:39:16] <mooeypoo>	 TrevorParscal, also, if we go with kaity's design exactly, the title of the field layout is in the same line as well
[00:40:01] <mooeypoo>	 sorry, I keep getting FieldLayout and FieldsetLayout mixed up when I type
[00:40:47] <mooeypoo>	 TrevorParscal, so, FieldLayout is the one for the horizontal layout with the button -- but FieldsetLayout is also always vertical, the title above whatever widgets. In kaity's design, that too is horizontal. Do we want to make that an option too?
[00:41:34] <mooeypoo>	 Otherwise it will be "Language: (line break) [ select ] [ button"
[01:05:21] <grrrit-wm>	 (03PS2) 10Jforrester: Update VE core submodule to master (029fc7e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173982 (owner: 10Trevor Parscal)
[01:06:11] <grrrit-wm>	 (03CR) 10Jforrester: "PS2 is a regeneration squashed into a real pull-through." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173982 (owner: 10Trevor Parscal)
[01:07:20] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (029fc7e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173982 (owner: 10Trevor Parscal)
[01:08:58] <James_F>	 Krinkle: Hmm. Can you purge the workspace for the box VE-MW's npm runs on?
[01:09:01] <James_F>	 Krinkle: "01:06:44 npm ERR! error rolling back Error: Refusing to delete: /mnt/jenkins-workspace/workspace/mwext-VisualEditor-npm/node_modules/grunt-jscs/node_modules/jscs/node_modules/.bin/esparse not in /mnt/jenkins-workspace/workspace/mwext-VisualEditor-npm/node_modules/grunt-jscs/node_modules/jscs/node_modules/esprima-harmony-jscs "
[01:09:14] <Krinkle>	 What have you done :P
[01:09:26] <Krinkle>	 which slave
[01:09:59] <James_F>	 Krinkle: integration-slave1007.
[01:10:06] <Krinkle>	 done
[01:10:06] <James_F>	 Krinkle: https://integration.wikimedia.org/ci/job/mwext-VisualEditor-npm/5510/console
[01:12:20] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Allowing creation of empty caption moves the column editing icon at the top of the empty space which looks odd - 10https://bugzilla.wikimedia.org/72829#c9 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production
[01:12:52] <wikibugs>	 3MediaWiki / 3ResourceLoader: CSSJanus fails to flip with !important - 10https://bugzilla.wikimedia.org/61440 (10James Forrester) 5PATC>3RESO/FIX
[01:13:15] <Krinkle>	 RoanKattouw: Wow. You thought String.prototype.bold is inappropiate? Java has String.execute
[01:13:20] <Krinkle>	 >> 'foo'.bold()
[01:13:20] <ecmabot-wm>	 Krinkle: (string) '<b>foo</b>'
[01:13:26] <Krinkle>	 println "uname -a".execute().text 
[01:13:42] <Krinkle>	 omg
[01:14:01] <Krinkle>	 I just ran into this trying to get php/hhvm version from a jenkins slave via Jenkins console (which only takes java)
[01:14:06] <Krinkle>	 and the example is println "uname -a".execute().text 
[01:16:18] <James_F>	 Krinkle: Lovely.
[01:17:50] <grrrit-wm>	 (03CR) 10Jforrester: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173982 (owner: 10Trevor Parscal)
[01:18:07] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf7] The cursor stays active on CE even after opening the dialog for Basic Reference/Citation/Reference list/Page Settings - 10https://bugzilla.wikimedia.org/73097#c15 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production
[01:19:39] <RoanKattouw>	 Krinkle: WHAT. THE. ACTUAL. FUCK
[01:27:05] <wikibugs>	 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression pre-wmf8] "Uncaught Error: Unknown dependency: rangefix" appears while trying to load mobile VE - 10https://bugzilla.wikimedia.org/73038#c12 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production
[01:30:44] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Update VE core submodule to master (029fc7e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173982 (owner: 10Trevor Parscal)
[01:32:22] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (029fc7e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173982 (owner: 10Trevor Parscal)
[01:32:31] <James_F>	 Bleh.
[01:32:47] <James_F>	 Now it's the /other/ random failure.
[01:33:05] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] "C'mon, jenkins…" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173982 (owner: 10Trevor Parscal)
[01:34:52] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (029fc7e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173982 (owner: 10Trevor Parscal)
[01:48:37] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: Categories without description pages don't show as red - 10https://bugzilla.wikimedia.org/65517#c5 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production
[01:56:05] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Update VE core submodule to master (029fc7e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173982 (owner: 10Trevor Parscal)
[01:57:39] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update VE core submodule to master (029fc7e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173982 (owner: 10Trevor Parscal)
[01:59:26] <grrrit-wm>	 (03Abandoned) 10Jforrester: Remove "Options" tool from hamburger menu [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/153737 (https://bugzilla.wikimedia.org/69451) (owner: 10Catrope)
[02:26:37] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: [Regression wmf8] inserting formulas give's TypeError: 'undefined - 10https://bugzilla.wikimedia.org/73627 (10Rummana Yasmeen)
[02:47:27] <grrrit-wm>	 (03CR) 10Ori.livneh: "This looks fine. I recommend scrapping the whole editor seniority thresholds scheme and just logging the bare edit count. If you find you " (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/171499 (owner: 10Catrope)
[02:47:36] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 031] Add instrumentation for edit schema [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/171499 (owner: 10Catrope)
[10:46:46] <grrrit-wm>	 (03PS1) 10Amire80: Fix the index of the insert menu [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174670 
[10:49:11] <grrrit-wm>	 (03PS2) 10Amire80: WIP: Add a class to the toolbar button [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174666 
[10:50:53] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP: Add a class to the toolbar button [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174666 (owner: 10Amire80)
[10:52:36] <grrrit-wm>	 (03PS2) 10Amire80: Fix the index of the insert menu [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174670 
[10:52:48] <grrrit-wm>	 (03PS3) 10Zfilipin: [BrowserTest] Fix the index of the insert menu [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174670 (owner: 10Amire80)
[10:54:32] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [BrowserTest] Fix the index of the insert menu [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174670 (owner: 10Amire80)
[10:55:46] <grrrit-wm>	 (03CR) 10Zfilipin: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174670 (owner: 10Amire80)
[10:55:55] <grrrit-wm>	 (03CR) 10Zfilipin: [C: 032] [BrowserTest] Fix the index of the insert menu [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174670 (owner: 10Amire80)
[10:57:34] <grrrit-wm>	 (03Merged) 10jenkins-bot: [BrowserTest] Fix the index of the insert menu [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174670 (owner: 10Amire80)
[11:28:59] <grrrit-wm>	 (03CR) 10Zfilipin: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174666 (owner: 10Amire80)
[12:02:12] <grrrit-wm>	 (03PS3) 10Amire80: WIP: Add a class to the toolbar button [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174666 
[12:53:23] <Krenair>	 edsanders|away, for https://bugzilla.wikimedia.org/show_bug.cgi?id=73565 - since they are all CE CSS rules, I thought about moving them into src/ce/styles/ve.ce.css and using an IE class somewhere
[12:54:03] <Krenair>	 edsanders|away, I was just wondering why ve-mw doesn't load that file though
[13:07:42] <edsanders>	 Krenair, if we're doing a wrapper class then we can put them adjacent to their regular declarations
[13:07:56] <edsanders>	 ve-mw doesn't load ve.ce.css?
[13:09:28] <edsanders>	 that seems like an oversight
[13:09:30] <Krenair>	 yeah
[13:09:37] <edsanders>	 although I'm not sure we need that as a separate class
[13:09:42] <edsanders>	 it's only used by language annotation
[13:09:58] <edsanders>	 and it's only three rules, if it's needed elsewhere it should just be added to the required class
[13:10:34] <edsanders>	 really it's just so we don't have to repeat the vendor prefixes but we should fix that with LESS in the future
[13:20:23] <wikibugs>	 3OOjs UI: OOjs UI: trouble with CheckboxInputWidget in Opera - 10https://bugzilla.wikimedia.org/73517#c4 (10Thiemo Mättig) The issue is caused by the combination of the SVG background and the border-radius. One solution can be seen in 2b8f46c6. An other solution is to remove the CSS border completely and draw...
[13:27:54] <grrrit-wm>	 (03PS1) 10Alex Monk: Copy in some IE CSS hacks from ve-mw [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/174683 (https://bugzilla.wikimedia.org/73565) 
[13:39:40] <wikibugs>	 3VisualEditor / 3Mobile: Editor switcher broken - 10https://bugzilla.wikimedia.org/73646#c3 (10Jon) a:3None Issue seems to be in VisualEditor exception 'MWException' with message 'ResourceLoaderFileModule::readStyleFile: style file not found: "/srv/mediawiki/php-master/extensions/VisualEditor/lib/ve/src/ui...
[13:45:54] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: z-index of toolbar and dialog in core - 10https://bugzilla.wikimedia.org/73650 (10Ed Sanders) 3NEW p:3Unprio s:3normal a:3None In MW we have a hack that moves the dialog overlay to zIndex 101 (from 1), but the hack to move the toolbar to zIndex 100 is in...
[13:50:49] <grrrit-wm>	 (03CR) 10Esanders: [C: 04-1] Eventify TemplateDataGenerator and use oojs-ui (032 comments) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 (owner: 10Mooeypoo)
[13:57:57] <grrrit-wm>	 (03PS1) 10Esanders: Remove unused CSS: toolbar contains no PopupButtonWidgets [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174686 
[13:58:43] <grrrit-wm>	 (03PS1) 10Esanders: Use super to call parent constructors [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174687 
[13:59:41] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Remove unused CSS: toolbar contains no PopupButtonWidgets [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174686 (owner: 10Esanders)
[14:03:10] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Use super to call parent constructors [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174687 (owner: 10Esanders)
[14:04:38] <grrrit-wm>	 (03PS1) 10Esanders: Fix z-indexes in core [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/174688 (https://bugzilla.wikimedia.org/73650) 
[14:40:43] <grrrit-wm>	 (03PS2) 10Esanders: Fix z-indexes in core [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/174688 (https://bugzilla.wikimedia.org/73650) 
[14:46:14] <grrrit-wm>	 (03PS1) 10Esanders: Give help content box a reasonable line height for legibility [oojs/ui] - 10https://gerrit.wikimedia.org/r/174692 
[14:53:41] <grrrit-wm>	 (03PS2) 10Esanders: Give help content box a reasonable line height for legibility [oojs/ui] - 10https://gerrit.wikimedia.org/r/174692 
[15:16:56] <grrrit-wm>	 (03PS1) 10Esanders: Fix poision of popup anchor, specifically on the help content popup. [oojs/ui] - 10https://gerrit.wikimedia.org/r/174700 
[15:24:20] <Krenair>	 edsanders, position?
[15:26:41] <wikibugs>	 3VisualEditor: VisualEditor: Text in dialog boxes is too small in Monobook - 10https://bugzilla.wikimedia.org/73660 (10Elitre) 3NEW p:3Unprio s:3normal a:3None See https://www.mediawiki.org/wiki/File:Save_page_by_skins.png . That applies to most of the dialogs (not to the link inspector, for example.)
[15:28:41] <grrrit-wm>	 (03CR) 10Esanders: [C: 04-1] "wip" [oojs/ui] - 10https://gerrit.wikimedia.org/r/174700 (owner: 10Esanders)
[15:45:21] <grrrit-wm>	 (03CR) 10Alex Monk: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174687 (owner: 10Esanders)
[16:09:52] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression] Text in dialog boxes is too small in Monobook - 10https://bugzilla.wikimedia.org/73660 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High
[16:10:37] <James_F>	 Hey, sorry, forgot to connect to IRC. :-)
[16:12:39] <wikibugs>	 3VisualEditor / 3Technical Debt: VisualEditor: z-index for .ve-ui-surface-overlay is too high (and we shouldn't use them anyway) - 10https://bugzilla.wikimedia.org/49514#c6 (10Alex Monk) Wasn't this fixed by Gerrit change 70572?
[16:14:39] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf9] inserting formulae gives 'TypeError: undefined is not a function' (ve.bind) - 10https://bugzilla.wikimedia.org/73627 (10James Forrester) p:5Unprio>3High a:3Krinkle
[16:17:11] <Krenair>	 how do those damn ve.bind references keep popping up?
[16:17:25] <Krenair>	 oh right, Math extension
[16:17:56] <Krenair>	 isn't that bug fixed now James?
[16:18:12] <grrrit-wm>	 (03PS2) 10Esanders: Remove CSS hack for positioning popupButtonWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/174700 
[16:18:37] <James_F>	 Krenair: Yeah, I'm getting it deployed right now.
[16:18:41] <Krinkle>	 Krenair: When I saw that bug I didn't know it was from Math, so I ran a search
[16:18:42] <Krinkle>	 https://github.com/search?q=%22ve.bind%22+@wikimedia&type=Code&utf8=%E2%9C%93
[16:18:44] <Krinkle>	 that was the last one
[16:18:52] <James_F>	 Krinkle: Good!
[16:18:59] <Krinkle>	 it's gone now that the change was merged by James_F
[16:19:09] <James_F>	 Krinkle: Gone in master. :-)
[16:20:22] <James_F>	 Krinkle: https://github.com/search?utf8=%E2%9C%93&q=%22ve.bind%22+%40Wikia&type=Code&ref=searchresults – Wikia are still using it, of course. Quite a bit!
[16:24:14] <James_F>	 Krinkle: Further thoughts on merging https://gerrit.wikimedia.org/r/#/c/174147/ so I can duplicate it out to our other build environments?
[16:30:01] <Krinkle>	 James_F: I don't think such a task should exist. It's not going to fly well in our other tasks and streams. Lots of I/O. Slow. And very specific and high maintenance. Things in text can go through code review. If code review misses it, it's not bad. It's just a typo. We're not setting up abuse filters for typos either. For @returns though, we should catch that in jsduck. And I'mhappy to do tha
[16:30:01] <Krinkle>	 t upstream.
[16:30:35] <James_F>	 Krinkle: This is established principle in Wikimedia CI for years now – see the operations repos.
[16:30:59] <James_F>	 Krinkle: This is about "inpsectors" and "ipnsectors" and "inspcetors" and all the rest.
[16:31:13] <Krinkle>	 No, Antoine implemented a quick job for one single repo for typos in identifiers (esams). That was one-off. hardly 'established in CI'.
[16:31:51] <James_F>	 It's widely used and depended upon
[16:32:15] <James_F>	 You don't get to wave your hands in the air afterwards and say "That's not what we meant!". :-)
[16:32:38] <Krinkle>	 In what imaginary context?
[16:32:47] <Krinkle>	 I'm happy for such a thing to exist, but I'd do it in Jenkins, not Grunt. So that it can be limited to changed files. And maintained at once.
[16:32:57] <James_F>	 At once?
[16:33:22] <Krinkle>	 Not duplicated everywhere. What would we put in it? Any word we mis spell once?
[16:33:37] <grrrit-wm>	 (03CR) 10Esanders: "Maybe we pull-throughs before merging?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/174589 (owner: 10Catrope)
[16:34:01] <edsanders>	 OOJS broke VE
[16:34:12] <Krinkle>	 and naturally, the correct spelling in the config, too.
[16:34:39] <James_F>	 Krinkle: Eh. Messy. You slow all repos down based on each projects' common typos.
[16:34:40] <Krinkle>	 for technical things like @returns, it's not a typo.
[16:34:51] <James_F>	 Krinkle: And "Colour" may be a typo in one and the correct one in antoher.
[16:34:51] <Krinkle>	 so having the correct thing would be usefu.
[16:35:14] <James_F>	 On @returns I grant it's a poor example; I just picked it as the obvious one.
[16:35:17] <Krinkle>	 oh com on, we're not seriously going to catch that with grunt?
[16:35:21] <James_F>	 edsanders: What broke?
[16:35:22] <Krinkle>	 That's a massive waste of time.
[16:35:24] <James_F>	 Krinkle: Why not?
[16:35:36] <Krinkle>	 I think @returns should be caught
[16:35:58] <edsanders>	 look at the demo
[16:36:41] <Krinkle>	 James_F: I'm not vetoing it, unless my opinion has that weight. You asked for my review. I'm saying the intended purpose is not clear to me as of yet, which makes it hard to review whether it's implemented in a good-enough manner.
[16:36:54] <Krinkle>	 it's doing something alright :)
[16:37:12] <James_F>	 Krinkle: It's a CI change; your opinion trumps everyone else's in this regard. :-)
[16:38:54] <Krinkle>	 James_F: Well, no, I don't trump VE. This doesn't affect Jenkins currently. I've seen other build tasks flky in and out of VE and OOjs UI in the past as well that I had doubts over. What works best for you in the moment is important, I don't want to stand in the way of that. But if you're asking how I'd do it, I'd fix @returns in jsduck upstream, and defer the rest to code review for plain tex
[16:38:54] <Krinkle>	 t comments. imho not worth the effort to spell check that. Maybe advocate a good spell checker to use in your text editor.
[16:39:47] <James_F>	 Krinkle: It's mostly to shorten the loop on stupid typos.
[16:40:03] <James_F>	 Krinkle: Code sits around for hours, sometimes days, which then gets C-1'ed because of a dumb typo.
[16:40:34] <James_F>	 Krinkle: It'd be much better if those got spotted and fixed immediately by the original developer (ideally, before it even hits gerrit).
[16:40:40] <James_F>	 Krinkle: Hence in grunt, not jenkins.
[16:41:37] <Krinkle>	 with a spell checker the developer would've fixed it before submitting to gerrit in the first place. Same for coding style. Grunt and jenkins are just a double check.
[16:41:52] <Krinkle>	 Just look at how rarely we get jshint or jscs errors nowadays from our team members.
[16:42:03] <Krinkle>	 aside from getting used to it, of course.
[16:43:22] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression ?pre-wmf8] Typing inside dialog surfaces for the first time in a session: the letters gets garbled and "Insert" button remains disabled in Firefox - 10https://bugzilla.wikimedia.org/73625 (10James Forrester)
[16:43:43] <James_F>	 edsanders: I've looked at the demo but it all looks familiar?
[16:43:53] <edsanders>	 the toolbar is broken
[16:44:13] <James_F>	 edsanders: Oh, the white background? Hmm. I assumed it was Beta Labs breakage.
[16:44:22] <James_F>	 edsanders: Is this a bug in OOUI?
[16:44:25] <edsanders>	 all the styles
[16:44:35] <edsanders>	 the border
[16:44:38] <edsanders>	 the lack of floating
[16:44:47] <James_F>	 Well, let's fix it.
[16:45:42] <edsanders>	 the toolbar-bar class was removed
[16:46:28] <James_F>	 By Trevor?
[16:50:52] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf9] inserting formulae gives 'TypeError: undefined is not a function' (ve.bind) - 10https://bugzilla.wikimedia.org/73627 (10James Forrester) 5PATC>3RESO/FIX
[16:53:54] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: z-index of toolbar and dialog in core - 10https://bugzilla.wikimedia.org/73650 (10James Forrester) p:5Unprio>3High a:3Ed Sanders
[16:58:37] <James_F>	 Krenair: Do you care about Monobook? https://bugzilla.wikimedia.org/show_bug.cgi?id=73660 wants someone to care. :-)
[16:58:50] <Krenair>	 no
[16:59:08] <Krenair>	 but I might look if they asked nicely
[17:00:10] * James_F bats his eyes. :-)
[17:00:17] <wikibugs>	 3VisualEditor / 3Technical Debt: VisualEditor: z-index for .ve-ui-surface-overlay is too high (and we shouldn't use them anyway) - 10https://bugzilla.wikimedia.org/49514#c7 (10James Forrester) 5ASSI>3RESO/FIX a:3Krinkle (In reply to Alex Monk from comment #6) > Wasn't this fixed by Gerrit change #70572...
[17:02:24] <grrrit-wm>	 (03PS1) 10Cmcmahon: [BrowserTest] locator changed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174723 
[17:03:02] <grrrit-wm>	 (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174723 (owner: 10Cmcmahon)
[17:04:50] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [BrowserTest] locator changed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174723 (owner: 10Cmcmahon)
[17:07:18] <grrrit-wm>	 (03CR) 10Cmcmahon: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174723 (owner: 10Cmcmahon)
[17:08:34] <Krenair>	 James_F, I wonder if the iframe removal would've caused this?
[17:08:35] <grrrit-wm>	 (03PS1) 10SuchetaG: [WIP] Link Inspector Redesign [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174725 
[17:08:45] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [WIP] Link Inspector Redesign [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174725 (owner: 10SuchetaG)
[17:14:29] <chrismcmahon>	 James_F: is there any way to get this merged without playing qunit-roulette all day? https://gerrit.wikimedia.org/r/#/c/174723/
[17:16:16] <Krenair>	 James_F, applying the font-size:127% like MonoBook does in div#globalWrapper makes it seem better
[17:16:35] <James_F>	 Krenair: Ick.
[17:16:56] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] [BrowserTest] locator changed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174723 (owner: 10Cmcmahon)
[17:18:38] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [BrowserTest] locator changed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174723 (owner: 10Cmcmahon)
[17:19:48] <Krinkle>	 chrismcmahon: No need to gamble if you know all the odds.
[17:19:50] <Krinkle>	 :P
[17:20:05] * Krinkle rolls dice
[17:20:30] <grrrit-wm>	 (03CR) 10Krinkle: [C: 032] [BrowserTest] locator changed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174723 (owner: 10Cmcmahon)
[17:21:01] <Krinkle>	 I've moved mwext-VisualEditor-qunit back to gallium/lanthanum
[17:21:47] <grrrit-wm>	 (03PS2) 10SuchetaG: [WIP] Link Inspector Redesign [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174725 
[17:22:09] <grrrit-wm>	 (03Merged) 10jenkins-bot: [BrowserTest] locator changed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174723 (owner: 10Cmcmahon)
[17:24:09] <Krenair>	 James_F, on my local wiki this issue doesn't happen. But for some reason my one still isolates windows in iframes?
[17:28:35] <Krenair>	 anyone know why?
[17:30:41] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=109284496
[17:30:41] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on ptwiki: https://pt.wikipedia.org/?diff=40658128
[17:30:41] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on fiwiki: https://fi.wikipedia.org/?diff=14457553
[17:30:54] <Krenair>	 oh, looks like my copy of VE was just a little too out of date
[17:40:54] <grrrit-wm>	 (03PS17) 10Divec: Refactor SurfaceObserver pollOnceInternal [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166188 
[17:41:39] <grrrit-wm>	 (03PS27) 10Divec: Use a single unicorn-like <img> instead of &#xFEFF; in inline slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151046 (owner: 10Catrope)
[17:44:17] <grrrit-wm>	 (03PS3) 10Divec: WIP: Rerender ContentBranchNodes when the selection anchor leaves [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/171494 
[17:46:07] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP: Rerender ContentBranchNodes when the selection anchor leaves [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/171494 (owner: 10Divec)
[17:50:52] <grrrit-wm>	 (03CR) 10Alex Monk: "Caused bug 73660" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/169286 (owner: 10Catrope)
[17:50:53] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression] Text in dialog boxes is too small in Monobook - 10https://bugzilla.wikimedia.org/73660#c1 (10Alex Monk) Caused by Gerrit change 169286, pulled into ve-mw by Gerrit change 170367
[17:51:09] <Krenair>	 James_F, looks like I was right about the iframe isolation thing :)
[17:53:08] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression] Text in dialog boxes is too small in Monobook - 10https://bugzilla.wikimedia.org/73660 (10Alex Monk) a:3Alex Monk
[17:56:53] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression wmf7] Text in dialog boxes is too small in Monobook - 10https://bugzilla.wikimedia.org/73660 (10James Forrester)
[17:57:36] <grrrit-wm>	 (03PS1) 10Alex Monk: Fix ridiculously small font size in overlays under MonoBook [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174742 (https://bugzilla.wikimedia.org/73660) 
[17:58:21] <grrrit-wm>	 (03PS1) 10Esanders: Restore toolbar class [oojs/ui] - 10https://gerrit.wikimedia.org/r/174743 
[17:59:14] <grrrit-wm>	 (03PS1) 10Mvolz: Replaced sync method modifyBody with async [services/citoid] - 10https://gerrit.wikimedia.org/r/174744 
[17:59:39] <edsanders>	 https://gerrit.wikimedia.org/r/#/c/174743/ needs merge and pullthrough
[18:10:12] <grrrit-wm>	 (03PS54) 10Paladox: WikiEditor: Re add SVG [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151611 (https://bugzilla.wikimedia.org/35342) 
[18:20:36] <grrrit-wm>	 (03CR) 10Alex Monk: [C: 032] Use super to call parent constructors [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174687 (owner: 10Esanders)
[18:20:41] <grrrit-wm>	 (03CR) 10Esanders: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174686 (owner: 10Esanders)
[18:20:46] <grrrit-wm>	 (03CR) 10Esanders: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174687 (owner: 10Esanders)
[18:23:18] <grrrit-wm>	 (03CR) 10Esanders: "I think this is good to go." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173805 (https://bugzilla.wikimedia.org/72426) (owner: 10Esanders)
[18:23:23] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Preserve `data-parsoid` attribute on internal copy-paste so that Parsoid preserves e.g. syntax layout - 10https://bugzilla.wikimedia.org/72426#c21 (10Ed Sanders) That seems fine.
[18:24:13] <Krenair>	 edsanders, ... so I can't submit that change?
[18:24:35] <Krenair>	 even though it has full Verified and CodeReview votes?
[18:25:25] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Remove unused CSS: toolbar contains no PopupButtonWidgets [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174686 (owner: 10Esanders)
[18:25:40] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] "prod" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174687 (owner: 10Esanders)
[18:27:52] <grrrit-wm>	 (03Merged) 10jenkins-bot: Use super to call parent constructors [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174687 (owner: 10Esanders)
[18:27:57] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove unused CSS: toolbar contains no PopupButtonWidgets [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174686 (owner: 10Esanders)
[18:31:20] <grrrit-wm>	 (03CR) 10Jforrester: [C: 04-1] "* "Follow-up Id9597fde: " in title?" [oojs/ui] - 10https://gerrit.wikimedia.org/r/174743 (owner: 10Esanders)
[18:33:06] <MatmaRex>	 Krenair: manual submit is disabled in VE repos
[18:33:30] <MatmaRex>	 in my opinion, this only serves to make our lives more annoying when jenkins goes bonkers
[18:33:37] <grrrit-wm>	 (03PS2) 10Esanders: Restore toolbar-bar class [oojs/ui] - 10https://gerrit.wikimedia.org/r/174743 
[18:34:10] <grrrit-wm>	 (03PS3) 10Jforrester: Follow-up Id9597fde: Restore toolbar-bar class [oojs/ui] - 10https://gerrit.wikimedia.org/r/174743 (owner: 10Esanders)
[18:34:20] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Follow-up Id9597fde: Restore toolbar-bar class [oojs/ui] - 10https://gerrit.wikimedia.org/r/174743 (owner: 10Esanders)
[18:34:36] <James_F>	 MatmaRex: Manual submit is /meant/ to be disabled in all repos.
[18:34:50] <James_F>	 MatmaRex: But no-one who cares has had time to roll it out.
[18:35:10] <MatmaRex>	 James_F: that does not change my opinion of it at all.
[18:35:12] <MatmaRex>	 :)
[18:36:08] <James_F>	 MatmaRex: Blame Krinkle. :-)
[18:40:33] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Follow-up Id9597fde: Restore toolbar-bar class [oojs/ui] - 10https://gerrit.wikimedia.org/r/174743 (owner: 10Esanders)
[18:40:52] <grrrit-wm>	 (03Merged) 10jenkins-bot: Follow-up Id9597fde: Restore toolbar-bar class [oojs/ui] - 10https://gerrit.wikimedia.org/r/174743 (owner: 10Esanders)
[18:41:08] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf9] inserting formulae gives 'TypeError: undefined is not a function' (ve.bind) - 10https://bugzilla.wikimedia.org/73627#c3 (10Rummana Yasmeen) Verified the fix in Betalabs
[18:42:25] <Krenair>	 James_F, aren't there still repos without jenkins submitting on CR+2?
[18:42:40] <grrrit-wm>	 (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (20c61ec865) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/174762 
[18:42:56] <James_F>	 Krenair: There are a couple of very odd ones, yes, but if you find one you should report it.
[18:43:08] <Krenair>	 to who?
[18:43:14] <James_F>	 Krenair: Can I grab a quick +2 on https://gerrit.wikimedia.org/r/174760 and https://gerrit.wikimedia.org/r/174762 ?
[18:43:16] <Krenair>	 Antoine/Timo?
[18:43:27] <James_F>	 Well, as of next week, in Phabricator's CI project.
[18:45:35] <Krinkle>	 Krenair: Most of the repos I actively see around me have the CR+2 restriction. Except mediawiki-core and one or two repos from the mobile team where they reverted my config change because they had important "breaking changes" to push through.
[18:45:50] <Krinkle>	 and of course all repos we don't "care about", e.g. not wmf engineering.
[18:46:09] <Krinkle>	 since the default is still to allow it
[18:46:19] <Krenair>	 yeah I don't think the one I found was wmf-engineering
[18:48:08] <wikibugs>	 3VisualEditor / 3Mobile: VisualEditor:[Regression wmf9] Editor switcher broken - 10https://bugzilla.wikimedia.org/73646 (10Rummana Yasmeen)
[18:49:02] <Krenair>	 James_F, why are you pulling this commit through on its own?
[18:49:19] <James_F>	 Krenair: To fix the regression.
[18:49:41] <Krenair>	 It doesn't say what that is
[18:50:12] <James_F>	 Krenair: "Follow-up …" is a clue. :-)
[18:50:38] <Krenair>	 oh, I read the wrong one, hah :)
[18:50:42] <James_F>	 :-)
[18:50:49] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update OOjs UI to v0.1.0-pre (20c61ec865) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/174762 (owner: 10Jforrester)
[18:51:49] * James_F sighs.
[18:52:07] <grrrit-wm>	 (03CR) 10Jforrester: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/174762 (owner: 10Jforrester)
[18:52:25] <grrrit-wm>	 (03CR) 10Alex Monk: [C: 032] Update OOjs UI to v0.1.0-pre (20c61ec865) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/174762 (owner: 10Jforrester)
[18:52:36] <James_F>	 Thanks.
[18:52:40] <Krenair>	 I'm going to have dinner. Good luck with Jenkins.
[18:52:43] <James_F>	 :-)
[18:55:42] <grrrit-wm>	 (03PS1) 10Cmcmahon: [BrowserTest] Rubocop style fixes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174764 
[18:57:07] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (20c61ec865) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/174762 (owner: 10Jforrester)
[18:58:39] <grrrit-wm>	 (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174764 (owner: 10Cmcmahon)
[18:59:27] <wikibugs>	 3MediaWiki / 3Page editing: Special-case edit conflicts where content is added to the end of a section and a new following section is inserted - 10https://bugzilla.wikimedia.org/73667 (10James Forrester) 3NEW p:3Unprio s:3enhanc a:3None From tgr on wikitech-l:  | Another low-hanging fruit would be to...
[18:59:37] <wikibugs>	 3MediaWiki / 3Page editing: Special-case edit conflicts where content is added to the end of a section and a new following section is inserted - 10https://bugzilla.wikimedia.org/73667 (10James Forrester) p:5Unprio>3Normal
[19:00:06] <grrrit-wm>	 (03Merged) 10jenkins-bot: [BrowserTest] Rubocop style fixes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174764 (owner: 10Cmcmahon)
[19:01:52] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] "Repeated unaddressed comments from earlier" (033 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166188 (owner: 10Divec)
[19:07:23] <wikibugs>	 3MediaWiki / 3Page editing: Special-case edit conflicts where content is added to the end of a section and a new following section is inserted - 10https://bugzilla.wikimedia.org/73667#c1 (10Umherirrender) Sounds a bit like bug 22783
[19:07:48] <grrrit-wm>	 (03PS1) 10Cmcmahon: [BrowserTest] more rubocop style fixes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174767 
[19:08:15] <RoanKattouw>	 Krinkle: https://gerrit.wikimedia.org/r/171499
[19:08:27] <RoanKattouw>	 Krinkle: is the thing I was talking about in the standup
[19:08:57] <RoanKattouw>	 James_F: Could you respond to Ori's comment on https://gerrit.wikimedia.org/r/#/c/171499/8/modules/ve-mw/init/ve.init.mw.trackSubscriber.js ?
[19:09:35] <RoanKattouw>	 James_F: (Also see the top-level comment he left about this
[19:10:51] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Insert last modified text as HTML [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174318 (https://bugzilla.wikimedia.org/73571) (owner: 10Alex Monk)
[19:12:07] <grrrit-wm>	 (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174767 (owner: 10Cmcmahon)
[19:12:09] <grrrit-wm>	 (03Merged) 10jenkins-bot: Insert last modified text as HTML [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174318 (https://bugzilla.wikimedia.org/73571) (owner: 10Alex Monk)
[19:13:18] <Krinkle>	 RoanKattouw: These values are all new, right? Or do they match something? preinit, switchwithout etc.
[19:13:33] <grrrit-wm>	 (03Merged) 10jenkins-bot: [BrowserTest] more rubocop style fixes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174767 (owner: 10Cmcmahon)
[19:13:52] <RoanKattouw>	 Krinkle: https://meta.wikimedia.org/wiki/Schema:Edit
[19:13:54] <Krinkle>	 Maybe list the expected values at #deactivate
[19:14:09] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: After updating a page <br /> gets added after the timestamp of last edit made on that page - 10https://bugzilla.wikimedia.org/73571 (10Alex Monk) 5PATC>3RESO/FIX
[19:14:51] <Krinkle>	 RoanKattouw: OK. Is that linked from somewhere?
[19:15:11] <RoanKattouw>	 Krinkle: Ahm, maybe not. That would be good to do
[19:15:47] <Krinkle>	 RoanKattouw: action=abort is that a query parameter somewhere? and 'action.abort.type' are those dots in property names or a nested object?
[19:16:23] <grrrit-wm>	 (03CR) 10Krinkle: Add instrumentation for edit schema (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/171499 (owner: 10Catrope)
[19:16:36] <Krinkle>	 RoanKattouw: LGTM. Testing now locally with a console subscriber
[19:16:49] <grrrit-wm>	 (03CR) 10Krinkle: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/171499 (owner: 10Catrope)
[19:16:55] <RoanKattouw>	 Krinkle: It's not a query parameter, it's a property in Schema:Edit
[19:20:17] <grrrit-wm>	 (03CR) 10Jforrester: "> This looks fine. I recommend scrapping the whole editor seniority thresholds scheme and just logging the bare edit count. If you find yo" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/171499 (owner: 10Catrope)
[19:21:23] <Krinkle>	 ve.ui.MWLinkMenuItemWidget.js:33 Uncaught TypeError: Expecting a function in instanceof check, but got undefined
[19:22:51] <grrrit-wm>	 (03PS3) 10Krinkle: Prevent JS errors when surfaceReady fires after deactivation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174357 (owner: 10Catrope)
[19:23:15] <RoanKattouw>	 Krinkle: Old code? That file doesn't have that name any more
[19:23:18] <grrrit-wm>	 (03PS3) 10Krinkle: Move tearDownBeforeUnloadHandler() to cancel() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174358 (owner: 10Catrope)
[19:23:30] <Krinkle>	 RoanKattouw: Fixed on master, but fatally broken on your patch stack
[19:23:32] <Krinkle>	 rebasing now
[19:23:35] <RoanKattouw>	 Ooh right
[19:23:45] <Krinkle>	 couldn't load any editor page
[19:23:47] <RoanKattouw>	 Because I'm based on a pre-rename VE
[19:23:53] <grrrit-wm>	 (03PS9) 10Krinkle: Add instrumentation for edit schema [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/171499 (owner: 10Catrope)
[19:24:15] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Prevent JS errors when surfaceReady fires after deactivation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174357 (owner: 10Catrope)
[19:25:42] <James_F>	 RoanKattouw: https://meta.wikimedia.org/w/index.php?title=Schema:Edit&diff=10590995&oldid=10436599
[19:28:14] <wikibugs>	 3MediaWiki / 3Page editing: Special-case edit conflicts where content is added to the end of a section and a new following section is inserted - 10https://bugzilla.wikimedia.org/73667 (10James Forrester)
[19:28:14] <wikibugs>	 3MediaWiki / 3Page editing: edit conflict while editing the last section of a page - 10https://bugzilla.wikimedia.org/22783 (10James Forrester)
[19:28:14] <wikibugs>	 3MediaWiki / 3Page editing: Special-case edit conflicts where content is added to the end of a section and a new following section is inserted - 10https://bugzilla.wikimedia.org/73667#c2 (10James Forrester) (In reply to Umherirrender from comment #1) > Sounds a bit like bug 22783  Yes, but this would occur f...
[19:30:15] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 04-1] "1. Dropping anything other than an item in the same list throws an exception - this needs to be resilient to dropping items from other lis" [oojs/ui] - 10https://gerrit.wikimedia.org/r/172325 (owner: 10Mooeypoo)
[19:30:17] <grrrit-wm>	 (03CR) 10Jforrester: [C: 031] Fix ridiculously small font size in overlays under MonoBook [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174742 (https://bugzilla.wikimedia.org/73660) (owner: 10Alex Monk)
[19:46:38] <grrrit-wm>	 (03PS1) 10Jforrester: Follow-up I7eb0d0e: ve.ui.MobileContext.css doesn't exist any more, Toto [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174779 (https://bugzilla.wikimedia.org/73646) 
[19:48:08] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Follow-up I7eb0d0e: ve.ui.MobileContext.css doesn't exist any more, Toto [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174779 (https://bugzilla.wikimedia.org/73646) (owner: 10Jforrester)
[19:48:39] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] Remove CSS hack for positioning popupButtonWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/174700 (owner: 10Esanders)
[19:48:45] <grrrit-wm>	 (03PS1) 10Jforrester: Follow-up I7eb0d0e: ve.ui.MobileContext.css doesn't exist any more, Toto [extensions/VisualEditor] (wmf/1.25wmf9) - 10https://gerrit.wikimedia.org/r/174781 
[19:49:00] <James_F>	 RoanKattouw: ^^^ +2?
[19:49:06] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] Give help content box a reasonable line height for legibility [oojs/ui] - 10https://gerrit.wikimedia.org/r/174692 (owner: 10Esanders)
[19:49:32] <grrrit-wm>	 (03Merged) 10jenkins-bot: Follow-up I7eb0d0e: ve.ui.MobileContext.css doesn't exist any more, Toto [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174779 (https://bugzilla.wikimedia.org/73646) (owner: 10Jforrester)
[19:49:36] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Follow-up I7eb0d0e: ve.ui.MobileContext.css doesn't exist any more, Toto [extensions/VisualEditor] (wmf/1.25wmf9) - 10https://gerrit.wikimedia.org/r/174781 (owner: 10Jforrester)
[19:51:13] <grrrit-wm>	 (03Merged) 10jenkins-bot: Follow-up I7eb0d0e: ve.ui.MobileContext.css doesn't exist any more, Toto [extensions/VisualEditor] (wmf/1.25wmf9) - 10https://gerrit.wikimedia.org/r/174781 (owner: 10Jforrester)
[19:53:36] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove CSS hack for positioning popupButtonWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/174700 (owner: 10Esanders)
[19:53:43] <grrrit-wm>	 (03Merged) 10jenkins-bot: Give help content box a reasonable line height for legibility [oojs/ui] - 10https://gerrit.wikimedia.org/r/174692 (owner: 10Esanders)
[19:59:36] <TrevorParscal>	 edsanders|away: so, https://gerrit.wikimedia.org/r/#/c/174688/2
[19:59:45] <TrevorParscal>	 let me know when you are back, I have questions
[20:00:08] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] Fix ridiculously small font size in overlays under MonoBook [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174742 (https://bugzilla.wikimedia.org/73660) (owner: 10Alex Monk)
[20:01:26] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix ridiculously small font size in overlays under MonoBook [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174742 (https://bugzilla.wikimedia.org/73660) (owner: 10Alex Monk)
[20:03:22] <grrrit-wm>	 (03PS1) 10Jforrester: Fix ridiculously small font size in overlays under MonoBook [extensions/VisualEditor] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/174788 
[20:03:34] <grrrit-wm>	 (03PS1) 10Jforrester: Fix ridiculously small font size in overlays under MonoBook [extensions/VisualEditor] (wmf/1.25wmf9) - 10https://gerrit.wikimedia.org/r/174789 
[20:03:42] <James_F>	 RoanKattouw: ^^ +2s please?
[20:04:08] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression wmf7] Text in dialog boxes is too small in Monobook - 10https://bugzilla.wikimedia.org/73660 (10James Forrester) 5PATC>3RESO/FIX
[20:04:15] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Fix ridiculously small font size in overlays under MonoBook [extensions/VisualEditor] (wmf/1.25wmf9) - 10https://gerrit.wikimedia.org/r/174789 (owner: 10Jforrester)
[20:04:21] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Fix ridiculously small font size in overlays under MonoBook [extensions/VisualEditor] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/174788 (owner: 10Jforrester)
[20:05:46] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix ridiculously small font size in overlays under MonoBook [extensions/VisualEditor] (wmf/1.25wmf9) - 10https://gerrit.wikimedia.org/r/174789 (owner: 10Jforrester)
[20:08:52] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix ridiculously small font size in overlays under MonoBook [extensions/VisualEditor] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/174788 (owner: 10Jforrester)
[20:18:37] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: z-index of toolbar and dialog in core - 10https://bugzilla.wikimedia.org/73650 (10Rummana Yasmeen) 5PATC>3RESO/FIX
[20:30:54] <wikibugs>	 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression wmf9] VisualEditor fails to load (ve.ui.MobileContext.css not defined?) - 10https://bugzilla.wikimedia.org/73646#c6 (10James Forrester) 5PATC>3RESO/FIX p:5Unprio>3High s:5normal>3critic a:3James Forrester Fixed in master; backport schedu...
[20:34:38] <Krinkle>	 RoanKattouw_away: Clicking "Read' triggers event.Edit three times (action=init, action=ready, action=abort)
[20:34:47] <Krinkle>	 Is that expected?
[20:36:22] <grrrit-wm>	 (03CR) 10Krinkle: "Logged data looks like this. The undefined properties look strange. http://i.imgur.com/eAsrXSo.png" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/171499 (owner: 10Catrope)
[20:44:11] <wikibugs>	 3VisualEditor: VisualEditor:  When I click the Save button, please take my cursor out of the main text and focus it in the Save dialog - 10https://bugzilla.wikimedia.org/73675 (10WhatamIdoing) 3NEW p:3Unprio s:3normal a:3None Goal:  Save page with edit summary "Copyedit".   (Almost) result:  Save page...
[20:45:49] <grrrit-wm>	 (03PS1) 10Alex Monk: Use localStorage to store ve-beta-welcome-dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174798 (https://bugzilla.wikimedia.org/62884) 
[21:11:00] <RoanKattouw>	 Krinkle: You clicked Edit, then Read?
[21:11:06] <Krinkle>	 Yep
[21:11:11] <RoanKattouw>	 init means "the editor started loading"
[21:11:18] <RoanKattouw>	 ready means "the editor is done loading and the user can interact with it now"
[21:11:22] <Krinkle>	 mw.trackSubscribe('', function (topic, data) {
[21:11:22] <Krinkle>	  console.log('[mw.track] ' + topic, data);
[21:11:22] <Krinkle>	 });
[21:11:26] <RoanKattouw>	 abort means "the user exited the editor without saving"
[21:11:27] <Krinkle>	 in Common.js
[21:12:29] <RoanKattouw>	 Hah, undefined timing is weird
[21:12:43] <Krinkle>	 RoanKattouw: nvm the tripple log burst at the end
[21:12:51] <Krinkle>	 it looked like that was the logs from the prevoous page load were still there
[21:12:52] <Krinkle>	 http://i.imgur.com/uEmkh3p.png
[21:12:52] <RoanKattouw>	 Yeah I know why some of these things are undefined, I should fix that
[21:13:09] <RoanKattouw>	 OK yeah that looks good
[21:13:10] <Krenair>	 Hi TrevorParscal 
[21:13:16] <RoanKattouw>	 The abort event should have mechanism=navigate-read
[21:13:45] <RoanKattouw>	 And type=nochange I think
[21:13:46] <grrrit-wm>	 (03CR) 10Krinkle: "Nevermind the three events supposedly fired at once when switching to Read mode. That was misinterpreted. http://i.imgur.com/uEmkh3p.png" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/171499 (owner: 10Catrope)
[21:13:59] <Krinkle>	 RoanKattouw: mechanism undefined
[21:14:17] <RoanKattouw>	 Oh but action.abort.mechanism should be defined?
[21:14:27] <RoanKattouw>	 There's some strange mapping going on there to fit the schema
[21:15:28] <TrevorParscal>	 Krenair: howdy
[21:16:34] <Krinkle>	 RoanKattouw: I can log the full object if you like but i think you've got it, right?
[21:16:40] <Krinkle>	 is this a bug?
[21:17:05] <RoanKattouw>	 The undefined properties are kind of a bug, yeah
[21:17:45] <RoanKattouw>	 I mean eventually this is going to be validated against the schema by EventLogging
[21:17:55] <RoanKattouw>	 But it's unclean to have undefined stuff there
[21:18:15] <Krinkle>	 RoanKattouw: https://gist.github.com/Krinkle/a014e0d637bb79c578bb
[21:18:15] <grrrit-wm>	 (03PS10) 10Catrope: Add instrumentation for edit schema [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/171499 
[21:18:35] <Krenair>	 TrevorParscal, ... actually I think I can work this out, sorry for bothering you
[21:19:05] <RoanKattouw>	 Krinkle: Yup. PS10 should kill the undefined properties, read the PS9..10 diff and the code immediately above the changed code to see what was going on
[21:19:42] <Krenair>	 although it may not end with nice code :/
[21:25:08] <Krinkle>	 RoanKattouw: The $.extend call in trackSubscriberAll, that doesn't add properties, right? It only overrides some?
[21:25:31] <Krinkle>	 Because I don't think event data objects should be composed in different code paths. Should be a straight object passed to track()
[21:27:43] <RoanKattouw>	 Krinkle: It adds a lot of properties like version, editor, integration, user.id, etc.
[21:27:50] <RoanKattouw>	 Basically it defines the default set
[21:28:29] <James_F>	 ryasmeen: https://www.mediawiki.org/wiki/Editing/Phabricator_project_plan
[21:28:47] <ryasmeen>	 Thanks James_F
[21:30:59] <Krenair>	 TrevorParscal, okay what I was hoping would work.. doesn't, quite.
[21:31:17] <Krenair>	 basically for https://gerrit.wikimedia.org/r/#/c/169976/ I need to run some code once the user has decided to retry
[21:31:29] <Krenair>	 /continue
[21:31:51] <Krenair>	 but before it actually retries
[21:32:18] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: LinkTargetInputWidget: Update for #sanitizeValue → #cleanUpValue OOUI change [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/174814 (https://bugzilla.wikimedia.org/73156) 
[21:32:20] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: [BREAKING CHANGE] Rename InputWidget#sanitizeValue → #cleanUpValue [oojs/ui] - 10https://gerrit.wikimedia.org/r/174815 (https://bugzilla.wikimedia.org/73156) 
[21:32:27] <Krenair>	 so I can set some properties in VPT
[21:36:23] <Krenair>	 ... could override onRetryButtonClick in MWSaveDialog and emit an event, I guess
[21:51:11] <Krinkle>	 RoanKattouw: 'version' and 'user.id' area alreayd in the first parameter objet to $.extend thee
[21:51:14] <Krinkle>	 I mean the second parameter
[21:51:27] <RoanKattouw>	 Ahm I don't think that's adding anything no
[21:51:30] <Krinkle>	 It's important that the event object is declared in one place and not some random properties that may or may not be added
[21:51:42] <Krinkle>	 makes it easier to check etc.
[21:52:17] <Krinkle>	 Making dinner in an unknown apartment with a too tiny kitchen that's missing half the cooking essentials I expected.
[21:52:25] <Krinkle>	 #stuff you don't realise is missing until you're half-way cooking
[21:52:33] <Krinkle>	 Can't open the tin can without a pull tab.
[21:52:35] <Krinkle>	 :P
[21:52:49] <Krinkle>	 Luckily I got two from different brands (wanted to try them) and the other does have a pull
[21:53:08] <Krinkle>	 (There's no can opener.)
[21:59:08] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression wmf7] Text in dialog boxes is too small in Monobook - 10https://bugzilla.wikimedia.org/73660#c4 (10etonkovidova) Checked in betalabs useskin=monobook: it seems that vi-ui-overlay 127%; when applied to text in dialogs still gets overwritten wit...
[22:06:57] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: After updating a page <br /> gets added after the timestamp of last edit made on that page - 10https://bugzilla.wikimedia.org/73571#c4 (10etonkovidova) Verified the fix in betalabs and test2.
[22:10:27] <MatmaRex>	 aw bloody hell, php
[22:10:33] <MatmaRex>	 Fatal error: Method OOUI\Tag::__toString() must not throw an exception in /var/www/wiki/oojs/ui/php/Tag.php on line 0
[22:10:47] * MatmaRex copy-pastes some magic code
[22:11:33] <TrevorParscal>	 MatmaRex: PHP got ya down?
[22:12:10] <MatmaRex>	 it's got me up in arms
[22:14:56] <TrevorParscal>	 so, there's an error because we threw an error?
[22:14:59] <TrevorParscal>	 that's INSANE
[22:15:06] <RoanKattouw>	 Welcome to PHP
[22:15:26] <RoanKattouw>	 PHP also throws warnings if you throw an exception from within an array_map() callback
[22:15:37] <TrevorParscal>	 if they are throwing an error because we threw an error inside of __toString() then CLEARLY you CAN throw and error from __toString()
[22:15:38] <RoanKattouw>	 Even though the exception bubbles up the way you expect and is caught by the calling code
[22:15:41] <TrevorParscal>	 they just did it!
[22:17:14] <TrevorParscal>	 this always ends up being "well, because we didn't implement X correctly, it leaks memory when Y happens so we just don't allow Y to happen and call it a day
[22:17:39] <wikibugs>	 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression wmf9] VisualEditor fails to load (ve.ui.MobileContext.css not defined?) - 10https://bugzilla.wikimedia.org/73646#c7 (10etonkovidova) Checked the fix in betalabs - switching between Editor and Edit source works.
[22:18:25] <TrevorParscal>	 "PHP, it's usually good enough"
[22:27:43] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: PHP: Add missing OOUI\Exception class [oojs/ui] - 10https://gerrit.wikimedia.org/r/174833 
[22:27:46] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: PHP: Wrap __toString() in try-catch to avoid unhelpful fatals [oojs/ui] - 10https://gerrit.wikimedia.org/r/174834 
[22:27:47] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: PHP: Reject malformed and potentially evil input when outputting HTML [oojs/ui] - 10https://gerrit.wikimedia.org/r/174835 (https://bugzilla.wikimedia.org/73156) 
[22:28:01] <MatmaRex>	 TrevorParscal: https://gerrit.wikimedia.org/r/174834
[22:28:36] <MatmaRex>	 also, i discovered that i did actually botch the prefix-to-namespace migration, see https://gerrit.wikimedia.org/r/174833 . that was too good to be true.
[22:30:44] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] PHP: Reject malformed and potentially evil input when outputting HTML [oojs/ui] - 10https://gerrit.wikimedia.org/r/174835 (https://bugzilla.wikimedia.org/73156) (owner: 10Bartosz Dziewoński)
[22:33:54] <MatmaRex>	 phpcs is a dick
[22:33:55] <wikibugs>	 3OOjs UI / 3Technical Debt: OOUI: Get rid of inline styles in LabelElement - 10https://bugzilla.wikimedia.org/73677 (10Bartosz Dziewoński) 3NEW p:3Unprio s:3normal a:3None We should get rid of inline styles in LabelElement.  this.$label.css( 'display', !label ? 'none' : '' );  $this->target->setAttri...
[22:37:50] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] PHP: Add missing OOUI\Exception class [oojs/ui] - 10https://gerrit.wikimedia.org/r/174833 (owner: 10Bartosz Dziewoński)
[22:41:21] <TrevorParscal>	 MatmaRex: lol
[22:41:36] <grrrit-wm>	 (03PS2) 10Bartosz Dziewoński: PHP: Reject malformed and potentially evil input when outputting HTML [oojs/ui] - 10https://gerrit.wikimedia.org/r/174835 (https://bugzilla.wikimedia.org/73156) 
[22:42:09] <edsanders>	 TrevorParscal, zIndexes?
[22:42:22] <TrevorParscal>	 edsanders: so, yes
[22:42:25] <TrevorParscal>	 that commit looks great
[22:42:26] <edsanders>	 RoanKattouw, James_F are travel around?
[22:42:37] <TrevorParscal>	 did you try it in vemw
[22:42:41] <TrevorParscal>	 on vector and monobook
[22:42:48] <edsanders>	 vector yes
[22:42:56] <TrevorParscal>	 my worry is that it may need to have a companion patch for monobook (specifically)
[22:42:56] <edsanders>	 zIndex 100 was the vector hack
[22:43:02] <TrevorParscal>	 yeah
[22:43:09] <edsanders>	 My thinking was that nothing overlaps the toolbar
[22:43:25] <edsanders>	 and vector already bumps the global overlay to 101
[22:43:46] <edsanders>	 also I was confused about the .ve-ui-overlay * { z-index... rule
[22:44:00] <edsanders>	 that seems hacky enough to warrant a comment at least
[22:44:35] <Krinkle>	 RoanKattouw: Which ones are supposed to end up in EventLogging?
[22:44:56] <RoanKattouw>	 Which properties you mean?
[22:45:07] <Krinkle>	 RoanKattouw: Of event.Edit action=init/ready/abort and various ve.performance.* only event.Edit and action=init ends up in EventLOgging for me
[22:45:18] <Krinkle>	 RoanKattouw: I've got EvetnLogging and WikimediaEvents installed locally (latest master()
[22:45:32] <Krinkle>	 with $wgEventLoggingBaseUri = 'http://127.0.0.1:8080/event.gif';  and  nc -k -l 8080
[22:45:43] <RoanKattouw>	 Krinkle: Do you know about eventlogging-devserver?
[22:45:52] <Krinkle>	 The only one logged is GET /event.gif?%7B%22event%22%3A%7B%22version%22%3A1%2C%22action%22%3A%22init
[22:46:17] <RoanKattouw>	 I'd rather you use that than netcat
[22:46:20] <Krinkle>	 Checking now
[22:46:23] <Krinkle>	 $ ./server/bin/eventlogging-devserver  
[22:46:25] <RoanKattouw>	 I use that locally and it works for me
[22:46:32] <Krinkle>	 No module named eventlogging
[22:46:50] <Krinkle>	 guess I have to intall something, checking.. just a moment
[22:46:55] <Krinkle>	 isn't gonna make a difference though
[22:47:09] <Krinkle>	 if bare nc doesn't even see it, it's not gonna produce more data with that server
[22:47:17] <Krinkle>	 so it probably ends up being caught as invalid event
[22:47:48] <RoanKattouw>	 IME bare nc sometimes drops things after the first thing
[22:47:50] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] PHP: Wrap __toString() in try-catch to avoid unhelpful fatals [oojs/ui] - 10https://gerrit.wikimedia.org/r/174834 (owner: 10Bartosz Dziewoński)
[22:47:53] <grrrit-wm>	 (03CR) 10Legoktm: "recheck" [oojs/ui] - 10https://gerrit.wikimedia.org/r/174833 (owner: 10Bartosz Dziewoński)
[22:47:56] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] PHP: Add missing OOUI\Exception class [oojs/ui] - 10https://gerrit.wikimedia.org/r/174833 (owner: 10Bartosz Dziewoński)
[22:48:05] <RoanKattouw>	 And eventlogging-devserver still shows invalid events with "clientValidated":false
[22:48:32] <Krinkle>	 RoanKattouw: How do I make that work? README says to install various packages including mysql but this hsouldn't require that
[22:48:38] <Krinkle>	 eventlogging is in the same directory right?
[22:49:06] <RoanKattouw>	 Hold on let me find the docs I used
[22:49:11] <wikibugs>	 3OOjs UI / 3Technical Debt: OOUI: Get rid of inline styles in LabelElement - 10https://bugzilla.wikimedia.org/73677#c1 (10Bartosz Dziewoński) (In reply to Bartosz Dziewoński from comment #0) > Trevor Parscal <tparscal@wikimedia.org> wrote: > > I think this is dumb, it should be done by removing oo-ui-labeled...
[22:49:32] <RoanKattouw>	 Krinkle: https://www.mediawiki.org/wiki/Extension:EventLogging/Guide#Installing_the_EventLogging_devserver
[22:49:45] <RoanKattouw>	 Looks like you were just missing step 3
[22:50:00] <RoanKattouw>	 OK... so....
[22:50:07] <Krinkle>	 Ah, do just python setup.py install
[22:50:15] <Krinkle>	 that isn't in the readme
[22:50:16] <Krinkle>	 OK :)
[22:50:24] <grrrit-wm>	 (03CR) 10Jforrester: [C: 031] [BREAKING CHANGE] Rename InputWidget#sanitizeValue → #cleanUpValue [oojs/ui] - 10https://gerrit.wikimedia.org/r/174815 (https://bugzilla.wikimedia.org/73156) (owner: 10Bartosz Dziewoński)
[22:50:26] <RoanKattouw>	 For whatever strange reason, https://gerrit.wikimedia.org/r/#/c/171823/ is causing our bug with typing in Firefox
[22:50:40] <RoanKattouw>	 Whereby surface B is focused, but key events are going to surface A
[22:50:47] <RoanKattouw>	 while the characters typed go into B
[22:52:23] <wikibugs>	 3OOjs UI / 3Technical Debt: OOjs UI: Get rid of inline styles in LabelElement - 10https://bugzilla.wikimedia.org/73677 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal s:5normal>3enhanc
[22:52:37] <wikibugs>	 3OOjs UI / 3Technical Debt: OOUI: It's unclear which class members (properties) are public/private/internal - 10https://bugzilla.wikimedia.org/72578 (10James Forrester) s:5minor>3enhanc
[22:52:49] <James_F>	 RoanKattouw: Huh.
[22:53:00] <James_F>	 RoanKattouw: Focus going wrong?
[22:53:23] <RoanKattouw>	 Dude
[22:53:26] <RoanKattouw>	 B is focused
[22:53:30] <RoanKattouw>	 When I type, characters appear in B
[22:53:37] <RoanKattouw>	 but the keydown events that are emitted go to A
[22:53:55] <grrrit-wm>	 (03Merged) 10jenkins-bot: PHP: Add missing OOUI\Exception class [oojs/ui] - 10https://gerrit.wikimedia.org/r/174833 (owner: 10Bartosz Dziewoński)
[22:54:04] <Krinkle>	 RoanKattouw: OK. Recieved Edit: init+ready, Read: abort
[22:54:15] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] PHP: Wrap __toString() in try-catch to avoid unhelpful fatals [oojs/ui] - 10https://gerrit.wikimedia.org/r/174834 (owner: 10Bartosz Dziewoński)
[22:54:22] <Krinkle>	 I guess ve.* is not logged at the moment via WikimediaEvents?
[22:54:29] <Krinkle>	 the performance thingies
[22:54:33] <James_F>	 Krinkle: They are.
[22:54:43] <James_F>	 Krinkle: But not the "behaviour" ones, I think.
[22:54:56] <Krinkle>	 ve.performance.system.domLoad ve.performance.system.activation 
[22:54:58] <Krinkle>	 those?
[22:55:11] * James_F looks at Graphite.
[22:55:56] <RoanKattouw>	 Krinkle: Those are logged via the TimingData schema
[22:56:01] <RoanKattouw>	 In the TimingData extension I think?
[22:56:08] <James_F>	 Krinkle: Yes.
[22:56:09] <RoanKattouw>	 It was somewhere in a weird place
[22:56:11] <TrevorParscal>	 MatmaRex: heads up, Roan and I discussed this http://etherpad.wikimedia.org/p/GroupSelectOption
[22:56:31] <TrevorParscal>	 I am planning on getting to it in the next couple of work days
[22:56:35] <TrevorParscal>	 but, something to be aware of
[22:56:40] <Krinkle>	 There is a TimingData extension?
[22:56:50] <RoanKattouw>	 Maybe?
[22:56:51] <James_F>	 Krinkle: ve.performance.system.domLoad.median appears in Graphite.
[22:57:10] <Krinkle>	 James_F: I'll check master to see if that one's emitting it locally
[22:57:11] <RoanKattouw>	 No, there isn't
[22:57:13] <RoanKattouw>	 Ahm
[22:57:36] <RoanKattouw>	 Krinkle: No the TimingData stuff is in WikimediaEvents
[22:57:53] <James_F>	 Krinkle: Hovers around 15s, down over the past few weeks a little but not much.
[22:57:58] <RoanKattouw>	 Krinkle: See ext.wikimediaEvents.ve.js
[22:58:08] <MatmaRex>	 TrevorParscal: i'm not entirely sure what that's about, but it… doesn't sound unreasonable? :)
[22:58:32] <TrevorParscal>	 well, right now, all items in a selectwidget must have unique data
[22:58:35] <TrevorParscal>	 and must have data
[22:58:45] <TrevorParscal>	 so, it's a required argument
[22:59:35] <TrevorParscal>	 this causes confusion because the data argument is easy to forget, the options that follow it are indistinguishable from data since data can be anything
[22:59:42] <TrevorParscal>	 and the options are optional
[22:59:49] <Krinkle>	 RoanKattouw: It's not ending up in eventlogging for me. Not on master and not with your patch
[22:59:51] <TrevorParscal>	 plus, the idea that all items will have unique data is silly
[23:00:45] <Krinkle>	 mw.loader.getState('schema.TimingData') // registered
[23:00:47] <TrevorParscal>	 so, we are going to remove that assumption/restriction, and implement {data:...}/.data/getData() on Widget instead of option, make it optional, and do other things as described in the etherpad
[23:00:50] <Krinkle>	 looks like it isn't being triggered
[23:02:46] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] "C'mon npm." [oojs/ui] - 10https://gerrit.wikimedia.org/r/174834 (owner: 10Bartosz Dziewoński)
[23:06:40] <grrrit-wm>	 (03Merged) 10jenkins-bot: PHP: Wrap __toString() in try-catch to avoid unhelpful fatals [oojs/ui] - 10https://gerrit.wikimedia.org/r/174834 (owner: 10Bartosz Dziewoński)
[23:07:38] <James_F>	 Yay.
[23:09:39] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor:  When I click the Save button, please take my cursor out of the main text and focus it in the Save dialog - 10https://bugzilla.wikimedia.org/73675#c1 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal s:5normal>3enhanc a:3Alex Monk Is this a r...
[23:10:46] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: LabelElement: Kill inline styles [oojs/ui] - 10https://gerrit.wikimedia.org/r/174844 (https://bugzilla.wikimedia.org/73156) 
[23:11:31] <MatmaRex>	 TrevorParscal: that indeed sounds sensible to me
[23:11:55] <James_F>	 MatmaRex: Work for /after/ OOUI-PHP is in MW-core. :-)
[23:11:57] <MatmaRex>	 TrevorParscal: can you give ^ a look? it seems that we can just kill this code with no ill effects, am i missing something?
[23:12:04] <grrrit-wm>	 (03CR) 10Krinkle: PHP: Wrap __toString() in try-catch to avoid unhelpful fatals (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/174834 (owner: 10Bartosz Dziewoński)
[23:13:27] <MatmaRex>	 Krinkle: ugh. hm
[23:13:47] <MatmaRex>	 Krinkle: the nested additional try-catch is my mistake, left it in from debugging :/ sorry
[23:14:21] <MatmaRex>	 Krinkle: i did mean to trigger E_USER_ERROR - i think we do want a fatal error in this case, it's just that the one that would otherwise happen has no information in the error message
[23:15:20] <Krinkle>	 James_F: https://www.mediawiki.org/w/index.php?title=Extension:EventLogging/Guide&veaction=edit&vesection=5 - the <pre> is rendering like plain text , that looks like a bad bug
[23:15:30] <MatmaRex>	 Krinkle: i'm not sure why it would ever throw an exception, unless you have an error handler set up for that
[23:16:38] <Krinkle>	 MatmaRex: then why try/catch a single call to trigger_error?
[23:16:50] <Krinkle>	 James_F: screenshots (read mode vs. edit mode) :  http://i.imgur.com/3ap7uLB.png http://i.imgur.com/4ibN6DI.png
[23:17:03] <Krinkle>	 this is my quick letting-you-know while levels deep in other stuff
[23:17:11] <James_F>	 Krinkle: Thanks. Will file with Parsoid.
[23:17:11] <MatmaRex>	 Krinkle: no reason, that was committed accidentally, thanks for catching. i am just confused by the rest of your comment.
[23:18:06] <Krinkle>	 MatmaRex: error level "notice" and "warning" are called "errors" in php , error level "error" is an exception.
[23:18:12] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: Remove accidental double try-catch from 76800b47 [oojs/ui] - 10https://gerrit.wikimedia.org/r/174846 
[23:18:19] <Krinkle>	 It's imho rather unusual to trigger an error with an exceptoin error level
[23:18:28] <Krinkle>	 should be a warnign, or throw a regular exception
[23:18:35] <MatmaRex>	 Krinkle: how so? errors and exceptions are different beasts, aren't they?
[23:18:51] <Krinkle>	 http://php.net/manual/en/errorfunc.constants.php
[23:18:54] <Krinkle>	 yes, but no.
[23:19:23] <MatmaRex>	 Krinkle: there's not a word about exceptions on that page.
[23:19:43] <Krinkle>	 "Fatal" "can not be recovered from"  "Execution of the script is halted"
[23:19:46] <Krinkle>	 aka exeption
[23:19:50] <MatmaRex>	 there are errors, among which are fatal errors; and there are exceptions. both fatal errors and exceptions stop execution of the script, unless handled/caught.
[23:20:02] <Krinkle>	 Yes
[23:20:27] <MatmaRex>	 exceptions are not errors, though. triggering an error doesn't raise an exception.
[23:20:30] <Krinkle>	 I don't see any value in triggering a non-fatal error with the error code that is reserved/intended for fatal errors.
[23:20:42] <Krinkle>	 php is stupid for allowing this
[23:21:22] <Krinkle>	 I'm referring to passing E_USER_ERROR to trigger_error. 
[23:21:25] <Krinkle>	 That's weird.
[23:21:48] <MatmaRex>	 Krinkle: there already *is* a fatal error happening in that code, if __toString() throws an exception; the code just triggers a different one. i think we should stop script execution in this case.
[23:21:52] <Krinkle>	 any php function php ships or that we write in mediawiki afaik either emits a notice or warning, or throws an exception. it doesn't emit a non-fatal fatal error.
[23:22:08] <Krinkle>	 MatmaRex: I'm aware of that. I'm leaving it at this
[23:22:15] <Krinkle>	 I hope it's useful.
[23:24:53] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "https://gerrit.wikimedia.org/r/#/c/174846/" [oojs/ui] - 10https://gerrit.wikimedia.org/r/174834 (owner: 10Bartosz Dziewoński)
[23:27:02] <Krinkle>	 RoanKattouw: Feel like tackling https://bugzilla.wikimedia.org/show_bug.cgi?id=73556 at some point? translatewiki suspects our minifier might be corrupting javascript in some cases
[23:27:18] <Krinkle>	 the state machine is a big magical to me. You're probably faster at this.
[23:38:51] <grrrit-wm>	 (03PS60) 10Paladox: WikiEditor: Convert .css to .less and also fixes SVG issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) 
[23:39:02] <grrrit-wm>	 (03PS61) 10Paladox: WikiEditor: Convert .css to .less and also fixes SVG issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) 
[23:39:18] <RoanKattouw>	 Krinkle: I'm neck-deep in figuring out a really weird Firefox bug right now
[23:39:37] <Krinkle>	 RoanKattouw: it's not high prio, but do you want to 'take' the bug?
[23:39:44] <Krinkle>	 self-assign (or have James_F remind you)
[23:39:46] <RoanKattouw>	 Krinkle: I would be willing to look into state machine stuff but only if there's a clear, reproducible, small test case
[23:39:54] <RoanKattouw>	 Right now it doesn't sound like there is one
[23:39:59] <Krinkle>	 OK. I'll get a test cae
[23:40:11] <RoanKattouw>	 Ooh it's a warning, interesting
[23:40:43] <RoanKattouw>	 OK your comment #1 there is perfect
[23:40:51] <RoanKattouw>	 Your observations are probably correct, and you asked for the right informatoin
[23:41:39] <wikibugs>	 3MediaWiki / 3ResourceLoader: PHP Notice: Uninitialized string offset: includes/libs/JavaScriptMinifier.php on line 571 - 10https://bugzilla.wikimedia.org/73556#c2 (10Krinkle) @Nemo: Can you help get a test case? By getting a stack trace we'll narrow down whehter this is from a file module, wiki module or ot...
[23:47:08] <Krinkle>	 Nice. Queen's "Machines" makes an odd reference to Random Access Memory
[23:47:17] <Krinkle>	 RAM emergency :)
[23:49:27] <wikibugs>	 3MediaWiki / 3ResourceLoader: PHP Notice: Uninitialized string offset: includes/libs/JavaScriptMinifier.php on line 571 - 10https://bugzilla.wikimedia.org/73556 (10James Forrester) 5NEW>3ASSI a:3Roan Kattouw
[23:52:39] <RoanKattouw>	 Krinkle: Thanks
[23:52:47] <RoanKattouw>	 Once more information is available I'd be happy to look at tit
[23:54:40] <RoanKattouw>	 *it
[23:56:16] <grrrit-wm>	 (03PS25) 10Paladox: WikiEditor: Convert .css to .less and add SVG [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151616 
[23:56:27] <grrrit-wm>	 (03PS26) 10Paladox: WikiEditor: Convert .css to .less and add SVG [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151616 
[23:56:43] <grrrit-wm>	 (03PS1) 10Catrope: Revert "Followup ca6a16f: use parent selector both for hiding and showing windows" [oojs/ui] - 10https://gerrit.wikimedia.org/r/174859 
[23:56:50] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Revert "Followup ca6a16f: use parent selector both for hiding and showing windows" [oojs/ui] - 10https://gerrit.wikimedia.org/r/174859 (owner: 10Catrope)
[23:58:17] <James_F>	 RoanKattouw: https://gerrit.wikimedia.org/r/174858 is for wmf8.
[23:58:25] <James_F>	 RoanKattouw: https://gerrit.wikimedia.org/r/174860 for wmf9.
[23:59:46] <grrrit-wm>	 (03Merged) 10jenkins-bot: Revert "Followup ca6a16f: use parent selector both for hiding and showing windows" [oojs/ui] - 10https://gerrit.wikimedia.org/r/174859 (owner: 10Catrope)