[00:01:47] <grrrit-wm>	 (03PS1) 10Catrope: Revert "Show the modal overlay as soon as openWindow is called" [oojs/ui] - 10https://gerrit.wikimedia.org/r/174863 (https://bugzilla.wikimedia.org/73625) 
[00:01:58] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Revert "Show the modal overlay as soon as openWindow is called" [oojs/ui] - 10https://gerrit.wikimedia.org/r/174863 (https://bugzilla.wikimedia.org/73625) (owner: 10Catrope)
[00:02:55] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression ?pre-wmf8] Typing inside dialog surfaces for the first time in a session: the letters gets garbled and "Insert" button remains disabled in Firefox - 10https://bugzilla.wikimedia.org/73625#c3 (10James Forrester) 5PATC>3RESO/FIX Going out in the SWA...
[00:04:43] <grrrit-wm>	 (03Merged) 10jenkins-bot: Revert "Show the modal overlay as soon as openWindow is called" [oojs/ui] - 10https://gerrit.wikimedia.org/r/174863 (https://bugzilla.wikimedia.org/73625) (owner: 10Catrope)
[00:07:17] <kaldari>	 RoanKattouw: Moved them to the correct Friday :P
[00:07:40] <wikibugs>	 3VisualEditor / 3Language: "Insert reference list" button partially hides "Reference list" heading in reference list dialog box - 10https://bugzilla.wikimedia.org/69396#c1 (10etonkovidova) 5UNCO>3RESO/WOR Most likely the problem was that a label for Insert has several words. Checked Iloko, Dutch, Portugu...
[00:07:54] <kaldari>	 RoanKattouw: Max already deployed the non-config change during the mobnile window
[00:08:03] <kaldari>	 so it's marked as done
[00:08:05] <RoanKattouw>	 Oh OK
[00:08:37] <kaldari>	 RoanKattouw: ack. Lemme fix that patch...
[00:09:52] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression ?pre-wmf8] Typing inside dialog surfaces for the first time in a session: the letters gets garbled and "Insert" button remains disabled in Firefox - 10https://bugzilla.wikimedia.org/73625#c5 (10Rummana Yasmeen) Verified the fix in Betalabs
[00:11:38] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor:  When I click the Save button, please take my cursor out of the main text and focus it in the Save dialog - 10https://bugzilla.wikimedia.org/73675#c2 (10Alex Monk) Worksforme...
[00:11:57] <kaldari>	 RoanKattouw: patch fixed
[00:12:27] <grrrit-wm>	 (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (d4cfcce969) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/174867 
[00:18:23] <James_F>	 Krenair: Could I grab +2s on https://gerrit.wikimedia.org/r/#/q/I317b4a747389de35411aca4ffdbbc2306b5b74cc,n,z if you've free? :-)
[00:22:59] <Krenair>	 James_F, why are those PHP changes mentioned in the commit message?
[00:23:33] <James_F>	 Krenair: The script pulls the whole git log.
[00:23:42] <James_F>	 Krenair: In future, the script will also sync the PHP.
[00:24:22] <wikibugs>	 3VisualEditor / 3Editing Tools: "Insert reference list" button partially hides "Reference list" heading in reference list dialog box - 10https://bugzilla.wikimedia.org/69396 (10James Forrester)
[00:26:39] <grrrit-wm>	 (03CR) 10Alex Monk: [C: 032] Update OOjs UI to v0.1.0-pre (d4cfcce969) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/174867 (owner: 10Jforrester)
[00:34:41] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (d4cfcce969) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/174867 (owner: 10Jforrester)
[01:08:37] <grrrit-wm>	 (03PS1) 10Trevor Parscal: [BREAKING CHANGE] Allow options with similar data [oojs/ui] - 10https://gerrit.wikimedia.org/r/174886 
[01:16:35] <grrrit-wm>	 (03PS2) 10Trevor Parscal: [BREAKING CHANGE] Allow options with similar data [oojs/ui] - 10https://gerrit.wikimedia.org/r/174886 
[01:40:01] <grrrit-wm>	 (03PS1) 10Catrope: Revert "Revert "Show the modal overlay as soon as openWindow is called"" [oojs/ui] - 10https://gerrit.wikimedia.org/r/174892 
[01:42:58] <grrrit-wm>	 (03PS2) 10Catrope: Revert "Revert "Show the modal overlay as soon as openWindow is called"" [oojs/ui] - 10https://gerrit.wikimedia.org/r/174892 
[01:46:18] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Copy in some IE CSS hacks from ve-mw [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/174683 (https://bugzilla.wikimedia.org/73565) (owner: 10Alex Monk)
[01:49:40] <grrrit-wm>	 (03Merged) 10jenkins-bot: Copy in some IE CSS hacks from ve-mw [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/174683 (https://bugzilla.wikimedia.org/73565) (owner: 10Alex Monk)
[01:50:35] <grrrit-wm>	 (03PS1) 10Alex Monk: Remove redunant IE CSS rules [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174895 (https://bugzilla.wikimedia.org/73565) 
[01:51:11] <grrrit-wm>	 (03PS2) 10Catrope: Remove redundant IE CSS rules [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174895 (https://bugzilla.wikimedia.org/73565) (owner: 10Alex Monk)
[01:52:05] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] "This looks it's probably missing some changes due to the rename mess? Probably needs CSS additions/changes too?" (033 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174725 (owner: 10SuchetaG)
[01:58:04] <Krenair>	 RoanKattouw, a couple of days ago you mentioned category moving being... questionable due to the ability to put them anywhere on the page
[01:58:15] <Krenair>	 so the entire idea is broken
[01:58:33] <RoanKattouw>	 Well, maybe not
[01:58:53] <RoanKattouw>	 There is probably a way to do this sensibly
[01:59:02] <Krenair>	 currently we allow moving a given category to the end of the list. I think this just removes it from the existing position and adds it to the end of the document? (haven't tested)
[01:59:05] <RoanKattouw>	 If the user drags C to between A and B, move C to right before where B is
[01:59:15] <RoanKattouw>	 I... don't know what that does actually
[01:59:20] <RoanKattouw>	 It's worth finding out
[02:12:20] <mooeypoo>	 What's the benefit in general of rearranging categories?
[02:12:49] <mooeypoo>	 Does it matter if the page has [ Cat1 | Cat2 | Cat3 ] rather than [ Cat3 | Cat1 | Cat2 ] ?
[02:13:10] <RoanKattouw>	 I don't knwo
[02:13:20] <RoanKattouw>	 I think categories are supposed to be in some sort of order, and some people care?
[02:13:23] <RoanKattouw>	 James_F|Away would know
[02:13:51] <mooeypoo>	 Hm
[02:14:14] <mooeypoo>	 I would imagine someone asked for this. I'm just curious if this is a wikitext "I'm used to doing this because it looks better in wikitext" thing or an actual need.
[02:14:32] <mooeypoo>	 if there's no difference and it makes a bunch of dirty diffs and makes little sense in action, do we really need to implement it?
[02:15:31] <RoanKattouw>	 I don't know
[02:15:41] <RoanKattouw>	 I wonder the same things
[02:25:41] <Krenair>	 Well the bug is https://bugzilla.wikimedia.org/show_bug.cgi?id=50809
[02:26:38] <Krenair>	 In which Maggie said several enwiki editors asked for it, and James agreed we should have it.
[02:27:22] <Krenair>	 no links to what they said though
[02:57:39] <RoanKattouw>	 And in other news today, Firefox sucks
[02:57:49] <RoanKattouw>	 It does not do what its own documentation claims it does: https://bugzilla.mozilla.org/show_bug.cgi?id=1102664
[02:58:45] <RoanKattouw>	 And I haven't even mentioned the weirder bug I found today that I haven't been able to isolate, when focusing a not-quite-visible-yet VE surface caused user keypresses to insert characters into surface B while sending keydown events to surface A
[09:46:28] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] Move tearDownBeforeUnloadHandler() to cancel() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174358 (owner: 10Catrope)
[10:12:32] <grrrit-wm>	 (03PS5) 10Esanders: build: Create a 'typos' task and fix a remaining @returns to be @return [oojs/ui] - 10https://gerrit.wikimedia.org/r/174147 (owner: 10Jforrester)
[12:27:52] <grrrit-wm>	 (03PS1) 10Esanders: Fix lots of spelling mistakes and typos [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/174938 
[12:31:09] <grrrit-wm>	 (03PS2) 10Esanders: Fix lots of spelling mistakes and typos [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/174938 
[12:51:57] <grrrit-wm>	 (03PS6) 10Esanders: build: Create a 'typos' task to detect common typos [oojs/ui] - 10https://gerrit.wikimedia.org/r/174147 (owner: 10Jforrester)
[12:51:59] <grrrit-wm>	 (03PS1) 10Esanders: Fix lots of spelling mistakes and typos [oojs/ui] - 10https://gerrit.wikimedia.org/r/174940 
[12:53:28] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Fix lots of spelling mistakes and typos [oojs/ui] - 10https://gerrit.wikimedia.org/r/174940 (owner: 10Esanders)
[13:01:09] <grrrit-wm>	 (03PS1) 10Esanders: Fix lots of spelling mistakes and typos [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174941 
[13:03:54] <grrrit-wm>	 (03PS1) 10Esanders: Fix lots of spelling mistakes and typos [unicodejs] - 10https://gerrit.wikimedia.org/r/174942 
[13:04:56] <grrrit-wm>	 (03CR) 10Esanders: "recheck" [oojs/ui] - 10https://gerrit.wikimedia.org/r/174940 (owner: 10Esanders)
[13:05:27] <grrrit-wm>	 (03CR) 10Esanders: [C: 031] build: Create a 'typos' task to detect common typos [oojs/ui] - 10https://gerrit.wikimedia.org/r/174147 (owner: 10Jforrester)
[14:24:19] <Krinkle>	 edsanders: Looks like an upstream bug in esparse or npm, filed at https://github.com/jscs-dev/node-jscs/issues/787
[15:05:38] <grrrit-wm>	 (03CR) 10Mvolz: [C: 032 V: 032] Replaced sync method modifyBody with async [services/citoid] - 10https://gerrit.wikimedia.org/r/174744 (owner: 10Mvolz)
[16:06:33] <grrrit-wm>	 (03PS1) 10Cmcmahon: [BrowserTest] rubocop updates to replace double quotes with single [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174959 
[16:10:13] <grrrit-wm>	 (03CR) 10Zfilipin: [C: 032] [BrowserTest] rubocop updates to replace double quotes with single [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174959 (owner: 10Cmcmahon)
[16:11:29] <grrrit-wm>	 (03Merged) 10jenkins-bot: [BrowserTest] rubocop updates to replace double quotes with single [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174959 (owner: 10Cmcmahon)
[16:13:39] <grrrit-wm>	 (03PS1) 10Cmcmahon: [BrowserTest] various rubocop updates [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174962 
[16:15:59] <grrrit-wm>	 (03PS2) 10Zfilipin: [BrowserTest] Fixed Style/SpaceAfterComma RuboCop offense [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174962 (owner: 10Cmcmahon)
[16:16:42] <grrrit-wm>	 (03CR) 10Zfilipin: [C: 032] [BrowserTest] Fixed Style/SpaceAfterComma RuboCop offense [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174962 (owner: 10Cmcmahon)
[16:18:08] <grrrit-wm>	 (03Merged) 10jenkins-bot: [BrowserTest] Fixed Style/SpaceAfterComma RuboCop offense [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174962 (owner: 10Cmcmahon)
[16:22:17] <grrrit-wm>	 (03PS1) 10Cmcmahon: [BrowserTest] rubocop proper format for comments [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174965 
[16:23:34] <grrrit-wm>	 (03CR) 10Zfilipin: [C: 032] [BrowserTest] rubocop proper format for comments [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174965 (owner: 10Cmcmahon)
[16:24:52] <grrrit-wm>	 (03Merged) 10jenkins-bot: [BrowserTest] rubocop proper format for comments [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174965 (owner: 10Cmcmahon)
[16:30:27] <grrrit-wm>	 (03PS1) 10Cmcmahon: [BrowserTest] update Gemfile to prevent rubocop failures in gerrit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174968 
[16:32:41] <grrrit-wm>	 (03CR) 10Zfilipin: [C: 032] [BrowserTest] update Gemfile to prevent rubocop failures in gerrit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174968 (owner: 10Cmcmahon)
[16:33:43] <grrrit-wm>	 (03PS1) 10Mvolz: Bug fixes; incorrect indexing [services/citoid] - 10https://gerrit.wikimedia.org/r/174969 
[16:33:56] <grrrit-wm>	 (03Merged) 10jenkins-bot: [BrowserTest] update Gemfile to prevent rubocop failures in gerrit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174968 (owner: 10Cmcmahon)
[16:34:42] <grrrit-wm>	 (03CR) 10Mvolz: [C: 032 V: 032] Bug fixes; incorrect indexing [services/citoid] - 10https://gerrit.wikimedia.org/r/174969 (owner: 10Mvolz)
[16:40:43] <grrrit-wm>	 (03PS1) 10Cmcmahon: [BrowserTest] rubocop change to an if() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174973 
[16:41:56] <grrrit-wm>	 (03CR) 10Zfilipin: [C: 032] [BrowserTest] rubocop change to an if() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174973 (owner: 10Cmcmahon)
[16:43:14] <grrrit-wm>	 (03Merged) 10jenkins-bot: [BrowserTest] rubocop change to an if() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174973 (owner: 10Cmcmahon)
[16:44:34] <James_F>	 Heya.
[16:49:32] <marktraceur>	 James_F: You're late
[16:50:19] <grrrit-wm>	 (03PS1) 10Cmcmahon: [BrowserTest] comments for classes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174975 
[16:51:34] <grrrit-wm>	 (03CR) 10Zfilipin: [C: 032] [BrowserTest] comments for classes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174975 (owner: 10Cmcmahon)
[16:52:50] <grrrit-wm>	 (03Merged) 10jenkins-bot: [BrowserTest] comments for classes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174975 (owner: 10Cmcmahon)
[16:54:29] <James_F>	 marktraceur: Dawdling down the road, that's me.
[16:54:51] <James_F>	 marktraceur: Friday -> no SWAT -> saunterage.
[16:55:21] <marktraceur>	 Good job.
[16:55:33] <marktraceur>	 I took a similar tack, wandering to the DMV to make my car a Proper Minnesotan again.
[16:55:36] <marktraceur>	 And me too.
[16:56:01] <grrrit-wm>	 (03PS1) 10Cmcmahon: [BrowserTest] have rubocop not complain about number of lines in class [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174978 
[16:56:33] * James_F nods.
[16:56:41] <James_F>	 Registered to vote and everything?
[16:56:48] <marktraceur>	 Uhhh...no.
[16:56:50] <marktraceur>	 Crap
[16:56:53] <marktraceur>	 I knew I forgot something
[16:56:57] <James_F>	 Isn't there a box on the form?
[16:57:03] <marktraceur>	 Apparently not
[16:57:09] <James_F>	 Helpful.
[16:57:19] <James_F>	 They were quite pushy in SF when I registered.
[16:57:28] <grrrit-wm>	 (03PS2) 10Zfilipin: [BrowserTest] RuboCop should not complain about number of lines in a method [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174978 (owner: 10Cmcmahon)
[16:57:35] <James_F>	 I had to quite pointedly say that it would be criminal for me to register. :-)
[16:57:38] <grrrit-wm>	 (03CR) 10Zfilipin: [C: 032] [BrowserTest] RuboCop should not complain about number of lines in a method [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174978 (owner: 10Cmcmahon)
[16:58:58] <grrrit-wm>	 (03Merged) 10jenkins-bot: [BrowserTest] RuboCop should not complain about number of lines in a method [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174978 (owner: 10Cmcmahon)
[17:04:29] <cscott>	 marktraceur: maybe minnesota's not a motor-voter state?
[17:05:08] <marktraceur>	 Maybe
[17:05:13] <marktraceur>	 I thought I did it when I was 16 though
[17:05:25] <marktraceur>	 I mean, for 2008.
[17:05:46] <marktraceur>	 Obviously if I had voted in the November 2006 elections there would have been a problem
[17:11:10] <James_F>	 Krinkle: So, if you wanted proof that https://gerrit.wikimedia.org/r/#/c/174147/ is needed, Ed has done sterling work in demonstrating our need: https://gerrit.wikimedia.org/r/#/q/topic:spellcheck+owner:%22Esanders+%253Cesanders%2540wikimedia.org%253E%22,n,z
[17:12:19] <Krinkle>	 James_F: No, that's nonsense.
[17:12:52] <James_F>	 Krinkle: Alternatively we could sack everyone except you so only perfectly-spelt comments and code get merged, but… :-P
[17:13:10] <Krinkle>	 No, I was right the other day, you totally missed my point
[17:13:17] <James_F>	 No, you missed mine.
[17:14:19] <Krinkle>	 Except for program identifiers (e.g. method names) or annotations (@returns) using this for regular spell check is going to be more maintenance work thatn its worth. There's plenty of dictionary files with spell checks and stuff already if that's what you want.
[17:14:49] <James_F>	 True. I suggested expanding to use those too, if you remember.
[17:15:03] <James_F>	 But lots of our code has method names that get mis-spelt.
[17:15:55] <Krinkle>	 So I'd only recommend using this for thigns that aren't plain text. And those things can be detected by a program instead of plain text (jsduck can catch annotations, it already does, it currentl has a hardcoded exception to allow @returns; things like jscs or jshint can detect references to method names). So you'd be left with comments which is the one thing you can use dictionary files for.
[17:16:07] <James_F>	 FFS.
[17:16:07] <James_F>	 S
[17:16:09] <James_F>	 t
[17:16:09] <James_F>	 o
[17:16:11] <James_F>	 p
[17:16:13] <James_F>	 Please.
[17:16:25] <James_F>	 We've already had the discussion about how this won't be used for @returns.
[17:16:33] <James_F>	 Stop trying to argue around that point.
[17:16:43] <James_F>	 It's insulting to everyone.
[17:16:58] <Krinkle>	 And it's probably more productive to catch spelling errors while writing code. Similar to jshint and jscs. Not when you're done writing code and submitting to gerrit. Sure it's faster than code review a week later.
[17:17:14] <Krinkle>	 Anyway, stop trying to convince me, it's obviously not working :P
[17:17:29] <James_F>	 So you want me to convince someone else to +2 instead, and disrespect you?
[17:17:34] <James_F>	 That doesn't seem very nice.
[17:17:52] <Krinkle>	 If you clarify what its purpose and boundaries are, I can review it without liking it. That's fine. I do that all the time.
[17:18:10] <Krinkle>	 :)
[17:18:38] <James_F>	 Krinkle: jscs doesn't catch typos of fragments of method names in comments.
[17:18:56] <James_F>	 Krinkle: jsduck doesn't catch typos in parameter descriptions.
[17:19:12] <James_F>	 Krinkle: jshint doesn't catch typos in file headers.
[17:20:06] <James_F>	 https://github.com/shama/grunt-spell is neat but not hugely maintained. It worked "OK" but missed some things we'd want to see.
[17:30:40] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on cswiki: https://cs.wikipedia.org/?diff=12019905
[17:30:40] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on sqwiki: https://sq.wikipedia.org/?diff=1472175
[17:30:40] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on mediawikiwiki: https://www.mediawiki.org/?diff=1275428
[17:30:40] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=109300077
[17:30:40] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=33372090
[17:30:41] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=33372100
[17:30:41] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=33372129
[17:30:42] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=66901016
[17:30:42] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on ptwiki: https://pt.wikipedia.org/?diff=40664048
[17:30:43] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on ptwiki: https://pt.wikipedia.org/?diff=40668973
[17:30:43] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on dewiki: https://de.wikipedia.org/?diff=136048710
[17:30:44] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on enwiki: https://en.wikipedia.org/?diff=634746640
[17:48:40] <grrrit-wm>	 (03CR) 10Krinkle: [C: 032] Fix lots of spelling mistakes and typos [oojs/ui] - 10https://gerrit.wikimedia.org/r/174940 (owner: 10Esanders)
[17:49:20] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Fix lots of spelling mistakes and typos [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/174938 (owner: 10Esanders)
[17:50:32] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Fix lots of spelling mistakes and typos [unicodejs] - 10https://gerrit.wikimedia.org/r/174942 (owner: 10Esanders)
[17:50:56] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix lots of spelling mistakes and typos [oojs/ui] - 10https://gerrit.wikimedia.org/r/174940 (owner: 10Esanders)
[17:51:21] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Fix lots of spelling mistakes and typos [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174941 (owner: 10Esanders)
[17:52:19] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Fix lots of spelling mistakes and typos [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/174938 (owner: 10Esanders)
[17:53:25] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix lots of spelling mistakes and typos [unicodejs] - 10https://gerrit.wikimedia.org/r/174942 (owner: 10Esanders)
[17:54:07] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix lots of spelling mistakes and typos [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174941 (owner: 10Esanders)
[17:55:02] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] "Dear jenkins…" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/174938 (owner: 10Esanders)
[17:57:14] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix lots of spelling mistakes and typos [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/174938 (owner: 10Esanders)
[18:28:34] <TrevorParscal>	 kirstenMA: howdy
[18:28:36] <TrevorParscal>	 and good morning
[18:28:54] <kirstenMA>	  hi
[18:28:59] <grrrit-wm>	 (03PS3) 10Jforrester: Update VE core submodule to master (fb57e24) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174895 (https://bugzilla.wikimedia.org/73565) (owner: 10Alex Monk)
[18:29:03] <TrevorParscal>	 MatmaRex: how much time do you have today?
[18:29:32] <Krenair>	 James_F, hey, so, https://bugzilla.wikimedia.org/show_bug.cgi?id=73675
[18:29:44] <Krenair>	 if anything broke this it was probably https://gerrit.wikimedia.org/r/#/c/172658/
[18:30:10] <MatmaRex>	 TrevorParscal: a lot
[18:30:31] <James_F>	 Krenair: Yeah, I was thinking it might be related. Still chasing it down.
[18:30:40] <Krenair>	 the steps to reproduce... could probably be more useful
[18:32:05] <Krenair>	 But my understanding is that when opening the save dialog, typing new text goes into the surface behind the dialog, rather than the edit summary box in the dialog?
[18:32:48] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: FieldLayout: Only use <label> for InputWidgets [oojs/ui] - 10https://gerrit.wikimedia.org/r/174994 
[18:33:11] <MatmaRex>	 TrevorParscal: this ^ is a wonderfully simple solution to the radio problem we had.
[18:33:30] <James_F>	 Krenair: Yeah, I can't reproduce right now either.
[18:33:43] <MatmaRex>	 i'm finishing this so that we can hopefully include radio buttons in the initial "release" of ooui into mw.
[18:33:53] <Krenair>	 James_F, Sherry suggested it may be Mac-only.
[18:35:47] <TrevorParscal>	 MatmaRex: ok
[18:36:42] * Krenair will be back after dinner
[18:38:46] <ryasmeen>	 Hey James_F! :) Where is that Etherpad , you were mentioning in the standup to report bug?
[18:42:19] <grrrit-wm>	 (03PS2) 10Bartosz Dziewoński: [WIP] Implement radio button widgets [oojs/ui] - 10https://gerrit.wikimedia.org/r/174290 (https://bugzilla.wikimedia.org/72586) 
[18:42:53] <grrrit-wm>	 (03CR) 10Catrope: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174357 (owner: 10Catrope)
[18:46:51] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Update VE core submodule to master (fb57e24) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174895 (https://bugzilla.wikimedia.org/73565) (owner: 10Alex Monk)
[18:50:39] <TrevorParscal>	 MatmaRex: I want to do an audit next week of OOjs UI, and do a breaking change that fixes the naming of a lot of methods, and in some cases moves methods to in the .static. property instead of directly on the constructor
[18:50:55] <TrevorParscal>	 so, I'm going to start collecting a list of known issues, wants to change, etc.
[18:52:07] <MatmaRex>	 :o
[18:52:25] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update VE core submodule to master (fb57e24) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174895 (https://bugzilla.wikimedia.org/73565) (owner: 10Alex Monk)
[19:29:24] <grrrit-wm>	 (03PS3) 10Bartosz Dziewoński: Implement radio button widgets [oojs/ui] - 10https://gerrit.wikimedia.org/r/174290 (https://bugzilla.wikimedia.org/72586) 
[19:31:27] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Implement radio button widgets [oojs/ui] - 10https://gerrit.wikimedia.org/r/174290 (https://bugzilla.wikimedia.org/72586) (owner: 10Bartosz Dziewoński)
[19:31:33] <MatmaRex>	 finally i am done with that blasted thing.
[19:31:36] <MatmaRex>	 or so i thought.
[19:32:19] <James_F>	 Ha.
[19:33:52] <grrrit-wm>	 (03PS4) 10Bartosz Dziewoński: Implement radio button widgets [oojs/ui] - 10https://gerrit.wikimedia.org/r/174290 (https://bugzilla.wikimedia.org/72586) 
[19:34:08] <MatmaRex>	 for real this time. :)
[19:37:45] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Prevent JS errors when surfaceReady fires after deactivation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174357 (owner: 10Catrope)
[19:41:02] <grrrit-wm>	 (03Merged) 10jenkins-bot: Prevent JS errors when surfaceReady fires after deactivation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174357 (owner: 10Catrope)
[19:43:01] <grrrit-wm>	 (03Merged) 10jenkins-bot: Move tearDownBeforeUnloadHandler() to cancel() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174358 (owner: 10Catrope)
[19:47:55] <TrevorParscal>	 edsanders: so, https://gerrit.wikimedia.org/r/#/c/174688 still needs to be tested in monobook, right?
[19:48:19] <James_F>	 edsanders: I'll do it if you can't.
[19:51:03] <grrrit-wm>	 (03PS11) 10Krinkle: Add instrumentation for edit schema [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/171499 (owner: 10Catrope)
[19:57:38] <edsanders>	 I guess so
[19:59:35] <grrrit-wm>	 (03PS12) 10Catrope: Add instrumentation for edit schema [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/171499 
[20:11:17] <grrrit-wm>	 (03PS2) 10Esanders: Find and replace [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/174491 
[20:11:19] <grrrit-wm>	 (03PS3) 10Esanders: Fix z-indexes in core [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/174688 (https://bugzilla.wikimedia.org/73650) 
[20:13:15] <Krenair>	 James_F, what should we do about Sherry's bug?
[20:13:31] <Krenair>	 get some more people to try to reproduce it?
[20:14:49] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Find and replace [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/174491 (owner: 10Esanders)
[20:25:00] <grrrit-wm>	 (03PS1) 10Cmcmahon: [BrowserTest] consolidate some duplicate elements [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175017 
[20:28:10] <grrrit-wm>	 (03PS2) 10Cmcmahon: [BrowserTest] consolidate some duplicate elements [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175017 
[20:29:05] <grrrit-wm>	 (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175017 (owner: 10Cmcmahon)
[20:30:30] <grrrit-wm>	 (03Merged) 10jenkins-bot: [BrowserTest] consolidate some duplicate elements [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175017 (owner: 10Cmcmahon)
[20:37:08] <grrrit-wm>	 (03CR) 10Krinkle: "Before:" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/171499 (owner: 10Catrope)
[20:37:14] <Krinkle>	 RoanKattouw_away: Looks like it broke validation
[20:41:20] <RoanKattouw_away>	 Krinkle: Oh right I didn't update the schema's oldid in WikimediaEvents
[20:41:23] <RoanKattouw_away>	 Thanks for pointing that out
[20:41:37] <Krinkle>	 Ah, that's what it was.
[20:58:08] <grrrit-wm>	 (03PS1) 10Cmcmahon: [BrowserTest] remove tests from the Jenkins builds known to fail for Chrome [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175035 
[20:59:14] <grrrit-wm>	 (03CR) 10Cmcmahon: [C: 032] "stop tests for Chrome failing in Jenkins" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175035 (owner: 10Cmcmahon)
[21:02:47] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [BrowserTest] remove tests from the Jenkins builds known to fail for Chrome [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175035 (owner: 10Cmcmahon)
[21:07:43] <TrevorParscal>	 MatmaRex: howdy
[21:07:57] <TrevorParscal>	 I am going to be working with kirstenMA for a bit, what are you up to?
[21:08:45] <TrevorParscal>	 i see you have quite a stack of changes for me to go through
[21:09:06] <MatmaRex>	 got a bit of email and review backlog to handle, i think i'm done with all of the things that had to be done *now*
[21:09:12] <TrevorParscal>	 kirstenMA: I'm going to take a few minutes to go through this backlog before we start, let's shoot for like 1:20
[21:09:20] <MatmaRex>	 yeah, waiting for some reviews from you and/or chris
[21:09:35] <kirstenMA>	 okay
[21:09:41] <TrevorParscal>	 did you notify him you are ready for him to look at those changes yet?
[21:09:57] <MatmaRex>	 he doesn't read bugmail?
[21:10:33] * MatmaRex emails
[21:10:45] <TrevorParscal>	 Roan can do it
[21:10:55] <TrevorParscal>	 just PM roan the changes
[21:11:17] <TrevorParscal>	 he may want Chris to also look at it
[21:12:06] <grrrit-wm>	 (03PS1) 10Cmcmahon: [BrowserTest] love for test that targets test2wiki [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175090 
[21:12:09] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] PHP: Reject malformed and potentially evil input when outputting HTML (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/174835 (https://bugzilla.wikimedia.org/73156) (owner: 10Bartosz Dziewoński)
[21:12:17] <RoanKattouw>	 Looks reasonable to me except for that one inline comment I left
[21:12:30] <RoanKattouw>	 But since these were Chris's concerns, Chris should look at this and see if they're satisfied
[21:12:36] <RoanKattouw>	 I'll add him as a reviewer on the change
[21:12:46] <grrrit-wm>	 (03CR) 10Cmcmahon: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175035 (owner: 10Cmcmahon)
[21:15:11] <MatmaRex>	 RoanKattouw: whoops, fixing.
[21:15:28] <TrevorParscal>	 MatmaRex: I thought we were planning on having a method on RadioInputWidget to get the selected value
[21:15:45] <RoanKattouw>	 MatmaRex: Is there a spec that says what valid attribute chars are, perhaps? Or is that too broad for our purposes?
[21:16:01] <grrrit-wm>	 (03PS3) 10Bartosz Dziewoński: PHP: Reject malformed and potentially evil input when outputting HTML [oojs/ui] - 10https://gerrit.wikimedia.org/r/174835 (https://bugzilla.wikimedia.org/73156) 
[21:16:26] <grrrit-wm>	 (03CR) 10Dduvall: [C: 032] [BrowserTest] remove tests from the Jenkins builds known to fail for Chrome [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175035 (owner: 10Cmcmahon)
[21:16:27] <RoanKattouw>	 Krinkle|detached: With https://gerrit.wikimedia.org/r/175102 , my instrumentation change should work properly
[21:16:42] <MatmaRex>	 RoanKattouw: there is, but the spec allows almost any character, not sure if we want that
[21:16:49] <RoanKattouw>	 Krinkle|detached: If it could be merged today, that would be much appreciated
[21:16:53] <MatmaRex>	 "Attribute names must consist of one or more characters other than the space characters, U+0000 NULL, U+0022 QUOTATION MARK ("), U+0027 APOSTROPHE ('), ">" (U+003E), "/" (U+002F), and "=" (U+003D) characters, the control characters, and any characters that are not defined by Unicode."
[21:17:02] <RoanKattouw>	 Oh dear
[21:17:39] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: PHP: Reject malformed and potentially evil input when outputting HTML (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/174835 (https://bugzilla.wikimedia.org/73156) (owner: 10Bartosz Dziewoński)
[21:17:59] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [BrowserTest] remove tests from the Jenkins builds known to fail for Chrome [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175035 (owner: 10Cmcmahon)
[21:18:12] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] "Works not-less-well in MonoBook." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/174688 (https://bugzilla.wikimedia.org/73650) (owner: 10Esanders)
[21:19:13] <chrismcmahon>	 James_F: Krinkle|detached qunit tests for VE are erroneously failing again
[21:20:17] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 04-1] "RadioInputWidget should probably have a way to get the selected radio in the same group, like getSelectedInput() -> {RadioInputWidget|null" [oojs/ui] - 10https://gerrit.wikimedia.org/r/174290 (https://bugzilla.wikimedia.org/72586) (owner: 10Bartosz Dziewoński)
[21:20:33] <MatmaRex>	 TrevorParscal: one more thing i want to do soon is the image syntax in module definition for RLImageModule; and then i'll probably find something else to do, there's no shortage of work :)
[21:20:52] <TrevorParscal>	 lol, indeed
[21:21:07] <MatmaRex>	 TrevorParscal: we'd have to always get that data from the DOM, which we avoided in InputWidgets so far for some reason
[21:21:20] <MatmaRex>	 (since, as we discussed, there's no event for unselecting a radio button)
[21:22:26] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix z-indexes in core [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/174688 (https://bugzilla.wikimedia.org/73650) (owner: 10Esanders)
[21:22:43] <MatmaRex>	 TrevorParscal: getting the selected input for the given value of 'name' attribute would include some tedious DOM walking, if we want it to be correct in all cases
[21:23:06] <TrevorParscal>	 MatmaRex: I thought we decided to emit events from setSelected by looking for other inputs in the same group and then manually calling setSelected( false ) on them?
[21:23:09] <MatmaRex>	 i'm not sure if we should be supporting that. RadioSelectWidget provides this magically.
[21:23:27] <MatmaRex>	 TrevorParscal: only RadioSelectWidget does that right now
[21:24:23] <TrevorParscal>	 ok, so I can think of reasons why the events are a no go
[21:24:35] <TrevorParscal>	 so..
[21:24:40] <MatmaRex>	 TrevorParscal: the prose from spec that describes how to do that (look up selected input), including the necessary terms definitions, would probably take a few pages.
[21:24:55] <TrevorParscal>	 anyway, what I am getting after is only a convenience for finding the selected input in the same group
[21:24:58] <MatmaRex>	 i can implement it, sure, but you need to convince me that it's worth the time. :)
[21:25:32] <TrevorParscal>	 ok, so I'm ok skipping that for now, but the isSelected() is probably of value and cheap to implement yes?
[21:26:09] <MatmaRex>	 yes
[21:26:17] <grrrit-wm>	 (03CR) 10Cmcmahon: [BrowserTest] remove tests from the Jenkins builds known to fail for Chrome [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175035 (owner: 10Cmcmahon)
[21:26:22] <grrrit-wm>	 (03PS2) 10Cmcmahon: [BrowserTest] remove tests from the Jenkins builds known to fail for Chrome [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175035 
[21:26:29] <grrrit-wm>	 (03CR) 10Cmcmahon: [C: 032] [BrowserTest] remove tests from the Jenkins builds known to fail for Chrome [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175035 (owner: 10Cmcmahon)
[21:26:30] <MatmaRex>	 (it's just inconsistent with how we did InputWidgets, and i don't know why we did them that way)
[21:27:03] <MatmaRex>	 (they all track their state explicitly and carefully via events)
[21:27:27] <TrevorParscal>	 it's because we don't trust the browser
[21:27:49] <TrevorParscal>	 with radios, it appears to be so bad, we can't do it
[21:27:53] <TrevorParscal>	 what if the form gets reset
[21:27:59] <grrrit-wm>	 (03Merged) 10jenkins-bot: [BrowserTest] remove tests from the Jenkins builds known to fail for Chrome [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175035 (owner: 10Cmcmahon)
[21:28:05] <TrevorParscal>	 this may also be a problem with checkboxes and we've not hit it yet
[21:28:27] <grrrit-wm>	 (03PS2) 10Cmcmahon: [BrowserTest] love for test that targets test2wiki [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175090 
[21:28:35] <TrevorParscal>	 the idea is that OOjs UI should do what it takes to provide a good API, even when the browser does not
[21:28:36] <grrrit-wm>	 (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175090 (owner: 10Cmcmahon)
[21:29:00] <MatmaRex>	 there's an event for that, but it doesn't seem like we hook to it
[21:29:16] <MatmaRex>	 we generally don't really look at elements' associated forms, and name attributes, at all
[21:29:29] <MatmaRex>	 we'd need to start doing it
[21:29:29] <TrevorParscal>	 in this case, select events would be of value, perhaps the select event of a radio is like this.emit( 'select', inputThatIsNowSelectedOrNull )
[21:29:59] <grrrit-wm>	 (03Merged) 10jenkins-bot: [BrowserTest] love for test that targets test2wiki [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175090 (owner: 10Cmcmahon)
[21:30:08] <TrevorParscal>	 MatmaRex: it gets really tricky because if the input is moved between forms we would need to unbind/bind the events - it's a rabbit hole
[21:30:16] <TrevorParscal>	 that's why I'm OK, for now, skipping it
[21:30:21] <MatmaRex>	 my thinking is that a <input type=radio/> is like a <option/>, and thus we are right not to track its state in it
[21:30:31] <TrevorParscal>	 since the primary use case at the moment is for static use of the radio input anyway
[21:30:57] <MatmaRex>	 (the equivalent of <select/> is a "radio button group", which is imaginary and not accessible anywhere)
[21:30:58] <TrevorParscal>	 MatmaRex: maybe you are right, and I like that you've done a RadioSelectWidget
[21:31:33] <TrevorParscal>	 yes, the radio button magical association between other radio buttons is a pretty crappy design from an API perspective
[21:31:43] <MatmaRex>	 http://www.w3.org/TR/html5/forms.html#radio-button-group
[21:32:24] <TrevorParscal>	 yeah - cannot contain only 1, such a strange rule
[21:32:40] <TrevorParscal>	 I mean, sure, why would you need a radio group with 1 item, but to enforce such things? c'mon
[21:33:14] <grrrit-wm>	 (03PS1) 10Jforrester: Follow-up I19da270a: Make overlay appear above non-VE skin items in Monobook [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175111 
[21:33:28] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] FieldLayout: Only use <label> for InputWidgets [oojs/ui] - 10https://gerrit.wikimedia.org/r/174994 (owner: 10Bartosz Dziewoński)
[21:34:02] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] build: Create a 'typos' task to detect common typos [oojs/ui] - 10https://gerrit.wikimedia.org/r/174147 (owner: 10Jforrester)
[21:35:39] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] Revert "Revert "Show the modal overlay as soon as openWindow is called"" [oojs/ui] - 10https://gerrit.wikimedia.org/r/174892 (owner: 10Catrope)
[21:36:33] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] PHP: Reject malformed and potentially evil input when outputting HTML [oojs/ui] - 10https://gerrit.wikimedia.org/r/174835 (https://bugzilla.wikimedia.org/73156) (owner: 10Bartosz Dziewoński)
[21:37:49] <grrrit-wm>	 (03PS1) 10Catrope: Handle empty rowspan/colspan attributes correctly [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175116 
[21:38:02] <grrrit-wm>	 (03Merged) 10jenkins-bot: FieldLayout: Only use <label> for InputWidgets [oojs/ui] - 10https://gerrit.wikimedia.org/r/174994 (owner: 10Bartosz Dziewoński)
[21:39:33] <grrrit-wm>	 (03PS3) 10Trevor Parscal: [BREAKING CHANGE] Allow options with similar data [oojs/ui] - 10https://gerrit.wikimedia.org/r/174886 
[21:39:36] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Allow options with similar data [oojs/ui] - 10https://gerrit.wikimedia.org/r/174886 (owner: 10Trevor Parscal)
[21:40:01] <TrevorParscal>	 kirstenMA: sorry, just another bit, trying to clear things so MatmaRex isn't waiting for me
[21:40:15] <kirstenMA>	 okay. no problem
[21:40:41] <TrevorParscal>	 https://gerrit.wikimedia.org/r/#/c/174886/ needs follow up commits in ve, vemw and mv - if anyone is sitting around bored, waiting for things to do :)
[21:41:21] <grrrit-wm>	 (03CR) 10Trevor Parscal: "Just add isSelected and I'm in." [oojs/ui] - 10https://gerrit.wikimedia.org/r/174290 (https://bugzilla.wikimedia.org/72586) (owner: 10Bartosz Dziewoński)
[21:41:46] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] Remove accidental double try-catch from 76800b47 [oojs/ui] - 10https://gerrit.wikimedia.org/r/174846 (owner: 10Bartosz Dziewoński)
[21:42:52] <grrrit-wm>	 (03Merged) 10jenkins-bot: build: Create a 'typos' task to detect common typos [oojs/ui] - 10https://gerrit.wikimedia.org/r/174147 (owner: 10Jforrester)
[21:43:29] <grrrit-wm>	 (03Merged) 10jenkins-bot: Revert "Revert "Show the modal overlay as soon as openWindow is called"" [oojs/ui] - 10https://gerrit.wikimedia.org/r/174892 (owner: 10Catrope)
[21:45:43] <grrrit-wm>	 (03Merged) 10jenkins-bot: PHP: Reject malformed and potentially evil input when outputting HTML [oojs/ui] - 10https://gerrit.wikimedia.org/r/174835 (https://bugzilla.wikimedia.org/73156) (owner: 10Bartosz Dziewoński)
[21:46:56] <ryasmeen>	 RoanKattouw: What happened to the the toolbar in Betalabs again? :(
[21:47:17] <RoanKattouw>	 The white background?
[21:47:25] <RoanKattouw>	 Ed put a commit in OOUI to fix that
[21:47:35] <RoanKattouw>	 I forget what that commit's status is; I think it should be pulled through already
[21:47:54] <grrrit-wm>	 (03CR) 10Mooeypoo: Eventify TemplateDataGenerator and use oojs-ui (032 comments) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 (owner: 10Mooeypoo)
[21:49:01] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove accidental double try-catch from 76800b47 [oojs/ui] - 10https://gerrit.wikimedia.org/r/174846 (owner: 10Bartosz Dziewoński)
[21:49:14] <grrrit-wm>	 (03CR) 10Krinkle: "The revision is now updated, but it's still being rejected by the server." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/171499 (owner: 10Catrope)
[21:49:15] <ryasmeen>	 Umm no actually, it was appearing much wider in Firefox
[21:49:18] <Krinkle>	 RoanKattouw: ^
[21:49:21] <RoanKattouw>	 Ugh
[21:49:31] <Krinkle>	 Sorry :)
[21:49:50] <James_F>	 ryasmeen: Was or is?
[21:50:18] <James_F>	 ryasmeen: http://en.wikipedia.beta.wmflabs.org/wiki/User:Jdforrester_(WMF)/Sandbox?veaction=edit looks fine to me in Firefox (and also on MW.org).
[21:50:36] <ryasmeen>	 "was". because it went away now after refresh :\
[21:51:03] <James_F>	 ryasmeen: Hmm.
[21:51:14] <James_F>	 Surely fixed bug is :-) ? ;-)
[21:52:16] <grrrit-wm>	 (03CR) 10Krinkle: "yay++;" [oojs/ui] - 10https://gerrit.wikimedia.org/r/174846 (owner: 10Bartosz Dziewoński)
[21:53:32] <ryasmeen>	 James_F: Sorry it was in debug mode :P
[21:55:38] <James_F>	 ryasmeen: Aha.
[21:55:42] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 04-1] "Please also add CSS to respond to the absence of the class the way the inline style used to behave." [oojs/ui] - 10https://gerrit.wikimedia.org/r/174844 (https://bugzilla.wikimedia.org/73156) (owner: 10Bartosz Dziewoński)
[21:57:45] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 04-1] "This needs a follow up commit in VisualEditor core where sanitizeValue is called." [oojs/ui] - 10https://gerrit.wikimedia.org/r/174815 (https://bugzilla.wikimedia.org/73156) (owner: 10Bartosz Dziewoński)
[21:58:13] <grrrit-wm>	 (03PS3) 10Alex Monk: Catch pagedeleted errors and give the ability to re-create the page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169976 (https://bugzilla.wikimedia.org/52073) 
[21:58:18] <James_F>	 TrevorParscal: https://gerrit.wikimedia.org/r/#/c/174814/
[21:58:43] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] "Nevermind, here it is: https://gerrit.wikimedia.org/r/#/c/174814/" [oojs/ui] - 10https://gerrit.wikimedia.org/r/174815 (https://bugzilla.wikimedia.org/73156) (owner: 10Bartosz Dziewoński)
[21:58:47] <grrrit-wm>	 (03PS1) 10Catrope: Consistently use ve.ui.WindowManager everywhere [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175125 
[21:59:22] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] Use README.md as doxygen main page [oojs/ui] - 10https://gerrit.wikimedia.org/r/174108 (owner: 10Hashar)
[21:59:36] <grrrit-wm>	 (03PS1) 10Catrope: OO.ui.WindowManager -> ve.ui.WindowManager [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175127 
[22:01:56] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Consistently use ve.ui.WindowManager everywhere [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175125 (owner: 10Catrope)
[22:03:26] <grrrit-wm>	 (03PS4) 10Trevor Parscal: [BREAKING CHANGE] Allow options with similar data [oojs/ui] - 10https://gerrit.wikimedia.org/r/174886 
[22:04:38] <TrevorParscal>	 MatmaRex: ok, I'm like 1 hour behind schedule with kirstenMA, but I've gone through your entire backlog
[22:04:43] <TrevorParscal>	 so... you know, progress
[22:05:23] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Rename InputWidget#sanitizeValue → #cleanUpValue [oojs/ui] - 10https://gerrit.wikimedia.org/r/174815 (https://bugzilla.wikimedia.org/73156) (owner: 10Bartosz Dziewoński)
[22:05:52] <MatmaRex>	 TrevorParscal: thank you
[22:06:16] <TrevorParscal>	 MatmaRex: please fix up the things I -1'd (all very trivial stuff) and review this: https://gerrit.wikimedia.org/r/#/c/174886/
[22:06:28] <TrevorParscal>	 James_F: is going to do the pull throughs after it's merged
[22:06:48] <MatmaRex>	 on it
[22:08:44] <grrrit-wm>	 (03Merged) 10jenkins-bot: Use README.md as doxygen main page [oojs/ui] - 10https://gerrit.wikimedia.org/r/174108 (owner: 10Hashar)
[22:09:59] <TrevorParscal>	 ok kirstenMA, let's "hang out" aye?
[22:10:25] <kirstenMA>	 okay :)
[22:11:04] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Consistently use ve.ui.WindowManager everywhere [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175125 (owner: 10Catrope)
[22:11:41] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] OO.ui.WindowManager -> ve.ui.WindowManager [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175127 (owner: 10Catrope)
[22:13:01] <grrrit-wm>	 (03Merged) 10jenkins-bot: OO.ui.WindowManager -> ve.ui.WindowManager [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175127 (owner: 10Catrope)
[22:14:20] <grrrit-wm>	 (03PS2) 10Bartosz Dziewoński: [BREAKING CHANGE] Rename InputWidget#sanitizeValue → #cleanUpValue [oojs/ui] - 10https://gerrit.wikimedia.org/r/174815 (https://bugzilla.wikimedia.org/73156) 
[22:14:34] <grrrit-wm>	 (03Merged) 10jenkins-bot: Consistently use ve.ui.WindowManager everywhere [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175125 (owner: 10Catrope)
[22:18:59] <grrrit-wm>	 (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (23565e7519) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175134 
[22:19:15] <James_F>	 MatmaRex: Please +2 https://gerrit.wikimedia.org/r/#/q/Ie039a451cf03eaf21e16538cfca270b1d9b8f7f9,n,z when you get a moment.
[22:19:18] <grrrit-wm>	 (03PS5) 10Bartosz Dziewoński: Implement radio button widgets [oojs/ui] - 10https://gerrit.wikimedia.org/r/174290 (https://bugzilla.wikimedia.org/72586) 
[22:19:35] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] Update OOjs UI to v0.1.0-pre (23565e7519) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175134 (owner: 10Jforrester)
[22:19:39] <James_F>	 Thanks!
[22:21:39] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Implement radio button widgets [oojs/ui] - 10https://gerrit.wikimedia.org/r/174290 (https://bugzilla.wikimedia.org/72586) (owner: 10Bartosz Dziewoński)
[22:22:13] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] "C'mon Jenkins." [oojs/ui] - 10https://gerrit.wikimedia.org/r/174815 (https://bugzilla.wikimedia.org/73156) (owner: 10Bartosz Dziewoński)
[22:22:37] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "I'm pretty sure that none is necessary in most cases, but that should indeed be tested carefully. I'll try pulling this into VE and clicki" [oojs/ui] - 10https://gerrit.wikimedia.org/r/174844 (https://bugzilla.wikimedia.org/73156) (owner: 10Bartosz Dziewoński)
[22:23:43] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (23565e7519) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175134 (owner: 10Jforrester)
[22:24:08] <grrrit-wm>	 (03Merged) 10jenkins-bot: Implement radio button widgets [oojs/ui] - 10https://gerrit.wikimedia.org/r/174290 (https://bugzilla.wikimedia.org/72586) (owner: 10Bartosz Dziewoński)
[22:30:43] <grrrit-wm>	 (03Merged) 10jenkins-bot: [BREAKING CHANGE] Rename InputWidget#sanitizeValue → #cleanUpValue [oojs/ui] - 10https://gerrit.wikimedia.org/r/174815 (https://bugzilla.wikimedia.org/73156) (owner: 10Bartosz Dziewoński)
[22:34:20] <grrrit-wm>	 (03PS2) 10Jforrester: Update OOjs UI to v0.1.0-pre (8f8896196f) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/174814 (https://bugzilla.wikimedia.org/73156) (owner: 10Bartosz Dziewoński)
[22:36:13] <James_F>	 MatmaRex: +1 https://gerrit.wikimedia.org/r/#/c/174814/ and +2 https://gerrit.wikimedia.org/r/#/c/175138/ and I'll +2 the former?
[22:36:35] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 031] Update OOjs UI to v0.1.0-pre (8f8896196f) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/174814 (https://bugzilla.wikimedia.org/73156) (owner: 10Bartosz Dziewoński)
[22:36:41] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update OOjs UI to v0.1.0-pre (8f8896196f) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/174814 (https://bugzilla.wikimedia.org/73156) (owner: 10Bartosz Dziewoński)
[22:36:47] <James_F>	 Hmm. Maybe not. :-)
[22:36:47] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] Update OOjs UI to v0.1.0-pre (8f8896196f) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/174814 (https://bugzilla.wikimedia.org/73156) (owner: 10Bartosz Dziewoński)
[22:37:07] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Update OOjs UI to v0.1.0-pre (8f8896196f) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/174814 (https://bugzilla.wikimedia.org/73156) (owner: 10Bartosz Dziewoński)
[22:37:10] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 031] Update OOjs UI to v0.1.0-pre (8f8896196f) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/174814 (https://bugzilla.wikimedia.org/73156) (owner: 10Bartosz Dziewoński)
[22:37:12] <MatmaRex>	 ugh.
[22:37:15] <MatmaRex>	 too many patches
[22:37:23] <James_F>	 MatmaRex: You +2 https://gerrit.wikimedia.org/r/#/c/175138/ OK? ;-)
[22:37:52] <MatmaRex>	 i hit the right button this time
[22:38:45] <mooeypoo>	 hm
[22:38:53] <James_F>	 :-)
[22:39:03] <mooeypoo>	 cssjanus should work on image names inside background urls, right?
[22:39:21] <James_F>	 mooeypoo: foo-ltr.svg swapped with foo-rtl.svg? Yes.
[22:39:38] <James_F>	 mooeypoo: But it doesn't actually take foo.svg and make a horizontally-flipped version for you.
[22:39:48] <mooeypoo>	 no no right, only on the names
[22:39:49] <James_F>	 mooeypoo: That's a proposed new functionality for ResourceLoader.
[22:40:02] <mooeypoo>	 but wait, does it work with ltr -> rtl or just literal "left" and "right" ?
[22:40:46] <mooeypoo>	 I'm trying to see how to properly embed the parameter icon in the TemplateData dialog, trying to cover my RTL bases
[22:40:50] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (8f8896196f) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/174814 (https://bugzilla.wikimedia.org/73156) (owner: 10Bartosz Dziewoński)
[22:40:50] <James_F>	 mooeypoo: I think it only works with -ltr files being changed to -rtl.
[22:41:15] * mooeypoo nods
[22:42:25] <James_F>	 mooeypoo: I /think/.
[22:42:31] <James_F>	 mooeypoo: Roan etc. will know for sure.
[22:42:36] <mooeypoo>	 aye, I'm going to try anyways
[22:42:48] <mooeypoo>	 but I need it to work in general first in order to try ...
[22:42:53] * mooeypoo glares at the css
[22:43:20] <mooeypoo>	 Mooey's passive aggressive approach to web development bugs.
[22:46:59] <RoanKattouw>	 mooeypoo: CSSJanus has separate features, one for ltr <-> rtl in URLs, and one for left <-> right in URLs
[22:47:02] <RoanKattouw>	 We only use the former IIRC
[22:47:26] <RoanKattouw>	 I mean, we definitely use the former, and I don't think we use the latter
[22:47:30] <mooeypoo>	 RoanKattouw, it's active in MW in general, though?
[22:47:37] <RoanKattouw>	 Yes
[22:47:42] <mooeypoo>	 this is for TemplateData
[22:47:46] <mooeypoo>	 but I'm copying off of VE
[22:47:48] <RoanKattouw>	 TemplateData is an MW extension, right?
[22:47:58] <mooeypoo>	 so	background-image: url(images/icons/parameter-ltr.svg);
[22:48:01] <RoanKattouw>	 So you should be set
[22:48:01] <mooeypoo>	 aye
[22:48:02] <RoanKattouw>	 Yeah exactly
[22:48:06] <RoanKattouw>	 That's what we do
[22:48:10] * mooeypoo nods
[22:48:10] <RoanKattouw>	 Don't forget /* @embed */
[22:48:19] <mooeypoo>	 yep
[22:48:53] <mooeypoo>	 I'm attaching it to .oo-ui-icon-parameter 
[22:48:56] <mooeypoo>	 which doesn't seem to work
[22:49:09] <mooeypoo>	 But it makes no sense that it doesn't, gah.
[22:51:38] <grrrit-wm>	 (03Abandoned) 10Jforrester: Fix typos [oojs/ui] - 10https://gerrit.wikimedia.org/r/174323 (owner: 10Bartosz Dziewoński)
[22:52:09] <RoanKattouw>	 Ahm, how does it not work? Can you be more specific?
[22:52:17] <RoanKattouw>	 Are you using it inside of a dialog? Is the dialog inside of an iframe?
[22:52:26] <James_F>	 RoanKattouw: Review on https://gerrit.wikimedia.org/r/#/c/174886/ please?
[22:52:51] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 031] "Looks sane to me." [oojs/ui] - 10https://gerrit.wikimedia.org/r/174886 (owner: 10Trevor Parscal)
[22:53:27] <MatmaRex>	 honestly, you guys give me too much credit, i don't know enough about how this stuff works right now to be able to comment more usefully. :)
[22:53:54] <RoanKattouw>	 I'm starting to review it now
[22:54:12] <MatmaRex>	 i was looking for a very large SelectWidget to test, and thought that VE's language selection widget would be nice… except that it uses OptionWidgets without a SelectWidget. huh.
[22:54:24] <mooeypoo>	 RoanKattouw, the style isn't applied to the span
[22:55:10] <RoanKattouw>	 MatmaRex: Urgh, wtf. I blame Ed
[22:55:10] <MatmaRex>	 oh, or maybe it does.
[22:55:26] <RoanKattouw>	 mooeypoo: But the span has .oo-ui-icon-parameter ?!
[22:55:37] <mooeypoo>	 The span has class="oo-ui-iconElement-icon oo-ui-icon-parameter" and I added .oo-ui-icon-parameter {} class (with the background-image above) to the css file and it's still not showing. 
[22:55:41] <MatmaRex>	 false alarm. i got lost in too much framework code. :)
[22:55:52] <mooeypoo>	 and I just checked, all other classes from that stylesheet are working
[22:56:17] <RoanKattouw>	 mooeypoo: ISTR there's something weird about that one with .oo-ui-ltr/rtl but I think I fixed taht?
[22:56:39] <mooeypoo>	 ISTR ?
[22:57:01] <RoanKattouw>	 I seem to recall
[22:57:02] <RoanKattouw>	 .oo-ui-icon-parameter {
[22:57:04] <RoanKattouw>	 	/* @embed */
[22:57:05] <RoanKattouw>	 	background-image: url(images/icons/parameter-ltr.svg);
[22:57:07] <RoanKattouw>	 }
[22:57:08] <RoanKattouw>	 But that is in *ve*.ui.Icons.css
[22:57:13] <mooeypoo>	 ^^ I have that exactly
[22:57:13] <mooeypoo>	 yes
[22:57:23] <mooeypoo>	 I copied it from ve Icons into templatedata css
[22:57:27] <RoanKattouw>	 Right
[22:57:35] <RoanKattouw>	 And you're not like, in a LESS file at the wrong nesting level or something?
[22:57:48] <RoanKattouw>	 And that path is definitely the correct relative path (relative to the CSS file's location) to the image?
[22:57:58] <mooeypoo>	 no, I'm adding to the CSS file that's already included in the extension
[22:58:10] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "(Meh, we do linear operations all over in SelectWidget.)" [oojs/ui] - 10https://gerrit.wikimedia.org/r/174886 (owner: 10Trevor Parscal)
[22:58:11] <mooeypoo>	 and I just changed something in it and it was reflected in the dialog -- so it's embedded and is working for sure
[22:58:23] <mooeypoo>	 RoanKattouw, I also tried trevor's advice from last time, making the rule more precise
[22:58:42] <mooeypoo>	 so I tried .oo-ui-iconElement-icon.oo-ui-icon-parameter instead of just the icon-parameter one
[22:58:45] <RoanKattouw>	 mooeypoo: That's only if the rule is crossed out in the inspector
[22:58:46] <mooeypoo>	 but that doesn't work either
[22:58:57] <mooeypoo>	 I figured I'd try
[22:58:58] <RoanKattouw>	 Because it's for fighting overrides, and the inspector exposes that
[22:59:03] <RoanKattouw>	 What I think is going on is the image path is wrong
[22:59:13] <mooeypoo>	 but I don't even see the rule in the inspector
[22:59:27] <mooeypoo>	 okay, so my css file is inside my modules folder
[22:59:28] <RoanKattouw>	 You have to have the SVG file there, and also have the -rtl version, and it has to be in the right place
[22:59:36] <mooeypoo>	 and inside that folder there's images and the images are there
[22:59:46] <mooeypoo>	 and as I am typing I am discovering you are correct
[22:59:49] <grrrit-wm>	 (03PS5) 10Catrope: [BREAKING CHANGE] Allow options with similar data [oojs/ui] - 10https://gerrit.wikimedia.org/r/174886 (owner: 10Trevor Parscal)
[23:00:09] <mooeypoo>	 I was going to say "and then there's a folder icons" only no, no there isn't. Great.
[23:00:25] <mooeypoo>	 GUESS WHAT. It works now that, oh I don't know.. the image path is right.
[23:01:19] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 04-1] "Needs updating for radio widgets. On it." [oojs/ui] - 10https://gerrit.wikimedia.org/r/174886 (owner: 10Trevor Parscal)
[23:01:40] <grrrit-wm>	 (03PS6) 10Bartosz Dziewoński: [BREAKING CHANGE] Allow options with similar data [oojs/ui] - 10https://gerrit.wikimedia.org/r/174886 (owner: 10Trevor Parscal)
[23:03:24] <grrrit-wm>	 (03PS7) 10Bartosz Dziewoński: [BREAKING CHANGE] Allow options with similar data [oojs/ui] - 10https://gerrit.wikimedia.org/r/174886 (owner: 10Trevor Parscal)
[23:03:49] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 031] [BREAKING CHANGE] Allow options with similar data [oojs/ui] - 10https://gerrit.wikimedia.org/r/174886 (owner: 10Trevor Parscal)
[23:16:34] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] "Nitpick about documentation changes, looks good otherwise. Also needs fixup commits for VE core and VE-MW (and possibly MultimediaViewer?)" (032 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/174886 (owner: 10Trevor Parscal)
[23:26:21] <grrrit-wm>	 (03PS1) 10Catrope: Start the window opening transition before ready, not after [oojs/ui] - 10https://gerrit.wikimedia.org/r/175146 
[23:28:11] <Krenair>	 James_F, I saw Elena's comment on https://bugzilla.wikimedia.org/show_bug.cgi?id=73660 but the text looks about right for monobook...
[23:36:41] <grrrit-wm>	 (03PS8) 10Trevor Parscal: [BREAKING CHANGE] Allow options with similar data [oojs/ui] - 10https://gerrit.wikimedia.org/r/174886 
[23:36:57] <TrevorParscal>	 https://gerrit.wikimedia.org/r/#/c/174886/7
[23:37:34] <grrrit-wm>	 (03CR) 10Catrope: [C: 031] "Looks good, but holding this back until fixup commits for the other repos have been written." [oojs/ui] - 10https://gerrit.wikimedia.org/r/174886 (owner: 10Trevor Parscal)
[23:38:13] <TrevorParscal>	 MatmaRex: do you have some time?
[23:38:49] <MatmaRex>	 TrevorParscal: probably
[23:39:12] <TrevorParscal>	 i could use some help, i need pull through commits for ve, vemw and mv for https://gerrit.wikimedia.org/r/#/c/174886/
[23:40:47] * MatmaRex grumbles
[23:41:02] <MatmaRex>	 when?
[23:41:21] <grrrit-wm>	 (03PS1) 10Catrope: [WIP] Set ready delay to animation duration in VE WindowManager [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175147 
[23:42:18] <grrrit-wm>	 (03PS1) 10Catrope: [WIP] Add focus method to BookletLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/175149 
[23:44:53] <RoanKattouw>	 Krinkle: Haaa, I found out why the events didn't validate
[23:45:12] <RoanKattouw>	 "user.editCount": { type: "integer", enum: [ "IP", .... ], required: "true" }
[23:45:14] <RoanKattouw>	 Guess what :P
[23:45:22] <RoanKattouw>	 It is impossible to submit valid values against that schema
[23:45:26] <James_F>	 MatmaRex: Before we land OOUI 0.2.0 in MW-core tonight. :-)
[23:46:34] <MatmaRex>	 that's some frantic pace.
[23:48:40] <RoanKattouw>	 Krinkle: With https://gerrit.wikimedia.org/r/175151 things validate for me now
[23:50:26] <MatmaRex>	 TrevorParscal: James_F: i'm on it, then.
[23:55:37] <grrrit-wm>	 (03PS1) 10Catrope: Add a getMenu() getter to ComboBoxWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/175154 
[23:55:40] <spagewmf>	 Yo ryasmeen (Elena) , I noticed a weird VE interaction. I wanted to add a category to a page, so [Hamburger] > Page settings > Categories "Design Research" , click [Apply changes]. But my change isn't there until I save, but [Save page] is grayed out. If I add a character and delete it I can save, but then Review changes says No change... 
[23:56:37] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add a getMenu() getter to ComboBoxWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/175154 (owner: 10Catrope)
[23:58:06] <grrrit-wm>	 (03PS2) 10Catrope: Add a getMenu() getter to ComboBoxWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/175154 
[23:58:20] <ryasmeen>	 hmm spagewmf, thats weird! I will see if I can reproduce it.
[23:59:44] <spagewmf>	 ryasmeen: seems like category change doesn't take at all, assuming it is supposed to add [[Category:Design Research]] to the page.  https://www.mediawiki.org/wiki/Flow/Moderated_Testing,_November,_2014:_talk_pages_and_Flow
[23:59:53] <spagewmf>	 I miss Bugzilla :)
[23:59:56] <Krenair>	 <Krenair> James_F, I saw Elena's comment on https://bugzilla.wikimedia.org/show_bug.cgi?id=73660 but the text looks about right for monobook...