[00:00:12] don't know what to do about Sherry's bug [00:00:37] spagewmf: There does not appear to be a Design Research category on mw.org? [00:00:41] Krenair:I tried reproducing Sherry's bug:https://bugzilla.wikimedia.org/show_bug.cgi?id=73675 [00:00:47] But no luck! [00:00:58] spagewmf: Also did you click a suggestion, or did you just fill out the text field and click Apply Changes? [00:01:10] James couldn't either [00:01:25] TrevorParscal: https://gerrit.wikimedia.org/r/#/c/175154/ [00:01:55] (03CR) 10Bartosz Dziewoński: "MMV: https://gerrit.wikimedia.org/r/175155" [oojs/ui] - 10https://gerrit.wikimedia.org/r/174886 (owner: 10Trevor Parscal) [00:02:05] Krenair: I wonder if it got fixed by one of cursor bugs that we pushed to production this week [00:02:51] RoanKattouw: yes, new category. Aha!, I'm meant to do something, I thought the gray "New category" was just informative since I saw a checkmark, and when I brought up the options dialog again "Design Research" was still there. [00:03:33] (03CR) 10Trevor Parscal: [C: 032] Add a getMenu() getter to ComboBoxWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/175154 (owner: 10Catrope) [00:04:27] spagewmf: Yeah, sorry :( [00:04:38] When a bug tracker is available, please file a bug about it, including that detail [00:05:06] What we will probably do is when you click Apply Changes, programmatically choose the first suggestion [00:05:26] We do that in TemplatePlaceholderPage already [00:05:37] (it would be helpful if you could add those comments to the bug as well) [00:05:38] ryasmeen: ^ user error, happens because I didn't press [Return] or click the item I entered. RoanKattouw, ideally the form would know it's "dirty" or [Apply changes] would not enable [00:05:49] spagewmf: Oh, yes that too! Good point! [00:05:51] or something, you folks are smart :) [00:05:56] (03Merged) 10jenkins-bot: Add a getMenu() getter to ComboBoxWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/175154 (owner: 10Catrope) [00:06:27] RoanKattouw: it's cool once I've figured it out. Nice bubbles :) [00:07:06] spagewmf: Please do file a bug when possible though [00:07:20] "839 matches across 54 files" [00:07:23] gonna be fun [00:07:56] could note on http://etherpad.wikimedia.org/p/bugscratchpad [00:08:21] Ooh right [00:08:22] Thanks [00:09:05] I don't think it's official or anything [00:09:11] (03CR) 10Bartosz Dziewoński: "(I'm doing VE and VE-MW too.)" [oojs/ui] - 10https://gerrit.wikimedia.org/r/174886 (owner: 10Trevor Parscal) [00:20:52] ummm… is ve.ui.ContextWidget dead code? we also have ve.ui.ContextSelectWidget, which has the same code and appears to actually have callers [00:22:35] ContextWidget is supposed to be renamed to ContextSelectWidget [00:22:44] did that get skipped somehow? [00:22:54] also, when are you planning on coming to SF in January, which day? [00:24:30] TrevorParscal: it did get skipped, there's a mess, i'll submit a patch later when i deal with the current thing [00:24:48] TrevorParscal: evening of 12th [00:25:09] (03CR) 10Krinkle: [C: 032] Add instrumentation for edit schema [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/171499 (owner: 10Catrope) [00:26:04] MatmaRex: ok, cool [00:26:33] (03Merged) 10jenkins-bot: Add instrumentation for edit schema [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/171499 (owner: 10Catrope) [00:31:57] MatmaRex: I'm planning on being gone from Dec. 15 - Jan 4 [00:33:07] so, I'm wondering if me being gone for 23 consecutive days is going to be a problem for you - I can check in with you on a regular basis and keep up on email if needed [00:33:11] your thoughts? [00:35:07] probably depends on what you'd want to have me do in that time, i guess? [00:35:58] i'm reasonably familiar with all the code, but i'd rather leave major decisions to someone else [00:36:17] ok, well I will give that some thought, I will probably give you some large-ish projects to work on, and keep in touch when possible, and have edsanders give you direction if you have spare time [00:37:04] when are you planning on taking time off? [00:37:52] fyi, the office is basically closed on the 25th, 26th, 1st and 2nd [00:38:05] i'll probably need a break in february for my exams, haven't planned anything else (other than the usual holidays) [00:45:21] MatmaRex: it's super late there, you doing OK? [00:45:40] that's my normal operating hours :) [00:45:50] I feel you [00:46:03] I was nocturnal before I got hitched [00:46:39] hah [00:48:11] ok, I'm available to code now [00:48:25] what can I do to help you, since we've dumped everything on you at this point [00:49:16] i'm finishing the rename pass in VE and VE-MW, i'll push it for review in 20 minutes or sor [00:49:26] ok [00:49:42] this is the OptionWidget caller update? [00:57:47] TrevorParscal> I was nocturnal before I got hitched <-- this should be on a tshirt [00:58:59] lol [00:59:01] TrevorParscal: yes. i'm not renaming anything, heh [00:59:05] I should make one [00:59:08] that would be awesome [00:59:49] Melissa could have one that says "I was diurnal before I gave birth" [01:01:53] (03PS1) 10Bartosz Dziewoński: Update for OOUI OptionWidget (and subclasses) changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175166 [01:02:41] (03PS1) 10Bartosz Dziewoński: Update for OOUI OptionWidget (and subclasses) changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175167 [01:04:08] (03CR) 10Trevor Parscal: [C: 031] Update for OOUI OptionWidget (and subclasses) changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175166 (owner: 10Bartosz Dziewoński) [01:04:33] (03CR) 10Bartosz Dziewoński: "VE: https://gerrit.wikimedia.org/r/#/c/175167/" [oojs/ui] - 10https://gerrit.wikimedia.org/r/174886 (owner: 10Trevor Parscal) [01:04:55] (03CR) 10Trevor Parscal: [C: 031] Update for OOUI OptionWidget (and subclasses) changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175167 (owner: 10Bartosz Dziewoński) [01:05:21] (03CR) 10jenkins-bot: [V: 04-1] Update for OOUI OptionWidget (and subclasses) changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175167 (owner: 10Bartosz Dziewoński) [01:05:22] TrevorParscal, you have a second? [01:05:29] yes [01:05:32] what's crackin? [01:05:34] I'm implementing your comments regarding templatedata [01:05:40] I am running into a small technical issue [01:06:22] ok [01:06:28] yeah, go ahead [01:06:30] so, we said that whatever "missing" parameters (params that exist in the template but aren't in the templatedata model yet) are showing at the bottom of the parameter list as "X unused parameters" [01:07:06] thing is -- if I add this as an option to the selectWidget, I'll need that option to behave differently than the other options. the other options (so, on "choose" of the widget) go to the edit panel [01:07:16] this one will go to the import feature [01:07:16] well, "Add X suggested parameters" I think, but yeah... [01:07:26] yeah, I have the acftual wording in the email [01:07:40] let me look at this in TemplateDialog [01:08:07] ve.ui.MWParameterPlaceholderPage [01:08:09] I could work on a different functionality through the event by checking, on the "on choose" event, whether the user chose the last option, and if so, do something different [01:08:17] but it's a bit backwards, no? [01:08:19] oh [01:08:43] or, maybe ve.ui.MWParameterPage [01:08:57] hm. [01:09:12] Also, you have a search widget. I should probably consider adding that too [01:09:19] Not sure,though? [01:09:38] In this case we probably do need to see all available parameters. Anyways, back to the original point, I'm looking [01:10:25] the widget you are basically working on recreating to some degree is ve.ui.MWParameterSearchWidget [01:10:39] don't use ve.ui.MWParameterSearchWidget, because it's quite a different use case [01:10:45] but it is similar in many ways [01:10:56] Hm, right [01:11:06] how does that deal with responding to the 'choose' event of the last option [01:11:32] items.push( new ve.ui.MWMoreParametersResultWidget( [01:11:32] { remainder: remainder }, { $: this.$ } [01:11:32] ) ); [01:11:36] ^^ [01:11:55] Uhm [01:11:57] yes [01:11:58] So it seems to be that. Right? I think [01:12:03] but then, this is just for view's sake [01:12:13] that's what I was just lookin at [01:12:13] Is it supposed to be passing two objects like that? [01:12:24] probably data vs config [01:12:31] OptionWidgets have data and config options [01:12:32] so, basically, when there's an item that you want to do something different, you can give it data that makes it work differently [01:12:40] RoanKattouw, yep, data and config [01:12:49] mooeypoo: fyi, yes, but not for long [01:13:00] TrevorParscal, okay, so then in the event handler, I'll have to check the data and act accordingly? [01:13:01] data is being moved to be part of options in 0.2.0 (coming soon) [01:13:04] Ooh right [01:13:07] mooeypoo: yes [01:13:08] Yeah that's moving [01:13:17] TrevorParscal, okay ,I suspected but wanted to make sure that's the right approach [01:13:27] RoanKattouw: by the way, you can start merging these patches now probably. [01:13:41] oh. Bah. I forsee a huge rebase in my near future [01:13:50] RoanKattouw: i pushed the updates to ve and mmv, very lightly tested [01:13:52] MatmaRex: Yeah will do so in a minute [01:13:55] Both TemplateData dialog *and* the media dialog have option widgets quite extensively [01:13:58] Or at least, I'll start looking [01:14:09] I might do it on Monday instead [01:14:25] TrevorParscal, okay, I'll do that, then, just wanted to make sure that was the right approach. Something in having a conditional response inside the event handler made me pause, so I figured I'd ask [01:14:52] (03CR) 10Jforrester: [C: 032] [BREAKING CHANGE] Allow options with similar data [oojs/ui] - 10https://gerrit.wikimedia.org/r/174886 (owner: 10Trevor Parscal) [01:15:45] also, i am pretty sure that 029fc7e22cfc551f5bde344d78bf734178a20387 broke some styles [01:15:48] !g 029fc7e22cfc551f5bde344d78bf734178a20387 [01:15:56] the update for menu->option rename [01:16:00] hmm [01:16:09] item->option * [01:16:11] missed mobileContextItemWidget [01:16:11] i tested it in the demos [01:16:18] where did you see breakage? [01:16:29] i don't see any breakage, but code is clearly wrong :) [01:16:39] i see [01:17:14] we also have 've-ui-contextMenuSelectWidget' class in ContextSelectWidget, somehow [01:17:14] ok, well I have to get going soon - can you point me to the code that's broken, or are you already working on it? [01:17:19] (no styles for it anywhere) [01:17:25] i'm working on it [01:17:34] (03Merged) 10jenkins-bot: [BREAKING CHANGE] Allow options with similar data [oojs/ui] - 10https://gerrit.wikimedia.org/r/174886 (owner: 10Trevor Parscal) [01:17:49] it's not uncommon to add classes to the DOM that styles aren't actually using [01:18:04] yeah, but that class clearly should be named 've-ui-contextSelectWidget' [01:18:22] right [01:18:29] (and we have styles for that one) [01:18:32] TrevorParscal, here's an interesting question -- the "add X suggested parameters" in your screenshot has the parameter-set icon. What happens if there's only 1 parameter to add? Do I keep the same icon, or do I change it to the single-param icon. Also, what happens to the way it looks ? it's no longer "including param1, param2, param3..."... should it be something like "Param X is suggested" or something? [01:18:39] I think the order of my regular expressions may have caused that [01:18:41] :( [01:19:26] yes, still use the parameter set icon [01:19:57] and, in fact we may even want to use an "add" icon, but yeah, for now the set icon is good [01:20:34] (03PS2) 10Jforrester: Update OOjs UI to v0.1.0-pre (9ed4cf2557) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175167 (owner: 10Bartosz Dziewoński) [01:20:49] i gotta head out... I want to verify this stuff lands and is in OK shape first [01:21:02] Have a good weekend TrevorParscal [01:21:23] legoktm: hey, you 'round? [01:21:42] what do we need to do, code-wise, to get OOjs UI's PHP lib "merged" into core [01:21:50] just add it to some composer manifest? [01:22:17] (03CR) 10Jforrester: [C: 032] Update OOjs UI to v0.1.0-pre (9ed4cf2557) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175167 (owner: 10Bartosz Dziewoński) [01:24:47] (03CR) 10jenkins-bot: [V: 04-1] Update OOjs UI to v0.1.0-pre (9ed4cf2557) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175167 (owner: 10Bartosz Dziewoński) [01:25:35] (03CR) 10Jforrester: "C'mon Jenkins." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175167 (owner: 10Bartosz Dziewoński) [01:27:50] MatmaRex: i'm heading home [01:28:10] we can finish merging things, cautiously, on Monday or over the weekend if we find time [01:28:15] (03CR) 10Jforrester: [C: 032] Update OOjs UI to v0.1.0-pre (9ed4cf2557) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175167 (owner: 10Bartosz Dziewoński) [01:28:19] thank you for dealing with our urgent demands [01:28:55] TrevorParscal: is there a tag for the version you want in core? [01:28:56] hey, thanks for dealing with my being unavailable for days sometimes :) [01:29:02] legoktm: master :D [01:29:07] MatmaRex: :-) [01:29:22] (03PS1) 10Bartosz Dziewoński: Delete src/ui/widgets/ve.ui.ContextWidget.js [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175172 [01:29:24] legoktm: we are going to tag as v0.2.0 in a bit [01:29:24] (03PS1) 10Bartosz Dziewoński: Tweak some ContextSelectWidget code after item→option update [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175173 [01:29:29] legoktm: About to create one. [01:30:01] ok, once there's a tag I can upload changes to include it in core [01:30:17] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (9ed4cf2557) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175167 (owner: 10Bartosz Dziewoński) [01:30:47] legoktm: What's the composer equivalent of `npm publish`? [01:30:55] legoktm: Need to update README.md :-) [01:30:56] nothing? [01:31:01] just upload the tag [01:31:06] legoktm: Ah. interesting. [01:31:54] (03CR) 10jenkins-bot: [V: 04-1] Tweak some ContextSelectWidget code after item→option update [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175173 (owner: 10Bartosz Dziewoński) [01:32:09] also, do one of you guys have access to the wikimedia github org? we need to set up a github service hook for this [01:32:18] I do. [01:32:24] (03PS2) 10Bartosz Dziewoński: Delete src/ui/widgets/ve.ui.ContextWidget.js [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175172 [01:32:37] ok, there should be a packagist hook [01:32:40] (03PS2) 10Bartosz Dziewoński: Tweak some ContextSelectWidget code after item→option update [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175173 [01:32:43] I can provide you with the api key [01:32:51] legoktm: Awesome. [01:35:01] (03PS1) 10Bartosz Dziewoński: Browser tests: Fix class name: ve-ui-contextMenuWidget → ve-ui-contextSelectWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175174 [01:37:10] Krinkle: When you have a minute, could you look at Marc's email (7h ago) and my reply (just now) on "[editing-team] Next steps for Parsoid Cite CSS support" ? [01:38:59] (03PS1) 10Jforrester: Tag v0.2.0 [oojs/ui] - 10https://gerrit.wikimedia.org/r/175175 [01:39:09] legoktm: Could you +2 https://gerrit.wikimedia.org/r/175175 for me? [01:39:35] (03CR) 10Legoktm: [C: 032] Tag v0.2.0 [oojs/ui] - 10https://gerrit.wikimedia.org/r/175175 (owner: 10Jforrester) [01:39:39] Ta. [01:39:45] RoanKattouw: Yep, I starred that one. Will look into it [01:39:54] OK, cool [01:40:10] No great rush, but I ended my email with "Timo, thoughts?" so I thought I'd notify you separately [01:40:22] Oh, didnt' see that [01:40:24] yet [01:40:44] I do have a gmail filter for mentions of my various call signs for emails not in my inbox (e.g. mailing lists/groups) [01:41:06] Well I sent it like 5 mins ago :) [01:41:39] (03PS2) 10Jforrester: Update VE core submodule to master (c8201dd) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175166 (owner: 10Bartosz Dziewoński) [01:41:47] James_F: I think require(package.json).version works, too [01:41:53] Though I probably wrote the original line [01:41:58] in a different repo [01:41:58] Krinkle: You did. :-) [01:42:07] Krinkle: OOjs's README.md. [01:42:11] back when I was young and foolish [01:42:14] Krinkle: Happy to change, but let's wait. :-) [01:42:30] (03Merged) 10jenkins-bot: Tag v0.2.0 [oojs/ui] - 10https://gerrit.wikimedia.org/r/175175 (owner: 10Jforrester) [01:42:34] Yay. [01:43:31] James_F: Wanna update the npm badge to the latest standard as well (hidpi/svg) later. [01:43:34] Krinkle: Do we want to do an archive of oojs-ui builds? [01:43:39] Krinkle: Sounds good. [01:43:51] James_F: So you asked me earlier about npm/composer and release for oojs-ui [01:43:54] Krinkle: Also, please add me to npm publisherss for OOUI. [01:43:56] James_F: but before I answer that [01:44:01] I'm already on that [01:44:05] Thanks. [01:44:08] James_F: What kind of archive? [01:44:19] Krinkle: Like oojs.github.io/archive [01:44:31] you mean like for oojs-core? [01:44:34] Yeah. [01:44:53] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/175171/ [01:45:18] James_F: oojs.github.ui/oojs-ui/vX/{{subst:dist}} [01:45:21] something like that maybe [01:45:28] Krinkle: That could work too. [01:45:39] so that it can be hyperlinked [01:45:42] the paths should be relative [01:45:56] doesn't download as easily though [01:46:07] Krinkle: Your call. [01:47:17] James_F: I've added npm users jdforrester and trevorparscal to oojs-ui owners [01:47:32] Krinkle: Thanks! `npm publish` run with success. [01:47:43] James_F: yeah, let's also zip or tar.gz it [01:47:47] * James_F nods. [01:48:10] James_F: As for pull throughs etc.. [01:48:13] Krinkle: Just /dist? What about the PHP land? [01:48:39] James_F: They're different packages, different distros. ports essentially. Should live in their own repo eventually. [01:48:47] Can be mixed in the same git repo for now [01:48:48] OK, I guess. [01:48:55] but shouldn't be mixed in dist [01:49:14] and or php we don't need downloadable. composer provides fetch and download interface [01:49:23] * James_F nods. [01:49:25] and for * [01:49:59] (and until php.js goes mainstream when we start compiling hhvm in ES6, we don't need the php code client-side on a CDN either :P) [01:50:00] legoktm: https://packagist.org/packages/oojs/ui – is that a good sign? [01:50:06] Krinkle: :-D [01:50:30] James_F: Hm.. the package should be called oojs-ui, not ui [01:50:43] It's username/package, not a hierchy like gerrit [01:50:54] more like github [01:51:23] cssjanus is cssjanus/cssjanus [01:51:29] Don't tell me. I didn't set it up. [01:51:32] just liek npm, except shared by publisher [01:51:42] I didn't know we already had a composer file [01:52:22] should oojs be its own organisation or under wikimedia/* ? [01:52:38] It's under MediaWiki. [01:53:02] That's just one of the maintainer user accounts [01:53:19] it's not 'under' mediawiki the same way that oojs-ui is not under jdforrester on npm now [01:53:33] when I push my username is added to that list. [01:54:58] legoktm: Thoughts? [01:55:37] (03CR) 10Jforrester: [C: 032] "OOUI now updated in MW." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175166 (owner: 10Bartosz Dziewoński) [01:56:05] (03PS2) 10Jforrester: Browser tests: Fix class name: ve-ui-contextMenuWidget → ve-ui-contextSelectWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175174 (owner: 10Bartosz Dziewoński) [01:56:30] (03PS3) 10Jforrester: [BrowserTests] Fix class name: ve-ui-contextMenuWidget → ve-ui-contextSelectWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175174 (owner: 10Bartosz Dziewoński) [01:56:36] (03CR) 10Jforrester: [C: 032] [BrowserTests] Fix class name: ve-ui-contextMenuWidget → ve-ui-contextSelectWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175174 (owner: 10Bartosz Dziewoński) [01:56:38] (03PS1) 10Krinkle: composer: Rename package to 'oojs-ui' and require php 5.3.3 [oojs/ui] - 10https://gerrit.wikimedia.org/r/175177 [01:58:05] Krinkle: So, where were these meant to go? [01:58:09] (03Merged) 10jenkins-bot: Update VE core submodule to master (c8201dd) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175166 (owner: 10Bartosz Dziewoński) [01:58:28] James_F: Where is what meant to go? [01:58:40] I know we're talking about oojs-ui and composer, but not sure what you mean [01:58:54] Krinkle: oojs.github.io/oojs-ui/v0.2.0/oojs-ui-0.2.0.tar.bz2 ? [01:59:03] Sorry. [01:59:05] James_F: Ah, that [01:59:08] that tars [01:59:09] Hm.. [01:59:26] I can call them whatever. [01:59:31] Well, they could go on oojs.github.io as well, but we can also put them the github downloads dashboard [01:59:45] or on download.wikimedia.org [02:00:01] releases.wikimedia.org/ * [02:00:10] Oh, right. [02:00:14] I don't care. [02:00:24] https://github.com/Krinkle/jquery-json/releases [02:00:26] How about I put these archives in a commit and you dispose of them as you see fit? :-) [02:00:30] that's how attached binaries look like on github [02:00:35] but I don't really like that actually [02:00:43] Yeah. [02:01:05] because we'd be putting them on the release page of a mirror [02:01:10] Yeah. [02:01:13] :D [02:01:29] (03Merged) 10jenkins-bot: [BrowserTests] Fix class name: ve-ui-contextMenuWidget → ve-ui-contextSelectWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175174 (owner: 10Bartosz Dziewoński) [02:01:47] oojs.github.io/oojs-ui/downloads/oojs-ui-0.2.0.tar.gz [02:02:02] It's not all in the same version dir, but it does keep downloads together which seems useful [02:02:13] or maybe move downloads up [02:02:21] oojs.github.io/downloads/oojs-ui/oojs-ui-0.2.0.tar.gz [02:02:27] I think.. [02:02:35] (or releases) [02:02:42] I'll give it some thought, suggestions welcome [02:02:46] OK. [02:03:10] main purpose for the downloadable would be to verify an update commit [02:03:21] e.g. pull tar, extract in place, verify no changes [02:03:32] and also to perform the actual update [02:05:39] James_F: What I wanted to say earlier about pull throughs, I think we should (at least a little) reduce our number of pull throughs. It'll naturally happen I hope as the need for it should go down. Because we should now no longer break as much in updates. Thus updates wouldn't require updating, it'd just mean we don't have the latest bug fixes out yet. We'd release often of course (maybe pull [02:05:39] through right before the wmf branch cuts) [02:06:20] Krinkle: Yeah, that's the ambition. [02:06:28] [13oojs.github.io] 15jdforrester created 06oojs-ui-0.2.0 (+1 new commit): 02https://github.com/oojs/oojs.github.io/commit/704fee33f31c [02:06:29] 13oojs.github.io/06oojs-ui-0.2.0 14704fee3 15James D. Forrester: Add OOjs UI 0.2.0 release from npm [02:06:45] And there's a release push for you to consider/amend/reject. [02:06:51] Krinkle: One release a week, ideally. [02:07:00] Krinkle: And on Wednesdays, just after the cut. [02:07:20] James_F: backports will be even harder than they already are due to ve and mw using it both [02:07:26] but it'll also keep us in check [02:07:33] Hopefully. :-) [02:08:09] James_F: Hm.. I'm hoping we can get a way with one archive format, and would be nice to have the raw files as well (I'll do that though, no worries) [02:08:17] Perhaps a demo (woot, finally!) [02:08:37] (03PS1) 10Jforrester: Add missing History.md file now we're a proper repo [oojs/ui] - 10https://gerrit.wikimedia.org/r/175183 [02:08:52] Krinkle: Sure. As I said, feel free to do with it as you wish. [02:09:06] James_F: whitespace between heading and bullet :) [02:09:13] Krinkle: Yeah yeah. [02:10:49] (03CR) 10Jforrester: [C: 031] composer: Rename package to 'oojs-ui' and require php 5.3.3 [oojs/ui] - 10https://gerrit.wikimedia.org/r/175177 (owner: 10Krinkle) [02:11:34] (03CR) 10Jforrester: [C: 032] Delete src/ui/widgets/ve.ui.ContextWidget.js [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175172 (owner: 10Bartosz Dziewoński) [02:12:10] (03CR) 10Jforrester: [C: 032] Tweak some ContextSelectWidget code after item→option update [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175173 (owner: 10Bartosz Dziewoński) [02:12:33] James_F: k, calling it a day [02:14:28] (03PS1) 10Catrope: Focus the bookletLayout on ready in the template dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175184 [02:15:09] (03Merged) 10jenkins-bot: Delete src/ui/widgets/ve.ui.ContextWidget.js [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175172 (owner: 10Bartosz Dziewoński) [02:15:11] (03Merged) 10jenkins-bot: Tweak some ContextSelectWidget code after item→option update [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175173 (owner: 10Bartosz Dziewoński) [02:18:10] Krinkle: https://gerrit.wikimedia.org/r/175185 [02:19:03] Krinkle: Want to edit that so it patches composer.json too, and base it off the top of https://gerrit.wikimedia.org/r/#/c/175180 ? [02:22:03] (night) [02:23:17] (03PS1) 10Catrope: Fix the "you are now logged in/out" warning [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175186 [02:24:39] James_F: will do tomorro [02:24:47] James_F: I assume it'a bsed on the one for oojs-core from np,/ [02:24:48] npm [02:25:30] Krinkle|detached: Yeah. [02:26:44] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/175111/ [02:27:42] (03CR) 10Catrope: [C: 032] Follow-up I19da270a: Make overlay appear above non-VE skin items in Monobook [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175111 (owner: 10Jforrester) [02:29:03] (03Merged) 10jenkins-bot: Follow-up I19da270a: Make overlay appear above non-VE skin items in Monobook [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175111 (owner: 10Jforrester) [02:31:13] (03PS2) 10Catrope: Add focus method to BookletLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/175149 [02:33:20] (03PS2) 10Catrope: Set ready delay to animation duration in VE WindowManager [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175147 [02:55:54] (03PS2) 10Jforrester: Add missing History.md file now we're a proper repo [oojs/ui] - 10https://gerrit.wikimedia.org/r/175183 [03:02:55] James_F: You will be happy to hear about https://gerrit.wikimedia.org/r/175190 and https://github.com/wikimedia/jquery.ime/pull/373 [03:06:16] RoanKattouw: Yes. [03:10:45] (03PS1) 10Jforrester: README.md: Update introduction, badges, advice [oojs/ui] - 10https://gerrit.wikimedia.org/r/175191 [06:58:57] (03Restored) 10Jagori79: WIP: [Browser Test] Reworked step definition and links file basis input [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/122400 (owner: 10Jagori79) [13:36:22] (03CR) 10Paladox: "Hi it has almost been two years. is this no longer a experiment. and is it a stable composer now I have added it here https://packagist.or" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/46531 (owner: 10Hashar) [13:40:16] (03PS1) 10Paladox: Update composer.json [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/175203 [13:40:29] (03PS2) 10Paladox: Update composer.json [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/175203 [13:47:45] (03CR) 10Mwjames: [C: 04-1] "Expected name inflection for mediawiki/* is defined by [0] which makes mediawiki/wiki-editor to be installed as `extensions/WikiEditor`." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/175203 (owner: 10Paladox) [13:55:15] (03CR) 10Paladox: "Oh ok." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/175203 (owner: 10Paladox) [13:55:31] (03Abandoned) 10Paladox: Update composer.json [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/175203 (owner: 10Paladox) [13:57:17] (03PS1) 10Esanders: Use newFromReplacement in insertContent [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175208 [13:57:46] (03CR) 10Mwjames: "@Legoktm Could you add the packagist mediawiki/wiki-editor?" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/46531 (owner: 10Hashar) [13:58:22] (03PS3) 10Esanders: Find replace [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/174491 [13:58:24] (03PS1) 10Esanders: Pass through excludeInsertions in get(Linear)Fragment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175209 [13:58:26] (03PS1) 10Esanders: Move getText from dm.Document to ElementLinearData [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175210 [13:58:28] (03PS1) 10Esanders: Emit ce.Surface#position after dm.Surface#documentUpdate [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175211 [13:59:54] (03CR) 10jenkins-bot: [V: 04-1] Use newFromReplacement in insertContent [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175208 (owner: 10Esanders) [14:01:13] (03CR) 10jenkins-bot: [V: 04-1] Find replace [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/174491 (owner: 10Esanders) [14:04:09] (03CR) 10Paladox: "Oh I have done that should I delete it and let him/her do it." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/46531 (owner: 10Hashar) [14:08:48] (03CR) 10Mwjames: "No no need for that but maybe he can add the "Maintainer:mediawiki"." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/46531 (owner: 10Hashar) [14:09:52] (03CR) 10Paladox: "Ok I have added him as a maintainer." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/46531 (owner: 10Hashar) [14:10:32] (03CR) 10Paladox: "I have added mediawiki as a maintainer." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/46531 (owner: 10Hashar) [14:12:20] (03PS2) 10Esanders: Use newFromReplacement in insertContent [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175208 [14:15:52] (03PS4) 10Esanders: Find replace [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/174491 [14:18:16] (03CR) 10jenkins-bot: [V: 04-1] Find replace [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/174491 (owner: 10Esanders) [14:27:09] (03CR) 10Mwjames: "It won't work out of the box because of the implicit GLOBALS references (such as `wgAutoloadClasses`)." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/46531 (owner: 10Hashar) [14:30:18] (03PS5) 10Esanders: Find replace [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/174491 [14:33:45] (03CR) 10jenkins-bot: [V: 04-1] Find replace [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/174491 (owner: 10Esanders) [14:37:57] (03PS1) 10Paladox: Converting to globals. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/175214 [14:38:05] (03PS2) 10Paladox: Converting to globals. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/175214 [14:39:06] (03CR) 10Paladox: "Ok I have created this patch https://gerrit.wikimedia.org/r/#/c/175214/" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/46531 (owner: 10Hashar) [14:40:16] (03PS3) 10Paladox: Converting to globals. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/175214 [14:41:17] (03CR) 10Mwjames: [C: 031] Converting to globals. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/175214 (owner: 10Paladox) [15:35:34] (03PS1) 10Alex Monk: Only try to close save dialog before destroying surface if it's currently open [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175217 (https://bugzilla.wikimedia.org/73589) [16:11:01] (03CR) 10Bartosz Dziewoński: [C: 04-1] Converting to globals. (031 comment) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/175214 (owner: 10Paladox) [16:13:52] (03CR) 10Alex Monk: "Seems to have broken adding tables." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175166 (owner: 10Bartosz Dziewoński) [16:14:44] Krenair: :( [16:15:13] Krenair: you mean the ve-mw change, or the ve change it pulled in? [16:15:21] or don't know? [16:15:22] * MatmaRex looks [16:19:48] (03CR) 10Bartosz Dziewoński: "Inserting a table works for me both in standalone and in MediaWiki. Cursoring from outside a table into it with arrows in a bit broken, bu" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175166 (owner: 10Bartosz Dziewoński) [16:22:37] MatmaRex, I ran "git checkout a8b4fc4; git submodule update" and it is broken [16:22:41] adding table causes "Uncaught RangeError: Maximum call stack size exceeded" [16:22:43] and produces a big blank area of table nodes [16:23:03] "git checkout HEAD^; git submodule update" fixes it [16:23:11] Krenair: is it also broken on master? [16:23:46] Krenair: that is what would happen if you updated ve-mw, but not dependencies, or vice versa [16:24:08] master works for me [16:24:28] but i found a different bug instead, added to http://etherpad.wikimedia.org/p/bugscratchpad [16:26:05] yes, broken on master since this commit [16:27:20] huh [16:27:23] MatmaRex, oh, I also updated MW core. seems fine now [16:27:52] ooh. right :D you need up-to-date OOUI version, too [16:28:14] all these dependencies are awful [16:28:26] (03CR) 10Alex Monk: "Oh, I just hadn't updated MW core." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175166 (owner: 10Bartosz Dziewoński) [16:41:12] (03PS4) 10Paladox: Converting to globals. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/175214 [17:05:14] (03PS2) 10Bartosz Dziewoński: LabelElement: Kill inline styles [oojs/ui] - 10https://gerrit.wikimedia.org/r/174844 (https://bugzilla.wikimedia.org/73156) [17:18:43] (03CR) 10Paladox: "I have done what you asked." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/175214 (owner: 10Paladox) [17:30:29] Corruption alert: visualeditor-needcheck on eswiki: https://es.wikipedia.org/?diff=78290043 [17:30:29] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=109322890 [17:30:30] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=109323013 [17:30:30] Corruption alert: visualeditor-needcheck on itwiki: https://it.wikipedia.org/?diff=69278160 [17:54:24] (03PS1) 10Esanders: Fix MW skin hacks [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175222 [18:34:00] (03PS1) 10Esanders: Make debug bar controls narrower [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175226 [18:34:55] (03PS3) 10Bartosz Dziewoński: LabelElement: Kill inline styles [oojs/ui] - 10https://gerrit.wikimedia.org/r/174844 (https://bugzilla.wikimedia.org/73156) [18:38:21] (03CR) 10Bartosz Dziewoński: "I spent some time clicking all of the clickable things in VE dialogs and I'm reasonably confident that these style changes don't break any" [oojs/ui] - 10https://gerrit.wikimedia.org/r/174844 (https://bugzilla.wikimedia.org/73156) (owner: 10Bartosz Dziewoński) [18:40:03] (03PS4) 10Bartosz Dziewoński: LabelElement: Kill inline styles [oojs/ui] - 10https://gerrit.wikimedia.org/r/174844 (https://bugzilla.wikimedia.org/73156) [18:49:13]