[00:00:39] <Krenair>	 I added some people to https://phabricator.wikimedia.org/T75099 earlier because it's so weird - the div that contains this extra 'add more information' text has display:none
[00:01:31] <Krenair>	 if you untick (and even retick) any of the css properties on it, poof
[00:01:44] <Krenair>	 suddenly it actually hides
[00:02:50] <Krenair>	 occurs in chrome, not firefox
[00:04:14] <RoanKattouw>	 Krenair: Oh is that the bug that ryasmeen keeps showing me and I keep being unable to reproduce?
[00:04:23] <Krenair>	 what browser do you use?
[00:04:27] <RoanKattouw>	 The double "Add more information" text?
[00:04:29] <RoanKattouw>	 Chrome!
[00:04:31] <Krenair>	 huh.
[00:04:34] <RoanKattouw>	 I can't get it to happen even in Chrome
[00:04:38] <RoanKattouw>	 But she can
[00:04:47] <RoanKattouw>	 You're saying it's being displayed even though it's got display: none;?
[00:04:50] <Krenair>	 yes.
[00:04:54] <RoanKattouw>	 sigh
[00:04:56] <RoanKattouw>	 Typical Chrome
[00:04:59] <Krenair>	 until you touch any of the css properties
[00:05:02] <RoanKattouw>	 Yup
[00:05:03] <Krenair>	 then it vanishes
[00:05:05] <RoanKattouw>	 Very typical
[00:05:27] <Krenair>	 I'm running chrome 39
[00:05:47] <wikibugs>	 3VisualEditor, VisualEditor-EditingTools: VisualEditor: Place page meta-data in expected order - https://phabricator.wikimedia.org/T52882#783099 (10Liuxinyu970226)
[00:06:12] <RoanKattouw>	 I'm on 39.0.2171.65
[00:06:22] <Krenair>	 39.0.2171.7 dev (64-bit)
[00:07:02] <RoanKattouw>	 Is there anything strange about the way it's receiving display: none;?
[00:07:05] <Krenair>	 ryasmeen, what did you manage to find this under?
[00:07:24] <RoanKattouw>	 I mean it's not even in an iframe any more, otherwise I would have suggested a forgotten this.$()
[00:08:10] <Krenair>	 has class .ve-ui-mwTemplatePage-more
[00:08:17] <Krenair>	 which is display:none in this skin
[00:08:48] <RoanKattouw>	 And we're not, like, programmatically showing it and then hiding it again?
[00:09:31] <ryasmeen>	 Krenair: My one is Version 38.0.2125.122 
[00:09:54] <Krenair>	 interesting. could have been something that got fixed between mine and roan's version
[00:13:00] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Refactor SurfaceObserver pollOnceInternal [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166188 (owner: 10Divec)
[00:15:34] <grrrit-wm>	 (03Merged) 10jenkins-bot: Refactor SurfaceObserver pollOnceInternal [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166188 (owner: 10Divec)
[00:17:38] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] Fix the "you are now logged in/out" warning [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175186 (owner: 10Catrope)
[00:19:16] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix the "you are now logged in/out" warning [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175186 (owner: 10Catrope)
[00:19:36] <Krenair>	 RoanKattouw, the other fun thing about this is that it goes away if I save the page and load it from a file
[00:20:31] <RoanKattouw>	 Why..... would you ever do that
[00:20:32] <RoanKattouw>	 But sure
[00:23:26] <Krenair>	 I wondered about trying to take out as much of the page as possible, to get the simplest reproducible example of the bug
[00:25:28] <wikibugs>	 3VisualEditor, VisualEditor-EditingTools: [Regression wmf7] While opening the "Citation needed" dialog for the first time in a session, the "Add more information" link is appearing twice in the dialog - https://phabricator.wikimedia.org/T75099#783159 (10Krenair) Roan couldn't reproduce this on Chrome 39.0.2171.6...
[00:27:50] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] Create ve.ui.Sequence which matches commands to typed text (035 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175334 (owner: 10Esanders)
[00:29:07] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Not all elements and widgets are inherently flaggable. Even if (nearly) all were, it still sounds reasonable to me to separate the code fo" [oojs/ui] - 10https://gerrit.wikimedia.org/r/164007 (owner: 10Jforrester)
[00:40:36] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] Removing padding override from LanguageResultWidget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175605 (owner: 10Esanders)
[00:40:49] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] Remove padding from undecorated option widgets [oojs/ui] - 10https://gerrit.wikimedia.org/r/175592 (owner: 10Esanders)
[00:41:02] <wikibugs>	 3VisualEditor, Beta-Cluster: Beta Cluster: API PrefixSearch is taking a very long time to return, and returns nothing when it does - https://phabricator.wikimedia.org/T74332#783169 (10Jdforrester-WMF)
[00:41:16] <wikibugs>	 3VisualEditor, VisualEditor-EditingTools: Link inspector pop-up suggestions is appearing in the wrong place when created as a bullet item but not on the first attempt in Firefox - https://phabricator.wikimedia.org/T75428#783170 (10Jdforrester-WMF)
[00:41:28] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] Change command list from whitelist to blacklist [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175476 (owner: 10Esanders)
[00:42:18] <James_F>	 Krinkle: Any thoughts on https://gerrit.wikimedia.org/r/#/c/175185/ ?
[00:42:20] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] [BREAKING CHANGE] Change command list from whitelist to blacklist [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175461 (owner: 10Esanders)
[00:42:50] <grrrit-wm>	 (03Merged) 10jenkins-bot: Change command list from whitelist to blacklist [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175476 (owner: 10Esanders)
[00:43:21] <grrrit-wm>	 (03Merged) 10jenkins-bot: Removing padding override from LanguageResultWidget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175605 (owner: 10Esanders)
[00:43:49] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove padding from undecorated option widgets [oojs/ui] - 10https://gerrit.wikimedia.org/r/175592 (owner: 10Esanders)
[00:44:45] <James_F>	 TrevorParscal: https://gerrit.wikimedia.org/r/#/c/175185/
[00:45:16] <grrrit-wm>	 (03Merged) 10jenkins-bot: [BREAKING CHANGE] Change command list from whitelist to blacklist [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175461 (owner: 10Esanders)
[00:46:02] <TrevorParscal>	 Krinkle: you 'round?
[00:46:17] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] Fix MW skin hacks [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175222 (owner: 10Esanders)
[00:46:26] <Krinkle>	 James_F: Yes, checking now
[00:46:43] <James_F>	 Krinkle: OK. There's kind of a rush on this, as I said.
[00:47:34] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix MW skin hacks [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175222 (owner: 10Esanders)
[00:47:41] <Krinkle>	 TrevorParscal: Yes?
[00:50:01] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] Handle empty rowspan/colspan attributes correctly [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175116 (owner: 10Catrope)
[00:50:33] <TrevorParscal>	 Krinkle: was just going to see if you could help review that shell script
[00:50:53] <TrevorParscal>	 I caused a semi urgent situation to become very urgent
[00:50:58] <wikibugs>	 3VisualEditor, VisualEditor-EditingTools, MediaWiki-extensions-UniversalLanguageSelector: IME selector shows up at the bottom-right corner of the table while selecting a cell on a table or placing a cursor into it - https://phabricator.wikimedia.org/T74824#783182 (10Ryasmeen)
[00:51:01] <TrevorParscal>	 because I accidentally merged some stuff out of order
[00:51:20] <James_F>	 (Tsk. ;-))
[00:51:44] <wikibugs>	 3VisualEditor, VisualEditor-EditingTools, MediaWiki-extensions-UniversalLanguageSelector: IME selector shows up at the bottom-right corner of the table while selecting a cell on a table or placing a cursor into it - https://phabricator.wikimedia.org/T74824#783183 (10Ryasmeen)
[00:51:58] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] ProcessDialog, MessageDialog: Support iconed actions [oojs/ui] - 10https://gerrit.wikimedia.org/r/175576 (owner: 10Bartosz Dziewoński)
[00:52:20] <grrrit-wm>	 (03Merged) 10jenkins-bot: Handle empty rowspan/colspan attributes correctly [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175116 (owner: 10Catrope)
[00:53:11] <wikibugs>	 3VisualEditor, VisualEditor-MediaWiki: Provide keyboard shortcut of Esc key to quit the editor, bring back to read mode (or trigger "are you sure?" confirmation dialog if needed) - https://phabricator.wikimedia.org/T75363#783187 (10Jdforrester-WMF)
[00:53:12] <wikibugs>	 3VisualEditor, VisualEditor-EditingTools: VisualEditor: Escape key (and on Macs additionally ⌘-. ) inside the main editor should cancel VE mode and return to action=view - https://phabricator.wikimedia.org/T52868#783188 (10Jdforrester-WMF)
[00:53:29] <wikibugs>	 3VisualEditor, VisualEditor-EditingTools: VisualEditor: Escape key (and on Macs additionally ⌘-. ) inside the main editor should cancel VE mode and return to action=view - https://phabricator.wikimedia.org/T52868#554398 (10Jdforrester-WMF)
[00:53:40] <wikibugs>	 3VisualEditor, VisualEditor-EditingTools: VisualEditor: Escape key (and on Macs additionally ⌘-. ) inside the main editor should cancel VE mode and return to action=view - https://phabricator.wikimedia.org/T52868#783191 (10Jdforrester-WMF)
[00:54:24] <grrrit-wm>	 (03Merged) 10jenkins-bot: ProcessDialog, MessageDialog: Support iconed actions [oojs/ui] - 10https://gerrit.wikimedia.org/r/175576 (owner: 10Bartosz Dziewoński)
[00:55:04] <wikibugs>	 3OOjs-UI: Process and Message dialogs don't really support having actions with no labels (only icons) - https://phabricator.wikimedia.org/T75696#783195 (10Jdforrester-WMF) 5Open>3Resolved
[00:56:57] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] MessageDialog: Fit actions after updating window size, not before [oojs/ui] - 10https://gerrit.wikimedia.org/r/175503 (owner: 10Bartosz Dziewoński)
[00:57:43] <wikibugs>	 3OOjs-UI: MessageDialog doesn't fit actions correctly - https://phabricator.wikimedia.org/T75376#783199 (10Jdforrester-WMF) 5Open>3Resolved
[00:59:19] <grrrit-wm>	 (03Merged) 10jenkins-bot: MessageDialog: Fit actions after updating window size, not before [oojs/ui] - 10https://gerrit.wikimedia.org/r/175503 (owner: 10Bartosz Dziewoński)
[01:05:24] <grrrit-wm>	 (03PS1) 10Krinkle: build: Add .npmignore [oojs/ui] - 10https://gerrit.wikimedia.org/r/175625 
[01:05:31] <Krinkle>	 James_F: Already done
[01:05:33] <grrrit-wm>	 (03PS1) 10Jforrester: build: Provide an .npmignore file [oojs/ui] - 10https://gerrit.wikimedia.org/r/175626 
[01:05:36] <James_F>	 Krinkle: Ha.
[01:05:47] <Krinkle>	 James_F: Didn't see your message. Switched context just before
[01:05:51] <James_F>	 Krinkle: Ha.
[01:06:03] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] build: Add .npmignore [oojs/ui] - 10https://gerrit.wikimedia.org/r/175625 (owner: 10Krinkle)
[01:06:38] <Krinkle>	 James_F: Releasing
[01:06:40] <grrrit-wm>	 (03Abandoned) 10Jforrester: build: Provide an .npmignore file [oojs/ui] - 10https://gerrit.wikimedia.org/r/175626 (owner: 10Jforrester)
[01:06:43] <James_F>	 Krinkle: Not yet.
[01:06:45] * James_F checks.
[01:06:55] <James_F>	 OK, yes, go for it.
[01:06:59] <Krinkle>	 OK
[01:06:59] <James_F>	 v0.2.2.
[01:07:49] <Krinkle>	 James_F: OK to exclude twn update from release log?
[01:08:45] <James_F>	 Krinkle: Yeah.
[01:08:50] * James_F has been doing that.
[01:09:04] <grrrit-wm>	 (03Merged) 10jenkins-bot: build: Add .npmignore [oojs/ui] - 10https://gerrit.wikimedia.org/r/175625 (owner: 10Krinkle)
[01:09:34] <grrrit-wm>	 (03PS1) 10Krinkle: Tag v0.2.2 [oojs/ui] - 10https://gerrit.wikimedia.org/r/175627 
[01:10:00] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Tag v0.2.2 [oojs/ui] - 10https://gerrit.wikimedia.org/r/175627 (owner: 10Krinkle)
[01:10:58] <wikibugs>	 3OOjs-UI: MessageDialog doesn't fit actions correctly - https://phabricator.wikimedia.org/T75376#783211 (10Jdforrester-WMF)
[01:12:43] <grrrit-wm>	 (03Merged) 10jenkins-bot: Tag v0.2.2 [oojs/ui] - 10https://gerrit.wikimedia.org/r/175627 (owner: 10Krinkle)
[01:13:05] * Krinkle pushed git tag and published to npm
[01:13:10] <wikibugs>	 3OOjs-UI, Wikimedia-Extension-setup: Security review of OOjs UI's PHP implementation - https://phabricator.wikimedia.org/T75156#783212 (10Jdforrester-WMF)
[01:13:21] <wikibugs>	 3OOjs-UI: OOUI: Implement radio buttons - https://phabricator.wikimedia.org/T74586#783213 (10Jdforrester-WMF)
[01:13:27] <James_F>	 So, does the script now work?
[01:13:37] <Krinkle>	 publish to npm takes a while
[01:13:41] <Krinkle>	 will retest when its done
[01:14:02] <James_F>	 Kk.
[01:14:31] <wikibugs>	 3OOjs-UI: Process and Message dialogs don't really support having actions with no labels (only icons) - https://phabricator.wikimedia.org/T75696#783214 (10Jdforrester-WMF)
[01:15:55] <wikibugs>	 3VisualEditor, VisualEditor-MediaWiki: VisualEditor: Escape key (and on Macs additionally ⌘-. ) inside the main editor should cancel VE mode and return to action=view - https://phabricator.wikimedia.org/T52868#783238 (10Jdforrester-WMF)
[01:21:55] <Krinkle>	 Ah, now I get it.
[01:22:06] <Krinkle>	 I get why packagist has 'mediawiki' (linked to gerritadmin) all over it
[01:22:22] <Krinkle>	 That's the account that pushes to github mirror from gerrit. So that's the user that 'created' and 'updated' those packages implicitly.
[01:22:26] <James_F>	 Yes.
[01:22:44] <James_F>	 Makes sense, I suppose.
[01:22:45] <Krinkle>	 Chad and I were wondering if we could update that to another e-mailaddress than gerritadmin
[01:22:47] <Krinkle>	 Yeah
[01:22:50] <James_F>	 Any news on the pull-through?
[01:22:56] <Krinkle>	 It's running now
[01:22:59] <James_F>	 Cool.
[01:23:27] <wikibugs>	 3VisualEditor, VisualEditor-MediaWiki: After updating a page <br /> gets added after the timestamp of last edit made on that page - https://phabricator.wikimedia.org/T75571#783250 (10Jdforrester-WMF)
[01:23:42] <wikibugs>	 3VisualEditor, VisualEditor-MediaWiki: [Regression wmf7] Text in dialog boxes is too small in Monobook - https://phabricator.wikimedia.org/T75660#783251 (10Jdforrester-WMF)
[01:23:50] <wikibugs>	 3VisualEditor, VisualEditor-EditingTools: [Regression ?wmf8] Typing inside dialog surfaces for the first time in a session: the letters gets garbled and "Insert" button remains disabled in Firefox - https://phabricator.wikimedia.org/T75625#783252 (10Jdforrester-WMF)
[01:24:41] <James_F>	 Krinkle: Looks like it works. +2 the script and do the equivalent in VE-core (or should I?).
[01:26:40] <Krinkle>	 James_F: Hm.. I'm not sure ve-core is ready for that yet.
[01:26:54] <Krinkle>	 Last I checked our ve dist/ had (imho) blocking issues to use it in prod.
[01:27:06] <James_F>	 Krinkle: VE-core isn't ready for OOUI?
[01:27:16] <Krinkle>	 Oh sure it's ready for that
[01:27:22] <Krinkle>	 it's the same script after all
[01:27:29] <James_F>	 Exactly.
[01:27:30] <Krinkle>	 I thought you meant visualeditor on npm :)
[01:27:35] <James_F>	 Ha. No no no.
[01:27:39] <Krinkle>	 and pull through in mw like we just did for oojs-ui
[01:27:40] <Krinkle>	 :D
[01:27:55] <Krinkle>	 One day :)
[01:28:04] <James_F>	 I've got it pencilled in for 2016.
[01:28:14] <Krinkle>	 Hm.. okay
[01:28:20] <Krinkle>	 I got it for christmas 2015.
[01:28:26] <Krinkle>	 Before or on the day of.
[01:28:29] <James_F>	 :-P
[01:28:38] <James_F>	 7 days early.
[01:29:03] <Krinkle>	 well, 331 days after christmas 2015 is still 2016.
[01:29:26] <James_F>	 372 days after.
[01:29:39] <Krinkle>	 Yep, that too.
[01:38:56] <grrrit-wm>	 (03CR) 10Catrope: [C: 031] Find and replace tool [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175306 (owner: 10Esanders)
[01:41:13] <James_F>	 Krinkle: So are you doing the script or should I?
[01:41:48] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] ve.ce.Surface: Move insert HTML path to DM (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172748 (owner: 10Jforrester)
[01:44:39] <Krenair>	 hm
[01:45:45] <Krenair>	 pressing escape to leave the cancelconfirm dialog triggers an error
[01:46:09] <RoanKattouw>	 Does getTeardownProcess() not deal gracefully with data being undefined?
[01:46:21] <Krenair>	 the exact same error I get when I try to press escape twice in my code for https://phabricator.wikimedia.org/T52868#783188
[01:46:23] <RoanKattouw>	 Or data.action being undefined or whatever it is
[01:46:49] <Krenair>	 also in my code, as soon as it opens the second time, it instantly closes
[01:47:23] <Krenair>	 the error is from ve.init.mw.ViewPageTarget.prototype.deactivate because it doesn't handle data being undefined, but tries to access data.action anyway
[01:49:15] <Krenair>	 and I know that the instant closing thing seems to be triggered by the Dialog's own escape-handling code
[02:00:30] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Provide a FileDropHandler for CSV and TSV files [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173296 (owner: 10Jforrester)
[02:03:45] <James_F>	 RoanKattouw: Tease. :-)
[02:05:59] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Filter out comments from external paste [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175415 (owner: 10Esanders)
[02:06:01] <RoanKattouw>	 Ugh
[02:06:05] <RoanKattouw>	 So I'm doing a pull-through
[02:06:10] <James_F>	 RoanKattouw: Wait a second.
[02:06:17] <James_F>	 RoanKattouw: I'm doing a new OOUI one for VE-core.
[02:06:21] <RoanKattouw>	 For VE core
[02:06:27] <RoanKattouw>	 But I can't find the VE-MW change for https://gerrit.wikimedia.org/r/#/c/175461/
[02:07:03] <RoanKattouw>	 Although... it looks like I don't need one?
[02:07:26] <grrrit-wm>	 (03Merged) 10jenkins-bot: Filter out comments from external paste [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175415 (owner: 10Esanders)
[02:08:56] <James_F>	 RoanKattouw: You might not.
[02:09:00] <James_F>	 RoanKattouw: Ed's magic like that.
[02:09:27] <RoanKattouw>	 Yeah I'm starting to think I don't have to
[02:09:45] <grrrit-wm>	 (03PS1) 10Catrope: Update VE core submodule to master (2d8aeef) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175643 
[02:10:01] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] [BREAKING CHANGE] Rename paste rules to import rules [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175418 (owner: 10Esanders)
[02:10:07] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Rename paste rules to import rules [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175418 (owner: 10Esanders)
[02:10:11] <RoanKattouw>	 Really?
[02:10:14] <James_F>	 :-)
[02:10:41] <grrrit-wm>	 (03PS1) 10Jforrester: build: Update update-oojs.sh and update-oojs-ui.sh scripts [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175645 
[02:10:46] <James_F>	 RoanKattouw: ^^^ Please.
[02:11:01] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (2d8aeef) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175643 (owner: 10Catrope)
[02:11:37] <James_F>	 Ouch.
[02:12:50] <grrrit-wm>	 (03PS2) 10Jforrester: build: Update update-oojs.sh and update-oojs-ui.sh scripts [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175645 
[02:12:51] <James_F>	 Whoops.
[02:12:57] <James_F>	 Forgot to --amend.
[02:13:00] <James_F>	 Better?
[02:13:55] <RoanKattouw>	 Oh, hah
[02:14:10] <RoanKattouw>	 David's change deleted a file and introduced another one, so I have to update VisualEditor.php
[02:14:18] <James_F>	 Aha.
[02:14:59] <grrrit-wm>	 (03PS2) 10Catrope: Update VE core submodule to master (2d8aeef) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175643 
[02:15:21] <James_F>	 RoanKattouw: https://gerrit.wikimedia.org/r/175645 so I can sync VE-core with the version of OOUI already merged in MW-core?
[02:15:21] <Krinkle>	 James_F: Thx, testing now and will merge soon (update scripts)
[02:15:28] <James_F>	 Krinkle: Oh, OK.
[02:15:36] <James_F>	 RoanKattouw: Never mind, Krinkle's on it.
[02:15:40] <RoanKattouw>	 Yeah I'll let Krinkle do those
[02:15:41] <Krinkle>	 James_F: require() :)
[02:15:46] <RoanKattouw>	 I'm pushing some breaking changes through
[02:16:05] <James_F>	 Krinkle: See PS2. :-)
[02:16:22] <Krinkle>	 James_F: assuming it works, I like it. But that's not in MW core though
[02:16:31] <James_F>	 Krinkle: It was until you botched it.
[02:16:38] * James_F hunts.
[02:16:51] <Krinkle>	 Did you push it while I was amending it? Hm.. must've missed that
[02:17:16] <James_F>	 Hmmmmmmmm.
[02:17:21] <James_F>	 Oh, right.
[02:17:22] <James_F>	 No.
[02:17:26] <grrrit-wm>	 (03PS2) 10Catrope: [BREAKING CHANGE] Rename paste rules to import rules [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175418 (owner: 10Esanders)
[02:17:34] <James_F>	 I did this in OOjs UI's README.md.
[02:17:43] <James_F>	 Knew I wrote it somewhere.
[02:17:46] <RoanKattouw>	 James_F: Merge https://gerrit.wikimedia.org/r/#/c/175643/ ?
[02:17:47] <James_F>	 It works great.
[02:17:55] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] [BREAKING CHANGE] Rename paste rules to import rules [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175418 (owner: 10Esanders)
[02:18:01] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Update VE core submodule to master (2d8aeef) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175643 (owner: 10Catrope)
[02:18:05] <grrrit-wm>	 (03PS7) 10Catrope: ve.ce.Surface: Move insert HTML path to DM [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172748 (owner: 10Jforrester)
[02:18:12] <grrrit-wm>	 (03PS7) 10Catrope: Provide a FileDropHandler for HTML files [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172749 (owner: 10Jforrester)
[02:18:20] <grrrit-wm>	 (03PS7) 10Catrope: Provide a FileDropHandler for CSV and TSV files [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173296 (owner: 10Jforrester)
[02:18:47] <RoanKattouw>	 James_F: Also https://gerrit.wikimedia.org/r/172748 has a relatively trivial -1 (suspected rebase mistake), besides that that whole stack is good to go
[02:19:09] <James_F>	 RoanKattouw: Yeah, confirmed that it's my screw-up in rebase.
[02:19:23] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update VE core submodule to master (2d8aeef) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175643 (owner: 10Catrope)
[02:19:26] <grrrit-wm>	 (03CR) 10Jforrester: ve.ce.Surface: Move insert HTML path to DM (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172748 (owner: 10Jforrester)
[02:19:31] <RoanKattouw>	 James_F: OK. I can fix if you're busy
[02:19:36] <James_F>	 RoanKattouw: Please.
[02:20:26] <grrrit-wm>	 (03Merged) 10jenkins-bot: [BREAKING CHANGE] Rename paste rules to import rules [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175418 (owner: 10Esanders)
[02:20:51] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Provide a FileDropHandler for CSV and TSV files [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173296 (owner: 10Jforrester)
[02:20:58] <James_F>	 What now?
[02:21:18] <grrrit-wm>	 (03PS8) 10Catrope: ve.ce.Surface: Move insert HTML path to DM [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172748 (owner: 10Jforrester)
[02:21:26] <James_F>	 Oh, just npm fails.
[02:21:56] <RoanKattouw>	 Yeah looks like an infrastructure fail
[02:22:11] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] ve.ce.Surface: Move insert HTML path to DM [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172748 (owner: 10Jforrester)
[02:22:19] <grrrit-wm>	 (03PS8) 10Catrope: Provide a FileDropHandler for HTML files [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172749 (owner: 10Jforrester)
[02:22:28] <grrrit-wm>	 (03PS8) 10Catrope: Provide a FileDropHandler for CSV and TSV files [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173296 (owner: 10Jforrester)
[02:23:05] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] ve.ce.Surface: Move insert HTML path to DM [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172748 (owner: 10Jforrester)
[02:24:12] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Provide a FileDropHandler for HTML files [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172749 (owner: 10Jforrester)
[02:26:33] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Provide a FileDropHandler for CSV and TSV files [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173296 (owner: 10Jforrester)
[02:26:38] <grrrit-wm>	 (03PS9) 10Catrope: ve.ce.Surface: Move insert HTML path to DM [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172748 (owner: 10Jforrester)
[02:26:50] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] ve.ce.Surface: Move insert HTML path to DM [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172748 (owner: 10Jforrester)
[02:26:58] <James_F>	 Gosh.
[02:27:17] <RoanKattouw>	 That one was legitimately me being stupid
[02:28:41] <wikibugs>	 3VisualEditor-ContentEditable, VisualEditor: Pasting lists from Microsoft Word (MS Office) injects hidden HTML cruft like <!--[if !supportLists]-->- - https://phabricator.wikimedia.org/T71821#783286 (10Jdforrester-WMF)
[02:29:13] <grrrit-wm>	 (03Merged) 10jenkins-bot: ve.ce.Surface: Move insert HTML path to DM [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172748 (owner: 10Jforrester)
[02:29:15] <grrrit-wm>	 (03CR) 10Jforrester: "Ping?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173805 (https://bugzilla.wikimedia.org/72426) (owner: 10Esanders)
[02:29:40] <grrrit-wm>	 (03PS9) 10Catrope: Provide a FileDropHandler for HTML files [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172749 (owner: 10Jforrester)
[02:32:11] <James_F>	 RoanKattouw: Do you think we should just +2 https://gerrit.wikimedia.org/r/#/c/173805/ and ride it out? Otherwise we'll be waiting for months…
[02:32:30] <RoanKattouw>	 Normally I would do that
[02:32:46] <RoanKattouw>	 But two business days before Thanksgiving, maybe not
[02:32:49] <James_F>	 But because of Thursday/Friday?
[02:32:52] <James_F>	 Eh.
[02:32:59] <James_F>	 We'll have all of Monday to sort it out.
[02:33:07] <James_F>	 And Arlo/cscott will be around to fix.
[02:33:08] <grrrit-wm>	 (03PS9) 10Catrope: Provide a FileDropHandler for CSV and TSV files [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173296 (owner: 10Jforrester)
[02:33:18] <James_F>	 We can always revert if it really does break stuff.
[02:33:23] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Provide a FileDropHandler for HTML files [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172749 (owner: 10Jforrester)
[02:33:24] <James_F>	 Parsoid team have told us it's fine.
[02:33:37] <RoanKattouw>	 Sure
[02:33:46] <RoanKattouw>	 I guess the week we should actually be worrying about it next week anyawy
[02:33:50] <James_F>	 Yes.
[02:33:54] <James_F>	 Which is "clear".
[02:34:06] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Remove data-parsoid removal hack [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173805 (https://bugzilla.wikimedia.org/72426) (owner: 10Esanders)
[02:34:24] <wikibugs>	 3VisualEditor-ContentEditable, VisualEditor-MediaWiki, VisualEditor: Preserve `data-parsoid` attribute on internal copy-paste so that Parsoid preserves e.g. syntax layout - https://phabricator.wikimedia.org/T74426#783297 (10Jdforrester-WMF)
[02:34:56] <Krinkle>	 James_F: the update-oosj-ui script for ve excludes pngs instead of rls
[02:34:58] <Krinkle>	 rtls
[02:35:07] <Krinkle>	 I assume that's on purpose, right>
[02:35:12] <James_F>	 Krinkle: Yes, that's how we roll in VE-core.
[02:35:28] <James_F>	 Krinkle: VE-core doesn't use PNGs ever, but it doesn't ship with CSSJanus.
[02:35:40] <grrrit-wm>	 (03Merged) 10jenkins-bot: Provide a FileDropHandler for HTML files [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/172749 (owner: 10Jforrester)
[02:35:57] <James_F>	 Krinkle: So we ship the RTL CSS files (for stand alone), but we don't bother copying the PNGs (which MW has for non-VE users).
[02:36:15] <grrrit-wm>	 (03Merged) 10jenkins-bot: Provide a FileDropHandler for CSV and TSV files [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173296 (owner: 10Jforrester)
[02:36:24] <Krinkle>	 James_F: OK. I'll update mediawiki core to use require(), you update the commnet over that line in the ve-core update oojs ui script?
[02:36:32] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove data-parsoid removal hack [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173805 (https://bugzilla.wikimedia.org/72426) (owner: 10Esanders)
[02:36:40] <James_F>	 Krinkle: Aha, did I not fix that? Whoops.
[02:37:28] <grrrit-wm>	 (03PS3) 10Jforrester: build: Update update-oojs.sh and update-oojs-ui.sh scripts [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175645 
[02:39:00] <grrrit-wm>	 (03Merged) 10jenkins-bot: Create 'preserveGenerated' mode for cloneElements and use in copy [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173807 (https://bugzilla.wikimedia.org/72426) (owner: 10Esanders)
[02:41:00] <grrrit-wm>	 (03PS4) 10Jforrester: build: Update update-oojs.sh and update-oojs-ui.sh scripts [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175645 
[02:41:07] <James_F>	 Krinkle: Yeah, my screw-up. Sorry!
[02:41:35] <grrrit-wm>	 (03CR) 10Krinkle: [C: 032] build: Update update-oojs.sh and update-oojs-ui.sh scripts [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175645 (owner: 10Jforrester)
[02:41:42] <James_F>	 Thanks.
[02:41:46] <Krinkle>	 yw
[02:43:50] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Filter out comments from external paste [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175392 (owner: 10Esanders)
[02:44:10] <grrrit-wm>	 (03Merged) 10jenkins-bot: build: Update update-oojs.sh and update-oojs-ui.sh scripts [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175645 (owner: 10Jforrester)
[02:45:17] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] Use newFromReplacement in insertContent (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175208 (owner: 10Esanders)
[02:45:32] <James_F>	 Krinkle: Hmmmmmm. The scripts don't work for me…
[02:45:58] <grrrit-wm>	 (03Merged) 10jenkins-bot: Filter out comments from external paste [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175392 (owner: 10Esanders)
[02:46:03] <James_F>	 jdforrester@local:~/Documents/git/vagrant/mediawiki/extensions/VisualEditor/lib/ve$ bin/update-oojs-ui.sh 
[02:46:03] <James_F>	 fatal: ambiguous argument 'lib/oojs-ui': unknown revision or path not in the working tree.
[02:46:08] * James_F sighs.
[02:46:19] <RoanKattouw>	 James_F: Maybe try putting -- before paths?
[02:46:25] <RoanKattouw>	 Or being in the right cwd
[02:46:35] <James_F>	 RoanKattouw: But it works in MW-core…
[02:46:42] <RoanKattouw>	 hah
[02:47:14] <James_F>	 RoanKattouw: Same script (path changed from "resources/lib/oojs-ui" to "lib/oojs-ui", otherwise identical).
[02:47:21] <RoanKattouw>	 weird...
[02:47:27] <James_F>	 Yeah.
[02:48:25] <RoanKattouw>	 Oooh
[02:48:29] <James_F>	 Does the second / magically do something in git?
[02:48:37] <James_F>	 RoanKattouw: ?
[02:48:44] <RoanKattouw>	 The reason I couldn't find Ed's unbreaking change for the command stuff is because Trevor had already merged it
[02:48:45] <RoanKattouw>	 Prematurely
[02:48:50] <James_F>	 RoanKattouw: Oh. ha.
[02:48:51] <RoanKattouw>	 James_F: I don't /think/ so?
[02:48:57] <James_F>	 RoanKattouw: :-P
[02:49:12] <RoanKattouw>	 Although I guess if there's only one slash it might be remote/refname
[02:49:16] <RoanKattouw>	 So adding -- might help
[02:49:39] <James_F>	 "git reset $TARGET_DIR && git checkout $TARGET_DIR && git fetch origin" -> "git reset $TARGET_DIR && git checkout -- $TARGET_DIR && git fetch origin"?
[02:49:48] <James_F>	 Doesn't seem to work.
[02:51:03] <grrrit-wm>	 (03PS2) 10Catrope: Update VE core submodule to master (8ca8c41) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175417 (owner: 10Esanders)
[02:51:41] <RoanKattouw>	 Is the error coming from git reset or git checkout ?
[02:51:41] <James_F>	 Oooh.
[02:51:45] <James_F>	 I'm a fool.
[02:51:46] <RoanKattouw>	 You only added -- to one of them
[02:52:07] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Update VE core submodule to master (8ca8c41) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175417 (owner: 10Esanders)
[02:53:11] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (8ca8c41) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175417 (owner: 10Esanders)
[02:54:53] <grrrit-wm>	 (03PS1) 10Jforrester: build: Fix script paths to be /bin/.. not /bin/../.. which isn't a thing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175652 
[02:54:56] <James_F>	 RoanKattouw: ^^^ *coughs*
[02:55:27] <grrrit-wm>	 (03PS1) 10Jforrester: Update OOjs UI to v0.2.2 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175653 
[02:55:38] <grrrit-wm>	 (03PS3) 10Catrope: Update VE core submodule to master (8ca8c41) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175417 (owner: 10Esanders)
[02:55:54] <grrrit-wm>	 (03PS2) 10Jforrester: Update OOjs UI to v0.2.2 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175653 
[02:56:38] <grrrit-wm>	 (03CR) 10Jforrester: "PS2: Change ID sync with MW-core pullthrough (already merged)." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175653 (owner: 10Jforrester)
[02:56:40] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] build: Fix script paths to be /bin/.. not /bin/../.. which isn't a thing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175652 (owner: 10Jforrester)
[02:57:41] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.2.2 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175653 (owner: 10Jforrester)
[02:58:10] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Update VE core submodule to master (8ca8c41) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175417 (owner: 10Esanders)
[02:58:40] <grrrit-wm>	 (03Merged) 10jenkins-bot: build: Fix script paths to be /bin/.. not /bin/../.. which isn't a thing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175652 (owner: 10Jforrester)
[02:59:28] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update VE core submodule to master (8ca8c41) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175417 (owner: 10Esanders)
[03:00:04] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update OOjs UI to v0.2.2 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175653 (owner: 10Jforrester)
[03:00:44] <grrrit-wm>	 (03PS1) 10Jforrester: Update VE core submodule to master (aad2986) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175656 
[03:00:54] <James_F>	 RoanKattouw: Busy night. :-)
[03:01:41] <RoanKattouw>	 Yeah lots of code flying around
[03:02:30] <James_F>	 RoanKattouw: Much compressed due to the delay in shipping the new pull-through script; normally we do this level of pull-throughs on Mondays, but over 12 hours not 1. :-)
[03:07:33] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Update VE core submodule to master (aad2986) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175656 (owner: 10Jforrester)
[03:08:56] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update VE core submodule to master (aad2986) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175656 (owner: 10Jforrester)
[03:10:41] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Only try to close save dialog before destroying surface if it's currently open [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175217 (owner: 10Alex Monk)
[03:11:10] <wikibugs>	 3VisualEditor-Initialisation, VisualEditor-MediaWiki, VisualEditor: Surface is not destroyed when you exit VE if you ever opened the save dialog - https://phabricator.wikimedia.org/T75589#783310 (10Jdforrester-WMF)
[03:11:25] <grrrit-wm>	 (03CR) 10Catrope: [C: 031] Register '<p># ' sequence for creating numbered lists [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175337 (owner: 10Esanders)
[03:12:05] <grrrit-wm>	 (03Merged) 10jenkins-bot: Only try to close save dialog before destroying surface if it's currently open [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175217 (owner: 10Alex Monk)
[03:13:47] <grrrit-wm>	 (03CR) 10Jforrester: [C: 04-1] "What about when the user types in [[ or {{ or <nowiki or <ref or ~~~ or == which aren't dealt with?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175336 (owner: 10Esanders)
[03:14:51] <grrrit-wm>	 (03CR) 10Jforrester: [C: 031] Catch pagedeleted errors and give the ability to re-create the page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169976 (https://bugzilla.wikimedia.org/52073) (owner: 10Alex Monk)
[03:18:09] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] Replace hacky wikitext warning listener with sequences (033 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175336 (owner: 10Esanders)
[03:18:40] <grrrit-wm>	 (03CR) 10Catrope: "@James: They are dealt with, see https://gerrit.wikimedia.org/r/#/c/175336/1/modules/ve-mw/ui/ve.ui.MWSequenceRegistry.js" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175336 (owner: 10Esanders)
[03:19:03] <James_F>	 RoanKattouw: Aha.
[03:19:49] <grrrit-wm>	 (03CR) 10Jforrester: "Aha, never mind then, more fool me. :-)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175336 (owner: 10Esanders)
[03:21:59] <wikibugs>	 3Beta-Cluster, VisualEditor: [Regression pre-wmf10] upload.beta.wmflabs.org is throwing 503s so Math function parsing is completely broken inside VE - https://phabricator.wikimedia.org/T75787#783313 (10Jdforrester-WMF)
[03:22:12] <wikibugs>	 3Beta-Cluster, VisualEditor: [Regression pre-wmf10] upload.beta.wmflabs.org is throwing 503s so all images are appearing with a broken icon inside VE - https://phabricator.wikimedia.org/T75786#783315 (10Jdforrester-WMF)
[03:25:42] <wikibugs>	 3VisualEditor: In table editor, selection N rows / columns and clicking "insert above/below" or "… left/right" should insert N rows / columns, not 1 - https://phabricator.wikimedia.org/T75227#783318 (10Jdforrester-WMF)
[03:25:52] <wikibugs>	 3VisualEditor: In table editor, selection N rows / columns and clicking "insert above/below" or "… left/right" should insert N rows / columns, not 1 - https://phabricator.wikimedia.org/T75227#751266 (10Jdforrester-WMF)
[03:26:37] <wikibugs>	 3VisualEditor-EditingTools, Multimedia, VisualEditor: VisualEditor: Insert Media - "Error creating thumbnail" - 500 server error - https://phabricator.wikimedia.org/T75584#783323 (10Jdforrester-WMF)
[03:28:33] <wikibugs>	 3VisualEditor: Combine imageinfo requests - https://phabricator.wikimedia.org/T75822 (10Catrope) 3NEW p:3Triage
[03:37:32] <wikibugs>	 3VisualEditor: LinkCache sends API requests for URL-encoded page names, gets "invalid" responses back when descending into template contents - https://phabricator.wikimedia.org/T75823 (10Catrope) 3NEW p:3Triage
[03:57:09] <grrrit-wm>	 (03PS7) 10Jforrester: [wip] Eventify the TemplateData Editor [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/157174 (owner: 10Mooeypoo)
[03:57:17] <grrrit-wm>	 (03CR) 10Jforrester: "ping" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/157174 (owner: 10Mooeypoo)
[03:57:28] <mooeypoo>	 I was just thinking about that one
[03:57:34] <James_F>	 :-)
[03:57:46] <mooeypoo>	 James_F, it is irrelevant now with the new ooui migration, but I am keeping it a bit for reference
[03:57:55] <mooeypoo>	 it would have eventified the *previous* version
[03:58:28] <James_F>	 mooeypoo: ooooog.
[03:58:30] <James_F>	 Oh dear.
[03:58:38] <mooeypoo>	 hm?
[03:58:40] <James_F>	 Quality timely code review there. :-(
[03:59:26] * James_F heads home.
[03:59:44] <mooeypoo>	 Yeah
[04:00:08] <mooeypoo>	 We were going a bit in circles with krinkle. I'm trying to add this functionality back into the ooui migration now, though.
[04:31:32] <grrrit-wm>	 (03PS17) 10Mooeypoo: Eventify TemplateDataGenerator and use oojs-ui [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 
[04:36:14] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Eventify TemplateDataGenerator and use oojs-ui [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 (owner: 10Mooeypoo)
[05:32:19] <grrrit-wm>	 (03PS1) 10Mooeypoo: Correct placement of <noinclude> tags [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/175661 
[05:52:50] <wikibugs>	 3VisualEditor-MediaWiki, VisualEditor: VisualEditor: [[MediaWiki:Anoneditwarning]] has an editor-specific link rather than taking you to the appropriate one - https://phabricator.wikimedia.org/T55746#783456 (10Mattflaschen) Note, Steven added a [custom workaround](https://en.wikipedia.org/w/index.php?title=Media...
[06:06:58] <grrrit-wm>	 (03PS18) 10Mooeypoo: Eventify TemplateDataGenerator and use oojs-ui [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 
[06:08:09] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Eventify TemplateDataGenerator and use oojs-ui [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 (owner: 10Mooeypoo)
[06:57:28] <grrrit-wm>	 (03PS19) 10Mooeypoo: Eventify TemplateDataGenerator and use oojs-ui [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 
[06:58:11] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Eventify TemplateDataGenerator and use oojs-ui [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 (owner: 10Mooeypoo)
[09:09:04] <wikibugs>	 3MediaWiki-extensions-Cite: Cite: when using "group=" attribute within "ref" element the space can cause line-break - https://phabricator.wikimedia.org/T21303#783704 (10Bub_s) 5Open>3Resolved a:3Bub_s Hi,  It no longer is a problem, at least on french Wikipedia displayed with skin Vector.  I just tested an...
[09:22:03] <grrrit-wm>	 (03Restored) 10Jagori79: WIP [BrowserTest] Use rspec-expectations expect syntax instead of should syntax [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146712 (https://bugzilla.wikimedia.org/66369) (owner: 10Jagori79)
[10:28:21] <wikibugs>	 3VisualEditor: VisualEditor does not open at en.wikipedia.beta.wmflabs.org - https://phabricator.wikimedia.org/T75858#783870 (10zeljkofilipin)
[11:31:00] <wikibugs>	 3MediaWiki-extensions-WikiEditor: Convert ext.wikiEditor.tests.toolbar to QUnit - https://phabricator.wikimedia.org/T39485#783953 (10happy5214)
[11:54:31] <grrrit-wm>	 (03PS1) 10Esanders: Add missing file ProgressDialog.js [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175680 
[11:58:19] <grrrit-wm>	 (03PS2) 10Esanders: Add missing files for ProgressDialog. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175680 
[12:21:39] <grrrit-wm>	 (03CR) 10Esanders: Find and replace (0314 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/174491 (owner: 10Esanders)
[12:22:31] <grrrit-wm>	 (03CR) 10Esanders: Move toolbar scroll hack to surface (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175305 (owner: 10Esanders)
[12:22:46] <grrrit-wm>	 (03PS5) 10Esanders: Find and replace tool [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175306 
[12:22:48] <grrrit-wm>	 (03PS10) 10Esanders: Find and replace [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/174491 
[12:22:53] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Find and replace tool [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175306 (owner: 10Esanders)
[12:22:55] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Find and replace [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/174491 (owner: 10Esanders)
[12:35:47] <grrrit-wm>	 (03CR) 10Esanders: Create ve.ui.Sequence which matches commands to typed text (035 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175334 (owner: 10Esanders)
[12:44:20] <grrrit-wm>	 (03CR) 10Esanders: "For the record I love how much functionality this changes with one line." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175337 (owner: 10Esanders)
[12:44:38] <grrrit-wm>	 (03PS2) 10Esanders: Register '<p># ' sequence for creating numbered lists [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175337 
[12:44:40] <grrrit-wm>	 (03PS2) 10Esanders: Replace hacky wikitext warning listener with sequences [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175336 
[12:44:50] <grrrit-wm>	 (03CR) 10Esanders: Replace hacky wikitext warning listener with sequences (033 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175336 (owner: 10Esanders)
[12:45:46] <grrrit-wm>	 (03PS4) 10Esanders: Create ve.ui.Sequence which matches commands to typed text [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175334 
[12:45:49] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Register '<p># ' sequence for creating numbered lists [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175337 (owner: 10Esanders)
[12:45:58] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Replace hacky wikitext warning listener with sequences [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175336 (owner: 10Esanders)
[12:46:44] <grrrit-wm>	 (03CR) 10Esanders: "ping" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175305 (owner: 10Esanders)
[12:47:37] <grrrit-wm>	 (03CR) 10Esanders: [C: 04-1] Correct placement of <noinclude> tags (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/175661 (owner: 10Mooeypoo)
[13:18:40] <wikibugs>	 3MediaWiki-extensions-WikiEditor: Remove button for <big> from toolbar - https://phabricator.wikimedia.org/T40487#784133 (10Gadget850) On enwiki we replace <big> with the {{big}} template where appropriate. I have found instances where <big> should have never been used at all and the markup just needs to be remo...
[14:03:17] <grrrit-wm>	 (03PS1) 10Happy5214: Add QUnit test for ext.wikiEditor.toolbar [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/175698 
[14:13:05] <grrrit-wm>	 (03PS1) 10Esanders: Files, messages and toolbar config for find and replace [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175699 
[14:14:13] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Files, messages and toolbar config for find and replace [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175699 (owner: 10Esanders)
[14:20:52] <grrrit-wm>	 (03PS1) 10Esanders: Fix rounded corners issue on help button by destroying notices [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175700 
[14:38:52] <grrrit-wm>	 (03PS5) 10Esanders: Editable blockquotes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134835 (https://bugzilla.wikimedia.org/51009) 
[14:44:07] <grrrit-wm>	 (03CR) 10Esanders: "James: Nested blockquotes get alienated and roundtrip cleanly." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134835 (https://bugzilla.wikimedia.org/51009) (owner: 10Esanders)
[15:36:05] <wikibugs>	 3VisualEditor: VisualEditor does not load on beta labs - https://phabricator.wikimedia.org/T75896 (10Cmcmahon) 3NEW p:3High
[15:36:40] <grrrit-wm>	 (03PS1) 10Esanders: Fix demo width now that OOUI sets max height [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175709 
[16:34:07] <grrrit-wm>	 (03PS3) 10Esanders: Add missing files for ProgressDialog. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175680 
[16:34:09] <grrrit-wm>	 (03PS2) 10Esanders: Files, messages and config for find and replace [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175699 
[16:34:11] <grrrit-wm>	 (03PS1) 10Esanders: Create ve.ui.MWCommandHelpDialog.css for height hack [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175723 
[16:34:14] <grrrit-wm>	 (03PS3) 10Esanders: Move toolbar scroll hack to surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175305 
[16:34:15] <grrrit-wm>	 (03PS6) 10Esanders: Find and replace tool [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175306 
[16:34:17] <grrrit-wm>	 (03PS11) 10Esanders: Find and replace [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/174491 
[16:34:19] <grrrit-wm>	 (03PS1) 10Esanders: Reduce height hack on command help dialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175724 
[16:35:41] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Files, messages and config for find and replace [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175699 (owner: 10Esanders)
[16:36:06] <grrrit-wm>	 (03PS4) 10Jforrester: VisualEditor.php: Add missing files for ProgressDialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175680 (owner: 10Esanders)
[16:36:15] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] VisualEditor.php: Add missing files for ProgressDialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175680 (owner: 10Esanders)
[16:37:14] <grrrit-wm>	 (03PS1) 10Esanders: Rename variables in surface#execute for clarity [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175726 
[16:37:48] <grrrit-wm>	 (03Merged) 10jenkins-bot: VisualEditor.php: Add missing files for ProgressDialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175680 (owner: 10Esanders)
[16:39:14] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Find and replace [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/174491 (owner: 10Esanders)
[16:39:16] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Reduce height hack on command help dialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175724 (owner: 10Esanders)
[17:01:09] <grrrit-wm>	 (03CR) 10Jforrester: [C: 04-1] "Styling for drop-down needs to be corrected for the trigger position to appear in the right place: https://imgur.com/VjdTuaG" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134835 (https://bugzilla.wikimedia.org/51009) (owner: 10Esanders)
[17:02:49] <grrrit-wm>	 (03PS2) 10Jforrester: Correct placement of <noinclude> tags [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/175661 (owner: 10Mooeypoo)
[17:02:55] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Correct placement of <noinclude> tags [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/175661 (owner: 10Mooeypoo)
[17:03:08] <grrrit-wm>	 (03CR) 10Jforrester: Correct placement of <noinclude> tags (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/175661 (owner: 10Mooeypoo)
[17:03:32] <grrrit-wm>	 (03Merged) 10jenkins-bot: Correct placement of <noinclude> tags [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/175661 (owner: 10Mooeypoo)
[17:04:10] <grrrit-wm>	 (03CR) 10Jforrester: "> For the record I love how much functionality this changes with one line." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175337 (owner: 10Esanders)
[17:11:59] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: Window: Disable transitions when changing window height to calculate content height [oojs/ui] - 10https://gerrit.wikimedia.org/r/175743 
[17:12:41] <grrrit-wm>	 (03PS2) 10Jforrester: Fix rounded corners issue on help button by destroying notices [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175700 (owner: 10Esanders)
[17:12:55] <grrrit-wm>	 (03CR) 10Jforrester: [C: 031] Fix rounded corners issue on help button by destroying notices [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175700 (owner: 10Esanders)
[17:13:14] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "This is magical, but it fixes the issue for me." [oojs/ui] - 10https://gerrit.wikimedia.org/r/175743 (owner: 10Bartosz Dziewoński)
[17:13:25] <wikibugs>	 3VisualEditor-MediaWiki, VisualEditor: VisualEditor: Toolbar help menu doesn't render nicely if the alert (edit notices) other half of the group isn't active - https://phabricator.wikimedia.org/T63575#784862 (10Jdforrester-WMF)
[17:13:37] <wikibugs>	 3VisualEditor-MediaWiki, VisualEditor: Toolbar help menu doesn't render nicely if the alert (edit notices) other half of the group isn't active - https://phabricator.wikimedia.org/T63575#784863 (10Jdforrester-WMF) a:3Esanders
[17:13:51] <James_F>	 MatmaRex: Magical, huh? :-)
[17:14:16] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Also, some dialogs are now made a bit higher than they should be (e.g. the "verbose" dialog in OOUI demo). This is because their height is" [oojs/ui] - 10https://gerrit.wikimedia.org/r/175743 (owner: 10Bartosz Dziewoński)
[17:14:27] <wikibugs>	 3OOjs-UI: Issues with dialog sizing on first open - https://phabricator.wikimedia.org/T72061#784866 (10Jdforrester-WMF) a:3matmarex
[17:14:31] <wikibugs>	 3OOjs-UI: Issues with dialog sizing on first open - https://phabricator.wikimedia.org/T72061#719206 (10Jdforrester-WMF)
[17:14:34] <MatmaRex>	 James_F: computing sizes is the worst.
[17:14:39] * James_F nods.
[17:14:48] <James_F>	 Aka CSS sucks.
[17:14:54] <grrrit-wm>	 (03PS4) 10Esanders: Move toolbar scroll hack to surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175305 
[17:14:56] <grrrit-wm>	 (03PS7) 10Esanders: Find and replace tool [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175306 
[17:14:58] <grrrit-wm>	 (03PS12) 10Esanders: Find and replace [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/174491 
[17:15:00] <MatmaRex>	 James_F: this one is especially fun because when you debug this, the transition happens while you're in a breakpoint.
[17:15:00] <grrrit-wm>	 (03PS2) 10Esanders: Reduce height hack on command help dialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175724 
[17:15:02] <grrrit-wm>	 (03PS1) 10Esanders: Refactor WindowAction to include close and toggle methods [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175748 
[17:15:06] <MatmaRex>	 so it took me a while
[17:15:12] <MatmaRex>	 and some epiphanies.
[17:15:18] <James_F>	 MatmaRex: Ha.
[17:15:51] <James_F>	 https://gerrit.wikimedia.org/r/#/projects/mediawiki/extensions/VisualEditor,dashboards/default – 26 occurences of "esanders".
[17:15:58] <James_F>	 edsanders: You need to stop. :-)
[17:15:59] <MatmaRex>	 i'm still not entirely sure if the transitions are the real cause, or if changing these style properties causes some other magic to happen
[17:16:13] <MatmaRex>	 but it definitely fixes the issue in the demo…
[17:17:41] <James_F>	 MatmaRex: Tested in Chrome/FF/Opera/Safari/IE?
[17:18:24] <edsanders>	 so my I know my phone is ringing because I get a notification via a web service
[17:18:31] <MatmaRex>	 James_F: not quite yet
[17:18:34] <edsanders>	 I can answer it with my bluetooth headset and take the call
[17:18:37] * James_F grins at edsanders.
[17:18:39] <edsanders>	 but I still can't find the thing
[17:21:24] <edsanders>	 James_F, apparently everyone else has stopped if it's that many
[17:21:38] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Move toolbar scroll hack to surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175305 (owner: 10Esanders)
[17:21:40] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Find and replace tool [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175306 (owner: 10Esanders)
[17:21:42] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Refactor WindowAction to include close and toggle methods [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175748 (owner: 10Esanders)
[17:22:11] <James_F>	 edsanders: Partly that, also partly that you do lots of little commits (which makes for faster review) and rebase them all at once (so they bubble to the top of the limited lists).
[17:24:00] <edsanders>	 tiny commits like 174491
[17:25:26] <grrrit-wm>	 (03PS6) 10Esanders: Editable blockquotes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134835 (https://bugzilla.wikimedia.org/51009) 
[17:25:44] <grrrit-wm>	 (03CR) 10Esanders: "Done." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134835 (https://bugzilla.wikimedia.org/51009) (owner: 10Esanders)
[17:27:11] <grrrit-wm>	 (03CR) 10Jforrester: [C: 031] Editable blockquotes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134835 (https://bugzilla.wikimedia.org/51009) (owner: 10Esanders)
[17:29:19] <MatmaRex>	 James_F: i did some more testing, and NATURALLY this doesn't work in firefox, for some reason - but only for the "verbose" dialog
[17:29:28] <James_F>	 MatmaRex: Eurgh.
[17:29:45] <MatmaRex>	 (it works in IE, but it curiously was already displaying the dialogs well)
[17:30:23] <James_F>	 A bug not in IE? Gosh.
[17:30:43] <edsanders>	 James_F, there's a problem with papaparse in MW
[17:31:25] <edsanders>	 it's trying to do a document.write
[17:33:49] <James_F>	 edsanders: Huh.
[17:33:54] <James_F>	 edsanders: That's not good.
[17:34:25] <edsanders>	 no
[17:35:50] <edsanders>	 I think it just breaks the ability to use it in worker mode (async process) which we don't use anyway
[17:35:58] <edsanders>	 it still works, just throws an exception
[17:36:21] <James_F>	 Put a catch on it?
[17:41:34] <edsanders>	 wait wat
[17:41:42] <edsanders>	 How have you got such an old version?
[17:42:05] <edsanders>	 you checked in 3.1.2, the latest is 4.0.5
[17:42:37] <James_F>	 I grabbed the recommended version on the site.
[17:44:53] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 04-1] "This doesn't quite always work in Firefox for some reason, except when you're debugging it, in which case it works perfectly every time." [oojs/ui] - 10https://gerrit.wikimedia.org/r/175743 (owner: 10Bartosz Dziewoński)
[17:46:10] <edsanders>	 https://github.com/mholt/PapaParse/issues/87#issuecomment-57885358 eww
[17:46:47] <edsanders>	 James_F, the site links you to master
[17:48:08] <wikibugs>	 3VisualEditor-MediaWiki, VisualEditor-DataModel, VisualEditor: Broken browser plugins cause cruft to be injected into the page - https://phabricator.wikimedia.org/T54327#784911 (10Jdforrester-WMF)
[17:50:29] <grrrit-wm>	 (03PS1) 10Esanders: Update inexplicably old version of PapaParse library [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175758 
[17:51:14] <wikibugs>	 3VisualEditor: API design and documentation - https://phabricator.wikimedia.org/T40855#784926 (10Jdforrester-WMF)
[17:54:02] <wikibugs>	 3VisualEditor-MediaWiki-Mobile, VisualEditor-Initialisation, VisualEditor-MediaWiki, VisualEditor, VisualEditor-ContentLanguage, VisualEditor-ContentEditable, VisualEditor-EditingTools: Create remaining VisualEditor projects and migrate "tracking" tasks into the relevant projects - https://phabricator.wikimedia.or...
[17:54:16] <James_F>	 edsanders: Hmm
[17:54:52] <edsanders>	 trying to write an upstream patch
[17:54:57] <edsanders>	 but it has no config mechanism
[17:55:37] <James_F>	 Helpful.
[18:17:41] <MatmaRex>	 RoanKattouw_away: sanity check very needed: https://gerrit.wikimedia.org/r/#/c/175743/1
[18:19:11] <MatmaRex>	 RoanKattouw_away: i've also figured out why it's broken on firefox, now i just need to fix that
[18:20:42] <MatmaRex>	 when not debugging, you get this: http://i.imgur.com/8mpcLvw.png when debugging, you sometimes get this: http://i.imgur.com/gfJnz2J.png - as you can see, this is a dialog with the exact same size, except sometimes it gets the scrollbar and sometimes it doesn't
[18:20:49] <MatmaRex>	 (this is firefox-only)
[18:21:02] <RoanKattouw>	 MatmaRex: I don't really understand what's going on
[18:21:04] <MatmaRex>	 scrollbars are evil
[18:21:06] <RoanKattouw>	 What is being animated exactly?
[18:21:20] <RoanKattouw>	 Because we set the height of this.$frame to 1px, then measure the scrollHeight inside
[18:21:35] <RoanKattouw>	 Ooooh
[18:21:40] <RoanKattouw>	 But that is itself animated
[18:21:42] <RoanKattouw>	 GRAH
[18:21:43] <MatmaRex>	 height has a transition
[18:21:59] <MatmaRex>	 i'm not sure why removing it fixes the issue, to be honest
[18:22:01] <RoanKattouw>	 So we measure scrollHeight while this.$frame is animating to 1px
[18:22:07] <RoanKattouw>	 Yeah it sounds like this should OVERestimate heights
[18:22:15] <MatmaRex>	 this is kind of hard to debug, since the animation still plays when you're in a breakpoint
[18:22:17] <RoanKattouw>	 Because scrollHeight = max( naturalHeight, parentHeight )
[18:22:36] <RoanKattouw>	 That's why we set parentHeigth=1px, so that scrollHeight === naturalHeight
[18:22:39] <MatmaRex>	 i have suspicions that it has to do with scrollbars (dis)appearing
[18:23:18] <RoanKattouw>	 Maybe
[18:23:24] <RoanKattouw>	 That does affect width and height
[18:23:31] <MatmaRex>	 this change seems like a sane thing to do, regardless of the bug; and it happens to consistently fix the bug
[18:23:39] <RoanKattouw>	 Yeah
[18:23:42] <RoanKattouw>	 I don't understand why it helps
[18:23:55] <RoanKattouw>	 But you're right that it definitely fixes a conceptual flaw in our measurement strategy
[18:24:10] <edsanders>	 https://github.com/mholt/PapaParse/issues/119
[18:24:59] <grrrit-wm>	 (03CR) 10Catrope: [C: 031] "Bartosz and I talked through this on IRC and we don't understand why this fixes the bug, but we do agree that this fixes a flaw in our mea" [oojs/ui] - 10https://gerrit.wikimedia.org/r/175743 (owner: 10Bartosz Dziewoński)
[18:26:32] <MatmaRex>	 RoanKattouw: as for firefox - when not debugging, you get this: http://i.imgur.com/8mpcLvw.png when debugging, you sometimes get this: http://i.imgur.com/gfJnz2J.png - as you can see, this is a dialog with the exact same size, except sometimes it gets the scrollbar and sometimes it doesn't
[18:26:52] <MatmaRex>	 no idea why, we could probably fix it by twiddling the 'overflow' property back and forth
[18:27:38] <MatmaRex>	 RoanKattouw: i also think that we should be doing all the measurements with overflow:hidden rather than auto, to avoid scrollbar width affecting the height
[18:28:07] <RoanKattouw>	 Sounds reasonable
[18:29:56] <RoanKattouw>	 TrevorP|Away: https://gerrit.wikimedia.org/r/175147
[18:30:02] <RoanKattouw>	 Ugh, he went |Away
[18:32:16] <TrevorParscal>	 MatmaRex: that's a clever idea
[18:32:44] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Always return boolean from an action [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175333 (owner: 10Esanders)
[18:33:20] <MatmaRex>	 hm, one can't mutate PanelLayout to be (non-)scrollable?
[18:33:31] <MatmaRex>	 intentional or just not implemented?
[18:33:42] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] Create ve.ui.Sequence which matches commands to typed text (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175334 (owner: 10Esanders)
[18:33:54] <MatmaRex>	 eh, actually, i don't want to make it non-scrollable, i need to manually kill the overflow property. nevermind.
[18:34:23] <MatmaRex>	 TrevorParscal: thanks… which one? :)
[18:35:18] <wikibugs>	 3VisualEditor: Numbered list with images is not preserved after Save  - https://phabricator.wikimedia.org/T75777#785096 (10Etonkovidova)
[18:36:01] <MatmaRex>	 RoanKattouw: also, can you review a two-line monobook patch to fix OOUI dialogs not being visible on it? james got a bit uneasy when he saw me submit it. ;) https://gerrit.wikimedia.org/r/175594
[18:36:22] <grrrit-wm>	 (03Merged) 10jenkins-bot: Always return boolean from an action [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175333 (owner: 10Esanders)
[18:36:37] <MatmaRex>	 (not necessarily now, but at some point, pretty-please)
[18:36:45] <RoanKattouw>	 TrevorParscal: Could you review https://gerrit.wikimedia.org/r/#/c/175709 ? That change is over my head
[18:37:06] <RoanKattouw>	 Yeah I will
[18:37:13] <RoanKattouw>	 Except the internet here is super slow right now
[18:39:14] <TrevorParscal>	 MatmaRex: I was talking about the overflow on/off trick - does it work?
[18:39:45] <edsanders>	 RoanKattouw, we need to fix this library or ditch it
[18:39:46] <MatmaRex>	 TrevorParscal: i don't know yet. works when i do it in the debugger (inspector)
[18:39:51] <edsanders>	 can you see why he has to use document.write?
[18:40:11] <RoanKattouw>	 edsanders: Haven't looked yet; but something about a script tag?
[18:40:32] <edsanders>	 he then inspects the src to get the absolute path
[18:40:58] <RoanKattouw>	 He inspects the src of what?
[18:41:10] <James_F>	 The thing he just wrote into the document?
[18:41:47] <TrevorParscal>	 RoanKattouw: yes on review, one sec
[18:42:11] <RoanKattouw>	 TrevorParscal: Not urgent
[18:42:25] <RoanKattouw>	 Krinkle: I +1ed https://gerrit.wikimedia.org/r/#/c/175594/1 but I'd like your opinion on it too
[18:44:02] <MatmaRex>	 edsanders: it uses document.write() to insert a <script> element right after the currently executing <script> element
[18:44:21] <MatmaRex>	 edsanders: then it gets the .previousSibling (which is the currently executing <script> element) and gets its src
[18:44:31] <MatmaRex>	 (and then that src is used for some weird stuff)
[18:44:38] <edsanders>	 sure
[18:44:50] <edsanders>	 but why document.write, why not DOM
[18:45:04] <MatmaRex>	 how will you do that with DOM?
[18:45:12] <MatmaRex>	 well, i mean, you can make reasonable guesses
[18:45:36] <MatmaRex>	 (check all <script>s, grep for src that looks like what you'd need)
[18:45:49] <MatmaRex>	 i agree with you that it should be configurable, the way it's done is really stupid
[18:46:14] <TrevorParscal>	 you can also do var els = document.getElementsByTagName( 'script' ); thisEl = els[els.length - 1];
[18:46:45] <TrevorParscal>	 gets the currently executing script tag (assuming things are still loading)
[18:46:54] <MatmaRex>	 i just found that stackoverflow. clever.
[18:47:50] <edsanders>	 TrevorParscal, is that safe?
[18:48:04] <TrevorParscal>	 in Palo, the ResourceLoader rewrite in Node.js I'm working on, I use that trick to deduce the URL for future package requests
[18:48:59] <TrevorParscal>	 so it doesn't have to be embedded anywhere, and then you can load resources from any path without client config changes
[18:49:19] <TrevorParscal>	 anyway, yeah, it works everywhere from what I could tell
[18:58:21] <wikibugs>	 3VisualEditor: VisualEditor does not load on beta labs - https://phabricator.wikimedia.org/T75896#785217 (10Catrope)
[19:01:43] <edsanders>	 TrevorParscal, it gives the wrong script tag when the script is loaded asynchronously
[19:02:01] <TrevorParscal>	 yeah, it's meant to be a technique only used with synchronous stuff
[19:02:06] <Krinkle>	 RoanKattouw: Note that the dialog still looks broken in monobook after this
[19:02:12] <TrevorParscal>	 I'm using it in the startup script, for instance
[19:02:21] <Krinkle>	 RoanKattouw: tiny font
[19:02:29] <grrrit-wm>	 (03PS2) 10Bartosz Dziewoński: Window: Disable transitions when changing window height to calculate content height [oojs/ui] - 10https://gerrit.wikimedia.org/r/175743 
[19:02:43] <Krinkle>	 RoanKattouw: http://i.imgur.com/QiNTr4L.png
[19:02:48] <edsanders>	 it partially solves my problem
[19:03:00] <edsanders>	 in that when it fails it does so gracefully
[19:03:06] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "I feel like I should split the Firefox hack to a separate commit. It's just too ew." [oojs/ui] - 10https://gerrit.wikimedia.org/r/175743 (owner: 10Bartosz Dziewoński)
[19:03:08] <RoanKattouw>	 edsanders: Or, possibly not a script tag at all :O
[19:03:21] <edsanders>	 right
[19:03:28] <edsanders>	 but anything is better than document.write
[19:03:55] <RoanKattouw>	 Yes it is
[19:06:24] <TrevorParscal>	 edsanders: so https://gerrit.wikimedia.org/r/#/c/175709/1/demos/ve/demo.css,unified
[19:06:45] <edsanders>	 yup
[19:06:55] <edsanders>	 OOUI is setting max-wdith 50em these days
[19:07:08] <edsanders>	 which seems a little arbitrary...
[19:07:08] <TrevorParscal>	 ok, that's what I was going to ask
[19:07:12] <TrevorParscal>	 what are you overriding
[19:07:16] <TrevorParscal>	 yes, that does seem odd
[19:07:31] <TrevorParscal>	 well, I think I wrote it, and it was some judgement call
[19:07:34] <TrevorParscal>	 but whatever
[19:07:44] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] Fix demo width now that OOUI sets max height [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175709 (owner: 10Esanders)
[19:08:04] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Rename variables in surface#execute for clarity [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175726 (owner: 10Esanders)
[19:08:09] <grrrit-wm>	 (03PS3) 10Bartosz Dziewoński: Window: Disable transitions when changing window height to calculate content height [oojs/ui] - 10https://gerrit.wikimedia.org/r/175743 
[19:08:11] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: MessageDialog: Add Firefox hack for scrollbars when sizing dialogs [oojs/ui] - 10https://gerrit.wikimedia.org/r/175782 
[19:08:55] <MatmaRex>	 TrevorParscal: is https://gerrit.wikimedia.org/r/#/c/175782/ reasonable for ensuring we run after transition completes? it's awful :(
[19:09:04] <TrevorParscal>	 lookin
[19:09:34] <wikibugs>	 3MediaWiki-skins-MonoBook, OOjs-UI: OOjs UI: Showing a dialog example doesn't work in MediaWiki's MonoBook skin (because of z-indexes) - https://phabricator.wikimedia.org/T73650#785292 (10matmarex) 5Open>3Resolved Dialogs still look terrible, but now at least they appear!
[19:10:59] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Fix demo width now that OOUI sets max height [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175709 (owner: 10Esanders)
[19:13:18] <TrevorParscal>	 https://gerrit.wikimedia.org/r/#/c/175782/1 is about on par with other techniques we've used in the past..
[19:13:22] <wikibugs>	 3OOjs-UI: Issues with dialog sizing on first open - https://phabricator.wikimedia.org/T72061#785352 (10matmarex) For posterity, here are screenshots of the Firefox bug the patch above fixes:  | Without the hack | With the hack | | {F16136} | {F16138} |
[19:13:54] <TrevorParscal>	 MatmaRex: the problem is actually that you should be doing this as part of the ready process
[19:14:03] <TrevorParscal>	 which already times things
[19:14:08] <RoanKattouw>	 MatmaRex: Wow, I'm amazed that bug also exists in Firefox in a different form
[19:14:14] <RoanKattouw>	 The Chrome version of it is much more hilarious
[19:14:15] <TrevorParscal>	 using delay times in window manager
[19:14:22] <grrrit-wm>	 (03Merged) 10jenkins-bot: Rename variables in surface#execute for clarity [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175726 (owner: 10Esanders)
[19:14:44] <RoanKattouw>	 MatmaRex: https://code.google.com/p/chromium/issues/detail?id=387290
[19:14:49] <MatmaRex>	 RoanKattouw: yeah, i know, i might have to have some fun with the chrome version too
[19:15:04] <MatmaRex>	 RoanKattouw: right now, on chrome, big dialogs are made bigger than they should be
[19:15:17] <RoanKattouw>	 That bug might possibly be why
[19:15:24] <MatmaRex>	 http://i.imgur.com/jdqGXG2.png
[19:15:36] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 04-1] MessageDialog: Add Firefox hack for scrollbars when sizing dialogs (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/175782 (owner: 10Bartosz Dziewoński)
[19:15:46] <MatmaRex>	 TrevorParscal: hmm
[19:15:49] <RoanKattouw>	 Well -- have you set overflow: hidden; yet? It might be correct scrollbar behavior
[19:16:05] <RoanKattouw>	 MatmaRex: Look at my jsfiddle in Chrome though, it'll blow your mind
[19:16:05] <MatmaRex>	 TrevorParscal: the dialog might get resized outside of the ready process
[19:16:36] <MatmaRex>	 RoanKattouw: it does
[19:16:57] <MatmaRex>	 RoanKattouw: even if the current behavior is explainable, i'm sure i'll run into that when i try implementing the fix
[19:17:04] <RoanKattouw>	 Right
[19:17:19] <RoanKattouw>	 Well you're already forcing a reflow for Firefox, so you may already be covered
[19:17:33] <MatmaRex>	 alas, i'm forcing the reflow for firefox after the transition
[19:17:43] <MatmaRex>	 i'll need another one before the measurement and transition
[19:17:44] <RoanKattouw>	 Oh right
[19:17:46] <MatmaRex>	 anyway, this sucks
[19:17:52] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Fix rounded corners issue on help button by destroying notices [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175700 (owner: 10Esanders)
[19:19:17] <grrrit-wm>	 (03PS2) 10Catrope: Create ve.ui.MWCommandHelpDialog.css for height hack [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175723 (owner: 10Esanders)
[19:19:31] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Create ve.ui.MWCommandHelpDialog.css for height hack [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175723 (owner: 10Esanders)
[19:20:32] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: MessageDialog: Add Firefox hack for scrollbars when sizing dialogs (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/175782 (owner: 10Bartosz Dziewoński)
[19:23:17] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Catch pagedeleted errors and give the ability to re-create the page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169976 (https://bugzilla.wikimedia.org/52073) (owner: 10Alex Monk)
[19:23:54] <wikibugs>	 3VisualEditor-MediaWiki-Mobile, VisualEditor-Initialisation, VisualEditor-MediaWiki, VisualEditor, VisualEditor-ContentLanguage, VisualEditor-ContentEditable, VisualEditor-EditingTools: Create remaining VisualEditor projects and migrate "tracking" tasks into the relevant projects - https://phabricator.wikimedia.or...
[19:24:50] <MatmaRex>	 TrevorParscal: hmm, i'm trying to figure out where the times to wait are defined, and failing
[19:25:07] <MatmaRex>	 TrevorParscal: it seems that they're all set to 0 in WindowManager, and not overridden anywhere?
[19:25:09] <RoanKattouw>	 MatmaRex: OO.ui.WindowManager#getReadyDelay
[19:25:18] <MatmaRex>	 yeah, but it's 0
[19:25:20] <RoanKattouw>	 TrevorParscal: They are going to be overridden in ve.ui.WindowManager once Trevor merges my code
[19:25:27] <wikibugs>	 3VisualEditor: VisualEditor does not open at en.wikipedia.beta.wmflabs.org - https://phabricator.wikimedia.org/T75858#785384 (10Ryasmeen)
[19:25:28] <wikibugs>	 3VisualEditor: VisualEditor does not load on beta labs - https://phabricator.wikimedia.org/T75896#785385 (10Ryasmeen)
[19:25:28] <MatmaRex>	 shouldn't it be at least 250?
[19:25:28] <RoanKattouw>	 https://gerrit.wikimedia.org/r/175147
[19:25:38] <RoanKattouw>	 Yeah my code sets it to 250
[19:25:46] <RoanKattouw>	 Eventually it should be measured cleverly or something
[19:26:08] <MatmaRex>	 RoanKattouw: hm, VE only?
[19:26:12] <RoanKattouw>	 TrevorParscal: Now both me and Bartosz want you to merge https://gerrit.wikimedia.org/r/175147
[19:26:22] <RoanKattouw>	 MatmaRex: Eventually we'll have OOUI measure what the theme did
[19:26:35] <RoanKattouw>	 My commit is a hakc
[19:26:38] <MatmaRex>	 sure, but right now we could have that hack in OOUI
[19:26:51] <MatmaRex>	 it seems like that would cause less inconsistencies and torn hair, no?
[19:27:02] <RoanKattouw>	 Maybe
[19:27:12] <RoanKattouw>	 I guess for the demo that would be useful
[19:27:12] <RoanKattouw>	 TrevorParscal: Thoughts?
[19:27:26] <RoanKattouw>	 I'm just gonna keep pinging him until either his computer melts or he responds :P
[19:27:52] <wikibugs>	 3VisualEditor-MediaWiki, VisualEditor: Toolbar help menu doesn't render nicely if the alert (edit notices) other half of the group isn't active - https://phabricator.wikimedia.org/T63575#785388 (10Jdforrester-WMF)
[19:28:05] <wikibugs>	 3VisualEditor-MediaWiki, VisualEditor: When user is saving a page subsequently deleted after they started editing, show them <confirmrecreate‎> - https://phabricator.wikimedia.org/T54073#785389 (10Jdforrester-WMF)
[19:28:16] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Check wgRelevantArticleId to determine relevant page existence even on special pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174582 (https://bugzilla.wikimedia.org/66885) (owner: 10Alex Monk)
[19:28:35] <RoanKattouw>	 Krinkle|detached: Could you review https://gerrit.wikimedia.org/r/174798 please?
[19:29:08] <wikibugs>	 3VisualEditor-MediaWiki, VisualEditor: WT create tab on Special:Undelete when looking at a page is changed to "Edit source" rather than "create source", but VE tab is correct - https://phabricator.wikimedia.org/T68885#785390 (10Jdforrester-WMF)
[19:29:41] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: Use localStorage to store ve-beta-welcome-dialog (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174798 (https://bugzilla.wikimedia.org/62884) (owner: 10Alex Monk)
[19:30:37] <wikibugs>	 3VisualEditor-MediaWiki-Mobile, VisualEditor-Initialisation, VisualEditor-MediaWiki, VisualEditor, VisualEditor-ContentLanguage, VisualEditor-ContentEditable, VisualEditor-EditingTools: Create remaining VisualEditor projects and migrate "tracking" tasks into the relevant projects - https://phabricator.wikimedia.or...
[19:31:35] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 04-1] "Eh, probably needs do handle all the vendor-prefixed versions too?" [oojs/ui] - 10https://gerrit.wikimedia.org/r/175743 (owner: 10Bartosz Dziewoński)
[19:34:39] <TrevorParscal>	 MatmaRex: having fun with CSS?
[19:34:56] <grrrit-wm>	 (03PS11) 10Mooeypoo: Adding DraggableGroupElement and DraggableElement mixins [oojs/ui] - 10https://gerrit.wikimedia.org/r/172325 
[19:34:59] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Adding DraggableGroupElement and DraggableElement mixins [oojs/ui] - 10https://gerrit.wikimedia.org/r/172325 (owner: 10Mooeypoo)
[19:35:18] <TrevorParscal>	 RoanKattouw: sorry, was talking to werdna, um...
[19:35:37] <TrevorParscal>	 so, the ready timing is non-zero
[19:36:18] <TrevorParscal>	 or.. hmm
[19:36:24] <TrevorParscal>	 where is that at..
[19:37:26] <MatmaRex>	 TrevorParscal: the kind of fun you get playing with lego bricks
[19:37:30] <MatmaRex>	 and then stepping on one
[19:37:38] <MatmaRex>	 (afk)
[19:37:40] <TrevorParscal>	 lol
[19:37:42] <legoktm>	 :) :(
[19:38:44] <TrevorParscal>	 ok, i'm going to meet with kirstenMA for a bit - I may be a little afk as well
[19:40:25] <RoanKattouw>	 TrevorParscal: It's in the commit I've been trying to get you to merge :P
[19:40:28] <RoanKattouw>	 OK, yeah go for it
[19:42:42] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix rounded corners issue on help button by destroying notices [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175700 (owner: 10Esanders)
[19:42:42] <Krinkle>	 RoanKattouw: checking
[19:42:47] <grrrit-wm>	 (03Merged) 10jenkins-bot: Create ve.ui.MWCommandHelpDialog.css for height hack [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175723 (owner: 10Esanders)
[19:43:02] <grrrit-wm>	 (03Merged) 10jenkins-bot: Catch pagedeleted errors and give the ability to re-create the page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169976 (https://bugzilla.wikimedia.org/52073) (owner: 10Alex Monk)
[19:43:32] <wikibugs>	 3VisualEditor-MediaWiki, VisualEditor: When user is saving a page subsequently deleted after they started editing, show them <confirmrecreate‎> - https://phabricator.wikimedia.org/T54073#785427 (10Krenair) 5Open>3Resolved
[19:43:55] <wikibugs>	 3VisualEditor-MediaWiki, VisualEditor: When user is saving a page subsequently deleted after they started editing, show them <confirmrecreate‎> - https://phabricator.wikimedia.org/T54073#550880 (10Krenair)
[19:44:06] <grrrit-wm>	 (03Merged) 10jenkins-bot: Check wgRelevantArticleId to determine relevant page existence even on special pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174582 (https://bugzilla.wikimedia.org/66885) (owner: 10Alex Monk)
[19:44:10] <Krinkle>	 RoanKattouw: So the problem with using localStorage at the moment is, for an unknown number of users (could be significant, I do not yet know) writes will fail just fail because it's volgeprompt with resourceloader
[19:44:25] <Krinkle>	 packed, volgepropt :D
[19:44:54] <Krinkle>	 in theory cookies can be full, too. But that's theory.
[19:45:39] <wikibugs>	 3VisualEditor-MediaWiki, VisualEditor: WT create tab on Special:Undelete when looking at a page is changed to "Edit source" rather than "create source", but VE tab is correct - https://phabricator.wikimedia.org/T68885#785430 (10Krenair) 5Open>3Resolved This should now work.
[19:45:43] <RoanKattouw>	 Yes
[19:45:55] <wikibugs>	 3VisualEditor-MediaWiki, VisualEditor: WT create tab on Special:Undelete when looking at a page is changed to "Edit source" rather than "create source", but VE tab is correct - https://phabricator.wikimedia.org/T68885#785432 (10Krenair)
[19:45:57] <RoanKattouw>	 Well cookies are transmitted over the network, that's the motivation for not using them here
[19:46:02] <RoanKattouw>	 I was wondeirng if we should be using indexdb or something
[19:46:07] <Krinkle>	 RoanKattouw: Yes, but that means we might as well remove them
[19:46:20] <Krinkle>	 cause putting them in ls is gonna be a no-op for all we know
[19:46:49] <Krinkle>	 I don't have sufficient data yet, but at first sight my gut says, using localStorage is not safe at this point and will simply break the feature.
[19:47:47] <wikibugs>	 3MediaWiki-Page-editing: Image mistakenly included in paragraph anchor - https://phabricator.wikimedia.org/T18959#785447 (10Aklapper) 5Open>3stalled
[19:47:54] <wikibugs>	 3MediaWiki-Page-editing: Links to newly created pages become blue only after a too big delay - https://phabricator.wikimedia.org/T49199#785450 (10Aklapper)
[19:53:44] <Krinkle>	 RoanKattouw: What do you think?
[19:54:44] <Krinkle>	 indexdb would require poyfils in different directions and is a lot of bootstrapping. We'll need a lib in ve and mw to use in front of that, which I think theDJ is working on, and I'm monitoring it as well but thats till a few weeks ago
[19:54:47] <Krinkle>	 weeks away*
[19:57:06] <wikibugs>	 3VisualEditor: Combine imageinfo requests - https://phabricator.wikimedia.org/T75822#785515 (10Jdforrester-WMF) p:5Triage>3High
[19:57:21] <wikibugs>	 3VisualEditor: Combine imageinfo requests - https://phabricator.wikimedia.org/T75822#783325 (10Jdforrester-WMF)
[19:57:26] <wikibugs>	 3VisualEditor: Combine imageinfo requests - https://phabricator.wikimedia.org/T75822#783325 (10Jdforrester-WMF)
[19:57:58] <wikibugs>	 3VisualEditor-MediaWiki, VisualEditor: LinkCache sends API requests for URL-encoded page names, gets "invalid" responses back when descending into template contents - https://phabricator.wikimedia.org/T75823#785542 (10Jdforrester-WMF) p:5Triage>3Normal
[19:58:04] <wikibugs>	 3VisualEditor-MediaWiki, VisualEditor: LinkCache sends API requests for URL-encoded page names, gets "invalid" responses back when descending into template contents - https://phabricator.wikimedia.org/T75823#783332 (10Jdforrester-WMF)
[19:58:48] <RoanKattouw>	 Krinkle: Right. So maybe hold off on moving this stuff around until proper infrastructure exists?
[19:59:10] <Krinkle>	 Yeah. Unless the perf is more critical, then we can hack something up.
[19:59:30] <RoanKattouw>	 The cookie isn't that big a deal
[20:03:07] <wikibugs>	 3VisualEditor, Beta-Cluster: Beta Cluster: API PrefixSearch is taking a very long time to return, and returns nothing when it does - https://phabricator.wikimedia.org/T74332#785573 (10greg)
[20:03:21] <wikibugs>	 3VisualEditor-EditingTools, VisualEditor: Layout breaks in keyboard shortcuts dialog if translated messages occupy slightly more space - https://phabricator.wikimedia.org/T75552#785583 (10Jdforrester-WMF) p:5Triage>3Normal
[20:03:25] <wikibugs>	 3VisualEditor-EditingTools, VisualEditor: Layout breaks in keyboard shortcuts dialog if translated messages occupy slightly more space - https://phabricator.wikimedia.org/T75552#759054 (10Jdforrester-WMF)
[20:03:50] <James_F>	 Krinkle, RoanKattouw: This is our last cookie now, right/
[20:03:56] <James_F>	 ISTR we had more but we killed them slowly.
[20:04:32] <grrrit-wm>	 (03PS1) 10Catrope: Track new pagedeleted save error in TargetEvents [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175795 
[20:09:36] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] Follow normalisation response from category status query (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166863 (https://bugzilla.wikimedia.org/72080) (owner: 10Alex Monk)
[20:13:06] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Fix demo width now that OOUI sets max height [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175709 (owner: 10Esanders)
[20:13:37] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Update inexplicably old version of PapaParse library [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175758 (owner: 10Esanders)
[20:14:18] <RoanKattouw>	 TrevorParscal: https://gerrit.wikimedia.org/r/#/c/175748/1
[20:14:51] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Reduce height hack on command help dialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175724 (owner: 10Esanders)
[20:15:20] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Move toolbar scroll hack to surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175305 (owner: 10Esanders)
[20:15:55] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix demo width now that OOUI sets max height [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175709 (owner: 10Esanders)
[20:16:07] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update inexplicably old version of PapaParse library [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175758 (owner: 10Esanders)
[20:18:25] <grrrit-wm>	 (03Merged) 10jenkins-bot: Reduce height hack on command help dialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175724 (owner: 10Esanders)
[20:18:55] <wikibugs>	 3VisualEditor, Beta-Cluster: Beta Cluster: API PrefixSearch is taking a very long time to return, and returns nothing when it does - https://phabricator.wikimedia.org/T74332#785716 (10greg)
[20:20:29] <Krinkle>	 RoanKattouw: Hm.. that mapping strikes me as odd. I get that we'll "do it later", but just checking whether maybe it's on purpose this way. e.g. wouldn't we emit saveError, error.code from mw.Target ?
[20:20:44] <Krinkle>	 instead of mapping it to specific event and then only to break it back down again
[20:20:53] <Krinkle>	 saveErrorPageDeleted
[20:23:02] <Krinkle>	 Ugh, I'm ignoring it for now. It's got other stuff on the bandwagen.
[20:24:24] <wikibugs>	 3Beta-Cluster, VisualEditor: [Regression pre-wmf10] upload.beta.wmflabs.org is throwing 503s so all images are appearing with a broken icon inside VE - https://phabricator.wikimedia.org/T75786#785728 (10greg) I was trying to repro and hit 503s from upload as well, just loading the main page (the main logo didn't...
[20:24:33] <wikibugs>	 3MediaWiki-skins-MonoBook, OOjs-UI: OOjs UI: Showing a dialog example doesn't work in MediaWiki's MonoBook skin (because of z-indexes) - https://phabricator.wikimedia.org/T73650#785730 (10Krinkle)
[20:24:39] <wikibugs>	 3Beta-Cluster, VisualEditor: [Regression pre-wmf10] upload.beta.wmflabs.org is throwing 503s so all images are appearing with a broken icon inside VE - https://phabricator.wikimedia.org/T75786#785732 (10greg)
[20:26:20] <wikibugs>	 3Beta-Cluster, VisualEditor: [Regression pre-wmf10] upload.beta.wmflabs.org is throwing 503s so Math function parsing is completely broken inside VE - https://phabricator.wikimedia.org/T75787#785745 (10greg)
[20:26:26] <wikibugs>	 3Beta-Cluster, VisualEditor: [Regression pre-wmf10] upload.beta.wmflabs.org is throwing 503s so Math function parsing is completely broken inside VE - https://phabricator.wikimedia.org/T75787#785749 (10greg)
[20:28:38] <wikibugs>	 3Beta-Cluster, VisualEditor: [Regression pre-wmf10] upload.beta.wmflabs.org is throwing 503s so all images are appearing with a broken icon inside VE - https://phabricator.wikimedia.org/T75786#785776 (10greg)
[20:28:41] <wikibugs>	 3Beta-Cluster, VisualEditor: [Regression pre-wmf10] upload.beta.wmflabs.org is throwing 503s so Math function parsing is completely broken inside VE - https://phabricator.wikimedia.org/T75787#785777 (10greg)
[20:34:49] <edsanders>	 TrevorParscal, so that script technique works for synchronous, is there a good way to detect if you script is being loaded sync or async?
[20:47:44] <wikibugs>	 3MediaWiki-ResourceLoader: Implement ability to create wiki-modules at a user level - https://phabricator.wikimedia.org/T36958#785828 (10Krinkle)
[20:54:05] <grrrit-wm>	 (03CR) 10Jforrester: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175748 (owner: 10Esanders)
[20:54:39] <wikibugs>	 3MediaWiki-ResourceLoader: Bad cache stuck due to race condition with scap between different web servers - https://phabricator.wikimedia.org/T47877#785870 (10Krinkle)
[20:56:10] <wikibugs>	 3MediaWiki-ResourceLoader: Support loading legacy "site" and "user" modules with mw.loader - https://phabricator.wikimedia.org/T32358#785878 (10Krinkle)
[20:56:39] <chrismcmahon>	 ryasmeen: is it known that VE is completely broken for MobileFrontend on beta labs right now?
[20:57:50] <ryasmeen>	 chrismcmahon: I believe its the same bug that you reported earlier today? VE being broken in Betalabs
[20:58:15] <ryasmeen>	 https://phabricator.wikimedia.org/T75896
[20:58:19] <chrismcmahon>	 ryasmeen: oh, thanks.  I didn't even think to check regular VE :-/
[20:58:43] <wikibugs>	 3MediaWiki-ResourceLoader: Using @font-face should work from a file module stylesheet with custom 'media' attribute - https://phabricator.wikimedia.org/T36459#785889 (10Krinkle)
[20:58:54] <chrismcmahon>	 figured it would be fixed 
[20:59:26] <ryasmeen>	 not yet chrismcmahon
[21:01:37] <wikibugs>	 3MediaWiki-ResourceLoader: ResourceLoader should support lang=qqx parameter - https://phabricator.wikimedia.org/T41028#785899 (10Krinkle)
[21:01:57] <wikibugs>	 3MediaWiki-ResourceLoader: ResourceLoader should support lang=qqx parameter - https://phabricator.wikimedia.org/T33961#785904 (10Krinkle)
[21:13:37] <wikibugs>	 3MediaWiki-ResourceLoader: Make ResourceLoader a standalone library - https://phabricator.wikimedia.org/T32956#785985 (10Krinkle)
[21:13:38] <wikibugs>	 3MediaWiki-ResourceLoader: @import styles broken in modules that combine multiple stylesheets - https://phabricator.wikimedia.org/T37562#785986 (10Krinkle)
[21:13:39] <wikibugs>	 3MediaWiki-ResourceLoader: CSSMin::minify could trim a little more - https://phabricator.wikimedia.org/T37493#785987 (10Krinkle)
[21:13:47] <wikibugs>	 3MediaWiki-ResourceLoader: ResourceLoader should have a context instead of using global object variables - https://phabricator.wikimedia.org/T36738#785993 (10Krinkle)
[21:13:49] <wikibugs>	 3MediaWiki-ResourceLoader: ResourceLoader: Implement support for enhanced minification (e.g. support UglifyJS) - https://phabricator.wikimedia.org/T49437#785995 (10Krinkle)
[21:13:51] <wikibugs>	 3MediaWiki-ResourceLoader: load.php should return HTTP 500 if one or more exceptions were thrown - https://phabricator.wikimedia.org/T35917#785996 (10Krinkle)
[21:13:53] <wikibugs>	 3MediaWiki-ResourceLoader: Merge <script> tags output by ResourceLoader in the 'top' and 'bottom' queues. - https://phabricator.wikimedia.org/T27202#785999 (10Krinkle)
[21:22:17] <mooeypoo>	 gaaaah this rebase is annoying
[21:32:59] <edsanders>	 Krinkle, , is there a good way to detect if you script is being loaded sync or async?
[21:35:04] <RoanKattouw>	 Krinkle: Yeah that crap needs to be cleaned up, along with a million other things in that area
[21:36:42] <greg-g>	 why does VE not load for me on beta? others seem to be using it just fine (modulo those upload.beta issues)
[21:39:27] <RoanKattouw>	 greg-g: You're far from the only one to complain about VE in beta labs odayt
[21:40:09] <Krenair>	 My code for https://phabricator.wikimedia.org/T52868 successfully opens the cancelconfirm dialog, but on the second press it gets instantly closed again due to the existing (hidden) dialog still listening for escape events. Shouldn't OO.ui.Dialog only be listening for escape events while it's open?
[21:40:26] <greg-g>	 RoanKattouw: well, as in parts not working or it not loading at all? I get not loading at all.
[21:42:42] <ryasmeen>	 greg-g:https://phabricator.wikimedia.org/T75896
[21:43:47] <greg-g>	 ryasmeen: whew, not just me
[21:43:59] <ryasmeen>	 but 50 others yeah!
[21:44:32] <Krenair>	 (because a simple this.isOpened() check in OO.ui.Dialog.prototype.onDocumentKeyDown seems to fix it while not breaking the dialog escape handling)
[21:44:48] <RoanKattouw>	 Oh the papaparse probelm
[21:44:59] <RoanKattouw>	 James was saying it only happened if you try to use the feature, but that's not true
[21:45:03] <RoanKattouw>	 I'll disable it in the meantime
[21:50:19] <grrrit-wm>	 (03PS1) 10Catrope: Disable papaparse because it breaks everything [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175862 
[21:50:30] <RoanKattouw>	 Krenair: Good catch
[21:50:51] <RoanKattouw>	 Krenair: I think this worked by accident because closing an already-closed dialog is a no-op?
[21:50:57] <RoanKattouw>	 Also, wait
[21:51:14] <RoanKattouw>	 Krenair: What would be MUCH better is if the keydown handler was unbound when the dialog clsoed
[21:51:27] <RoanKattouw>	 Otherwise we're still executing all these handlers for every single key event
[21:51:51] <Krenair>	 yeah the isOpened check was for me to test out the idea
[21:52:37] <RoanKattouw>	 Krenair: Also could you help me out by merging https://gerrit.wikimedia.org/r/175862 real quick?
[21:54:58] <Krenair>	 looking
[21:57:12] <grrrit-wm>	 (03CR) 10Alex Monk: [C: 032] Disable papaparse because it breaks everything [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175862 (owner: 10Catrope)
[21:57:13] <Krenair>	 done
[22:00:16] <RoanKattouw>	 hanks
[22:00:22] <RoanKattouw>	 Once that lands, it should unbreak beta labs
[22:01:18] <grrrit-wm>	 (03PS3) 10SuchetaG: [WIP] Link Inspector Redesign [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174725 
[22:01:27] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [WIP] Link Inspector Redesign [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174725 (owner: 10SuchetaG)
[22:01:51] <TrevorParscal>	 edsanders: that's a good question
[22:02:03] <edsanders>	 I'm thinking using body onload?
[22:02:08] <grrrit-wm>	 (03Merged) 10jenkins-bot: Disable papaparse because it breaks everything [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175862 (owner: 10Catrope)
[22:02:17] <Krenair>	 RoanKattouw, hmm... you can't just this.$document.on( 'keydown', this.onDocumentKeyDown.bind( this ) ); and then .off the same way, can you?
[22:02:32] <RoanKattouw>	 Almost but not entirely
[22:02:51] <RoanKattouw>	 You have to do this.documentKeyDownHandler = this.onDocumentKeyDown.bind( this );
[22:02:53] <Krenair>	 the function binding breaks this, doesn't it?
[22:02:59] <Krenair>	 yeah... :(
[22:03:22] <RoanKattouw>	 ryasmeen, greg-g, etonkovidova: VE in beta labs should be unbroken now (or within the next 5 mins)
[22:03:29] <greg-g>	 coolio
[22:03:37] <etonkovidova>	 great1
[22:03:41] <etonkovidova>	 !
[22:03:41] <grrrit-wm>	 (03CR) 10Catrope: Find and replace (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/174491 (owner: 10Esanders)
[22:04:41] <ryasmeen>	 Thanks RoanKattouw!
[22:05:21] <grrrit-wm>	 (03CR) 10Catrope: Find and replace (033 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/174491 (owner: 10Esanders)
[22:06:04] <grrrit-wm>	 (03PS1) 10Alex Monk: Dialog: Only handle escape events when open [oojs/ui] - 10https://gerrit.wikimedia.org/r/175868 
[22:07:55] <grrrit-wm>	 (03CR) 10Catrope: Find and replace (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/174491 (owner: 10Esanders)
[22:08:14] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] "Comments on PS10" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/174491 (owner: 10Esanders)
[22:08:46] <RoanKattouw>	 TrevorParscal: https://gerrit.wikimedia.org/r/#/c/175868/1
[22:09:20] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] Dialog: Only handle escape events when open [oojs/ui] - 10https://gerrit.wikimedia.org/r/175868 (owner: 10Alex Monk)
[22:09:46] <grrrit-wm>	 (03PS1) 10Alex Monk: Cancel VE when escape key pressed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175869 
[22:10:04] <grrrit-wm>	 (03PS12) 10Mooeypoo: Adding DraggableGroupElement and DraggableElement mixins [oojs/ui] - 10https://gerrit.wikimedia.org/r/172325 
[22:12:06] <grrrit-wm>	 (03CR) 10Alex Monk: "(Note that I have no idea what happens on macs when you press ⌘-. with this commit)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175869 (owner: 10Alex Monk)
[22:12:08] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Adding DraggableGroupElement and DraggableElement mixins [oojs/ui] - 10https://gerrit.wikimedia.org/r/172325 (owner: 10Mooeypoo)
[22:12:35] <grrrit-wm>	 (03PS13) 10Mooeypoo: Adding DraggableGroupElement and DraggableElement mixins [oojs/ui] - 10https://gerrit.wikimedia.org/r/172325 
[22:13:03] <grrrit-wm>	 (03Merged) 10jenkins-bot: Dialog: Only handle escape events when open [oojs/ui] - 10https://gerrit.wikimedia.org/r/175868 (owner: 10Alex Monk)
[22:13:50] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] Cancel VE when escape key pressed (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175869 (owner: 10Alex Monk)
[22:14:24] <grrrit-wm>	 (03PS2) 10Ryasmeen: [Browsertest]Tests for options under Advanced Settings panel [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175589 
[22:15:06] <grrrit-wm>	 (03PS5) 10Jforrester: Create ve.ui.Sequence which matches commands to typed text [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175334 (owner: 10Esanders)
[22:15:12] <grrrit-wm>	 (03CR) 10Jforrester: Create ve.ui.Sequence which matches commands to typed text (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175334 (owner: 10Esanders)
[22:15:29] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Create ve.ui.Sequence which matches commands to typed text [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175334 (owner: 10Esanders)
[22:15:49] <wikibugs>	 3VisualEditor-EditingTools, VisualEditor: [Regression pre-wmf10] Cannot open any Citation dialog, TypeError: this.bookletLayout.focus is not a function appears in the console - https://phabricator.wikimedia.org/T75779#786197 (10Jdforrester-WMF)
[22:18:05] <grrrit-wm>	 (03Merged) 10jenkins-bot: Create ve.ui.Sequence which matches commands to typed text [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175334 (owner: 10Esanders)
[22:18:07] <edsanders>	 TrevorParscal, Krinkle|detached https://github.com/mholt/PapaParse/pull/120
[22:18:45] <edsanders>	 git status
[22:18:49] <edsanders>	 oops
[22:23:16] <edsanders>	 James_F, so what do you want to do about this library? I've submitted a pull request but who knows if he'll merge it.
[22:23:40] <James_F>	 edsanders: Fork if needed.
[22:23:44] <edsanders>	 https://github.com/edg2s/PapaParse
[22:23:55] <James_F>	 edsanders: ISTR it was you who suggested I use this one. ;-)
[22:24:02] <grrrit-wm>	 (03PS2) 10Catrope: Refactor WindowAction to include close and toggle methods [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175748 (owner: 10Esanders)
[22:24:13] <grrrit-wm>	 (03PS4) 10SuchetaG: [WIP] Link Inspector Redesign [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174725 
[22:24:39] <James_F>	 edsanders: Switch us over to your fork for now. If upstream takes it, we'll revert to theirs.
[22:25:13] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [WIP] Link Inspector Redesign [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174725 (owner: 10SuchetaG)
[22:26:50] <James_F>	 edsanders: Does that work for you?
[22:27:00] <edsanders>	 yeah - bit of a pain but hey
[22:27:19] <James_F>	 edsanders: Do you want me to do so you can address Roan's CRs of your code?
[22:27:31] <edsanders>	 I've got it
[22:27:34] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] [WIP] Link Inspector Redesign (035 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174725 (owner: 10SuchetaG)
[22:27:39] <James_F>	 Kk.
[22:27:50] <RoanKattouw>	 I'm going to pull through the sequence stuff
[22:28:55] <James_F>	 Go go.
[22:29:03] <wikibugs>	 3VisualEditor-EditingTools, VisualEditor: When user inputs */1. at the start of the line, make it a bulletted/numbered list - https://phabricator.wikimedia.org/T53408#786247 (10Jdforrester-WMF)
[22:30:03] <wikibugs>	 3VisualEditor-EditingTools, MediaWiki-extensions-UniversalLanguageSelector, VisualEditor: IME selector shows up at the bottom-right corner of the table while selecting a cell on a table or placing a cursor into it - https://phabricator.wikimedia.org/T74824#786250 (10Jdforrester-WMF)
[22:30:34] <wikibugs>	 3VisualEditor-EditingTools, MediaWiki-extensions-UniversalLanguageSelector, VisualEditor: IME selector shows up at the bottom-right corner of the table while selecting a cell on a table or placing a cursor into it - https://phabricator.wikimedia.org/T74824#764861 (10Jdforrester-WMF) >>! In T74824#783182, @Ryasme...
[22:30:36] <grrrit-wm>	 (03PS1) 10Catrope: Update VE core submodule to master (3270e6c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175871 
[22:30:51] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Update VE core submodule to master (3270e6c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175871 (owner: 10Catrope)
[22:31:23] <grrrit-wm>	 (03PS3) 10Catrope: Register '<p># ' sequence for creating numbered lists [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175337 (owner: 10Esanders)
[22:31:25] <grrrit-wm>	 (03PS3) 10Catrope: Replace hacky wikitext warning listener with sequences [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175336 (owner: 10Esanders)
[22:31:59] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (3270e6c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175871 (owner: 10Catrope)
[22:32:17] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update VE core submodule to master (3270e6c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175871 (owner: 10Catrope)
[22:33:11] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Replace hacky wikitext warning listener with sequences [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175336 (owner: 10Esanders)
[22:33:29] <grrrit-wm>	 (03PS2) 10Alex Monk: Cancel VE when escape key pressed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175869 
[22:34:54] <grrrit-wm>	 (03PS5) 10Catrope: Move toolbar scroll hack to surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175305 (owner: 10Esanders)
[22:35:00] <grrrit-wm>	 (03PS13) 10Catrope: Find and replace [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/174491 (owner: 10Esanders)
[22:35:08] <grrrit-wm>	 (03PS8) 10Catrope: Find and replace tool [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175306 (owner: 10Esanders)
[22:35:33] <grrrit-wm>	 (03PS5) 10SuchetaG: [WIP] Link Inspector Redesign [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174725 
[22:35:43] <grrrit-wm>	 (03CR) 10Esanders: Find and replace (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/174491 (owner: 10Esanders)
[22:36:28] <grrrit-wm>	 (03PS1) 10Esanders: Update PapaParse to 4.0.6 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175875 
[22:36:30] <grrrit-wm>	 (03PS1) 10Esanders: Switch to personal fork of Papa Parse [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175876 
[22:37:41] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] "Also comments on PS4" (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174725 (owner: 10SuchetaG)
[22:37:48] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Update PapaParse to 4.0.6 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175875 (owner: 10Esanders)
[22:38:17] <grrrit-wm>	 (03CR) 10Jforrester: Switch to personal fork of Papa Parse (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175876 (owner: 10Esanders)
[22:38:34] <greg-g>	 (btw, yay, VE finally works again for me in beta cluster)
[22:38:52] <James_F>	 grrrit-wm: :-)
[22:38:54] <James_F>	 Err.
[22:38:57] <James_F>	 greg-g: :-)
[22:38:58] * James_F sighs.
[22:38:58] <greg-g>	 :)
[22:39:09] <James_F>	 greg-g: We're going to have to rename gerrit to… Phabricator.
[22:39:13] <James_F>	 ;-)
[22:39:30] <grrrit-wm>	 (03PS4) 10Catrope: Replace hacky wikitext warning listener with sequences [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175336 (owner: 10Esanders)
[22:39:50] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Replace hacky wikitext warning listener with sequences [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175336 (owner: 10Esanders)
[22:39:53] <greg-g>	 differ
[22:40:02] <greg-g>	 I like differ
[22:40:06] <grrrit-wm>	 (03PS4) 10Catrope: Register '<p># ' sequence for creating numbered lists [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175337 (owner: 10Esanders)
[22:40:08] <wikibugs>	 3VisualEditor-TechnicalDebt, VisualEditor-MediaWiki, VisualEditor: Wikitext warning triggered when editing paragraph with wikitext in it, even though none was added in this edit - https://phabricator.wikimedia.org/T53751#786278 (10Jdforrester-WMF) 5declined>3Open a:3Esanders
[22:40:11] <James_F>	 greg-g: :-)
[22:40:13] <greg-g>	 :)
[22:40:14] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Register '<p># ' sequence for creating numbered lists [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175337 (owner: 10Esanders)
[22:40:32] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update PapaParse to 4.0.6 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175875 (owner: 10Esanders)
[22:40:57] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Replace hacky wikitext warning listener with sequences [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175336 (owner: 10Esanders)
[22:41:23] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Register '<p># ' sequence for creating numbered lists [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175337 (owner: 10Esanders)
[22:41:25] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] "Go go Jenkins" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175336 (owner: 10Esanders)
[22:41:39] <wikibugs>	 3VisualEditor-TechnicalDebt, VisualEditor-MediaWiki, VisualEditor: Wikitext warning triggered when editing paragraph with wikitext in it, even though none was added in this edit - https://phabricator.wikimedia.org/T53751#558791 (10Jdforrester-WMF) p:5Triage>3Normal
[22:42:06] <Krenair>	 phrrrit-wm
[22:42:13] <wikibugs>	 3VisualEditor-TechnicalDebt, VisualEditor-MediaWiki, VisualEditor: Wikitext warning triggered when editing paragraph with wikitext in it, even though none was added in this edit - https://phabricator.wikimedia.org/T53751#786287 (10Jdforrester-WMF)
[22:42:26] <James_F>	 Or Phabulist.
[22:42:31] <James_F>	 Telling tales, se?
[22:42:50] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace hacky wikitext warning listener with sequences [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175336 (owner: 10Esanders)
[22:42:52] <grrrit-wm>	 (03Merged) 10jenkins-bot: Register '<p># ' sequence for creating numbered lists [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175337 (owner: 10Esanders)
[22:43:16] <grrrit-wm>	 (03PS6) 10SuchetaG: [WIP] Link Inspector Redesign [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174725 
[22:43:30] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Refactor WindowAction to include close and toggle methods [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175748 (owner: 10Esanders)
[22:43:44] <wikibugs>	 3Beta-Cluster, VisualEditor: [Regression pre-wmf10] upload.beta.wmflabs.org is throwing 503s so all images are appearing with a broken icon inside VE - https://phabricator.wikimedia.org/T75786#786291 (10greg)
[22:43:45] <edsanders>	 TrevorParscal, I have an OOjsUI question
[22:43:58] <TrevorParscal>	 shoot
[22:44:53] <grrrit-wm>	 (03PS1) 10Esanders: Pass original event with TextInputWidget#enter [oojs/ui] - 10https://gerrit.wikimedia.org/r/175879 
[22:45:24] <grrrit-wm>	 (03PS1) 10Esanders: Add missing documentation to ToolFactory [oojs/ui] - 10https://gerrit.wikimedia.org/r/175880 
[22:45:54] <grrrit-wm>	 (03Merged) 10jenkins-bot: Refactor WindowAction to include close and toggle methods [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175748 (owner: 10Esanders)
[22:46:07] <grrrit-wm>	 (03Merged) 10jenkins-bot: Move toolbar scroll hack to surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175305 (owner: 10Esanders)
[22:47:28] <grrrit-wm>	 (03CR) 10Catrope: Find and replace (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/174491 (owner: 10Esanders)
[22:48:20] <RoanKattouw>	 TrevorParscal: I think edsanders may just have asked his question in the form of two Gerrit patchsets :P
[22:48:31] <grrrit-wm>	 (03PS7) 10SuchetaG: [WIP] Link Inspector Redesign [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174725 
[22:48:33] <edsanders>	 sort of
[22:48:46] <edsanders>	 I realised I'd forgot to commit the thing I was going to ask about
[22:48:59] <edsanders>	 https://gerrit.wikimedia.org/r/175879 
[22:49:28] <edsanders>	 so I've written that so that in FindAndReplace we can distinguish between enter and shift+enter
[22:49:44] <edsanders>	 which leads to the obvious question: should be let OOui users know about the original event
[22:49:52] <edsanders>	 or should we treat them like idiots
[22:49:57] <wikibugs>	 3Beta-Cluster, VisualEditor: [Regression pre-wmf10] upload.beta.wmflabs.org is throwing 503s so Math function parsing is completely broken inside VE - https://phabricator.wikimedia.org/T75787#786303 (10greg)
[22:50:24] <edsanders>	 other examples: Did you user have any other modifiers pressed on a keyboard/mouse event
[22:50:49] <edsanders>	 did the user click on the top half of the button (e.clientX)?
[22:51:22] <edsanders>	 did the user double or triple click (e.clickCount)
[22:51:26] <grrrit-wm>	 (03PS2) 10Jforrester: Switch to personal fork of Papa Parse [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175876 (owner: 10Esanders)
[22:51:37] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Switch to personal fork of Papa Parse [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175876 (owner: 10Esanders)
[22:53:47] <RoanKattouw>	 TrevorParscal: https://gerrit.wikimedia.org/r/175147
[22:53:59] <grrrit-wm>	 (03Merged) 10jenkins-bot: Switch to personal fork of Papa Parse [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175876 (owner: 10Esanders)
[22:54:40] <wikibugs>	 3VisualEditor: [Regression pre-wmf10] VisualEditor does not load on beta labs - https://phabricator.wikimedia.org/T75896#786335 (10Jdforrester-WMF)
[22:54:42] <grrrit-wm>	 (03PS8) 10SuchetaG: [WIP] Link Inspector Redesign [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174725 
[22:54:44] <wikibugs>	 3VisualEditor: [Regression pre-wmf10] VisualEditor does not load on beta labs - https://phabricator.wikimedia.org/T75896#784592 (10Jdforrester-WMF)
[22:54:47] <wikibugs>	 3Beta-Cluster, VisualEditor: [Regression pre-wmf10] upload.beta.wmflabs.org is throwing 503s so all images are appearing with a broken icon inside VE - https://phabricator.wikimedia.org/T75786#786337 (10Jdforrester-WMF)
[22:54:51] <wikibugs>	 3Beta-Cluster, VisualEditor: [Regression pre-wmf10] upload.beta.wmflabs.org is throwing 503s so Math function parsing is completely broken inside VE - https://phabricator.wikimedia.org/T75787#786338 (10Jdforrester-WMF)
[22:55:12] <grrrit-wm>	 (03PS9) 10Esanders: Find and replace tool [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175306 
[22:55:14] <grrrit-wm>	 (03PS14) 10Esanders: Find and replace [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/174491 
[22:55:18] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Find and replace tool [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175306 (owner: 10Esanders)
[22:55:21] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Find and replace [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/174491 (owner: 10Esanders)
[22:55:32] <grrrit-wm>	 (03CR) 10Esanders: Find and replace (034 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/174491 (owner: 10Esanders)
[22:56:05] <grrrit-wm>	 (03PS10) 10Esanders: Find and replace tool [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175306 
[22:56:07] <grrrit-wm>	 (03PS15) 10Esanders: Find and replace [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/174491 
[23:02:37] <grrrit-wm>	 (03PS1) 10Esanders: Go backwards through find and replace results on shift enter [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175883 
[23:02:42] <wikibugs>	 3VisualEditor: [Regression pre-wmf10] VisualEditor does not load on beta labs - https://phabricator.wikimedia.org/T75896#786386 (10Ryasmeen)
[23:02:49] <wikibugs>	 3VisualEditor: [Regression pre-wmf10] VisualEditor does not load on beta labs - https://phabricator.wikimedia.org/T75896#784592 (10Ryasmeen)
[23:03:39] <TrevorParscal>	 edsanders: looking now
[23:04:09] <grrrit-wm>	 (03PS1) 10Catrope: Update VE core submodule to master (486b674) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175885 
[23:05:28] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (486b674) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175885 (owner: 10Catrope)
[23:05:49] <grrrit-wm>	 (03PS1) 10Jforrester: Point wikitext markup link in warning to MW.org [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175886 
[23:06:20] <wikibugs>	 3VisualEditor-MediaWiki, VisualEditor: MediaWiki:Visualeditor-wikitext-warning-link should link mediawiki.org - https://phabricator.wikimedia.org/T69273#786415 (10Jdforrester-WMF) p:5Triage>3Low a:3Jdforrester-WMF
[23:06:29] <wikibugs>	 3VisualEditor-MediaWiki, VisualEditor: MediaWiki:Visualeditor-wikitext-warning-link should link mediawiki.org - https://phabricator.wikimedia.org/T69273#729949 (10Jdforrester-WMF)
[23:08:23] <grrrit-wm>	 (03PS2) 10Jforrester: Update VE core submodule to master (486b674) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175885 (owner: 10Catrope)
[23:09:33] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (486b674) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175885 (owner: 10Catrope)
[23:13:28] <RoanKattouw>	 sucheta: https://getcomposer.org/download/
[23:13:30] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] Set ready delay to animation duration in VE WindowManager [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175147 (owner: 10Catrope)
[23:15:55] <grrrit-wm>	 (03Merged) 10jenkins-bot: Set ready delay to animation duration in VE WindowManager [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175147 (owner: 10Catrope)
[23:17:07] <wikibugs>	 3Beta-Cluster, VisualEditor: [Regression pre-wmf10] upload.beta.wmflabs.org is throwing 503s so all images are appearing with a broken icon inside VE - https://phabricator.wikimedia.org/T75786#786448 (10Jdforrester-WMF) 5Open>3Resolved
[23:17:26] <wikibugs>	 3Beta-Cluster, VisualEditor: [Regression pre-wmf10] upload.beta.wmflabs.org is throwing 503s so Math function parsing is completely broken inside VE - https://phabricator.wikimedia.org/T75787#786450 (10Jdforrester-WMF) 5Open>3Resolved
[23:17:42] <wikibugs>	 3VisualEditor-EditingTools, MediaWiki-extensions-UniversalLanguageSelector, VisualEditor: IME selector shows up at the bottom-right corner of the table while selecting a cell on a table or placing a cursor into it - https://phabricator.wikimedia.org/T74824#786452 (10Jdforrester-WMF) 5Open>3Resolved
[23:17:44] <wikibugs>	 3VisualEditor-EditingTools, VisualEditor: Support tables (tracking) - https://phabricator.wikimedia.org/T41596#786454 (10Jdforrester-WMF)
[23:18:25] <grrrit-wm>	 (03PS3) 10Catrope: Update VE core submodule to master (486b674) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175885 
[23:18:51] <wikibugs>	 3VisualEditor-Initialisation, VisualEditor-MediaWiki, VisualEditor: Surface is not destroyed when you exit VE if you ever opened the save dialog - https://phabricator.wikimedia.org/T75589#786465 (10Jdforrester-WMF)
[23:19:45] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (486b674) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175885 (owner: 10Catrope)
[23:20:53] <ryasmeen>	 Hey James_F: I am still getting https://phabricator.wikimedia.org/T75787 and https://phabricator.wikimedia.org/T75786
[23:21:20] <RoanKattouw>	 ryasmeen: :( Those sound like infrastructure problems with beta labs itself though
[23:21:31] <James_F>	 ryasmeen: Eurgh. Now I'm getting them again. It was working briefly.
[23:21:43] <ryasmeen>	 oouf!!
[23:23:58] <wikibugs>	 3VisualEditor, Beta-Cluster: [Regression pre-wmf10] upload.beta.wmflabs.org is throwing 503s so Math function parsing is completely broken inside VE - https://phabricator.wikimedia.org/T75787#786490 (10Jdforrester-WMF)
[23:23:59] <wikibugs>	 3VisualEditor, Beta-Cluster: [Regression pre-wmf10] upload.beta.wmflabs.org is throwing 503s so all images are appearing with a broken icon inside VE - https://phabricator.wikimedia.org/T75786#786491 (10Jdforrester-WMF)
[23:25:32] <edsanders>	 TrevorParscal, thoughts?
[23:26:04] <RoanKattouw>	 edsanders: You evil bastard
[23:26:08] <RoanKattouw>	 			Array.prototype.push.apply( rects, partialRange.getClientRects() );
[23:26:16] <RoanKattouw>	 PhantomJS says: TypeError: '[object ClientRectList]' is not a valid argument for 'Function.prototype.apply'
[23:26:18] <RoanKattouw>	 And it's not wrong
[23:26:22] <RoanKattouw>	 A ClientRectList is not an array
[23:26:39] <RoanKattouw>	 (rangeFix.getClientRects)
[23:26:49] <edsanders>	 and console.log isn't a function
[23:26:55] <edsanders>	 someimtes
[23:26:58] <edsanders>	 *sometimes
[23:27:01] <RoanKattouw>	 Yeah sometimes
[23:27:27] <RoanKattouw>	 I wonder if Array.prototype.slice.apply( partialRange.getClientRects() ) will array-ify it
[23:28:00] <edsanders>	 hm
[23:28:25] <edsanders>	 probably
[23:29:27] <edsanders>	 so PJS throws an actual error?
[23:30:45] <James_F>	 edsanders: Yeah.
[23:30:56] <James_F>	 edsanders: Hence unable to merge in VE-MW.
[23:33:31] <RoanKattouw>	 I'll try fixing it that way
[23:34:27] <TrevorParscal>	 edsanders: ok, sorry, I'm trying to figure out what you are asking about
[23:34:51] <wikibugs>	 3VisualEditor: Add an explanation about Alternative text in the media adding dialog - https://phabricator.wikimedia.org/T75731#786548 (10Jdforrester-WMF) p:5Triage>3Normal a:3Jdforrester-WMF
[23:34:59] <edsanders>	 TrevorParscal, should we pass through original events
[23:35:08] <TrevorParscal>	 ah
[23:35:37] <TrevorParscal>	 because right now we turn a click event, for instance, and re-emit it without the original even object
[23:35:43] <edsanders>	 right
[23:35:53] <wikibugs>	 3VisualEditor, VisualEditor-EditingTools: When user inputs */1. at the start of the line, make it a bulletted/numbered list - https://phabricator.wikimedia.org/T53408#786560 (10Etonkovidova)
[23:36:18] <grrrit-wm>	 (03PS9) 10Alex Monk: Follow normalisation response from category status query [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166863 
[23:36:40] <TrevorParscal>	 which use case is this?
[23:36:50] <edsanders>	 in find and replace
[23:36:58] <edsanders>	 I listen to the 'enter' event on the find textbox
[23:37:06] <edsanders>	 to trigger nextButtonClick
[23:37:12] <TrevorParscal>	 because you want to know about control keys
[23:37:15] <edsanders>	 and I want shift+enter to trigger previousButtonClick
[23:37:16] <edsanders>	 right
[23:37:47] <edsanders>	 in general though, an OOui user may want to know about any modifier key on any event
[23:38:01] <edsanders>	 keyboard and mouse
[23:38:09] <TrevorParscal>	 so, one trouble there is that, since we are so clever, and we use the keydown -> setTimeout -> .value trick, we don't even have the event at the time we are emitting our own change event
[23:38:10] <edsanders>	 or other event properties
[23:39:32] <TrevorParscal>	 I guess our "change" event is so detached from a key event, that it's sort of screwing us when we want to know something detailed about the change event
[23:39:45] <TrevorParscal>	 so... you could override the TextInputWidget
[23:39:51] <TrevorParscal>	 override the event handler
[23:39:51] <ryasmeen>	 RoanKattouw: re:https://phabricator.wikimedia.org/T75779
[23:39:58] <TrevorParscal>	 and capture what you need
[23:40:02] <TrevorParscal>	 in your subclass
[23:40:26] <RoanKattouw>	 ryasmeen: Is that still broken?
[23:40:45] <ryasmeen>	 RoanKattouw:I am getting a slightly different behavior and error now, Cant close the citation dialog and the error is TypeError: this.outlineSelectWidget is undefined
[23:40:55] <RoanKattouw>	 Ugh
[23:40:55] <ryasmeen>	 Is that a separate issue?
[23:40:57] <RoanKattouw>	 I'll look
[23:44:16] <wikibugs>	 3VisualEditor: [Regression pre-wmf10]  Cannot close Citation dialog , error in the console:TypeError: this.outlineSelectWidget is undefined - https://phabricator.wikimedia.org/T75942#786588 (10Ryasmeen)
[23:44:24] <wikibugs>	 3VisualEditor, Beta-Cluster: [Regression pre-wmf10] upload.beta.wmflabs.org is throwing 503s so all images are appearing with a broken icon inside VE - https://phabricator.wikimedia.org/T75786#786599 (10hashar)
[23:44:27] <wikibugs>	 3VisualEditor, Beta-Cluster: [Regression pre-wmf10] upload.beta.wmflabs.org is throwing 503s so Math function parsing is completely broken inside VE - https://phabricator.wikimedia.org/T75787#786600 (10hashar)
[23:46:35] <wikibugs>	 3VisualEditor: In the media adding dialog, LTR direction is forced on the description field even in RTL wikis - https://phabricator.wikimedia.org/T71969#786606 (10Jdforrester-WMF)
[23:49:21] <wikibugs>	 3VisualEditor, VisualEditor-MediaWiki, VisualEditor-TechnicalDebt: Wikitext warning triggered when editing paragraph with wikitext in it, even though none was added in this edit - https://phabricator.wikimedia.org/T53751#786619 (10Etonkovidova) Verified in betalabs.
[23:50:12] <TrevorParscal>	 edsanders: does the subclass approach seem sane to you?
[23:50:57] <edsanders>	 so in this case we do have access to the event right
[23:51:24] <wikibugs>	 3VisualEditor: [Regression pre-wmf10]  Cannot close Citation dialog , error in the console:TypeError: this.outlineSelectWidget is undefined - https://phabricator.wikimedia.org/T75942#786621 (10Ryasmeen)
[23:53:05] <grrrit-wm>	 (03PS1) 10Catrope: Make BookletLayout#focus not crash when there are zero pages [oojs/ui] - 10https://gerrit.wikimedia.org/r/175892 
[23:54:26] <grrrit-wm>	 (03PS1) 10Catrope: Work around broken BooketLayout#focus method in OOUI for now [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175893 
[23:54:33] <grrrit-wm>	 (03CR) 10Trevor Parscal: Find and replace (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/174491 (owner: 10Esanders)
[23:54:47] <RoanKattouw>	 edsanders: Could you quickly merge https://gerrit.wikimedia.org/r/175893 ?
[23:56:09] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] Work around broken BooketLayout#focus method in OOUI for now [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175893 (owner: 10Catrope)
[23:57:29] <grrrit-wm>	 (03Merged) 10jenkins-bot: Work around broken BooketLayout#focus method in OOUI for now [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175893 (owner: 10Catrope)
[23:58:50] <edsanders>	 TrevorParscal, why does setTimeout prevent us from passing the event object?
[23:59:09] <TrevorParscal>	 I think we could enclose it or bind it in some way
[23:59:27] <ryasmeen>	 RoanKattouw: I reported it as a separate bug though:https://phabricator.wikimedia.org/T75942
[23:59:33] <TrevorParscal>	 I'm just saying that it's possible for multiple keypresses to occur before the timeout is executed
[23:59:42] <ryasmeen>	 or are you going to tag it against the previous one?