[00:00:04] <TrevorParscal>	 and, then the setValue gets cleaned up, and then we only emit if there was an actual change
[00:00:34] <edsanders>	 right
[00:01:15] <edsanders>	 so maybe 'change' is not a 'direct' event
[00:01:28] <wikibugs>	 3VisualEditor: [Regression pre-wmf10]  Cannot close Citation dialog , error in the console:TypeError: this.outlineSelectWidget is undefined - https://phabricator.wikimedia.org/T75942#786655 (10Jdforrester-WMF)
[00:02:00] <TrevorParscal>	 my point is, our change events are very abstract, maybe you want to have a subclass that pays attention to the key state, and then emit a different event that includes mofiier key information
[00:02:29] <TrevorParscal>	 like an input event
[00:02:31] <TrevorParscal>	 for instance
[00:02:50] <edsanders>	 I'm not talking about change events necessarily
[00:03:09] <TrevorParscal>	 yeah, I get that - that's why I'm suggesting that you have a different event
[00:03:18] <James_F>	 ryasmeen: T75942 fixed now?
[00:03:30] <TrevorParscal>	 because, change isn't unique, most of our events are abstracted a lot
[00:03:45] <ryasmeen>	 checking James_F
[00:03:46] <TrevorParscal>	 click is the closest thing we have
[00:04:06] <TrevorParscal>	 highlight, select, choose - these are very separated from the events that triggered them
[00:04:20] <TrevorParscal>	 so, doing things like CTRL+Click to choose an item will be tricky
[00:04:22] <ryasmeen>	 not yet James_F, maybe wait for a while?
[00:04:38] <Krinkle>	 edsanders: RE: "is there a good way to detect if you script is being loaded sync or async?"
[00:04:50] <Krinkle>	 edsanders: script as in, a module?
[00:05:03] <TrevorParscal>	 and I'm open to ideas about how to make that less tricky - I'm just suggesting that the change event situation is the rule not the exception
[00:05:11] <edsanders>	 script as in script
[00:05:23] <James_F>	 ryasmeen: Maybe?
[00:05:24] <Krinkle>	 edsanders: context
[00:05:38] <TrevorParscal>	 Krinkle: the conversation was mostly around whether to use doc write or DOM
[00:05:55] <wikibugs>	 3VisualEditor: Use [[ as a 'hotkey' trigger for opening the 'create a link' dialog - https://phabricator.wikimedia.org/T52093#786670 (10Jdforrester-WMF) 5declined>3Open a:5rmoen>3None
[00:06:01] <Krinkle>	 TrevorParscal: always DOM, unless you need to block the html parser for the main document, in which case you use doc.write
[00:06:15] <wikibugs>	 3VisualEditor: Use [[ as a 'hotkey' trigger for opening the 'create a link' dialog - https://phabricator.wikimedia.org/T52093#564242 (10Jdforrester-WMF) This is no longer catastrophically expensive to do. Yay.
[00:06:31] <Krinkle>	 TrevorParscal: Is this about resourceloader?\
[00:06:37] <edsanders>	 sort of
[00:06:43] <edsanders>	 it's the Papa Parse lib
[00:06:44] <wikibugs>	 3VisualEditor: Use [[ as a 'hotkey' trigger for opening the 'create a link' dialog - https://phabricator.wikimedia.org/T52093#786682 (10Jdforrester-WMF)
[00:07:11] <wikibugs>	 3VisualEditor, VisualEditor-MediaWiki: VisualEditor: Entering ";" does not trip the wikitext warning that it won't work - https://phabricator.wikimedia.org/T71689#786683 (10Jdforrester-WMF)
[00:07:28] <wikibugs>	 3VisualEditor, VisualEditor-MediaWiki: Entering ";" does not trip the wikitext warning that it won't work - https://phabricator.wikimedia.org/T71689#786686 (10Jdforrester-WMF)
[00:07:38] <Krinkle>	 edsanders: I saw that name earlier in the standaup
[00:07:56] <Krinkle>	 edsanders: Is there a bug or patch about this?
[00:08:39] <Krinkle>	 Seems like that sort of lib shouldn' t be concerned about that
[00:09:00] <edsanders>	 https://github.com/edg2s/PapaParse/commit/65388f3d50695a2aedaece2c8b3387248393bf3a
[00:09:14] <edsanders>	 it uses worker threads so needs to know it's own path
[00:10:07] <James_F>	 * its
[00:10:57] <Krinkle>	 edsanders: what csv files are we dealing with?
[00:11:10] <Krinkle>	 larger context :)
[00:11:25] <James_F>	 Krinkle: Ones that users drag in.
[00:11:27] <edsanders>	 drag and drop
[00:11:29] <edsanders>	 blame James
[00:11:42] <James_F>	 Blame users.
[00:13:30] <etonkovidova>	 ryasmeen: betalabs does not have a help icon anymore - oo-ui-icon-help. Is it a "new feature"? Or just a bug ?
[00:14:54] <RoanKattouw>	 wtf
[00:14:57] <RoanKattouw>	 etonkovidova: Where?
[00:14:57] <ryasmeen>	 etonkovidova: bug I believe :( if you could file it
[00:15:05] <Krinkle>	 Patterns like scripts[scripts.length-1] to get the script path are no associated with the quality levels of software we want to be using.  It may be state of the art in its data model, but when it comes to reality in browsers and javascript developments, that's not gonna work in any modern or large scale environment.
[00:15:38] <Krinkle>	 <Krinkle: Patterns like scripts[scripts.length-1] to get the script path are no associated with the quality levels of software we want to be using.  It may be state of the art in its data model, but when it comes to reality in browsers and javascript developments, that's not gonna work in any modern or large scale environment. 
[00:15:57] <Krinkle>	 For a Worker app like that, I think there are better established patterns. But off hand I can think of one:
[00:16:33] <etonkovidova>	 ryasmeen: sure - I will 
[00:16:46] <TrevorParscal>	 Krinkle: lol
[00:16:49] <Krinkle>	 default to no script path, by the time the library is called from user code, assume the user has set the proper path. If not, either throw, or (if you want to spoonfeed little applications) do some best effort approach as fallback like what it does now (assume loaded by standalone file etc.)
[00:16:57] <etonkovidova>	 ryasmeen: Roan just saw it and he thinks he is fixing it :)
[00:17:07] <Krinkle>	 Alternatively, if it only needs to load itself.
[00:17:07] <TrevorParscal>	 @ "Patterns like scripts[scripts.length-1] to get the script path are no associated with the quality levels of software we want to be using"
[00:17:20] <Krinkle>	 it could just.. load itself.
[00:17:23] <Krinkle>	 this.toString()
[00:17:30] <Krinkle>	 and pass that to the worker as direct script.
[00:17:59] <Krinkle>	 I realise that's upstream though, and from what i hear, they're not flexible to take advice from professionals..
[00:18:10] <Krinkle>	 So.. I guess Ed's forking it.
[00:18:11] <TrevorParscal>	 Krinkle: that might be a little extreme, I'm not guaranteeing that I'm right, but I'm pretty confident this isn't a bad way to get the blocking script tag being currently executed during page load
[00:18:11] <Krinkle>	 Cool :)
[00:18:33] <Krinkle>	 TrevorParscal: True, but that premise is too narrow to begin with.
[00:18:46] <wikibugs>	 3VisualEditor: oo-ui-icon-help is missing in beta  - https://phabricator.wikimedia.org/T75946 (10Etonkovidova) 3NEW p:3High a:3Catrope
[00:18:54] <Krinkle>	 TrevorParscal: Taking a gun and pointing it at your foot and pulling the trigger is an extremely effective way of shooting yourself in the foot.
[00:19:01] <Krinkle>	 But you may not want to be doing that.
[00:19:41] <TrevorParscal>	 I'm saying that, in a very narrow case, it's not dangerous at all, but any other case I wouldn't expect it to work
[00:20:25] <Krinkle>	 A library shouldn't need to know where it's hosted. Things get concatenated. Or loaded by a module. Or even dynamically generated. Or loaded from websockets, or localstorage, or indeed resourceloader.
[00:20:38] <TrevorParscal>	 and if you think I'm crazy, just take it from your boy John Resig http://ejohn.org/blog/degrading-script-tags/
[00:21:18] <TrevorParscal>	 and in the case of a ResourceLoader, it actually DOES need to know where to ask for more modules
[00:22:09] <Krinkle>	 TrevorParscal: yes. The module loader it configured to load modules from a certain place. Because it's agnostic in that way. 
[00:22:33] <TrevorParscal>	 that's the case I was making - I agree that other cases are suspect
[00:22:45] <Krinkle>	 But it wouldn't need to know where it itself is hosted.
[00:23:05] <edsanders>	 So the worker wouldn't work anyway in RL
[00:23:08] <wikibugs>	 3VisualEditor, VisualEditor-EditingTools: VisualEditor: Link input widget should have separate inputs for target and display text - https://phabricator.wikimedia.org/T55973#786734 (10Jdforrester-WMF)
[00:23:10] <wikibugs>	 3VisualEditor: Add a "display text" field in the link inspector - https://phabricator.wikimedia.org/T75726#786733 (10Jdforrester-WMF)
[00:23:24] <Krinkle>	 edsanders: It'd work just fine. It is given the configuration at run time, which it can pass to the worker.
[00:23:46] <TrevorParscal>	 whether you deduce it by reading the src attribute of the currently executed script tag while executing the startup module or bundle the URL as part of the startup module makes no difference, the startup module does need to know how to ask for the initial payload
[00:24:04] <Krinkle>	 the script url communicates only information to the server. The client doesn't know anything about the url it got requested with.
[00:24:34] <edsanders>	 how is my patch different? it only uses auto_script_path if script_path isn't set
[00:24:46] <Krinkle>	 I haven't looked at your patch yet in detail.
[00:24:48] <James_F>	 edsanders, TrevorParscal, Krinkle: Don't you all have more important bugs to fix? ;-)
[00:24:51] <grrrit-wm>	 (03PS9) 10SuchetaG: [WIP] Link Inspector Redesign [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174725 
[00:24:52] <Krinkle>	 I was referring to the way it did it originally.
[00:25:02] <Krinkle>	 not your approach.
[00:25:08] <TrevorParscal>	 no James_F, someone is wrong on the internet!
[00:25:15] <TrevorParscal>	 Krinkle: no worries
[00:25:43] <James_F>	 TrevorParscal: :-P
[00:26:12] <edsanders>	 right
[00:26:20] <edsanders>	 I know that is wrong
[00:26:35] <Krinkle>	 TrevorParscal: Given the current time and reality we live in, libraries that need to load more should either settle on a loader (e.g. "we support AMD, and best viewed in IE4 with 800x600 display"), or provide a configuration fo the user to provide their own.
[00:27:26] <edsanders>	 "You're the only one to speak up who's refused to hard-code the path [INTO THE LIBRARY!!!]. ... I wish you the best of luck."
[00:28:08] <Krinkle>	 And if it only needs to load itself, it wouldn't need a path of any kind.
[00:28:44] <edsanders>	 if you have any improvements feel free to edit my fork
[00:28:58] <wikibugs>	 3VisualEditor, VisualEditor-MediaWiki: Toolbar help menu doesn't render nicely if the alert (edit notices) other half of the group isn't active - https://phabricator.wikimedia.org/T63575#786740 (10Jdforrester-WMF) 5Open>3Resolved
[00:29:06] <Krinkle>	 I'm not the one working on it :)
[00:29:16] <wikibugs>	 3VisualEditor, VisualEditor-MediaWiki, VisualEditor-ContentEditable: Preserve `data-parsoid` attribute on internal copy-paste so that Parsoid preserves e.g. syntax layout - https://phabricator.wikimedia.org/T74426#786749 (10Jdforrester-WMF)
[00:29:23] <Krinkle>	 edsanders: Does it load more code or the same code?
[00:29:24] <wikibugs>	 3VisualEditor, VisualEditor-MediaWiki, VisualEditor-ContentEditable: Preserve `data-parsoid` attribute on internal copy-paste so that Parsoid preserves e.g. syntax layout - https://phabricator.wikimedia.org/T74426#786750 (10Jdforrester-WMF) 5Open>3Resolved
[00:30:30] <Krinkle>	 I'm not reading any of the code, just answering questions. Seems more useful for both our times. I can drop what I'm working on and dig into it, but I think you've got it loaded in memory already so that's probaby more useful.
[00:31:22] <wikibugs>	 3VisualEditor, VisualEditor-EditingTools: When user inputs */1. at the start of the line, make it a bulletted/numbered list - https://phabricator.wikimedia.org/T53408#786755 (10Jdforrester-WMF)
[00:31:30] <Krinkle>	 James_F: Is this new, or did we just recently upgrade? This was never enabled in ve-mw, right? Like, the parsing in workers is not a new aspect, that was always there.
[00:31:38] <James_F>	 Krinkle: New.
[00:31:52] <wikibugs>	 3VisualEditor, Parsoid: Parsoid: Page redirect is not working on betalabs - https://phabricator.wikimedia.org/T63403#786757 (10Arlolra)
[00:32:09] <wikibugs>	 3VisualEditor, Parsoid: Parsoid: Page redirect is not working on betalabs - https://phabricator.wikimedia.org/T63403#786759 (10Arlolra)
[00:32:51] <wikibugs>	 3MediaWiki-ResourceLoader: Merge <script> tags output by ResourceLoader in the 'top' and 'bottom' queues. - https://phabricator.wikimedia.org/T27202#786763 (10Krinkle)
[00:32:57] <ryasmeen>	 James_F:https://phabricator.wikimedia.org/T75942 still not working
[00:33:05] <James_F>	 ryasmeen: I know. Roan just bellowed.
[00:33:12] <ryasmeen>	 okay :)
[00:33:17] <RoanKattouw>	 RAWR
[00:33:26] <RoanKattouw>	 I hate both Trevor and Ed right now
[00:33:30] * James_F hugs RoanKattouw.
[00:33:42] <RoanKattouw>	 Ed accidentally wrote code that removes all tools that don't have commands associated with them
[00:33:58] <RoanKattouw>	 Trevor wrote code that in a very sneaky way adds some tools that are OO.ui.Tools but not ve.ui.Tools to VE
[00:34:00] <wikibugs>	 3MediaWiki-ResourceLoader: Implement pipeline for enhanced minification (e.g. support UglifyJS) - https://phabricator.wikimedia.org/T49437#786765 (10Krinkle)
[00:34:10] <RoanKattouw>	 So my fix for Ed's bug breaks because of Trevor's bug
[00:34:12] * RoanKattouw works around it
[00:34:14] <wikibugs>	 3VisualEditor, VisualEditor-MediaWiki, VisualEditor-TechnicalDebt: Wikitext warning triggered when editing paragraph with wikitext in it, even though none was added in this edit - https://phabricator.wikimedia.org/T53751#786769 (10Jdforrester-WMF)
[00:34:33] <James_F>	 :-)
[00:36:16] <wikibugs>	 3VisualEditor: oo-ui-icon-help is missing in beta - https://phabricator.wikimedia.org/T75946#786773 (10Jdforrester-WMF)
[00:36:41] <wikibugs>	 3VisualEditor: [Regression pre-wmf10] oo-ui-icon-help is missing - https://phabricator.wikimedia.org/T75946#786775 (10Jdforrester-WMF)
[00:37:13] <wikibugs>	 3VisualEditor: [Regression pre-wmf10] oo-ui-icon-help is missing - https://phabricator.wikimedia.org/T75946 (10Ryasmeen)
[00:37:38] <grrrit-wm>	 (03PS1) 10Catrope: Followup 166a52b: unbreak tools that don't have commands [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175902 
[00:37:50] <James_F>	 edsanders: ^^^ please.
[00:37:59] <ryasmeen>	 James_F: I like this cool feature in Phab to give token in a bug :D
[00:39:00] <wikibugs>	 3VisualEditor, VisualEditor-TechnicalDebt: MWPopupTool is not a subclass of ve.ui.Tool - https://phabricator.wikimedia.org/T75948 (10Catrope) 3NEW p:3Triage
[00:40:19] <grrrit-wm>	 (03PS2) 10Catrope: Make BookletLayout#focus not crash when there are zero pages or when there is no outline [oojs/ui] - 10https://gerrit.wikimedia.org/r/175892 
[00:40:48] <aharoni>	 James_F: Hallo.
[00:41:05] <James_F>	 ryasmeen: Hmm. Not sure how useful it is…
[00:41:07] <James_F>	 aharoni: Hey.
[00:41:13] <aharoni>	 So how do I get to a VE guided tour in English for example?
[00:41:29] <James_F>	 aharoni: I don't know. Done by cookie/preference maybe?
[00:41:47] <James_F>	 aharoni: superm401 would know straight away.
[00:42:07] <aharoni>	 I created a new account, enable the VE beta feature and tried to edit.
[00:42:16] <aharoni>	 I didn't see anything except the usual welcome box.
[00:49:58] <grrrit-wm>	 (03PS3) 10Krinkle: BookletLayout: Make #focus not crash when there are zero pages or when there is no outline [oojs/ui] - 10https://gerrit.wikimedia.org/r/175892 (owner: 10Catrope)
[00:50:03] <grrrit-wm>	 (03CR) 10Krinkle: [C: 032] BookletLayout: Make #focus not crash when there are zero pages or when there is no outline [oojs/ui] - 10https://gerrit.wikimedia.org/r/175892 (owner: 10Catrope)
[00:50:33] <ryasmeen>	 Okay another issue now on Betalabs
[00:50:34] <etonkovidova>	 ryasmeen: there are 'pterodactyl' and 'evil spooky haunted tree' Award Token that made me think :)
[00:50:43] <ryasmeen>	 its loading different article in VE 
[00:51:01] <Krinkle>	 RoanKattouw: How can I reproduce that crash btw?
[00:51:02] <RoanKattouw>	 What
[00:51:20] <Krinkle>	 Rp BookletLayout
[00:51:21] <Krinkle>	 RoanKattouw: BookletLayout
[00:51:42] <RoanKattouw>	 Krinkle: Revert d2b809137226db921d10ca3162aba5341d095c63 in VE-MW locally, then open the template dialog or the citation dialog (separate crash causes)
[00:51:53] <RoanKattouw>	 ryasmeen: WTF, is our code haunted?
[00:52:10] <ryasmeen>	 RoanKattouw: I dont know , this is the cherry on top:(
[00:52:24] <RoanKattouw>	 What do you mean exactly when you say "different article"?
[00:52:36] <ryasmeen>	 I mean completely diiferent content
[00:52:46] <ryasmeen>	 http://en.wikipedia.beta.wmflabs.org/w/index.php?title=25thnovemberchrome&veaction=edit
[00:52:56] <ryasmeen>	 I was editing this one
[00:53:07] <ryasmeen>	 now its all about an article on kittens
[00:53:30] <grrrit-wm>	 (03Merged) 10jenkins-bot: BookletLayout: Make #focus not crash when there are zero pages or when there is no outline [oojs/ui] - 10https://gerrit.wikimedia.org/r/175892 (owner: 10Catrope)
[00:53:43] <RoanKattouw>	 wtf
[00:54:31] <grrrit-wm>	 (03PS1) 10Catrope: Allow empty IME test suite [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175905 
[00:54:49] <RoanKattouw>	 Krinkle: Could you merge https://gerrit.wikimedia.org/r/175905 so I can unbreak the VE core pull-through?
[00:57:55] <RoanKattouw>	 Krinkle: I also need https://gerrit.wikimedia.org/r/175902 for a bug fix
[00:59:09] <Krinkle>	 RoanKattouw: Can you give a little more context on the unbreak one? I assume we don't actually have empty ime tests
[00:59:18] <RoanKattouw>	 Sorry
[00:59:25] <RoanKattouw>	 It's there to allow the set of IME tests to be of length zero
[00:59:37] <RoanKattouw>	 In VE-MW most of these tests fail (because of PhantomJS problems)
[00:59:51] <RoanKattouw>	 So we had commented out all but one of them, which happened to pass
[01:00:05] <RoanKattouw>	 Now that one also fails because of something in RangeFix
[01:00:09] <grrrit-wm>	 (03CR) 10Krinkle: Followup 166a52b: unbreak tools that don't have commands (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175902 (owner: 10Catrope)
[01:00:24] <RoanKattouw>	 So I want to disable that one too, but then there are zero IME tests, and the existing test runner throws an exception in that case
[01:00:31] <RoanKattouw>	 My commit removes that exception so we're allowed to have zero IME tests
[01:00:39] <Krinkle>	 OK
[01:00:40] <RoanKattouw>	 (where before we had 1 in VE-MW, and all of them in VE core)
[01:00:53] <Krinkle>	 And they only break (and are disabled) in ve-mw?
[01:00:57] <Krinkle>	 Or we just use Chromium in ve
[01:01:02] <grrrit-wm>	 (03CR) 10Krinkle: [C: 032] Allow empty IME test suite [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175905 (owner: 10Catrope)
[01:01:05] <RoanKattouw>	 Yeah I think it's the latter
[01:01:20] <RoanKattouw>	 They run and pass in VE core
[01:01:48] <grrrit-wm>	 (03PS2) 10Catrope: Followup 166a52b: unbreak tools that don't have commands [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175902 
[01:01:48] <RoanKattouw>	 Thanks
[01:03:15] <grrrit-wm>	 (03Merged) 10jenkins-bot: Allow empty IME test suite [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175905 (owner: 10Catrope)
[01:04:23] <grrrit-wm>	 (03PS4) 10Catrope: Update VE core submodule to master (673cf05) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175885 
[01:06:16] <grrrit-wm>	 (03PS5) 10Catrope: Update VE core submodule to master (673cf05) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175885 
[01:06:28] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Update VE core submodule to master (673cf05) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175885 (owner: 10Catrope)
[01:07:29] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] Point wikitext markup link in warning to MW.org (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175886 (owner: 10Jforrester)
[01:07:50] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update VE core submodule to master (673cf05) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175885 (owner: 10Catrope)
[01:16:34] <grrrit-wm>	 (03CR) 10Jforrester: Point wikitext markup link in warning to MW.org (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175886 (owner: 10Jforrester)
[01:16:42] <grrrit-wm>	 (03PS3) 10Catrope: Files, messages and config for find and replace [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175699 (owner: 10Esanders)
[01:17:24] <grrrit-wm>	 (03PS1) 10Jforrester: Warn users who write ';' or ':' on a new line that it won't work [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175909 
[01:17:26] <grrrit-wm>	 (03PS1) 10Jforrester: Provide '[[' and '{{' to trigger the appropriate window open actions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175910 
[01:17:28] <grrrit-wm>	 (03PS1) 10Jforrester: If the user types in ':' at the beginning of a line, make it a blockquote [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175911 
[01:17:57] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Files, messages and config for find and replace [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175699 (owner: 10Esanders)
[01:18:21] <grrrit-wm>	 (03PS20) 10Mooeypoo: Eventify TemplateDataGenerator and use oojs-ui [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 
[01:18:25] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Eventify TemplateDataGenerator and use oojs-ui [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 (owner: 10Mooeypoo)
[01:18:50] <wikibugs>	 3VisualEditor, VisualEditor-MediaWiki: Entering ";" does not trip the wikitext warning that it won't work - https://phabricator.wikimedia.org/T71689#786966 (10Jdforrester-WMF)
[01:18:55] <wikibugs>	 3VisualEditor, VisualEditor-MediaWiki: Entering ";" does not trip the wikitext warning that it won't work - https://phabricator.wikimedia.org/T71689#738941 (10Jdforrester-WMF)
[01:19:08] <wikibugs>	 3VisualEditor: Use [[ as a 'hotkey' trigger for opening the 'create a link' dialog - https://phabricator.wikimedia.org/T52093#786968 (10Jdforrester-WMF) a:3Jdforrester-WMF
[01:19:13] <wikibugs>	 3VisualEditor: Use [[ as a 'hotkey' trigger for opening the 'create a link' dialog - https://phabricator.wikimedia.org/T52093#564242 (10Jdforrester-WMF)
[01:19:53] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] "This is throwing exceptions when results are found in the internalList." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/174491 (owner: 10Esanders)
[01:20:56] <wikibugs>	 3VisualEditor: [Regression pre-wmf10]  Cannot close Citation dialog , error in the console:TypeError: this.outlineSelectWidget is undefined - https://phabricator.wikimedia.org/T75942#786974 (10Ryasmeen) Verified the fix in Betalabs
[01:21:15] <wikibugs>	 3VisualEditor, VisualEditor-EditingTools: [Regression pre-wmf10] Cannot open any Citation dialog, TypeError: this.bookletLayout.focus is not a function appears in the console - https://phabricator.wikimedia.org/T75779#786975 (10Ryasmeen) Verified the fix in Betalabs
[01:22:11] <RoanKattouw>	 Krinkle: Could you re-review https://gerrit.wikimedia.org/r/175902 ?
[01:22:22] <wikibugs>	 3VisualEditor, VisualEditor-EditingTools: [Regression pre-wmf10] Cannot open any Citation dialog, TypeError: this.bookletLayout.focus is not a function appears in the console - https://phabricator.wikimedia.org/T75779#786983 (10Jdforrester-WMF) 5Open>3Resolved
[01:22:32] <wikibugs>	 3VisualEditor: [Regression pre-wmf10]  Cannot close Citation dialog , error in the console:TypeError: this.outlineSelectWidget is undefined - https://phabricator.wikimedia.org/T75942#786984 (10Ryasmeen)
[01:23:01] <grrrit-wm>	 (03PS1) 10Catrope: ve.init.mw.trackSubscriber: Populate platform field with hack [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175912 
[01:23:15] <RoanKattouw>	 James_F: https://gerrit.wikimedia.org/r/175912
[01:24:11] <grrrit-wm>	 (03PS2) 10Catrope: ve.init.mw.trackSubscriber: Populate platform field with hack [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175912 
[01:24:39] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] "Yay for out-of-band CR." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175912 (owner: 10Catrope)
[01:26:00] <grrrit-wm>	 (03Merged) 10jenkins-bot: ve.init.mw.trackSubscriber: Populate platform field with hack [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175912 (owner: 10Catrope)
[01:31:51] <grrrit-wm>	 (03CR) 10Krinkle: [C: 032] Followup 166a52b: unbreak tools that don't have commands [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175902 (owner: 10Catrope)
[01:32:47] <ryasmeen>	 Hey James_F :) I was thinking of closing the bugs once verified against prod, like we used to do it earlier in BZ
[01:33:04] <ryasmeen>	 Should we keep doing that in phabricator too?
[01:34:05] <grrrit-wm>	 (03Merged) 10jenkins-bot: Followup 166a52b: unbreak tools that don't have commands [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175902 (owner: 10Catrope)
[01:36:06] <wikibugs>	 3VisualEditor, VisualEditor-MediaWiki: Use '{{' and '$==' wikitext fragments as keyboard shortcuts - https://phabricator.wikimedia.org/T53897#787019 (10Jdforrester-WMF) a:3Jdforrester-WMF
[01:36:14] <wikibugs>	 3VisualEditor, VisualEditor-MediaWiki: Use '{{' and '$==' wikitext fragments as keyboard shortcuts - https://phabricator.wikimedia.org/T53897#576835 (10Jdforrester-WMF)
[01:37:48] <Krinkle>	 𝖜𝖎𝖐𝖎𝖙𝖊𝖝𝖙
[01:39:21] <wikibugs>	 3VisualEditor, VisualEditor-MediaWiki: Use '{{' and '^==' wikitext fragments as keyboard shortcuts - https://phabricator.wikimedia.org/T53897#787030 (10Catrope)
[01:40:03] <grrrit-wm>	 (03PS1) 10Catrope: Update VE core submodule to master (0e7f030) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175914 
[01:40:11] <RoanKattouw>	 James_F: https://gerrit.wikimedia.org/r/175914 needs to make it before the cut
[01:40:18] <wikibugs>	 3VisualEditor, VisualEditor-MediaWiki: Use '{{' and '^==' wikitext fragments as keyboard shortcuts - https://phabricator.wikimedia.org/T53897#787031 (10Jdforrester-WMF) I've cleaned up the ask here, removing duplication (yay Phabricator).  > 4) if it's possible to convince VE to be nicer when i type '' or ''' or...
[01:40:28] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Update VE core submodule to master (0e7f030) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175914 (owner: 10Catrope)
[01:40:34] <RoanKattouw>	 Thanks
[01:40:38] <James_F>	 RoanKattouw: Yes master.
[01:41:16] <James_F>	 ryasmeen: I'd rather we closed them when they're verified against Beta Labs so they don't stay around in the devs' eyeline.
[01:41:49] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update VE core submodule to master (0e7f030) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175914 (owner: 10Catrope)
[01:41:59] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Point wikitext markup link in warning to MW.org [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175886 (owner: 10Jforrester)
[01:42:15] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Warn users who write ';' or ':' on a new line that it won't work [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175909 (owner: 10Jforrester)
[01:42:27] <James_F>	 RoanKattouw: I've got a new one coming.
[01:42:40] <grrrit-wm>	 (03CR) 10Catrope: [C: 031] Go backwards through find and replace results on shift enter [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175883 (owner: 10Esanders)
[01:43:21] <grrrit-wm>	 (03Merged) 10jenkins-bot: Point wikitext markup link in warning to MW.org [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175886 (owner: 10Jforrester)
[01:43:34] <grrrit-wm>	 (03Merged) 10jenkins-bot: Warn users who write ';' or ':' on a new line that it won't work [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175909 (owner: 10Jforrester)
[01:44:15] <wikibugs>	 3VisualEditor, VisualEditor-MediaWiki: Entering ";" does not trip the wikitext warning that it won't work - https://phabricator.wikimedia.org/T71689#787051 (10Jdforrester-WMF)
[01:44:22] <ryasmeen>	 James_F: yeah right, thats more important 
[01:44:27] <wikibugs>	 3VisualEditor, VisualEditor-MediaWiki: MediaWiki:Visualeditor-wikitext-warning-link should link mediawiki.org - https://phabricator.wikimedia.org/T69273#787052 (10Jdforrester-WMF)
[01:45:07] <RoanKattouw>	 ryasmeen, James_F: We could have separate columns for "merged", "confirmed in environment X", "confirmed in environment Y" perhaps
[01:45:19] <James_F>	 RoanKattouw: It's already 2600px wide.
[01:45:33] <James_F>	 RoanKattouw: Let's please not add any more columns unless we really think it's needed.
[01:45:59] <James_F>	 ryasmeen: We could have project tags – "Confirmed in test2", "Confirmed in enwiki"?
[01:46:30] <ryasmeen>	 instead of columns I wish we could add states like that in Status field
[01:46:44] <ryasmeen>	 James_F: yeah tags probably works too
[01:46:57] * James_F nods.
[01:47:47] <James_F>	 ryasmeen: So closed == James/QA sees it working in Beta Labs; tags added as part of the deployment verification process?
[01:47:53] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Editable blockquotes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134835 (https://bugzilla.wikimedia.org/51009) (owner: 10Esanders)
[01:48:01] <James_F>	 Yay.
[01:48:20] <wikibugs>	 3VisualEditor, VisualEditor-EditingTools: Add support for <blockquote>s - https://phabricator.wikimedia.org/T53009#787063 (10Jdforrester-WMF)
[01:48:35] <ryasmeen>	 James_F: yep sounds pretty good
[01:48:40] <James_F>	 Cool.
[01:48:50] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] Provide '[[' and '{{' to trigger the appropriate window open actions (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175910 (owner: 10Jforrester)
[01:48:55] <James_F>	 Sometimes I might mark as "closed" a little bit ahead of it working in VE.
[01:49:19] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] If the user types in ':' at the beginning of a line, make it a blockquote (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175911 (owner: 10Jforrester)
[01:49:20] <ryasmeen>	 I know before pull-through and stuffs , thats okay I guess
[01:49:24] <James_F>	 RoanKattouw: Whoops, yeah; could you fix?
[01:49:28] <RoanKattouw>	 Sure
[01:50:04] <James_F>	 Thanks.
[01:50:11] <grrrit-wm>	 (03Merged) 10jenkins-bot: Editable blockquotes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134835 (https://bugzilla.wikimedia.org/51009) (owner: 10Esanders)
[01:50:21] <grrrit-wm>	 (03PS2) 10Catrope: Provide '[[' and '{{' to trigger the appropriate window open actions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175910 (owner: 10Jforrester)
[01:50:38] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Provide '[[' and '{{' to trigger the appropriate window open actions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175910 (owner: 10Jforrester)
[01:50:44] <grrrit-wm>	 (03PS2) 10Catrope: If the user types in ':' at the beginning of a line, make it a blockquote [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175911 (owner: 10Jforrester)
[01:50:46] <grrrit-wm>	 (03CR) 10Jforrester: Provide '[[' and '{{' to trigger the appropriate window open actions (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175910 (owner: 10Jforrester)
[01:51:20] <grrrit-wm>	 (03CR) 10Jforrester: [C: 031] Provide '[[' and '{{' to trigger the appropriate window open actions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175910 (owner: 10Jforrester)
[01:52:02] <grrrit-wm>	 (03Merged) 10jenkins-bot: Provide '[[' and '{{' to trigger the appropriate window open actions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175910 (owner: 10Jforrester)
[01:52:46] <grrrit-wm>	 (03PS3) 10Catrope: If the user types in ':' at the beginning of a line, make it a blockquote [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175911 (owner: 10Jforrester)
[01:53:04] <grrrit-wm>	 (03PS1) 10Jforrester: If the user types in '==' at the start of a line, make it an H2 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175919 
[01:53:12] <grrrit-wm>	 (03PS1) 10Catrope: Update VE core submodule to master (f0a63dc) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175921 
[01:53:26] <grrrit-wm>	 (03PS4) 10Catrope: If the user types in ':' at the beginning of a line, make it a blockquote [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175911 (owner: 10Jforrester)
[01:54:07] <James_F>	 RoanKattouw: Isn't Ed's code fun? :-)
[01:54:10] <ryasmeen>	 umm RoanKattouw:VE broken again in Betalabs?
[01:54:19] <RoanKattouw>	 Ugh really?
[01:54:41] <RoanKattouw>	 Oh crap
[01:54:42] <RoanKattouw>	 My fault
[01:54:45] <marktraceur>	 God RoanKattouw, what the hell
[01:54:47] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (f0a63dc) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175921 (owner: 10Catrope)
[01:54:52] <James_F>	 RoanKattouw: What did you do?
[01:54:54] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] If the user types in ':' at the beginning of a line, make it a blockquote [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175911 (owner: 10Jforrester)
[01:54:54] <ryasmeen>	 :D
[01:54:56] <ryasmeen>	 hehe
[01:54:59] <RoanKattouw>	 James_F: The desktop/tablet hack
[01:55:06] <RoanKattouw>	 It tries to access something that doesn't exist pre-init
[01:55:06] <James_F>	 RoanKattouw: Oh. Whoops.
[01:55:08] <RoanKattouw>	 I'm gonna revert it
[01:55:10] * James_F nods.
[01:55:11] <James_F>	 Yeah.
[01:55:31] <grrrit-wm>	 (03PS1) 10Catrope: Revert "ve.init.mw.trackSubscriber: Populate platform field with hack" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175922 
[01:55:33] <grrrit-wm>	 (03PS1) 10Jforrester: Revert "ve.init.mw.trackSubscriber: Populate platform field with hack" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175923 
[01:55:35] <James_F>	 Ha.
[01:55:47] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Revert "ve.init.mw.trackSubscriber: Populate platform field with hack" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175922 (owner: 10Catrope)
[01:55:55] <grrrit-wm>	 (03Abandoned) 10Jforrester: Revert "ve.init.mw.trackSubscriber: Populate platform field with hack" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175923 (owner: 10Jforrester)
[01:55:56] <marktraceur>	 This revert ain't big enough for the two of us
[01:56:44] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] If the user types in '==' at the start of a line, make it an H2 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175919 (owner: 10Jforrester)
[01:57:11] <grrrit-wm>	 (03Merged) 10jenkins-bot: Revert "ve.init.mw.trackSubscriber: Populate platform field with hack" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175922 (owner: 10Catrope)
[01:57:22] <wikibugs>	 3VisualEditor, VisualEditor-MediaWiki: Use '{{' and '^==' wikitext fragments as keyboard shortcuts - https://phabricator.wikimedia.org/T53897#787073 (10Jdforrester-WMF)
[01:58:46] <grrrit-wm>	 (03PS2) 10Catrope: Update VE core submodule to master (f0a63dc) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175921 
[01:58:54] <grrrit-wm>	 (03PS5) 10Catrope: If the user types in ':' at the beginning of a line, make it a blockquote [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175911 (owner: 10Jforrester)
[01:58:54] <James_F>	 RoanKattouw: Ha, beat me to it.
[01:59:20] <mooeypoo>	 ooh we need the same for *
[01:59:23] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Update VE core submodule to master (f0a63dc) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175921 (owner: 10Catrope)
[01:59:35] <RoanKattouw>	 mooeypoo: Already have it :)
[01:59:39] <RoanKattouw>	 And "1. " too
[01:59:48] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Follow normalisation response from category status query [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166863 (owner: 10Alex Monk)
[01:59:52] <James_F>	 mooeypoo: Magic.
[02:00:01] <mooeypoo>	 RoanKattouw, oh! missed that :D
[02:00:14] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] If the user types in ':' at the beginning of a line, make it a blockquote [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175911 (owner: 10Jforrester)
[02:00:17] <wikibugs>	 3VisualEditor, VisualEditor-MediaWiki: [Regression ?wmf3] Non-normalised category names cause "Uncaught TypeError: Cannot read property 'hidden' of undefined" to be thrown - https://phabricator.wikimedia.org/T74080#787074 (10Jdforrester-WMF)
[02:00:27] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] If the user types in ':' at the beginning of a line, make it a blockquote [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175911 (owner: 10Jforrester)
[02:00:29] <mooeypoo>	 Pointy magic....
[02:00:33] <mooeypoo>	 bullet...pointy...magic
[02:00:36] <James_F>	 Yeah.
[02:00:37] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: fixup transitions [oojs/ui] - 10https://gerrit.wikimedia.org/r/175925 
[02:00:39] <mooeypoo>	 okay, that joke was lame to begin with.
[02:00:39] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: MessageDialog: Actually correctly calculate and set height [oojs/ui] - 10https://gerrit.wikimedia.org/r/175926 
[02:00:43] <mooeypoo>	 I shall quit while I'm ahead.
[02:00:45] <James_F>	 mooeypoo: I didn't say nothing.
[02:01:07] <MatmaRex>	 aw poop, forgot to rebase.
[02:01:11] <mooeypoo>	 James_F, you didn't have to, it was glaringly lame. But thanks :P
[02:01:17] * James_F coughs.
[02:01:46] <grrrit-wm>	 (03PS2) 10Bartosz Dziewoński: MessageDialog: Actually correctly calculate and set height [oojs/ui] - 10https://gerrit.wikimedia.org/r/175926 
[02:01:48] <grrrit-wm>	 (03PS2) 10Bartosz Dziewoński: MessageDialog: Add Firefox hack for scrollbars when sizing dialogs [oojs/ui] - 10https://gerrit.wikimedia.org/r/175782 
[02:01:50] <grrrit-wm>	 (03PS4) 10Bartosz Dziewoński: Window: Disable transitions when changing window height to calculate content height [oojs/ui] - 10https://gerrit.wikimedia.org/r/175743 
[02:02:06] <grrrit-wm>	 (03Abandoned) 10Bartosz Dziewoński: fixup transitions [oojs/ui] - 10https://gerrit.wikimedia.org/r/175925 (owner: 10Bartosz Dziewoński)
[02:02:23] <grrrit-wm>	 (03Merged) 10jenkins-bot: If the user types in '==' at the start of a line, make it an H2 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175919 (owner: 10Jforrester)
[02:02:27] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update VE core submodule to master (f0a63dc) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175921 (owner: 10Catrope)
[02:02:30] <grrrit-wm>	 (03Merged) 10jenkins-bot: Follow normalisation response from category status query [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166863 (owner: 10Alex Monk)
[02:02:34] <grrrit-wm>	 (03Merged) 10jenkins-bot: If the user types in ':' at the beginning of a line, make it a blockquote [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175911 (owner: 10Jforrester)
[02:02:42] <James_F>	 Whee.
[02:03:03] <wikibugs>	 3VisualEditor: [Regression pre-wmf10] oo-ui-icon-help is missing - https://phabricator.wikimedia.org/T75946#787079 (10Jdforrester-WMF)
[02:03:26] <wikibugs>	 3VisualEditor: Use [[ as a 'hotkey' trigger for opening the 'create a link' dialog - https://phabricator.wikimedia.org/T52093#787080 (10Jdforrester-WMF)
[02:03:31] <Krinkle>	 RoanKattouw: (ignore for now, fun quiz if/when you have a minute). An old web app has global function remove() { ..xhr/rest.. } and html   <input type="button" value="Remove user" onclick="remove()">. As of a few weeks ago in new browsers, clicking the button results in the button disappearing instead of the xhr/REST/remove happening.
[02:03:50] <Krinkle>	 Q: What is the cause.
[02:04:18] <Krinkle>	 (Q2: How will browsers fix it, because they will)
[02:29:20] <wikibugs>	 3OOjs-UI, MediaWiki-skins-MonoBook: OOjs UI: Showing a dialog example doesn't work in MediaWiki's MonoBook skin (because of z-indexes) - https://phabricator.wikimedia.org/T73650#787131 (10Jdforrester-WMF)
[02:57:57] <grrrit-wm>	 (03PS1) 10Jforrester: Follow-up I5bc30eca7: Register <visualeditor-formatdropdown-format-blockquote> [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175936 
[02:58:06] <James_F>	 Krinkle: Can I steal a +2 on https://gerrit.wikimedia.org/r/175936 from you?
[02:58:18] <James_F>	 Hmm.
[02:58:20] <James_F>	 Wait a sec.
[03:01:15] <Krinkle>	 ok
[03:01:31] <James_F>	 There.
[03:01:33] <grrrit-wm>	 (03PS2) 10Jforrester: Follow-up I5bc30eca7: Register <visualeditor-formatdropdown-format-blockquote> [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175936 
[03:01:52] <grrrit-wm>	 (03Abandoned) 10Jforrester: [WIP] Editable blockquotes in MW [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134838 (https://bugzilla.wikimedia.org/51009) (owner: 10Esanders)
[03:02:27] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Add missing documentation to ToolFactory [oojs/ui] - 10https://gerrit.wikimedia.org/r/175880 (owner: 10Esanders)
[03:02:46] <Krinkle>	 James_F: Uncaught Error: Unknown dependency: schema..Edit 
[03:03:03] <Krinkle>	 wiki/Main_Page?veaction=edit
[03:03:20] <James_F>	 Krinkle: That's because you're using an ancient checkout of WikimediaEvents or EventLogging. Can't remember which.
[03:03:28] <Krinkle>	 I doubt it
[03:03:33] <Krinkle>	 I think someone mistyped the module name
[03:03:35] <James_F>	 I, however, don't.
[03:03:44] <James_F>	 It was a fix we made to EventLogging.
[03:03:52] <Krinkle>	 To have two dots in the name?
[03:03:59] <James_F>	 It was adding a '.' after the initial piece.
[03:04:07] <James_F>	 We stopped it from doing so.
[03:04:10] <James_F>	 Yeah.
[03:04:29] <James_F>	 Krinkle: Observe master working just fine: http://en.wikipedia.beta.wmflabs.org/wiki/User:Jdforrester_(WMF)/Sandbox?veaction=edit
[03:05:04] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add missing documentation to ToolFactory [oojs/ui] - 10https://gerrit.wikimedia.org/r/175880 (owner: 10Esanders)
[03:06:03] <Krinkle>	 James_F: Right. it was EventLogging, not WikimediaEvents
[03:06:06] <wikibugs>	 3VisualEditor, VisualEditor-EditingTools: VisualEditor: Indent buttons should be used for in-/out-denting paragraphs as well as lists. - https://phabricator.wikimedia.org/T50010#787158 (10Jdforrester-WMF)
[03:06:07] <Krinkle>	 too many extensions :P
[03:06:07] <wikibugs>	 3VisualEditor, VisualEditor-EditingTools: Add support for <blockquote>s - https://phabricator.wikimedia.org/T53009#787156 (10Jdforrester-WMF)
[03:06:18] <wikibugs>	 3VisualEditor, VisualEditor-EditingTools: VisualEditor: Support for definition-lists - https://phabricator.wikimedia.org/T39938#787161 (10Jdforrester-WMF)
[03:06:35] <James_F>	 Krinkle: Yeah, I know. :-(
[03:07:14] <wikibugs>	 3VisualEditor, VisualEditor-MediaWiki: Use '{{' and '^==' wikitext fragments as keyboard shortcuts - https://phabricator.wikimedia.org/T53897#787162 (10Jdforrester-WMF) 5Open>3Resolved
[03:07:26] <wikibugs>	 3VisualEditor: Use [[ as a 'hotkey' trigger for opening the 'create a link' dialog - https://phabricator.wikimedia.org/T52093#787164 (10Jdforrester-WMF)
[03:07:42] <wikibugs>	 3VisualEditor: [Regression pre-wmf10] oo-ui-icon-help is missing - https://phabricator.wikimedia.org/T75946#787166 (10Jdforrester-WMF)
[03:07:49] <Krinkle>	 James_F: Gonna add a way to make mw.msg throw for unknown key so we can catch it in testing
[03:07:57] <James_F>	 Krinkle: Sounds good.
[03:07:58] <Krinkle>	 something like a notice, not an exception
[03:08:11] * Krinkle makes note
[03:08:15] <James_F>	 Krinkle: I've also thought of a jenkins task that looks for files not registered.
[03:08:22] <James_F>	 Krinkle: Same could be done for messages.
[03:08:40] <James_F>	 Krinkle: (Everything in modules.json should be in VisualEditor.php)
[03:08:50] <Krinkle>	 well, that's just a refactor note
[03:08:55] <Krinkle>	 we don't need that in the first place
[03:09:03] <wikibugs>	 3VisualEditor: [Regression pre-wmf10]  Cannot close Citation dialog , error in the console:TypeError: this.outlineSelectWidget is undefined - https://phabricator.wikimedia.org/T75942#787168 (10Jdforrester-WMF) 5Open>3Resolved
[03:09:18] <James_F>	 You mean, load the files directly with modules.json? Can you do that?
[03:09:26] <Krinkle>	 I don't see why not
[03:09:41] <Krinkle>	 I'd recommend against spreading it as a pattern for mediawiki in general
[03:09:50] <wikibugs>	 3VisualEditor, VisualEditor-MediaWiki: MediaWiki:Visualeditor-wikitext-warning-link should link mediawiki.org - https://phabricator.wikimedia.org/T69273#787170 (10Jdforrester-WMF)
[03:09:52] * James_F nods.
[03:09:56] <Krinkle>	 but since we're loading an upstream library and not yet using dist/ve.js, for the time being I'd recommend doing that
[03:09:56] <James_F>	 OK, let's explore that.
[03:10:42] <Krinkle>	 e.g. parse the json file and register the modules
[03:10:56] <Krinkle>	 probably a subset. but adding a module every now and then will be easier than adding files
[03:11:01] <James_F>	 Done.
[03:11:01] <wikibugs>	 3VisualEditor, VisualEditor-MediaWiki: Load VisualEditor file from modules.json as a manifest, rather than tediously copying it into VisualEditor.php - https://phabricator.wikimedia.org/T75964 (10Jdforrester-WMF) 3NEW p:3Low
[03:11:18] <wikibugs>	 3VisualEditor, VisualEditor-ContentEditable: Pasting lists from Microsoft Word (MS Office) injects hidden HTML cruft like <!--[if !supportLists]-->- - https://phabricator.wikimedia.org/T71821#787181 (10Jdforrester-WMF)
[03:12:24] <wikibugs>	 3VisualEditor, VisualEditor-MediaWiki: [Regression ?wmf3] Non-normalised category names cause "Uncaught TypeError: Cannot read property 'hidden' of undefined" to be thrown - https://phabricator.wikimedia.org/T74080#787184 (10Jdforrester-WMF)
[03:12:27] <Krinkle>	 James_F: Hm.. it's not exactly pretty
[03:12:34] <James_F>	 Krinkle: What isn't?
[03:12:34] <grrrit-wm>	 (03CR) 10Krinkle: [C: 032] Follow-up I5bc30eca7: Register <visualeditor-formatdropdown-format-blockquote> [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175936 (owner: 10Jforrester)
[03:12:41] <James_F>	 (Thanks.)
[03:12:44] <Krinkle>	 James_F: http://i.imgur.com/N3WE1WD.png
[03:13:03] <Krinkle>	 The indention is just wrong. I know why, but it's wrong. It should probably have some kind of edge
[03:13:10] <James_F>	 Krinkle: It's meant to give a feel for how it works, but yeah.
[03:13:23] <James_F>	 I'm interested in user feedback.
[03:13:35] <Krinkle>	 It makes it look like a sub-item of Preformatted
[03:13:47] <wikibugs>	 3VisualEditor, VisualEditor-MediaWiki: VisualEditor: Escape key (and on Macs additionally ⌘-. ) inside the main editor should cancel VE mode and return to action=view - https://phabricator.wikimedia.org/T52868#787186 (10Jdforrester-WMF)
[03:13:51] <James_F>	 Indeed.
[03:13:54] <grrrit-wm>	 (03Merged) 10jenkins-bot: Follow-up I5bc30eca7: Register <visualeditor-formatdropdown-format-blockquote> [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175936 (owner: 10Jforrester)
[03:14:22] <wikibugs>	 3VisualEditor, VisualEditor-MediaWiki: VisualEditor: Escape key (and on Macs additionally ⌘-. ) inside the main editor should cancel VE mode and return to action=view - https://phabricator.wikimedia.org/T52868#554398 (10Jdforrester-WMF)
[03:14:31] <Krinkle>	 James_F: I think in general blockquotes should have more styling than merely indentation.
[03:14:43] <James_F>	 Krinkle: Speak to Design. :-)
[03:14:53] <James_F>	 Krinkle: Maybe a faint trailing line in the margin?
[03:15:08] <Krinkle>	 Indeed. That's very common for blockquotes nowadays
[03:15:15] <Krinkle>	 a 3-5px border on the left, light grey
[03:15:24] * James_F nods.
[03:15:28] <Krinkle>	 possibly with a light shade behind it
[03:15:29] <James_F>	 At least in VE-core.
[03:15:30] <Krinkle>	 anyway
[03:15:35] <Krinkle>	 Right
[03:15:56] * Krinkle makes another note to revisit one day
[03:16:00] <James_F>	 In VE-MW it should look like the skin.
[03:16:02] <James_F>	 Yeah.
[03:16:05] <James_F>	 You off?
[03:16:09] <Krinkle>	 Not yet
[03:16:25] <Krinkle>	 just saying, the list Im writing this off is just to bounce when I will next complain about it :P
[03:16:32] <Krinkle>	 probably 3-4 months given the length
[03:16:33] <James_F>	 OK. :-) How's killing PhantomJS going?
[03:16:40] * James_F grins.
[03:16:57] <wikibugs>	 3VisualEditor: [Regression pre-wmf10] Switch to source edit option is disabled - https://phabricator.wikimedia.org/T75965 (10Ryasmeen) 3NEW p:3Triage
[03:17:12] <Krinkle>	 James_F: Not so good. Discovered a garbage problem with karma-chrome-launcher on integration slaves.
[03:17:17] <James_F>	 :-(
[03:17:27] <Krinkle>	 The user-profiles that are temp created (with browser history, cookies etc.) aren't deleted consistently.
[03:17:29] <Krinkle>	 filling up /tmp
[03:18:08] <James_F>	 Oh dear.
[03:18:59] <Krinkle>	 I guess I should file a bug for that. Been debugging that one and off the past hour. Trying to think of a solution while doing other stuff.
[03:19:23] <James_F>	 `cron rm -rf /tmp`
[03:19:25] <James_F>	 Done.
[03:19:33] <Krinkle>	 :-)
[03:19:44] <Krinkle>	 And randomly kill running jobs every N minutes
[03:19:50] <Krinkle>	 tempting
[03:19:53] <James_F>	 Now you're just being picky. ;-)
[03:20:09] <Krinkle>	 I think in general we should actually do a cron for tmp
[03:20:22] <Krinkle>	 with a $find for dated items (e.g. > 6 hours)
[03:20:52] <Krinkle>	 I'd say this is one of those cases where I consider /tmp/foo not being deleted a bug in the environment, not the software.
[03:20:58] <Krinkle>	 I'd like it to be a stash and forget about
[03:21:16] <Krinkle>	 But clearly that's not established in either Mac or Linux unfortunately
[03:21:25] <Krinkle>	 other than it clearing on reboot (I think?)
[03:21:44] <James_F>	 Yeah.
[03:26:22] <Krinkle>	 James_F: As for qunit/chromium in general, there are various frameworks like Karma. That is to say, Karma isn't the only one that choose to adopt the webdriver standard and write lightweight adapters for major browsers (including firefox/chrome/phantomjs/saucelabs).
[03:26:35] <James_F>	 Sure.
[03:26:38] <Krinkle>	 So I'm hoping to find one that is already re-usable (without the rest of the framework) or pull it out of one of those.
[03:26:44] <Krinkle>	 And use it for grunt-contrib-qunit
[03:26:59] <Krinkle>	 so that you can swap phantomjs for chromium in there just like we do with karma
[03:27:22] <Krinkle>	 Or (which I'm still trying as well) is actually use Karma.
[03:28:00] <Krinkle>	 But its requirement and fundamental design around static files is probably not gonna let that work though I have a few nasty ideas that might work if well tucked away and out of our way once implemented :muhahah:
[03:28:42] * James_F grins.
[04:52:25] <grrrit-wm>	 (03PS21) 10Mooeypoo: Eventify TemplateDataGenerator and use oojs-ui [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 
[04:53:12] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Eventify TemplateDataGenerator and use oojs-ui [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 (owner: 10Mooeypoo)
[06:19:44] <wikibugs>	 3VisualEditor, Continuous-Integration: Jenkins: Convert mwext qunit from grunt-contrib-qunit (PhantomJS) to grunt-karma (Chromium) - https://phabricator.wikimedia.org/T74063#787333 (10Krinkle) Blocked on https://gerrit.wikimedia.org/r/#/c/175949/ which removes the test that was leaking jQuery animations.
[06:45:41] <wikibugs>	 3VisualEditor: A message key appears instead of the actual message in visualeditor-dialog-meta-settings-newsectioneditlink-help - https://phabricator.wikimedia.org/T75969 (10Amire80) 3NEW p:3Triage
[07:53:24] <wikibugs>	 3VisualEditor: The message visualeditor-recreate says "Press continue", but it's unclear what does "continue" refer to - https://phabricator.wikimedia.org/T75971 (10Amire80) 3NEW p:3Triage
[09:44:10] <wikibugs>	 3VisualEditor, VisualEditor-TechnicalDebt: VisualEditor: Zero width no-break space is added to the end of the article (in a slug) in the editing element (but not the document) - https://phabricator.wikimedia.org/T56051#787635 (10zeljkofilipin)
[10:01:09] <wikibugs>	 3VisualEditor: [Regression pre-wmf10] VisualEditor does not load on beta labs - https://phabricator.wikimedia.org/T75896#787649 (10zeljkofilipin)
[10:13:01] <wikibugs>	 3MediaWiki-Page-editing: Allow "suppressredirect" and "move-subpages" within userspace - https://phabricator.wikimedia.org/T71162#787662 (10He7d3r)
[10:14:55] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] Pass original event with TextInputWidget#enter [oojs/ui] - 10https://gerrit.wikimedia.org/r/175879 (owner: 10Esanders)
[10:18:35] <grrrit-wm>	 (03Merged) 10jenkins-bot: Pass original event with TextInputWidget#enter [oojs/ui] - 10https://gerrit.wikimedia.org/r/175879 (owner: 10Esanders)
[11:37:15] <grrrit-wm>	 (03PS1) 10Mvolz: Add unique sessionIDs [services/citoid] - 10https://gerrit.wikimedia.org/r/175974 
[12:38:56] <wikibugs>	 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Copying from Microsoft Word adds XML cruft like " <w:WordDocument>
[12:39:23] <wikibugs>	 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Copying from Microsoft Word adds XML cruft like " <w:WordDocument>
[12:56:54] <grrrit-wm>	 (03PS4) 10Esanders: Files, messages and config for find and replace [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175699 
[12:57:05] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Files, messages and config for find and replace [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175699 (owner: 10Esanders)
[13:00:37] <grrrit-wm>	 (03PS11) 10Esanders: Find and replace tool [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175306 
[13:00:39] <grrrit-wm>	 (03PS16) 10Esanders: Find and replace [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/174491 
[13:00:41] <grrrit-wm>	 (03PS2) 10Esanders: Go backwards through find and replace results on shift enter [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175883 
[13:00:43] <grrrit-wm>	 (03PS1) 10Esanders: Move window managers to sub folder [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175980 
[13:04:26] <grrrit-wm>	 (03PS1) 10Esanders: Use selected annotations when replacing content [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175982 
[13:06:26] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Go backwards through find and replace results on shift enter [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175883 (owner: 10Esanders)
[14:39:20] <grrrit-wm>	 (03PS8) 10Divec: WIP: Show entire expandable call tree in ve.Filibuster [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167021 
[14:53:32] <sheldon1>	 hello
[14:54:02] <sheldon1>	 is visualeditor ready for implementation at all? im using mediawiki at work as a knowledgebase and ive not had much luck getting it setup before
[15:58:42] <grrrit-wm>	 (03PS5) 10Divec: POC: Match native content start annotation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/165233 
[16:18:28] <wikibugs>	 3VisualEditor, Multimedia, VisualEditor-EditingTools: VisualEditor: Insert Media - "Error creating thumbnail" - 500 server error - https://phabricator.wikimedia.org/T75584#788364 (10Gilles) p:5Triage>3Normal It seems to be an issue with that image:  Error creating thumbnail: convert: no decode delegate for t...
[17:30:52] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=109450216
[17:30:52] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=109450995
[17:30:52] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=109456914
[17:30:53] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=33420362
[17:30:53] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=33424674
[17:30:53] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=33425001
[17:30:54] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=67012147
[17:30:54] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on ptwiki: https://pt.wikipedia.org/?diff=40706469
[17:30:54] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on plwiki: https://pl.wikipedia.org/?diff=41034637
[17:30:55] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on ltwiki: https://lt.wikipedia.org/?diff=4671237
[17:30:55] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on ltwiki: https://lt.wikipedia.org/?diff=4671244
[17:30:56] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on ltwiki: https://lt.wikipedia.org/?diff=4671246
[17:30:56] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on bgwiki: https://bg.wikipedia.org/?diff=6350944
[17:52:27] <wikibugs>	 3VisualEditor, VisualEditor-MediaWiki: Use '{{' and '^==' wikitext fragments as keyboard shortcuts - https://phabricator.wikimedia.org/T53897#788735 (10Kipod)
[17:57:12] <wikibugs>	 3VisualEditor, VisualEditor-MediaWiki: Use '{{' and '^==' wikitext fragments as keyboard shortcuts - https://phabricator.wikimedia.org/T53897#788738 (10He7d3r) Apparently [[https://gerrit.wikimedia.org/r/#/c/175919/1/modules/ve-mw/ui/ve.ui.MWSequenceRegistry.js,unified|the patch is only about "=="]].
[17:57:50] <wikibugs>	 3VisualEditor, VisualEditor-MediaWiki: Use '{{' and '^==' wikitext fragments as keyboard shortcuts - https://phabricator.wikimedia.org/T53897#788740 (10Jdforrester-WMF) >>! In T53897#788735, @Kipod wrote: > i could not see whether this patch fixed only ^== or also {{ and [[. > if the former, then i do not think...
[18:19:54] <mooeypoo>	 Ahha.
[18:20:58] <mooeypoo>	 We have an issue with "hasBeenChanged()" in SurfaceWidget *only* in Firefox.
[18:21:01] <mooeypoo>	 This is weird.
[18:21:36] <mooeypoo>	 James_F, okay, when you're back, how do I report a bug in phabricator? is this a "task" ?
[18:22:50] <James_F>	 mooeypoo: Yes. We is have no no task no more no.
[18:22:57] <James_F>	 Err. Bug.
[18:23:27] <James_F>	 mooeypoo: You want https://phabricator.wikimedia.org/maniphest/task/create/?projects=PHID-PROJ-dafezmpv6huxg3taml24
[18:24:05] <James_F>	 mooeypoo: Aka go to https://phabricator.wikimedia.org/tag/visualeditor/ and click "New Task".
[18:25:13] <mooeypoo>	 ooh okay
[18:27:26] <Krenair>	 "We is have no no task no more no."?
[18:27:43] <Krenair>	 Every time I read this is makes less sense :D
[18:27:52] <James_F>	 Krenair: That was the idea. :-)
[18:28:13] <Krenair>	 it makes*
[18:43:10] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Add unique sessionIDs [services/citoid] - 10https://gerrit.wikimedia.org/r/175974 (owner: 10Mvolz)
[18:45:11] <mooeypoo>	 Okay this is making no sense whatsoever. Did anything change with the way we're checking changes in surfaceWidgets ?
[18:47:18] <James_F>	 mooeypoo: Possibly. Since when?
[18:47:38] <mooeypoo>	 Sherry just sent me an email about a bug in the caption surface of the media dialog but only in Firefox
[18:48:20] <James_F>	 Hmm.
[18:48:26] <mooeypoo>	 So I'm looking at the ReferenceDialog and I am increasingly confused. Where did the .connect( documentUpdate ) go...
[18:48:29] <James_F>	 Please forward to me so I can deal.
[18:48:56] <mooeypoo>	 I was trying to see what the problem is so I can report correctly but now I'm not so sure it's only the media dialog
[18:48:56] <RoanKattouw>	 mooeypoo: That event handler was removed by Ed when he did the ve.ui.Sequence stuff
[18:49:07] <RoanKattouw>	 mooeypoo: Was there something else in that handler that he should not have removed?
[18:49:09] <mooeypoo>	 What do we listen to instead?
[18:49:33] <RoanKattouw>	 The wikitext warning is using the built-in sequence system now
[18:49:34] <mooeypoo>	 well, the media dialog listens to this change so it knows to enable the "Apply" button if you change caption
[18:49:48] <RoanKattouw>	 If you were using that event handler to check for changes, then you're now screwed and you should cast nasty looks at Ed
[18:49:56] * mooeypoo stares at Ed
[18:50:00] <RoanKattouw>	 And then put the event handler back sans the wikitext warning stuff
[18:50:04] <wikibugs>	 3VisualEditor, VisualEditor-ContentEditable, VisualEditor-ContentLanguage: Non-local text changes cause CE updates that close IME candidate window - https://phabricator.wikimedia.org/T76056#788865 (10dchan)
[18:50:30] <mooeypoo>	 okay, RoanKattouw, but answer me this: Why does it only not-work in Firefox?
[18:50:31] <wikibugs>	 3VisualEditor, VisualEditor-ContentEditable, VisualEditor-ContentLanguage: Non-local text changes cause CE updates that close IME candidate window - https://phabricator.wikimedia.org/T76056#788876 (10Jdforrester-WMF) p:5Triage>3High
[18:50:36] <mooeypoo>	 RoanKattouw, is Chrome psychic?
[18:50:37] <wikibugs>	 3VisualEditor, VisualEditor-ContentEditable, VisualEditor-ContentLanguage: Non-local text changes cause CE updates that close IME candidate window - https://phabricator.wikimedia.org/T76056#788865 (10Jdforrester-WMF)
[18:50:42] <RoanKattouw>	 mooeypoo: It might be a different bug?
[18:50:54] <RoanKattouw>	 Like, we have sometimes seen bugs in FF where typing does not cause transactions to happen
[18:51:00] <RoanKattouw>	 Because of bugs in the way things are focused
[18:51:40] <James_F>	 Surface/dialog focussing is currently non-optimal.
[18:51:43] <mooeypoo>	 RoanKattouw, okay, fair enough, what I'm not sure I understand, though, is that if this event handler is out, but my code still listens to it, what does Chrome listen *to* ... 
[18:51:44] <James_F>	 As in, broken. :-)
[18:51:52] <mooeypoo>	 this is weird as hell. It shouldn't work! Why is it working!
[18:51:54] <mooeypoo>	 :D
[18:52:06] <RoanKattouw>	 mooeypoo: Well, what I was talking about landed yesterday
[18:52:17] <RoanKattouw>	 That code isn't in production yet, so that's probably not what you're hearing about
[18:52:17] <mooeypoo>	 Oh
[18:52:28] <RoanKattouw>	 Sorry, should have realized that earlier
[18:52:28] <mooeypoo>	 Okay, that... yes. No. Probably not.
[18:52:48] <mooeypoo>	 this is odd though
[18:52:50] <mooeypoo>	 I have this:
[18:52:50] <mooeypoo>	 	this.captionSurface.getSurface().getModel().connect( this, {
[18:52:50] <mooeypoo>	 		documentUpdate: this.checkChanged.bind( this )
[18:52:51] <mooeypoo>	 	} );
[18:52:54] <mooeypoo>	 in the media dialog
[18:53:19] <mooeypoo>	 which, btw, was changed from having an entire wikitext-warning-thing to the above
[18:53:29] <mooeypoo>	 but that event seems to be fired in Chrome and not in Firefox
[18:53:38] <mooeypoo>	 James_F, I forwarded the email to you
[18:53:41] <James_F>	 mooeypoo: Ta.
[18:53:59] <mooeypoo>	 I was trying to figure out if this is a MediaDialog bug or a SurfaceWidget bug
[18:54:48] <mooeypoo>	 James_F, I'm not yet sure what to file this under.
[18:55:00] <RoanKattouw>	 mooeypoo: Probably a CE bug
[18:55:39] <RoanKattouw>	 If you are able to reproduce this, reproduce it with ?debug=true and see if you see different behavior in the selection display thing in Chrome vs Firefox
[18:55:51] <mooeypoo>	 aaand now I updated mw and it doesn't load.
[18:55:53] <RoanKattouw>	 (I mean the thing that appears below surfaces in debug mode that says "Linear 1-1"
[18:55:53] <mooeypoo>	 aewsome.
[18:55:59] <RoanKattouw>	 mooeypoo: composer update
[18:56:37] <mooeypoo>	 RoanKattouw, yeah i did that, but I am confused about the fact that in my code there's an event listener (that seems to be triggered O.o) and in ReferenceDialog there isn't, and yet ReferenceDialog seems to update the 'apply' button and my code doesn't.
[18:56:43] <mooeypoo>	 oh, composer
[19:00:47] <ryasmeen>	 RoanKattouw:https://phabricator.wikimedia.org/T75965
[19:01:34] <RoanKattouw>	 ryasmeen: What the ...
[19:01:36] <mooeypoo>	 RoanKattouw, okay, it is definitely a problem in the MediaDialog but I am seriously confused. I don't even see what the ReferenceDialog is *listening to* for changes in the SurfaceWidget
[19:02:02] <RoanKattouw>	 ryasmeen: I'm going to guess this is another thing Ed broke with his tools/commands code. Will investigate once I'm out of this meeting
[19:02:16] <ryasmeen>	 sure RoanKattouw
[19:02:20] <RoanKattouw>	 mooeypoo: 	this.referenceModel.getDocument().connect( this, { transact: 'onDocumentTransact' } );
[19:02:25] <mooeypoo>	 transact?
[19:02:30] <mooeypoo>	 but isn't that already applying ?
[19:03:01] <RoanKattouw>	 Now why we listen to transact in one dialog and documentUpdate in another, I have no idea
[19:03:30] <mooeypoo>	 well, the documentUpdate *used to work*
[19:03:37] <mooeypoo>	 ... then apparently it was taken away
[19:04:59] <mooeypoo>	 Okaaaay. At least I've established that the event isn't working in *BOTH* firefox and chrome.
[19:05:18] <mooeypoo>	 I no longer feel the need to put a tin foil hat over my head.
[19:05:55] <mooeypoo>	 eh. Also, the call seemed to have changed.
[19:07:53] <mooeypoo>	 holy cow, we're listening to the model, not the widget. 
[19:07:54] <mooeypoo>	 hm
[19:09:34] <mooeypoo>	 WOW.
[19:09:52] <mooeypoo>	 Okay, more than just event handlers have changed.
[19:11:09] <mooeypoo>	 RoanKattouw, so, we used to have it so that  someSurfaceWidget.getSurface().getModel() returns the 'doc' that was stored. So, my event was attached to this.captionSurface.getSurface().getModel().connect( ... )
[19:11:16] <mooeypoo>	 this, however, doesn't work anymore.
[19:11:37] <wikibugs>	 3VisualEditor, MediaWiki-extensions-AbuseFilter: Mismatch between new page text seen by AbuseFilter and actual new page content - https://phabricator.wikimedia.org/T76063 (10Orlodrim) 3NEW p:3Triage
[19:12:10] <mooeypoo>	 The document *itself* is different? I'm trying to look at which document and model is what, but it seems to me that we're either not returning the right model anymore, or we're not allowing for the return of that document at all
[19:14:16] <grrrit-wm>	 (03PS1) 10Mooeypoo: Change event listener for caption surface in media dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/176028 
[19:14:31] <mooeypoo>	 RoanKattouw, ^^ is this really the way things should work?
[19:14:54] <mooeypoo>	 (They do work like that)
[19:14:58] <mooeypoo>	 but.. should they.
[19:17:22] <RoanKattouw>	 mooeypoo: In theory either should be fine
[19:17:25] <RoanKattouw>	 Does this change fix the bug?
[19:17:29] <mooeypoo>	 yes
[19:17:41] <mooeypoo>	 but... getSurface().getModel() doesn't seem to give me the document
[19:17:49] <mooeypoo>	 and there's no .getDocument() to the surface
[19:18:06] <mooeypoo>	 so.. is there no way to get the document back from the surface? 
[19:18:10] <RoanKattouw>	 Yes there is
[19:18:14] <RoanKattouw>	 .getDocument() is there
[19:18:17] <mooeypoo>	 It's not working
[19:18:23] <RoanKattouw>	 See ve.dm.Surface.js, also for docs for the documentUpdate event
[19:18:32] <RoanKattouw>	 transact is emitted by Document, documentUpdate is emitted by Surface
[19:18:34] <RoanKattouw>	 From the docs:
[19:18:53] <RoanKattouw>	 " Emitted when a transaction has been processed on the document and the selection has been translated to account for that transaction. You should only use this event if you need to access the selection; in most cases, you should use {ve.dm.Document#event-transact}."
[19:19:18] <mooeypoo>	 mmmm
[19:19:29] <RoanKattouw>	 The old wikitext warning listener did need the selection, so it used documentUpdate. Given that the current dialog code only needs to check whether there is history, it should use transact
[19:19:36] <RoanKattouw>	 So your change is correct, but the old code should have worked in theory
[19:19:50] <RoanKattouw>	 Is there a difference? Do things start working with your change?
[19:20:39] <mooeypoo>	 RoanKattouw, this.captionSurface.getDocument() and  this.captionSurface.getSurface().getDocument() are both failing
[19:20:52] <RoanKattouw>	 Well yes
[19:20:53] <mooeypoo>	 this.captionSurface.getSurface().getModel() works but doesn't seem to trigger the event
[19:21:08] <RoanKattouw>	 OK this is slightly confusing, but let me map all these vars for you
[19:21:12] <mooeypoo>	 I am confused as to what it returns if not the right document
[19:21:18] <RoanKattouw>	 this.captionSurface is a SurfaceWidget (not a Surface?! Come on Trevor!)
[19:21:29] <RoanKattouw>	 this.captionSurface.getSurface() is a ui.Surface
[19:21:37] <RoanKattouw>	 this.captionSurface.getSurface().getModel() is a dm.Surface
[19:21:45] <mooeypoo>	 oh gods, dm.Surface! ha. I .. yes.
[19:21:50] <RoanKattouw>	 And THAT will have a .getDocument()
[19:21:55] <mooeypoo>	 ... wow
[19:22:19] <mooeypoo>	 so uhm question
[19:22:40] <mooeypoo>	 when you instantiate a surfaceWidget -- new ve.ui.MWSurfaceWidget( document, config )
[19:22:54] <mooeypoo>	 And then if you want that document back, which you just put in directly, you have to go aaaaaaall that above route
[19:23:05] <mooeypoo>	 widget.getSurface().getModel().getDocument()
[19:23:20] <mooeypoo>	 so.. could we not add "getDocument()" to the widget, since it's *stored* in the widget?
[19:23:40] <RoanKattouw>	 It probably isn't actually stored in the widget? But let me check
[19:23:44] <mooeypoo>	 It's rather confusing, I have to say, since we're actively sending it to the widget but then we can't get that
[19:23:54] <marcoil>	 I don't know if you know about this: The Catalan Wikipedia is doing a big campaign promoting the use of VE, some of it is on twitter https://twitter.com/search?q=%23editorvisual&src=tyah
[19:23:55] <mooeypoo>	 well, it's not stored, but it's given to the widget. And then to its parent and parent's parent
[19:23:57] <RoanKattouw>	 The ReferenceDialog should probably retain a reference to the document though
[19:24:03] <mooeypoo>	 API-wise it's extremely confusing
[19:24:04] <mooeypoo>	 it does
[19:24:09] <mooeypoo>	 media dialog doesn't, really
[19:24:24] <mooeypoo>	 I just need the event to act on it
[19:24:28] <RoanKattouw>	 It probably should
[19:24:39] <RoanKattouw>	 Yeah I looked at SurfaceWidget and the document just gets passed through, not stored
[19:24:46] <RoanKattouw>	 But I hear you, a .getDocument() getter would probably be useful
[19:25:10] <mooeypoo>	 omg
[19:25:14] <mooeypoo>	 It's not working in Firefox
[19:25:20] * mooeypoo stares at her computer
[19:25:26] <mooeypoo>	 It works brilliantly in Chrome
[19:25:31] <mooeypoo>	 how can it not work in Firefox!?
[19:25:54] <mooeypoo>	 wait, let me clear cache before I resort to using the sledgehammer
[19:26:00] <RoanKattouw>	 So NOW, could you look at ?debug=true and whether there's a difference in the selection thing that's displayed below the surface?
[19:26:06] * mooeypoo nods
[19:27:33] <mooeypoo>	 ok, so before the selection I just tried something with the event itself. If I add spaces it doesn't work in Firefox but *does* in Chrome
[19:27:46] <mooeypoo>	 however, if I fix up anything like a letter or anything else, that works
[19:29:45] <RoanKattouw>	 Most likely it's the difference between starting to type immediately vs moving the cursor first and then typing
[19:30:10] <mooeypoo>	 I just hit space
[19:30:21] <mooeypoo>	 oh, no, I went to the end of the word first, then hit space
[19:30:25] <mooeypoo>	 but I did it in both browsers
[19:30:40] <grrrit-wm>	 (03PS2) 10Mooeypoo: Change event listener for caption surface in media dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/176028 
[19:31:36] <mooeypoo>	 This works in any case, the difference seems to be only spaces
[19:31:53] <mooeypoo>	 so.. that fixes the previous bug. I can try and see what's wrong with the new bug/difference
[19:33:34] <wikibugs>	 3VisualEditor, Citoid, Continuous-Integration: Set up CI in the mediawiki/services/citoid.git repo - https://phabricator.wikimedia.org/T76069#789031 (10Jdforrester-WMF)
[19:35:39] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Use selected annotations when replacing content [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175982 (owner: 10Esanders)
[19:38:10] <grrrit-wm>	 (03Merged) 10jenkins-bot: Use selected annotations when replacing content [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175982 (owner: 10Esanders)
[19:47:15] <wikibugs>	 3VisualEditor-ContentEditable: [regression-wmf9]visualeditor-formatdropdown-format-blockquote  is displayed in Headings menu  - https://phabricator.wikimedia.org/T76072 (10Etonkovidova) 3NEW p:3Triage
[19:48:27] <mooeypoo>	  uhm, James_F, I've fixed the bug before I had a chance of reporting it. Did you add it into the task list yet? If not, nevermind. If yes, is there a way to add the link from the commit? https://gerrit.wikimedia.org/r/#/c/176028
[19:57:13] <wikibugs>	 3VisualEditor: [Regression pre-wmf10]Toolbar for Basic Reference and Media Settings dialog is broken - https://phabricator.wikimedia.org/T76073 (10Ryasmeen) 3NEW p:3High
[19:58:26] <James_F>	 mooeypoo: Did you report?
[19:59:02] <James_F>	 mooeypoo: To add, amend the commit message (click the yellow icon in the top-right) and put "Bug: T1234" at the bottom above the change-id.
[19:59:58] <mooeypoo>	 I didn't yet
[20:00:14] <mooeypoo>	 should I anyways?
[20:00:40] <mooeypoo>	 I was going to, but I wanted to see what bug it is (if it's media dialog or surface) and while investigating, I solved the bug. Should I report it anywys, or just leave it since the patch is already up?
[20:00:53] <James_F>	 mooeypoo: File it so we know it was fixed.
[20:01:04] <James_F>	 mooeypoo: Especially 'cos this will need a cherry-pick for wmf9.
[20:01:10] * mooeypoo nods
[20:03:34] <wikibugs>	 3VisualEditor: Changes in the caption surface in MediaDialog does not enable the "Apply" button - https://phabricator.wikimedia.org/T76074 (10Mooeypoo) 3NEW p:3Triage
[20:03:45] <mooeypoo>	 James_F, ^^ did I do this okay?
[20:04:10] <grrrit-wm>	 (03PS3) 10Mooeypoo: Change event listener for caption surface in media dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/176028 
[20:04:34] <mooeypoo>	 woot, seems to work well in the linkage
[20:04:54] <mooeypoo>	 hm, how do I assign it to myself...
[20:05:28] <James_F>	 mooeypoo: On the task, "claim" at the bottom or "edit" at the top.
[20:05:30] <James_F>	 Or I can.
[20:05:50] <mooeypoo>	 Where's the "claim"...
[20:05:52] <mooeypoo>	 hm
[20:06:01] <James_F>	 In the "action" menu.
[20:06:24] <mooeypoo>	 ah!
[20:06:24] <wikibugs>	 3VisualEditor: Changes in the caption surface in MediaDialog does not enable the "Apply" button - https://phabricator.wikimedia.org/T76074#789095 (10Mooeypoo) a:3Mooeypoo
[20:06:28] <mooeypoo>	 done. I think.
[20:06:36] <wikibugs>	 3VisualEditor, VisualEditor-ContentEditable: [Regression wmf10] Changes in the caption surface in MediaDialog does not enable the "Apply" button - https://phabricator.wikimedia.org/T76074#789096 (10Jdforrester-WMF) p:5Triage>3High a:5Mooeypoo>3None
[20:06:38] <James_F>	 Yup.
[20:07:32] <mooeypoo>	 eek I have a typo
[20:07:33] <wikibugs>	 3VisualEditor: [Regression pre-wmf10] Cannot open comment box, it just flickers and gets closed - https://phabricator.wikimedia.org/T76076 (10Ryasmeen) 3NEW p:3Triage
[20:07:37] <mooeypoo>	 (which you didn't catch, James_F ! )
[20:07:46] <mooeypoo>	 "Changes ..... does not enable"
[20:07:46] <mooeypoo>	 oops
[20:08:48] <wikibugs>	 3VisualEditor: [Regression pre-wmf10] Cannot open comment box, it just flickers and gets closed - https://phabricator.wikimedia.org/T76076#789107 (10Ryasmeen) Getting same behavior for Gallery too
[20:11:38] <James_F>	 mooeypoo: I trust you to not break things. :-)
[20:12:19] <wikibugs>	 3VisualEditor, VisualEditor-ContentEditable: [Regression wmf10] Changes in the caption surface in MediaDialog does not enable the "Apply" button - https://phabricator.wikimedia.org/T76074#789126 (10Jdforrester-WMF)
[20:12:38] <wikibugs>	 3VisualEditor, VisualEditor-ContentEditable: [Regression wmf10] Changes in the caption surface in MediaDialog does not enable the "Apply" button - https://phabricator.wikimedia.org/T76074#789127 (10Jdforrester-WMF) a:3Mooeypoo
[20:12:54] <wikibugs>	 3VisualEditor, VisualEditor-EditingTools: Make it easy to identify the file type (e.g., .png versus .svg) when adding an image - https://phabricator.wikimedia.org/T74061#789128 (10Jdforrester-WMF) a:5MSchottlender-WMF>3Mooeypoo
[20:12:55] <mooeypoo>	 James_F, oh, the typo is in the bug *report* not the bug *code*. It won't break anything except my English-speaking Ego.
[20:13:07] <wikibugs>	 3VisualEditor, VisualEditor-EditingTools: In the media insertion dialog, give a tooltip on each item saying what will happen when you click it (i.e., "Click to insert as a thumbnail" or whatever) - https://phabricator.wikimedia.org/T54219#789136 (10Jdforrester-WMF)
[20:13:07] * James_F grins.
[20:13:57] <wikibugs>	 3VisualEditor: [Regression pre-wmf10] Cannot open comment/gallery/special character inspector, they just flicker and get closed - https://phabricator.wikimedia.org/T76076#789137 (10Ryasmeen)
[20:14:35] <wikibugs>	 3VisualEditor: [Regression pre-wmf10] Switch to source edit option is disabled - https://phabricator.wikimedia.org/T75965#789138 (10Ryasmeen) p:5Triage>3High
[20:14:57] <wikibugs>	 3VisualEditor, VisualEditor-EditingTools: [Regression wmf10] Toolbar for Basic Reference and Media Settings dialog is broken - https://phabricator.wikimedia.org/T76073#789147 (10Jdforrester-WMF)
[20:15:05] <wikibugs>	 3VisualEditor-ContentEditable: Safari only: applying any options from formatting menu gives [Error] Failed to load resource: The operation couldn’t be completed. - https://phabricator.wikimedia.org/T76079#789139 (10Etonkovidova)
[20:15:27] <wikibugs>	 3VisualEditor: [Regression pre-wmf10] Cannot open comment/gallery/special character inspector, they just flicker and get closed - https://phabricator.wikimedia.org/T76076#789152 (10Jdforrester-WMF)
[20:15:32] <wikibugs>	 3VisualEditor, VisualEditor-EditingTools: [Regression wmf10] Toolbar for Basic Reference and Media Settings dialog is broken - https://phabricator.wikimedia.org/T76073#789076 (10Jdforrester-WMF)
[20:15:36] <wikibugs>	 3VisualEditor: [Regression pre-wmf10] Switch to source edit option is disabled - https://phabricator.wikimedia.org/T75965#789154 (10Jdforrester-WMF)
[20:16:02] <mooey|away>	 ... that did not just happen.
[20:19:01] <James_F>	 TrevorP|Away: Ping.
[20:19:50] <James_F>	 TrevorP|Away: When you're back, we need to agree what outstanding items you want to put into OOUI this week – ideally we should do the cut and pull today.
[20:21:25] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Change event listener for caption surface in media dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/176028 (owner: 10Mooeypoo)
[20:23:38] <wikibugs>	 3VisualEditor, MediaWiki-extensions-AbuseFilter: Mismatch between new page text seen by AbuseFilter and actual new page content - https://phabricator.wikimedia.org/T76063#789173 (10Se4598)
[20:23:48] <wikibugs>	 3VisualEditor: VisualEditor is not displayed after clicking on Edit - https://phabricator.wikimedia.org/T76081 (10Lorenzocipriani) 3NEW p:3Triage
[20:24:40] <wikibugs>	 3VisualEditor: VisualEditor is not displayed after clicking on Edit - https://phabricator.wikimedia.org/T76081#789176 (10Lorenzocipriani)
[20:24:44] <wikibugs>	 3VisualEditor, MediaWiki-extensions-AbuseFilter: Incorrect tagging of edits on some Wikipedias – AbuseFilter's diff and the real diff are not the same - https://phabricator.wikimedia.org/T73947#752843 (10Se4598) added VE Project as it's mentioned here and for all edits in merged T76063
[20:25:19] <wikibugs>	 3VisualEditor: VisualEditor is not displayed after clicking on Edit - https://phabricator.wikimedia.org/T76081#789176 (10Lorenzocipriani)
[20:29:12] <TrevorParscal>	 James_F: ok, i'm back
[20:29:12] <TrevorParscal>	 OMG
[20:29:30] <TrevorParscal>	 so much crap I had to do aparently
[20:29:36] <TrevorParscal>	 but the cleaners are here, and things are in order
[20:29:38] <James_F>	 TrevorParscal: Ha.
[20:29:44] <TrevorParscal>	 so... I'm now available
[20:29:51] <TrevorParscal>	 lets talk outstanding OOUI
[20:29:52] <James_F>	 TrevorParscal: https://gerrit.wikimedia.org/r/#/q/status:open+project:oojs/ui+-message:WIP,n,z
[20:30:38] <James_F>	 TrevorParscal: I'd suggest https://gerrit.wikimedia.org/r/#/c/175926/ https://gerrit.wikimedia.org/r/#/c/175782/ (has -1) and https://gerrit.wikimedia.org/r/#/c/175743/, and maybe https://gerrit.wikimedia.org/r/#/c/172325/ if you think it's good to go.
[20:30:49] <James_F>	 TrevorParscal: Sane?
[20:30:52] <TrevorParscal>	 looking
[20:31:50] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] MessageDialog: Add Firefox hack for scrollbars when sizing dialogs [oojs/ui] - 10https://gerrit.wikimedia.org/r/175782 (owner: 10Bartosz Dziewoński)
[20:32:47] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] Window: Disable transitions when changing window height to calculate content height [oojs/ui] - 10https://gerrit.wikimedia.org/r/175743 (owner: 10Bartosz Dziewoński)
[20:33:48] <grrrit-wm>	 (03PS1) 10Catrope: Followup 142a44e: fix path names to MobileContextItemWidget.{js,css} [extensions/VisualEditor] (wmf/1.25wmf9) - 10https://gerrit.wikimedia.org/r/176052 
[20:33:53] <wikibugs>	 3VisualEditor: [Regression pre-wmf10]Basic reference that has Citation inside tries to render it as Basic Reference (<ref><ref>{{Cite we }}</ref></ref>)and thus fails - https://phabricator.wikimedia.org/T76082#789196 (10Ryasmeen)
[20:34:21] <wikibugs>	 3VisualEditor: [Regression pre-wmf10]Basic reference that has Citation inside tries to render it as Basic Reference (<ref><ref>{{Cite web }}</ref></ref>)and thus fails - https://phabricator.wikimedia.org/T76082#789196 (10Ryasmeen)
[20:35:05] <RoanKattouw>	 James_F: https://gerrit.wikimedia.org/r/176052 should fix the mobile bug in wmf9
[20:35:14] <RoanKattouw>	 ryasmeen: Do we have a Phabricator task for that somewhere?
[20:35:39] <ryasmeen>	 RoanKattouw:for mobile not working in test2?
[20:35:56] <RoanKattouw>	 Yeah
[20:35:59] <ryasmeen>	 no, shall we use the previous one or file a new one?
[20:36:29] <ryasmeen>	 https://phabricator.wikimedia.org/T75646
[20:36:37] <ryasmeen>	 this was for last week
[20:37:13] <RoanKattouw>	 OK I'll reuse that one
[20:37:27] <wikibugs>	 3VisualEditor-MediaWiki-Mobile: [Regression wmf9] VisualEditor fails to load (ve.ui.MobileContext.css not defined?) - https://phabricator.wikimedia.org/T75646#789207 (10Catrope) Still failing in wmf9, now because our fix used MobileContextOptionWidget instead of MobileContextItemWidget
[20:37:40] <grrrit-wm>	 (03PS2) 10Catrope: Followup 142a44e: fix path names to MobileContextItemWidget.{js,css} [extensions/VisualEditor] (wmf/1.25wmf9) - 10https://gerrit.wikimedia.org/r/176052 
[20:37:42] <James_F>	 RoanKattouw: Yeah, use That.
[20:38:06] <grrrit-wm>	 (03CR) 10Jforrester: [C: 031] Followup 142a44e: fix path names to MobileContextItemWidget.{js,css} [extensions/VisualEditor] (wmf/1.25wmf9) - 10https://gerrit.wikimedia.org/r/176052 (owner: 10Catrope)
[20:38:09] <James_F>	 Hey mvolz.
[20:39:42] <wikibugs>	 3VisualEditor-ContentEditable: Safari only: inserting a link link on a new line will force the link inspector to be displayed in the upper left corner  - https://phabricator.wikimedia.org/T76083 (10Etonkovidova) 3NEW p:3Triage
[20:41:03] <wikibugs>	 3VisualEditor: VisualEditor is not displayed after clicking on Edit - https://phabricator.wikimedia.org/T76081#789219 (10Jdforrester-WMF) What if any output is there on your browser's console log?
[20:41:39] <James_F>	 ryasmeen: You know wmf10 has shipped, right? :-)
[20:42:11] <ryasmeen>	 yep sorry changing it :D
[20:43:48] <TrevorParscal>	 epic commit message: https://gerrit.wikimedia.org/r/#/c/175926/
[20:44:18] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] MessageDialog: Actually correctly calculate and set height [oojs/ui] - 10https://gerrit.wikimedia.org/r/175926 (owner: 10Bartosz Dziewoński)
[20:44:46] <wikibugs>	 3VisualEditor, VisualEditor-EditingTools: VisualEditor: Tool to set/unset text as small - https://phabricator.wikimedia.org/T53614#789235 (10Jdforrester-WMF) a:5Jdforrester-WMF>3Esanders
[20:44:57] <wikibugs>	 3VisualEditor: The message visualeditor-recreate says "Press continue", but it's unclear what does "continue" refer to - https://phabricator.wikimedia.org/T75971#789244 (10Jdforrester-WMF) 5Open>3Resolved a:3Jdforrester-WMF The message is <ooui-dialog-process-continue>. I've updated the qqq to reflect this.
[20:45:33] <wikibugs>	 3VisualEditor: [Regression pre-wmf10]Basic reference that has Citation inside tries to render it as Basic Reference (<ref><ref>{{Cite web }}</ref></ref>)and thus fails - https://phabricator.wikimedia.org/T76082#789247 (10Jdforrester-WMF)
[20:46:29] <James_F>	 TrevorParscal: Yeah. :-)
[20:46:46] <James_F>	 TrevorParscal: Anything else you want to land for next week's cut of MW-core?
[20:47:01] <TrevorParscal>	 am I doing somthing wrong, or is the demo for https://gerrit.wikimedia.org/r/#/c/172325/ seem broken?
[20:47:37] <James_F>	 ^^ mooey|away?
[20:47:43] * James_F tries.
[20:48:22] <grrrit-wm>	 (03PS3) 10Catrope: MessageDialog: Actually correctly calculate and set height [oojs/ui] - 10https://gerrit.wikimedia.org/r/175926 (owner: 10Bartosz Dziewoński)
[20:48:42] <TrevorParscal>	 I thought there were like labels for the draggable items
[20:48:51] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] MessageDialog: Actually correctly calculate and set height [oojs/ui] - 10https://gerrit.wikimedia.org/r/175926 (owner: 10Bartosz Dziewoński)
[20:49:52] <James_F>	 TrevorParscal: There were. It seems broken here too.
[20:50:00] <James_F>	 TrevorParscal: Probably a rebase mistake?
[20:50:15] <TrevorParscal>	 I'm also noticing (and maybe it is related, maybe not) that Radio Select widgets are not showing labels either
[20:51:12] <TrevorParscal>	 probably has to do with the changes to LabeledWidget that MatmaRex made trying to remove inline styling
[20:51:19] <grrrit-wm>	 (03Merged) 10jenkins-bot: Window: Disable transitions when changing window height to calculate content height [oojs/ui] - 10https://gerrit.wikimedia.org/r/175743 (owner: 10Bartosz Dziewoński)
[20:51:23] <grrrit-wm>	 (03Merged) 10jenkins-bot: MessageDialog: Add Firefox hack for scrollbars when sizing dialogs [oojs/ui] - 10https://gerrit.wikimedia.org/r/175782 (owner: 10Bartosz Dziewoński)
[20:52:33] <James_F>	 Huh. Yeah.
[20:54:03] <James_F>	 TrevorParscal: Also "ButtonSelectWidget" is broken with the icon button (first item) in each of the four demo groups
[20:54:21] <James_F>	 TrevorParscal: Oh, no, caching issue, ignore.
[20:56:05] <TrevorParscal>	 i'm comparing to master
[20:56:25] <wikibugs>	 3VisualEditor-ContentEditable: [Regression wmf10] cannot open Formula inspector  - https://phabricator.wikimedia.org/T76087 (10Etonkovidova) 3NEW p:3Triage
[20:56:57] <TrevorParscal>	 in master, the radio select widget's labels are actually empty, so it would make sense for them to not have any labels
[20:57:08] <James_F>	 Maybe they shouldn't.
[20:57:12] <James_F>	 For the demo.
[20:57:29] <TrevorParscal>	 except that the demo specifies them
[20:57:36] <TrevorParscal>	 so, there's something broken there
[20:57:37] <James_F>	 Oh.
[20:57:46] <TrevorParscal>	 and, I guess nobody is using it yet, but that's a problem
[20:58:01] <TrevorParscal>	 and it may be the same thing that is causing the drag and drop labels to not appear
[20:58:13] <TrevorParscal>	 so, it's sort of blocking her commit until we can verify that
[20:58:14] <James_F>	 I3a8fed4ebe4c0d56cb4cda25d42e30777ac035b7
[20:58:18] <James_F>	 Maybe?
[20:58:38] <TrevorParscal>	 right, that was my guess
[20:58:39] <James_F>	 Only thing to touch LabelElement in the past week.
[20:58:50] <mooeypoo>	 TrevorParscal, oy vey, I had a nightmare time trying to rebase, I missed the errors :\ sorry!
[20:58:59] <mooeypoo>	 can we revert a patchet so I can redo the rebase?
[20:59:01] <James_F>	 mooeypoo: Might not be your fault.
[20:59:07] <TrevorParscal>	 but it doesn't actually make the label's element empty, it just changes the CSS
[20:59:24] <James_F>	 mooeypoo: If you want to get an earlier patchset, use `git review -d123456,7`
[20:59:30] <mooeypoo>	 Since my patchset breaks apart the variable, it's a really tough job to rebsase it
[20:59:42] <mooeypoo>	 in this case, though, I just took the original and re-inserted my fixes
[20:59:43] <James_F>	 mooeypoo: Where '7' is the patchset you want to grab, and '123456' is the change number.
[20:59:46] <mooeypoo>	 should've worked :\
[20:59:47] <TrevorParscal>	 mooeypoo: well, master if borked, so I'm not sure you've done anything wrong
[20:59:58] <mooeypoo>	 oh, I'll wait, then
[20:59:58] * James_F nods.
[21:00:09] * James_F leaves it in TrevorParscal's capable hands.
[21:00:38] <TrevorParscal>	 are you aware of any recent changes to OptionWidget?
[21:01:02] <mooeypoo>	 TrevorParscal, I noticed in my rebasing, yes
[21:01:15] <mooeypoo>	 ... crap, I changed the rebase but not the actual code of my elements
[21:01:15] <mooeypoo>	 ha
[21:01:22] <TrevorParscal>	 I see that I changed it when I removed the requirement for unique data
[21:01:28] <TrevorParscal>	 looking into that
[21:01:55] <mooeypoo>	 yeah I didn't change the actual constructors and I think I also didn't change the instantiation in the widgets.js file for the demo. Meh
[21:04:05] <grrrit-wm>	 (03PS1) 10Trevor Parscal: Remove lies from documentation [oojs/ui] - 10https://gerrit.wikimedia.org/r/176069 
[21:04:26] <James_F>	 Promising commit name. :-)
[21:05:30] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] MessageDialog: Actually correctly calculate and set height [oojs/ui] - 10https://gerrit.wikimedia.org/r/175926 (owner: 10Bartosz Dziewoński)
[21:06:59] <TrevorParscal>	 well, i'm going to at least figure out the option widget label issue
[21:07:05] <TrevorParscal>	 and maybe that will reveal something
[21:10:26] <grrrit-wm>	 (03PS1) 10Divec: Only showSelection if checkSequences actually matched something [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/176070 
[21:12:28] <TrevorParscal>	 ok, so the problem with the demo not showing the labels was simple, the demo was still using the required data arg before the options are for option widgets
[21:12:53] <TrevorParscal>	 but, now I'm seeing that the label is on its own line, so... looking into that now
[21:13:01] <TrevorParscal>	 didn't they used to be inline?
[21:13:28] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Only showSelection if checkSequences actually matched something [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/176070 (owner: 10Divec)
[21:13:48] <mooeypoo>	 TrevorParscal, you're talking about the draggable stuff?
[21:13:54] <TrevorParscal>	 not yet
[21:14:04] <TrevorParscal>	 but i'm hoping to discover a common cause
[21:14:04] <mooeypoo>	 oh okay
[21:14:28] <mooeypoo>	 TrevorParscal, there are supposed to be 2 demos, one for horizontal and one for vertical... the vertical lays it out on its own line, ,but the horizontal should override the display property.
[21:15:23] <TrevorParscal>	 looks like kill inline styles caused a rule to be so powerful it knocks another one out
[21:15:28] <TrevorParscal>	 MatmaRex: you 'roudn?
[21:15:43] <MatmaRex>	 hi
[21:15:45] <MatmaRex>	 i broke something?
[21:15:47] <James_F>	 RoanKattouw: caVeEditNextnode = ( reverseTabOrder ^ conf.tabPosition === 'before' ) ? $caEdit.get( 0 ) : $caEdit.next().get( 0 );
[21:16:54] <TrevorParscal>	 MatmaRex: well, https://gerrit.wikimedia.org/r/#/c/174844/4/src/styles/widgets/OptionWidget.less,unified
[21:17:38] <TrevorParscal>	 this caused the rules for RadioOptionWidget to be overpowered
[21:18:01] <TrevorParscal>	 specifically the display: block part
[21:18:57] <grrrit-wm>	 (03PS1) 10Jforrester: i18n: Pass value to <visualeditor-dialog-meta-settings-newsectioneditlink-help> [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/176071 
[21:19:17] <wikibugs>	 3VisualEditor: A message key appears instead of the actual message in visualeditor-dialog-meta-settings-newsectioneditlink-help - https://phabricator.wikimedia.org/T75969#789369 (10Jdforrester-WMF) a:3Jdforrester-WMF
[21:19:32] <wikibugs>	 3VisualEditor: A message key appears instead of the actual message in visualeditor-dialog-meta-settings-newsectioneditlink-help - https://phabricator.wikimedia.org/T75969#787343 (10Jdforrester-WMF)
[21:19:41] <wikibugs>	 3VisualEditor: A message key appears instead of the actual message in visualeditor-dialog-meta-settings-newsectioneditlink-help - https://phabricator.wikimedia.org/T75969#787343 (10Jdforrester-WMF) p:5Triage>3Normal
[21:19:46] <MatmaRex>	 hmph.
[21:20:04] <grrrit-wm>	 (03CR) 10Esanders: [C: 04-1] "Surface.execute should also return a boolean, so you can check to command actually ran as well" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/176070 (owner: 10Divec)
[21:20:18] <MatmaRex>	 TrevorParscal: i didn't break anything that matters, though? :) i'll fix that later today
[21:21:29] <TrevorParscal>	 yeah, it's not critical urgent OMG, it needs to be fixing
[21:22:00] <James_F>	 Well.
[21:22:11] <James_F>	 It needs fixing before the OOUI cut this afternoon, ideally. :-)
[21:23:13] <wikibugs>	 3VisualEditor: [Regression wmf10] Basic reference that has Citation inside tries to render it as Basic Reference (<ref><ref>{{Cite web }}</ref></ref>)and thus fails  - https://phabricator.wikimedia.org/T76082#789388 (10Jdforrester-WMF)
[21:23:30] <wikibugs>	 3VisualEditor, VisualEditor-MediaWiki: [Regression wmf10] Switch to source edit option is disabled - https://phabricator.wikimedia.org/T75965#789390 (10Jdforrester-WMF)
[21:23:44] <TrevorParscal>	 when is that, like now?
[21:23:56] <wikibugs>	 3VisualEditor, VisualEditor-EditingTools, VisualEditor-MediaWiki: [Regression wmf10] Cannot open comment/gallery/special character inspector, they just flicker and get closed - https://phabricator.wikimedia.org/T76076#789393 (10Jdforrester-WMF) p:5Triage>3High a:3Esanders
[21:24:15] <James_F>	 TrevorParscal: Well, we need to give people time to fix/update things.
[21:24:17] <grrrit-wm>	 (03Merged) 10jenkins-bot: Only showSelection if checkSequences actually matched something [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/176070 (owner: 10Divec)
[21:24:27] <James_F>	 TrevorParscal: And Monday is business-tomorrow.
[21:25:24] <grrrit-wm>	 (03PS1) 10Trevor Parscal: Fix RadioOptionWidget demos [oojs/ui] - 10https://gerrit.wikimedia.org/r/176072 
[21:25:34] * James_F looks.
[21:26:24] <TrevorParscal>	 and, in fact, that same issue is why the drag stuff was not showing labels
[21:26:42] <James_F>	 TrevorParscal: Hmm. Display:block?
[21:26:59] <TrevorParscal>	 no, using the wrong method signature for OptionWidget
[21:27:38] <MatmaRex>	 ugh
[21:27:40] <wikibugs>	 3VisualEditor-ContentEditable: [Regression wmf10] cannot open Formula inspector - https://phabricator.wikimedia.org/T76087#789423 (10Etonkovidova) p:5Triage>3High a:3Esanders
[21:27:43] <MatmaRex>	 i can't `git pull`, is it just me?
[21:28:07] <MatmaRex>	 this has been happening repeatedly lately, with git fetches and other simple operations taking five minutes, or timing out
[21:29:08] <grrrit-wm>	 (03PS14) 10Trevor Parscal: Adding DraggableGroupElement and DraggableElement mixins [oojs/ui] - 10https://gerrit.wikimedia.org/r/172325 (owner: 10Mooeypoo)
[21:29:12] <TrevorParscal>	 peep that
[21:29:13] <James_F>	 MatmaRex: gerrit can sometimes be very slow.
[21:29:24] <TrevorParscal>	 ok, we are getting close here
[21:29:36] <MatmaRex>	 James_F: timing out a git fetch after ten minutes is not 'slow', it is 'down'.
[21:29:53] <James_F>	 MatmaRex: It's not been that bad, but close.
[21:29:54] <TrevorParscal>	 mooeypoo: yeah, the rebase you did failed to take into account changes in OptionWidget
[21:29:57] <MatmaRex>	 ah, it completed. rejoice. i wonder if i'll be able to push.
[21:30:05] <TrevorParscal>	 in the demo, specifically
[21:30:59] <James_F>	 TrevorParscal: https://dl.dropboxusercontent.com/u/17195534/Screen%20Shot%202014-11-26%20at%2013.27.15.png
[21:31:10] <James_F>	 TrevorParscal: Surely this is not how it's meant to look, right?
[21:31:21] <James_F>	 MatmaRex: You ask too much, sir. ;-)
[21:31:43] <mooeypoo>	 oi
[21:31:48] <TrevorParscal>	 James_F: yeah, so that's because of the too-powerful rule added here https://gerrit.wikimedia.org/r/#/c/174844/4/src/styles/widgets/OptionWidget.less,unified
[21:31:58] <mooeypoo>	 TrevorParscal, do I need to re-rebase?
[21:32:04] <James_F>	 TrevorParscal: Oh, so https://gerrit.wikimedia.org/r/176072 isn't meant to make that look OK yet?
[21:32:24] <MatmaRex>	 oh, there's a patch for that.
[21:32:26] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] Fix RadioOptionWidget demos [oojs/ui] - 10https://gerrit.wikimedia.org/r/176072 (owner: 10Trevor Parscal)
[21:32:57] <TrevorParscal>	 mooeypoo: I fixed your patch
[21:34:00] <mooeypoo>	 yay, thanks!
[21:35:16] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: RadioOptionWidget: Increase rule specificity to match OptionWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/176122 
[21:35:37] <MatmaRex>	 James_F: this ^ fixes it, needs https://gerrit.wikimedia.org/r/176072 merged first and a rebase
[21:35:46] <James_F>	 MatmaRex: Cool. Thanks!
[21:36:04] <grrrit-wm>	 (03PS1) 10Jforrester: Only showSelection if checkSequences actually matched something [VisualEditor/VisualEditor] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/176129 
[21:36:15] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Only showSelection if checkSequences actually matched something [VisualEditor/VisualEditor] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/176129 (owner: 10Jforrester)
[21:39:02] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] "Yay workage." [oojs/ui] - 10https://gerrit.wikimedia.org/r/176122 (owner: 10Bartosz Dziewoński)
[21:39:06] <James_F>	 MatmaRex: Nice.
[21:39:22] <James_F>	 TrevorParscal: Does that mean Draggable is Mergable? ;-)
[21:39:25] <James_F>	 Timing!
[21:39:53] <mooeypoo>	 hah
[21:40:29] <grrrit-wm>	 (03PS2) 10Jforrester: RadioOptionWidget: Remove lies from documentation [oojs/ui] - 10https://gerrit.wikimedia.org/r/176069 (owner: 10Trevor Parscal)
[21:40:37] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] RadioOptionWidget: Remove lies from documentation [oojs/ui] - 10https://gerrit.wikimedia.org/r/176069 (owner: 10Trevor Parscal)
[21:42:50] <wikibugs>	 3VisualEditor, VisualEditor-MediaWiki: MediaWiki:Visualeditor-wikitext-warning-link should link mediawiki.org - https://phabricator.wikimedia.org/T69273#789449 (10Nemo_bis)
[21:44:40] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Fix RadioOptionWidget demos [oojs/ui] - 10https://gerrit.wikimedia.org/r/176072 (owner: 10Trevor Parscal)
[21:45:21] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 04-2] "Just one sec" [oojs/ui] - 10https://gerrit.wikimedia.org/r/176122 (owner: 10Bartosz Dziewoński)
[21:46:02] <MatmaRex>	 eh
[21:46:34] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: Fix RadioOptionWidget demos [oojs/ui] - 10https://gerrit.wikimedia.org/r/176072 (owner: 10Trevor Parscal)
[21:46:38] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] Fix RadioOptionWidget demos [oojs/ui] - 10https://gerrit.wikimedia.org/r/176072 (owner: 10Trevor Parscal)
[21:47:15] <grrrit-wm>	 (03PS29) 10Divec: Use a single unicorn-like <img> instead of &#xFEFF; in inline slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151046 (owner: 10Catrope)
[21:47:17] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "This should be rebased on top of https://gerrit.wikimedia.org/r/#/c/176072/ , since that one implements the widgets demo changes. They sho" [oojs/ui] - 10https://gerrit.wikimedia.org/r/176122 (owner: 10Bartosz Dziewoński)
[21:47:37] <grrrit-wm>	 (03PS5) 10Divec: WIP: Rerender ContentBranchNodes when the selection anchor leaves [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/171494 
[21:50:32] <wikibugs>	 3VisualEditor: VisualEditor is not displayed after clicking on Edit - https://phabricator.wikimedia.org/T76081#789464 (10Lorenzocipriani) Maybe I found something:  ``` /* exception 'MWException' with message 'ResourceLoaderFileModule::readScriptFiles: script file not found: ".../extensions/VisualEditor/lib/ve/sr...
[21:53:22] <wikibugs>	 3VisualEditor, VisualEditor-EditingTools: [Regression wmf10] Toolbar for Basic Reference and Media Settings dialog is broken - https://phabricator.wikimedia.org/T76073#789468 (10Catrope) Should be fixed by https://gerrit.wikimedia.org/r/#/c/175936/
[21:56:55] <wikibugs>	 3VisualEditor, Beta-Cluster: VisualEditor not updating in beta labs - https://phabricator.wikimedia.org/T76097#789475 (10Catrope)
[21:59:50] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Fix RadioOptionWidget demos [oojs/ui] - 10https://gerrit.wikimedia.org/r/176072 (owner: 10Trevor Parscal)
[21:59:52] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Only showSelection if checkSequences actually matched something [VisualEditor/VisualEditor] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/176129 (owner: 10Jforrester)
[22:03:53] <cscott>	 James_F|Away: parsoid deploy complete, could you test your config change?
[22:04:47] <TrevorParscal>	 so, status of https://gerrit.wikimedia.org/r/#/c/176122/ and https://gerrit.wikimedia.org/r/#/c/176072/ ?
[22:05:07] <TrevorParscal>	 mooeypoo: looking at draggable, one sec
[22:05:09] <grrrit-wm>	 (03Merged) 10jenkins-bot: RadioOptionWidget: Remove lies from documentation [oojs/ui] - 10https://gerrit.wikimedia.org/r/176069 (owner: 10Trevor Parscal)
[22:06:45] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix RadioOptionWidget demos [oojs/ui] - 10https://gerrit.wikimedia.org/r/176072 (owner: 10Trevor Parscal)
[22:07:38] <mooeypoo>	 shoot, I screwed up git
[22:09:10] <mooeypoo>	 RoanKattouw, help help 
[22:09:26] <mooeypoo>	 RoanKattouw, I ran into this before and I forgot. I need to revert *locally* to a local commit thta isn't the current one
[22:09:36] <mooeypoo>	 I once again overrode my local commit with a gerrit one :(
[22:13:51] <grrrit-wm>	 (03PS2) 10Bartosz Dziewoński: RadioOptionWidget: Increase rule specificity to match OptionWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/176122 
[22:13:57] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] RadioOptionWidget: Increase rule specificity to match OptionWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/176122 (owner: 10Bartosz Dziewoński)
[22:14:41] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: RadioOptionWidget: Increase rule specificity to match OptionWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/176122 (owner: 10Bartosz Dziewoński)
[22:14:52] <wikibugs>	 3VisualEditor, Beta-Cluster: VisualEditor not updating in beta labs - https://phabricator.wikimedia.org/T76097#789504 (10bd808) deployment-bastion:/srv/mediawiki-staging/php-master/extensions/VisualEditor is at git hash a14f88d which seems to match https://git.wikimedia.org/summary/mediawiki%2Fextensions%2FVisua...
[22:18:31] <James_F>	 MatmaRex: Tsk, self-+2. ;-)
[22:18:52] <MatmaRex>	 only prodding jenkins.
[22:18:58] <James_F>	 Yeah, I know.
[22:19:00] <MatmaRex>	 i'm not sure if it helped.
[22:19:17] <grrrit-wm>	 (03Merged) 10jenkins-bot: RadioOptionWidget: Increase rule specificity to match OptionWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/176122 (owner: 10Bartosz Dziewoński)
[22:19:18] <James_F>	 MatmaRex: The gate-and-submit is running.
[22:19:20] <James_F>	 Ha.
[22:19:21] <James_F>	 Worked.
[22:19:34] <wikibugs>	 3VisualEditor, Wikimedia-Extension-setup: VisualEditor has been disabled unexpectedly on fr.wiktionary - https://phabricator.wikimedia.org/T76099#789510 (10Automatik)
[22:19:45] <grrrit-wm>	 (03PS4) 10Jforrester: MessageDialog: Actually correctly calculate and set height [oojs/ui] - 10https://gerrit.wikimedia.org/r/175926 (owner: 10Bartosz Dziewoński)
[22:19:54] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] "C'mon." [oojs/ui] - 10https://gerrit.wikimedia.org/r/175926 (owner: 10Bartosz Dziewoński)
[22:20:07] <James_F>	 TrevorP|Away: Where are we at with https://gerrit.wikimedia.org/r/#/c/172325/ ?
[22:23:14] <TrevorParscal>	 doing final review now
[22:23:23] <mooeypoo>	 James_F, is RoanKattouw next to you by any chance?
[22:23:35] <James_F>	 mooeypoo: Yes.
[22:23:50] <RoanKattouw>	 mooeypoo: Yes, your git problem, sorry
[22:23:51] <mooeypoo>	 Can you poke him and say mooey says "AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA". ?
[22:23:58] <mooeypoo>	 :D
[22:24:14] <mooeypoo>	 RoanKattouw, sorry, I know you told me this before, but I am a little worried of doing this wrong 
[22:24:16] <RoanKattouw>	 mooeypoo: Do you remember / have the git hash of the commit you want to move to?
[22:24:29] <RoanKattouw>	 If not, you can probably recover it from git reflog
[22:24:35] <TrevorParscal>	 the CSS isn't setup right
[22:24:36] <mooeypoo>	 so, I am trying to remember how to find the hash. Is that with "show head" ?
[22:24:41] <TrevorParscal>	 it's not themable right now
[22:25:12] <RoanKattouw>	 mooeypoo: git reflog will list a recent history of hashes. You can inspect a hash using git show 123abc
[22:25:17] <RoanKattouw>	 to see if it's the right one
[22:25:22] <TrevorParscal>	 my recomendation to use special grabing pointers wasn't responded to
[22:25:44] <mooeypoo>	 RoanKattouw, so, i'm looking for the lst one that was "commit"
[22:25:45] <mooeypoo>	 right?
[22:26:21] <RoanKattouw>	 Probably?
[22:26:24] <TrevorParscal>	 dropping non-owned items appears to be fixed
[22:26:28] * mooeypoo is checking
[22:26:34] <RoanKattouw>	 It's not always super clear, I often have to try a few before I find the right one
[22:27:09] <mooeypoo>	 yes! found it
[22:27:23] <mooeypoo>	 (I hope.)
[22:27:32] <wikibugs>	 3VisualEditor-ContentEditable: Inserted media in Table Caption gets de-attached after Save - https://phabricator.wikimedia.org/T76100 (10Etonkovidova) 3NEW p:3Triage
[22:27:37] <mooeypoo>	 frm the git show 435f49d it looks like it's the right one
[22:27:52] <RoanKattouw>	 OK, I'm assuming you're on a branch called review/mooeypoo/something and you accidentally reset it using git review -d ?
[22:27:53] <wikibugs>	 3VisualEditor, Wikimedia-Extension-setup: VisualEditor has been disabled unexpectedly on fr.wiktionary - https://phabricator.wikimedia.org/T76099#789540 (10Jdforrester-WMF)
[22:27:59] * mooeypoo nods
[22:28:01] <mooeypoo>	 exactly
[22:28:11] <RoanKattouw>	 Then run git reset --hard 435f49d
[22:28:18] <RoanKattouw>	 ALSO
[22:28:21] <RoanKattouw>	 This will DESTROY local changes
[22:28:25] <RoanKattouw>	 So run git status first
[22:28:30] <RoanKattouw>	 To check you have no uncommitted changes
[22:28:30] <mooeypoo>	 yeah I have no local changes
[22:28:30] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 04-1] "The CSS as setup isn't theme-able. Look at how other widgets are setup and copy it. Essentially you specify an emtpy mixin, invoke that mi" [oojs/ui] - 10https://gerrit.wikimedia.org/r/172325 (owner: 10Mooeypoo)
[22:28:51] <wikibugs>	 3VisualEditor, Beta-Cluster: VisualEditor not updating in beta labs - https://phabricator.wikimedia.org/T76097#789542 (10bd808)
[22:29:03] <MatmaRex>	 i like that the horrible code in https://gerrit.wikimedia.org/r/#/c/175926/ has three +2s.
[22:29:18] <mooeypoo>	 RoanKattouw, perfect! I'm back! thank you!!!
[22:29:29] <TrevorParscal>	 lol
[22:29:49] <RoanKattouw>	 MatmaRex: Awesome commit summary
[22:29:56] <TrevorParscal>	 i know right?
[22:30:07] <mooeypoo>	 RoanKattouw, okay, another issue. So, this problem started from the fact that I accidentally created a patch today without creating a branch for it (whoops)
[22:30:47] <mooeypoo>	 then I went to the commit I'm in, and (like a champ!) rebased it... which turned out it's on the wrong commit, because the "master" had "ahead 1 commit" for obvious reasons. I since reset the master, but *now* my branch seems to be dependent on the other commit
[22:31:04] <mooeypoo>	 RoanKattouw, so, I wnat to rebase onto master. That's "rebase --onto master HEAD^" ?
[22:31:15] <mooeypoo>	 or something similar
[22:32:14] <RoanKattouw>	 mooeypoo: OK so let's back up for a second
[22:32:32] <RoanKattouw>	 mooeypoo: Presumably your master has everything it's supposed to have, plus one commit of yours?
[22:32:42] <mooeypoo>	 https://gerrit.wikimedia.org/r/#/c/176028/ <-- this has no separate branch, because I'm silly.
[22:33:07] <mooeypoo>	 After doing that, I went to my currently-problematic branch and worked on it, noticed it's not rebsed, and went "git rebase master"
[22:33:23] <RoanKattouw>	 Right
[22:33:27] <mooeypoo>	 then when I wanted to send to review, it told me it is now dependent on the 176028 branch
[22:33:31] <mooeypoo>	 which was a problem
[22:33:33] <wikibugs>	 3VisualEditor: VisualEditor is not displayed after clicking on Edit - https://phabricator.wikimedia.org/T76081#789561 (10Jdforrester-WMF) 5Open>3Resolved a:3Jdforrester-WMF Aha. That means you didn't checkout the actual code for VisualEditor itself, just the MediaWiki extension that embeds it. You need to...
[22:33:38] <RoanKattouw>	 So yeah if you do git checkout master ; git log , you will probably see 176028 at the top, right?
[22:33:41] <mooeypoo>	 so I went back to master, went "git reset --hard HEAD^" and it was done
[22:33:45] <RoanKattouw>	 OK
[22:33:49] <RoanKattouw>	 Good, so you fixed that
[22:33:49] <mooeypoo>	 master is fine now
[22:33:52] <RoanKattouw>	 Awesome
[22:34:01] <RoanKattouw>	 So yeah for your other branch, git rebase --onto master HEAD^ will do it
[22:34:19] <mooeypoo>	 but then I went back to my problem-branch (accidentally by asking for it from review, which caused the previous problem) but then when I reset the correct commit, it's still rebased onto the *wrong* branch.
[22:34:21] <mooeypoo>	 ah, excellent
[22:34:22] <mooeypoo>	 thanks!
[22:35:12] <grrrit-wm>	 (03PS8) 10Mooeypoo: [WIP] Transform the search widget to show image details [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161342 
[22:35:14] * mooeypoo crosses her fingers
[22:35:24] <mooeypoo>	 woot! RoanKattouw thanks!
[22:35:57] <wikibugs>	 3VisualEditor, Beta-Cluster: VisualEditor not updating in beta labs - https://phabricator.wikimedia.org/T76097#789575 (10Jdforrester-WMF)
[22:39:32] <grrrit-wm>	 (03CR) 10Jforrester: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/176028 (owner: 10Mooeypoo)
[22:39:45] <mooeypoo>	 TrevorParscal, also, if you get time to look at TemplateData, ignore the fact jenkins marked it as "x" ... qunit tests actually do pass, but for some reason jenkins thinks they don't.
[22:40:20] <TrevorParscal>	 ok, cool
[22:40:29] <wikibugs>	 3VisualEditor, VisualEditor-EditingTools: [Regression pre-wmf10] Toolbar for Basic Reference and Media Settings dialog is broken - https://phabricator.wikimedia.org/T76073#789585 (10Jdforrester-WMF) a:3Jdforrester-WMF
[22:40:32] <TrevorParscal>	 James_F: so, what's up? the draggable commit isn't ready
[22:40:54] <James_F>	 TrevorParscal: Do you want to wait for it to be ready, or should we cut OOUI now and have it wait a week?
[22:41:32] <wikibugs>	 3VisualEditor, VisualEditor-EditingTools: [Regression pre-wmf10] Toolbar for Basic Reference and Media Settings dialog is broken - https://phabricator.wikimedia.org/T76073#789076 (10Jdforrester-WMF)
[22:41:39] <wikibugs>	 3VisualEditor, VisualEditor-EditingTools: [Regression pre-wmf10] Toolbar for Basic Reference and Media Settings dialog is broken - https://phabricator.wikimedia.org/T76073#789076 (10Jdforrester-WMF) 5Open>3Resolved
[22:42:17] <TrevorParscal>	 I don't want to rush it - it only needs to go out with the code that depends on it (template data) which isn't going out this week, right?
[22:42:49] <mooeypoo>	 TrevorParscal, no, and even if itis, the code that depends on draggable is separate 
[22:42:57] <mooeypoo>	 I made it separate on purpose
[22:43:10] <James_F>	 TrevorParscal: Well, it would be nice to go out when needed.
[22:43:45] <TrevorParscal>	 I think we can cut it now
[22:43:53] <James_F>	 OK.
[22:43:59] <TrevorParscal>	 I mean, it's a 4 day weekend, not much is going down between now and next week man
[22:44:14] <James_F>	 Oh, wait, we should wait for https://gerrit.wikimedia.org/r/#/c/175926/
[22:44:31] <James_F>	 (Jenkins is very much flaky right now.)
[22:44:44] <James_F>	 Don't re-+2 it; I can see that other things are blocking it.
[22:45:10] <wikibugs>	 3VisualEditor, Wikimedia-Extension-setup: VisualEditor has been disabled unexpectedly on fr.wiktionary - https://phabricator.wikimedia.org/T76099#789595 (10Jdforrester-WMF)
[22:45:15] <wikibugs>	 3VisualEditor, Beta-Cluster: VisualEditor not updating in beta labs - https://phabricator.wikimedia.org/T76097#789597 (10Jdforrester-WMF)
[22:45:59] <TrevorParscal>	 it's tripple +2'd what are we waiting for?
[22:46:33] <James_F>	 TrevorParscal: Wikidata jobs, mostly.
[22:46:45] <James_F>	 And VE ones, to be fair.
[22:46:57] <grrrit-wm>	 (03PS1) 10Catrope: Followup 166a52b: don't disable tools that don't have commands [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/176158 
[22:47:24] <grrrit-wm>	 (03Merged) 10jenkins-bot: MessageDialog: Actually correctly calculate and set height [oojs/ui] - 10https://gerrit.wikimedia.org/r/175926 (owner: 10Bartosz Dziewoński)
[22:47:27] <James_F>	 Yay.
[22:47:31] <James_F>	 OK. Branch time.
[22:48:53] <wikibugs>	 3VisualEditor-EditingTools: [Regression wmf9] inserting formulae gives 'TypeError: undefined is not a function' (ve.bind) - https://phabricator.wikimedia.org/T75627#789610 (10Ryasmeen) Verified the fix in test2 and production
[22:54:25] <wikibugs>	 3OOjs-UI: Issues with dialog sizing on first open - https://phabricator.wikimedia.org/T72061#789636 (10matmarex) This should be all fixed now. Rigorous testing would be very useful, though.
[22:55:47] <grrrit-wm>	 (03PS1) 10Jforrester: Tag v0.2.3 [oojs/ui] - 10https://gerrit.wikimedia.org/r/176159 
[22:55:54] <James_F>	 TrevorParscal: Want to do the honours? ;-)
[22:56:08] <wikibugs>	 3VisualEditor-EditingTools: [Regression wmf9] inserting formulae gives 'TypeError: undefined is not a function' (ve.bind) - https://phabricator.wikimedia.org/T75627#789641 (10Ryasmeen)
[22:56:31] <wikibugs>	 3VisualEditor: VisualEditor: Tables wikitext can be inconsistent - https://phabricator.wikimedia.org/T75215#789643 (10Arlolra)
[22:58:09] <wikibugs>	 3OOjs-UI: Issues with dialog sizing on first open - https://phabricator.wikimedia.org/T72061#789652 (10Jdforrester-WMF) 5Open>3Resolved
[22:58:34] <wikibugs>	 3VisualEditor-MediaWiki-Mobile: [Regression wmf9] VisualEditor fails to load (ve.ui.MobileContext.css not defined?) - https://phabricator.wikimedia.org/T75646#789654 (10Ryasmeen)
[22:59:06] <wikibugs>	 3VisualEditor-MediaWiki-Mobile: [Regression wmf9] VisualEditor fails to load (ve.ui.MobileContext.css not defined?) - https://phabricator.wikimedia.org/T75646#789655 (10Ryasmeen)
[22:59:55] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] Tag v0.2.3 [oojs/ui] - 10https://gerrit.wikimedia.org/r/176159 (owner: 10Jforrester)
[23:09:22] <wikibugs>	 3VisualEditor: VisualEditor: new autoadded reflist does not display when in VE edit mode - https://phabricator.wikimedia.org/T69873#789698 (10Arlolra)
[23:10:30] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Tag v0.2.3 [oojs/ui] - 10https://gerrit.wikimedia.org/r/176159 (owner: 10Jforrester)
[23:10:34] <wikibugs>	 3OOjs-UI: MessageDialog do not re-fit actions on window resize - https://phabricator.wikimedia.org/T75783#789701 (10Jdforrester-WMF)
[23:10:47] <James_F>	 OFFS.
[23:10:51] * James_F glares at Krinkle|detached.
[23:11:06] <grrrit-wm>	 (03CR) 10Jforrester: "recheck" [oojs/ui] - 10https://gerrit.wikimedia.org/r/176159 (owner: 10Jforrester)
[23:20:12] <wikibugs>	 3VisualEditor, VisualEditor-EditingTools: [Regression ?wmf8] Typing inside dialog surfaces for the first time in a session: the letters gets garbled and "Insert" button remains disabled in Firefox - https://phabricator.wikimedia.org/T75625#789714 (10Ryasmeen)
[23:20:44] <wikibugs>	 3VisualEditor, VisualEditor-EditingTools: [Regression ?wmf8] Typing inside dialog surfaces for the first time in a session: the letters gets garbled and "Insert" button remains disabled in Firefox - https://phabricator.wikimedia.org/T75625#789715 (10Ryasmeen)
[23:23:46] <James_F>	 MatmaRex: Anything in https://phabricator.wikimedia.org/project/board/697/?order=priority take your fancy? :-)
[23:24:28] <wikibugs>	 3VisualEditor: VisualEditor is not displayed after clicking on Edit - https://phabricator.wikimedia.org/T76081#789722 (10Lorenzocipriani) Yes, I found it and already did it, thanks.  Now I'm investigating another issue. {F16587} After I click on Edit the loader bar rolls forever and the editing area never appear...
[23:25:15] <MatmaRex>	 James_F: i guess you still want me to do the toolbars things
[23:27:26] <TrevorParscal>	 so, is https://gerrit.wikimedia.org/r/#/c/176159/ stuck in code purgatory?
[23:28:06] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] Tag v0.2.3 [oojs/ui] - 10https://gerrit.wikimedia.org/r/176159 (owner: 10Jforrester)
[23:28:15] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: Tag v0.2.3 [oojs/ui] - 10https://gerrit.wikimedia.org/r/176159 (owner: 10Jforrester)
[23:28:41] <wikibugs>	 3VisualEditor-EditingTools: VisualEditor:[Regression wmf8] All inspector dialog UI is broken when added inside Reference/Media Settings dialog box - https://phabricator.wikimedia.org/T75542#789728 (10Ryasmeen) Verified the fix in en.wiki
[23:29:07] <wikibugs>	 3VisualEditor-EditingTools: VisualEditor:[Regression wmf8] All inspector dialog UI is broken when added inside Reference/Media Settings dialog box - https://phabricator.wikimedia.org/T75542#789729 (10Ryasmeen)
[23:35:31] <wikibugs>	 3VisualEditor-EditingTools: VisualEditor: [Regression wmf5] Have to undo twice to reverse comment creation - https://phabricator.wikimedia.org/T74315#789743 (10Etonkovidova)
[23:35:59] <James_F>	 MatmaRex: :-D
[23:36:20] <James_F>	 TrevorParscal: Looks like it died somehow; hopefully it will now merge.
[23:36:23] <James_F>	 (Thanks MatmaRex.)
[23:36:24] <wikibugs>	 3OOjs-UI: OOjs UI: OO.ui.ButtonWidget default target should not be "_blank" - https://phabricator.wikimedia.org/T75452#789745 (10matmarex)
[23:36:26] <grrrit-wm>	 (03Merged) 10jenkins-bot: Tag v0.2.3 [oojs/ui] - 10https://gerrit.wikimedia.org/r/176159 (owner: 10Jforrester)
[23:36:30] <James_F>	 Whee.
[23:36:40] <MatmaRex>	 let's push through that one, too. it's been annoying me as well
[23:37:21] <James_F>	 Doing so now.
[23:38:26] <wikibugs>	 3VisualEditor, Beta-Cluster: [Regression pre-wmf10] upload.beta.wmflabs.org is throwing 503s so all images are appearing with a broken icon inside VE - https://phabricator.wikimedia.org/T75786#789747 (10Ryasmeen)
[23:38:53] <wikibugs>	 3VisualEditor, Beta-Cluster: [Regression pre-wmf10] upload.beta.wmflabs.org is throwing 503s so Math function parsing is completely broken inside VE - https://phabricator.wikimedia.org/T75787#789748 (10Ryasmeen)
[23:39:19] <github>	 [13oojs.github.io] 15jdforrester created 06oojs-ui.2.3 (+1 new commit): 02https://github.com/oojs/oojs.github.io/commit/94a6e7e73b76
[23:39:20] <github>	 13oojs.github.io/06oojs-ui.2.3 1494a6e7e 15James D. Forrester: Add OOjs UI 0.2.3 release from npm
[23:41:20] <grrrit-wm>	 (03PS1) 10Jforrester: Update OOjs UI to v0.2.3 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/176175 
[23:41:54] <wikibugs>	 3VisualEditor, VisualEditor-EditingTools: [Regression pre-wmf10] Toolbar for Basic Reference and Media Settings dialog is broken - https://phabricator.wikimedia.org/T76073#789753 (10Ryasmeen)
[23:42:12] <wikibugs>	 3VisualEditor, VisualEditor-EditingTools: [Regression pre-wmf10] Toolbar for Basic Reference and Media Settings dialog is broken - https://phabricator.wikimedia.org/T76073#789754 (10Ryasmeen)
[23:43:29] <wikibugs>	 3VisualEditor: [Regression pre-wmf10]  Cannot close Citation dialog , error in the console:TypeError: this.outlineSelectWidget is undefined - https://phabricator.wikimedia.org/T75942#789760 (10Ryasmeen)
[23:43:40] <wikibugs>	 3VisualEditor: [Regression pre-wmf10]  Cannot close Citation dialog , error in the console:TypeError: this.outlineSelectWidget is undefined - https://phabricator.wikimedia.org/T75942#789761 (10Ryasmeen)
[23:43:58] <wikibugs>	 3VisualEditor-MediaWiki: VisualEditor: Math rendering 2.0 does not work in edit mode - https://phabricator.wikimedia.org/T74539#789762 (10Etonkovidova) Verified in production  - used the sample from https://pt.wikipedia.org/w/index.php?diff=40380507: \frac{\sqrt{(x+1)}}{y^2}
[23:44:20] <wikibugs>	 3VisualEditor-MediaWiki: VisualEditor: Math rendering 2.0 does not work in edit mode - https://phabricator.wikimedia.org/T74539#789763 (10Etonkovidova)
[23:44:56] <wikibugs>	 3VisualEditor, VisualEditor-EditingTools: Add support for <blockquote>s - https://phabricator.wikimedia.org/T53009#789768 (10Ryasmeen)
[23:46:38] <RoanKattouw>	 James_F: https://gerrit.wikimedia.org/r/176158
[23:46:43] <wikibugs>	 3VisualEditor, MediaWiki-extensions-UniversalLanguageSelector, VisualEditor-EditingTools: IME selector shows up at the bottom-right corner of the table while selecting a cell on a table or placing a cursor into it - https://phabricator.wikimedia.org/T74824#789773 (10Ryasmeen)
[23:47:16] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Followup 166a52b: don't disable tools that don't have commands [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/176158 (owner: 10Catrope)
[23:47:26] <grrrit-wm>	 (03PS1) 10Jforrester: Followup 166a52b: don't disable tools that don't have commands [VisualEditor/VisualEditor] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/176179 
[23:47:32] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Followup 166a52b: don't disable tools that don't have commands [VisualEditor/VisualEditor] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/176179 (owner: 10Jforrester)
[23:48:35] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update OOjs UI to v0.2.3 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/176175 (owner: 10Jforrester)
[23:48:53] <wikibugs>	 3VisualEditor, VisualEditor-MediaWiki: After updating a page <br /> gets added after the timestamp of last edit made on that page - https://phabricator.wikimedia.org/T75571#789775 (10Ryasmeen)
[23:49:13] <grrrit-wm>	 (03CR) 10Jforrester: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/176175 (owner: 10Jforrester)
[23:49:42] <grrrit-wm>	 (03PS1) 10Catrope: Followup c56a921: use cite-transclusion-* tools in MWReferenceDialog, not cite-* [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/176180 
[23:49:47] <RoanKattouw>	 James_F: And that one ---^^
[23:50:38] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Followup c56a921: use cite-transclusion-* tools in MWReferenceDialog, not cite-* [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/176180 (owner: 10Catrope)
[23:50:49] <wikibugs>	 3VisualEditor-ContentEditable: VisualEditor: Link inspector opens in a upper left corner in Safari - https://phabricator.wikimedia.org/T75336#789778 (10Etonkovidova) 5Resolved>3declined
[23:51:01] <wikibugs>	 3VisualEditor, VisualEditor-MediaWiki: [Regression wmf10] Switch to source edit option is disabled - https://phabricator.wikimedia.org/T75965#789780 (10Jdforrester-WMF)
[23:51:11] <wikibugs>	 3VisualEditor, VisualEditor-MediaWiki: [Regression wmf10] Switch to source edit option is disabled - https://phabricator.wikimedia.org/T75965#789781 (10Jdforrester-WMF) a:3Catrope
[23:51:52] <wikibugs>	 3VisualEditor: [Regression wmf10] Basic reference that has Citation inside tries to render it as Basic Reference (<ref><ref>{{Cite web }}</ref></ref>)and thus fails - https://phabricator.wikimedia.org/T76082#789785 (10Jdforrester-WMF)
[23:52:04] <wikibugs>	 3VisualEditor: [Regression wmf10] Basic reference that has Citation inside tries to render it as Basic Reference (<ref><ref>{{Cite web }}</ref></ref>)and thus fails - https://phabricator.wikimedia.org/T76082#789787 (10Jdforrester-WMF) a:3Catrope
[23:52:13] <RoanKattouw>	 mooeypoo: Does https://gerrit.wikimedia.org/r/#/c/176028/3/modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js actually fix anything? I don't believe it should, but maybe something mysterious is happening
[23:52:40] <grrrit-wm>	 (03CR) 10Catrope: [C: 032 V: 032] Followup 142a44e: fix path names to MobileContextItemWidget.{js,css} [extensions/VisualEditor] (wmf/1.25wmf9) - 10https://gerrit.wikimedia.org/r/176052 (owner: 10Catrope)
[23:54:02] <wikibugs>	 3VisualEditor-MediaWiki: VisualEditor: Restore selection when user exits the save dialog (on clicking "Resume editing") - https://phabricator.wikimedia.org/T74911#789805 (10Etonkovidova)
[23:55:57] <grrrit-wm>	 (03Merged) 10jenkins-bot: Followup c56a921: use cite-transclusion-* tools in MWReferenceDialog, not cite-* [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/176180 (owner: 10Catrope)
[23:56:24] <grrrit-wm>	 (03Merged) 10jenkins-bot: Followup 166a52b: don't disable tools that don't have commands [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/176158 (owner: 10Catrope)
[23:56:26] <grrrit-wm>	 (03PS1) 10Catrope: Followup c56a921: use cite-transclusion-* tools in MWReferenceDialog, not cite-* [extensions/VisualEditor] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/176184 
[23:56:28] <grrrit-wm>	 (03Merged) 10jenkins-bot: Followup 166a52b: don't disable tools that don't have commands [VisualEditor/VisualEditor] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/176179 (owner: 10Jforrester)
[23:56:30] <grrrit-wm>	 (03PS2) 10Catrope: Followup c56a921: use cite-transclusion-* tools in MWReferenceDialog, not cite-* [extensions/VisualEditor] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/176184 
[23:56:36] <grrrit-wm>	 (03CR) 10Catrope: [C: 032 V: 032] Followup c56a921: use cite-transclusion-* tools in MWReferenceDialog, not cite-* [extensions/VisualEditor] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/176184 (owner: 10Catrope)
[23:57:54] <grrrit-wm>	 (03PS1) 10Catrope: Update VE core for cherry-pick [extensions/VisualEditor] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/176185 
[23:58:05] <grrrit-wm>	 (03CR) 10Catrope: [C: 032 V: 032] Update VE core for cherry-pick [extensions/VisualEditor] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/176185 (owner: 10Catrope)
[23:58:43] <wikibugs>	 3VisualEditor-EditingTools: VisualEditor: [Regression wmf5] Comment inspector closes and saves empty comment when tool is used - https://phabricator.wikimedia.org/T73706#789834 (10Etonkovidova)
[23:59:30] <mooeypoo>	 RoanKattouw, it does, yes. 
[23:59:55] <mooeypoo>	 RoanKattouw, without it, the dialog doesn't recognize when a user changes something in the caption surface