[02:12:32] 3VisualEditor, VisualEditor-ContentLanguage: Cursor error typing into end of paragraph with Ibus Malayalam Swanalekha - https://phabricator.wikimedia.org/T56057#793942 (10Jdforrester-WMF) [02:21:43] 3VisualEditor, VisualEditor-MediaWiki: The (Ctrl+Alt+S) keyboard shortcut opens the Save dialog but should also trigger save when in it - https://phabricator.wikimedia.org/T76161#793944 (10Jdforrester-WMF) [02:22:10] 3VisualEditor, VisualEditor-MediaWiki: The (Ctrl+Alt+S) keyboard shortcut opens the Save dialog but should also trigger save when in it - https://phabricator.wikimedia.org/T76161#792208 (10Jdforrester-WMF) [02:22:59] 3VisualEditor: Insert special character broken - https://phabricator.wikimedia.org/T76134#793948 (10Jdforrester-WMF) [02:23:00] 3VisualEditor, VisualEditor-EditingTools, VisualEditor-MediaWiki: [Regression wmf10] Cannot open comment/gallery/special character inspector, they just flicker and get closed - https://phabricator.wikimedia.org/T76076#793949 (10Jdforrester-WMF) [02:23:36] 3VisualEditor, MediaWiki-skins-Chameleon: Dropdowns in the VE toolbar opening "under" the content area in the Chameleon skin - https://phabricator.wikimedia.org/T72678#793951 (10Jdforrester-WMF) [02:23:42] 3VisualEditor, MediaWiki-skins-Chameleon: Dropdowns in the VE toolbar opening "under" the content area in the Chameleon skin - https://phabricator.wikimedia.org/T72678#757650 (10Jdforrester-WMF) [02:25:20] 3VisualEditor: The dialog to search for images to add should have a "Hide images already on the page" checkbox - https://phabricator.wikimedia.org/T76220#793953 (10Jdforrester-WMF) p:5Triage>3Low [02:25:23] 3VisualEditor: The dialog to search for images to add should have a "Hide images already on the page" checkbox - https://phabricator.wikimedia.org/T76220#793232 (10Jdforrester-WMF) [02:32:57] 3VisualEditor, VisualEditor-EditingTools: Suggestions list should not be cropped to the dialog they're in, but to the document - https://phabricator.wikimedia.org/T76235#793958 (10Jdforrester-WMF) [02:33:01] 3VisualEditor, VisualEditor-EditingTools: Suggestions list should not be cropped to the dialog they're in, but to the document - https://phabricator.wikimedia.org/T76235#793446 (10Jdforrester-WMF) [02:35:15] 3VisualEditor, VisualEditor-EditingTools: [Regression wmf10] is displayed in Headings menu - https://phabricator.wikimedia.org/T76072#793963 (10Jdforrester-WMF) [02:35:25] 3VisualEditor, VisualEditor-EditingTools: [Regression wmf10] is displayed in Headings menu - https://phabricator.wikimedia.org/T76072#789060 (10Jdforrester-WMF) p:5Triage>3Normal [02:35:33] 3VisualEditor, VisualEditor-EditingTools: [Regression wmf10] is displayed in Headings menu - https://phabricator.wikimedia.org/T76072#789060 (10Jdforrester-WMF) 5Open>3declined a:3Jdforrester-WMF This functionality was released in wmf10 so shouldn't show up i... [02:37:20] 3VisualEditor, OOjs-UI: Tools in the toolbar do not have unique attributes - https://phabricator.wikimedia.org/T76143#793969 (10Jdforrester-WMF) [02:38:11] (03CR) 10Jforrester: [C: 04-1] "See my comments on the task. Verging on a -2." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174666 (owner: 10Amire80) [02:38:36] 3VisualEditor, OOjs-UI: Tools in the toolbar do not have unique attributes - https://phabricator.wikimedia.org/T76143#793972 (10Jdforrester-WMF) [02:38:40] 3VisualEditor, OOjs-UI: Tools in the toolbar do not have unique attributes - https://phabricator.wikimedia.org/T76143#791133 (10Jdforrester-WMF) [02:39:40] 3VisualEditor, VisualEditor-ContentEditable: [Regression wmf10] cannot open Formula inspector - https://phabricator.wikimedia.org/T76087#793974 (10Jdforrester-WMF) [02:39:42] 3VisualEditor, VisualEditor-EditingTools, VisualEditor-MediaWiki: [Regression wmf10] Cannot open comment/gallery/special character inspector, they just flicker and get closed - https://phabricator.wikimedia.org/T76076#793975 (10Jdforrester-WMF) [02:39:57] 3VisualEditor, VisualEditor-EditingTools, VisualEditor-MediaWiki: [Regression wmf10] Cannot open any inspectors, they just flicker and get closed - https://phabricator.wikimedia.org/T76076#793977 (10Jdforrester-WMF) p:5High>3Unbreak! [02:44:15] 3VisualEditor, Beta-Cluster: VisualEditor not updating in beta labs - https://phabricator.wikimedia.org/T76097#793980 (10Jdforrester-WMF) [02:59:17] (03PS1) 10Jforrester: Update VE core submodule to master (b5a0269) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/176392 [03:02:46] (03CR) 10Jforrester: [C: 031] Cancel VE when escape key pressed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175869 (owner: 10Alex Monk) [03:03:14] (03Abandoned) 10Jforrester: Update VE core submodule to master (b5a0269) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/176203 (owner: 10Jforrester) [03:07:18] (03CR) 10Jforrester: [C: 032] "Dependency is in OOUI v0.2.3 which we now use." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175883 (owner: 10Esanders) [03:07:25] (03CR) 10Jforrester: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175883 (owner: 10Esanders) [03:25:41] (03CR) 10Jforrester: "I don't quite understand how "pagedeleted" gets turned into "editPageDeleted" or whatever – or, for that matter, how "newuser" gets turned" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175795 (owner: 10Catrope) [03:26:13] (03CR) 10Jforrester: [C: 031] Find and replace [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/174491 (owner: 10Esanders) [03:27:46] 3VisualEditor, VisualEditor-MediaWiki: The message visualeditor-recreate says "Press continue", but it's unclear what does "continue" refer to - https://phabricator.wikimedia.org/T75971#793981 (10Jdforrester-WMF) [04:08:05] 3VisualEditor, VisualEditor-MediaWiki: The message visualeditor-recreate says "Press continue", but it's unclear what does "continue" refer to - https://phabricator.wikimedia.org/T75971#793998 (10Liuxinyu970226) [09:33:50] (03PS1) 10Prtksxna: mediawiki: Reduce indentation in theme-oo-ui-checkboxInputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/176396 [09:33:52] (03PS1) 10Prtksxna: mediawiki.ui: checkbox: Fix states according to spec [oojs/ui] - 10https://gerrit.wikimedia.org/r/176397 [09:33:54] (03PS1) 10Prtksxna: MediaWiki Theme: Add radio buttons [oojs/ui] - 10https://gerrit.wikimedia.org/r/176398 [09:42:37] 3VisualEditor, OOjs-UI: Tools in the toolbar do not have unique attributes - https://phabricator.wikimedia.org/T76143#794185 (10zeljkofilipin) [15:14:04] 3VisualEditor, OOjs-UI: Tools in the toolbar do not have unique attributes - https://phabricator.wikimedia.org/T76143#794289 (10zeljkofilipin) >>! In T76143#793969, @Jdforrester-WMF wrote: > I'm not sure I agree with the premise here, that bloating the DOM model and so taking up more memory/etc. is a worthwhile... [15:22:05] 3VisualEditor, OOjs-UI: Tools in the toolbar do not have unique attributes - https://phabricator.wikimedia.org/T76143#794291 (10zeljkofilipin) >>! In T76143#793969, @Jdforrester-WMF wrote: > I'm not sure I agree with the premise here, that bloating the DOM model and so taking up more memory/etc. is a worthwhile... [16:06:13] (03CR) 10Jforrester: [C: 04-1] MediaWiki Theme: Add radio buttons (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/176398 (owner: 10Prtksxna) [16:18:09] (03PS1) 10Esanders: Fix typo in comment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/176469 [17:13:21] 3MediaWiki-extensions-WikiEditor: Unable to remove individual booklet-pages from loading to the toolbar - https://phabricator.wikimedia.org/T70791#794346 (10happy5214) [17:19:09] (03PS2) 10Jforrester: ve.dm.Node: Fix typo in comment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/176469 (owner: 10Esanders) [17:19:18] (03CR) 10Jforrester: [C: 032] ve.dm.Node: Fix typo in comment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/176469 (owner: 10Esanders) [17:23:34] (03Merged) 10jenkins-bot: ve.dm.Node: Fix typo in comment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/176469 (owner: 10Esanders) [17:26:43] (03PS1) 10Prtksxna: TextInputWidget: Use .css( propertyName, value ) instead of .css( properties) for single property [oojs/ui] - 10https://gerrit.wikimedia.org/r/176474 [17:26:45] (03PS1) 10Prtksxna: TextInputWidget: Stop adjustSize if the value of the textarea is the same [oojs/ui] - 10https://gerrit.wikimedia.org/r/176475 [17:26:47] (03PS1) 10Prtksxna: TextInputWidget: Reuse a single clone instead of appending and removing new ones [oojs/ui] - 10https://gerrit.wikimedia.org/r/176476 [17:30:36] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=109527304 [17:30:36] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=109529022 [17:30:36] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=33456822 [17:30:36] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=33457314 [17:30:36] Corruption alert: visualeditor-needcheck on ptwiki: https://pt.wikipedia.org/?diff=40728040 [17:30:37] Corruption alert: visualeditor-needcheck on ptwiki: https://pt.wikipedia.org/?diff=40728531 [17:30:37] Corruption alert: visualeditor-needcheck on ptwiki: https://pt.wikipedia.org/?diff=40730611 [17:30:38] Corruption alert: visualeditor-needcheck on ptwiki: https://pt.wikipedia.org/?diff=40730860 [17:30:38] Corruption alert: visualeditor-needcheck on itwiki: https://it.wikipedia.org/?diff=69383193 [17:30:39] Corruption alert: visualeditor-needcheck on itwiki: https://it.wikipedia.org/?diff=69391072 [17:35:05] 3VisualEditor, OOjs-UI: Tools in the toolbar do not have unique attributes - https://phabricator.wikimedia.org/T76143#794364 (10Jdforrester-WMF) >>! In T76143#794185, @zeljkofilipin wrote: >>>! In T76143#793969, @Jdforrester-WMF wrote: >> I'm not sure I agree with the premise here, that bloating the DOM model an... [17:45:29] 3OOjs-UI: MessageDialog do not re-fit actions on dialog resize - https://phabricator.wikimedia.org/T75783#794366 (10matmarex) [17:46:00] (03CR) 10Bartosz Dziewoński: [C: 032] TextInputWidget: Use .css( propertyName, value ) instead of .css( properties) for single property [oojs/ui] - 10https://gerrit.wikimedia.org/r/176474 (owner: 10Prtksxna) [17:48:11] (03Merged) 10jenkins-bot: TextInputWidget: Use .css( propertyName, value ) instead of .css( properties) for single property [oojs/ui] - 10https://gerrit.wikimedia.org/r/176474 (owner: 10Prtksxna) [17:54:06] (03CR) 10Bartosz Dziewoński: "This is sensible, but it feels like we really should have a way to do this more cleanly, as we already track the value (as this.value, imp" [oojs/ui] - 10https://gerrit.wikimedia.org/r/176475 (owner: 10Prtksxna) [17:55:52] (03PS2) 10Bartosz Dziewoński: TextInputWidget: Stop adjustSize if the value of the textarea is the same [oojs/ui] - 10https://gerrit.wikimedia.org/r/176475 (owner: 10Prtksxna) [17:56:02] (03CR) 10Bartosz Dziewoński: [C: 032] "I'll submit a patch for that; this is definitely an improvement and doing that would be somewhat unconventional (we pretty much don't do `" [oojs/ui] - 10https://gerrit.wikimedia.org/r/176475 (owner: 10Prtksxna) [17:56:38] (03PS2) 10Bartosz Dziewoński: TextInputWidget: Reuse a single clone instead of appending and removing new ones [oojs/ui] - 10https://gerrit.wikimedia.org/r/176476 (owner: 10Prtksxna) [18:00:04] (03Merged) 10jenkins-bot: TextInputWidget: Stop adjustSize if the value of the textarea is the same [oojs/ui] - 10https://gerrit.wikimedia.org/r/176475 (owner: 10Prtksxna) [18:18:07] (03CR) 10Bartosz Dziewoński: [C: 04-1] "This doesn't seem to work anymore. Probably we can't measure the stuff if the cloned element is hidden?" [oojs/ui] - 10https://gerrit.wikimedia.org/r/176476 (owner: 10Prtksxna) [18:33:50] (03PS3) 10Bartosz Dziewoński: TextInputWidget: Reuse a single clone instead of appending and removing new ones [oojs/ui] - 10https://gerrit.wikimedia.org/r/176476 (owner: 10Prtksxna) [18:35:47] (03CR) 10Bartosz Dziewoński: "Tweaked, works now. But I have some concerns." [oojs/ui] - 10https://gerrit.wikimedia.org/r/176476 (owner: 10Prtksxna) [18:58:26] (03CR) 10Bartosz Dziewoński: "Egh, I actually won't. I wrote it, but it causes the scrollbar to briefly flash on and off, because #setValue is called from within a setT" [oojs/ui] - 10https://gerrit.wikimedia.org/r/176475 (owner: 10Prtksxna) [18:59:54] (03PS1) 10Bartosz Dziewoński: InputWidget: Update DOM value before firing 'change' event [oojs/ui] - 10https://gerrit.wikimedia.org/r/176478 [19:13:54] (03PS58) 10Paladox: WikiEditor: Re add SVG [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151611 [19:15:29] (03CR) 10Paladox: "This re add svg images." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151611 (owner: 10Paladox) [19:32:40] (03CR) 10TheDJ: [C: 04-1] "one small ws problem, but other than that good to go." (031 comment) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/175698 (owner: 10Happy5214) [19:44:55] 3OOjs-UI: OOjs UI: TextInputWidget auto-resize method is a little inefficient - https://phabricator.wikimedia.org/T75328#794426 (10Jdforrester-WMF) 5Open>3Resolved a:3Prtksxna [19:45:03] 3OOjs-UI: TextInputWidget auto-resize method is a little inefficient - https://phabricator.wikimedia.org/T75328#794429 (10Jdforrester-WMF) [20:11:10] (03PS2) 10Happy5214: Add QUnit test for ext.wikiEditor.toolbar [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/175698 [20:14:17] (03PS3) 10Happy5214: Add QUnit test for ext.wikiEditor.toolbar [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/175698 [20:32:36] 3VisualEditor, OOjs-UI: Tools in the toolbar do not have unique attributes - https://phabricator.wikimedia.org/T76143#794435 (10zeljkofilipin) >>! In T76143#793969, @Jdforrester-WMF wrote: > Also, if this is a requirement, it should be made in OOUI which ships the toolbar code, not hacked in by one of its client... [20:38:40] 3VisualEditor, OOjs-UI: Tools in the toolbar do not have unique attributes - https://phabricator.wikimedia.org/T76143#794437 (10zeljkofilipin) >>! In T76143#794364, @Jdforrester-WMF wrote: > If you want robust tests, agree to my request to have the browser tests block merge. :-) Right now the tests are a basket... [21:10:58] (03PS3) 10Bartosz Dziewoński: MessageDialog: Fit actions again when the dialog is resized [oojs/ui] - 10https://gerrit.wikimedia.org/r/175543 [21:11:00] (03PS1) 10Bartosz Dziewoński: Window: Avoid height flickering when resizing dialogs [oojs/ui] - 10https://gerrit.wikimedia.org/r/176484 [21:12:56] (03CR) 10jenkins-bot: [V: 04-1] MessageDialog: Fit actions again when the dialog is resized [oojs/ui] - 10https://gerrit.wikimedia.org/r/175543 (owner: 10Bartosz Dziewoński) [21:15:15] (03CR) 10jenkins-bot: [V: 04-1] Window: Avoid height flickering when resizing dialogs [oojs/ui] - 10https://gerrit.wikimedia.org/r/176484 (owner: 10Bartosz Dziewoński) [21:23:59] (03PS2) 10Bartosz Dziewoński: Window: Avoid height flickering when resizing dialogs [oojs/ui] - 10https://gerrit.wikimedia.org/r/176484 [21:24:00] (03PS4) 10Bartosz Dziewoński: MessageDialog: Fit actions again when the dialog is resized [oojs/ui] - 10https://gerrit.wikimedia.org/r/175543 [21:29:39] 3OOjs-UI: OOjs UI: OO.ui.ButtonWidget default target should not be "_blank" - https://phabricator.wikimedia.org/T75452#794483 (10matmarex) [21:36:18] (03PS1) 10Bartosz Dziewoński: [BREAKING CHANGE] ButtonWidget: Don't default 'target' to '_blank' [oojs/ui] - 10https://gerrit.wikimedia.org/r/176488 [21:42:41] 3OOjs-UI: OOjs UI: OO.ui.ButtonWidget default target should not be "_blank" - https://phabricator.wikimedia.org/T75452#794490 (10matmarex) [21:43:15] 3OOjs-UI: MessageDialog does not re-fit actions on dialog resize - https://phabricator.wikimedia.org/T75783#794491 (10matmarex) [21:49:40] 3OOjs-UI: Scrolling elements into view does not work in most cases - https://phabricator.wikimedia.org/T73609#794498 (10matmarex) [22:28:43] 3MediaWiki-extensions-WikiEditor: Unable to remove individual booklet-pages from loading to the toolbar - https://phabricator.wikimedia.org/T70791#794534 (10GOIII) [22:38:59] (03CR) 10GOIII: [C: 031] Add QUnit test for ext.wikiEditor.toolbar [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/175698 (owner: 10Happy5214) [23:13:59] 3MediaWiki-extensions-WikiEditor: [Regression] WikiEditor 'removeFromToolbar' API is broken - https://phabricator.wikimedia.org/T39484#794547 (10GOIII) [23:48:48] hi [23:49:04] I cannot remove : from the link. is that known? [23:50:17] looks fine now [23:52:01] I am very happy that you deployed VE into vw [23:53:30] omg! we moved to phabricator [23:53:34] how it works? [23:53:46] hopefully the change for the next ten years guys