[00:06:19] (03PS2) 10Prtksxna: MediaWiki Theme: Add radio buttons [oojs/ui] - 10https://gerrit.wikimedia.org/r/176398 [00:06:21] (03PS2) 10Prtksxna: MediaWiki Theme: checkbox: Fix states according to spec [oojs/ui] - 10https://gerrit.wikimedia.org/r/176397 [00:06:23] (03PS2) 10Prtksxna: MediaWiki Theme: Reduce indentation in theme-oo-ui-checkboxInputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/176396 [00:12:18] (03PS3) 10Prtksxna: MediaWiki Theme: Add radio buttons [oojs/ui] - 10https://gerrit.wikimedia.org/r/176398 [00:13:55] (03CR) 10Prtksxna: MediaWiki Theme: Add radio buttons (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/176398 (owner: 10Prtksxna) [01:00:00] (03CR) 10Prtksxna: "http://jsperf.com/show-hide-vs-insertafter-remove" [oojs/ui] - 10https://gerrit.wikimedia.org/r/176476 (owner: 10Prtksxna) [03:36:32] 3MediaWiki-extensions-Cite: Render references list in multiple columns based on the number of items - https://phabricator.wikimedia.org/T33597#795805 (10Krinkle) p:5Normal>3High [03:39:45] 3MediaWiki-extensions-Cite: Render references list in multiple columns based on the number of items - https://phabricator.wikimedia.org/T33597#795809 (10Krinkle) [03:56:44] 3MediaWiki-extensions-Cite: Render references list in multiple columns based on the number of items - https://phabricator.wikimedia.org/T33597#795815 (10Krinkle) [04:02:34] (03CR) 10Prtksxna: "http://jsperf.com/adjustsize" [oojs/ui] - 10https://gerrit.wikimedia.org/r/176476 (owner: 10Prtksxna) [05:49:11] 3MediaWiki-ResourceLoader: mw.loader.store should not occupy all of localStorage - https://phabricator.wikimedia.org/T66721#795821 (10tstarling) This is the first thing I saw on opening my web console on Wikipedia today -- localStorage exceptions from VisualEditor due to quota exhaustion, apparently due to modul... [05:53:18] 3MediaWiki-ResourceLoader: mw.loader.store should not occupy all of localStorage - https://phabricator.wikimedia.org/T66721#795823 (10tstarling) Actually, disabling the code is not enough -- localStorage has no expiry, so everyone's browser will stay broken until we explicitly clean up these old entries. [06:32:03] 3VisualEditor-ContentEditable, VisualEditor: VisualEditor: Focus highlights for elements using CSS column-count are too tall in Chrome - https://phabricator.wikimedia.org/T52036#795826 (10Tbayer) [06:54:26] 3MediaWiki-ResourceLoader: mw.loader.store should not occupy all of localStorage - https://phabricator.wikimedia.org/T66721#795843 (10tstarling) [07:49:55] (03PS1) 10Prtksxna: Add SVG compression grunt task using 'svgmin' [oojs/ui] - 10https://gerrit.wikimedia.org/r/176634 [08:28:07] (03PS1) 10Prtksxna: Add PNG compression grunt task using 'pngmin' [oojs/ui] - 10https://gerrit.wikimedia.org/r/176637 [08:28:54] 3OOjs-UI: Compress OOjs PNGs with pngcrush -brute -reduce - https://phabricator.wikimedia.org/T76148#795922 (10Prtksxna) [08:30:10] (03CR) 10jenkins-bot: [V: 04-1] Add PNG compression grunt task using 'pngmin' [oojs/ui] - 10https://gerrit.wikimedia.org/r/176637 (owner: 10Prtksxna) [09:04:49] 3MediaWiki-extensions-WikiEditor: WikiEditor: Dialogs for inserting links get a few pixel wider every time called - https://phabricator.wikimedia.org/T29603#795959 (10happy5214) [12:32:23] 3VisualEditor-ContentEditable, VisualEditor: [Regression wmf10] cannot open Formula inspector - https://phabricator.wikimedia.org/T76087#796208 (10Swainr) Same behavior with link inspectors, for external links only. 1> insert an external link, say-//cnn.com 2> click on the context menu to open the edit dialog. T... [12:40:34] 3MediaWiki-extensions-WikiEditor: WikiEditor: ext.wikiEditor.toolbar.hideSig.js is loaded even when the enhanced editing toolbar is disabled - https://phabricator.wikimedia.org/T35923#796222 (10hashar) [13:17:57] (03PS1) 10Esanders: Restore papaparse [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/176654 [13:19:35] (03CR) 10jenkins-bot: [V: 04-1] Restore papaparse [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/176654 (owner: 10Esanders) [13:59:37] 3VisualEditor-MediaWiki, VisualEditor: VisualEditor: Page save time at 75th percentile up 70% from February - https://phabricator.wikimedia.org/T66171#796261 (10Esanders) Upload compression was added in T68914. Roan and I have discussed re-introducing change markers and only sending content which has changed.... [14:00:14] 3VisualEditor, VisualEditor-EditingTools: [Regression wmf10]: Changing a list item to blockquote , looses the list style( only visually) - https://phabricator.wikimedia.org/T76337#796266 (10Swainr) [14:02:09] g [14:03:31] 3VisualEditor, VisualEditor-EditingTools: [Regression wmf10]: Changing a list item to blockquote , looses the list style( only visually) - https://phabricator.wikimedia.org/T76337#796278 (10Swainr) {F17750} {F17752} [14:16:59] (03PS1) 10Esanders: Fix window manager logic [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/176663 [14:50:47] (03PS1) 10Prtksxna: Element.getClosestScrollableContainer: Use 'body' or 'documentElement' based on browser [oojs/ui] - 10https://gerrit.wikimedia.org/r/176666 [14:51:36] 3OOjs-UI: Scrolling elements into view does not work in most cases - https://phabricator.wikimedia.org/T73609#797827 (10Prtksxna) [14:52:33] (03CR) 10jenkins-bot: [V: 04-1] Element.getClosestScrollableContainer: Use 'body' or 'documentElement' based on browser [oojs/ui] - 10https://gerrit.wikimedia.org/r/176666 (owner: 10Prtksxna) [15:34:16] (03PS2) 10Prtksxna: Element.getClosestScrollableContainer: Use 'body' or 'documentElement' based on browser [oojs/ui] - 10https://gerrit.wikimedia.org/r/176666 [16:46:47] 3OOjs-UI: OOjs UI: Use MutationObserver to detect when an OO.ui.Element is attached to a document - https://phabricator.wikimedia.org/T64174#798545 (10Prtksxna) [16:46:47] (03PS1) 10Prtksxna: [WIP] Use MutationObserver instead of DOMNodeInsertedIntoDocument [oojs/ui] - 10https://gerrit.wikimedia.org/r/176681 [16:48:01] (03CR) 10Prtksxna: [C: 04-2] "Not ready for review!" [oojs/ui] - 10https://gerrit.wikimedia.org/r/176681 (owner: 10Prtksxna) [16:48:06] Heya. [16:48:47] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Use MutationObserver instead of DOMNodeInsertedIntoDocument [oojs/ui] - 10https://gerrit.wikimedia.org/r/176681 (owner: 10Prtksxna) [16:49:21] 3VisualEditor, VisualEditor-ContentLanguage: Cursor not moving past "ग्र" and other multiple code-unit grapheme clusters on left arrow key press - https://phabricator.wikimedia.org/T53846#798549 (10Jdforrester-WMF) [16:49:42] 3VisualEditor: Multiple left arrow press required to navigate through characters in Malayalam - https://phabricator.wikimedia.org/T76282#798551 (10Jdforrester-WMF) [16:49:43] 3VisualEditor, VisualEditor-ContentLanguage: Cursor not moving past "ग्र" and other multiple code-unit grapheme clusters on left arrow key press - https://phabricator.wikimedia.org/T53846#570542 (10Jdforrester-WMF) [16:51:01] 3Wikidata, VisualEditor-TechnicalDebt, Project-Management, MobileFrontend-Hygiene: Create technical-debt project - https://phabricator.wikimedia.org/T75892#798554 (10JanZerebecki) [16:58:05] 3VisualEditor-EditingTools, VisualEditor-MediaWiki, VisualEditor: [Regression wmf10] Cannot open any inspectors, they just flicker and get closed - https://phabricator.wikimedia.org/T76076#798558 (10Jdforrester-WMF) [17:00:02] 3VisualEditor-EditingTools, VisualEditor-MediaWiki, VisualEditor: Changing a list item to blockquote format looses the visual list styling until save - https://phabricator.wikimedia.org/T76337#798561 (10Jdforrester-WMF) [17:00:06] 3VisualEditor-EditingTools, VisualEditor-MediaWiki, VisualEditor: Changing a list item to blockquote format looses the visual list styling until save - https://phabricator.wikimedia.org/T76337#796266 (10Jdforrester-WMF) [17:04:13] https://phabricator.wikimedia.org/T66721#795843 - what is Tim referring to? :/ [17:04:40] 3VisualEditor, Parsoid: Editing a specific article at pl.wp truncates category name - https://phabricator.wikimedia.org/T76353 (10Elitre) 3NEW p:3Triage [17:11:02] 3VisualEditor-ContentEditable, VisualEditor: [Regression wmf10] cannot open Formula inspector - https://phabricator.wikimedia.org/T76087#798594 (10Jdforrester-WMF) [17:11:05] 3VisualEditor-EditingTools, VisualEditor-MediaWiki, VisualEditor: [Regression wmf10] Cannot open any inspectors, they just flicker and get closed - https://phabricator.wikimedia.org/T76076#798595 (10Jdforrester-WMF) [17:12:03] 3VisualEditor, Parsoid: Editing a specific article at pl.wp truncates category name - https://phabricator.wikimedia.org/T76353#798597 (10ssastry) Looks like incorrect DSR value on some tag. To be investigated. [17:26:58] Krenair: No idea? [17:29:24] divec|away: https://gerrit.wikimedia.org/r/#/c/176392/ [17:30:19] (03CR) 10Divec: [C: 032] Update VE core submodule to master (b5a0269) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/176392 (owner: 10Jforrester) [17:31:03] 3VisualEditor: [Regression pre-wmf10] VisualEditor does not load on beta labs - https://phabricator.wikimedia.org/T75896#798617 (10Jdforrester-WMF) [17:31:20] Corruption alert: visualeditor-needcheck on cswiki: https://cs.wikipedia.org/?diff=12042386 [17:31:20] Corruption alert: visualeditor-needcheck on cswiki: https://cs.wikipedia.org/?diff=12043066 [17:31:20] Corruption alert: visualeditor-needcheck on svwiki: https://sv.wikipedia.org/?diff=28977345 [17:31:20] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=33479416 [17:31:20] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=33479478 [17:31:21] Corruption alert: visualeditor-needcheck on cawiki: https://ca.wikipedia.org/?diff=14380805 [17:31:21] Corruption alert: visualeditor-needcheck on ptwiki: https://pt.wikipedia.org/?diff=40745005 [17:31:22] Corruption alert: visualeditor-needcheck on itwiki: https://it.wikipedia.org/?diff=69423531 [17:31:22] Corruption alert: visualeditor-needcheck on enwiki: https://en.wikipedia.org/?diff=636121074 [17:31:23] Corruption alert: visualeditor-needcheck on bgwiki: https://bg.wikipedia.org/?diff=6356398 [17:31:59] 3VisualEditor-EditingTools, VisualEditor: [Regression pre-wmf10] Cannot open any Citation dialog, TypeError: this.bookletLayout.focus is not a function appears in the console - https://phabricator.wikimedia.org/T75779#798622 (10Jdforrester-WMF) [17:32:22] 3VisualEditor-MediaWiki, VisualEditor: [Regression wmf10] Switch to source edit option is disabled - https://phabricator.wikimedia.org/T75965#798623 (10Jdforrester-WMF) [17:32:33] (03Merged) 10jenkins-bot: Update VE core submodule to master (b5a0269) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/176392 (owner: 10Jforrester) [17:32:39] Whee. [17:33:00] 3VisualEditor: [Regression wmf10] Basic reference that has Citation inside tries to render it as Basic Reference ({{Cite web }})and thus fails - https://phabricator.wikimedia.org/T76082#798624 (10Jdforrester-WMF) [17:35:12] hi. [17:36:24] hi [17:37:43] Hey. [17:39:06] good morning! hope you had a nice holiday. [17:43:43] 3VisualEditor-MediaWiki, VisualEditor, Parsoid: Editing a specific article at pl.wp truncates category name - https://phabricator.wikimedia.org/T76353#798647 (10Jdforrester-WMF) [17:43:46] 3VisualEditor-MediaWiki, VisualEditor, Parsoid: Editing a specific article at pl.wp truncates category name - https://phabricator.wikimedia.org/T76353#798571 (10Jdforrester-WMF) [17:48:27] 3VisualEditor-EditingTools, VisualEditor-MediaWiki, VisualEditor: [Regression wmf9] Opening page settings dialog when cursor is in a block slug (between two references lists) throws "Uncaught TypeError: Cannot read property 'previousSibling' of undefined" - https://phabricator.wikimedia.org/T75620#798663 (10Jdfor... [17:48:42] 3VisualEditor-EditingTools, VisualEditor-MediaWiki, VisualEditor: [Regression wmf9] Opening page settings dialog when cursor is in a block slug (between two references lists) throws "Uncaught TypeError: Cannot read property 'previousSibling' of undefined" - https://phabricator.wikimedia.org/T75620#766041 (10Jdfor... [17:50:38] 3OOjs-UI: Scrolling elements into view does not work in most cases - https://phabricator.wikimedia.org/T73609#798671 (10Jdforrester-WMF) [17:50:51] 3OOjs-UI: Scrolling elements into view does not work in most cases - https://phabricator.wikimedia.org/T73609#798672 (10Jdforrester-WMF) a:3Prtksxna [17:53:59] 3OOjs-UI: OOjs UI: Use MutationObserver to detect when an OO.ui.Element is attached to a document - https://phabricator.wikimedia.org/T64174#798674 (10Jdforrester-WMF) a:3Prtksxna [17:56:14] (03CR) 10Jforrester: [C: 031] "Anything left to do here?" [services/citoid/deploy] - 10https://gerrit.wikimedia.org/r/176619 (owner: 10Mvolz) [17:57:26] 3OOjs-UI: Compress OOjs UI PNGs with pngcrush -brute -reduce - https://phabricator.wikimedia.org/T76148#798679 (10Jdforrester-WMF) p:5Triage>3Low a:3Prtksxna [17:58:49] (03CR) 10Jforrester: [C: 04-1] "I think it would make sense for this task to happen immediately after the SVG files are copied, rather than after the PNGs are created fro" [oojs/ui] - 10https://gerrit.wikimedia.org/r/176634 (owner: 10Prtksxna) [18:06:16] (03CR) 10Esanders: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/176654 (owner: 10Esanders) [18:06:39] 3MediaWiki-extensions-Cite: Render references list in multiple columns based on the number of items - https://phabricator.wikimedia.org/T33597#798688 (10Krinkle) a:3Krinkle I've been eyeballing this for over a year now and think I've got a good idea of how to implement it. I'll give it a shot. [18:16:05] Krenair: ping [18:16:16] hi [18:18:14] 3MediaWiki-extensions-Cite: Allow HTML attributes for tags - https://phabricator.wikimedia.org/T8019#798709 (10Krinkle) [18:20:44] 3MediaWiki-extensions-Cite: Allow HTML attributes for tags - https://phabricator.wikimedia.org/T8019#798718 (10Krinkle) 5Open>3declined a:3Krinkle Fulfilling requests for specific implementations is tricky as there's no obvious use cases. There are obviously relevant use cases related to thi... [18:20:59] Krenair: So which task are you working on? Cite feature or VE bug? [18:21:15] (03CR) 10Bartosz Dziewoński: "We optimize (and sometimes hand-optimize) the SVG files in the repo, so I don't think this will help much. Also, my experience with SVG op" [oojs/ui] - 10https://gerrit.wikimedia.org/r/176634 (owner: 10Prtksxna) [18:22:33] Krinkle: https://phabricator.wikimedia.org/T53260 [18:23:24] Krinkle: Though T33597 is attractive, too. [18:23:44] Krinkle, what was the context again? [18:24:03] Krinkle: It doesn't do "list-style" stuff, though, which people will grumble about. [18:25:20] James_F: yeah, but that's got nothing to do with all this. A separate feature. The only have in common that they'll affect the html output and may possibly be implemented as an attribute. Not doing it in the same patch is a good thing. They really really have got nothing to do with one another. [18:25:57] why is this failing? https://integration.wikimedia.org/ci/job/mwext-VisualEditor-qunit/12740/consoleFull [18:25:58] That should be done per-wiki, not per . [18:26:01] it works locally... [18:26:07] Krinkle: Sure, but I would probably have WONTFIXed that patch. [18:26:08] And if the use case is multilingual wikis, we should use page content language. [18:26:11] Krinkle: What? [18:26:19] James_F: which patch? [18:26:24] What are we talking about [18:26:30] Krinkle: T33597. [18:26:50] Krinkle: You should generally consider un-blessed tasks as risky things to spend time on. :-) [18:27:10] James_F: Alex was assigned in early October. [18:27:57] Krinkle: March. [18:28:10] Last time. [18:28:11] (03CR) 10Catrope: [C: 032] Fix window manager logic [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/176663 (owner: 10Esanders) [18:28:12] Anyway [18:28:25] (03PS1) 10Jforrester: Fix window manager logic [VisualEditor/VisualEditor] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/176698 [18:28:31] James_F: So you agree or disagree that list-style and column count should be in the same bug/commit? [18:28:51] Krinkle: I agree they should not be the same commit. I disagree that we should definitely do both. [18:28:56] James_F: And what about implementation-wise, do you feel like it should be done per-references? Or worth trying per-wiki / software related. [18:29:04] James_F: Great, me too. [18:29:24] Krinkle: I'm not convinced we should do T33597 instead of T53260. [18:29:54] Krinkle: I'm not convinced that doing both T53260 and T33597 would be anything other than very confusing for users. [18:30:00] Basicially the patch I'm half-way writing as: count columns, if more then X add a class. That class is css-driven (ext.cite.css) and does column-width based on media-queries like you'd expect. [18:30:31] Krinkle: I'm not convinced that T33597 is yet in a good enough state product-wise to be acted upon. [18:30:39] (03CR) 10Catrope: [C: 04-1] "Well, that would be because I forgot to change ve.init.mw.trackSubscriber.js :(" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175795 (owner: 10Catrope) [18:30:52] James_F: T53260 is becoming an omni bug. I'd say ditch it. In favour of two bugs tracking the actual use cases, which is T33597 and then a maybe-wontfifx bug for making list-style configurable in some fashion. [18:31:12] (03Merged) 10jenkins-bot: Fix window manager logic [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/176663 (owner: 10Esanders) [18:31:14] Krinkle: I can tell that you're in favour of the task you wrote. [18:31:21] Krinkle: That doesn't mean I'm agreeing. [18:31:32] Krinkle: This is not the way to make major product changes. [18:33:54] James_F: It's not a major product change. It's a simple change that the community has been doing themselves for years. It's gonna happen. It already happened. I can't stand any longer this super trivial thing being so overly blown out of proportion. Any modern developer and designer who'd be tasked with a list in a fluid design like this would do the same thing. It's obvious. [18:36:10] I appreciate the product side but tell me why I (or Alex) wouldn't just do this in an hour. It is about planning (we'll need a migration path, due to the template hacks wrapping outside list we need to work with com to remove those as else you'll have e.g. 3 columns split in 6 columns due to the outer
case I'm happy to wait. [18:36:39] (03CR) 10Catrope: "Ping?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175208 (owner: 10Esanders) [18:37:56] it would simplify quite a few things for VE as well when {{references}} and the like become an edge case we no longer need to be concerned about. And for Parsoid, they can ditch that whole hackery in favour of just loading the Cite stylesheet (which theyre already doing) and matching the simple logic we'd put in Cite PHP. [18:39:02] I just want clarity :) [18:40:26] RoanKattouw, remember the bug we discussed with the caption surface not triggering the update event properly? I think I figured it out. I've called the 'focus' before calling the surface initialize. :\ hah. Fix is here: https://gerrit.wikimedia.org/r/#/c/176197/ [18:44:04] (03CR) 10Catrope: [C: 032] Set panels after everything is initialized in media dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/176197 (owner: 10Mooeypoo) [18:48:26] (03Merged) 10jenkins-bot: Set panels after everything is initialized in media dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/176197 (owner: 10Mooeypoo) [18:49:19] Krinkle: It's a pretty major product change. You're changing the styling of content (which is always an extremely rough roll-out). [18:49:34] Krinkle: I also don't remotely have the time for this right now. :-) [18:50:10] (03PS1) 10Jforrester: Set panels after everything is initialized in media dialog [extensions/VisualEditor] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/176704 [18:50:23] (03CR) 10Catrope: [C: 032] Fix window manager logic [VisualEditor/VisualEditor] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/176698 (owner: 10Jforrester) [18:50:42] (03CR) 10Catrope: [C: 032] Set panels after everything is initialized in media dialog [extensions/VisualEditor] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/176704 (owner: 10Jforrester) [18:53:42] (03Merged) 10jenkins-bot: Fix window manager logic [VisualEditor/VisualEditor] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/176698 (owner: 10Jforrester) [18:58:22] (03Merged) 10jenkins-bot: Set panels after everything is initialized in media dialog [extensions/VisualEditor] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/176704 (owner: 10Jforrester) [19:00:24] (03PS1) 10Catrope: Update VE core for cherry-picks [extensions/VisualEditor] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/176711 [19:00:44] (03CR) 10Catrope: [C: 032] Update VE core for cherry-picks [extensions/VisualEditor] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/176711 (owner: 10Catrope) [19:03:17] (03Merged) 10jenkins-bot: Update VE core for cherry-picks [extensions/VisualEditor] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/176711 (owner: 10Catrope) [19:03:19] (03CR) 10Catrope: [C: 032] Change event listener for caption surface in media dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/176028 (owner: 10Mooeypoo) [19:05:12] (03Merged) 10jenkins-bot: Change event listener for caption surface in media dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/176028 (owner: 10Mooeypoo) [19:14:11] (03PS12) 10Esanders: Find and replace tool [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175306 [19:14:13] (03PS17) 10Esanders: Find and replace [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/174491 [19:14:15] (03PS3) 10Esanders: Go backwards through find and replace results on shift enter [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175883 [19:15:28] 3Wikimedia-Extension-setup, VisualEditor: VisualEditor has been disabled unexpectedly on fr.wiktionary - https://phabricator.wikimedia.org/T76099#798911 (10Etonkovidova) [19:19:08] (03CR) 10Catrope: [C: 04-1] "This also needs a code change to pass a value into $1" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/176071 (owner: 10Jforrester) [19:19:52] (03PS2) 10Catrope: Remove duplicate startSanityCheck from ViewPageTarget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/176301 (owner: 10Esanders) [19:20:57] (03CR) 10Catrope: [C: 032] Remove duplicate startSanityCheck from ViewPageTarget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/176301 (owner: 10Esanders) [19:21:55] (03PS2) 10Catrope: Restore papaparse [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/176654 (owner: 10Esanders) [19:22:48] (03PS2) 10Jforrester: i18n: Pass value to [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/176071 [19:23:00] (03Merged) 10jenkins-bot: Remove duplicate startSanityCheck from ViewPageTarget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/176301 (owner: 10Esanders) [19:23:07] (03CR) 10jenkins-bot: [V: 04-1] Restore papaparse [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/176654 (owner: 10Esanders) [19:24:04] (03CR) 10Catrope: "Doesn't V-1 locally. This seems to be the culprit:" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/176654 (owner: 10Esanders) [19:24:14] (03CR) 10Bartosz Dziewoński: "(If you're into mobile, T69340 might interest you.)" [oojs/ui] - 10https://gerrit.wikimedia.org/r/176666 (owner: 10Prtksxna) [19:24:41] (03CR) 10jenkins-bot: [V: 04-1] i18n: Pass value to [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/176071 (owner: 10Jforrester) [19:24:55] Krinkle: WTF PhantomJS? https://gerrit.wikimedia.org/r/#/c/176654/ seems to indicate document.body is null? [19:25:37] (03CR) 10Catrope: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/176071 (owner: 10Jforrester) [19:29:50] RoanKattouw: I'm gonna have to stop IRC while tethering. Ping me on hangouts :-/ [19:29:57] (03CR) 10Catrope: [C: 032] i18n: Pass value to [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/176071 (owner: 10Jforrester) [19:29:57] Krinkle: :-( [19:30:56] RoanKattouw, I found that when I browse to /w/index.php?title=SomePage&veaction=edit and try to add transclusions with links inside them (e.g. to TargetPage), they point to /w/TargetPage, which is invalid [19:31:18] Krenair: Urgh [19:31:45] I think I know how to dig us out of that hole [19:31:48] Could you file a bug? [19:31:48] it all happens inside the $.parseHTML call in MWTransclusionNode#onParseSuccess though [19:32:07] 3VisualEditor: [Regression pre wmf11]While switching from Save Page Dialog to Review Changes Dialog the window opens with an animation from bottom - https://phabricator.wikimedia.org/T76371 (10Ryasmeen) 3NEW p:3Triage a:3matmarex [19:32:08] I was wondering if this was already filed as a bug [19:32:40] 3VisualEditor: [Regression pre-wmf11] While switching from Save Page Dialog to Review Changes Dialog the window opens with an animation from bottom - https://phabricator.wikimedia.org/T76371#798945 (10Catrope) [19:32:50] (03PS3) 10Catrope: Window: Avoid height flickering when resizing dialogs [oojs/ui] - 10https://gerrit.wikimedia.org/r/176484 (owner: 10Bartosz Dziewoński) [19:32:56] Krenair: maybe? I don't know [19:33:06] I saw parseHTML takes a context argument which is a document. I don't think I can just $.extend document with a new base URI though [19:33:07] I guess it might be but I'm leaning towards "probably not" [19:33:33] Oh, it does? [19:34:26] yeah... [19:34:35] Krenair: Could you file a tech debt bug about how we should use the context argument to $.parseHtml() rather than manually transplanting stuff with ve.copyDomElements() ? [19:34:42] 3VisualEditor: [Regression pre-wmf11] While switching from Save Page Dialog to Review Changes Dialog the window opens with an animation from bottom - https://phabricator.wikimedia.org/T76371#798948 (10Ryasmeen) [19:34:44] We must have a way to deal with this already... [19:34:47] a separate bug for that? [19:34:48] 3VisualEditor: [Regression pre-wmf11] While switching from Save Page Dialog to Review Changes Dialog the window opens with an animation from bottom - https://phabricator.wikimedia.org/T76371#798936 (10Ryasmeen) [19:34:52] Yeah [19:35:03] Yeah there is something somewhere to do href remapping [19:35:18] Waait [19:35:27] GeneratedContentNode already does href computation [19:35:27] ? [19:35:34] This should be *working* [19:35:37] (03Merged) 10jenkins-bot: i18n: Pass value to [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/176071 (owner: 10Jforrester) [19:35:42] href remapping? isn't that in GeneratedCo-- okay. I'll shut up now. [19:35:46] See ve.ce.GeneratedContentNode.prototype.getRenderedDomElements and the stuff about computed attributes [19:36:08] Which... oooh but they're not in the right document at that time, I guess? [19:36:13] I remember seeing it when I looked at the image links [19:36:55] I haven't checked what parsoid's links look like for subpages, but I imagine they might fall into a similar issue? [19:37:15] I first thought that we should be computing attributes after cloning into the right document, but that's wrong, because that's cloning into the view document [19:37:25] We need to resolve with respect to the model document [19:38:49] I also tried updating my laptop's copy of parsoid to a modern version and [19:39:02] well it just refused to finish parsing anything [19:39:29] Re subpages, that used to be worse until recently when they standardized their base hrefs [19:46:12] 3VisualEditor-TechnicalDebt: Use $.parseHTML's context argument rather than manually transplanting stuff with ve.copyDomElements - https://phabricator.wikimedia.org/T76374 (10Krenair) 3NEW p:3Triage [19:46:57] 3VisualEditor: [Regression pre-wmf10] oo-ui-icon-help is missing - https://phabricator.wikimedia.org/T75946#798996 (10Etonkovidova) Verified in betalabs. Re-checked Help button in test2/production. [19:47:52] TIL you can have a local variable called window [19:48:27] >>> function f() { var window = { hello: 'world' }; return window.hello; } f(); [19:48:29] RoanKattouw: (string) 'world' [19:50:30] (03CR) 10Catrope: [C: 04-1] Window: Avoid height flickering when resizing dialogs (032 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/176484 (owner: 10Bartosz Dziewoński) [19:50:37] (03PS5) 10Catrope: MessageDialog: Fit actions again when the dialog is resized [oojs/ui] - 10https://gerrit.wikimedia.org/r/175543 (owner: 10Bartosz Dziewoński) [19:50:40] RoanKattouw, assigned to you? [19:50:49] or just cc? [19:50:52] Just CC [19:51:57] RoanKattouw: it indeed bothers me slightly that we called OOUI windows "windows" [19:52:18] Yeah I've never liked that name very much [19:52:22] Especially for non-modal ones [19:52:57] RoanKattouw: what do you want me to call that variable? window_? [19:53:16] "that"? "self"? Krinkl.e would scowl at this [19:53:17] Ahm... [19:53:23] Yeah good question [19:53:26] What should it be [19:53:47] 3VisualEditor-ContentEditable: Links in transclusion nodes can point to /w/PageName if browsing from /w/index.php?veaction=edit - https://phabricator.wikimedia.org/T76379#799035 (10Krenair) [19:54:05] i guess we can always go with "element" [19:54:23] but that's almost like calling it "item" or "data" [19:54:43] oh, there's a few `var win` in that file. problem solved! [19:55:36] (03PS4) 10Bartosz Dziewoński: Window: Avoid height flickering when resizing dialogs [oojs/ui] - 10https://gerrit.wikimedia.org/r/176484 [19:55:53] 3VisualEditor-MediaWiki, VisualEditor: LinkCache sends API requests for URL-encoded page names, gets "invalid" responses back when descending into template contents - https://phabricator.wikimedia.org/T75823#799046 (10Krenair) [20:00:20] (03PS1) 10Bartosz Dziewoński: ViewPageTarget.init: Correct docs: ve.libs.mw → mw.libs.ve [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/176729 [20:02:04] hmm [20:02:11] seems that plugins added with mw.libs.ve.addPlugin() are never called :( [20:06:58] MatmaRex: Whoops. [20:07:04] MatmaRex: That seems sub-optimal. [20:07:16] (or at least, mine isn't. https://meta.wikimedia.org/wiki/User:Matma_Rex/visualeditor-signature.js) [20:10:17] (hmm. or maybe i'm just stupid) [20:10:39] 3OOjs-UI: MessageDialog doesn't fit actions correctly - https://phabricator.wikimedia.org/T75376#799070 (10Etonkovidova) [20:22:40] 3VisualEditor, VisualEditor-EditingTools: In RTL (hewiki and arwiki) wikis, can't remove categories - https://phabricator.wikimedia.org/T53490#799078 (10Kipod) [20:24:01] (i was just stupid, nevermind me.) [20:25:12] (03PS6) 10Bartosz Dziewoński: MessageDialog: Fit actions again when the dialog is resized [oojs/ui] - 10https://gerrit.wikimedia.org/r/175543 [20:27:35] (03CR) 10jenkins-bot: [V: 04-1] MessageDialog: Fit actions again when the dialog is resized [oojs/ui] - 10https://gerrit.wikimedia.org/r/175543 (owner: 10Bartosz Dziewoński) [20:30:46] eh ooui's theming is so confusing [20:38:27] :( [20:38:31] mooeypoo: Lies! ;-) [20:38:50] I'm trying to figure out how to set up the draggableElement/draggableGroupElement as themable [20:39:03] no lies, the theming *is* stupid. [20:39:04] considering that I *have* to use base style rules [20:39:28] mooeypoo: i believe it should "just work". [20:40:10] what exactly are you trying to make it do? [20:40:31] in LESS, if I have oo-ui-draggableElement { ... } then having &-dragging inside the parenths is the same as writing out a rule for oo-ui-draggableElement-dragging {} right? [20:41:34] mooeypoo: there's a difference between CSS classes and mixins [20:42:07] mooeypoo: let's look at OptionWidget as an example [20:42:16] (and the apex theme) [20:42:32] the theme defines a mixin called ".theme-oo-ui-optionWidget" in widgets.less [20:42:39] * mooeypoo nods [20:42:44] I did that to the draggable stuff [20:42:49] this doesn't generate any css by itself; but the mixin is called in OptionWidget.less [20:42:57] * mooeypoo nods [20:42:59] mixins are basically macros [20:43:03] this allows users to override it [20:43:03] right? [20:43:16] so it allows the template to override whatever base we had. [20:43:18] yes, each theme can define different contents for this mixn [20:43:20] yes [20:43:26] * mooeypoo nods [20:43:37] but I have *base* stuff that must be used between all templates. [20:43:38] you only have mixins for "toplevel", for the various Elements [20:43:50] So if I look at OptionWidget.less I can see it defines those [20:44:04] and then calls the .theme-oo-ui-optionWidget(); at the end [20:44:43] so I need to do that in draggableElement. look here: https://gerrit.wikimedia.org/r/#/c/172325/14/src/styles/elements/DraggableElement.less [20:45:21] The first rule for oo-ui-draggableElement-dragging I can do as &-dragging { .. } inside the main mixin [20:45:27] but the second rule I'm confused about [20:45:40] how do I get this in: .oo-ui-draggableGroupElement-horizontal .oo-ui-draggableElement.oo-ui-optionWidget { [20:46:06] perhaps that should be in DraggableGroupElement.less, if there is such a file? that should make it more natural [20:46:10] or, you could do: [20:46:21] .oo-ui-draggableGroupElement-horizontal &.oo-ui-optionWidget { … } [20:46:26] you can put the '&' anywhere [20:46:46] (not that this is usually a good idea, if you want soebody else than you to understand the code later) [20:47:02] MatmaRex, no, it's the element's [20:47:07] hmmm [20:47:32] Well, basically I want to say in context of the element "if we're in a horizontal group, style my horizontal" [20:47:42] I can do that to the element asking its parent, or to the parent styling it's child [20:47:56] it seemed more logical that the styling itself will be in the child css [20:48:52] hmm, i wanted to say that we usually do the latter (parent can override child's styles), but that seems to not always be the case [20:49:13] hmm [20:49:26] I'll leave it there and talk to Trevor about this when he gets back [20:49:28] looking at apex's widgets.less still, .theme-oo-ui-buttonSelectWidget does the latter, .theme-oo-ui-optionWidget does the former, for example [20:49:32] 3VisualEditor, OOjs-UI: [Regression 0.2.3] While switching dialog sizes, the window opens with an animation from bottom - https://phabricator.wikimedia.org/T76371#799102 (10Jdforrester-WMF) p:5Triage>3High [20:49:40] That's also a bit of a hack anyways, so we'll have to see which we prefer [20:50:07] MatmaRex, yeah and in general we technically sholdn't need this at all, it's just a hack that we should at some point fix the cause of [20:50:31] Krenair: Argh. https://phabricator.wikimedia.org/T76379 [20:50:46] Krenair: Please always always always tag VE bugs with #VisualEditor or they'll never be seen. [20:51:23] 3VisualEditor-MediaWiki, VisualEditor: Links in transclusion nodes can point to /w/PageName if browsing from /w/index.php?veaction=edit - https://phabricator.wikimedia.org/T76379#799106 (10Jdforrester-WMF) [20:51:38] right, sorry [20:51:51] Krenair: No worries, I'm just worried we're missing tonnes of them. :-( [20:52:08] I don't often have to file bugs myself. And I'm not quite used to Phabricator yet [20:52:20] * James_F nods. [20:52:25] 3VisualEditor-TechnicalDebt, VisualEditor: Use $.parseHTML's context argument rather than manually transplanting stuff with ve.copyDomElements - https://phabricator.wikimedia.org/T76374#799114 (10Krenair) [20:53:10] Krenair: The snappily-named https://phabricator.wikimedia.org/maniphest/task/create/?projects=PHID-PROJ-dafezmpv6huxg3taml24 will always make the task in the right project. :-) [20:53:28] Well. Unless you delete the "VisualEditor" pre-filled project. [20:54:13] James_F, I stuck the one you mentioned in VE-CE because of it being GeneratedContentNode stuff [20:54:31] Krenair: GCN is DM stuff, though? [20:54:42] Krenair: I mean, it has effects in CE but most things in DM do… [20:54:46] * James_F shrugs. [20:55:19] ve.dm.GeneratedContentNode has umm... one function - storeGeneratedContents [20:55:28] 3VisualEditor-TechnicalDebt, VisualEditor: Use $.parseHTML's context argument rather than manually transplanting stuff with ve.copyDomElements - https://phabricator.wikimedia.org/T76374#799147 (10Jdforrester-WMF) p:5Triage>3Normal [20:55:30] other than constructor [20:55:38] 3VisualEditor-TechnicalDebt, VisualEditor: Use $.parseHTML's context argument rather than manually transplanting stuff with ve.copyDomElements - https://phabricator.wikimedia.org/T76374#798980 (10Jdforrester-WMF) [20:55:45] And all its inherited methods and stuff. [20:55:51] We're dealing with ve.ce.GeneratedContentNode [20:55:52] Static controls are powerful. :-) [20:56:01] No, we're dealing with Parsoid's tag. [20:56:09] Which is absolutely and completely VE-MW land. [20:56:52] Well, I wasn't so sure when I read Roan's notes on IRC [20:56:54] It's /probably/ a new bug from the recent addition of a tag by Parsoid which we swore we were ready for. :-) [20:56:56] * James_F nods. [20:57:13] Parsoid's or MW's or whatever. Either way, base resolution is our problem. :-) [20:58:19] 3VisualEditor-MediaWiki, VisualEditor: [Regression?] Links in transclusion nodes can point to /w/PageName if browsing from /w/index.php?veaction=edit - https://phabricator.wikimedia.org/T76379#799156 (10Jdforrester-WMF) [20:58:47] 3VisualEditor-TechnicalDebt, VisualEditor: MWPopupTool is not a subclass of ve.ui.Tool - https://phabricator.wikimedia.org/T75948#799159 (10Jdforrester-WMF) p:5Triage>3Low [20:58:53] 3VisualEditor-TechnicalDebt, VisualEditor: MWPopupTool is not a subclass of ve.ui.Tool - https://phabricator.wikimedia.org/T75948#786781 (10Jdforrester-WMF) [21:00:54] 3VisualEditor, OOjs-UI: [Regression 0.2.3] While switching dialog sizes, the window opens with an animation from bottom - https://phabricator.wikimedia.org/T76371#799167 (10Jdforrester-WMF) [21:01:08] 3VisualEditor-MediaWiki, VisualEditor: Entering ";" does not trip the wikitext warning that it won't work - https://phabricator.wikimedia.org/T71689#799168 (10Etonkovidova) [21:01:14] 3VisualEditor-MediaWiki, VisualEditor: Entering ";" does not trip the wikitext warning that it won't work - https://phabricator.wikimedia.org/T71689#738941 (10Etonkovidova) Verified in beta and test2 - a semi-colon will trigger a wikitext warning; a colon(:) - indicates a
text. [21:07:34] (03PS15) 10Mooeypoo: Adding DraggableGroupElement and DraggableElement mixins [oojs/ui] - 10https://gerrit.wikimedia.org/r/172325 [21:07:38] (03CR) 10jenkins-bot: [V: 04-1] Adding DraggableGroupElement and DraggableElement mixins [oojs/ui] - 10https://gerrit.wikimedia.org/r/172325 (owner: 10Mooeypoo) [21:07:42] Okay, that should do-- whaaat [21:07:53] nooooooo [21:10:13] (03PS13) 10Esanders: Find and replace tool [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175306 [21:10:15] (03PS18) 10Esanders: Find and replace [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/174491 [21:10:17] (03PS4) 10Esanders: Go backwards through find and replace results on shift enter [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175883 [21:11:37] MatmaRex: Have you tried changing .done() to .then() ? [21:11:49] (03PS1) 10Esanders: Papaparse update [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/176748 [21:11:50] (in https://meta.wikimedia.org/wiki/User:Matma_Rex/visualeditor-signature.js ) [21:12:03] (03CR) 10Esanders: "Depends on I4adcddee in core." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/176654 (owner: 10Esanders) [21:12:23] RoanKattouw_away: fixed it already, https://meta.wikimedia.org/w/index.php?title=User:Matma_Rex/visualeditor-signature.js&diff=10675327&oldid=9215078 [21:13:26] Oh yeah that would help [21:13:54] James_F, Krenair: That tech debt bug is for ce.GCN, and probably unrelated to the Parsoid change I fear; at first glance it looks like this would have been broken before [21:14:26] s/tech debt// [21:14:31] 3VisualEditor, VisualEditor-EditingTools: Auto-filled references based on destination URL / ISBN / etc. - https://phabricator.wikimedia.org/T62768#799186 (10KHammerstein) [21:14:41] Hmm. OK. [21:16:19] (03PS1) 10Jforrester: Update VE core submodule to master (eed8fcb) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/176749 [21:16:47] (03CR) 10jenkins-bot: [V: 04-1] Find and replace tool [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175306 (owner: 10Esanders) [21:17:32] 3VisualEditor-TechnicalDebt, VisualEditor: Tools should be able to specify contexts they can/can't operate in themselves - https://phabricator.wikimedia.org/T51438#799191 (10Jdforrester-WMF) 5Open>3Resolved a:3Esanders [21:18:42] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: Some table editor menus are hard to find - https://phabricator.wikimedia.org/T74770#799196 (10KHammerstein) [21:19:17] 3VisualEditor-DataModel, VisualEditor: Don't allow nested s, because Cite.php doesn't - https://phabricator.wikimedia.org/T55303#799200 (10Jdforrester-WMF) 5Open>3Resolved a:3Esanders [21:19:19] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: "Insert table" tool should be (also?) in the "Table" menu, not (or in addition to?) "Insert" menu - https://phabricator.wikimedia.org/T75212#799205 (10KHammerstein) [21:20:53] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (eed8fcb) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/176749 (owner: 10Jforrester) [21:22:34] (03Merged) 10jenkins-bot: Update VE core submodule to master (eed8fcb) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/176749 (owner: 10Jforrester) [21:23:01] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Reference & cite tooltips should show content snippets, instead of generic labels - https://phabricator.wikimedia.org/T71474#799216 (10KHammerstein) [21:23:22] 3VisualEditor, VisualEditor-ContentEditable: Pressing tab inside a cell when the cursor is active should taking it to the next cell, not to beginning of the document - https://phabricator.wikimedia.org/T74823#799217 (10KHammerstein) [21:24:08] 3VisualEditor-ContentEditable, VisualEditor: VisualEditor: Deletion across a header caused it to remain without WS, leading Parsoid to output "====" - https://phabricator.wikimedia.org/T52100#799218 (10Jdforrester-WMF) a:3Jdforrester-WMF [21:24:25] 3VisualEditor-ContentEditable, VisualEditor: VisualEditor: Deletion across a header caused it to remain without WS, leading Parsoid to output "====" - https://phabricator.wikimedia.org/T52100#565138 (10Jdforrester-WMF) [21:25:09] 3VisualEditor-DataModel, VisualEditor: VisualEditor: Whitespace-only headings should be collapsed to (blank) paragraphs - https://phabricator.wikimedia.org/T51452#799221 (10Jdforrester-WMF) [21:25:25] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Doesn't work for me." [oojs/ui] - 10https://gerrit.wikimedia.org/r/176637 (owner: 10Prtksxna) [21:25:31] 3VisualEditor, VisualEditor-MediaWiki-Mobile: VisualEditor: Selecting templates on iOS < 8 causes the on-screen keyboard to close, so they cannot be deleted - https://phabricator.wikimedia.org/T62110#799223 (10Jdforrester-WMF) [21:26:41] (03CR) 10Bartosz Dziewoński: [C: 032] MediaWiki Theme: Reduce indentation in theme-oo-ui-checkboxInputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/176396 (owner: 10Prtksxna) [21:27:30] (03PS16) 10Mooeypoo: Adding DraggableGroupElement and DraggableElement mixins [oojs/ui] - 10https://gerrit.wikimedia.org/r/172325 [21:29:07] MatmaRex, is there a way to set up per-browser CSS conditions in LESS or do I need to do it in javascript? [21:29:26] mooeypoo: ew, why would you do that? [21:29:37] (there isn't) [21:29:48] (other than using any of the well-known CSS hacks) [21:30:41] (03CR) 10jenkins-bot: [V: 04-1] MediaWiki Theme: Reduce indentation in theme-oo-ui-checkboxInputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/176396 (owner: 10Prtksxna) [21:30:50] (03CR) 10jenkins-bot: [V: 04-1] Adding DraggableGroupElement and DraggableElement mixins [oojs/ui] - 10https://gerrit.wikimedia.org/r/172325 (owner: 10Mooeypoo) [21:31:56] GRRAWR [21:32:04] why is the rubocop task thing broken [21:32:18] * James_F blames Krinkle. ;-) [21:32:27] why does it even *run* if i didn't touch any .rb files? isn't that a lint checker or something? [21:32:42] It's a lint + style checker. [21:35:17] MatmaRex: (And indeed.) [21:36:57] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Looking at the demo, the control appears somewhat lopsided. http://i.imgur.com/1HFZkwt.png Code looks good otherwise, same stuff we have i" [oojs/ui] - 10https://gerrit.wikimedia.org/r/176397 (owner: 10Prtksxna) [21:37:20] I know nothing of robocop. I do see that it tries to access ../gems/ inside a workspace directory which looks very suspicious and wrong. [21:37:44] Krinkle: on #-qa: [22:36] MatmaRex: when did that become voting? the problem seems to be that rubygems.org is down for some reason. [21:37:45] I'd forward to Antoine or QA. [21:38:07] rubygems being down was not the reason. [21:38:12] oh, it's a DDOS on DNSimple took out rubygems.org (and other sites I guess) [21:38:20] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Looking at the demo, the control appears somewhat lopsided. http://i.imgur.com/1HFZkwt.png Code looks good otherwise, same stuff we have i" [oojs/ui] - 10https://gerrit.wikimedia.org/r/176398 (owner: 10Prtksxna) [21:38:42] Krinkle: I'm looking at https://github.com/inez/ve-dirtydiffbot/commit/a77b8f36de0030c4dd40dced6d66993552611d5f - does VE not check for .bind anymore, or just newer version of PhantomJS have that problem solved? [21:38:56] chrismcmahon: MatmaRex: It started failing after I reset the workspaces on integation-slave1006. [21:39:04] Though that could be a coincendence [21:39:14] InezK: We use es5-shim [21:39:38] InezK: The module depends on it [21:39:40] I see, thanks [21:39:41] Krinkle: it's a coincidence. root cause is https://gist.github.com/anonymous/87172d2c0c93bc7120c8 [21:39:59] ERROR: Could not find a valid gem 'bundler' (>= 0), here is why: [21:40:00] chrismcmahon: Eww. :-( [21:40:00] 21:27:11 Unable to download data from https://rubygems.org/ [21:40:02] (03CR) 10Mvolz: [C: 032 V: 032] "I don't think so; Roan?" [services/citoid/deploy] - 10https://gerrit.wikimedia.org/r/176619 (owner: 10Mvolz) [21:40:34] James_F: eww, indeed. [21:41:23] (03CR) 10Bartosz Dziewoński: "Hmm, also. A side-effect of the changes to images.json is that we now have a .oo-ui-icon-circle class being generated. Not sure if that's " [oojs/ui] - 10https://gerrit.wikimedia.org/r/176398 (owner: 10Prtksxna) [21:41:42] mvolz: Well, let's hope it didn't. :-) [21:41:50] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: Some table editor menus are hard to find - https://phabricator.wikimedia.org/T74770#799288 (10KHammerstein) {F17789} {F17790} Designs for including a menu in context. [21:42:00] 3VisualEditor, Beta-Cluster: VisualEditor not updating in beta labs - https://phabricator.wikimedia.org/T76097#799289 (10greg) [21:43:25] (03CR) 10Esanders: "We can draw circles with CSS quite easily." [oojs/ui] - 10https://gerrit.wikimedia.org/r/176398 (owner: 10Prtksxna) [21:43:48] 3VisualEditor, VisualEditor-EditingTools: Put table cell editing controls in the context of the so they aren't so hard to find - https://phabricator.wikimedia.org/T74770#799297 (10Jdforrester-WMF) [21:44:24] (03CR) 10Bartosz Dziewoński: "That's asking for a world of pain. We already have like ten generated pseudoelements here." [oojs/ui] - 10https://gerrit.wikimedia.org/r/176398 (owner: 10Prtksxna) [21:46:27] MatmaRex, because I need a drag cursor, and different browsers have different ways of doing it :\ [21:48:46] mooeypoo: Do they conflict, or is it just like -moz-foo // -chrome-foo? [21:52:08] (03CR) 10Catrope: [C: 04-1] WIP: Show entire expandable call tree in ve.Filibuster (034 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167021 (owner: 10Divec) [21:53:24] 3VisualEditor, VisualEditor-EditingTools: Add a feature to write en dash instead of hyphen in VE - https://phabricator.wikimedia.org/T76275#799340 (10Krenair) [21:54:06] 3MediaWiki-ResourceLoader: Make ResourceLoader a standalone library - https://phabricator.wikimedia.org/T32956#799342 (10Krinkle) p:5Volunteer?>3Low [21:59:11] 3MediaWiki-ResourceLoader: @import styles broken in modules that combine multiple stylesheets - https://phabricator.wikimedia.org/T37562#799362 (10Krinkle) [21:59:19] (03CR) 10Esanders: "Also there's a strange looking hover state that only triggers on small parts of the radio button." [oojs/ui] - 10https://gerrit.wikimedia.org/r/176398 (owner: 10Prtksxna) [22:02:09] (03CR) 10Esanders: "The active state seems very inconsistent too. When not selected it goes from bordered to grey filled. When selected it just reduces the b" [oojs/ui] - 10https://gerrit.wikimedia.org/r/176398 (owner: 10Prtksxna) [22:03:39] James_F, some seem to conflict. IE and opera require an actual icon to be attached [22:03:42] (03CR) 10Bartosz Dziewoński: "There's a small but clear improvement, so it might be worth it. I tweaked the jsperf to use jQuery 1.11 (which dramatically lowered the sp" [oojs/ui] - 10https://gerrit.wikimedia.org/r/176476 (owner: 10Prtksxna) [22:03:56] (03CR) 10Bartosz Dziewoński: "http://jsperf.com/adjustsize/2" [oojs/ui] - 10https://gerrit.wikimedia.org/r/176476 (owner: 10Prtksxna) [22:04:10] James_F, see here: http://blog.vjeux.com/2012/css/css-cross-browser-drag-cursor.html <-- there are about 5 rules, each to a different browser, and one that's "if nothing works, do this" [22:04:32] do I have to do this through javascript rules, or is there a sane way to do it in CSS ? [22:04:35] edsanders: this is merged in mediawiki/core, you know. [22:05:00] yes [22:10:15] 3OOjs-UI: TextInputWidget auto-resize method is a little inefficient - https://phabricator.wikimedia.org/T75328#799405 (10matmarex) We're now better filtering out when the textarea hasn't changed. We can't do real debouncing because that causes really horrible UX (scrollbars flickering on and off). Switching fr... [22:10:16] I've just been editing a page with VE and managed to get a list item stuck at the top of the page, no way to remove it :/ [22:12:52] mooey|food, you needn't bother with IE789 [22:13:01] although oojs, hmm [22:13:36] * MatmaRex calls the "graceful degradation" card [22:13:41] yup [22:13:54] does it work without the cursor changing? sure does. [22:14:08] browser-specific stuff is icky and will break on us in the future [22:19:03] edsanders: OOUI is IE8+ target, IIRC. [22:20:26] (03CR) 10Catrope: [C: 04-1] "Chimeras should not use the same image as unicorns. They should also respect the "Input debugging" toggle." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151046 (owner: 10Catrope) [22:21:10] hm [22:21:20] yes, but IE8 compat !== IE8 pixel perfect [22:22:13] (03CR) 10Krinkle: TextInputWidget: Reuse a single clone instead of appending and removing new ones (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/176476 (owner: 10Prtksxna) [22:22:44] mooey|food: Sounds like you should do https://phabricator.wikimedia.org/P115 or something. [22:22:50] edsanders: True, hence my phaste. [22:23:11] Not tested, probably doesn't work. :-) [22:23:19] * mooey|food will test that [22:23:23] I thought the url overrides them [22:23:30] hm, it's by order, though [22:23:33] Isn't it first->last? [22:23:33] Yeah. [22:23:45] And I probably missed some bits. [22:23:52] yes, but i thought that the url oerrides anyways? hm, I think my test was borked. [22:27:13] mooey|food: I'm not the guru to ask. :-) [22:27:31] mooey|food: If necessary, don't set a URL and old IE users just don't get the hint. [22:31:21] 3VisualEditor: Inform the user if there is no template parameter documented using a different message with a link to the template - https://phabricator.wikimedia.org/T59682#799505 (10Jdforrester-WMF) [22:40:52] ha. James_F seems to work! [22:41:09] not sure about IE and opera though [22:52:52] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Whee, works! Some comments." (035 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/176666 (owner: 10Prtksxna) [22:53:43] (03PS17) 10Mooeypoo: Adding DraggableGroupElement and DraggableElement mixins [oojs/ui] - 10https://gerrit.wikimedia.org/r/172325 [22:56:17] 3VisualEditor: Display illustrative images and WikiData descriptions for link suggestions - https://phabricator.wikimedia.org/T76397#799557 (10Jdforrester-WMF) p:3Triage [22:56:45] (03CR) 10jenkins-bot: [V: 04-1] Adding DraggableGroupElement and DraggableElement mixins [oojs/ui] - 10https://gerrit.wikimedia.org/r/172325 (owner: 10Mooeypoo) [22:56:51] not agaaaain [22:57:05] eh [22:57:09] 3VisualEditor: Provide a separate tab in the link editor for external links - https://phabricator.wikimedia.org/T76398 (10Jdforrester-WMF) 3NEW p:3High [22:57:11] what's rubocop? [22:57:32] mooeypoo: Ruby linting, should be non-voting [22:57:50] It voted 'x' [22:58:06] :\ https://gerrit.wikimedia.org/r/#/c/172325/ <-- how do i fix this? [22:58:09] 3VisualEditor: Change the link inspector menu widget to show information about the target in a bigger format - https://phabricator.wikimedia.org/T76399#799577 (10Jdforrester-WMF) [22:58:32] 3VisualEditor: Display illustrative images and WikiData descriptions for link suggestions - https://phabricator.wikimedia.org/T76397#799585 (10Jdforrester-WMF) [22:59:20] (03CR) 10Catrope: "Did this change ever actually get deployed? Or do you need someone to do that?" [services/citoid/deploy] - 10https://gerrit.wikimedia.org/r/176619 (owner: 10Mvolz) [23:00:17] 3VisualEditor, VisualEditor-EditingTools: Add a feature to write en dash instead of hyphen in VE - https://phabricator.wikimedia.org/T76275#799587 (10Jdforrester-WMF) What are you suggesting? That if I type "foo-bar" it changes it to "foo–bar"? What about em-dash? Should "foo - bar" be changed to "foo — bar"? [23:00:59] 3VisualEditor, VisualEditor-EditingTools: Convert hyphens to en dashes when written in VisualEditor - https://phabricator.wikimedia.org/T76275#799589 (10Jdforrester-WMF) p:5Triage>3Low [23:03:19] (03PS1) 10Divec: Use unicorn client rect for adjacent collapsed selection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/176824 [23:06:43] mooeypoo: Someone DDoS'ed rubygems.org which broke ruby linting. [23:06:58] RoanKattouw: No, ruby linting is voting in all 20 repos or so. [23:08:35] RoanKattouw: As of last week or two? [23:09:17] 3VisualEditor, VisualEditor-EditingTools: Convert hyphens to en dashes when written in VisualEditor - https://phabricator.wikimedia.org/T76275#799605 (10Etonkovidova) Just to note - VE preserves hyphen, en-dash, and em-dash typed with regular keyboard shortcuts(on Mac - Option+- for en-dash and Shift+Option+- fo... [23:09:49] ah [23:10:02] mooeypoo: Not good. :-) [23:10:08] James_F, indeed [23:13:32] (From Twitter: "I'm sure fucking glad that DNS is redundant. If it weren't, our entire build system might be broken by rubygems being unavailable. I MEAN IN WHAT UNIVERSE WOULD THAT HAPPEN. NOBODY WOULD HOST INFRASTRUCTURE DEPENDED ON BY A VAST NUMBER OF PEOPLE WITH A SINGLE POINT OF FAILURE, RIGHT? Answer: Yes. Yes, they would.") [23:13:45] RoanKattouw: Quite. [23:15:32] (03CR) 10Catrope: [C: 04-1] Use unicorn client rect for adjacent collapsed selection (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/176824 (owner: 10Divec) [23:17:39] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Left-aligning a large image causes horizontal scrolling past the context menu on Chrome - https://phabricator.wikimedia.org/T73540#799674 (10matmarex) This doesn't appear to be a problem anymore; we scroll to where the popup is, and no further. Trevor an... [23:23:05] (03PS2) 10Divec: Use unicorn client rect for adjacent collapsed selection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/176824 [23:29:55] (03CR) 10Catrope: [C: 032] Use unicorn client rect for adjacent collapsed selection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/176824 (owner: 10Divec) [23:31:40] (03PS17) 10Divec: Make setSelection emit activeAnnotationChange if continuation unicorns may be needed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168327 (https://bugzilla.wikimedia.org/72108) [23:31:48] (03CR) 10jenkins-bot: [V: 04-1] Make setSelection emit activeAnnotationChange if continuation unicorns may be needed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168327 (https://bugzilla.wikimedia.org/72108) (owner: 10Divec) [23:33:21] (03Merged) 10jenkins-bot: Use unicorn client rect for adjacent collapsed selection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/176824 (owner: 10Divec) [23:37:28] 3VisualEditor, VisualEditor-EditingTools: Inspector menu triggers on next line rather than at word when annotation is at the end of the wrap window - https://phabricator.wikimedia.org/T52194#799767 (10Jdforrester-WMF) [23:41:00] RoanKattouw: re: https://phabricator.wikimedia.org/T76308 and https://gerrit.wikimedia.org/r/#/c/176619/, it's deployed where I'm using it but presumably not whereever you set it up. Which I don't have access to :) [23:41:22] (or maybe I do any just don't know where it lives) [23:41:27] Oh OK [23:41:45] Yeah you're right, you don't have access to the production one [23:42:26] the master shouldn't fall over and die when zotero isn't running but we should still deal with restarting it not fixing it? [23:42:47] Ahm... what do you mean exactly? [23:43:00] 3VisualEditor, VisualEditor-EditingTools: Put table cell editing controls in the context of the cell/selection so they aren't so hard to find - https://phabricator.wikimedia.org/T74770#799788 (10Jdforrester-WMF) [23:43:10] well in the bug report Gwicke said that Zotero wasn't running [23:43:18] 3VisualEditor-ContentEditable, VisualEditor, VisualEditor-EditingTools: When cursoring back onto a link, the context menu appears at the end of the paragraph rather than the correct position. - https://phabricator.wikimedia.org/T76415#799791 (10Jdforrester-WMF) [23:43:31] 3VisualEditor-ContentEditable, VisualEditor, VisualEditor-EditingTools: When cursoring back onto a link, the context menu appears at the end of the paragraph rather than the correct position. - https://phabricator.wikimedia.org/T76415#799791 (10Jdforrester-WMF) [23:43:43] I'm assuming there's some way in puppet to restart things that aren't running? [23:45:03] on my labs one i have a cron job but presumably this is not how things are done in production. [23:45:07] MatmaRex: Do you think https://phabricator.wikimedia.org/T73644 is out-of-date rather than just not needed right now? [23:45:57] Yeah I believe puppet should automatically be restarting services that are not running [23:46:10] "Should". :-) [23:46:13] But, does "not running" mean some kind of undeath in this case? [23:46:17] James_F: the bug as specified isn't solved, buuuut the issue it was causing appears to be. not sure if that's caused by fairies or actually fixed [23:46:20] Like, the process is alive but not responding, or something? [23:46:35] I have no idea, maybe should ask gwicke to investigate more. [23:46:45] MatmaRex: Yeah. Maybe leave T73644 on the backlog but mark the VE issue as fixed, removing the dependency? [23:46:55] in the few cases where zotero has died for me the process actually stopped [23:47:00] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Left-aligning a large image causes horizontal scrolling past the context menu on Chrome - https://phabricator.wikimedia.org/T73540#799826 (10Jdforrester-WMF) [23:47:02] James_F: sounds sensible. [23:47:12] {{done}} [23:47:12] 3VisualEditor, VisualEditor-ContentEditable: Left-aligning a large image causes horizontal scrolling past the context menu on Chrome - https://phabricator.wikimedia.org/T73540#799827 (10Jdforrester-WMF) 5Open>3Resolved [23:50:38] mvolz: Hmm. Well puppet doesn't run very frequently so if Zotero is prone to randomly dying then maybe we need something more aggressive / frequent to restart it [23:52:07] (03PS18) 10Divec: Make setSelection emit activeAnnotationChange if continuation unicorns may be needed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168327 (https://bugzilla.wikimedia.org/72108) [23:52:54] (03CR) 10Divec: "Patchset 18: rebased from patchset 16" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168327 (https://bugzilla.wikimedia.org/72108) (owner: 10Divec) [23:54:03] RoanKattouw: it's weird. It's been running perfectly fine for me on beta for over 3 months now [23:54:21] but there was one day it would just randomly go down every hour without me every even querying it [23:54:31] so I hesitate to put a pattern on it [23:54:46] but for the most part it's been alive for months on end, but that's with pretty minimal traffic [23:54:59] not on beta, on labs, sorry [23:55:32] Krinkle, are you around? I am baffled :\ jenkins says my patch didn't pass unit tests but it does. It says something about a missing QUnit.start(); but that exists in the test file.... https://gerrit.wikimedia.org/r/#/c/167046/21/tests/ext.templateData.tests.js [23:56:10] after the every hour thing I have a cron job that checks it every minute but I have no idea what caused that and it hasn't happened since... [23:56:31] mooeypoo: Missing qunit.start error means it timed out before QUnit finished (or it never started). It's not about the 'start' after 'stop' (for an async test), but the error is about the 'start' at the beginnig of the first test (the one meidawiki core calls to start the flow of tests) [23:56:56] oh [23:56:57] most likely a fatal error in the javascript or php stack. [23:57:01] (03PS6) 10Catrope: WIP: Rerender ContentBranchNodes when the selection anchor leaves [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/171494 (owner: 10Divec) [23:57:03] (03PS30) 10Catrope: Use a chimera instead of  in inline slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151046 [23:57:08] Krinkle, hm. How do I figure out what to fix? [23:57:09] mooeypoo: e.g. Special:JavaScriptTest/qunit didn't load. [23:57:12] (03CR) 10jenkins-bot: [V: 04-1] Use a chimera instead of  in inline slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151046 (owner: 10Catrope) [23:57:13] oh [23:57:16] mooeypoo: Does it work locally? [23:57:17] Krinkle, but it's the third time it happens [23:57:18] yes [23:57:25] mooeypoo: It's not a race condition. [23:57:25] (03CR) 10Esanders: "@bartosz with that many pseudos should we not just add a wrapper div? I think we should assume the default skin implementation is to *not*" [oojs/ui] - 10https://gerrit.wikimedia.org/r/176398 (owner: 10Prtksxna) [23:57:28] mooeypoo: link? [23:57:37] https://gerrit.wikimedia.org/r/#/c/167046/ [23:58:18] 3VisualEditor-MediaWiki, VisualEditor: A message key appears instead of the actual message in visualeditor-dialog-meta-settings-newsectioneditlink-help - https://phabricator.wikimedia.org/T75969#799902 (10Jdforrester-WMF) 5Open>3Resolved [23:58:53] Krinkle, it passes locally for me :\ [23:59:43] mooeypoo: phpunit fails as well, so that suggests the problem is early on in the php stage [23:59:43] (03PS7) 10Catrope: Rerender ContentBranchNodes when the selection anchor leaves [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/171494 (owner: 10Divec) [23:59:51] mooeypoo: there is a missing variable $dir [23:59:53] (03PS31) 10Catrope: Use a chimera instead of  in inline slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151046 [23:59:54] https://integration.wikimedia.org/ci/job/mwext-TemplateData-qunit/230/console [23:59:58] https://integration.wikimedia.org/ci/job/mwext-TemplateData-testextension/55/consoleFull