[00:00:01] ... jesus [00:00:01] (03CR) 10jenkins-bot: [V: 04-1] Use a chimera instead of  in inline slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151046 (owner: 10Catrope) [00:00:05] 04:52:37 PHP Notice: Undefined variable: dir in /srv/ssd/jenkins-slave/workspace/mwext-TemplateData-testextension/src/extensions/TemplateData/TemplateData.hooks.php on line 56 [00:00:07] Krinkle, how did you... [00:00:18] * mooeypoo grumbles [00:00:18] mooeypoo: You presumably surpress errors locally in your php.ini config so you didn't see it. [00:00:22] 3VisualEditor-MediaWiki, VisualEditor: [Regression wmf10] Editing a formula causes the inspector to close immediately - https://phabricator.wikimedia.org/T76420 (10Jdforrester-WMF) 3NEW p:3High [00:00:31] Krinkle, thank you! I can't believe I missed that... [00:00:49] mooeypoo: On Jenkins display_error=On, which means a php warnign results in Warning being output, which breaks the test page. [00:01:04] * mooeypoo will fix up her php.ini [00:01:23] I didn't even think about php when I saw that, I thought it was javascript, because of the QUnit.start() note [00:01:29] :-) [00:01:29] mooeypoo: https://github.com/Krinkle/dotfiles/blob/master/hosts/KrinkleMac/php.ini#L35-L43 [00:01:38] sweet! thanks! [00:02:01] Yeah, upstream grunt-contrib-qunit leaves that note since that's the most common problem. But not always. [00:02:07] * mooeypoo nods [00:02:13] Now I know not to let it confuse me [00:03:05] (03PS22) 10Mooeypoo: Eventify TemplateDataGenerator and use oojs-ui [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 [00:03:14] * mooeypoo stares at her patchset [00:04:17] ^_^ [00:07:24] 3VisualEditor-EditingTools, VisualEditor-MediaWiki, VisualEditor: [Regression wmf10] Cannot open any inspectors, they just flicker and get closed - https://phabricator.wikimedia.org/T76076#799942 (10Jdforrester-WMF) 5Open>3Resolved [00:09:25] 3VisualEditor-ContentEditable, VisualEditor: [Regression wmf10] Changes in the caption surface in MediaDialog does not enable the "Apply" button - https://phabricator.wikimedia.org/T76074#799944 (10Jdforrester-WMF) [00:13:50] (03CR) 10Esanders: [C: 04-1] Element.getClosestScrollableContainer: Use 'body' or 'documentElement' based on browser (033 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/176666 (owner: 10Prtksxna) [00:15:54] (03PS8) 10Catrope: Rerender ContentBranchNodes when the selection anchor leaves [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/171494 (owner: 10Divec) [00:15:56] (03PS32) 10Catrope: Use a chimera instead of  in inline slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151046 [00:23:07] 3Parsoid, VisualEditor, VisualEditor-MediaWiki: Editing a specific article at pl.wp truncates category name - https://phabricator.wikimedia.org/T76353#799975 (10Arlolra) The patch tries to help with this case. But the culprit is mainly that there's a template with an unclosed table. I left an edit for review, h... [00:24:07] 3VisualEditor, VisualEditor-ContentLanguage: ZH IME input sometimes inserts latin characters - https://phabricator.wikimedia.org/T74268#799977 (10Jdforrester-WMF) p:5Triage>3High [00:24:39] 3VisualEditor, VisualEditor-ContentLanguage: VisualEditor lost the first character when inputing with some IME - https://phabricator.wikimedia.org/T70893#799980 (10Jdforrester-WMF) p:5Triage>3High [00:25:17] 3VisualEditor, VisualEditor-ContentLanguage: VisualEditor lost the first character when inputing with some IME - https://phabricator.wikimedia.org/T70893#736466 (10Jdforrester-WMF) [00:28:49] 3Parsoid, VisualEditor, VisualEditor-ContentLanguage: {{int:..}} usages should render in user language instead of content language - https://phabricator.wikimedia.org/T72215#799992 (10Jdforrester-WMF) [00:29:10] 3Parsoid, VisualEditor, VisualEditor-ContentLanguage: {{int:..}} usages should render in user language instead of content language - https://phabricator.wikimedia.org/T72215#737927 (10Jdforrester-WMF) [00:31:09] 3MediaWiki-skins-MonoBook, VisualEditor-MediaWiki, VisualEditor: Monobook: extremely small font in Insert-Template and Cite options dialog boxes - https://phabricator.wikimedia.org/T75800#799997 (10Jdforrester-WMF) p:5Triage>3Normal [00:31:17] 3MediaWiki-skins-MonoBook, VisualEditor-MediaWiki, VisualEditor: Monobook: extremely small font in Insert-Template and Cite options dialog boxes - https://phabricator.wikimedia.org/T75800#782743 (10Jdforrester-WMF) [00:35:21] 3VisualEditor, VisualEditor-ContentLanguage: VisualEditor: Language dialog box didn't draw correctly - https://phabricator.wikimedia.org/T72733#800001 (10Jdforrester-WMF) This appears to now be fixed for me – testing in Firefox, Chrome and Safari. [00:35:54] 3OOjs-UI: OOjs UI: Toolbar should collapse items rather than span multiple lines when the window is narrow - https://phabricator.wikimedia.org/T52227#800004 (10Jdforrester-WMF) [00:36:15] 3OOjs-UI: Use MutationObserver to detect when an OO.ui.Element is attached to a document - https://phabricator.wikimedia.org/T64174#800006 (10Jdforrester-WMF) [00:36:25] 3UI Standardization, OOjs-UI: Get OOUI PHP to be good to go - https://phabricator.wikimedia.org/T74713#800007 (10Jdforrester-WMF) [00:36:34] 3OOjs-UI: PHP docs should be auto-generated - https://phabricator.wikimedia.org/T74454#800008 (10Jdforrester-WMF) [00:36:51] 3OOjs-UI: OOjs UI: Dialog height initially mis-measured in Safari 7.1 - https://phabricator.wikimedia.org/T73736#800012 (10Jdforrester-WMF) p:5High>3Normal [00:41:47] 3VisualEditor, VisualEditor-EditingTools: VisualEditor:Template "reflist" does not get added immediately on the page - https://phabricator.wikimedia.org/T59271#800031 (10Jdforrester-WMF) [00:41:48] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: Parsoid's render of {{reflist}} has no context, so no references appear; similarly, edited templates inside structures, look odd on edit - https://phabricator.wikimedia.org/T53146#800032 (10Jdforrester-WMF) [00:42:03] 3VisualEditor: VisualEditor: new autoadded reflist does not display when in VE edit mode - https://phabricator.wikimedia.org/T69873#800034 (10Jdforrester-WMF) [00:42:05] 3VisualEditor, VisualEditor-EditingTools: Append references list to bottom of pages when first reference is added - https://phabricator.wikimedia.org/T56906#800035 (10Jdforrester-WMF) [00:47:48] (03PS1) 10Divec: Add getDescription method to selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/176850 [00:51:08] 3VisualEditor-MediaWiki, VisualEditor: The (Ctrl+Alt+S) keyboard shortcut opens the Save dialog but should also trigger save when in it - https://phabricator.wikimedia.org/T76161#800066 (10Krenair) [27-11-2014 22:48:38] I guess it could be achieved with this.getActions().get( { action... [00:53:52] 3VisualEditor-MediaWiki, VisualEditor: VisualEditor: When I click the Save button, please take my cursor out of the main text and focus it in the Save dialog - https://phabricator.wikimedia.org/T75675#800070 (10Krenair) Did anyone other than the reporter ever manage to reproduce this issue? [00:54:06] 3VisualEditor, VisualEditor-EditingTools: Blockquotes aren't CBNs in reality, and our code shouldn't try to insist that they are - https://phabricator.wikimedia.org/T76426 (10Jdforrester-WMF) 3NEW p:3Normal [01:02:00] 3VisualEditor, VisualEditor-ContentEditable: References in blockquote invisible outside it; reflist outside blockquote invisible inside it - https://phabricator.wikimedia.org/T54398#800086 (10Jdforrester-WMF) [01:02:05] 3VisualEditor, VisualEditor-ContentEditable: References in blockquote invisible outside it; reflist outside blockquote invisible inside it - https://phabricator.wikimedia.org/T54398#592354 (10Jdforrester-WMF) [01:02:24] 3VisualEditor, VisualEditor-ContentEditable: References in blockquote invisible outside it; reflist outside blockquote invisible inside it - https://phabricator.wikimedia.org/T54398#592354 (10Jdforrester-WMF) [01:03:43] 3MediaWiki-skins-MonoBook, VisualEditor-MediaWiki, VisualEditor, OOjs-UI: Cancel button does not work for Insert-Template and some Cite options in VisualEditor in Monobook - https://phabricator.wikimedia.org/T75802#800101 (10Jdforrester-WMF) [01:05:04] 3VisualEditor, VisualEditor-MediaWiki, VisualEditor-ContentEditable: The box for preformatted option doesn't shorten itself when there are floated nodes to the right - https://phabricator.wikimedia.org/T58753#800104 (10Jdforrester-WMF) p:5Triage>3Low [01:05:43] 3MediaWiki-skins-MonoBook, VisualEditor-MediaWiki, VisualEditor, OOjs-UI: Cancel button does not work for Insert-Template and some Cite options in VisualEditor in Monobook - https://phabricator.wikimedia.org/T75802#782782 (10Jdforrester-WMF) [01:05:46] 3VisualEditor, VisualEditor-MediaWiki, VisualEditor-ContentEditable: The box for preformatted option doesn't shorten itself when there are floated nodes to the right - https://phabricator.wikimedia.org/T58753#602641 (10Jdforrester-WMF) p:5Low>3Normal [01:06:58] 3VisualEditor: "beta" superscript on page has flash of unstyled content FOUC on page load - https://phabricator.wikimedia.org/T69266#800117 (10Jdforrester-WMF) [01:08:23] 3VisualEditor: "beta" superscript on page has flash of unstyled content FOUC on page load - https://phabricator.wikimedia.org/T69266#800124 (10Jdforrester-WMF) [01:08:32] 3VisualEditor: VisualEditor should support redirects to sections on a page - https://phabricator.wikimedia.org/T69147#800128 (10Jdforrester-WMF) [01:08:46] 3VisualEditor-MediaWiki, VisualEditor: VisualEditor should support redirects to sections on a page - https://phabricator.wikimedia.org/T69147#714874 (10Jdforrester-WMF) p:5Normal>3Low [01:09:47] (03PS1) 10Alex Monk: Handle encoding of links in transclusion nodes properly when determining existence [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/176857 [01:09:55] 3VisualEditor: unexpected "session no longer valid" in automated test - https://phabricator.wikimedia.org/T64931#800136 (10Jdforrester-WMF) 5Open>3Resolved a:3Jdforrester-WMF Wasn't this the bug that was caused by the mobile test for logging the user out running in parallel? [01:10:01] 3VisualEditor-MediaWiki, VisualEditor: LinkCache sends API requests for URL-encoded page names, gets "invalid" responses back when descending into template contents - https://phabricator.wikimedia.org/T75823#800139 (10Krenair) a:3Krenair [01:10:02] Krenair: Nice. :-) [01:12:57] 3VisualEditor: Transcluded pages quasi-template eats into subsequent entry - https://phabricator.wikimedia.org/T53119#800143 (10Jdforrester-WMF) [01:17:19] :) [01:20:48] (03PS19) 10Catrope: Make setSelection emit activeAnnotationChange if continuation unicorns may be needed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168327 (https://bugzilla.wikimedia.org/72108) (owner: 10Divec) [01:22:38] (03CR) 10jenkins-bot: [V: 04-1] Make setSelection emit activeAnnotationChange if continuation unicorns may be needed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168327 (https://bugzilla.wikimedia.org/72108) (owner: 10Divec) [01:23:01] 3MediaWiki-Page-editing, MediaWiki-ContentHandler: [Regression] section=new no longer works for user js/css pages - https://phabricator.wikimedia.org/T52962#800161 (10Jdforrester-WMF) [01:23:50] (03PS20) 10Catrope: Make setSelection emit activeAnnotationChange if continuation unicorns may be needed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168327 (https://bugzilla.wikimedia.org/72108) (owner: 10Divec) [01:31:11] (03PS1) 10Alex Monk: Disable Apply Changes in reference dialog until changes have been made [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/176861 [01:33:11] (03CR) 10jenkins-bot: [V: 04-1] Disable Apply Changes in reference dialog until changes have been made [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/176861 (owner: 10Alex Monk) [01:34:56] (03PS2) 10Alex Monk: Disable Apply Changes in reference dialog until changes have been made [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/176861 [01:36:38] seems doing that for transclusions would be much more complicated [01:36:49] Hmm. [01:37:56] (/citations) [01:38:09] * James_F nods. [01:39:33] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: "Merge cells" option should be in a selection context menu, not the toolbar - https://phabricator.wikimedia.org/T75228#800178 (10Krenair) [01:41:50] 3VisualEditor-MediaWiki, VisualEditor: The (Ctrl+Alt+S) keyboard shortcut opens the Save dialog but should also trigger save when in it - https://phabricator.wikimedia.org/T76161#800181 (10Jdforrester-WMF) >>! In T76161#800066, @Krenair wrote: > [27-11-2014 22:48:38] I guess it could... [01:42:31] (03PS9) 10Divec: WIP: Show entire expandable call tree in ve.Filibuster [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167021 [01:43:29] (03CR) 10Catrope: [C: 032] Add getDescription method to selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/176850 (owner: 10Divec) [01:45:14] 3VisualEditor: Provide a separate tab in the link editor for external links - https://phabricator.wikimedia.org/T76398#800183 (10Krenair) [01:45:48] (03Merged) 10jenkins-bot: Add getDescription method to selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/176850 (owner: 10Divec) [01:47:13] 3VisualEditor, VisualEditor-ContentLanguage: Cursor error typing into end of paragraph with Ibus Malayalam Swanalekha - https://phabricator.wikimedia.org/T56057#800187 (10Jdforrester-WMF) [01:50:25] (03CR) 10Jforrester: "Change should at least be made semi-upstream in https://github.com/edg2s/PapaParse." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/176748 (owner: 10Esanders) [01:54:43] (03PS10) 10Divec: WIP: Show entire expandable call tree in ve.Filibuster [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167021 [01:56:55] 3VisualEditor-MediaWiki, VisualEditor: If the user only has edited in one section, VisualEditor should insert the name of the edited section into the edit summary - https://phabricator.wikimedia.org/T53903#800202 (10Mattflaschen) [01:58:40] (03PS2) 10Jforrester: Track new pagedeleted save error in TargetEvents [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175795 (owner: 10Catrope) [01:59:01] (03CR) 10Catrope: [C: 04-1] Make setSelection emit activeAnnotationChange if continuation unicorns may be needed (033 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168327 (https://bugzilla.wikimedia.org/72108) (owner: 10Divec) [02:01:41] (03CR) 10Jforrester: [C: 031] "WikimediaEvents change is I9f39c51d7." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175795 (owner: 10Catrope) [02:02:17] (03CR) 10Catrope: [C: 032] Track new pagedeleted save error in TargetEvents [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175795 (owner: 10Catrope) [02:04:15] (03Merged) 10jenkins-bot: Track new pagedeleted save error in TargetEvents [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175795 (owner: 10Catrope) [02:49:20] 3VisualEditor: "beta" superscript on page has flash of unstyled content FOUC on page load - https://phabricator.wikimedia.org/T69266#800248 (10Jaredzimmerman-WMF) [03:16:02] 3MediaWiki-ResourceLoader: mw.loader.store should not occupy all of localStorage - https://phabricator.wikimedia.org/T66721#800279 (10Mattflaschen) [04:19:41] 3MediaWiki-ResourceLoader: mw.loader.store should not occupy all of localStorage - https://phabricator.wikimedia.org/T66721#800313 (10Krinkle) [04:21:49] 3MediaWiki-ResourceLoader: mw.loader.store should not occupy all of localStorage - https://phabricator.wikimedia.org/T66721#800321 (10MZMcBride) [04:59:52] can someone help me with Gerrit and Citoid? I'm trying to push my changes to gerrit [05:00:25] I get [05:00:27] Problems encountered installing commit-msg hook [05:00:27] /var/www/mw/citoid/deploy/src/.git/hooks/commit-msg: Not a directory [05:19:40] (03PS1) 10Legoktm: Add .gitreview file [services/citoid/deploy] - 10https://gerrit.wikimedia.org/r/176883 [05:20:19] (03CR) 10Legoktm: [C: 032 V: 032] Add .gitreview file [services/citoid/deploy] - 10https://gerrit.wikimedia.org/r/176883 (owner: 10Legoktm) [05:23:50] ^ solved :) [05:29:38] 3Parsoid, VisualEditor, VisualEditor-MediaWiki: Editing a specific article at pl.wp truncates category name - https://phabricator.wikimedia.org/T76353#800387 (10ssastry) [05:59:51] (03PS1) 10Unicodesnowman: Add requestFromPMID (and aliases for PMCID, Manuscript ID), which fetches DOI and grabs response of that [services/citoid] - 10https://gerrit.wikimedia.org/r/176887 [06:02:15] unicodesnowman: yay! [06:03:07] (03PS2) 10Unicodesnowman: Add requestFromPMID (and aliases for PMCID, Manuscript ID), which fetches DOI and grabs response of that [services/citoid] - 10https://gerrit.wikimedia.org/r/176887 [06:03:57] unicodesnowman: you should add "Bug: T1197" to the footer of your commit message (on the line above the Change-Id) to link the patch to the bug [06:06:33] (03PS3) 10Unicodesnowman: Add requestFromPMID (and aliases for PMCID, Manuscript ID), which fetches DOI and grabs response of that [services/citoid] - 10https://gerrit.wikimedia.org/r/176887 [06:12:20] (03PS4) 10Unicodesnowman: Add requestFromPMID (and aliases for PMCID, Manuscript ID), which fetches DOI and grabs response of that [services/citoid] - 10https://gerrit.wikimedia.org/r/176887 [08:03:03] hello mvolz :) [08:13:05] Hi! [08:13:15] Saw you had a patch already, that was fast! [08:19:40] thanks! I spent most of the time fiddling with git/gerrit, can I ask what's the difference between mediawiki/services/citoid and mediawiki/services/citoid/deploy ? was confusing [08:28:26] 3VisualEditor-MediaWiki, VisualEditor: VisualEditor: Magically support Extension:InputBox's content for BLP warning notices on enwiki - https://phabricator.wikimedia.org/T56029#800523 (10TheDJ) [08:33:45] unicodesnowman: we use deploy in production so it can be automatically set up with puppet [08:34:10] since citioid requires several other components to work [08:34:43] basically so a machine can set up citoid. but if you're a human you can do it from scratch :) [08:34:49] otherwise there's no real difference [08:35:16] since deploy includes the code from mediawiki/services/citoid [08:40:23] mvolz, ah, I see. thanks [09:22:29] 3VisualEditor-EditingTools, VisualEditor-MediaWiki, VisualEditor: [Regression wmf10] Cannot open any inspectors, they just flicker and get closed - https://phabricator.wikimedia.org/T76076#800770 (10zeljkofilipin) This is still broken at beta: http://en.wikipedia.beta.wmflabs.org/wiki/Language_Screenshot?veacti... [09:42:14] (03PS5) 10Mvolz: Add requestFromPMID (and aliases for PMCID, Manuscript ID), which fetches DOI and grabs response of that [services/citoid] - 10https://gerrit.wikimedia.org/r/176887 (owner: 10Unicodesnowman) [09:43:05] (03CR) 10Mvolz: "(Fixed my own documentation in patch 5)" [services/citoid] - 10https://gerrit.wikimedia.org/r/176887 (owner: 10Unicodesnowman) [09:43:50] (03CR) 10Mvolz: [C: 04-1] "Commit message:" [services/citoid] - 10https://gerrit.wikimedia.org/r/176887 (owner: 10Unicodesnowman) [09:45:20] (03CR) 10Mvolz: "Documentation/Style" [services/citoid] - 10https://gerrit.wikimedia.org/r/176887 (owner: 10Unicodesnowman) [09:45:53] (03CR) 10Mvolz: "Code" [services/citoid] - 10https://gerrit.wikimedia.org/r/176887 (owner: 10Unicodesnowman) [09:47:09] unicodesnowman: great job! just some very little things to fix :) [09:48:05] (including things I messed up myself so I uploaded the patch with my own docs fixed, so you should work from that patch- woo more learning gerrit) [09:48:06] :) [09:53:57] mvolz, think I figured out how to work from that patch, yay! :D [10:01:22] mvolz, one note about "no need to send an empty object through on 112.": idea is so people can pass HTTP proxy settings if they need to? or that not necessary? [10:09:57] hmm. I'm having trouble imagining where we'd need to use a proxy but only for requests to the pubmed id converter. Maybe if they were constantly banning our IPs? :) [10:15:50] mvolz, good point, no need for the additional complexity. the requestFromURL function also has the weird } \n else { formatting, should I fix those too? [10:16:10] i was very confused over the coding convention, heh [10:17:36] (03PS2) 10Prtksxna: Use MutationObserver instead of DOMNodeInsertedIntoDocument [oojs/ui] - 10https://gerrit.wikimedia.org/r/176681 [10:18:23] (03CR) 10Prtksxna: "Ready for review, needs optimizing." [oojs/ui] - 10https://gerrit.wikimedia.org/r/176681 (owner: 10Prtksxna) [10:19:41] (03CR) 10jenkins-bot: [V: 04-1] Use MutationObserver instead of DOMNodeInsertedIntoDocument [oojs/ui] - 10https://gerrit.wikimedia.org/r/176681 (owner: 10Prtksxna) [10:20:15] (03PS3) 10Prtksxna: TextInputWidget: Use MutationObserver instead of DOMNodeInsertedIntoDocument [oojs/ui] - 10https://gerrit.wikimedia.org/r/176681 [10:21:37] 3OOjs-UI: Use MutationObserver to detect when an OO.ui.Element is attached to a document - https://phabricator.wikimedia.org/T64174#800919 (10Prtksxna) [10:22:42] unicodesnowman: yup! [10:23:17] (03CR) 10jenkins-bot: [V: 04-1] TextInputWidget: Use MutationObserver instead of DOMNodeInsertedIntoDocument [oojs/ui] - 10https://gerrit.wikimedia.org/r/176681 (owner: 10Prtksxna) [10:24:56] unicodesnowman: the extra option isn't bad strictly speaking since it's good to make things flexible, but if you do it that way you should probably do it the way the request library does it; i.e. allow the first argument to be either a url or an option object [10:25:03] that would probably be the nicest solution [10:25:19] but up to you whether you want to bother doing that, we can always add it in later if needed :) [10:27:37] oh yeah, that would be the best way. I take my patch back thought, I think a smaller codebase is better :) [10:33:05] (03PS6) 10Unicodesnowman: Add requestFromPubMedID, requestJSON [services/citoid] - 10https://gerrit.wikimedia.org/r/176887 [10:34:20] yay! I'm liking gerrit :) [10:37:51] (03PS4) 10Prtksxna: TextInputWidget: Reuse a single clone instead of appending and removing new ones [oojs/ui] - 10https://gerrit.wikimedia.org/r/176476 [10:38:09] (03CR) 10Prtksxna: TextInputWidget: Reuse a single clone instead of appending and removing new ones (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/176476 (owner: 10Prtksxna) [10:39:37] 3OOjs-UI: TextInputWidget auto-resize method is a little inefficient - https://phabricator.wikimedia.org/T75328#800964 (10Prtksxna) I have updated the patch to use `.style.display`. Testing is welcome. [10:40:02] 3OOjs-UI: TextInputWidget auto-resize method is a little inefficient - https://phabricator.wikimedia.org/T75328#800966 (10Prtksxna) 5Resolved>3Open [10:41:39] (03CR) 10Prtksxna: "Updated to the 'new' code from jsPerf." [oojs/ui] - 10https://gerrit.wikimedia.org/r/176476 (owner: 10Prtksxna) [10:51:33] (03PS4) 10Prtksxna: TextInputWidget: Use MutationObserver instead of DOMNodeInsertedIntoDocument [oojs/ui] - 10https://gerrit.wikimedia.org/r/176681 [11:02:01] (03PS3) 10Prtksxna: Element.getClosestScrollableContainer: Use 'body' or 'documentElement' based on browser [oojs/ui] - 10https://gerrit.wikimedia.org/r/176666 [11:02:33] (03CR) 10Prtksxna: "I have fixed most of the things you guys pointed out. I had a question about keeping this as a boolean property though. See inline comment" (035 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/176666 (owner: 10Prtksxna) [11:11:11] 3OOjs-UI: PHP docs should be auto-generated - https://phabricator.wikimedia.org/T74454#801047 (10hashar) [11:11:37] 3Continuous-Integration, OOjs-UI: PHP docs should be auto-generated - https://phabricator.wikimedia.org/T74454#750834 (10hashar) We can do it for branches, but not for tags currently :( [11:18:05] 3MediaWiki-extensions-WikiEditor: Vector toolbar. Option to Find / Replace only within selected text - https://phabricator.wikimedia.org/T42797#801055 (10Perhelion) [11:19:13] unicodesnowman: yeah it's kind of random :). there are a lot of different js styles. VisualEditor uses spaces within parens, which I absolutely hate, but it's a very consistent codebase! I haven't been the best with enforcing citoid styling conventions so it's a bit of a mess (you get to be the guinea pig) [11:22:49] heh, yeah. oh, single quotes or double quotes for string literals? I saw it was a bit mixed [11:23:01] mvolz, also, submitted my patch :) [11:39:13] (03CR) 10Mvolz: [C: 04-1] "Just a few things I missed the first time:" [services/citoid] - 10https://gerrit.wikimedia.org/r/176887 (owner: 10Unicodesnowman) [11:45:27] re:strings, probably single... but yeah I've not been consistent at all there. [11:46:19] (03PS7) 10Unicodesnowman: Add requestFromPubMedID, requestJSON [services/citoid] - 10https://gerrit.wikimedia.org/r/176887 [11:47:32] okay, thank you for being thorough by the way! my first code-reviewed code :) [12:00:40] 3MediaWiki-extensions-WikiEditor: WikiEditor textbox loses focus while toolbar renders, making it feel slow - https://phabricator.wikimedia.org/T35990#801113 (10happy5214) Is this still an issue? [12:03:46] 3MediaWiki-extensions-WikiEditor: Headers of Toolbar Help section don't align with its content on IE7 - https://phabricator.wikimedia.org/T25981#801115 (10happy5214) [12:06:03] 3MediaWiki-extensions-WikiEditor: Added "search and replace within selection" functionality - https://phabricator.wikimedia.org/T56961#801117 (10Perhelion) [12:06:06] 3MediaWiki-extensions-WikiEditor: WikiEditor textbox loses focus while toolbar renders, making it feel slow - https://phabricator.wikimedia.org/T35990#801118 (10TheDJ) [12:07:19] 3MediaWiki-extensions-WikiEditor: When dialog to insert an image is invoked on a selection, prefill the fields accordingly - https://phabricator.wikimedia.org/T40829#801123 (10Perhelion) [12:16:28] (03CR) 10Mvolz: [C: 032 V: 032] "Great job!" [services/citoid] - 10https://gerrit.wikimedia.org/r/176887 (owner: 10Unicodesnowman) [12:46:12] 3MediaWiki-extensions-WikiEditor: When dialog to insert an image is invoked on a selection, prefill the fields accordingly - https://phabricator.wikimedia.org/T40829#801197 (10happy5214) [12:53:26] (03PS1) 10Amire80: Change Basic image type to "Inline" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/176919 [13:17:18] (03PS1) 10Unicodesnowman: Add missing PMIDs by looking up DOI [services/citoid] - 10https://gerrit.wikimedia.org/r/176921 [13:21:52] 3VisualEditor, VisualEditor-ContentLanguage: VisualEditor: Support for right-to-left (rtl) / bidirectional content (tracking) - https://phabricator.wikimedia.org/T35126#801283 (10Amire80) [14:35:55] 3OOjs-UI, MediaWiki-ResourceLoader: Implement ResourceLoader module to ship CSS for sets of SVG+PNG icons to the user - https://phabricator.wikimedia.org/T76473 (10matmarex) 3NEW p:3Triage [14:40:04] (03PS1) 10Happy5214: Pre-fill fields in image dialog when image code is selected in editor [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/176927 [14:40:09] (03CR) 10jenkins-bot: [V: 04-1] Pre-fill fields in image dialog when image code is selected in editor [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/176927 (owner: 10Happy5214) [14:40:13] 3OOjs-UI, MediaWiki-ResourceLoader: Implement ResourceLoader module to ship CSS for sets of SVG+PNG icons to the user - https://phabricator.wikimedia.org/T76473#801446 (10matmarex) Trevor's rasterization test: https://github.com/trevorparscal/colorize (check out the rsvg branch too: https://github.com/trevorpars... [14:48:22] 3VisualEditor: VisualEditor page options menu goes off-screen in RTL wikis - https://phabricator.wikimedia.org/T76474 (10Amire80) 3NEW p:3Triage [14:49:05] 3VisualEditor, VisualEditor-ContentLanguage: VisualEditor: Support for right-to-left (rtl) / bidirectional content (tracking) - https://phabricator.wikimedia.org/T35126#801454 (10Amire80) [15:46:22] (03CR) 10Mvolz: "Line 183: trailing whitespace (You can configure your editor to either trim these or point them out to you while editing. If you're using " [services/citoid] - 10https://gerrit.wikimedia.org/r/176921 (owner: 10Unicodesnowman) [15:47:42] 3MediaWiki-ResourceLoader, MediaWiki-File-management: Create a variant of SvgHandler suitable for T76473 - https://phabricator.wikimedia.org/T76477 (10matmarex) 3NEW p:3Triage [16:03:35] 3OOjs-UI: OOjs UI: OO.ui.ButtonWidget default target should not be "_blank" - https://phabricator.wikimedia.org/T75452#801563 (10Prtksxna) [16:06:19] 3OOjs-UI: OOjs UI: Move transition timings in theme specific files - https://phabricator.wikimedia.org/T67254#801571 (10Prtksxna) Could this just be a property being set when the theme is instantiated? [16:07:08] 3MediaWiki-extensions-WikiEditor: Undo/Redo doesn't work in Chrome/Chromium/Firefox for WikiEditor 0.3.1 in MW 1.19.2 - https://phabricator.wikimedia.org/T45187#801576 (10happy5214) This has probably already been fixed. I have no issues with undo/redo in Firefox on my local wiki running MW 1.23 and WikiEditor fr... [16:08:20] 3OOjs-UI: OOjs UI: Dialog height initially mis-measured in Safari 7.1 - https://phabricator.wikimedia.org/T73736#801584 (10Prtksxna) [16:08:56] 3OOjs-UI: OOjs UI: Toolbar should collapse items rather than span multiple lines when the window is narrow - https://phabricator.wikimedia.org/T52227#801588 (10Prtksxna) [16:26:34] (03CR) 10Esanders: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/175306 (owner: 10Esanders) [16:49:08] 3OOjs-UI, MediaWiki-ResourceLoader: Implement ResourceLoader module to ship CSS for sets of SVG+PNG icons to the user - https://phabricator.wikimedia.org/T76473#801806 (10matmarex) [17:06:14] 3VisualEditor-MediaWiki, VisualEditor: Entering ";" does not trip the wikitext warning that it won't work - https://phabricator.wikimedia.org/T71689#801844 (10Whatamidoing-WMF) I don't think that's exactly correct: the ; semi-colon and the : regular colon are supposed to create association lists (aka definition... [17:08:56] 3VisualEditor, VisualEditor-EditingTools: Blockquotes aren't CBNs in reality, and our code shouldn't try to insist that they are - https://phabricator.wikimedia.org/T76426#801853 (10Whatamidoing-WMF) [17:11:24] 3VisualEditor, VisualEditor-EditingTools: Blockquotes aren't CBNs in reality, and our code shouldn't try to insist that they are - https://phabricator.wikimedia.org/T76426#801883 (10Jdforrester-WMF) [17:14:13] (03PS2) 10Esanders: Papaparse update [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/176748 [17:14:40] (03PS1) 10Esanders: [BREAKING CHANGE] Refactor for multiple surfaces [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/176952 [17:19:22] (03PS2) 10Esanders: [BREAKING CHANGE] Refactor for multiple surfaces [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/176952 [17:19:25] (03PS1) 10Esanders: Refactor out trigger listening to allow target triggers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/176955 [17:21:11] morning James_F [17:21:30] Heya. [17:21:33] (03CR) 10jenkins-bot: [V: 04-1] Refactor out trigger listening to allow target triggers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/176955 (owner: 10Esanders) [17:21:49] James_F: i went ahead and made RLImageModule work with the standard SvgHandler, and in the process realized that it sucks much more than we thought [17:21:59] James_F: so i filed https://phabricator.wikimedia.org/T76473 and a few dependencies, enjoy [17:21:59] MatmaRex: Oh dear. :-( [17:22:03] * James_F looks. [17:22:24] it mostly works on a standard MW installation now, though. so that's nice. [17:22:36] * James_F nods. [17:23:12] i'm afraid that the dependencies need some intimate knowledge, the fixes seem obvious, but i assume that there's a reason why it's done in the current way :( [17:23:22] 3MediaWiki-ResourceLoader, MediaWiki-File-management: Create a variant of SvgHandler suitable for T76473 - https://phabricator.wikimedia.org/T76477#801944 (10Jdforrester-WMF) [17:23:49] Fun. [17:24:06] I see gi11es triaged https://phabricator.wikimedia.org/T76475 as high/current sprint. [17:24:16] So that should get fixed soon, at least. [17:25:55] 3UI Standardization, MediaWiki-ResourceLoader, MediaWiki-File-management: Create a variant of SvgHandler suitable for T76473 - https://phabricator.wikimedia.org/T76477#801966 (10Jdforrester-WMF) [17:26:59] 3MediaWiki-Interface, UI Standardization, OOjs-UI: Provide the OOUI PHP module inside MW core - https://phabricator.wikimedia.org/T74714#801970 (10Jdforrester-WMF) [17:27:31] 3MediaWiki-Interface, UI Standardization, OOjs-UI: Provide the OOUI PHP module inside MW core - https://phabricator.wikimedia.org/T74714#751656 (10Jdforrester-WMF) [17:27:56] 3UI Standardization, OOjs-UI: OOjs UI: Be able to resurrect OOUI PHP widgets into OOjs UI widgets - https://phabricator.wikimedia.org/T74716#801976 (10Jdforrester-WMF) [17:30:40] Corruption alert: visualeditor-needcheck on cswiki: https://cs.wikipedia.org/?diff=12045625 [17:30:40] Corruption alert: visualeditor-needcheck on nowiki: https://no.wikipedia.org/?diff=13549905 [17:30:40] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=109596757 [17:30:41] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=33487988 [17:30:41] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=33488426 [17:30:41] Corruption alert: visualeditor-needcheck on ptwiki: https://pt.wikipedia.org/?diff=40752090 [17:30:41] Corruption alert: visualeditor-needcheck on ptwiki: https://pt.wikipedia.org/?diff=40752742 [17:30:42] Corruption alert: visualeditor-needcheck on plwiki: https://pl.wikipedia.org/?diff=41102486 [17:30:42] Corruption alert: visualeditor-needcheck on ltwiki: https://lt.wikipedia.org/?diff=4673654 [17:30:43] Corruption alert: visualeditor-needcheck on ltwiki: https://lt.wikipedia.org/?diff=4673655 [17:30:43] Corruption alert: visualeditor-needcheck on dawiki: https://da.wikipedia.org/?diff=7866411 [17:31:40] (03PS3) 10Esanders: [BREAKING CHANGE] Refactor for multiple surfaces [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/176952 [17:31:42] (03PS2) 10Esanders: Refactor out trigger listening to allow target triggers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/176955 [17:34:53] (03CR) 10jenkins-bot: [V: 04-1] Refactor out trigger listening to allow target triggers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/176955 (owner: 10Esanders) [17:41:25] 3VisualEditor-MediaWiki-Media: VisualEditor "basic" image type should be called "inline" - https://phabricator.wikimedia.org/T76460#802000 (10Jdforrester-WMF) 5Open>3declined a:3Jdforrester-WMF No. "Inline" is absolutely not what this sets. MediaWiki's Multimedia support is terrible, but lying to users to... [17:41:30] (03Abandoned) 10Jforrester: Change Basic image type to "Inline" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/176919 (owner: 10Amire80) [17:41:56] 3VisualEditor-MediaWiki, VisualEditor, Verified-in-Phase0: Entering ";" does not trip the wikitext warning that it won't work - https://phabricator.wikimedia.org/T71689#802004 (10Jdforrester-WMF) Indeed. This is intentional. Use of a ":" to "indent a paragraph" (as multiple people who are wikitext experts have c... [17:47:30] James_F: Hi. I'm not sure that I understand your reply on https://phabricator.wikimedia.org/T76460 . [17:47:40] Is it not inline? [17:47:42] aharoni: No. [17:47:51] I must be confused then. [17:47:53] aharoni: The checkbox above this control is what sets block vs. inline. [17:47:59] aharoni: This control sets "type". [17:48:28] I.e. the difference between [[File:Foo.jpg|thumb]] [[File:Foo.jpg|frame]] [[File:Foo.jpg|frameless]] and [[File:Foo.jpg|none]] [17:48:32] 3VisualEditor-EditingTools, VisualEditor-MediaWiki, VisualEditor: [Regression wmf10] Cannot open any inspectors, they just flicker and get closed - https://phabricator.wikimedia.org/T76076#802027 (10zeljkofilipin) [17:48:42] The "inline" state is "[[File:Foo.jpg]]" [17:48:48] [[File:Foo.jpg|none]] !== [[File:Foo.jpg]] [17:48:51] 3VisualEditor, Beta-Cluster: VisualEditor not updating in beta labs - https://phabricator.wikimedia.org/T76097#789475 (10zeljkofilipin) [17:49:00] But "none" is a really stupid label, so with Design we agreed to call them "Basic". [17:49:18] Welcome to MediaWiki's basket-case of bad design and worse naming. [17:50:34] James_F: "The checkbox above this control" - with what label? [17:50:54] 3VisualEditor, Beta-Cluster: VisualEditor not updating in beta labs - https://phabricator.wikimedia.org/T76097#802032 (10hashar) Seems the script python I wrote to update the VisualEditor repo is no more working / choking on something. I haven't noticed this task until it has be pointed to me during the Releng... [17:51:43] aharoni: [17:52:12] aharoni: It defaults to on == block; off == inline. [17:54:10] my mind is totally blown [17:54:20] in a not-so-good way [17:54:23] aharoni: Yeah. :-( [17:54:48] aharoni: One of the big projects on my backlog is "totally re-do how MediaWiki does media transclusion". [17:55:02] aharoni: But it's a post-2020 project at this point. :-( [18:01:30] 3OOjs-UI, MediaWiki-ResourceLoader: Implement ResourceLoader module to ship CSS for sets of SVG+PNG icons to the user - https://phabricator.wikimedia.org/T76473#802052 (10Bawolff) When testing please keep in mind image magick quality varries considerably depending on if it was compiled against rsvg or not. [18:13:07] (03CR) 10Trevor Parscal: [C: 04-1] "I have been aware of this alternative, but it's rather costly. I really was hoping this code would be able to provide an attached and deta" [oojs/ui] - 10https://gerrit.wikimedia.org/r/176681 (owner: 10Prtksxna) [18:16:41] (03CR) 10Trevor Parscal: [C: 032] MessageDialog: Fit actions again when the dialog is resized [oojs/ui] - 10https://gerrit.wikimedia.org/r/175543 (owner: 10Bartosz Dziewoński) [18:17:46] (03CR) 10Trevor Parscal: [C: 032] Window: Avoid height flickering when resizing dialogs [oojs/ui] - 10https://gerrit.wikimedia.org/r/176484 (owner: 10Bartosz Dziewoński) [18:20:09] (03Merged) 10jenkins-bot: Window: Avoid height flickering when resizing dialogs [oojs/ui] - 10https://gerrit.wikimedia.org/r/176484 (owner: 10Bartosz Dziewoński) [18:20:21] James_F: so, you know how rsvg can't handle our icons, and how i have a workaround for that? [18:20:32] (03Merged) 10jenkins-bot: MessageDialog: Fit actions again when the dialog is resized [oojs/ui] - 10https://gerrit.wikimedia.org/r/175543 (owner: 10Bartosz Dziewoński) [18:20:34] MatmaRex: Yes? [18:20:51] James_F: should we apply it in the RL module only, before rasterizing, or as part of the build process, or to the icons in the repo? [18:20:59] files in the repo* [18:21:21] MatmaRex: Hmm. [18:21:56] MatmaRex: Probably we should make the fix in RL. rsvg isn't sufficiently standard that we should code around it in the repo, I feel. [18:21:57] James_F: people are probably going to want to upload these to commons and such, or reuse in other software, or whatever. there was a wikitech-l thread already. (a short one) [18:22:01] MatmaRex: What do you think? [18:22:31] James_F: this is apparently also necessary for imagemagick when compiled with rsvg, or something. [18:22:41] MatmaRex: Oh. Hmm. [18:22:55] MatmaRex: Is "fixing" our SVGs possible without also changing them visually? [18:23:14] James_F: i think it'd be best done as soon as possible. during build, or to the version-controlled files. [18:23:28] the workaround is just a regex replacement which inserts some spaces and zeroes [18:23:40] 3VisualEditor: [Regression pre-wmf11] Cannot edit inserted Formulae - https://phabricator.wikimedia.org/T76507#802076 (10Etonkovidova) [18:23:52] So we could do it to the original files in OOUI, but other users of this facility are screwed? :-( [18:24:19] https://gerrit.wikimedia.org/r/#/c/165922/24/includes/resourceloader/ResourceLoaderImage.php see massageSvgPathdata() function [18:24:30] "facility"? [18:25:27] MatmaRex: People other than OOUI using ResourceLoaderImage. [18:25:35] (in fact, i wouldn't even mind upstreaming the workaround to svgo) [18:26:10] James_F: normal SVG editors don't generate the problematic syntax, as far as i can tell. only svgo and possibly other SVG minifiers, if there are any [18:26:38] MatmaRex: Running SVGO on the repo is quite common, though. [18:26:40] James_F: i mean, would you say that ".123.456" is valid syntax to represent two numbers? me neither, but it is [18:26:50] Maybe upstreaming the fix to svgo would be a good idea too. [18:28:19] 3VisualEditor: [Regression pre-wmf11] Cannot edit inserted Formulae - https://phabricator.wikimedia.org/T76507#802091 (10Etonkovidova) [18:29:22] (03PS11) 10Catrope: Show entire expandable call tree in ve.ui.Filibuster [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167021 (owner: 10Divec) [18:29:30] (03CR) 10Catrope: [C: 032] Show entire expandable call tree in ve.ui.Filibuster [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167021 (owner: 10Divec) [18:33:11] 3VisualEditor-MediaWiki, VisualEditor: [Regression wmf10] Editing a formula causes the inspector to close immediately - https://phabricator.wikimedia.org/T76420#802096 (10Ryasmeen) [18:33:13] 3VisualEditor: [Regression pre-wmf11] Cannot edit inserted Formulae - https://phabricator.wikimedia.org/T76507#802097 (10Ryasmeen) [18:33:33] i'm going to spend a minute over the SVG spec to see if that's actually valid syntax. i'm not sure if it is. [18:33:44] (03CR) 10Catrope: [C: 031] "Let's land this in wmf11" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/171494 (owner: 10Divec) [18:34:45] (03PS1) 10Jforrester: Tag v0.2.4 [oojs/ui] - 10https://gerrit.wikimedia.org/r/176975 [18:35:23] (03PS4) 10Esanders: [BREAKING CHANGE] Refactor for multiple surfaces [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/176952 [18:35:25] (03PS3) 10Esanders: Refactor out trigger listening to allow target triggers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/176955 [18:36:13] (03Merged) 10jenkins-bot: Show entire expandable call tree in ve.ui.Filibuster [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167021 (owner: 10Divec) [18:38:41] (03CR) 10Jforrester: "…he means wmf12. ;-)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/171494 (owner: 10Divec) [18:38:51] (03CR) 10jenkins-bot: [V: 04-1] Refactor out trigger listening to allow target triggers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/176955 (owner: 10Esanders) [18:39:44] edsanders: Could you +2 https://gerrit.wikimedia.org/r/#/c/176975/ please? [18:40:42] 3VisualEditor-MediaWiki, VisualEditor: [Regression wmf10] Editing a formula causes the inspector to close immediately - https://phabricator.wikimedia.org/T76420#802105 (10Ryasmeen) 5duplicate>3Open [18:40:43] 3VisualEditor, OOjs-UI: [Regression 0.2.3] While switching dialog sizes, the window opens with an animation from bottom - https://phabricator.wikimedia.org/T76371#802104 (10Jdforrester-WMF) 5Open>3Resolved [18:41:16] 3OOjs-UI: Scrolling elements into view does not work in most cases - https://phabricator.wikimedia.org/T73609#802107 (10Jdforrester-WMF) [18:41:30] 3VisualEditor: [Regression pre-wmf11] Cannot edit inserted Formulae - https://phabricator.wikimedia.org/T76507#802109 (10Ryasmeen) [18:41:33] 3VisualEditor-MediaWiki, VisualEditor: [Regression wmf10] Editing a formula causes the inspector to close immediately - https://phabricator.wikimedia.org/T76420#799922 (10Ryasmeen) [18:41:34] 3VisualEditor, OOjs-UI: [Regression 0.2.3] While switching dialog sizes, the window opens with an animation from bottom - https://phabricator.wikimedia.org/T76371#798936 (10Jdforrester-WMF) [18:43:34] 3VisualEditor: VisualEditor page options menu goes off-screen in RTL wikis - https://phabricator.wikimedia.org/T76474#802113 (10Jdforrester-WMF) p:5Triage>3High [18:44:17] (03CR) 10Esanders: [C: 032] Tag v0.2.4 [oojs/ui] - 10https://gerrit.wikimedia.org/r/176975 (owner: 10Jforrester) [18:44:21] (03Merged) 10jenkins-bot: Tag v0.2.4 [oojs/ui] - 10https://gerrit.wikimedia.org/r/176975 (owner: 10Jforrester) [18:44:36] Thanks edsanders! [18:45:06] James_F: https://phabricator.wikimedia.org/T73609 is not quite resolved yet, not merged. [18:45:29] 3VisualEditor-EditingTools, VisualEditor-MediaWiki, VisualEditor: [Regression wmf10] Cannot open any inspectors, they just flicker and get closed - https://phabricator.wikimedia.org/T76076#802117 (10Ryasmeen) [18:45:44] 3VisualEditor-EditingTools, VisualEditor-MediaWiki, VisualEditor: [Regression wmf10] Cannot open any inspectors, they just flicker and get closed - https://phabricator.wikimedia.org/T76076#802119 (10Ryasmeen) 5Resolved>3Open [18:46:08] MatmaRex: Whoops, yes, I meant https://phabricator.wikimedia.org/T75783 [18:46:26] 3OOjs-UI: MessageDialog does not re-fit actions on dialog resize - https://phabricator.wikimedia.org/T75783#802120 (10Jdforrester-WMF) 5Open>3Resolved [18:46:42] 3OOjs-UI: Scrolling elements into view does not work in most cases - https://phabricator.wikimedia.org/T73609#802129 (10Jdforrester-WMF) 5Resolved>3Open [18:48:59] [13oojs.github.io] 15jdforrester created 06oojs-ui.2.4 (+1 new commit): 02https://github.com/oojs/oojs.github.io/commit/7635af8accb9 [18:49:00] 13oojs.github.io/06oojs-ui.2.4 147635af8 15James D. Forrester: Add OOjs UI 0.2.4 release from npm [18:56:24] 3VisualEditor: [Regression pre-wmf11] Cannot edit inserted Formulae - https://phabricator.wikimedia.org/T76507#802147 (10Jdforrester-WMF) [18:56:25] 3VisualEditor-MediaWiki, VisualEditor: [Regression wmf10] Editing a formula causes the inspector to close immediately - https://phabricator.wikimedia.org/T76420#802146 (10Jdforrester-WMF) [18:56:28] 3VisualEditor-EditingTools, VisualEditor-MediaWiki, VisualEditor: [Regression wmf10] Cannot open any inspectors, they just flicker and get closed - https://phabricator.wikimedia.org/T76076#802148 (10Jdforrester-WMF) [18:56:58] 3VisualEditor-EditingTools, VisualEditor-MediaWiki, VisualEditor: [Regression wmf10] Cannot open any inspectors, they just flicker and get closed - https://phabricator.wikimedia.org/T76076#789107 (10Jdforrester-WMF) [19:06:09] (03PS1) 10Jforrester: Update OOjs UI to v0.2.4 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/176986 [19:12:33] 3VisualEditor-EditingTools, VisualEditor-MediaWiki, VisualEditor: [Regression wmf10] Cannot open any inspectors, they just flicker and get closed - https://phabricator.wikimedia.org/T76076#802171 (10Jdforrester-WMF) [19:26:50] (03PS33) 10Divec: Use a chimera instead of  in inline slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151046 (owner: 10Catrope) [19:28:31] 3VisualEditor-EditingTools, VisualEditor-MediaWiki, VisualEditor: [Regression wmf10] Cannot open any inspectors, they just flicker and get closed - https://phabricator.wikimedia.org/T76076#802197 (10Esanders) Definitely fixed in master. Probably has pulled through to beta labs. [19:47:21] James_F: Oh, right. We were working on oojs-ui on oojs.github.io [19:47:27] * Krinkle makes note [20:12:53] (03PS10) 10Mooeypoo: [WIP] Transform the search widget to show image details [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161342 [20:15:56] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Transform the search widget to show image details [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161342 (owner: 10Mooeypoo) [20:28:35] is there somewhere a task on Phab for https://fi.wikipedia.org/w/index.php?title=Resedakasvit&curid=1206202&diff=14486819&oldid=14470967 (the template thing) [20:32:51] 3VisualEditor, Beta-Cluster: VisualEditor not updating in beta labs - https://phabricator.wikimedia.org/T76097#802330 (10hashar) 5Open>3Resolved a:3hashar Seems there was some transient error that prevented Gerrit to merge the bot change automatically. Apparently due to some merge conflict. I am not sure... [20:39:56] 3VisualEditor-EditingTools, VisualEditor-MediaWiki, VisualEditor: [Regression wmf10] Cannot open any inspectors, they just flicker and get closed - https://phabricator.wikimedia.org/T76076#802351 (10Ryasmeen) [20:47:37] 3VisualEditor-EditingTools, VisualEditor-MediaWiki, VisualEditor: [Regression wmf10] Cannot open any inspectors, they just flicker and get closed - https://phabricator.wikimedia.org/T76076#802371 (10Ryasmeen) [20:54:00] 3MediaWiki-extensions-WikiEditor: Hide signature button from WikiEditor toolbar in content namespaces - https://phabricator.wikimedia.org/T59727#802375 (10Jdforrester-WMF) [20:54:04] 3MediaWiki-extensions-WikiEditor: WikiEditor: Add SVG versions of editing toolbar icons - https://phabricator.wikimedia.org/T37342#802376 (10Jdforrester-WMF) [21:06:07] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: Searching for a page name that starts with http://whatever... is kind of silly - https://phabricator.wikimedia.org/T71500#802401 (10Krenair) >>! In T71500#749617, @Krenair wrote: > Interesting that MediaWiki allows you to create pages that are URLs, but yo... [21:07:24] 3VisualEditor, VisualEditor-EditingTools: Auto-filled references based on destination URL / ISBN / etc. - https://phabricator.wikimedia.org/T62768#802402 (10KHammerstein) {F18007} {F18009} {F18010} [21:07:27] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: When inserting valid internal links that look like URLs, we need to use the ':' prefix - https://phabricator.wikimedia.org/T71500#802403 (10Krenair) [21:09:18] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: When inserting valid internal links that look like URLs, we need to use the ':' prefix - https://phabricator.wikimedia.org/T71500#749597 (10Krenair) See also {T76398} [21:11:06] 3MediaWiki-extensions-WikiEditor: When dialog to insert an image is invoked on a selection, prefill the fields accordingly - https://phabricator.wikimedia.org/T40829#802416 (10Jdforrester-WMF) p:5Normal>3Low [21:12:30] 3MediaWiki-extensions-WikiEditor: Editing toolbar fails to work on new section "subject line" text box - https://phabricator.wikimedia.org/T37159#802418 (10Jdforrester-WMF) [21:13:49] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: Improvements and behaviour changes to the link input widget (tracking) - https://phabricator.wikimedia.org/T50789#802420 (10Krenair) [21:14:07] 3MediaWiki-extensions-TemplateData: TemplateData: Import parameters message should rendere as "success" not "error" in the GUI editor - https://phabricator.wikimedia.org/T73077#802422 (10Jdforrester-WMF) [21:14:10] 3MediaWiki-extensions-TemplateData: TemplateData: "Required" and "Suggested" label should not wrap in the GUI editor - https://phabricator.wikimedia.org/T73078#802424 (10Jdforrester-WMF) [21:15:05] 3VisualEditor, VisualEditor-EditingTools: Auto-filled references based on destination URL / ISBN / etc. - https://phabricator.wikimedia.org/T62768#802427 (10KHammerstein) [21:16:11] 3MediaWiki-extensions-TemplateData: TemplateData: Provide property "example" for template parameters - https://phabricator.wikimedia.org/T53049#802432 (10Jdforrester-WMF) p:5High>3Normal [21:16:32] 3MediaWiki-extensions-TemplateData: TemplateData: Add parameter type for url - https://phabricator.wikimedia.org/T54880#802435 (10Jdforrester-WMF) p:5High>3Normal [21:16:49] 3MediaWiki-extensions-TemplateData: TemplateData: Localise names of types in the HTML rendering (string, wiki-page-name, ...) - https://phabricator.wikimedia.org/T61745#802438 (10Jdforrester-WMF) [21:16:57] 3MediaWiki-extensions-TemplateData: TemplateData: Have the GUI editor warn the user if a related page already contains a TemplateData block - https://phabricator.wikimedia.org/T74062#802440 (10Jdforrester-WMF) [21:21:55] 3Parsoid, VisualEditor, VisualEditor-EditingTools: When the user adds an internal link that looks like a URL, Parsoid needs to insert a ':' prefix for it to work - https://phabricator.wikimedia.org/T71500#802446 (10Jdforrester-WMF) [21:22:30] 3Parsoid, VisualEditor, VisualEditor-EditingTools: When the user adds an internal link that looks like a URL, Parsoid needs to insert a ':' prefix for it to work - https://phabricator.wikimedia.org/T71500#749597 (10Jdforrester-WMF) [21:24:20] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: Link input widget should recognise input text that look like urls without protocol as external links (e.g. "www.example.org/foo") - https://phabricator.wikimedia.org/T52360#802451 (10Krenair) >>! In T52360#542816, @Krinkle wrote: > We solved this to some de... [21:26:09] 3Parsoid, VisualEditor, VisualEditor-EditingTools: When the user adds an internal link that looks like a URL, MediaWiki needs to insert a ':' prefix for it to work - https://phabricator.wikimedia.org/T71500#802453 (10Krenair) [21:29:01] 3VisualEditor-Tables, VisualEditor, VisualEditor-EditingTools: VisualEditor: "Insert table" tool should be (also?) in the "Table" menu, not (or in addition to?) "Insert" menu - https://phabricator.wikimedia.org/T75212#802455 (10Krenair) [21:30:23] 3VisualEditor, VisualEditor-MediaWiki-Links: Change the link inspector menu widget to show information about the target in a bigger format - https://phabricator.wikimedia.org/T76399#802460 (10Krenair) [21:30:50] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: Improvements and behaviour changes to the link input widget (tracking) - https://phabricator.wikimedia.org/T50789#802462 (10Krenair) [21:31:10] James_F: something's broken in some VE edits on pl.wp recently. not sure if VE or parsoid. https://pl.wikipedia.org/w/index.php?title=Banshee&diff=prev&oldid=41106789 https://pl.wikipedia.org/w/index.php?title=%C5%9Aci%C4%85ga&diff=prev&oldid=41106792 [21:31:28] the latter canonicalized all link targets on the entire page [21:31:34] the former expanded a template in the lead [21:31:58] cc TarLocesilion ^ [21:32:53] 3VisualEditor, VisualEditor-EditingTools: Blockquotes aren't ContentBranchNodes in reality, and our code shouldn't try to insist that they are - https://phabricator.wikimedia.org/T76426#802463 (10Krenair) [21:38:21] 3VisualEditor: VisualEditor: Performance issues (tracker) - https://phabricator.wikimedia.org/T51685#802467 (10Jdforrester-WMF) [21:38:49] 3VisualEditor, VisualEditor-Performance: VisualEditor: Performance issues (tracker) - https://phabricator.wikimedia.org/T51685#802468 (10Jdforrester-WMF) [21:39:00] MatmaRex, are you aware of a task about Phabricator only listing the first few project suggestions? [21:39:22] Krenair: don't know of any, no. [21:39:25] 3VisualEditor-DataModel, Parsoid, VisualEditor, VisualEditor-Performance: When saving a page, only send back to Parsoid the parts of the page that have been changed - https://phabricator.wikimedia.org/T70042#802473 (10Jdforrester-WMF) [21:39:36] (it lists five.) [21:39:46] (that might be configurable somewhere) [21:39:58] 3VisualEditor, VisualEditor-MediaWiki, VisualEditor-Performance: VE page save time at 75th percentile up 70% from February - https://phabricator.wikimedia.org/T66171#802477 (10Jdforrester-WMF) [21:40:36] 3VisualEditor-TechnicalDebt, VisualEditor, VisualEditor-Performance: Reduce number of load.php calls on VisualEditor open (down from 3) - https://phabricator.wikimedia.org/T53569#802480 (10Jdforrester-WMF) [21:40:55] 3VisualEditor-Initialisation, VisualEditor, VisualEditor-Performance: Pre-fetch VisualEditor modules to improve speed for end-users - https://phabricator.wikimedia.org/T59952#802483 (10Jdforrester-WMF) [21:41:14] 3VisualEditor-Performance, VisualEditor, VisualEditor-EditingTools: On VisualEditor load, async pre-load all the TemplateData for the page to make editing templates speedier - https://phabricator.wikimedia.org/T66772#802486 (10Jdforrester-WMF) [21:45:56] 3OOjs-UI: OOjs UI: Move transition timings in theme specific files - https://phabricator.wikimedia.org/T67254#802489 (10Catrope) An alternative idea we had a while ago was to use ``` $foo.css('transition-duration') ``` to measure the transition duration. But using a config file feels more reliable to me. [21:46:16] James_F, https://phabricator.wikimedia.org/T76398 is interesting and would solve a couple of annoying issues I mentioned it on. I assume from the lack of assignee, nobody is working on it yet? [21:46:59] (03PS34) 10Catrope: Use a chimera instead of  in inline slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151046 [21:47:41] (03CR) 10Catrope: [C: 032] ViewPageTarget.init: Correct docs: ve.libs.mw → mw.libs.ve [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/176729 (owner: 10Bartosz Dziewoński) [21:47:45] ("solve" meaning "transfers responsibility to the user", but I think it's reasonable) [21:48:59] James_F: hey! [21:49:47] James_F: On phabricator it seems the easiest way to show a whole flow is uploading several images to one mock https://phabricator.wikimedia.org/M13 [21:50:14] (03Merged) 10jenkins-bot: ViewPageTarget.init: Correct docs: ve.libs.mw → mw.libs.ve [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/176729 (owner: 10Bartosz Dziewoński) [21:50:38] James_F: then if you scroll down to Mock History you can click the thumbs to go to the next image [21:50:39] MatmaRex, it should be able to scroll through all matches, not have a configurable cut-off point :/ [21:51:23] James_F: easier than clicking back and forth back to the task [21:51:32] Krenair: (as far as i can tell it isn't actually configurable for end-user, or site admin, either) [21:51:37] Im just not sure if commenting works on each mock if I do it this way? [21:51:47] Krenair: (there's a default of `maximumResultCount : 5,` set in one file and nothing seems to be overriding it) [21:52:24] James_F: Did anybody complain about the Table button being active only inside tables? [21:52:43] It makes sense to have it add a table. [21:53:27] aharoni: yes, i did. :) [21:53:43] Good :) [21:54:07] Somebody just complained in the Hebrew Wikipedia that "the new table tool doesn't actually work". [21:54:44] 3VisualEditor-MediaWiki, VisualEditor, VisualEditor-Performance: For very large pages on slow connections (when a timeout happens?), users get an "Error: Unknown error" on saving changes in VisualEditor (but change is indeed saved) - https://phabricator.wikimedia.org/T55093#802498 (10Jdforrester-WMF) [21:54:52] aharoni: https://phabricator.wikimedia.org/T75212#802455 [21:54:58] 3VisualEditor, VisualEditor-ContentEditable, VisualEditor-Performance: VisualEditor: Draw highlights using SVG polygons - https://phabricator.wikimedia.org/T53202#802501 (10Jdforrester-WMF) [21:55:43] 3VisualEditor, VisualEditor-ContentEditable, VisualEditor-Performance: Draw VisualEditor's non-CE block highlights using SVG polygons - https://phabricator.wikimedia.org/T53202#802505 (10Jdforrester-WMF) [21:56:14] 3VisualEditor-Performance, VisualEditor, VisualEditor-MediaWiki-Mobile: Improve VisualEditor's performance on tablet devices - https://phabricator.wikimedia.org/T64755#802506 (10Jdforrester-WMF) [21:56:46] 3VisualEditor-Initialisation, VisualEditor, VisualEditor-Performance: Improve VisualEditor's loading performance in Firefox - https://phabricator.wikimedia.org/T52616#802509 (10Jdforrester-WMF) [21:57:18] 3VisualEditor-TechnicalDebt, VisualEditor, VisualEditor-Performance: Explore peformance gains from progressive de-alienation in VisualEditor - https://phabricator.wikimedia.org/T54365#802517 (10Jdforrester-WMF) [21:58:11] 3VisualEditor-Initialisation, VisualEditor-MediaWiki, VisualEditor, VisualEditor-Performance: Lazy load extensions' large resources in VisualEditor, rather than blocking load - https://phabricator.wikimedia.org/T55826#802527 (10Jdforrester-WMF) [21:58:36] 3VisualEditor-DataModel, VisualEditor, VisualEditor-Performance: Reduce VisualEditor's memory usage - https://phabricator.wikimedia.org/T55825#802533 (10Jdforrester-WMF) [22:00:11] 3VisualEditor-MediaWiki, VisualEditor, VisualEditor-Performance: Add a notice on load for users of slower computers advising them to use source mode instead of VisualEditor - https://phabricator.wikimedia.org/T52518#802537 (10Jdforrester-WMF) [22:01:10] MatmaRex, Chase pointed me to it - https://phabricator.wikimedia.org/T75737 [22:01:17] 3VisualEditor-MediaWiki, VisualEditor, VisualEditor-Performance: Support editing parts of a page in VisualEditor - https://phabricator.wikimedia.org/T50429#802541 (10Jdforrester-WMF) [22:02:51] (03PS1) 10Catrope: Make LinkCache fail more gracefully when given undefined [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/177086 [22:04:50] 3Parsoid, VisualEditor-Performance: Move data-parsoid and possibly data-mw out of the DOM, add uids - https://phabricator.wikimedia.org/T54936#802550 (10Jdforrester-WMF) [22:08:55] 3VisualEditor, VisualEditor-Performance: Show the VisualEditor toolbar/editor chrome immediately after the user clicks "edit", rather than blocking on waiting for the content to load - https://phabricator.wikimedia.org/T76523 (10Jdforrester-WMF) 3NEW p:3High [22:09:44] 3VisualEditor, VisualEditor-Performance: Instrument how quickly after load users make their first keyboard interaction (first keyDown?) - https://phabricator.wikimedia.org/T76524 (10Jdforrester-WMF) 3NEW p:3High a:3Catrope [22:09:52] 3VisualEditor, VisualEditor-MediaWiki, VisualEditor-Performance: VE page save time at 75th percentile up 70% from February - https://phabricator.wikimedia.org/T66171#802581 (10Jdforrester-WMF) [22:12:04] Krenair: https://phabricator.wikimedia.org/T76398 is assigned to Sucheta, but she doesn't have a Phabricator account yet. :-( [22:12:13] kaity: Hey. [22:12:26] kaity: https://phabricator.wikimedia.org/M13 looks good. Nice! [22:13:01] Oh, ok [22:13:38] aharoni: Yes, the current table editing interface is not ideal and is on the list to be fixed. [22:13:56] James_F: cool [22:14:33] Having the Tab key do what it does in other word processors would be my favorite addition. [22:14:39] move between cells and add rows [22:16:06] 3MediaWiki-extensions-WikiEditor: Dialog allows to insert invalid urls - https://phabricator.wikimedia.org/T30789#802596 (10Jdforrester-WMF) [22:16:17] Oh yeah, we need to make the Tab key do ... well anything but what it does now, really [22:16:37] RoanKattouw: https://phabricator.wikimedia.org/T72665 [22:16:48] Nice [22:19:44] Oh, and by the way, about https://gerrit.wikimedia.org/r/#/c/174666/ [22:19:50] (03CR) 10Jforrester: [C: 031] Make LinkCache fail more gracefully when given undefined [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/177086 (owner: 10Catrope) [22:19:53] RoanKattouw, James_F - is it really that bad? [22:20:02] (03CR) 10Catrope: [C: 032] "Hmm, this looks fine, but shouldn't the URL decode step happen inside of getTargetDataFromHref()?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/176857 (owner: 10Alex Monk) [22:20:15] does adding classes affect performance? [22:20:17] aharoni: Trevor is the one to talk to about OOUI structural stuff. [22:20:33] I guessed so... is he around? [22:20:35] aharoni: And yes, every line of code slows performance down. It needs to justify itself. [22:20:40] aharoni: No, he's ill. :-( [22:20:46] Oh. [22:20:52] I'll wait patiently then. [22:21:32] * James_F nods. [22:22:17] (03Merged) 10jenkins-bot: Handle encoding of links in transclusion nodes properly when determining existence [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/176857 (owner: 10Alex Monk) [22:22:27] Your patch isn't too bad in my opinion, but as pointed out in the task this is a general problem, and I'd like us to come up with a general solution rather than sprinkling some classes around in some of the config objects [22:25:21] 3VisualEditor, VisualEditor-Performance: Instrument how quickly after load users make their first keyboard interaction (first keyDown?) - https://phabricator.wikimedia.org/T76524#802623 (10Jdforrester-WMF) [22:25:26] 3VisualEditor, VisualEditor-Performance: Show the VisualEditor toolbar/editor chrome immediately after the user clicks "edit", rather than blocking on waiting for the content to load - https://phabricator.wikimedia.org/T76523#802624 (10Jdforrester-WMF) [22:26:04] 3VisualEditor, VisualEditor-MediaWiki-Links: If there is a page with the exact name, it should appear first in the link auto-complete list - https://phabricator.wikimedia.org/T71780#802626 (10Jdforrester-WMF) p:5Triage>3Normal [22:26:09] 3VisualEditor, VisualEditor-MediaWiki-Links: If there is a page with the exact name, it should appear first in the link auto-complete list - https://phabricator.wikimedia.org/T71780#717321 (10Jdforrester-WMF) [22:27:51] 3VisualEditor-MediaWiki, VisualEditor, VisualEditor-Performance: LinkCache sends API requests for URL-encoded page names, gets "invalid" responses back when descending into template contents - https://phabricator.wikimedia.org/T75823#802632 (10Krenair) 5Open>3Resolved [22:34:02] 3VisualEditor, VisualEditor-EditingTools: Convert hyphens to en dashes when written in VisualEditor - https://phabricator.wikimedia.org/T76275#802653 (10Juandev) [22:40:01] 3VisualEditor, VisualEditor-EditingTools: Convert hyphens to en dashes when written in VisualEditor - https://phabricator.wikimedia.org/T76275#802670 (10Jdforrester-WMF) [22:43:28] (03CR) 10Alex Monk: [C: 032] Make LinkCache fail more gracefully when given undefined [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/177086 (owner: 10Catrope) [22:45:11] (03Merged) 10jenkins-bot: Make LinkCache fail more gracefully when given undefined [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/177086 (owner: 10Catrope) [22:50:59] (03PS3) 10Ryasmeen: [Browsertest]Tests for options under Advanced Settings panel [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175589 [22:54:37] (03PS4) 10Ryasmeen: [Browsertest]Tests for options under Advanced Settings panel [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175589 [22:57:06] 3MediaWiki-skins-MonoBook, VisualEditor-MediaWiki, VisualEditor, OOjs-UI: Cancel button does not work for Insert-Template and some Cite options in VisualEditor in Monobook - https://phabricator.wikimedia.org/T75802#802690 (10Etonkovidova) 5Open>3Resolved [22:59:05] 3MediaWiki-skins-MonoBook, VisualEditor-MediaWiki, VisualEditor: Monobook: extremely small font in Insert-Template and Cite options dialog boxes - https://phabricator.wikimedia.org/T75800#802691 (10Etonkovidova) 5Open>3Resolved [22:59:43] 3MediaWiki-skins-MonoBook, VisualEditor-MediaWiki, VisualEditor, OOjs-UI: Cancel button does not work for Insert-Template and some Cite options in VisualEditor in Monobook - https://phabricator.wikimedia.org/T75802#802692 (10Jdforrester-WMF) a:3Krenair [22:59:55] 3MediaWiki-skins-MonoBook, VisualEditor-MediaWiki, VisualEditor: Monobook: extremely small font in Insert-Template and Cite options dialog boxes - https://phabricator.wikimedia.org/T75800#802694 (10Jdforrester-WMF) [23:00:47] (03PS5) 10Ryasmeen: [Browsertest]Tests for options under Advanced Settings panel [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175589 [23:01:29] (03CR) 10Cmcmahon: [C: 032] "paired with Rummana" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175589 (owner: 10Ryasmeen) [23:03:39] (03Merged) 10jenkins-bot: [Browsertest]Tests for options under Advanced Settings panel [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175589 (owner: 10Ryasmeen) [23:08:53] eh. The new display of media results works now, but it is slower. Meh. [23:09:54] RoanKattouw, I don't know if you remember when you were here, we were talking about this. I am doing all the splitting/rows after the results are displayed, so it takes a bit longer now... ideally, I think this should be done in the GroupElement level, when items are added? Not sure. [23:11:03] It won't be pretty, but the current operation displays results a tad slower than before. I'm also not sure if it has to do with the way I rebuilt the thumbnails, since if you search something again the rows are destroed and then are refilled and that is faster. [23:15:18] Hmm [23:15:21] Is this code in Gerrit? [23:18:23] mooeypoo: If you could point me to this code in Gerrit, then I could take a look at it and do some profiling [23:20:04] mvolz, I am unsure how you're getting TypeError: undefined is not a function? [23:21:33] RoanKattouw, give me a sec and I'll push the updated one [23:21:36] OK [23:22:25] (03PS11) 10Mooeypoo: [WIP] Transform the search widget to show image details [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161342 [23:22:28] RoanKattouw, ^^ [23:22:50] RoanKattouw, before you try this, try the media search *without* the patch [23:22:53] it takes a little bit now too [23:23:20] I just think it takes a little longer with mine. But it seems to take longer the first search, and then subsequent search feels shorter to me, but I didn't quantify it. [23:23:56] Yeah, when I reopen the dialog now again it's pretty quick [23:24:23] James_F, I fixed https://phabricator.wikimedia.org/T75802 ? [23:25:20] (03PS1) 10Catrope: Reduce complexity around onbeforeunload handler [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/177107 [23:25:48] Sounds like that was probably me? [23:29:51] (03PS5) 10Esanders: [BREAKING CHANGE] Refactor for multiple surfaces [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/176952 [23:29:53] (03PS4) 10Esanders: Refactor out trigger listening to allow target triggers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/176955 [23:29:55] (03PS1) 10Esanders: [BREAKING CHANGE] Multiple surface support and demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177109 [23:32:51] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Multiple surface support and demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177109 (owner: 10Esanders) [23:33:26] Krenair: Didn't you fix the Monobook layout issues? [23:33:39] Krenair: The cancel button not working was releated. [23:33:53] yes [23:33:57] oh, ok.. [23:34:02] I wasn't aware of that [23:34:30] Neither was I until Elena told me. :-) [23:52:47] (03PS1) 10Prtksxna: Run 'quick-build' instead of 'build' from watch [oojs/ui] - 10https://gerrit.wikimedia.org/r/177125 [23:55:26] (03PS2) 10Jforrester: build: Have grunt watch run 'quick-build' instead of 'build' [oojs/ui] - 10https://gerrit.wikimedia.org/r/177125 (owner: 10Prtksxna) [23:55:34] (03CR) 10Jforrester: [C: 031] build: Have grunt watch run 'quick-build' instead of 'build' [oojs/ui] - 10https://gerrit.wikimedia.org/r/177125 (owner: 10Prtksxna) [23:55:52] 3Verified-in-Phase0, VisualEditor-EditingTools, VisualEditor-MediaWiki, VisualEditor: [Regression wmf10] Cannot open any inspectors, they just flicker and get closed - https://phabricator.wikimedia.org/T76076#802770 (10Ryasmeen) [23:56:04] 3Verified-in-Phase0, VisualEditor-EditingTools, VisualEditor-MediaWiki, VisualEditor: [Regression wmf10] Cannot open any inspectors, they just flicker and get closed - https://phabricator.wikimedia.org/T76076#789107 (10Ryasmeen) Verified in test2