[00:00:13] so, what I'm after is some generalized theory of naming methods that return promises [00:00:34] OK [00:00:44] TrevorParscal: BTW this is your regularly scheduled reminder that there's oojs-ui code awaiting your review [00:00:55] TrevorParscal: And we want to make the cut tonight. :-) [00:01:09] for instance: they should be verbs, simpler is better, and not start with "get" or an "is"-like word [00:01:21] will peek [00:01:45] TrevorParscal: PromiseMe() [00:02:05] willBeValid() ? [00:02:05] TrevorParscal: promiseMeIsValid() [00:02:15] TrevorParscal: promiseMeDestruction() [00:02:23] TrevorParscal: promiseMySettings() [00:02:26] TrevorParscal: It's perfect! [00:02:32] I'm not a fan of hungarian notation in general, but I do fine that a P suffix is short and to-the-point. [00:02:54] cscott: i love your future tense [00:02:56] lol [00:03:09] willSomedayMaybeBeValidDependingOnVariousFactors() [00:03:11] Hey Krinkle. [00:03:20] TrevorParscal: …OrNot [00:03:21] iWillSomedayTellYouIfImValid() [00:04:01] validateEventually() [00:04:09] O.O [00:04:14] TrevorParscal: Eww. [00:04:31] TrevorParscal: promiseValidation() [00:04:48] (03CR) 10Trevor Parscal: [C: 032] Remove window even if closing promise rejects [oojs/ui] - 10https://gerrit.wikimedia.org/r/177406 (owner: 10Esanders) [00:05:35] Personally, I think that methods called validate() or activate() or whatever can return promises (or not), and I think that's fine. We do have return type docs. As long as we don't have methods with very specific naming patterns like isSomething() or getSomething() return promises [00:06:19] So I don't think we necessarily need a naming convention for functions that return promises, as long as those stay out of the way of naming conventions that imply something else [00:07:24] (03Merged) 10jenkins-bot: Remove window even if closing promise rejects [oojs/ui] - 10https://gerrit.wikimedia.org/r/177406 (owner: 10Esanders) [00:07:36] 3MediaWiki-extensions-WikiEditor: wikiEditor "replace" borked - https://phabricator.wikimedia.org/T76750#820129 (10Aklapper) Which browser and version is this about? Always welcome when filing WikiEditor bugs. See also the [[ https://phabricator.wikimedia.org/maniphest/query/Cta5KPc9bHZw/#R | list of issues in W... [00:08:27] 3VisualEditor, VisualEditor-MediaWiki-Mobile: [Regression wmf11] VE is not opening in mobile - https://phabricator.wikimedia.org/T76660#820131 (10Jdforrester-WMF) [00:09:07] so, https://gerrit.wikimedia.org/r/#/c/176666 still doesn't cache the result of which to use for scrolling [00:09:14] and it's suggested (rightly) that it should [00:09:23] where are we at on this? [00:09:43] TrevorParscal: Is this something that only varies by browser? [00:09:59] yes [00:10:00] OK [00:10:08] Then the result of the feature detection must be cached [00:10:13] well, I'm wondering if we could be ticked in certain circumstances [00:10:27] I'm feeling like this needs more time, moving on [00:10:33] The traditional pattern for this in VE is to write a function that returns a boolean and caches its return value somewhere [00:10:53] Assuming that you can identify one behavior as the compliant one and the other as the deviant one [00:10:56] bah, i should have replied there [00:11:16] (03CR) 10Trevor Parscal: [C: 032] TextInputWidget: Reuse a single clone instead of appending and removing new ones [oojs/ui] - 10https://gerrit.wikimedia.org/r/176476 (owner: 10Prtksxna) [00:11:17] Cause then you can name your function isFooBroken() like VE's feature detection functions [00:11:52] TrevorParscal: Also that feature detection code looks scary because it potentially scrolls the body [00:12:06] RoanKattouw: yeah, I'm not ready to sign off on that man [00:12:17] we should -1 it for now, it needs more scrutiny [00:12:35] I would much rather that any time we try to scroll the body, we also scroll the documentElement [00:12:38] RoanKattouw: we can probably just lazy-initialize that. [00:13:01] RoanKattouw: the first time the function is called, try scrolling the body by the appropriate amount; if it fails, then we know not to try scrolling the body anymore [00:13:04] That doesn't fit neatly in the current pattern of the code that expects you to return a single HTMLElement to scorll, but I think it's a safer approach [00:13:12] (03CR) 10Trevor Parscal: [C: 04-1] "Needs to cache the value, and I'm also suspicious that if conditions were to change between calls you might get a different result even on" [oojs/ui] - 10https://gerrit.wikimedia.org/r/176666 (owner: 10Prtksxna) [00:13:21] Oh yeah that's even better [00:13:43] But in any case it means that we can't quite have the level of separation between determining what to scroll and scrolling it that we have now [00:13:46] (03Merged) 10jenkins-bot: TextInputWidget: Reuse a single clone instead of appending and removing new ones [oojs/ui] - 10https://gerrit.wikimedia.org/r/176476 (owner: 10Prtksxna) [00:14:08] it's a good thing browsers are so consistent [00:14:28] so glad we don't have to deal with divergent implementations of simple things, like scrolling the page [00:14:37] c'mon! [00:15:17] RoanKattouw: OOjs UI has no unmerged mergable patches [00:15:26] TrevorParscal: OK, thanks! [00:15:40] see: http://etherpad.wikimedia.org/p/OOjsUI-TODO [00:16:28] esp. setOutlineItem (should be used internally only) being used instead of setupOutlineItem (recommended, public) in subclasses of PageLayout [00:17:58] TrevorParscal: Awesome, thanks man [00:18:41] MatmaRex: see those todo's? that's from kirstenMA's documentation work exposing nasty inconsistencies [00:19:27] TrevorParscal: nice [00:20:34] yeah, as she's been learning the library, she's been going through the documentation (JSDUCK output) class by class [00:21:04] i'm off for today, sorry; if you want me to do stuff, please assign to me; if you don't, i heard that we had quite a bit of ooui backlog tasks filed recently ;), so i'll get at that [00:21:07] and I keep finding things that don't belong, because she will ask things like "so, i noticed that the icon option to StackLayout doesn't seem to do anything" [00:21:08] lol [00:21:15] heh [00:21:24] MatmaRex: awseome [00:21:26] have a good night man [00:21:35] or... morning really [00:22:38] night [00:23:02] 3VisualEditor: Find field - NaN is displayed - https://phabricator.wikimedia.org/T76811#820163 (10Etonkovidova) [00:28:43] 3VisualEditor: Find field - NaN is displayed - https://phabricator.wikimedia.org/T76811#820177 (10Catrope) a:3Esanders [00:29:51] Krinkle: https://gerrit.wikimedia.org/r/#/c/177468 [00:30:00] (03PS1) 10Jforrester: Tag v0.3.0 [oojs/ui] - 10https://gerrit.wikimedia.org/r/177705 [00:30:08] TrevorParscal: https://gerrit.wikimedia.org/r/177705 please? :-) [00:30:14] TrevorParscal: Yay for first breaking-change release. [00:38:07] meh. [00:38:09] meeeeeh. [00:38:54] Users need to be more consistent when filling up fields so when I read them from the API they don't mess everything up by being junk-fields. [00:39:22] Just saying. [00:47:56] (03CR) 10Trevor Parscal: [C: 032] Tag v0.3.0 [oojs/ui] - 10https://gerrit.wikimedia.org/r/177705 (owner: 10Jforrester) [00:48:02] Thanks TrevorParscal. [00:48:38] we are leaving in a few [00:48:45] will let you know when we are about to park [00:50:07] (03Merged) 10jenkins-bot: Tag v0.3.0 [oojs/ui] - 10https://gerrit.wikimedia.org/r/177705 (owner: 10Jforrester) [00:50:44] TrevorParscal: Umm. I'm in meetings 'til at least 18:00. Can you wait a bit? [00:56:02] (03PS1) 10Jforrester: Update OOjs UI to v0.3.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177721 [00:56:11] RoanKattouw: https://gerrit.wikimedia.org/r/177720 and https://gerrit.wikimedia.org/r/177721 [00:58:10] 3OOjs-UI: clearWindows() is completely broken, only removes open window(s) - https://phabricator.wikimedia.org/T76659#820264 (10Jdforrester-WMF) 5Open>3Resolved [00:59:35] 3OOjs-UI: TextInputWidget auto-resize method is a little inefficient - https://phabricator.wikimedia.org/T75328#820267 (10Jdforrester-WMF) 5Open>3Resolved [04:02:17] hi [04:02:32] I am trying to install visual editor on media wiki 1.24.0 [04:02:56] but I get this error .. [f7bc7464] 2014-12-05 03:56:21: Fatal exception of type MWException [05:19:22] 3OOjs-UI: TextInputWidget auto-resize method is a little inefficient - https://phabricator.wikimedia.org/T75328#820602 (10Prtksxna) [11:23:53] 3MediaWiki-extensions-WikiEditor: WikiEditor: Search and replace (tracking) - https://phabricator.wikimedia.org/T65665#821041 (10TheDJ) [12:15:23] (03PS1) 10Esanders: Ignore enter key when no results. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177781 [12:24:00] 3OOjs-UI: OOUI's svgo-optimized SVG files are not compatible with rsvg's broken SVG parsing - https://phabricator.wikimedia.org/T76852#821103 (10matmarex) [12:24:43] 3UI-Standardization, OOjs-UI, MediaWiki-ResourceLoader: Implement ResourceLoader module to ship CSS for sets of SVG+PNG icons to the user - https://phabricator.wikimedia.org/T76473#801437 (10matmarex) [12:29:20] 3OOjs-UI: OOUI's svgo-optimized SVG files are not compatible with rsvg's broken SVG parsing - https://phabricator.wikimedia.org/T76852#821115 (10matmarex) [12:30:59] 3OOjs-UI: OOUI's svgo-optimized SVG files are not compatible with rsvg's broken SVG parsing - https://phabricator.wikimedia.org/T76852#821125 (10Perhelion) [12:35:15] (03CR) 10Krinkle: "FIXME: Ehm.. excuse me, why are we requesting Google GMail urls from inside OOjs UI stylesheets?" [oojs/ui] - 10https://gerrit.wikimedia.org/r/172325 (owner: 10Mooeypoo) [12:46:28] 3OOjs-UI: OOUI's svgo-optimized SVG files are not compatible with rsvg's broken SVG parsing - https://phabricator.wikimedia.org/T76852#821147 (10matmarex) [12:46:28] (03PS1) 10Krinkle: [WIP] Sample commit [oojs/ui] - 10https://gerrit.wikimedia.org/r/177784 [12:46:30] 3VisualEditor-ContentEditable: VisualEditor Search and replace has weird display in RTL wikis - https://phabricator.wikimedia.org/T76807#821148 (10Esanders) a:3Esanders [12:50:20] (03PS1) 10Esanders: Fix find and replace highlights in RTL [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177785 [12:52:31] (03CR) 10Krinkle: "recheck" [oojs/ui] - 10https://gerrit.wikimedia.org/r/177784 (owner: 10Krinkle) [12:53:39] (03PS2) 10Krinkle: [WIP] Sample commit [oojs/ui] - 10https://gerrit.wikimedia.org/r/177784 [12:56:11] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Sample commit [oojs/ui] - 10https://gerrit.wikimedia.org/r/177784 (owner: 10Krinkle) [12:57:03] (03Abandoned) 10Krinkle: [WIP] Sample commit [oojs/ui] - 10https://gerrit.wikimedia.org/r/177784 (owner: 10Krinkle) [12:57:16] (03CR) 10Krinkle: "https://gerrit.wikimedia.org/r/#/c/174619" [oojs/ui] - 10https://gerrit.wikimedia.org/r/177784 (owner: 10Krinkle) [12:57:19] 3OOjs-UI: OOUI's svgo-optimized SVG files are not compatible with rsvg's broken SVG parsing - https://phabricator.wikimedia.org/T76852#821185 (10matmarex) 5Open>3Resolved a:3matmarex [12:57:20] 3UI-Standardization, OOjs-UI, MediaWiki-ResourceLoader: Implement ResourceLoader module to ship CSS for sets of SVG+PNG icons to the user - https://phabricator.wikimedia.org/T76473#821187 (10matmarex) [13:03:20] (03CR) 10Bartosz Dziewoński: [C: 032] Remove previewDialog [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/176512 (owner: 10TheDJ) [13:03:27] (03Merged) 10jenkins-bot: Remove previewDialog [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/176512 (owner: 10TheDJ) [13:29:14] (03CR) 10Amire80: [C: 031] "Thanks a lot. I tested it and it fixes the problem." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177785 (owner: 10Esanders) [13:50:31] 3OOjs-UI: OOjs UI: In certain situations involving StackLayouts, removing items scrolls the focus up to the top - https://phabricator.wikimedia.org/T64420#821249 (10matmarex) I recently filed T75694 which seems to be the same thing, but with more weird behaviors. [14:01:54] 3OOjs-UI: Make a number of Element getters static - https://phabricator.wikimedia.org/T76631#821256 (10matmarex) [14:03:56] 3OOjs-UI: Remove deprecated Element#onDOMEvent and #offDOMEvent - https://phabricator.wikimedia.org/T76861#821257 (10matmarex) [14:04:31] 3OOjs-UI: Make a number of Element getters static - https://phabricator.wikimedia.org/T76631#821266 (10matmarex) > OO.ui.Element.onDOMEvent ➞ OO.ui.Element.static.onDOMEvent > OO.ui.Element.offDOMEvent ➞ OO.ui.Element.static.offDOMEvent We should just remove these if we're breaking compat, they're deprecated. T... [14:06:45] (03CR) 10Krinkle: Add classes to toolbar UI elements (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174666 (owner: 10Amire80) [14:08:18] (03PS1) 10Bartosz Dziewoński: ve.ce.Surface: Remove use of deprecated OO.ui.Element#onDOMEvent and #offDOMEvent [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177791 [14:10:52] (03CR) 10jenkins-bot: [V: 04-1] ve.ce.Surface: Remove use of deprecated OO.ui.Element#onDOMEvent and #offDOMEvent [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177791 (owner: 10Bartosz Dziewoński) [14:12:48] (03PS1) 10Bartosz Dziewoński: [BREAKING CHANGE] Remove deprecated Element#onDOMEvent and #offDOMEvent [oojs/ui] - 10https://gerrit.wikimedia.org/r/177793 [14:14:34] (03PS2) 10Bartosz Dziewoński: ve.ce.Surface: Remove use of deprecated OO.ui.Element#onDOMEvent and #offDOMEvent [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177791 [14:21:52] (03CR) 10Krinkle: [C: 032] [BREAKING CHANGE] Remove deprecated Element#onDOMEvent and #offDOMEvent [oojs/ui] - 10https://gerrit.wikimedia.org/r/177793 (owner: 10Bartosz Dziewoński) [14:23:18] (03CR) 10Krinkle: [C: 032] ve.ce.Surface: Remove use of deprecated OO.ui.Element#onDOMEvent and #offDOMEvent [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177791 (owner: 10Bartosz Dziewoński) [14:23:26] (03PS1) 10Bartosz Dziewoński: [BREAKING CHANGE] Make a number of Element getters static [oojs/ui] - 10https://gerrit.wikimedia.org/r/177795 [14:24:26] (03Merged) 10jenkins-bot: [BREAKING CHANGE] Remove deprecated Element#onDOMEvent and #offDOMEvent [oojs/ui] - 10https://gerrit.wikimedia.org/r/177793 (owner: 10Bartosz Dziewoński) [14:25:14] (03Merged) 10jenkins-bot: ve.ce.Surface: Remove use of deprecated OO.ui.Element#onDOMEvent and #offDOMEvent [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177791 (owner: 10Bartosz Dziewoński) [14:25:47] (03PS1) 10Bartosz Dziewoński: Update for I9ee6a9ec in OOUI [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177796 [14:26:19] (03PS1) 10Bartosz Dziewoński: Update for I9ee6a9ec in OOUI [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/177797 [14:27:46] 3OOjs-UI: Rename a lot of getters for consistency - https://phabricator.wikimedia.org/T76630#821292 (10matmarex) a:3matmarex [14:28:55] (03CR) 10jenkins-bot: [V: 04-1] Update for I9ee6a9ec in OOUI [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177796 (owner: 10Bartosz Dziewoński) [14:29:10] 3OOjs-UI: Rename a lot of getters for consistency - https://phabricator.wikimedia.org/T76630#808058 (10matmarex) [14:34:27] (03CR) 10Krinkle: [C: 031] "Looks good. To test later." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/177107 (owner: 10Catrope) [14:39:48] (03PS1) 10Bartosz Dziewoński: [BREAKING CHANGE] Rename BookletLayout#getPageName → #getCurrentPageName [oojs/ui] - 10https://gerrit.wikimedia.org/r/177799 [14:41:18] 3OOjs-UI: Rename a lot of getters for consistency - https://phabricator.wikimedia.org/T76630#821309 (10matmarex) The BookletLayout#getPageName → #getCurrentPageName one was an obvious improvement and is entirely painless, but I would like to hear the rationale for get→find replacements before I spend tons of tim... [14:48:04] MatmaRex: yeah, me too. [14:48:08] Was about to comment: [14:48:10] Hm.. consistency with what? At first glance I'd guess that a "get" method is a reference or value that is computed or gathered on-demand and either takes no argument or a unique identifier for a single item. "find" seems like something that might take a search query and return varying results in plural. ack-grep found 0 matches for `prototype.find` in oojs/ui, and 2 matches in lib/ve/*. [14:48:55] Krinkle: yeah, that's what i guessed too, but i also found hardly any similar usages. [14:49:11] do comment :) [14:49:29] also, i found *yet another* dialog sizing bug in ooui. fml. [14:50:59] 3OOjs-UI: Rename a lot of getters for consistency - https://phabricator.wikimedia.org/T76630#821312 (10Krinkle) [14:52:11] 3MediaWiki-Page-editing, MediaWiki-ContentHandler: [Regression] section=new no longer works for user js/css pages - https://phabricator.wikimedia.org/T52962#821318 (10Aklapper) [14:52:12] 3MediaWiki-extensions-WikiEditor: [Regression] ext.wikiEditor.toolbar.hideSig.js stopped working - https://phabricator.wikimedia.org/T42972#821321 (10Aklapper) [14:52:14] 3MediaWiki-extensions-AbuseFilter, VisualEditor: Incorrect tagging of edits on some Wikipedias – AbuseFilter's diff and the real diff are not the same - https://phabricator.wikimedia.org/T73947#821322 (10Aklapper) [14:52:18] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Inserting template into slug causes seemingly random nodes to be selected - https://phabricator.wikimedia.org/T58396#821328 (10Aklapper) [14:52:19] 3VisualEditor-MediaWiki, VisualEditor: VisualEditor: [Regression] The #contentSub should not be removed during loading phase - https://phabricator.wikimedia.org/T72954#821329 (10Aklapper) [14:52:31] 3MediaWiki-extensions-Cite: Add back an error message for missing - https://phabricator.wikimedia.org/T74858#821338 (10Aklapper) [14:52:54] 3MediaWiki-Page-editing, Design: Revert bug 27860 or add configuration variable to restore "Mark all edits minor by default" preference behaviour - https://phabricator.wikimedia.org/T44008#821355 (10Aklapper) [14:53:04] 3MediaWiki-Page-editing: Allow creation of revisionless page entries - https://phabricator.wikimedia.org/T43473#821364 (10Aklapper) [14:57:47] 3VisualEditor: A number of VisualEditor dialogs do not cover full screen when 'full' size - https://phabricator.wikimedia.org/T76863 (10matmarex) 3NEW p:3Triage [15:07:23] (03PS2) 10Krinkle: Update UnicodeJS to v0.1.2 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177582 (owner: 10Jforrester) [15:10:30] 3OOjs-UI: OOjs UI: Dialogs should be repositionable/draggable - https://phabricator.wikimedia.org/T51969#821409 (10matmarex) [15:12:14] (03CR) 10Krinkle: [C: 032] Update UnicodeJS to v0.1.2 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177582 (owner: 10Jforrester) [15:14:32] (03Merged) 10jenkins-bot: Update UnicodeJS to v0.1.2 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177582 (owner: 10Jforrester) [15:14:39] 3OOjs-UI: Remove deprecated Element#onDOMEvent and #offDOMEvent - https://phabricator.wikimedia.org/T76861#821421 (10matmarex) [15:17:29] 3OOjs-UI: OOjs UI: Dialogs should be repositionable/draggable - https://phabricator.wikimedia.org/T51969#821422 (10Ironholds) [15:17:37] 3OOjs-UI: ComboBoxWidget: Provide a getMenu method - https://phabricator.wikimedia.org/T76646#821423 (10matmarex) Done in afbedc71eef5ba898c76c1687c3788f295b7a029 (https://gerrit.wikimedia.org/r/#/c/175154/). [15:18:12] 3OOjs-UI: ComboBoxWidget: Provide a getMenu method - https://phabricator.wikimedia.org/T76646#821426 (10matmarex) [15:18:19] (03CR) 10Bartosz Dziewoński: "Fixed T76646." [oojs/ui] - 10https://gerrit.wikimedia.org/r/175154 (owner: 10Catrope) [15:18:41] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: Add support for editing templates' parameters as DOM elements, including supporting nested templates - https://phabricator.wikimedia.org/T52355#821436 (10Ironholds) [15:18:43] 3VisualEditor-CopyPaste, VisualEditor: VisualEditor: Can't copy/paste header from start of document without losing formatting - https://phabricator.wikimedia.org/T52126#821437 (10Ironholds) [15:18:57] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Hidden templates should display as an icon in-page so they can be interacted with (e.g. a puzzle piece?) - https://phabricator.wikimedia.org/T51806#821438 (10Ironholds) [15:18:59] 3VisualEditor-DataModel, VisualEditor: VisualEditor: created, and meta-data removed, from [[Bahá'u'lláh]] on edit - https://phabricator.wikimedia.org/T52481#821439 (10Ironholds) [15:19:00] 3VisualEditor-DataModel, VisualEditor: VisualEditor: Edit to a template somehow removing equals signs in markup? - https://phabricator.wikimedia.org/T54752#821440 (10Ironholds) [15:19:04] 3VisualEditor-DataModel, VisualEditor: VisualEditor: Mis-nested annotations are cleaned up, leading to a dirty diff - https://phabricator.wikimedia.org/T52052#821441 (10Ironholds) [15:21:17] 3OOjs-UI: Consider changing toggle to toggleVisibility - https://phabricator.wikimedia.org/T76644#821445 (10matmarex) I considered it and in my opinion `.toggle()` is intuitive enough, matches the convention established by jQuery and is a lot harder to mistype than `.toggleVisibility()`. ;) More considerations w... [15:23:55] 3OOjs-UI: OOjs UI: Dialogs should be repositionable/draggable - https://phabricator.wikimedia.org/T51969#821451 (10Spinningspark) >>! In T51969#821409, @matmarex wrote: > ...and could work a lot better than clunky dragging of dialogs (which are often way too large for dragging to make sense, as they would cover... [15:24:05] 3OOjs-UI: MediaWiki, Apex: Provide default margins for buttons and other widgets - https://phabricator.wikimedia.org/T76643#821453 (10matmarex) What other widgets? We don't have that many "inline" ones. By which I mean we have none other. [15:24:50] 3OOjs-UI: OOjs UI: Dialogs should be repositionable/draggable - https://phabricator.wikimedia.org/T51969#821459 (10matmarex) Indeed, but in this use case you then have to drag it back on-screen to input the category name or whatever. [15:30:11] (03CR) 10Mvolz: "Okay, it works, now I get to nitpick! :)" [services/citoid] - 10https://gerrit.wikimedia.org/r/177478 (owner: 10Sn1per) [15:30:51] (03CR) 10Mvolz: [C: 04-1] "Style:" [services/citoid] - 10https://gerrit.wikimedia.org/r/177478 (owner: 10Sn1per) [15:31:39] (03CR) 10Mvolz: "Code:" [services/citoid] - 10https://gerrit.wikimedia.org/r/177478 (owner: 10Sn1per) [15:36:33] 3OOjs-UI: demo: Change icon demo to not put buttons in a fieldset without field layouts around them - https://phabricator.wikimedia.org/T76640#821466 (10matmarex) [15:38:09] (03PS1) 10Bartosz Dziewoński: demo: Don't put buttons in a FieldsetLayout without FieldLayouts around them [oojs/ui] - 10https://gerrit.wikimedia.org/r/177812 [15:39:51] 3OOjs-UI: Add getIconTitle, same as getIndicatorTitle, to OO.ui.IconElement - https://phabricator.wikimedia.org/T76639#821473 (10matmarex) a:3matmarex [15:40:49] 3OOjs-UI: Add getIconTitle, same as getIndicatorTitle, to OO.ui.IconElement - https://phabricator.wikimedia.org/T76639#808139 (10matmarex) [15:41:08] (03PS1) 10Bartosz Dziewoński: IconElement: Add missing #getIconTitle [oojs/ui] - 10https://gerrit.wikimedia.org/r/177813 [15:49:25] 3VisualEditor, OOjs-UI: Tools in the toolbar do not have unique attributes - https://phabricator.wikimedia.org/T76143#821494 (10Amire80) [15:51:12] 3OOjs-UI: SelectWidget.prototype.getRelativeItem's direction argument is the wrong way around? - https://phabricator.wikimedia.org/T76637#821496 (10matmarex) ```@param {number} direction Direction to move in, -1 to look backward, 1 to move forward```` Sounds sensible to me, and code seems to match the docs this... [15:53:10] 3MediaWiki-extensions-WikiEditor: wikiEditor "replace" borked - https://phabricator.wikimedia.org/T76750#821503 (10Kipod) this happens with google chrome (v39) on windows and linux, and firefox (v33) on windows and linux. it probably happens with any other geko and webkit browser. if you have any browser for w... [15:55:13] 3OOjs-UI: OOjs UI: optionWidget with check icon should not appear for invalid entries in the category input field. - https://phabricator.wikimedia.org/T74000#821507 (10matmarex) Can't reproduce anymore, must have been fixed at some point. [16:00:15] 3VisualEditor: In category input field, typing invalid category name doesn't clear suggestions - https://phabricator.wikimedia.org/T76868#821520 (10matmarex) [16:01:27] 3OOjs-UI: OOjs UI: optionWidget with check icon should not appear for invalid entries in the category input field. - https://phabricator.wikimedia.org/T74000#821529 (10matmarex) [16:02:17] James_F|Away: why do we not have a "Done" column on https://phabricator.wikimedia.org/tag/oojs-ui/board/ ? [16:06:40] 3OOjs-UI: OOjs UI: Dialogs should be repositionable/draggable - https://phabricator.wikimedia.org/T51969#821533 (10matmarex) [16:21:51] 3OOjs-UI: OOjs UI: Toolbar menu width isn't working in IE11 any more - https://phabricator.wikimedia.org/T74592#821535 (10matmarex) [16:21:54] 3OOjs-UI: OOjs UI: [Regression] Menu width isn't working in IE11 any more – see VisualEditor's 'Page options' drop down menu - https://phabricator.wikimedia.org/T74640#772678 (10matmarex) [16:27:08] 3OOjs-UI: OOUI's svgo-optimized SVG files are not compatible with rsvg's broken SVG parsing - https://phabricator.wikimedia.org/T76852#821546 (10matmarex) The patch is included in rsvg 2.40.6. https://git.gnome.org/browse/librsvg/log/ [16:39:12] RoanKattouw_away: the pasted graph did in fact have a [16:39:52] ....
...
[16:40:48] This appears correctly in VE, but when it's saved as wikitext, the inside the seems to get omitted, and the row gets run together with the first in the [16:55:11] (03CR) 10Bartosz Dziewoński: [C: 032] Ignore enter key when no results. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177781 (owner: 10Esanders) [16:55:13] (03CR) 10Bartosz Dziewoński: [C: 032] Fix find and replace highlights in RTL [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177785 (owner: 10Esanders) [17:03:48] (03Merged) 10jenkins-bot: Ignore enter key when no results. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177781 (owner: 10Esanders) [17:03:50] (03Merged) 10jenkins-bot: Fix find and replace highlights in RTL [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177785 (owner: 10Esanders) [17:07:46] 3OOjs-UI: OOjs UI: Dialogs should be repositionable/draggable - https://phabricator.wikimedia.org/T51969#821594 (10PamD) Looks as if it might work: I don't know the term "dock" but I think you mean what I'd call "minimise"? So click on that icon, the dialog box shrinks to an icon, I read what's behind it: I hop... [17:27:43] Hey. [17:28:11] 3OOjs-UI: OOjs UI: optionWidget with check icon should not appear for invalid entries in the category input field. - https://phabricator.wikimedia.org/T74000#821604 (10Swainr) Looks like it got fixed.But, now when invalid characters are entered in the input field , JS error-{F19050} "Uncaught TypeError: Cannot... [17:29:10] 3OOjs-UI: ComboBoxWidget: Provide a getMenu method - https://phabricator.wikimedia.org/T76646#821605 (10Jdforrester-WMF) [17:29:43] morning James_F [17:29:56] James_F: why do we not have a "Done" column on https://phabricator.wikimedia.org/tag/oojs-ui/board/ ? [17:30:18] MatmaRex: "Done" column == "Someone from QA should sign this off as working in production". [17:30:30] MatmaRex: It doesn't really make sense for most back-end projects. [17:30:37] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=109691473 [17:30:37] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=109691499 [17:30:37] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=109691503 [17:30:37] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=109701253 [17:30:37] Corruption alert: visualeditor-needcheck on itwiki: https://it.wikipedia.org/?diff=69485876 [17:30:38] Corruption alert: visualeditor-needcheck on test2wiki: https://test2.wikipedia.org/?diff=133859 [17:31:40] James_F: so do i just resolve bugs when i think they're resolved? what to do so that no one complains? :) [17:31:54] MatmaRex: If you leave them I'll close them. [17:32:12] MatmaRex: It's important to tag them against the wmf-deploy project, and probably easiest to just get me to do that for you. :-) [17:32:21] meh [17:32:32] okay [17:32:38] 3VisualEditor, VisualEditor-EditingTools: Find field - NaN is displayed - https://phabricator.wikimedia.org/T76811#821608 (10Jdforrester-WMF) 5Open>3Resolved p:5Triage>3Normal [17:32:43] Close them if you want, but it doesn't save any time. [17:32:48] i just have reports that are already done, but are not marked as such in any way [17:32:50] 'Cos I still have to go tag them. [17:32:52] huh, that test2 entry [17:32:55] saves my time when i go through the list of open tasks. [17:33:10] MatmaRex: If you move them to "doing" you can ignore them, surely? [17:33:23] MatmaRex: Tasks in "doing" will generally have a patch. [17:33:33] Krenair: Ick, yeah. [17:33:35] yeah, that's what i did [17:33:51] MatmaRex: But the real problem is that you're working too quickly for me to keep up. ;-) [17:34:29] that's why i prefer not to have to wait for people to do boring maintenance after my comments, if i can do the maintenance myself. [17:34:36] * James_F nods. [17:34:41] We can add a "Done" column if you want. [17:35:04] meh [17:35:28] it's fine, i can just move things to "Doing" and make it your problem. :) [17:35:44] 3VisualEditor, VisualEditor-InterfaceLanguage, VisualEditor-EditingTools: Search and replace has weird display in RTL wikis - https://phabricator.wikimedia.org/T76807#821613 (10Jdforrester-WMF) p:5Triage>3Normal [17:35:46] * James_F grins. [17:41:46] (03CR) 10Jforrester: [C: 032] demo: Don't put buttons in a FieldsetLayout without FieldLayouts around them [oojs/ui] - 10https://gerrit.wikimedia.org/r/177812 (owner: 10Bartosz Dziewoński) [17:43:04] 3OOjs-UI: demo: Change icon demo to not put buttons in a fieldset without field layouts around them - https://phabricator.wikimedia.org/T76640#808149 (10Jdforrester-WMF) [17:43:19] 3OOjs-UI: demo: Change icon demo to not put buttons in a fieldset without field layouts around them - https://phabricator.wikimedia.org/T76640#821645 (10Jdforrester-WMF) 5Open>3Resolved [17:44:20] (03Merged) 10jenkins-bot: demo: Don't put buttons in a FieldsetLayout without FieldLayouts around them [oojs/ui] - 10https://gerrit.wikimedia.org/r/177812 (owner: 10Bartosz Dziewoński) [17:54:50] 3OOjs-UI: OOjs UI: Dialogs should be repositionable/draggable - https://phabricator.wikimedia.org/T51969#821684 (10Spinningspark) >>! In T51969#821594, @PamD wrote: >I don't know the term "dock" but I think you mean what I'd call "minimise"? No, dock does not mean the same as minimise. Docking is fixing the... [18:02:09] [09:54] cscott [2014-12-05 08:37:54] This appears correctly in VE, but when it's saved as wikitext, the inside the seems to get omitted, and the row gets run together with the first in the [18:02:21] cscott: Congratulations, you have rediscovered https://phabricator.wikimedia.org/T74702 ;) [18:05:58] RoanKattouw: timo figured out that not only can we move the default options to a standard url-loaded module (and thus enjoy caching for much more than 5 minutes), the module doesn't have to top-load, and doesn't even have to be loaded by default. it can just allow itself to be pulled in as a dependency whenever user.options is needed [18:06:07] pretty exciting [18:07:34] that is going to break *so many* user scripts. :D [18:13:35] tough! [18:27:41] MatmaRex: :-) [18:32:18] (03CR) 10Krinkle: "appVersion is a odd property that is just the userAgent without the "Mozilla/" prefix. Maybe we should use userAgent instead?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177461 (owner: 10Catrope) [18:32:18] 3VisualEditor, VisualEditor-MediaWiki-Links, Design: Display illustrative images and WikiData descriptions for link suggestions - https://phabricator.wikimedia.org/T76397#821752 (10Jdforrester-WMF) a:3sucheta [18:32:24] (03CR) 10Krinkle: [C: 032] Update IE detection to include Edge [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177461 (owner: 10Catrope) [18:32:30] 3VisualEditor, VisualEditor-MediaWiki-Links, Design: Change the link inspector menu widget to show information about the target in a bigger format - https://phabricator.wikimedia.org/T76399#821753 (10Jdforrester-WMF) [18:32:36] 3VisualEditor, VisualEditor-MediaWiki-Links: Provide a separate tab in the link editor for external links - https://phabricator.wikimedia.org/T76398#821754 (10Jdforrester-WMF) a:3sucheta [18:34:13] 3VisualEditor-ContentEditable, VisualEditor: data-ve-clipboard-key span inserted in page - https://phabricator.wikimedia.org/T76749#821761 (10Jdforrester-WMF) [18:34:19] 3VisualEditor-ContentEditable, VisualEditor: data-ve-clipboard-key span inserted in page - https://phabricator.wikimedia.org/T76749#821762 (10Jdforrester-WMF) p:5Triage>3High [18:34:30] (03Merged) 10jenkins-bot: Update IE detection to include Edge [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177461 (owner: 10Catrope) [18:35:32] (03PS1) 10Esanders: Regular expression find and replace [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177851 [18:35:45] Krinkle: Ugh, I don't know why that code uses appVersion instead of userAgent, that's just stupid [18:36:21] (03PS1) 10Bartosz Dziewoński: SelectWidget: Rewrite #getRelativeSelectableItem [oojs/ui] - 10https://gerrit.wikimedia.org/r/177853 [18:36:45] (03CR) 10jenkins-bot: [V: 04-1] Regular expression find and replace [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177851 (owner: 10Esanders) [18:37:36] RoanKattouw: I'm gonna do a sweep [18:39:23] Krinkle: of? [18:41:17] 3VisualEditor-ContentEditable, VisualEditor: data-ve-clipboard-key span inserted in page - https://phabricator.wikimedia.org/T76749#821770 (10Esanders) Copy paste bug. This is reproduceable in Firefox [18:44:22] (03CR) 10Bartosz Dziewoński: "The workaround should probably be actually limited to IE 8, not any IE version. We probably don't need this on IE 11." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/115378 (owner: 10Gerrit Patch Uploader) [18:44:28] (03CR) 10Bartosz Dziewoński: [C: 04-1] Workaround for a scrolling bug in IE8 on resize [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/115378 (owner: 10Gerrit Patch Uploader) [18:44:59] RoanKattouw: btw https://html.spec.whatwg.org/multipage/webappapis.html#dom-navigator-appcodename [18:45:11] RoanKattouw: of appVersion > userAgent over js authored by wikimedia [18:45:17] RoanKattouw: greatest spec ever [18:45:28] what do you mean there are different browser? platform = Gecko. [18:45:32] That is the standard :D [18:45:38] can't edit empty document in FF [18:45:41] product* [18:46:57] "40101e42a4544768ac624ef2b4da0e7d44b69b65 is the first bad commit" [18:47:05] looks towards RoanKattouw and divec|away [18:47:24] (Use a chimera instead of  in inline slugs) [18:47:35] hah [18:47:38] divec|away: Investigate? [18:48:57] (03CR) 10Esanders: "FIXME: This breaks editing empty documents in Firefox" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151046 (owner: 10Catrope) [18:49:58] (03PS1) 10Krinkle: navigator.appVersion -> navigator.userAgent [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177856 [18:51:50] divec|away, also empty paragraphs have no height, so pressing enter is gross [18:54:20] 3OOjs-UI: Rename a lot of getters for consistency - https://phabricator.wikimedia.org/T76630#821773 (10Jdforrester-WMF) Consistency with what Trevor wants OOUI to look like. :-) [19:03:16] edsanders: If I blank a document in firefox on master, typing works for me. ve-standalone refuses to load an empty html file. How exactly do you get firefox but not chromium to break? [19:05:10] 3VisualEditor-MediaWiki, VisualEditor: In category input field, typing invalid category name doesn't clear suggestions - https://phabricator.wikimedia.org/T76868#821801 (10Jdforrester-WMF) p:5Triage>3Normal [19:05:18] 3VisualEditor-MediaWiki, VisualEditor: In category input field, typing invalid category name doesn't clear suggestions - https://phabricator.wikimedia.org/T76868#821520 (10Jdforrester-WMF) [19:06:12] 3OOjs-UI: Make a number of Element getters static - https://phabricator.wikimedia.org/T76631#821810 (10Jdforrester-WMF) [19:06:29] 3OOjs-UI: Remove deprecated Element#onDOMEvent and #offDOMEvent - https://phabricator.wikimedia.org/T76861#821813 (10Jdforrester-WMF) p:5Triage>3Normal [19:16:22] Refuses to load empty.html? [19:16:31] 3VisualEditor, VisualEditor-ContentEditable, VisualEditor-MediaWiki-Templates: Inserting template into slug causes seemingly random nodes to be selected - https://phabricator.wikimedia.org/T58396#821862 (10Jdforrester-WMF) 5Open>3Resolved [19:16:44] divec, works fine for me - also if you edit a non-existent page in MW [19:18:24] also if you blank the document, the paragraph is the wrong height [19:19:22] 3VisualEditor-MediaWiki, VisualEditor, Design: VisualEditor: There is not enough UI difference between reading and editing mode - https://phabricator.wikimedia.org/T50008#821880 (10John_Broughton) [19:24:00] 3MediaWiki-Page-editing: Allow creation of revisionless page entries - https://phabricator.wikimedia.org/T43473#821906 (10Jdforrester-WMF) p:5Low>3Volunteer? [19:31:23] 3UI-Standardization, OOjs-UI, MediaWiki-ResourceLoader: Implement ResourceLoader module to ship CSS for sets of SVG+PNG icons to the user - https://phabricator.wikimedia.org/T76473#821995 (10Jdforrester-WMF) >>! In T76473#808482, @matmarex wrote: >> Do we have a list of the browsers that would need PNGs and a ro... [19:32:04] 3VisualEditor-MediaWiki, VisualEditor: [Regression wmf11]Cannot set “Sort this page by default as” for the individual Categories. - https://phabricator.wikimedia.org/T76707#821998 (10Jdforrester-WMF) [19:32:42] 3VisualEditor-Tables, VisualEditor, Design: Tables: Delete table should be an option from the context tooltip, not in the toolbar - https://phabricator.wikimedia.org/T76676#822010 (10Jdforrester-WMF) p:5Triage>3Normal [19:32:58] 3VisualEditor, VisualEditor-EditingTools: Context tooltips should always appear at the bottom of an object - https://phabricator.wikimedia.org/T76669#822016 (10Jdforrester-WMF) p:5Triage>3High [19:35:40] 3VisualEditor, VisualEditor-EditingTools: A number of VisualEditor dialogs do not cover full screen when 'full' size - https://phabricator.wikimedia.org/T76863#822030 (10Jdforrester-WMF) p:5Triage>3Normal [19:36:32] 3VisualEditor, VisualEditor-EditingTools: Context tooltips should always appear at the bottom of an object - https://phabricator.wikimedia.org/T76669#808693 (10Jdforrester-WMF) [19:36:36] 3VisualEditor, VisualEditor-EditingTools: A number of VisualEditor dialogs do not cover full screen when 'full' size - https://phabricator.wikimedia.org/T76863#821387 (10Jdforrester-WMF) [19:38:47] (03PS2) 10Jforrester: Trim whitespace when annotating [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177533 (owner: 10Esanders) [19:40:03] 3VisualEditor, VisualEditor-ContentEditable, VisualEditor-EditingTools: Trim selections with whitespace on the end when annotating - https://phabricator.wikimedia.org/T53023#822087 (10Jdforrester-WMF) a:3Esanders [19:41:11] 3VisualEditor, VisualEditor-ContentEditable, VisualEditor-EditingTools: Trim selections with whitespace on the end when annotating - https://phabricator.wikimedia.org/T53023#822104 (10Ironholds) [19:41:11] (03PS1) 10Esanders: Ensure clipboard key is removed from paste target [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177867 [19:42:50] 3VisualEditor-ContentEditable, VisualEditor: data-ve-clipboard-key span inserted in page - https://phabricator.wikimedia.org/T76749#822130 (10Jdforrester-WMF) [19:44:08] 3VisualEditor-TechnicalDebt, VisualEditor: VisualEditor: Transclusion nodes should re-evaluate their block/inline status on every update - https://phabricator.wikimedia.org/T51784#822159 (10Ironholds) [19:44:09] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: Let users relabel (or renumber if auto-numbered) parameters in the transclusion dialog - https://phabricator.wikimedia.org/T52268#822160 (10Ironholds) [19:44:13] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Phantoms can be width:100% when the object they're meant to cover has a floated element alongside it - https://phabricator.wikimedia.org/T52395#822161 (10Ironholds) [19:44:15] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: backspacing sometimes inserts a breaking space - https://phabricator.wikimedia.org/T52358#822162 (10Ironholds) [19:44:52] 3MediaWiki-extensions-TemplateData: TempateData: Provide a way to list all documented templates on a wiki (beyond Special:PagesWithProp/templatedata) - https://phabricator.wikimedia.org/T52368#822171 (10Ironholds) [19:45:39] 3VisualEditor-DataModel, VisualEditor: VisualEditor: Ordered application of annotations to avoid fragmentation (e.g. ''[[Foo|Fo]]''[[Foo|o]]) - https://phabricator.wikimedia.org/T52098#822176 (10Ironholds) [19:45:40] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: Adding a reference cannot update fake references blocks inside templates - https://phabricator.wikimedia.org/T52769#822177 (10Ironholds) [19:45:44] 3VisualEditor-DataModel, VisualEditor: VisualEditor: References created by templates numbered alone, not with the rest of the page, and don't show up as references to insert - https://phabricator.wikimedia.org/T52474#822180 (10Ironholds) [19:45:46] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Don't let the user enter multiple consecutive spaces (except in preformatted blocks), because that's not how HTML works - https://phabricator.wikimedia.org/T53056#822181 (10Ironholds) [19:45:48] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Add a block slug at the end of pages - https://phabricator.wikimedia.org/T52353#822182 (10Ironholds) [19:45:49] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: Reference dialog re-use search form should recognise group names - https://phabricator.wikimedia.org/T53838#822183 (10Ironholds) [19:48:27] Krinkle: Hmm. Any idea why https://gerrit.wikimedia.org/r/#/c/177516/ in citoid got a V+2 for PS1, but jenkins-bot didn't run for PS2? [19:51:22] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: Place page meta-data in expected order - https://phabricator.wikimedia.org/T52882#822267 (10Ironholds) [19:51:24] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: Be able to name references manually in the reference dialog - https://phabricator.wikimedia.org/T52568#822268 (10Ironholds) [19:51:27] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: Alternative way of editing categories - https://phabricator.wikimedia.org/T52239#822269 (10Ironholds) [19:51:28] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: Transclusion dialog makes it too easy for users to remove the newlines between parameters - https://phabricator.wikimedia.org/T52584#822270 (10Ironholds) [19:51:31] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Template:Listen (and similar sound files) doesn't render the TMH aspects correctly - https://phabricator.wikimedia.org/T52365#822272 (10Ironholds) [19:51:33] 3VisualEditor-MediaWiki, VisualEditor: VisualEditor: Wikitext "review your changes" is relatively unhelpful for page creations; consider behaviour - https://phabricator.wikimedia.org/T52180#822273 (10Ironholds) [19:51:34] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: sizing of footnote tags (e.g. [12]) inconsistent. - https://phabricator.wikimedia.org/T52095#822274 (10Ironholds) [19:51:35] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Pre-annotation is from up-page, so deleting and replacing the first character in a link de-links it; deleting and replacing the first bold character in a word de-bolds it; etc. - https://phabricator.wikimedia.org/T52678#822275 (10Ironholds) [19:51:38] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: Transclusion dialog informing you that there are "no unused parameters" looks odd; improve message? - https://phabricator.wikimedia.org/T52735#822276 (10Ironholds) [19:51:39] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Show a different cursor when Ctrl (Cmd on Mac) is held down, as the interaction will be different - https://phabricator.wikimedia.org/T52741#822277 (10Ironholds) [19:51:40] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: CSS munging causing CSS image cropping template {{Css Image Crop}} to display wrong portion of image - https://phabricator.wikimedia.org/T53166#822278 (10Ironholds) [19:51:47] 3MediaWiki-extensions-TemplateData: TemplateData: Get better error messages for JSON syntax errors - https://phabricator.wikimedia.org/T52511#822283 (10Ironholds) [19:52:13] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: Editing tool to changing case - https://phabricator.wikimedia.org/T52745#822297 (10Ironholds) [19:53:55] RoanKattouw, so parsing link hrefs inside transclusion nodes on mobile [19:54:25] doc.baseURI in ve.dm.MWInternalLinkAnnotation.static.getTargetDataFromHref gives me path/to/wiki/Main_Page?veaction=edit [19:55:18] rather than just path/to/wiki/ [19:56:07] I see that ve.ce.MWTransclusionNode.prototype.getRenderedDomElements is passing it the ownerDocument of the link... [19:56:32] should it get the model html document of the transclusion node instead? [19:56:34] Yeah as I said yesterday: [19:56:36] 3OOjs-UI: OOjs UI: optionWidget with check icon should not appear for invalid entries in the category input field. - https://phabricator.wikimedia.org/T74000#822335 (10matmarex) Hmm, that's probably the root cause of T76868 I recently filed after looking at this bug. :) [19:57:06] [22:38:32] Krenair: The code around transclusion nodes and GeneratedContentNode is a complete mess with respect to documents anywy [19:57:12] [22:38:42] Almost nothing in that code uses the correct document [19:57:13] [22:39:06] This includes passing things that have been created in the wrong document, converting things to the wrong document at the wrong time, etc etc [19:57:14] [22:39:32] It's super confusing so I haven't yet taken the time to sit down and chart the situation exactly, but I do know it's insane and needs to be rethought from scratch [19:57:20] Krenair: Yeah that sounds right [19:57:28] I'm just saying, be aware that this is a big mess [19:57:49] 3VisualEditor: Cannot scroll down when editing long tables - https://phabricator.wikimedia.org/T76891 (10EBernhardson) 3NEW p:3Triage [19:57:57] If you can fix it, great, but if you sink into a swamp of layers upon layers of confusion and brokenness I won't be surprised or disappointed in any way [19:59:03] 3VisualEditor: Cannot scroll down when editing long tables - https://phabricator.wikimedia.org/T76891#822338 (10EBernhardson) [19:59:59] 3OOjs-UI: OOjs UI: optionWidget with check icon should not appear for invalid entries in the category input field. - https://phabricator.wikimedia.org/T74000#822365 (10Jdforrester-WMF) 5Open>3Resolved [20:02:58] Although possibly I'm overestimating how bad it all is, because I was a bit sick when looking at this the other day and I wasn't feeling very intelligent that day in general [20:05:09] 3VisualEditor: Allow undoing/fixing edits from the 'Review your changes' tab - https://phabricator.wikimedia.org/T76898 (10EBernhardson) 3NEW p:3Triage [20:07:53] 3VisualEditor-MediaWiki, VisualEditor: In category input field, typing invalid category name doesn't clear suggestions - https://phabricator.wikimedia.org/T76868#822437 (10matmarex) >>! In T74000#821604, @Swainr wrote: > Looks like it got fixed.But, now when invalid characters are entered in the input field , JS... [20:08:18] 3VisualEditor-MediaWiki, VisualEditor: In category input field, typing invalid category name doesn't clear suggestions - https://phabricator.wikimedia.org/T76868#822441 (10matmarex) a:3matmarex [20:08:26] (03PS1) 10Bartosz Dziewoński: MWCategoryInputWidget: Don't explode on invalid titles [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/177871 [20:10:23] RoanKattouw, looks like the old code would support wgArticlePath putting the $1 anywhere, and turning it into (.*) [20:10:45] should be safe to assume it's at the end, shouldn't it? [20:10:47] Yeah... [20:10:57] I don't know what Parsoid does for those cases exactly [20:11:47] Are there any legitimate cases? [20:12:19] /w/index.php?title=$1&action=read ? [20:12:50] action=view, actually [20:13:04] TrevorParscal, okay, I am doing my best to wrangle this API but there might be a couple of issues: for one, the API takes its information from user-generated templates, which means that we sometimes get weird non-standard info back. Best example is "Author" and "Credit". Author should be the username, and it is returned with the link (so, html format in the api response). The 'Credit' is returned as html as well; there's a lot of "O [20:13:04] wn Work" (surrounded by a span) and hten there's sometimes just a bare link, like http://blablabla.com/bla which, I assume, denotes the source. But that's not standard either. [20:13:44] TrevorParscal, so, I'm trying to standardize as much as I can, but we very well might get responses that are a bit jumbled, just from the nature of the fact that the info is user generated templates that already seem to be mildly inconsistent. [20:13:53] mooeypoo: gotta go to lunch - we should do a hangout or something to catch up when I return [20:14:00] * mooeypoo nods [20:14:03] MatmaRex: will you be around in an hour? [20:14:24] yes [20:14:26] Krenair: There are probably semi-legitimate cases, but I suggest you write working code first and worry about this later [20:14:37] I also wonder what Parsoid's base URL looks like in that circumstance [20:16:38] I'm going to have a merge party (i'm working on a patch that includes the cursor files in OOjs ui) [20:16:40] brb [20:17:07] (03PS2) 10Esanders: Regular expression find and replace [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177851 [20:18:44] James_F: hmm, so is https://phabricator.wikimedia.org/T74714 a blocker to https://phabricator.wikimedia.org/T74715 or the other way 'round? [20:19:15] RoanKattouw_away, I think if we can assume that, we can ditch the regex and run with indexOf/substring/length [20:22:57] (03PS65) 10Paladox: WikiEditor: Convert .css to .less and also fixes SVG issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 [20:23:58] (03PS66) 10Paladox: WikiEditor: Convert .css to .less and also fixes SVG issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 [20:26:17] (03PS28) 10Paladox: WikiEditor: Convert .css to .less and add Arrow SVG images [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151616 [20:26:25] (03CR) 10jenkins-bot: [V: 04-1] WikiEditor: Convert .css to .less and add Arrow SVG images [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151616 (owner: 10Paladox) [20:31:30] (03PS29) 10Paladox: WikiEditor: Convert .css to .less and add Arrow SVG images [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151616 [20:31:32] James_F: checking [20:31:48] James_F: untrusted user. [20:32:02] (03PS30) 10Paladox: WikiEditor: Convert .css to .less and add Arrow SVG images [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151616 [20:32:26] James_F: There's no check pipeline. Figured we wouldn't need one for the time being [20:32:32] 3OOjs-UI: OOjs UI: Dialogs should be repositionable/draggable - https://phabricator.wikimedia.org/T51969#822504 (10John_Broughton) The discussion is complicated by the unnecessary "Options" menu on the left side of the dialog box. (I believe this is the **only** place in VE where selecting a choice from a top me... [20:32:46] (03PS31) 10Paladox: WikiEditor: Convert .css to .less and add Arrow SVG images [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151616 [20:33:00] (03PS32) 10Paladox: WikiEditor: Convert .css to .less and add Arrow SVG images [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151616 [20:34:29] (03PS62) 10Paladox: WikiEditor: Re add SVG [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151611 [20:36:21] (03PS2) 10Paladox: Pre-fill fields in image dialog when image code is selected in editor [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/176927 (owner: 10Happy5214) [20:36:26] (03CR) 10jenkins-bot: [V: 04-1] Pre-fill fields in image dialog when image code is selected in editor [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/176927 (owner: 10Happy5214) [20:48:51] James_F: Krinkle: what do you think about me making https://phabricator.wikimedia.org/T74715 "Convert MW core login/logout/signup pages to OOUI" happen now? (also, is https://phabricator.wikimedia.org/T74714 a blocker to https://phabricator.wikimedia.org/T74715 or the other way 'round?) [20:51:25] MatmaRex: OOjs UI is ready to go in mediawiki-core. There's a commit adding it to composer.json. Depend on that commit to show how it'd be done. As soon as we have a working proposal commit that we agree on, I'll merge that and the dependency [20:51:53] okay. let's do it them [20:52:11] I'm not sure about product decision priorities, assignments, but from this angle I'd say, sure go ahead and convert signup/login. [21:00:35] (03PS1) 10Alex Monk: Try to fix href parsing in transclusion nodes when on alternative (e.g. mobile) domains/paths [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/177875 [21:11:00] (03CR) 10Alex Monk: [C: 032] MWCategoryInputWidget: Don't explode on invalid titles [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/177871 (owner: 10Bartosz Dziewoński) [21:11:30] fucking gerrit doesn't let me download things again [21:11:36] shit keeps timing out [21:12:57] (03Merged) 10jenkins-bot: MWCategoryInputWidget: Don't explode on invalid titles [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/177871 (owner: 10Bartosz Dziewoński) [21:13:46] MatmaRex: ah, I thought it was my connection. [21:13:52] MatmaRex: Yeah, me too. pushing is fine. [21:14:05] MatmaRex: I worked around it by pulling from https:// github remote instead. [21:14:14] (for master anyway) [21:16:17] TrevorP|Away, I have to run to get a couple of boxes, I'll be back shortly if you'll have time for a quick hangout [21:16:39] 3VisualEditor-MediaWiki, VisualEditor: VisualEditor: Provide simultaneous access to editor and edit summary - https://phabricator.wikimedia.org/T52961#822601 (10Cenarium) [21:42:51] (03CR) 10Esanders: "It's a pending pull request to the main branch. No need to block here." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/176748 (owner: 10Esanders) [21:45:25] (03CR) 10Esanders: "merged into fork" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/176748 (owner: 10Esanders) [22:01:12] (03PS3) 10Jforrester: Papaparse update per https://github.com/edg2s/PapaParse/pull/2 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/176748 (owner: 10Esanders) [22:01:24] (03CR) 10Jforrester: [C: 032] Papaparse update per https://github.com/edg2s/PapaParse/pull/2 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/176748 (owner: 10Esanders) [22:03:37] (03PS6) 10Sn1per: Implement BibTeX export format [services/citoid] - 10https://gerrit.wikimedia.org/r/177478 [22:04:27] 3VisualEditor-MediaWiki-Templates, VisualEditor-MediaWiki, VisualEditor: [Regression?] Links in transclusion nodes can point to /w/PageName if browsing from /w/index.php?veaction=edit - https://phabricator.wikimedia.org/T76379#822686 (10Krenair) a:3Krenair [22:05:35] (03PS7) 10Sn1per: Implement BibTeX export format [services/citoid] - 10https://gerrit.wikimedia.org/r/177478 [22:05:49] 3VisualEditor-MediaWiki, VisualEditor: In category input field, typing invalid category name doesn't clear suggestions - https://phabricator.wikimedia.org/T76868#822687 (10Jdforrester-WMF) [22:06:09] (03Merged) 10jenkins-bot: Papaparse update per https://github.com/edg2s/PapaParse/pull/2 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/176748 (owner: 10Esanders) [22:07:15] (03PS8) 10Sn1per: Implement BibTeX export format [services/citoid] - 10https://gerrit.wikimedia.org/r/177478 [22:10:48] Krinkle|detached: RoanKattouw_away: ori: https://gerrit.wikimedia.org/r/#/c/168732/ [22:11:24] Timo is over here: https://gerrit.wikimedia.org/r/#/c/177874/ fixing crap I already done fixerated! [22:13:34] (03CR) 10Catrope: [C: 032] navigator.appVersion -> navigator.userAgent [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177856 (owner: 10Krinkle) [22:13:56] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/177900/ [22:14:00] FYI. [22:14:03] TrevorParscal, you have a minute for a quick chat? I'm free all evening if you want later [22:14:24] mooeypoo: He probably does but he's just stepped away from his desk for a minute [22:14:42] oh, okay, he'll see it when he gets back, I assume. Pinged by his nickname. [22:15:24] 3VisualEditor-MediaWiki, VisualEditor: Same Category get added multiple times ,for every change in “Sort this page by default as” value. - https://phabricator.wikimedia.org/T76715#822696 (10Krenair) [22:15:33] RoanKattouw, also, I remember you were cringing pretty badly last time I did something with raw regex for this, so maybe you have an idea -- there's a bug/request to have the media search show the file type (png/jpg/etc) and the only way to do this is to extract it from the filename. I found regex for that, but, as i remember, you disliked it a lot. Any alternatives? [22:15:37] are we doing it anywhere else? [22:15:51] the image model just says "bitmap" vs "drawing" [22:15:57] no actual file extension. [22:16:19] (03Merged) 10jenkins-bot: navigator.appVersion -> navigator.userAgent [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177856 (owner: 10Krinkle) [22:18:17] (03CR) 10Catrope: Disable Apply Changes in reference dialog until changes have been made (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/176861 (owner: 10Alex Monk) [22:19:45] 3VisualEditor-MediaWiki, VisualEditor: [Regression wmf11]Cannot set “Sort this page by default as” for the individual Categories. - https://phabricator.wikimedia.org/T76707#822704 (10Krenair) Works for me. [22:19:50] (03PS1) 10Jforrester: Update VE core submodule to master (d52749b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/177927 [22:19:56] I'm not having very good luck reproducing bugs recently. [22:20:48] Krenair: :-( [22:21:12] I can't decide whether this is a good thing or a bad thing. [22:21:13] Krenair: "Try to fix href parsing" looks good to me; is the reason the commit msg is so tentative that you're not having luck reproducing things? [22:21:25] Cause I would love to merge that code as is but with a more confident-sounding commit msg [22:21:31] Krinkle|detached: Aha. Yeah, oh well. [22:21:49] Krinkle|detached: Time to remove human V+2 from the repo now? [22:21:55] I did actually test it since writing that message, it seems ok [22:22:07] I will make it more bold [22:23:11] (03PS2) 10Alex Monk: Fix href parsing in transclusion nodes when on alternative (e.g. mobile) domains/paths [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/177875 [22:23:16] RoanKattouw, better? [22:23:20] (03CR) 10Catrope: [C: 032] Ensure clipboard key is removed from paste target [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177867 (owner: 10Esanders) [22:24:05] 3VisualEditor-ContentEditable, VisualEditor: data-ve-clipboard-key span inserted in page - https://phabricator.wikimedia.org/T76749#822719 (10Jdforrester-WMF) [22:24:39] RoanKattouw, I could reproduce the bug(s) in question quite well. It helps that I found them I guess [22:25:38] (03CR) 10Catrope: "Appears to be a regression from ea59d25a568e320be523d6d33041fdf83825838d which is wmf10" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177867 (owner: 10Esanders) [22:25:45] (03Merged) 10jenkins-bot: Ensure clipboard key is removed from paste target [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177867 (owner: 10Esanders) [22:26:02] (03PS1) 10Catrope: Ensure clipboard key is removed from paste target [VisualEditor/VisualEditor] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/177929 [22:26:53] (03CR) 10Jforrester: [C: 032] Ensure clipboard key is removed from paste target [VisualEditor/VisualEditor] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/177929 (owner: 10Catrope) [22:27:14] (03PS1) 10Catrope: Ensure clipboard key is removed from paste target [VisualEditor/VisualEditor] (wmf/1.25wmf11) - 10https://gerrit.wikimedia.org/r/177930 [22:27:55] (03CR) 10Jforrester: [C: 032] Ensure clipboard key is removed from paste target [VisualEditor/VisualEditor] (wmf/1.25wmf11) - 10https://gerrit.wikimedia.org/r/177930 (owner: 10Catrope) [22:29:00] (03Merged) 10jenkins-bot: Ensure clipboard key is removed from paste target [VisualEditor/VisualEditor] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/177929 (owner: 10Catrope) [22:29:12] I opened mobile VE on testwiki and can't seem to add any citations :/ [22:29:12] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (d52749b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/177927 (owner: 10Jforrester) [22:29:15] that known? [22:30:41] mooeypoo: one sec [22:30:59] Krenair: No :( [22:31:27] (03CR) 10Alex Monk: [C: 032] Disable Apply Changes in reference dialog until changes have been made (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/176861 (owner: 10Alex Monk) [22:31:31] (03Merged) 10jenkins-bot: Update VE core submodule to master (d52749b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/177927 (owner: 10Jforrester) [22:31:43] wait what? [22:31:50] (03CR) 10Alex Monk: [C: 04-2] Disable Apply Changes in reference dialog until changes have been made [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/176861 (owner: 10Alex Monk) [22:31:57] ummm [22:32:22] I didn't mean to press that, obviously. [22:33:19] (03PS1) 10Trevor Parscal: Add cursor files [oojs/ui] - 10https://gerrit.wikimedia.org/r/177932 [22:33:25] (03Merged) 10jenkins-bot: Ensure clipboard key is removed from paste target [VisualEditor/VisualEditor] (wmf/1.25wmf11) - 10https://gerrit.wikimedia.org/r/177930 (owner: 10Catrope) [22:34:50] (03CR) 10Alex Monk: "Obviously, I didn't mean to approve this." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/176861 (owner: 10Alex Monk) [22:36:06] MatmaRex: https://gerrit.wikimedia.org/r/#/c/165922/26/includes/resourceloader/ResourceLoaderImageModule.php,unified [22:36:09] thoughts? [22:36:30] (see comment line ~260) [22:37:51] (03CR) 10Catrope: Disable Apply Changes in reference dialog until changes have been made (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/176861 (owner: 10Alex Monk) [22:42:10] TrevorParscal: looking [22:44:46] (03CR) 10Catrope: [C: 032] "Merging because this improves the situation, but it doesn't fix the bug. You can still make a change and then undo it, or change the group" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/176861 (owner: 10Alex Monk) [22:46:16] TrevorParscal: responded, i agree with you guys on this [22:46:28] (03Merged) 10jenkins-bot: Disable Apply Changes in reference dialog until changes have been made [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/176861 (owner: 10Alex Monk) [22:49:39] (03PS1) 10Catrope: Update VE core for cherry-pick [extensions/VisualEditor] (wmf/1.25wmf11) - 10https://gerrit.wikimedia.org/r/177935 [22:50:00] MatmaRex: My initial opinion was that double-embedding is bad, but Trevor convinced me with the argument that a lot of browsers that need -webkit are mobile [22:50:13] Especially once I found the Chinese one with 0.2% US market share but almost 3% global [22:54:35] (03CR) 10Mvolz: [C: 04-1] "Almost there! Looks good!" (037 comments) [services/citoid] - 10https://gerrit.wikimedia.org/r/177478 (owner: 10Sn1per) [22:58:16] (03PS9) 10Sn1per: Implement BibTeX export format [services/citoid] - 10https://gerrit.wikimedia.org/r/177478 [23:13:16] (03CR) 10Mvolz: [C: 032 V: 032] "Woo!" [services/citoid] - 10https://gerrit.wikimedia.org/r/177478 (owner: 10Sn1per) [23:17:48] 3VisualEditor, VisualEditor-EditingTools: Find field - NaN is displayed - https://phabricator.wikimedia.org/T76811#822811 (10Etonkovidova) [23:19:22] (03PS1) 10Catrope: Update VE core for cherry-pick [extensions/VisualEditor] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/177941 [23:19:40] (03CR) 10Catrope: [C: 032] Update VE core for cherry-pick [extensions/VisualEditor] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/177941 (owner: 10Catrope) [23:19:42] (03CR) 10Sn1per: "Hooray! thanks for all the help :D" [services/citoid] - 10https://gerrit.wikimedia.org/r/177478 (owner: 10Sn1per) [23:19:53] (03CR) 10Catrope: [C: 032] Update VE core for cherry-pick [extensions/VisualEditor] (wmf/1.25wmf11) - 10https://gerrit.wikimedia.org/r/177935 (owner: 10Catrope) [23:22:29] (03Merged) 10jenkins-bot: Update VE core for cherry-pick [extensions/VisualEditor] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/177941 (owner: 10Catrope) [23:22:33] (03Merged) 10jenkins-bot: Update VE core for cherry-pick [extensions/VisualEditor] (wmf/1.25wmf11) - 10https://gerrit.wikimedia.org/r/177935 (owner: 10Catrope) [23:23:27] edsanders|away: git show b392d88f src/ce/ve.ce.Surface.js [23:24:09] edsanders|away: So you moved $cursorHolder.remove() from deferred (inside the setTimeout) to immediate (outside the setTimeout), that seems very weird. Any idea why you did that? [23:24:28] Because now that code injects a span, puts the cursor in it, then immediately removes the span again [23:24:41] Rather than only removing it after the key event was processed [23:28:55] (03PS3) 10Mvolz: Package.json: Add contributors field [services/citoid] - 10https://gerrit.wikimedia.org/r/177516 [23:34:00] (03PS2) 10Jforrester: Follow-up I859ff276e: Add cursor files to repo [oojs/ui] - 10https://gerrit.wikimedia.org/r/177932 (owner: 10Trevor Parscal) [23:36:20] (03CR) 10Jforrester: [C: 031] Follow-up I859ff276e: Add cursor files to repo [oojs/ui] - 10https://gerrit.wikimedia.org/r/177932 (owner: 10Trevor Parscal) [23:36:26] RoanKattouw: ^^^ Sanity-check? [23:41:51] (03CR) 10Catrope: [C: 032] Follow-up I859ff276e: Add cursor files to repo [oojs/ui] - 10https://gerrit.wikimedia.org/r/177932 (owner: 10Trevor Parscal) [23:43:41] 3VisualEditor: Pasting an external link adds a ☀ - https://phabricator.wikimedia.org/T76916 (10NemesisIII) 3NEW p:3Triage [23:44:57] (03Merged) 10jenkins-bot: Follow-up I859ff276e: Add cursor files to repo [oojs/ui] - 10https://gerrit.wikimedia.org/r/177932 (owner: 10Trevor Parscal) [23:45:12] 3VisualEditor: Pasting an external link adds a ☀ - https://phabricator.wikimedia.org/T76916#822859 (10Catrope) James says: "pasting into a slug sometimes but not always inserts the ☀ placeholder but not the ☂ placeholder". From the example diff it looks like that's what's going on. [23:45:27] 3VisualEditor-ContentEditable, VisualEditor: Pasting an external link adds a ☀ - https://phabricator.wikimedia.org/T76916#822861 (10Catrope) a:3Esanders [23:51:46] (03PS1) 10Alex Monk: Don't re-enable apply changes in reference dialog if the changes have been undone [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/177944 [23:53:31] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/177943/ look sane? [23:55:39] 3VisualEditor-CopyPaste, VisualEditor: Pasting an external link adds a ☀ - https://phabricator.wikimedia.org/T76916#822894 (10Jdforrester-WMF) p:5Triage>3High [23:57:37] 3VisualEditor: Allow undoing/fixing edits from the 'Review your changes' tab - https://phabricator.wikimedia.org/T76898#822910 (10Jdforrester-WMF) p:5Triage>3Low [23:57:46] 3VisualEditor: Allow undoing/fixing edits from the 'Review your changes' tab - https://phabricator.wikimedia.org/T76898#822410 (10Jdforrester-WMF) [23:57:57] (03CR) 10Alex Monk: "Done in I0450ab59" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/176861 (owner: 10Alex Monk)