[00:03:31] 3VisualEditor, Analytics-EventLogging, Analytics: http://edit-reportcard.wmflabs.org/ doesn't seem to be getting updates (cron job not running yet?) - https://phabricator.wikimedia.org/T76921#822918 (10Jdforrester-WMF) [00:15:00] (03CR) 10Jforrester: [C: 032] IconElement: Add missing #getIconTitle [oojs/ui] - 10https://gerrit.wikimedia.org/r/177813 (owner: 10Bartosz Dziewoński) [00:15:25] 3OOjs-UI: Add getIconTitle, same as getIndicatorTitle, to OO.ui.IconElement - https://phabricator.wikimedia.org/T76639#822941 (10Jdforrester-WMF) 5Open>3Resolved [00:17:23] (03Merged) 10jenkins-bot: IconElement: Add missing #getIconTitle [oojs/ui] - 10https://gerrit.wikimedia.org/r/177813 (owner: 10Bartosz Dziewoński) [00:19:40] (03PS1) 10Divec: WIP: Native leftarrow, rightarrow, backspace and delete [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177946 [00:20:51] (03CR) 10Trevor Parscal: [C: 032] [BREAKING CHANGE] Rename BookletLayout#getPageName → #getCurrentPageName [oojs/ui] - 10https://gerrit.wikimedia.org/r/177799 (owner: 10Bartosz Dziewoński) [00:21:07] (03CR) 10jenkins-bot: [V: 04-1] WIP: Native leftarrow, rightarrow, backspace and delete [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177946 (owner: 10Divec) [00:21:46] (03CR) 10Trevor Parscal: [C: 032] SelectWidget: Rewrite #getRelativeSelectableItem [oojs/ui] - 10https://gerrit.wikimedia.org/r/177853 (owner: 10Bartosz Dziewoński) [00:23:05] (03CR) 10Trevor Parscal: [C: 032] [BREAKING CHANGE] Make a number of Element getters static [oojs/ui] - 10https://gerrit.wikimedia.org/r/177795 (owner: 10Bartosz Dziewoński) [00:23:27] 3OOjs-UI: Rename a lot of getters for consistency - https://phabricator.wikimedia.org/T76630#822948 (10matmarex) But why?! :) [00:24:02] 3OOjs-UI: Rename a lot of getters for consistency - https://phabricator.wikimedia.org/T76630#822949 (10matmarex) [00:24:04] (03Merged) 10jenkins-bot: SelectWidget: Rewrite #getRelativeSelectableItem [oojs/ui] - 10https://gerrit.wikimedia.org/r/177853 (owner: 10Bartosz Dziewoński) [00:24:08] 3OOjs-UI: Rename a lot of getters for consistency - https://phabricator.wikimedia.org/T76630#822950 (10Krenair) [00:25:49] (03Merged) 10jenkins-bot: [BREAKING CHANGE] Make a number of Element getters static [oojs/ui] - 10https://gerrit.wikimedia.org/r/177795 (owner: 10Bartosz Dziewoński) [00:25:56] (03Merged) 10jenkins-bot: [BREAKING CHANGE] Rename BookletLayout#getPageName → #getCurrentPageName [oojs/ui] - 10https://gerrit.wikimedia.org/r/177799 (owner: 10Bartosz Dziewoński) [00:29:05] (03PS1) 10Jforrester: Tag v0.4.0 [oojs/ui] - 10https://gerrit.wikimedia.org/r/177947 [00:29:55] (03CR) 10Trevor Parscal: [C: 032] Tag v0.4.0 [oojs/ui] - 10https://gerrit.wikimedia.org/r/177947 (owner: 10Jforrester) [00:30:44] 3OOjs-UI: OOjs UI: optionWidget with check icon should not appear for invalid entries in the category input field. - https://phabricator.wikimedia.org/T74000#822973 (10Liuxinyu970226) [00:32:01] we're going to run out of numbers soon if we keep up this pace. [00:32:02] 3OOjs-UI: Remove deprecated Element#onDOMEvent and #offDOMEvent - https://phabricator.wikimedia.org/T76861#822976 (10Jdforrester-WMF) 5Open>3Resolved [00:32:28] (03Merged) 10jenkins-bot: Tag v0.4.0 [oojs/ui] - 10https://gerrit.wikimedia.org/r/177947 (owner: 10Jforrester) [00:32:29] MatmaRex: 0.23.45 is a valid number in our scheme. Worry not. :-) [00:33:00] James_F: i wonder which tools break when your version number exceeds MAX_INT. [00:39:22] 3VisualEditor, Analytics-EventLogging, Analytics: http://edit-reportcard.wmflabs.org/ doesn't seem to be getting updates (cron job not running yet?) - https://phabricator.wikimedia.org/T76921#822988 (10Liuxinyu970226) [00:54:28] (03CR) 10Catrope: [C: 032] Don't re-enable apply changes in reference dialog if the changes have been undone [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/177944 (owner: 10Alex Monk) [00:56:12] (03Merged) 10jenkins-bot: Don't re-enable apply changes in reference dialog if the changes have been undone [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/177944 (owner: 10Alex Monk) [01:21:47] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: Dialogs should disable "Apply changes" until a change is present - https://phabricator.wikimedia.org/T57976#823009 (10Krenair) [01:22:08] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: Dialogs should disable "Apply changes" until a change is present - https://phabricator.wikimedia.org/T57976#610243 (10Krenair) I kind of wish this had been broken into one bug for each dialog. [01:36:12] (03PS2) 10Jforrester: Update OOjs UI to v0.4.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177721 [01:36:21] (03Abandoned) 10Jforrester: Update for I9ee6a9ec in OOUI [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177796 (owner: 10Bartosz Dziewoński) [01:39:10] 3OOjs-UI: Make a number of Element getters static - https://phabricator.wikimedia.org/T76631#823034 (10Jdforrester-WMF) 5Open>3Resolved [01:40:08] 3VisualEditor, Analytics-EventLogging, Analytics: http://edit-reportcard.wmflabs.org/ doesn't seem to be getting updates (cron job not running yet?) - https://phabricator.wikimedia.org/T76921#823036 (10Jdforrester-WMF) [01:43:47] 3VisualEditor-MediaWiki-Templates, VisualEditor: The transclusion dialog should disable the "Apply changes" button until a change is present - https://phabricator.wikimedia.org/T76926 (10Jdforrester-WMF) 3NEW p:3Normal a:3Krenair [01:44:12] 3VisualEditor-MediaWiki-References, VisualEditor: The citation dialog should disable the "Apply changes" button until a change is present - https://phabricator.wikimedia.org/T76927 (10Jdforrester-WMF) 3NEW p:3Normal a:3Krenair [01:44:36] 3VisualEditor-MediaWiki-References, VisualEditor: The reference dialog should disable the "Apply changes" button until a change is present - https://phabricator.wikimedia.org/T76928 (10Jdforrester-WMF) 3NEW p:3Normal a:3Krenair [01:44:59] 3VisualEditor-MediaWiki-References, VisualEditor, VisualEditor-MediaWiki-Templates: The citation dialog should disable the "Apply changes" button until a change is present - https://phabricator.wikimedia.org/T76927#823045 (10Jdforrester-WMF) [01:45:15] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: Dialogs should disable "Apply changes" until a change is present - https://phabricator.wikimedia.org/T57976#823062 (10Jdforrester-WMF) >>! In T57976#823009, @Krenair wrote: > I kind of wish this had been broken into one bug for each dialog. Done. :-) [01:51:26] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: Dialogs should disable "Apply changes" until a change is present - https://phabricator.wikimedia.org/T57976#823066 (10Krenair) So this is now a tracker? [01:53:28] James_F, and they're all assigned to me? :/ [01:54:13] 3VisualEditor-MediaWiki-References, VisualEditor: The reference dialog should disable the "Apply changes" button until a change is present - https://phabricator.wikimedia.org/T76928#823067 (10Krenair) [01:56:30] Krenair: 'Cos I was duplicating from the first. Feel free to unassign. [01:56:38] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: Dialogs should disable "Apply changes" until a change is present - https://phabricator.wikimedia.org/T57976#823071 (10Jdforrester-WMF) [01:57:53] I wonder if transclusion and citation could be done as one in the template dialog [01:59:17] Krenair: Possibly; I split them as it might be fiddly. [02:00:00] I'm not going to unassign now, but may do on monday after looking into what it would require some more [02:00:32] (03PS2) 10Jforrester: Update for I9ee6a9ec in OOUI [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/177797 (owner: 10Bartosz Dziewoński) [02:00:44] (03CR) 10Jforrester: "PS2 adds a wfUseMW update for when OOjs UI 0.4.0 lands in MW." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/177797 (owner: 10Bartosz Dziewoński) [02:00:47] Krenair: Cool. [02:02:30] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.4.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177721 (owner: 10Jforrester) [02:04:44] (03Merged) 10jenkins-bot: Update OOjs UI to v0.4.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177721 (owner: 10Jforrester) [05:27:08] 3VisualEditor-MediaWiki, VisualEditor: [Regression pre-wmf12]- “Uncaught TypeError: undefined is not a function” when selecting the indicator-down arrow and the pop-up overrides the category. - https://phabricator.wikimedia.org/T76931 (10Swainr) 3NEW p:3Normal [05:27:53] 3VisualEditor-MediaWiki, VisualEditor: [Regression pre-wmf12]- “Uncaught TypeError: undefined is not a function” when selecting the indicator-down arrow and the pop-up overrides the category. - https://phabricator.wikimedia.org/T76931#823117 (10Swainr) {F19139} [05:32:03] 3VisualEditor-MediaWiki, VisualEditor: [Regression wmf11]Cannot set “Sort this page by default as” for the individual Categories. - https://phabricator.wikimedia.org/T76707#823125 (10Swainr) Cannot reproduce either.But, I get "Uncaught TypeError: undefined is not a function” on selecting the indicator down arrow... [05:36:32] 3VisualEditor-MediaWiki, VisualEditor: Same Category get added multiple times ,for every change in “Sort this page by default as” value. - https://phabricator.wikimedia.org/T76715#823126 (10Swainr) I can reproduce it, both in beta and test2. The step#5 is the key. [07:36:20] 3VisualEditor: Allow undoing/fixing edits from the 'Review your changes' tab - https://phabricator.wikimedia.org/T76898#823171 (10MZMcBride) [09:18:15] 3MediaWiki-extensions-WikiEditor: Clicking on the wiki toolbar buttons more than one time mixes up the wiki syntax - https://phabricator.wikimedia.org/T28979#823183 (10Pranavmk98) [09:52:17] (03PS7) 10Esanders: [BREAKING CHANGE] Refactor for multiple surfaces [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/176952 [09:52:19] (03PS6) 10Esanders: [BREAKING CHANGE] Multiple surface support and demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177109 [09:52:21] (03PS6) 10Esanders: Refactor out trigger listening to allow target triggers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/176955 [09:57:52] RoanKattouw_away, the answer is usually Firefox - I remember fiddling about with that until it worked in all browsers. [09:58:23] the edge cases were cursoring off focusable nodes and from the end of regular nodes (e.g. links) [12:40:51] (03PS4) 10Gerrit Patch Uploader: Workaround for a scrolling bug in IE8 on resize [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/115378 [12:40:54] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/115378 (owner: 10Gerrit Patch Uploader) [13:30:03] 3VisualEditor-ContentEditable, VisualEditor: data-ve-clipboard-key span inserted in page - https://phabricator.wikimedia.org/T76749#823263 (10NemesisIII) [15:34:57] (03PS33) 10Paladox: WikiEditor: Convert .css to .less and add Arrow SVG images [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151616 [15:41:12] (03PS67) 10Paladox: WikiEditor: Convert .css to .less and also fixes SVG issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 [15:54:38] (03CR) 10Bartosz Dziewoński: [C: 032] Workaround for a scrolling bug in IE8 on resize [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/115378 (owner: 10Gerrit Patch Uploader) [15:54:42] (03Merged) 10jenkins-bot: Workaround for a scrolling bug in IE8 on resize [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/115378 (owner: 10Gerrit Patch Uploader) [15:55:00] 3MediaWiki-extensions-WikiEditor: textarea scrolls up in IE8 on resize - https://phabricator.wikimedia.org/T63910#823326 (10matmarex) 5Open>3Resolved [17:16:15] (03PS4) 10Danmichaelo: Package.json: Add contributors field [services/citoid] - 10https://gerrit.wikimedia.org/r/177516 (owner: 10Mvolz) [17:19:33] (03PS5) 10Danmichaelo: Package.json: Add contributors field [services/citoid] - 10https://gerrit.wikimedia.org/r/177516 (owner: 10Mvolz) [17:22:18] (03CR) 10Danmichaelo: [C: 031] Package.json: Add contributors field [services/citoid] - 10https://gerrit.wikimedia.org/r/177516 (owner: 10Mvolz) [17:30:39] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=109720006 [17:30:39] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=109721685 [17:30:39] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=109722306 [17:30:39] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=67187513 [17:30:39] Corruption alert: visualeditor-needcheck on ptwiki: https://pt.wikipedia.org/?diff=40783316 [17:30:40] Corruption alert: visualeditor-needcheck on ptwiki: https://pt.wikipedia.org/?diff=40783320 [18:06:12] (03PS1) 10Krinkle: build: Use String#slice instead of discouraged String#substr [unicodejs] - 10https://gerrit.wikimedia.org/r/177992 [18:08:13] (03PS1) 10Krinkle: build: Use String#slice instead of discouraged String#substr [oojs/ui] - 10https://gerrit.wikimedia.org/r/177994 [18:11:23] (03PS2) 10Krinkle: Use String#slice instead of discouraged String#substr [unicodejs] - 10https://gerrit.wikimedia.org/r/177992 [18:41:39] (03PS1) 10Krinkle: Element: Use $.context instead of recomputing in #getElementDocument [oojs/ui] - 10https://gerrit.wikimedia.org/r/177997 [18:51:32] (03PS1) 10Krinkle: build: Use String#slice instead of discouraged String#substr [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177998 [18:51:55] (03PS2) 10Krinkle: Use String#slice instead of discouraged String#substr [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177998 [18:55:02] 3VisualEditor: Heading of template editor is misaligned, possibly fr.wiki only - https://phabricator.wikimedia.org/T76947 (10Eloquence) 3NEW p:3Triage [18:55:21] (03PS2) 10Krinkle: Element: Use $.context instead of recomputing in #getElementDocument [oojs/ui] - 10https://gerrit.wikimedia.org/r/177997 [18:56:27] 3VisualEditor: Heading of template editor is misaligned, possibly fr.wiki only - https://phabricator.wikimedia.org/T76947#823411 (10Eloquence) {F19186} [18:58:50] 3VisualEditor: Heading of template editor is misaligned, possibly fr.wiki only - https://phabricator.wikimedia.org/T76947#823421 (10matmarex) This is the same issue as T70571, where this has been declined (the suggested solution is to make the button labels shorter). The abandoned patch https://gerrit.wikimedia.... [19:01:25] 3VisualEditor: Heading of template editor is misaligned, possibly fr.wiki only - https://phabricator.wikimedia.org/T76947#823425 (10matmarex) [19:02:49] MatmaRex, merge the ticket? [19:03:29] Krenair: that would imply that i agree with it being declined, and i don't quite. :) [19:03:36] no it wouldn't [19:04:01] (03PS2) 10Krinkle: bin: Update update-unicodejs.sh to parity with update-oojs.sh [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177583 (owner: 10Jforrester) [19:07:38] 3VisualEditor: Heading of template editor is misaligned, possibly fr.wiki only - https://phabricator.wikimedia.org/T76947#823426 (10Eloquence) [19:08:00] (03CR) 10Mvolz: [C: 032 V: 032] Package.json: Add contributors field [services/citoid] - 10https://gerrit.wikimedia.org/r/177516 (owner: 10Mvolz) [19:11:17] (03PS1) 10Krinkle: Use String#slice instead of discouraged String#substr [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178000 [19:13:06] (03CR) 10jenkins-bot: [V: 04-1] Use String#slice instead of discouraged String#substr [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178000 (owner: 10Krinkle) [19:13:09] (03PS1) 10Krinkle: Restrict Verified+1/2 and Submit to JenkinsBot and l10n-bot [services/citoid] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/178001 [19:13:30] (03CR) 10Krinkle: [C: 032 V: 032] Restrict Verified+1/2 and Submit to JenkinsBot and l10n-bot [services/citoid] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/178001 (owner: 10Krinkle) [19:18:33] 3VisualEditor-MediaWiki, VisualEditor: [Regression wmf11]Cannot set “Sort this page by default as” for the individual Categories. - https://phabricator.wikimedia.org/T76707#823428 (10Jdforrester-WMF) [19:44:14] 3VisualEditor: Heading of template editor is misaligned, possibly fr.wiki only - https://phabricator.wikimedia.org/T76947#823438 (10Elitre) Same at the German Wikipedia (check the Saving dialog). The French workaround to this one was changing the equivalent of "Save your changes" to "Contribution"... [20:27:51] Heya. [20:27:55] hi [20:29:10] (03PS3) 10Jforrester: Update VE core submodule to master (32397d8) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/177797 (owner: 10Bartosz Dziewoński) [20:29:27] (03CR) 10Jforrester: [C: 032] Update VE core submodule to master (32397d8) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/177797 (owner: 10Bartosz Dziewoński) [20:31:17] (03Merged) 10jenkins-bot: Update VE core submodule to master (32397d8) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/177797 (owner: 10Bartosz Dziewoński) [20:36:41] 3Citoid, VisualEditor: Expose the production citoid service publicly so we can start switching scripts over to use it - https://phabricator.wikimedia.org/T76949#823454 (10Jdforrester-WMF) [20:37:31] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: Automatically convert inserted URLs to readable formatted links - https://phabricator.wikimedia.org/T67540#823469 (10Jdforrester-WMF) [20:38:23] 3Design, VisualEditor, VisualEditor-EditingTools: Auto-filled references based on destination URL / ISBN / etc. - https://phabricator.wikimedia.org/T62768#823470 (10Jdforrester-WMF) [21:02:52] 3Citoid, VisualEditor: Expose the production citoid service publicly so we can start switching scripts over to use it - https://phabricator.wikimedia.org/T76949#823474 (10Krenair) [21:06:09] (03CR) 10Catrope: [C: 032] Element: Use $.context instead of recomputing in #getElementDocument [oojs/ui] - 10https://gerrit.wikimedia.org/r/177997 (owner: 10Krinkle) [21:08:43] (03Merged) 10jenkins-bot: Element: Use $.context instead of recomputing in #getElementDocument [oojs/ui] - 10https://gerrit.wikimedia.org/r/177997 (owner: 10Krinkle) [21:15:38] (03CR) 10Jforrester: "Ping. What can I do to help move this forward?" [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/168746 (owner: 10Mvolz) [21:16:44] 3OOjs-UI: Create an ActionFieldLayout - https://phabricator.wikimedia.org/T76634#823479 (10Jdforrester-WMF) a:3Mooeypoo [21:16:55] (03PS2) 10Jforrester: [wip] Add an ActionFieldLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/175568 (owner: 10Mooeypoo) [21:16:58] (03CR) 10jenkins-bot: [V: 04-1] [wip] Add an ActionFieldLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/175568 (owner: 10Mooeypoo) [21:18:46] [13oojs.github.io] 15jdforrester created 06oojs-ui-0.4.0 (+1 new commit): 02https://github.com/oojs/oojs.github.io/commit/aab4ead6076a [21:18:49] 13oojs.github.io/06oojs-ui-0.4.0 14aab4ead 15James D. Forrester: Add OOjs UI 0.4.0 release from npm [21:19:13] Krinkle|detached: Ping when you're around? What do you want to do with the OOjs UI releases? [21:21:09] James_F: Can I schedule the copypaste cherry-pick for the Monday 8am SWAT? [21:21:15] RoanKattouw: Sure. [21:21:19] k [21:23:12] (03PS3) 10Jforrester: [WIP] Add an ActionFieldLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/175568 (owner: 10Mooeypoo) [21:23:14] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Add an ActionFieldLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/175568 (owner: 10Mooeypoo) [21:24:51] (03CR) 10Catrope: [C: 032] Use String#slice instead of discouraged String#substr [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177998 (owner: 10Krinkle) [21:25:30] (03CR) 10Catrope: [C: 032] Use String#slice instead of discouraged String#substr [unicodejs] - 10https://gerrit.wikimedia.org/r/177992 (owner: 10Krinkle) [21:26:16] (03Merged) 10jenkins-bot: Use String#slice instead of discouraged String#substr [unicodejs] - 10https://gerrit.wikimedia.org/r/177992 (owner: 10Krinkle) [21:26:22] (03PS2) 10Catrope: Use String#slice instead of discouraged String#substr [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178000 (owner: 10Krinkle) [21:27:15] (03Merged) 10jenkins-bot: Use String#slice instead of discouraged String#substr [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177998 (owner: 10Krinkle) [21:34:11] (03CR) 10Catrope: [C: 032] Use String#slice instead of discouraged String#substr [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178000 (owner: 10Krinkle) [21:35:52] (03Merged) 10jenkins-bot: Use String#slice instead of discouraged String#substr [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178000 (owner: 10Krinkle) [21:38:52] (03PS4) 10Jforrester: [WIP] Add an ActionFieldLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/175568 (owner: 10Mooeypoo) [21:39:19] (03CR) 10Jforrester: "PS3 fixes a jsduck typo." [oojs/ui] - 10https://gerrit.wikimedia.org/r/175568 (owner: 10Mooeypoo) [21:39:33] (03CR) 10Catrope: [C: 032] Fix href parsing in transclusion nodes when on alternative (e.g. mobile) domains/paths [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/177875 (owner: 10Alex Monk) [21:40:11] (03CR) 10Catrope: [C: 032] build: Use String#slice instead of discouraged String#substr [oojs/ui] - 10https://gerrit.wikimedia.org/r/177994 (owner: 10Krinkle) [21:40:44] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/177583/ is trivial. [21:41:15] (03Merged) 10jenkins-bot: Fix href parsing in transclusion nodes when on alternative (e.g. mobile) domains/paths [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/177875 (owner: 10Alex Monk) [21:41:37] (03CR) 10Catrope: [C: 032] bin: Update update-unicodejs.sh to parity with update-oojs.sh [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177583 (owner: 10Jforrester) [21:41:40] (03CR) 10Jforrester: [C: 031] Trim whitespace when annotating [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177533 (owner: 10Esanders) [21:41:46] Ta. [21:42:07] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/176952/7 and stack? [21:42:30] No I'm about to head out actually [21:42:40] OK. Coming to grab your bike? [21:42:47] Eventually [21:42:58] OK. I won't throw it out a window, then. ;-) [21:44:07] Krenair: BTW, you are aware that echo doesn't work in LQT, right? "Ping [[User:DChan (WMF)]] :)" is not just ineffective but makes it look like you've done something when you haven't… [21:44:10] 3VisualEditor-TechnicalDebt, VisualEditor: Use $.parseHTML's context argument rather than manually transplanting stuff with ve.copyDomElements - https://phabricator.wikimedia.org/T76374#823485 (10Krenair) [21:44:40] James_F, hm, it doesn't? I thought we had code for that... [21:44:49] Krenair: In Flow but not LQT, I believe. [21:44:53] (03Merged) 10jenkins-bot: build: Use String#slice instead of discouraged String#substr [oojs/ui] - 10https://gerrit.wikimedia.org/r/177994 (owner: 10Krinkle) [21:45:04] I haven't looked at Echo's code for a while. . . [21:45:06] Krenair: I've come across people "pinging" me in threads days or weeks later. [21:45:19] (03Merged) 10jenkins-bot: bin: Update update-unicodejs.sh to parity with update-oojs.sh [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177583 (owner: 10Jforrester) [21:46:04] (03CR) 10Jforrester: "Ping?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118758 (owner: 10Jforrester) [21:46:28] Ah, we haven't had it for two years: https://gerrit.wikimedia.org/r/#/c/39318/ [21:46:50] Hmm. [21:46:52] No bug link. [21:46:56] Unhelpful. [21:54:33] (03PS3) 10Jforrester: Restore papaparse [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/176654 (owner: 10Esanders) [21:58:00] (03CR) 10Jforrester: [C: 031] Restore papaparse [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/176654 (owner: 10Esanders) [22:00:58] (03CR) 10Jforrester: "OOUI styles module is created by I56e7802c (not yet merged); VE would need to depend on it and thus load it in top on all pages. Ouch. :-(" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175488 (owner: 10Esanders) [22:04:10] (03CR) 10Mvolz: "Kaity's mockups are substantially different than what is here, and requires changes to other VE components, so I've just recently abandone" [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/168746 (owner: 10Mvolz) [22:05:08] (03CR) 10Jforrester: "Well, getting the design right can be done once the code is in production to a large extent; just getting it out there will give us feedba" [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/168746 (owner: 10Mvolz) [22:06:16] James_F, I don't know if LQT's Echo could would still work if it was uncommented. [22:06:49] (03CR) 10Mvolz: "Gotcha :)." [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/168746 (owner: 10Mvolz) [22:06:56] Krenair: Given that LQT is going to be de-deployed in a few weeks, I'd not bother worrying. [22:24:50] (03CR) 10Krinkle: Trim whitespace when annotating (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177533 (owner: 10Esanders) [22:25:31] Krinkle: https://gerrit.wikimedia.org/r/#/c/174619/ is +2'ed but not merged – was it deployed and you forgot, or is it outstanding? [22:28:16] Deployed (as per comment). [22:28:30] Ah, OK. [22:28:31] jjb-config git is only a log. Merging must only happen post-deploy. [22:28:34] thx [22:28:49] Just was hoping something wasn't broken. :-) [22:28:55] (so that nothing based on another commit can cause an accidental deployment) [22:28:59] James_F: It's ff-only [22:29:05] fast-forward [22:29:08] hence wasn't merged [22:29:10] Right. [22:30:06] Hey mvolz. :-) [22:54:07] 3MediaWiki-extensions-WikiEditor: Clicking on the wiki toolbar buttons more than one time mixes up the wiki syntax - https://phabricator.wikimedia.org/T28979#823528 (10GOIII) Of course the default example text -- in this case the phrase 'Bold text' -- would be the target for bolding; no existing text was selecte... [23:18:25] 3OOjs-UI: CheckboxInput doesn't support string value, forces boolean and won't work with many use cases in HTML static forms - https://phabricator.wikimedia.org/T76645#823543 (10Jdforrester-WMF) p:5High>3Normal [23:18:35] 3OOjs-UI: Consider changing toggle to toggleVisibility - https://phabricator.wikimedia.org/T76644#823546 (10Jdforrester-WMF) p:5High>3Normal [23:18:42] 3OOjs-UI: MenuOptionWidget: Make more flexible to cover MenuSectionOptionWidget and cases like these (e.g. breaks) - https://phabricator.wikimedia.org/T76647#823547 (10Jdforrester-WMF) [23:19:33] 3OOjs-UI: Provide an RTL variant of the 'help' icon, but don't use it for he and yi - https://phabricator.wikimedia.org/T76540#823551 (10Jdforrester-WMF)