[02:25:04] 3VisualEditor, VisualEditor-InterfaceLanguage, VisualEditor-ContentLanguage: VisualEditor: Support for right-to-left (rtl) / bidirectional content (tracking) - https://phabricator.wikimedia.org/T35126#824167 (10Krinkle) [02:25:09] 3VisualEditor: VisualEditor: Non-English Wikipedia issues (tracking) - https://phabricator.wikimedia.org/T53792#824168 (10Krinkle) [02:25:13] 3VisualEditor, VisualEditor-ContentLanguage: VisualEditor multilingual input / i18n issues (tracking) - https://phabricator.wikimedia.org/T35077#824169 (10Krinkle) [03:41:56] 3MediaWiki-Page-editing: Notify user when username used in an edit summary - https://phabricator.wikimedia.org/T32750#824179 (10Gryllida) [03:51:24] 3MediaWiki-Page-editing: Deleting a page should not affect the old protection - https://phabricator.wikimedia.org/T14343#824194 (10Krenair) [03:56:37] 3OOjs-UI: OOjs UI: Dialogs should be repositionable/draggable - https://phabricator.wikimedia.org/T51969#824196 (10Whatamidoing-WMF) Making the dialog one-third the width of the screen is only going to make sense on a desktop system. One third the width of a smartphone screen is not going to be functional (the... [07:01:21] Hi. Anyone around? [07:52:32] hi llelly [08:24:49] hello :) [08:28:15] was hoping someone could clarify the status of the visual editor for installation on private sites [08:28:19] im running into a lot of bugs xD [08:33:25] Ill come back later maybe more ppl around :) [09:23:02] 3MediaWiki-extensions-WikiEditor: Show the localized value for "thumb" in the help section of the toolbar - https://phabricator.wikimedia.org/T40831#824415 (10Schnark) No, since "thumb" must be localized in the wiki's language, while the help text is in the user's language. This is the same as for the namespace,... [09:33:50] 3MediaWiki-Page-editing: Inform author of successful edit conflict resolution - https://phabricator.wikimedia.org/T76997 (10Schnark) 3NEW p:3Triage [09:42:03] 3MobileFrontend-Hygiene, VisualEditor-TechnicalDebt, Project-Management, Wikidata: Create technical-debt project - https://phabricator.wikimedia.org/T75892#824439 (10Qgil) [09:56:55] 3VisualEditor: Random removal of categories - https://phabricator.wikimedia.org/T76998 (10Elitre) 3NEW p:3Triage [10:00:31] 3MediaWiki-extensions-WikiEditor: Show the localized value for "thumb" in the help section of the toolbar - https://phabricator.wikimedia.org/T40831#824461 (10TheDJ) Namespaces in JS are exposed trough wgFormattedNamespaces, but most parts of the localized wiki syntax is not exposed in any way whatsoever and thi... [10:02:38] 3MediaWiki-extensions-WikiEditor: Text Editor : Copy and paste text from web pages and wiki editor (IE7) - https://phabricator.wikimedia.org/T24632#824462 (10TheDJ) 5Open>3declined a:3TheDJ Javascript on IE7 is no longer supported. [10:11:06] (03PS4) 10Prtksxna: Element.getClosestScrollableContainer: Use 'body' or 'documentElement' based on browser [oojs/ui] - 10https://gerrit.wikimedia.org/r/176666 [10:13:38] (03CR) 10jenkins-bot: [V: 04-1] Element.getClosestScrollableContainer: Use 'body' or 'documentElement' based on browser [oojs/ui] - 10https://gerrit.wikimedia.org/r/176666 (owner: 10Prtksxna) [10:23:28] (03PS5) 10Prtksxna: Element.getClosestScrollableContainer: Use 'body' or 'documentElement' based on browser [oojs/ui] - 10https://gerrit.wikimedia.org/r/176666 [10:25:14] 3MediaWiki-extensions-WikiEditor: Undo/Redo doesn't work in Chrome/Chromium/Firefox for WikiEditor 0.3.1 in MW 1.19.2 - https://phabricator.wikimedia.org/T45187#824519 (10happy5214) [10:25:56] (03CR) 10jenkins-bot: [V: 04-1] Element.getClosestScrollableContainer: Use 'body' or 'documentElement' based on browser [oojs/ui] - 10https://gerrit.wikimedia.org/r/176666 (owner: 10Prtksxna) [10:26:48] (03PS6) 10Prtksxna: Element.getClosestScrollableContainer: Use 'body' or 'documentElement' based on browser [oojs/ui] - 10https://gerrit.wikimedia.org/r/176666 [10:28:18] (03CR) 10Prtksxna: "> Needs to cache the value, and I'm also suspicious that if conditions were to change between calls you might get a different result even " (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/176666 (owner: 10Prtksxna) [10:35:33] 3MediaWiki-extensions-WikiEditor: Show the localized value for "thumb" in the help section of the toolbar - https://phabricator.wikimedia.org/T40831#824535 (10Schnark) [10:37:33] (03PS2) 10Prtksxna: Add PNG compression grunt task using 'pngmin' [oojs/ui] - 10https://gerrit.wikimedia.org/r/176637 [10:37:35] (03PS2) 10Prtksxna: Add SVG compression grunt task using 'svgmin' [oojs/ui] - 10https://gerrit.wikimedia.org/r/176634 [10:39:45] (03CR) 10jenkins-bot: [V: 04-1] Add PNG compression grunt task using 'pngmin' [oojs/ui] - 10https://gerrit.wikimedia.org/r/176637 (owner: 10Prtksxna) [10:40:24] (03CR) 10Prtksxna: "> I think it would make sense for this task to happen immediately after the SVG files are copied, rather than after the PNGs are created f" [oojs/ui] - 10https://gerrit.wikimedia.org/r/176634 (owner: 10Prtksxna) [10:41:12] 3MediaWiki-extensions-WikiEditor: wikiEditor's replace function inserts string in wrong places - https://phabricator.wikimedia.org/T76750#824551 (10Aklapper) p:5Triage>3Low [10:46:44] (03CR) 10Prtksxna: "Bartosz, I have visually compared the icons with and without svgmin and they look the same." [oojs/ui] - 10https://gerrit.wikimedia.org/r/176634 (owner: 10Prtksxna) [10:47:17] (03PS3) 10Prtksxna: Add PNG compression grunt task using 'pngmin' [oojs/ui] - 10https://gerrit.wikimedia.org/r/176637 [10:47:19] (03PS3) 10Prtksxna: Add SVG compression grunt task using 'svgmin' [oojs/ui] - 10https://gerrit.wikimedia.org/r/176634 [10:49:39] (03CR) 10jenkins-bot: [V: 04-1] Add PNG compression grunt task using 'pngmin' [oojs/ui] - 10https://gerrit.wikimedia.org/r/176637 (owner: 10Prtksxna) [10:51:48] (03PS4) 10Prtksxna: Add PNG compression grunt task using 'pngmin' [oojs/ui] - 10https://gerrit.wikimedia.org/r/176637 [10:53:06] (03CR) 10jenkins-bot: [V: 04-1] Add PNG compression grunt task using 'pngmin' [oojs/ui] - 10https://gerrit.wikimedia.org/r/176637 (owner: 10Prtksxna) [11:01:49] 3VisualEditor, VisualEditor-MediaWiki-Links: Use [[ as a 'hotkey' trigger for opening the 'create a link' dialog - https://phabricator.wikimedia.org/T52093#824566 (10Elitre) [11:10:09] (03PS5) 10Prtksxna: Add PNG compression grunt task using 'pngmin' [oojs/ui] - 10https://gerrit.wikimedia.org/r/176637 [11:12:21] (03CR) 10jenkins-bot: [V: 04-1] Add PNG compression grunt task using 'pngmin' [oojs/ui] - 10https://gerrit.wikimedia.org/r/176637 (owner: 10Prtksxna) [11:15:49] (03PS6) 10Prtksxna: Add PNG compression grunt task using 'pngmin' [oojs/ui] - 10https://gerrit.wikimedia.org/r/176637 [11:18:02] (03CR) 10jenkins-bot: [V: 04-1] Add PNG compression grunt task using 'pngmin' [oojs/ui] - 10https://gerrit.wikimedia.org/r/176637 (owner: 10Prtksxna) [11:20:51] 3MediaWiki-Page-editing: Inform author of successful edit conflict resolution - https://phabricator.wikimedia.org/T76997#824600 (10Aklapper) [11:22:58] (03PS1) 10TheDJ: Toolbar help: Make magic word from help string a param [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/178180 [11:36:32] (03CR) 10Prtksxna: "Need the 'pngquant' package on Linux - https://github.com/zauni/pngmin#linux-users" [oojs/ui] - 10https://gerrit.wikimedia.org/r/176637 (owner: 10Prtksxna) [11:37:37] (03CR) 10Prtksxna: "Should we consider using something else? Suggestions?" [oojs/ui] - 10https://gerrit.wikimedia.org/r/176637 (owner: 10Prtksxna) [12:29:20] (03PS4) 10Prtksxna: MediaWiki Theme: Add radio buttons [oojs/ui] - 10https://gerrit.wikimedia.org/r/176398 [12:29:22] (03PS3) 10Prtksxna: MediaWiki Theme: checkbox: Fix states according to spec [oojs/ui] - 10https://gerrit.wikimedia.org/r/176397 [12:39:45] 3VisualEditor, VisualEditor-MediaWiki-Links: Use [[ as a 'hotkey' trigger for opening the 'create a link' dialog - https://phabricator.wikimedia.org/T52093#824679 (10Ironholds) [12:47:34] (03CR) 10Prtksxna: "Yup, its the same stuff barring a few things. Added the margin so that the two elements overlap properly." [oojs/ui] - 10https://gerrit.wikimedia.org/r/176397 (owner: 10Prtksxna) [12:48:46] (03CR) 10Prtksxna: "> Also there's a strange looking hover state that only triggers on small parts of the radio button." [oojs/ui] - 10https://gerrit.wikimedia.org/r/176398 (owner: 10Prtksxna) [14:45:40] 3VisualEditor, VisualEditor-CopyPaste: Pasting an external link adds a ☀ - https://phabricator.wikimedia.org/T76916#824955 (10Esanders) Can't reproduce, need more specific instructions. [14:58:11] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: [Regression wmf1] When the inspector is still open for a selected node, after placing the cursor in a different position, inspector flickers there - https://phabricator.wikimedia.org/T73151#825004 (10Esanders) [15:26:48] 3MediaWiki-Page-editing: Allow creation of revisionless page entries - https://phabricator.wikimedia.org/T43473#825038 (10Aklapper) >>! In T43473#823769, @Nemo_bis wrote: > James, please manually notify Platonides of your priority change (as he's not in phabricator yet). That doesn't make sense. Mail has been m... [15:55:57] * James_F waves. [16:06:42] 3MobileFrontend-Hygiene, VisualEditor-TechnicalDebt, Project-Management, Wikidata: Create technical-debt project - https://phabricator.wikimedia.org/T75892#825557 (10Jdforrester-WMF) >>! In T75892#824439, @Qgil wrote: >>>! In T75892#790593, @Jdforrester-WMF wrote: >> Rather than create a new project, just re-lab... [16:08:16] (03CR) 10Esanders: "As we compress files before they hit the repo - this seems like we're risking corruption for no benefit." [oojs/ui] - 10https://gerrit.wikimedia.org/r/176634 (owner: 10Prtksxna) [16:13:06] 3VisualEditor, VisualEditor-ContentEditable: data-ve-clipboard-key span inserted in page - https://phabricator.wikimedia.org/T76749#825673 (10Jdforrester-WMF) 5Open>3Resolved [16:25:16] when I make a redirect in VE, the format :mw:page... should work, right? [16:25:38] 3MediaWiki-JavaScript, MediaWiki-Interface, Librarization, MediaWiki-General-or-Unknown, MediaWiki-ResourceLoader: Merge projects javascript and MediaWiki-JavaScript - https://phabricator.wikimedia.org/T76269#826181 (10Jdforrester-WMF) >>! In T76269#818594, @matmarex wrote: >> I disagree with merging the tasks i... [16:26:40] Elitre: I think there's an issue where the redirect box doesn't let you pick "invalid" titles, and it doesn't recognise interwikis as valid (because MediaWiki doesn't) [16:27:22] 3VisualEditor, OOjs-UI: Tools in the toolbar do not have unique attributes - https://phabricator.wikimedia.org/T76143#826219 (10Esanders) The problem with letting people use these classes for gadgets is they then become an undocumented API. Trevor's point about greppability is that I should be able to see a clas... [16:28:09] 3MediaWiki-JavaScript, MediaWiki-Interface, Librarization, MediaWiki-General-or-Unknown, MediaWiki-ResourceLoader: Merge projects javascript and MediaWiki-JavaScript - https://phabricator.wikimedia.org/T76269#826236 (10matmarex) MediaWiki-Resources? [16:29:07] 3VisualEditor, OOjs-UI: Tools in the toolbar do not have unique attributes - https://phabricator.wikimedia.org/T76143#826283 (10Esanders) A 'better API' in this case would probably be giving groups unique symbolic names, then they could be accessed via ``` ve.init.target.getToolbar().getGroup( 'structure' ) ```... [16:29:26] James_F: not sure if it's the same issue. https://az.wikipedia.org/w/index.php?title=%C4%B0stifad%C9%99%C3%A7i%3AElitre_%28WMF%29&diff=3131414&oldid=3131393 it drops the first part, and it looks wrong when I edit it. [16:30:48] 3MediaWiki-Core-Team, MediaWiki-ResourceLoader: Fix "PHP Notice: Uninitialized string offset: 1 in includes/libs/jsminplus.php on line 1968" - https://phabricator.wikimedia.org/T77169#826354 (10Krinkle) [16:32:49] Elitre: Setting it to "m:Foo" works fine. [16:32:54] (that is, it also misses the space between my username and the (WMF) bit when I try to change the redirect: that's when it drops the :m:, not when I create the redirect ) [16:32:56] Elitre: But yeah, that's a bit janky. [16:33:09] It's when you touch it a second time. [16:33:12] * James_F sighs. [16:33:13] yes. [16:33:51] (03CR) 10Esanders: "vertical spacing is inconsistent in demos" [oojs/ui] - 10https://gerrit.wikimedia.org/r/175568 (owner: 10Mooeypoo) [16:35:06] (03PS1) 10Jforrester: Update VE core submodule to master (af4b395) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178208 [16:43:00] (03CR) 10Esanders: "Use fewer pseduo elements are more real elements. DOM simplicity is overrated, and we should assume that the skin is going to override the" [oojs/ui] - 10https://gerrit.wikimedia.org/r/176398 (owner: 10Prtksxna) [16:54:10] (03CR) 10Esanders: "I think not showing any information on the masonry page is a regression - I think the title should be available there still." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161342 (owner: 10Mooeypoo) [17:09:56] (03CR) 10Bartosz Dziewoński: [C: 04-2] "I just tested and svgo still removes the XML prolog (), which caused serious breakage in WMF environ" [oojs/ui] - 10https://gerrit.wikimedia.org/r/176634 (owner: 10Prtksxna) [17:11:27] (03CR) 10Jforrester: Add SVG compression grunt task using 'svgmin' (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/176634 (owner: 10Prtksxna) [17:14:36] 3MediaWiki-JavaScript, MediaWiki-Interface, Librarization, MediaWiki-General-or-Unknown, MediaWiki-ResourceLoader: Merge projects javascript and MediaWiki-JavaScript - https://phabricator.wikimedia.org/T76269#827966 (10Jdforrester-WMF) [17:19:42] (03CR) 10Bartosz Dziewoński: "It also causes some rather hilarious behavior for me locally when building. Here's how the built add.png looks: http://i.imgur.com/Lgglisx" [oojs/ui] - 10https://gerrit.wikimedia.org/r/176634 (owner: 10Prtksxna) [17:19:53] ^ lol [17:20:00] MatmaRex: Whoops. [17:20:59] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Oh, what James said could probably make this work, I wasn't aware you can do that." [oojs/ui] - 10https://gerrit.wikimedia.org/r/176634 (owner: 10Prtksxna) [17:23:13] MatmaRex: Magic! [17:26:08] (03CR) 10Bartosz Dziewoński: "After rebasing on master (without the dependency which breaks things for me), It works out-of-the-box on my Windows 7, but…" [oojs/ui] - 10https://gerrit.wikimedia.org/r/176637 (owner: 10Prtksxna) [17:27:14] quite [17:30:29] Corruption alert: visualeditor-needcheck on mediawikiwiki: https://www.mediawiki.org/?diff=1307091 [17:30:29] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=109765873 [17:30:29] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=33541184 [17:30:29] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=33542062 [17:30:29] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=33542432 [17:35:56] 3MediaWiki-ResourceLoader: Errors in one module can affect other modules via $.ready - https://phabricator.wikimedia.org/T72772#828284 (10Krinkle) An example of where this happened would be useful to assess what kind of code did this, who the affected users were, how and by whom it was addressed, etc. Initially... [17:36:31] 3MediaWiki-ResourceLoader: Errors in one module can affect other modules via $.ready - https://phabricator.wikimedia.org/T72772#828287 (10Krinkle) p:5High>3Normal [17:39:02] 3MediaWiki-Core-Team, MediaWiki-ResourceLoader: Fix "PHP Notice: Uninitialized string offset: 1 in includes/libs/jsminplus.php on line 1968" - https://phabricator.wikimedia.org/T77169#828302 (10Krinkle) [17:39:59] 3VisualEditor, VisualEditor-EditingTools: For Frame type image, the “Make full size” button gets disabled, when switching to other image types. - https://phabricator.wikimedia.org/T76623#828342 (10Etonkovidova) [17:43:38] (03PS1) 10Cmcmahon: [BrowserTest] update Cite tests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178218 [17:45:09] (03PS2) 10Divec: WIP: Native leftarrow, rightarrow, backspace and delete [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177946 [17:47:18] (03CR) 10jenkins-bot: [V: 04-1] WIP: Native leftarrow, rightarrow, backspace and delete [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177946 (owner: 10Divec) [17:48:54] (03CR) 10Bartosz Dziewoński: [C: 031] Element.getClosestScrollableContainer: Use 'body' or 'documentElement' based on browser (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/176666 (owner: 10Prtksxna) [17:49:44] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178218 (owner: 10Cmcmahon) [17:51:47] (03Merged) 10jenkins-bot: [BrowserTest] update Cite tests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178218 (owner: 10Cmcmahon) [17:52:03] (03CR) 10Bartosz Dziewoński: "Caused by https://gerrit.wikimedia.org/r/176476 , not a bug." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178218 (owner: 10Cmcmahon) [17:52:14] (03CR) 10Bartosz Dziewoński: "Follow-up in VE: https://gerrit.wikimedia.org/r/#/c/178218/1" [oojs/ui] - 10https://gerrit.wikimedia.org/r/176476 (owner: 10Prtksxna) [17:52:26] 3VisualEditor, VisualEditor-MediaWiki: [Regression wmf11]Cannot set “Sort this page by default as” for the individual Categories. - https://phabricator.wikimedia.org/T76707#828834 (10Etonkovidova) Works for me too now - checked in betalabs and test2. [17:52:30] (03CR) 10Bartosz Dziewoński: "Follow-up in VE (browser tests): https://gerrit.wikimedia.org/r/#/c/178218/1" [oojs/ui] - 10https://gerrit.wikimedia.org/r/176476 (owner: 10Prtksxna) [18:01:26] 3MediaWiki-User-login-and-signup, MediaWiki-JavaScript, MediaWiki-Watchlist, MediaWiki-Interface, Librarization, MediaWiki-General-or-Unknown, MediaWiki-API, MediaWiki-ResourceLoader: Merge projects javascript and MediaWiki-JavaScript - https://phabricator.wikimedia.org/T76269#829218 (10Krinkle) MediaWiki-Resour... [18:23:20] 3OOjs-UI: Rename a lot of getters for consistency - https://phabricator.wikimedia.org/T76630#829995 (10matmarex) a:5matmarex>3None [18:24:00] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (af4b395) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178208 (owner: 10Jforrester) [18:25:48] (03Merged) 10jenkins-bot: Update VE core submodule to master (af4b395) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178208 (owner: 10Jforrester) [18:42:45] James_F, btw, I'm still working on the image search widget thing and hopefully templatedata dialog will be used soon when the dependency issue is sorted -- but before you (and everyone else!) leaves, I'll need to discuss more tasks [18:43:19] Just because it's goin to be like... 3 weeks or something? I should have stuff to do. James_F, you want me to try and get into the gallery drag/drop? [18:46:17] mooeypoo: Hmm. Good question. [18:46:44] mooeypoo: Maybe not the best time to try to fix bugs in new areas. :-) [18:51:07] Krinkle|detached: Really? Typos in the ResourceLoaderStartupModule test suite that just make it work by accident? <_< [18:51:13] (polyfill vs polyfil) [18:58:33] James_F, I'll go over the RTL things that are awaiting ,but I didn't see many that are critical [18:59:48] who is *not* leaving for like half of december, actually? i'll need someone to review my patches. :D [19:01:37] RoanKattouw: Interesting. test.x. polyfil, right? [19:04:51] Yeah [19:05:00] My change fixes that as a side-effect [19:05:10] I noticed because Trevor's dependency indexing skipped it, treated it as an unknown dependency [19:05:46] MatmaRex: I'll be working from your timezone Dec 15-19, but 22-24 most people are probably away [19:06:18] Moriel and Sucheta have said they'll be around that week, and Ed is listed in the spreadsheet but I don't know if that's just because he hasn't put his time in yet [19:06:47] 29-31 it looks like it'll be just you, Moriel and David [19:07:39] RoanKattouw: I'm not entirely keen on the dependency/group numeral indexing actually. Seems gzip does a pretty reducing those repeated patterns already. [19:08:07] I was generally skeptical of Trevor's compression schemes, but this is what I like about the indexing one: [19:08:13] It uses an implicit mapping [19:08:17] We already simplify dependencies to remove redundant ones that can be implied, removed raw modules like jquery/mediawiki and unquoted timestamps. I'm sure there's other things we can do as well. [19:08:37] If you were doing something like indexes = {0:foo, 1:bar, ... }; data = [1, 3, 2]; then you're just doing what gzip would have done [19:08:53] But he doesn't need a map of indexes here because that map is derived from the ordering of the data [19:08:58] I know [19:09:06] Also he measured the impact :) [19:09:10] before gzip [19:09:20] and after [19:09:23] 9% for enwiki [19:10:00] Krinkle: RoanKattouw: we could go back to the idea of "parameterized modules" [19:10:21] What is that? [19:10:24] SyntaxHighlight registers like 150 modules that are all almost the same right now; perhaps it could register one parameterized module [19:10:37] ext.syntaxhighlight.c, ext.syntaxhighlight.javascript, ext.syntaxhighlight.python, etc. [19:10:46] (or something along these lines) [19:11:01] Hm.. yeah. That can probably also be greatly reduced in general. [19:11:08] they are always all invalidated together [19:11:24] ImageModule is essentially parameterized as well [19:11:25] MatmaRex: MOst syntax highlighters I know for text editors are language agnostic. [19:11:36] but we don't ship all the data in one module [19:11:40] MatmaRex: This is just poor coding. They don't need to be separate modules. [19:11:46] Krinkle: but these probably suck, eh? [19:12:05] there's tons of syntax that can't be just done by matching (), {} and \w+ [19:12:27] the syntax matching is done server side [19:12:38] in every highlighter I know the parser is specific per language [19:12:42] but not the highlighting [19:12:53] oh. hmm. [19:13:05] Problem with parametized modules is that you can't depend on them properly. if they're mutually exclusive, you've got a state drama. If they're not, then they should just be separate modules. [19:13:23] there must be a reason for this, but what you're saying doesn't sound unreasonable [19:13:27] there wouldn't be much gain in making those paramatized modules. [19:13:40] no, they all have rules like .code-ruby .comment {…} [19:13:49] MatmaRex: It's Geshi. I'm pretty sure everything you and I can come up with in under a minute is better than what it does. [19:14:23] meh. at least from user's perspective, it's been working solidly for years, can't complain [19:14:43] Yes, it works. I'm not denying that. But it works in a very inefficient way. [19:14:56] The way wikis theme it is also testifying to that [19:15:01] we have worse things [19:15:05] * MatmaRex points to Tidy [19:15:08] You brought it up :) 150 modules [19:15:29] well, i also made it that way :P it used to just not use ResourceLoader [19:16:38] b6d8b1a5b9a75a085d7d609db3524d99b99d345c [19:16:59] The syntaxhighlighter GitHub uses parses into generic class names (e.g. blob-number, blob-string, pl-assign, pl-symbol). The syntax highlighter Sublime, Atom and TextMate use also work in a similar way. You can install plugins for puppet and Less and code themes that don't know about these plugins. [19:17:14] Afaik most highlighters work that way. I can't think of another one other htan Geshi that does it this way. [19:18:50] It's actually a defacto standard by TextMate (the Sublime themes are actually tm themes) [19:18:51] http://manual.macromates.com/en/themes [19:19:42] 3VisualEditor, VisualEditor-MediaWiki: Same Category get added multiple times ,for every change in “Sort this page by default as” value. - https://phabricator.wikimedia.org/T76715#830829 (10Etonkovidova) Reproducible in beta ad test2 - but multiple categories do not get saved, so the bug is minor. Steps(simplif... [19:20:20] hmm. [19:20:58] that could actually be an interesting experiment. geshi internally also seems to mostly use generic, non-language-specific names [19:21:14] it just allows each language definition to specify its own styles for them [19:21:44] Considering there's loads of tm language grammar plugins out there. We could even consider moving away from Geshi. We certainly wouldn't lose any (or many) support for individiaul languages. And we'd be using something that is actually maintained. [19:22:09] And in much better shape probably. But oh well. [19:24:22] MatmaRex: cool. [19:24:58] there's a "next generation" geshi version https://github.com/GeSHi/geshi-1.1 I'm not sure if that's any different (we're still using 1.0) [19:30:30] legoktm: Hm.. interesting. 1.0 is labeled "old", "1.1" is labeled new. But the website talks about 1.2 [19:30:33] http://geshi.org [19:30:57] o.O [19:31:22] from 2012 [19:31:25] http://qbnz.com/highlighter/news.php?id=131 [19:31:55] lol [19:31:57] legoktm: seems the dates get higher for older versions [19:31:59] http://geshi.org/ [19:32:14] GeSHi 1.2 Opened to Public Testing - 2005 [19:32:15] wtf [19:32:43] GeSHi 1.1.0 released – 2005 [19:33:00] And 1.1.1 [19:33:02] and then silence [19:33:04] hahah [19:33:20] 1.0.x still got releases every now and then [19:47:55] 3MediaWiki-ResourceLoader: Bad cache stuck due to race condition with scap between different web servers - https://phabricator.wikimedia.org/T47877#831400 (10Krinkle) It may be short but it just broke nearly all javascript again on 1.25wmf11. During the deployment, the server responding to `bits.wikimedia.org/w... [19:50:22] James_F, did you manage to reproduce https://phabricator.wikimedia.org/T76931 ? [19:54:45] 3VisualEditor, VisualEditor-MediaWiki: [Regression pre-wmf12]- “Uncaught TypeError: undefined is not a function” when selecting the indicator-down arrow and the pop-up overrides the category. - https://phabricator.wikimedia.org/T76931#831424 (10Krenair) [19:55:16] 3MediaWiki-Core-Team, MediaWiki-ResourceLoader: Bad cache stuck due to race condition with scap between different web servers - https://phabricator.wikimedia.org/T47877#831426 (10Krinkle) [19:57:13] Krenair: Don't remember. [20:09:07] 3MediaWiki-ResourceLoader: Errors in one module can affect other modules via $.ready - https://phabricator.wikimedia.org/T72772#831448 (10Tgr) [20:09:54] 3VisualEditor, VisualEditor-MediaWiki: [Regression pre-wmf12]- “Uncaught TypeError: undefined is not a function” when selecting the indicator-down arrow and the pop-up overrides the category. - https://phabricator.wikimedia.org/T76931#831457 (10Swainr) Works for me. [20:10:09] (03PS3) 10Divec: WIP: Native leftarrow, rightarrow, backspace and delete [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177946 [20:12:50] (03CR) 10jenkins-bot: [V: 04-1] WIP: Native leftarrow, rightarrow, backspace and delete [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177946 (owner: 10Divec) [20:18:22] (03CR) 10Catrope: [C: 032] Regular expression find and replace [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177851 (owner: 10Esanders) [20:19:23] (03PS3) 10Catrope: Regular expression find and replace [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177851 (owner: 10Esanders) [20:19:47] (03CR) 10Catrope: [C: 032] Regular expression find and replace [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177851 (owner: 10Esanders) [20:25:31] (03Merged) 10jenkins-bot: Regular expression find and replace [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177851 (owner: 10Esanders) [20:26:37] 3VisualEditor: [Regression pre-wmf12] Pressing return on CE is not adding newline in Firefox - https://phabricator.wikimedia.org/T77905#831473 (10Ryasmeen) [20:31:00] 3VisualEditor: [Regression pre-wmf12] Pressing return on CE is not adding newline in Firefox - https://phabricator.wikimedia.org/T77905#831481 (10Ryasmeen) screenshot {F20031} [20:31:21] 3VisualEditor: [Regression pre-wmf12] Pressing return on CE is not adding newline in Firefox - https://phabricator.wikimedia.org/T77905#831482 (10Ryasmeen) p:5Triage>3High [20:32:57] (03PS1) 10Divec: Track state properly at the end of an event loop. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178263 [20:42:02] 3MobileFrontend-Hygiene, VisualEditor-TechnicalDebt, Project-Management, Wikidata: Create technical-debt project - https://phabricator.wikimedia.org/T75892#831488 (10Qgil) > Editable By VisualEditor (Project) You do it. :) [20:53:16] (03PS1) 10Divec: Fix the src attribute for non-debug chimeras [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178268 [20:55:06] omg it works [20:55:08] * mooeypoo cheers [20:55:17] RoanKattouw, remember our convoluded CSS3 chat on Friday? [20:56:14] RoanKattouw, WIN! $details.find( '.ve-ui-mwMediaDialog-panel-imageinfo-label:not(:last-of-type)' ).append( this.$( '' ).addClass( 'separator-class' ).html( 'the separator entity' ) ) [20:57:13] Nice :D [20:57:39] \o/ now I can rewrite that awful code to work with proper arrays [21:12:27] 3VisualEditor, VisualEditor-CopyPaste: Pasting an external link adds a ☀ - https://phabricator.wikimedia.org/T76916#831605 (10Etonkovidova) So far, the most reliable way to reproduce the issue is like this: 1. In Text Edit switch to plain text and type something - copy it 2. In VE, on a new line type one wor... [21:17:20] hi James_F|Away et al [21:18:58] some wikis have VE as a beta feature, and others have it enable by default and have a preference to disable it, right? [21:19:05] visualeditor-enable and visualeditor-betatempdisable? [21:19:08] Is there anything else? [21:28:10] (03PS2) 10Divec: Fix the src attribute for non-debug chimeras [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178268 [21:36:02] (03PS6) 10Jforrester: [WIP/POC] Match native content start annotation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/165233 (owner: 10Divec) [21:36:15] (03PS3) 10Jforrester: [WIP/POC] Normalise annotations on insertion [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177482 (owner: 10Divec) [21:36:28] (03PS4) 10Jforrester: [WIP/POC] Don't calculate DOM hash in SurfaceObserver [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/165975 (owner: 10Divec) [21:38:11] (03CR) 10jenkins-bot: [V: 04-1] [WIP/POC] Normalise annotations on insertion [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177482 (owner: 10Divec) [21:41:49] (03PS1) 10Divec: Fix typo in JS documentation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178275 [21:43:24] 3VisualEditor: [Regression pre-wmf12] Pressing return on CE is not adding newline in Firefox - https://phabricator.wikimedia.org/T77905#831797 (10Ryasmeen) [21:53:30] 3VisualEditor, VisualEditor-MediaWiki: Same Category get added multiple times ,for every change in “Sort this page by default as” value. - https://phabricator.wikimedia.org/T76715#831827 (10Krenair) Yep, managed to reproduce this now. Thanks. [21:59:19] I wonder if that task I just commented on is due to the use of a promise in MWCategoryWidget#addItems [22:00:39] I don't think OO.ui.GroupElement#addItems is intended to be overridden like that [22:00:39] 3VisualEditor, VisualEditor-MediaWiki-Links: Use [[ as a 'hotkey' trigger for opening the 'create a link' dialog - https://phabricator.wikimedia.org/T52093#831834 (10Etonkovidova) [22:01:01] 3VisualEditor, VisualEditor-MediaWiki-Links: Use [[ as a 'hotkey' trigger for opening the 'create a link' dialog - https://phabricator.wikimedia.org/T52093#831836 (10Etonkovidova) [22:13:33] (03PS2) 10Jforrester: ve.ce.TestRunner: Fix copypasta in JS documentation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178275 (owner: 10Divec) [22:13:39] (03CR) 10Jforrester: [C: 032] ve.ce.TestRunner: Fix copypasta in JS documentation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178275 (owner: 10Divec) [22:15:55] 3MediaWiki-Core-Team, MediaWiki-Page-editing: ipblocks query from EditPage unconditionally goes to master - https://phabricator.wikimedia.org/T51419#831922 (10greg) [22:17:36] (03Merged) 10jenkins-bot: ve.ce.TestRunner: Fix copypasta in JS documentation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178275 (owner: 10Divec) [22:20:02] how can I find the handler for paste events? [22:20:28] It's in ve.ce.Surface.js somewhere [22:20:34] Probably called afterPaste or something [22:20:57] k... I'll probably ask more questions :) [22:23:40] ok so I think I was right about addItems [22:27:06] Yeah addItems shouldn't return a promise, that sounds bad [22:28:03] 3VisualEditor, Design, VisualEditor-EditingTools: Auto-filled references based on destination URL / ISBN / etc. - https://phabricator.wikimedia.org/T62768#831980 (10KHammerstein) Hi Marielle, I think we should leave the user on the same screen, in case they messed up the number and want to try again. We should... [22:28:04] 3VisualEditor, VisualEditor-MediaWiki: Same Category get added multiple times ,for every change in “Sort this page by default as” value. - https://phabricator.wikimedia.org/T76715#831981 (10Krenair) This appears to be due to MWCategoryWidget#addItems using promises (the parent GroupElement#addItems does not real... [22:30:34] 3VisualEditor: Add a cross button to close the Find-Replace panel or clicking on CE may slide it up ? - https://phabricator.wikimedia.org/T77933#831984 (10Ryasmeen) [22:32:11] 3VisualEditor: Add a cross button to close the Find-Replace panel or clicking on CE may slide it up ? - https://phabricator.wikimedia.org/T77933#831984 (10Ryasmeen) p:5Triage>3Normal [22:38:45] (03CR) 10Catrope: [C: 032] Fix the src attribute for non-debug chimeras [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178268 (owner: 10Divec) [22:39:10] (03PS2) 10Catrope: Track state properly at the end of an event loop [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178263 (owner: 10Divec) [22:40:07] 3VisualEditor, VisualEditor-ContentEditable: [Regression pre-wmf12] Pressing return on CE is not adding newline in Firefox - https://phabricator.wikimedia.org/T77905#832006 (10Jdforrester-WMF) [22:40:08] (03CR) 10Catrope: [C: 032] Track state properly at the end of an event loop [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178263 (owner: 10Divec) [22:41:07] aharoni, you there for a quick question? [22:41:59] aharoni, is momentjs output translated/translatable in MW? Do I need to do anything t make it translateable? or is it already set up automatically? [22:43:52] (03Merged) 10jenkins-bot: Fix the src attribute for non-debug chimeras [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178268 (owner: 10Divec) [22:43:56] (03Merged) 10jenkins-bot: Track state properly at the end of an event loop [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178263 (owner: 10Divec) [22:45:11] (03PS1) 10Jforrester: Update VE core submodule to master (805e9aa) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178351 [22:50:22] (03PS7) 10Jforrester: Make category widget items draggable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173360 (https://bugzilla.wikimedia.org/50809) (owner: 10Alex Monk) [22:50:38] (03CR) 10Jforrester: "What's left to do here?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173360 (https://bugzilla.wikimedia.org/50809) (owner: 10Alex Monk) [22:52:22] (03CR) 10jenkins-bot: [V: 04-1] Make category widget items draggable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173360 (https://bugzilla.wikimedia.org/50809) (owner: 10Alex Monk) [22:52:24] (03PS1) 10Catrope: Followup 1c04d32d: release saveDialog reference even if closed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178354 [22:52:37] (03CR) 10Catrope: "This is a wmf10 regression" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178354 (owner: 10Catrope) [22:53:28] (03CR) 10Jforrester: [C: 031] "Looks entirely sane." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178354 (owner: 10Catrope) [22:54:07] 3VisualEditor, VisualEditor-MediaWiki: Random removal of categories - https://phabricator.wikimedia.org/T76998#832027 (10Jdforrester-WMF) [22:54:33] 3VisualEditor, VisualEditor-MediaWiki: Random removal of categories - https://phabricator.wikimedia.org/T76998#824453 (10Jdforrester-WMF) [22:54:58] (03PS4) 10Divec: WIP: Native leftarrow, rightarrow, backspace and delete [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177946 [22:57:42] (03CR) 10jenkins-bot: [V: 04-1] WIP: Native leftarrow, rightarrow, backspace and delete [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177946 (owner: 10Divec) [23:02:53] (03CR) 10Bartosz Dziewoński: [C: 032] Followup 1c04d32d: release saveDialog reference even if closed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178354 (owner: 10Catrope) [23:06:38] (03Merged) 10jenkins-bot: Followup 1c04d32d: release saveDialog reference even if closed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178354 (owner: 10Catrope) [23:07:05] MatmaRex: +2 https://gerrit.wikimedia.org/r/178351 maybe? [23:07:45] (03CR) 10Bartosz Dziewoński: [C: 032] Update VE core submodule to master (805e9aa) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178351 (owner: 10Jforrester) [23:07:51] Thanks. [23:08:06] sure [23:08:47] (03CR) 10Alex Monk: "I think I decided that it couldn't really be done properly" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173360 (https://bugzilla.wikimedia.org/50809) (owner: 10Alex Monk) [23:11:05] (03PS5) 10Divec: WIP: Native leftarrow, rightarrow, backspace and delete [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177946 [23:11:17] (03Merged) 10jenkins-bot: Update VE core submodule to master (805e9aa) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178351 (owner: 10Jforrester) [23:11:47] how can I diagnose why VE never loads for me on enwiki? [23:12:32] what I see every time: http://imgur.com/v0xevWq [23:12:42] 3VisualEditor, Design, VisualEditor-MediaWiki-Links: Links: Display illustrative images and WikiData descriptions for link suggestions - https://phabricator.wikimedia.org/T76397#832102 (10KHammerstein) [23:13:09] 3VisualEditor, Design, VisualEditor-EditingTools: Cite: Auto-filled references based on destination URL / ISBN / etc. - https://phabricator.wikimedia.org/T62768#832103 (10KHammerstein) [23:13:46] (03PS1) 10Jforrester: Followup 1c04d32d: release saveDialog reference even if closed [extensions/VisualEditor] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/178362 [23:13:57] (03PS1) 10Jforrester: Followup 1c04d32d: release saveDialog reference even if closed [extensions/VisualEditor] (wmf/1.25wmf11) - 10https://gerrit.wikimedia.org/r/178363 [23:14:43] (03CR) 10jenkins-bot: [V: 04-1] WIP: Native leftarrow, rightarrow, backspace and delete [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177946 (owner: 10Divec) [23:20:14] 3VisualEditor, Design, VisualEditor-MediaWiki-Links: Provide a separate tab in the link editor for external links - https://phabricator.wikimedia.org/T76398#832127 (10KHammerstein) [23:25:32] (03CR) 10Catrope: [C: 032] Followup 1c04d32d: release saveDialog reference even if closed [extensions/VisualEditor] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/178362 (owner: 10Jforrester) [23:25:36] (03CR) 10Catrope: [C: 032] Followup 1c04d32d: release saveDialog reference even if closed [extensions/VisualEditor] (wmf/1.25wmf11) - 10https://gerrit.wikimedia.org/r/178363 (owner: 10Jforrester) [23:26:22] James_F, https://phabricator.wikimedia.org/T76931 - worksforme is invalid or resolved now? [23:26:32] Krenair: Resolved. [23:27:33] (03Merged) 10jenkins-bot: Followup 1c04d32d: release saveDialog reference even if closed [extensions/VisualEditor] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/178362 (owner: 10Jforrester) [23:28:07] (03Merged) 10jenkins-bot: Followup 1c04d32d: release saveDialog reference even if closed [extensions/VisualEditor] (wmf/1.25wmf11) - 10https://gerrit.wikimedia.org/r/178363 (owner: 10Jforrester) [23:35:49] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: [Regression wmf1] When the inspector is still open for a selected node, after placing the cursor in a different position, inspector flickers there - https://phabricator.wikimedia.org/T73151#832241 (10Ryasmeen) I am still getting this issue in Betalabs. {F2... [23:43:19] (03PS1) 10Catrope: Split up ve.init.mw.ViewPageTarget.css [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178366 [23:43:27] RoanKattouw: Gosh. [23:43:37] mooeypoo: yo [23:43:41] James_F: Pretty tame actually, but prep for my next thing [23:43:49] aharoni, yoyo [23:43:55] RoanKattouw: :-) [23:43:58] 1:43 am, a usual hour with two-months-old [23:44:15] mooeypoo: afaik, momentjs is translatable in its own GitHub repo [23:45:20] (03CR) 10Jforrester: [C: 031] Split up ve.init.mw.ViewPageTarget.css [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178366 (owner: 10Catrope) [23:45:25] aharoni, ok, hm, well, I'm working on showing details in the media dialog, and utilizing moment.js. The simplest way is something like moment( timestamp ).fromNow() which produces a string "10 days ago" or "a year ago" etc etc. I know momentjs has itself translations within its own library, but seeing as we internationalize all strings in MW should I use this safely? [23:46:04] aharoni, or should I stick to showing "regular" timestamp with some date formatting? My previous attempt had a translate message with the date format, [23:46:18] (03PS1) 10Catrope: Remove IEHacks.css in favor of .ve-init-target-ie class [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178367 [23:47:45] aharoni, I remember a conversation about this in the list, I think in wikitech-l, maybe? about "X ago" strings, but I don't remember if it should be used or not? [23:48:44] The only other way to make this timestamp internationalized is to use only numbers [23:49:37] mooeypoo: it's probably safe to use momentjs without worrying about localization. [23:49:51] awesomesauce [23:49:55] thanks! [23:50:06] I remember some other library inside MW that did something similar, developed by werdna IIRC, [23:50:16] I'm not sure how do they map to each other [23:50:23] RoanKattouw: you certainly remember. [23:51:32] Oh I think you're talking about FlaggedRevs maybe? [23:51:37] Or ArticleFeedback? [23:51:48] Whatever it was, it was garbage compared to momentjs [23:52:43] RoanKattouw: maybe it was for the bubble thing at the top, or AFT [23:52:51] but OK [23:53:45] * mooeypoo just tried [23:53:52] momentjs is automatically translated [23:53:56] wooo [23:54:54] mooeypoo: today I did a workshop in the National Library in Jerusalem, [23:54:59] ooh! [23:55:02] aharoni, how did that go? [23:55:10] first there was another lecturer, who showed source editing, [23:55:32] she spoke about images, and how she always enters a width, even though the default is good, [23:56:07] 3VisualEditor, MediaWiki-extensions-BetaFeatures, Multimedia: Local Info and Discussions for Visual Editor - https://phabricator.wikimedia.org/T77066#832406 (10Gilles) [23:56:09] for the case that she will want to change it, because the number of pixels jumps to the wrong side of the English file name in Hebrew wiki syntax [23:56:43] Wow [23:56:43] wrong upon wrong. [23:57:06] You people have some serious Stockholm syndrome with regards to RTL support in software [23:57:13] and then I showed how to add images in VE and change their params. [23:57:30] That was a Great Success. [23:59:53] aharoni, is taht lecturer... someone... I know...?