[00:00:07] Shani [00:00:11] RoanKattouw, that is the BEST way to put it that I've heard [00:00:15] aharoni, oh, from the med school? [00:00:25] Yes. [00:00:33] She sounded excited about VE when I chatted with her on Facebook after Wikimania [00:01:04] And yay for image editing :D [00:01:35] Not to mention book citation. [00:01:55] 3VisualEditor, VisualEditor-ContentEditable: [Regression pre-wmf12] Pressing return on CE is not adding newline in Firefox - https://phabricator.wikimedia.org/T77905#832453 (10Ryasmeen) Verified in Betalabs [00:02:07] 3VisualEditor, VisualEditor-ContentEditable: [Regression pre-wmf12] Pressing return on CE is not adding newline in Firefox - https://phabricator.wikimedia.org/T77905#832456 (10Ryasmeen) [00:02:09] adding (the Hebrew version of) {{cite book}} was a hit. [00:03:59] (03CR) 10Jforrester: [C: 032] Remove IEHacks.css in favor of .ve-init-target-ie class (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178367 (owner: 10Catrope) [00:05:37] aharoni: Lost scrollback before "adding (the Hebrew version of) {{cite book}} was a hit" but… sounds good? [00:05:51] James_F: yes, good, another workshop [00:05:56] aharoni: Excellent. [00:06:29] a significant bug is that numbers of footnotes added by templates are wrong. [00:06:52] Yes. [00:06:56] Don't use them. [00:07:31] huh? [00:07:38] but {{cite}} templates do it. [00:07:45] oh, actually they don't. [00:08:10] Indeed. [00:08:32] but he.wiki likes its RTL ref template very much, [00:08:35] {{sfn}} etc. are hacks using a mistake in the MediaWiki parser. [00:08:41] They were never meant to work. [00:08:52] which is why I occasionally try to localize the the tag, [00:09:21] and yes, I know that Parsoid people won't like it very much. [00:10:49] (03CR) 10Esanders: Fix the src attribute for non-debug chimeras (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178268 (owner: 10Divec) [00:11:32] We're going to replace sooner than we'll make {{sfn}} work, I'd say. [00:29:18] mooeypoo: thanks to you, I sent a pull request to moment.js [00:29:20] https://github.com/moment/moment/pull/2090 [00:29:35] hah! glad I could help :D [00:30:07] wow I didn't even think about that rule [00:30:20] ha I don't even think I noticed it [00:31:06] WOW. It's not even a recommendation usage, it doesn't work with the other term.. [00:31:56] it's possible to say "esrim shanim", but it's more natural "esrim shana". Both are correct. [00:32:16] It sounds off [00:32:17] I never noticed [00:32:18] The guy who does Hebrew localization for Apple noticed it some time ago and added a rule to CLDR. [00:32:30] I always used it right, but never noticed it was different. I didn't think about that, ha [00:34:38] (03PS1) 10Jforrester: Follow-up Ifa89a85e: Use '0' not '0px' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178380 [00:35:36] (03CR) 10Jforrester: Fix the src attribute for non-debug chimeras (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178268 (owner: 10Divec) [00:41:43] (03CR) 10Catrope: "Why?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178380 (owner: 10Jforrester) [00:55:24] 3VisualEditor, VisualEditor-MediaWiki: Random removal of categories - https://phabricator.wikimedia.org/T76998#832584 (10Etonkovidova) So far, cannot reproduce it either. [01:34:45] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: Dialogs should disable "Apply changes" until a change is present - https://phabricator.wikimedia.org/T57976#832632 (10Krenair) [01:34:46] 3VisualEditor, VisualEditor-MediaWiki-References: The reference dialog should disable the "Apply changes" button until a change is present - https://phabricator.wikimedia.org/T76928#832631 (10Krenair) 5Open>3Resolved [01:57:10] browserstack now has Windows Mobile testing :) [01:57:12] James_F: :) [01:57:22] Krinkle: Nice. [01:57:29] (03CR) 10GOIII: [C: 031] Toolbar help: Make magic word from help string a param [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/178180 (owner: 10TheDJ) [01:57:33] Krinkle: If only someone used it. ;-) [01:57:37] :P [02:00:01] James_F: Hm.. It's a bit weird that an issue can be both assigned and be in state "Need triage" or "Need volunteer". [02:19:27] Krinkle: Eh. What task? [02:19:49] James_F: Phabricator in general [02:20:01] James_F: but I noticed it on https://phabricator.wikimedia.org/T28799 [02:20:08] bz Lowest -> Need volunteer [02:20:10] Krinkle: Triage/etc. is a task-level priority. [02:20:28] Krinkle: "Assignment" is a "this idiot things he's going to work on it". [02:20:29] So we've got a coupe in need of volunteer that are also assigned [02:21:28] Krinkle: https://phabricator.wikimedia.org/maniphest/query/tw0TbXUqWccJ/#R shows a bunch of tasks that aren't triaged but are assigned. [02:22:26] Krinkle: https://phabricator.wikimedia.org/maniphest/query/OIcRp1C6vOd3/#R is better. [02:23:04] 3VisualEditor, VisualEditor-DataModel: VisualEditor: In the Re-use reference dialog, search is not returning correct results on the second initialization for a specific case - https://phabricator.wikimedia.org/T72886#832674 (10Jdforrester-WMF) p:5Triage>3Low [02:23:31] Krinkle: None in VE, happily. [02:28:59] James_F: I'm pretty sure those all predate Phabricator. From Bugzilla when there was a default-assignment concept. [02:29:06] Something I"m glad we no longer have [02:29:34] Krinkle: Yeah. [02:34:26] 3VisualEditor, VisualEditor-DataModel, VisualEditor-MediaWiki-References: In the Re-use reference dialog, search is not returning correct results on the second initialization for a specific case - https://phabricator.wikimedia.org/T72886#832684 (10Jdforrester-WMF) [02:41:17] I should probably detail what that case actually is [02:41:45] maybe when it's not 2:40 am though [02:50:54] (03PS1) 10Catrope: [WIP] Move from legacy TimingData schema to new statsd API [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178415 [03:00:09] James_F: So, looks like VE won't even load in Windows Phone, even with vewhitelist=1, the Edit tab never show sup [03:00:25] Krinkle: Are you using debug mode? :-) [03:00:39] James_F: No? [03:00:43] Krenair: Shoo. :-) [03:00:53] Krinkle: Roan's fun discovery of earlier. [03:01:41] James_F: on mediawiki.org that was breaking Flow/LQT? That's something else. [03:02:07] Krinkle: No, on en.wikipedia.org ?debug=true -> no VE for you, even if you've opted in. [03:02:10] Hm.. I got the Edit tab and loader to appear. Then it dies at some point. [03:02:14] k [03:02:19] Yeah. [03:02:21] I never use debug mode :) [03:02:43] anyhow, good to know Windows Phone isn't going to concur the world. [03:02:58] Krinkle: Then give me a ?BypassRLTimestampAndGiveMeTheDamnLatestCode please. :-) [03:03:15] James_F: btw, Hangouts. [03:03:23] Krinkle: Yes? [03:03:55] James_F: sent a msg 4h ago [03:04:00] Krinkle: Oh? [03:04:13] Aha. [03:55:35] 3VisualEditor, VisualEditor-EditingTools, VisualEditor-Tables: Support tables (tracking) - https://phabricator.wikimedia.org/T41596#832797 (10Arlolra) [03:55:36] 3VisualEditor, VisualEditor-Tables, Parsoid: Broken wikitext inside a table leads to it and the table header being duplicated - https://phabricator.wikimedia.org/T55394#832794 (10Arlolra) [07:21:02] (03PS12) 10Mooeypoo: [WIP] Transform the search widget to show image details [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161342 [07:23:21] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Transform the search widget to show image details [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161342 (owner: 10Mooeypoo) [09:47:30] (03PS11) 10Paladox: Reformat the license warning only if available [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/98249 (owner: 10Dev-zero) [10:19:15] hello [10:19:47] in action=visualeditoredit, why does it even need the displaytitle? [10:21:55] in ve.init.mw.Target.onSave it is passed through to this.emit() to the "save" event [10:22:06] how do I find out what handles that event? [10:29:25] never mind [11:04:28] 3MediaWiki-Page-editing: Warn on creating of double redirect - https://phabricator.wikimedia.org/T12963#147545 (10fbstj) [13:12:34] (03CR) 10Bartosz Dziewoński: [C: 032] "It's neater. Zero is zero, regardless of units. We do that in CSS." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178380 (owner: 10Jforrester) [13:15:11] (03Merged) 10jenkins-bot: Follow-up Ifa89a85e: Use '0' not '0px' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178380 (owner: 10Jforrester) [14:34:25] 3VisualEditor, VisualEditor-CopyPaste: Pasting an external link adds a ☀ - https://phabricator.wikimedia.org/T76916#833522 (10Esanders) Can you be more precise still. What is "Text Edit"? From where to where do you copy? At what position do you paste? [15:07:37] 3VisualEditor, VisualEditor-Performance, VisualEditor-MediaWiki: Support editing parts of a page in VisualEditor - https://phabricator.wikimedia.org/T50429#833634 (10Ckoerner) [16:05:33] ok, so today, I'm going to try and stop the jumping on IE. [16:05:45] https://phabricator.wikimedia.org/T75294 [17:00:34] 3VisualEditor: VisualEditor: Using the VE toolbar in MSIE causes the cursor to jump to the start of the page - https://phabricator.wikimedia.org/T75294#833791 (10matmarex) [17:30:30] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=109804075 [17:30:30] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=33555176 [17:30:30] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=33557255 [17:30:30] Corruption alert: visualeditor-needcheck on huwiki: https://hu.wikipedia.org/?diff=15397430 [17:30:30] Corruption alert: visualeditor-needcheck on ptwiki: https://pt.wikipedia.org/?diff=40802903 [17:30:31] Corruption alert: visualeditor-needcheck on itwiki: https://it.wikipedia.org/?diff=69534353 [17:41:19] 3VisualEditor, MediaWiki-General-or-Unknown, Parsoid, MediaWiki-Interface: Use Parsoid HTML for read-only views too - https://phabricator.wikimedia.org/T55784#833969 (10GWicke) [17:48:30] 3VisualEditor, MediaWiki-General-or-Unknown, Parsoid, MediaWiki-Interface: Use Parsoid HTML for read-only views too - https://phabricator.wikimedia.org/T55784#833970 (10GWicke) [17:50:36] 3VisualEditor, MediaWiki-General-or-Unknown, Parsoid, MediaWiki-Interface: Use Parsoid HTML for read-only views too - https://phabricator.wikimedia.org/T55784#833971 (10GWicke) [17:54:11] 3OOjs-UI: CheckboxInput doesn't support string value, forces boolean and won't work with many use cases in HTML static forms - https://phabricator.wikimedia.org/T76645#833972 (10matmarex) We'd need to separate "value" vs "checkedness", like in RadioInputWidget. Easy, but this kills the abstraction over HTML we w... [17:57:43] (03CR) 10Jforrester: [C: 032] Split up ve.init.mw.ViewPageTarget.css [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178366 (owner: 10Catrope) [18:00:00] (03Merged) 10jenkins-bot: Split up ve.init.mw.ViewPageTarget.css [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178366 (owner: 10Catrope) [18:00:02] (03Merged) 10jenkins-bot: Remove IEHacks.css in favor of .ve-init-target-ie class [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178367 (owner: 10Catrope) [18:04:38] https://twitter.com/booksprint/status/542376958902796289 [18:05:15] booksprint == adam hyde == dude who runs book sprints in a lot of places and is pretty cool [18:05:18] just thought I'd share [18:18:29] 3VisualEditor, MediaWiki-General-or-Unknown, Parsoid, MediaWiki-Interface: Use Parsoid HTML for read-only views too - https://phabricator.wikimedia.org/T55784#834004 (10GWicke) [18:19:30] greg-g: Oh yeah he was in the office last week [18:20:09] 3VisualEditor, MediaWiki-General-or-Unknown, Parsoid, MediaWiki-Interface: Use Parsoid HTML for read-only views too - https://phabricator.wikimedia.org/T55784#554184 (10GWicke) [18:20:54] RoanKattouw, Krinkle, etc.: I have a review comment that OO.EventEmitter is "meant to be a mixin", is that correct? [18:21:00] I've been using oo.inheritClass for it [18:21:09] marktraceur: mixin indeed. [18:21:17] Krinkle: Any particular reason that's preferred? [18:21:19] You *can* use inheritClass with EventEmitter but it's not recommended [18:21:31] Because it's not needed, and you will likely shoot your future self in the foot with it [18:21:38] Eh, screw that guy [18:21:40] But OK [18:21:51] 3VisualEditor, MediaWiki-General-or-Unknown, Parsoid, MediaWiki-Interface: Use Parsoid HTML for read-only views too - https://phabricator.wikimedia.org/T55784#834027 (10GWicke) [18:22:08] marktraceur: It's simplified so that it can work without inheritance. thus enabling you to inherit from something else while also being able to make it an eventemitter. [18:22:10] In the case of EventEmitter, inherit and mixin are pretty much equivalent. But that's not true for other classes, and you can have multiple mixins but only inherit from one [18:22:41] Yup. [18:23:02] greg-g: We've been working with Adam; they're doing great stuff with VisualEditor, it's very exciting. [18:24:30] RoanKattouw: he was?! [18:24:33] James_F: cool! [18:24:43] greg-g: Yeah, we spent most of Wednesday with him. [18:24:49] coolio [18:24:53] sorry I missed him [18:25:05] greg-g: Sorry, would have mentioned him to you if I'd known. [18:25:22] no worries, you aren't responsible for my social network :) [18:28:30] MatmaRex: https://gerrit.wikimedia.org/r/#/c/178385/ [18:29:16] :o [18:29:50] TrevorParscal: what about it? i really have no experience with JavaScript/PHP templating engine stuff [18:29:51] so, aparently now, despite the consensus to use Mustache, we have robson and kaldari deciding to integrate https://github.com/zordius/lightncandy (which Flow uses) into core instead [18:30:30] the decision was to limit the features in core on purpose, so we don't regret giving out features we wish we haddn't [18:31:18] they claim they can turn all the extras off, but I'm leery about this lightncandy approach, as opposed to just using http://mustache.github.io/ stright up [18:31:44] because jon has done nearly nothing with this, it's now created a void [18:32:08] and we need to fill that void ourselves aparently, or bad things are going to start happening [18:32:26] in other news, we need to merge some crap [18:32:40] where are you at in responding to Roan's comments? [18:32:53] re: https://gerrit.wikimedia.org/r/#/c/165922/ [18:33:25] i responded to them [18:36:40] (03PS23) 10Bartosz Dziewoński: Eventify TemplateDataGenerator and use oojs-ui [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 (owner: 10Mooeypoo) [18:36:55] 3VisualEditor, Parsoid, MediaWiki-Interface, MediaWiki-General-or-Unknown, Services, RESTBase: Use Parsoid HTML for read-only views too - https://phabricator.wikimedia.org/T55784#834052 (10GWicke) [18:36:57] RoanKattouw: did you actually publish your comments? [18:37:01] I don't see any recent ones [18:37:13] (03CR) 10Catrope: [C: 04-1] "Right now, it's a bad idea to put this in production. localStorage is frequently full due to ResourceLoader's module storage, especially o" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174798 (https://bugzilla.wikimedia.org/62884) (owner: 10Alex Monk) [18:37:17] MatmaRex: I guess you just need to write a better commit message? [18:38:01] hm, yeah [18:38:50] have we decided how exactly we're going to make iiui use this, btw? or is that something left to figure out? [18:39:27] (03CR) 10Catrope: "As James points out, we could also try writing to LS, then if that fails set a cookie instead. That would probably help a bit." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174798 (https://bugzilla.wikimedia.org/62884) (owner: 10Alex Monk) [18:43:17] eh, it would have been easier to review changes if i was able to download them [18:43:22] it would be* [18:45:10] 3VisualEditor, Parsoid, MediaWiki-Interface, MediaWiki-General-or-Unknown, Services, RESTBase: Use Parsoid HTML for read-only views too - https://phabricator.wikimedia.org/T55784#834084 (10GWicke) [18:45:30] 3VisualEditor, Parsoid, MediaWiki-Interface, MediaWiki-General-or-Unknown, Services, RESTBase: Use Parsoid HTML for read-only views too - https://phabricator.wikimedia.org/T55784#834090 (10Jdforrester-WMF) [18:46:12] so, as far as ooui is concerned [18:47:28] as long as we configured it using the right prefix, it can purely be supplemental, we don't have to use it right away for all icons but as icons are added they should work just fine [18:47:39] we could also rethink the icon prefixing of oojs ui [18:48:40] such that the oojs ui hardcoded oo-ui-icon- and oo-ui-indicator- prefixes are configured [18:48:48] but, I think minimal initial changes are better [18:49:19] and simply deploying the image module with oo-ui-* prefixes will do fine [18:49:22] ? [18:49:47] the more i tihnk about it, the more it seems like the whole RLImageModule stuff will need scrapping and rewriting at some point in the future [18:49:52] but for now it probably will work, yeah [18:50:10] what are you main points for thinking so? [18:50:26] so we're not touching OOUI code, nor how the import is done - we just create additional module for the icons, adding them on as-needed basis? [18:50:40] yes [18:50:44] TrevorParscal: it seems tightly coupled with how OOUI works. [18:50:48] minimal changes [18:51:02] if you look how other icon libraries work, it's quite similar [18:51:13] with the exception of fonts [18:51:29] most declare icons by background image [18:51:50] all the variant stuff is maybe a little bit specific, i'm not sure [18:51:54] So we'll have an "editing" OOUI icon pack repo which will be a sub-repo of VE-core and also of MW-core's OOUI theme? [18:52:13] TrevorParscal, MatmaRex: As far as I'm concerned the image module commit is ready to merge, but by its own admission it needs a real commit message and the example stuff needs to be cleaned up [18:52:36] James_F: i'm not sure it needs to be it's own repo [18:52:39] yeah, let me just split the example to a separate commit (and abandon it) [18:52:50] i'm not sure yet [18:53:00] TrevorParscal: So how will it be shared by VE-core and WikiEditor and the MW-core wikitext editor and Flow and whatever else? [18:53:27] ugh, more repos? [18:53:36] i think this tool was built to solve a particular problem, how do we provide a uniform interface and uniform capabilities to all parts of the software, core and extensions [18:53:38] MatmaRex: Yeah, hence my concern. [18:53:53] how we actually use it should be thought though carefully [18:53:53] MatmaRex: Unless VE-core uses its own iconset that VE-MW doesn't. [18:54:03] Which would be OK, but might be a bit confusing for downstream users? [18:54:16] but the basic concept, define icons based on JSON and SVG, I think has a lot of value [18:55:13] +1 to the concept, i'm just not sold on the format we used [18:55:25] I think the icons in OOjs UI themes (there aren't any in OOjs UI core styles) should remain minimal, and probably even be more minimal than they are today [18:55:34] the format being SVG? [18:55:36] TrevorParscal: There's one, remember. [18:55:39] or, the configuration format? [18:55:41] we've implemented/discussed like five configuration formats, first in OOUI and now in MW, and i didn't like any of them [18:55:44] the format of JSON file [18:55:45] yes [18:55:52] ah [18:56:02] but i think this will just be ironed out as we start using it, and it starts sucking for us [18:56:06] then we'll rewrite [18:56:09] ok [18:56:10] so meh [18:56:10] sure [18:56:14] the concept is solid, i agree [18:56:31] we probably won't know how good/bad parts of it are until we start using it for real [18:56:34] I think you are right there [18:56:45] so, we want to create an "icon pack" for ooui? [18:57:05] MatmaRex: For the MediaWiki theme of OOUI. [18:57:23] let's please put it in the main OOUI repo, or we'll go mad from the plentitude [18:58:30] I think the problem here is that OOjs UI probably should have been integrated into MediaWiki as a MediaWiki extension [18:58:45] I guess that's not out of the question still [18:58:56] but, it sort of lends itself to yet another repo [18:59:04] extensions/OOjsUI [18:59:29] which then includes the actual OOjsUI code for both the client and the server [18:59:48] but, instead it's divided between resources and vendor or whatever [18:59:54] (03CR) 10Catrope: [C: 032] Restore papaparse [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/176654 (owner: 10Esanders) [19:00:09] in any case, no matter where it lives, it needs to have a resource loader definition [19:00:29] and keeping that up to date, if the icons live in the oojs-ui repo, will be a pain [19:00:49] and tbh, what the design team wants is to have icon packs checked into MW core (afaik) [19:01:08] that can "just work" with any OOjs UI code (whether php or JS) [19:01:38] TrevorParscal: Why not put them in OOUI for now, and later (when you move the theme) move them to MW-core? [19:01:43] hmm [19:01:44] this ^ [19:01:49] TrevorParscal: 'Cos otherwise you're going to have big split-dev issues. [19:01:55] and all this fancy rigging is meant to be a way to avoid the complexity of interdependencies and copy pasting icons around and updating an icon in 9 different repos [19:02:07] TrevorParscal: And you're making redoing the fancy rigging a blocker for progress unnecessarily. [19:02:08] (03Merged) 10jenkins-bot: Restore papaparse [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/176654 (owner: 10Esanders) [19:02:15] i was just going to suggest that. we'll be moving the MW theme to MW at some point, and then it'll be natural to have the icons with the theme, right? [19:02:35] I think we should avoid actually using the icon module for oojs-ui mw theme provided icons for now [19:02:48] because there's another pre-requisite that will make this all make more sense [19:03:03] which is the ability to build the mw theme without it being part of the oojs-ui repo [19:03:30] That's not a pre-req. [19:03:34] That's a wishlist item. [19:03:35] SUrely? [19:03:49] so the mw theme can live in - well, mw... fancy that - and then since we will have all this mw specific code only living in mw, we can use the mw facilities like the icon module to specifiy the icons instead of the oojs ui build script ones [19:04:13] which actually helps us to make building a theme outside oojs-ui core much easier [19:04:27] TrevorParscal: You're arguing for lots of work so that lots of work are easier. :-) [19:04:52] my point is, we do nothing today [19:05:23] Argh, meeting. [19:05:29] soon we take steps toward moving the oojs ui theme to mw core [19:06:09] part of that effort includes using the RL image module [19:06:44] in the shorter term, the design team provides icons (which aren't used in any oojs ui themes at all) for the first icon packs [19:06:51] they define them as RL image modules [19:07:19] everyone can start using them using .oo-ui-icon to get the background image [19:07:32] I think there was a request to use .mw-icon instead [19:07:57] and, like I was saying, we could make oojs-ui configurable so it doesn't hard-code the icon prefix as .oo-ui-icon [19:08:08] since icons are theme specific, it could be part of the theme code [19:08:14] and the rigging is pretty much done already [19:08:49] MatmaRex: I could write that patch, then we could use .mw-icon in mediawiki without losing any functionality - feelings/thoughts? [19:10:25] (one sec) [19:13:19] RoanKattouw: updated RLImageModule https://gerrit.wikimedia.org/r/165922 , please check if i didn't break anything. :) [19:15:08] TrevorParscal: eh, OOUI icons should use the .oo-ui prefix, if you ask me. we can very well have icon packs that are not connected to OOUI, and these could use .mw-icon-whatever [19:15:29] TrevorParscal: the hypothetical MW theme OOUI icon pack could use both, if we want to make it neat to use [19:15:30] But then you have to know where an icon comes from in order to use it [19:15:32] That sounds bad [19:15:46] Also icon packs should be able to override core icons [19:16:02] MatmaRex: there are no such thing as OOjs UI icons, only theme icons [19:16:07] yeah. so we should probably stick to .oo-ui [19:16:24] OOjs UI core has no icons [19:16:31] Yes it does [19:16:40] it now has a cursor [19:16:53] Wait, not any more? [19:16:55] Where did the icons go? [19:16:56] there are no icons outside of the themes [19:16:57] on purpose [19:17:05] because the icons need to match the theme [19:17:08] (i am also generally appalled that we have to put icon names into the HTML, like in the days of , but it seems i lost that battle ;) ) [19:17:21] having universal icons doesn't hold up in real life [19:17:30] Oh they're in the themes now [19:18:58] 3VisualEditor, VisualEditor-CopyPaste: Pasting an external link adds a ☀ - https://phabricator.wikimedia.org/T76916#834166 (10Etonkovidova) Sorry - some clarifications: - type a word in TextEdit((Mac text editor) in plain text mode or in Notepad - select to copy - in VE type word(s) on a new line - switch t... [19:24:27] agh, some of this less code to do with images makes my brain hurt [19:28:38] TrevorParscal, welcome to the image club! [19:29:06] * mooeypoo hands TrevorParscal an image of tylanol [19:29:17] lol [19:32:25] mooeypoo: eh, so i tried to look at https://gerrit.wikimedia.org/r/#/c/167046/ [19:32:37] ok [19:32:57] mooeypoo: and i absolutely can't figure out how to use the thing, as a user. not sure if something in the UI is broken or what [19:33:22] Are you using it in Template namespaces inside an existing template? [19:33:32] :\ okay, uhm. That's not good. [19:34:53] mooeypoo: http://i.imgur.com/6HNsU01.png [19:35:27] MatmaRex, I just found a bug in the import. meh, this worked before. I'm fixing now [19:35:49] as for the empty language, that's not supposed to happen [19:36:08] everything is modal, that kind of sucks; at first i thought everything disappeared when i clicked "Add parameter", but it was just a modal dialog on top [19:36:20] i also can only add a parameter, but not change any of its properties [19:36:34] you mean a panel? [19:36:51] i suppose some breaking changes in OOUI affected this? :( [19:36:56] okay, I'm going over this change again. I found a bug with the import, but obviously there's more [19:36:59] appanrelty :\ [19:37:01] apparently [19:37:12] This worked before. okay, i'm on it. [19:37:17] 3VisualEditor: Typing inside a dialog while keeping the link inspector open ,types the letters in CE - https://phabricator.wikimedia.org/T78026#834218 (10Ryasmeen) [19:38:36] 3VisualEditor: Typing inside a dialog while keeping the link inspector open ,types the letters in CE - https://phabricator.wikimedia.org/T78026#834218 (10Ryasmeen) This issue occurs in both Chrome and Firefox in all environments [19:41:07] okay. bonk me when you need me, i'm going to do some more breaking ooui changes. :) [19:43:23] MatmaRex, oi, yes, all the ooui breaking changes broke the code. I'm fixing.Thanks! [19:57:14] MatmaRex, TrevorParscal: BTW the RLImageModule commit is merged now [19:57:52] seen it, thanks [19:58:55] thanks man [19:58:59] (03PS1) 10Bartosz Dziewoński: RadioInputWidget: Remove documentation lies [oojs/ui] - 10https://gerrit.wikimedia.org/r/178586 [19:59:22] something has been seriously wrong with my connection to gerrit in the past weeks and it's getting worse [19:59:41] i've been trying to `git pull` mw/core for twenty minutes now [19:59:46] (03CR) 10Catrope: [C: 04-1] Trim whitespace when annotating (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177533 (owner: 10Esanders) [20:02:19] 3VisualEditor, OOjs-UI: Height of ButtonSelectWidget is too high in MediaWiki theme - https://phabricator.wikimedia.org/T78029 (10Jdforrester-WMF) 3NEW p:3Triage [20:04:07] 3VisualEditor, Parsoid, MediaWiki-Interface, MediaWiki-General-or-Unknown, Services, RESTBase: Use Parsoid HTML for read-only views too - https://phabricator.wikimedia.org/T55784#834283 (10Eloquence) [20:13:22] (03CR) 10Catrope: [C: 031] "Looks good, but let's merge this tomorrow after the cut." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/176952 (owner: 10Esanders) [20:15:30] (03CR) 10Catrope: [C: 031] Use target.getSurface now that targets can have multiple surfaces (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/177129 (owner: 10Esanders) [20:17:37] 3VisualEditor, Parsoid, MediaWiki-Interface, MediaWiki-General-or-Unknown, Services, RESTBase: Use Parsoid HTML for read-only views too - https://phabricator.wikimedia.org/T55784#834438 (10GWicke) [20:19:05] 3VisualEditor, VisualEditor-MediaWiki-Templates, OOjs-UI: Vertical alignment of the "add template" button and the search box is incorrect in template dialog in VisualEditor when using the OOjs UI MediaWiki theme - https://phabricator.wikimedia.org/T78052#834452 (10Jdforrester-WMF) [20:20:57] 3VisualEditor, VisualEditor-MediaWiki-Templates, VisualEditor-MediaWiki, OOjs-UI: Vertical alignment of the "add template" button and the search box is incorrect in template dialog in VisualEditor when using the OOjs UI MediaWiki theme - https://phabricator.wikimedia.org/T78052#834452 (10Jdforrester-WMF) [20:20:58] 3VisualEditor, OOjs-UI, VisualEditor-MediaWiki: Bottom border of text box in save dialog only appears when zoomed in, in VisualEditor when using the OOjs UI MediaWiki theme - https://phabricator.wikimedia.org/T78051#834468 (10Jdforrester-WMF) [20:21:01] 3VisualEditor, OOjs-UI, VisualEditor-MediaWiki: Width layout issues in the media insert window in VisualEditor when using the OOjs UI MediaWiki theme - https://phabricator.wikimedia.org/T78050#834469 (10Jdforrester-WMF) [20:21:02] 3VisualEditor, OOjs-UI, VisualEditor-MediaWiki: Layout of the image size options is jarring in VisualEditor when using the OOjs UI MediaWiki theme - https://phabricator.wikimedia.org/T78049#834470 (10Jdforrester-WMF) [20:21:03] 3VisualEditor, OOjs-UI, VisualEditor-MediaWiki: Disabled checkbox is almost indistinguishable from an enabled, selected checbox in the OOjs UI MediaWiki theme - https://phabricator.wikimedia.org/T78048#834471 (10Jdforrester-WMF) [20:21:05] 3VisualEditor, OOjs-UI, VisualEditor-MediaWiki: Vertical spacer before the start of the citation dialog contents is too big in VisualEditor when using the OOjs UI MediaWiki theme - https://phabricator.wikimedia.org/T78045#834473 (10Jdforrester-WMF) [20:21:05] 3VisualEditor, OOjs-UI, VisualEditor-MediaWiki: Replace and Replace all buttons are clipped in VisualEditor when using the OOjs UI MediaWiki theme - https://phabricator.wikimedia.org/T78042#834475 (10Jdforrester-WMF) [20:21:07] 3VisualEditor, OOjs-UI, VisualEditor-MediaWiki: Height of the toolbar is insufficient for a constructive button to appear there in the OOjs UI MediaWiki theme - https://phabricator.wikimedia.org/T78043#834474 (10Jdforrester-WMF) [20:21:08] 3VisualEditor, OOjs-UI, VisualEditor-MediaWiki: We need to pick a highlight colour and use it consistently in VisualEditor when using the OOjs UI MediaWiki theme - https://phabricator.wikimedia.org/T78047#834472 (10Jdforrester-WMF) [20:21:09] 3VisualEditor, OOjs-UI, VisualEditor-MediaWiki: Vertical alignment of text in the search-and-replace field is off in VisualEditor when using the OOjs UI MediaWiki theme - https://phabricator.wikimedia.org/T78041#834476 (10Jdforrester-WMF) [20:21:10] 3VisualEditor, OOjs-UI, VisualEditor-MediaWiki: Need for a muted destructive state for buttons which are destructive but not important workflow items in the OOjs UI MediaWiki theme - https://phabricator.wikimedia.org/T78040#834477 (10Jdforrester-WMF) [20:21:11] 3VisualEditor, OOjs-UI, VisualEditor-MediaWiki: Clash between rounded corners and text content is jarring for the category editor in VisualEditor when using the OOjs UI MediaWiki theme - https://phabricator.wikimedia.org/T78039#834478 (10Jdforrester-WMF) [20:21:12] 3VisualEditor, OOjs-UI, VisualEditor-MediaWiki: Dialog section labels are way too big compared to the rest of the contents of a dialog - https://phabricator.wikimedia.org/T78037#834480 (10Jdforrester-WMF) [20:21:13] 3VisualEditor, OOjs-UI, VisualEditor-MediaWiki: Special character inserter width needs adjusting in VisualEditor when using the OOjs UI MediaWiki theme - https://phabricator.wikimedia.org/T78038#834479 (10Jdforrester-WMF) [20:21:16] 3VisualEditor, OOjs-UI, VisualEditor-MediaWiki: Parameter "add more information" field floats very oddly in the transclusion dialog in VisualEditor when using the OOUI MediaWiki theme - https://phabricator.wikimedia.org/T78034#834483 (10Jdforrester-WMF) [20:21:17] 3VisualEditor, OOjs-UI, VisualEditor-MediaWiki: Parameter "add more information" label "No unused fields" placed oddly in the transclusion dialog in VisualEditor when using the OOUI MediaWiki theme - https://phabricator.wikimedia.org/T78035#834482 (10Jdforrester-WMF) [20:21:18] 3VisualEditor, OOjs-UI, VisualEditor-MediaWiki: We should set "destructive" on parameter remove buttons in the transclusion dialog in VisualEditor when using the OOUI MediaWiki theme - https://phabricator.wikimedia.org/T78033#834484 (10Jdforrester-WMF) [20:21:19] 3VisualEditor, OOjs-UI, VisualEditor-MediaWiki: Height of ButtonSelectWidget is too high in MediaWiki theme - https://phabricator.wikimedia.org/T78029#834488 (10Jdforrester-WMF) [20:21:21] 3VisualEditor, OOjs-UI, VisualEditor-MediaWiki: Vertical alignment of text alongside checkbox is off in MediaWiki theme - https://phabricator.wikimedia.org/T78030#834487 (10Jdforrester-WMF) [20:21:22] 3VisualEditor, OOjs-UI, VisualEditor-MediaWiki: Vertical height of panel controls is too low in MediaWiki theme - https://phabricator.wikimedia.org/T78031#834486 (10Jdforrester-WMF) [20:21:23] 3VisualEditor, OOjs-UI, VisualEditor-MediaWiki: Selected state of panel controls is blue, but for ButtonSelectWidgets is grey, in MediaWiki theme - https://phabricator.wikimedia.org/T78032#834485 (10Jdforrester-WMF) [20:22:35] (03PS2) 10Bartosz Dziewoński: RadioInputWidget: Remove documentation lies [oojs/ui] - 10https://gerrit.wikimedia.org/r/178586 [20:22:37] (03PS1) 10Bartosz Dziewoński: [BREAKING CHANGE] CheckboxInputWidget: Allow setting HTML 'value' attribute [oojs/ui] - 10https://gerrit.wikimedia.org/r/178592 [20:24:32] (03PS1) 10Bartosz Dziewoński: testsuitegenerator: Actually filter out non-unique combinations [oojs/ui] - 10https://gerrit.wikimedia.org/r/178593 [20:26:05] 3OOjs-UI, UI-Standardization, MediaWiki-Interface: Switch MediaWiki core's use of OOjs UI to use the MediaWiki theme, not Apex - https://phabricator.wikimedia.org/T78054#834496 (10Jdforrester-WMF) [20:26:45] (03CR) 10Bartosz Dziewoński: [C: 032] "No one cares" [oojs/ui] - 10https://gerrit.wikimedia.org/r/178593 (owner: 10Bartosz Dziewoński) [20:26:56] MatmaRex: Tsk. I care! [20:27:34] (03CR) 10Bartosz Dziewoński: testsuitegenerator: Actually filter out non-unique combinations [oojs/ui] - 10https://gerrit.wikimedia.org/r/178593 (owner: 10Bartosz Dziewoński) [20:27:50] (03CR) 10Bartosz Dziewoński: [C: 032] "No one runs this code" [oojs/ui] - 10https://gerrit.wikimedia.org/r/178593 (owner: 10Bartosz Dziewoński) [20:28:14] James_F: :) [20:28:20] ;-) [20:30:34] 3OOjs-UI: CheckboxInput doesn't support string value, forces boolean and won't work with many use cases in HTML static forms - https://phabricator.wikimedia.org/T76645#834514 (10matmarex) a:3matmarex [20:30:47] (03Merged) 10jenkins-bot: testsuitegenerator: Actually filter out non-unique combinations [oojs/ui] - 10https://gerrit.wikimedia.org/r/178593 (owner: 10Bartosz Dziewoński) [20:31:13] 3OOjs-UI, UI-Standardization, MediaWiki-Interface: Switch MediaWiki core's use of OOjs UI to use the MediaWiki theme, not Apex - https://phabricator.wikimedia.org/T78054#834515 (10Jdforrester-WMF) [20:33:02] 3VisualEditor, OOjs-UI, VisualEditor-MediaWiki: Height of ButtonSelectWidget is too high in MediaWiki theme - https://phabricator.wikimedia.org/T78029#834519 (10Jdforrester-WMF) [20:33:03] 3VisualEditor, OOjs-UI, VisualEditor-MediaWiki: Vertical alignment of text alongside checkbox is off in MediaWiki theme - https://phabricator.wikimedia.org/T78030#834520 (10Jdforrester-WMF) p:5Triage>3High [20:33:05] 3VisualEditor, OOjs-UI, VisualEditor-MediaWiki: Vertical height of panel controls is too low in MediaWiki theme - https://phabricator.wikimedia.org/T78031#834521 (10Jdforrester-WMF) p:5Triage>3High [20:33:06] 3VisualEditor, OOjs-UI, VisualEditor-MediaWiki: Selected state of panel controls is blue, but for ButtonSelectWidgets is grey, in MediaWiki theme - https://phabricator.wikimedia.org/T78032#834522 (10Jdforrester-WMF) p:5Triage>3High [20:33:08] 3VisualEditor, OOjs-UI, VisualEditor-MediaWiki: Parameter "add more information" label "No unused fields" placed oddly in the transclusion dialog in VisualEditor when using the OOUI MediaWiki theme - https://phabricator.wikimedia.org/T78035#834525 (10Jdforrester-WMF) p:5Triage>3High [20:33:09] 3VisualEditor, OOjs-UI, VisualEditor-MediaWiki: We should set "destructive" on parameter remove buttons in the transclusion dialog in VisualEditor when using the OOUI MediaWiki theme - https://phabricator.wikimedia.org/T78033#834523 (10Jdforrester-WMF) p:5Triage>3High [20:33:10] 3VisualEditor, OOjs-UI, VisualEditor-MediaWiki: Special character inserter width needs adjusting in VisualEditor when using the OOjs UI MediaWiki theme - https://phabricator.wikimedia.org/T78038#834526 (10Jdforrester-WMF) p:5Triage>3High [20:33:12] 3VisualEditor, OOjs-UI, VisualEditor-MediaWiki: Parameter "add more information" field floats very oddly in the transclusion dialog in VisualEditor when using the OOUI MediaWiki theme - https://phabricator.wikimedia.org/T78034#834524 (10Jdforrester-WMF) p:5Triage>3High [20:33:13] 3VisualEditor, OOjs-UI, VisualEditor-MediaWiki: Height of the toolbar is insufficient for a constructive button to appear there in the OOjs UI MediaWiki theme - https://phabricator.wikimedia.org/T78043#834529 (10Jdforrester-WMF) p:5Triage>3High [20:33:14] 3VisualEditor, OOjs-UI, VisualEditor-MediaWiki: Replace and Replace all buttons are clipped in VisualEditor when using the OOjs UI MediaWiki theme - https://phabricator.wikimedia.org/T78042#834528 (10Jdforrester-WMF) p:5Triage>3High [20:33:15] 3VisualEditor, OOjs-UI, VisualEditor-MediaWiki: Vertical alignment of text in the search-and-replace field is off in VisualEditor when using the OOjs UI MediaWiki theme - https://phabricator.wikimedia.org/T78041#834527 (10Jdforrester-WMF) [20:33:16] 3VisualEditor, OOjs-UI, VisualEditor-MediaWiki: Vertical spacer before the start of the citation dialog contents is too big in VisualEditor when using the OOjs UI MediaWiki theme - https://phabricator.wikimedia.org/T78045#834530 (10Jdforrester-WMF) p:5Triage>3High [20:33:17] 3VisualEditor, VisualEditor-MediaWiki-Templates, VisualEditor-MediaWiki, OOjs-UI: Vertical alignment of the "add template" button and the search box is incorrect in template dialog in VisualEditor when using the OOjs UI MediaWiki theme - https://phabricator.wikimedia.org/T78052#834534 (10Jdforrester-WMF) p:5Tri... [20:33:18] 3VisualEditor, OOjs-UI, VisualEditor-MediaWiki: Width layout issues in the media insert window in VisualEditor when using the OOjs UI MediaWiki theme - https://phabricator.wikimedia.org/T78050#834533 (10Jdforrester-WMF) p:5Triage>3High [20:33:20] 3VisualEditor, OOjs-UI, VisualEditor-MediaWiki: We need to pick a highlight colour and use it consistently in VisualEditor when using the OOjs UI MediaWiki theme - https://phabricator.wikimedia.org/T78047#834531 (10Jdforrester-WMF) [20:33:21] 3VisualEditor, OOjs-UI, VisualEditor-MediaWiki: Disabled checkbox is almost indistinguishable from an enabled, selected checbox in the OOjs UI MediaWiki theme - https://phabricator.wikimedia.org/T78048#834532 (10Jdforrester-WMF) p:5Triage>3High [20:33:29] 3VisualEditor, OOjs-UI, VisualEditor-MediaWiki: Checked state of checkboxes looks off when zoomed in, in the MediaWiki theme - https://phabricator.wikimedia.org/T78036#834535 (10Jdforrester-WMF) p:5Triage>3Normal [20:33:30] 3VisualEditor, OOjs-UI, VisualEditor-MediaWiki: Clash between rounded corners and text content is jarring for the category editor in VisualEditor when using the OOjs UI MediaWiki theme - https://phabricator.wikimedia.org/T78039#834537 (10Jdforrester-WMF) p:5Triage>3Normal [20:33:31] 3VisualEditor, OOjs-UI, VisualEditor-MediaWiki: Dialog section labels are way too big compared to the rest of the contents of a dialog - https://phabricator.wikimedia.org/T78037#834536 (10Jdforrester-WMF) p:5Triage>3Normal [20:33:34] 3VisualEditor, OOjs-UI, VisualEditor-MediaWiki: Bottom border of text box in save dialog only appears when zoomed in, in VisualEditor when using the OOjs UI MediaWiki theme - https://phabricator.wikimedia.org/T78051#834540 (10Jdforrester-WMF) p:5Triage>3Normal [20:33:35] 3VisualEditor, OOjs-UI, VisualEditor-MediaWiki: Need for a muted destructive state for buttons which are destructive but not important workflow items in the OOjs UI MediaWiki theme - https://phabricator.wikimedia.org/T78040#834538 (10Jdforrester-WMF) [20:33:36] 3VisualEditor, OOjs-UI, VisualEditor-MediaWiki: Layout of the image size options is jarring in VisualEditor when using the OOjs UI MediaWiki theme - https://phabricator.wikimedia.org/T78049#834539 (10Jdforrester-WMF) p:5Triage>3Normal [20:33:49] (03PS1) 10Trevor Parscal: [IDEA] Make icon prefix theme-configurable [oojs/ui] - 10https://gerrit.wikimedia.org/r/178595 [20:34:04] MatmaRex: for your consideration ^^^ just an idea, but it does work [20:34:09] brb, lunch timez [20:34:15] 3VisualEditor, OOjs-UI, VisualEditor-MediaWiki: Height of the toolbar is insufficient for a constructive button to appear there in the OOjs UI MediaWiki theme - https://phabricator.wikimedia.org/T78043#834365 (10Jdforrester-WMF) [20:34:36] 3VisualEditor, OOjs-UI, VisualEditor-MediaWiki: Need for a muted destructive state for buttons which are destructive but not important workflow items in the OOjs UI MediaWiki theme - https://phabricator.wikimedia.org/T78040#834343 (10Jdforrester-WMF) p:5Normal>3High [20:35:11] 3VisualEditor, OOjs-UI, VisualEditor-MediaWiki: Vertical height of panel controls is too low in MediaWiki theme - https://phabricator.wikimedia.org/T78031#834549 (10Jdforrester-WMF) [20:35:17] 3VisualEditor, OOjs-UI, VisualEditor-MediaWiki: Height of ButtonSelectWidget is too high in MediaWiki theme - https://phabricator.wikimedia.org/T78029#834551 (10Jdforrester-WMF) [20:35:32] Yay for a bunch of tasks to fix. [20:37:26] 3VisualEditor, OOjs-UI, VisualEditor-MediaWiki: Bottom border of text box in save dialog only appears when zoomed in, in VisualEditor when using the OOjs UI MediaWiki theme - https://phabricator.wikimedia.org/T78051#834556 (10Jdforrester-WMF) [20:37:30] 3VisualEditor, OOjs-UI, VisualEditor-MediaWiki: Width layout issues in the media insert window in VisualEditor when using the OOjs UI MediaWiki theme - https://phabricator.wikimedia.org/T78050#834564 (10Jdforrester-WMF) [20:37:32] 3VisualEditor, OOjs-UI, VisualEditor-MediaWiki: Layout of the image size options is jarring in VisualEditor when using the OOjs UI MediaWiki theme - https://phabricator.wikimedia.org/T78049#834565 (10Jdforrester-WMF) [20:37:36] 3VisualEditor, OOjs-UI, VisualEditor-MediaWiki: Disabled checkbox is almost indistinguishable from an enabled, selected checbox in the OOjs UI MediaWiki theme - https://phabricator.wikimedia.org/T78048#834566 (10Jdforrester-WMF) [20:37:39] 3VisualEditor, OOjs-UI, VisualEditor-MediaWiki: We need to pick a highlight colour and use it consistently in VisualEditor when using the OOjs UI MediaWiki theme - https://phabricator.wikimedia.org/T78047#834567 (10Jdforrester-WMF) [20:38:19] how do i debug ssh connections taking minutes to complete? :/ [20:38:21] >>> false ? 'foo' : 0 || 1 [20:38:24] 3VisualEditor, OOjs-UI, VisualEditor-MediaWiki: Parameter "add more information" field floats very oddly in the transclusion dialog in VisualEditor when using the OOUI MediaWiki theme - https://phabricator.wikimedia.org/T78034#834578 (10Jdforrester-WMF) [20:38:24] RoanKattouw: (number) 1 [20:38:31] 3VisualEditor, OOjs-UI, VisualEditor-MediaWiki: Dialog section labels are way too big compared to the rest of the contents of a dialog - https://phabricator.wikimedia.org/T78037#834580 (10Jdforrester-WMF) [20:38:36] >>> true ? 'foo' : 0 || 1 [20:38:36] 3VisualEditor, OOjs-UI, VisualEditor-MediaWiki: Vertical height of panel controls is too low in MediaWiki theme - https://phabricator.wikimedia.org/T78031#834581 (10Jdforrester-WMF) [20:38:38] RoanKattouw: (string) 'foo' [20:38:39] 3VisualEditor, OOjs-UI, VisualEditor-MediaWiki: Vertical alignment of text alongside checkbox is off in MediaWiki theme - https://phabricator.wikimedia.org/T78030#834582 (10Jdforrester-WMF) [20:38:41] >>> true ? '' : 0 || 1 [20:38:42] RoanKattouw: (string) '' [20:38:56] >>> (true ? '' : 0) || 1 [20:38:57] RoanKattouw: (number) 1 [20:39:05] OK so that proves that ?: binds more tightly than || [20:39:11] The more you know [20:40:51] TrevorParscal: So, https://phabricator.wikimedia.org/T78054 is the result of the audit I did with kaity|away on what needs urgent fixing before we do the OOjs UI switch-over to the MediaWiki theme. [20:41:13] ok, will look in a few [20:43:05] TrevorParscal: About 2/3rds are VE-specific issues where we code Apex-styling into controls, I think. The other 1/3rd are issues in OOUI. [20:43:09] TrevorParscal: But enjoy lunch. :-) [20:44:17] can anybody here read `ssh -vvv` logs? or know anybody who can? [20:44:25] i'm trying to figure out why i can't pull from gerrit. [20:46:19] I can try [20:50:14] 3OOjs-UI, UI-Standardization, MediaWiki-ResourceLoader: Implement ResourceLoader module to ship CSS for sets of SVG+PNG icons to the user - https://phabricator.wikimedia.org/T76473#834611 (10Jdforrester-WMF) So Idf6ff4eb8e is merged; can this be marked as Resolved? If so, are the "blocking" tasks not really bloc... [20:55:28] eh, it works when i debug it [20:56:56] MatmaRex: Heisenbugs! [20:57:49] (03PS2) 10Bartosz Dziewoński: [BREAKING CHANGE] CheckboxInputWidget: Allow setting HTML 'value' attribute [oojs/ui] - 10https://gerrit.wikimedia.org/r/178592 [20:58:26] (03PS1) 10Bartosz Dziewoński: Update for I32608c7f in OOUI [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178625 [20:58:30] ^ i wonder if i missed any. the metaItemCheckboxes thing is a work of a twisted mind. [20:58:41] haha [20:58:46] The twisted mind of James_F [20:59:12] :-P [20:59:40] (03CR) 10Catrope: [C: 04-1] Refactor out trigger listening to allow target triggers (0310 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/176955 (owner: 10Esanders) [21:02:10] (03PS1) 10Divec: Normalize split text nodes correctly [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178640 [21:02:48] (03PS1) 10Bartosz Dziewoński: Rename some things for my sanity [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178641 [21:03:00] (03CR) 10Catrope: [C: 032] Normalize split text nodes correctly [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178640 (owner: 10Divec) [21:05:01] (03PS2) 10Alex Monk: Prefer localStorage to store ve-beta-welcome-dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174798 (https://bugzilla.wikimedia.org/62884) [21:05:20] 3OOjs-UI: CheckboxInput doesn't support string value, forces boolean and won't work with many use cases in HTML static forms - https://phabricator.wikimedia.org/T76645#834653 (10matmarex) I didn't find any other users. [21:07:17] (03CR) 10Esanders: Trim whitespace when annotating (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177533 (owner: 10Esanders) [21:08:39] (03CR) 10jenkins-bot: [V: 04-1] Rename some things for my sanity [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178641 (owner: 10Bartosz Dziewoński) [21:11:38] (03Merged) 10jenkins-bot: Normalize split text nodes correctly [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178640 (owner: 10Divec) [21:15:25] 3VisualEditor, Parsoid, MediaWiki-Interface, MediaWiki-General-or-Unknown, Services, RESTBase: Use Parsoid HTML for read-only views too - https://phabricator.wikimedia.org/T55784#834691 (10damons) [21:25:07] 3MediaWiki-Page-editing, VisualEditor-EditingTools, MobileFrontend-Feature-requests: iOS: Shake to undo in WTE on mobile does not undo or redo typing - https://phabricator.wikimedia.org/T67600#834805 (10Jaredzimmerman-WMF) [21:26:38] 3OOjs-UI, UI-Standardization, MediaWiki-ResourceLoader: Implement ResourceLoader module to ship CSS for sets of SVG+PNG icons to the user - https://phabricator.wikimedia.org/T76473#834811 (10matmarex) The "blocking" tasks are blocking releasing this as part of a new MediaWiki version. They make the module unusab... [21:27:20] 3OOjs-UI, UI-Standardization, MediaWiki-ResourceLoader: Implement ResourceLoader module to ship CSS for sets of SVG+PNG icons to the user - https://phabricator.wikimedia.org/T76473#834813 (10matmarex) (Perhaps not {T76477}, but the other two do.) [21:27:44] 3OOjs-UI, UI-Standardization, MediaWiki-ResourceLoader: Implement ResourceLoader module to ship CSS for sets of SVG+PNG icons to the user - https://phabricator.wikimedia.org/T76473#834816 (10matmarex) [21:28:31] 3Multimedia, UI-Standardization, MediaWiki-ResourceLoader, MediaWiki-File-management: Create a variant of SvgHandler suitable for T76473 - https://phabricator.wikimedia.org/T76477#801529 (10matmarex) [21:29:55] 3OOjs-UI, UI-Standardization, MediaWiki-ResourceLoader: Implement ResourceLoader module to ship CSS for sets of SVG+PNG icons to the user - https://phabricator.wikimedia.org/T76473#834843 (10matmarex) [21:32:38] (03PS8) 10Esanders: [BREAKING CHANGE] Multiple surface support and demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177109 [21:32:40] (03PS8) 10Esanders: Refactor out trigger listening to allow target triggers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/176955 [21:32:52] (03CR) 10Esanders: Refactor out trigger listening to allow target triggers (038 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/176955 (owner: 10Esanders) [21:34:10] RoanKattouw_away, also OO.ui.Element generates this.$element, whereas ve.init.Target is fed it, so that needs to be refactored too [21:36:17] 3VisualEditor-ContentLanguage, VisualEditor-EditingTools, MediaWiki-Page-editing, VisualEditor-ContentEditable: Rationalize the project names of VE and WTE - https://phabricator.wikimedia.org/T78063#834889 (10Jaredzimmerman-WMF) [21:37:02] 3VisualEditor-ContentLanguage, VisualEditor-EditingTools, MediaWiki-Page-editing, VisualEditor-ContentEditable: Rationalize the project names of VE and WTE - https://phabricator.wikimedia.org/T78063#834819 (10Jaredzimmerman-WMF) [21:38:09] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Multiple surface support and demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177109 (owner: 10Esanders) [21:38:14] (03CR) 10jenkins-bot: [V: 04-1] Refactor out trigger listening to allow target triggers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/176955 (owner: 10Esanders) [21:40:48] so, MatmaRex, how's it going? [21:40:50] you saw https://phabricator.wikimedia.org/T78054 ? [21:41:10] so, for various reasons, this is actually a pretty high priority [21:42:28] 3VisualEditor, VisualEditor-ContentLanguage, VisualEditor-ContentEditable, VisualEditor-EditingTools, MediaWiki-Page-editing, MediaWiki-extensions-WikiEditor: Rationalize the project names of VE and WTE - https://phabricator.wikimedia.org/T78063#834912 (10matmarex) [21:42:55] TrevorParscal: hi, i'm making some more breaking ooui changes :) [21:43:12] seen it, gonna work on the dependencies if it's high-priority [21:43:36] TrevorParscal: have you had time to look at the four tasks i linked you to? [21:44:31] 3MediaWiki-Page-editing, MediaWiki-extensions-WikiEditor: Rationalize the project names of VE and WTE - https://phabricator.wikimedia.org/T78063#834922 (10matmarex) [21:44:49] James_F: oooh, did you just add the umbrella icon or was it there before? [21:45:03] MatmaRex: Just did it. Was meaning to do it for a while. [21:45:08] MatmaRex: Like it? [21:45:14] sure i do [21:45:19] MatmaRex: (The icon was already in Phabricator, if that's what you mean.) [21:45:36] yeah, i've seen it somewhere before, i was wondering why we're not using it [21:46:04] Because I hadn't been prompted. :-) [21:46:53] 3OOjs-UI, VisualEditor-MediaWiki: We should set "destructive" on parameter remove buttons in the transclusion dialog in VisualEditor when using the OOUI MediaWiki theme - https://phabricator.wikimedia.org/T78033#834941 (10Jdforrester-WMF) a:3Jdforrester-WMF [21:48:32] * mooeypoo slaps xchat [21:50:15] 3MediaWiki-Page-editing, MediaWiki-extensions-WikiEditor: Rationalize the project names of VE and WTE - https://phabricator.wikimedia.org/T78063#834956 (10Jaredzimmerman-WMF) thanks for clarifying @matamarex, you kind of hit on what I'm saying. Is there any way we can make the phab project names for these more c... [21:53:26] 3MediaWiki-Page-editing, MediaWiki-extensions-WikiEditor: Rationalize the project names of VE and WTE - https://phabricator.wikimedia.org/T78063#834975 (10Krenair) No, not really. Core's wikitext editing must stay under MediaWiki- and VisualEditor (and WikiEditor) must be separate. [21:53:43] MatmaRex: um, they got lost I guess, can you relink in PM? [21:54:10] Hah. TrevorParscal it could actually be pretty cool to look for an image and see "Created: Stone age." [21:54:25] And then "taken with an iPhone" [21:54:32] lol [21:54:53] that's also tricky, because the subject creation date is different than the image creation date [21:55:20] should all pictures of me be "Created: 31 March 1984"? [21:56:04] 3MediaWiki-extensions-Flow, MobileFrontend-General-or-Unknown, Wikipedia-App-Android-App, MediaWiki-extensions-WikiEditor, MediaWiki-extensions-LiquidThreads, VisualEditor-MediaWiki-Mobile, Wikipedia-App-iOS-App, MediaWiki-extensions-CodeEditor, MediaWiki-Page-editing: Rationalize the project names of VE and WTE -... [21:56:11] MatmaRex: ^^^ But wait, it's worse. ;-( [21:56:27] surely, the time of day, time of year, age of subject, etc. are factors in the image - so the "creation" date may be confusing [21:57:21] Didn't LQT just use WikiEditor or something? :/ [21:57:30] It's been a while since I touched that extension.. [21:57:33] James_F: eh… i don't think all these are very relevant [21:57:56] apps are obviously entirely distinct codebases than what we run on the sites [21:58:00] MatmaRex: They're all "the editor" as Design have labelled whatever was in context. [21:58:05] MatmaRex: Obvious to you. [21:58:21] i believe this is actually obvious to everyone [21:58:27] MatmaRex: And yet… :-( [21:58:31] I wonder if you could include some of the wikidata UI things there... [21:58:32] i hope people understand the difference between apps and websites [21:59:00] liquidthreads indeed uses wikieditor, and does only very few awkward things to it [21:59:10] does flow reimplement the edit toolbar? (please say it doesn't) [21:59:26] MatmaRex: Yes. [21:59:28] MatmaRex: Twice. [21:59:35] MatmaRex: In their VE and their WT editor. [21:59:39] TrevorParscal, ... that's a good point [21:59:40] gods [21:59:40] why [21:59:44] MatmaRex: Quite. [21:59:47] actually, i don't want to know [22:00:18] but that definitely doesn't sound like a bug management issue, that sounds like a coding issue. :) [22:00:43] TrevorParscal, I think that's the fault of the template, though. "Created" is too vague. It should have indicated when the picture was taken, imho, which is usually the important bit, not when the object in the image was created. Also, techincally, pictures of you should have "created" date that's 9 months before 31 March 1984 [22:03:38] (03PS2) 10Esanders: Use target.getSurface now that targets can have multiple surfaces [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/177129 [22:03:40] (03PS2) 10Esanders: File for TriggerListener in VE core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/177130 [22:03:42] (03PS4) 10Esanders: Update toolbar setup methods [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/177131 [22:05:12] (03CR) 10jenkins-bot: [V: 04-1] Update toolbar setup methods [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/177131 (owner: 10Esanders) [22:06:14] (03CR) 10Bartosz Dziewoński: "Hmm, this is actually a lot better than I thought it could be." [oojs/ui] - 10https://gerrit.wikimedia.org/r/178595 (owner: 10Trevor Parscal) [22:06:45] (03CR) 10jenkins-bot: [V: 04-1] File for TriggerListener in VE core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/177130 (owner: 10Esanders) [22:07:03] MatmaRex: It feels like it breaks downstream extension of which icons to use quite badly, though. [22:07:37] MatmaRex: Surely adding a class "oo-ui-icon-" to the existing icons in the system into which OOUI is being used isn't that hard? [22:08:41] 3OOjs-UI: Rename a lot of getters for consistency - https://phabricator.wikimedia.org/T76630#835056 (10TrevorParscal) The idea was simply that there were three classes of getters. 1. Get a single thing that is always there - like input.getValue() 2. Get a single thing that may or may not be there - like booklet... [22:10:10] (03PS1) 10Esanders: [BREAKING CHANGE] Make ve.init.target an OO.ui.Element [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178665 [22:10:12] James_F: i can't quite parse what you said :/ [22:10:34] MatmaRex: See Trevor's "con". [22:10:37] (03PS24) 10Mooeypoo: Eventify TemplateDataGenerator and use oojs-ui [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 [22:10:58] MatmaRex, when/if you have time, the TemplateData dialog is fixed ^^ [22:11:05] 3OOjs-UI: SelectWidget.prototype.getRelativeItem's direction argument is the wrong way around? - https://phabricator.wikimedia.org/T76637#835063 (10TrevorParscal) I only added this because Kirsten was experiencing it behaving in reverse while testing the library out and exercising all methods. If you are confide... [22:11:07] re first thing, yeah, that would probably be somewhat incompatible with "icon packs" [22:11:19] re second thing i don't understand what you mean [22:12:44] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Make ve.init.target an OO.ui.Element [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178665 (owner: 10Esanders) [22:12:47] MatmaRex: If the idiots who made mw-icon-foo can't make it also have the class "oo-ui-icon-foo" then we shouldn't break OOjs UI but help them make that change. [22:13:08] James_F: oh. mw-icon is not really a thing. [22:13:12] MatmaRex: In other words, I've not seen a convincing reason to make this change. [22:13:16] there is exactly one icon defined in that system. [22:13:21] unless someone defined any outside of core. [22:13:27] TrevorParscal, btw, re our conversation about convoluded CSS3 on Friday -- this works: $details.find( '.ve-ui-mwMediaDialog-panel-imageinfo-label:not(:last-of-type)' ).append( ...[span with separator entity]... ); [22:13:34] mooeypoo: will look [22:13:48] MatmaRex: TrevorParscal's patch and IRC chatter talks about lots of pre-existing icons in mediawiki/core.git. [22:14:42] there's a bunch of icons, sure, but no unified system for them [22:15:05] eh, hm. [22:15:07] Isn't that what OOjs UI is going to be? ;-) [22:15:33] there is the .mw-ui-icon class defined in /resources/src/mediawiki.ui/components/icons.less, and this is what has exactly one usage (in the same file) [22:15:38] 3OOjs-UI: Consider changing toggle to toggleVisibility - https://phabricator.wikimedia.org/T76644#835081 (10TrevorParscal) [22:16:04] there are a few .mw-icon-whatever classes defined in random files, the fact that they have a common prefix is a historical accident [22:16:23] 3MediaWiki-Page-editing, VisualEditor-EditingTools, MobileFrontend-Feature-requests: iOS: Shake to undo in WTE on mobile does not undo or redo typing - https://phabricator.wikimedia.org/T67600#835090 (10Jdforrester-WMF) [22:16:32] So burn it to the ground? [22:16:45] burn which? [22:16:54] actually yes, we can probably burn it all if we want to [22:16:55] mw-ui-icon :-) [22:17:14] no idea if MF or Flow or whatever use that [22:17:47] eh [22:17:52] that can wait, anyway [22:19:33] Yes. [22:19:49] (03PS1) 10Esanders: Fix target constructors now they generated this.$element [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178670 [22:19:52] But making bad changes in OOUI to appease people short-term seems like a bad long-term idea. [22:19:56] TrevorParscal might disagree. :-) [22:21:02] (03CR) 10jenkins-bot: [V: 04-1] Fix target constructors now they generated this.$element [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178670 (owner: 10Esanders) [22:23:02] 3OOjs-UI: OOjs UI: Dialogs should be repositionable/draggable - https://phabricator.wikimedia.org/T51969#835122 (10TrevorParscal) [22:23:29] (03PS2) 10Catrope: Fix target constructors now that they generate this.$element [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178670 (owner: 10Esanders) [22:24:15] 3MediaWiki-Page-editing, VisualEditor-EditingTools, MobileFrontend-Feature-requests: iOS: Shake to undo in WTE on mobile does not undo or redo typing - https://phabricator.wikimedia.org/T67600#835133 (10Jaredzimmerman-WMF) @Jdforrester-WMF this behaviour should be supported by both editors on mobile devices whic... [22:24:29] 3MediaWiki-Page-editing, VisualEditor-EditingTools, MobileFrontend-Feature-requests: iOS: Shake to undo on mobile does not undo or redo typing - https://phabricator.wikimedia.org/T67600#835135 (10Jaredzimmerman-WMF) [22:24:31] MatmaRex: ok, replied to all of those tasks [22:24:35] thanks for linking me to them [22:25:00] (03CR) 10jenkins-bot: [V: 04-1] Fix target constructors now that they generate this.$element [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178670 (owner: 10Esanders) [22:25:15] 3MediaWiki-Page-editing, VisualEditor-MediaWiki-Mobile, MobileFrontend-Feature-requests: iOS: Shake to undo on mobile does not undo or redo typing - https://phabricator.wikimedia.org/T67600#835138 (10Jdforrester-WMF) [22:25:40] thanks :D [22:25:54] James_F: I'm not actually recommending we allow mw-ui-icon-* naming [22:26:14] TrevorParscal: OK. In that case I might be a bit lost? [22:26:39] if anything, I think we should have "oo-ui-icon-" be fixed, and all mediawiki specific icons should be prefixed after that, like "oo-ui-icon-mw-nowiki" [22:26:53] I wrote that patch so we could have a concrete conversation about this [22:27:36] (03CR) 10Trevor Parscal: [C: 04-1] "This is probably still a bad idea." [oojs/ui] - 10https://gerrit.wikimedia.org/r/178595 (owner: 10Trevor Parscal) [22:27:42] that's why it's labeled [IDEA] [22:27:47] TrevorParscal: Right, OK. [22:27:53] sorry for the confusion [22:28:06] in any case, it took me like 15 min to explore [22:28:29] * James_F nods. [22:28:49] and in the process I think I convinced myself that we can choose not to make that configurable not because it's hard to make it configurable, but because having it be variable is a bad idea [22:28:54] moving targets are hard to hit [22:28:55] aye [22:29:25] imagine how messy this would be in VisualEditor [22:29:28] (03CR) 10Catrope: [C: 031] "This probably also requires a MobileFrontend change?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178670 (owner: 10Esanders) [22:29:35] * James_F nods. [22:29:42] we would need to export our icons as either mw or oo prefixed [22:29:53] or, I guess both? [22:29:54] ugh [22:30:26] Yeah. [22:30:29] then again, it may be that in MW you don't bother with the stock VE icons and you provide your own anyway because you are trying to match your theme [22:30:39] TrevorParscal: I feel the need to go through this with you on a whiteboad. [22:30:45] and the prefixing doesn't affect you because you never tried to use stock VE icons with MW [22:30:46] TrevorParscal: Tomorrow, maybe? [22:30:50] yes [22:30:52] that's fine [22:30:55] Kk. [22:32:13] the whiteboard will just have a bunch of curvy arrows pointing at each other, maybe eventually looking something like this: http://www.theoreticallogic.com/2011/07/microsoft-internet-explorer-javascript-engine/ [22:34:30] 3OOjs-UI, UI-Standardization, MediaWiki-Interface: Decide whether or not to use hover to indicate which item in menus/etc. we're about to select, in the MediaWiki theme - https://phabricator.wikimedia.org/T78082 (10Jdforrester-WMF) 3NEW p:3High a:3Jdforrester-WMF [22:34:58] TrevorParscal: Thoughts on https://phabricator.wikimedia.org/T78082 (should we have a hover) and https://phabricator.wikimedia.org/T78032 (if so, can we pick a single colour please). [22:35:11] Also, ha. :-) [22:35:13] (03PS3) 10Esanders: Trim whitespace when annotating [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177533 [22:35:44] 3OOjs-UI, VisualEditor-MediaWiki: Selected state of panel controls is blue, but for ButtonSelectWidgets is grey, in MediaWiki theme - https://phabricator.wikimedia.org/T78032#835193 (10Jdforrester-WMF) [22:35:52] (03PS6) 10Divec: WIP: Native leftarrow, rightarrow, backspace and delete [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177946 [22:36:20] (03CR) 10Divec: "Patchset 6: rebase" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177946 (owner: 10Divec) [22:36:47] (03CR) 10Catrope: [C: 032] Trim whitespace when annotating [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177533 (owner: 10Esanders) [22:37:24] (03CR) 10Catrope: [C: 032] Prefer localStorage to store ve-beta-welcome-dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174798 (https://bugzilla.wikimedia.org/62884) (owner: 10Alex Monk) [22:38:49] 3OOjs-UI, VisualEditor-MediaWiki: Selected state of panel controls is blue, but for ButtonSelectWidgets is grey, in MediaWiki theme - https://phabricator.wikimedia.org/T78032#835199 (10TrevorParscal) In the MediaWiki theme, selected is shown as gray - the same as seen with ButtonOptionWidget. This is to avoid se... [22:39:12] (03Merged) 10jenkins-bot: Prefer localStorage to store ve-beta-welcome-dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174798 (https://bugzilla.wikimedia.org/62884) (owner: 10Alex Monk) [22:39:50] 3OOjs-UI, UI-Standardization, MediaWiki-Interface: Decide whether or not to use hover to indicate which item in menus/etc. we're about to select, in the MediaWiki theme - https://phabricator.wikimedia.org/T78082#835204 (10TrevorParscal) I think hover states are valuable and expected on desktop. The MediaWiki the... [22:40:21] (03PS2) 10Esanders: [BREAKING CHANGE] Make ve.init.target an OO.ui.Element [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178665 [22:40:37] (03PS3) 10Esanders: Fix target constructors now they generated this.$element [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178670 [22:40:51] TrevorParscal: Is "skitzo" the preferred term? :-) [22:41:27] 3OOjs-UI, VisualEditor-MediaWiki: Selected state of panel controls is blue, but for ButtonSelectWidgets is grey, in MediaWiki theme - https://phabricator.wikimedia.org/T78032#835205 (10Jdforrester-WMF) [22:42:15] skitzo: of 2+ minds [22:42:23] :-P [22:43:28] (03CR) 10jenkins-bot: [V: 04-1] Fix target constructors now they generated this.$element [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178670 (owner: 10Esanders) [22:43:59] 3OOjs-UI, UI-Standardization, MediaWiki-Interface: Shadow at the bottom of the dropdown menus is vertically mis-aligned by a pixel or two in the MediaWiki theme - https://phabricator.wikimedia.org/T78083 (10Jdforrester-WMF) 3NEW p:3High [22:45:52] (03CR) 10jenkins-bot: [V: 04-1] WIP: Native leftarrow, rightarrow, backspace and delete [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177946 (owner: 10Divec) [22:47:19] 3VisualEditor-EditingTools: Make lighter icons for the bullet/numbered list controls, in keeping with wider icon theme (and indent/outdent icons) - https://phabricator.wikimedia.org/T78084#835229 (10Jdforrester-WMF) [22:47:26] 3VisualEditor-EditingTools: Make lighter icons for the bullet/numbered list controls, in keeping with wider icon theme (and indent/outdent icons) - https://phabricator.wikimedia.org/T78084#835229 (10Jdforrester-WMF) p:5Triage>3Normal [22:47:27] (03CR) 10Catrope: [BREAKING CHANGE] Make ve.init.target an OO.ui.Element (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178665 (owner: 10Esanders) [22:47:31] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Make ve.init.target an OO.ui.Element [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178665 (owner: 10Esanders) [22:48:23] 3MediaWiki-extensions-Flow, MobileFrontend-General-or-Unknown, Wikipedia-App-Android-App, MediaWiki-extensions-WikiEditor, Collaboration-Team, MediaWiki-extensions-LiquidThreads, VisualEditor-MediaWiki-Mobile, Wikipedia-App-iOS-App, MediaWiki-extensions-CodeEditor, MediaWiki-Page-editing: Rationalize the project n... [22:48:40] 3MediaWiki-extensions-Flow, MobileFrontend-General-or-Unknown, Wikipedia-App-Android-App, MediaWiki-extensions-WikiEditor, Collaboration-Team, MediaWiki-extensions-LiquidThreads, VisualEditor-MediaWiki-Mobile, Wikipedia-App-iOS-App, MediaWiki-extensions-CodeEditor, MediaWiki-Page-editing: Rationalize the project n... [22:48:52] 3OOjs-UI: Toolbars should have a heavy shadow on their bottom in the MediaWiki theme - https://phabricator.wikimedia.org/T78085 (10Jdforrester-WMF) 3NEW p:3Normal [22:48:52] (03CR) 10Catrope: [C: 04-1] [BREAKING CHANGE] Make ve.init.target an OO.ui.Element (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178665 (owner: 10Esanders) [22:49:18] (03Merged) 10jenkins-bot: Trim whitespace when annotating [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177533 (owner: 10Esanders) [22:49:46] 3MediaWiki-extensions-Flow, MobileFrontend-General-or-Unknown, Wikipedia-App-Android-App, MediaWiki-extensions-WikiEditor, Collaboration-Team, MediaWiki-extensions-LiquidThreads, VisualEditor-MediaWiki-Mobile, Wikipedia-App-iOS-App, MediaWiki-extensions-CodeEditor, MediaWiki-Page-editing: Rationalize the project n... [22:50:01] (03CR) 10Catrope: [C: 031] Refactor out trigger listening to allow target triggers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/176955 (owner: 10Esanders) [22:51:05] (03PS1) 10Tim Starling: Fix duplicate wikitext parse for displaytitle [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178692 [22:51:38] 3MediaWiki-extensions-Flow, MobileFrontend-General-or-Unknown, Wikipedia-App-Android-App, MediaWiki-extensions-WikiEditor, Collaboration-Team, MediaWiki-extensions-LiquidThreads, VisualEditor-MediaWiki-Mobile, Wikipedia-App-iOS-App, MediaWiki-extensions-CodeEditor, MediaWiki-Page-editing: Rationalize the project n... [22:52:23] (03CR) 10Catrope: [C: 032] Fix duplicate wikitext parse for displaytitle [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178692 (owner: 10Tim Starling) [22:52:35] TimStarling: Thanks! [22:53:14] yw [22:53:27] +1. :-) [22:54:26] I managed to avoid refactoring hundreds of lines of code code with that one [22:54:35] although I am still considering it as a followup... [22:54:41] (03Merged) 10jenkins-bot: Fix duplicate wikitext parse for displaytitle [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178692 (owner: 10Tim Starling) [22:54:49] TimStarling: Refactors welcome. [22:55:20] Our API modules are pretty nasty [22:55:24] (03CR) 10Esanders: [BREAKING CHANGE] Make ve.init.target an OO.ui.Element (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178665 (owner: 10Esanders) [22:55:25] Definitely not our proudest moment [22:55:30] (03PS3) 10Esanders: [BREAKING CHANGE] Make ve.init.target an OO.ui.Element [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178665 [22:55:46] (03CR) 10Catrope: [C: 031] [BREAKING CHANGE] Make ve.init.target an OO.ui.Element [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178665 (owner: 10Esanders) [22:56:33] yeah, getting the ParserOutput that you just generated a millisecond ago from ApiParse via the ParserCache is a bit inelegant [22:57:11] ideally you would use the same object rather than serialize, send it off to memcached, get it back, and unserialize [22:57:28] (03PS4) 10Esanders: Fix target constructors now they generate this.$element [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178670 [22:57:45] 3Design, VisualEditor-EditingTools: Make lighter icons for the bullet/numbered list controls, in keeping with wider icon theme (and indent/outdent icons) - https://phabricator.wikimedia.org/T78084#835257 (10KHammerstein) [22:58:24] but that is probably not our largest concern [22:58:31] as far as performance goes ;) [22:58:42] (03CR) 10jenkins-bot: [V: 04-1] Fix target constructors now they generate this.$element [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178670 (owner: 10Esanders) [22:59:36] Karma seems to timeout more often than not [23:00:32] edsanders: Is karma running for VE-MW? Isn't that the whole point of Timo's work? [23:00:52] edsanders: Oh, you mean for https://gerrit.wikimedia.org/r/#/c/178665/ ? [23:00:54] dunno, this is a core commit [23:01:04] Yeah, karma's running for VE-core. [23:02:51] 3OOjs-UI: Menus' dropdown icons should be smaller and lighter in the MediaWiki theme - https://phabricator.wikimedia.org/T78086 (10Jdforrester-WMF) 3NEW p:3Normal [23:12:40] 3OOjs-UI, VisualEditor-MediaWiki: We should set "destructive" on parameter remove buttons in the transclusion dialog in VisualEditor when using the OOUI MediaWiki theme - https://phabricator.wikimedia.org/T78033#835291 (10TrevorParscal) Gosh that looks terrible. I don't know that the style guide actually demands... [23:15:47] 3OOjs-UI, VisualEditor-MediaWiki: We need to pick a highlight colour and use it consistently in VisualEditor when using the OOjs UI MediaWiki theme - https://phabricator.wikimedia.org/T78047#835311 (10TrevorParscal) See T78032, I think the MediaWiki theme calls for light gray for highlighted and a medium gray fo... [23:16:42] 3OOjs-UI, VisualEditor-MediaWiki: Disabled checkbox is almost indistinguishable from an enabled, selected checbox in the OOjs UI MediaWiki theme - https://phabricator.wikimedia.org/T78048#835315 (10TrevorParscal) [23:17:42] 3OOjs-UI, VisualEditor-MediaWiki: Width layout issues in the media insert window in VisualEditor when using the OOjs UI MediaWiki theme - https://phabricator.wikimedia.org/T78050#835323 (10TrevorParscal) As long as the upcoming image fitting stuff works we can ignore this. This inflexibility is a problem with th... [23:18:42] 3OOjs-UI, VisualEditor-MediaWiki: Need for a muted destructive state for buttons which are destructive but not important workflow items in the OOjs UI MediaWiki theme - https://phabricator.wikimedia.org/T78040#835327 (10TrevorParscal) Seems like destructive + primary should be the only case where a red fill is u... [23:19:23] 3OOjs-UI, VisualEditor-MediaWiki: Checked state of checkboxes looks off when zoomed in, in the MediaWiki theme - https://phabricator.wikimedia.org/T78036#835329 (10TrevorParscal) Given how delicate the technique is, it may or may not be possible to resolve this rendering error. [23:19:53] MatmaRex: how're you doing? [23:19:57] what'cha up to? [23:22:11] 3OOjs-UI, UI-Standardization, MediaWiki-Interface: Switch MediaWiki core's use of OOjs UI to use the MediaWiki theme, not Apex - https://phabricator.wikimedia.org/T78054#835332 (10TrevorParscal) Mostly we are looking at alignment, margin and padding adjustments. In a few cases there are some serious design decis... [23:22:20] TrevorParscal: right now i think i'm gonna hit the bed. tomorrow will probably be the blockers to https://phabricator.wikimedia.org/T78054 [23:22:33] sweet [23:22:49] thanks for your excellent work man [23:22:59] we're targeting this for next week's cut? [23:23:22] or after holidays? (this = switching OOUI to MW theme) [23:25:03] RoanKattouw_away: statsv endpoint is up and ready for metrics [23:31:23] MatmaRex: um, ideally we can get those small fixes merged in and be willing to switch to the mediawiki theme with the cut tomorrow [23:31:29] or something like that [23:35:05] uh oh [23:36:32] ? [23:36:35] uh oh? [23:36:47] am I saying something crazy? [23:38:06] i'm not sure what exactly needs doing, but judging by the number of tasks, that might take a few hours [23:38:32] if you're depending on me, then i'm disappearing soon and only reappearing around 9 AM SF time tomorrow [23:38:59] that's fine [23:39:08] yeah, I think it's only a little bit of work, either of us can do it [23:39:12] maybe we can split it up [23:39:32] I will need to look after the tasks with unclear resolutions for sure [23:45:55] i'm feeling well, thank goodness - no more cold, no more flu [23:46:33] but this past couple of weeks has beaten me down, and now I'm falling asleep at my keyboard - so I'm going to take a nap [23:46:46] I'll get back on later... cyall [23:50:05] (03CR) 10Krinkle: [C: 031] "Yay" (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178665 (owner: 10Esanders) [23:50:26] edsanders|away: James_F: Time out for local browsers or saucelabs? [23:54:08] Krinkle: Lol, great minds etc [23:54:14] Krinkle: Compare https://gerrit.wikimedia.org/r/#/c/178665/2/demos/ve/demo.js and https://gerrit.wikimedia.org/r/#/c/178665/3/demos/ve/demo.js :D [23:54:38] RoanKattouw: hah [23:54:57] (03PS2) 10Catrope: Move from legacy TimingData schema to new statsd API [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178415 [23:55:50] ori: https://gerrit.wikimedia.org/r/#/c/178415/2 [23:57:10] ... omg [23:57:22] * mooeypoo just ran into a REALLY interesting API response