[00:00:55] <Krenair>	 ?
[00:02:41] <grrrit-wm>	 (03PS1) 10Jforrester: ve.ui.MWParameter*: Use the destructive flag for all four remove buttons [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178717 
[00:02:48] <wikibugs>	 3OOjs-UI, VisualEditor-MediaWiki: We should set "destructive" on parameter remove buttons in the transclusion dialog in VisualEditor when using the OOUI MediaWiki theme - https://phabricator.wikimedia.org/T78033#835499 (10Jdforrester-WMF)
[00:03:06] <RoanKattouw>	 mooeypoo: Now we want to know
[00:03:10] <mooeypoo>	 RoanKattouw, TrevorP|Away James_F do check your email for a laugh. And cry, maybe.
[00:03:16] <mooeypoo>	 RoanKattouw, I sent you lovely screenshots.
[00:03:29] <mooeypoo>	 I <3 the media api. It's so predictable and standardized.
[00:04:19] <mooeypoo>	 It's all TrevorP|Away's fault. He mentioned that I've been looking at pictures of screenshots, which don't look as good as pictures of nice vistas and fields. 
[00:05:00] <mooeypoo>	 I tried searching for "vista" but I get a lot of Microsoft stuff :D
[00:05:12] <RoanKattouw>	 lol
[00:05:14] <RoanKattouw>	 Ahm
[00:05:15] <wikibugs>	 3OOjs-UI, VisualEditor-MediaWiki: Width layout issues in the media insert window in VisualEditor when using the OOjs UI MediaWiki theme - https://phabricator.wikimedia.org/T78050#835500 (10Jdforrester-WMF) What about the width of the search box being different from the width of the search results?
[00:05:26] <RoanKattouw>	 Put user-generated content at the bottom, not the middle?
[00:05:37] <RoanKattouw>	 Then it can be as long as it wants to be without pushing down any of your stuff
[00:05:57] <mooeypoo>	 RoanKattouw, this is the field titled "Artist"
[00:06:01] <RoanKattouw>	 WHAT
[00:06:03] <mooeypoo>	 which is supposed to contain the artist's name.
[00:06:12] <RoanKattouw>	 That artist has a very long name then
[00:06:15] <mooeypoo>	 "user:Mooeypoo" with a link is the most common that I've seen
[00:06:26] <mooeypoo>	 yes, notice that after aaaaall that html crap, there's "Own work"
[00:06:26] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 04-1] "Haven't gotten around to review the code yet, sorry, but I played with it." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 (owner: 10Mooeypoo)
[00:06:28] <mooeypoo>	 :D
[00:07:36] <mooeypoo>	 RoanKattouw, I could as a matter of principle strip all html from that field, *but* (a) That will also strip the link to user pages which they usually supply, and (b) it wouldn't have helped here, you'd jave just seen a bunch of text about commercial and non commercial.
[00:08:34] <mooeypoo>	 RoanKattouw, TrevorParscal, I'm not sure what to recommend. I'm hoping this is a fluke that doesn't happen often. But it *does* show us the inherent problem of trusting templated user-driven data in displaying image info :\
[00:08:38] <MatmaRex>	 mooeypoo: i'll give it a proper code review tomorrow when we're not shipping last-minute OOUI changes. :)
[00:08:45] <mooeypoo>	 MatmaRex, awesome, thanks!
[00:09:17] <mooeypoo>	 oops about your bug... ha, I'll fix it
[00:10:10] <grrrit-wm>	 (03Abandoned) 10Jforrester: Remove $ from wgExtensionCredits [extensions/WikiEditor] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/177579 (owner: 10Paladox)
[00:10:15] <grrrit-wm>	 (03Abandoned) 10Jforrester: Remove $ from wgExtensionCredits [extensions/WikiEditor] (wmf/1.25wmf11) - 10https://gerrit.wikimedia.org/r/177577 (owner: 10Paladox)
[00:11:09] <Krenair>	 RoanKattouw, messing with transclusion dialog/model stuff again :/ I've noticed that when I reopen the dialog for a template I just inserted, the transclusion model starts with 0 parts again and has to process them being re-added - emitting a change event in the process. but the transclusion dialog still thinks everything was already loaded
[00:12:50] <grrrit-wm>	 (03CR) 10Mooeypoo: "Oops, the language option is a bug, I'm fixing that in the net patchset. Thanks!" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 (owner: 10Mooeypoo)
[00:12:58] <RoanKattouw>	 Krenair: Ugh
[00:13:08] <RoanKattouw>	 Yeah that code is a bit of a mess here and there
[00:13:18] <grrrit-wm>	 (03PS25) 10Mooeypoo: Eventify TemplateDataGenerator and use oojs-ui [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 
[00:13:21] <RoanKattouw>	 The async population is hard to reason about so I'm not too surprised there are bugs when reopening
[00:20:35] <James_F>	 RoanKattouw: https://github.com/wikimedia/mediawiki-tools-release/blob/HEAD/make-extension-branches/make-extension-branches
[00:22:33] <grrrit-wm>	 (03PS1) 10Jforrester: Update VE core submodule to master (b6423de) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178721 
[00:22:58] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Update VE core submodule to master (b6423de) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178721 (owner: 10Jforrester)
[00:24:59] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update VE core submodule to master (b6423de) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178721 (owner: 10Jforrester)
[00:25:44] <grrrit-wm>	 (03PS3) 10Ori.livneh: Move from legacy TimingData schema to new statsd API [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178415 (owner: 10Catrope)
[00:25:50] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 032] Move from legacy TimingData schema to new statsd API [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178415 (owner: 10Catrope)
[00:27:46] <grrrit-wm>	 (03Merged) 10jenkins-bot: Move from legacy TimingData schema to new statsd API [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178415 (owner: 10Catrope)
[00:28:05] <James_F>	 Whee.
[00:28:17] <ori>	 could we still get that out today?
[00:30:40] <James_F>	 ori: RoanKattouw?
[00:30:52] <ori>	 RoanKattouw: James_F?
[00:30:53] <RoanKattouw>	 Ahm, sure?
[00:33:00] <James_F>	 Krinkle: Did https://gerrit.wikimedia.org/r/#/c/177107/ meet with your testing satisfaction?
[00:34:58] <RoanKattouw>	 ori: Yeah let's do it
[00:35:06] <RoanKattouw>	 We'll need the WMEvents change as well as the VE change
[00:36:11] <wikibugs>	 3VisualEditor-ContentLanguage: VisualEditor: a line started with Japanese input disappear when I switch to and start non-Japanese (latin) input - https://phabricator.wikimedia.org/T74508#835592 (10Jdforrester-WMF)
[00:40:07] <James_F>	 RoanKattouw: https://gerrit.wikimedia.org/r/#/c/178728/
[00:41:18] <grrrit-wm>	 (03PS1) 10Catrope: Move from legacy TimingData schema to new statsd API [extensions/VisualEditor] (wmf/1.25wmf11) - 10https://gerrit.wikimedia.org/r/178730 
[00:41:40] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Move from legacy TimingData schema to new statsd API [extensions/VisualEditor] (wmf/1.25wmf11) - 10https://gerrit.wikimedia.org/r/178730 (owner: 10Catrope)
[00:41:44] <grrrit-wm>	 (03CR) 10Jforrester: [C: 031] Move from legacy TimingData schema to new statsd API [extensions/VisualEditor] (wmf/1.25wmf11) - 10https://gerrit.wikimedia.org/r/178730 (owner: 10Catrope)
[00:41:51] <RoanKattouw>	 ori: Wait, it's called statsv, not statsd?
[00:41:59] <RoanKattouw>	 I've been calling it statsd everywhere
[00:42:03] <RoanKattouw>	 Including the config var
[00:42:22] <James_F>	 RoanKattouw: Whoops. :-)
[00:42:25] <James_F>	 RoanKattouw: Rename it later.
[00:43:41] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Move from legacy TimingData schema to new statsd API [extensions/VisualEditor] (wmf/1.25wmf11) - 10https://gerrit.wikimedia.org/r/178730 (owner: 10Catrope)
[00:46:01] <ori>	 RoanKattouw: it's OK; statsd is the name of the popular metric aggregator; statsv is a pun on that since its a varnish->statsd gateway
[00:46:14] <RoanKattouw>	 Ooooh
[00:46:15] <RoanKattouw>	 OK
[00:46:23] <wikibugs>	 3VisualEditor-MediaWiki-Media: In the media adding dialog, LTR direction is forced on the description field even in RTL wikis - https://phabricator.wikimedia.org/T71969#835633 (10Amire80) The problem is probably in ve.dm.Document.js, line 40.  I know little about the DM, so it may be a naive question, but is the...
[00:46:26] <RoanKattouw>	 Krinkle: Grumble grumble Jenkins grumble https://integration.wikimedia.org/ci/job/mwext-VisualEditor-npm/5882/console
[00:46:29] <RoanKattouw>	 Krinkle: Race condition?
[00:46:43] <grrrit-wm>	 (03CR) 10Catrope: [V: 032] Move from legacy TimingData schema to new statsd API [extensions/VisualEditor] (wmf/1.25wmf11) - 10https://gerrit.wikimedia.org/r/178730 (owner: 10Catrope)
[00:47:13] <aharoni>	 mooeypoo + whoever knows the dm, see https://phabricator.wikimedia.org/T71969
[00:48:39] <wikibugs>	 3VisualEditor-MediaWiki-Media: In the media adding dialog, LTR direction is forced on the description field even in RTL wikis - https://phabricator.wikimedia.org/T71969#835643 (10Catrope) >>! In T71969#835633, @Amire80 wrote: > The problem is probably in ve.dm.Document.js, line 40. >  > I know little about the D...
[01:01:42] <wikibugs>	 3VisualEditor-MediaWiki-Media: In the media adding dialog, LTR direction is forced on the description field even in RTL wikis - https://phabricator.wikimedia.org/T71969#835661 (10Amire80) Fair enough :)  Can it be just set to nothing if not given as an argument? I just brutally removed these two lines, and it so...
[01:24:54] <grrrit-wm>	 (03PS1) 10Ryasmeen: [BROWSERTEST] Adding tests for checking fields under Page Settings [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178741 
[01:30:49] <Krinkle>	 RoanKattouw: Not sure.
[01:31:00] <RoanKattouw>	 There's also a socket error so maybe not
[01:31:06] <Krinkle>	 RoanKattouw: How long ago was that?
[01:31:20] <RoanKattouw>	 An hour? Hour and a half?
[01:31:27] <Krinkle>	 49 minutes
[01:31:50] <Krinkle>	 Sorry, that was a useless question.
[01:32:09] <Krinkle>	 RoanKattouw: OK I thought maybe someone rebooted Gearman
[01:32:10] <Krinkle>	 that tends to produce an error ilke that
[01:32:23] <Krinkle>	 no idea. If you see it more than once, let me know or file a phab
[01:33:45] <James_F>	 Krinkle: Eww.
[01:33:56] <James_F>	 Krinkle: Please, let's not encourage people to use that as a noun.
[01:35:12] <wikibugs>	 3VisualEditor-MediaWiki: [Regression pre-wmf12]- “Uncaught TypeError: undefined is not a function” when selecting the indicator-down arrow and the pop-up overrides the category. - https://phabricator.wikimedia.org/T76931#835702 (10Jdforrester-WMF)
[01:35:18] <RoanKattouw>	 I haven't seen it twice yet
[01:38:30] <Krinkle>	 James_F: Okay, I won't encourage people to fab tickets.
[01:38:35] <Krinkle>	 Can I use it as a verb?
[01:38:39] <Krinkle>	 I think I just did :P
[01:39:00] <RoanKattouw>	 Pretty much any verb can be nouned in English
[01:39:41] <James_F>	 Krinkle: You are so getting in trouble when I fly back to London. :-)
[01:41:56] <wikibugs>	 3VisualEditor-MediaWiki, VisualEditor-ContentEditable: Multiline list items rendering differently in ContentEditable than the resulting wikitext - https://phabricator.wikimedia.org/T57746#835714 (10Jdforrester-WMF) p:5Triage>3Normal
[01:50:13] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] "I tried the demo and it looks like something is broken about the interaction with find and replace:" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/176955 (owner: 10Esanders)
[01:54:36] <wikibugs>	 3VisualEditor-ContentEditable: Cursoring with arrows from outside a table into it and typing causes pawns - https://phabricator.wikimedia.org/T75691#835731 (10Jdforrester-WMF)
[01:55:27] <wikibugs>	 3OOjs-UI: OOjs UI: Dialogs should be repositionable/draggable - https://phabricator.wikimedia.org/T51969#835733 (10Jdforrester-WMF)
[01:56:12] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] [BREAKING CHANGE] Multiple surface support and demo (038 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177109 (owner: 10Esanders)
[01:57:15] <wikibugs>	 3OOjs-UI: OOjs UI: Dialogs should be repositionable/draggable - https://phabricator.wikimedia.org/T51969#835736 (10Jdforrester-WMF) >>! In T51969#821409, @matmarex wrote: > I'm increasingly convinced that draggable dialogs in general are a solution in search of a problem. (It could be interesting to do, but shou...
[01:59:43] <wikibugs>	 3VisualEditor-ContentEditable: Cursoring with arrows from outside a table into it and typing causes pawns - https://phabricator.wikimedia.org/T75691#835749 (10Jdforrester-WMF)
[01:59:47] <wikibugs>	 3OOjs-UI: Toolbars should have a heavy shadow on their bottom in the MediaWiki theme - https://phabricator.wikimedia.org/T78085#835750 (10Jdforrester-WMF)
[02:02:48] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] ve.ui.MWParameter*: Use the destructive flag for all four remove buttons [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178717 (owner: 10Jforrester)
[02:04:36] <grrrit-wm>	 (03Merged) 10jenkins-bot: ve.ui.MWParameter*: Use the destructive flag for all four remove buttons [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178717 (owner: 10Jforrester)
[02:05:47] <grrrit-wm>	 (03PS13) 10Mooeypoo: [WIP] Transform the search widget to show image details [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161342 
[02:07:32] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [WIP] Transform the search widget to show image details [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161342 (owner: 10Mooeypoo)
[02:13:47] <wikibugs>	 3VisualEditor-MediaWiki-Media: In the media adding dialog, LTR direction is forced on the description field even in RTL wikis - https://phabricator.wikimedia.org/T71969#835775 (10Mooeypoo) I've looked through the hierarchy of the surface and the document direction and language; it seems to me that it's a good id...
[02:15:34] <wikibugs>	 3Wikipedia-App-Android-App, MediaWiki-extensions-WikiEditor, Wikipedia-App-iOS-App, VisualEditor-MediaWiki-Mobile, MediaWiki-extensions-CodeEditor, MediaWiki-Page-editing: Rationalize the project names of VE and wikitext editor - https://phabricator.wikimedia.org/T78063#835778 (10Mattflaschen)
[02:48:20] <wikibugs>	 3OOjs-UI: OOjs UI: Dialogs should be repositionable/draggable - https://phabricator.wikimedia.org/T51969#835818 (10John_Broughton)
[05:19:35] <wikibugs>	 3VisualEditor-MediaWiki: [Regression pre-wmf12]- “Uncaught TypeError: undefined is not a function” when selecting the indicator-down arrow and the pop-up overrides the category. - https://phabricator.wikimedia.org/T76931#835943 (10Swainr) Sorry, this bug has disappeared.Please close this issue.
[05:27:57] <wikibugs>	 3VisualEditor-Tables: Menu items in tables (e.g., "Insert before") are truncated in Indonesian - https://phabricator.wikimedia.org/T78119#835947 (10Whatamidoing-WMF)
[05:43:47] <wikibugs>	 3VisualEditor-ContentLanguage, VisualEditor-Tables: Chinese table contents are lost when saving in VisualEditor, unless the first letter is in the Latin alphabet - https://phabricator.wikimedia.org/T78121 (10Whatamidoing-WMF) 3NEW p:3Triage
[05:55:58] <wikibugs>	 3VisualEditor-ContentLanguage: Chinese full stop disappears at the end of paragraphs, if preceded by ref tags - https://phabricator.wikimedia.org/T78122 (10Whatamidoing-WMF) 3NEW p:3Triage
[06:07:41] <wikibugs>	 3VisualEditor-ContentEditable: VisualEditor: Using browser native interactive spell-check when the changed word in the only item in the paragraph causes endless insertions in Firefox - https://phabricator.wikimedia.org/T74929#835987 (10Whatamidoing-WMF)
[06:24:24] <wikibugs>	 3VisualEditor-ContentEditable: Native browser interactive spell-check tool fails to get content into DM, just CE, in Safari - https://phabricator.wikimedia.org/T61748#836003 (10Whatamidoing-WMF)
[07:12:53] <wikibugs>	 3VisualEditor-ContentLanguage: VisualEditor: CE eats up syllables except a last syllable of a word in Korean IME - https://phabricator.wikimedia.org/T52631#836024 (10Revi)
[07:20:02] <wikibugs>	 3VisualEditor-ContentLanguage: VisualEditor: CE eats up syllables except a last syllable of a word in Korean IME - https://phabricator.wikimedia.org/T52631#836028 (10Jdforrester-WMF) >>! In T52631#836024, @Revi wrote: > Hmm, while reviewing [[ https://ko.wikipedia.org/w/index.php?title=특수:최근바뀜&tagfilter=visualed...
[07:20:52] <wikibugs>	 3VisualEditor-MediaWiki: [Regression pre-wmf12]- “Uncaught TypeError: undefined is not a function” when selecting the indicator-down arrow and the pop-up overrides the category. - https://phabricator.wikimedia.org/T76931#836030 (10Jdforrester-WMF)
[09:13:35] <grrrit-wm>	 (03CR) 10Hashar: [C: 04-1] "I don't think the Gemfile.lock file should be added to the repository. It has been added to the change with patchset 23 and seems to refle" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/122400 (owner: 10Jagori79)
[09:46:02] <wikibugs>	 3VisualEditor-ContentLanguage: Chinese full stop disappears at the end of paragraphs, if preceded by ref tags - https://phabricator.wikimedia.org/T78122#836118 (10Byfserag) p:5Triage>3High
[11:04:32] <grrrit-wm>	 (03CR) 10Esanders: "Yes - I noted this as a mental todo. It will happen with an inspector too I imagine, as they focus the surface when closed, stealing focus" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/176955 (owner: 10Esanders)
[11:18:50] <grrrit-wm>	 (03CR) 10Esanders: [BREAKING CHANGE] Multiple surface support and demo (035 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177109 (owner: 10Esanders)
[11:25:11] <grrrit-wm>	 (03CR) 10Esanders: [BREAKING CHANGE] Multiple surface support and demo (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177109 (owner: 10Esanders)
[11:30:06] <wikibugs>	 3VisualEditor-MediaWiki: VisualEditor: Where VisualEditor is the primary editor, redlinks in read mode should go to veaction=edit not action=edit - https://phabricator.wikimedia.org/T55441#836192 (10Ricordisamoa) a:3Ricordisamoa Let's give it a try.
[11:51:33] <grrrit-wm>	 (03PS8) 10Esanders: [BREAKING CHANGE] Refactor for multiple surfaces [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/176952 
[11:51:35] <grrrit-wm>	 (03PS9) 10Esanders: [BREAKING CHANGE] Multiple surface support and demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177109 
[11:51:37] <grrrit-wm>	 (03PS9) 10Esanders: Refactor out trigger listening to allow target and document triggers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/176955 
[11:51:39] <grrrit-wm>	 (03PS4) 10Esanders: [BREAKING CHANGE] Make ve.init.target an OO.ui.Element [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178665 
[11:58:19] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Make ve.init.target an OO.ui.Element [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178665 (owner: 10Esanders)
[12:00:00] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Refactor for multiple surfaces [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/176952 (owner: 10Esanders)
[12:33:02] <wikibugs>	 3VisualEditor-EditingTools: Leading white spaces - https://phabricator.wikimedia.org/T78137 (10Jopparn) 3NEW p:3Low
[12:38:53] <wikibugs>	 3VisualEditor-EditingTools: Table blocks text - https://phabricator.wikimedia.org/T78138#836336 (10Jopparn)
[13:29:44] <wikibugs>	 3VisualEditor-MediaWiki-Media: In the media adding dialog, LTR direction is forced on the description field even in RTL wikis - https://phabricator.wikimedia.org/T71969#836407 (10Amire80) FYI, I worked around it locally in the Hebrew Wikipedia's Common.css:  ``` .ve-ui-mwMediaDialog .ve-ce-paragraphNode {  direc...
[13:51:50] <wikibugs>	 3MediaWiki-ResourceLoader: ResourceLoader: Get rid of startupScripts - https://phabricator.wikimedia.org/T65240#836494 (10Krinkle)
[13:52:13] <wikibugs>	 3MediaWiki-ResourceLoader: ResourceLoader: Get rid of startupScripts - https://phabricator.wikimedia.org/T65240#836496 (10Krinkle) p:5Normal>3Low
[13:59:48] <wikibugs>	 3MediaWiki-extensions-Cite: <references/> list item must not wrap the text in <span> - https://phabricator.wikimedia.org/T49544#836547 (10Krinkle)
[14:00:29] <wikibugs>	 3MediaWiki-extensions-WikiEditor: Rename WikiEditor classes with generic names to use mw- or mwe- prefixes or redefine them more complexly - https://phabricator.wikimedia.org/T44190#836559 (10Krinkle)
[14:05:40] <wikibugs>	 3MediaWiki-ResourceLoader: ResourceLoader: Invalid argument supplied for foreach - https://phabricator.wikimedia.org/T46907#836614 (10Krinkle)
[14:16:37] <wikibugs>	 3MediaWiki-Page-editing: EditPage.php needs rewrite - https://phabricator.wikimedia.org/T20654#836783 (10Krinkle)
[14:25:58] <grrrit-wm>	 (03PS4) 10Mvolz: [WIP] Use TempateData to insert citations [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/168746 
[14:29:27] <grrrit-wm>	 (03PS5) 10Mvolz: [WIP] Use TempateData to insert citations [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/168746 
[15:44:45] <grrrit-wm>	 (03CR) 10Cmcmahon: [C: 04-1] "Good work getting this up to gerrit!" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178741 (owner: 10Ryasmeen)
[16:30:47] <MatmaRex>	 hi.
[16:50:46] <James_F>	 Hey.
[16:58:17] <grrrit-wm>	 (03PS1) 10Esanders: Improve support for multiple surfaces in demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178867 
[17:04:59] <grrrit-wm>	 (03CR) 10Jforrester: "Also, we normally just say "[BrowserTest]" rather than in caps. :-)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178741 (owner: 10Ryasmeen)
[17:21:33] <grrrit-wm>	 (03CR) 10Jforrester: "Just created T78161 for this." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161342 (owner: 10Mooeypoo)
[17:30:37] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on lawiki: https://la.wikipedia.org/?diff=2811980
[17:30:37] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on lawiki: https://la.wikipedia.org/?diff=2811983
[17:30:37] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on lawiki: https://la.wikipedia.org/?diff=2811984
[17:30:37] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on lawiki: https://la.wikipedia.org/?diff=2811986
[17:30:37] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on lawiki: https://la.wikipedia.org/?diff=2811987
[17:30:38] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on lawiki: https://la.wikipedia.org/?diff=2812159
[17:30:38] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=109834548
[17:30:39] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on trwiki: https://tr.wikipedia.org/?diff=14904331
[17:44:40] <PolK>	 Hi, people, is this the place for help on setup parsoid properly?
[17:46:51] <RoanKattouw>	 PolK: #mediawiki-parsoid is the Parsoid channel
[17:49:42] <PolK>	 RoanKattouw: thanks!
[17:55:18] <grrrit-wm>	 (03PS2) 10Esanders: Improve support for multiple surfaces in demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178867 
[18:14:28] <MatmaRex>	 wikibugs: wake up
[18:14:33] <MatmaRex>	 the bot's busted. :(
[18:19:27] <MatmaRex>	 whenever i try investigating a MW theme bug, i instead notice another one
[18:20:26] <MatmaRex>	 James_F: TrevorP|Away: so, design input please: are the buttons supposed to be that way and we should adjust stuff, or not and we should adjust the buttons? the reports are confusing.  https://phabricator.wikimedia.org/T78029
[18:20:33] <grrrit-wm>	 (03PS1) 10Esanders: Refactor debug bar dump methods and add hide button [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178875 
[18:21:15] <edsanders>	 TrevorP|Away, I think find and replace needs a close button, as currently the only way to dismiss it is with keyboard shortcuts or selecting it from the menu again.
[18:21:50] <RoanKattouw_away>	 edsanders: ryasmeen|Away filed a bug about that already, didn't she?
[18:21:52] <edsanders>	 we don't have close buttons for dialogs though, just 'Done' actions - should I add a 'done' button somewhere, and what colour?
[18:22:33] <James_F>	 MatmaRex: The height of buttons in the dialogs is smaller than "regular" ones/
[18:22:50] <James_F>	 edsanders: https://phabricator.wikimedia.org/T77933
[18:22:52] <James_F>	 edsanders: (yes.)
[18:23:07] <MatmaRex>	 James_F: you mean, is in the Apex theme? because it's the same in MW as far as i can tell.
[18:23:20] <James_F>	 edsanders: Given it slides out, should it be "^"?
[18:23:31] <edsanders>	 James_F, that's close
[18:23:32] <James_F>	 MatmaRex: No.
[18:24:03] <edsanders>	 we don't use 'x' or '<' or '^' close buttons anymore
[18:24:21] <James_F>	 MatmaRex: Compare the height of buttons in https://phabricator.wikimedia.org/F20272
[18:24:23] <edsanders>	 e.g. commandHelp/link inspector hbes 'done'
[18:24:26] <edsanders>	 *have
[18:24:44] <James_F>	 MatmaRex: The "Add template" button is 50% taller than the "cancel" and "insert" buttons in the dialog command lines.
[18:24:45] <MatmaRex>	 James_F: action buttons are smaller.
[18:24:48] <James_F>	 edsanders: True.
[18:24:53] <MatmaRex>	 in the Apex theme, too.
[18:25:02] <MatmaRex>	 (but the difference is less huge)
[18:25:12] <James_F>	 MatmaRex: Ah. Yeah, they should probably be the same size.
[18:25:22] <James_F>	 MatmaRex: But it's particularly bad in MW.
[18:25:27] <MatmaRex>	 http://i.imgur.com/Djg2wOI.png
[18:25:30] <James_F>	 edsanders: "Done" would be normal.
[18:25:45] <MatmaRex>	 because the buttons are larger, but dialog heads are not larger.
[18:25:54] <mooeypoo>	 RoanKattouw, so, about the document thing, you're absolutely right about the UI, I think I explained things wrong a bit; I was thinking of fixing the widgets, rather than the documents which is why I mentioned UI. *BUT* anyways. I think the main problem is thta when we create surfaces for the *widget* we create them with a new document that doesn't have language set into it.. a sort of 'detached' surface. So then the language and di
[18:25:54] <mooeypoo>	 rection fallback on en/ltr
[18:26:07] <James_F>	 MatmaRex: I like the current sizes of the dialog heads/feet.
[18:26:31] <James_F>	 MatmaRex: We should consider if it needs to be bigger for touch devices, but let's keep it now in case?
[18:26:33] <MatmaRex>	 they look cramped in the MW theme because of how massive everything else is.
[18:27:09] <mooeypoo>	 RoanKattouw, we could go over all instances of "new ve.ui.MWSurfaceWidget ..." and add language to the document it gets, or have a *ce* fallback for the widget (because we can't have it for the document) if that makes sense
[18:27:17] <MatmaRex>	 i mean, MW theme looks as if it doubled every margin and padding and such, except in dialog heads
[18:27:40] <MatmaRex>	 (lack of shadows and rounded corners contributes to that)
[18:28:30] <James_F>	 MatmaRex: So… shrink it?
[18:30:13] <MatmaRex>	 eh
[18:30:20] <RoanKattouw>	 mooeypoo: Yeah the new document that's created should inherit the directionality from its parent
[18:30:21] <RoanKattouw>	 Right now that's ugly
[18:30:28] <MatmaRex>	 i bet people will have problems with that
[18:30:29] <RoanKattouw>	 My subdocument refactor should address that too
[18:30:31] <MatmaRex>	 becuse "design spec"
[18:30:53] <divec>	 mooeypoo: you should take a look at https://gerrit.wikimedia.org/r/177946/ which will mess with your cursoring
[18:31:27] <grrrit-wm>	 (03PS1) 10Esanders: Add 'done' button to find and replace dialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178878 
[18:31:53] <mooeypoo>	 RoanKattouw, but the problem is that in the case of the widget, it has no parent
[18:32:04] <mooeypoo>	 well, it does, but it's more complicated than that
[18:32:49] <mooeypoo>	 RoanKattouw, the direction parent is wherever the cursor is, I guess?
[18:34:31] <RoanKattouw>	 mooeypoo: Well to start with you could take the parent document's directionality
[18:34:41] <RoanKattouw>	 And inject it into the child document at the time it's created
[18:34:46] <RoanKattouw>	 In like getDocumentSlice or whatever
[18:34:49] <mooeypoo>	 hm
[18:35:09] <mooeypoo>	 Okay, I'll try that
[18:35:54] <RoanKattouw>	 I realize that ideally we'd use contextual directionality but that needs .css() which needs CE which is annoyin
[18:36:07] <mooeypoo>	 RoanKattouw, ... exactly my point :\
[18:40:10] <MatmaRex>	 ugh
[18:40:25] <MatmaRex>	 the keyboard shortcuts dialog is too small for its contents.
[18:41:35] <edsanders>	 Why am I getting email alerts from [diffusion] about commites from two months ago?
[18:41:39] <edsanders>	 *commits
[18:41:56] <MatmaRex>	 edsanders: see wikitech-l
[18:41:59] <MatmaRex>	 it's a bug
[18:42:23] <MatmaRex>	 you're lucky, some people are getting emails about commits from ten years ago. :D
[18:43:36] <MatmaRex>	 eh, i set out to fix some bugs and instead filed five.
[18:43:46] <James_F>	 :-)
[18:46:06] <James_F>	 Hey Krinkle.
[18:47:10] <MatmaRex>	 James_F: i am getting increasingly convinced we shouldn't ship the MW theme today, even if we manage to fix it up
[18:47:24] <James_F>	 MatmaRex: "Today"?
[18:47:24] <MatmaRex>	 it sucks and it's going to result in people hating us and the theme
[18:47:45] <MatmaRex>	 (i heard we wanted to ship it ASAP, possibly today?)
[18:47:54] <James_F>	 MatmaRex: We're talking about getting it ready today so we can switch it for wmf13 (i.e. next week for MW.org, and January for real wikis).
[18:48:11] <James_F>	 MatmaRex: This gives us as much time as possible to fix things, even if we're mostly on holiday.
[18:48:19] <James_F>	 MatmaRex: "Today" is just the ideal.
[18:49:39] <MatmaRex>	 okay
[18:49:59] <James_F>	 But if we can get most of it done today, yay. :-)
[18:50:20] <divec>	 RoanKattouw, edsanders: image cursoring bug: https://code.google.com/p/chromium/issues/detail?id=440877
[18:51:30] <edsanders>	 ew
[18:51:34] <RoanKattouw>	 divec: Re step 2, it takes 2 steps for me, not 3
[18:51:49] <grrrit-wm>	 (03PS1) 10Jforrester: Follow-up I4e38607d8: Register <visualeditor-find-and-replace-regular-expression> [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178881 
[18:52:02] <edsanders>	 3 for me
[18:52:07] <James_F>	 RoanKattouw: You asking Ops in SoS about the DNS thing for citoid?
[18:52:09] <RoanKattouw>	 edsanders: Another fun one: Foo<span contentEditable=false style="color: red;">FUDGE</span>Bar
[18:52:15] <RoanKattouw>	 James_F: Yes, once that portion of SoS starts
[18:52:22] <James_F>	 RoanKattouw: Still not started?
[18:52:33] <RoanKattouw>	 Wrapping up the retrospective now
[18:52:45] <James_F>	 RoanKattouw: Fun. :-(
[18:53:11] <RoanKattouw>	 edsanders: In that one, if you arrow right through it, the cursor never un-renders at Foo|FUDGEBar, so you end up with something that looks like Foo|FUDGEB|ar (two cursors)
[18:53:12] <TrevorParscal>	 MatmaRex: how are we doing today?
[18:53:26] <MatmaRex>	 TrevorParscal: i set out to fix bugs and instead filed… seven now.
[18:53:37] <TrevorParscal>	 lol
[18:53:42] <TrevorParscal>	 nice
[18:53:50] <MatmaRex>	 most in MW theme, but some also affect Apex
[18:54:04] <TrevorParscal>	 that's awesome really
[18:54:12] <MatmaRex>	 also, wikibugs is broken.
[18:54:13] <RoanKattouw>	 Hmm, it's two key presses for me in both Chrome and Chromium
[18:54:19] <MatmaRex>	 or clogged. not reporting stuff.
[18:54:37] <TrevorParscal>	 did you file a bug against ButtonInputWidget having smaller text?
[18:54:44] <edsanders>	 TrevorParscal, MW buttons are way too tall
[18:54:52] <James_F>	 MatmaRex: Possibly killed by the import disabling outbound e-mail?
[18:55:06] <TrevorParscal>	 edsanders: yeah, there's a task against that
[18:55:09] <TrevorParscal>	 somewhere
[18:55:10] <MatmaRex>	 TrevorParscal: nnnope.
[18:55:19] <James_F>	 MatmaRex: Ah, no; "<legoktm> I think wikibugs is backlogged by like 2 hours :|"
[18:55:43] <TrevorParscal>	 I guess I was really hoping Prateek was going to have finished the theme nicely
[18:55:49] <TrevorParscal>	 don't know what happened there
[18:55:52] <TrevorParscal>	 but we have to solve it
[18:55:56] <MatmaRex>	 TrevorParscal: does it have smaller font size? can't repro
[18:56:04] <TrevorParscal>	 in the demo
[18:56:16] <MatmaRex>	 TrevorParscal: at least some of the bugs we have filed are "by design", i think
[18:56:20] <RoanKattouw>	 divec: This is crazy, we have exactly the same version of Chromium and the same OS. Let's compare once I get out of this meeting
[18:56:24] <legoktm>	 MatmaRex, James_F: I have a fix but I can't deploy it without losing the stuff it's still backlogged on
[18:56:31] <MatmaRex>	 like the buttons being stupidly big and action buttons being stupidly small
[18:56:51] <James_F>	 legoktm: Such is life. :-(
[18:57:03] <MatmaRex>	 https://phabricator.wikimedia.org/T78169
[18:57:05] <James_F>	 legoktm: Losing the e-mail would probably be worse.
[18:57:43] <TrevorParscal>	 i think there's either a happy medium, or the input buttons are correct
[18:57:47] <MatmaRex>	 TrevorParscal: can you screenshot the ButtonInputWidget  issue? ButtonInputWidget and ButtonWidget look the same for me
[18:57:52] <TrevorParscal>	 depending on the theme
[18:58:00] <MatmaRex>	 http://i.imgur.com/Mz6DVyx.png
[18:58:13] <MatmaRex>	 http://i.imgur.com/kDG6dDs.png
[18:58:29] <TrevorParscal>	 http://cl.ly/image/1s2o3Q440b3x
[18:58:39] <James_F>	 MatmaRex: Apex buttons are only ~2px smaller, but it feels huge.
[18:58:54] <TrevorParscal>	 maybe use font-size: inherit on the actual button?
[18:59:58] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Follow-up I4e38607d8: Register <visualeditor-find-and-replace-regular-expression> [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178881 (owner: 10Jforrester)
[19:00:06] <James_F>	 RoanKattouw: Thanks.
[19:00:18] <grrrit-wm>	 (03PS1) 10Jforrester: Follow-up I4e38607d8: Register <visualeditor-find-and-replace-regular-expression> [extensions/VisualEditor] (wmf/1.25wmf12) - 10https://gerrit.wikimedia.org/r/178883 
[19:00:28] <RoanKattouw>	 Yeah I was about to ask about that
[19:01:16] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Follow-up I4e38607d8: Register <visualeditor-find-and-replace-regular-expression> [extensions/VisualEditor] (wmf/1.25wmf12) - 10https://gerrit.wikimedia.org/r/178883 (owner: 10Jforrester)
[19:01:22] <James_F>	 Ta.
[19:01:47] <edsanders>	 and wide for that matter - just too big for desktop
[19:01:51] <grrrit-wm>	 (03Merged) 10jenkins-bot: Follow-up I4e38607d8: Register <visualeditor-find-and-replace-regular-expression> [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178881 (owner: 10Jforrester)
[19:01:58] <James_F>	 edsanders: Possibly.
[19:02:19] <James_F>	 edsanders: They're not much bigger than Apex, width-wise.
[19:02:22] <James_F>	 TrevorParscal?
[19:03:27] <grrrit-wm>	 (03Merged) 10jenkins-bot: Follow-up I4e38607d8: Register <visualeditor-find-and-replace-regular-expression> [extensions/VisualEditor] (wmf/1.25wmf12) - 10https://gerrit.wikimedia.org/r/178883 (owner: 10Jforrester)
[19:04:05] <TrevorParscal>	 I think the padding is out of proportion on MW buttons
[19:04:16] <TrevorParscal>	 the text should be at 0.9em, but they use bold text
[19:08:22] <MatmaRex>	 TrevorParscal: filed that as https://phabricator.wikimedia.org/T78182
[19:11:49] <mooeypoo>	 RoanKattouw, are you around?
[19:11:50] <MatmaRex>	 James_F: sorry for assigning these tasks to you, phab helpfully did it when i clicked "Create Subtask" :/
[19:11:58] <James_F>	 MatmaRex: No worries. :-)
[19:12:23] <RoanKattouw>	 mooeypoo: Yes
[19:14:03] <mooeypoo>	 RoanKattouw, can you help me wih something? I'm trying to figure out where to add/change the surface direction. I see that when we attach a ve.dm.Document to the surface widget, the doc itself has direction, but I don't see where it is ever *read* to set up directionality in the widget itself. The only place we read the direction seems to be in ve.ui.Surface (which is *ui* surface) and that is by the css.
[19:14:47] <RoanKattouw>	 mooeypoo: I believe ve.ce.DocumentNode sets a dir attribute
[19:15:10] <RoanKattouw>	 Or... something sets the dir attribute on it?
[19:16:12] <RoanKattouw>	 mooeypoo: The ve.ce.Document constructor sets it on the ve.ce.DocumentNode's .$element
[19:16:14] <RoanKattouw>	 Because of course <_<
[19:16:24] <mooeypoo>	 yah
[19:16:35] <mooeypoo>	 i'm a little confused on how to do this right 
[19:16:51] <RoanKattouw>	 Well you just need to make sure that the dm.Document has the right direction
[19:17:00] <RoanKattouw>	 The CE code for then delivering that direction should already be working
[19:17:24] <mooeypoo>	 RoanKattouw, and I am not sure how to add the ability to hierarchically get the direction. If you look in the media dialog, line #822, that's where the caption surface is created. I can get direction from the selectedNode, but if that exists, the document already exists. How do I read "where the cursor is" even without selected node? if I can do that, I can get the direction, theoretically, from that bit of the document
[19:17:58] <RoanKattouw>	 mooeypoo: It's about captionDocument's creation
[19:18:08] <mooeypoo>	 RoanKattouw, right. I need to add a language there
[19:18:50] <RoanKattouw>	 Unfortunately it's not created in any one place, it's in a few different places depending on case
[19:18:52] <mooeypoo>	 line #827, where the end of the 'new ve.dm.Document( ... )' call is, I need to add 		], null, null, null, null, lang, dir );
[19:19:17] <RoanKattouw>	 The non-obvious one is line 814
[19:19:20] <mooeypoo>	 RoanKattouw, if I can attach the language and direction there, it should "stick" to existing nodes later, right?
[19:19:21] <James_F>	 mooeypoo: Add comments to each null explaining what they are. :-)
[19:19:31] <RoanKattouw>	 Wait wtf you need that many nulls?
[19:19:37] <James_F>	 Also, what RoanKattouw said.
[19:19:53] <RoanKattouw>	 mooeypoo: Yeah once the dir has been passed into the dm.Document it'll remember, and it should cascade
[19:19:54] <mooeypoo>	 because the ve.dm.Document constructor is ve.dm.Document = function VeDmDocument( data, htmlDocument, parentDocument, internalList, innerWhitespace, lang, dir ) 
[19:20:02] <RoanKattouw>	 Oh I see
[19:20:04] <RoanKattouw>	 Ugh
[19:20:06] <mooeypoo>	 :\
[19:20:06] <James_F>	 Ha.
[19:20:07] <James_F>	 Lovely.
[19:20:24] <mooeypoo>	 We should fix that up , but first let's get it working I think
[19:20:25] <RoanKattouw>	 Hmm, cloneFromRange() already passes the direction through
[19:20:29] <RoanKattouw>	 So editing existing captions should already work
[19:20:50] <mooeypoo>	 yeah, it seems only with the creation of new documents
[19:21:02] <RoanKattouw>	 OK
[19:21:14] <mooeypoo>	 RoanKattouw, but that can only be done if you *have* this.selectedNode
[19:21:22] <Krinkle>	 edsanders: You certainly have a way of upsetting npm.
[19:21:23] <Krinkle>	 11:58:17 npm ERR! weird error 3 
[19:21:29] <Krinkle>	 weird error no. 3
[19:21:31] <Krinkle>	 That's a first for me
[19:21:35] <RoanKattouw>	 mooeypoo: ?
[19:21:35] <Krinkle>	 https://integration.wikimedia.org/ci/job/VisualEditor-npm/4581/console
[19:21:53] <Krinkle>	 :D
[19:21:55] <mooeypoo>	 RoanKattouw, cloneFromRange() there works on this.selectedNode.getDocument().cloneFromRange( this.captionNode.getRange() )
[19:22:03] <mooeypoo>	 which means I have to *have* a selectedNode yes?
[19:22:07] <Krinkle>	 Like, where do I even start with a useless error like that
[19:22:13] <Krinkle>	 I wonder if there even is a no 1 or 2.
[19:22:25] <RoanKattouw>	 mooeypoo: Yeah that's the existing caption case
[19:22:27] <mooeypoo>	 if you're inserting an image from scratch, you don't have selectedNode
[19:22:32] <James_F>	 Krinkle: rm -rf node_modules and retry.
[19:22:39] <James_F>	 Krinkle: I've had error no. 3 before.
[19:22:45] <mooeypoo>	 so the only case I seem to need to add explicit hierarchical lang/dir is the case where you're inserting an image from scratch
[19:22:51] <Krinkle>	 James_F: The code is fine. This one is definitely Chromium or xvfb losing track of each other
[19:22:55] <James_F>	 Krinkle: No idea what it is.
[19:22:59] <James_F>	 Krinkle: Hmm. If you're sure.
[19:23:14] <RoanKattouw>	 mooeypoo: Yes
[19:23:23] <RoanKattouw>	 mooeypoo: The new ve.dm.Document invocations, as you said
[19:23:26] <mooeypoo>	 RoanKattouw, in line #822. But I'm stuck with how do I get the cursor-position's dir value at that point without having selectedNode 
[19:23:30] <RoanKattouw>	 mooeypoo: It looks like we are in violent agreement
[19:23:30] <grrrit-wm>	 (03CR) 10Krinkle: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178665 (owner: 10Esanders)
[19:23:37] <RoanKattouw>	 mooeypoo: Ahm, for now inherit the document direction
[19:23:41] <RoanKattouw>	 That's what cloneFromRange() does too
[19:23:55] <mooeypoo>	 which document
[19:24:14] <mooeypoo>	 surface.getFragment().getDocument() (or something like that)
[19:24:15] <mooeypoo>	 ?
[19:24:23] <RoanKattouw>	 this.getFragment().getDocument() or something
[19:24:29] <mooeypoo>	 okay. I see
[19:24:34] <RoanKattouw>	 Yes that
[19:24:53] <RoanKattouw>	 (There is some legacy code calling this.getFragment().getSurface().getDocument(), presumably because fragment didn't use to have a document getter)
[19:25:03] <mooeypoo>	 okay, but we should try and think of better ways to do fallbacks in documents, I think
[19:25:10] <RoanKattouw>	 Yes, we should
[19:25:22] <mooeypoo>	 and we should do something about that insane constructor call :\
[19:25:32] <Krenair>	 https://la.wikipedia.org/?diff=2812159 - that's... weirsd
[19:25:35] <Krenair>	 weird*
[19:25:57] <Krenair>	 looks like the user tried to fix that a few times
[19:29:15] <wikibugs>	 3VisualEditor-InterfaceLanguage, VisualEditor-EditingTools: Search and replace has weird display in RTL wikis - https://phabricator.wikimedia.org/T76807#838613 (10Etonkovidova) Verified in betalabs. Also,  all newly added English labels displayed in the screenshot - 'Match case', 'Replace all', 'Replace' etc - a...
[19:30:09] <RoanKattouw>	 wtf, single opening tag but double closing?
[19:30:42] <mooeypoo>	 HA
[19:30:54] <grrrit-wm>	 (03CR) 10Jforrester: "Works fine, but I'm not hugely happy with the way this breaks the already-awkward design." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178878 (owner: 10Esanders)
[19:31:28] <wikibugs>	 3VisualEditor-InterfaceLanguage, VisualEditor-EditingTools: Search and replace has weird display in RTL wikis - https://phabricator.wikimedia.org/T76807#838628 (10Jdforrester-WMF) >>! In T76807#838613, @Etonkovidova wrote: > Verified in betalabs. Also,  all newly added English labels displayed in the screenshot...
[19:35:43] <mooeypoo>	 ok I'm getting errors when trying to select an image regardless of my attempted fix
[19:36:23] <mooeypoo>	 anyone getting the same? has to do with resizableNode, it seems, and calling .focus()
[19:36:36] <mooeypoo>	 It just started after I updated master
[19:37:21] <mooeypoo>	 anything happened with "this.resizableOffset = OO.ui.Element.static.getRelativePosition" lately?  
[19:37:29] <mooeypoo>	 err getRelativePosition I mean
[19:39:49] <RoanKattouw>	 mooeypoo: Make sure both MW core and VE are up to date
[19:39:49] <RoanKattouw>	 That function was renamed in OOUI
[19:40:04] <mooeypoo>	 hm
[19:40:10] <grrrit-wm>	 (03PS1) 10Jforrester: Creating new wmf/1.25wmf12 branch [extensions/VisualEditor] (wmf/1.25wmf12) - 10https://gerrit.wikimedia.org/r/178892 
[19:40:21] <James_F>	 RoanKattouw: ^^^ Merge?
[19:40:50] <grrrit-wm>	 (03PS1) 10Divec: Fix filibuster expansion bug [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178893 
[19:41:18] <mooeypoo>	 RoanKattouw, thanks, that fixed it
[19:41:48] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Creating new wmf/1.25wmf12 branch [extensions/VisualEditor] (wmf/1.25wmf12) - 10https://gerrit.wikimedia.org/r/178892 (owner: 10Jforrester)
[19:42:21] <grrrit-wm>	 (03PS1) 10Divec: Delimit text nodes in debug observations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178894 
[19:45:23] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] "Oops." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178893 (owner: 10Divec)
[19:45:48] <mooeypoo>	 RoanKattouw, okay, my fix works but only to the level of the *whole* document. This means that if you have an image inside <div dir="rtl"></div> and you edit it, the caption is still aligned LTR because the rest of the document is. This might be an issue with the dm not dealing with language blocks right? not sure.
[19:47:51] <grrrit-wm>	 (03Merged) 10jenkins-bot: Creating new wmf/1.25wmf12 branch [extensions/VisualEditor] (wmf/1.25wmf12) - 10https://gerrit.wikimedia.org/r/178892 (owner: 10Jforrester)
[19:47:53] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix filibuster expansion bug [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178893 (owner: 10Divec)
[19:48:55] <RoanKattouw>	 mooeypoo: Yes that's right
[19:49:12] <mooeypoo>	 We should fix that too.
[19:49:46] <RoanKattouw>	 Yes
[19:49:55] <RoanKattouw>	 That's a slightly bigger project
[19:50:01] <mooeypoo>	 err, and i'm getting grunt issues with ve.init.mw.Target.css O.o
[19:50:02] <RoanKattouw>	 Right now the model has no non-global concept of directionality
[19:50:17] <RoanKattouw>	 Ahm
[19:50:20] <RoanKattouw>	 I created that file recently
[19:50:24] <mooeypoo>	 RoanKattouw, indeed. I think it was supposed to be the continuation of the langauge inspector idea.
[19:50:27] <RoanKattouw>	 Like this week
[19:50:33] <RoanKattouw>	 So maybe another out-of-date-ness issue?
[19:50:45] <mooeypoo>	 "Heading (h3) has already been defined. Headings should be defined only once. (unique-headings)"
[19:51:04] <RoanKattouw>	 Ugh if it complains about that then how the hell did it merge when I wrote it?
[19:51:07] <mooeypoo>	 RoanKattouw, csslint
[19:51:33] <mooeypoo>	 is it complaining to anyone else? might be something local for me?
[19:51:35] <RoanKattouw>	 It's different CSS definitions, csslint, come on
[19:51:56] <RoanKattouw>	 One rule is for .ve-init-target-ie .ve-ce-surface h3, the other is for .ve-ui-commandHelpDialog-section h3
[19:51:59] <grrrit-wm>	 (03PS1) 10Mooeypoo: Image caption should have parent document direction [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178899 
[19:52:02] <RoanKattouw>	 I refuse to believe that is a legitimate error
[19:52:07] <James_F>	 mooeypoo: Those are warnings, not errors.
[19:52:07] <MatmaRex>	 csslint is stupid
[19:52:14] <MatmaRex>	 it probably thinks it is legitimate
[19:52:17] <James_F>	 mooeypoo: It's not erroring.
[19:52:18] <MatmaRex>	 NOTABUG BYDESIGN
[19:52:23] <MatmaRex>	 why are we using it?
[19:52:29] <James_F>	 MatmaRex: Ask Krinkle|detached.
[19:52:39] <RoanKattouw>	 Just put in a comment to shut up that warning
[19:52:46] <mooeypoo>	 James_F, well, it goes "Warning: Task "csslint:all" failed. Use --force to continue." at the end
[19:52:47] <RoanKattouw>	  /*csslint unique-headings:false*/ or whatever
[19:52:53] <James_F>	 mooeypoo: Err.
[19:52:55] <MatmaRex>	 Krinkle|detached: why are we using csslint? it's more opinionated than jslint and its opinions are even stupider.
[19:52:55] <TrevorParscal>	 MatmaRex: ok, I'm done with all this heath care bureaucracy nonsense and I'm ready to merge all the things, maybe even write some code
[19:53:02] <James_F>	 mooeypoo: Not in master.
[19:53:05] <mooeypoo>	 really?!
[19:53:13] <mooeypoo>	 :\ what's wrong with my repo then
[19:53:18] <RoanKattouw>	 Maybe I need to update csslint?
[19:53:21] <RoanKattouw>	 It fails for me locally too
[19:53:26] <mooeypoo>	 I *just* updated everything, including mw
[19:53:31] <James_F>	 It passes locally for me, with warnings.
[19:53:39] <James_F>	 …
[19:53:48] <James_F>	 Running "csslint:all" (csslint) task
[19:53:49] <James_F>	 Linting modules/ve-mw/init/styles/ve.init.mw.Target.css...ERROR
[19:53:49] <James_F>	 [L20:C35]
[19:53:50] <James_F>	 WARNING: Heading (h3) has already been defined. Headings should be defined only once. (unique-headings) Browsers: All
[19:53:52] <James_F>	 [GENERAL]
[19:53:54] <James_F>	 WARNING: You have 2 h3s defined in this stylesheet. Headings should be defined only once. (unique-headings) Browsers: All
[19:53:56] <James_F>	 >> 45 files lint free.
[19:53:56] <ecmabot-wm>	 James_F: SyntaxError: Unexpected identifier
[19:53:58] <James_F>	 …
[19:54:00] <James_F>	 Done, without errors.
[19:54:04] <James_F>	 Dear csslint…
[19:54:06] <James_F>	 ecmabot-wm: Yeah yeah.
[19:54:06] <ecmabot-wm>	 James_F: There is no command: Yeah yeah.
[19:54:07] <RoanKattouw>	 James_F: Yes, but right before that it says Linting modules/ve-mw/init/styles/ve.init.mw.Target.css ...ERROR for me
[19:54:14] <mooeypoo>	 yea me too
[19:54:17] <RoanKattouw>	 And Warning: Task "csslint:all" failed. Use --force to continue.
[19:54:36] <mooeypoo>	 RoanKattouw, I just went 'npm install' and now it's "just" a warning
[19:54:38] <mooeypoo>	 not an error anymore
[19:54:53] <wikibugs>	 3OOjs-UI, VisualEditor-MediaWiki: Vertical alignment of text alongside checkbox is off in MediaWiki theme - https://phabricator.wikimedia.org/T78030#838757 (10matmarex) a:3matmarex
[19:54:56] <mooeypoo>	 so, apparently updating csslint 
[19:54:57] <wikibugs>	 3OOjs-UI: Multiline checkbox labels broken - https://phabricator.wikimedia.org/T78173#838758 (10matmarex) a:5TrevorParscal>3matmarex
[19:54:57] <RoanKattouw>	 Oh I see
[19:55:01] <RoanKattouw>	 Old version then
[19:55:11] <James_F>	 Ah, right, you two were using old versions.
[19:55:21] <RoanKattouw>	 npm barfed on me while updating so I had to rm -rf node_modules and install stuff from scratch
[19:55:39] <RoanKattouw>	 npm is so unstable, it's ridiculous
[19:55:46] <mooeypoo>	 Next time turn its head to the side
[19:55:54] <mooeypoo>	 have it barf on whoever sits next to you
[19:56:03] <RoanKattouw>	 OK yeah now it shows the warnings but then succeeds anyway
[19:56:15] <RoanKattouw>	 "whoever sits next to me" is Trevor
[19:56:19] <RoanKattouw>	 And Blaise barfs on him enough
[19:56:45] <mooeypoo>	 ha, okay, fair enough.
[19:56:57] <matanya>	 James_F: should i poke you again about performance under firefox ?
[19:57:44] <TrevorParscal>	 MatmaRex: https://phabricator.wikimedia.org/T78054
[19:57:47] <TrevorParscal>	 so...
[19:58:20] <TrevorParscal>	 any suggestions for what I should take a look at - given you've been going through this stuff more recently
[19:58:22] <James_F>	 matanya: Do you have specifics?
[19:58:32] <James_F>	 matanya: The quickest fix is to ship v8 in Firefox.
[19:58:41] <James_F>	 matanya: But somehow I think that's an UPSTREAM WONTFIX. :-)
[19:58:53] <TrevorParscal>	 MatmaRex: also, did the new things you filed get added as blockers to that, or - were they not blockers for that?
[19:59:19] <matanya>	 James_F: i opened a bug with numbers some time ago, and you asked me to poke later, so here i am
[19:59:24] <MatmaRex>	 TrevorParscal: i added all that were applicable as blockers
[19:59:26] <MatmaRex>	 i think
[19:59:27] <James_F>	 matanya: Ah, cool.
[19:59:36] <matanya>	 I can redo the test if you wish
[19:59:40] <etonkovidova>	 James_F: <span class="oo-ui-iconElement-icon oo-ui-icon-regular-expression" title="<visualeditor-find-and-replace-regular-expression>"></span>
[19:59:49] <MatmaRex>	 TrevorParscal: can you look at the ones that are possibly by design? dependencies of https://phabricator.wikimedia.org/T78169 would be nice to start with
[19:59:52] <etonkovidova>	 will be the title changed?
[19:59:54] <grrrit-wm>	 (03CR) 10Jforrester: "We should do this for references too, presumably?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178899 (owner: 10Mooeypoo)
[20:00:10] <James_F>	 etonkovidova: Fix is already merged, will be deployed soon.
[20:00:17] <etonkovidova>	 cool
[20:00:50] <mooeypoo>	 oh references!
[20:00:54] <mooeypoo>	 I was trying to think where else to put this
[20:01:19] <matanya>	 James_F: for ref: https://phabricator.wikimedia.org/T52616
[20:01:36] <MatmaRex>	 TrevorParscal: more design bits are https://phabricator.wikimedia.org/T78047 https://phabricator.wikimedia.org/T78048 https://phabricator.wikimedia.org/T78040
[20:01:41] <TrevorParscal>	 MatmaRex: so, I'm going to take on the two or three that relate to using the light blue colors for highlight and selected
[20:01:57] <TrevorParscal>	 yes, those 2
[20:01:58] <MatmaRex>	 (these are the bugs that i'm definitely not going to touch if i can avoid it)
[20:01:58] <TrevorParscal>	 first
[20:02:06] <TrevorParscal>	 and yeah, the button thing would be a good thing to also take on
[20:02:07] <mooeypoo>	 James_F, we should rework the way the surface widget document fallbacks on direction regardless... I'll add it to references, but I'm concerned that there are other places I'll probably miss. Some templates, maybe? anyways, this is more of a stop-gap, I think.
[20:02:07] <MatmaRex>	 ok, cool. i'm looking into checkboxes now
[20:02:13] <James_F>	 MatmaRex: :-)
[20:02:26] <James_F>	 mooeypoo: Right now the only uses of SurfaceWidget are references and media.
[20:02:32] * mooeypoo nods
[20:02:37] <James_F>	 mooeypoo: But yes, a better solution would be good as a tech-debt task.
[20:02:50] <James_F>	 mooeypoo: Right now we need to land your other pieces of work, not start off on new things. :-)
[20:03:56] <wikibugs>	 3VisualEditor-Performance, VisualEditor-Initialisation: Improve VisualEditor's loading performance in Firefox - https://phabricator.wikimedia.org/T52616#838779 (10Jdforrester-WMF) Could you compare loading times for these articles now, three months later?
[20:05:11] <grrrit-wm>	 (03PS1) 10Divec: Wrap inline images in a span ce=false [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178904 
[20:06:31] <mooeypoo>	 James_F, aye, I'm just putting a caveat on this bug fix
[20:06:47] <mooeypoo>	 James_F, also, hopefully the templatedata dialog will land *SOON*
[20:07:21] <James_F>	 mooeypoo: Sure.
[20:07:27] <wikibugs>	 3VisualEditor-Performance, VisualEditor-Initialisation: Improve VisualEditor's loading performance in Firefox - https://phabricator.wikimedia.org/T52616#838787 (10Jdforrester-WMF)
[20:07:31] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] Wrap inline images in a span ce=false (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178904 (owner: 10Divec)
[20:07:45] <grrrit-wm>	 (03CR) 10Catrope: "Ed, does this look sensible to you?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178904 (owner: 10Divec)
[20:07:57] <grrrit-wm>	 (03PS2) 10Divec: Wrap inline images in a span ce=false [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178904 
[20:08:18] <James_F>	 matanya: Have made your data into a table in https://phabricator.wikimedia.org/T52616 – does that help?
[20:08:34] <matanya>	 I'll do it now James_F 
[20:08:38] <grrrit-wm>	 (03CR) 10Catrope: Wrap inline images in a span ce=false [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178904 (owner: 10Divec)
[20:09:00] <James_F>	 matanya: Thank you.
[20:09:27] <grrrit-wm>	 (03PS3) 10Divec: Wrap inline images in a span ce=false [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178904 
[20:10:48] <wikibugs>	 3OOjs-UI, VisualEditor-MediaWiki: Need for a muted destructive state for buttons which are destructive but not important workflow items in the OOjs UI MediaWiki theme - https://phabricator.wikimedia.org/T78040#838791 (10TrevorParscal) We should just use different constructive/destructive/progressive styling base...
[20:18:56] <wikibugs>	 3OOjs-UI, VisualEditor-MediaWiki: Need for a muted destructive state for buttons which are destructive but not important workflow items in the OOjs UI MediaWiki theme - https://phabricator.wikimedia.org/T78040#838800 (10Jdforrester-WMF) Go for it.
[20:20:18] <TrevorParscal>	 MatmaRex: getting some food - brb
[20:24:11] <wikibugs>	 3VisualEditor-Performance, VisualEditor-Initialisation: Improve VisualEditor's loading performance in Firefox - https://phabricator.wikimedia.org/T52616#838808 (10Matanya)
[20:26:54] <wikibugs>	 3VisualEditor-Performance, VisualEditor-Initialisation: Improve VisualEditor's loading performance in Firefox - https://phabricator.wikimedia.org/T52616#838811 (10Matanya) Added the new data, one thing to note is if you check chrome before firefox, or check only firefox, the results are almost the same for firef...
[20:27:14] <matanya>	 done James_F some interesting stuff
[20:33:57] <grrrit-wm>	 (03PS2) 10Mooeypoo: Surfaces should have parent document direction [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178899 
[20:35:03] <mooeypoo>	 James_F, I had to add 'getDir' and 'setDir' to the ReferenceModel since it is detached from the document. Not super pretty, but it works without being a time-hog change that the more complete and strategic solution will probably be.
[20:35:51] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Surfaces should have parent document direction [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178899 (owner: 10Mooeypoo)
[20:36:03] <matanya>	 or not
[20:36:08] <mooeypoo>	 :\
[20:37:11] <mooeypoo>	 eh, I don't understand the problem. It passed grunt; what's the error here? this? "Could not record history. Previous build's commit, 946e0ae5a6fab2499670e93ce01268330e016277, does not exist in the current repository." ?
[20:37:16] <mooeypoo>	 O.o
[20:38:36] <MatmaRex>	 annnnnd i can't pull in mw/core again.
[20:38:44] <grrrit-wm>	 (03PS14) 10Mooeypoo: [WIP] Transform the search widget to show image details [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161342 
[20:38:50] <MatmaRex>	 that makes developing against it somewhat problematic.
[20:39:30] <MatmaRex>	 oh, there, it worked at last.
[20:42:36] <RoanKattouw_away>	 Krinkle|detached: Grumble grumble Jenkins grumble https://integration.wikimedia.org/ci/job/mwext-VisualEditor-npm/5893/console
[20:44:47] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] Surfaces should have parent document direction (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178899 (owner: 10Mooeypoo)
[20:45:22] <MatmaRex>	 gods
[20:45:31] <MatmaRex>	 how do i update mw/core to a development copy of ooui these days?
[20:46:51] <grrrit-wm>	 (03CR) 10Mooeypoo: Surfaces should have parent document direction (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178899 (owner: 10Mooeypoo)
[20:50:39] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [WIP] Transform the search widget to show image details [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161342 (owner: 10Mooeypoo)
[20:52:32] <grrrit-wm>	 (03PS1) 10Esanders: WIP Death to isolation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178918 
[20:52:52] <edsanders>	 RoanKattouw_away, as I suggested this is not too complicated with fake selections ^^
[20:53:03] <edsanders>	 Although the link inspector has some height issues
[20:53:05] <grrrit-wm>	 (03PS3) 10Mooeypoo: Surfaces should have parent document direction [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178899 
[20:53:32] <edsanders>	 can you check it out and see what's broken
[20:54:07] <edsanders>	 I had to put a position relative on the find and replace dialog which should be fixed upstream
[21:01:53] <MatmaRex>	 MW theme checkbox is terrible
[21:02:09] <MatmaRex>	 so flaky
[21:06:14] <RoanKattouw_away>	 edsanders: SWEET!
[21:06:18] <RoanKattouw_away>	 edsanders: Does that do inspectors too?
[21:06:29] <RoanKattouw_away>	 I'll check it out after this meeting
[21:08:47] <RoanKattouw_away>	 MatmaRex: FSG meeting?
[21:09:05] <MatmaRex>	 RoanKattouw_away: joining, one sec
[21:10:12] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: [BREAKING CHANGE] FieldLayout: Handle 'inline' alignment better [oojs/ui] - 10https://gerrit.wikimedia.org/r/178946 
[21:10:20] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: Update for Ie27bd94c in OOUI [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178948 
[21:12:27] <wikibugs>	 3OOjs-UI, VisualEditor-MediaWiki: Vertical alignment of text alongside checkbox is off in MediaWiki theme - https://phabricator.wikimedia.org/T78030#839068 (10matmarex) Fixed: {F20711}.
[21:12:37] <wikibugs>	 3OOjs-UI: Multiline checkbox labels broken - https://phabricator.wikimedia.org/T78173#839070 (10matmarex) Fixed: {F20711}.
[21:13:52] <grrrit-wm>	 (03PS4) 10Divec: Wrap inline images in a span ce=false [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178904 
[21:14:24] <grrrit-wm>	 (03CR) 10Divec: "Patch set 4: rebase" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178904 (owner: 10Divec)
[21:15:01] <grrrit-wm>	 (03PS2) 10Ryasmeen: [BrowserTest] Adding tests for checking fields under Page Settings [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178741 
[21:17:00] <grrrit-wm>	 (03CR) 10Jforrester: Surfaces should have parent document direction (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178899 (owner: 10Mooeypoo)
[21:29:22] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] FieldLayout: Handle 'inline' alignment better [oojs/ui] - 10https://gerrit.wikimedia.org/r/178946 (owner: 10Bartosz Dziewoński)
[21:29:39] <edsanders>	 RoanKattouw, yes "Although the link inspector has some height issues"
[21:29:46] <RoanKattouw>	 Oh right
[21:30:04] <grrrit-wm>	 (03PS2) 10Bartosz Dziewoński: [BREAKING CHANGE] FieldLayout: Handle 'inline' alignment better [oojs/ui] - 10https://gerrit.wikimedia.org/r/178946 
[21:30:43] <grrrit-wm>	 (03PS4) 10Mooeypoo: Surfaces should have parent document direction [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178899 
[21:32:42] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Surfaces should have parent document direction [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178899 (owner: 10Mooeypoo)
[21:33:28] <mooeypoo>	 whaaat is going on.
[21:33:50] <mooeypoo>	 RoanKattouw, what does it mean when jenkins fails on "mwext-VisualEditor-npm" ?
[21:33:59] <mooeypoo>	 I don't understand what to fix in there to make jenkins happy
[21:34:16] <RoanKattouw>	 21:31:37 npm ERR! error rolling back Error: ENOTEMPTY, rmdir '/mnt/jenkins-workspace/workspace/mwext-VisualEditor-npm/node_modules/grunt-jscs/node_modules/jscs/node_modules/glob/node_modules/graceful-fs'
[21:34:26] <RoanKattouw>	 Krinkle|detached: ---^^
[21:34:47] <RoanKattouw>	 Timo needs to take Jenkins's crack pipe away
[21:35:05] <mooeypoo>	 ha
[21:35:13] <edsanders>	 mooeypoo, providing a default language ('en') suggests you're doing something wrong, why do we need one in that commit?
[21:35:25] <aharoni>	 mooeypoo, edsanders - thanks for working on this
[21:35:38] <mooeypoo>	 edsanders, I only added 'en' as default because there was 'ltr' as default
[21:36:09] <mooeypoo>	 edsanders, but you're right, the language probably shouldn't have default, since it only matters for new ve.dm.Document and *that* has some sort of fallback iirc
[21:36:54] <mooeypoo>	 edsanders, and I only did that for the image model, not the references. It was mostly to be consistent with the "ltr" fallback
[21:37:40] <edsanders>	 then remove that fallback too
[21:38:05] <mooeypoo>	 hm, I think I had trouble when I did. The ltr/rtl was important for alignment. But I may be mixing bugs here. I'll check.
[21:39:43] <edsanders>	 where is the dir/lang data for that method taken from?
[21:39:53] <edsanders>	 you should make the required parameters
[21:40:02] <edsanders>	 then the caller can decide if it needs to fallback the dir
[21:42:01] <edsanders>	 the only time we should fallback to ltr is when we can't get a computed style, and therefore we are mimicking CSS behaviour
[21:44:04] <mooeypoo>	 edsanders, yeah. My worry is that this is the dm, so I wasn't sure we *always* have a computed style, since we don't want to reach into the DOM
[21:44:40] <mooeypoo>	 and in the case of imageModel and referenceModel they're both *standalone*, detached from the document model itself, so they have to be fed those values literally.
[21:46:22] <grrrit-wm>	 (03PS5) 10Mooeypoo: Surfaces should have parent document direction [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178899 
[21:56:04] <wikibugs>	 3OOjs-UI: Update checkbox styles in MediaWiki theme to latest design spec - https://phabricator.wikimedia.org/T78199#839178 (10matmarex) 3NEW a:3Prtksxna
[21:56:19] <grrrit-wm>	 (03PS4) 10Bartosz Dziewoński: MediaWiki Theme: checkbox: Fix states according to spec [oojs/ui] - 10https://gerrit.wikimedia.org/r/176397 (owner: 10Prtksxna)
[21:56:38] <grrrit-wm>	 (03PS5) 10Bartosz Dziewoński: MediaWiki theme: checkbox: Fix states according to spec [oojs/ui] - 10https://gerrit.wikimedia.org/r/176397 (owner: 10Prtksxna)
[21:56:55] <grrrit-wm>	 (03PS6) 10Bartosz Dziewoński: MediaWiki Theme: checkbox: Fix states according to spec [oojs/ui] - 10https://gerrit.wikimedia.org/r/176397 (owner: 10Prtksxna)
[21:57:08] <grrrit-wm>	 (03PS7) 10Bartosz Dziewoński: MediaWiki Theme: checkbox: Fix states according to spec [oojs/ui] - 10https://gerrit.wikimedia.org/r/176397 (owner: 10Prtksxna)
[22:00:11] <grrrit-wm>	 (03PS1) 10Cmcmahon: [BrowserTest] issues with Chrome at SauceLabs causes test to fail [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178971 
[22:04:54] <TrevorParscal>	 MatmaRex: what are you travel dates for Jan again?
[22:05:05] <TrevorParscal>	 the 12th through the 20 something-th?
[22:05:12] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "The weird :active behavior appears to be a browser bug / inconsistency. Each browser does weird stuff: Chrome only applies :active on firs" [oojs/ui] - 10https://gerrit.wikimedia.org/r/176397 (owner: 10Prtksxna)
[22:05:57] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "The weird :active behavior appears to be a browser bug / inconsistency. Each browser does weird stuff: Chrome only applies :active on firs" [oojs/ui] - 10https://gerrit.wikimedia.org/r/176398 (owner: 10Prtksxna)
[22:06:09] <MatmaRex>	 TrevorParscal: 12-29
[22:06:45] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] MediaWiki Theme: checkbox: Fix states according to spec [oojs/ui] - 10https://gerrit.wikimedia.org/r/176397 (owner: 10Prtksxna)
[22:07:55] <MatmaRex>	 so, browsers still can't consistently handle CSS1. wonderful
[22:10:16] <wikibugs>	 3OOjs-UI, VisualEditor-MediaWiki: Disabled checkbox is almost indistinguishable from an enabled, selected checbox in the OOjs UI MediaWiki theme - https://phabricator.wikimedia.org/T78048#839195 (10matmarex) a:3Prtksxna Fixed in latest design, which was implemented in {T78199}.
[22:10:36] <wikibugs>	 3OOjs-UI, VisualEditor-MediaWiki: Checked state of checkboxes looks off when zoomed in, in the MediaWiki theme - https://phabricator.wikimedia.org/T78036#839200 (10matmarex) a:3Prtksxna Fixed in latest design, which was implemented in {T78199}.
[22:10:59] <grrrit-wm>	 (03Merged) 10jenkins-bot: MediaWiki Theme: checkbox: Fix states according to spec [oojs/ui] - 10https://gerrit.wikimedia.org/r/176397 (owner: 10Prtksxna)
[22:16:47] <wikibugs>	 3OOjs-UI, VisualEditor-MediaWiki: Need for a muted destructive state for buttons which are destructive but not important workflow items in the OOjs UI MediaWiki theme - https://phabricator.wikimedia.org/T78040#839209 (10Esanders) +1 for Trevor's suggestion.
[22:23:17] <wikibugs>	 3OOjs-UI: Update checkbox styles in MediaWiki theme to latest design spec - https://phabricator.wikimedia.org/T78199#839232 (10matmarex) Design mockup, matches the final implementation rather well:  {F20729,size=full}
[22:23:44] <wikibugs>	 3MediaWiki-Interface, UI-Standardization, OOjs-UI: Switch MediaWiki core's use of OOjs UI to use the MediaWiki theme, not Apex - https://phabricator.wikimedia.org/T78054#839236 (10matmarex)
[22:23:47] <wikibugs>	 3OOjs-UI: Update checkbox styles in MediaWiki theme to latest design spec - https://phabricator.wikimedia.org/T78199#839234 (10matmarex) 5Open>3Resolved
[22:24:12] <wikibugs>	 3MediaWiki-Interface, UI-Standardization, OOjs-UI: Switch MediaWiki core's use of OOjs UI to use the MediaWiki theme, not Apex - https://phabricator.wikimedia.org/T78054#834496 (10matmarex)
[22:24:25] <wikibugs>	 3MediaWiki-Interface, UI-Standardization, OOjs-UI: Switch MediaWiki core's use of OOjs UI to use the MediaWiki theme, not Apex - https://phabricator.wikimedia.org/T78054#834496 (10matmarex)
[22:24:28] <wikibugs>	 3OOjs-UI, VisualEditor-MediaWiki: Checked state of checkboxes looks off when zoomed in, in the MediaWiki theme - https://phabricator.wikimedia.org/T78036#839239 (10matmarex) 5Open>3Resolved
[22:25:53] <grrrit-wm>	 (03PS5) 10Bartosz Dziewoński: MediaWiki Theme: Add radio buttons [oojs/ui] - 10https://gerrit.wikimedia.org/r/176398 (owner: 10Prtksxna)
[22:26:55] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "I think the approach with pseudoelements is fine. It's a bit icky, but it's the same thing as we use in mediawiki.ui in MW core, and IMO t" [oojs/ui] - 10https://gerrit.wikimedia.org/r/176398 (owner: 10Prtksxna)
[22:27:07] <wikibugs>	 3VisualEditor-MediaWiki-Mobile, MobileFrontend-Feature-requests, MediaWiki-Page-editing: iOS: Shake to undo on mobile does not undo or redo typing - https://phabricator.wikimedia.org/T67600#839241 (10kaldari) @Jaredzimmerman-WMF Works for me. Tested in Mobile Safari on iPhone.
[22:27:19] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 031] "Is anything else preventing this from being merged?" [oojs/ui] - 10https://gerrit.wikimedia.org/r/176398 (owner: 10Prtksxna)
[22:29:40] <grrrit-wm>	 (03CR) 10Cmcmahon: [C: 032] "maintenance." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178971 (owner: 10Cmcmahon)
[22:32:15] <Krenair>	 RoanKattouw, have been wondering what I can do about the issue I ran into with the transclusion dialog/model
[22:32:53] <Krenair>	 IIRC, on reopen, the transclusion model would start with no parts and they would all get queued to go back in
[22:32:57] <grrrit-wm>	 (03Merged) 10jenkins-bot: [BrowserTest] issues with Chrome at SauceLabs causes test to fail [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178971 (owner: 10Cmcmahon)
[22:33:04] <Krenair>	 emitting change events
[22:33:18] <Krenair>	 but the transclusion dialog would think it had already finished loading?
[22:33:41] <RoanKattouw>	 Krenair: I don't know exactly why that happens
[22:34:00] <RoanKattouw>	 It doesn't sound like anything is very wrong architecturally
[22:34:08] <RoanKattouw>	 Just some code hanging on to some data that it shouldn't be hanging on to, probably
[22:37:20] <wikibugs>	 3OOjs-UI, VisualEditor-MediaWiki: Replace and Replace all buttons are clipped in VisualEditor when using the OOjs UI MediaWiki theme - https://phabricator.wikimedia.org/T78042#839260 (10matmarex) I'm pretty sure that's by design. The task for figuring out what to do with the massive buttons is T78169.
[22:37:26] <wikibugs>	 3VisualEditor-MediaWiki-Mobile, MobileFrontend-Feature-requests, MediaWiki-Page-editing: iOS: Shake to undo on mobile does not undo or redo typing - https://phabricator.wikimedia.org/T67600#839264 (10Jaredzimmerman-WMF) 5Open>3Resolved a:3Jaredzimmerman-WMF Just testing on iphone, and ipad, in VE and WTE,...
[22:43:49] <Krenair>	 RoanKattouw, it looks like onTransclusionReady is called before the change event goes through
[22:46:44] <RoanKattouw>	 Hmm
[22:49:19] <Krenair>	 RoanKattouw, MWTransclusionModel#process will resolve the promises (which would call onTransclusionReady), then emits change
[22:50:36] <Krenair>	 Hm, maybe I could hack around this by counting the number of times the change event was called since onTransclusionReady. . . :)
[22:53:52] <RoanKattouw>	 Well or it could call change before resolving the promises?
[22:54:00] <RoanKattouw>	 I mean that seems more sensible to me
[22:54:24] <RoanKattouw>	 Oh, I see
[22:54:37] <RoanKattouw>	 It resolves promises inside the loop, then emits change outside the loop
[22:55:39] <RoanKattouw>	 Krenair: So what is hooked up to these promises and what is hooked up to change?
[22:55:44] <wikibugs>	 3VisualEditor-Tables, VisualEditor-ContentLanguage: Chinese table contents are lost when saving in VisualEditor, unless the first letter is in the Latin alphabet - https://phabricator.wikimedia.org/T78121#839342 (10Etonkovidova) Confirmed on https://zh.wikipedia.org/ - typed Cangjie(on Mac) in tables is not save...
[22:56:21] <RoanKattouw>	 Because it sounds like there are two things that need to run, they need to run in a certain order, but one is hooked into the one and one is hooked into the other, and they don't always fire in the same order
[22:58:03] <Krenair>	 So MWTemplateDialog#getSetupProcess basically calls this.transclusionModel.load( ... ).always( this.onTransclusionReady.bind( this ) )
[22:58:48] <RoanKattouw>	 Where .load returns $.when( a, bunch, of, promises )?
[22:58:49] <Krenair>	 MWTransclusionModel#load sets those promises and then it's own gets resolved when they're all done (using $.when)
[22:59:05] <Krenair>	 yes
[23:00:10] <Krenair>	 then MWTransclusionModel#process comes along and resolves them all, and emits change after the last one was resolved
[23:00:49] <Krenair>	 which means onTransclusionReady gets called, then a change event is guaranteed immediately afterwards
[23:04:06] <RoanKattouw>	 Right
[23:04:17] <RoanKattouw>	 But what happens in response to the change event?
[23:04:30] <grrrit-wm>	 (03PS3) 10Bartosz Dziewoński: [BREAKING CHANGE] FieldLayout: Handle 'inline' alignment better [oojs/ui] - 10https://gerrit.wikimedia.org/r/178946 
[23:06:30] <Krenair>	 RoanKattouw, apply change button is enabled (for https://phabricator.wikimedia.org/T76926 )
[23:07:40] <Krenair>	 not sure if anything is done on the current master. haven't looked into that
[23:08:02] <RoanKattouw>	 Ugh
[23:08:05] <RoanKattouw>	 Right
[23:08:21] <RoanKattouw>	 I guess you could ignore change events until transclusionReady has happened?
[23:08:56] <Krenair>	 that's what I'm doing
[23:09:05] <Krenair>	 the problem is that the change event comes after transclusionready
[23:15:21] <RoanKattouw>	 Right, of course :(
[23:15:24] <wikibugs>	 3VisualEditor-MediaWiki: In category input field, typing invalid category name doesn't clear suggestions - https://phabricator.wikimedia.org/T76868#839382 (10Ryasmeen) Verified the fix in Betalabs and test2
[23:16:30] <wikibugs>	 3VisualEditor-MediaWiki: In category input field, typing invalid category name doesn't clear suggestions - https://phabricator.wikimedia.org/T76868#839384 (10Ryasmeen) 5Open>3Resolved
[23:18:56] <RoanKattouw>	 MatmaRex: FYI, https://phabricator.wikimedia.org/T78207
[23:19:16] <Krenair>	 RoanKattouw, I could modify MWTransclusionModel#process to store the Deferred objects, then resolve them all after the change emit
[23:19:38] <MatmaRex>	 ugh
[23:19:51] <RoanKattouw>	 Yeah that's what I was thinking. It feels a bit icky but I guess it might be needed
[23:19:58] <MatmaRex>	 yeah
[23:20:09] <MatmaRex>	 but, there are supposed to be for screen readers
[23:20:10] <RoanKattouw>	 MatmaRex: Bringing that bug to your attention because you are the author of the change I'm suggesting reverting
[23:20:15] <grrrit-wm>	 (03PS7) 10Divec: WIP: Native leftarrow, rightarrow, backspace and delete [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177946 
[23:20:20] <MatmaRex>	 isn't #mw-head like, somewhere entirely different than actual navigation?
[23:20:24] <RoanKattouw>	 And also probably the person that made the change that caused this bug :)
[23:20:31] <Krenair>	 RoanKattouw, it certainly seems to do the trick for my patch
[23:20:54] <MatmaRex>	 in the DOM i mean
[23:20:57] <MatmaRex>	 anyway, will look
[23:20:58] <grrrit-wm>	 (03PS1) 10Trevor Parscal: Split primary flag into primary and progressive [oojs/ui] - 10https://gerrit.wikimedia.org/r/179000 
[23:22:01] <RoanKattouw>	 MatmaRex: I think #mw-head is right
[23:22:05] <grrrit-wm>	 (03CR) 10Jforrester: "Did a brief review in-person; looks nice. +1 from that end. Not looked at the code." [oojs/ui] - 10https://gerrit.wikimedia.org/r/179000 (owner: 10Trevor Parscal)
[23:22:07] <RoanKattouw>	 #mw-navigation is the parent of #mw-head
[23:22:36] <RoanKattouw>	 But #mw-head and its siblings are absolutely positioned, so #mw-navigation has 100% width and 0 height and is located somewhere insane
[23:23:01] <TrevorParscal>	 MatmaRex: ok, so https://gerrit.wikimedia.org/r/179000 works, I don't have any pull throughs yet, but it's pretty much just pulling it through and adding progressive to anywhere we are using primary (should have both now, since we split the meaning existing uses mean both still)
[23:23:10] <MatmaRex>	 RoanKattouw: okay, that sounds like a good idea then
[23:23:11] <TrevorParscal>	 but, I need to spend some time with kirstenMA
[23:23:25] <MatmaRex>	 TrevorParscal: aye
[23:23:28] <TrevorParscal>	 so... I'm not going to be working on the pull throughs for a while
[23:23:36] <TrevorParscal>	 just fyi
[23:23:41] <TrevorParscal>	 brb
[23:23:51] <MatmaRex>	 how long a while?
[23:24:12] <MatmaRex>	 (as in, should i do that, or is it yours, just not today?)
[23:25:23] <RoanKattouw>	 I think he meant a few hours
[23:25:24] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP: Native leftarrow, rightarrow, backspace and delete [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177946 (owner: 10Divec)
[23:27:32] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Split primary flag into primary and progressive [oojs/ui] - 10https://gerrit.wikimedia.org/r/179000 (owner: 10Trevor Parscal)
[23:28:59] <grrrit-wm>	 (03PS1) 10Alex Monk: Template dialog: Disable 'Apply changes' until a change is made [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/179002 
[23:29:28] <James_F>	 MatmaRex: Maybe do the VE-core pull-through-fix-up for it whilst he's not here?
[23:30:53] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Template dialog: Disable 'Apply changes' until a change is made [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/179002 (owner: 10Alex Monk)
[23:31:10] <grrrit-wm>	 (03CR) 10Jforrester: "Typo in comment." (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/179002 (owner: 10Alex Monk)
[23:31:39] <Krenair>	 oops, well spotted James_F 
[23:31:56] <James_F>	 Krenair: The sole advantage of having worked as a copyeditor. :-)
[23:32:21] <grrrit-wm>	 (03PS2) 10Alex Monk: Template dialog: Disable 'Apply changes' until a change is made [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/179002 
[23:32:36] <MatmaRex>	 James_F: let me see if i know how to, heh
[23:33:06] <MatmaRex>	 and whether the script works on windows
[23:33:32] <James_F>	 MatmaRex: Oh, I meant the fix-up part. I'm happy to do the actual pull-through once it's landed. :-)
[23:33:43] <MatmaRex>	 (the oojs update ones were recent;ly broken by using mktemp, i should fix that some time)
[23:33:57] <MatmaRex>	 ugh, what fix-up?
[23:34:02] <MatmaRex>	 for trevor's buttons?
[23:34:07] <James_F>	 Yeah. Breaking change fun times.
[23:34:15] <MatmaRex>	 he threatened that it's a breaking change for like five repos
[23:34:27] <James_F>	 Mostly it's s/primary/progressive/
[23:34:29] <James_F>	 Yeah.
[23:35:16] <MatmaRex>	 not today, i'm disappearing soon
[23:36:08] <grrrit-wm>	 (03PS2) 10Jforrester: [BREAKING CHANGE] Split primary flag into primary and progressive [oojs/ui] - 10https://gerrit.wikimedia.org/r/179000 (owner: 10Trevor Parscal)
[23:36:09] <James_F>	 OK.
[23:36:35] <grrrit-wm>	 (03CR) 10Jforrester: "PS2: Fix JSism in PHP code; note in commit title that this is a breaking change." [oojs/ui] - 10https://gerrit.wikimedia.org/r/179000 (owner: 10Trevor Parscal)
[23:37:25] <wikibugs>	 3OOjs-UI, VisualEditor-MediaWiki: Need for a muted destructive state for buttons which are destructive but not important workflow items in the OOjs UI MediaWiki theme - https://phabricator.wikimedia.org/T78040#839411 (10Jdforrester-WMF) a:3TrevorParscal
[23:39:13] <RoanKattouw>	 MatmaRex: Before you disappear, could you look at https://gerrit.wikimedia.org/r/179004 ?
[23:39:19] <RoanKattouw>	 It fixes the bug for me locally
[23:39:51] <RoanKattouw>	 It's essentially a revert of that commit from 2013, but not directly because the code moved to a different repo without preservation of history
[23:41:03] <wikibugs>	 3OOjs-UI, VisualEditor-MediaWiki: Checked state of checkboxes looks off when zoomed in, in the MediaWiki theme - https://phabricator.wikimedia.org/T78036#839429 (10Jdforrester-WMF) Nice.
[23:41:32] <wikibugs>	 3OOjs-UI, VisualEditor-MediaWiki: We need to pick a highlight colour and use it consistently in VisualEditor when using the OOjs UI MediaWiki theme - https://phabricator.wikimedia.org/T78047#839433 (10Jdforrester-WMF) Eww. Oh well.
[23:41:42] <MatmaRex>	 RoanKattouw: +2'd, thanks
[23:41:47] <RoanKattouw>	 Thanks man
[23:43:53] <wikibugs>	 3VisualEditor-EditingTools: Pressing Escape while a dialog is open closes the editor, should only close the dialog - https://phabricator.wikimedia.org/T78201#839439 (10Jdforrester-WMF) p:5Triage>3High
[23:44:18] <wikibugs>	 3VisualEditor-MediaWiki: Wikitext warning triggered when editing paragraph with wikitext in it, even though none was added in this edit - https://phabricator.wikimedia.org/T53751#839441 (10Etonkovidova)
[23:48:05] <wikibugs>	 3VisualEditor, VisualEditor-Performance, VisualEditor-Initialisation: Improve VisualEditor's loading performance in Firefox - https://phabricator.wikimedia.org/T52616#839450 (10Jdforrester-WMF) Those are pretty major performance improvements, much more than I was expecting. Odd.
[23:48:19] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] Delimit text nodes in debug observations (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178894 (owner: 10Divec)
[23:49:06] <James_F>	 MatmaRex: Have reverted #VisualEditor to just use the boring briefcase.
[23:49:56] <MatmaRex>	 boo
[23:50:14] <MatmaRex>	 it's really stupid that this breaks the bot
[23:50:19] <James_F>	 Indeed.
[23:51:47] <grrrit-wm>	 (03CR) 10Esanders: "Don't we have to handle this programmatically anyway, as we switch to focusable node highlights?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178904 (owner: 10Divec)
[23:55:21] <wikibugs>	 3VisualEditor, VisualEditor-MediaWiki, MediaWiki-skins-MonoBook: Monobook: extremely small font in Insert-Template and Cite options dialog boxes - https://phabricator.wikimedia.org/T75800#839470 (10Etonkovidova)
[23:57:06] <wikibugs>	 3VisualEditor, VisualEditor-MediaWiki, MediaWiki-skins-MonoBook, OOjs-UI: Cancel button does not work for Insert-Template and some Cite options in VisualEditor in Monobook - https://phabricator.wikimedia.org/T75802#839476 (10Etonkovidova)