' ).append( $thumb ); Now, I need to control the thumb size, but the *easiest* to do this is with css 'max-height' and 'max-width' since they're both conditional and work great. I could do this programmatically, but I am wondering -- at what point can I get the actual size (post css resizing) of the $thumb ? a [20:10:22] fter it's attached? when is the CSS rule actually applied? [20:10:37] or is this totally backwards and I should do this programmatically completely... :\ [20:10:40] 3VisualEditor, VisualEditor-MediaWiki: Extra space before the start of the citation dialog contents - https://phabricator.wikimedia.org/T78045#842596 (10Krenair) [20:10:53] 3UI-Standardization, OOjs-UI, MediaWiki-Interface: Switch MediaWiki core's use of OOjs UI to use the MediaWiki theme, not Apex - https://phabricator.wikimedia.org/T78054#842605 (10Krenair) [20:11:01] here you go: http://cl.ly/3N071K0m463k [20:11:02] omg [20:11:11] Why is aklapper subscribed to everything? :/ [20:11:39] 3OOjs-UI: ButtonGroupWidget in demo pooped in MediaWiki theme - https://phabricator.wikimedia.org/T78326#842606 (10matmarex) a:3matmarex [20:11:49] Krenair: Because it's his job to be. [20:12:04] Krenair: If you remove him the system will just add him back. [20:13:23] TrevorParscal: wat [20:16:00] MatmaRex: did you see the graphic? [20:16:17] the mega graphic of doom! dude, it makes my computer chug because it's so massive lol [20:16:23] TrevorParscal: the A0-format PDF, yeah [20:18:00] mooeypoo: Is $thumb an ? [20:20:59] (03PS1) 10Bartosz Dziewoński: Don't set line-height of unset labels [oojs/ui] - 10https://gerrit.wikimedia.org/r/179186 [20:22:33] RoanKattouw, indeed yes [20:22:43] RoanKattouw, it has a class that has max-height and max-width in it [20:22:58] mooeypoo: OK so with tags in general, your browser will love you if you set width and height attributes on it before setting src [20:23:08] hmmm [20:23:09] Because otherwise it doesn't know how big to make it until it receives the image [20:23:22] Ah, I see. Right. [20:23:34] That's only relevant if it's not absolutely positioned [20:23:44] 3UI-Standardization, OOjs-UI, MediaWiki-Interface: Shadow at the bottom of the dropdown menus is vertically mis-aligned by a pixel or two in the MediaWiki theme - https://phabricator.wikimedia.org/T78083#842640 (10matmarex) a:5matmarex>3None So this is apparently by design. Someone else can figure out what t... [20:23:47] In this case it's probably floated so the width and height do matter [20:23:58] Hm. Okay, sounds like I will have to do this programmatically anyways [20:24:03] Although if a container around it already has w+h (probably does) then it doesn't matter that much [20:24:03] 3OOjs-UI: Shadow at the bottom of the dropdown menus is vertically mis-aligned by a pixel or two in the MediaWiki theme - https://phabricator.wikimedia.org/T78083#842642 (10matmarex) [20:24:22] I was hoping to skip the 'if landscape && bigger than screen || portrait && bigger than screen etc etc" conditions [20:24:43] Oh you're trying to resize the image if it's bigger than the screen? [20:24:48] yes [20:25:00] RoanKattouw, it's the image display panel in the media dialog [20:25:03] Is this in the context of image selection in a dialog, or image rendering in the surface? [20:25:05] OK so the former [20:25:26] 3OOjs-UI, UI-Standardization: Shadow at the bottom of buttons, dropdown menus is intentionally vertically mis-aligned by a pixel or two in the MediaWiki theme - https://phabricator.wikimedia.org/T78083#842644 (10Jdforrester-WMF) a:3violetto [20:25:28] so, I wnt to display a bigger version than the search results, so *before* I was just using thumb which is small enough to never be bigger than screen, but *now* I am using the original image and resizing it [20:25:36] Then you're getting your image URLs from an API response that should also include thumbwidth and thumbheight properties hopefully [20:25:38] MatmaRex: Happy with my re-write? [20:25:50] James_F: <3 [20:25:54] :-) [20:25:55] Oh, image display panel, OK I see [20:26:04] RoanKattouw, but the positioning of the info depends on how the image is laid out on the screen, so I was thinking of saving myself the trouble, letting CSS do the work for me, and *then* post-process positioning. [20:26:14] RoanKattouw, but apparently I was ahead of myself there :p [20:26:30] 3UI-Standardization, OOjs-UI, MediaWiki-Interface: Switch MediaWiki core's use of OOjs UI to use the MediaWiki theme, not Apex - https://phabricator.wikimedia.org/T78054#842648 (10Jdforrester-WMF) [20:26:34] You're reusing the src of the image rendered on the page I take it? [20:26:45] Or are you getting a different image URL from somewhere else? [20:26:50] well, somewhat [20:26:55] the search results use info.thumburl [20:27:03] the image display is just info.url [20:27:15] so the image isn't loaded yet if that's what you're going for? [20:27:55] RoanKattouw, I am getting into a *bit* of trouble with this method in case the image is *huge* [20:28:03] i have a couple of images that take a little bit to load [20:28:18] but overall, I think this is better than displaying the thumbnail, as TrevorParscal said too. The user expects a bigger version. [20:28:23] mooeypoo: So, question [20:28:24] I wish there was an intermediate, though [20:28:36] "the image display", does that happen after selecting a search result, or when inspecting an existing image, or both? [20:28:44] 3OOjs-UI, VisualEditor: Toolbars should have a heavy shadow on their bottom in the MediaWiki theme - https://phabricator.wikimedia.org/T78085#842655 (10matmarex) a:5matmarex>3None I figure that this should match the design from {T78083}, so waiting on that. [20:28:45] after selecting search results [20:28:54] What happens when you inspect an existing image then? [20:29:01] just the current dialog? [20:29:15] yeah, the dialog is divided to two main components -- image attributes and image search [20:29:21] O [20:29:23] K [20:29:30] if you inspect a current image, you get the attributes, unless you click "change image" in which case you get the search [20:29:35] So, one thing you could do is call the API again asking for a slightly larger thumb [20:29:37] when you add a new image, you go to the search directly [20:30:04] (except if the one you have already is already full size) [20:30:07] explain "slightly larger thumb" ? I didn't see the option of having resized thumbnails, but that would DEFINITELY help me [20:30:20] You're passing iiurlwidth in order to get thumbnails [20:30:32] I am? [20:30:36] (I'm not) [20:30:43] So instead of passing &iiurlwidth=200 with a search query for lots of images, query only one image and pass &iiurlwidth=600 or whatever [20:30:50] Ahm, well some code somewhere must be, right? [20:30:54] (03PS3) 10Bartosz Dziewoński: RadioInputWidget: Remove documentation lies [oojs/ui] - 10https://gerrit.wikimedia.org/r/178586 [20:30:58] I am asking for an image and just ask for .thumburl [20:30:59] That's how you get thumbnail [20:31:01] URLs [20:31:03] hm [20:31:04] anyone? ^ [20:31:36] ooh hmm [20:31:41] RoanKattouw, hm. ve.ce.ImageNode does that. I don't in my search results. I should. [20:31:47] Did they change how the API works and you now get thumburl for the default thumb size? [20:32:00] I get thumb url without that, yes [20:32:06] Aha! [20:32:08] iiurlheight: this.size [20:32:16] MWMediaSearchWidget 155 [20:32:24] oh I asked for height instead [20:32:31] ... i forgot i did that [20:32:36] okaaay. Hm. [20:32:59] So.. I'll have to re-request API data when I load the image panel [20:33:22] So repeat that request but without the search generator stuff or a bunch of the other stuff, basically just action=query&prop=imageinfo&titles=File:Whatever.png&iiprop=dimensions|url&iiurlheight=600 [20:33:25] Or width=something or whatever [20:33:42] Yeah that's the downside [20:33:45] RoanKattouw, no way of getting multiple thumbs at once, is there? [20:33:50] Unfortunately not [20:33:58] It would be nice if you could get all the thumb URLs for the larger size [20:34:06] yea [20:34:14] saves quite a lot of api requests [20:34:28] and the search widget ALREADY has a lot of requests since it fires on keystroke [20:34:51] Well this you would only need to request for an image when it's chosen [20:35:18] RoanKattouw, if I ask for both iiurlheight= and iiurlwidth= will I get an image that is boxed by those? [20:35:25] Yes [20:35:29] awesome, at least that [20:35:34] As you may have noticed thumburl is a string, not an array [20:35:41] It's not set up to give you multiple thumbs [20:35:46] sadly, yeah [20:35:49] (of the same image at least) [20:36:50] However, I think that in many cases doing an API call then downloading a larger thumb will still be faster than downloading a full-size image [20:37:42] (03PS3) 10Jforrester: [BREAKING CHANGE] CheckboxInputWidget: Allow setting HTML 'value' attribute [oojs/ui] - 10https://gerrit.wikimedia.org/r/178592 (owner: 10Bartosz Dziewoński) [20:38:07] (03CR) 10Jforrester: [C: 032] "Per Trevor." [oojs/ui] - 10https://gerrit.wikimedia.org/r/178592 (owner: 10Bartosz Dziewoński) [20:38:26] (03CR) 10Jforrester: [C: 032] RadioInputWidget: Remove documentation lies [oojs/ui] - 10https://gerrit.wikimedia.org/r/178586 (owner: 10Bartosz Dziewoński) [20:38:51] 3VisualEditor, Parsoid, VisualEditor-MediaWiki: Editing a specific article at pl.wp truncates category name - https://phabricator.wikimedia.org/T76353#842668 (10Elitre) Thanks a lot. Seems to work now. Please double check then close the bug accordingly :) [20:39:04] RoanKattouw, yeah, you're probably right. Also, I think it is probably okay for the user to see a spinning loader for the image for a brief moment, worse case [20:39:29] Yeah [20:39:36] Better than very slowly watching a 2MB image load [20:39:43] Indeed. [20:39:55] Remember that Commons encourages uploading full-size images [20:39:59] Can we re-use the size that MediaViewer are generating? [20:40:06] 2MB is probably not that bad nowadays, but there are much larger images, indeed. [20:40:08] Nowadays full-size is often ~4kx3k pixels [20:40:28] James_F, well they are using a different size screen. Mine needs to fit inside the media dialog [20:40:29] Also some "images" are not images but have thumbs [20:40:32] Like videos and PDFs [20:40:41] mooeypoo: Sure, but we can also re-size the dialog. ;-) [20:41:05] (03Merged) 10jenkins-bot: RadioInputWidget: Remove documentation lies [oojs/ui] - 10https://gerrit.wikimedia.org/r/178586 (owner: 10Bartosz Dziewoński) [20:41:05] RoanKattouw, aye, but those are relatively easy, I check first if they're "AUDIO" or other types and then use the original thumburl if they are [20:41:14] James_F, hm, that too [20:41:32] James_F, I'll start with fitting them to the screen. If we want to resize later, we can just change the size requested in the API [20:41:41] mooeypoo: OK. [20:44:50] (03Merged) 10jenkins-bot: [BREAKING CHANGE] CheckboxInputWidget: Allow setting HTML 'value' attribute [oojs/ui] - 10https://gerrit.wikimedia.org/r/178592 (owner: 10Bartosz Dziewoński) [20:47:41] (03PS12) 10Paladox: Reformat the license warning only if available [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/98249 (owner: 10Dev-zero) [20:49:35] (03PS7) 10Catrope: Update VE core submodule to master (cf1e167) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/177131 (owner: 10Esanders) [20:52:25] (03PS1) 10Trevor Parscal: Use gray instead of blue for select and highlight [oojs/ui] - 10https://gerrit.wikimedia.org/r/179193 [20:55:42] TrevorParscal: so i just discovered that MW theme is missing most of the styles for the booklet dialog things. [20:56:07] 3OOjs-UI, VisualEditor, VisualEditor-MediaWiki-Templates: Parameter entries aren't indented in the transclusion dialog's booklet layout in VisualEditor when using the OOUI MediaWiki theme - https://phabricator.wikimedia.org/T78321#842705 (10matmarex) a:3matmarex [20:56:12] 3VisualEditor, OOjs-UI, VisualEditor-MediaWiki: Vertical height of panel controls is too low in MediaWiki theme - https://phabricator.wikimedia.org/T78031#842706 (10matmarex) a:3matmarex [20:56:16] so that's what i'm doing right now [20:59:12] TrevorParscal: For that highlight change, should we parameterise the colour or just leave it for now? [20:59:45] (03PS2) 10Jforrester: MediaWiki theme: Use gray instead of blue for select and highlight [oojs/ui] - 10https://gerrit.wikimedia.org/r/179193 (owner: 10Trevor Parscal) [20:59:54] 3VisualEditor, OOjs-UI, VisualEditor-MediaWiki: Width layout issues in the media insert window in VisualEditor when using the OOjs UI MediaWiki theme - https://phabricator.wikimedia.org/T78050#842710 (10Krenair) Isn't this another thing that happens in Apex as well? [20:59:59] (03CR) 10Jforrester: [C: 031] "Maybe parameterise?" [oojs/ui] - 10https://gerrit.wikimedia.org/r/179193 (owner: 10Trevor Parscal) [21:00:23] (03CR) 10Jforrester: [C: 032] Update VE core submodule to master (cf1e167) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/177131 (owner: 10Esanders) [21:01:23] Is there TrevorParscal? [21:01:40] I suspect the comment for this method is out-of-date. https://github.com/wikimedia/oojs-ui/blob/master/src/Toolbar.js#L98 [21:01:43] Hey BladeBronson. [21:02:04] hey james [21:02:19] (03Merged) 10jenkins-bot: Update VE core submodule to master (cf1e167) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/177131 (owner: 10Esanders) [21:02:36] (03CR) 10Jforrester: [C: 031] "+2-worthy "Yay"?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178665 (owner: 10Esanders) [21:02:52] BladeBronson: MatmaRex might know if TrevorParscal's busy. [21:03:43] Cool. In Wikia's implementation, due to a loading animation sequence, i want to separate toolbar setup and toolbar initialization. It doesn't seem like one needs to be called immediately after the other as the comment says. [21:05:12] BladeBronson: why do you think it's out-of-date? the method in OOUI doesn't actually do what the comment says, but it seems that it is intended to be overridden in subclasses. ve.ui.Toolbar.prototype.initialize has the same comment and seems to do the stuff. [21:05:47] 3VisualEditor, OOjs-UI, VisualEditor-MediaWiki: Width layout issues in the media insert window in VisualEditor when using the OOjs UI MediaWiki theme - https://phabricator.wikimedia.org/T78050#842721 (10Jdforrester-WMF) >>! In T78050#842710, @Krenair wrote: > Isn't this another thing that happens in Apex as well... [21:05:58] i admittedly don't know much about this code, though. this seems to be a case of too close VE-OOUI coupling. [21:06:13] 3VisualEditor, VisualEditor-MediaWiki: Width layout issues in the media insert window - https://phabricator.wikimedia.org/T78050#842722 (10Jdforrester-WMF) a:3Mooeypoo [21:06:36] I feel like there are too few people at WMF who care about details, and they are all people who aren't really in the right positions to be effective in doing something about that [21:06:43] i feel like I'm taking crazy pills [21:07:02] * MatmaRex hugs TrevorParscal [21:07:07] * James_F hugs TrevorParscal too. [21:07:09] 3VisualEditor, VisualEditor-MediaWiki, VisualEditor-MediaWiki-Media: Width layout issues in the media insert window - https://phabricator.wikimedia.org/T78050#842727 (10Krenair) [21:07:17] mooeypoo: https://phabricator.wikimedia.org/T78050 needs a fix ASAP, if you can. :-( [21:08:08] 3OOjs-UI, VisualEditor, VisualEditor-MediaWiki: Need for a muted destructive state for buttons which are destructive but not important workflow items in the OOjs UI MediaWiki theme - https://phabricator.wikimedia.org/T78040#842728 (10violetto) It seems like the main action upon clicking on the red link is the "D... [21:08:09] MatmaRex: Okay, but it doesn't seem like any hard dependency on these methods being called one right after the other. There could be a second in between for an animation. [21:08:10] James_F, this will be fixed with the work I'm doing now for the new dialog, but since that will probably take a bit longer with all the design consideration, I may as well work on a quick fix for this now [21:08:42] BladeBronson: in OOUI itself, probably yes. i've never looked at this code before, though. [21:09:09] mooeypoo: Yeah; just a 50px bump down in the window width or whatever might be sufficient. [21:09:13] i think the intent of this comment is, "must be called before you do any real stuff with the toolbar" [21:09:25] okay, that seems right to me [21:09:36] cool, thanks. [21:09:43] so don't let people click on buttons while it's animating, and it should be fine [21:09:51] bbiab [21:10:00] James_F, ok, i'm just writing a 'todo' comment to myself in the current commit so I can switch to master. got burnt with eating my own commit over gerrit one too many times :\ [21:10:22] mooeypoo: Bah. :-( Sympathies. [21:10:49] Blade_Away: Right now I'm merging some stuff that edsanders|away wrote that touches on toolbar initialization [21:10:54] (03PS15) 10Mooeypoo: [WIP] Transform the search widget to show image details [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161342 [21:10:56] slash setup slash whatever it's called [21:11:04] But if you need that to be split up more, go for it [21:11:10] Or tell edsanders|away what you need [21:12:27] err I can't load VE now ? what am I missing.. updated both mediawiki core and VE (mw + core) .. "Uncaught TypeError: Cannot read property 'triggerListener' of undefined" [21:12:27] 3OOjs-UI, VisualEditor: Toolbars should have a heavy shadow on their bottom in the MediaWiki theme - https://phabricator.wikimedia.org/T78085#842746 (10KHammerstein) [21:12:47] Sorry, VE loads, I can't open the media dialog [21:12:54] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Transform the search widget to show image details [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161342 (owner: 10Mooeypoo) [21:13:32] 3VisualEditor, VisualEditor-MediaWiki-Mobile: [Regression wmf11] VE is not opening in mobile - https://phabricator.wikimedia.org/T76660#842747 (10Ryasmeen) [21:13:45] mooeypoo: Oh dear. RoanKattouw, did we just break master? [21:14:37] Ahm, maybe? [21:14:45] triggerListener does sound like Ed's code [21:14:56] 3OOjs-UI: Menus' dropdown icons should be smaller and lighter in the MediaWiki theme - https://phabricator.wikimedia.org/T78086#842749 (10KHammerstein) [21:15:07] legoktm: https://www.mediawiki.org/w/index.php?title=Git/Reviewers&diff=1311411&oldid=1311410 :-( [21:15:10] WFM [21:15:15] mooeypoo: Update your submodule [21:15:20] (03PS1) 10Bartosz Dziewoński: Copy .theme-oo-ui-{outlineControlsWidget, outlineOptionWidget} from Apex to MediaWiki [oojs/ui] - 10https://gerrit.wikimedia.org/r/179198 [21:15:23] (03PS1) 10Bartosz Dziewoński: MediaWiki theme: Extract @active-color variable [oojs/ui] - 10https://gerrit.wikimedia.org/r/179199 [21:15:27] I am now (did before, but redoing everything) including composer update [21:15:40] (03CR) 10Bartosz Dziewoński: "Parameterised in https://gerrit.wikimedia.org/r/179199" [oojs/ui] - 10https://gerrit.wikimedia.org/r/179193 (owner: 10Trevor Parscal) [21:15:44] You shouldn't need to bump composer. [21:15:59] I just figured I'd update it all to make sure I'm up to date [21:16:06] (03CR) 10Jforrester: [C: 032] "Cool." [oojs/ui] - 10https://gerrit.wikimedia.org/r/179193 (owner: 10Trevor Parscal) [21:16:24] Oh hold on I see it [21:16:29] Opening the media dialog crashes [21:16:35] mrr. not working [21:16:38] (03PS2) 10Jforrester: MediaWiki theme: Copy .theme-oo-ui-{outlineControlsWidget, outlineOptionWidget} from Apex [oojs/ui] - 10https://gerrit.wikimedia.org/r/179198 (owner: 10Bartosz Dziewoński) [21:16:40] oh, okay, i'm not the only one [21:16:46] (03CR) 10Jforrester: [C: 031] MediaWiki theme: Copy .theme-oo-ui-{outlineControlsWidget, outlineOptionWidget} from Apex [oojs/ui] - 10https://gerrit.wikimedia.org/r/179198 (owner: 10Bartosz Dziewoński) [21:16:51] (03PS3) 10Bartosz Dziewoński: Copy .theme-oo-ui-{outlineControlsWidget, outlineOptionWidget} from Apex to MediaWiki [oojs/ui] - 10https://gerrit.wikimedia.org/r/179198 [21:16:53] (03PS2) 10Jforrester: MediaWiki theme: Extract @active-color variable [oojs/ui] - 10https://gerrit.wikimedia.org/r/179199 (owner: 10Bartosz Dziewoński) [21:16:55] > this.getSurface() [21:16:56] undefined [21:16:58] WTF [21:17:14] (03CR) 10Jforrester: [C: 032] MediaWiki theme: Extract @active-color variable [oojs/ui] - 10https://gerrit.wikimedia.org/r/179199 (owner: 10Bartosz Dziewoński) [21:17:21] (03PS4) 10Bartosz Dziewoński: Copy .theme-oo-ui-{outlineControlsWidget, outlineOptionWidget} from Apex to MediaWiki [oojs/ui] - 10https://gerrit.wikimedia.org/r/179198 [21:17:31] (sorry about the commit messagespam) [21:17:32] Oh he didn't update SurfaceWidget [21:17:43] (03CR) 10Bartosz Dziewoński: [C: 032] MediaWiki theme: Use gray instead of blue for select and highlight [oojs/ui] - 10https://gerrit.wikimedia.org/r/179193 (owner: 10Trevor Parscal) [21:17:43] MatmaRex: Bah. [21:17:47] hmm it seems to come from the caption surfaceWidget [21:17:49] 3VisualEditor, VisualEditor-MediaWiki-Media: Show media search results more pleasingly, with meta-data details available - https://phabricator.wikimedia.org/T78161#842757 (10KHammerstein) [21:17:54] * mooeypoo hopes it's not the RTL fix [21:18:06] doesn't look it, though.. hm. [21:18:12] (03PS3) 10Bartosz Dziewoński: MediaWiki theme: Extract @active-color variable [oojs/ui] - 10https://gerrit.wikimedia.org/r/179199 [21:18:14] 3VisualEditor, VisualEditor-MediaWiki-Media: Show media search results more pleasingly, with meta-data details available - https://phabricator.wikimedia.org/T78161#837446 (10KHammerstein) [21:18:27] MatmaRex: How about "MediaWiki theme: Copy .theme-oo-ui-outline{Controls, Option}Widget from Apex"? :-) [21:19:06] James_F: probably fine. kill grepability a bit though. [21:19:13] kills* [21:19:16] (03Merged) 10jenkins-bot: MediaWiki theme: Use gray instead of blue for select and highlight [oojs/ui] - 10https://gerrit.wikimedia.org/r/179193 (owner: 10Trevor Parscal) [21:19:18] mooeypoo: I found it [21:19:23] hm, you can't kill something a bit. hurts a bit. :D [21:19:28] MatmaRex: Sure, but it makes MW-theme commits start with a consistent string. [21:19:34] RoanKattouw, oh, awesome, thanks [21:19:39] 3OOjs-UI, UI-Standardization, MediaWiki-Interface: Decide whether or not to use hover to indicate which item in menus/etc. we're about to select, in the MediaWiki theme - https://phabricator.wikimedia.org/T78082#842764 (10Jdforrester-WMF) 5Open>3Resolved [21:19:40] 3OOjs-UI, VisualEditor, VisualEditor-MediaWiki: Selected state of panel controls is blue, but for ButtonSelectWidgets is grey, in MediaWiki theme - https://phabricator.wikimedia.org/T78032#842767 (10Jdforrester-WMF) [21:19:42] 3UI-Standardization, MediaWiki-Interface, OOjs-UI: Switch MediaWiki core's use of OOjs UI to use the MediaWiki theme, not Apex - https://phabricator.wikimedia.org/T78054#842766 (10Jdforrester-WMF) [21:19:45] James_F: sounds okay to me [21:19:53] 3UI-Standardization, MediaWiki-Interface, OOjs-UI: Switch MediaWiki core's use of OOjs UI to use the MediaWiki theme, not Apex - https://phabricator.wikimedia.org/T78054#834496 (10Jdforrester-WMF) [21:19:54] hah now you can't /close/ the media dialog [21:19:54] 3OOjs-UI, VisualEditor, VisualEditor-MediaWiki: We need to pick a highlight colour and use it consistently in VisualEditor when using the OOjs UI MediaWiki theme - https://phabricator.wikimedia.org/T78047#842769 (10Jdforrester-WMF) 5Open>3Resolved [21:21:26] OK now it works [21:21:39] (03PS5) 10Jforrester: MediaWiki theme: Copy .theme-oo-ui-outline{Controls,Option}Widget from Apex [oojs/ui] - 10https://gerrit.wikimedia.org/r/179198 (owner: 10Bartosz Dziewoński) [21:24:12] 3VisualEditor: [Regression pre-wmf13]TypeError: this.toolbar.getSurface(...) is null appears while trying to save an edit on a page - https://phabricator.wikimedia.org/T78335#842773 (10Ryasmeen) 3NEW [21:24:23] (03PS1) 10Catrope: Followup cf1e167: unbreak SurfaceWidget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179202 [21:24:33] (03CR) 10Bartosz Dziewoński: Element.getClosestScrollableContainer: Use 'body' or 'documentElement' based on browser (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/176666 (owner: 10Prtksxna) [21:26:06] RoanKattouw, I just tested and it works. I want to +2, but should I wait for jenkins to have a pass first? [21:26:10] (03PS1) 10Divec: Get CSS directionality from selected node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179203 [21:26:14] mooeypoo: Go for it. [21:26:26] mooeypoo: You can't merge if Jenkins doesn't like it anyway. :-) [21:26:33] good point [21:26:50] (03CR) 10Mooeypoo: [C: 032] "Works now!" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179202 (owner: 10Catrope) [21:27:03] okay I must eat now [21:27:16] (03PS2) 10Bartosz Dziewoński: Don't set line-height of unset button labels [oojs/ui] - 10https://gerrit.wikimedia.org/r/179186 [21:29:38] (03PS2) 10Divec: Get CSS directionality from selected node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179203 [21:30:40] 3VisualEditor: [Regression pre-wmf13]Cannot open Basic Reference and Media dialog, TypeError: this.getSurface(...) is undefined appears - https://phabricator.wikimedia.org/T78338#842802 (10Ryasmeen) 3NEW a:3Catrope [21:30:41] /*jshint bitwise:false */ [21:30:42] caVeEditNextnode = ( reverseTabOrder ^ conf.tabPosition === 'before' ) ? $caEdit.get( 0 ) : $caEdit.next().get( 0 ); [21:30:50] Shocked that we had to over-ride jshint there. :-P [21:31:13] 3VisualEditor: [Regression pre-wmf13]Cannot open Basic Reference and Media dialog, TypeError: this.getSurface(...) is undefined appears - https://phabricator.wikimedia.org/T78338#842802 (10Ryasmeen) p:5Triage>3High [21:32:16] (03PS1) 10Jforrester: README.md: Drop localisation update auto-commits from release notes [oojs/ui] - 10https://gerrit.wikimedia.org/r/179207 [21:32:29] (03Merged) 10jenkins-bot: Followup cf1e167: unbreak SurfaceWidget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179202 (owner: 10Catrope) [21:33:20] (03PS1) 10Jforrester: Update VE core submodule to master (17c36e7) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/179208 [21:34:22] (03PS1) 10Catrope: Update VE core submodule to master (17c36e7) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/179209 [21:34:38] (03Abandoned) 10Catrope: Update VE core submodule to master (17c36e7) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/179209 (owner: 10Catrope) [21:34:47] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (17c36e7) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/179208 (owner: 10Jforrester) [21:34:56] ha, brilliant minds, RoanKattouw & James_F [21:35:00] also, niiiice timing! [21:35:08] mooey|food: It's called a script. :-) [21:35:28] It was cooler to think you're psychic [21:35:36] :-) [21:35:45] (03PS1) 10Jforrester: build: Suppress the 'unique-headings' warning from CSSLint [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/179212 [21:36:01] James_F: I was just marking it all as read without even reading it so... [21:36:06] RoanKattouw: https://gerrit.wikimedia.org/r/179207 https://gerrit.wikimedia.org/r/179212 https://gerrit.wikimedia.org/r/179208 [21:36:14] legoktm: Still. :-( [21:36:16] 3VisualEditor: [Regression pre-wmf13]TypeError: this.toolbar.getSurface(...) is null appears after saving an edit and then cannot reopen that page next time - https://phabricator.wikimedia.org/T78335#842817 (10Ryasmeen) [21:36:17] (03CR) 10jenkins-bot: [V: 04-1] Don't set line-height of unset button labels [oojs/ui] - 10https://gerrit.wikimedia.org/r/179186 (owner: 10Bartosz Dziewoński) [21:36:27] legoktm: So if we get stuck in future we should just ask in IRC? [21:36:35] (03CR) 10Catrope: [C: 032] README.md: Drop localisation update auto-commits from release notes [oojs/ui] - 10https://gerrit.wikimedia.org/r/179207 (owner: 10Jforrester) [21:36:43] yeah or just add me as a reviewer and I'll look [21:36:43] (03Merged) 10jenkins-bot: Update VE core submodule to master (17c36e7) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/179208 (owner: 10Jforrester) [21:36:50] (03CR) 10Catrope: [C: 032] build: Suppress the 'unique-headings' warning from CSSLint [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/179212 (owner: 10Jforrester) [21:37:59] (03PS3) 10Bartosz Dziewoński: Don't set line-height of unset button labels [oojs/ui] - 10https://gerrit.wikimedia.org/r/179186 [21:38:13] 3VisualEditor, VisualEditor-EditingTools: [Regression pre-wmf13] Cannot open Basic Reference and Media dialog, TypeError: this.getSurface(...) is undefined appears - https://phabricator.wikimedia.org/T78338#842821 (10Jdforrester-WMF) 5Open>3Resolved [21:38:50] (03Merged) 10jenkins-bot: build: Suppress the 'unique-headings' warning from CSSLint [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/179212 (owner: 10Jforrester) [21:38:54] 3VisualEditor-InterfaceLanguage, VisualEditor, VisualEditor-ContentLanguage: VisualEditor: Support for right-to-left (rtl) / bidirectional content (tracking) - https://phabricator.wikimedia.org/T35126#842826 (10Jdforrester-WMF) [21:38:55] 3VisualEditor, VisualEditor-MediaWiki-Media, VisualEditor-MediaWiki-References: In the media adding dialog, LTR direction is forced on the description field even in RTL wikis - https://phabricator.wikimedia.org/T71969#842824 (10Jdforrester-WMF) 5Open>3Resolved [21:39:20] (03Merged) 10jenkins-bot: README.md: Drop localisation update auto-commits from release notes [oojs/ui] - 10https://gerrit.wikimedia.org/r/179207 (owner: 10Jforrester) [21:47:31] 3OOjs-UI, VisualEditor: Toolbars should have a heavy shadow on their bottom in the MediaWiki theme - https://phabricator.wikimedia.org/T78085#842838 (10matmarex) a:3matmarex Thanks Kaity! Let's do this then. [21:48:03] (03CR) 10Jforrester: [C: 031] "Testing in Chrome and Firefox in VE-MW in en/ltr; works perfectly as expected, no noticeable issues. Is further testing needed?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178904 (owner: 10Divec) [21:49:45] 3VisualEditor, VisualEditor-MediaWiki: Extra space before the start of the citation/template (not multiple transclusion) dialog contents - https://phabricator.wikimedia.org/T78045#842844 (10Krenair) [21:49:54] 3VisualEditor, VisualEditor-MediaWiki: Extra space before the start of the citation/template (not multiple transclusion) dialog contents - https://phabricator.wikimedia.org/T78045#834378 (10Krenair) a:3Krenair [21:52:10] (03CR) 10Catrope: [C: 032] [BREAKING CHANGE] Make ve.init.target an OO.ui.Element [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178665 (owner: 10Esanders) [21:53:17] 3OOjs-UI, VisualEditor: Toolbars should have a heavy shadow on their bottom in the MediaWiki theme - https://phabricator.wikimedia.org/T78085#842860 (10matmarex) So in context, it's supposed to look like this? I can't quite tell from this mockup if the line is supposed to reach screen edges or not. {F20891} [21:54:00] so... https://phabricator.wikimedia.org/T78054 time to regroup? [21:54:08] MatmaRex: what are you working on? [21:54:40] i just finished all the things i was doing. [21:54:50] Nice. [21:55:01] TrevorParscal: a bunch of changes is awaiting review :) [21:55:08] Is there a reason we don't set display:none; for template page labels in single transclusion dialogs? In my browser (and clearly others: https://phabricator.wikimedia.org/T78045 ) it still shows up without display:none; despite having height:0; [21:55:25] Krenair: Is that what it is? [21:55:25] 3OOjs-UI, VisualEditor: Toolbars should have a heavy shadow on their bottom in the MediaWiki theme - https://phabricator.wikimedia.org/T78085#842867 (10TrevorParscal) Bartosz, I think you have it right - unfortunately the mockup is based on a hypothetical skin that doesn't have a line on the left so it's unclear. [21:55:37] Krenair: Why is height: 0; set? [21:55:42] let me look at the stack [21:55:47] I don't know. [21:55:48] time to merge all the things [21:55:55] TrevorParscal: Quick +2s on https://gerrit.wikimedia.org/r/#/c/179198/ and https://gerrit.wikimedia.org/r/#/c/179186/ from you. [21:55:59] Also presumably it would need overflow: auto; to actually hide the text, but again why the hell height: 0; but not display: none; if the intent is to hide it [21:56:18] MatmaRex: Commit your change for https://phabricator.wikimedia.org/T78085 and we're good? [21:56:18] (03Merged) 10jenkins-bot: [BREAKING CHANGE] Make ve.init.target an OO.ui.Element [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178665 (owner: 10Esanders) [21:56:34] (03PS1) 10Bartosz Dziewoński: MediaWiki theme: Update toolbar design [oojs/ui] - 10https://gerrit.wikimedia.org/r/179221 [21:56:36] James_F: ^ [21:56:41] The text is hidden by opacity:0 - https://github.com/wikimedia/mediawiki-extensions-VisualEditor/blob/master/modules/ve-mw/ui/styles/dialogs/ve.ui.MWTransclusionDialog.css#L55:L61 [21:56:48] :-) [21:56:52] Krenair: wtf [21:57:01] So why isn't it actually being hidden? [21:57:18] That CSS seems to try hard to hide something without actually hiding it [21:57:31] So 1) why not really hide it and 2) why doesn't it work [21:57:32] (03PS2) 10Jforrester: MediaWiki theme: Add thematic border to the bottom of toolbars [oojs/ui] - 10https://gerrit.wikimedia.org/r/179221 (owner: 10Bartosz Dziewoński) [21:57:40] TrevorParscal: And on https://gerrit.wikimedia.org/r/#/c/179221/ please. [21:58:05] hmm [21:58:14] (03CR) 10Trevor Parscal: [C: 032] MediaWiki theme: Add thematic border to the bottom of toolbars [oojs/ui] - 10https://gerrit.wikimedia.org/r/179221 (owner: 10Bartosz Dziewoński) [21:58:15] (03PS5) 10Catrope: Fix target constructors now they generate this.$element [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178670 (owner: 10Esanders) [21:58:24] actually, nevermind. [21:58:50] MatmaRex: yeah, that toolbar commit is good - the mockups we get are hard to follow because they aren't based on current software [21:58:57] or... real software [21:59:24] Or… software. [21:59:25] or anything [21:59:26] :-) [21:59:30] With.. like... boundaries [21:59:42] 3UI-Standardization, MediaWiki-Interface, OOjs-UI: Switch MediaWiki core's use of OOjs UI to use the MediaWiki theme, not Apex - https://phabricator.wikimedia.org/T78054#842882 (10Jdforrester-WMF) [21:59:43] (03CR) 10Trevor Parscal: [C: 032] Don't set line-height of unset button labels [oojs/ui] - 10https://gerrit.wikimedia.org/r/179186 (owner: 10Bartosz Dziewoński) [21:59:44] 3OOjs-UI, VisualEditor: Toolbars should have a heavy shadow on their bottom in the MediaWiki theme - https://phabricator.wikimedia.org/T78085#842880 (10Jdforrester-WMF) 5Open>3Resolved [21:59:49] Contrary to popular belief our software doesn't float in a vast expanse of white [21:59:56] (03PS4) 10Trevor Parscal: MediaWiki theme: Extract @active-color variable [oojs/ui] - 10https://gerrit.wikimedia.org/r/179199 (owner: 10Bartosz Dziewoński) [22:00:00] Instead it's down-to-earth [22:00:13] 3UI-Standardization, MediaWiki-Interface, OOjs-UI: Switch MediaWiki core's use of OOjs UI to use the MediaWiki theme, not Apex - https://phabricator.wikimedia.org/T78054#834496 (10Jdforrester-WMF) [22:00:14] 3OOjs-UI: ButtonGroupWidget in demo pooped in MediaWiki theme - https://phabricator.wikimedia.org/T78326#842883 (10Jdforrester-WMF) 5Open>3Resolved [22:00:22] James_F, am I supposed to do something ot see the new template? [22:00:29] RoanKattouw: Which Earth are you on that's a soft grey? [22:00:37] mooeypoo: New template? [22:00:40] (03CR) 10Trevor Parscal: [C: 032] MediaWiki theme: Extract @active-color variable [oojs/ui] - 10https://gerrit.wikimedia.org/r/179199 (owner: 10Bartosz Dziewoński) [22:00:41] The one that's flooded with rain water [22:00:50] Touché. [22:00:59] (03Merged) 10jenkins-bot: MediaWiki theme: Add thematic border to the bottom of toolbars [oojs/ui] - 10https://gerrit.wikimedia.org/r/179221 (owner: 10Bartosz Dziewoński) [22:01:01] (03CR) 10jenkins-bot: [V: 04-1] Fix target constructors now they generate this.$element [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178670 (owner: 10Esanders) [22:01:08] (03PS6) 10Catrope: Update VE core submodule to master (9ac8136) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178670 (owner: 10Esanders) [22:01:25] James_F, I updated master and can't see this to fix it https://phabricator.wikimedia.org/T78050 [22:01:43] mooeypoo: You mean the new theme? [22:01:47] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (9ac8136) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178670 (owner: 10Esanders) [22:01:51] (03CR) 10Trevor Parscal: [C: 032] MediaWiki theme: Copy .theme-oo-ui-outline{Controls,Option}Widget from Apex [oojs/ui] - 10https://gerrit.wikimedia.org/r/179198 (owner: 10Bartosz Dziewoński) [22:01:55] mooeypoo: I can give a screenshot for the Apex theme too; it's the same. [22:01:59] yes... what did I say?... oh. ha. I said template. Sorry, yes. Theme [22:02:07] RoanKattouw, https://gerrit.wikimedia.org/r/#/c/116902/11/modules/ve-mw/ui/styles/ve.ui.MWDialog.css [22:02:08] (03PS1) 10Divec: Native backspace and delete [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179223 [22:02:12] James_F, how do I replace it in VE so I can see it? [22:02:15] mooeypoo: Click http://en.wikipedia.beta.wmflabs.org/wiki/User:Jdforrester_(WMF)/Sandbox?veaction=edit and insert an image. [22:02:24] mooeypoo: Ignore the theme stuff; it's not theme-specific. [22:02:37] Krenair: OK then you should ask TrevorParscal why the hell he did that. But maybe not today [22:02:42] :) [22:02:48] (03CR) 10Trevor Parscal: [C: 032] Element.getClosestScrollableContainer: Use 'body' or 'documentElement' based on browser (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/176666 (owner: 10Prtksxna) [22:02:53] :-) [22:03:35] (03Merged) 10jenkins-bot: Don't set line-height of unset button labels [oojs/ui] - 10https://gerrit.wikimedia.org/r/179186 (owner: 10Bartosz Dziewoński) [22:03:37] (03CR) 10Trevor Parscal: [C: 032] Give non-isolated windows a tabIndex for selection holding [oojs/ui] - 10https://gerrit.wikimedia.org/r/179125 (owner: 10Esanders) [22:03:45] 3OOjs-UI: Scrolling elements into view does not work in most cases - https://phabricator.wikimedia.org/T73609#842905 (10Jdforrester-WMF) 5Open>3Resolved [22:03:56] (03Merged) 10jenkins-bot: Update VE core submodule to master (9ac8136) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178670 (owner: 10Esanders) [22:04:06] Krenair: what's up? can I help? [22:04:24] TrevorParscal, nothing particularly important [22:04:54] Krenair: the opacity thing [22:05:00] it seems you wrote some css to hide the template page label in single transclusion dialogs [22:05:00] yeah that [22:05:03] it's transitioned just a few lines above [22:05:16] that makes the label fade in and out instead of just appearing/dissapearing [22:05:23] transition: all ... [22:05:38] that make sense? [22:05:49] Aaah [22:05:51] i haven't worked on this in a while [22:05:51] Yeah that makes sense [22:05:54] cool [22:06:09] We were scratching our heads about why you applied every property under the sun EXCEPT display: none; [22:06:13] But that makes perfect sense now [22:06:18] lol [22:06:20] So why does it still take up room? [22:06:27] Okay, so we just need to make it take up no room then [22:06:29] yeah, maybe a comment would have gone a long way [22:06:30] (03CR) 10jenkins-bot: [V: 04-1] Native backspace and delete [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179223 (owner: 10Divec) [22:06:33] (03Merged) 10jenkins-bot: MediaWiki theme: Copy .theme-oo-ui-outline{Controls,Option}Widget from Apex [oojs/ui] - 10https://gerrit.wikimedia.org/r/179198 (owner: 10Bartosz Dziewoński) [22:07:01] James_F: well, we are also transitioning the height [22:07:02] (03Merged) 10jenkins-bot: MediaWiki theme: Extract @active-color variable [oojs/ui] - 10https://gerrit.wikimedia.org/r/179199 (owner: 10Bartosz Dziewoński) [22:07:06] (03Merged) 10jenkins-bot: Element.getClosestScrollableContainer: Use 'body' or 'documentElement' based on browser [oojs/ui] - 10https://gerrit.wikimedia.org/r/176666 (owner: 10Prtksxna) [22:07:25] TrevorParscal: But to 0? [22:07:36] yes [22:07:39] mooeypoo: What's outstanding on https://gerrit.wikimedia.org/r/#/c/175568/ (though see edsanders|away's code review – are you just waiting for CR from Trevor?). [22:07:41] https://gerrit.wikimedia.org/r/#/c/116902/11/modules/ve-mw/ui/styles/ve.ui.MWDialog.css [22:08:00] mooeypoo: sorry, I haven't really given you enough time lately [22:08:39] (03Merged) 10jenkins-bot: Give non-isolated windows a tabIndex for selection holding [oojs/ui] - 10https://gerrit.wikimedia.org/r/179125 (owner: 10Esanders) [22:08:59] hmm, i should probably review that TD thing now [22:09:14] James_F, for the moment this was a general direction commit, I was waiting to talk to trevor about it. It's not so urgent; it would allow us to make the TemplateData dialog show the language dropdown with the button on the same line rather than below. We can have that in the second stage of the TemplateData dialog, assuming it will be merged soon [22:09:31] https://gerrit.wikimedia.org/r/#/c/175568 probably needs to use table layout or something to safely place the input and button on the same line [22:09:52] mooeypoo: OK, sure. [22:10:02] Ha, there's CR for you. :-) [22:10:10] I don't understand how it can have height:0; and still take up room :/ [22:10:27] Krenair: padding? [22:10:33] Krenair: Magic! aka Browsers! [22:10:34] depends on the box sizing [22:10:43] padding:0 [22:10:44] margins [22:10:49] margin:0 as well [22:11:07] eh this fix is annoying'er than I anticipated. The image results container is not centered properly and the size of it is not available on construction. [22:11:10] 3OOjs-UI, VisualEditor, VisualEditor-MediaWiki: Vertical height of panel controls is too low in MediaWiki theme - https://phabricator.wikimedia.org/T78031#842914 (10Jdforrester-WMF) 5Open>3Resolved [22:11:11]