[00:00:20] <RoanKattouw>	 oooooh crap
[00:00:23] <RoanKattouw>	 But hold on
[00:00:23] <TrevorParscal>	 ?
[00:00:29] <RoanKattouw>	 No I have to revert Timo's change
[00:00:34] <RoanKattouw>	 Think about after the window is fully set up
[00:00:40] <TrevorParscal>	 that's what I was trying to tell you
[00:00:42] <RoanKattouw>	 this.$ is now a $ function bound to the inner document
[00:00:57] <RoanKattouw>	 So now this.$.context is a document again but it's not the same document as this.$element's
[00:01:21] <TrevorParscal>	 basically, i had all the plates spinning, and you guys came through with a baseball bat
[00:01:42] <RoanKattouw>	 haha
[00:03:27] <TrevorParscal>	 what's going on here? https://gerrit.wikimedia.org/r/#/c/179324/ firefox won't start now my crap gets -1?
[00:05:00] <grrrit-wm>	 (03PS1) 10Catrope: Revert 370b375: don't use this.$.context in getElementDocument() [oojs/ui] - 10https://gerrit.wikimedia.org/r/179346 
[00:06:39] <RoanKattouw>	 Jenkins breaking for the seventeen hundredth time?
[00:08:53] <RoanKattouw>	 TrevorParscal: I fail to comprehend that change
[00:09:16] <RoanKattouw>	 First of all, why mention both #eee and #eeeeee in the same commit msg, they're equivalent ways to write the same color
[00:09:38] <RoanKattouw>	 Second of all, where are selected non-hovered tools set to #eee?
[00:09:41] <RoanKattouw>	 I guess that's somewhere else?
[00:10:25] <RoanKattouw>	 Zeroth of all, WTF is up with .foo, .foo:hover { rule }; ?
[00:10:35] <RoanKattouw>	 That's useless by definition
[00:10:52] <RoanKattouw>	 Anything that matches .foo:hover also matches .foo, unless you have some really scary specificity overrides going on
[00:10:52] <TrevorParscal>	 the extra :hover is to overpower the previous :hover rule and make it dark when you click down
[00:11:06] <RoanKattouw>	 Oh I see
[00:11:13] <TrevorParscal>	 as for #eee vs #eeeeee... I just work here
[00:11:17] <RoanKattouw>	 lol
[00:11:17] <TrevorParscal>	 :)
[00:11:23] <TrevorParscal>	 i don't know it's not ideal
[00:11:28] <RoanKattouw>	 Whatever, that's fine
[00:11:32] <TrevorParscal>	 I'm not in a very exacting mood I guess
[00:11:33] <RoanKattouw>	 Consistency with #d0d0d0;
[00:11:49] <TrevorParscal>	 yeah... and other uses of #eeeeee in the file
[00:12:36] <RoanKattouw>	 Oh and now I understand the transition you're talking about
[00:12:59] <RoanKattouw>	 Selected: #eee -> #d0d0d0 confused me because I didn't see where the initial state was, but in that case the initial state is enabled:hover
[00:13:05] <RoanKattouw>	 OK this is fine
[00:13:11] <MatmaRex>	 you guys are more and more hilarious with each minute, just thought you should know.
[00:13:11] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] Revert 370b375: don't use this.$.context in getElementDocument() [oojs/ui] - 10https://gerrit.wikimedia.org/r/179346 (owner: 10Catrope)
[00:13:16] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] MediaWiki theme: Add hover state to listToolGroup [oojs/ui] - 10https://gerrit.wikimedia.org/r/179324 (owner: 10Trevor Parscal)
[00:13:47] <wikibugs>	 3VisualEditor-MediaWiki, VisualEditor, Parsoid: Editing a specific article at pl.wp truncates category name - https://phabricator.wikimedia.org/T76353#843135 (10Arlolra) Yup, rt is looking good http://localhost:8000/_rt/plwiki/Lamborghini?oldid=41225226  Still discussing if we can do better on similar wikitext i...
[00:13:48] <TrevorParscal>	 now I can test 179343...
[00:14:16] <TrevorParscal>	 MatmaRex: i'm glad you are having some kind of fun
[00:14:23] <wikibugs>	 3VisualEditor-MediaWiki-Media, VisualEditor-MediaWiki-References, VisualEditor: In the media adding dialog, LTR direction is forced on the description field even in RTL wikis - https://phabricator.wikimedia.org/T71969#738779 (10Amire80) Thank you!
[00:14:31] <TrevorParscal>	 I've been drowning you in tasks for weeks
[00:16:27] <MatmaRex>	 heh :)
[00:20:01] <grrrit-wm>	 (03Merged) 10jenkins-bot: Revert 370b375: don't use this.$.context in getElementDocument() [oojs/ui] - 10https://gerrit.wikimedia.org/r/179346 (owner: 10Catrope)
[00:20:19] <grrrit-wm>	 (03Merged) 10jenkins-bot: MediaWiki theme: Add hover state to listToolGroup [oojs/ui] - 10https://gerrit.wikimedia.org/r/179324 (owner: 10Trevor Parscal)
[00:22:04] <grrrit-wm>	 (03PS1) 10Trevor Parscal: Improve search widget styling in MediaWiki theme [oojs/ui] - 10https://gerrit.wikimedia.org/r/179355 
[00:24:05] <grrrit-wm>	 (03PS2) 10Trevor Parscal: Improve search widget styling in MediaWiki theme [oojs/ui] - 10https://gerrit.wikimedia.org/r/179355 
[00:24:17] <TrevorParscal>	 gotta help with blaise
[00:24:20] <TrevorParscal>	 be back later
[00:42:47] <grrrit-wm>	 (03PS1) 10Divec: Convenience cmpDocumentOrder method [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179361 
[00:43:53] <grrrit-wm>	 (03PS2) 10Divec: Convenience cmpDocumentOrder method [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179361 
[00:44:06] <grrrit-wm>	 (03PS5) 10Divec: Wrap inline images in a span ce=false [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178904 
[00:44:23] <grrrit-wm>	 (03PS3) 10Jforrester: Improve search widget styling in MediaWiki theme [oojs/ui] - 10https://gerrit.wikimedia.org/r/179355 (owner: 10Trevor Parscal)
[00:44:35] <James_F>	 Hey.
[00:44:37] <grrrit-wm>	 (03PS4) 10Jforrester: MediaWiki theme: Improve search widget styling [oojs/ui] - 10https://gerrit.wikimedia.org/r/179355 (owner: 10Trevor Parscal)
[00:44:37] * James_F is back.
[00:49:38] <grrrit-wm>	 (03PS11) 10Divec: WIP: Native leftarrow and rightarrow [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177946 
[00:56:56] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP: Native leftarrow and rightarrow [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177946 (owner: 10Divec)
[01:00:33] <wikibugs>	 3OOjs-UI, VisualEditor, VisualEditor-MediaWiki: Parameter "add more information" field floats very oddly in the transclusion dialog in VisualEditor when using the OOUI MediaWiki theme - https://phabricator.wikimedia.org/T78034#843251 (10Jdforrester-WMF) With the "Improve search widget styling" patch, this looks...
[01:02:06] <grrrit-wm>	 (03CR) 10Jforrester: [C: 031] "Updated screenshots with this patch at https://phabricator.wikimedia.org/T78034#843251 – note that the "No unused fields" bit still appear" [oojs/ui] - 10https://gerrit.wikimedia.org/r/179355 (owner: 10Trevor Parscal)
[01:08:00] <wikibugs>	 3OOjs-UI, VisualEditor: MediaWiki theme: A SurfaceWidget should have the Blue Bar Of Activity applied to is when active - https://phabricator.wikimedia.org/T78358#843255 (10Jdforrester-WMF) 3NEW
[01:13:34] <grrrit-wm>	 (03CR) 10Catrope: "- In VE core, the link inspector is too tall; does not affect VE-MW" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178918 (owner: 10Esanders)
[01:17:53] <grrrit-wm>	 (03CR) 10Catrope: WIP Death to isolation (033 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178918 (owner: 10Esanders)
[01:18:04] <grrrit-wm>	 (03CR) 10Catrope: "Looks like the Escape thing is an existing bug, I'm on that." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178918 (owner: 10Esanders)
[01:20:44] <wikibugs>	 3OOjs-UI, VisualEditor, VisualEditor-MediaWiki-Templates, VisualEditor-MediaWiki: Vertical alignment of the "add template" button and the search box is incorrect in template dialog in VisualEditor when using the OOjs UI MediaWiki theme - https://phabricator.wikimedia.org/T78052#843270 (10Jdforrester-WMF) Above p...
[01:20:48] <wikibugs>	 3OOjs-UI, VisualEditor, VisualEditor-MediaWiki: Vertical alignment of text in the search-and-replace field is off in VisualEditor when using the OOjs UI MediaWiki theme - https://phabricator.wikimedia.org/T78041#843271 (10Jdforrester-WMF) Above patch doesn't seem to fix the issue at hand:  {F20931}
[01:21:19] <grrrit-wm>	 (03CR) 10Jforrester: "CR on the tasks with bonus screenshots. :-) TL;DR: T78052 fixed by PS1, but T78041 isn't." [oojs/ui] - 10https://gerrit.wikimedia.org/r/179339 (owner: 10Bartosz Dziewoński)
[01:27:05] <wikibugs>	 3VisualEditor, VisualEditor-EditingTools: Pressing Escape while a dialog is open closes the editor, should only close the dialog - https://phabricator.wikimedia.org/T78201#843287 (10Jdforrester-WMF) a:3Catrope
[01:27:39] <wikibugs>	 3VisualEditor-MediaWiki, VisualEditor, VisualEditor-EditingTools: [Regression wmf11] Pressing Escape while a dialog is open closes the editor, should only close the dialog - https://phabricator.wikimedia.org/T78201#843289 (10Jdforrester-WMF)
[01:28:59] <wikibugs>	 3VisualEditor-Performance, VisualEditor, VisualEditor-MediaWiki-Media: Combine (or defer until needed?) imageinfo requests on load - https://phabricator.wikimedia.org/T75822#843291 (10Jdforrester-WMF)
[01:29:11] <grrrit-wm>	 (03Abandoned) 10Divec: Wrap inline images in a span ce=false [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178904 (owner: 10Divec)
[01:30:21] <wikibugs>	 3VisualEditor-MediaWiki, VisualEditor, VisualEditor-EditingTools: [Regression wmf11] Pressing Escape while a dialog is open closes the editor, should only close the dialog - https://phabricator.wikimedia.org/T78201#843295 (10Catrope) This is only reproducible if you make no changes. In that case Escape immediate...
[01:33:08] <RoanKattouw>	 Ugh
[01:33:20] <RoanKattouw>	 I have a fix for that bug and with Ed's unisolation commit it would have been sufficient
[01:33:22] <RoanKattouw>	 But now it's not
[01:33:31] <RoanKattouw>	 SOMEHOW the escape keypress is propagating through documents?
[01:33:33] <RoanKattouw>	 This shit is scary
[01:46:57] <RoanKattouw>	 OH WOW
[01:47:18] <RoanKattouw>	 So edsanders|away created ve.init.Target.prototype.onDocumentKeyDown, not realizing that there was already a ve.init.mw.Target.prototype.onDocumentKeyDown
[01:47:38] <RoanKattouw>	 So every time Ed's code thinks it's calling trigger handler stuff, it's really calling Alex's escape code
[02:03:05] <grrrit-wm>	 (03PS1) 10Catrope: Factor out event handler binding in ve.init.Target [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179383 
[02:05:17] <grrrit-wm>	 (03PS12) 10Divec: Native leftarrow and rightarrow [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177946 
[02:05:22] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Factor out event handler binding in ve.init.Target [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179383 (owner: 10Catrope)
[02:07:58] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Native leftarrow and rightarrow [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177946 (owner: 10Divec)
[02:09:35] <grrrit-wm>	 (03PS13) 10Divec: Native leftarrow and rightarrow [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177946 
[02:11:34] <grrrit-wm>	 (03PS2) 10Catrope: Factor out event handler binding in ve.init.Target [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179383 
[02:11:36] <grrrit-wm>	 (03PS1) 10Catrope: Move ve.init.Target#destroy to a place where it actually ends up existing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179386 
[02:15:28] <grrrit-wm>	 (03PS3) 10Catrope: Factor out event handler binding in ve.init.Target [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179383 
[02:17:49] <grrrit-wm>	 (03PS14) 10Divec: Native leftarrow and rightarrow [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177946 
[02:20:01] <grrrit-wm>	 (03PS1) 10Catrope: VE-MW fix commit for I4efbae614e [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/179387 
[02:24:16] <grrrit-wm>	 (03PS15) 10Divec: Native leftarrow and rightarrow [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177946 
[02:27:58] <wikibugs>	 3MediaWiki-Page-editing, MediaWiki-Core-Team: ipblocks query from EditPage unconditionally goes to master - https://phabricator.wikimedia.org/T51419#843344 (10RobLa-WMF)
[02:28:45] <grrrit-wm>	 (03PS16) 10Divec: Native leftarrow and rightarrow [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177946 
[02:40:51] <TrevorParscal>	 howdy
[02:42:30] <James_F>	 Hey TrevorParscal.
[02:42:38] <TrevorParscal>	 hi
[02:42:50] <TrevorParscal>	 so, my internet at home is still down, but cell phone works
[02:42:53] <TrevorParscal>	 still
[02:42:58] <TrevorParscal>	 so that's positive
[02:43:10] <RoanKattouw>	 Allegedly my house has power again
[02:43:12] <James_F>	 TrevorParscal: Fun.
[02:43:20] <RoanKattouw>	 Or so the PG&E web site says
[02:43:37] <RoanKattouw>	 Haven't gone back there yet. Power went down this morning at 7:20
[02:44:08] <grrrit-wm>	 (03CR) 10Jforrester: [C: 031] "AFAICT, this works correctly (for RTL values of "correctly") and without incident, in VE-core and VE-MW both. Nice." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177946 (owner: 10Divec)
[02:45:32] <TrevorParscal>	 James_F: ok, so what shall I look at
[02:45:32] <TrevorParscal>	 ?
[02:45:39] <James_F>	 Looking.
[02:46:57] <James_F>	 TrevorParscal: Code is https://gerrit.wikimedia.org/r/#/c/179355/ – updated screenshots at https://phabricator.wikimedia.org/T78034#843251
[02:47:21] <grrrit-wm>	 (03PS1) 10Catrope: When Esc is pressed, don't close VE if a window is open [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/179388 
[02:47:44] <grrrit-wm>	 (03PS2) 10Jforrester: [WIP] Apex theme: Fix box-sizing for inputs [oojs/ui] - 10https://gerrit.wikimedia.org/r/179343 (owner: 10Trevor Parscal)
[02:48:26] <grrrit-wm>	 (03PS1) 10Catrope: Add getter for toolbarDialogs in ve.ui.Surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179390 
[02:49:21] <grrrit-wm>	 (03PS1) 10Catrope: Use getToolbarDialogs() from VE core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/179391 
[02:51:21] <grrrit-wm>	 (03CR) 10Jforrester: [C: 04-1] "Method naming is contra-spec. Otherwise good." (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179361 (owner: 10Divec)
[02:53:00] <TrevorParscal>	 James_F: ok, so I have a patch I'm working on, but i have to help get kids in bed and stuff
[02:53:12] <TrevorParscal>	 So, we will tie this up in the morning
[02:53:20] <TrevorParscal>	 between standup and my wall of meetings
[02:53:33] <James_F>	 TrevorParscal: Sounds fun. :-)
[02:53:39] <TrevorParscal>	 ok, cya tomorrow
[02:53:43] <James_F>	 See you!
[02:55:42] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [WIP] Apex theme: Fix box-sizing for inputs [oojs/ui] - 10https://gerrit.wikimedia.org/r/179343 (owner: 10Trevor Parscal)
[02:56:09] <Krinkle>	 RoanKattouw: The fact that this.$ and/or this.$element can change seems undesirable though. That means 1) it's contructing an element only to discard it, either Element is too limiting, or a subclass is too demanding, 2) All classes in between will be using the wrong $element and this.$ up to a certain point in their constructor.
[02:56:36] <Krinkle>	 It's a constructor argument. Can't change it afterwards. Shouldn't rather.
[02:56:42] <James_F>	 Krinkle: Sure, but we should fix it first before rolling out the break.
[02:56:48] <Krinkle>	 Yeah, totally.
[02:57:08] <James_F>	 I grumbled to RoanKattouw that really we didn't want to revert, but "unmerge and put back to in-review".
[02:58:00] <Krinkle>	 Yeah, to be merged after we fix the weird usage that's breaking it.
[02:58:06] <Krinkle>	 or figure out some other way.
[02:58:15] <Krinkle>	 I bet this is causing other bugs we have yet to associate with it.
[02:58:25] <Krinkle>	 or perf at the very least / cleanliness.
[02:58:26] <RoanKattouw>	 So the weird usage is in Window
[02:58:37] * James_F nods
[02:58:39] <Krinkle>	 RoanKattouw: is it transplanting nodes?
[02:58:40] <RoanKattouw>	 It eventually binds this.$ to the iframe document instead of the outer document
[02:58:48] <Krinkle>	 or just re-creating and discarding it?
[02:59:21] <Krinkle>	 if transplanted, we could support that natively by forbidding use of transplantNode and making it an OO.ui.Element method that updates its own state accordingly.
[02:59:39] <Krinkle>	 forbid of raw use that is, so that the model stays informed.
[03:00:12] <RoanKattouw>	 So, no
[03:00:17] <RoanKattouw>	 this.$element stays in its original document
[03:00:20] <RoanKattouw>	 this.$ is pointed to the new one
[03:00:32] <RoanKattouw>	 So this.$.context !== this.$element[0].ownerDocument
[03:01:17] <Krinkle>	 RoanKattouw: Ah, it basically uses one Element to manage two: The host document's wrapper element, and then the utility method to interact with the inner document
[03:01:36] <Krinkle>	 Mm.. 
[03:01:37] <RoanKattouw>	 In the early stage when the dialog isn't set up yet, this.$ = function () { throw new Error( 'Go away' ); } or something, and so this.$.context is undefined, but even after it's done it won't be the same
[03:01:48] <Krinkle>	 yeah
[03:01:52] <RoanKattouw>	 Yeah we used to have Window and Frame
[03:02:04] <RoanKattouw>	 But even then Frame was magical
[03:02:27] <RoanKattouw>	 Because it had this.$element = <iframe> and this.$ = iframe's document
[03:02:34] <Krinkle>	 RoanKattouw: Yeah
[03:02:42] <RoanKattouw>	 But that got confusing in Window because it had to call this.frame.$() a lot
[03:02:46] <Krinkle>	 RoanKattouw: What kind of stuff do we do with the frame's this.$ ?
[03:03:12] <RoanKattouw>	 Almost all subclasses use it exclusively
[03:03:22] <Krinkle>	 Right
[03:03:24] <RoanKattouw>	 Think about it, things like ve.ui.MWReferenceDialog indirectly extend Window
[03:03:24] <grrrit-wm>	 (03PS1) 10Divec: Rename method cmpOffsetPaths to compareOffsetPaths [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179393 
[03:03:29] <Krinkle>	 because Dialog is a Window/Fraw
[03:03:32] <Krinkle>	 Frame*
[03:03:38] <Krinkle>	 it's not an element inside a Frame
[03:03:41] <RoanKattouw>	 Previously they had to know to use this.frame.$() to create things whereas every other class uses this.$()
[03:03:51] <Krinkle>	 Yeah, that's also wrong
[03:03:52] <RoanKattouw>	 And also they had to do things like this.fooWidget = new FooWidget( { $: this.frame.$ } );
[03:03:56] <grrrit-wm>	 (03PS2) 10Jforrester: [BREAKING CHANGE] Rename method cmpOffsetPaths to compareOffsetPaths [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179393 (owner: 10Divec)
[03:04:00] <Krinkle>	 because they shouldn't have to know
[03:04:03] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] [BREAKING CHANGE] Rename method cmpOffsetPaths to compareOffsetPaths [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179393 (owner: 10Divec)
[03:04:05] <RoanKattouw>	 I mean it's more correct from a pedantic standpoint
[03:04:11] <RoanKattouw>	 But exactly, it's a horrible implementation detail
[03:04:13] <RoanKattouw>	 The good news is
[03:04:27] <RoanKattouw>	 Ed has a WIP that works pretty well that sets all WindowManagers in VE to isolate: false
[03:04:46] <RoanKattouw>	 Once that has been in VE for a while, we are going to remove the isolate (iframe) feature from Window / WindowManager
[03:04:52] <Krinkle>	 RoanKattouw: So... makes sense that we have separate elements. I mean. the Dialog could be an exclusive <div> child of iframe's <body> (instead of essentially pretending to be iframe's <html>)
[03:04:57] <RoanKattouw>	 And once that's done, we're going to deprecate this.$ and config.$
[03:05:21] <Krinkle>	 RoanKattouw: Hm.. but don't we already can haz dialogs without frames?
[03:05:22] <RoanKattouw>	 (keeping them around for b/c but basically we'll say "you should always use the main document, if you choose to use iframes we have no pity for you")
[03:05:26] <RoanKattouw>	 Dialogs yes
[03:05:30] <RoanKattouw>	 But inspectors are isolated stil
[03:05:36] <RoanKattouw>	 As are toolbar dialogs (find an dreplace)
[03:05:37] <grrrit-wm>	 (03PS3) 10Divec: Convenience compareDocumentOrder method [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179361 
[03:05:37] <Krinkle>	 So Dialog doesn't inherit from Frame/Window then
[03:05:42] * Krinkle looks at code
[03:05:47] <grrrit-wm>	 (03PS4) 10Jforrester: Convenience compareDocumentOrder method [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179361 (owner: 10Divec)
[03:06:03] <RoanKattouw>	 No, the Dialog's $element is a <div> *around* the <iframe>
[03:06:17] <RoanKattouw>	 Even when Dialog and Frame were still split, that was the case, Dialog contained Frame
[03:06:36] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Convenience compareDocumentOrder method [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179361 (owner: 10Divec)
[03:06:40] <RoanKattouw>	 ( s/Dialog/Window/ , it's also generally true)
[03:06:56] <RoanKattouw>	 No Dialog inherits Window, as does Inspector
[03:07:07] <RoanKattouw>	 But a WindowSet can be configured to either be isolating (using iframes) or not
[03:07:32] <Krinkle>	 WindowManager apparantly.
[03:07:34] <Krinkle>	 renamed
[03:07:40] <RoanKattouw>	 Sorry yes
[03:07:41] <RoanKattouw>	 WindowManager
[03:07:45] <RoanKattouw>	 (I said it right earlier! :P )
[03:08:40] <Krinkle>	 RoanKattouw: OK, so the dirt is in OO.ui.Window.prototype.setManager then
[03:08:58] <Krinkle>	 Where reality is being reformed
[03:09:01] <RoanKattouw>	 Yes
[03:09:04] <RoanKattouw>	 Well and again later
[03:09:11] <RoanKattouw>	 In load()
[03:09:16] <RoanKattouw>	 Where this.$ is set to its final value
[03:09:26] <RoanKattouw>	 setManager() just sets it to a temporary value
[03:09:40] <Krinkle>	 And the class fragments between where it might have $frame vs $contents and subclasses have to carefully second guess accessing either by asking again whether it is isolated.
[03:09:47] <Krinkle>	 Separation of concerns is mixed there.
[03:10:02] <Krinkle>	 Yeah
[03:12:12] <grrrit-wm>	 (03Merged) 10jenkins-bot: [BREAKING CHANGE] Rename method cmpOffsetPaths to compareOffsetPaths [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179393 (owner: 10Divec)
[03:12:14] <grrrit-wm>	 (03Merged) 10jenkins-bot: Convenience compareDocumentOrder method [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179361 (owner: 10Divec)
[03:12:34] <Krinkle>	 RoanKattouw: Should a dialog be isolated based on type of dialog or based on type of page? Assuming you'd only have one manager per page. It seems like right now it'll either isolate all or none since the logic is in manager (unless it's a "configuration" option passed when linking dialog to manager and it changes the input)
[03:12:36] <Krinkle>	 oh it does that.
[03:12:57] <RoanKattouw>	 No there are three managers
[03:13:05] <RoanKattouw>	 One for dialogs, one for inspectors, one for toolbar dialogs
[03:13:17] <Krinkle>	 sure usre
[03:13:18] <Krinkle>	 sure sure
[03:13:21] <RoanKattouw>	 Because the DOM location of the manager's $element is important, and it needs to be different for all three
[03:13:29] <RoanKattouw>	 (also modality is a property of the manager)
[03:14:10] <Krinkle>	 What's a toolbar dialog again?
[03:14:19] <RoanKattouw>	 Find&replace
[03:14:24] <RoanKattouw>	 It's kind of awkwardly named
[03:14:31] <RoanKattouw>	 But it's an OO.ui.Window that's embedded in the toolbar
[03:14:46] <Krinkle>	 And they can't be dialogs like transclusion or media editor because
[03:15:06] <RoanKattouw>	 Ahm
[03:15:13] <Krinkle>	 (feel free to defer to later if I'm just behind and this isn't productive)
[03:15:33] <RoanKattouw>	 I think he did that at first but I made him change it, and I forget why?
[03:16:02] <RoanKattouw>	 I mean ToolbarDialog extends Dialog
[03:16:06] <RoanKattouw>	 And just adds size=full and some CSS
[03:16:30] <Krinkle>	 It's not in a different DOM layer?
[03:16:40] <grrrit-wm>	 (03Abandoned) 10Divec: Get CSS directionality from selected node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179203 (owner: 10Divec)
[03:16:45] <RoanKattouw>	 Yes it has its own WindowManager
[03:16:51] <RoanKattouw>	 Which unsurprisingly is inside the toolbar, DOM-wise
[03:17:30] <Krinkle>	 RoanKattouw: Is there some advantage to it being a child of toolbar instead of global or surface?
[03:17:48] <RoanKattouw>	 Visually it grows the toolbar
[03:17:50] <Krinkle>	 wait, surface overlays, is that this one
[03:17:52] <RoanKattouw>	 The toolbar border goes around it
[03:17:54] <Krinkle>	 Oh, right.
[03:17:58] <Krinkle>	 ...
[03:18:12] <RoanKattouw>	 and background and stuff
[03:18:16] <Krinkle>	 OK. I think we might benefit from rethinking this model. There's gotta be an easier way.
[03:18:18] <RoanKattouw>	 And it floats along with it
[03:18:33] <RoanKattouw>	 What model? Window types? Things inside the toolbar?
[03:18:51] <RoanKattouw>	 As for the original thing we started talking about, the this.$ problems will be a thing of the past once isolation and iframes are killed in a big fire
[03:19:04] <Krinkle>	 I know it because I was involved with it enough in the begin to understand it still (though lost track more than I wanted, my bad) - but I can tell I can't justify it to myself.
[03:19:27] <Krinkle>	 it, being the reason why there's three managers, $ changes and other dialog related stuff.
[03:19:42] <Krinkle>	 It could just be a matter of documentation, examples and a few minor renames.
[03:19:45] <RoanKattouw>	 OK well
[03:19:49] <Krinkle>	 But right now I can't wrap my head around it.
[03:20:17] <grrrit-wm>	 (03PS17) 10Divec: Native leftarrow and rightarrow [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177946 
[03:20:18] <RoanKattouw>	 Don't worry too much about the $ stuff. It sucks but we're on a path to get rid of that code completely
[03:20:21] <Krinkle>	 I still don't know how to create a simple dialog and make it appear from the browser console without writing way too much code and getting sucked in by weird config options being duplciated and in multiple places.
[03:20:55] <RoanKattouw>	 Krinkle: So very soon, you and I and a few other people will be asked to review a bunch of documentation Kirsten has written
[03:21:00] <RoanKattouw>	 Which AIUI will touch on this as well
[03:21:03] <Krinkle>	 my gut says it's overengineered. Not by design, the design was pretty solid. But it grew out of boundaries.
[03:21:11] <RoanKattouw>	 So in addition to reviewing what she wrote, you might learn from it :)
[03:21:28] <RoanKattouw>	 I won't deny that some shortcuts would be nice, but I don't think it's as overengineered as I think you think it is
[03:21:56] <Krinkle>	 I have questions about that process as well. It feels unusual to have someone else write it. I think it's cool and I'm open to it. Just wanna know exactly how this ties and, responsibilities, benefits, goals etc.
[03:22:02] <RoanKattouw>	 mooeypoo: You might appreciate https://gerrit.wikimedia.org/r/#/c/177946/17/demos/ve/pages/rtl.html
[03:22:05] <Krinkle>	 but not know
[03:22:09] <Krinkle>	 now*
[03:22:19] <RoanKattouw>	 Krinkle: She's been working closely with Trevor, I have faith in that going well
[03:22:36] <RoanKattouw>	 Just having a person who has never seen OOUI before try to write code examples and run them exposed so many problems
[03:22:46] <RoanKattouw>	 You may have noticed Trevor has been renaming and refactoring lots of things recently?
[03:22:57] <RoanKattouw>	 (I mean not that that's necessarily very different from Trevor just being Trevor, but still)
[03:23:02] <Krinkle>	 RoanKattouw: I think I mean a different kind of documentation. I never write manuals or go somewhere other than source code.
[03:23:05] <mooeypoo>	 RoanKattouw, isn't this from David's chrome bug demo?
[03:23:10] <RoanKattouw>	 That's because Kirsten finds inconsistencies and bugs faster than we can fix them
[03:23:13] <Krinkle>	 My standard is that I can use code by looking it at it, no matter how complex.
[03:23:20] <RoanKattouw>	 Right
[03:23:21] <Krinkle>	 So far I've never failed to reach that.
[03:23:24] <James_F>	 RoanKattouw: http://living-style-guide.wmflabs.org/wiki/Main_Page
[03:23:28] <RoanKattouw>	 Well I think 40,000ft documentation is valuable
[03:23:32] <Krinkle>	 Absolutely
[03:23:37] <RoanKattouw>	 And necessary for a complex code base like this
[03:23:42] <Krinkle>	 but I shouldn't need to read that just because I've been out of it for a few months.
[03:23:43] <RoanKattouw>	 I mean, the jsduck docs should absolutely be better
[03:23:46] <James_F>	 <ooui-demo type="TextInput">
[03:23:46] <James_F>	 { 
[03:23:46] <James_F>	         "value": "Text input",
[03:23:46] <RoanKattouw>	 Especially the class-level docs
[03:23:48] <James_F>	         "label": "basic textInput" 
[03:23:50] <James_F>	 }
[03:23:52] <James_F>	 </ooui-demo>
[03:23:54] <James_F>	 Very neat. :-)
[03:24:11] <RoanKattouw>	 Krinkle: Well the thing with the three (until recently two) WindowSets has been around for ages
[03:24:21] <RoanKattouw>	 As has the this.$ munging
[03:24:36] <RoanKattouw>	 I think it's just a corner of OOUI you haven't had the misfortune of poking around in too much
[03:24:39] <Krinkle>	 RoanKattouw: Yeah. I know the 40,000ft already. But my questions are more around invididual use cases. Once you're past the upstart phase and looking into methods that you'll be using. that part is lacking.
[03:24:51] <RoanKattouw>	 mooeypoo: It's from the demo for his commit that does native cursoring :)
[03:24:51] <Krinkle>	 RoanKattouw: And yet.. I had to ask.
[03:25:03] <Krinkle>	 RoanKattouw: Yeah, absolutely.
[03:25:10] <Krinkle>	 And I regret that.
[03:25:11] <RoanKattouw>	 Right
[03:25:14] <mooeypoo>	 RoanKattouw, but he posted a bug report about this and how the native cursoring in chrome doesn't work... 
[03:25:25] <mooeypoo>	 Though I'm pretty amused he uses Yiddish
[03:25:32] <RoanKattouw>	 Well for windows and stuff there's a 10,000ft view, that perhaps belongs in the class documentation comment for Window
[03:25:50] <RoanKattouw>	 Krinkle: Don't regret not knowing things about iframes, I can tell you that
[03:25:59] <RoanKattouw>	 I know too much about that tar bit of doom
[03:26:14] <RoanKattouw>	 mooeypoo: It works better now that he's working around somethings
[03:26:26] <Krinkle>	 I'll try better first. At this point I feel like blaming the code because I don't immediately know everything about it. It might be that if I read through it a bit more, I'll understand and make sense of it.
[03:26:26] <RoanKattouw>	 But he also said that "This change exposes certain browser quirks relating to cursoring." in the commit summary was a gross understatemnt
[03:27:02] <RoanKattouw>	 Krinkle: Once you do figure it out, you would be a good person to identify what should bedocumented and where those docs should go
[03:27:11] <Krinkle>	 :)
[03:27:38] <mooeypoo>	 RoanKattouw, ... yes. Though as you said a few days ago, we RTLers seem to have a knack for finding excuses for working around bad browser behavior. I believe you called it a Stockholm syndrome.
[03:27:39] <Krinkle>	 RoanKattouw: Last time I did was when we created the dialogs demo. and it led to a minor rewrite.
[03:27:39] <mooeypoo>	 :D
[03:28:40] <Krinkle>	 It's what I do when somethig isn't super high priority, and thus I can allow my recursive perfection to get distracted and get the underground household in order to make that other thing easier (e.g. creating a demo, not liking how the demo is written, so working backwrads to make it nicer)
[03:29:09] <Krinkle>	 But... qunit and RL hackery first
[03:30:13] <Krinkle>	 RoanKattouw: So, I've thought about it for a day while doing other things. I can't think of a better way to do what I did in core for that. So I think it's OK now for you to take a look at. Right now there's an obvious bug that makes it fail for anywhere other than my machine which I'll fix my morning and then I'll unWIP it and send it your way
[03:31:31] <Krinkle>	 While I'd love to hear a better way, I suspect it might be a case where we're gonna have to accept status quo isn't built for it and we'll do it an ugly way first and refactor later. Though I hate to see it when that happens, and even harder to accept it for myself...
[03:33:49] <grrrit-wm>	 (03CR) 10Krinkle: "If they're only for tests (now identified as such) I guess we don't the other ones as those aren't used? And/remove as needed, and not in " [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174666 (owner: 10Amire80)
[03:41:13] <RoanKattouw>	 Krinkle: OK I will take a look, probably tomorrow
[03:41:20] <RoanKattouw>	 Right now I'm going through native cursoring code with David
[03:42:27] <Krinkle>	 k
[04:02:54] <wikibugs>	 3Apex, OOjs-UI: Use the "Apex" theme in OOjs UI when using the Apex skin - https://phabricator.wikimedia.org/T78367#843490 (10Jdforrester-WMF) 3NEW a:3Jdforrester-WMF
[04:06:28] <wikibugs>	 3MediaWiki-ResourceLoader: Let skins set $wgResourceLoaderSkinScripts for core (and other?) RL modules that have skin-specific scripts - https://phabricator.wikimedia.org/T78368#843502 (10Jdforrester-WMF) 3NEW a:3Jdforrester-WMF
[04:11:32] <Krinkle>	 key = 'jquery2'; key.slice( 0, key.indexOf('@'))
[04:11:35] <Krinkle>	 >> key = 'jquery2'; key.slice( 0, key.indexOf('@'))
[04:11:36] <ecmabot-wm>	 Krinkle: (string) 'jquery'
[04:11:42] <Krinkle>	 Yay
[04:12:13] <James_F>	 Really?
[04:12:13] <James_F>	 Is that a magic function?
[04:12:16] <RoanKattouw>	 Interesting
[04:12:19] <Krinkle>	 -1
[04:12:22] <Krinkle>	 it's obvious
[04:12:22] <RoanKattouw>	 James_F: No it's -1
[04:12:26] <Krinkle>	 :P
[04:12:41] <Krinkle>	 							module = key.slice( 0, key.indexOf( '@' ) );
[04:12:42] <Krinkle>	 							if ( mw.loader.store.getModuleKey( module ) !== key ) {
[04:13:07] <Krinkle>	 Which means if someone inserts an invalid key without an '@' in the cache that has the name of a known module + 1 character, weird shit will happen
[04:13:22] <RoanKattouw>	 OH WOW
[04:13:30] <RoanKattouw>	 HE USES IT AS A MODULE NAME
[04:13:36] <RoanKattouw>	 That's amazing!
[04:14:27] <Krinkle>	 mw.loader.store.stats.expired++;
[04:14:27] <Krinkle>	 								delete mw.loader.store.items[key];
[04:14:37] <Krinkle>	 Meh, not much. It'll just discard the cache
[04:14:44] <Krinkle>	 Which is shooting yourself in the foot.
[04:14:57] <Krinkle>	 on purpose
[04:15:03] <Krinkle>	 Fun :D
[04:15:05] <grrrit-wm>	 (03PS2) 10Jforrester: Update for I32608c7f in OOUI [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178625 (owner: 10Bartosz Dziewoński)
[04:15:10] <grrrit-wm>	 (03PS2) 10Jforrester: Rename some things for my sanity [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178641 (owner: 10Bartosz Dziewoński)
[04:15:41] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Rename some things for my sanity [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178641 (owner: 10Bartosz Dziewoński)
[04:19:24] <wikibugs>	 3MediaWiki-Unit-tests, MediaWiki-ResourceLoader: Add tests for mw.loader.store - https://phabricator.wikimedia.org/T78369#843517 (10Krinkle) 3NEW
[04:20:49] <James_F>	 OK, I'm off.
[04:20:54] * James_F waves.
[04:23:27] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] Native leftarrow and rightarrow (0310 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177946 (owner: 10Divec)
[04:51:07] <grrrit-wm>	 (03PS1) 10Prtksxna: MediaWiki Theme: Add state transition to radio buttons [oojs/ui] - 10https://gerrit.wikimedia.org/r/179404 
[05:22:33] <grrrit-wm>	 (03Abandoned) 10Prtksxna: Add PNG compression grunt task using 'pngmin' [oojs/ui] - 10https://gerrit.wikimedia.org/r/176637 (owner: 10Prtksxna)
[05:23:15] <wikibugs>	 3OOjs-UI: Compress OOjs UI PNGs with pngcrush -brute -reduce - https://phabricator.wikimedia.org/T76148#843597 (10Prtksxna) a:5Prtksxna>3None
[08:55:06] <wikibugs>	 3VisualEditor, Performance-Metrics-Dashboard: VE performance dashboard broken - https://phabricator.wikimedia.org/T78106#843895 (10Qgil) Can @memeht help here? See T78130.
[10:54:57] <wikibugs>	 3VisualEditor: <templatedata> cannot be used as Template Data - https://phabricator.wikimedia.org/T78386#844033 (10guoyunhebrave) 3NEW
[10:55:33] <wikibugs>	 3VisualEditor: <templatedata> cannot be used as Template Data - https://phabricator.wikimedia.org/T78386#844033 (10guoyunhebrave)
[11:32:19] <grrrit-wm>	 (03PS1) 10Mvolz: Bug fix: remove extra Array in scrapeHelper [services/citoid] - 10https://gerrit.wikimedia.org/r/179432 
[11:38:01] <grrrit-wm>	 (03CR) 10Mvolz: [C: 032 V: 032] Bug fix: remove extra Array in scrapeHelper [services/citoid] - 10https://gerrit.wikimedia.org/r/179432 (owner: 10Mvolz)
[11:58:36] <grrrit-wm>	 (03PS1) 10Mvolz: Stop using Mozilla user agent header [services/citoid] - 10https://gerrit.wikimedia.org/r/179435 
[12:00:41] <grrrit-wm>	 (03CR) 10Mvolz: [C: 032 V: 032] Stop using Mozilla user agent header [services/citoid] - 10https://gerrit.wikimedia.org/r/179435 (owner: 10Mvolz)
[13:00:38] <grrrit-wm>	 (03PS1) 10Mvolz: /url endpoint checks for missing POST params [services/citoid] - 10https://gerrit.wikimedia.org/r/179445 
[13:02:14] <grrrit-wm>	 (03CR) 10Mvolz: [C: 032 V: 032] /url endpoint checks for missing POST params [services/citoid] - 10https://gerrit.wikimedia.org/r/179445 (owner: 10Mvolz)
[13:15:55] <grrrit-wm>	 (03PS1) 10Mvolz: Bug fix: Strip PMC prefix from PMCIDs [services/citoid] - 10https://gerrit.wikimedia.org/r/179449 
[13:16:07] <grrrit-wm>	 (03CR) 10Esanders: "Most of those sound like upstream bugs in ooui. Will investigate either way. Bounding rects for text don't include line height, browser bu" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178918 (owner: 10Esanders)
[13:18:24] <grrrit-wm>	 (03CR) 10Mvolz: [C: 032 V: 032] Bug fix: Strip PMC prefix from PMCIDs [services/citoid] - 10https://gerrit.wikimedia.org/r/179449 (owner: 10Mvolz)
[13:34:50] <wikibugs>	 3VisualEditor, VisualEditor-ContentLanguage: VisualEditor: CE eats up syllables except a last syllable of a word in Korean IME - https://phabricator.wikimedia.org/T52631#844224 (10ellif) Helo. It seems that finally most of Korean problems are solved. But one more problem is seen in VE.  In the Windows 7 Chrome 6...
[14:24:45] <grrrit-wm>	 (03PS1) 10Esanders: Temporarily remove position:absolute on body when resizing [oojs/ui] - 10https://gerrit.wikimedia.org/r/179465 
[14:25:13] <grrrit-wm>	 (03CR) 10Esanders: "Upstream inspector height issue: https://gerrit.wikimedia.org/r/#/c/179465/" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178918 (owner: 10Esanders)
[14:42:59] <grrrit-wm>	 (03CR) 10Esanders: WIP Death to isolation (038 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178918 (owner: 10Esanders)
[15:22:26] <wikibugs>	 3VisualEditor: Sequence's should be undoable with a backspace - https://phabricator.wikimedia.org/T78401#844317 (10Esanders) 3NEW
[15:23:17] <grrrit-wm>	 (03PS5) 10Esanders: Death to isolation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178918 
[15:25:40] <grrrit-wm>	 (03PS6) 10Esanders: Death to isolation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178918 
[15:30:49] <Stryn>	 bugzilla links should be changed to Phabricator at https://github.com/wikimedia/mediawiki-extensions-VisualEditor/blob/0130b6b45cdf9cfb4c2e9f871c1f9c1217966823/modules/ve-mw/ui/tools/ve.ui.MWPopupTool.js
[15:46:03] <grrrit-wm>	 (03CR) 10Esanders: [C: 04-2] When Esc is pressed, don't close VE if a window is open (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/179388 (owner: 10Catrope)
[15:50:25] <grrrit-wm>	 (03PS1) 10Esanders: Kill the escape keydown event after handling a window close [oojs/ui] - 10https://gerrit.wikimedia.org/r/179476 
[15:51:49] <Rosencrantz>	 Is there a good way to get VE to preload a template (like what can be done with the Inputbox extension)
[15:58:04] <grrrit-wm>	 (03PS1) 10Esanders: Check for stopped propagation before show close dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/179478 
[16:01:18] <grrrit-wm>	 (03PS1) 10Esanders: Stop propagation of events after handling trigger keys [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179479 
[16:02:15] <grrrit-wm>	 (03Abandoned) 10Esanders: When Esc is pressed, don't close VE if a window is open [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/179388 (owner: 10Catrope)
[16:28:34] <wikibugs>	 3VisualEditor, TemplateData: <templatedata> cannot be used as Template Data - https://phabricator.wikimedia.org/T78386#844387 (10Jdforrester-WMF) http://xuexiii.org/w/%E7%89%B9%E6%AE%8A:%E7%89%88%E6%9C%AC shows that you don't have the #TemplateData extension installed. If you install that (and then make an edit...
[16:29:23] <wikibugs>	 3VisualEditor: Sequence's should be undoable with a backspace - https://phabricator.wikimedia.org/T78401#844390 (10Jdforrester-WMF) He'lp 'I'm st'uck press'''ng 'the a'po'strophe key'.
[16:30:40] <wikibugs>	 3VisualEditor, VisualEditor-EditingTools: Sequences should be undoable with a backspace - https://phabricator.wikimedia.org/T78401#844392 (10Jdforrester-WMF) p:5Triage>3Low
[16:33:25] <marktraceur>	 James_F|Away: <3
[16:39:00] <wikibugs>	 3VisualEditor, TemplateData: <templatedata> cannot be used as Template Data - https://phabricator.wikimedia.org/T78386#844404 (10guoyunhebrave) @Jdforrester-WMF Thanks!
[17:16:38] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: FieldLayout: Synchronise PHP with JS [oojs/ui] - 10https://gerrit.wikimedia.org/r/179491 
[17:23:57] <wikibugs>	 3OOjs-UI, VisualEditor: Scrollbars everywhere in MediaWiki theme - https://phabricator.wikimedia.org/T78178#844443 (10matmarex) a:5TrevorParscal>3matmarex
[17:25:31] <wikibugs>	 3MediaWiki-Page-editing: Show category links above the edit box - https://phabricator.wikimedia.org/T4679#844446 (10Qgil) ... and the patch has been stalled for a year now...   Meanwhile, VisualEditor is on its mission to take over mainstream MediaWiki editing. Interestingly, categories are also out of sight whe...
[17:30:30] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=109890143
[17:30:30] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=109890164
[17:30:30] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=67297114
[17:30:30] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on slwiki: https://sl.wikipedia.org/?diff=4318182
[17:30:30] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on enwiki: https://en.wikipedia.org/?diff=637694922
[17:36:40] <wikibugs>	 3OOjs-UI, VisualEditor, VisualEditor-MediaWiki: Replace and Replace all buttons are clipped in VisualEditor when using the OOjs UI MediaWiki theme - https://phabricator.wikimedia.org/T78042#844468 (10matmarex) The clipping depends on zoom level, so probably Chromium rendering bug.
[17:38:00] <wikibugs>	 3OOjs-UI, VisualEditor: Scrollbars everywhere in MediaWiki theme - https://phabricator.wikimedia.org/T78178#844471 (10matmarex) The template dialog one was probably fixed by e57856beec7fd53927e1392cb3251e8fd876d027 (https://gerrit.wikimedia.org/r/#/c/179198/).
[17:44:01] <wikibugs>	 3VisualEditor, TemplateData: <templatedata> cannot be used as Template Data - https://phabricator.wikimedia.org/T78386#844485 (10Jdforrester-WMF) 5Open>3Resolved a:3Jdforrester-WMF http://xuexiii.org/w/%E7%89%B9%E6%AE%8A:%E7%89%88%E6%9C%AC shows that you don't have the #TemplateData extension installed. If...
[17:44:19] <wikibugs>	 3OOjs-UI, VisualEditor: Disabled scrollbars appear in some PopupWidgets in MediaWiki theme (Page options → Advanced) - https://phabricator.wikimedia.org/T78178#844488 (10matmarex)
[17:47:49] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: [WIP] Don't round() measured sizes [oojs/ui] - 10https://gerrit.wikimedia.org/r/179494 
[17:48:11] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: GridLayout: Don't round to 1% [oojs/ui] - 10https://gerrit.wikimedia.org/r/179495 
[17:49:06] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "This change doesn't seem to fix or break anything. Can anybody tell me why we're doing the rounding?" [oojs/ui] - 10https://gerrit.wikimedia.org/r/179494 (owner: 10Bartosz Dziewoński)
[17:54:15] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: PopupWidget: Remove box-shadow rule that generates invisible shadow [oojs/ui] - 10https://gerrit.wikimedia.org/r/179496 
[18:10:58] <grrrit-wm>	 (03PS26) 10Bartosz Dziewoński: Eventify TemplateDataGenerator and use oojs-ui [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 (owner: 10Mooeypoo)
[18:11:09] <grrrit-wm>	 (03PS27) 10Bartosz Dziewoński: Eventify TemplateDataGenerator and use oojs-ui [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 (owner: 10Mooeypoo)
[18:19:25] <wikibugs>	 3VisualEditor, VisualEditor-EditingTools: [Regression pre-wmf13] Cannot open Basic Reference and Media dialog, TypeError: this.getSurface(...) is undefined appears - https://phabricator.wikimedia.org/T78338#844533 (10Ryasmeen) Verified the fix in Betalabs
[18:19:55] <chrismcmahon>	 ryasmeen: beta labs may still be fairly broken right now
[18:20:36] <chrismcmahon>	 ryasmeen:  in case you see any strange behavior, beta was down most of the morning
[18:21:10] <ryasmeen>	 chrismcmahon:no nothing strange so far, i just started looking at it
[18:22:18] <wikibugs>	 3VisualEditor: [Regression pre-wmf13]TypeError: this.toolbar.getSurface(...) is null appears after saving an edit and then cannot reopen that page next time - https://phabricator.wikimedia.org/T78335#844536 (10Ryasmeen) Verified the fix in Betalabs
[18:22:31] <wikibugs>	 3VisualEditor: [Regression pre-wmf13]TypeError: this.toolbar.getSurface(...) is null appears after saving an edit and then cannot reopen that page next time - https://phabricator.wikimedia.org/T78335#844537 (10Ryasmeen) 5Open>3Resolved
[18:24:49] <mooeypoo>	 wtf... I'm getting "Uncaught TypeError: undefined is not a function" for ".done( ve.bind( function ( data ) { ..." and it works without the ve.bind. Why won't it recognize ve.bind!?
[18:25:37] <RoanKattouw>	 mooeypoo: ve.bind() was removed weeks ago
[18:25:45] <mooeypoo>	 but there's still code using it
[18:25:51] <mooeypoo>	 I remembered something about that, but I checked, and...
[18:25:51] <RoanKattouw>	 Shouldn't be
[18:25:54] <RoanKattouw>	 We removed it all
[18:26:04] <RoanKattouw>	 Unless this code was still pending review at the time
[18:26:39] <mooeypoo>	 hm Damnit, I saw it in visualeditor.js and didn't even notice
[18:26:58] <mooeypoo>	 I remembered we did something but I wanted to verify, and got confused with the results. Lovely.
[18:27:24] <mooeypoo>	 RoanKattouw, okay, so for anonymous methods, do I just use $.proxy ?
[18:27:57] <mooeypoo>	 oo.bind
[18:28:01] <mooeypoo>	 damnit. 
[18:28:07] <RoanKattouw>	 No just .bind()
[18:28:17] <RoanKattouw>	 function () { blah blah }.bind( this );
[18:28:29] <mooeypoo>	 that works if you have a method, what about anonymou-- oh
[18:28:34] <mooeypoo>	 gee you can chain this way?
[18:28:42] <mooeypoo>	 well.. why not, really. Ha.
[18:28:51] <RoanKattouw>	 Yeah :)
[18:29:00] <RoanKattouw>	 For methods it's this.onFoobar.bind( this )
[18:29:13] <mooeypoo>	 yeah that I know
[18:29:24] <mooeypoo>	 the anonymous functions are the confusing part
[18:29:38] <mooeypoo>	 is this better than doing $.proxy() ?
[18:29:49] <mooeypoo>	 for anonymous methods, I mean?
[18:29:53] <RoanKattouw>	 Whether it's better I leave up to Krinkle|detached 
[18:29:56] <RoanKattouw>	 But it's what we do now
[18:30:09] <RoanKattouw>	 You shouldn't find many instances of $.proxy() in our code base any more
[18:31:26] <mooeypoo>	 yeah i just looked.
[18:34:30] <MatmaRex>	 ugh
[18:34:32] <MatmaRex>	 OO.ui.ClippableElement.prototype.clip = function () {
[18:34:33] <MatmaRex>	 …
[18:34:36] <MatmaRex>	 var buffer = 10,
[18:34:51] <MatmaRex>	 nice round number, pity it's too large for MW theme!
[18:39:32] <mooeypoo>	 hmm. TrevorParscal RoanKattouw brainstorming when you get a moment. The detail view of an image (after you click on it in the search results) calls for the resized thumbnail, which is great, *but* it takes noticeable time to appear. Not insane - I count about 1-2 seconds on average, but that's noticeable. I placed a spinner in a div that has the anticipated size of the image in there, so the user can expect this, but ... I dunno, it
[18:39:33] <mooeypoo>	 's noticeable. Is that okay? Should I first display the original previous (small) thumbnail until the new one arrives? that has the potential of being confusing.
[18:41:36] <RoanKattouw>	 I suppose you could display the thumbnail you got before, stretched to the new dimensions, with a spinner on top?
[18:41:39] <RoanKattouw>	 Maybe?
[18:41:43] <mooeypoo>	 wait... I could do this the other way around. When I ask the API for search results, instead of asking for small thumbnails, I can ask for the dialog-fitted ones, and then in the results I'll resize them down...
[18:41:46] <RoanKattouw>	 It'll look kinda hideous
[18:41:52] <RoanKattouw>	 Oh, hah
[18:41:58] <RoanKattouw>	 mooeypoo: If you do that make sure they're nice multiples of each other
[18:42:10] <mooeypoo>	 It will mean the results will all be resized, but the user waits for results anyways, no?
[18:42:13] <RoanKattouw>	 mooeypoo: Also that massively increases the amount of thumbnail data you're downloading
[18:42:19] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: ClippableElement: 7 is a better number than 10 [oojs/ui] - 10https://gerrit.wikimedia.org/r/179510 
[18:42:28] <mooeypoo>	 well, I'm resizing all thumbnails in the search to the same *height*
[18:42:38] <mooeypoo>	 (then I manipulate it to make it fit the rows and all that)
[18:43:16] <mooeypoo>	 so even if we get a larger thumb, they'll still be all the same height in the results. The only downside here is that we'll ask for a lot heavier data on search, because *all* images will be bigger
[18:43:30] <mooeypoo>	 but that size is not insane, it's about 4-5 times bigger than the search results are now
[18:43:40] <mooeypoo>	 That shouldn't be too horrible, I think.
[18:44:13] <mooeypoo>	 Actually, it's a lot less than 4-5 times. Maybe 2-3 times on average.
[18:44:18] <mooeypoo>	 not counting small images that won't change.
[18:45:51] <RoanKattouw>	 In any case, make sure you ask for a multiple then
[18:46:05] <RoanKattouw>	 If you scale the search results to 150px height, ask for a 600px height image
[18:46:10] <RoanKattouw>	 (factor 4)
[18:46:44] <RoanKattouw>	 That minimizes the amount of damage that scaling it down twice will do (compared to asking for e.g. 700px)
[18:49:48] <grrrit-wm>	 (03PS5) 10Trevor Parscal: MediaWiki theme: Improve search widget styling [oojs/ui] - 10https://gerrit.wikimedia.org/r/179355 
[18:54:05] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: FieldLayout: In styles, don't assume that label is given [oojs/ui] - 10https://gerrit.wikimedia.org/r/179514 
[18:58:42] <mooeypoo>	 RoanKattouw, hm. I'm asking for the height of the dialog. I wanted dynamic rather than a fixed hard-coded value... is that not good? :\
[18:58:59] <mooeypoo>	 it seems to work now, though the results have occasional slower-to-load image
[19:03:15] <RoanKattouw>	 Well I'm a bit concerned the scaling might not look very good in that case
[19:03:24] <RoanKattouw>	 But TrevorParscal knows more about that than I do
[19:03:26] <grrrit-wm>	 (03PS1) 10Trevor Parscal: MediaWiki theme: Make button sizes match Apex [oojs/ui] - 10https://gerrit.wikimedia.org/r/179518 
[19:03:54] <TrevorParscal>	 MatmaRex: how's it going?
[19:04:02] <TrevorParscal>	 we're in the home stretch here
[19:04:51] <grrrit-wm>	 (03PS2) 10Jforrester: MediaWiki theme: Make button sizes match Apex [oojs/ui] - 10https://gerrit.wikimedia.org/r/179518 (owner: 10Trevor Parscal)
[19:05:10] <MatmaRex>	 TrevorParscal: https://lh4.googleusercontent.com/-q_CSd6VuGxg/UfeYTp6ci_I/AAAAAAAAgV8/gXy32wVX47A/w480-h360-no/programming.gif
[19:05:22] <MatmaRex>	 precisely like this
[19:05:25] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] MediaWiki theme: Make button sizes match Apex [oojs/ui] - 10https://gerrit.wikimedia.org/r/179518 (owner: 10Trevor Parscal)
[19:05:54] <TrevorParscal>	 MatmaRex: amazing! dude, I miss that show
[19:06:04] <TrevorParscal>	 did you ever watch Malcom in the Middle?
[19:06:06] <James_F>	 MatmaRex: ^^^ Fixes enough issues that we should just make it now and clean-up minor issues later. Hope you're OK with that. :-0
[19:06:08] <James_F>	 MatmaRex: Ha.
[19:06:13] <TrevorParscal>	 I remember disliking the kid though...
[19:06:14] <grrrit-wm>	 (03PS2) 10Bartosz Dziewoński: FieldLayout: Synchronise PHP with JS [oojs/ui] - 10https://gerrit.wikimedia.org/r/179491 
[19:06:16] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: FieldLayout: Use <label> for this.$body, not this.$element [oojs/ui] - 10https://gerrit.wikimedia.org/r/179520 
[19:06:49] <MatmaRex>	 TrevorParscal: hah, nope. it's just this bit that amuses me.
[19:07:02] <wikibugs>	 3OOjs-UI, VisualEditor, VisualEditor-MediaWiki: Height of ButtonSelectWidget is too high in MediaWiki theme - https://phabricator.wikimedia.org/T78029#844629 (10Jdforrester-WMF) 5Open>3Resolved a:3TrevorParscal
[19:07:03] <wikibugs>	 3OOjs-UI, VisualEditor: Buttons in the MediaWiki theme are higher than in Apex theme - https://phabricator.wikimedia.org/T78169#844632 (10Jdforrester-WMF)
[19:07:17] <wikibugs>	 3OOjs-UI, VisualEditor: Buttons in the MediaWiki theme are higher than in Apex theme - https://phabricator.wikimedia.org/T78169#837957 (10Jdforrester-WMF)
[19:07:18] <wikibugs>	 3OOjs-UI, VisualEditor, VisualEditor-MediaWiki: Replace and Replace all buttons are clipped in VisualEditor when using the OOjs UI MediaWiki theme - https://phabricator.wikimedia.org/T78042#844633 (10Jdforrester-WMF) 5Open>3Resolved a:3TrevorParscal
[19:07:34] <wikibugs>	 3OOjs-UI, VisualEditor, VisualEditor-MediaWiki: Height of the toolbar is insufficient for a button to appear there in the OOjs UI MediaWiki theme - https://phabricator.wikimedia.org/T78043#844636 (10Jdforrester-WMF) 5Open>3Resolved a:3TrevorParscal
[19:07:35] <wikibugs>	 3OOjs-UI, VisualEditor: Buttons in the MediaWiki theme are higher than in Apex theme - https://phabricator.wikimedia.org/T78169#837957 (10Jdforrester-WMF)
[19:07:50] <MatmaRex>	 James_F: hah. hm, i wonder how well that will go over.
[19:07:57] <James_F>	 MatmaRex: *coughs*
[19:08:06] <wikibugs>	 3OOjs-UI, VisualEditor: Buttons in the MediaWiki theme are higher than in Apex theme - https://phabricator.wikimedia.org/T78169#837957 (10Jdforrester-WMF)
[19:08:16] <wikibugs>	 3UI-Standardization, OOjs-UI, MediaWiki-Interface: Switch MediaWiki core's use of OOjs UI to use the MediaWiki theme, not Apex - https://phabricator.wikimedia.org/T78054#844645 (10Jdforrester-WMF)
[19:08:19] <wikibugs>	 3OOjs-UI, VisualEditor: Buttons in the MediaWiki theme are higher than in Apex theme - https://phabricator.wikimedia.org/T78169#844643 (10Jdforrester-WMF) 5Open>3Resolved
[19:08:21] <grrrit-wm>	 (03Merged) 10jenkins-bot: MediaWiki theme: Make button sizes match Apex [oojs/ui] - 10https://gerrit.wikimedia.org/r/179518 (owner: 10Trevor Parscal)
[19:08:32] <James_F>	 So.
[19:08:35] <James_F>	 We're now down to:
[19:08:37] <MatmaRex>	 anyway, https://gerrit.wikimedia.org/r/#/c/179520/1 is the top of a big stack that fixes some things that we broke
[19:08:48] <MatmaRex>	 (i broke most of them)
[19:09:06] <MatmaRex>	 James_F: we regressed https://phabricator.wikimedia.org/T70370 , needs fixing; i know why and how to fix
[19:09:06] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] MediaWiki theme: Improve search widget styling [oojs/ui] - 10https://gerrit.wikimedia.org/r/179355 (owner: 10Trevor Parscal)
[19:09:08] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] MediaWiki theme: Improve search widget styling [oojs/ui] - 10https://gerrit.wikimedia.org/r/179355 (owner: 10Trevor Parscal)
[19:09:24] <MatmaRex>	 James_F: (on all browsers but Chrome)
[19:09:46] <James_F>	 MatmaRex: Whoops.
[19:10:52] <wikibugs>	 3OOjs-UI: OOjs UI: ClippableElements should clip to the viewport, not the body - https://phabricator.wikimedia.org/T70370#844653 (10matmarex) 5Resolved>3Open We accidentally broke this again. Needs a less brittle fix.
[19:11:18] <wikibugs>	 3OOjs-UI: OOjs UI: ClippableElements should clip to the viewport, not the body - https://phabricator.wikimedia.org/T70370#844656 (10matmarex) a:5Esanders>3matmarex
[19:11:23] <grrrit-wm>	 (03CR) 10Jforrester: "Doesn't fix anything, I think? Abandon?" [oojs/ui] - 10https://gerrit.wikimedia.org/r/179343 (owner: 10Trevor Parscal)
[19:12:26] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] PopupWidget: Remove box-shadow rule that generates invisible shadow [oojs/ui] - 10https://gerrit.wikimedia.org/r/179496 (owner: 10Bartosz Dziewoński)
[19:12:54] <grrrit-wm>	 (03PS6) 10Trevor Parscal: MediaWiki theme: Improve search widget styling [oojs/ui] - 10https://gerrit.wikimedia.org/r/179355 
[19:13:01] <James_F>	 Thanks Trevor.
[19:13:19] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] MediaWiki theme: Improve search widget styling [oojs/ui] - 10https://gerrit.wikimedia.org/r/179355 (owner: 10Trevor Parscal)
[19:13:46] <wikibugs>	 3UI-Standardization, OOjs-UI, MediaWiki-Interface: Switch MediaWiki core's use of OOjs UI to use the MediaWiki theme, not Apex - https://phabricator.wikimedia.org/T78054#844662 (10Jdforrester-WMF)
[19:13:47] <wikibugs>	 3OOjs-UI, VisualEditor, VisualEditor-MediaWiki: Parameter "add more information" field floats very oddly in the transclusion dialog in VisualEditor when using the OOUI MediaWiki theme - https://phabricator.wikimedia.org/T78034#844659 (10Jdforrester-WMF) 5Open>3Resolved a:3TrevorParscal
[19:13:59] <wikibugs>	 3OOjs-UI, VisualEditor, VisualEditor-MediaWiki: Parameter "add more information" label "No unused fields" placed oddly in the transclusion dialog in VisualEditor when using the OOUI MediaWiki theme - https://phabricator.wikimedia.org/T78035#844663 (10Jdforrester-WMF) 5Open>3Resolved a:3TrevorParscal
[19:14:01] <wikibugs>	 3UI-Standardization, OOjs-UI, MediaWiki-Interface: Switch MediaWiki core's use of OOjs UI to use the MediaWiki theme, not Apex - https://phabricator.wikimedia.org/T78054#834496 (10Jdforrester-WMF)
[19:14:23] <James_F>	 Okie-dokie.
[19:14:26] <James_F>	 Let's try this again.
[19:14:28] <wikibugs>	 3VisualEditor: Performance issues in Internet Explorer 11 - https://phabricator.wikimedia.org/T78413#844667 (10Whatamidoing-WMF) 3NEW
[19:14:34] <James_F>	 So we're now down to:
[19:14:51] <James_F>	 https://phabricator.wikimedia.org/T78178 (disabled scrollbars in PopupWidgets)
[19:15:21] <James_F>	 https://phabricator.wikimedia.org/T78052 (vertical alignment of search box in template dialog; MatmaRex has a patch but edsanders has objections)
[19:15:43] <grrrit-wm>	 (03PS16) 10Mooeypoo: [WIP] Transform the search widget to show image details [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161342 
[19:15:50] <James_F>	 https://phabricator.wikimedia.org/T78041 (vertical alignment of the '2 of 23' text in the search-and-replace control)
[19:15:55] <James_F>	 That's it, AFAIAA, yes?
[19:16:10] <James_F>	 Plus merging the various whoopsie-fixes. :-)
[19:16:33] <grrrit-wm>	 (03Merged) 10jenkins-bot: PopupWidget: Remove box-shadow rule that generates invisible shadow [oojs/ui] - 10https://gerrit.wikimedia.org/r/179496 (owner: 10Bartosz Dziewoński)
[19:16:36] <grrrit-wm>	 (03Merged) 10jenkins-bot: MediaWiki theme: Improve search widget styling [oojs/ui] - 10https://gerrit.wikimedia.org/r/179355 (owner: 10Trevor Parscal)
[19:17:41] <James_F>	 Oh, I see, https://phabricator.wikimedia.org/T78178 has a patch.
[19:17:44] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [WIP] Transform the search widget to show image details [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161342 (owner: 10Mooeypoo)
[19:18:15] <James_F>	 TrevorParscal: https://gerrit.wikimedia.org/r/#/c/179510/ https://gerrit.wikimedia.org/r/#/c/179514/ https://gerrit.wikimedia.org/r/#/c/179491/ https://gerrit.wikimedia.org/r/#/c/179520/
[19:18:38] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: Account for <html> rather than <body> being the scrollable root in Chrome [oojs/ui] - 10https://gerrit.wikimedia.org/r/179523 
[19:18:58] <wikibugs>	 3OOjs-UI: OOjs UI: ClippableElements should clip to the viewport, not the body - https://phabricator.wikimedia.org/T70370#844704 (10matmarex) …needs a less brittle fix, but for now, this will have to do.
[19:19:14] <RoanKattouw>	 MatmaRex: Didn't Prateek have an outstanding patch with basically the same summary (scrolling documentElement vs body)?
[19:19:18] <wikibugs>	 3VisualEditor, VisualEditor-Performance: Performance issues in Internet Explorer 11 - https://phabricator.wikimedia.org/T78413#844705 (10Jdforrester-WMF)
[19:19:37] <James_F>	 RoanKattouw: You mean https://gerrit.wikimedia.org/r/#/c/176666/ which this follows-up?
[19:20:20] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] "I'm going to approve this because there's an undocumented top secret rule that I've never told anyone, which is that unless there's a good" [oojs/ui] - 10https://gerrit.wikimedia.org/r/179339 (owner: 10Bartosz Dziewoński)
[19:20:31] <RoanKattouw>	 James_F: Yes that one
[19:20:37] <RoanKattouw>	 Oh good, it extends that to different places
[19:20:41] <RoanKattouw>	 Rather than duplicating it
[19:20:42] <RoanKattouw>	 that's good
[19:20:42] * James_F nods
[19:20:47] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] MediaWiki Theme: Add state transition to radio buttons [oojs/ui] - 10https://gerrit.wikimedia.org/r/179404 (owner: 10Prtksxna)
[19:20:48] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 04-2] "Let me just add a comment" [oojs/ui] - 10https://gerrit.wikimedia.org/r/179339 (owner: 10Bartosz Dziewoński)
[19:21:26] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] Temporarily remove position:absolute on body when resizing [oojs/ui] - 10https://gerrit.wikimedia.org/r/179465 (owner: 10Esanders)
[19:21:40] <legoktm>	 top secret!
[19:21:51] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] Kill the escape keydown event after handling a window close [oojs/ui] - 10https://gerrit.wikimedia.org/r/179476 (owner: 10Esanders)
[19:22:00] <InezK>	 Did you guys have problem with VE/Parsoid removing all categories from the article during the edit?
[19:22:07] <InezK>	 Without user's intention
[19:22:16] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] [WIP] Don't round() measured sizes [oojs/ui] - 10https://gerrit.wikimedia.org/r/179494 (owner: 10Bartosz Dziewoński)
[19:22:27] <TrevorParscal>	 wrong button
[19:22:33] <TrevorParscal>	 i fixed it
[19:22:41] <RoanKattouw>	 InezK: We've had some reports of categories moving to the wrong place, but never figured out why
[19:22:50] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 04-1] [WIP] Don't round() measured sizes [oojs/ui] - 10https://gerrit.wikimedia.org/r/179494 (owner: 10Bartosz Dziewoński)
[19:23:00] <MatmaRex>	 RoanKattouw: InezK: parsoid guys have just figured out at least one case of this recently
[19:23:16] <RoanKattouw>	 MatmaRex: Oh nice. Link?
[19:23:20] <InezK>	 MatmaRex: of moving them, or removing them?
[19:23:22] <MatmaRex>	 (caused by unclosed table in a template, i can dig it out, one sec)
[19:23:25] <MatmaRex>	 moving
[19:23:46] <grrrit-wm>	 (03CR) 10Trevor Parscal: "The reason I added these was mostly because the really long numbers looked ugly in the DOM - I know, silly. I support this if it appears t" [oojs/ui] - 10https://gerrit.wikimedia.org/r/179494 (owner: 10Bartosz Dziewoński)
[19:24:00] <MatmaRex>	 https://phabricator.wikimedia.org/T76353
[19:24:32] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] GridLayout: Don't round to 1% [oojs/ui] - 10https://gerrit.wikimedia.org/r/179495 (owner: 10Bartosz Dziewoński)
[19:24:33] <MatmaRex>	 hmm, or was that removing?
[19:24:41] <MatmaRex>	 anyway
[19:25:52] <grrrit-wm>	 (03PS2) 10Bartosz Dziewoński: TextInputWidget: Set vertical-align: middle, like buttons [oojs/ui] - 10https://gerrit.wikimedia.org/r/179339 
[19:26:17] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] "Per Trevor." [oojs/ui] - 10https://gerrit.wikimedia.org/r/179339 (owner: 10Bartosz Dziewoński)
[19:26:18] <wikibugs>	 3VisualEditor-MediaWiki, VisualEditor: [Regression pre-wmf13]TypeError: this.toolbar.getSurface(...) is null appears after saving an edit and then cannot reopen that page next time - https://phabricator.wikimedia.org/T78335#844708 (10Jdforrester-WMF)
[19:26:19] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] ClippableElement: 7 is a better number than 10 [oojs/ui] - 10https://gerrit.wikimedia.org/r/179510 (owner: 10Bartosz Dziewoński)
[19:26:24] <James_F>	 Yay.
[19:26:42] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] FieldLayout: In styles, don't assume that label is given [oojs/ui] - 10https://gerrit.wikimedia.org/r/179514 (owner: 10Bartosz Dziewoński)
[19:27:04] <wikibugs>	 3VisualEditor-Tables, VisualEditor, VisualEditor-ContentLanguage: Chinese table contents are lost when saving in VisualEditor, unless the first letter is in the Latin alphabet - https://phabricator.wikimedia.org/T78121#844709 (10Whatamidoing-WMF) The problem was originally spotted in Google Chrome while using Tr...
[19:27:23] <wikibugs>	 3UI-Standardization, OOjs-UI, MediaWiki-Interface: Switch MediaWiki core's use of OOjs UI to use the MediaWiki theme, not Apex - https://phabricator.wikimedia.org/T78054#844712 (10Jdforrester-WMF)
[19:27:28] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] FieldLayout: Synchronise PHP with JS [oojs/ui] - 10https://gerrit.wikimedia.org/r/179491 (owner: 10Bartosz Dziewoński)
[19:28:01] <grrrit-wm>	 (03Abandoned) 10Trevor Parscal: [WIP] Apex theme: Fix box-sizing for inputs [oojs/ui] - 10https://gerrit.wikimedia.org/r/179343 (owner: 10Trevor Parscal)
[19:28:05] <wikibugs>	 3UI-Standardization, OOjs-UI, MediaWiki-Interface: Switch MediaWiki core's use of OOjs UI to use the MediaWiki theme, not Apex - https://phabricator.wikimedia.org/T78054#834496 (10Jdforrester-WMF)
[19:28:06] <wikibugs>	 3VisualEditor-MediaWiki-Templates, OOjs-UI, VisualEditor, VisualEditor-MediaWiki: Vertical alignment of the "add template" button and the search box is incorrect in template dialog in VisualEditor when using the OOjs UI MediaWiki theme - https://phabricator.wikimedia.org/T78052#844714 (10Jdforrester-WMF) 5Open...
[19:28:25] <grrrit-wm>	 (03Merged) 10jenkins-bot: MediaWiki Theme: Add state transition to radio buttons [oojs/ui] - 10https://gerrit.wikimedia.org/r/179404 (owner: 10Prtksxna)
[19:28:47] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] FieldLayout: Use <label> for this.$body, not this.$element [oojs/ui] - 10https://gerrit.wikimedia.org/r/179520 (owner: 10Bartosz Dziewoński)
[19:28:54] <MatmaRex>	 James_F: the insert multimedia dialog looks really poopy with MW theme.
[19:29:04] <James_F>	 MatmaRex: ?
[19:29:27] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] Account for <html> rather than <body> being the scrollable root in Chrome [oojs/ui] - 10https://gerrit.wikimedia.org/r/179523 (owner: 10Bartosz Dziewoński)
[19:29:28] <MatmaRex>	 http://i.imgur.com/6dN52y3.png
[19:29:29] <James_F>	 MatmaRex: You mean the search screen or the details screen?
[19:29:39] <James_F>	 MatmaRex: Oh. Update to VE-MW master. :-)
[19:29:44] <grrrit-wm>	 (03Merged) 10jenkins-bot: Temporarily remove position:absolute on body when resizing [oojs/ui] - 10https://gerrit.wikimedia.org/r/179465 (owner: 10Esanders)
[19:29:46] <grrrit-wm>	 (03Merged) 10jenkins-bot: Kill the escape keydown event after handling a window close [oojs/ui] - 10https://gerrit.wikimedia.org/r/179476 (owner: 10Esanders)
[19:29:54] <MatmaRex>	 oh. okay then. :)
[19:30:15] <wikibugs>	 3OOjs-UI, VisualEditor, VisualEditor-MediaWiki: Vertical alignment of text in the search-and-replace field is off in VisualEditor when using the OOjs UI MediaWiki theme - https://phabricator.wikimedia.org/T78041#844727 (10Jdforrester-WMF) Not fixed. I'm going to declare this not a blocker to switching.
[19:30:43] <wikibugs>	 3MediaWiki-ResourceLoader, MediaWiki-Core-Team: Introduce MediaWiki:Mainpage.css - https://phabricator.wikimedia.org/T78418#844728 (10Jdlrobson) 3NEW
[19:30:48] <wikibugs>	 3UI-Standardization, OOjs-UI, MediaWiki-Interface: Switch MediaWiki core's use of OOjs UI to use the MediaWiki theme, not Apex - https://phabricator.wikimedia.org/T78054#844735 (10Jdforrester-WMF)
[19:30:53] <wikibugs>	 3Mobile-Web, MediaWiki-ResourceLoader, MediaWiki-Core-Team: Introduce MediaWiki:Mainpage.css - https://phabricator.wikimedia.org/T78418#844728 (10Jdlrobson)
[19:31:08] <James_F>	 MatmaRex: OK, will do the cut in a few minutes.
[19:31:09] <James_F>	 Yay!
[19:31:53] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] GridLayout: Don't round to 1% [oojs/ui] - 10https://gerrit.wikimedia.org/r/179495 (owner: 10Bartosz Dziewoński)
[19:33:34] <grrrit-wm>	 (03CR) 10Catrope: "According to the jQuery documentation, returning false is equivalent to preventing default and stopping propagation :) so in theory this s" [oojs/ui] - 10https://gerrit.wikimedia.org/r/179476 (owner: 10Esanders)
[19:36:48] <grrrit-wm>	 (03Merged) 10jenkins-bot: TextInputWidget: Set vertical-align: middle, like buttons [oojs/ui] - 10https://gerrit.wikimedia.org/r/179339 (owner: 10Bartosz Dziewoński)
[19:36:57] <grrrit-wm>	 (03Merged) 10jenkins-bot: ClippableElement: 7 is a better number than 10 [oojs/ui] - 10https://gerrit.wikimedia.org/r/179510 (owner: 10Bartosz Dziewoński)
[19:36:59] <grrrit-wm>	 (03Merged) 10jenkins-bot: FieldLayout: In styles, don't assume that label is given [oojs/ui] - 10https://gerrit.wikimedia.org/r/179514 (owner: 10Bartosz Dziewoński)
[19:37:01] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] FieldLayout: Synchronise PHP with JS [oojs/ui] - 10https://gerrit.wikimedia.org/r/179491 (owner: 10Bartosz Dziewoński)
[19:37:03] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] FieldLayout: Use <label> for this.$body, not this.$element [oojs/ui] - 10https://gerrit.wikimedia.org/r/179520 (owner: 10Bartosz Dziewoński)
[19:37:05] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Account for <html> rather than <body> being the scrollable root in Chrome [oojs/ui] - 10https://gerrit.wikimedia.org/r/179523 (owner: 10Bartosz Dziewoński)
[19:37:42] <MatmaRex>	 ugh
[19:38:16] <grrrit-wm>	 (03PS3) 10Bartosz Dziewoński: FieldLayout: Synchronise PHP with JS [oojs/ui] - 10https://gerrit.wikimedia.org/r/179491 
[19:38:27] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] FieldLayout: Synchronise PHP with JS [oojs/ui] - 10https://gerrit.wikimedia.org/r/179491 (owner: 10Bartosz Dziewoński)
[19:39:18] <RoanKattouw>	 OK time to go into the office
[19:39:40] <grrrit-wm>	 (03PS2) 10Bartosz Dziewoński: FieldLayout: Use <label> for this.$body, not this.$element [oojs/ui] - 10https://gerrit.wikimedia.org/r/179520 
[19:39:52] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] FieldLayout: Use <label> for this.$body, not this.$element [oojs/ui] - 10https://gerrit.wikimedia.org/r/179520 (owner: 10Bartosz Dziewoński)
[19:40:06] <grrrit-wm>	 (03PS2) 10Bartosz Dziewoński: Account for <html> rather than <body> being the scrollable root in Chrome [oojs/ui] - 10https://gerrit.wikimedia.org/r/179523 
[19:40:17] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] Account for <html> rather than <body> being the scrollable root in Chrome [oojs/ui] - 10https://gerrit.wikimedia.org/r/179523 (owner: 10Bartosz Dziewoński)
[19:40:29] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] GridLayout: Don't round to 1% [oojs/ui] - 10https://gerrit.wikimedia.org/r/179495 (owner: 10Bartosz Dziewoński)
[19:40:40] <grrrit-wm>	 (03PS2) 10Bartosz Dziewoński: GridLayout: Don't round to 1% [oojs/ui] - 10https://gerrit.wikimedia.org/r/179495 
[19:40:57] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] GridLayout: Don't round to 1% [oojs/ui] - 10https://gerrit.wikimedia.org/r/179495 (owner: 10Bartosz Dziewoński)
[19:43:45] <grrrit-wm>	 (03Merged) 10jenkins-bot: FieldLayout: Synchronise PHP with JS [oojs/ui] - 10https://gerrit.wikimedia.org/r/179491 (owner: 10Bartosz Dziewoński)
[19:49:54] <grrrit-wm>	 (03Merged) 10jenkins-bot: FieldLayout: Use <label> for this.$body, not this.$element [oojs/ui] - 10https://gerrit.wikimedia.org/r/179520 (owner: 10Bartosz Dziewoński)
[19:49:57] <grrrit-wm>	 (03Merged) 10jenkins-bot: Account for <html> rather than <body> being the scrollable root in Chrome [oojs/ui] - 10https://gerrit.wikimedia.org/r/179523 (owner: 10Bartosz Dziewoński)
[19:50:04] <grrrit-wm>	 (03Merged) 10jenkins-bot: GridLayout: Don't round to 1% [oojs/ui] - 10https://gerrit.wikimedia.org/r/179495 (owner: 10Bartosz Dziewoński)
[19:52:08] <wikibugs>	 3Mobile-Web, MediaWiki-ResourceLoader, MediaWiki-Core-Team: Introduce MediaWiki:Mainpage.css - https://phabricator.wikimedia.org/T78418#844799 (10matmarex) Doesn't sound unreasonable to me. By the way, the Polish Wikipedia currently has a default-on gadget that implements styles for the main page (which is as mo...
[20:00:40] <grrrit-wm>	 (03CR) 10Esanders: "Agree with Bartosz, rounding should happen at the last possible instance (if ever), i.e. when writing to style, but I don't think there ar" [oojs/ui] - 10https://gerrit.wikimedia.org/r/179494 (owner: 10Bartosz Dziewoński)
[20:00:56] <grrrit-wm>	 (03CR) 10Esanders: [C: 031] [WIP] Don't round() measured sizes [oojs/ui] - 10https://gerrit.wikimedia.org/r/179494 (owner: 10Bartosz Dziewoński)
[20:02:15] <grrrit-wm>	 (03PS1) 10Divec: Readonly selection handling [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179530 
[20:02:23] <James_F>	 OK.
[20:02:25] <James_F>	 Let's do this.
[20:02:49] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "I'm not aware of any issues this would fix (and that's actually really curious, either this doesn't work how I think it does, or we were r" [oojs/ui] - 10https://gerrit.wikimedia.org/r/179494 (owner: 10Bartosz Dziewoński)
[20:04:49] <grrrit-wm>	 (03PS1) 10Jforrester: README: Point to Phabricator, not Bugzilla [oojs/ui] - 10https://gerrit.wikimedia.org/r/179531 
[20:04:51] <James_F>	 MatmaRex: ^^^ +2 please?
[20:06:04] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] README: Point to Phabricator, not Bugzilla [oojs/ui] - 10https://gerrit.wikimedia.org/r/179531 (owner: 10Jforrester)
[20:07:31] <grrrit-wm>	 (03PS1) 10Jforrester: Tag v0.5.0 [oojs/ui] - 10https://gerrit.wikimedia.org/r/179533 
[20:07:34] <James_F>	 MatmaRex: ^^^ Want to do the honours? :-)
[20:09:17] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] Tag v0.5.0 [oojs/ui] - 10https://gerrit.wikimedia.org/r/179533 (owner: 10Jforrester)
[20:09:34] <grrrit-wm>	 (03Merged) 10jenkins-bot: README: Point to Phabricator, not Bugzilla [oojs/ui] - 10https://gerrit.wikimedia.org/r/179531 (owner: 10Jforrester)
[20:09:48] <James_F>	 Whee.
[20:12:02] <grrrit-wm>	 (03Merged) 10jenkins-bot: Tag v0.5.0 [oojs/ui] - 10https://gerrit.wikimedia.org/r/179533 (owner: 10Jforrester)
[20:15:23] <github>	 [13oojs.github.io] 15jdforrester created 06oojs-ui-0.5.0 from 06oojs-ui-0.4.0 (+0 new commits): 02https://github.com/oojs/oojs.github.io/commits/oojs-ui-0.5.0
[20:19:09] <grrrit-wm>	 (03PS2) 10Jforrester: Update OOjs UI to v0.5.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178948 (owner: 10Bartosz Dziewoński)
[20:20:14] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Update OOjs UI to v0.5.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178948 (owner: 10Bartosz Dziewoński)
[20:23:46] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update OOjs UI to v0.5.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178948 (owner: 10Bartosz Dziewoński)
[20:24:58] <grrrit-wm>	 (03PS17) 10Mooeypoo: [WIP] Transform the search widget to show image details [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161342 
[20:28:44] <grrrit-wm>	 (03PS1) 10Jforrester: Update VE core submodule to master (b5e2b87) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/179541 
[20:29:15] <grrrit-wm>	 (03PS3) 10Jforrester: Update VE core submodule to master (b5e2b87) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178625 (owner: 10Bartosz Dziewoński)
[20:29:32] <grrrit-wm>	 (03Abandoned) 10Jforrester: Update VE core submodule to master (b5e2b87) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/179541 (owner: 10Jforrester)
[20:32:44] <grrrit-wm>	 (03PS2) 10Divec: Non-DOM-modifying selection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179530 
[20:35:11] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Stop propagation of events after handling trigger keys [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179479 (owner: 10Esanders)
[20:35:25] <wikibugs>	 3OOjs-UI, VisualEditor, VisualEditor-MediaWiki: Vertical alignment of text in the search-and-replace field is off in VisualEditor - https://phabricator.wikimedia.org/T78041#844867 (10matmarex)
[20:35:49] <wikibugs>	 3OOjs-UI, VisualEditor, VisualEditor-MediaWiki: Vertical alignment of text in the search-and-replace field is off in VisualEditor - https://phabricator.wikimedia.org/T78041#834353 (10matmarex) This also affects the Apex theme.
[20:35:53] <grrrit-wm>	 (03PS3) 10Divec: Non-DOM-modifying selection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179530 
[20:37:17] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] Check for stopped propagation before show close dialog (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/179478 (owner: 10Esanders)
[20:37:50] <grrrit-wm>	 (03CR) 10Catrope: "Note that this is going to conflict with https://gerrit.wikimedia.org/r/#/c/179387/ which fixes onDocumentKeyDown to extend rather than ov" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/179478 (owner: 10Esanders)
[20:37:53] <grrrit-wm>	 (03PS18) 10Mooeypoo: [WIP] Transform the search widget to show image details [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161342 
[20:38:29] <grrrit-wm>	 (03Merged) 10jenkins-bot: Stop propagation of events after handling trigger keys [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179479 (owner: 10Esanders)
[20:38:30] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: ButtonGroupWidget: Remove weird margin-bottom: -1px; from theme styles [oojs/ui] - 10https://gerrit.wikimedia.org/r/179545 
[20:38:49] <MatmaRex>	 woot
[20:38:57] <MatmaRex>	 ! [remote rejected] HEAD -> refs/publish/master (internal server error)
[20:38:57] <MatmaRex>	 error: failed to push some refs to 'ssh://matmarex@gerrit.wikimedia.org:29418/oojs/ui.git'
[20:39:06] <MatmaRex>	 i've just gotten this while pushing that change for review
[20:39:14] <grrrit-wm>	 (03PS2) 10Bartosz Dziewoński: ButtonGroupWidget: Remove weird margin-bottom: -1px; from theme styles [oojs/ui] - 10https://gerrit.wikimedia.org/r/179545 
[20:40:12] <wikibugs>	 3OOjs-UI, VisualEditor, VisualEditor-MediaWiki: Vertical alignment of text in the search-and-replace field is off in VisualEditor - https://phabricator.wikimedia.org/T78041#844879 (10matmarex) https://gerrit.wikimedia.org/r/#/c/179545/
[20:42:58] <James_F>	 MatmaRex: Fun.
[20:43:59] <MatmaRex>	 quite. looks like the phab notification thing broke, since it didn't notify. oh well.
[20:44:26] <Krenair>	 James_F, do you think https://phabricator.wikimedia.org/T78415 was supposed to be created under VisualEditor?
[20:44:38] <James_F>	 Krenair: Sounds like it.
[20:44:44] <Krenair>	 Even -WMF people are messing that up :( that field really needs to be required
[20:45:00] <wikibugs>	 3VisualEditor, VisualEditor-ContentEditable: Cursor jumps to the start of the page when deleting a character or creating a heading in Internet Explorer 11 - https://phabricator.wikimedia.org/T78415#844891 (10Jdforrester-WMF)
[20:45:02] <James_F>	 Indeed.
[20:45:04] <MatmaRex>	 that's a dupe
[20:45:14] <James_F>	 It is?
[20:45:26] <MatmaRex>	 quite so
[20:45:38] <MatmaRex>	 of https://phabricator.wikimedia.org/T73119
[20:45:40] <wikibugs>	 3VisualEditor, VisualEditor-ContentEditable: Cursor jumps to the start of the page when deleting a character or creating a heading in Internet Explorer 11 - https://phabricator.wikimedia.org/T78415#844892 (10Krenair) When creating tasks in Phabricator, please don't forget to add at least one project.
[20:45:48] <MatmaRex>	 and https://phabricator.wikimedia.org/T75294
[20:46:05] <MatmaRex>	 and a few other dupes
[20:46:54] <James_F>	 MatmaRex: Scroll up !== cursor movement.
[20:46:59] <James_F>	 MatmaRex: Are you sure they're the same?
[20:49:02] <grrrit-wm>	 (03PS3) 10Catrope: Rename some things for my sanity [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178641 (owner: 10Bartosz Dziewoński)
[20:49:03] <MatmaRex>	 James_F: yes, because i just tested and the cursor doesn't jump anywhere
[20:49:18] <MatmaRex>	 the view is just scrolled
[20:49:40] <James_F>	 MatmaRex: Aha.
[20:49:41] <James_F>	 OK.
[20:50:09] <wikibugs>	 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Pressing "Backspace" causes the page to abruptly scroll up on IE 11 - https://phabricator.wikimedia.org/T73119#844906 (10Jdforrester-WMF)
[20:50:10] <wikibugs>	 3VisualEditor: VisualEditor: Using the VE toolbar in MSIE causes the cursor to jump to the start of the page - https://phabricator.wikimedia.org/T75294#844905 (10Jdforrester-WMF)
[20:50:11] <wikibugs>	 3VisualEditor, VisualEditor-ContentEditable: Cursor jumps to the start of the page when deleting a character or creating a heading in Internet Explorer 11 - https://phabricator.wikimedia.org/T78415#844904 (10Jdforrester-WMF)
[20:50:51] <wikibugs>	 3VisualEditor, VisualEditor-ContentEditable: Pressing "Backspace" or creating a heading causes the page to abruptly scroll up on Internet Explorer 11 - https://phabricator.wikimedia.org/T73119#844916 (10Jdforrester-WMF)
[20:51:36] <grrrit-wm>	 (03PS4) 10Divec: Non-DOM-modifying selection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179530 
[20:51:39] <MatmaRex>	 James_F: TrevorP|Away: we should probably make the Apex skin use the Apex OOUI theme at some point, whatcha think?
[20:51:55] <MatmaRex>	 (or rather, have you thought about how to do this neatly?)
[20:51:56] <James_F>	 MatmaRex: See my commit. :-)
[20:52:32] <James_F>	 MatmaRex: https://gerrit.wikimedia.org/r/#/c/179400/
[20:52:36] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Update VE core submodule to master (b5e2b87) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178625 (owner: 10Bartosz Dziewoński)
[20:54:07] <MatmaRex>	 James_F: oooh, neat. but i think you totally have the contents of these two arrays switched.
[20:54:30] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update VE core submodule to master (b5e2b87) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178625 (owner: 10Bartosz Dziewoński)
[20:54:36] <grrrit-wm>	 (03Merged) 10jenkins-bot: Rename some things for my sanity [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178641 (owner: 10Bartosz Dziewoński)
[20:56:17] <wikibugs>	 3OOjs-UI: OOjs UI: ClippableElements should clip to the viewport, not the body - https://phabricator.wikimedia.org/T70370#844922 (10Jdforrester-WMF) 5Open>3Resolved Maybe we should make a tech-debt task for making this less brittle?
[20:57:03] <James_F>	 MatmaRex: Yeah, point. :-) Also we'll probably need locally-stored copies of the Apex theme added to Apex.
[20:57:15] <James_F>	 Maybe we should call them OO/Apex and MW/Apex for sanity. :-)
[21:00:18] <Krenair>	 https://phabricator.wikimedia.org/T78045#842962 - if I add position:absolute; it appears to be hidden correctly?
[21:01:56] <Krenair>	 guess I'll upload it for review..
[21:02:10] <grrrit-wm>	 (03PS1) 10Alex Monk: Hide extra space at the top of the single transclusion dialogs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/179551 
[21:03:16] <mooeypoo>	 James_F, kaity|away TrevorParscal Media dialog mail sent your way with screenshots
[21:03:31] <mooeypoo>	 it's almost done, I think. Just final touches and final design decisions -- at least for the preliminary round
[21:04:46] <MatmaRex>	 (afk)
[21:06:02] <grrrit-wm>	 (03Abandoned) 10Trevor Parscal: [IDEA] Make icon prefix theme-configurable [oojs/ui] - 10https://gerrit.wikimedia.org/r/178595 (owner: 10Trevor Parscal)
[21:06:45] <grrrit-wm>	 (03CR) 10Catrope: "Not sure if this is the best way to do it, or if we should instead make a .ve-init-target-ie -like selector that excludes fixed versions o" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179242 (owner: 10Catrope)
[21:07:40] <James_F>	 mooeypoo: It looks great!
[21:07:46] <James_F>	 mooeypoo: I like the title overlay.
[21:08:09] <mooeypoo>	 yay :D
[21:08:25] <mooeypoo>	 Yeah I think the file name is better back on there, as ed pointed out.
[21:09:43] <wikibugs>	 3UI-Standardization, OOjs-UI, MediaWiki-Interface: Provide the OOUI PHP module inside MW core - https://phabricator.wikimedia.org/T74714#844951 (10Jdforrester-WMF)
[21:09:46] <wikibugs>	 3UI-Standardization, OOjs-UI, MediaWiki-Interface: Switch MediaWiki core's use of OOjs UI to use the MediaWiki theme, not Apex - https://phabricator.wikimedia.org/T78054#844949 (10Jdforrester-WMF) 5Open>3Resolved Woo.
[21:09:56] <wikibugs>	 3UI-Standardization, OOjs-UI, MediaWiki-Interface: Switch MediaWiki core's use of OOjs UI to use the MediaWiki theme, not Apex - https://phabricator.wikimedia.org/T78054#844952 (10Jdforrester-WMF)
[21:10:55] <grrrit-wm>	 (03PS63) 10Paladox: WikiEditor: Re add SVG [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151611 
[21:11:26] <grrrit-wm>	 (03PS18) 10Divec: Native leftarrow and rightarrow [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177946 
[21:12:13] <grrrit-wm>	 (03CR) 10Paladox: "@Krinkle and @Raimond Spekking please review. this re adds the svg images that were reverted do to it having a shadow on the background th" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151611 (owner: 10Paladox)
[21:12:14] <James_F>	 RoanKattouw: FYI, "Re-enable stripping data-parsoid for template content" just landed in Parsoid.
[21:12:22] <RoanKattouw>	 Yay
[21:12:24] <Krenair>	 RoanKattouw, where is ve.init.Target#destroy actually called? :/
[21:12:33] <RoanKattouw>	 James_F: Should reduce Parsoid HTML size
[21:12:37] <James_F>	 RoanKattouw: Yeah. :-)
[21:12:56] <RoanKattouw>	 Did they also say anything about Timo's or Alex's (I forget whose) report about data-parsoid="{}" attributes? Or was that this?
[21:13:12] <James_F>	 Timo's, and not seen anything either way.
[21:15:17] <Krenair>	 I can't find it. . .
[21:15:34] <James_F>	 It was a complaint in -parsoid. :-)
[21:15:58] <Krenair>	 James_F, I was talkig about Target#destroy, not data-parsoid
[21:16:09] <James_F>	 Krenair: Oh. Sorry.
[21:16:44] <RoanKattouw>	 Krenair: Ahm...
[21:16:48] <RoanKattouw>	 Good question
[21:16:53] <Krenair>	 I can't seem to get it to be called by closing VE
[21:16:55] <RoanKattouw>	 Hopefully nowhere, because it didn't exit before? :P
[21:16:59] <RoanKattouw>	 *exist
[21:17:15] <RoanKattouw>	 Oh!
[21:17:18] <RoanKattouw>	 Tests, hopefully
[21:17:25] <RoanKattouw>	 Or rather, should be but isn't
[21:17:38] <RoanKattouw>	 I noticed recently that if you run the test suite, you end up with a couple dozen targets in your DOM
[21:17:43] <RoanKattouw>	 The test suite should be destroying targets
[21:17:50] <Krenair>	 1f7e9443 modules/ve/init/ve.init.Target.js (Ed Sanders 2014-01-08 15:02:31 +0000 52) ve.init.Target.prototype.destroy = function () {
[21:18:03] <RoanKattouw>	 Other than that we don't really have target destruction, because VPT deactivates but stays alive forever, as does the demo taget
[21:18:17] <RoanKattouw>	 Krenair: Yeah but it was before OO.extendClass
[21:18:22] <RoanKattouw>	 Which wipes it out
[21:18:29] <RoanKattouw>	 The destructor, destroyed :P
[21:18:31] <grrrit-wm>	 (03CR) 10Esanders: Check for stopped propagation before show close dialog (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/179478 (owner: 10Esanders)
[21:18:52] <RoanKattouw>	 s/was/is/ because https://gerrit.wikimedia.org/r/#/c/179386/1 isn't merged yet
[21:19:07] <Krenair>	 yeah, that's the change I was looking at
[21:19:29] <RoanKattouw>	 Well in a way it's good it's unused, because using it would cause an error
[21:19:31] <Krenair>	 I was surprised this wasn't breaking things in some obvious way
[21:19:40] <RoanKattouw>	 But the only place I can think of where it should be used is the tests
[21:19:49] <RoanKattouw>	 Because the other targets are designed to stay alive forever
[21:19:54] <Krenair>	 but I guess it's lack of use is why the issue went unnoticed
[21:20:33] <grrrit-wm>	 (03CR) 10Catrope: Check for stopped propagation before show close dialog (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/179478 (owner: 10Esanders)
[21:20:43] <RoanKattouw>	 Yeah
[21:22:40] <grrrit-wm>	 (03CR) 10Alex Monk: [C: 032] Move ve.init.Target#destroy to a place where it actually ends up existing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179386 (owner: 10Catrope)
[21:27:03] <grrrit-wm>	 (03PS19) 10Divec: Native leftarrow and rightarrow [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177946 
[21:28:22] <grrrit-wm>	 (03CR) 10Esanders: "or a ve-init-target-ieX class?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179242 (owner: 10Catrope)
[21:29:22] <grrrit-wm>	 (03Merged) 10jenkins-bot: Move ve.init.Target#destroy to a place where it actually ends up existing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179386 (owner: 10Catrope)
[21:31:04] <Krenair>	 RoanKattouw, onDocumentKeyDown and onTargetKeyDown are identical? :/
[21:31:31] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Non-DOM-modifying selection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179530 (owner: 10Divec)
[21:31:49] <RoanKattouw>	 Krenair: Almost but not quite
[21:31:53] <RoanKattouw>	 Small difference
[21:31:57] <RoanKattouw>	 IIRC
[21:32:09] <mooeypoo>	 James_F, btw, the *search* itself (the results we're getting from the API) is ... uh... weird.
[21:32:22] <Krenair>	 documentTriggerListener vs. targetTriggerListener, ok
[21:33:13] <mooeypoo>	 When I search for images of, say, "Paris" -- I expect, I dunno, images of the eiffel tower and paris, yes? I'm getting images of old maps of the plans to paris from like, 1600
[21:34:49] <mooeypoo>	 I searched "sport" and the first results are cars, which would have been fine if they were sports cars, but the first 2 images are of SUVs -- "Range rover sport" and "Mitsubishi Montero sport" and everything else is cars except for 2 pages later where I can actually see actual sports related stuff.
[21:34:59] <mooeypoo>	 James_F, who do I talk to about this?
[21:35:08] <mooeypoo>	 We're going to get people very frustrated at this rate :\
[21:35:15] <grrrit-wm>	 (03CR) 10Alex Monk: [C: 032] Factor out event handler binding in ve.init.Target [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179383 (owner: 10Catrope)
[21:36:58] <Krenair>	 mooeypoo, search - manybubbles and ^d?
[21:37:16] <grrrit-wm>	 (03Merged) 10jenkins-bot: Non-DOM-modifying selection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179530 (owner: 10Divec)
[21:38:05] <mooeypoo>	 ah, hm, thanks Krenair. I'm trying to see if it's something we're mis-searching perhaps, but it doesn't look it.
[21:38:06] <RoanKattouw>	 edsanders: https://gerrit.wikimedia.org/r/#/c/178918/6/src/ui/styles/dialogs/ve.ui.ToolbarDialog.css
[21:38:17] <RoanKattouw>	 edsanders: "TODO fix upstream" --> is tthat fixed now?
[21:39:34] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Death to isolation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178918 (owner: 10Esanders)
[21:43:37] <grrrit-wm>	 (03PS2) 10Esanders: Check for stopped propagation before show close dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/179478 
[21:45:11] <wikibugs>	 3Mobile-Web, MediaWiki-ResourceLoader, MediaWiki-Core-Team: Introduce MediaWiki:Mainpage.css - https://phabricator.wikimedia.org/T78418#845007 (10Edokter) +9000  I would like some sandbox mechanism though, that allows me to test CSS wihtout having to load it manually via importStylesheet, withCSS or some other h...
[21:45:46] <TrevorParscal>	 Krenair: hey, https://gerrit.wikimedia.org/r/#/c/179551/1/modules/ve-mw/ui/styles/dialogs/ve.ui.MWTransclusionDialog.css,unified
[21:45:47] <TrevorParscal>	 so...
[21:46:49] <TrevorParscal>	 by flipping the positioning to absolute, the content this element was previously pushing out of the way by being position relative will not smoothly transition to it's new location, but instead jump instantly
[21:47:07] <TrevorParscal>	 which... well is sort of working against the point of making this thing animate at all, no?
[21:47:17] <Krenair>	 yeah, good point :/
[21:48:33] <grrrit-wm>	 (03Merged) 10jenkins-bot: Factor out event handler binding in ve.init.Target [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179383 (owner: 10Catrope)
[21:52:00] <edsanders>	 RoanKattouw, nope
[21:54:05] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Native leftarrow and rightarrow [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177946 (owner: 10Divec)
[21:54:43] <grrrit-wm>	 (03Merged) 10jenkins-bot: Death to isolation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178918 (owner: 10Esanders)
[21:59:44] <Krenair>	 TrevorParscal, what can we do to fix it?
[22:03:37] <James_F>	 MatmaRex: You happy with https://gerrit.wikimedia.org/r/#/c/177901/ removing the reference to Minerva, apart from anything else? :-)
[22:04:55] <MatmaRex>	 hah, yeah. :)
[22:07:21] <wikibugs>	 3Mobile-Web, MediaWiki-ResourceLoader, MediaWiki-Core-Team: Introduce MediaWiki:Mainpage.css - https://phabricator.wikimedia.org/T78418#845045 (10Jdlrobson) See also T32405 - this would allow us to deprecate a bunch of code debt we have in MobileFrontend.
[22:08:26] <grrrit-wm>	 (03PS68) 10Paladox: WikiEditor: Convert .css to .less and also fixes SVG issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 
[22:09:44] <James_F>	 MatmaRex: Sadly for some reason it isn't like yet on Beta Labs.
[22:10:31] <James_F>	 Err. Live.
[22:10:35] <RoanKattouw>	 James_F: Check Special:Version?
[22:11:12] <James_F>	 RoanKattouw: I did. It looks OK for MW, bad for VE.
[22:11:59] <James_F>	 Oh, that reminds me.
[22:13:13] <grrrit-wm>	 (03PS1) 10Jforrester: Follow-up I64f5e2f6c: Bump wfUseMW version given breaking OOjs UI dependency [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/179559 
[22:17:51] <wikibugs>	 3OOjs-UI, Apex: Use the "Apex" theme in OOjs UI when using the Apex skin - https://phabricator.wikimedia.org/T78367#845052 (10Jdforrester-WMF) p:5Triage>3Low
[22:20:57] <wikibugs>	 3UI-Standardization, OOjs-UI, MediaWiki-ResourceLoader: Implement ResourceLoader module to ship CSS for sets of SVG+PNG icons to the user - https://phabricator.wikimedia.org/T76473#845054 (10matmarex) p:5Normal>3Volunteer?
[22:21:07] <MatmaRex>	 …whoops.
[22:21:14] <wikibugs>	 3UI-Standardization, OOjs-UI, MediaWiki-ResourceLoader: Implement ResourceLoader module to ship CSS for sets of SVG+PNG icons to the user - https://phabricator.wikimedia.org/T76473#801437 (10matmarex) p:5Volunteer?>3Normal
[22:21:19] <MatmaRex>	 bloody phabricator.
[22:24:03] <grrrit-wm>	 (03PS1) 10Esanders: Fix demo CSS hack broken by OOUI change [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179561 
[22:24:12] <edsanders>	 quick +2 ^^
[22:26:04] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] Fix demo CSS hack broken by OOUI change [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179561 (owner: 10Esanders)
[22:26:14] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Fix demo CSS hack broken by OOUI change [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179561 (owner: 10Esanders)
[22:26:20] <RoanKattouw>	 lol
[22:26:28] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Follow-up I64f5e2f6c: Bump wfUseMW version given breaking OOjs UI dependency [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/179559 (owner: 10Jforrester)
[22:26:58] <James_F>	 RoanKattouw: https://phabricator.wikimedia.org/T76473#838917 – click the link. Observe. :-)
[22:28:13] <grrrit-wm>	 (03Merged) 10jenkins-bot: Follow-up I64f5e2f6c: Bump wfUseMW version given breaking OOjs UI dependency [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/179559 (owner: 10Jforrester)
[22:29:15] <aharoni>	 Hallo.
[22:29:23] <aharoni>	 I want to try to fix a little bug,
[22:29:23] <James_F>	 Hey Amir.
[22:29:28] <aharoni>	 and it's probably in oojs-ui,
[22:29:37] <James_F>	 Little bug and OOjs UI?
[22:29:38] <edsanders>	 soooo, now that we don't use isolation, do we keep supporting it in ooui?
[22:29:38] <James_F>	 :-)
[22:29:47] <James_F>	 edsanders: For other users?
[22:29:51] <edsanders>	 there's a lot of code supporting a feature we don't use
[22:29:57] <RoanKattouw>	 edsanders: No our plan is to kill it
[22:30:02] <aharoni>	 and my question is how do I build oojs-ui to test it with VE.
[22:30:04] <edsanders>	 this.$ ...
[22:30:04] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix demo CSS hack broken by OOUI change [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179561 (owner: 10Esanders)
[22:30:14] <edsanders>	 aharoni, there's a build script in ve
[22:30:15] <RoanKattouw>	 I started my crusade against isolation specifically because Trevor was saying he wanted this.$ to die
[22:30:22] <James_F>	 aharoni: You need to run "grunt build" locally, then copy them to MediaWiki core.
[22:30:49] <James_F>	 aharoni: …/oojs-ui/dist/* -> …/mediawiki/resources/lib/oojs-ui/.
[22:30:58] <RoanKattouw>	 edsanders: "Here, let us teach you this library, it's easy. Oh BTW, you can't use the $() function anywhere, you have to use our special this.$() function"
[22:31:14] <James_F>	 aharoni: The actual pull-throughs to MW-core happen with OOjs UI library releases.
[22:31:22] <grrrit-wm>	 (03PS20) 10Divec: Native leftarrow and rightarrow [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177946 
[22:31:30] <aharoni>	 I'm a bit confused between what edsanders says and what James_F says.
[22:31:31] <edsanders>	 RoanKattouw, and every time you make a widget you need this magic copypasta
[22:31:40] <RoanKattouw>	 Oh yeah {$: this.$}
[22:31:49] <RoanKattouw>	 aharoni: Do what James_F says
[22:31:50] <aharoni>	 does the build happen in oojs-ui or in be?
[22:31:52] <edsanders>	 aharoni, we're saying the same thing but his method is simpler
[22:31:54] <aharoni>	 OK
[22:32:01] <James_F>	 aharoni: OOjs UI.
[22:32:07] <RoanKattouw>	 edsanders: So the plan is this
[22:32:17] <edsanders>	 aharoni, there's a magic script that copies it but it also does other things like changing branch, so just copy
[22:32:19] <aharoni>	 let's see.
[22:32:29] <James_F>	 edsanders: No.
[22:32:31] <RoanKattouw>	 Wait for unisolation to be deployed and prove itself stable
[22:32:38] <James_F>	 edsanders: That script only works if the code you want is a release.
[22:32:45] <RoanKattouw>	 Then remove isolation support from Window/WindowManager
[22:32:46] <James_F>	 edsanders: For unmerged code you have to copy it manually.
[22:33:37] <RoanKattouw>	 Then get rid of this.$ and config.$ in OOUI and VE code, but keep a this.$ thing around for backwards compatibility
[22:33:38] <James_F>	 edsanders: Same as for e.g. jQuery.
[22:33:48] <RoanKattouw>	 (old code that uses it shouldn't fail)
[22:33:56] <RoanKattouw>	 (could just be this.$ = $;)
[22:34:05] <edsanders>	 RoanKattouw, more stable that transplantStyles is not a high bar
[22:34:21] <RoanKattouw>	 Exactly
[22:36:33] <RoanKattouw>	 I gotta run for my flight, be back on IRC later
[22:36:42] <edsanders>	 or this.$ = function () { warnOnce( 'this.$ be dead fool' ); return $.apply( this, arguments ); }
[22:37:24] <edsanders>	 this.$$ = function () { throw new Error( 'party like it's 2013' ); }
[22:38:55] <grrrit-wm>	 (03PS3) 10Esanders: Check for stopped propagation before showing close dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/179478 
[22:39:19] <James_F>	 edsanders: Maybe not. :-)
[22:44:55] <grrrit-wm>	 (03Abandoned) 10Divec: WIP: Prepare-Observe-Fixup for keyboard events [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/105172 (owner: 10Divec)
[22:46:32] <grrrit-wm>	 (03PS1) 10Amire80: Add noflip to oo-ui-popupToolGroup-left and -right [oojs/ui] - 10https://gerrit.wikimedia.org/r/179565 
[22:47:17] <grrrit-wm>	 (03PS19) 10Mooeypoo: [WIP] Transform the search widget to show image details [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161342 
[22:47:24] <aharoni>	 OK, looks like it worked.
[22:47:26] <aharoni>	 https://gerrit.wikimedia.org/r/#/c/179565/
[22:47:58] <aharoni>	 It's a very small change, but needs careful review, because I don't know much about oojs-ui.
[22:49:03] <James_F>	 aharoni: OK. Is there a Task attached?
[22:49:25] <aharoni>	 https://phabricator.wikimedia.org/T76474
[22:50:01] <James_F>	 Cool.
[22:53:04] <divec>	 mooeypoo: Can I hassle you to try out https://gerrit.wikimedia.org/r/177946/ if you haven't already? (Native cursoring)
[22:54:58] <mooeypoo>	 divec, ooooh. Okay, let me try it out. I was going to discuss something with RoanKattouw_away but he's away now anyways.
[22:57:10] <grrrit-wm>	 (03PS20) 10Mooeypoo: [WIP] Transform the search widget to show image details [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161342 
[22:57:23] <aharoni>	 yo mooeypoo 
[22:57:37] <mooeypoo>	 heya aharoni 
[22:57:43] <mooeypoo>	 how is fatherhood going? :D
[22:58:24] <aharoni>	 I do my best coding in moments like this: https://twitter.com/aharoni/status/543134790820450305
[22:58:56] <aharoni>	 Jerusalem is rainy.
[22:59:10] <aharoni>	 mooeypoo: It would be nice if you could take a look at https://gerrit.wikimedia.org/r/#/c/179565/ .
[22:59:17] <divec>	 aharoni: that reads 'shshshsh!' right?
[22:59:26] <mooeypoo>	 divec, oops, I found a bug
[22:59:28] <aharoni>	 divec: yes.
[22:59:36] <divec>	 :-)
[22:59:42] <mooeypoo>	 aawwww!
[23:00:02] <divec>	 mooeypoo: Ahh! I claim it's a browser bug until proven otherwise!
[23:00:08] <divec>	 No, seriously, go on ...
[23:00:37] <mooeypoo>	 divec, okay I have a page that is all english, but I loaded my wiki in rtl more (local settings set to $wgLanguageCode = "he";)
[23:00:44] <mooeypoo>	 now, add an image in the middle of some random line
[23:00:56] <mooeypoo>	 basic image, so choose a smallish image
[23:01:26] <mooeypoo>	 now if you put the cursor in the beginning of the line and go forward (left) it reaches the image, skips it, and all is fine.
[23:01:40] <mooeypoo>	 Now go back from the end of the line (right) and it reaches the image and gets stuck
[23:02:15] <mooeypoo>	 divec, so, I added an image inside a word, "inform|ation"
[23:02:39] <mooeypoo>	 if I am in the "info" side, and I go right, the cursor stops after "r" and goes back and forth before and after the "r"
[23:02:45] <divec>	 mooeypoo: 1) which browser, and 2) completely stuck, or needs an extra keypress?
[23:02:45] <mooeypoo>	 which isn't even the edge of the image O.o
[23:03:29] <mooeypoo>	 divec, however many keypresses, it stays going back and forth before/after the letter "r" in "inform[IMAGE]ation"
[23:03:33] <mooeypoo>	 and Chrome
[23:03:36] <mooeypoo>	 let me check version
[23:04:04] <mooeypoo>	 divec, Chrome, version 39.0.2171.95 (64-bit). I'm going to test this in Firefox
[23:04:38] <divec>	 You mean it toggles between "info|rm<img>ation" and "infor|m<img>ation" on repeated right presses?
[23:04:45] <mooeypoo>	 divec, no problem in firefox.
[23:04:56] <mooeypoo>	 divec, exactly
[23:08:00] <mooeypoo>	 aharoni, sorry, not ignoring you, it looks good on a brief glance, but I need to test and I'm having a small issue with my oojs repo. Will test in a bit
[23:08:07] <aharoni>	 mooeypoo: np
[23:14:20] <MatmaRex>	 mooeypoo: i went to finally review "Eventify TemplateDataGenerator and use oojs-ui", but it still has some non-UI bugs in it
[23:14:50] <MatmaRex>	 mooeypoo: params.*.default apparently should be a string, not a multi-lingual string (or whatever)
[23:15:34] <MatmaRex>	 and by "should", i mean that templatadata generated with your tool refuses to save with "Property "params.align.default" is expected to be of type "string"." (for example)
[23:15:44] <mooeypoo>	 hm, really? in the spec?
[23:15:45] <mooeypoo>	 ahha
[23:18:43] <mooeypoo>	 MatmaRex, you're right, I don't know why I defined it as multilingual. In any case, it's a 1-line change, I'll change it now
[23:19:02] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: Eventify TemplateDataGenerator and use oojs-ui (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 (owner: 10Mooeypoo)
[23:19:26] <MatmaRex>	 i'm going to read through the code and give it a few more whacks
[23:20:04] <mooeypoo>	 MatmaRex, awesome. I'm pushing a fix
[23:20:40] <wikibugs>	 3VisualEditor, VisualEditor-InterfaceLanguage: VisualEditor page options menu goes off-screen in RTL wikis - https://phabricator.wikimedia.org/T76474#845145 (10Amire80) Setting appropriate left and right values for oo-ui-popupToolGroup-left and oo-ui-popupToolGroup-right by adding noflip seems to fix the issue,...
[23:20:44] <grrrit-wm>	 (03PS28) 10Mooeypoo: Eventify TemplateDataGenerator and use oojs-ui [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 
[23:20:52] <James_F>	 Krinkle|detached: Did RoanKattouw_away give you CR on your ResourceLoaderInOneFileOMG commit? :-)
[23:20:54] <mooeypoo>	 MatmaRex, ^^ fixed the default and the duplicate line. Thanks!
[23:23:21] <MatmaRex>	 mooeypoo: i wonder if we need to pull in that copy of jquery.uls.
[23:23:39] <mooeypoo>	 MatmaRex, it's a stripped down version
[23:23:47] <MatmaRex>	 looks like the kind of thing that's going to get out of date pretty soon :(
[23:23:58] <MatmaRex>	 hmm
[23:24:03] <mooeypoo>	 MatmaRex, I'm only using the data piece
[23:24:06] <mooeypoo>	 that shouldn't change anytime soon
[23:24:29] <MatmaRex>	 just to build the list of languages and codes?
[23:24:33] <mooeypoo>	 and if it does, we can update. In any case, we first check if the user has uls installed and only if they don't the local one is used
[23:24:44] <mooeypoo>	 yeah to get languages and antonyms 
[23:24:46] <MatmaRex>	 there is also a mediawiki.language.names module in MW core, have you looked at it?
[23:25:03] <mooeypoo>	 yeah. We're using uls also in VE for the language widget
[23:25:10] <mooeypoo>	 same purpose. In fact, I copied Ed's work
[23:25:14] <mooeypoo>	 ... shamelessly
[23:25:15] <mooeypoo>	 :D
[23:29:19] <James_F>	 Hey Krinkle.
[23:32:46] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [WIP] Transform the search widget to show image details [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161342 (owner: 10Mooeypoo)
[23:33:55] <mooeypoo>	 not npm again
[23:35:06] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: Eventify TemplateDataGenerator and use oojs-ui (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 (owner: 10Mooeypoo)
[23:35:44] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add noflip to oo-ui-popupToolGroup-left and -right [oojs/ui] - 10https://gerrit.wikimedia.org/r/179565 (owner: 10Amire80)
[23:40:05] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Eventify TemplateDataGenerator and use oojs-ui [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 (owner: 10Mooeypoo)
[23:40:50] <MatmaRex>	 mooeypoo: hmm, also.
[23:41:07] <MatmaRex>	 mooeypoo: i think your UI was hit by another breaking change,
[23:41:09] <MatmaRex>	 !g 8c25cfe9
[23:41:14] <MatmaRex>	 !gerrit 8c25cfe9
[23:41:17] <MatmaRex>	 blast
[23:41:20] <mooeypoo>	 ... crap, where
[23:41:31] <MatmaRex>	 https://gerrit.wikimedia.org/r/#/c/179000/ [BREAKING CHANGE] Split primary flag into primary and progressive
[23:42:09] <MatmaRex>	 all the buttons are suspiciously bland :)
[23:42:32] <mooeypoo>	 eh
[23:43:14] <MatmaRex>	 mooeypoo: also, are you intentionally using .$element.hide()/.show() instead of .toggle(true/false)?
[23:43:31] <mooeypoo>	 isn't it the same?
[23:43:47] <mooeypoo>	 toggle( false ) is the same as hide() isn't it?
[23:44:03] <MatmaRex>	 mostly, yeah
[23:44:20] <MatmaRex>	 it emits some events and generally does some unnecessary work
[23:44:25] <mooeypoo>	 oh
[23:44:39] <mooeypoo>	 I can change it. I didn't realize it matters
[23:44:47] <MatmaRex>	 i don't think it does
[23:44:58] <MatmaRex>	 was just wondering if you ran into any issues or something
[23:45:14] <mooeypoo>	 I use .toggle() for cases of "if x show / else hide" things
[23:45:21] <mooeypoo>	 not.. that I was aware of
[23:45:41] <mooeypoo>	 seems I have missed a hide() though, heh
[23:46:19] <MatmaRex>	 mooeypoo: (i mean, OO.ui.Widget#toggle, not jQuery toggle)
[23:46:25] <MatmaRex>	 anyway, doesn't matter
[23:46:35] <mooeypoo>	 oh, I thought you meant jquery toggle
[23:46:37] <mooeypoo>	 ha.
[23:46:39] <mooeypoo>	 hm
[23:47:44] <mooeypoo>	 yeah it emits another event, in the cases I've used I don't think it's necessary
[23:48:33] <aharoni>	 OH COME ON what's wrong with those failing builds https://gerrit.wikimedia.org/r/#/c/179565/ .
[23:48:34] <Krinkle>	 jquery toggle or hide/show doesn't matter. That's a 1-line shortcut. Wiget#toggle does a few things though. An event and also ensures isVisible() stays accurate.
[23:48:56] <Krinkle>	 which seems like a source of bugs if circumvented
[23:55:10] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 04-1] Eventify TemplateDataGenerator and use oojs-ui (035 comments) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 (owner: 10Mooeypoo)
[23:56:11] <MatmaRex>	 aharoni: just ignore them :(