[09:56:16] (03PS1) 10Catrope: Record whitespace on generated empty paragraphs correctly [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179879 [09:56:18] (03PS1) 10Catrope: Fix whitespace consistency checking when child has no whitespace property [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179880 [09:58:13] 3MediaWiki-ResourceLoader, WikiEditor: Update browser blacklists for WikiEditor modules - https://phabricator.wikimedia.org/T78527#847483 (10Schnark) 3NEW [11:02:21] 3MediaWiki-ResourceLoader, WikiEditor: Update browser blacklists for WikiEditor modules - https://phabricator.wikimedia.org/T78527#847602 (10Aklapper) p:5Triage>3Normal [12:20:51] 3VisualEditor: Insufficient span tags stripping? - https://phabricator.wikimedia.org/T78540#847764 (10Elitre) 3NEW [13:03:35] 3VisualEditor-ContentEditable: Display categories in ns category - https://phabricator.wikimedia.org/T78541#847822 (10Juandev) 3NEW [13:07:34] 3VisualEditor-ContentEditable: Allow to edit inputbox - https://phabricator.wikimedia.org/T78542#847831 (10Juandev) 3NEW [13:21:25] 3VisualEditor: "Watch this page" field in save window has the wrong status in a subsequent edit - https://phabricator.wikimedia.org/T78543#847849 (10Raymond) 3NEW [13:23:16] 3VisualEditor-ContentEditable: Enable VE in editing galleries - https://phabricator.wikimedia.org/T78544#847856 (10Juandev) 3NEW [13:26:38] 3VisualEditor: Use VE to creat new pages - https://phabricator.wikimedia.org/T78545#847866 (10Juandev) 3NEW [13:31:45] 3VisualEditor: Use VE to creat new pages - https://phabricator.wikimedia.org/T78545#847875 (10Catrope) [13:31:48] 3VisualEditor-MediaWiki, VisualEditor: VisualEditor: Where VisualEditor is the primary editor, redlinks in read mode should go to veaction=edit not action=edit - https://phabricator.wikimedia.org/T55441#847876 (10Catrope) [13:43:19] RAWR [13:43:25] .oo-ui-bookletLayout-stackLayout .oo-ui-panelLayout [13:43:27] COME ON [13:43:34] It's called a child selector [13:53:46] 3VisualEditor: Edit source tab should not hijack middle-click - https://phabricator.wikimedia.org/T78546#847897 (10Catrope) 3NEW a:3Krenair [13:54:58] 3Analytics, VisualEditor: [gadsh] "VisualEditor: Latency" graphs look dead - https://phabricator.wikimedia.org/T78547#847905 (10Nemo_bis) 3NEW [13:55:19] 3Analytics, VisualEditor: [gdash] "VisualEditor: Latency" graphs look dead - https://phabricator.wikimedia.org/T78547#847905 (10Nemo_bis) a:3Jdforrester-WMF [13:56:21] 3VisualEditor: Link inspector inside media dialog has too much padding - https://phabricator.wikimedia.org/T78548#847915 (10Catrope) 3NEW a:3Catrope [14:07:52] (03PS1) 10Catrope: Sprinkle some child selectors around in BookletLayout styles [oojs/ui] - 10https://gerrit.wikimedia.org/r/179912 [14:15:46] 3OOjs-UI: Compress OOjs UI PNGs with pngcrush -brute -reduce - https://phabricator.wikimedia.org/T76148#847966 (10Nemo_bis) 5declined>3Open [14:37:39] 3OOjs-UI: Compress OOjs UI PNGs with pngcrush -brute -reduce - https://phabricator.wikimedia.org/T76148#848026 (10Nemo_bis) [15:34:46] 3VisualEditor: The undo link in the page history leads to the source editor and not VisualEditor - https://phabricator.wikimedia.org/T78550#848117 (10Amire80) 3NEW [15:44:08] (03CR) 10Zfilipin: "Hashar, Gemfile.lock is changed automatically on her windows machine when she runs bundler. I am fine with keeping the change in this com" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/122400 (owner: 10Jagori79) [15:48:39] (03CR) 10Catrope: "Why not put Gemfile.lock in .gitignore?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/122400 (owner: 10Jagori79) [16:14:04] (03PS1) 10Catrope: [VERY VERY WIP] DocumentSet and subdocuments [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179940 [16:15:52] (03PS1) 10Catrope: [VERY VERY WIP] MW change for subdocuments; use for image captions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/179941 [16:16:42] (03CR) 10jenkins-bot: [V: 04-1] [VERY VERY WIP] MW change for subdocuments; use for image captions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/179941 (owner: 10Catrope) [16:47:06] 3OOjs-UI: Compress OOjs UI PNGs with pngcrush -brute -reduce - https://phabricator.wikimedia.org/T76148#848217 (10matmarex) a:5matmarex>3None [16:58:08] * James_F waves. [16:58:35] hello ^_^ [17:01:14] Oh look, someone on my team is alive [17:01:25] Yay! [17:03:38] RoanKattouw: Is it sucheta? :-) [17:04:29] Wat. [17:04:50] [18:01] RoanKattouw Oh look, someone on my team is alive [17:04:54] I meant you, James_F [17:05:12] Muhahaha. [17:05:14] RoanKattouw: I'm in Product. Clearly I'm not on your team. :-) [17:05:19] The first VE team member to say anything since I joined this channel 8 hours ago [17:05:20] OK, fine [17:05:24] Then sucheta wins the honor [17:05:24] * James_F grins. [17:05:28] +u. [17:05:35] Did I say 8? I meant 10 [17:05:49] * RoanKattouw needs to stop waking up at 5:30 [17:05:55] RoanKattouw: Indeed. [17:06:07] RoanKattouw: But in the mean time, keep working! ;-) [17:06:35] I admit I was in IST for a week, but not anymore. [17:08:22] sucheta: So now that I am on IST, you're not any more? :P [17:08:42] 3Analytics, VisualEditor: [gdash] "VisualEditor: Latency" graphs look dead - https://phabricator.wikimedia.org/T78547#848245 (10Jdforrester-WMF) [17:08:43] 3VisualEditor, Performance-Metrics-Dashboard: VE performance dashboard broken - https://phabricator.wikimedia.org/T78106#848246 (10Jdforrester-WMF) [17:10:05] 3VisualEditor-MediaWiki, VisualEditor: VisualEditor: Offer ability to save without exiting (for saving your work in the middle of an editing session) - https://phabricator.wikimedia.org/T68847#848252 (10Jdforrester-WMF) [17:10:06] 3VisualEditor: Saving without leaving visual editor - https://phabricator.wikimedia.org/T78491#848251 (10Jdforrester-WMF) [17:10:21] I was on IST, because I was on jetlag. You're on IST, because, well, jetlag. So, apparently jetlag means belonging to IST, no matter where you travel to. [17:10:34] Clearly [17:10:47] Are you back on your normal timezone now? [17:11:12] Which is, like, Newfoundland time or something? ;) [17:12:08] Yes. No more zz-ing away from the crowd when everyone is up and functional. [17:12:29] * James_F grins. [17:12:49] Well, then I better get over this jetlag fast [17:12:55] sucheta: Only Moriel (and me, but I don't count) are now both (a) working and (b) doing so in the US. [17:13:10] Cause it sounds like I'm the only one in a non-US timezone [17:13:19] 3VisualEditor: Link inspector inside media dialog has too much padding - https://phabricator.wikimedia.org/T78548#848263 (10Jdforrester-WMF) p:5Triage>3Normal [17:13:21] RoanKattouw: Possibly. :-) [17:13:26] Case in point: I'm in Europe and NOBODY ELSE who is in Europe has spoken on IRC today [17:13:39] RoanKattouw: Maybe you scare them. [17:13:47] We killed the other folks? Haw. [17:14:06] I said 'scared'. You said 'killed'. Nice escalation there. :-) [17:14:18] Apparently that's how scary I am [17:14:29] Anyone who's scared of me dies, by definition [17:14:43] They were scared to death. Literally. [17:14:56] RoanKattouw: You are Medusa, clearly. [17:16:36] 3VisualEditor-MediaWiki, VisualEditor: Edit source tab should not hijack middle-click - https://phabricator.wikimedia.org/T78546#848271 (10Jdforrester-WMF) p:5Triage>3Normal [17:16:43] I was at college all day. :/ [17:17:33] Krenair: A fair reason. [17:18:38] 3VisualEditor-EditingTools, VisualEditor-InterfaceLanguage, VisualEditor: Don't text-transform: capitalize; section headers in the special character inserter - https://phabricator.wikimedia.org/T78327#848273 (10Jdforrester-WMF) p:5Triage>3Normal a:3Jdforrester-WMF [17:18:47] hm, does "The "Apply changes" button in the reference window of VisualEditor is now disabled until you make a change" really merit a tech news mention? :/ [17:19:37] Krenair: More than anything else, given it was asked for by at least a couple of community people. [17:22:42] (03PS1) 10Jforrester: SpecialCharacterInspector: Don't auto-capitalise the headings [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179957 [17:24:51] hi. [17:25:12] Hey. [17:30:45] Corruption alert: visualeditor-needcheck on svwiki: https://sv.wikipedia.org/?diff=29163216 [17:30:45] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=109956540 [17:30:45] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=109968358 [17:30:45] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=109981840 [17:30:45] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=109981998 [17:30:46] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=109982656 [17:30:46] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=33610003 [17:30:46] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=67342760 [17:30:47] Corruption alert: visualeditor-needcheck on ptwiki: https://pt.wikipedia.org/?diff=40848767 [17:30:47] Corruption alert: visualeditor-needcheck on ltwiki: https://lt.wikipedia.org/?diff=4679839 [17:30:48] Corruption alert: visualeditor-needcheck on fiwiki: https://fi.wikipedia.org/?diff=14512439 [17:32:18] sigh [17:37:15] Hah. I was at college for three days last week. [17:37:27] I can feeeeeel the sigh there. [17:38:26] sucheta: But you have something to show for it! [17:38:38] But I managed to conquer the Degree certificate, yes. [17:39:28] sucheta: Whoo. [18:04:50] ugh [18:19:50] (03CR) 10Esanders: [C: 032] [BREAKING CHANGE] PopupToolGroup and friends: Pay off technical debt [oojs/ui] - 10https://gerrit.wikimedia.org/r/179786 (owner: 10Bartosz Dziewoński) [18:22:48] (03Merged) 10jenkins-bot: [BREAKING CHANGE] PopupToolGroup and friends: Pay off technical debt [oojs/ui] - 10https://gerrit.wikimedia.org/r/179786 (owner: 10Bartosz Dziewoński) [18:24:48] RoanKattouw, MatmaRex, mooeypoo so the language select widget has been copied from VE to templateData, which is clearly a problem [18:25:42] MatmaRex: Ugh? [18:25:46] edsanders: You're thinking of a core library of MW-specific OOUI widgets that VE, TD, skins etc. can use? [18:25:47] Should we be separating out esoteric stuff like that into OOUI extensions [18:26:12] Hmm, except indeed VE-core isn't MW-specific. [18:26:15] Meh. [18:26:18] I don't think they have to be mw specific [18:26:22] edsanders: i wouldn't mind including it in OOUI itself [18:26:34] MatmaRex: When do we stop, though? [18:26:42] edsanders, why is that a problem? [18:26:47] 3VisualEditor, VisualEditor-MediaWiki: The undo link in the page history leads to the source editor and not VisualEditor - https://phabricator.wikimedia.org/T78550#848430 (10Jdforrester-WMF) p:5Triage>3Low [18:26:54] we already have some fairly esoteric stuff [18:27:07] James_F: when we stop breaking backwards-compatibility every other week :) [18:27:18] the language widget doesn't even work without a dependency on jQuery.i18n.data [18:27:28] MatmaRex: Sure, but more stuff in OOUI is more styling in every page's payload. [18:27:36] so we don't want to bloat OOUI [18:27:41] edsanders: So, move it to jQuery.i18n.data? [18:27:48] edsanders, it's not in OOUI though, it's in TemplateData extension [18:27:55] mooeypoo: Exactly. [18:28:19] It's a dependency of that extension. Plus, we check to see if ULS exists already before we use the attached version [18:28:37] James_F: if that's your only concern, then this particular dialog has no special styles for it. [18:28:37] mooeypoo: Ed is complaining about code duplication. [18:28:42] yes [18:28:48] MatmaRex: None at all? Impressive. [18:29:01] MatmaRex: Also code payload, but I care slightly less about that. [18:29:05] eh [18:29:06] i can't find any, at least. [18:29:14] MatmaRex: I want to defer modularising OOUI for as long as possible. [18:29:21] Meh, why do images grow when you edit them [18:29:22] MatmaRex: Modular libraries are the bane of sanity. [18:29:28] I take it this is one of many known image bugs? [18:29:31] I don't think we're duplicating that much code [18:29:33] RoanKattouw: Ouch. Not to me. [18:29:40] at it grows, we will probably need to split it up, but i'd also like to do it as late as possible [18:29:49] RoanKattouw, no no they shrink to me -- the difference between *user based* settings and *wiki based* settings [18:29:52] MatmaRex, it has CSS in VE [18:29:55] maybe that wasn't copied [18:29:56] Right [18:29:58] edsanders: where? [18:29:59] RoanKattouw, we don't do user-based settings [18:30:09] ve.ui.LangaugeSearchWidget.css [18:30:10] it = LanguageSearchDialog, right? [18:30:14] RoanKattouw, and it annoys me too, yes. My images shrink in VE. [18:30:22] oh [18:30:22] & LanguageResultWidget [18:30:26] ...but I'm logged out [18:30:36] Oh but Parsoid hard-codes some weird value doesn't it [18:30:44] RoanKattouw: 220px. [18:30:46] well, that's literally seven lines of CSS, then. :) [18:31:14] RoanKattouw: Which is the "normal" value for WMF projects. [18:31:18] i'd be more worried that it introduces some funky dependencies to UUI [18:31:19] OOUI [18:31:24] mooeypoo, 2 widgets and 4 files - that's more than a bit of boilerplate [18:31:28] MatmaRex: Indeed. [18:31:39] edsanders, James_F I'm not sure I understand the issue with the "duplication" here. We are using another library to populate a select widget. It's not *really* duplicated that much, it just uses that library in a select widget....? i don't know that we really need a language widget specifically [18:31:39] which is why I don't want to put it in OOUI [18:31:41] since it's using jquery.whatever for the list of languages, for some reason [18:32:00] ugh [18:32:12] MatmaRex: Because that's the closest there is to a standard. [18:32:15] mooeypoo: The duplication is that you copied code from VE into TemplateData. [18:32:30] Those two widgets are identical [18:32:36] Yes [18:32:51] LanguageSearchWidget is 140 lines of code [18:33:24] If extensions X&Y do the same we have 4 versions of LanguageSearchWidget in 4 repos [18:33:28] How many other projects would use such a thing, though? [18:33:35] if there's a bug or enhancement we need to fix it in all 4 [18:33:42] even 2 is too many for that much shared code [18:34:03] That raises a separate issue btw [18:34:08] any extension that has a language select widget, which on WMF projects is a lot [18:34:13] TemplateData has more than just that as code duplication [18:34:23] such as? [18:34:24] Because I was trying to make it look similar to the VE design [18:34:57] well, I ended up creating my own, but technically optionImportWidget is taken in its majority from VE's "show more" in the template dialog [18:35:15] Same with the parameters [18:35:35] I adjusted them slightly for my use, but they're pretty much taken (including design) from VE's template stuff [18:35:41] the point was to make things look the same. [18:35:54] So maybe we should rethink how TemplateData extension is done and how much it is dependent on VE? [18:36:14] Making it depend on VE would be a bit messy. [18:36:30] Theoretically TD is useful for people who don't have or use VE. [18:36:48] if it made sense to have a common base widget you could base those two on, then we should consider that too [18:37:04] edsanders: Make a TechDebt bug and move on? [18:37:05] ve.ui.MWMoreParametersResultWidget [18:37:13] language results is a simpler case to fix [18:37:15] and ve.ui.MWParameterResultWidget [18:37:19] I wasn't suggesting we fix it now [18:37:26] * James_F nods. [18:37:44] I wanted to see what the plans were, specifically how we'd go about creating OOUI extensions [18:37:47] If we can have a common base for widgets between VE and TD that would be extremely helpful [18:38:05] edsanders: I think the answer is "we don't have a plan yet". [18:38:28] ok, then we should come up with one [18:38:32] By definintion TD is supposed to look/behave as close as possible to VE's template dialog [18:38:49] I copied a lot of the CSS over, and adjusted and semi-copied some of the wigdets. [18:39:18] i can already imagine what the dependency tree is going to look like, ugh [18:39:31] Not sure how we can do that without being dependent on VE, though? I mean, I can't even depend strictly on ve-core, since these are MW-specific widgets. [18:39:36] dependency bush [18:39:42] haha [18:40:13] {OOjs -> OOjs UI, jQuery.language.data} -> VisualEditor -> VisualEditor-MediaWiki -> TemplateData [18:40:27] Fun times. [18:40:48] And that's ignoring the 10 libraries we use in VE. [18:40:50] :\ [18:42:04] eh, i think it would be reasonable to have a language selection widget/dialog in OOUI itself. [18:42:20] MatmaRex: With a dependency on jQuery.i18n.data? [18:42:49] at some point we'll probably want a date selection widget/dialog, color selection, and such; they will all be heavy [18:42:52] MatmaRex: Or do we make it pluggable with sources, and have something in jQuery.i18n.data that registers itself with OOUI as a supplier of data? [18:43:01] but they will probably all be JS-only [18:43:12] MatmaRex: I'm not a huge fan of making OOjs UI depend on jQuery.i18n.data. [18:43:17] 3OOjs-UI: Create infrastructure for shared OOUI widgets which don't belong in the main repo - https://phabricator.wikimedia.org/T78571#848501 (10Esanders) 3NEW [18:43:25] Thanks Ed. [18:43:29] we should totally put in the work to split off PHP+JS styles and JS styles at some point. [18:43:35] Yes [18:43:45] That'll be important in the longrun [18:43:47] 3OOjs-UI: Create infrastructure for shared OOjs UI widgets which don't belong in the main repo - https://phabricator.wikimedia.org/T78571#848509 (10Jdforrester-WMF) p:5Triage>3Normal [18:43:50] * James_F nods. [18:43:55] It'll be ooui-language -> [ooui, jquery.i18n.data] [18:44:01] James_F: me neither, but meh [18:44:11] edsanders: If we do that. [18:44:19] James_F: this being somewhat static data, i think we totally could just bake it in [18:44:30] there's not that much of it, either [18:44:36] edsanders: See my comments about not doing modularisation unless we really have to. [18:44:48] MatmaRex: Except in MW, where the data changes. [18:44:58] MatmaRex: Hence this entire design Ed came up with. [18:45:27] well you can pretend it's MW specific and make OOui-mw [18:45:49] James_F: what changes? it gets translated, i guess? [18:45:59] MatmaRex: I dunno. I'm not the expert, but yeah. [18:46:20] I think it's the NxN matrix of the name of every language in every language? [18:46:22] don't we already have a wonderful working machinery for translatable things? [18:46:23] that comes in from MW? [18:46:28] but I can see people building larger widgets in the future and us not wanting to bloat ooui [18:46:42] RoanKattouw, yes [18:46:53] CLDR extension [18:48:40] if we don't want to depend on jquery.uls, or to copy all the data, we could ship the dialog in OOUI with just the language codes and have it check if jquery.uls is present and only use it if it is… [18:49:06] MatmaRex: Or we could ignore it for now. :-) [18:49:51] James_F: i blame ed for raising the issue, i've been happily ignoring it until now :D [18:49:58] * James_F laughs. [18:50:20] Gotta go play taxi driver, back in ~30 [18:50:47] MatmaRex: CR on https://gerrit.wikimedia.org/r/#/c/179598/ and https://gerrit.wikimedia.org/r/#/c/179912/ appreciated. [18:57:32] (03CR) 10Jforrester: "Tag against https://phabricator.wikimedia.org/T49344 or make a sub-task for this?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179940 (owner: 10Catrope) [18:58:41] (03CR) 10Jforrester: [C: 04-1] Add 'done' button to find and replace dialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178878 (owner: 10Esanders) [18:58:53] (03CR) 10Bartosz Dziewoński: [C: 032] Sprinkle some child selectors around in BookletLayout styles [oojs/ui] - 10https://gerrit.wikimedia.org/r/179912 (owner: 10Catrope) [18:59:28] 3VisualEditor, OOjs-UI: Link inspector inside media dialog has too much padding - https://phabricator.wikimedia.org/T78548#848567 (10matmarex) [18:59:29] RoanKattouw_away, edsanders: What do you think re. doing a new release of OOjs UI before Wednesday? [19:06:48] (03Merged) 10jenkins-bot: Sprinkle some child selectors around in BookletLayout styles [oojs/ui] - 10https://gerrit.wikimedia.org/r/179912 (owner: 10Catrope) [19:08:10] (03CR) 10Bartosz Dziewoński: "I don't understand this change. Why is there a distinction on whether the OOUI Window is isolated or not? This code makes it possible to s" [oojs/ui] - 10https://gerrit.wikimedia.org/r/179598 (owner: 10Esanders) [19:08:28] 3VisualEditor, OOjs-UI: Link inspector inside media dialog has too much padding - https://phabricator.wikimedia.org/T78548#848581 (10Jdforrester-WMF) [19:08:35] 3VisualEditor, OOjs-UI: Link inspector inside media dialog has too much padding - https://phabricator.wikimedia.org/T78548#848582 (10Jdforrester-WMF) 5Open>3Resolved [19:09:32] (03CR) 10Bartosz Dziewoński: "…in fact, why do we even want to prevent scrolling, when the OOUI Windows are always inside a `position: fixed;` wrapper?" [oojs/ui] - 10https://gerrit.wikimedia.org/r/179598 (owner: 10Esanders) [19:28:17] 3VisualEditor-EditingTools, VisualEditor: Keyboard shortcuts dialog should do vertical not horizontal overflow - https://phabricator.wikimedia.org/T78179#848611 (10Jdforrester-WMF) [19:28:18] 3VisualEditor: [regression wmf11] Chrome only: Help - Keyboard shortcuts - 'Other' section is not displayed - https://phabricator.wikimedia.org/T76664#848610 (10Jdforrester-WMF) [19:30:56] 3OOjs-UI: PopupToolGroup technical debt is demanding that we pay it - https://phabricator.wikimedia.org/T78499#848626 (10Jdforrester-WMF) p:5Triage>3High [19:31:05] 3OOjs-UI: ClippableElement PopupToolGroup near right side of viewport hilariously broken - https://phabricator.wikimedia.org/T78447#848627 (10Jdforrester-WMF) p:5Triage>3High [19:31:05] (03PS1) 10Alex Monk: Edit/view source tab: Do not hijack middle click to display confirmation, only left click [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/179975 [19:34:20] (03CR) 10Bartosz Dziewoński: "What about Shift/Ctrl-click? We had a snippet for this somewhere." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/179975 (owner: 10Alex Monk) [19:37:38] (03CR) 10Bartosz Dziewoński: "jquery.suggestions.js:" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/179975 (owner: 10Alex Monk) [19:56:33] James_F: What all has landed since 0.5.0? [19:57:24] * [BREAKING CHANGE] PopupToolGroup and friends: Pay off technical debt (Bartosz Dziewoński) [19:57:24] * Sprinkle some child selectors around in BookletLayout styles (Roan Kattouw) [19:58:03] RoanKattouw: I assumed we'd wait for 0.6.0 for wmf14. [19:58:16] i have like, five more patches pending [19:59:08] the RTL one would be nice to get in - https://gerrit.wikimedia.org/r/179581 [19:59:35] MatmaRex: Sure, but it's the breaking change that makes us wary. [20:00:29] it's only technically breaking, and it's in toolbars, which only we use. it broke VE because we did stupid stuff in it. [20:00:36] Hmm. [20:00:42] RoanKattouw, thoughts? [20:00:58] (and we're still doing to stupid stuff, alas - changing font sizes of dropdown menu items) [20:01:04] the stupid stuff* [20:01:54] MatmaRex: That's intentional, though? [20:02:15] MatmaRex: You mean for the formatting menu to simulate the effect of applying the format? [20:02:24] 3VisualEditor: [Regression pre-wmf13]In Firefox, While changing the math node to Inline/Block for the first time in a page the text {\textstyle\math funtion} flickers on CE - https://phabricator.wikimedia.org/T78583#848726 (10Ryasmeen) 3NEW [20:02:28] MatmaRex: Or the Monobook inheritance re-over-ride the font-dize bit? [20:02:59] 3VisualEditor: In Firefox, While changing the math node to Inline/Block for the first time in a page the text {\textstyle\math funtion} flickers on CE - https://phabricator.wikimedia.org/T78583#848726 (10Ryasmeen) [20:03:07] James_F: I'd say, get edsanders to review some more of the (mostly MatmaRex-created) backlog, then do a release like tomorrow [20:03:15] RoanKattouw: OK, let's do that. [20:03:18] James_F: intentional, yes, doesn't make it less silly in my opinion :) [20:03:21] * James_F looks encouragingly at edsanders. [20:03:24] MatmaRex: :-P [20:03:33] MatmaRex: Google, Word, LibreOffice and others all do it. [20:06:54] I think we should keep that feature [20:11:31] * James_F too. [20:11:34] Hey Krinkle. [20:11:43] RoanKattouw: Did you CR Krinkle's RL patch? [20:14:11] 3VisualEditor-ContentEditable: Display categories in ns category - https://phabricator.wikimedia.org/T78541#848777 (10Krenair) It's difficult to understand this, but is it a duplicate of {T58289}? [20:14:26] James_F: I'm unwipping it now [20:14:35] Krinkle: Nice. [20:14:59] 3VisualEditor-MediaWiki, VisualEditor: Display categories in ns category - https://phabricator.wikimedia.org/T78541#848781 (10Jdforrester-WMF) [20:15:24] 3VisualEditor-MediaWiki, VisualEditor: Display categories in ns category - https://phabricator.wikimedia.org/T78541#847822 (10Jdforrester-WMF) >>! In T78541#848777, @Krenair wrote: > It's difficult to understand this, but is it a duplicate of {T58289}? AFAICT, yes. [20:15:33] 3VisualEditor-MediaWiki, VisualEditor: Display categories in ns category - https://phabricator.wikimedia.org/T78541#848784 (10Jdforrester-WMF) [20:15:34] 3VisualEditor-MediaWiki, VisualEditor: VisualEditor: When editing a file/category page, show the non-page composite components outside the VE surface in their "normal" place - https://phabricator.wikimedia.org/T58289#848785 (10Jdforrester-WMF) [20:16:14] Phabricator's duplicate system is backwards :( [20:16:49] There's a task for that. [20:17:36] Maybe it's just because I'm so used to the way bugzilla and otrs do it, but... [20:31:26] it is. [20:31:36] which task? [20:40:44] Hmm. Can't find it right now in the sea of things we want from them: https://phabricator.wikimedia.org/project/board/6/ [20:51:19] I wonder how much of those things are declined upstream now [20:53:32] I doubt many. [20:53:33] Anyway. [20:53:49] (03CR) 10Jforrester: [C: 032] MediaWiki theme: RadioInputWidget tweaks [oojs/ui] - 10https://gerrit.wikimedia.org/r/179624 (owner: 10Bartosz Dziewoński) [20:57:21] (03PS2) 10Alex Monk: Edit/view source tab: Do not hijack middle click to display confirmation, only left click [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/179975 [20:57:53] (03Merged) 10jenkins-bot: MediaWiki theme: RadioInputWidget tweaks [oojs/ui] - 10https://gerrit.wikimedia.org/r/179624 (owner: 10Bartosz Dziewoński) [21:08:17] (03PS1) 10Alex Monk: Set 's' accesskey on save button inside save dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/179988 [21:08:52] 3VisualEditor, VisualEditor-MediaWiki: The (Ctrl+Alt+S) keyboard shortcut opens the Save dialog but should also trigger save when in it - https://phabricator.wikimedia.org/T76161#849015 (10Krenair) a:3Krenair [21:20:31] 3VisualEditor, VisualEditor-EditingTools, VisualEditor-MediaWiki: [Regression wmf11] Pressing Escape while a dialog is open closes the editor, should only close the dialog - https://phabricator.wikimedia.org/T78201#849033 (10Jdforrester-WMF) 5Open>3Resolved [21:20:56] 3VisualEditor, VisualEditor-EditingTools: In Firefox, While changing the math node to Inline/Block for the first time in a page the text {\textstyle\math funtion} flickers on CE - https://phabricator.wikimedia.org/T78583#849035 (10Jdforrester-WMF) p:5Triage>3Low [21:21:26] 3VisualEditor, VisualEditor-MediaWiki: "Watch this page" field in save window has the wrong status in a subsequent edit without refreshing the page - https://phabricator.wikimedia.org/T78543#849038 (10Jdforrester-WMF) p:5Triage>3Low [21:22:31] 3VisualEditor, Analytics-Engineering: Dashboard repository for Edit schema - https://phabricator.wikimedia.org/T76744#849042 (10Jdforrester-WMF) p:5Triage>3High [21:22:44] 3VisualEditor, Analytics-Engineering: Dashboard repository for Edit schema - https://phabricator.wikimedia.org/T76744#819244 (10Jdforrester-WMF) [21:22:45] 3VisualEditor, OOjs-UI: Link inspector inside media dialog has too much padding - https://phabricator.wikimedia.org/T78548#849045 (10Jdforrester-WMF) [21:22:47] 3VisualEditor, VisualEditor-EditingTools, VisualEditor-MediaWiki: [Regression wmf11] Pressing Escape while a dialog is open closes the editor, should only close the dialog - https://phabricator.wikimedia.org/T78201#849044 (10Jdforrester-WMF) [21:22:48] 3OOjs-UI, VisualEditor, VisualEditor-MediaWiki-Templates, VisualEditor-MediaWiki: Vertical alignment of the "add template" button and the search box is incorrect in template dialog in VisualEditor when using the OOjs UI MediaWiki theme - https://phabricator.wikimedia.org/T78052#849046 (10Jdforrester-WMF) [21:22:51] 3VisualEditor, OOjs-UI, VisualEditor-MediaWiki: Vertical height of panel controls is too low in MediaWiki theme - https://phabricator.wikimedia.org/T78031#849047 (10Jdforrester-WMF) [21:22:52] 3VisualEditor, OOjs-UI, VisualEditor-MediaWiki: Need for a muted destructive state for buttons which are destructive but not important workflow items in the OOjs UI MediaWiki theme - https://phabricator.wikimedia.org/T78040#849048 (10Jdforrester-WMF) [21:22:54] 3VisualEditor, OOjs-UI: "+" icon in VE transclusion dialog missing in MediaWiki theme - https://phabricator.wikimedia.org/T78177#849049 (10Jdforrester-WMF) [21:22:55] 3VisualEditor-MediaWiki-Templates, VisualEditor, OOjs-UI: Parameter entries aren't indented in the transclusion dialog's booklet layout in VisualEditor when using the OOUI MediaWiki theme - https://phabricator.wikimedia.org/T78321#849051 (10Jdforrester-WMF) [21:22:56] 3VisualEditor, OOjs-UI, VisualEditor-MediaWiki: Replace and Replace all buttons are clipped in VisualEditor when using the OOjs UI MediaWiki theme - https://phabricator.wikimedia.org/T78042#849050 (10Jdforrester-WMF) [21:22:57] 3VisualEditor-ContentEditable, VisualEditor, VisualEditor-EditingTools: Trim selections with whitespace on the end when annotating - https://phabricator.wikimedia.org/T53023#849052 (10Jdforrester-WMF) [21:22:59] 3VisualEditor, OOjs-UI, VisualEditor-MediaWiki: Parameter "add more information" field floats very oddly in the transclusion dialog in VisualEditor when using the OOUI MediaWiki theme - https://phabricator.wikimedia.org/T78034#849054 (10Jdforrester-WMF) [21:23:00] 3VisualEditor, OOjs-UI: Disabled scrollbars appear in some PopupWidgets in MediaWiki theme (Page options → Advanced) - https://phabricator.wikimedia.org/T78178#849053 (10Jdforrester-WMF) [21:23:02] 3VisualEditor, OOjs-UI, VisualEditor-MediaWiki: Parameter "add more information" label "No unused fields" placed oddly in the transclusion dialog in VisualEditor when using the OOUI MediaWiki theme - https://phabricator.wikimedia.org/T78035#849055 (10Jdforrester-WMF) [21:23:03] 3VisualEditor, OOjs-UI, VisualEditor-MediaWiki: Height of ButtonSelectWidget is too high in MediaWiki theme - https://phabricator.wikimedia.org/T78029#849056 (10Jdforrester-WMF) [21:23:04] 3VisualEditor, VisualEditor-MediaWiki-Media, VisualEditor-MediaWiki: Width layout issues in the media insert window - https://phabricator.wikimedia.org/T78050#849058 (10Jdforrester-WMF) [21:23:05] 3VisualEditor, OOjs-UI, VisualEditor-MediaWiki: Height of the toolbar is insufficient for a button to appear there in the OOjs UI MediaWiki theme - https://phabricator.wikimedia.org/T78043#849057 (10Jdforrester-WMF) [21:23:07] 3VisualEditor, VisualEditor-MediaWiki-Mobile: [Regression wmf11] VE is not opening in mobile - https://phabricator.wikimedia.org/T76660#849061 (10Jdforrester-WMF) [21:23:08] 3VisualEditor, OOjs-UI, VisualEditor-MediaWiki: Vertical alignment of text alongside checkbox is off in MediaWiki theme - https://phabricator.wikimedia.org/T78030#849062 (10Jdforrester-WMF) [21:23:10] 3VisualEditor, OOjs-UI: Toolbars should have a heavy shadow on their bottom in the MediaWiki theme - https://phabricator.wikimedia.org/T78085#849059 (10Jdforrester-WMF) [21:23:11] 3VisualEditor, OOjs-UI, VisualEditor-MediaWiki: We need to pick a highlight colour and use it consistently in VisualEditor when using the OOjs UI MediaWiki theme - https://phabricator.wikimedia.org/T78047#849060 (10Jdforrester-WMF) [21:23:12] 3VisualEditor, VisualEditor-Performance: Instrument how quickly after load users make their first keyboard interaction (first keyDown?) - https://phabricator.wikimedia.org/T76524#849063 (10Jdforrester-WMF) [21:23:14] 3VisualEditor, VisualEditor-MediaWiki: Entering ";" does not trip the wikitext warning that it won't work - https://phabricator.wikimedia.org/T71689#849064 (10Jdforrester-WMF) [21:23:15] 3VisualEditor, VisualEditor-MediaWiki: Use '{{' and '^==' wikitext fragments as keyboard shortcuts - https://phabricator.wikimedia.org/T53897#849065 (10Jdforrester-WMF) [21:23:18] 3VisualEditor, VisualEditor-EditingTools: When user inputs */1. at the start of the line, make it a bulletted/numbered list - https://phabricator.wikimedia.org/T53408#849066 (10Jdforrester-WMF) [21:23:19] 3VisualEditor, VisualEditor-MediaWiki-Templates, VisualEditor-MediaWiki: [Regression?] Links in transclusion nodes can point to /w/PageName if browsing from /w/index.php?veaction=edit - https://phabricator.wikimedia.org/T76379#849070 (10Jdforrester-WMF) [21:23:20] 3VisualEditor, OOjs-UI, VisualEditor-MediaWiki: We should set "destructive" on parameter remove buttons in the transclusion dialog in VisualEditor when using the OOUI MediaWiki theme - https://phabricator.wikimedia.org/T78033#849069 (10Jdforrester-WMF) [21:23:22] 3VisualEditor, VisualEditor-MediaWiki: Message 'visualeditor-find-and-replace-regular-expression' missing - https://phabricator.wikimedia.org/T78180#849068 (10Jdforrester-WMF) [21:23:23] 3VisualEditor, VisualEditor-Performance, VisualEditor-MediaWiki: LinkCache sends API requests for URL-encoded page names, gets "invalid" responses back when descending into template contents - https://phabricator.wikimedia.org/T75823#849073 (10Jdforrester-WMF) [21:23:24] 3VisualEditor, VisualEditor-MediaWiki-Mobile: [Regression wmf9] VisualEditor fails to load (ve.ui.MobileContext.css not defined?) - https://phabricator.wikimedia.org/T75646#849072 (10Jdforrester-WMF) [21:23:26] 3VisualEditor, VisualEditor-InterfaceLanguage, VisualEditor-EditingTools: Search and replace has weird display in RTL wikis - https://phabricator.wikimedia.org/T76807#849071 (10Jdforrester-WMF) [21:23:27] 3VisualEditor: [Regression pre-wmf10] VisualEditor does not load on beta labs - https://phabricator.wikimedia.org/T75896#849076 (10Jdforrester-WMF) [21:23:29] 3VisualEditor-MediaWiki-Links, VisualEditor: Use [[ as a 'hotkey' trigger for opening the 'create a link' dialog - https://phabricator.wikimedia.org/T52093#849075 (10Jdforrester-WMF) [21:23:30] 3VisualEditor, VisualEditor-MediaWiki: [Regression ?wmf3] Non-normalised category names cause "Uncaught TypeError: Cannot read property 'hidden' of undefined" to be thrown - https://phabricator.wikimedia.org/T74080#849074 (10Jdforrester-WMF) [21:23:31] 3VisualEditor-Initialisation, VisualEditor, VisualEditor-Performance, VisualEditor-MediaWiki: Surface is not destroyed when you exit VE if you ever opened the save dialog - https://phabricator.wikimedia.org/T75589#849078 (10Jdforrester-WMF) [21:23:33] 3VisualEditor, VisualEditor-MediaWiki: MediaWiki:Visualeditor-wikitext-warning-link should link mediawiki.org - https://phabricator.wikimedia.org/T69273#849077 (10Jdforrester-WMF) [21:23:34] 3VisualEditor, VisualEditor-MediaWiki: Toolbar help menu doesn't render nicely if the alert (edit notices) other half of the group isn't active - https://phabricator.wikimedia.org/T63575#849079 (10Jdforrester-WMF) [21:23:35] 3VisualEditor-Performance, VisualEditor-MediaWiki, VisualEditor: Prefer HTML5 Web Storage over cookies for state not needed server-side - https://phabricator.wikimedia.org/T64884#849080 (10Jdforrester-WMF) [21:23:36] 3VisualEditor-ContentEditable, VisualEditor: [Regression pre-wmf12] Pressing return on CE is not adding newline in Firefox - https://phabricator.wikimedia.org/T77905#849081 (10Jdforrester-WMF) [21:23:38] 3VisualEditor-ContentEditable, VisualEditor: data-ve-clipboard-key span inserted in page - https://phabricator.wikimedia.org/T76749#849082 (10Jdforrester-WMF) [21:23:39] 3VisualEditor, VisualEditor-EditingTools: Add support for
s - https://phabricator.wikimedia.org/T53009#849083 (10Jdforrester-WMF) [21:23:40] 3VisualEditor: [Regression pre-wmf10] oo-ui-icon-help is missing - https://phabricator.wikimedia.org/T75946#849084 (10Jdforrester-WMF) [21:23:42] 3VisualEditor, VisualEditor-MediaWiki: WT create tab on Special:Undelete when looking at a page is changed to "Edit source" rather than "create source", but VE tab is correct - https://phabricator.wikimedia.org/T68885#849087 (10Jdforrester-WMF) [21:23:43] 3VisualEditor-ContentEditable, VisualEditor, VisualEditor-MediaWiki: Preserve `data-parsoid` attribute on internal copy-paste so that Parsoid preserves e.g. syntax layout - https://phabricator.wikimedia.org/T74426#849086 (10Jdforrester-WMF) [21:23:44] 3VisualEditor-ContentLanguage, VisualEditor: VisualEditor: Some icons need to be flipped for RTL languages - https://phabricator.wikimedia.org/T65593#849085 (10Jdforrester-WMF) [21:23:46] 3VisualEditor, VisualEditor-MediaWiki: When user is saving a page subsequently deleted after they started editing, show them - https://phabricator.wikimedia.org/T54073#849088 (10Jdforrester-WMF) [21:24:34] 3VisualEditor: First word in new paragraph disappears after pressing space - https://phabricator.wikimedia.org/T76281#849096 (10Jdforrester-WMF) I believe that this issue should be fixed as of wmf12. [21:37:46] (03PS3) 10Cmcmahon: [BrowserTest] Adding tests for checking fields under Page Settings [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178741 (owner: 10Ryasmeen) [21:59:45] 3VisualEditor-ContentLanguage, VisualEditor: First word in new paragraph using an IME disappears after pressing space - https://phabricator.wikimedia.org/T76281#849245 (10Jdforrester-WMF) 5Open>3Resolved [22:11:17] RoanKattouw: Do you think there's anything left on https://phabricator.wikimedia.org/T13270 for us to do? It's assigned to you from a while ago. [22:14:40] 3VisualEditor-ContentEditable, VisualEditor: Enable VE in editing galleries - https://phabricator.wikimedia.org/T78544#849290 (10Jdforrester-WMF) [22:14:41] 3VisualEditor-ContentEditable, VisualEditor: Allow to edit inputbox - https://phabricator.wikimedia.org/T78542#849291 (10Jdforrester-WMF) [22:14:43] 3VisualEditor, VisualEditor-EditingTools: Leading white spaces - https://phabricator.wikimedia.org/T78137#849293 (10Jdforrester-WMF) [22:16:30] James_F: It was about moving section edit links to the left [22:16:34] AFAICT that has happened [22:16:37] RoanKattouw: Yeah. [22:16:42] RoanKattouw: So, close? [22:16:45] Yes [22:16:48] Kk. [22:16:57] Don't remember which commit it was that finally did stick, but it's been fixed for a long time [22:17:22] This was a biannual ritual for me, rebasing Aryeh's patch onto master [22:17:29] * James_F grins. [22:17:35] I mean, before "rebasing" and "master" were words in my vocabulary, of course :) [22:17:42] I was updating the patch to apply cleanly to trunk, [22:17:44] is what it was [22:18:07] Do you mean twice-annually (biannually) or once every two years (biennially)? [22:29:34] 3Performance-Metrics-Dashboard, VisualEditor: VE performance dashboard broken - https://phabricator.wikimedia.org/T78106#849370 (10Jdforrester-WMF) >>! In T78106#843895, @Qgil wrote: > Can @memeht help here? See T78130. I don't know offhand how gdash is configured, however, so I'm not much help. [22:29:54] (03CR) 10Esanders: [C: 032] [WIP] Don't round() measured sizes [oojs/ui] - 10https://gerrit.wikimedia.org/r/179494 (owner: 10Bartosz Dziewoński) [22:30:02] (03CR) 10Esanders: [C: 04-2] [WIP] Don't round() measured sizes [oojs/ui] - 10https://gerrit.wikimedia.org/r/179494 (owner: 10Bartosz Dziewoński) [22:30:02] biennially [22:30:08] edsanders: I was about to say.... [22:30:16] James_F: I was wondering what the word was [22:30:24] (03CR) 10Esanders: [WIP] Don't round() measured sizes (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/179494 (owner: 10Bartosz Dziewoński) [22:30:29] Also for twice annually I think I would say semi-annually [22:30:49] RoanKattouw: That also works. [22:30:58] RoanKattouw: I avoid saying "Biannually" for this reason. [22:31:02] doesn't look WIP - think the commit message needs to be updated [22:31:19] (03PS2) 10Bartosz Dziewoński: Don't round() measured sizes [oojs/ui] - 10https://gerrit.wikimedia.org/r/179494 [22:31:24] that was "WIP" as in "i haven't tested it" [22:31:53] But Ed now has? [22:31:58] (03CR) 10Bartosz Dziewoński: Don't round() measured sizes (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/179494 (owner: 10Bartosz Dziewoński) [22:46:09] (03CR) 10Esanders: "Fixing the button widths is separate to this issue." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178878 (owner: 10Esanders) [23:12:28] (03CR) 10Jforrester: "Design of high-profile new tools shouldn't suck this badly, though." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178878 (owner: 10Esanders) [23:16:51] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: When inserting a media item, search Commons for the Wikidata item this page represents (if available) rather than title - https://phabricator.wikimedia.org/T53031#849515 (10Jdforrester-WMF) [23:26:32] 3Parsoid, VisualEditor: Insufficient span tags stripping? - https://phabricator.wikimedia.org/T78540#849523 (10Jdforrester-WMF) [23:38:44] 3VisualEditor, Parsoid: Insufficient span tags stripping? - https://phabricator.wikimedia.org/T78540#849546 (10ssastry) This looks like VE sending Parsoid HTML with the span tags which Parsoid promptly left behind as spans as there is no wikitext equivalents for that. I don't think Parsoid should start stripping... [23:42:03] (03PS1) 10Divec: Calculate unicorn offsets correctly [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/180072 [23:49:57] (03CR) 10Esanders: "It already "sucks", but you can't bully me into fixing it by -1ing unrelated patches :)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178878 (owner: 10Esanders)