[00:12:27] 3VisualEditor-ContentEditable, VisualEditor, Parsoid: Insufficient span tags stripping? - https://phabricator.wikimedia.org/T78540#849623 (10Jdforrester-WMF) Yeah, it's probably a VE-land corruption. [00:18:10] James_F: Hey. Could you take a look at VE here: http://public.christian.wikia-dev.com/core/index.php/Foo?veaction=edit [00:18:32] Is the look&feel the one you are going for? I just noticed that it looks different than mediawiki.org - and want to make sure that I'm not missing anything [00:18:48] InezK: Yeah – that's going live in wmf13 and beyond. [00:18:59] sweet, I like the new design [00:19:00] InezK: TrevorB. said you'd want to stay with Apex. [00:19:12] InezK: Either way, whatever works - it should interoperate flawlessly. [00:19:16] "Should". :-) [00:19:28] James_F: so this thing is not Apex? [00:19:40] InezK: Indeed, this is the "MediaWiki" theme for OOjs UI. [00:19:42] Rather than Apex. [00:20:30] ok, I see, so, mediawiki.org will look like that soon? [00:21:10] Yeah, and all the others by January. [00:21:28] Apex will remain the default OOjs UI theme, and the default theme for VisualEditor stand-alone. [00:21:50] But MediaWiki will ship with OOjs UI's MediaWiki theme (reasonably enough ;-)). [00:22:00] Not sure if it meshes with Wikia's plans. [00:23:18] http://public.christian.wikia-dev.com/core/extensions/VisualEditor/lib/ve/demos/ve/desktop.html#!/src/pages/aliens.html == apex [00:23:25] * James_F nods. [00:23:27] http://public.christian.wikia-dev.com/core/index.php/Foo?veaction=edit == MediaWiki theme [00:25:01] ok, let me try to get MediaWiki + VisualEditor in no apex [00:25:09] in apex!! [00:25:20] The magic lines are at the bottom of resources/Resources.php [00:30:01] ok [00:30:03] thank [00:30:04] thanks [00:51:35] 3VisualEditor: [Regression pre-wmf13]Uncaught TypeError: Cannot read property 'createElement' of null appears after adding a citation without required parameter - https://phabricator.wikimedia.org/T78626#849740 (10Ryasmeen) 3NEW [03:08:40] 3VisualEditor-MediaWiki, VisualEditor: VisualEditor: Where VisualEditor is the primary editor, redlinks in read mode should go to veaction=edit not action=edit - https://phabricator.wikimedia.org/T55441#849782 (10Juandev) I reported this as a nead to create new page with VE. In this ligt there is a not logic mes... [03:11:44] 3VisualEditor-MediaWiki, VisualEditor: VisualEditor: Where VisualEditor is the primary editor, redlinks in read mode should go to veaction=edit not action=edit - https://phabricator.wikimedia.org/T55441#849783 (10Juandev) >>! In T55441#840960, @matmarex wrote: > I am not sure of this change will be beneficial at... [06:02:55] 3VisualEditor, VisualEditor-Performance: Combine API requests required to load VE - https://phabricator.wikimedia.org/T78628#849811 (10ori) 3NEW a:3Catrope [07:25:48] 3MediaWiki-ResourceLoader: ResourceLoader: mw.loader.using() promise is indefinitely "pending" if load request is aborted - https://phabricator.wikimedia.org/T68598#849821 (10Fomafix) Steps to reproduce: * Load MediaWiki from localhost. * Stop the Webserver. -> All further requests gets aborted. * Try to make a... [07:26:57] 3MediaWiki-ResourceLoader: ResourceLoader: mw.loader.using() promise is indefinitely "pending" if load request is aborted - https://phabricator.wikimedia.org/T68598#849822 (10Fomafix) [07:28:01] 3MediaWiki-ResourceLoader: ResourceLoader: mw.loader.using() promise is indefinitely "pending" if load request is aborted - https://phabricator.wikimedia.org/T68598#715503 (10Fomafix) [07:54:52] (03CR) 10Bartosz Dziewoński: [C: 032] Edit/view source tab: Do not hijack middle click to display confirmation, only left click [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/179975 (owner: 10Alex Monk) [07:57:28] (03Merged) 10jenkins-bot: Edit/view source tab: Do not hijack middle click to display confirmation, only left click [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/179975 (owner: 10Alex Monk) [08:09:38] 3VisualEditor-MediaWiki, VisualEditor: VisualEditor: Where VisualEditor is the primary editor, redlinks in read mode should go to veaction=edit not action=edit - https://phabricator.wikimedia.org/T55441#849854 (10matmarex) What I meant is that a vocal group of English Wikipedia users hates VisualEditor's guts an... [09:37:11] 3MediaWiki-ResourceLoader: ResourceLoader: mw.loader.using() promise is indefinitely "pending" if load request is aborted - https://phabricator.wikimedia.org/T68598#850004 (10Fomafix) The `crossDomain: true` prevents a callback on HTTP errors. Without `crossDomain: true`: ``` var d = $.ajax( { url: '/', dataTyp... [10:27:35] 3VisualEditor, VisualEditor-Performance: Combine API requests required to load VE - https://phabricator.wikimedia.org/T78628#850069 (10Catrope) This is a duplicate of several tickets, and should probably become a tracking ticket. I'll find them and make them all subtasks of this one. [10:43:37] 3VisualEditor: LinkCache prepopulation in ApiVisualEditor should include page being edited - https://phabricator.wikimedia.org/T78642#850096 (10Catrope) 3NEW [10:44:18] 3VisualEditor, VisualEditor-Performance: Combine API requests required to load VE - https://phabricator.wikimedia.org/T78628#850103 (10Catrope) [10:47:28] 3VisualEditor, VisualEditor-Performance: Combine API requests required to load VE - https://phabricator.wikimedia.org/T78628#850108 (10Catrope) [10:49:06] 3VisualEditor, VisualEditor-Performance: Combine API requests required to load VE - https://phabricator.wikimedia.org/T78628#849811 (10Catrope) [10:56:22] (03PS1) 10Amire80: WIP [BrowserTest] Change the Hading menu item from a to span [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180139 [10:56:50] 3VisualEditor: LinkCache prepopulation in ApiVisualEditor should include page being edited - https://phabricator.wikimedia.org/T78642#850116 (10Catrope) a:3Krenair [10:57:02] (03PS2) 10Amire80: WIP [BrowserTest] Change the Heading menu item from a to span [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180139 [10:57:44] (03CR) 10Amire80: "Just something that I found while working on the classes for toolbar elements. It's not related to that patch, so I'm sending this separat" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180139 (owner: 10Amire80) [11:01:35] 3VisualEditor, VisualEditor-Performance: Combine API requests required to load VE - https://phabricator.wikimedia.org/T78628#850119 (10Catrope) Also it's worth mentioning that only the action=visualeditor request blocks loading VE (which is reasonable because it delivers the Parsoid HTML). The prop=info and imag... [11:12:17] 3VisualEditor-EditingTools, VisualEditor: Template suggestions are not appearing in production while trying to add a template - https://phabricator.wikimedia.org/T78643#850130 (10Elitre) 3NEW [11:41:26] (03CR) 10Catrope: [C: 032] Calculate unicorn offsets correctly [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/180072 (owner: 10Divec) [11:44:04] (03Merged) 10jenkins-bot: Calculate unicorn offsets correctly [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/180072 (owner: 10Divec) [12:06:17] (03PS11) 10Amire80: WIP Add classes to toolbar UI elements [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174666 [12:22:40] 3VisualEditor-MediaWiki, VisualEditor: Random removal of categories - https://phabricator.wikimedia.org/T76998#850242 (10Elitre) Another diff, another example (confirmed this happens in Safari): https://fr.wikipedia.org/w/index.php?title=Ludmila_Pagliero&diff=next&oldid=109908395 An example on en.wp: https://en... [12:23:49] 3VisualEditor: VisualEditor screenshots-taking tests should link to the job that uploaded them from the file description page - https://phabricator.wikimedia.org/T78647#850236 (10Amire80) [12:27:20] 3VisualEditor: VisualEditor language screenshots come out with pixelated fonts - https://phabricator.wikimedia.org/T78648#850256 (10Amire80) 3NEW [12:49:06] (03PS12) 10Amire80: WIP Add classes to toolbar UI elements [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174666 [12:52:27] (03CR) 10Zfilipin: "@Catrope: Bundler documentation recommends adding Gemfile.lock to the repository. From http://bundler.io/:" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/122400 (owner: 10Jagori79) [12:57:52] (03CR) 10Zfilipin: [C: 031] "Looks good to me. Why is this WIP?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180139 (owner: 10Amire80) [13:03:04] (03CR) 10Catrope: "Hah, I guess that's because it's not a lock file, despite the name. Instead it seems to be a manifest of package names and version numbers" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/122400 (owner: 10Jagori79) [13:08:41] (03CR) 10Amire80: "It doesn't break anything, but it doesn't really make the test run either. Can be merged as far as I'm concerned. (Just remove "WIP".)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180139 (owner: 10Amire80) [13:14:29] (03CR) 10Zfilipin: WIP Add classes to toolbar UI elements (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174666 (owner: 10Amire80) [13:17:10] (03CR) 10Amire80: WIP Add classes to toolbar UI elements (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174666 (owner: 10Amire80) [15:08:20] 3VisualEditor, VisualEditor-EditingTools: De-bounce search-and-replace assessment until after user has finished typing - https://phabricator.wikimedia.org/T78234#850643 (10Esanders) That makes it less likely to explode, but doesn't fix the problem, which is that rendering 16000 highlights is too much. There shou... [15:31:30] 3VisualEditor, VisualEditor-EditingTools: De-bounce search-and-replace assessment until after user has finished typing - https://phabricator.wikimedia.org/T78234#850668 (10Catrope) I wonder how much not rendering off-screen would save. You'd save on a bunch of DOM modification, but you'd still have to find every... [15:35:22] (03CR) 10Bartosz Dziewoński: [C: 032] SpecialCharacterInspector: Don't auto-capitalise the headings [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179957 (owner: 10Jforrester) [15:37:18] (03CR) 10Bartosz Dziewoński: [C: 04-1] Prevent parent window scroll in modal mode using overflow hidden [oojs/ui] - 10https://gerrit.wikimedia.org/r/179598 (owner: 10Esanders) [15:39:18] (03Merged) 10jenkins-bot: SpecialCharacterInspector: Don't auto-capitalise the headings [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179957 (owner: 10Jforrester) [15:55:44] (03PS1) 10Esanders: Limit number of find and replace results to render [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/180195 [16:32:26] 3VisualEditor, Parsoid, RESTBase: Store & load data-mw separately - https://phabricator.wikimedia.org/T78676#850842 (10GWicke) 3NEW [16:33:04] 3VisualEditor, Parsoid, MediaWiki-General-or-Unknown, MediaWiki-Interface, RESTBase, Services: Use Parsoid HTML for read-only views too - https://phabricator.wikimedia.org/T55784#850849 (10GWicke) [16:33:36] 3VisualEditor, Parsoid, MediaWiki-General-or-Unknown, MediaWiki-Interface, RESTBase, Services: Use Parsoid HTML for read-only views too - https://phabricator.wikimedia.org/T55784#554184 (10GWicke) [16:47:01] (03CR) 10Esanders: "In isolated mode the scroll event does bubble up because the parent has a different window. If you have a scrollable area in your window, " [oojs/ui] - 10https://gerrit.wikimedia.org/r/179598 (owner: 10Esanders) [16:49:54] 3VisualEditor, Parsoid, RESTBase: Store & load data-mw separately - https://phabricator.wikimedia.org/T78676#850875 (10GWicke) [16:57:41] (03CR) 10Bartosz Dziewoński: "Let me rephrase:" [oojs/ui] - 10https://gerrit.wikimedia.org/r/179598 (owner: 10Esanders) [17:00:19] edsanders: http://i.imgur.com/M4bz1By.png [17:00:48] (by the way, why are the action buttons broken, eh…) [17:03:44] (03CR) 10Bartosz Dziewoński: "http://i.imgur.com/M4bz1By.png" [oojs/ui] - 10https://gerrit.wikimedia.org/r/179598 (owner: 10Esanders) [17:04:25] 3VisualEditor, Parsoid, RESTBase: Store & load data-mw separately - https://phabricator.wikimedia.org/T78676#850907 (10GWicke) [17:09:07] (03CR) 10Esanders: "The problem is the user intended to cause the dialog contents to scroll - and what actually happens is something different and not intende" [oojs/ui] - 10https://gerrit.wikimedia.org/r/179598 (owner: 10Esanders) [17:22:14] edsanders: on a touchscreen, when flicking, the parent window is scrolled in isolated mode too. at least on my windows tablet. [17:23:18] yeah - I read some things about weighted scroll [17:23:26] it's not perfect [17:23:27] (03CR) 10Bartosz Dziewoński: "Oooh, okay, that makes sense now. Still, on a touchscreen, when flicking, the parent window is scrolled in isolated mode too (at least on " [oojs/ui] - 10https://gerrit.wikimedia.org/r/179598 (owner: 10Esanders) [17:29:08] hi [17:29:28] how does it come that VE offers in drop-down menu non-existent categories? [17:30:32] (03CR) 10Bartosz Dziewoński: [C: 031] "The code makes sense, but I am not entirely convinced if we want to do this." [oojs/ui] - 10https://gerrit.wikimedia.org/r/179598 (owner: 10Esanders) [17:30:35] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=109983886 [17:30:35] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=109983945 [17:30:35] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=109985211 [17:30:35] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=109985436 [17:30:35] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=109985475 [17:30:36] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=109993897 [17:30:36] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=110002213 [17:30:37] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=110005490 [17:30:37] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=33619529 [17:30:37] Corruption alert: visualeditor-needcheck on skwiki: https://sk.wikipedia.org/?diff=5914517 [17:30:37] Corruption alert: visualeditor-needcheck on skwiki: https://sk.wikipedia.org/?diff=5914519 [17:30:40] uh oh. [17:36:01] 3VisualEditor, VisualEditor-InterfaceLanguage, VisualEditor-EditingTools: Don't text-transform: capitalize; section headers in the special character inserter - https://phabricator.wikimedia.org/T78327#851014 (10Jdforrester-WMF) 5Open>3Resolved [17:42:19] 3VisualEditor, VisualEditor-MediaWiki: Edit source tab should not hijack middle-click - https://phabricator.wikimedia.org/T78546#851029 (10Jdforrester-WMF) 5Open>3Resolved [17:43:58] RoanKattouw_away: BTW, https://gerrit.wikimedia.org/r/178551 looks like Krinkle thinks it's OK to merge? [17:50:42] 3OOjs-UI: ClippableElement PopupToolGroup near right side of viewport hilariously broken - https://phabricator.wikimedia.org/T78447#851067 (10matmarex) [17:50:43] 3OOjs-UI: OOjs UI: Toolbar menu width isn't working in IE11 any more - https://phabricator.wikimedia.org/T74592#851068 (10matmarex) [17:50:44] 3OOjs-UI: OOjs UI: [Regression] Menu width isn't working in IE11 any more – see VisualEditor's 'Page options' drop down menu - https://phabricator.wikimedia.org/T74640#851069 (10matmarex) [17:51:12] 3OOjs-UI: OOjs UI: [Regression] Menu width isn't working in IE11 any more – see VisualEditor's 'Page options' drop down menu - https://phabricator.wikimedia.org/T74640#772678 (10matmarex) [17:52:28] (03CR) 10Esanders: "We already attempt to achieve for both mousewheel and arrow keys - it just so happens that it doesn't work for the mousewheel event, so th" [oojs/ui] - 10https://gerrit.wikimedia.org/r/179598 (owner: 10Esanders) [17:55:50] RoanKattouw_away: Also, thoughts on https://phabricator.wikimedia.org/T78540 appreciated. [18:02:22] (03PS21) 10Mooeypoo: [WIP] Transform the search widget to show image details [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161342 [18:13:21] 3VisualEditor: Icon "Non sighted" shown after saving even that editor has autoreview right - https://phabricator.wikimedia.org/T78691#851215 (10Raymond) 3NEW [18:15:56] Krinkle: Ha. [18:16:21] Krinkle: OK, now I get “Uncaught Error: Unknown dependency: jquery.json” [18:16:41] James_F: Is the regular special page working fine? [18:16:52] James_F: That sounds like you have an old extension installed still using jquery.json [18:17:13] Hmm. [18:17:28] Tests completed in 43 milliseconds. [18:17:34] 0 assertions of 0 passed, 0 failed. [18:17:38] … that's not good. [18:19:04] Nothing obvious. [18:20:25] Krinkle: 'jquery.json' doesn't appear in my install, AFAICT. Very odd. [18:21:31] (03PS1) 10Jforrester: Update VE core submodule to master (cb46d98) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180218 [18:22:04] 3VisualEditor, MediaWiki-extensions-FlaggedRevs: Icon "Non sighted" shown after saving even that editor has autoreview right - https://phabricator.wikimedia.org/T78691#851241 (10matmarex) Same as T60057? [18:23:17] 3VisualEditor, VisualEditor-EditingTools: De-bounce search-and-replace assessment until after user has finished typing - https://phabricator.wikimedia.org/T78234#851248 (10Esanders) So I considered the render on screen things, and as you point out you'd have occasional problems with floated things or worse, posi... [18:30:35] (03CR) 10Jforrester: [C: 032] Add 'done' button to find and replace dialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178878 (owner: 10Esanders) [18:30:37] (03CR) 10jenkins-bot: [V: 04-1] Add 'done' button to find and replace dialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178878 (owner: 10Esanders) [18:33:02] James_F, why do the deployment project names contain underscores and things? [18:33:35] James_F: Maybe comment out extensions in your localsettings for a bit, and verify your mediawiki-core checkout git status is clean (presumably on my branch) [18:33:56] Krinkle: I don't have a LocalSettings file. [18:34:03] Krinkle: Vagrant, remember? It's all puppet. [18:34:09] James_F: Not my problem. :P [18:34:44] Krinkle: It is if you want feedback. [18:34:45] James_F: I suppose there's a way to disable that without actually uninstalling stuff [18:34:53] Krenair: Separation, apparently. [18:35:01] Krenair: I'm a slave to tradition. ;-) [18:35:03] but why not spaces [18:35:10] James_F: Does vagrant keep git clones up to date? [18:35:32] James_F: Do you have additional extensions installed manually that are not puppetised? [18:35:39] Krinkle: Yes. But you're failing to pay attention to what I said. [18:36:01] Krenair: You can't have spaces in Phabricator project names and use them inline. Helpful, right? [18:36:14] James_F: There's nothing referencing 'jquery.json' in core. It was removed (as you know). If that's the error, it isn't related to my patch. I'm happy to help debug and fgure out that's doing it though. [18:36:18] ugh, of course [18:36:40] James_F: which you'll need as I imagine your medaiwiki core install doens't work properly at the moment [18:36:51] James_F: Does the error happen also when running the special page test normally in your browser? [18:36:55] (e.g. not via karma or grunt) [18:37:03] (in the browser console) [18:37:12] edsanders: Things for you: https://gerrit.wikimedia.org/r/#/c/179390/ https://gerrit.wikimedia.org/r/#/c/179880/ https://gerrit.wikimedia.org/r/#/c/179879/ in VE-core, https://gerrit.wikimedia.org/r/#/c/179002/ and https://gerrit.wikimedia.org/r/#/c/179988/ in VE-MW. [18:37:33] Krinkle: 0 assertions of 0 passed, 0 failed. [18:37:43] 3VisualEditor, VisualEditor-EditingTools: De-bounce search-and-replace assessment until after user has finished typing - https://phabricator.wikimedia.org/T78234#851296 (10Catrope) Yeah I was thinking of binary search too, but I don't know how reliable it'll be because the DOM sequence is similar to but not the... [18:38:01] Krinkle: And yes, sorry, failure there. [18:38:24] James_F: So it's failing to load the test suite due to a missing dependency. That means it's a direct dependency. [18:39:11] James_F: Maybe in the chrome console, type: copy(JSON.stringify(mw.loader.moduleRegistry, null, 4)); [18:39:14] Krinkle: How do I get it to tell me the module? stack: "Error: Unknown dependency: jquery.json↵ at sortDependencies (http://localhost:8080/w/load.php?debug=true&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20141216T174425Z:11153:12)↵ at sortDependencies (http://localhost:8080/w/load.php?debug=true&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=201 [18:39:15] 41216T174425Z:11199:7)↵ at sortDependencies (http://localhost:8080/w/load.php?debug=true&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20141216T174425Z:11199:7)↵ at resolve (http://localhost:8080/w/load.php?debug=true&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20141216T174425Z:11222:7)↵ at Object.mw.loader.load [as load] (http://localhost: [18:39:15] 8080/w/load.php?debug=true&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20141216T174425Z:12179:17)↵ at Object. (http://localhost:8080/wiki/Special:JavaScriptTest/qunit?debug=true:161:89)↵ at fire (http://localhost:8080/w/load.php?debug=true&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20141216T174425Z:3119:30)↵ at Object.self.fir [18:39:16] James_F: Paste into sublime and look for .json [18:39:16] eWith [as resolveWith] (http://localhost:8080/w/load.php?debug=true&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20141216T174425Z:3231:7)↵ at Object.deferred.(anonymous function) [as ready] (http://localhost:8080/w/load.php?debug=true&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20141216T174425Z:3321:34)↵ at handlePending (http://localhost:8080/ [18:39:18] w/load.php?debug=true&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20141216T174425Z:11341:14)" [18:39:20] Bah. [18:39:26] Sorry for mis-paste. [18:39:39] Krinkle: Undefined. [18:39:54] Bleh. [18:39:56] Never mind. [18:40:02] James_F: Well, if you inspect the exception, it'll be in the local variable of that exception. But it's easier to just look at the module registry probaby. [18:40:06] Talking to five people at once appears to be my limit. [18:40:12] :) [18:40:23] Aha. EventLogging. [18:40:25] WTF? [18:40:31] That's not depended on it for months. [18:40:41] James_F: maybe it's checked out an old commit? [18:40:53] Possibly. [18:41:29] Updating now. [18:44:17] RoanKattouw: The registry everybody knows but never really sees at once: [18:44:26] copy(JSON.stringify(mw.loader.moduleRegistry, null, 4)); // exec in Chrome on a wiki page, paste in Sublime [18:44:45] Just made that up, but I think I'll keep that under a snippet in chrome dev tools, gonna be useful. [18:45:10] 3VisualEditor: "Watch this page" option does not reflect the status of the article on de.wp - https://phabricator.wikimedia.org/T78694#851302 (10Elitre) 3NEW [18:45:22] 3VisualEditor, VisualEditor-EditingTools: De-bounce search-and-replace assessment until after user has finished typing - https://phabricator.wikimedia.org/T78234#851309 (10Esanders) getVisibleRange is only ever going to be an estimate due to floats and position absolute, and you'll probably add +/- 50% for good... [18:48:04] (03CR) 10Esanders: [C: 04-1] "Actually use it!" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179390 (owner: 10Catrope) [18:48:37] (03CR) 10Catrope: "I did? https://gerrit.wikimedia.org/r/179391" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179390 (owner: 10Catrope) [18:49:17] (03CR) 10Catrope: "Although there are a few places in VE core as well, fair enough" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179390 (owner: 10Catrope) [18:49:25] (03CR) 10Esanders: [C: 032] Fix whitespace consistency checking when child has no whitespace property [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179880 (owner: 10Catrope) [18:51:52] RoanKattouw, hey [18:51:54] (03CR) 10Esanders: "Now that it's 7 lines of code to make an empty paragraph should it be an internal function?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179879 (owner: 10Catrope) [18:52:41] (03CR) 10Catrope: "Actually I think we could simplify it by (ab)using processNextWhitespace()" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179879 (owner: 10Catrope) [18:55:02] (03CR) 10Esanders: [C: 031] Template dialog: Disable 'Apply changes' until a change is made [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/179002 (owner: 10Alex Monk) [18:55:30] (03PS2) 10Catrope: Add getter for toolbarDialogs in ve.ui.Surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179390 [18:55:38] (03CR) 10Esanders: [C: 032] Set 's' accesskey on save button inside save dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/179988 (owner: 10Alex Monk) [18:56:16] RoanKattouw, As I mentioned earlier I took a look at https://phabricator.wikimedia.org/T75822 - I was wondering about using something a bit like LinkCache to combine all these requests into batches? [18:56:42] (03CR) 10Esanders: "Do you want to do that here on in a new commit?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179879 (owner: 10Catrope) [18:56:53] Krenair: Do we need to do them up-front at all? [18:57:28] up-front? [18:57:58] (03Merged) 10jenkins-bot: Set 's' accesskey on save button inside save dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/179988 (owner: 10Alex Monk) [18:58:13] Krenair: Yeah [18:58:32] Krenair: It was always my intention to separate the promise-based interface out into an abstract subclass [18:58:39] *superclass [18:58:52] So LinkCache would inherit from that and add link-specific things, and we could have an ImageCache and what not [18:58:54] (03CR) 10Esanders: [C: 032] Add getter for toolbarDialogs in ve.ui.Surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179390 (owner: 10Catrope) [18:59:07] (03PS2) 10Bartosz Dziewoński: Add 'done' button to find and replace dialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178878 (owner: 10Esanders) [18:59:22] 3VisualEditor, VisualEditor-MediaWiki: The (Ctrl+Alt+S) keyboard shortcut opens the Save dialog but should also trigger save when in it - https://phabricator.wikimedia.org/T76161#851379 (10Jdforrester-WMF) 5Open>3Resolved [18:59:35] RoanKattouw, ok, so I didn't go that far and make a proper superclass for both LinkCache and ImageInfoQueue [18:59:40] (03CR) 10Esanders: "Needs rebasing" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/179391 (owner: 10Catrope) [19:00:00] (03CR) 10Esanders: "*or in a..." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179879 (owner: 10Catrope) [19:00:17] Krenair: That's fine, that'll be a magical future we can dream of :) [19:01:00] (03Abandoned) 10Catrope: Use getToolbarDialogs() from VE core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/179391 (owner: 10Catrope) [19:01:16] (03Merged) 10jenkins-bot: Add getter for toolbarDialogs in ve.ui.Surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179390 (owner: 10Catrope) [19:01:18] (03CR) 10Bartosz Dziewoński: [C: 032] "Meh." [oojs/ui] - 10https://gerrit.wikimedia.org/r/179598 (owner: 10Esanders) [19:01:42] I don't remember how well I tested this (did I test it at all?), got a bit stuck on that annoying scalable thing I spoke to Moriel about [19:01:51] (03PS1) 10Alex Monk: [WIP] Combine imageinfo requests by setting up a new class like LinkCache to request them all centrally [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180228 (https://bugzilla.wikimedia.org/75822) [19:02:06] then solved it, moaned on hangouts, and went to sleep [19:02:08] mooeypoo, ^ [19:02:55] Krenair: :-) [19:03:41] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Combine imageinfo requests by setting up a new class like LinkCache to request them all centrally [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180228 (https://bugzilla.wikimedia.org/75822) (owner: 10Alex Monk) [19:04:58] Krenair, oh that's clever [19:05:07] jenkins is moaning about my left over console.log >_> [19:05:23] (03Merged) 10jenkins-bot: Prevent parent window scroll in modal mode using overflow hidden [oojs/ui] - 10https://gerrit.wikimedia.org/r/179598 (owner: 10Esanders) [19:05:39] (03CR) 10Jforrester: [C: 032] Add 'done' button to find and replace dialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178878 (owner: 10Esanders) [19:07:44] James_F: https://gerrit.wikimedia.org/r/#/c/178948/ "This change added the .png and .min.css files. I don't think that was intentional, was it?" [19:08:30] Krenair, okay I haven't tested yet, but this is clever. [19:08:32] haha "// TODO: I have no words. " [19:09:12] 3VisualEditor: Break up ve.ce.Surface.js by functionality - https://phabricator.wikimedia.org/T78696#851410 (10Esanders) 3NEW [19:11:11] (03Merged) 10jenkins-bot: Add 'done' button to find and replace dialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178878 (owner: 10Esanders) [19:12:26] 3VisualEditor, Continuous-Integration: Jenkins: Convert mwext qunit from grunt-contrib-qunit (PhantomJS) to grunt-karma (Chromium) - https://phabricator.wikimedia.org/T74063#851420 (10Krinkle) Test comment to see if mentioning #Patch-For-Review adds it. [19:12:28] 3VisualEditor, VisualEditor-CopyPaste, MediaWiki-Page-editing, VisualEditor-MediaWiki: The read HTML should have hinting to allow full DOM copying (as opposed to just rich copying) from read mode into VE surfaces - https://phabricator.wikimedia.org/T54091#851422 (10Jdforrester-WMF) [19:12:44] 3VisualEditor, Continuous-Integration: Jenkins: Convert mwext qunit from grunt-contrib-qunit (PhantomJS) to grunt-karma (Chromium) - https://phabricator.wikimedia.org/T74063#851424 (10Krinkle) [19:15:58] 3VisualEditor, Parsoid, MediaWiki-extensions-Flow, VisualEditor-Performance, RESTBase: Move data-parsoid and possibly data-mw out of the DOM, add uids - https://phabricator.wikimedia.org/T54936#851428 (10Jdforrester-WMF) Moving data-mw out of the DOM would kill {T54091}. [19:24:11] 3VisualEditor, Parsoid, MediaWiki-extensions-Flow, VisualEditor-Performance, RESTBase: Move data-parsoid and possibly data-mw out of the DOM, add uids - https://phabricator.wikimedia.org/T54936#851472 (10Esanders) T54091 is already blocked in Firefox because it refuses to copy RDFa. [19:25:17] 3VisualEditor: [Regression pre-wmf13]Uncaught TypeError: Cannot read property 'createElement' of null appears after adding a citation without required parameter - https://phabricator.wikimedia.org/T78626#851475 (10Ryasmeen) Not happening anymore.Marking as closed [19:25:29] 3VisualEditor: [Regression pre-wmf13]Uncaught TypeError: Cannot read property 'createElement' of null appears after adding a citation without required parameter - https://phabricator.wikimedia.org/T78626#851476 (10Ryasmeen) 5Open>3Resolved [19:32:43] [18:29:22] how does it come that VE offers in drop-down menu non-existent categories? [19:34:37] Krinkle, when you have a moment, can you take a look at line 603 of this? https://gerrit.wikimedia.org/r/#/c/161342/21/modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js [19:35:26] Krinkle, I'm sanitizing unexpected information from the API response we discusssed. I'm ignoring the "permission" like you said, but there *are* some inconsistencies sometimes in the fields that I am still fetching (author, credit and description) [19:36:39] Krinkle, I went with as-safe-as-possibly-possibly route, where I check if it's complex html (multiple nodes) I just hide it with a "read more" link to the original info page -- then, if it's a link I rebuild it myself, and if it's text I strip it. Should be safe now, but I could use your expertise and advice on this. [19:36:47] James_F: Interesting, latest Firefox (Aurora) blocks pasting into the console (Scam warning). Requiring users to type "allow pasting" first. [19:37:12] Krinkle: Huh. [19:40:28] What is ve.Filibuster? It uses a new class 'Set' that I don't think we have a polyfill for and is not in browsers we support. [19:40:49] Ah, debugScripts [19:40:50] OK [19:45:27] It's a big red button David made, then gave an intriguing name so that unsuspecting developers would click it and crash their browsers [19:48:59] haha [19:49:09] David's version for an easter egg? [19:55:26] (03CR) 10Esanders: Don't round() measured sizes [oojs/ui] - 10https://gerrit.wikimedia.org/r/179494 (owner: 10Bartosz Dziewoński) [19:56:08] Krinkle, IIRC Facebook did something like that a while back? [19:56:30] Krenair: Nah, they write a bit warning to console.log [19:56:38] but pasting/exec works fine [19:57:18] console.log was disabled temporarily at some point [19:57:55] They disabled the input from the console itself via ES5 accessors, but can be circumvented. [19:58:00] so they stopped doing it afaik [19:58:00] 3VisualEditor, Parsoid, MediaWiki-extensions-Flow, VisualEditor-Performance, RESTBase: Move data-parsoid and possibly data-mw out of the DOM, add uids - https://phabricator.wikimedia.org/T54936#851527 (10Jdforrester-WMF) >>! In T54936#851472, @Esanders wrote: > T54091 is already blocked in Firefox because it ref... [19:58:32] it was this: https://stackoverflow.com/questions/21692646/how-does-facebook-disable-the-browsers-integrated-developer-tools [19:59:11] Krenair: it now looks like this http://i.imgur.com/UrZ8SW0.png [20:01:16] 3VisualEditor, VisualEditor-EditingTools: Add a cross button to close the Find-Replace panel or clicking on CE may slide it up ? - https://phabricator.wikimedia.org/T77933#851531 (10Jdforrester-WMF) 5Open>3Resolved [20:02:35] 3VisualEditor, VisualEditor-ContentEditable: Break up ve.ce.Surface.js by functionality - https://phabricator.wikimedia.org/T78696#851534 (10Jdforrester-WMF) p:5Triage>3Normal [20:05:51] Krenair: http://escape.alf.nu/20 [20:05:59] Krenair: function statements hoist outside block statements [20:06:25] Krenair: typing 'function window() {}' will redefine the local window reference. [20:06:35] and thus not trigger .console [20:06:36] ) [20:07:20] 3VisualEditor, MediaWiki-extensions-FlaggedRevs: Icon "Non sighted" shown after saving even that editor has autoreview right - https://phabricator.wikimedia.org/T78691#851543 (10Jdforrester-WMF) >>! In T78691#851241, @matmarex wrote: > Same as T60057? I think they're different. [20:07:54] 3VisualEditor, MediaWiki-extensions-FlaggedRevs: FlaggedRevisions icon "Non sighted" shown after saving even that editor has autoreview right - https://phabricator.wikimedia.org/T78691#851545 (10Jdforrester-WMF) p:5Triage>3Low [20:10:35] 3VisualEditor, MediaWiki-extensions-FlaggedRevs: FlaggedRevisions icon "Non sighted" shown after saving even that editor has autoreview right - https://phabricator.wikimedia.org/T78691#851550 (10Raymond) >>! In T78691#851241, @matmarex wrote: > Same as T60057? No, different bugs. This one is about after saving... [20:15:31] Hey RoanKattouw. [20:15:42] Hey [20:15:48] So yeah, the API merger stuff [20:15:53] There is already a task for this somewhere [20:15:58] "Provide an API to retrieve (Parsoid-generated) HTML in core" or something? [20:16:00] Oh, OK. [20:16:44] I just need to find it [20:16:47] RoanKattouw: https://phabricator.wikimedia.org/T64803 maybe you were thinking of? [20:16:52] That's just red links though. [20:16:55] No [20:17:01] There's an SoS ticket somewhere [20:17:36] Oh, https://phabricator.wikimedia.org/T50483 [20:17:40] Expose a parsoid public web API end point in the MediaWiki API [20:18:23] We're going to end up with $wgUsingParsoid or something ghastly, I can feel it. [20:18:25] Oh well. [20:18:30] Maaybe [20:18:38] I feel like there was another ticket [20:18:47] https://phabricator.wikimedia.org/T75955 ? [20:19:13] https://phabricator.wikimedia.org/T1218 [20:19:21] Oooh. [20:19:27] OK, had no idea about that. [20:19:32] It's in all the wrong teams. [20:19:38] Useless. [20:19:42] More or less spectacularly misunderstood ticket description, as well [20:20:32] 3VisualEditor, Parsoid, MediaWiki-extensions-Flow, VisualEditor-MediaWiki, MediaWiki-General-or-Unknown, RESTBase, Scrum-of-Scrums: use PHP Virtual REST Service to access Parsoid on private wikis (e.g. officewiki) - https://phabricator.wikimedia.org/T1218#851563 (10Jdforrester-WMF) [20:20:41] Want to re-write it from scratch? [20:21:28] Yeah I'll do that [20:22:22] Ta. [20:22:33] And we can make other things sub-tasks of this, maybe. Eh. [20:25:52] 3VisualEditor, Parsoid, MediaWiki-extensions-Flow, VisualEditor-MediaWiki, MediaWiki-General-or-Unknown, RESTBase, Scrum-of-Scrums: Use PHP Virtual REST Service to access Parsoid - https://phabricator.wikimedia.org/T1218#851565 (10Catrope) [20:27:23] 3VisualEditor, Parsoid, MediaWiki-extensions-Flow, VisualEditor-MediaWiki, MediaWiki-General-or-Unknown, RESTBase, Scrum-of-Scrums: Use PHP Virtual REST Service to access Parsoid - https://phabricator.wikimedia.org/T1218#851567 (10Jdforrester-WMF) p:5Normal>3High [20:28:00] 3VisualEditor: LinkCache prepopulation in ApiVisualEditor should include page being edited - https://phabricator.wikimedia.org/T78642#851571 (10Jdforrester-WMF) p:5Triage>3Normal [20:28:05] (03PS2) 10Alex Monk: [WIP] Combine imageinfo requests by setting up a new class like LinkCache to request them all centrally [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180228 [20:29:46] 3VisualEditor, Parsoid, MediaWiki-extensions-Flow, VisualEditor-MediaWiki, MediaWiki-General-or-Unknown, RESTBase, Scrum-of-Scrums: Use PHP Virtual REST Service to access Parsoid - https://phabricator.wikimedia.org/T1218#851577 (10Catrope) [20:35:52] RoanKattouw: You up for me doing an OOjs UI release? [20:36:03] RoanKattouw: "Only slightly breaking", per MatmaRex. :-) [20:38:04] RoanKattouw: And if so, want https://gerrit.wikimedia.org/r/#/c/179581 to land first? Looks sane to me. [20:42:08] James_F: 302 edsanders|away [20:42:18] RoanKattouw: 303 RoanKattouw. [20:42:47] RoanKattouw: He said sure, then left just as I was working out what was outstanding. [20:42:54] Lovely [20:43:08] (Sorry.) [20:43:44] MatmaRex: In https://gerrit.wikimedia.org/r/#/c/179581/3/src/elements/ClippableElement.js , why do cHeight and cWidth have +buffer? I would have expected -buffer [20:44:14] (03CR) 10Jforrester: [C: 032] ButtonGroupWidget: Remove weird margin-bottom: -1px; from theme styles [oojs/ui] - 10https://gerrit.wikimedia.org/r/179545 (owner: 10Bartosz Dziewoński) [20:44:36] * MatmaRex looks [20:44:42] Oh nm [20:44:44] It makes sense [20:44:49] Too many minus signs messing with my head [20:44:53] * James_F grins. [20:44:54] (03CR) 10Catrope: [C: 032] ClippableElement: Handle clipping with left edge [oojs/ui] - 10https://gerrit.wikimedia.org/r/179581 (owner: 10Bartosz Dziewoński) [20:45:01] Yay. [20:45:06] OK, thanks RoanKattouw. [20:45:28] Now I just need a release +2 once those merge. [20:45:40] Sure [20:47:46] (03Merged) 10jenkins-bot: ButtonGroupWidget: Remove weird margin-bottom: -1px; from theme styles [oojs/ui] - 10https://gerrit.wikimedia.org/r/179545 (owner: 10Bartosz Dziewoński) [20:48:48] (03Merged) 10jenkins-bot: ClippableElement: Handle clipping with left edge [oojs/ui] - 10https://gerrit.wikimedia.org/r/179581 (owner: 10Bartosz Dziewoński) [20:48:51] (The VisualEditor project is back to being an Umbrella in Phabricator.) [20:49:07] whee [20:50:17] (03PS1) 10Jforrester: Tag v0.6.0 [oojs/ui] - 10https://gerrit.wikimedia.org/r/180263 [20:50:30] RoanKattouw: Want to do the honours? :-) [20:51:04] (03CR) 10Amire80: "Thank you!" [oojs/ui] - 10https://gerrit.wikimedia.org/r/179581 (owner: 10Bartosz Dziewoński) [20:52:49] (03CR) 10Catrope: [C: 032] Tag v0.6.0 [oojs/ui] - 10https://gerrit.wikimedia.org/r/180263 (owner: 10Jforrester) [20:52:54] Ta. [20:54:24] 3OOjs-UI: OOjs UI: [Regression] Menu width isn't working in IE11 any more – see VisualEditor's 'Page options' drop down menu - https://phabricator.wikimedia.org/T74640#851634 (10Jdforrester-WMF) 5Open>3Resolved [20:54:25] 3OOjs-UI: PopupToolGroup technical debt is demanding that we pay it - https://phabricator.wikimedia.org/T78499#851636 (10Jdforrester-WMF) [20:54:38] 3OOjs-UI: PopupToolGroup technical debt is demanding that we pay it - https://phabricator.wikimedia.org/T78499#846875 (10Jdforrester-WMF) [20:54:40] 3OOjs-UI: OOjs UI: Toolbar menu width isn't working in IE11 any more - https://phabricator.wikimedia.org/T74592#851637 (10Jdforrester-WMF) 5Open>3Resolved [20:54:52] 3OOjs-UI: PopupToolGroup technical debt is demanding that we pay it - https://phabricator.wikimedia.org/T78499#846875 (10Jdforrester-WMF) [20:54:53] 3OOjs-UI: ClippableElement PopupToolGroup near right side of viewport hilariously broken - https://phabricator.wikimedia.org/T78447#851640 (10Jdforrester-WMF) 5Open>3Resolved [20:55:14] 3OOjs-UI: PopupToolGroup technical debt is demanding that we pay it - https://phabricator.wikimedia.org/T78499#851643 (10Jdforrester-WMF) 5Open>3Resolved [20:55:47] Hey mvolz. [20:59:46] (03Merged) 10jenkins-bot: Tag v0.6.0 [oojs/ui] - 10https://gerrit.wikimedia.org/r/180263 (owner: 10Jforrester) [21:03:20] James_F, I found a way to (somewhat) deal with insane output from the API, but it means we're basically hiding it. So, if I get any response that includes multiple nodes, I ignore it and instead display "More information" link to the original image description. that doesn't seem to happen often, but it does occasionally any in unexpected fields. Is that okay? [21:03:40] James_F, the best example is that image i sent you a bit ago - https://commons.wikimedia.org/wiki/File:Cows_in_green_field_-_nullamunjie_olive_grove.jpg [21:03:53] in that case, the "Author" field will display "More details" link to the page. [21:04:26] (03PS3) 10Jforrester: Update OOjs UI to v0.6.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179788 (owner: 10Bartosz Dziewoński) [21:05:45] 3VisualEditor: Couldn't click the horizontal scroll bar under Page Options. - https://phabricator.wikimedia.org/T78706#851675 (10T-man2396) 3NEW [21:07:35] crap, meh, that's actually not good. [21:09:23] (03CR) 10Jforrester: [C: 032] Update OOjs UI to v0.6.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179788 (owner: 10Bartosz Dziewoński) [21:09:43] (03CR) 10Cmcmahon: [C: 032] "merging to save rebase hassle later" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178741 (owner: 10Ryasmeen) [21:09:58] mooeypoo: Not good? [21:10:23] James_F, well, it works, but then it goes "more info" on something like "This is a screenshot from foo [21:10:25] :\ [21:10:35] so I'm trying to also test the combined length of the multiple nodes [21:10:37] mooeypoo: Eurgh. [21:13:03] James_F, okay, so, if a "complex response" (multiple nodes) is shorter than some length (say, 500 chars) it will be returned as-is. I think that is safe enough, considering I'm going $.parseHTML *and* it is all coming from wikitext parser. [21:13:10] Krinkle, RoanKattouw ^^ [21:13:30] mooeypoo: Sure, I guess. We'll probably have different thoughts after a while, but let's go with it. [21:13:31] return $( '
' ).html( parsed ); [21:14:06] James_F, yea the more api responses, the more adjustments, but I'm *trying* to at least get the more common madness under control without exposing ourselves to too much dangerous output [21:14:07] (03PS1) 10Krinkle: Remove use of bind() for inline functions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180301 [21:14:21] mooeypoo: :- [21:14:23] ) [21:14:24] Bah. [21:14:31] (03Merged) 10jenkins-bot: [BrowserTest] Adding tests for checking fields under Page Settings [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178741 (owner: 10Ryasmeen) [21:14:34] James_F, Even your smiley is frustrated. [21:14:34] :D [21:14:43] (03CR) 10Krinkle: [C: 04-1] [WIP] Transform the search widget to show image details (034 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161342 (owner: 10Mooeypoo) [21:14:45] (03Merged) 10jenkins-bot: Update OOjs UI to v0.6.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179788 (owner: 10Bartosz Dziewoński) [21:15:19] ha, we were just talking about 'bind' with anonymous functions last week [21:16:09] mooeypoo: don't use .html() on an empty element. Just use append() instead. [21:17:04] Krinkle, okay, I wasn't sure which. [21:18:28] 3VisualEditor: Couldn't click the horizontal scroll bar under Page Options. - https://phabricator.wikimedia.org/T78706#851697 (10Catrope) In which browser? This works for me in Chrome and Firefox. [21:18:49] mooeypoo: .html( foo ) is implemented as .empty().append( foo ) [21:18:55] RoanKattouw: You spoken to Krenair about the API yet? If not, I guess this is a cue. ;-) [21:18:56] oh [21:19:16] Was this the thing I mentioned earlier in the hangout? [21:19:27] No. [21:19:30] No, this is something that came out of our meeting with the mobile and Parsoid teams about an hour ao [21:19:34] oh, ok [21:19:35] RoanKattouw, we talked about having a difference between how .append() behaves in terms of security on Friday.. for some reason I thought I should not use it for the semi raw responses. [21:19:59] RoanKattouw: Yeah, plus some additional strange logic on top of empty/append. [21:20:08] mooeypoo: I think Krinkle wanted you to use .append( $.parseHtml( str ) ) but I'll let him speak for himsefl [21:20:20] Yeah, that sounds right. [21:20:22] Krenair: So there's all this code proxying to Parsoid in ApiVisualEditor.php [21:20:35] Krinkle, RoanKattouw, oh, okay, "parsed" is already after $.parseHtml() [21:20:43] 3VisualEditor: [Regression pre-wmf13]Uncaught TypeError: Cannot read property 'createElement' of null appears after adding a citation without required parameter - https://phabricator.wikimedia.org/T78626#851700 (10Ryasmeen) 5Resolved>3Open [21:20:46] As you can probably imagine, all this code is duplicated in Flow [21:20:50] we want to put it somewhere shared? [21:20:54] Yes [21:21:07] 3VisualEditor: [Regression pre-wmf13]Uncaught TypeError: Cannot read property 'createElement' of null appears after adding a citation without required parameter - https://phabricator.wikimedia.org/T78626#849740 (10Ryasmeen) Reproduced again in Betalabs [21:21:08] When Flow deployed to officewiki they were totally surprised that their code broke [21:21:24] And we were like "oh, yeah, cookie forwarding, we fixed this a year ago, look at how we did it" [21:21:36] At the time there was already a ticket for sharing this code but this put it back on our radar [21:21:37] :) [21:21:41] RoanKattouw: +2 on https://gerrit.wikimedia.org/r/#/c/180218/ please so I can do a cleaner pull-through? [21:21:45] Well this and the ambition to use Parsoid HTML as read HTML in mobile alpha [21:21:59] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (cb46d98) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180218 (owner: 10Jforrester) [21:21:59] So we want to move this out to Extension:Parsoid and make that a dependency (again)? [21:22:00] mooeypoo: yeah, html() and empty/append are only different if you give them strings. If you have nodes, you really shouldn't use html(), it works, btu is undocumented. [21:22:02] it takes htmlString [21:22:04] James_F: Psh Ed didn't even merge that one? [21:22:15] Krenair: Probably [21:22:17] RoanKattouw: Indeed. [21:22:18] Krenair: :S re dependency [21:22:38] Now IMO it's pretty clear-cut that this code should live in Extension:Parsoid [21:23:07] That's how I wrote https://phabricator.wikimedia.org/T1218 as well [21:23:11] Krinkle, oh, okay, that makes sense. [21:23:13] thanks [21:23:17] 3VisualEditor: Couldn't click the horizontal scroll bar under Page Options. - https://phabricator.wikimedia.org/T78706#851709 (10matmarex) Do you mean that the dropdown looks like this? {F21441} If yes, then this is T74640 and we've just fixed it. [21:23:28] Krenair: But then this happened in the meeting: https://office.wikimedia.org/wiki/Bash#December_2014 [21:23:54] (03CR) 10Jforrester: "Needs rebase (and merge)." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/179387 (owner: 10Catrope) [21:24:15] ah :) [21:24:26] So gwicke suggested that he had other opinions about where this code should go [21:24:39] (03Merged) 10jenkins-bot: Update VE core submodule to master (cb46d98) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180218 (owner: 10Jforrester) [21:24:42] In any case, someone needs to put this code somewhere shared [21:24:56] Looking at both VE and Flow's implementations [21:25:40] (I doubt Flow's is spectacularly better than ours given the cookie forwarding incident, and I doubt it has very different use cases from ours, but it's worth checkign) [21:28:54] (03PS3) 10Jforrester: Update VE core submodule to master (fe2d908) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/179789 (owner: 10Bartosz Dziewoński) [21:30:04] RoanKattouw: Can I grab a +2 on https://gerrit.wikimedia.org/r/180307 please? [21:31:12] Krenair: Anyway as you're probably familiar, the "someone" in "someone needs to do X" frequently ends up being me, so I'm always looking for people to hand stuff off to, and you were the one I thought of when we were talking about refactoring a bunch of ApiVisualEditor.php code [21:31:18] (Thanks to James_F for proving my point as I wrote that) [21:31:44] heh [21:32:17] :D [21:32:26] do we have a task in phabricator? [21:35:26] Krenair: [21:35:27] https://phabricator.wikimedia.org/T1218 [21:36:07] RoanKattouw: to be fair, you said you've been meaning to do it :P [21:36:43] Yes [21:37:18] That's true [21:37:32] I guess I no longer do, now I just want it to get done [21:37:50] :-) [21:40:26] RoanKattouw, description looks as expected, but "PHP Virtual REST Service"? aren't restbase and other services things a project of gabriel's? [21:40:38] Krenair: RESTbase is the backend. [21:40:53] on the parsoid side? [21:41:00] "Virtual REST service" is a really strange name [21:41:16] RESTbase will eventually be what we access Parsoid through [21:41:49] The great thing about sharing this code in the Parsoid extension is that when that move does happen, we've made updating the code their problem :P [21:42:21] RoanKattouw: :-) [21:42:34] :D [21:44:05] But in all seriousness, I'm sure the Parsoid team doesn't enjoy having to cajole two teams (soon three) when they make changes like those [21:44:33] the virtual rest service is an abstraction layer for service requests in core [21:44:44] https://www.mediawiki.org/wiki/Requests_for_comment/PHP_Virtual_REST_Service [21:45:14] RoanKattouw: Sorry, and https://gerrit.wikimedia.org/r/180310 and https://gerrit.wikimedia.org/r/180311 too? [21:45:29] currently it's primarily used for swift [21:45:38] haha RoanKattouw, I've been working for a while and then switched a moment to my windows PC -- it was so BRIGHT that I suddenly realize my work comp screen is all red -- and then I remembered you were the culprit. Thank you,btw :p it's really good for the eyes! [21:46:02] https://github.com/wikimedia/mediawiki/tree/master/includes/libs/virtualrest [21:46:12] RoanKattouw: ^^ [21:46:36] gwicke: Oh, wait, it already exists as a thing? [21:46:53] yeah, it's less virtual than you might think in some ways ;) [21:46:54] * @since 1.23 [21:46:56] Huh. [21:46:58] Never knew. [21:47:04] Aaron built it [21:47:40] RoanKattouw: Maybe it should live in MW-core? The Parsoid extension is a hack and isn't intended to exist long-term. [21:48:04] yeah, HTTP request wrappers should not live in random extensions [21:48:28] the Parsoid extension should die once we find a better way to do pub/sub [21:50:28] And "get me the HTTP block of the page" isn't really an extension's job. [21:51:11] one of the motivations behind the virtualrest thing is to be able to do parallel requests [21:51:38] so it can fetch several things in parallel, from different backend services [21:51:41] 3MediaWiki-Page-editing, MediaWiki-extensions-ProofreadPage: New improved LivePreview incompatible with ProofreadPage's fancy forms for Index: namespace pages - https://phabricator.wikimedia.org/T78709#851754 (10matmarex) 3NEW [21:53:39] Yeah sounds good to me [21:53:53] I didn't realize that virtualrest had already ceased to be vaporware :) [21:53:58] So yeah go ahead and put it there then [21:54:27] That does introduce the first real link (soft dependency) from MW core to Parsoid, but that was going to happen eventually I guess [21:54:39] Indeed. [21:54:53] Next step, we'll make Parsoid a sub-module of core and Chad will kill us. :-) [21:55:42] [22:51] gwicke so it can fetch several things in parallel, from different backend services [21:55:44] Ooooh [21:55:52] That's totally something we're gonna use for data-mw in the future then [21:55:59] *nod* [21:56:21] * RoanKattouw goes off to rewrite the ticket [21:56:30] you might be able to hide the cookie business in the parsoid backend handler [21:57:21] You know, I am a bit disappointed now, because now https://office.wikimedia.org/wiki/Bash#December_2014 ends with you being right :D [21:57:44] I'm sorry ;) [21:58:41] we are using a similar thing in restbase btw [21:59:08] requests to parsoid are to /v1/{domain}/_sys/parsoid/ [21:59:32] with the backend handler registered at that path being the only place where actual addresses etc are known [22:00:27] Krenair, gwicke: I've rewritten https://phabricator.wikimedia.org/T1218 per this conversation [22:00:56] coolio! [22:01:44] Krenair: I'm happy to help, as will likely be Aaron [22:02:09] RoanKattouw, hi [22:02:20] do anyone know what's the status of stuff in http://etherpad.wikimedia.org/p/OOjsUI-TODO ? [22:02:22] does* [22:02:31] RoanKattouw, ok, that seems like a different task now :) [22:03:12] Yes [22:03:52] I mean it still accomplishes the same thing but in a totally different way [22:04:06] And it'll hopefully be easier because VirtualREST should provide you with some infrastructure [22:04:24] Although I didn't know it existed until just now so I don't really know what it actually provides [22:05:20] (03PS2) 10Catrope: Record whitespace on generated empty paragraphs correctly [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179879 [22:05:38] 3OOjs-UI: Rename a lot of getters for consistency - https://phabricator.wikimedia.org/T76630#851795 (10matmarex) 5Open>3stalled [22:06:52] 3MediaWiki-extensions-Flow, Scrum-of-Scrums, VisualEditor, RESTBase, VisualEditor-MediaWiki, MediaWiki-General-or-Unknown, Parsoid: Use PHP Virtual REST Service to access Parsoid - https://phabricator.wikimedia.org/T1218#851806 (10GWicke) It might be nice to model the internal interface somewhat similar to the w... [22:12:42] (03PS1) 10Ryasmeen: [BrowserTest]WIP changing the css paths for Cite options for fixing the tests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180320 [22:16:33] 3VisualEditor-Performance, VisualEditor, VisualEditor-MediaWiki-Media: Combine (or defer until needed?) imageinfo requests on load - https://phabricator.wikimedia.org/T75822#851817 (10Krenair) a:3Krenair [22:26:44] Krinkle|detached, $.when.apply( null, ... ) - null instead of $? [22:27:05] I always use $.when.apply( $, ... ) [22:27:09] because $ is what the context would naturally be [22:27:21] (03PS2) 10Cmcmahon: [BrowserTest]WIP changing the css paths for Cite options for fixing the tests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180320 (owner: 10Ryasmeen) [22:33:55] (03PS3) 10Cmcmahon: [BrowserTest] changing the css paths for Cite options for fixing the tests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180320 (owner: 10Ryasmeen) [22:35:07] (03CR) 10Ryasmeen: [C: 032] "Paired with Chris" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180320 (owner: 10Ryasmeen) [22:36:53] (03Merged) 10jenkins-bot: [BrowserTest] changing the css paths for Cite options for fixing the tests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180320 (owner: 10Ryasmeen) [22:37:18] RoanKattouw_away, see https://gerrit.wikimedia.org/r/#/c/180301/1/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js [22:38:19] (03CR) 10Alex Monk: Remove use of bind() for inline functions (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180301 (owner: 10Krinkle) [22:38:38] (03PS22) 10Mooeypoo: [WIP] Transform the search widget to show image details [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161342 [22:39:30] (03CR) 10Esanders: [C: 032] Record whitespace on generated empty paragraphs correctly [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179879 (owner: 10Catrope) [22:43:45] (03Merged) 10jenkins-bot: Record whitespace on generated empty paragraphs correctly [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179879 (owner: 10Catrope) [22:52:02] 3MediaWiki-extensions-Flow, Scrum-of-Scrums, VisualEditor, RESTBase, VisualEditor-MediaWiki, MediaWiki-General-or-Unknown, Parsoid: Use PHP Virtual REST Service to access Parsoid - https://phabricator.wikimedia.org/T1218#21069 (10GWicke) [22:54:02] (03PS1) 10Ryasmeen: [BrowserTest]WIP Fixing options test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180336 [23:03:11] (03PS2) 10Ryasmeen: [BrowserTest]WIP Fixing options test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180336 [23:04:25] RoanKattouw_away: Yeah, but when you pass deferred.done or promise.then we don't bind to preserve that, either. [23:05:04] RoanKattouw_away: They're save to detach as being static methods, no need to rebind them. I'm fine either way. [23:05:24] Afaik the only exception to that in any known library in our scope is VE itself where there's 1 class doing very strange things with 'this' inside a static method. [23:05:49] anyhow, fine either way [23:23:27] (03CR) 10Krinkle: Remove use of bind() for inline functions (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180301 (owner: 10Krinkle) [23:25:32] (03PS2) 10Krinkle: Remove use of bind() for inline functions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180301 [23:25:39] (03CR) 10Krinkle: Remove use of bind() for inline functions (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180301 (owner: 10Krinkle) [23:27:16] (03CR) 10jenkins-bot: [V: 04-1] Remove use of bind() for inline functions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180301 (owner: 10Krinkle) [23:27:58] (03PS3) 10Krinkle: Remove use of bind() for inline functions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180301 [23:29:57] (03PS2) 10Jforrester: Fix whitespace consistency checking when child has no whitespace property [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179880 (owner: 10Catrope) [23:30:29] (03CR) 10Jforrester: [C: 032] "Per Ed." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179880 (owner: 10Catrope) [23:36:04] (03Merged) 10jenkins-bot: Fix whitespace consistency checking when child has no whitespace property [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179880 (owner: 10Catrope) [23:38:53] (03PS5) 10Jforrester: Improve support for multiple surfaces in demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178867 (owner: 10Esanders) [23:39:09] (03CR) 10Jforrester: [C: 032] "PS5 is a rebase." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178867 (owner: 10Esanders) [23:42:15] (03Merged) 10jenkins-bot: Improve support for multiple surfaces in demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178867 (owner: 10Esanders) [23:42:59] (03PS2) 10Jforrester: VE-MW fix commit for I4efbae614e [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/179387 (owner: 10Catrope) [23:43:21] (03CR) 10Jforrester: [C: 031] VE-MW fix commit for I4efbae614e [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/179387 (owner: 10Catrope) [23:45:43] (03CR) 10Jforrester: [C: 032] Refactor debug bar dump methods and add hide button [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178875 (owner: 10Esanders) [23:46:36] (03CR) 10Jforrester: [C: 04-1] "Making Ed's discontent more visible as a -1 here (feel free to ignore if he turns out to be happy)." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179242 (owner: 10Catrope) [23:47:28] Krenair: Can I steal some +2s from you? https://gerrit.wikimedia.org/r/#/c/180310/ in mw/vendor, https://gerrit.wikimedia.org/r/#/c/180311/ in mw/core (just boring updates), and then I'll need someone to +2 a VE pull-through. [23:48:19] (03Merged) 10jenkins-bot: Refactor debug bar dump methods and add hide button [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/178875 (owner: 10Esanders) [23:50:24] (03PS1) 10Jforrester: Update VE core submodule to master (fc3c1b4) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180354 [23:51:42] looking [23:51:55] Thanks. [23:53:08] Krenair: bd808 just grabbed them. [23:53:22] (ok, I got distracted) [23:53:31] No worries. :-) [23:59:16] Krenair: https://gerrit.wikimedia.org/r/#/c/179789/ and https://gerrit.wikimedia.org/r/#/c/180354/ need +2s, though. Boring, but…