[00:00:21] 3RESTBase, VisualEditor, Parsoid: Store & load data-mw separately - https://phabricator.wikimedia.org/T78676#852033 (10GWicke) [00:00:57] looking [00:03:24] 3MediaWiki-extensions-Flow, VisualEditor, RESTBase, VisualEditor-Performance, Parsoid: Move data-parsoid and possibly data-mw out of the DOM, add uids - https://phabricator.wikimedia.org/T54936#852052 (10GWicke) See also: T78676 Summary: To really make a difference for large / template-heavy pages, we need to r... [00:04:34] (03CR) 10Alex Monk: [C: 032] Update VE core submodule to master (fe2d908) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/179789 (owner: 10Bartosz Dziewoński) [00:08:32] (03CR) 10Alex Monk: [C: 032] Update VE core submodule to master (fc3c1b4) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180354 (owner: 10Jforrester) [00:08:50] (03Merged) 10jenkins-bot: Update VE core submodule to master (fe2d908) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/179789 (owner: 10Bartosz Dziewoński) [00:09:16] Thanks, Krenair. [00:10:31] (03Merged) 10jenkins-bot: Update VE core submodule to master (fc3c1b4) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180354 (owner: 10Jforrester) [00:11:24] (03CR) 10Alex Monk: [C: 032] Remove use of bind() for inline functions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180301 (owner: 10Krinkle) [00:13:25] (03Merged) 10jenkins-bot: Remove use of bind() for inline functions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180301 (owner: 10Krinkle) [00:13:43] 3MediaWiki-ResourceLoader, MediaWiki-Vagrant: Local vagrant super slow due to minifier - https://phabricator.wikimedia.org/T78733#852085 (10Jdlrobson) 3NEW [00:16:32] (03PS23) 10Mooeypoo: [WIP] Transform the search widget to show image details [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161342 [00:16:41] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Transform the search widget to show image details [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161342 (owner: 10Mooeypoo) [00:19:27] Krinkle: How aghast will you be if I use node -e to read and update MediaWiki's composer.json file? [00:20:49] (03PS24) 10Mooeypoo: [WIP] Transform the search widget to show image details [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161342 [00:53:21] James_F: If its more than 80 characters, I'd say simply put it in a js file and invoke it with node [00:53:28] could be next to update-oojs-ui.sh [00:53:33] Krinkle: Eww. [00:53:37] and called from within, so the user doesn't have to deal with it [00:53:43] update-oojs-ui-callme-please.js [00:54:12] Nah, update-composer-json.sh with some arguments like [00:54:22] Hmm. Possibly. [00:54:31] and called from inside update-oojs-ui.sh [00:54:33] update-composer-json.js could work. [00:54:49] It'll be worth the separate file in value of linting. [00:54:54] A bit error prone [00:55:03] Sure. [01:09:17] (03PS1) 10Alex Monk: Pre-populate LinkCache for page we're editing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180377 [01:15:15] James_F, you guys still want to assign https://phabricator.wikimedia.org/T1218 to me? [01:17:55] Krenair: Do you feel you know what to do? [01:18:00] No [01:18:06] Ha. :-) [01:18:28] Well then, probably best if you speak to Roan first (tomorrow == today for you)? [01:18:36] Roan originally poked me about it because it's dealing with VE-MW PHP stuff [01:18:41] Yeah. [01:18:46] or rather, was [01:18:58] now it's changed entirely [01:19:19] It is? [01:20:29] Well now it's "Write a Parsoid backend for VirtualRestService" [01:21:10] Krenair: it's just a different way of dressing it up, with the added bonus of supporting parallel requests [01:21:33] 3Mobile-Web, VisualEditor: VisualEditor broken for MobileFrontend - https://phabricator.wikimedia.org/T78710#852272 (10Jdlrobson) [01:21:37] * James_F nods. [01:22:20] apart from the bit about it being an entirely separate system :) [01:24:49] 3VisualEditor: Use URL from Commons to search for images within VisualEditor - https://phabricator.wikimedia.org/T78741#852278 (10Whatamidoing-WMF) 3NEW [01:25:52] 3VisualEditor: Use URL from foreign file repositories to search for images within VisualEditor - https://phabricator.wikimedia.org/T78741#852285 (10Krenair) [01:28:38] 3VisualEditor-MediaWiki-Mobile, Mobile-Web, VisualEditor: VisualEditor broken for MobileFrontend - https://phabricator.wikimedia.org/T78710#851761 (10Krenair) [01:33:28] Krinkle: https://gerrit.wikimedia.org/r/180379 [01:34:24] James_F: git-reset, -checkout -add take variadic arguments. [01:34:57] Will checkout later, maybe tomorrow. It's getting late and current into something else. [01:35:24] Krinkle: Yeah, but I didn't want to modify the common lines with the other scripts as much as possible. [01:35:28] Krinkle: Cool, thanks [01:37:07] [13oojs.github.io] 15jdforrester created 06oojs-ui-0.6.0 from 06oojs-ui-0.4.0 (+0 new commits): 02https://github.com/oojs/oojs.github.io/commits/oojs-ui-0.6.0 [01:37:59] (03PS3) 10Ryasmeen: [BrowserTest]Fixing options test Fixed the unique selector for failing cases Change-Id: I41bde7245328303fcc8c5afea8f7228c1d36b915 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180336 [01:40:00] (03CR) 10Jforrester: Pre-populate LinkCache for page we're editing (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180377 (owner: 10Alex Monk) [01:42:53] 3VisualEditor, VisualEditor-MediaWiki-Media: Use URL from foreign file repositories to search for images within VisualEditor - https://phabricator.wikimedia.org/T78741#852328 (10Jdforrester-WMF) p:5Triage>3Volunteer? [01:43:42] 3VisualEditor: Couldn't click the horizontal scroll bar under Page Options. - https://phabricator.wikimedia.org/T78706#852331 (10Jdforrester-WMF) 5Open>3stalled [01:48:41] (03CR) 10Alex Monk: Pre-populate LinkCache for page we're editing (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180377 (owner: 10Alex Monk) [01:49:42] gwicke, so where are these VirtualRESTService classes used at the moment? [01:50:18] Krenair: afaik only for swift [01:50:32] ok, where? [01:51:11] Krenair: Aaron Schulz would know in detal [01:51:15] *detail [01:51:18] did you grep for it? [01:52:08] didn't find anything in core's includes/ [01:52:14] https://github.com/wikimedia/mediawiki/search?utf8=%E2%9C%93&q=SwiftVirtualRESTService [01:52:39] so it's possible that it's not actually used yet [01:53:28] although I'm not sure if the swift stuff is all in core, or if some of it is in an extension [01:54:09] (03CR) 10Jforrester: Pre-populate LinkCache for page we're editing (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180377 (owner: 10Alex Monk) [01:55:48] Krenair: https://github.com/wikimedia/mediawiki/blob/7458dc32d99e6dd569b1629762443d074b6a3c52/includes/libs/virtualrest/VirtualRESTServiceClient.php is the way to use the thing; https://github.com/wikimedia/mediawiki/blob/7458dc32d99e6dd569b1629762443d074b6a3c52/includes/libs/virtualrest/VirtualRESTService.php is the base class for the backends [02:03:35] 3VisualEditor: Couldn't click the horizontal scroll bar under Page Options. - https://phabricator.wikimedia.org/T78706#852352 (10T-man2396) @Catrope I was on Internet Explorer, it works fine on Chrome. @matmarex Yes, that was it. [02:03:54] 3VisualEditor: Couldn't click the horizontal scroll bar under Page Options. - https://phabricator.wikimedia.org/T78706#852354 (10Jdforrester-WMF) Cool. :-) [02:04:14] 3VisualEditor: Couldn't click the horizontal scroll bar under Page Options. - https://phabricator.wikimedia.org/T78706#852355 (10Jdforrester-WMF) [02:04:15] 3OOjs-UI: OOjs UI: [Regression] Menu width isn't working in IE11 any more – see VisualEditor's 'Page options' drop down menu - https://phabricator.wikimedia.org/T74640#852356 (10Jdforrester-WMF) [02:14:50] James_F: Mmm nice. Phabricator supports Note/Warning/Important notices inside its markup. :D A bit funny but useful? [02:14:51] https://secure.phabricator.com/book/phabricator/article/remarkup/#layout [02:15:14] Krinkle: Let's not. [02:15:34] James_F: https://phabricator.wikimedia.org/T78553#850584 [02:15:52] Hehe, yeah, let's not [02:15:54] Eww. [02:16:35] Krinkle: Did you ever actually test https://gerrit.wikimedia.org/r/#/c/177107/ ? It's been waiting for 12 days now with your +1. [02:17:10] Nope, and it currently path conflicts [02:17:34] * James_F rebases. [02:17:48] OK. I'll try and reproduce the bug. It's non-trivial to reproduce. [02:17:59] The bug? [02:19:00] Yes, the bug it tries to fix. [02:19:08] And must remain fixed [02:19:17] There isn't a bug. [02:19:17] It can easily re-introduce the bfcache bug [02:19:22] We're trying to kill it. [02:19:24] That's what it's all for. [02:19:30] We don't /want/ the bfcache to "work". [02:20:01] It's inconsistent with user expectations and what we explicitly tell them will happen. [02:20:17] Either way, there's code, it does *something*. I'm testing that it does the same before and after in a scenario that is relevant (e.g. not just opening the editor and typing, this code doesn't relate to that) [02:20:40] bug, undesired behaviour, whatever you want to call it. [02:20:43] I know what it does. Roan explained at length. So. Much. Length. :-) [02:21:03] Anyway, I'll leave it with you. [02:26:26] James_F: So mediawiki theme being active for VE is intentional now, right? [02:26:32] Just seeing it for hte first time on latest master now [02:26:45] Krinkle: It's been live for 5 days, yes. [02:27:45] James_F: There seems to be a fat bottom border. One that is not present in the OOjs UI demos for toolbar/mediawiki. [02:28:10] Krinkle: https://tools.wmflabs.org/oojs-ui/oojs-ui/demos/index.html#toolbars-mediawiki-vector-ltr [02:28:17] Krinkle: It's in the toolbars in OOjs UI. [02:28:25] Krinkle: Did you forget to `grunt build`? [02:28:36] no, but I guess it was recently added [02:28:47] it looks like an error to me [02:28:51] Ill look it up [02:28:52] It was part of the design that was missing until this time last week, yes. [02:28:53] http://i.imgur.com/MA3kP0H.png [02:29:02] Old screenshot. [02:29:11] Or, new screenshot of old software. :-) [02:29:26] old or new doesn't matter, I'm curious why. [02:29:32] but don't answer. The commit better explein itself :P [02:29:36] It's part of the design. [02:29:55] i m using mediawiki 1.24. i have cloned VI code into my extensions directory. I included visualeditor.php into LocalSetting.php file but getting this error : [0e5c2dec] 2014-12-17 02:20:17: Fatal exception of type MWException [02:30:20] could you put the whole error on gist or pastebin? [02:30:27] Abhi_: Did you clone master of VisualEditor? [02:30:39] Abhi_: VisualEditor master isn't compatible with MediaWiki 1.24. [02:30:49] Abhi_: If you checkout the branch "REL1_24" it should work. [02:30:54] yes i cloned master only [02:30:57] https://github.com/wikimedia/oojs-ui/commit/0df9b5e74b003f5f598290a9c6b6245f6d5ab1b5 [02:32:11] James_F: It's unfortunate that the person providing the screenshot on https://phabricator.wikimedia.org/T78085 wasn't working with Vector as surrounding. As a designer one should be aware of where it ends up in. he/she may not have designed it that way had it been flat-against a 1px blue border like Vector does around the content area. [02:33:17] Krinkle: I'm not the person to talk to about this, and I know. [02:47:30] James_F git checkout REL1_24 -> git merge -s ours master -> git checkout master -> git merge REL1_24 is this enough ? [02:47:30] i did it and my error has gone. [02:48:45] but i m not getting VI UI . [02:49:09] James_F: Yeah. Hmm. will email instead phabricator. [02:49:54] Abhi_: Have you made any local changes? [02:50:19] Abhi_: If not, and you're in extensions/VisualEditor (or wherever), `git checkout REL1_24` and then `git submodule update` should get you to a working version. [02:50:35] Abhi_: Did you do `git submodule --init` the first time, though? [02:52:27] git submodule update --init r8 [02:52:27] ? [02:54:09] hey james thanks (y) Finished ! [02:58:00] James_F: The mw-target should be adapted for the larger border now. When I switch between edit/read mode. The upwards animation is but smooth. The border struggles. [02:58:29] probably like a 100 reflows there. Not sure what's going on. [02:58:44] Maybe it's trying to split the 4px into 100 frames (the default animation duration) [03:03:21] James_F: Haha. This is like the 4th major party copying our fundraiser now? Mozilla is getting some action now as well. http://i.imgur.com/3UvBNni.png [03:09:00] (03CR) 10Krinkle: [C: 04-1] "Needs conflict resolution. Tested: On master when changing something on the page we trigger the native "Stay/Leave page" when navigating a" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/177107 (owner: 10Catrope) [03:15:26] Krinkle: Hmm. :-( [03:15:34] Krinkle: Yeah, Mozilla 'borrowed' our strategy there. [03:15:43] Krinkle: Which, of course, makes us industry-standard. :-) [03:16:04] James_F: yeah, others can copy it knowing we've researched it and know it works well. [03:27:13] * James_F homes. [09:07:15] Do we need to install parsoid for VI to work in mediawiki version 1.24 ? [09:17:39] Abhi__: Are you using Mediawiki-Vagrant? [09:23:34] Abhi__: The vagrant role says that it'll need parasoid. [09:51:38] Do we need to install parsoid for VI to work in mediawiki version 1.24 and i am not using vigrant? [09:54:25] Abhi_: Yes you do. [10:38:08] how do i install parsoid for VI to work ! i cloned Visual Editor from https://github.com/wikimedia/mediawiki-extensions-VisualEditor and Parsoid from https://github.com/wikimedia/mediawiki-extensions-Parsoid ! Then i did local changes and included both the files into LocalSetting.php file and then also did git submodule update ! But my editor still looks this http://imgur.com/GzVKbjF [11:58:01] (03PS1) 10Mvolz: Fix style in all .js files [services/citoid] - 10https://gerrit.wikimedia.org/r/180448 [12:01:47] (03CR) 10Mvolz: [C: 032 V: 032] Fix style in all .js files [services/citoid] - 10https://gerrit.wikimedia.org/r/180448 (owner: 10Mvolz) [12:46:51] 3MediaWiki-ResourceLoader, MediaWiki-Vagrant: Local vagrant super slow due to minifier - https://phabricator.wikimedia.org/T78733#853109 (10Aklapper) [15:07:01] (03CR) 10Cmcmahon: [C: 032] "looks good!" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180336 (owner: 10Ryasmeen) [15:07:51] 3VisualEditor, VisualEditor-MediaWiki-Mobile, Mobile-Web: VisualEditor broken for MobileFrontend - https://phabricator.wikimedia.org/T78710#853377 (10Cmcmahon) Beta labs, sorry. [15:09:26] (03Merged) 10jenkins-bot: [BrowserTest]Fixing options test Fixed the unique selector for failing cases Change-Id: I41bde7245328303fcc8c5afea8f7228c1d36b915 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180336 (owner: 10Ryasmeen) [15:17:50] (03PS1) 10Cmcmahon: [BrowserTest] WIP update Links test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180488 [15:20:21] (03PS2) 10Cmcmahon: [BrowserTest] WIP update Links test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180488 [15:25:49] How do i enable Visual Editor in my mediawiki-1.24 ? I cloned VE from https://github.com/wikimedia/mediawiki-extensions-VisualEditor and Parsoid from https://github.com/wikimedia/mediawiki-extensions-Parsoid . I also included parsoid.php and visualeditor.php in my LocalSettings.php file . [15:41:10] Abhi_: Did you run the Parsoid service, and configure it to point at your wiki? [15:44:53] marktracer_ : do i need to keep running parsoid server in background ? I just added parsoid extension. What all do i need to do for it to work in mediawiki-1.24 ? [15:49:36] (03PS3) 10Cmcmahon: [BrowserTest] update Links test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180488 [15:51:27] (03PS4) 10Cmcmahon: [BrowserTest] update Links test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180488 [15:53:17] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180488 (owner: 10Cmcmahon) [15:55:02] (03Merged) 10jenkins-bot: [BrowserTest] update Links test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180488 (owner: 10Cmcmahon) [16:31:29] (03PS1) 10Cmcmahon: [BrowserTest] update general markup test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180497 [16:33:09] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180497 (owner: 10Cmcmahon) [16:38:48] (03CR) 10Cmcmahon: "maintenance" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180497 (owner: 10Cmcmahon) [16:40:55] (03Merged) 10jenkins-bot: [BrowserTest] update general markup test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180497 (owner: 10Cmcmahon) [17:22:49] (03PS1) 10Cmcmahon: [BrowserTest] update test for new selector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180519 [17:26:21] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180519 (owner: 10Cmcmahon) [17:28:11] (03Merged) 10jenkins-bot: [BrowserTest] update test for new selector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180519 (owner: 10Cmcmahon) [17:30:41] Corruption alert: visualeditor-needcheck on eswiki: https://es.wikipedia.org/?diff=78839998 [17:30:41] Corruption alert: visualeditor-needcheck on ptwiki: https://pt.wikipedia.org/?diff=40864117 [17:30:41] Corruption alert: visualeditor-needcheck on itwiki: https://it.wikipedia.org/?diff=69668245 [17:37:30] (03PS1) 10Cmcmahon: [BrowserTest] clear default text before entering search text [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180524 [17:38:04] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180524 (owner: 10Cmcmahon) [17:40:00] (03Merged) 10jenkins-bot: [BrowserTest] clear default text before entering search text [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180524 (owner: 10Cmcmahon) [18:26:37] Hm. Intersting. npm just got a redesign [18:26:38] https://www.npmjs.com/package/cssjanus [18:26:49] it now showcases the readme as primary content [18:27:02] and also shows statistics from github about open issues / pull requests. [18:32:07] Krinkle: Interesting. [18:34:14] http://blog.npmjs.org/ [18:34:29] I like the npm alternate meaning rotator in the top left [18:39:22] 3Citoid, VisualEditor, Scrum-of-Scrums: Expose the production citoid service publicly so we can start switching scripts over to use it - https://phabricator.wikimedia.org/T76949#853790 (10Krinkle) [18:58:25] 3RESTBase, VisualEditor, Parsoid: Store & load data-mw separately - https://phabricator.wikimedia.org/T78676#853835 (10Jdforrester-WMF) p:5Triage>3High [19:17:28] edsanders: https://gerrit.wikimedia.org/r/#/c/179387/ OK to merge? It really needs to land now. [19:19:09] James_F, oh, I was planning to merge that [19:20:08] (03CR) 10Esanders: [C: 032] VE-MW fix commit for I4efbae614e [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/179387 (owner: 10Catrope) [19:20:17] but Ed got there first [19:20:52] Ha. [19:20:53] OK. [19:21:08] wmf13 hasn't been cut yet, but it will soon. [19:21:16] (Thanks Ed.) [19:22:50] Uh.. embarrassing. Just reading the QUnit 1.16 announcement. http://blog.jquery.com/2014/12/10/qunit-1-16-release-and-roadmap/ [19:23:50] Krinkle: So… [19:24:11] Didn't know the photo was going to be *that* public :D [19:24:35] :D [19:24:57] Krinkle: :-) [19:25:03] are the other three holding you hostage? [19:25:07] I like how everyone is smiling apart from Timo. [19:25:11] They do look like it. [19:25:32] I *am* smiling. [19:25:32] :P [19:25:53] Also, I didnt know they were smiling [19:25:57] Krinkle: No, you're not. :-) [19:36:23] (03PS29) 10Mooeypoo: Eventify TemplateDataGenerator and use oojs-ui [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 [19:37:00] (03CR) 10Mooeypoo: "Comments answered on ps28" (0311 comments) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 (owner: 10Mooeypoo) [19:38:47] James_F, regarding the "more information" deal, just a quick question: I can "trim" the descriptions when they're too long and add "more information" link at the end, but with all other fields like author and credit and license, the length of "more information" *itself* is around the length we want those fields to be to begin with :P so... do I still trim those at a certain length + more info label, or do I replace them in that case? [19:39:17] mooeypoo: Trim. Maybe at 50 characters if you want to be really aggressive. [19:39:22] * mooeypoo nods [19:39:25] mooeypoo: Don't worry if it doesn't look perfect. [19:39:34] okay, now I just need those icons, then. [19:39:53] do we have an iconedLabel widget? [19:40:21] can't find a case where we use something like this elsewhere. We don't, I think. Just iconed-otherstuff [19:40:45] Make one locally? [19:40:59] mooeypoo: Oh, also, do you know the filetype of the media items or anything like that? [19:41:16] James_F, I can get it from the filename... [19:41:36] mooeypoo: Hmm. Worth showing it as an icon? There's a long-standing request for it. [19:41:38] I only have "BITMAP" or "DRAWING" as mediatypes for files [19:41:52] James_F, yeah I can show as icon or as the suffix [19:41:59] well, if it's an icon, I'll need the different icons [19:42:05] Sure. :-) [19:42:19] png, jpg, gif... what else do we allow for? [19:42:28] But a PNG/SVG/JPEG/OGV/PDF/etc. icon might be nice. [19:42:29] Lots. [19:42:29] pdf at some point, but I don't think we allow for it at the moment anyways [19:42:40] OGV is audio, no? [19:42:45] I do indicate "AUDIO" when it's an audio file [19:42:46] OGV is video. [19:42:52] oh, I should do "video" then for that [19:42:57] OGG is a container that can contain audio or video. [19:43:10] Which is… unhelpful for extension-based guessing. [19:43:21] hmm. Okay, I can take those types from the file suffixes, so if I have icons, I can display them [19:43:40] extmetadata should really specify it though, honestly [19:44:02] mooeypoo: https://commons.wikimedia.org/wiki/Commons:Project_scope/Allowable_file_types has the current list. [19:44:43] okay, 'cause I remember RoanKattouw_away disliked getting any suffix with regex without validating [19:44:47] so that list is great. [19:45:03] ... wait, hm, though if I do limit/validate we might have a problem with local files [19:45:21] If a local wiki allows for.. I dunno... bmp (god help them) [19:45:34] Short form: SVG, PNG, JPEG, GIF, TIFF, XCF; OGA, OGG, MIDI, WAV; WEBM, OGV, OGX; APNG; PDF, DJVU [19:45:50] Well, non-Wikimedia wikis might have different file types, certainly. [19:45:56] But Wikimedia ones don't. [19:46:05] Hmm, I'm not sure we're set up to add PDF and DJVU properly in general with the media dialog [19:46:13] (We might think about making some of this functionality in ve-wmf rather than ve-mw, frankly. [19:46:25] hmm true. [19:46:35] TIFF, PDF and DJVU are all multi-page-capable. [19:46:41] Well, theoretically, adding suffices for the validation should be easy [19:46:47] especially since I do believe they're stored in the settings [19:46:51] Most of our stuff only shows the first page, which sucks but is expected. [19:46:59] "allowed file types" for upload setting [19:47:32] Yeah we have a request somewhere to add support to show specific page from pdfs and books. that shouldn't be a terrible problem [19:49:32] Yeah, future stuff. [19:51:01] okay. As we say in hebrew -- Cow cow. [19:51:12] (Or: One cow at a time.) [19:52:42] (03CR) 10jenkins-bot: [V: 04-1] VE-MW fix commit for I4efbae614e [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/179387 (owner: 10Catrope) [19:52:55] … what? [19:53:27] Krinkle: 32 minutes to fail? [19:53:39] 19:51:59 npm ERR! Error: ENOENT, lstat '/mnt/jenkins-workspace/workspace/mwext-VisualEditor-npm/node_modules/grunt-jscs/node_modules/jscs/node_modules/xmlbuilder/node_modules/lodash-node/modern/objects/pairs.js' [19:54:01] (03CR) 10Jforrester: [C: 032] "Try again, Jenkins." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/179387 (owner: 10Catrope) [19:54:20] James_F: The time delay is because of the new gating system. All commits for core, extensions or skins now wait for each other synchronously in the submit gate. [19:54:32] I'm sceptical about it's advantages, but oh well. [19:54:48] Krinkle: Can I get a +3 to queue jump, then? [19:54:58] No such thing [19:55:09] Exactly my point. [19:55:27] It also couldn't exist. It's not a queue. [19:55:47] I mean jumping the queue on gate-and-submit. [19:55:54] James_F, naming help, is it "MWIconedLabelWidget" or "MWIconLabelWidget" or maybe "MWLabeledIconWidget" ? I think the first, but Trevor put emphasis on the differences and I'm not sure [19:56:04] Krinkle: It's currently 6 items long in gate-and-submit. [19:56:19] James_F: It makes sense kind of, e.g. core can make a change that VE will not work with. For the same reason we run tests on the simulated merge to the target branch (not on the parent commit when you submitted the commit), because things can change meanwhile. [19:56:23] I guess we need to allow bypassing Jenkins again. [19:56:24] to 'ed' or not to 'ed', that is the Iconed question. [19:56:35] Krenair: This is a different kind of bypass. [19:56:55] James_F: Are you blocked within an hour of deployment? If not, just continue working and pretend its merged. [19:57:07] Krinkle: Yes. wmf13 is getting cut in a few seconds. [19:57:08] It's an sync action, click a button and forget about it. [19:57:14] Krinkle: That patch needs to be in wmf13. [19:57:24] Well, a wise man told me it shouldn't be merged in a few seconds before the branch cut. [19:57:30] :p [19:57:36] Krinkle: As in, it's a follow-up and should have been merged two days ago but someone forgot. [20:03:48] (03Merged) 10jenkins-bot: VE-MW fix commit for I4efbae614e [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/179387 (owner: 10Catrope) [20:04:07] (03PS1) 10Jforrester: VE-MW fix commit for I4efbae614e [extensions/VisualEditor] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/180575 [20:04:18] Krinkle: Can you +2 https://gerrit.wikimedia.org/r/#/c/180575/ please? [20:04:51] Krinkle: Also, can we throw more hardware at the submit gate process so it runs faster? [20:05:43] (03CR) 10Krinkle: [C: 032] VE-MW fix commit for I4efbae614e [extensions/VisualEditor] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/180575 (owner: 10Jforrester) [20:05:47] Thanks. [20:06:02] James_F: hardware isn't the problem. We're hardly using the slaves we have. [20:06:15] Zuul itself or its configuration is inefficient. [20:06:26] And Gerrit, too. [20:06:34] And Jenkins is very slow in writing to disk. [20:06:45] Which is does all the time, for everything [20:06:56] You mean, our disks are slow? [20:07:00] Or it does too much writing? [20:07:02] Or what? [20:07:30] Can we have it write to a virtual RAM disc we sync with real rust every few seconds? [20:09:05] James_F: There's synchronous micro tasks Jenkins does in between that block the whole system. But I think it's more cost effective and worthy of human resources to phase out Jenkins instead of trying to make it fast. [20:09:15] our dependency has been made very thin. Almost gone. [20:09:47] And we'll have to see how fast Phabricator is when pumped full with all our repos on a single server. [20:09:58] I'm curious how (if) it separates the proposed commits from merged commits. [20:10:35] Krinkle: bored? should we merge https://gerrit.wikimedia.org/r/154024 ? "Update jquery.ui Vector theme to 1.9.2" [20:10:54] Krinkle: Yeah, I imagine we'll chat about that if you want next week. [20:15:47] 3MediaWiki-ResourceLoader, MediaWiki-Vagrant: Local vagrant super slow due to minifier - https://phabricator.wikimedia.org/T78733#854003 (10Jdlrobson) This is making it near impossible for me to work now :-( I really don't want to vagrant destroy as setting up a new wiki instance will take up most of my day. [20:15:59] (03Merged) 10jenkins-bot: VE-MW fix commit for I4efbae614e [extensions/VisualEditor] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/180575 (owner: 10Jforrester) [20:17:26] MatmaRex: Not bored, rather busy in fact. That change, I can't worry about at the moment. It's very time consuming to test that. [20:18:00] MatmaRex: If you wanna work on it, that'd be great. Be sure to check it applies cleanly and looks as expected visually on plain medaiwki core with a dialog, with a ui button and ui datepicker inside of it. [20:18:06] meh, let's just do it. [20:18:07] Thats my composite test case [20:19:03] 3MediaWiki-ResourceLoader, MediaWiki-Vagrant: Local vagrant super slow due to minifier - https://phabricator.wikimedia.org/T78733#854004 (10Legoktm) Are you constantly changing your CSS? All the info you've posted looks like RL is either minifying the CSS each time (cache misses), or contacting redis in vagrant... [20:34:18] 3VisualEditor: Default text for Media should disappear upon clicking - https://phabricator.wikimedia.org/T78821#854040 (10Cmcmahon) 3NEW [20:41:06] 3MediaWiki-ResourceLoader, MediaWiki-Vagrant: Local vagrant super slow due to minifier - https://phabricator.wikimedia.org/T78733#854069 (10dduvall) Also, since it sounds like you're dependent on a fair amount of custom wiki configuration and content/templates for your development, you might want to consider pac... [20:46:30] 3VisualEditor: VisualEditor diff dialog is too small - https://phabricator.wikimedia.org/T78823#854082 (10Tgr) 3NEW [20:47:44] 3VisualEditor-MediaWiki, VisualEditor: Make the diff screen of the save dialog a large rather than medium sized - https://phabricator.wikimedia.org/T78823#854089 (10Jdforrester-WMF) p:5Triage>3Normal [20:48:23] 3VisualEditor: Default text for Media should disappear upon clicking - https://phabricator.wikimedia.org/T78821#854092 (10Cmcmahon) On closer examination, I believe that the default text in the media search box is briefly selected, but the selection disappears. Again, compare to Link which does the same thing co... [20:52:48] James_F, so the REST service thing... [20:57:41] (03PS1) 10Esanders: Use viewport clipping when lots of search results found [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/180635 [21:00:05] Krenair: Yeah. [21:06:57] hm, tabs don't work in switching between cells in tables. Is that known or is this a bug? [21:07:05] James_F, ... [21:07:25] edsanders: Thoughts about https://gerrit.wikimedia.org/r/#/c/179476/ and https://gerrit.wikimedia.org/r/#/c/179478/ and https://gerrit.wikimedia.org/r/#/c/179479/ ? [21:07:32] mooeypoo: Known. [21:07:55] James_F, hm i have another bug in tables [21:08:30] I'm adding to the officewiki table, I went to the last row, clicked "add row after", filled in the lines, clicked "save" and in "review your changes" I see that my entry is *instead* of the one above me [21:08:44] actually, strike that. Instead of someone else. Eh, is this an editing conflict? [21:09:02] Krenair: Did you have a look at includes/libs/virtualrest/SwiftVirtualRESTService.php? [21:09:19] mooeypoo: Hmm. Sounds bad. [21:09:29] yes [21:09:31] James_F, seems so :\ I refresh, that person is now the last in the list. It's the third time this happens. I should either wait for thta table to stop being popular or edit in wikitext mode to work on conflicts manually [21:09:55] mooeypoo: Oh, wait, no. [21:10:02] mooeypoo: That should just work when you try to save. [21:10:07] mooeypoo: MW is magic like that. Sometimes. [21:10:15] So save anyways despite what I see in the "review your changes" ? [21:10:20] it shows me -'s [21:10:21] Krenair: Does it make any sense to you? [21:10:30] mooeypoo: Give it a try. [21:10:42] "Your changes could not be saved because of an edit conflict. Would you like to resolve the conflict manually?" [21:10:52] mooeypoo: The diff is against "current", not against what you started from. [21:10:55] mooeypoo: Boo. :-( [21:11:07] James_F, hm. It's really confusing when that happens [21:11:14] mooeypoo: Edit half-way up the table and it will almost certainly just work. [21:11:30] Any chance we can compare what the user *started* working on vs what we're testing against and notify "might be a conflict" or something? [21:12:01] mooeypoo: We can definitely compare it to something valueless, but… [21:12:13] mooeypoo: The "might conflict" logic isn't available as an API. [21:12:56] James_F, yeah, bummer. It did work great if I edit the middle of the table [21:13:14] mooeypoo: Part of our magic plans for the future. [21:13:25] but it happened 3 times, it got a bit annoying. I wonder if this is table-specific issue with the conflicts? [21:13:59] yeah, no, just wanted to make sure it's known. I assume we're not really encountering a heavily popular edit to the end of a table very often :P [21:14:29] Krinkle: BTW, did you see https://github.com/jamesward/gulp-launcher – not sure if it's interesting to us? [21:14:40] mooeypoo: Not in real content, no. :-) [21:14:55] James_F, not a great deal. [21:14:56] James_F, hooray for random weird edge-case bug-finding! [21:14:58] :D [21:15:10] Krenair: Me neither. :-( Ping ori? [21:16:16] 3VisualEditor: Improve editing preformatted text - https://phabricator.wikimedia.org/T78827#854160 (10despens) 3NEW [21:17:12] James_F, a simple example of how it's intended to be used would be helpful. [21:22:36] Krenair: If RoanKattouw_away's here later hopefully he can shed some light. [21:27:03] 3VisualEditor: Improve editing preformatted text - https://phabricator.wikimedia.org/T78827#854169 (10Jdforrester-WMF) Shift+Enter in a pre-formatted block already does insert a line break for me. Does it not for you? [21:32:36] 3VisualEditor-MediaWiki, VisualEditor: Make the diff screen of the save dialog a large rather than medium sized - https://phabricator.wikimedia.org/T78823#854082 (10Jdforrester-WMF) [21:37:58] 3VisualEditor: Improve editing preformatted text - https://phabricator.wikimedia.org/T78827#854200 (10despens) Oh! I figured the design issue is more complicated: Currently there are two cases: 1.1 Enter already existing, multi-line pre-formatted block. 1.2 Shift+Enter creates line break when cursor is above l... [21:39:03] James_F, thoughts? merge it [21:39:30] 3VisualEditor: Improve editing preformatted text - https://phabricator.wikimedia.org/T78827#854201 (10Jdforrester-WMF) Oh, hmm, this is a bug. [21:40:52] 3VisualEditor-ContentEditable, VisualEditor: Shift-enter at the end of a pre-formatted text block should act like shift-enter anywhere else in the block - https://phabricator.wikimedia.org/T78827#854204 (10Jdforrester-WMF) p:5Triage>3Normal [21:42:57] edsanders: ? [21:43:13] edsanders: Oh, sorry, my question wasn't good. [21:43:34] edsanders: Thoughts about pulling https://gerrit.wikimedia.org/r/#/c/179476/ and https://gerrit.wikimedia.org/r/#/c/179478/ and https://gerrit.wikimedia.org/r/#/c/179479/ and trying to deploy them to wmf12? [21:43:48] should be fine [21:54:23] edsanders: Want to try? [22:01:36] ok [22:04:58] BTW, Phabricator's now down, probably until tomorrow. [22:06:06] James_F: https://gerrit.wikimedia.org/r/#/c/178948/ This change added the .png and .min.css files. I don't think that was intentional, was it? [22:06:32] MatmaRex: Oh, hmm. No. [22:06:35] * James_F peers. [22:07:06] rsync --force --recursive --delete --exclude 'oojs-ui*.min.*' --exclude 'images/*/*.png' ./node_modules/oojs-ui/dist/ "$REPO_DIR/$TARGET_DIR" || exit 1 [22:07:12] That shouldn't happen… [22:12:39] * James_F does a follow-up. [22:16:06] (03PS1) 10Jforrester: Follow-up I4f080228: Re-remove PNG and minimisation-related files from OOjs UI [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/180648 [22:27:43] (03CR) 10Bartosz Dziewoński: [C: 032] Follow-up I4f080228: Re-remove PNG and minimisation-related files from OOjs UI [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/180648 (owner: 10Jforrester) [22:30:58] Phabricator is now down? [22:31:09] I thought we had until midnight? [22:31:21] Krenair: It's back now. [22:31:27] (03CR) 10jenkins-bot: [V: 04-1] Follow-up I4f080228: Re-remove PNG and minimisation-related files from OOjs UI [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/180648 (owner: 10Jforrester) [22:31:35] Oh FFS. [22:31:47] obviously MatmaRex is to blame [22:32:13] That V-1 was on the patchset, not the gate. [22:32:30] And is the spurious "npm ERR! weird error 3" issue. [22:36:48] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Invocations of deleted images don't render at all - https://phabricator.wikimedia.org/T54186#854375 (10ssastry) [22:36:49] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: We need a representation of red-linked images - https://phabricator.wikimedia.org/T52788#854376 (10ssastry) [22:38:33] (03CR) 10Bartosz Dziewoński: [C: 032] Follow-up I4f080228: Re-remove PNG and minimisation-related files from OOjs UI [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/180648 (owner: 10Jforrester) [22:43:05] (03Merged) 10jenkins-bot: Follow-up I4f080228: Re-remove PNG and minimisation-related files from OOjs UI [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/180648 (owner: 10Jforrester) [22:46:27] Krenair, MatmaRex: Clearly neither of you ever read WP:BEANS. [22:47:02] Clearly WP:BEANS is irrelevant. [22:47:14] what did i do D: [22:47:41] Krenair: Common sense, however, is meant to be used. [22:48:15] MatmaRex: After Krenair started openly explaining to people how to abuse a security flaw to break wikis, I made it private. You made it public again, and Krenair thanked you. [22:48:29] Making it private was pointless. [22:48:40] And I agree about common sense. Which is why administrators should not be allowed to change such pages. [22:48:41] what did i make public? [22:48:47] Explaining how to abuse wikis is pointless, and yet you did it. [22:49:25] You have the ability to fix the bug. [22:49:36] James_F: (i do find making "bugs" that are common knowledge "security-sensitive" somewhat stupid, by the way.) [22:49:40] Technical, yes. [22:49:48] Did you fix it? No. What did you do? You tried to convince people it was worth their time instead by making it a bigger problem. [22:49:51] However, given the superprotect fiasco, I imagine not the political? [22:50:04] That's not the right way to get things fixed, it's not cool, and it's not helpful. [22:50:21] We decided it was a well known flaw that you can't consider private. [22:50:49] i am completely at loss about what we're talking about. i'm not aware of making anything public?… [22:50:49] MatmaRex: "Common knowledge" is in the eye of the beholder, however. Just because you and a dozen other developers understand it doesn't mean you should broadcast it to the 5,000 other people with access but without understanding. [22:51:11] Chris Steipp, who is our actual security engineer, agrees. [22:51:42] His words, IIRC, are that we should remove rights to edit security-worrying places like the MediaWiki namespace from non-experts. [22:51:48] Which is not agreeing with you. [22:52:15] "This is the first I noticed this particular bug. I agree, we can make this public, unless James thinks it's being abused." [22:52:38] Err. Where did he say that? [22:52:52] James_F: https://phabricator.wikimedia.org/T45646 is most definitely not publicly visible. [22:53:03] MatmaRex: "matmarex changed Security from Security or Sensitive Bug to none." [22:53:11] MatmaRex: Thanks to you, it is. [22:53:12] James_F: that's just phab being stupid. [22:53:18] it's not public. that's a lie. [22:53:24] you need a snickers. :) [22:53:30] Hmm. [22:53:37] Wait, it's not visible? [22:53:39] I can't see it. [22:53:53] But it said security changed to none... [22:53:55] "Access Denied: Restricted Task" "You do not have permission to view this object." [22:53:55] James_F: a "Security or Sensitive Bug" can't have a custom ACL, and i wanted to let Krenair view it again. [22:53:58] Interesting. Phabriactor's security system is even more complicated. [22:54:03] custom ACL overrides "security" [22:54:04] gj phabricator [22:54:17] MatmaRex: Whut? That's a bit insane. [22:54:29] in fact, "security" is a macro for custom ACL, that people who can't edit ACLs can set. [22:54:49] it's apparently implemented using that Herald rule that keeps shitting on the tasks [22:54:50] Then Herald comes along and fixes the ACL to match. [22:55:02] (aka "Restricted Application") [22:55:02] MatmaRex: Aha. Interesting. [22:55:08] * James_F nods. [22:55:25] Once Herald is public that will change to "Herald change the visibility", right? [22:55:33] all that said, i definitely believe that this particular issue should be public. [22:55:43] However, "matmarex changed the visibility of this Task from "Custom Policy" to "Custom Policy"." doesn't help users much. [22:56:00] James_F: you can click on "Custom Policy" to see what happened. [22:56:17] (the UI sucks, yes) [22:56:22] MatmaRex: Why can't it show it inline, though? [22:56:31] beats me [22:56:38] Go go Phabricator. [22:56:39] I'm not sure how well you could get a policy to be inline... [22:56:47] I get the impression they can be quite complex. [22:57:15] Krenair: "matmarex changed the custom visibility of this Task to add users "Krenair" and "TheDJ"". [22:57:44] James_F: want to know how complicated ACLs can be? http://i.imgur.com/2So0bsr.png [22:57:47] Krenair: "matmarex changed the custom visibility of this Task to add user "Krenair", remove user "Foo", and add group "Bar"". [22:58:01] MatmaRex: Oh. Dear. [22:58:15] "matmarex changed custom visiblity of this Task to add "Krenair" while the moon is waxing". [22:58:41] WFM. :-) [22:59:10] (i haven't actually checked whether that works.) [22:59:17] MatmaRex: Let's not try. :-) [23:00:30] Krenair: I can make it public again if you promise to stop trolling by giving out details of how to exploit. Deal? [23:00:59] It's already on mw:User:MZMcBride/Attacks [23:01:23] Max also trolling isn't a defence. [23:01:42] I don't feel the need to defend myself. [23:01:53] And I don't feel the need to make it public. [23:02:00] That's fine, I'll have security do it. [23:02:00] This is what we call an impasse. :-) [23:02:03] James_F: http://blogs.msdn.com/b/oldnewthing/archive/2006/05/08/592350.aspx [23:02:12] Unless you seriously believe it's actively being abused. [23:02:26] MatmaRex: … yes? [23:02:33] 3VisualEditor, VisualEditor-MediaWiki-References: The reference dialog should disable the "Apply changes" button until a change is present - https://phabricator.wikimedia.org/T76928#854447 (10Ryasmeen) [23:03:17] James_F: to be able to abuse that, you need to already have sysop privileges. that says not-a-bug to me. [23:03:33] (or, well, not-a-security-bug. it might still be a bug.) [23:04:08] MatmaRex: Holes allowing cross-user scripting abuse by sysops is a security bug. [23:04:29] The "hole" is basically considered a feature. [23:04:37] James_F: i need to introduce you to the new feature we have called MediaWiki:Common.js :) [23:04:59] MatmaRex: One of the two is highly watched. [23:05:27] There are many others that are also deliberate, but not highly watched. [23:05:42] Krenair: You keep using that word. I don't think it means what you think it means. [23:05:54] James_F: did you know that there are 83 gadget .js pages on the English Wikipedia? and like ten common.js subpages? [23:05:59] What, "deliberate"? "many"? [23:06:16] Let's not even go into group-specific JS. [23:06:18] Krenair: Most of the "deliberate" holes in the MediaWiki namespace were added unthinkingly, and without any serious thought to account malpractice. [23:06:35] MatmaRex: Those numbers sound about right, yes. [23:06:53] it is indeed very unfortunate that any sysop can add any JavaScript to the wiki [23:06:56] Krenair: There is a lot of work on the horizon to undo a lot of these holes. [23:07:11] I am hoping against hope that I don't have to do it. [23:07:11] but as long as we have documented ways of doing that, the undocumented ways are hardly critical problems. [23:07:42] sounds like we should instead encourage more people to know about them and go watch these pages. [23:07:52] Or get rid of these pages. [23:07:56] Much simpler. [23:08:23] I watch many of those pages... [23:08:34] T13|mobile: Too few people do, however. :-( [23:09:01] Why would they? [23:09:36] Most, I'd venture to say, know nothing about and care not to learn about scripts [23:09:41] T13|mobile: You've clearly not been around long enough if you don't remember sysops abusing these holes to get their way. [23:09:50] Because their account security is put at risk by them. [23:09:59] Indeed. [23:10:21] Krenair: Anyway, I've made it public again. Feel free to stop. [23:10:22] But they wouldn't know if something was added that puts there account security at risk. [23:11:22] I know for a fact that some who would still are not aware of their existence. [23:11:46] There are a lot of parts of mw.util and whatnot I don't know or understand well. [23:12:04] But would love to get to knoe better. [23:12:58] I wish the documentation on it was better in most cases.. [23:13:56] mw.util? Can you identify a place where the documentation should be better? [23:14:32] For me it's often a lack of functional examples. [23:15:04] There are examples, but they're not stand alone and won't work if tried. [23:18:39] gwicke, hi [23:20:32] The things I tend to have the hardest time with are callbacks, $.Deferred, and getting it all to work with mw.Api [23:20:55] Oh, this is the VE channel [23:21:19] When will ve support text formatting? [23:21:45] define 'text formatting' [23:21:47] Size, color, font-family, background, etc. [23:22:48] define 'support'. :) [23:23:00] as far as i know, it is all already supported, but not available from the toolbar. [23:23:26] Being able to apply those effects while typing. [23:24:08] I couldnt figure out how to make red text with it earlier "other than source editing) [23:24:36] T13|mobile: We don't really want users doing that, do we? [23:25:13] It may be appropriate from time to time. [23:25:26] Arbitrary styles in user-facing content? [23:25:36] Or "choose from these 12 colours picked by the community"? [23:26:12] If you really need to access wikitext from VE, you can make a transclusion and just edit the content. [23:26:15] But I think usually suers shouldn't be do- ^ [23:26:17] users* [23:27:30] Hrmm. [23:41:33] (03PS1) 10Legoktm: Avoid GlobalTitleFail in ApiVisualEditor::diffWikitext() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180674 [23:42:02] (03CR) 10Alex Monk: Pre-populate LinkCache for page we're editing (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180377 (owner: 10Alex Monk) [23:48:39] Krinkle, hey [23:51:13] Krenair: Hi [23:51:23] (03CR) 10Alex Monk: [C: 032] Avoid GlobalTitleFail in ApiVisualEditor::diffWikitext() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180674 (owner: 10Legoktm) [23:52:38] Krinkle, you know when an error is thrown in javascript in response to another error, chrome doesn't format the original stack trace as it normally does? [23:53:00] Yeah [23:53:09] (03Merged) 10jenkins-bot: Avoid GlobalTitleFail in ApiVisualEditor::diffWikitext() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180674 (owner: 10Legoktm) [23:53:18] Is there any way to get it to format that? [23:53:19] Krenair: Catching it in the debugger solves that and also gives you the local scope variables as bonus. [23:53:20] (03PS1) 10Bartosz Dziewoński: Actually remove ve.instances [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/180676 [23:53:26] Pause on exceptions [23:53:42] And the full stack trace you can step up/down in [23:53:54] ok, thanks [23:54:35] Krenair: thanks [23:55:39] (03CR) 10Esanders: [C: 032] "Must have forgot to stage that change." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/180676 (owner: 10Bartosz Dziewoński) [23:59:13] (03CR) 10jenkins-bot: [V: 04-1] Actually remove ve.instances [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/180676 (owner: 10Bartosz Dziewoński)