[00:01:28] (03CR) 10Krinkle: [C: 032] Actually remove ve.instances [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/180676 (owner: 10Bartosz Dziewoński) [00:01:47] Weird. This chrome timing out thing is getting weird. [00:03:21] (03CR) 10Jforrester: [C: 032] "Sure. :-)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180377 (owner: 10Alex Monk) [00:03:46] (03CR) 10jenkins-bot: [V: 04-1] Actually remove ve.instances [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/180676 (owner: 10Bartosz Dziewoński) [00:05:13] (03Merged) 10jenkins-bot: Pre-populate LinkCache for page we're editing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180377 (owner: 10Alex Monk) [00:08:11] OK. Looking into it. [00:09:46] (03PS1) 10Krinkle: build: Update devDependencies related to Karma [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/180682 [00:10:08] Krinkle, "getting"? [00:10:15] :) [00:10:21] Krinkle: Is that just clean-up or do those fix anything we're worried about? [00:10:52] James_F: We'll know if it runs on slave1008 again and doesn't time out [00:11:07] Exciting isn't it :) [00:11:19] :-) [00:12:30] James_F: +2 :) [00:12:42] Krinkle: Am testing locally. [00:12:59] (03CR) 10Jforrester: [C: 032] build: Update devDependencies related to Karma [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/180682 (owner: 10Krinkle) [00:13:13] Krinkle: Are you suggesting I should have +2'ed without testing?! ;-) [00:13:41] James_F: While I didn't find a tangible issue directly. There were reports on upstream Karma about Chrome 37/38 having a regression causing errors with Karma. [00:13:51] Hmm. [00:15:04] (03Merged) 10jenkins-bot: build: Update devDependencies related to Karma [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/180682 (owner: 10Krinkle) [00:15:07] https://github.com/karma-runner/karma/issues/1206 [00:15:12] https://github.com/karma-runner/karma-chrome-launcher/issues/30 [00:15:14] Well, that worked… [00:15:17] https://code.google.com/p/chromium/issues/detail?id=422218 [00:15:29] (03PS2) 10Krinkle: Actually remove ve.instances [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/180676 (owner: 10Bartosz Dziewoński) [00:19:34] Krinkle, weird.. so mobile VE is broken on beta at the moment, and the stack trace shows the error is "TypeError: Illegal invocation" coming from some calls under $.ajax [00:20:30] Krinkle: Hmm. That seems to work? [00:20:54] (03CR) 10Jforrester: [C: 032] "Third time's the charm." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/180676 (owner: 10Bartosz Dziewoński) [00:23:03] (03Merged) 10jenkins-bot: Actually remove ve.instances [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/180676 (owner: 10Bartosz Dziewoński) [00:28:25] hmm... ve.init.target.pageName is a jQuery object? [00:29:51] Apparently jQuery doesn't like this. Can't blame it. [00:32:00] MatmaRex: Observe https://www.mediawiki.org/w/index.php?title=VisualEditor/status#2014-12-17_.28MW_1.25wmf13.29 and particularly the OOjs UI section. :-) [00:33:01] James_F|Away: hah [00:33:05] James_F|Away: CheckboxInputWidget* [00:33:15] ok, so why is MobileViewTarget passing Target a $container if it doesn't take one? [00:33:40] (corrected) [00:34:54] I blame edsanders|away [00:34:57] https://gerrit.wikimedia.org/r/#/c/178670/6/modules/ve-mw/init/ve.init.mw.Target.js [00:35:04] did not update MobileViewTarget caller [00:54:27] I don't think that fixes the whole issue... :/ [01:01:42] ok, next issue blocking mobile VE: "Uncaught TypeError: Cannot read property 'triggerListener' of undefined" from ve.ui.Toolbar.getCommands [01:02:02] (03PS1) 10Alex Monk: Fix Ia6bf604c: Update another caller to ve.init.mw.Target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180690 [01:03:38] (03CR) 10Alex Monk: "You missed a caller and it broke mobile - see I431a9025" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/178670 (owner: 10Esanders) [01:27:23] (03CR) 10Alex Monk: "Uploaded MobileFrontend commit: Ifcb2a985" (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180690 (owner: 10Alex Monk) [01:45:57] (03CR) 10Jforrester: [C: 032] Fix Ia6bf604c: Update another caller to ve.init.mw.Target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180690 (owner: 10Alex Monk) [01:46:05] (03PS1) 10Jforrester: Fix Ia6bf604c: Update another caller to ve.init.mw.Target [extensions/VisualEditor] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/180700 [01:46:13] (03PS2) 10Jforrester: Fix Ia6bf604c: Update another caller to ve.init.mw.Target [extensions/VisualEditor] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/180700 [01:46:34] Krenair: And RoanKattouw_away even said "This probably also requires a MobileFrontend change" in code review. [01:46:36] * James_F sighs. [01:46:40] Umm. [01:46:43] :) [01:47:00] I don't know why gerrit created two patch sets there [01:47:11] Gerrit is misbehaving todya [01:47:13] today* [01:47:23] As I said it doesn't seem to fix all the issues that stop mobile VE from working, unfortunately. [01:47:36] It's a start, however. [01:47:46] it was trying to access something like triggerListeners on a null surface, I think [01:48:29] That's certainly not helpful. :-) [01:49:23] (03Merged) 10jenkins-bot: Fix Ia6bf604c: Update another caller to ve.init.mw.Target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180690 (owner: 10Alex Monk) [02:02:37] The conversation in here earlier about Phabricator('s ACLs) was both enlightening and terrifying. [02:12:51] hey guys, has anyone had issues with VisualEditor 'disappearing' under MediaWiki 1.24.1? [02:13:53] I- [02:13:58] well ok then [02:29:09] it's showing as active under Special:Version (version: 0.1.0 (af11aa1) 08:55, 12 October 2014) but I'm not getting an 'edit' tab for it [02:29:41] and if I force a veaction=edit url, it doesn't do anything [02:30:11] hi [02:30:20] you ran away when I tried to speak earlier [02:30:33] sorry, client glitched out, didn't mean to [02:30:42] hi :) [02:31:34] The developers all run master and deploy to WMF production which is basically master from a week ago, with some fixes [02:31:43] But I think it should work with 1.24... [02:31:53] It was working fine with 1.24.0 [02:32:06] it's just gone AWOL with 1.24.1 [02:32:10] if you open your dev console, do you get an error? [02:34:47] This is all I'm seeing: [02:34:49] Resource interpreted as Script but transferred with MIME type text/html: "https://wiki.subnet.net.au/mediawiki/load.php?debug=false&lang=en-gb&modules=startup&only=scripts&skin=vector&*". [02:34:49] Test:1 Refused to execute script from 'https://wiki.subnet.net.au/mediawiki/load.php?debug=false&lang=en-gb&modules=startup&only=scripts&skin=vector&*' because its MIME type ('text/html') is not executable, and strict MIME type checking is enabled. [02:36:23] note no config on the server or in LocalSettings has changed [02:36:31] hmm [02:36:38] you only updated from 1.24.0 to 1.24.1? [02:37:00] yes [02:37:27] the database and LocalSettings has been in existence since 1.22.something [02:37:44] VisualEditor has been in use since early 1.23... I forget what exactly [02:38:03] is the site public? [02:38:07] nope [02:38:09] urgh [02:38:53] sorry, I figured that would cause issues :S [02:39:01] yes [02:39:22] having a private wiki means we can't really try to debug stuff ourselves against your setup [02:39:30] yup [02:40:46] oh, the other thing I forgot to note, the 'edit' tab changes to 'edit source', so it's clearly recognising VisualEditor is there, I just don't get an additional 'edit' tab for VE [02:42:19] oh [02:42:42] I've completely removed and re-cloned it from git (with git checkout REL1_24) [02:43:01] can you open your network tab of the dev console, and look for the request for the URL given in the error? [02:48:12] WheelieBin? [02:48:44] sorry, just fielding unrelated question from a colleague [02:49:08] what bit do you need? [02:49:11] it reports 200 OK [02:49:16] but in the Preview tab it's showing: Fatal error: Class 'ResourceLoaderTemplateModule' not found in /var/www/html/mediawiki-1.24.1/includes/resourceloader/ResourceLoader.php on line 496 [02:49:31] (and the Response tab) [02:49:56] ok, that'll be the issue [02:52:02] WheelieBin, do you use MobileFrontend? [02:52:08] yes [02:52:23] I cloned REL1_24 for that from scratch as well [02:52:56] although I don't remember if I specified the branch for Mantle [02:52:56] ok [02:53:02] hang on, let me try that [02:53:14] is your copy of Mantle in git? [02:53:26] yes [02:53:33] try commit 267d1924f1ec4d5c22cfe31ffaee118af4437cce^ [02:53:52] (with the caret at the end) [02:53:58] ok [02:55:23] you will want to identify what exactly is referring to ResourceLoaderTemplateModule as well, using grep [02:56:12] ah, changing Mantle to REL1_24 has fixed it (although that commit is throwing an error) [02:56:17] sorry, stupid mistake [02:56:22] thank you heaps for your help! [02:58:13] (I used https://old-bugzilla.wikimedia.org/show_bug.cgi?id=73377 to work out what was going on here) [02:58:16] you're welcome [03:08:00] WheelieBin, so I suspect a lot of your JS would've been broken by this issue [03:08:01] not just VE [03:08:28] although admittedly VE entirely relies on JS, whereas most MW features will work without [03:10:53] yeah, just that VE was immediately obvious [03:11:13] yup [04:01:05] now that that is all sorted, VE seems a hell of a lot faster under 1.24.1 than it did on 1.24.0 - this is good :) [04:08:23] :) [04:24:51] (03PS3) 10Krinkle: Remove use of Math.round() for offset and position pixel measures [oojs/ui] - 10https://gerrit.wikimedia.org/r/179494 (owner: 10Bartosz Dziewoński) [04:25:05] (03PS4) 10Krinkle: Remove use of Math.round() for offset and position pixel values [oojs/ui] - 10https://gerrit.wikimedia.org/r/179494 (owner: 10Bartosz Dziewoński) [04:32:36] (03PS5) 10Krinkle: Remove use of Math.round() for offset and position pixel values [oojs/ui] - 10https://gerrit.wikimedia.org/r/179494 (owner: 10Bartosz Dziewoński) [04:40:19] (03CR) 10Krinkle: [C: 032] Remove use of Math.round() for offset and position pixel values [oojs/ui] - 10https://gerrit.wikimedia.org/r/179494 (owner: 10Bartosz Dziewoński) [04:43:57] (03Merged) 10jenkins-bot: Remove use of Math.round() for offset and position pixel values [oojs/ui] - 10https://gerrit.wikimedia.org/r/179494 (owner: 10Bartosz Dziewoński) [04:55:53] (03CR) 10Krinkle: Add SVG compression grunt task using 'svgmin' (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/176634 (owner: 10Prtksxna) [04:56:22] (03CR) 10Krinkle: Add SVG compression grunt task using 'svgmin' (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/176634 (owner: 10Prtksxna) [07:32:49] 3OOjs-UI, Continuous-Integration: PHP docs should be auto-generated - https://phabricator.wikimedia.org/T74454#750834 (10Krinkle) When this happens, please maintain a redirect from https://doc.wikimedia.org/oojs-ui/master to https://doc.wikimedia.org/oojs-ui/master/php. [07:33:36] 3OOjs-UI: Audit all required constructor arguments and throw exceptions if they are not provided - e.g. FieldLayout - https://phabricator.wikimedia.org/T76648#808217 (10Krinkle) [07:34:16] 3OOjs-UI: Clean up duplication between being titled through their icon and indicator mixins in addition to TitledElement in IconWidget and IndicatorWidget - https://phabricator.wikimedia.org/T76638#931718 (10Krinkle) [07:47:37] 3OOjs-UI: Rewrite doc scripts from Ruby to Node.js - https://phabricator.wikimedia.org/T84839#931730 (10Krinkle) 3NEW [08:24:24] 3MediaWiki-Page-editing: Edits that were created using StashEdit API show wrong timestamp - https://phabricator.wikimedia.org/T84843#931806 (10Schnark) 3NEW [08:41:02] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: Show a user's recent uploads in the MW insert media dialog - https://phabricator.wikimedia.org/T62398#931853 (10Nemo_bis) [08:44:02] 3VisualEditor, Performance-Metrics-Dashboard: VE performance dashboard broken - https://phabricator.wikimedia.org/T78106#931863 (10Nemo_bis) > Probably related to VE performance data being moved to statsd about two hours ago? Is that data still forwarded to graphite? > I don't know offhand how gdash is configu... [08:45:36] 3VisualEditor, Performance-Metrics-Dashboard: VE performance dashboard broken - https://phabricator.wikimedia.org/T78106#931864 (10Nemo_bis) [08:59:30] 3VisualEditor, Performance-Metrics-Dashboard: VE performance dashboard broken - https://phabricator.wikimedia.org/T78106#931920 (10mark) [09:13:38] 3VisualEditor-ContentEditable, VisualEditor: Allow wikiformat in tables - https://phabricator.wikimedia.org/T84850#931963 (10Juandev) 3NEW [09:15:26] (03PS13) 10Amire80: WIP Add classes to toolbar UI elements [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174666 [09:20:05] 3VisualEditor-ContentEditable, VisualEditor: Allow keyboard arrows to move within the table - https://phabricator.wikimedia.org/T84851#931990 (10Juandev) 3NEW [10:00:34] (03PS14) 10Amire80: WIP Add classes to toolbar UI elements [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174666 [10:28:05] (03PS15) 10Amire80: Add classes to toolbar UI elements [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174666 [10:31:50] 3OOjs-UI, VisualEditor: Tools in the toolbar do not have unique attributes - https://phabricator.wikimedia.org/T76143#932145 (10Amire80) I updated the patch. Now it adds classes only to elements that cannot be found in the DOM by Selenium in any other way. Incidentally, all of these are elements that are identif... [10:39:06] (03CR) 10Zfilipin: [C: 031] Add classes to toolbar UI elements [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174666 (owner: 10Amire80) [10:55:24] (03PS1) 10Esanders: Update setupToolbar signature in mobile target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180759 [11:00:29] 3OOjs-UI, VisualEditor: Tools in the toolbar do not have unique attributes - https://phabricator.wikimedia.org/T76143#932189 (10Esanders) Thanks Amir. On a separate issue - would you be able to work with a JS API in this case, so we know if it's worth implementing? [11:20:53] mooeypoo, :O [11:23:10] (03CR) 10Esanders: [C: 04-1] "I'm still not convinced this is necessary" [oojs/ui] - 10https://gerrit.wikimedia.org/r/176634 (owner: 10Prtksxna) [11:25:14] (03CR) 10Alex Monk: [C: 032] "Another breaking change from Ic999ec16 that didn't update callers." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180759 (owner: 10Esanders) [11:25:35] (03PS2) 10Alex Monk: Update setupToolbar signature in mobile target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180759 (owner: 10Esanders) [11:25:54] (03CR) 10Alex Monk: Update setupToolbar signature in mobile target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180759 (owner: 10Esanders) [11:25:59] (03CR) 10Alex Monk: [C: 032] Update setupToolbar signature in mobile target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180759 (owner: 10Esanders) [11:26:24] (03CR) 10Alex Monk: "Did not update all callers, see Ifba696c2" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177109 (owner: 10Esanders) [11:27:51] 3Mobile-Web, VisualEditor-MediaWiki-Mobile, VisualEditor: VisualEditor broken for MobileFrontend - https://phabricator.wikimedia.org/T78710#932245 (10Krenair) (https://gerrit.wikimedia.org/r/180690 happened while Gerrit was down.) [11:27:53] (03Merged) 10jenkins-bot: Update setupToolbar signature in mobile target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180759 (owner: 10Esanders) [11:29:22] 3Mobile-Web, VisualEditor-MediaWiki-Mobile, VisualEditor: VisualEditor broken for MobileFrontend - https://phabricator.wikimedia.org/T78710#932248 (10Krenair) a:3Krenair it should now work. [11:31:00] (03PS1) 10Esanders: Fix typo in MobileContext [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/180765 [11:31:56] 3Mobile-Web, VisualEditor-MediaWiki-Mobile, VisualEditor: VisualEditor broken for MobileFrontend - https://phabricator.wikimedia.org/T78710#932250 (10Krenair) 5Open>3Resolved (Or at least, as well as the desktop version, which just returns a Parsoid error.) [11:33:23] (03CR) 10Alex Monk: [C: 032] "Broken by I225df797" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/180765 (owner: 10Esanders) [11:33:47] (03CR) 10Alex Monk: Move mobile ContextItemWidget hacks into separate class (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173865 (owner: 10Esanders) [11:34:12] anything else edsanders ? :) [11:34:23] Krenair, that appears to work now [11:34:35] I think you got the others [11:34:54] yeah. need to poke deployment-prep parsoid now [11:35:18] (it's returning a 503 from varnish) [11:50:34] (03CR) 10jenkins-bot: [V: 04-1] Fix typo in MobileContext [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/180765 (owner: 10Esanders) [12:11:41] ssh: connect to host deployment-parsoid04.eqiad.wmflabs port 22: Connection timed out [13:34:52] [14:31] James_F [2014-12-17 17:43:34] Krenair: And RoanKattouw_away even said "This probably also requires a MobileFrontend change" in code review. [13:34:55] Whoops, sorry folks [13:34:58] :) [13:35:06] I totally spotted that during my first review and totally forgot about it during my second [13:35:14] It's all sorted out now, we think [13:35:31] we can't test it on deployment-prep because parsoid is broken there at the moment (or at least varnish) [13:35:42] (more than one thing was broken there) [13:36:50] hosts running the wrong things, configs pointing to the wrong hosts, jenkins jobs broken, live local commits, not responding to ssh... probably more. it's quite the mess [13:43:40] Urgh, things broken again? [13:43:58] I swear *something* in beta labs is 503ing like every other day [13:44:05] To be fair on Tuesday it was a segfault in HHVM [13:44:33] I hope I don't have to rebuild the Parsoid instance for the fifth time [13:47:32] hashar is fixing it [13:47:50] he did wonder what parsoid05 is there for though, RoanKattouw [13:48:05] Ahm [13:48:06] Wait [13:48:12] Is something somewhere still pointing to 04? [13:48:21] If 05 is functional, point it to there [13:48:27] jenkins was updating 04 [13:48:43] Oh aha [13:48:48] Well that's a good reason to use 04 [13:49:06] RoanKattouw, did you make 05? [13:49:20] Probably? [13:49:35] I don't remember the last time I messed with this very well [13:49:44] subbu: kart_ Krenair: Parsoid hasn't been updated since October 28th [13:51:22] RoanKattouw, also 05 is trusty whereas 04 is precise [13:52:32] he's migrating everything to 05 [13:52:38] Oh yeah [13:52:46] Then I intended to migrate everything to 05 and just didn't do it very well [13:53:02] You're talking to him in -labs I take it? [13:53:18] -qa actually [13:53:26] (apparently qa run deployment-prep now? idk) [13:53:44] Well they certainly care about it being up [13:54:28] true [14:10:15] 3Mobile-Web, VisualEditor, VisualEditor-MediaWiki-Mobile: VisualEditor broken for MobileFrontend - https://phabricator.wikimedia.org/T78710#932469 (10Krenair) (All the many different problems with Parsoid now seem to be fixed, thanks to @hashar) [14:15:47] what is wrong with jenkins running karma [14:16:05] it constantly times out [14:16:17] it needs to be more reliable [14:16:29] I think Krinkle|detached was looking into it yesterday? [14:22:06] (03PS10) 10SuchetaG: [WIP] Link Inspector Redesign [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174725 [14:54:29] 3VisualEditor, Citoid, Scrum-of-Scrums: Expose the production citoid service publicly so we can start switching scripts over to use it - https://phabricator.wikimedia.org/T76949#932592 (10akosiaris) Hello, So I am a bit unclear on this and the two tasks listed as blocked (T62768 and T67540) did not make it any... [14:56:19] 3VisualEditor, Citoid, Scrum-of-Scrums: Expose the production citoid service publicly so we can start switching scripts over to use it - https://phabricator.wikimedia.org/T76949#932604 (10Catrope) Citoid !== Cite, they're totally different. However, Gabriel said he would work on setting up a services Varnish th... [14:57:47] 3VisualEditor, Citoid, Scrum-of-Scrums: Expose the production citoid service publicly so we can start switching scripts over to use it - https://phabricator.wikimedia.org/T76949#932606 (10Catrope) a:5Catrope>3GWicke [16:10:15] (03PS1) 10Amire80: Remove unnecessary translated messages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180801 [16:17:08] (03CR) 10Mooeypoo: [C: 032] "Original message has a {{notranslate}}" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180801 (owner: 10Amire80) [16:18:58] (03Merged) 10jenkins-bot: Remove unnecessary translated messages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180801 (owner: 10Amire80) [16:40:23] 3Parsoid, VisualEditor, VisualEditor-ContentEditable: Insufficient span tags stripping? - https://phabricator.wikimedia.org/T78540#932925 (10Elitre) Another example, and again looks like the 2 issues are related: https://sv.wikipedia.org/w/index.php?title=Aquavit_(restaurang)&diff=prev&oldid=29177658 [16:41:27] 3VisualEditor, Math: Create a VisualEditor plugin tool to add/edit maths blocks - https://phabricator.wikimedia.org/T45058#932936 (10matmarex) This has been fixed a looong time ago, or needs a better summary to explain what's missing. [16:47:13] 3MediaWiki-Page-editing: LivePreview: Since 1.25wmf12 the preview of the summary does not get updated on "Show changes" - https://phabricator.wikimedia.org/T84836#931670 (10matmarex) [16:54:25] James_F, how do we know what language to display in standalone ve? we go by browser language? the demos don't have lang= set up in the html or body [16:54:44] mooeypoo: I believe it hard-codes en. [16:55:24] James_F: i noticed we have a herald rule that adds #VisualEditor now, yay! [16:55:36] hm. So if anyone uses the standalone in another environment language, it still hard-codes "en" ? [16:55:56] aharoni, ^^ [16:56:11] yep, an admin created it for us [16:56:36] MatmaRex: Yeah. [16:57:32] mooeypoo, James_F - If I run a local web server and open extensions/VisualEditor/lib/ve/demos/ve/desktop.html , then I see that demo in Hebrew. [16:57:45] My browser's UI is Hebrew, and so is my Accept-Language. [16:57:48] mooeypoo: aharoni: we detect it from the browser, yeah [16:57:50] I guess that it's one of them. [16:58:03] it doesn't normalize en-us to en, by the way :( [16:58:26] MatmaRex - yeah, looks like it's the browser [16:58:44] my Chrome has Hebrew UI and Serbocroatian Accept-Language, and I see the demo in Hebrew. [16:58:48] aharoni, is "lang" not hierarchical like direction? [16:58:50] MatmaRex, it was https://phabricator.wikimedia.org/T76954 [16:58:55] But where do you get it? [16:59:02] isn't it navigator.language? [16:59:07] I cannot grep this. [16:59:47] MatmaRex: Use en-gb and it works fine, though. [17:00:15] James_F: i think it just falls back to 'en' since en is the default. it doesn't say "English" though, just "en-us". [17:00:53] MatmaRex: Yeah. If only MediaWiki properly supported variants of English without imperialistic assumptions… [17:01:24] aharoni: yes [17:01:36] aharoni: it comes from deep within the guts of jquery.i18n [17:01:59] en-us is different enough from en ;) [17:02:09] James_F: there's a bug for that. not gonna happen since enabling variant support breaks some parser constructs. [17:02:32] MatmaRex: Well, the real real reason I'm asking about this is that I want to finally get the user guide link to point directly to the relevant translated version. [17:02:47] For that I need the UI language code. [17:02:50] (there's a patch somewhere to add a "pig latin" variant of english, and that patch is currently failing tests because of that) [17:03:07] MatmaRex: Once we replace the parser with Parsoid… ;-) [17:03:08] I could just do $( 'html' ).prop( 'lang' ), but that wouldn't be the most robust thing. [17:03:15] Someone seriously translated everything to pig latin? [17:03:16] aharoni: if you have jquery.i18n, then you can just use `$.i18n().locale` (that's what the demo does) [17:03:22] mooeypoo: no, a language variant [17:03:25] regex magic [17:03:30] ha [17:03:39] aha, let's see what does it give me. [17:03:53] mooeypoo: https://gerrit.wikimedia.org/r/72053 [17:04:23] (note the low changeset number ;) ) [17:04:58] ha! return $m[2] . $m[1] . 'ay'; [17:05:28] mooeypoo: great, $.i18n().locale gives me what I want. [17:05:34] MatmaRex: ^ [17:05:45] thanks [17:05:48] :) [17:17:42] * mooeypoo will bbl [17:20:43] 3OOjs-UI: Rewrite PHP/JS comparison scripts from Ruby to Node.js - https://phabricator.wikimedia.org/T84839#933148 (10matmarex) [17:24:54] (03PS1) 10Bartosz Dziewoński: Update JSPHP-suite.json [oojs/ui] - 10https://gerrit.wikimedia.org/r/180823 [17:25:01] 3VisualEditor, Mobile-Web, VisualEditor-MediaWiki-Mobile: VisualEditor broken for MobileFrontend - https://phabricator.wikimedia.org/T78710#933190 (10hashar) Parsoid was stalled to a version from October 28th :-( Thanks to Krenair, Roan and Kartik we get it back to the latest version :-] [17:26:11] pff, antoine shouldn't let me take any credit. I ran around irc talking to people and trying to ssh into all the beta hosts [17:26:56] (03CR) 10Esanders: [C: 032] Fix typo in MobileContext [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/180765 (owner: 10Esanders) [17:27:21] oh, I missed that failure somehow [17:30:31] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=110045430 [17:30:31] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=110048629 [17:30:31] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=110063418 [17:30:32] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=110064262 [17:30:32] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=110064998 [17:30:32] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=110065093 [17:30:32] Corruption alert: visualeditor-needcheck on itwiki: https://it.wikipedia.org/?diff=69681463 [17:31:44] (03Merged) 10jenkins-bot: Fix typo in MobileContext [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/180765 (owner: 10Esanders) [17:33:05] 3OOjs-UI: ButtonInputWidget sometimes has smaller font than ButtonWidget - https://phabricator.wikimedia.org/T78182#933240 (10matmarex) a:3matmarex [17:33:20] (03CR) 10Jforrester: [C: 032] Update JSPHP-suite.json [oojs/ui] - 10https://gerrit.wikimedia.org/r/180823 (owner: 10Bartosz Dziewoński) [17:36:41] (03Merged) 10jenkins-bot: Update JSPHP-suite.json [oojs/ui] - 10https://gerrit.wikimedia.org/r/180823 (owner: 10Bartosz Dziewoński) [17:36:53] (03PS1) 10Bartosz Dziewoński: ButtonElement: Inherit all 'font' styles, not only for 'font-family' [oojs/ui] - 10https://gerrit.wikimedia.org/r/180827 [17:37:45] James_F: do we have a Phab dashboard/search/whatever that would display the list of tasks I'm assigned to that need action? (taking into account our weird QA practices) [17:37:59] MatmaRex: Well… [17:38:03] the two "High" priority tasks I have are both fixed a long time ago [17:38:22] MatmaRex: https://phabricator.wikimedia.org/maniphest/ will show all "assigned" items to you. [17:38:40] yes, i know [17:38:58] i've already submitted patches for many of them and they have been merged, but the tasks are still open due to how we do QA [17:38:58] https://phabricator.wikimedia.org/maniphest/query/pmD0bIbaw_7O/#R is all assigned items without Patch For Review [17:39:16] given that how we do QA isn't likely to change, i'm hoping to fix this for myself [17:39:33] but it seems like i can't do queries on a workboard column [17:39:42] so i'm aksing if you've perhaps somehow solved it. [17:39:46] asking. [17:40:26] i want to see #patch-for-review, this needs action from me (bug people to look at it, or respond to comments) [17:44:32] 3VisualEditor-MediaWiki, VisualEditor: It is very difficult to edit pages wrapped with {{Indentar}} and {{Indentar/fim}} - https://phabricator.wikimedia.org/T62541#933286 (10matmarex) [17:46:41] MatmaRex, you can't do queries on a workboard column? [17:46:54] you're not just looking to filter what shows on the workboard view are you? [17:47:44] Krenair: i want tasks that are assigned to me, that are not in "#VisualEditor (Done)" [17:48:57] oh you want to filter against a specific column [17:49:00] well you can just do https://phabricator.wikimedia.org/project/board/483/query/m_X2_PNSuBu5/ [17:49:11] that's the visualeditor workboard for open tasks assigned to you [17:49:27] shows nothing outside of the Done column actually [17:50:28] Krenair: my issue is this: http://i.imgur.com/ffjIkqP.png - i have already fixed both "High" priority tasks a long time ago, and the fixes have been merged a long time ago too. i don't need to see them. [17:50:57] right now i only have a few tasks there anyway, but i often have more [17:51:15] hmm. maybe i could mark them as Stalled, and then exclude Stalled. [17:59:51] 3OOjs-UI: OOjs UI: Dialogs should be repositionable/draggable - https://phabricator.wikimedia.org/T51969#933320 (10matmarex) 5Open>3stalled a:5matmarex>3None [18:17:35] edsanders: In the "forgot about mobile" category: https://phabricator.wikimedia.org/T84897 [18:24:01] MatmaRex: What's stalled about T51969? [18:24:53] James_F: it's unclear whether we want to implement it. [18:25:13] MatmaRex: Fair. [18:25:39] 3VisualEditor-MediaWiki-Mobile, Mobile-Web, VisualEditor: Cannot switch from VE to wikitext editor - https://phabricator.wikimedia.org/T84897#933411 (10Jdforrester-WMF) [18:26:11] MatmaRex: Also, please don't mark QA-able tasks as Stalled; just ping Elena or Rummana. [18:27:33] 3Performance-Metrics-Dashboard, VisualEditor: VE performance dashboard broken - https://phabricator.wikimedia.org/T78106#933416 (10Nemo_bis) I note there is something at https://grafana.wikimedia.org/#/dashboard/db/comparative-vewt-save-timings [18:28:36] 3Performance-Metrics-Dashboard, VisualEditor: VE performance dashboard broken - https://phabricator.wikimedia.org/T78106#933418 (10Jdforrester-WMF) >>! In T78106#933416, @Nemo_bis wrote: > I note there is something at https://grafana.wikimedia.org/#/dashboard/db/comparative-vewt-save-timings Yes, of course ther... [18:32:22] edsanders: Krenair: Yeah, I'm not sure what's up with that. Seems maybe the Labs VMs have something weird in them that causes Xvfb to die, or maybe Chromium itself isn't fully compatible with our stack of Chromium in Xvfb on Linux in OpenStack on Linux. It's Linux after all. Bring your own keyboard, mouse, monitor and drivers. If it doesn't work, it's our fault. [18:32:39] But one think I do know: It's not in Jenkins, Zuul, Gerrit or Grunt. [18:32:43] thing8 [18:33:07] I did an update yesterday that should resolve it to some degree. [18:33:12] Let me know if you get it again (even just once) [18:35:07] 3VisualEditor-MediaWiki-Mobile, Mobile-Web, VisualEditor: Cannot switch from VE to wikitext editor - https://phabricator.wikimedia.org/T84897#933452 (10Cmcmahon) [18:37:58] RoanKattouw, not ve.instances[0] [18:38:04] Krinkle: I've had problems running automated tests with VE in Chrome on Linux for some time now. The cursor doesn't behave correctly. [18:38:08] it's in target.unbindHandlers [18:38:13] urgh [18:38:25] chrismcmahon: In our case the browser (or its container) disappears unexpectedly [18:38:39] It seems to run fine on desktop Linux. [18:39:01] I suspect Xvfb or the VM supervisor we use to virtualise graphics in labs in general. [18:39:10] or Chromium's compatibility with those at least. [18:39:13] RoanKattouw, tries to call getElementDocument after this.$element has been nulled [18:39:33] not sure why this.$element would ever be null though [18:40:15] oh, because we set it to null in destroy [18:40:39] that seems like a left over from when we generated this.$element [18:43:45] Oooh [18:44:02] That makes much more sense [18:45:35] 3VisualEditor-MediaWiki-Mobile, Mobile-Web, VisualEditor: Cannot switch from VE to wikitext editor - https://phabricator.wikimedia.org/T84897#933514 (10Catrope) ``` [19:37] edsanders RoanKattouw, not ve.instances[0] [19:38] edsanders it's in target.unbindHandlers [19:39] edsanders RoanKattouw, tries to call getE... [18:45:42] 3OOjs-UI, Continuous-Integration: PHP docs should be auto-generated - https://phabricator.wikimedia.org/T74454#933517 (10Jdforrester-WMF) >>! In T74454#931711, @Krinkle wrote: > When this happens, please maintain a redirect from https://doc.wikimedia.org/oojs-ui/master to https://doc.wikimedia.org/oojs-ui/master... [18:46:15] 3OOjs-UI, Continuous-Integration: PHP docs should be auto-generated - https://phabricator.wikimedia.org/T74454#933518 (10Krinkle) >>! In T74454#933517, @Jdforrester-WMF wrote: >>>! In T74454#931711, @Krinkle wrote: >> When this happens, please maintain a redirect from https://doc.wikimedia.org/oojs-ui/master to... [18:47:20] (03PS1) 10Esanders: Remove this.$element on destroy but don't nullify [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/180852 [18:48:18] RoanKattouw, MF also calls "prepareForSave" on the target, which no longer exists [18:48:22] know what that was replaced with? [18:49:11] (03CR) 10Raimond Spekking: "There are a lot more translations because the message is marked as optional only." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180801 (owner: 10Amire80) [18:50:02] showSaveDialog? [18:52:29] oh wait, it's a MF method, got underscore prefixed [18:55:25] prepareForSave? [18:55:30] Oh OK [18:55:38] Dude we need to fold a LOT of this MF code into MobileViewTarget [18:55:54] There's too much logic in MF right now that should be in VE [18:56:48] (03CR) 10jenkins-bot: [V: 04-1] Remove this.$element on destroy but don't nullify [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/180852 (owner: 10Esanders) [18:58:01] (03CR) 10Catrope: [C: 032] Remove this.$element on destroy but don't nullify [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/180852 (owner: 10Esanders) [19:02:19] (03PS1) 10Jforrester: Check for stopped propagation before showing close dialog [extensions/VisualEditor] (wmf/1.25wmf12) - 10https://gerrit.wikimedia.org/r/180858 [19:04:07] RoanKattouw, yep - it's a mess [19:04:17] (03PS1) 10Jforrester: Stop propagation of events after handling trigger keys [VisualEditor/VisualEditor] (wmf/1.25wmf12) - 10https://gerrit.wikimedia.org/r/180859 [19:07:27] (03CR) 10jenkins-bot: [V: 04-1] Remove this.$element on destroy but don't nullify [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/180852 (owner: 10Esanders) [19:10:16] (03CR) 10Amire80: "*Now* there are a lot more translations, because I added them to relevant languages." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180801 (owner: 10Amire80) [19:10:31] (03CR) 10Catrope: [C: 032] "Come on Jenkins" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/180852 (owner: 10Esanders) [19:11:11] (03CR) 10Raimond Spekking: "Oh sorry, this way :-) Thanks for your work" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180801 (owner: 10Amire80) [19:11:48] (03CR) 10Jforrester: "What's the template to put in a qqq message for "don't translate this, it's for local wikis to over-ride" then?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180801 (owner: 10Amire80) [19:15:53] (03CR) 10Amire80: "It makes sense to me to link to the translated user guide on mediawiki.org, when it is translated." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180801 (owner: 10Amire80) [19:19:54] (03CR) 10jenkins-bot: [V: 04-1] Stop propagation of events after handling trigger keys [VisualEditor/VisualEditor] (wmf/1.25wmf12) - 10https://gerrit.wikimedia.org/r/180859 (owner: 10Jforrester) [19:20:39] 3VisualEditor: Cannot type anything after placing cursor at the beginning of a citation node, right after adding it - https://phabricator.wikimedia.org/T84904#933607 (10Ryasmeen) 3NEW [19:20:48] (03Merged) 10jenkins-bot: Remove this.$element on destroy but don't nullify [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/180852 (owner: 10Esanders) [19:21:52] 3VisualEditor: In Firefox,Cannot type anything after placing cursor at the beginning of a citation node, right after adding it - https://phabricator.wikimedia.org/T84904#933607 (10Ryasmeen) [19:24:25] (03PS69) 10Paladox: WikiEditor: Convert .css to .less and also fixes SVG issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 [19:37:17] (03CR) 10Esanders: "Actually this doesn't work at all." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/173300 (owner: 10Jforrester) [19:37:34] edsanders: It doesn't? [19:37:50] no [19:38:10] there are a number of problems [19:38:49] so embed combines the orignal files into one and embeds images [19:39:07] embed has to run before any concatenation, otherwise the relative paths will be wrong [19:39:27] concat then runs and adds the banner [19:40:11] sorry - I'm reading from the left side of the patch, the right side is also broken [19:40:44] Hmm. [19:40:45] 1. concat runs - it brings together the source files into ve.css [19:40:56] 2. janus runs, creating ve.rtl.css [19:41:11] Yes. [19:41:21] 3. embed runs, completely destroying the work you did in 1 & 2 [19:41:33] Does your embedding script not work? [19:41:56] because it builds off the orignal css files, not the concatenated ones [19:42:02] Doesn't it take ve.css and embed the files it mentions into a new ve.css? [19:42:04] Oh. Why? [19:42:25] because you wrote it that way - and the computer follows your instructions, such is the way of programming [19:42:29] https://gerrit.wikimedia.org/r/#/c/173300/2/Gruntfile.js [19:42:34] there is a fundamental problem though [19:42:55] embed can't run off the concatenated css, because then relative paths are wrong [19:43:10] but if embed runs before janus, then ltr assets are used [19:43:14] so janus must run firts [19:43:28] but if janus runs first - you end up with concatenated output [19:43:38] and so embed won't work [19:44:08] I didn't add cssUrlEmbed to the repo. [19:44:10] You did. [19:44:15] I've never looked at it. [19:44:40] it was broken before and after - but your code is clearly broken just by reading it [19:45:19] you made embed run after janus, but left embed pointing at the original files [19:45:31] so it runs after janus, but completely ignores its output [19:45:32] I assumed it was using the src for the relative positions. [19:45:50] Oh well. [19:46:40] you can't have: "cssjanus: .. dest: visualEditor.rtl.css", "cssUrlEmbed: .. src: coreBuildFiles.styles" [19:47:07] What happens if you run cssUrlEmbed on src: visualEditor.rtl.css? [19:47:34] it won't work, because the paths are relative to the folders in which the source file is [19:47:52] Did this ever work? [19:47:57] so they may be "../../../images/foo.svg" or "../../images/bar.svg" [19:48:04] " it was broken before and after" [19:48:26] before we weren't using rtl assets, now we aren't using any RTL css at all [19:49:58] This is for the single-file dist attempt, right? [19:50:21] (03PS1) 10Esanders: Revert "Follow-up 2075a46: Fix RTL image build by embedding after flipping" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/180869 [19:50:32] yeah [19:50:35] edsanders: How does that make it better? [19:50:45] because RTL looks reasonable [19:51:01] But not embedded? [19:51:13] I'd much rather we dump trying to make this work. [19:51:18] it is embedded [19:51:22] Rather than doing a half-arsed attempt that doesn't. [19:51:28] But it's embedding the LTR images? [19:51:40] yes - but the only place that breaks in core is the table editor [19:51:47] the bullet list switches on parent class [19:52:05] And the help icon? [19:52:10] And various other places. [19:52:25] help is probably the only other place in core [19:52:28] and not critical [19:52:40] not as critical as none of the VE styles being flipped at all [19:52:51] * James_F sighs. [19:52:56] Why not dump embedding instead? [19:52:59] Then it works great. [19:54:28] because then we'll forget about it an it will never get fixed [19:54:45] Make a task. [19:54:52] Make a task for VE-SA. [19:54:57] Have this be a blocker. [19:54:59] Done. [19:58:30] (03CR) 10Jforrester: [C: 032] "Meh." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/180869 (owner: 10Esanders) [20:00:09] 3VisualEditor: Standalone build process embeds the LTR images even for the RTL sheet - https://phabricator.wikimedia.org/T84910#933706 (10Jdforrester-WMF) 3NEW [20:00:46] 3VisualEditor-MediaWiki, VisualEditor: It is very difficult to edit pages wrapped with {{Indentar}} and {{Indentar/fim}} - https://phabricator.wikimedia.org/T62541#933713 (10Etonkovidova) The page mentioned in the issue consists entirely of templates and can be edited only from Transclusion boxes. That is, of c... [20:08:17] 3Math, VisualEditor: Create a visual VisualEditor plugin tool to add/edit maths blocks - https://phabricator.wikimedia.org/T45058#933723 (10Jdforrester-WMF) [20:08:24] 3Math, VisualEditor: Create a visual VisualEditor plugin tool to add/edit maths blocks - https://phabricator.wikimedia.org/T45058#475322 (10Jdforrester-WMF) >>! In T45058#932936, @matmarex wrote: > This has been fixed a looong time ago, or needs a better summary to explain what's missing. Happy? [20:08:30] (03CR) 10jenkins-bot: [V: 04-1] Revert "Follow-up 2075a46: Fix RTL image build by embedding after flipping" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/180869 (owner: 10Esanders) [20:09:38] 3VisualEditor-ContentEditable, VisualEditor-CopyPaste, VisualEditor: Insufficient span tags stripping from copy-and-paste (?) - https://phabricator.wikimedia.org/T78540#933729 (10Jdforrester-WMF) p:5Triage>3High [20:10:22] James_F: subtle. :) [20:10:44] (03CR) 10Bartosz Dziewoński: [C: 032] Revert "Follow-up 2075a46: Fix RTL image build by embedding after flipping" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/180869 (owner: 10Esanders) [20:11:07] MatmaRex: It was clearly stated earlier in the task. [20:12:10] 3VisualEditor-ContentEditable, VisualEditor: Allow wikiformat in tables - https://phabricator.wikimedia.org/T84850#933749 (10Jdforrester-WMF) I'm lost. You can add all of these things in a table. What are you asking for? [20:16:49] (03CR) 10Esanders: [C: 032] "Goddammit Jenkins. You just can't get the help these days." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/180869 (owner: 10Esanders) [20:21:22] 3VisualEditor-MediaWiki-Mobile, VisualEditor: [Regression pre-wmf14] In mobile VE, as soon as you place your cursor inside the field in Citation dialog and type, the text box disappears - https://phabricator.wikimedia.org/T84914#933781 (10Ryasmeen) 3NEW [20:22:31] (03CR) 10jenkins-bot: [V: 04-1] Revert "Follow-up 2075a46: Fix RTL image build by embedding after flipping" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/180869 (owner: 10Esanders) [20:25:07] 3VisualEditor-MediaWiki-Mobile, Mobile-Web, VisualEditor: [Regression pre-wmf14] Cannot switch from VE to wikitext editor - https://phabricator.wikimedia.org/T84897#933801 (10Jdforrester-WMF) p:5Triage>3High a:3Esanders [20:25:55] (03CR) 10Bartosz Dziewoński: [C: 032] "Q: How many software engineers are needed to merge a revert?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/180869 (owner: 10Esanders) [20:26:24] gwicke [20:26:32] Fatal error: Call to undefined function curl_multi_init() in /home/alex/Development/MediaWiki/includes/libs/MultiHttpClient.php on line 374 [20:26:57] 3VisualEditor-MediaWiki-Mobile, Mobile-Web, VisualEditor: [Regression pre-wmf14] Cannot switch from VE to wikitext editor in Mobile Web - https://phabricator.wikimedia.org/T84897#933811 (10Jdforrester-WMF) [20:27:13] (MultiHttpClient is the class which SwiftFileBackend and VirtualRESTServiceClient depend on) [20:28:10] Krenair: hmmm; is this with Zend or HHVM? [20:28:17] zend [20:28:26] which version? [20:28:33] That function exists for me [20:28:37] http://php.net/manual/en/function.curl-multi-init.php [20:28:38] In 5.5.9 [20:28:40] alex@alex-laptop:~/Development/MediaWiki/extensions/VisualEditor (T1218)$ php --version [20:28:40] PHP 5.5.9-1ubuntu4.5 (cli) (built: Oct 29 2014 11:59:10) [20:29:23] we have been using this method for a long time in production [20:29:37] in SwiftFileBackend? [20:29:51] in MultiHttpClient [20:30:08] which is used where? [20:30:08] which is what the prod swift backend uses for example [20:30:12] right [20:30:23] I don't think it's an actual MW requirement [20:30:34] considering I can currently run MW and VE with Parsoid without it [20:30:41] VirtualRest is just a different wrapper around the MultiHttp functionality [20:30:54] hm: https://www.mediawiki.org/wiki/Manual:CURL [20:31:02] we use it in the Parsoid extension too [20:31:08] but yeah, you don't need that necessarily [20:31:21] I never had problems with it on Debian [20:31:37] I could install it for my setup, but I'm not happy with introducing yet another dependency. [20:31:55] ahh, try apt-get install php5-curl [20:32:41] curl is pretty reasonable I think [20:32:48] I don't think we can approve this to go into ve-mw until the curl dependency is removed. [20:32:58] I certainly wouldn't. [20:33:00] it comes with php by default [20:33:12] and is the only way php can do parallel http requests [20:33:17] I don't think I've gone and deliberately uninstalled it... [20:33:30] (short of writing some socket loop manually) [20:33:32] Debian/Ubuntu have a somewhat stupid PHP package [20:34:03] it's very modular, but you have to install some things explicitly that normally come with the binary distribution [20:34:10] But it would be nice if there were something like a non-parallel fallback, because non-parallel requests seem to be supported without cURL [20:34:43] Then again I don't think requiring curl is too much of a problem [20:34:48] yeah, we could probably add that to MultiHttpClient [20:34:55] currently we use MWHttpRequest [20:35:07] It's 2014, if I can't have an HTTP library then when am I ever gonna get my flying car [20:35:15] ;) [20:35:24] which supports curl and url fopen [20:35:43] the problem is its lack of parallelism [20:35:59] so it could be a fall-back for MultiHttpClient [20:36:11] basically process the requests in a loop [20:36:21] rather than parallel [20:36:31] (03CR) 10jenkins-bot: [V: 04-1] Revert "Follow-up 2075a46: Fix RTL image build by embedding after flipping" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/180869 (owner: 10Esanders) [20:36:59] welp, i guess we're not gonna revert that today. [20:37:17] Jenkins has been V-1ing things willy-nilly because of Karma [20:37:21] Krinkle: ^ [20:37:22] It may just need another kick [20:37:32] MatmaRex: If the error message is "Karma timed out", just +2 it again [20:37:33] RoanKattouw: It's had four. :-) [20:37:38] Oh dear [20:39:22] MatmaRex: RoanKattouw: It seems it's alwayas on integration-slave1006 [20:39:26] I've depooled that one [20:39:27] Try again [20:39:31] can anyone remind me why we removed our ability to override jenkins?… :( [20:39:40] MatmaRex: so that master isn't broken. [20:39:48] (03CR) 10Bartosz Dziewoński: [C: 032] Revert "Follow-up 2075a46: Fix RTL image build by embedding after flipping" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/180869 (owner: 10Esanders) [20:40:01] good news, master is currently broken [20:40:06] we're unable to unbreak it [20:40:52] The solution isn't to have everyone everywhere override it but to fix the test and/or the test runner (Xvfb in this case). [20:40:58] I've depooled the faulty server. [20:42:22] that solution is somewhat of a bottleneck when we have exactly one person who can do it [20:42:29] (or perhaps sometimes two) [20:43:18] MatmaRex: well, I can't hire people or clone myself [20:44:23] clearly the foundation needs to invest in that technology. :) [20:44:41] (or perhaps we could instead re-enable Verified for humans. food for thought.) [20:45:42] OK. It's gonna time out again [20:46:00] Krinkle: We can hire more CI engineers, and we can design systems that are less good but more easily understood. [20:46:19] MatmaRex: For what it's worth, humans do have Verified. It's limited to operations and gerrit admins. If this is in production a breakage and James says it has priority, it'll get merged in under a minute. [20:46:33] Krinkle: Striving for the perfect system which is hugely complicated, undocumented and which no-one other than you and sometimes hashar understands is hard. [20:47:17] I've designed no undocumented systems. I've only written about the perfect system and complained about the huge compromise we have now. What we have now is the less good but more easily understood system. [20:47:20] Krinkle: That's not technically true, but Gerrit admins can give themselves Verified by editing the ACL [20:47:51] Right, because we have quite a few gerrit admins, and they too find those buttons confusing and would press them by accident. [20:48:15] (03CR) 10jenkins-bot: [V: 04-1] Revert "Follow-up 2075a46: Fix RTL image build by embedding after flipping" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/180869 (owner: 10Esanders) [20:48:16] Or is there no way to grant them that ability globally without editing local ACL? [20:48:54] and the current compromise/much simplified system we have is in fact quite well documented. [20:49:20] Krinkle: Pages on MW.org no-one has ever read other than the author aren't documented in effect. :-) [20:49:21] Better than most if not all large systems we have currently deployed in production. [20:50:10] James_F: Well, that's not exactly a relevant fact. The reason nobody reads the docs other than Antoine and me is because nobody else has that access or is expected to read them. [20:51:22] If Jenkins was as well documented as we document apache, nginx, varnish, gerrit, ldap, puppet or anything for that matter, I wouldn't be maintaining it haha [20:51:39] * James_F grins. [20:51:41] Anyhow.. integration 1009 is also broken. [20:51:53] It's not cached. They're fresh Chromium boots. [20:51:54] 3VisualEditor: Navigating via Tab between fields in TransclusionCitation boxes switches to the Find/Replace fields in the background - https://phabricator.wikimedia.org/T84919#933903 (10Etonkovidova) 3NEW [20:51:58] Krinkle: OK, so each time you change how CI works you drop an e-mail to engineering@ reminding us, right? [20:52:10] Krinkle: Oh I don't disagree with the current setup, I'm just pointing out that even admins have to jump through hoops [20:52:34] Actually I think project owners can do this too because they can edit their own project's ACL [20:52:45] RoanKattouw: Yes. But ssh! ;-) [20:53:02] Anyway. I dislike enabling V for humans but if we have to we have to [20:53:04] 3Parsoid, MediaWiki-extensions-Flow, VisualEditor, RESTBase, MediaWiki-General-or-Unknown, VisualEditor-MediaWiki, Scrum-of-Scrums: Use PHP Virtual REST Service to access Parsoid - https://phabricator.wikimedia.org/T1218#933915 (10Krenair) a:3Krenair [20:53:27] RoanKattouw: Let's not in this case. [20:53:33] If we have to +2 everything 3 times, CI is unusable [20:53:43] I actually managed to get it sending requests [20:53:52] But the next branch cuts is weeks away, so we have the luxury of time [20:54:13] If CI had been as bad as it was today on a Monday or Tuesday of a regular week, though, I would have already edited the ACL [20:54:20] I think my understanding of how responses are supposed to be handled is a bit messed up, will come back to this later. [20:54:46] James_F, thoughts on adding a new dependency? Specifically php5-curl, that RoanKattouw and gwicke were surprised I didn't have. [20:55:18] Krenair: Do you need to ask me anything before I go off IRC for 17 days? [20:55:54] Currently we can access parsoid without it, because we use MWHttpRequest which handles curl and fopen url. But the VirtualRESTService stuff requires it [20:55:59] I mean I'll still be on hangouts, don't hesitate to ping me there, and it looks like you and gwicke are making progress on this quite nicely, but if there's anything on your mind, might as well talk about it while I'm here [20:56:39] RoanKattouw, I don't think I have anything at the moment... [20:57:15] * Krenair afk for a bit [20:57:34] OK, cool [20:57:40] Well, bye IRC, see you in 2015 [20:58:35] RoanKattouw_away: guten Rutsch! [20:58:47] 20:48:10 Chromium 39.0.2171 (Ubuntu): Executed 163 of 189 DISCONNECTED (51.137 secs / 40.554 secs) [20:58:54] interesting, it ran some tests and then stopped. [21:00:27] (03PS1) 10Krinkle: [DONT MERGE] Run grunt verbosely [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/180886 [21:03:29] Krinkle: That's quite common. [21:03:49] 3VisualEditor: Non-searchable text in Templates by Find - https://phabricator.wikimedia.org/T84920#933918 (10Etonkovidova) 3NEW [21:03:58] Krenair: We can't use fopen url? [21:04:59] Krenair: Can we use MWHttpRequest? [21:05:08] Krenair: Or would that be too mesy. [21:07:42] 3Parsoid, VisualEditor: VisualEditors adds unnecessary tags to bolded strings that end in apostrophes - https://phabricator.wikimedia.org/T84921#933927 (10Amire80) 3NEW [21:08:35] 3Parsoid, VisualEditor: VisualEditors adds unnecessary tags to bolded strings that end in apostrophes - https://phabricator.wikimedia.org/T84921#933927 (10Amire80) [21:10:49] Ha, my commit passed. [21:10:50] Ugh [21:10:53] so it is a race condition still [21:11:02] Maybe there's something about the same code running again [21:11:19] (03PS2) 10Krinkle: Revert "Follow-up 2075a46: Fix RTL image build by embedding after flipping" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/180869 (owner: 10Esanders) [21:11:27] (03PS3) 10Krinkle: Revert "Follow-up 2075a46: Fix RTL image build by embedding after flipping" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/180869 (owner: 10Esanders) [21:11:36] (03CR) 10Krinkle: [C: 032] Revert "Follow-up 2075a46: Fix RTL image build by embedding after flipping" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/180869 (owner: 10Esanders) [21:11:44] (03Abandoned) 10Krinkle: [DONT MERGE] Run grunt verbosely [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/180886 (owner: 10Krinkle) [21:12:43] 3VisualEditor-InterfaceLanguage, VisualEditor-ContentLanguage, VisualEditor: VisualEditor: Support for right-to-left (rtl) / bidirectional content (tracking) - https://phabricator.wikimedia.org/T35126#933941 (10Jdforrester-WMF) [21:12:55] 3OOjs-UI, VisualEditor-MediaWiki, VisualEditor: Vertical alignment of text in the search-and-replace field is off in VisualEditor - https://phabricator.wikimedia.org/T78041#933942 (10Jdforrester-WMF) 5Open>3Resolved [21:13:13] James_F: btw, jscs-jsdoc has been released. https://github.com/jscs-dev/jscs-jsdoc Would be interesting to try that out on a large code base. maybe oojs-ui or ve (before adding to the wikimedia.json preset) [21:13:31] Krinkle: Ooh. [21:13:46] Krinkle: Something for you and me to hack on next week in our spare time, maybe? :-) [21:13:52] :) [21:14:02] ah, there's even a preset for jsduck [21:14:03] interesting [21:14:29] yeah [21:14:42] (03CR) 10Jforrester: [C: 031] ButtonElement: Inherit all 'font' styles, not only for 'font-family' [oojs/ui] - 10https://gerrit.wikimedia.org/r/180827 (owner: 10Bartosz Dziewoński) [21:15:11] Krinkle: Focus, you. :-) [21:15:23] (03CR) 10jenkins-bot: [V: 04-1] Revert "Follow-up 2075a46: Fix RTL image build by embedding after flipping" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/180869 (owner: 10Esanders) [21:15:33] My code is compiling [21:15:38] it failed [21:15:41] :-) [21:15:47] But only on the gate [21:15:55] 3OOjs-UI, VisualEditor: Tools in the toolbar do not have unique attributes - https://phabricator.wikimedia.org/T76143#933944 (10Jdforrester-WMF) a:3Amire80 [21:15:58] Okay, Im seeing a pattern here that can't be a coincidence [21:16:17] ryasmeen: https://phabricator.wikimedia.org/T74332 needs a reply from greg-g. [21:17:06] (03CR) 10Krinkle: [C: 032] "Purged." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/180869 (owner: 10Esanders) [21:19:44] (03Merged) 10jenkins-bot: Revert "Follow-up 2075a46: Fix RTL image build by embedding after flipping" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/180869 (owner: 10Esanders) [21:20:07] Hmm. [21:20:50] (03CR) 10Jforrester: "recheck" [VisualEditor/VisualEditor] (wmf/1.25wmf12) - 10https://gerrit.wikimedia.org/r/180859 (owner: 10Jforrester) [21:20:50] 3VisualEditor, OOjs-UI: Tools in the toolbar do not have unique attributes - https://phabricator.wikimedia.org/T76143#933953 (10Amire80) >>! In T76143#932189, @Esanders wrote: > Thanks Amir. On a separate issue - would you be able to work with a JS API in this case, so we know if it's worth implementing? This i... [21:24:03] (03PS2) 10Bartosz Dziewoński: ButtonElement: Inherit all 'font' styles, not only 'font-family' [oojs/ui] - 10https://gerrit.wikimedia.org/r/180827 [21:29:00] In the Hebrew Wikipedia we have an abuse filter rule that tags all edits that add . [21:29:18] In the past it caught a lot of cases where was unnecessary. [21:29:37] Now it happens much less, and when it does happen, it usually has a good reason. [21:29:59] Good work. [21:32:37] aharoni: :-) [21:33:08] Krenair: Can I steal a +2 on https://gerrit.wikimedia.org/r/#/c/180859/ please? [21:36:40] James_F: "from" or "to" [21:36:59] greg-g: to. Sorry. :-) [21:37:06] greg-g: From ryasmeen to you. :-) [21:40:53] 3Editing, VisualEditor, MediaWiki-Page-editing: Provide a editing tools issues "report card" useful for finding problems - https://phabricator.wikimedia.org/T84926#934015 (10Jdforrester-WMF) 3NEW [21:41:02] James_F: :) [21:41:39] 3Editing, VisualEditor, MediaWiki-Page-editing: Provide an editing tools issues "report card" useful for finding problems - https://phabricator.wikimedia.org/T84926#934015 (10Jdforrester-WMF) [21:41:53] 3Editing, VisualEditor, MediaWiki-Page-editing: Provide an editing tools issues "report card" useful for tracking behavioural changes when new features are deployed - https://phabricator.wikimedia.org/T84927#934022 (10Jdforrester-WMF) [21:43:02] 3Editing, VisualEditor, MediaWiki-Page-editing: Provide an editing behaviour "report card" for each of some of our big wikis (frwiki, enwiki, dewiki, eswiki, etc.) - https://phabricator.wikimedia.org/T84929#934044 (10Jdforrester-WMF) 3NEW [21:56:37] 3VisualEditor, OOjs-UI, VisualEditor-InterfaceLanguage: VisualEditor page options menu goes off-screen in RTL wikis - https://phabricator.wikimedia.org/T76474#934081 (10Etonkovidova) [21:57:47] 3MediaWiki-Page-editing: Allow "suppressredirect" and "move-subpages" within userspace - https://phabricator.wikimedia.org/T71162#934083 (10Jaydiem) I'm the Wikipedia editor who originally proposed this change. To avoid confusion, I think it should be clarified that "within userspace" is meant to refer to an ind... [22:17:53] James_F/greg-g: yeah, looks okay to me too, not getting any slowness for any kind of search, adding comment to the bug [22:18:06] Cool. Thanks! [22:18:09] ryasmeen: sweet [22:18:58] 3VisualEditor, Beta-Cluster: Beta Cluster: API PrefixSearch is taking a very long time to return, and returns nothing when it does - https://phabricator.wikimedia.org/T74332#934140 (10Ryasmeen) Yeah, I am not getting any slowness in any search any more.Closing the bug for now. [22:19:22] 3VisualEditor, Beta-Cluster: Beta Cluster: API PrefixSearch is taking a very long time to return, and returns nothing when it does - https://phabricator.wikimedia.org/T74332#934141 (10Ryasmeen) 5Open>3Resolved [22:21:04] Krenair: No +2 on https://gerrit.wikimedia.org/r/#/c/180859/ ? [22:21:48] James_F, I don't think I should be +2ing things to wmf branches. [22:21:51] 3VisualEditor, VisualEditor-EditingTools: Limit effect of search-and-replace assessment on long documents - https://phabricator.wikimedia.org/T78234#934148 (10Jdforrester-WMF) [22:22:07] Krenair: It's not a real wmf branch. The actual deployment will happen in the SWAT. [22:22:19] Krenair: Which you (a) can't do and (b) won't be asked to. :-) [22:22:33] But I don't want to self-+2. [22:26:01] (03CR) 10Alex Monk: [C: 032] Stop propagation of events after handling trigger keys [VisualEditor/VisualEditor] (wmf/1.25wmf12) - 10https://gerrit.wikimedia.org/r/180859 (owner: 10Jforrester) [22:26:11] done [22:27:35] 3VisualEditor-MediaWiki, VisualEditor: Release VisualEditor-MediaWiki as "1.0" - https://phabricator.wikimedia.org/T84936#934150 (10Jdforrester-WMF) 3NEW [22:27:45] 3VisualEditor-MediaWiki, VisualEditor: Release VisualEditor-MediaWiki as "1.0" - https://phabricator.wikimedia.org/T84936#934150 (10Jdforrester-WMF) [22:27:46] Thanks. [22:28:45] 3VisualEditor-MediaWiki, VisualEditor: Release VisualEditor-MediaWiki as "1.0" - https://phabricator.wikimedia.org/T84936#934159 (10Jdforrester-WMF) [22:30:23] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Using browser native interactive spell-check tool causing repeated automatic deletion in Chrome - https://phabricator.wikimedia.org/T65462#934160 (10Jdforrester-WMF) [22:31:14] (03PS21) 10Divec: Native leftarrow and rightarrow [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177946 [22:32:40] (03CR) 10Divec: "Patchset 21: rebase on top of I185f8c97d66e605b7147e71d9850189da6a5d350 to fix cursoring across foobar ." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177946 (owner: 10Divec) [22:40:46] 3VisualEditor-MediaWiki, VisualEditor: Release VisualEditor-MediaWiki as "1.0" - https://phabricator.wikimedia.org/T84936#934172 (10Jdforrester-WMF) [22:41:06] (03Merged) 10jenkins-bot: Stop propagation of events after handling trigger keys [VisualEditor/VisualEditor] (wmf/1.25wmf12) - 10https://gerrit.wikimedia.org/r/180859 (owner: 10Jforrester) [22:46:53] 3VisualEditor, VisualEditor-ContentLanguage: Make the Sogou Input IME work - https://phabricator.wikimedia.org/T49436#934212 (10Jdforrester-WMF) p:5Volunteer?>3High [22:53:18] 3VisualEditor: TypeError: Illegal invocation appears while trying to open mobile VE in test2 - https://phabricator.wikimedia.org/T84939#934225 (10Ryasmeen) 3NEW [22:55:22] (03PS3) 10Amire80: [BrowserTest] Change the Heading menu item from a to span [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180139 [22:56:00] edsanders: Do you need a reply about the JavaScript API to merge https://gerrit.wikimedia.org/r/#/c/174666/ ? [22:56:04] 3VisualEditor: TypeError: Illegal invocation appears while trying to open mobile VE in test2 - https://phabricator.wikimedia.org/T84939#934232 (10Krenair) [22:56:06] 3VisualEditor, Mobile-Web, VisualEditor-MediaWiki-Mobile: VisualEditor broken for MobileFrontend - https://phabricator.wikimedia.org/T78710#934233 (10Krenair) [22:57:50] 3VisualEditor-MediaWiki, VisualEditor: Release VisualEditor-MediaWiki as "1.0" - https://phabricator.wikimedia.org/T84936#934238 (10Jdforrester-WMF) [23:12:11] 3VisualEditor-MediaWiki, VisualEditor: [Regression pre-wmf13]TypeError: this.toolbar.getSurface(...) is null appears after saving an edit and then cannot reopen that page next time - https://phabricator.wikimedia.org/T78335#934271 (10Ryasmeen) [23:15:46] 3VisualEditor, VisualEditor-EditingTools: [Regression pre-wmf13] Cannot open Basic Reference and Media dialog, TypeError: this.getSurface(...) is undefined appears - https://phabricator.wikimedia.org/T78338#934286 (10Ryasmeen) [23:45:39] (03PS1) 10Jforrester: FieldsetLayout: Shrink size of label and bump the weight to compensate [oojs/ui] - 10https://gerrit.wikimedia.org/r/180999 [23:46:01] 3OOjs-UI, VisualEditor-MediaWiki, VisualEditor: Dialog section labels are way too big compared to the rest of the contents of a dialog - https://phabricator.wikimedia.org/T78037#934378 (10Jdforrester-WMF) a:3Jdforrester-WMF [23:51:17] gwicke, hey [23:52:28] 3VisualEditor-ContentEditable, VisualEditor: Allow keyboard arrows to move within the table - https://phabricator.wikimedia.org/T84851#934408 (10matmarex) I believe this is already possible. [23:52:45] (03PS1) 10Jforrester: Update sub-module for cherry-pick to dd5df33a3 [extensions/VisualEditor] (wmf/1.25wmf12) - 10https://gerrit.wikimedia.org/r/181002 [23:53:56] gwicke, Notice: Undefined index: response in /home/alex/Development/MediaWiki/includes/libs/virtualrest/VirtualRESTServiceClient.php on line 139 [23:54:06] I also see that my onResponses function is not getting called [23:54:46] (03PS2) 10Jforrester: Check for stopped propagation before showing close dialog [extensions/VisualEditor] (wmf/1.25wmf12) - 10https://gerrit.wikimedia.org/r/180858 [23:55:00] I put a debug line into VirtualRESTServiceClient::run to dump $req[0] and got a big array out, showing the request body and such [23:59:58] (03CR) 10Hoo man: [C: 032] Check for stopped propagation before showing close dialog [extensions/VisualEditor] (wmf/1.25wmf12) - 10https://gerrit.wikimedia.org/r/180858 (owner: 10Jforrester)