[00:00:03] <grrrit-wm>	 (03CR) 10Hoo man: [C: 032] Update sub-module for cherry-pick to dd5df33a3 [extensions/VisualEditor] (wmf/1.25wmf12) - 10https://gerrit.wikimedia.org/r/181002 (owner: 10Jforrester)
[00:00:33] <grrrit-wm>	 (03CR) 10Hoo man: [C: 032] Fix Ia6bf604c: Update another caller to ve.init.mw.Target [extensions/VisualEditor] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/180700 (owner: 10Jforrester)
[00:02:22] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update sub-module for cherry-pick to dd5df33a3 [extensions/VisualEditor] (wmf/1.25wmf12) - 10https://gerrit.wikimedia.org/r/181002 (owner: 10Jforrester)
[00:02:29] <grrrit-wm>	 (03Merged) 10jenkins-bot: Check for stopped propagation before showing close dialog [extensions/VisualEditor] (wmf/1.25wmf12) - 10https://gerrit.wikimedia.org/r/180858 (owner: 10Jforrester)
[00:07:24] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix Ia6bf604c: Update another caller to ve.init.mw.Target [extensions/VisualEditor] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/180700 (owner: 10Jforrester)
[00:25:42] <wikibugs>	 3VisualEditor-MediaWiki, VisualEditor-EditingTools, VisualEditor: [Regression wmf11] Pressing Escape while a dialog is open closes the editor, should only close the dialog - https://phabricator.wikimedia.org/T78201#934484 (10Ryasmeen) Verified the fix in Betalabs and test2
[00:30:11] <wikibugs>	 3Mobile-Web, VisualEditor-MediaWiki-Mobile, VisualEditor: [Regression pre-wmf14] Cannot switch from VE to wikitext editor in Mobile Web - https://phabricator.wikimedia.org/T84897#934488 (10Jdlrobson) 5Open>3Resolved
[00:30:43] <wikibugs>	 3Mobile-Web, VisualEditor-MediaWiki-Mobile, VisualEditor: [Regression pre-wmf14] Cannot switch from VE to wikitext editor in Mobile Web - https://phabricator.wikimedia.org/T84897#934490 (10Jdforrester-WMF)
[00:35:04] <James_F>	 Krenair: BTW, as well as the POST convert/HTML/to/wikitext for VisualEditor, Flow will need convert/wikitext/to/HTML. Fun, huh? ;-)
[00:35:22] <Krenair>	 I haven't properly got it doing VE's stuff yet
[00:35:38] <James_F>	 Oh, sure.
[00:35:45] <James_F>	 Just thought it worth pointing  out.
[01:01:10] <wikibugs>	 3VisualEditor-MediaWiki, VisualEditor-EditingTools, VisualEditor: [Regression wmf11] Pressing Escape while a dialog is open closes the editor, should only close the dialog - https://phabricator.wikimedia.org/T78201#934600 (10Ryasmeen) Verified the fix in en.wiki running wmf12
[01:02:05] <wikibugs>	 3VisualEditor-MediaWiki, VisualEditor, VisualEditor-EditingTools: [Regression wmf11] Pressing Escape while a dialog is open closes the editor, should only close the dialog - https://phabricator.wikimedia.org/T78201#934602 (10Ryasmeen)
[01:07:13] <grrrit-wm>	 (03CR) 10Krinkle: ""Returning false from a handler automatically calls event.stopPropagation() and event.preventDefault()." – http://api.jquery.com/on/ (conf" [oojs/ui] - 10https://gerrit.wikimedia.org/r/179476 (owner: 10Esanders)
[01:43:20] <grrrit-wm>	 (03PS1) 10Krinkle: readme: Update badges [oojs/core] - 10https://gerrit.wikimedia.org/r/181016 
[01:50:13] <grrrit-wm>	 (03PS2) 10Krinkle: readme: Update badges [oojs/core] - 10https://gerrit.wikimedia.org/r/181016 
[01:55:58] <grrrit-wm>	 (03PS1) 10Krinkle: readme: Update badges [oojs/ui] - 10https://gerrit.wikimedia.org/r/181018 
[02:02:19] <grrrit-wm>	 (03PS25) 10Mooeypoo: [WIP] Transform the search widget to show image details [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161342 
[02:04:03] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [WIP] Transform the search widget to show image details [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161342 (owner: 10Mooeypoo)
[02:19:24] <grrrit-wm>	 (03CR) 10Jforrester: readme: Update badges (031 comment) [oojs/core] - 10https://gerrit.wikimedia.org/r/181016 (owner: 10Krinkle)
[02:20:54] <grrrit-wm>	 (03CR) 10Jforrester: "See my comment on the equivalent patchset for OOjs." [oojs/ui] - 10https://gerrit.wikimedia.org/r/181018 (owner: 10Krinkle)
[02:25:59] <grrrit-wm>	 (03PS1) 10Jforrester: Update VE core submodule to master (b5102a8) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/181022 
[02:35:18] <wikibugs>	 3RESTBase, VisualEditor-MediaWiki, VisualEditor, Scrum-of-Scrums, MediaWiki-General-or-Unknown, Parsoid, MediaWiki-extensions-Flow: Use PHP Virtual REST Service to access Parsoid - https://phabricator.wikimedia.org/T1218#935534 (10Krenair) I ran into issues with the way I was trying to use VirtualRESTService. My...
[04:47:55] <grrrit-wm>	 (03PS3) 10Krinkle: readme: Update badges [oojs/core] - 10https://gerrit.wikimedia.org/r/181016 
[04:49:43] <wikibugs>	 3Mobile-Web, VisualEditor-MediaWiki-Mobile, VisualEditor: [Regression pre-wmf14] Cannot switch from VE to wikitext editor in Mobile Web - https://phabricator.wikimedia.org/T84897#935586 (10Ryasmeen) Is it resolved ? I am still getting the following errors in Betalabs: TypeError: obj is null Uncaught TypeError: C...
[04:57:57] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] readme: Update badges [oojs/core] - 10https://gerrit.wikimedia.org/r/181016 (owner: 10Krinkle)
[05:15:42] <grrrit-wm>	 (03PS1) 10Krinkle: build: Update devDependencies [oojs/core] - 10https://gerrit.wikimedia.org/r/181032 
[05:16:01] <grrrit-wm>	 (03PS4) 10Krinkle: readme: Update badges [oojs/core] - 10https://gerrit.wikimedia.org/r/181016 
[05:19:05] <wikibugs>	 3MediaWiki-Page-editing: Allow "suppressredirect" and "move-subpages" within userspace on en.wikipedia - https://phabricator.wikimedia.org/T71162#935629 (10Dereckson)
[05:25:34] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] build: Update devDependencies [oojs/core] - 10https://gerrit.wikimedia.org/r/181032 (owner: 10Krinkle)
[05:25:46] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] readme: Update badges [oojs/core] - 10https://gerrit.wikimedia.org/r/181016 (owner: 10Krinkle)
[06:47:59] <grrrit-wm>	 (03CR) 10Krinkle: "#debug8" [oojs/core] - 10https://gerrit.wikimedia.org/r/181032 (owner: 10Krinkle)
[06:48:05] <grrrit-wm>	 (03CR) 10Krinkle: "recheck" [oojs/core] - 10https://gerrit.wikimedia.org/r/181032 (owner: 10Krinkle)
[07:26:32] <grrrit-wm>	 (03CR) 10Krinkle: "recheck" [oojs/core] - 10https://gerrit.wikimedia.org/r/181032 (owner: 10Krinkle)
[08:01:40] <wikibugs>	 3VisualEditor, Performance-Metrics-Dashboard: VE performance dashboard broken - https://phabricator.wikimedia.org/T78106#935753 (10Qgil) @memeht, I suspect it is not easy to let you help fixing this task, as probably there is some background and permissions that you should get before. However, just in case you w...
[08:25:19] <grrrit-wm>	 (03CR) 10Krinkle: "recheck" [oojs/core] - 10https://gerrit.wikimedia.org/r/181032 (owner: 10Krinkle)
[08:25:25] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] build: Update devDependencies [oojs/core] - 10https://gerrit.wikimedia.org/r/181032 (owner: 10Krinkle)
[08:27:42] <grrrit-wm>	 (03CR) 10Krinkle: "recheck" [oojs/core] - 10https://gerrit.wikimedia.org/r/181032 (owner: 10Krinkle)
[08:37:13] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] build: Update devDependencies [oojs/core] - 10https://gerrit.wikimedia.org/r/181032 (owner: 10Krinkle)
[09:16:25] <grrrit-wm>	 (03CR) 10Krinkle: "recheck" [oojs/core] - 10https://gerrit.wikimedia.org/r/181032 (owner: 10Krinkle)
[09:32:37] <grrrit-wm>	 (03CR) 10Krinkle: "recheck" [oojs/core] - 10https://gerrit.wikimedia.org/r/181016 (owner: 10Krinkle)
[09:40:11] <wikibugs>	 3VisualEditor, Performance-Metrics-Dashboard: VE performance dashboard broken - https://phabricator.wikimedia.org/T78106#935890 (10Nemo_bis) > The problem is that I don't know how to fix gdash, and instead of helping you just dismissed my question as "not that hard". :-)  Sorry. I just mean, the first step is fi...
[15:09:57] <wikibugs>	 3MediaWiki-Page-editing: Edits that were created using StashEdit API show wrong timestamp - https://phabricator.wikimedia.org/T84843#936372 (10Aklapper) p:5Triage>3Normal
[16:05:28] <wikibugs>	 3VisualEditor, VisualEditor-MediaWiki-Mobile, Mobile-Web: [Regression pre-wmf14] Cannot switch from VE to wikitext editor in Mobile Web - https://phabricator.wikimedia.org/T84897#936427 (10Cmcmahon) 5Resolved>3Open
[16:05:50] <wikibugs>	 3VisualEditor, VisualEditor-MediaWiki-Mobile, Mobile-Web: [Regression pre-wmf14] Cannot switch from VE to wikitext editor in Mobile Web - https://phabricator.wikimedia.org/T84897#933292 (10Cmcmahon) re-opening, this is still a problem
[16:09:34] <wikibugs>	 3VisualEditor: VisualEditor language screenshots come out with pixelated fonts - https://phabricator.wikimedia.org/T78648#936432 (10zeljkofilipin) p:5Triage>3Low
[16:09:47] <wikibugs>	 3VisualEditor: VisualEditor screenshots-taking tests should link to the job that uploaded them from the file description page - https://phabricator.wikimedia.org/T78647#936433 (10zeljkofilipin) p:5Triage>3Low
[16:22:24] <wikibugs>	 3VisualEditor: Impossible edit long lists in "Div col" templates - https://phabricator.wikimedia.org/T85005#936452 (10Nnvu) 3NEW
[16:32:58] <grrrit-wm>	 (03PS1) 10Cmcmahon: [BrowserTest] This test is unreliable in any version of Chrome [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/181087 
[16:33:44] <grrrit-wm>	 (03PS2) 10Cmcmahon: [BrowserTest] This test is unreliable in any version of Chrome [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/181087 
[16:34:34] <grrrit-wm>	 (03PS3) 10Cmcmahon: [BrowserTest] This test is unreliable in any version of Chrome [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/181087 
[16:40:39] <wikibugs>	 3VisualEditor: Impossible edit long lists in "Div col" templates - https://phabricator.wikimedia.org/T85005#936466 (10matmarex)
[16:40:40] <wikibugs>	 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Focus highlights for elements using CSS column-count are too tall in Chrome - https://phabricator.wikimedia.org/T52036#936467 (10matmarex)
[16:42:34] <wikibugs>	 3VisualEditor: Impossible edit long lists in "Div col" templates - https://phabricator.wikimedia.org/T85005#936452 (10matmarex) As a workaround, you can also double-click the blue area to open the template dialog.
[17:30:37] <grrrit-wm>	 (03PS26) 10Mooeypoo: [WIP] Transform the search widget to show image details [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161342 
[17:30:41] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on sqwiki: https://sq.wikipedia.org/?diff=1477638
[17:30:41] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on sqwiki: https://sq.wikipedia.org/?diff=1477639
[17:30:41] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=110083762
[17:30:41] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=33648435
[17:30:41] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=67409790
[17:30:41] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=67413495
[17:30:41] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on itwiki: https://it.wikipedia.org/?diff=69708860
[17:30:42] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on dawiki: https://da.wikipedia.org/?diff=7888008
[17:45:12] <wikibugs>	 3VisualEditor: Impossible edit long lists in "Div col" templates - https://phabricator.wikimedia.org/T85005#936570 (10Etonkovidova) The issue is  similar to https://phabricator.wikimedia.org/T62541 - when a large amount of text is placed into Transclusion box fields,  it is difficult to edit it.   Another (sligh...
[17:52:41] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] build: Update devDependencies [oojs/core] - 10https://gerrit.wikimedia.org/r/181032 (owner: 10Krinkle)
[17:53:05] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] readme: Update badges [oojs/core] - 10https://gerrit.wikimedia.org/r/181016 (owner: 10Krinkle)
[17:53:28] <grrrit-wm>	 (03CR) 10Jforrester: [C: 04-1] "Per OOjs, don't drop the david-dm badge." [oojs/ui] - 10https://gerrit.wikimedia.org/r/181018 (owner: 10Krinkle)
[17:56:53] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] "Seems sane." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/181087 (owner: 10Cmcmahon)
[18:02:47] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] build: Update devDependencies [oojs/core] - 10https://gerrit.wikimedia.org/r/181032 (owner: 10Krinkle)
[18:02:49] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] readme: Update badges [oojs/core] - 10https://gerrit.wikimedia.org/r/181016 (owner: 10Krinkle)
[18:03:03] <grrrit-wm>	 (03Merged) 10jenkins-bot: [BrowserTest] This test is unreliable in any version of Chrome [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/181087 (owner: 10Cmcmahon)
[18:04:18] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 04-1] Eventify TemplateDataGenerator and use oojs-ui (032 comments) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 (owner: 10Mooeypoo)
[18:14:50] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: Eventify TemplateDataGenerator and use oojs-ui (032 comments) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 (owner: 10Mooeypoo)
[18:19:31] <grrrit-wm>	 (03PS1) 10Esanders: Destroy toolbar dialog manager when surface is destroyed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/181108 
[18:19:34] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: Eventify TemplateDataGenerator and use oojs-ui (032 comments) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 (owner: 10Mooeypoo)
[18:20:01] <MatmaRex>	 mooeypoo: i should stop reviewing it and merge it already, i think. :)
[18:21:07] <wikibugs>	 3MediaWiki-Vagrant, MediaWiki-ResourceLoader: Local vagrant super slow due to minifier - https://phabricator.wikimedia.org/T78733#936625 (10Jdlrobson) I'm rarely changing the css. I'm seeing lots of rl-minify-css-cache-misses in the redis trace though. Is it possible my caching isn't setup correctly? Will take l...
[18:33:04] <wikibugs>	 3MediaWiki-Page-editing: Allow creation of revisionless page entries - https://phabricator.wikimedia.org/T43473#936646 (10Trijnstel) >>! In T43473#825038, @Aklapper wrote: >>>! In T43473#823769, @Nemo_bis wrote: >> James, please manually notify Platonides of your priority change (as he's not in phabricator yet)....
[18:36:34] <wikibugs>	 3MediaWiki-Page-editing: Allow creation of revisionless page entries - https://phabricator.wikimedia.org/T43473#936648 (10Jdforrester-WMF) >>! In T43473#936646, @Trijnstel wrote: >>>! In T43473#825038, @Aklapper wrote: >> Mail has been more than once to users, asking them to create an account in Phabricator.  >>...
[18:41:44] <grrrit-wm>	 (03PS1) 10Jackmcbarn: Do all of Cite's real work during unstrip [extensions/Cite] - 10https://gerrit.wikimedia.org/r/181112 
[18:44:04] <grrrit-wm>	 (03Abandoned) 10Jackmcbarn: Use transparent tags [extensions/Cite] - 10https://gerrit.wikimedia.org/r/137824 (owner: 10Jackmcbarn)
[18:45:52] <wikibugs>	 3MediaWiki-Page-editing: Allow creation of revisionless page entries - https://phabricator.wikimedia.org/T43473#936670 (10Trijnstel) >>! In T43473#936648, @Jdforrester-WMF wrote: >>>! In T43473#936646, @Trijnstel wrote: >>>>! In T43473#825038, @Aklapper wrote: >>> Mail has been more than once to users, asking th...
[18:46:10] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Do all of Cite's real work during unstrip [extensions/Cite] - 10https://gerrit.wikimedia.org/r/181112 (owner: 10Jackmcbarn)
[18:46:44] <grrrit-wm>	 (03CR) 10Jackmcbarn: "V-1 is due to missing core change. All tests pass when it's present." [extensions/Cite] - 10https://gerrit.wikimedia.org/r/181112 (owner: 10Jackmcbarn)
[18:53:27] <wikibugs>	 3VisualEditor, VisualEditor-MediaWiki-Mobile, Mobile-Web: [Regression pre-wmf14] Cannot switch from VE to wikitext editor in Mobile Web - https://phabricator.wikimedia.org/T84897#936676 (10Esanders) 5Open>3Resolved This is fixed but VE hasn't been redeployed yet.
[18:55:42] <wikibugs>	 3VisualEditor, Performance-Metrics-Dashboard: VE performance dashboard broken - https://phabricator.wikimedia.org/T78106#936683 (10Jdforrester-WMF) p:5Triage>3Normal a:3Jdforrester-WMF
[18:57:34] <wikibugs>	 3VisualEditor, Performance-Metrics-Dashboard: VE performance dashboard broken - https://phabricator.wikimedia.org/T78106#936693 (10Jdforrester-WMF) >>! In T78106#935890, @Nemo_bis wrote: >> The problem is that I don't know how to fix gdash, and instead of helping you just dismissed my question as "not that hard"...
[18:57:55] <mooeypoo>	 MatmaRex, I'm waiting for you to finish review before I fix :)
[18:59:15] <MatmaRex>	 mooeypoo: i've had enough, i'm just going to merge it :D
[18:59:26] <mooeypoo>	 MatmaRex, no need of fixes?
[18:59:27] <James_F>	 MatmaRex: Tsk. ;-)
[18:59:32] <wikibugs>	 3VisualEditor: Position event not emitted after slug close - https://phabricator.wikimedia.org/T85014#936699 (10Krenair) Needs the correct project added
[19:00:04] <wikibugs>	 3VisualEditor, VisualEditor-ContentEditable: Position event not emitted after slug close - https://phabricator.wikimedia.org/T85014#936702 (10Jdforrester-WMF) p:5Triage>3Normal
[19:02:38] <James_F>	 edsanders: +2 https://gerrit.wikimedia.org/r/#/c/181022/ so that T84897 is visibly fixed in Beta Labs?
[19:03:31] <grrrit-wm>	 (03PS2) 10Jforrester: Limit number of find and replace results to render [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/180195 (owner: 10Esanders)
[19:03:36] <grrrit-wm>	 (03PS2) 10Jforrester: Use viewport clipping when lots of search results found [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/180635 (owner: 10Esanders)
[19:04:46] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] Update VE core submodule to master (b5102a8) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/181022 (owner: 10Jforrester)
[19:04:59] <James_F>	 OK, time for me to pack and run.
[19:05:01] * James_F waves.
[19:10:12] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update VE core submodule to master (b5102a8) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/181022 (owner: 10Jforrester)
[19:12:10] <wikibugs>	 3MediaWiki-Page-editing: Edits that were created using StashEdit API show wrong timestamp - https://phabricator.wikimedia.org/T84843#936732 (10Umherirrender) edit stashing must/should ignore wikitext with time-depending things getting substituted, like all the time variables (LOCAL*/CURRENT*), parser function #t...
[19:15:04] <edsanders>	 so the latest version of OOUI is messing up in FF badly
[19:16:14] <edsanders>	 hmm, maybe not OOUI, but the demo is messed up
[19:16:20] <edsanders>	 might be this multi surface patch
[19:17:00] <Krinkle>	 npm outdated --depth 1
[19:17:03] <Krinkle>	 Not bad
[19:17:14] <Krinkle>	 (npm 2.x and above)
[19:18:06] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Limit number of find and replace results to render [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/180195 (owner: 10Esanders)
[19:20:54] <edsanders>	 Krinkle, it appears that <link rel=stylesheet disabled> doesn't disabled the stylesheet in FF
[19:21:05] <edsanders>	 but setting .prop('disabled', true) does work
[19:21:47] <Krinkle>	 edsanders: oojs-ui latest master /demos ?
[19:21:56] <edsanders>	 ve demo
[19:21:56] <edsanders>	 http://stackoverflow.com/questions/18237591/firefox-not-adhering-to-disabled-stylesheet
[19:22:07] <edsanders>	 I think the other cases work because the JS code runs at least once
[19:22:22] <edsanders>	 but I refactored the demo so the JS disabler doesn't run until you change directionality
[19:22:28] <edsanders>	 thus exposing this bug
[19:23:33] <edsanders>	 https://developer.mozilla.org/en-US/docs/Web/HTML/Element/link?redirectlocale=en-US&redirectslug=HTML%2FElement%2Flink#Attributes
[19:23:41] <edsanders>	 annoying
[19:25:12] <Krinkle>	 edsanders: Yeah
[19:25:25] <Krinkle>	 edsanders: Apparently not (yet?) a standard.
[19:25:47] <Krinkle>	 edsanders: Hm.. other work-arounds I can think of: pay with rel="" instead of disabled.
[19:25:52] <Krinkle>	 or only for the initial value.
[19:26:04] <Krinkle>	 e.g. rel=disabled-stylesheet
[19:26:24] <edsanders>	 we have a method for disabling based on direction - I'll just call it on init, and not bother with any attributes
[19:26:29] <edsanders>	 cleaner
[19:26:35] <Krinkle>	 adding them with javascript, would mean we get the same flash as in oojs-ui demos where the contents render without styles nd then load async
[19:26:49] <Krinkle>	 (adding the link tags with js that is)
[19:28:31] <Krinkle>	 edsanders: I'll look into getting that attribute standardised btw. Seems simple enough.
[19:30:36] <mooeypoo>	 meh, anyone knows how I can resize SVGs ?
[19:31:19] <mooeypoo>	 html attributes don't seem to work, and the icons look pretty bad
[19:31:43] <wikibugs>	 3VisualEditor, VisualEditor-ContentEditable: Allow keyboard arrows to move within the table - https://phabricator.wikimedia.org/T84851#936767 (10Etonkovidova) Checked on Mac and Windows - cannot navigate within a table with arrow buttons(or a tab).
[19:34:29] <mooeypoo>	 edsanders, you created/edited a lot of the ooui/ve icons, right? Can I use your help to resize/adjust 4 more?
[19:34:30] <grrrit-wm>	 (03PS1) 10Esanders: Update stylsheets from direction on init [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/181117 
[19:34:47] <edsanders>	 yes, which ones?
[19:35:14] <mooeypoo>	 edsanders, it's for the media dialog, I'll send them in email. I got them from kaity, but they're huge and when I try to resize them manually or through HTML they look really bad
[19:36:42] <edsanders>	 ok
[19:37:10] <mooeypoo>	 edsanders, thanks!! sent an email
[19:37:14] <edsanders>	 we hand adjust all the icons we get from design eventually so they are the right size and fit our pixel grid better
[19:37:32] <edsanders>	 and compress out the metadata
[19:37:49] <mooeypoo>	 yeah, I saw that the rest of the icons are resized. I downloaded Inscape, but every time I try to resize it ruins the icon. :\
[19:38:39] <edsanders>	 FU google apps: "Wikimedia Foundation Mail virus scanners are temporarily unavailable"
[19:38:48] <edsanders>	 thanks for protecting me from malicious SVGs
[19:39:12] <mooeypoo>	 edsanders, also, the icons I got aren't the same size in general among themselves. cc.svg and profile.svg seem to be surrounded by whitespace
[19:39:21] <edsanders>	 ok
[19:39:43] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update stylsheets from direction on init [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/181117 (owner: 10Esanders)
[19:39:48] <mooeypoo>	 I tried to resize the icon *itself* first to get rid of that, and then the entire thing to 24px, but ... yeah, I got it all messed up
[19:42:02] <edsanders>	 what's the clock for?
[19:42:13] <edsanders>	 and profile?
[19:52:43] <mooeypoo>	 edsanders, the clock is for the upload date
[19:52:48] <mooeypoo>	 the profile is for the "artist"
[19:53:02] <mooeypoo>	 person who uploaded
[19:53:16] <mooeypoo>	 clock might be "created" date instead of upload, we're still debating which to use
[19:53:57] <wikibugs>	 3MediaWiki-Vagrant, MediaWiki-ResourceLoader: Local vagrant super slow due to minifier - https://phabricator.wikimedia.org/T78733#936816 (10Jdlrobson) Okay so I debugged this and the source of slowdown seems to be $result = $compiler->compileFile( $fileName ); in compileLessFile  Did something change to do with...
[19:57:26] <wikibugs>	 3MediaWiki-Vagrant, MediaWiki-ResourceLoader: Local vagrant super slow due to minifier - https://phabricator.wikimedia.org/T78733#936824 (10Krinkle) The cache misses may be due to T84960.
[19:58:34] <wikibugs>	 3MediaWiki-Vagrant, MediaWiki-ResourceLoader: Local vagrant super slow due to minifier - https://phabricator.wikimedia.org/T78733#936828 (10matmarex) Depending on how recently you mean. The result of some `compileFile` calls used to be cached separately some time ago, now it isn't (only the final CSS is).  Perha...
[19:59:23] <MatmaRex>	 bah
[19:59:32] <MatmaRex>	 phabricator has no mid-air colision detection?
[20:06:11] <wikibugs>	 3VisualEditor: [Regression pre-wmf13]Uncaught TypeError: Cannot read property 'createElement' of null appears after adding a citation without required parameter - https://phabricator.wikimedia.org/T78626#936843 (10Ryasmeen) The error also appears even if you fill up all required parameters for Cite Journal
[20:15:05] <wikibugs>	 3VisualEditor, VisualEditor-ContentLanguage: VisualEditor: Pawning prevention code in ve.ce.Surface sometimes prevents some legit keypresses from being handled (e.g. typing “ą” in Polish on a new line) - https://phabricator.wikimedia.org/T69367#936848 (10matmarex) This no longer happens. Just for the kicks I bis...
[20:16:58] <Krinkle>	 MatmaRex: indeed. There's a bug about that
[20:17:54] <grrrit-wm>	 (03PS2) 10Alex Monk: Make a VirtualRESTService class for Parsoid, and use it [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/181011 
[20:25:06] <wikibugs>	 3VisualEditor, VisualEditor-ContentEditable: Cursoring with arrows from outside a table into it and typing causes pawns - https://phabricator.wikimedia.org/T75691#936961 (10matmarex) Can't reproduce the pawns anymore, the rest of the report still stands.
[20:34:38] <wikibugs>	 3VisualEditor, VisualEditor-ContentLanguage: VisualEditor: Pawning prevention code in ve.ce.Surface sometimes prevents some legit keypresses from being handled (e.g. typing “ą” in Polish on a new line) - https://phabricator.wikimedia.org/T69367#936977 (10Jdforrester-WMF) Yes! See fakeIMETests. Please use the scr...
[20:35:04] <wikibugs>	 3VisualEditor, VisualEditor-ContentLanguage: VisualEditor: Pawning prevention code in ve.ce.Surface sometimes prevents some legit keypresses from being handled (e.g. typing “ą” in Polish on a new line) - https://phabricator.wikimedia.org/T69367#936978 (10Jdforrester-WMF)
[20:35:20] <wikibugs>	 3VisualEditor-MediaWiki, VisualEditor: Release VisualEditor-MediaWiki as "1.0" - https://phabricator.wikimedia.org/T84936#936980 (10Jdforrester-WMF)
[20:35:21] <wikibugs>	 3VisualEditor, VisualEditor-ContentLanguage: VisualEditor: Pawning prevention code in ve.ce.Surface sometimes prevents some legit keypresses from being handled (e.g. typing “ą” in Polish on a new line) - https://phabricator.wikimedia.org/T69367#936979 (10Jdforrester-WMF) 5Open>3Resolved
[20:36:45] <wikibugs>	 3VisualEditor-CopyPaste, VisualEditor, VisualEditor-ContentEditable: Insufficient span tags stripping from copy-and-paste (?) - https://phabricator.wikimedia.org/T78540#936983 (10Drongou) Select a internallink (compulsory) and a space (compulsory)  and some text (plain text or internallink) Cmd C => Cmd V anywhe...
[20:38:37] <wikibugs>	 3VisualEditor, VisualEditor-ContentEditable: Blue hover highlights of focusable nodes inside a table are not updated immediately after a table cell is "focused", making it possible to do things to them - https://phabricator.wikimedia.org/T85020#936993 (10matmarex)
[20:43:48] <wikibugs>	 3RESTBase, Parsoid, VisualEditor, MediaWiki-General-or-Unknown, VisualEditor-MediaWiki, Scrum-of-Scrums, MediaWiki-extensions-Flow: Use PHP Virtual REST Service to access Parsoid - https://phabricator.wikimedia.org/T1218#936998 (10Krenair) >>! In T1218#935534, @Krenair wrote: > I ran into issues with the way I w...
[20:51:59] <wikibugs>	 3RESTBase, Parsoid, VisualEditor, MediaWiki-General-or-Unknown, VisualEditor-MediaWiki, Scrum-of-Scrums, MediaWiki-extensions-Flow: Use PHP Virtual REST Service to access Parsoid - https://phabricator.wikimedia.org/T1218#937019 (10GWicke) @krenair: Ahh, great news! @aaron: Thank you!
[20:52:26] <wikibugs>	 3MediaWiki-Vagrant, MediaWiki-ResourceLoader: Local vagrant super slow due to minifier - https://phabricator.wikimedia.org/T78733#937020 (10Jdlrobson) I can't view T84960 :( Okay now I'm getting somewhere. If I checkout commit Id0221e9f68786758e10b2f222f5e9170898e320d it only takes 1 second. Going to keep invest...
[20:53:51] <mooeypoo>	 edsanders, Thanks!!
[20:56:27] <wikibugs>	 3VisualEditor, VisualEditor-ContentEditable: Allow keyboard arrows to move within the table - https://phabricator.wikimedia.org/T84851#937035 (10matmarex) I can navigate with arrow keys (as long as a cell is "selected" (blue overlay) and not focused (has blinking cursor inside)), until I press the Tab key, at wh...
[20:58:12] <edsanders>	 mooeypoo, np
[20:59:16] <wikibugs>	 3VisualEditor, VisualEditor-ContentEditable: Allow keyboard arrows to move within the table - https://phabricator.wikimedia.org/T84851#937041 (10Esanders) WFM too. Once you are editing the cell the arrow keys will move you around the paragraph.
[20:59:54] <wikibugs>	 3MediaWiki-Vagrant, MediaWiki-ResourceLoader: Local vagrant super slow due to minifier - https://phabricator.wikimedia.org/T78733#937043 (10Jdlrobson) This is the commit where it all went wrong for me https://gerrit.wikimedia.org/r/#/c/175485/
[21:00:28] <wikibugs>	 3MediaWiki-Vagrant, MediaWiki-ResourceLoader: Local vagrant super slow due to minifier - https://phabricator.wikimedia.org/T78733#937044 (10Jdlrobson) @legoktm any idea why this has had just a negative effect on performance for me?
[21:01:07] <edsanders>	 mooeypoo, just realised I used some mixed spaces and tabs in those SVGs
[21:01:17] <edsanders>	 if you could replace the tabs with four spaces....
[21:01:47] <grrrit-wm>	 (03CR) 10Alex Monk: "TODO:" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/181011 (owner: 10Alex Monk)
[21:03:22] <wikibugs>	 3MediaWiki-Vagrant, MediaWiki-ResourceLoader: Local vagrant super slow due to minifier - https://phabricator.wikimedia.org/T78733#937057 (10matmarex) It upgraded the lessphp library from 0.4.0 to 0.5.0, so I guess they had a performance regression.
[21:06:20] <wikibugs>	 3MediaWiki-Vagrant, MediaWiki-ResourceLoader: Local vagrant super slow due to minifier - https://phabricator.wikimedia.org/T78733#937072 (10Legoktm) >>! In T78733#937057, @matmarex wrote: > It upgraded the lessphp library from 0.4.0 to 0.5.0, so I guess they had a performance regression.  Actually https://gerrit...
[21:09:27] <wikibugs>	 3MediaWiki-Vagrant, MediaWiki-ResourceLoader: Possible performance degradation in lessc - Local vagrant super slow - https://phabricator.wikimedia.org/T78733#937075 (10Jdlrobson)
[21:10:20] <mooeypoo>	 edsanders, will do.
[21:10:23] <mooeypoo>	 thanks!
[21:15:32] <wikibugs>	 3VisualEditor, VisualEditor-MediaWiki-Mobile, Mobile-Web: [Regression pre-wmf14] Cannot switch from VE to wikitext editor in Mobile Web - https://phabricator.wikimedia.org/T84897#937089 (10Ryasmeen) Verified the fix in Betalabs
[21:21:54] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: demo: Unbreak eventLogger.html and eventSequencer.html [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/181136 
[21:29:19] <Krinkle>	 Pfff, Apple is becoming like Microsoft when it comes to maintaining their browser.
[21:29:55] <Krinkle>	 Native querySelector in Safari 7 and 8 has a glaring regression in it for very basic css selector. jQuery had to fallback to Sizzle for a lot of selectors.
[21:30:06] <Krinkle>	 http://blog.jquery.com/2014/12/18/jquery-1-11-2-and-2-1-3-released-safari-fail-safe-edition/
[21:34:05] <Krenair>	 https://github.com/wikimedia/mediawiki-extensions-VisualEditor/blob/master/ApiVisualEditor.php#L76
[21:34:11] <Krenair>	 I'm not sure how we would ever reach this condition
[21:34:33] <Krenair>	 OK: $this->ok
[21:34:42] <Krenair>	 Good: $this->ok && !$this->errors
[21:35:19] <Krenair>	 we already found that $this->ok would not be true in this ccase. This elseif can never be true
[21:36:06] <Krenair>	 oh well, I am redoing this code for T1218
[21:40:13] <wikibugs>	 3VisualEditor, VisualEditor-ContentEditable: Allow keyboard arrows to move within the table - https://phabricator.wikimedia.org/T84851#937106 (10Etonkovidova) My bad - yes, with blue overlay, arrows keys  allow to navigate- that's right.
[21:43:41] <wikibugs>	 3VisualEditor-MediaWiki-Mobile, VisualEditor: [Regression wmf13] The icon for Cite>Website option is misaligned in the Cite menu of the toolbar in mobile VE - https://phabricator.wikimedia.org/T85025#937109 (10Ryasmeen) 3NEW
[21:55:00] <wikibugs>	 3VisualEditor-MediaWiki, VisualEditor: Release VisualEditor-MediaWiki as "1.0" - https://phabricator.wikimedia.org/T84936#937140 (10matmarex)
[21:55:02] <wikibugs>	 3VisualEditor, VisualEditor-ContentLanguage: VisualEditor: Pawning prevention code in ve.ce.Surface sometimes prevents some legit keypresses from being handled (e.g. typing “ą” in Polish on a new line) - https://phabricator.wikimedia.org/T69367#937138 (10matmarex) 5Resolved>3Open Let's do that.
[21:55:09] <wikibugs>	 3VisualEditor, VisualEditor-ContentLanguage: VisualEditor: Pawning prevention code in ve.ce.Surface sometimes prevents some legit keypresses from being handled (e.g. typing “ą” in Polish on a new line) - https://phabricator.wikimedia.org/T69367#937141 (10matmarex) a:5dchan>3matmarex
[21:59:46] <grrrit-wm>	 (03PS3) 10Alex Monk: [BREAKING CHANGE][WIP] Make a VirtualRESTService class for Parsoid, and use it [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/181011 
[22:09:17] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: ve.ce.TestRunner: Don't assume that 'changeText' happened before 'endLoop' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/181172 
[22:09:19] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: imetests: Add a regression test for Polish keyboard input [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/181173 
[22:09:21] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: ve.ce: Remove hacks from Surface#onDocumentKeyPress, add related IME test [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/181174 
[22:10:32] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Please note that I have absolutely NO IDEA what I'm doing here." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/181174 (owner: 10Bartosz Dziewoński)
[22:13:59] <grrrit-wm>	 (03PS2) 10Bartosz Dziewoński: ve.ce: Remove hacks from Surface#onDocumentKeyPress, add related IME test [NO IDEA WHAT I'M DOING] [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/181174 
[22:15:56] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] ve.ce.TestRunner: Don't assume that 'changeText' happened before 'endLoop' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/181172 (owner: 10Bartosz Dziewoński)
[22:16:59] <MatmaRex>	 eh
[22:17:03] * MatmaRex misses reliable unit tests
[22:18:08] <Krenair>	 same
[22:18:28] <Krenair>	 I think we should disable that test.
[22:18:35] <Krenair>	 (i.e. make it non-voting)
[22:18:52] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 031] "Design direction is good - haven't tested yet but would +2 if it does what it claims." [oojs/ui] - 10https://gerrit.wikimedia.org/r/180999 (owner: 10Jforrester)
[22:19:04] <Krenair>	 Aren't you supposed to be on holiday TrevorP|Away ? :P
[22:19:18] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] ButtonElement: Inherit all 'font' styles, not only 'font-family' [oojs/ui] - 10https://gerrit.wikimedia.org/r/180827 (owner: 10Bartosz Dziewoński)
[22:29:13] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] Destroy toolbar dialog manager when surface is destroyed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/181108 (owner: 10Esanders)
[22:57:09] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Destroy toolbar dialog manager when surface is destroyed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/181108 (owner: 10Esanders)
[23:10:09] <grrrit-wm>	 (03CR) 10MaxSem: "Per T74988, I can haz this in some shared place, be that core or some extension used by all other extensions?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/181011 (owner: 10Alex Monk)
[23:10:12] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] ButtonElement: Inherit all 'font' styles, not only 'font-family' [oojs/ui] - 10https://gerrit.wikimedia.org/r/180827 (owner: 10Bartosz Dziewoński)
[23:10:44] <grrrit-wm>	 (03CR) 10Alex Monk: "see commit msg" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/181011 (owner: 10Alex Monk)
[23:31:54] <grrrit-wm>	 (03PS27) 10Mooeypoo: [WIP] Transform the search widget to show image details [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161342 
[23:37:13] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] Destroy toolbar dialog manager when surface is destroyed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/181108 (owner: 10Esanders)
[23:43:33] <wikibugs>	 3VisualEditor-MediaWiki-Mobile, VisualEditor: [Regression wmf13] Icons for are misaligned in the Cite dropdown menu of the toolbar in mobile VE - https://phabricator.wikimedia.org/T85025#937315 (10matmarex)
[23:44:27] <wikibugs>	 3VisualEditor-MediaWiki-Mobile, VisualEditor: [Regression wmf13] Icons for are misaligned in the Cite dropdown menu of the toolbar in mobile VE - https://phabricator.wikimedia.org/T85025#937109 (10matmarex) All the icons look wonky. Probably caused by T78499, but I can't imagine what kind of thing MobileFrontend...
[23:45:54] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Destroy toolbar dialog manager when surface is destroyed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/181108 (owner: 10Esanders)
[23:48:04] <wikibugs>	 3VisualEditor-MediaWiki-Mobile, VisualEditor: [Regression wmf13] Icons for are misaligned in the Cite dropdown menu of the toolbar in mobile VE - https://phabricator.wikimedia.org/T85025#937323 (10matmarex) a:3matmarex
[23:59:17] <ori>	 James_F|Away: http://gdash.wikimedia.org/dashboards/ve/ looks better now, thanks!