[03:35:31] (03PS4) 10Alex Monk: [BREAKING CHANGE][WIP] Make a VirtualRESTService class for Parsoid, and use it [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/181011 [03:37:15] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE][WIP] Make a VirtualRESTService class for Parsoid, and use it [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/181011 (owner: 10Alex Monk) [09:09:58] ircs://freenode/Mvolz,isnick [10:41:41] 3VisualEditor: VisualEditor not loading in el.wikipedia - https://phabricator.wikimedia.org/T85055#937699 (10geraki) 3NEW [10:42:13] 3VisualEditor: VisualEditor not loading in el.wikipedia - https://phabricator.wikimedia.org/T85055#937699 (10geraki) p:5Unbreak!>3High [11:53:18] Hi, I'm leaving here a note that VE is not loading on el.wikipedia for more than 24 hours. It was reported by many users. https://el.wikipedia.org/wiki/%CE%9A%CE%BF%CF%81%CE%B9%CE%AC%CE%BA%CF%83%CE%BA%CE%B9?veaction=edit https://phabricator.wikimedia.org/T85055 [12:38:34] 3VisualEditor: VisualEditor not loading in el.wikipedia - https://phabricator.wikimedia.org/T85055#937757 (10geraki) 5Open>3Resolved [12:41:14] 3VisualEditor: VisualEditor not loading in el.wikipedia - https://phabricator.wikimedia.org/T85055#937758 (10geraki) 5Resolved>3Invalid a:3geraki Resolved by [[https://el.wikipedia.org/w/index.php?title=MediaWiki:Common.js&diff=4979660&oldid=4917315|removing some code from Mediawiki:Common.js]] (although... [13:24:12] (03CR) 10Paladox: [C: 031] Convert entry point to use explicit globals [extensions/WikiEditor] (REL1_24) - 10https://gerrit.wikimedia.org/r/175296 (owner: 10Paladox) [13:24:32] 3VisualEditor: Create right-click menus for VisualEditor - https://phabricator.wikimedia.org/T85058#937773 (10Amire80) 3NEW [13:52:20] (03PS2) 10Esanders: Update stylsheets from direction on init [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/181117 [15:46:48] 3VisualEditor, Performance-Metrics-Dashboard: VE performance dashboard broken - https://phabricator.wikimedia.org/T78106#937853 (10Nemo_bis) 5Open>3Resolved Looks ok now, though we've lost history in the year-long graph. Are the numbers comparable to the previous ones? If yes they might be added on the same... [16:45:08] 3Services, MediaWiki-General-or-Unknown, Parsoid, MediaWiki-Interface, RESTBase, VisualEditor: Use Parsoid HTML for read-only views too - https://phabricator.wikimedia.org/T55784#937883 (10ssastry) p:5Low>3High [17:30:45] Corruption alert: visualeditor-needcheck on cswiki: https://cs.wikipedia.org/?diff=12087592 [17:30:45] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=110096680 [17:30:45] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=110113196 [17:30:45] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=110113592 [17:30:45] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=67433975 [17:30:45] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=67436381 [17:30:45] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=67436986 [17:30:46] Corruption alert: visualeditor-needcheck on ptwiki: https://pt.wikipedia.org/?diff=40891991 [17:30:46] Corruption alert: visualeditor-needcheck on ptwiki: https://pt.wikipedia.org/?diff=40893941 [17:30:47] Corruption alert: visualeditor-needcheck on ptwiki: https://pt.wikipedia.org/?diff=40893951 [17:30:47] Corruption alert: visualeditor-needcheck on ptwiki: https://pt.wikipedia.org/?diff=40893964 [17:30:48] Corruption alert: visualeditor-needcheck on slwiki: https://sl.wikipedia.org/?diff=4322090 [21:01:11] when using the arrow keys to move to a cell off the page, we don't scroll to it [21:02:33] sometimes when clicking cells it moves though, in very weird ways [21:35:42] (03CR) 10Esanders: [C: 032] demo: Unbreak eventLogger.html and eventSequencer.html [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/181136 (owner: 10Bartosz Dziewoński) [21:39:33] (03Merged) 10jenkins-bot: demo: Unbreak eventLogger.html and eventSequencer.html [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/181136 (owner: 10Bartosz Dziewoński) [21:55:02] 3VisualEditor-MediaWiki-Mobile, VisualEditor: Inspector titles clipped in VE on mobile - https://phabricator.wikimedia.org/T85068#938000 (10Esanders) 3NEW [22:06:34] edsanders: i bet that was satisfying. :D [22:07:23] I think that's the original bug I found which alerted me to it, must have forgotten about it [22:10:12] MatmaRex, do you know how the template spec model builds itself? [22:10:59] I know it reads the template names from MediaWiki:Visualeditor-cite-tool-definition.json [22:11:16] but I'm not getting any fields in the dialog - even though I've given one templatedata [22:15:55] no idea, sorry [22:23:05] found the API request [22:23:08] action=templatedata [22:26:18] edsanders, does it return no fields in the response? [22:26:27] Krenair, yes [22:26:37] is your templatedata directly on the template page? [22:26:42] or transcluded from a documentation page? [22:26:48] on the template page I think [22:26:54] check [22:27:28] it's on the page, in a noinclude [22:28:27] It's a fake version of cite web - the actual contents are "foobar" but the templatedata is real [22:29:44] should it be on a /doc page like en.wiki? [22:30:47] no [22:31:13] If it was transcluded you may have needed to make a null edit to the main page before it would get picked up by templatedata [22:31:25] (the main template page, i.e. not /doc) [22:31:41] so I just made a null-ish edit and the API is working again [22:31:53] maybe TD was disabled when I first created it [22:32:15] sweet [22:40:17] (03CR) 10Esanders: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/181108 (owner: 10Esanders) [22:41:09] (03PS2) 10Esanders: Destroy toolbar dialog manager when surface is destroyed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/181108 [22:44:07] (03CR) 10Bartosz Dziewoński: [C: 032] Destroy toolbar dialog manager when surface is destroyed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/181108 (owner: 10Esanders) [22:46:32] (03Merged) 10jenkins-bot: Destroy toolbar dialog manager when surface is destroyed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/181108 (owner: 10Esanders) [23:03:03] (03CR) 10Legoktm: "I don't see any point in backporting this." [extensions/WikiEditor] (REL1_24) - 10https://gerrit.wikimedia.org/r/175296 (owner: 10Paladox) [23:16:02] https://twitter.com/Lcawte/status/546296462255341569 [23:16:32] :P [23:35:09] 3VisualEditor, VisualEditor-MediaWiki-Mobile: Wonky toolbar menus in VE in mobile - https://phabricator.wikimedia.org/T85072#938072 (10Esanders) 3NEW [23:48:10] 3VisualEditor, VisualEditor-MediaWiki-Mobile: Wonky toolbar menus in VE in mobile - https://phabricator.wikimedia.org/T85072#938092 (10matmarex) [23:48:11] 3VisualEditor, VisualEditor-MediaWiki-Mobile: [Regression wmf13] Icons for are misaligned in the Cite dropdown menu of the toolbar in mobile VE - https://phabricator.wikimedia.org/T85025#938093 (10matmarex)