[14:44:04] 3VisualEditor, VisualEditor-MediaWiki: VisualEditor: Magically support Extension:InputBox's content for BLP warning notices on enwiki - https://phabricator.wikimedia.org/T56029#945042 (10Cenarium) >>! In T56029#800523, @TheDJ wrote: > alternatively, get away from this specific implementation and try to move it i... [14:59:32] (03PS13) 10TheDJ: Reformat the license warning only if available [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/98249 (owner: 10Dev-zero) [16:07:39] James_F, around? [16:07:51] does the fix for https://phabricator.wikimedia.org/T84897 need to be backported before this issue hits group1 wikis? [16:08:25] Krenair: Yes, but not working. :-) [16:08:27] Oy. [16:08:32] Eh. Yeah, we should backport that. [16:08:46] Can you try to get it all sorted and add something to the Deployment calendar for Monday 5 Jan? [16:09:07] Only SWAT deployments before the group1 deploy. [16:09:07] I would if there was a calendar section for that day :) [16:09:13] * James_F grins. [16:09:40] yeah needs to be in 1.25wmf13 before it goes to group1 on the 6th of January [16:12:49] will just add a new section there with a note for it [16:12:50] Add a section and put it in. :-) [16:12:52] Yeah. [16:15:04] 15:00 window? [16:22:40] James_F, https://wikitech.wikimedia.org/wiki/SWAT_deploys#15:00_UTC_window shows 15:00 and 23:00, but https://wikitech.wikimedia.org/w/index.php?title=Deployments&oldid=137042 shows they were doing 16:00 and 00:00? [17:26:37] Krenair: They're at 08:00 SF time, which is 16:00 in UTC currently. [17:28:35] (03PS1) 10Alex Monk: Remove this.$element on destroy but don't nullify [VisualEditor/VisualEditor] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/181901 [17:29:12] (03CR) 10Jforrester: [C: 032] Remove this.$element on destroy but don't nullify [VisualEditor/VisualEditor] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/181901 (owner: 10Alex Monk) [17:29:18] Not. Working. [17:29:20] Honest. :-) [17:29:23] :D [17:29:38] James_F, https://wikitech.wikimedia.org/wiki/Deployments#Week_of_January_5th - did I do it right? [17:30:43] Corruption alert: visualeditor-needcheck on cswiki: https://cs.wikipedia.org/?diff=12104254 [17:30:43] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=110277232 [17:30:43] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=67564823 [17:30:53] Krenair: No. :-) Don't list it against me, as I'll be in an aeroplane and singularly unable to verify it's been done. [17:30:59] ah [17:31:03] Krenair: Make the requester you and it's good to go, however. [17:32:44] James_F, looks like it'll have to be the evening SWAT then [17:33:11] Krenair: OK. [17:33:16] Is there a wgVariable that I can check to see if VE is active for a user? [17:33:17] (03Merged) 10jenkins-bot: Remove this.$element on destroy but don't nullify [VisualEditor/VisualEditor] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/181901 (owner: 10Alex Monk) [17:33:17] also I screwed up the who field as well. oops [17:33:21] Krenair: Or make it edsanders? [17:34:00] wgVisualEditor doesn't seem to have anything. At least not when inactive [17:34:16] James_F, shouldn't I check with Ed first? [17:35:05] T13|mobile, why do you need to check that? [17:35:20] Is this in PHP or JS? [17:35:25] Js [17:36:16] En:Template talk:Ln#Add an edit beta or vedit link [17:36:25] !!$( '#ca-ve-edit' ).length ? [17:37:05] T13|mobile: No, it's a user option. [17:37:05] T13|mobile: 'visualeditor-enable' && !'visualeditor-beta-disable' or something. [17:38:21] Thanks James_F [17:38:26] Krenair: Sure, but he'll probably be around. [17:39:15] !$skin->getUser()->getOption( 'visualeditor-enable' ) || [17:39:15] $skin->getUser()->getOption( 'visualeditor-betatempdisable' ) [17:39:20] is what the php does [17:39:28] That's it. [17:39:39] if that is true, then no VE [17:40:24] but if you want to check whether VE is enabled on the current page, there's things like checking to see if there is an edit tab, which namespace we're in, etc. [17:43:02] It's mw.user.options.get('visualeditor-enable') and it equals "1" when on (yes, a string), and it's null if off. There is no "disable" anywhere I can see. [17:43:27] Not null, undefined [17:44:21] Might be good if it was true/false. Oh well. [17:45:32] you mean you don't see visualeditor-betatempdisable ? [17:46:48] Nope, don't see it [17:48:57] 3VisualEditor, VisualEditor-ContentEditable: em and nowiki tags inserted incorrectly by VisualEditor - https://phabricator.wikimedia.org/T85377#945297 (10Automatik) 3NEW [17:48:57] And checking the language tool doesn't force ve on either. [17:49:51] Even though it's suppose to be dependent [17:51:19] Hmm. When you find yourself writing code like "delete tempOtherStack[tempStack[temp]]['@metadata'];" maybe it's time to rename some variables. :-) [17:51:54] lol [20:50:56] (03CR) 10GOIII: "As I mentioned in the discussion under T37342, retaining those arrow-xxx.png files in a patch designed just to add the .svg equivalents wo" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (owner: 10Paladox) [20:55:25] (03CR) 10GOIII: "* insert-redirect-rtl.svg is also a x-axis flip of insert-redirect.svg" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (owner: 10Paladox) [21:18:44] (03CR) 10Paladox: "Hi do you mean by removing arrow.xxx.png. what I mean is do I just add svg version and keep the png the same as before." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (owner: 10Paladox) [21:35:03] (03CR) 10GOIII: "Why are the three arrow related png files part of this patch in any way, shape or form?" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (owner: 10Paladox) [21:53:59] (03CR) 10Paladox: "Oh ok i was just asking to make sure because i thought you meant remove all the arrow png files so i will leave them untouched." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (owner: 10Paladox) [22:52:33] (03PS1) 10Amire80: Clarify a comment and correct its spelling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/181941 [23:04:44] 3VisualEditor-EditingTools, VisualEditor: VisualEditor: When adding a link to a reference without dismissing the link inspector, the link isn't applied (race condition) - https://phabricator.wikimedia.org/T69049#945537 (10Amire80) Can anybody reproduce this? I can't. Either I misunderstand the description, or it... [23:14:58] (03CR) 10Paladox: "Hi do mean by this •magnify-clip.svg is available on commons for addition to this patch. do you mean add the svg version too." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (owner: 10Paladox) [23:20:35] 3VisualEditor, VisualEditor-InterfaceLanguage, VisualEditor-ContentLanguage: VisualEditor: Support for right-to-left (rtl) / bidirectional content (tracking) - https://phabricator.wikimedia.org/T35126#945543 (10Amire80) [23:20:36] 3VisualEditor, VisualEditor-InterfaceLanguage: VisualEditor: Content menu is embedding off-screen for left-floated node in RTL environment - https://phabricator.wikimedia.org/T74668#945540 (10Amire80) 5Open>3Resolved a:3Amire80 Looks good to me now. Not sure when it was fixed. [23:42:50] (03PS10) 10Paladox: Re add svg images [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 [23:43:46] (03PS11) 10Paladox: Re add svg images [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 [23:49:56] (03CR) 10Paladox: "This could probably be merged when this gets merged https://gerrit.wikimedia.org/r/#/c/181786/" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181788 (owner: 10Paladox)