[04:26:40] 3VisualEditor-MediaWiki, VisualEditor: Special character inserter width needs adjusting - https://phabricator.wikimedia.org/T78038#952221 (10Krenair) Looks like this is to do with the margin on .ve-ui-fragmentInspector-form, margin-right: 0; seems to fix it... [04:42:26] 3VisualEditor: Opening an internal link with "CTRL + Left click" in a new page fails. - https://phabricator.wikimedia.org/T85622#952225 (10Krenair) Cannot reproduce on Chrome. [05:13:54] 3VisualEditor: "Open" button in the Link tool can sometimes lead to a broken or incorrect target - https://phabricator.wikimedia.org/T85619#952229 (10Krenair) Looks like the href of the open button is not getting updated as much as the contents of the input box changes. [05:26:04] 3VisualEditor: "Open" button in the Link tool can sometimes lead to a broken or incorrect target - https://phabricator.wikimedia.org/T85619#952231 (10Krenair) It does get updated, but it's always a step behind... Interesting. [05:32:41] (03PS1) 10Alex Monk: Link inspector: Set href of open button to new value, not old. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/182432 [05:32:56] 3VisualEditor: "Open" button in the Link tool can sometimes lead to a broken or incorrect target - https://phabricator.wikimedia.org/T85619#952234 (10Krenair) a:3Krenair [06:17:27] TimStarling: we have done a good amount of profiling [06:18:06] ah, good [06:18:42] I actually wrote https://github.com/gwicke/nodegrind to get sane profile info [06:19:21] it helped; the last major profiling effort shaved off about 30% from wt2html time on obama [06:19:49] excellent [06:19:55] for html2wt, a major bottleneck is still DOM parsing [06:20:20] partly because the HTML is currently huge [06:20:40] that'll improve once data-parsoid and data-mw are moved out [06:20:54] right [06:21:03] we also improved the performance of the dom parsing lib we are using by quite a bit [06:21:25] don't remember the exact percentage, but IIRC something like 2x [06:22:47] there is a lot of potential for parallelization in tokenization and token stream expansion [06:22:53] not so much in DOM processing [06:24:47] there is some ongoing work to distribute transclusion processing [06:25:50] I was mostly wondering whether to do some profiling on parsoid or mediawiki's parser [06:25:56] btw, Rust has a nice PEG library & a mozilla-sponsored DOM [06:26:00] it sounds like the answer is mediawiki's parser [06:26:17] it feels like it has been done before, but that was years ago now, it really needs to be done again [06:26:53] and it needs to be done using hhvm [06:27:24] and I probably need to do a lot of tight loop tests to get an idea of how to actually do micro-optimisation on hhvm [06:27:46] I think in Parsoid land the next big improvements will come from being clever about avoiding re-parsing from scratch, and from parallelization [06:29:37] the main benefit from a faster parsoid is for wikitext editors [06:30:16] for HTML editors it doesn't really make a difference in the medium term [06:32:08] right [06:36:39] to give you an idea of the current ballpark re perf, Obama from scratch without any template / image expansion reuse took about 11s on my laptop the last time I measured, while html2wt took about 2.5s [06:38:25] the reduced API load and HHVM might have improved that slightly since [06:39:18] gtg, ttyl [06:39:27] thanks, bye [07:47:48] 3VisualEditor: Textbox should expand automatically in UserInfo template - https://phabricator.wikimedia.org/T85689#952296 (1001tonythomas) 3NEW [07:48:54] 3VisualEditor: Textbox should expand automatically in UserInfo template - https://phabricator.wikimedia.org/T85689#952296 (1001tonythomas) [09:58:27] Hello i am new to mediawiki and phabricator ,so can anyone guide me how can i start contributing. I am already familiar with bugzilla and have made account in phabricator. [11:19:24] 3VisualEditor: Textboxes in template editor don't expand automatically when it's opened - https://phabricator.wikimedia.org/T85689#952363 (10matmarex) [12:57:15] 3VisualEditor: VisualEditor: Update bits still referring to Bugzilla - https://phabricator.wikimedia.org/T75733#952451 (10Elitre) To be precise, the 2 messages are MediaWiki:Feedback-bugornote and MediaWiki:Feedback-bugcheck. [15:15:08] MatmaRex, hey [15:16:53] I noticed that with the latest OOjs UI master, VE's overlay for the TextInputMenuSelectWidget in the link inspector is showing up wrong [15:19:23] * MatmaRex grumbles [15:20:15] (by the way, TextInputMenuSelectWidget is five nouns and it still tells me nothing about what it does… i think we're inching into AbstractFactoryBean territory, eh) [15:21:09] :D [15:21:39] Krenair: hmm, wrong how? looks sane at a glance on betalabs [15:22:21] so it does [15:22:26] maybe I broke my install again [15:23:02] hmph, it does act all stupid when inside, say, the reference dialog [15:23:06] 1. visit http://en.wikipedia.beta.wmflabs.org/wiki/0.24595949980612886?veaction=edit [15:23:10] 2. edit the only ref there [15:23:20] 3. add some newlines, so that a scrollbar appears inside the dialog [15:23:31] 4. open a link inspector inside the dialog, scroll down and watch the fireworks [15:24:10] (4.5 type "0." in the inspector, to get a long dropdown) [15:30:34] 3VisualEditor-MediaWiki, VisualEditor: VisualEditor: Update bits still referring to Bugzilla - https://phabricator.wikimedia.org/T75733#952529 (10Krenair) [15:33:05] MatmaRex, yeah I just hadn't built OOjs UI properly [15:42:47] (03PS1) 10Alex Monk: Update bugzilla links to phabricator [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/182462 [15:45:49] (03CR) 10Ricordisamoa: Update bugzilla links to phabricator (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/182462 (owner: 10Alex Monk) [15:47:58] (03CR) 10Alex Monk: Update bugzilla links to phabricator (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/182462 (owner: 10Alex Monk) [15:48:16] (03PS2) 10Alex Monk: Update bugzilla links to phabricator [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/182462 [16:07:43] (03PS1) 10Alex Monk: Update bugzilla links to phabricator [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/182464 [16:11:03] (03PS2) 10Alex Monk: Update bugzilla links to phabricator [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/182464 [16:25:32] 3MediaWiki-Page-editing: Long autogenerated edit comments entirely removed from page history, but not from logs - https://phabricator.wikimedia.org/T85700#952626 (10Ciencia_Al_Poder) [16:29:37] 3MediaWiki-Page-editing: Long autogenerated edit comments entirely removes because error in cutting multibyte chars - https://phabricator.wikimedia.org/T85700#952634 (10MaxBioHazard) [17:30:41] Corruption alert: visualeditor-needcheck on svwiki: https://sv.wikipedia.org/?diff=29255832 [17:30:41] Corruption alert: visualeditor-needcheck on svwiki: https://sv.wikipedia.org/?diff=29255834 [17:30:41] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=110486275 [17:30:41] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=110495380 [17:30:41] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=33806507 [17:30:42] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=33807713 [17:30:42] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=33812325 [17:30:43] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=67655229 [17:30:43] Corruption alert: visualeditor-needcheck on itwiki: https://it.wikipedia.org/?diff=69957759 [17:30:44] Corruption alert: visualeditor-needcheck on napwiki: https://nap.wikipedia.org/?diff=637571 [17:30:44] Corruption alert: visualeditor-needcheck on dawiki: https://da.wikipedia.org/?diff=7899446 [17:30:45] Corruption alert: visualeditor-needcheck on dawiki: https://da.wikipedia.org/?diff=7899448 [17:30:45] Corruption alert: visualeditor-needcheck on dawiki: https://da.wikipedia.org/?diff=7899450 [17:30:46] Corruption alert: visualeditor-needcheck on dawiki: https://da.wikipedia.org/?diff=7899455 [17:44:58] 3MediaWiki-Page-editing: Long edit comments get entirely removed instead of truncated (error in cutting multibyte chars?) - https://phabricator.wikimedia.org/T85700#952711 (10Aklapper) p:5Triage>3High [17:45:36] 3MediaWiki-Page-editing: Long edit comments get entirely removed instead of truncated (error in cutting multibyte chars?) - https://phabricator.wikimedia.org/T85700#952620 (10Aklapper) (Offtopic, but problem would be less visible if T6715 got fixed) [18:11:29] Did we have a bug about the categories toolbar appearing in random places? [18:11:34] Because I just ran into it again [19:01:07] 3MediaWiki-Page-editing: Section edit conflict expands edit box to entire article - https://phabricator.wikimedia.org/T6745#952790 (10Nemo_bis) [23:10:50] 3VisualEditor: Setting ==Section headings== on multiple lines ought to work - https://phabricator.wikimedia.org/T85655#952907 (10Etonkovidova) Yes, h2> disregards new lines in text. Seems that VE takes into account new lines in text and applies VE Heading format to each "paragraph" separately. The issue n... [23:23:10] 3VisualEditor: Search and replace is too slow - https://phabricator.wikimedia.org/T85673#952908 (10Etonkovidova) Checked with Chrome. Hmm... Did not notice any specific latency between bringing up Find-Replace boxes and availability of them for typing.