[00:01:47] 3VisualEditor, OOjs-UI: Link inspector inside media dialog has too much padding - https://phabricator.wikimedia.org/T78548#954263 (10Etonkovidova) Checked in betalabs. [00:12:53] I'm trying to set up a test instance, and when I click the VE tab, the page reloads and the URL changes, but it is still just a page view, nothing else happens [00:15:48] mw.libs.ve is undefined [00:31:19] VE core (submodule) updated? [00:32:09] thanks Krenair [00:32:36] actually the submodule is not initialised, I didn't know it existed [00:32:39] Ah. [00:34:15] funny that RL didn't log anything [00:34:21] it just set the module status to "error" [00:37:03] probably because it's not actually missing, since the module declaration is in trunk [00:37:32] so a ResourceLoaderFileModule for the class is instantiated, but errors out because it can't find files [00:38:24] different notions of 'missing'. [00:39:34] yeah, like I said, the status was "error", not "missing" [00:41:27] but if it was missing, would the effect have been any different? [08:22:07] 3VisualEditor: Deleting column after header column causes all columns to become header columns - https://phabricator.wikimedia.org/T85782#954484 (10kaldari) 3NEW [08:23:09] 3VisualEditor: Deleting column after header column causes all columns to become header columns - https://phabricator.wikimedia.org/T85782#954484 (10kaldari) [09:19:12] (03CR) 10Catrope: [C: 04-1] Limit number of find and replace results to render (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/180195 (owner: 10Esanders) [09:30:45] (03CR) 10Catrope: Limit number of find and replace results to render (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/180195 (owner: 10Esanders) [10:04:09] 3MediaWiki-Page-editing: LivePreview: Displaytitle replaces FirstHeading instead of title in FirstHeading - https://phabricator.wikimedia.org/T85784#954527 (10Fomafix) 3NEW a:3Fomafix [10:08:00] TimStarling, ori: Yeah RL errors for missing files suck. It's one of those things I've been meaning to get around to fixing but never do [10:09:33] I've been thinking about whether there is a case for batching of parsoid's requests to the MW API [10:10:59] Hmm, maybe [10:11:17] batching would probably improve throughput by a factor of 3 or so, but gwicke always said the rationale is to optimise for latency [10:11:21] because it's only money [10:11:48] or something [10:12:04] About a year ago Gabriel asked if it would be possible to gzip HTTP traffic between the VE API and Parsoid. I found that it would be non-straightforward, and I figured it wouldn't matter much because it's an internal network [10:12:30] yeah, shouldn't matter much [10:12:37] Especially since it's just one request [10:12:48] VE could do its part to avoid toasting the API cluster also [10:12:51] But you're talking about reducing the # of requests, which even on an internal network I imagine might help [10:12:56] by batching imageinfo requests [10:13:10] Yeah I noticed we did that [10:13:18] and filed a task before I went on vacation [10:13:23] well, when I say 2/3 I mean average request time is ~60ms with ~40ms of startup overhead [10:13:48] https://phabricator.wikimedia.org/T75822 [10:14:17] Oh wow there's a WIP patch for that bug now [10:14:22] so if you do say 10 template expansions per API call, instead of 1, then the parse time dominates instead of the setup time [10:14:30] I like people doing work behind my back while I'm on vacation [10:14:38] good stuff [10:14:42] Yeah that makes sense [10:15:05] well, it makes sense as a throughput optimisation [10:15:06] If you make lots of small requests (both in the imageinfo and template expansion cases), setup time starts dominating pretty quickly [10:15:28] Yeah I guess latency-wise it doesn't matter much [10:15:30] the tradeoff is that you have to wait for 10 templates to appear in the token stream before you can send off the batch request [10:15:38] and might even hurt slightly from Parsoid's perspective [10:18:46] but you know, parsoid is meant to be for everyone [10:18:52] not just people who can afford infinite hardware [10:19:01] it probably should at least be configurable [10:19:20] Yeah that's fair [10:19:20] then we can tune the batch size for an optimal throughput/latency tradeoff [10:19:39] If we really wanted to not use batching, WMF config could set a batch size of 1 [10:19:45] right [10:19:56] which reminds me [10:20:17] parsoid has all its HTTP timeouts and connection limits hard coded [10:20:38] which is probably not best practise [10:21:46] Ouch [10:24:48] (03CR) 10Catrope: [C: 04-1] Use viewport clipping when lots of search results found (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/180635 (owner: 10Esanders) [10:44:20] (03CR) 10Mvolz: [C: 04-1] Detect and request PMID/PCMID info (031 comment) [services/citoid] - 10https://gerrit.wikimedia.org/r/182752 (owner: 10Sn1per) [11:08:59] (03CR) 10Esanders: Use viewport clipping when lots of search results found (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/180635 (owner: 10Esanders) [11:10:31] (03CR) 10Catrope: Use viewport clipping when lots of search results found (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/180635 (owner: 10Esanders) [11:16:49] (03PS3) 10Esanders: Limit number of find and replace results to render [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/180195 [11:16:51] (03PS3) 10Esanders: Use viewport clipping when lots of search results found [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/180635 [11:17:02] (03PS4) 10Esanders: Limit number of find and replace results to render [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/180195 [11:17:03] (03PS4) 10Esanders: Use viewport clipping when lots of search results found [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/180635 [11:41:17] Heya all. [11:43:31] (03CR) 10Jforrester: [C: 032] Update grunt-css-url-embed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/181976 (owner: 10Esanders) [11:48:38] (03Merged) 10jenkins-bot: Update grunt-css-url-embed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/181976 (owner: 10Esanders) [11:55:38] 3VisualEditor: Allow copy/pasting of tables - https://phabricator.wikimedia.org/T85791#954634 (10Elitre) 3NEW [12:04:01] (03CR) 10Jforrester: [C: 032] Update bugzilla links to phabricator [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/182464 (owner: 10Alex Monk) [12:05:03] 3VisualEditor-EditingTools, VisualEditor-MediaWiki-Links, VisualEditor: "Open" button in the Link tool can sometimes lead to a broken or incorrect target - https://phabricator.wikimedia.org/T85619#954662 (10Jdforrester-WMF) p:5Triage>3High [12:05:45] (03CR) 10Jforrester: [C: 032] Update bugzilla links to phabricator [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/182462 (owner: 10Alex Monk) [12:07:38] (03Merged) 10jenkins-bot: Update bugzilla links to phabricator [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/182462 (owner: 10Alex Monk) [12:07:44] (03Merged) 10jenkins-bot: Update bugzilla links to phabricator [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/182464 (owner: 10Alex Monk) [12:08:36] 3VisualEditor, VisualEditor-MediaWiki: Update bits of VisualEditor still referring to Bugzilla - https://phabricator.wikimedia.org/T75733#954672 (10Jdforrester-WMF) p:5Triage>3Normal a:3Krenair [12:09:50] 3VisualEditor-MediaWiki, VisualEditor: Edit source link broken after editing the page with VisualEditor - https://phabricator.wikimedia.org/T85552#954680 (10Jdforrester-WMF) p:5Triage>3Normal [12:10:38] 3VisualEditor, VisualEditor-MediaWiki-Mobile: [Regression wmf13] Icons are misaligned in the Cite dropdown menu of the toolbar in mobile VE - https://phabricator.wikimedia.org/T85025#954684 (10Jdforrester-WMF) p:5Triage>3Normal [12:11:03] 3VisualEditor, VisualEditor-MediaWiki: "Watch this page" option does not reflect the status of the article if it was changed without reloading - https://phabricator.wikimedia.org/T78694#954686 (10Jdforrester-WMF) p:5Triage>3Normal [12:11:44] 3MobileFrontend-stable, VisualEditor, VisualEditor-MediaWiki-Mobile: Inspector titles clipped in VisualEditor on mobile - https://phabricator.wikimedia.org/T85068#954688 (10Jdforrester-WMF) p:5Triage>3Normal a:3Esanders [12:12:07] Morning James_F [12:12:13] Aren't you supposed to be flying at some point [12:12:25] RoanKattouw: If the plane shows up, yes. :-) [12:12:33] Oh not for an hour or two I see [12:12:36] * James_F grumbles about 787s. [12:12:49] Oh God and an hour delayed too [12:12:50] Boarding is now theorised to be 14:45 rather than 13:00. [12:12:55] Yeah. Fun times. [12:13:04] hah, Google claims departure at 14:45 (from 13:40) [12:13:08] Ha. [12:13:18] That's what they're saying is the announcement-about-the-plane time. [12:13:26] We'll see. [12:13:35] Anyway, how are you? [12:13:38] I'm good [12:13:45] Working at the WMNL office in Utrecht today [12:14:05] Re-wrapping my mind around subdocuments and references and binary search [12:15:47] * James_F nods. [12:15:49] Having fun? ;-) [12:16:52] 3VisualEditor-EditingTools, VisualEditor: Leading white spaces should be highlighted and converted to   or something - https://phabricator.wikimedia.org/T78137#954707 (10Jdforrester-WMF) [12:17:08] I'll be having more fun once things start working :P [12:17:28] * James_F grins. [12:18:29] 3MediaWiki-General-or-Unknown, UI-Standardization, OOjs-UI: Initialize theme and set directionality in MediaWiki Core - https://phabricator.wikimedia.org/T85767#954712 (10Jdforrester-WMF) [12:18:59] 3MediaWiki-Interface, UI-Standardization, OOjs-UI: Provide the OOUI PHP module inside MW core - https://phabricator.wikimedia.org/T74714#954714 (10Jdforrester-WMF) [12:19:35] 3OOjs-UI: No demo for LookupInputWidget - https://phabricator.wikimedia.org/T85467#954720 (10Jdforrester-WMF) p:5Triage>3Normal [12:19:58] 3UI-Standardization, OOjs-UI: In MediaWiki theme, some thin grey lines in dialogs do not appear in some configurations - https://phabricator.wikimedia.org/T85226#954723 (10Jdforrester-WMF) p:5Triage>3Normal [12:20:18] 3OOjs-UI: OOjs UI should have a central hub that lives outside MediaWiki.org - https://phabricator.wikimedia.org/T85466#954726 (10Jdforrester-WMF) p:5Triage>3Volunteer? [12:20:42] 3OOjs-UI: Rewrite PHP/JS comparison scripts from Ruby to Node.js - https://phabricator.wikimedia.org/T84839#954729 (10Jdforrester-WMF) p:5Triage>3Volunteer? [12:23:32] 3VisualEditor: reconsider the terminology around citations, references and footnotes in VisualEditor - https://phabricator.wikimedia.org/T85679#954739 (10Jdforrester-WMF) p:5Triage>3Low a:3Jdforrester-WMF [12:25:19] 3VisualEditor: Search and replace is too slow - https://phabricator.wikimedia.org/T85673#954750 (10Jdforrester-WMF) [12:25:23] 3VisualEditor-EditingTools, VisualEditor: Limit effect of search-and-replace assessment on long documents - https://phabricator.wikimedia.org/T78234#954751 (10Jdforrester-WMF) [12:27:30] 3VisualEditor: Please make the "More" and "Fewer" setting in the Insert menu be sticky - https://phabricator.wikimedia.org/T85638#954762 (10Jdforrester-WMF) 5Open>3declined a:3Jdforrester-WMF We intentionally made this not sticky to ensure that the editor is always in the same state when you open it, to av... [12:28:13] 3VisualEditor-EditingTools, VisualEditor: cmd + K doesn't trigger link tool in Opera - https://phabricator.wikimedia.org/T85617#954765 (10Jdforrester-WMF) p:5Triage>3Volunteer? [12:29:15] 3VisualEditor-MediaWiki-Templates, VisualEditor: Insert/Template inspector should put focus on input text_field when invoked but no longer does - https://phabricator.wikimedia.org/T85484#954774 (10Jdforrester-WMF) p:5Triage>3Normal [12:29:59] 3Editing, MobileFrontend-beta, VisualEditor, VisualEditor-MediaWiki-Mobile: Back arrow appears before other VE controls in MobileFrontend but does nothing - https://phabricator.wikimedia.org/T85481#954777 (10Jdforrester-WMF) p:5Triage>3Normal [12:32:33] 3VisualEditor-ContentEditable, VisualEditor: Can't type anything after placing cursor just up-page of a citation node immediately after adding it, in Firefox - https://phabricator.wikimedia.org/T84904#954785 (10Jdforrester-WMF) p:5Triage>3Normal [12:35:47] 3VisualEditor: Allow copy/pasting of tables - https://phabricator.wikimedia.org/T85791#954795 (10Jdforrester-WMF) You can do this, but you have to select either side of it to work. Copying sub-parts of tables doesn't, however, so re-purposing this. [12:36:22] 3VisualEditor-Tables, VisualEditor, VisualEditor-CopyPaste: Allow copy/pasting of arbitrary selections of table cells - https://phabricator.wikimedia.org/T85791#954797 (10Jdforrester-WMF) p:5Triage>3Normal [12:36:48] 3VisualEditor-Tables, VisualEditor: Deleting column after header column causes all columns to become header columns - https://phabricator.wikimedia.org/T85782#954802 (10Jdforrester-WMF) p:5Triage>3Normal [12:37:29] 3VisualEditor, VisualEditor-CopyPaste: Copy and paste inside VE includes black sun ☀ character - https://phabricator.wikimedia.org/T85432#954805 (10Jdforrester-WMF) [12:37:29] 3VisualEditor, VisualEditor-CopyPaste: Pasting an external link adds a ☀ - https://phabricator.wikimedia.org/T76916#954806 (10Jdforrester-WMF) [12:37:49] 3VisualEditor-EditingTools, VisualEditor: VisualEditor: Be able to copy the name of an image - https://phabricator.wikimedia.org/T72244#954808 (10Jdforrester-WMF) [12:37:54] 3VisualEditor-EditingTools, VisualEditor: VisualEditor: Please show the file name in the media dialog, and make it easy to copy it - https://phabricator.wikimedia.org/T71726#954809 (10Jdforrester-WMF) [12:40:51] edsanders: You around? [12:41:02] yup [12:41:16] edsanders: Any objection to me cutting an OOjs UI release? Anything you want to get in this week? [12:42:09] (Heya Krinkle too. :-)) [12:42:38] my icon rewrite maybe [12:43:01] edsanders: I think that has some issues. [12:43:10] edsanders: Something Trevor said about natural sizing of SVGs? [12:43:13] * James_F forgets. [12:43:15] 3VisualEditor, VisualEditor-MediaWiki-Mobile: [Regression pre-wmf14] In mobile VE, as soon as you place your cursor inside the field in Citation dialog and type, the text box disappears - https://phabricator.wikimedia.org/T84914#954816 (10Jdforrester-WMF) p:5Triage>3High [12:43:26] Anyway, there's not enough time for that to land, really. [12:43:51] ok, in which browser? [12:44:44] edsanders: IE I think? Not your patch, but general issues around it. [12:44:52] edsanders: https://gerrit.wikimedia.org/r/#/c/176634/ could land, maybe? [12:45:35] (03CR) 10Jforrester: "What's WIP here?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180228 (owner: 10Alex Monk) [12:45:39] the one I think we should abandon? [12:46:04] (03CR) 10Jforrester: [C: 04-1] "Per Ed's comment. Otherwise, what's WIP here?" [oojs/ui] - 10https://gerrit.wikimedia.org/r/175568 (owner: 10Mooeypoo) [12:47:23] edsanders: Eh. Sure. It's mostly harmless. [12:47:46] edsanders: And it stops terrible SVGs making the repo huge when people merge them without going through you/me/Trevor. ;-) [12:48:08] which happens never [12:48:21] And it adds to the build time [12:48:39] I'm also not convinced it's safe [12:48:51] I'd rather people tested the SVGs after svgo [12:49:17] We could have a validation check that sees if your svg compresses more than 10% or something [12:54:32] 3VisualEditor, VisualEditor-CopyPaste: Pasting next to an MWEntity adds a ☀ - https://phabricator.wikimedia.org/T76916#954826 (10Esanders) [12:55:11] edsanders: OK, let's abandon and branch. [12:55:16] edsanders: You abandon, I'll branch. [12:56:19] (03CR) 10Esanders: [C: 04-2] "If there were a quick way to test if an SVG contained too much metadata or hadn't been compressed properly- I'd support that being a votin" [oojs/ui] - 10https://gerrit.wikimedia.org/r/176634 (owner: 10Prtksxna) [12:58:22] (03PS1) 10Jforrester: Tag v0.6.1 [oojs/ui] - 10https://gerrit.wikimedia.org/r/182787 [12:58:29] edsanders: Please do the honours. [12:59:32] (03CR) 10Esanders: [C: 032] Tag v0.6.1 [oojs/ui] - 10https://gerrit.wikimedia.org/r/182787 (owner: 10Jforrester) [12:59:37] Ta. [13:01:48] (03PS1) 10Jforrester: Update VE core submodule to master (a687518) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/182790 [13:01:58] 3VisualEditor: Add a close button to the VisualEditor search and replace bar - https://phabricator.wikimedia.org/T85792#954837 (10Amire80) 3NEW [13:03:59] 3VisualEditor: Add a close button to the VisualEditor search and replace bar - https://phabricator.wikimedia.org/T85792#954849 (10Jdforrester-WMF) [13:04:00] 3VisualEditor-EditingTools, VisualEditor: Add a cross button to close the Find-Replace panel or clicking on CE may slide it up ? - https://phabricator.wikimedia.org/T77933#954850 (10Jdforrester-WMF) [13:04:03] (03Merged) 10jenkins-bot: Tag v0.6.1 [oojs/ui] - 10https://gerrit.wikimedia.org/r/182787 (owner: 10Jforrester) [13:05:31] (03PS1) 10Jforrester: Update OOjs UI to v0.6.1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/182791 [13:09:18] (03CR) 10jenkins-bot: [V: 04-1] Update OOjs UI to v0.6.1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/182791 (owner: 10Jforrester) [13:09:53] (03CR) 10Jforrester: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/182791 (owner: 10Jforrester) [13:10:19] edsanders: Please +2 https://gerrit.wikimedia.org/r/#/q/Iafe5770c74b671dc04a92b9dfab6f121e7fe718d,n,z if Jenkins will let you. ;-) [13:14:18] edsanders: Oh, and https://gerrit.wikimedia.org/r/#/c/182790/ of course. [13:15:31] (03CR) 10Jforrester: [C: 031] Update "Watch this page" option when necessary [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/182336 (owner: 10Alex Monk) [13:16:42] (03PS1) 10Esanders: Fix context comparison on after paste [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/182795 [13:17:06] (03CR) 10Esanders: [C: 032] Update OOjs UI to v0.6.1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/182791 (owner: 10Jforrester) [13:17:35] (03CR) 10Esanders: [C: 032] Update VE core submodule to master (a687518) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/182790 (owner: 10Jforrester) [13:18:04] Thanks. :-) [13:19:06] (03CR) 10Esanders: "ping" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/181117 (owner: 10Esanders) [13:20:09] (03CR) 10jenkins-bot: [V: 04-1] Fix context comparison on after paste [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/182795 (owner: 10Esanders) [13:21:37] (03Merged) 10jenkins-bot: Update OOjs UI to v0.6.1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/182791 (owner: 10Jforrester) [13:21:46] (03CR) 10Jforrester: [C: 032] Update stylsheets from direction on init [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/181117 (owner: 10Esanders) [13:22:20] (03CR) 10Jforrester: [C: 04-1] Fix context comparison on after paste (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/182795 (owner: 10Esanders) [13:23:00] (03Merged) 10jenkins-bot: Update VE core submodule to master (a687518) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/182790 (owner: 10Jforrester) [13:23:20] (03CR) 10Jforrester: [C: 032] Don't break "Edit source" link after VE has closed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/181679 (owner: 10Alex Monk) [13:23:35] (03Merged) 10jenkins-bot: Update stylsheets from direction on init [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/181117 (owner: 10Esanders) [13:28:37] (03CR) 10Jforrester: [C: 032] Update comment to indicate TD uses jquery.uls.data [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/182581 (owner: 10Mvolz) [13:28:44] (03Merged) 10jenkins-bot: Don't break "Edit source" link after VE has closed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/181679 (owner: 10Alex Monk) [13:29:29] (03CR) 10Jforrester: [C: 032] Correctly detect if jquery.uls.data is loaded [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/182580 (owner: 10Mvolz) [13:30:18] (03Merged) 10jenkins-bot: Update comment to indicate TD uses jquery.uls.data [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/182581 (owner: 10Mvolz) [13:30:25] (03Merged) 10jenkins-bot: Correctly detect if jquery.uls.data is loaded [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/182580 (owner: 10Mvolz) [13:30:39] 3VisualEditor, VisualEditor-MediaWiki: Update bits of VisualEditor still referring to Bugzilla - https://phabricator.wikimedia.org/T75733#954917 (10Jdforrester-WMF) 5Open>3Resolved [13:30:52] 3VisualEditor-MediaWiki, VisualEditor: Edit source link broken after editing the page with VisualEditor - https://phabricator.wikimedia.org/T85552#954919 (10Jdforrester-WMF) 5Open>3Resolved [13:31:01] 3OOjs-UI, VisualEditor, VisualEditor-MediaWiki: Dialog section labels are way too big compared to the rest of the contents of a dialog - https://phabricator.wikimedia.org/T78037#954921 (10Jdforrester-WMF) 5Open>3Resolved [13:35:10] (03CR) 10Jforrester: [C: 032] Toolbar help: Make magic word from help string a param [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/178180 (owner: 10TheDJ) [13:35:18] (03Merged) 10jenkins-bot: Toolbar help: Make magic word from help string a param [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/178180 (owner: 10TheDJ) [13:36:38] edsanders: You fixing https://gerrit.wikimedia.org/r/#/c/182795/ already? Would really really like to get that one out. :-) [13:37:17] (03CR) 10Jforrester: "How can I help move this along?" [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/168746 (owner: 10Mvolz) [13:37:22] I reviewed the find&replace throttling stuff BTW [13:37:31] It looks good to me but I haven't had the opportunity to test any of it yet [13:39:58] RoanKattouw: Want me to test and +2 if it works? [13:40:38] (My plane still hasn't arrived, BTW. *sighs*) [13:40:47] Sure [13:40:59] Kk. [13:41:24] (03CR) 10Catrope: [C: 031] "Code looks good, but I'm not able to test this right now" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/182795 (owner: 10Esanders) [13:42:13] RoanKattouw: What about its follow-up? [13:42:19] (03CR) 10Catrope: [C: 031] Limit number of find and replace results to render [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/180195 (owner: 10Esanders) [13:42:27] (03CR) 10Catrope: [C: 031] Use viewport clipping when lots of search results found [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/180635 (owner: 10Esanders) [13:42:33] Aha, thanks. [13:45:50] Hmm. Performance isn't hugely improved in my test… [13:48:30] (03CR) 10Jforrester: [C: 032] "Better, but not amazing performance still." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/180635 (owner: 10Esanders) [13:48:51] (03CR) 10Jforrester: [C: 032] "Works fine." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/180195 (owner: 10Esanders) [13:51:55] (03Merged) 10jenkins-bot: Limit number of find and replace results to render [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/180195 (owner: 10Esanders) [13:53:10] (03CR) 10jenkins-bot: [V: 04-1] Use viewport clipping when lots of search results found [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/180635 (owner: 10Esanders) [13:53:16] * James_F sighs. [13:53:43] (03CR) 10Jforrester: [C: 032] "C'mon." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/180635 (owner: 10Esanders) [13:56:25] (03Merged) 10jenkins-bot: Use viewport clipping when lots of search results found [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/180635 (owner: 10Esanders) [13:57:03] 3MediaWiki-Page-editing: LivePreview should not replace tilte message with displaytitle value in in firstHeading - https://phabricator.wikimedia.org/T85784#954962 (10Krinkle) [14:00:52] 3VisualEditor-EditingTools, VisualEditor-MediaWiki-Templates, VisualEditor: Navigating via Tab between fields in TransclusionCitation boxes switches to the Find/Replace fields in the background - https://phabricator.wikimedia.org/T84919#954966 (10Jdforrester-WMF) p:5Triage>3Normal [14:02:34] James_F, what is your test? [14:03:17] edsanders: Make a page with ~10,000 copies of "foo " in it (stand-alone VE, starting from an empty page). Open S&R tool. Click into the "find" field and type "o". [14:03:35] edsanders: Tab goes single-tasking for ~20 seconds. [14:04:03] (03PS2) 10Esanders: Fix context comparison on after paste [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/182795 [14:05:13] (03CR) 10Jforrester: [C: 031] ";-)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/182795 (owner: 10Esanders) [14:07:07] (03CR) 10jenkins-bot: [V: 04-1] Fix context comparison on after paste [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/182795 (owner: 10Esanders) [14:08:51] (03PS1) 10Jforrester: Update VE core submodule to master (147c576) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/182803 [14:12:32] 3MediaWiki-Page-editing: Collapsible lists on edit page footer no longer collapsible after live preview is used - https://phabricator.wikimedia.org/T55918#954988 (10TheDJ) This is one more of those UI elements that we should get implemented using PHP/JS templates etc, to make it consistent. We better focus on so... [14:14:11] James_F, takes 5 seconds for me but that your test case causes it to render 5,000 highlights [14:14:34] (03PS1) 10Jforrester: Update VE core submodule to wmf/1.25wmf13 for cherry-pick (34f4110) [extensions/VisualEditor] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/182804 [14:14:49] edsanders: Sure, I agree that users have unrealistic expectations, but… ;-) [14:15:04] Oh, right [14:15:21] edsanders: Could you +2 https://gerrit.wikimedia.org/r/182804 and stand-by around 2 hours from now to agree that VE still works when it's deployed? [14:15:33] The second change removes the hard limit on the # of highlights, assuming there will never be an unreasonable number of highlights in view all at once [14:15:39] yes [14:15:41] RoanKattouw: Indeed. [14:15:56] we could reinstate but then you have to guess what reasonable is [14:16:10] 100. :-) [14:16:43] it feels wrong to render the first X, perhaps if there are > N result on the page, we render nothing [14:16:49] Possibly. [14:16:55] Anyway. [14:17:08] https://gerrit.wikimedia.org/r/182804 please. :-) [14:17:10] Before I need to run for my flight. [14:17:30] The internet says 15:10 now [14:17:47] Yeah, they just said it was going to board in ~ 10 minutes maybe. [14:17:55] Also, tsk, it's Internet. [14:17:58] OK yeah that sounds about right [14:18:20] Freaking Houston, man [14:18:48] Second-to-last time I was scheduled to fly home via Houston the exact same thing happened to me and I managed to get the last seat on a flight to Chicago instead [14:19:14] 3VisualEditor, VisualEditor-MediaWiki-Mobile: [Regression wmf13] Icons are misaligned in the Cite dropdown menu of the toolbar in mobile VE - https://phabricator.wikimedia.org/T85025#955001 (10Jdforrester-WMF) 5Open>3Resolved [14:19:23] If I hadn't done that I would've been delayed 3 or 4 hours or something crazy [14:20:15] (03PS1) 10Esanders: Documentation fix [oojs/ui] - 10https://gerrit.wikimedia.org/r/182805 [14:21:00] (03PS2) 10Jforrester: WindowManager#removeWindows: Documentation fix [oojs/ui] - 10https://gerrit.wikimedia.org/r/182805 (owner: 10Esanders) [14:21:07] (03CR) 10Jforrester: [C: 032] WindowManager#removeWindows: Documentation fix [oojs/ui] - 10https://gerrit.wikimedia.org/r/182805 (owner: 10Esanders) [14:22:30] 3MediaWiki-Page-editing: LivePreview should not replace title message with displaytitle value in in firstHeading - https://phabricator.wikimedia.org/T85784#955004 (10Fomafix) [14:23:44] edsanders: Please? [14:24:07] (03CR) 10Esanders: [C: 032] Update VE core submodule to wmf/1.25wmf13 for cherry-pick (34f4110) [extensions/VisualEditor] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/182804 (owner: 10Jforrester) [14:24:23] 3VisualEditor-EditingTools, VisualEditor: Limit effect of search-and-replace assessment on long documents - https://phabricator.wikimedia.org/T78234#955005 (10Jdforrester-WMF) This is now better, but not great in very extreme cases. [14:25:07] edsanders: BTW, on the S&R front, a common not-insane thing to do is to look for ' ' (double space) and turn into ' ' (single space). Searching will crash when you type in the first of the two spaces to search for… [14:25:34] 3MediaWiki-Page-editing: LivePreview should not replace title message with displaytitle value in in firstHeading - https://phabricator.wikimedia.org/T85784#955006 (10Fomafix) [14:26:43] takes about 1.5s on long.html [14:27:14] Long.html isn't that long. [14:27:32] (03Merged) 10jenkins-bot: WindowManager#removeWindows: Documentation fix [oojs/ui] - 10https://gerrit.wikimedia.org/r/182805 (owner: 10Esanders) [14:27:47] (Presumably.) [14:28:20] (03PS2) 10Sn1per: Detect and request PMID/PCMID info [services/citoid] - 10https://gerrit.wikimedia.org/r/182752 [14:29:13] (03Merged) 10jenkins-bot: Update VE core submodule to wmf/1.25wmf13 for cherry-pick (34f4110) [extensions/VisualEditor] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/182804 (owner: 10Jforrester) [14:29:43] 3MediaWiki-extensions-ProofreadPage, MediaWiki-Page-editing: New improved LivePreview incompatible with ProofreadPage's fancy forms for Index: namespace pages - https://phabricator.wikimedia.org/T78709#955034 (10TheDJ) Yeah, before we did a normal submit, so whatever form was there, it got submitted, rendered an... [14:42:04] (03CR) 10Jforrester: [C: 031] "Think this is now good to go – Moriel, can you confirm?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177946 (owner: 10Divec) [14:42:12] OK, that's my flight. [14:42:13] Bye all! [14:45:15] 3VisualEditor-Tables, VisualEditor, VisualEditor-CopyPaste: Allow copy/pasting of arbitrary selections of table cells - https://phabricator.wikimedia.org/T85791#955069 (10Elitre) I'm testing on https://en.wikipedia.org/wiki/Manchester_British-Americans . I don't manage to copy/paste the table in Safari, but it s... [14:49:10] (03PS1) 10Esanders: Clear windows when destroying window manager [oojs/ui] - 10https://gerrit.wikimedia.org/r/182812 [14:50:59] (03PS2) 10Esanders: Clear windows when destroying window manager [oojs/ui] - 10https://gerrit.wikimedia.org/r/182812 [14:52:43] (03PS1) 10Esanders: Destroy the surface when switching away from VE mode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/182813 [14:53:00] James_F|Away, bye [14:53:18] (Long.html is long, it just doesn't have a single small word repeated) [14:58:02] (03CR) 10Catrope: Native leftarrow and rightarrow (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177946 (owner: 10Divec) [14:58:09] (03CR) 10Catrope: Native leftarrow and rightarrow (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177946 (owner: 10Divec) [14:58:18] James_F|Away: RoanKattouw: https://phabricator.wikimedia.org/T76204#955076 - we may want to switch to always() instead of done() for ve plugins. [14:58:38] that way a broken plugin or site/user module (which may provide a plugin) doesn't affect VE. [14:58:48] Krinkle: Good catch [14:59:09] James_F|Away: Contrary to what you might think, user scripts exceptions don't interfere with VE at all. They affect VE because VE explicitly waits for "done" [15:00:55] 3MediaWiki-ResourceLoader: ResourceLoader: Implement support for Source Maps - https://phabricator.wikimedia.org/T47514#955085 (10Krinkle) p:5Normal>3Low [15:22:40] 3MediaWiki-ResourceLoader: ResourceLoader: wfDebugLog should bypass wfIsDebugRawPage() filter - https://phabricator.wikimedia.org/T49960#955108 (10Krinkle) 5Open>3Resolved a:3Krinkle Indeed. This behaviour was changed by 28a7ce420bd9. Which changed wfDebugLog to use MWLogger instead of `wfDebug`. And the `... [15:24:19] 3MediaWiki-ResourceLoader: ResourceLoader: wfDebugLog should bypass wfIsDebugRawPage() filter - https://phabricator.wikimedia.org/T49960#955114 (10Krinkle) [15:26:36] 3MediaWiki-ResourceLoader: Debug mode causes different rendering of CSS in IE9 - https://phabricator.wikimedia.org/T52830#955117 (10Krinkle) Does the desired rendering happening in debug mode or in production mode? If IE has trouble parsing minified CSS, then the correct rendering would occur in debug mode, and... [15:29:46] 3MediaWiki-ResourceLoader: modules loaded with using() fail in debug mode - https://phabricator.wikimedia.org/T36485#955127 (10Krinkle) 5Open>3Resolved a:3Krinkle I can't reproduce this on latest MediaWiki master. Please re-open if you can reproduce this issue. [15:32:23] 3MediaWiki-ResourceLoader: Implement support for LESS pre-processor in ResourceLoader - https://phabricator.wikimedia.org/T42964#955134 (10Krinkle) [15:32:24] 3MediaWiki-ResourceLoader: Add SASS and Compass support to ResourceLoader - https://phabricator.wikimedia.org/T48545#955135 (10Krinkle) [15:32:24] 3MediaWiki-ResourceLoader: Add support for pre-processing in debug mode - https://phabricator.wikimedia.org/T48546#955131 (10Krinkle) 5Open>3Invalid a:3Krinkle ResourceLoader doesn't need implementation for individual pre-processors for debug mode. Pre-processors should not (and afaik do not) minify by def... [15:33:19] 3MediaWiki-ResourceLoader: Make it possible to debug private mw.loader variables - https://phabricator.wikimedia.org/T30846#955142 (10Krinkle) 5Open>3declined a:3Krinkle Can be trivially inspecting using developer tools in modern browsers. And if really needed, revert to your local install and set breakpoi... [15:37:54] 3MediaWiki-ResourceLoader: Implement feature for logging in debug mode - https://phabricator.wikimedia.org/T39763#955152 (10Krinkle) p:5Normal>3Low [15:44:09] 3MediaWiki-ResourceLoader: ResourceLoader: Redesign how debug mode operates - https://phabricator.wikimedia.org/T85805#955168 (10Krinkle) 3NEW [15:44:46] 3MediaWiki-ResourceLoader: ResourceLoader: Redesign how debug mode operates - https://phabricator.wikimedia.org/T85805#955168 (10Krinkle) [15:45:04] 3MediaWiki-ResourceLoader: ResourceLoader: Debug mode should not execute scripts in the global scope - https://phabricator.wikimedia.org/T64605#677384 (10Krinkle) [15:45:16] 3MediaWiki-ResourceLoader: ResourceLoaderFileModule should have a debug mode for styles - https://phabricator.wikimedia.org/T29025#302226 (10Krinkle) [16:00:20] 3MediaWiki-ResourceLoader: Debug mode causes different rendering of CSS in IE9 - https://phabricator.wikimedia.org/T52830#955229 (10matmarex) [16:29:58] 3Editing, Mobile-Web, VisualEditor: in MobileFrontend, invoking the editor is incorrect and switching from VisualEditor to wikitext editor does nothing - https://phabricator.wikimedia.org/T85480#955332 (10matmarex) 5Resolved>3Open This probably needs some swift backporting to wmf13? [16:42:30] 3VisualEditor-Tables, Parsoid, VisualEditor: Deleting column after header column causes all columns to become header columns - https://phabricator.wikimedia.org/T85782#955368 (10matmarex) [17:17:36] 3VisualEditor-Tables, VisualEditor-CopyPaste, VisualEditor: Allow copy/pasting of arbitrary selections of table cells - https://phabricator.wikimedia.org/T85791#955432 (10Elitre) Will right-clicking on the table to copy it ever work? [17:30:29] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=110614971 [17:30:29] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=33840556 [17:30:29] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=67712473 [17:30:29] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=67718117 [17:30:29] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=67728133 [17:34:59] (03PS3) 10Esanders: Fix context comparison on after paste [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/182795 [17:48:17] 3VisualEditor-EditingTools, VisualEditor: Changes to extension node attributes are ignored - https://phabricator.wikimedia.org/T85818#955495 (10Krinkle) 3NEW [17:50:28] edsanders: Do you know if ^ worked at all? Or new "feature"? [17:50:59] it used to work [17:51:37] the syntax highlighting doesn't change immediately, because I think it loads the modules for the languages present on the page at the start [17:51:44] but the wikitext should update when you save [17:53:04] edsanders: Yeah, the highlighting not being live is fine. But it doesn't get new HTML from the API, and isn't reflected in dm or wikitext. [17:56:28] hmm, teardown is called before updateMwData [17:56:38] which empties this.attributeInputs [17:58:30] (03CR) 10Alex Monk: "I don't remember. Might've been something to do with titles. Hopefully it'll come up in review if it's still an issue." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180228 (owner: 10Alex Monk) [17:58:36] (03PS3) 10Alex Monk: Combine imageinfo requests by setting up a new class like LinkCache to request them all centrally [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180228 [18:00:23] (03PS1) 10Esanders: Fix teardown order of MWAlienExtensionsInspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/182846 [18:01:09] (03PS6) 10Mvolz: Use TempateData to insert citations [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/168746 [18:01:49] (03PS22) 10Divec: Native leftarrow and rightarrow [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177946 [18:02:30] (03CR) 10Mvolz: "No changes, just removing WIP in title. Just needs review from my standpoint." [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/168746 (owner: 10Mvolz) [18:04:07] (03CR) 10Mvolz: "(The behaviour is to show an error if there's no config messages, but might want to change this for production to just not load in that ca" [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/168746 (owner: 10Mvolz) [18:16:45] (03CR) 10Catrope: [C: 032] Fix teardown order of MWAlienExtensionsInspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/182846 (owner: 10Esanders) [18:18:55] (03Merged) 10jenkins-bot: Fix teardown order of MWAlienExtensionsInspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/182846 (owner: 10Esanders) [18:20:07] (03CR) 10Mvolz: [C: 032 V: 032] Detect and request PMID/PCMID info [services/citoid] - 10https://gerrit.wikimedia.org/r/182752 (owner: 10Sn1per) [18:39:39] RoanKattouw:the bugs about "disappearing" categories - 85671, 76998, 74048 - there are my comments... [18:40:06] not too helpful - I think. I could not reproduce the issue entirely [18:43:05] etonkovidova: Ooh there are some good things there [18:43:17] good to know :) [18:44:21] Oh wait, that's different, the category doesn't really disappear, it just moves [18:44:32] But AFAIK in these reports the categories really do go away [18:45:27] Or, in the case of https://phabricator.wikimedia.org/T74048 , moving to random places [18:46:24] yeah, this is the problem - the complains were about total disappearnce [18:46:41] as much as I tired - it never actually happened [18:47:12] Hmm [18:47:24] Sometimes they disappear, sometimes they end up inside references [18:47:43] I now have a suspicion about what's happening [18:47:56] in production, the page content is big enough to cause disappearance? - it sound lame, I know... [18:47:58] Maybe the metadata is getting misaligned from the data in some way [18:48:08] oh, that [18:48:22] is undoubdetly so [18:48:23] But I don't see how that could happen [18:48:38] Maybe there's an exception thrown somewhere and a transaction is processed halfway [18:48:50] But these people aren't making any special kinds of edits [18:49:11] did not see anything bad in Console [18:49:40] yup - they calimed they they did not touch the are after the last paragraph on a page [18:49:49] *claimed [18:50:02] Yeah and the changes they did make are just text [18:50:31] I mean it's possible they made some changes that they then undid, but it doesn't look like they were messing with references or images or anything complicated like that, just text [18:51:49] well, on the other hand, there is no verifiable proof that they never typed/pressed delete or Enter in the Category area :) [18:55:49] Yeah, there's not much information in any case [18:56:19] I just messed around with a historical copy of one of the pages that broke (the version right before https://fr.wikipedia.org/w/index.php?title=Nancy_Juvonen&diff=prev&oldid=110406585&diffonly=1&unhide=1 ) and I didn't manage to get anything to break [19:01:34] Ooh, I just watched the video [19:01:43] Which shows Ctrl+A Delete breaking things [19:03:28] (03PS14) 10Paladox: Re add svg images [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 [19:03:41] (03PS5) 10Paladox: Adds svg to css file [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181788 [19:03:49] 3OOjs-UI: Menus' dropdown icons should be smaller and lighter in the MediaWiki theme - https://phabricator.wikimedia.org/T78086#955808 (10KHammerstein) Icon width 10 px, #AAA. Can this be sized and colored in code or should we change the asset? [19:03:52] (03PS4) 10Paladox: Convert .css to .less [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181790 [19:05:02] RoanKattouw: right :) [19:07:56] Hmmm [19:08:04] I think it might be something to do with slugs [19:08:11] That would make some amount of sense actually [19:09:21] 3UI-Standardization, OOjs-UI: Shadow at the bottom of buttons, dropdown menus is intentionally vertically mis-aligned by a pixel or two in the MediaWiki theme - https://phabricator.wikimedia.org/T78083#955815 (10KHammerstein) Hey May, I don't think the overlap of the shadow and the border is intended, can you co... [19:09:32] I guess, if we can prevent any "interference" with metadata when we type/edit the area after the last paragraph on a pgae - the issue hopefully would be gone [19:09:36] If the main data and metadata got out of sync during slugging/unslugging somehow, they'd be off by two [19:09:52] oh - that- ok [19:10:16] Which would move categories from the "end of the page" (really before the start of the internalList) down two places, into the start of the first internalItem (reference), which is exactly what I saw in that one diff [19:10:39] If that theory is correct, than the only pages where categories disappeared completely should be ones where there are no references [19:10:41] * RoanKattouw checks [19:10:48] 3VisualEditor-EditingTools, VisualEditor: Changes to extension node attributes are ignored - https://phabricator.wikimedia.org/T85818#955826 (10Etonkovidova) Betalabs - the issue is fixed. [19:13:19] Hmm, nope [19:13:27] But I did see off-by-ones as well as off-by-twos [19:13:59] at least something tangible - at last :) [19:14:35] Yeah... [19:14:45] it was really difficult with all those diffs recording "disappearance" to get hold of anything [19:15:21] etonkovidova: Would you be able to test with Safari? [19:15:29] All reports I saw that did name a browser (most didn't) named Safari [19:15:50] If I play back the steps in that youtube video, it doesn't break in Chrome [19:15:55] But maybe it will for you in Safari [19:16:10] Will do [19:16:56] Thanks [19:17:15] 3UI-Standardization, OOjs-UI: Shadow at the bottom of buttons, dropdown menus is intentionally vertically mis-aligned by a pixel or two in the MediaWiki theme - https://phabricator.wikimedia.org/T78083#955853 (10violetto) Shadow and border of? [19:18:58] 3VisualEditor-MediaWiki, OOjs-UI, VisualEditor: Clash between rounded corners and text content is jarring for the category editor in VisualEditor when using the OOjs UI MediaWiki theme - https://phabricator.wikimedia.org/T78039#955865 (10KHammerstein) I agree, lets use the standard form field for this. [19:19:48] 3UI-Standardization, OOjs-UI: Shadow at the bottom of buttons, dropdown menus is intentionally vertically mis-aligned by a pixel or two in the MediaWiki theme - https://phabricator.wikimedia.org/T78083#955869 (10Catrope) The grey (thick) shadow at the bottom of the dropdown (see screenshot in first post) overlap... [19:20:38] 3VisualEditor: [Regression pre-wmf14] The UI of all context menus and inspectors inside Media Settings and Reference dialog is broken - https://phabricator.wikimedia.org/T85842#955867 (10Ryasmeen) [19:22:04] ryasmeen: I approve of the user of humor in https://phabricator.wikimedia.org/T85842#955867 :D [19:22:25] (03PS1) 10Esanders: Fix save dialog styling for MediaWiki theme [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/182862 [19:22:53] RoanKattouw: What could be the better example right? :P [19:30:18] btw RoanKattouw: I think we were supposed to backport the fix of https://phabricator.wikimedia.org/T84897 to wmf13 [19:30:47] so mobile VE in test2 is still broken [19:31:12] (03CR) 10Catrope: [C: 032] Fix save dialog styling for MediaWiki theme [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/182862 (owner: 10Esanders) [19:31:24] ryasmeen: Did that not happen a few hours ago? [19:31:27] * RoanKattouw checks deploy calenadr [19:31:45] Sorry not that one RoanKattouw: https://phabricator.wikimedia.org/T85480 [19:32:30] Oh, there was a MobileFrontend side too, I see [19:33:13] I'll bug Jon about that [19:33:19] (03Merged) 10jenkins-bot: Fix save dialog styling for MediaWiki theme [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/182862 (owner: 10Esanders) [19:33:42] okay RoanKattouw [19:34:11] 3UI-Standardization, OOjs-UI: Shadow at the bottom of buttons, dropdown menus is intentionally vertically mis-aligned by a pixel or two in the MediaWiki theme - https://phabricator.wikimedia.org/T78083#955914 (10violetto) Gotcha. The shadow of the box should be #000 at 10% opacity. Inner shadow #DDD. {F26645}... [19:38:43] 3UI-Standardization, OOjs-UI: Shadow at the bottom of buttons, dropdown menus is intentionally vertically mis-aligned by a pixel or two in the MediaWiki theme - https://phabricator.wikimedia.org/T78083#955920 (10Catrope) This question isn't about colors, though, but about the alignment/positioning of the shadow... [19:48:52] Oh my God you gotta be kidding me [19:49:05] Chrome swallows borders if you have a negative margin with half pixels [19:49:24] margin-left: -35px; gives me a border, but -34.5px and -35.5px cause the left border to disappear [19:49:52] is this because of those removals of Math.round() from last month? [19:49:58] I was suspicious about those.... [19:50:09] MatmaRex: hey man! [19:50:15] edsanders: dude! howdy! [19:50:17] It's possible that that's what's causing PopupWidget to set fractional margin-left values, I guess [19:50:25] hmm [19:50:43] I've decided that I hate browsers [19:50:44] ... like 10 years ago [19:50:50] sup [19:50:54] fuck NCSA mosaic! [19:51:03] lol [19:51:13] lies. you did not lol. [19:51:20] RoanKattouw: looking at the context borders? [19:51:30] Yeah [19:51:37] https://phabricator.wikimedia.org/T85842#955867 [19:51:38] i also looked at them briefly and removing overflow:hidden from some ancestor caused them to reappear [19:52:14] we are also having issues with the dialogs btw [19:52:16] the border between the heading and the body [19:52:28] yeah, i filed that somewhere [19:52:29] it's also on a fractional boundary and gets rounded down [19:52:41] that is actually caused by overflows, i think? because the border is actually a box-shadow [19:53:08] RoanKattouw: would you want to review or should I merge it? [19:53:19] MatmaRex: No I'm working on a different border problem [19:53:20] RoanKattouw: (happy new year, by the way) [19:53:31] Not the box-shadow that's only at the bottom and is thick, the actual border that's thin and goes all the way around [19:53:32] MatmaRex: I'm suprised that T74716 is blocking https://phabricator.wikimedia.org/T74713 [19:53:50] It disappears in Chrome when you use half-pixel margin-left values and I haven't isolated it into a jsfiddle yet [19:54:15] yeah [19:54:27] ori: I'll take a quick look at it [19:54:31] TrevorParscal: hmm, well, ask james about it? [19:54:59] "good to go" is ambiguous :D [19:55:18] I think James is mid-air right now [19:56:22] srsly [19:57:37] RoanKattow: in Safari - nothing new on disappearance :( looks the same [20:02:56] 3VisualEditor: [Regression wmf13] After editing the caption field of an image, the image highlight gets shifted few pixels right - https://phabricator.wikimedia.org/T85844#955964 (10Ryasmeen) 3NEW [20:03:37] Krinkle: what are you thoughts about using a separate repo for the dist files, publishing only the dist repo to npm/bower, and mounting the dist repo as a submodule in the main repo? [20:05:52] this is to avoid the "npm install", "grunt build", "echo wftisnothingworking" situation, as well as actually support bower which doesn't have install-time building [20:06:20] ori: That code looks like gibberish to me because I've never messed with anything in the VirtualRESTService ecosystem. So I defer to people who do know about it, like Aaron and Gabriel [20:06:39] * ori nods [20:15:59] TrevorParscal: Is this become bower has no way to publish compiled files? [20:16:05] npm doesn't need this :P [20:16:28] TrevorParscal: There is no need to do grunt build for consumers of npm packages. [20:16:36] This is done prepublish. [20:17:08] Krinkle: only because we build the files before checking them in, no? [20:17:27] TrevorParscal: I'm naturally still suspicious about supporting anything related to bower if bower is the only usecase of said infrastructure. [20:17:30] Krinkle: yes, I know npm doesn't have this problem [20:17:46] Krinkle: I haven't really seen bower being "cancelled" [20:17:50] what's the story there [20:18:23] TrevorParscal: Yes, npm fires the build hook before building the tarball of the package. That's part of npm's design. This is used for eg. compiling .coffee to .js, or for generating any other dynamically created resources. Or for e.g. creating binaries or native extensions (such as phantomjs) [20:18:25] 3VisualEditor: The "Apply Changes" button in Media Settings dialog does not get enabled after applying/changing the link of the caption, when the cursor is at the beginning index - https://phabricator.wikimedia.org/T85845#955986 (10Ryasmeen) 3NEW [20:18:41] TrevorParscal: bower isn't dead just yet, but we sure aren't using it (not yet anyway). [20:18:46] So it doesn't seem releant to us? [20:18:58] relevant* [20:19:30] ori: TrevorParscal: i am not happy with https://gerrit.wikimedia.org/r/182875 . thoughts? [20:20:02] I recall you were suggesting there was movement to make NPM more browser friendly, like supporting flat-ish depenedencies by allowing automatica-deduping for instance [20:20:24] TrevorParscal: Indeed. npm has committed to that and working on it. [20:21:02] TrevorParscal: And on our side, we're not in a rush yet because we've got a lot of librarisation to do. And librisation can happen just fine without actually using a package manager for fetching dependencies. [20:21:03] but Bower doesn't appear to be like giving up [20:21:17] Krinkle: yeah, I'm not suggesting there's a hurry [20:21:28] TrevorParscal: define giving up. jquery isn't using it. wikimedia isn't using it. [20:21:33] I'm curious about your thoughts of that particular solution to the bower problem [20:21:51] TrevorParscal: That's a bower problem. really. [20:22:38] TrevorParscal: I think there's a bug upstream that is stalled on maintainers not giving it the attention it needs. [20:22:54] TrevorParscal: Requiring customers to run grunt-build is an anti-pattern indeed. [20:23:42] TrevorParscal: assuming this isn't a third-party using bower, I assume you've got a private corner somewhere developing something new and using bower. Otherwise you wouldn't need to care. [20:25:04] TrevorParscal: I'm looking for the bower upstream issue report now for supporting that. I;m sure there's a few recommendations there. [20:25:08] Krinkle: yeah, well I want OOjs UI to be on Bower for 3rd party use - someday [20:26:57] MatmaRex: so... re: https://gerrit.wikimedia.org/r/182875 [20:26:59] TrevorParscal: The go-to answer for such third-parties is that they can maintain a bower port if they want to. Just like package managers on linux outside Debian. Software maintainers publish in one or two, and the rest is based on demand and done by third parties. jQuery isn't pushing to bower either. Someone else who cares enough maintains a port. Probably using a fork and dist/ in-git like [20:26:59] you say. [20:27:33] 3VisualEditor: The "Apply Changes" button in Media Settings dialog does not get enabled after applying/changing the link of the caption, when the cursor is at the beginning index - https://phabricator.wikimedia.org/T85845#956012 (10Krenair) [20:27:35] There's a good dozen other front-end package managers like Yum and Hotjs in addition to bower. We're not supporting those either. [20:27:57] Krinkle: cool - thanks for your thoughts [20:28:13] TrevorParscal: Jam* , not yum. [20:28:22] Krinkle: also component [20:28:59] MatmaRex: ori: re: https://gerrit.wikimedia.org/r/182875 - I guess I just don't think this is a big deal [20:29:29] maybe that's silly of me, but this seems like a really small amount of code to be run and it solves the problem in, what I feel, is probably the right place [20:29:56] well [20:30:06] maybe we need to do this in a place common to both index and api [20:30:07] TrevorParscal: Yeah. I dont think it's worth our time at this point to maintain ports to package managers we don't use. If someone else uses those, someone will step up and mainain it for us. When we're far enough ahead to worry about promotion, we can maintain them ourselves maybe. [20:30:36] Krinkle: agreed that we aren't at the stage where promotion is important [20:30:54] jQuery took the same attitude to my surprise. Third-parties maintain the ports on bower, jamjs etc. [20:30:57] they only push to npm. [20:31:16] 3UI-Standardization, OOjs-UI: Shadow at the bottom of buttons, dropdown menus is intentionally vertically mis-aligned by a pixel or two in the MediaWiki theme - https://phabricator.wikimedia.org/T78083#956016 (10violetto) I suspect because the colors of the inner and outer shadows are the same, they look like th... [20:40:06] mooeypoo:https://phabricator.wikimedia.org/T85845 [20:40:28] TrevorParscal: http://blog.npmjs.org/post/101775448305/npm-and-front-end-packaging [20:40:37] TrevorParscal: https://github.com/bower/bower/issues/1520 [20:40:43] TrevorParscal: https://github.com/bower/bower/issues/1564 [20:40:57] 3VisualEditor: The "Apply Changes" button in Media Settings dialog for newly added images does not get enabled after applying/changing the link of the caption, when the cursor is at the beginning index - https://phabricator.wikimedia.org/T85845#956050 (10Ryasmeen) a:3Catrope [20:43:33] TrevorParscal: WTF is up with .ve-ui-surface::after { content: "."; display: block; visibility: hidden; etc } ? [20:43:45] Is it for the clear: both; so floats are cleared? [20:43:53] RoanKattouw: clearfix [20:44:08] 3VisualEditor-MediaWiki, VisualEditor, MediaWiki-extensions-FlaggedRevs: VisualEditor: The on-page Flagged Revisions notice about transcluded files or templates having outstanding changes doesn't appear in the edit notices - https://phabricator.wikimedia.org/T54280#956068 (10matmarex) [20:45:33] 3VisualEditor-MediaWiki, VisualEditor, MediaWiki-extensions-FlaggedRevs: Edit notice saying that changes must be reviewed appears even when the user has autoreview rights - https://phabricator.wikimedia.org/T60057#956070 (10matmarex) [20:46:42] 3VisualEditor: The "Apply Changes" button in Media Settings dialog for newly added images does not get enabled after applying/changing the link of the caption, when the cursor is at the beginning index - https://phabricator.wikimedia.org/T85845#956071 (10Mooeypoo) This only happens to new images, and it's extrem... [20:50:10] mooeypoo: this is the other one about highlight: https://phabricator.wikimedia.org/T85844 [20:51:18] 3VisualEditor: the "Done" button doesn't go well with VisualEditor's Find And Replace bar - https://phabricator.wikimedia.org/T85852#956107 (10Amire80) 3NEW [20:51:57] (03PS1) 10Amire80: Change "Done" to "Close" in Find And Replace [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/182882 [20:54:17] (03PS1) 10Amire80: Add visualeditor-dialog-action-close message to RL module definition [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/182883 [20:55:52] 3VisualEditor-MediaWiki, VisualEditor: Edit source link broken after editing the page with VisualEditor - https://phabricator.wikimedia.org/T85552#956157 (10Etonkovidova) Checked in betalbs - Edit source works after VE Save. [20:58:26] 3VisualEditor-EditingTools, VisualEditor: VisualEditor: Documentation for the message Visualeditor-dialog-action-done is misleading - https://phabricator.wikimedia.org/T72281#956162 (10Amire80) ... This caused T85852. "Done" just doesn't sound like a button in a dialog that has no changes to make. [21:05:59] (03PS1) 10Bartosz Dziewoński: MWSaveDialog: Correct whitespace [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/182884 [21:07:22] (03CR) 10Catrope: [C: 032] MWSaveDialog: Correct whitespace [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/182884 (owner: 10Bartosz Dziewoński) [21:07:28] MatmaRex: Love the branch name :) [21:07:36] heh [21:09:09] (03Merged) 10jenkins-bot: MWSaveDialog: Correct whitespace [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/182884 (owner: 10Bartosz Dziewoński) [21:18:00] 3VisualEditor: Links color #362b36 instead of #0b0080 - https://phabricator.wikimedia.org/T85857#956197 (10Etonkovidova) 3NEW [21:18:44] 3VisualEditor, VisualEditor-MediaWiki: Update bits of VisualEditor still referring to Bugzilla - https://phabricator.wikimedia.org/T75733#956206 (10Etonkovidova) Links refer to Phabricator - however, what happened to the color of links? From color: #0b0080; in test2 and production to color: #362b36 in beta? h... [21:19:27] Ugh, right, MW core still uses a jQuery UI dialog for the feedback thing [21:19:29] barf [21:20:39] 3VisualEditor, VisualEditor-MediaWiki: Links color #362b36 instead of #0b0080 - https://phabricator.wikimedia.org/T85857#956219 (10Krenair) I think this is mw.Feedback and we don't have much control over how that's styled, do we? [21:27:16] 3VisualEditor: Choosing "Keep Changes" after "Switch to source editing" causes serious error - https://phabricator.wikimedia.org/T85863#956259 (10Cmcmahon) 3NEW [21:27:21] 3VisualEditor, VisualEditor-MediaWiki: Links color #362b36 instead of #0b0080 - https://phabricator.wikimedia.org/T85857#956265 (10Catrope) Caused by https://gerrit.wikimedia.org/r/#/c/154024/ [21:28:47] 3VisualEditor: Choosing "Keep Changes" after "Switch to source editing" causes serious error - https://phabricator.wikimedia.org/T85863#956259 (10Cmcmahon) [21:28:58] 3OOjs-UI, VisualEditor, VisualEditor-MediaWiki: Clash between rounded corners and text content is jarring for the category editor in VisualEditor when using the OOjs UI MediaWiki theme - https://phabricator.wikimedia.org/T78039#956275 (10KHammerstein) [21:30:38] RoanKattouw, so really this is a Vector skin issue, not VE? [21:30:45] 3VisualEditor, VisualEditor-MediaWiki: Links color #362b36 instead of #0b0080 - https://phabricator.wikimedia.org/T85857#956277 (10Catrope) [21:31:09] Krenair: Yup. I've CCed Krinkle and MatmaRex on the bug, since one of them wrote the patch and the other merged it [21:32:05] 3VisualEditor: Choosing "Keep Changes" after "Switch to source editing" causes serious error - https://phabricator.wikimedia.org/T85863#956285 (10Catrope) This is because Parsoid is broken in beta labs (yet again). Try hitting an uncached page like http://en.wikipedia.beta.wmflabs.org/w/index.php?title=0.5209895... [21:32:07] ew [21:32:10] ewwww [21:32:22] 3MediaWiki-skins-Vector, VisualEditor, VisualEditor-MediaWiki: All links inside jQuery UI dialogs are black since update - https://phabricator.wikimedia.org/T85857#956289 (10Krenair) [21:33:10] Krenair: Thanks for moving it to the correct product, I forgot to do that [21:33:13] RoanKattouw, do we have a bug to track the parsoid on deployment-prep issue? [21:33:17] I guess I also didn't realize we had a Vector project [21:33:21] I just added an extra project [21:33:29] Krenair: Yes, https://phabricator.wikimedia.org/T85863 [21:33:30] We don't have to "move products" now :) [21:33:36] You mean the double slash errors, right? [21:33:44] I'm trying to figure out why that's happening right now [21:33:52] yeah [21:34:11] RoanKattouw, ok, that's the first report of this issue? [21:34:21] I'm not entirely sure [21:34:23] It's the first I saw [21:35:20] I could've sworn I saw it mentioned earlier, might've been IRC. ok [21:36:11] RoanKattouw: the dark-like link colours are not new though. that's always been the case afaik. [21:36:19] (inside jquery ui) [21:36:19] Oh for fuck's sake [21:36:22] // URL to the Parsoid instance [21:36:24] // MUST NOT end in a slash due to Parsoid bug [21:36:29] catrope@deployment-bastion:~$ mwscript eval.php enwiki [21:36:30] > echo $wgVisualEditorParsoidURL [21:36:31] Or did we make a hotfix that I forgot to maintain in the upgrade? [21:36:32] http://10.68.16.145/ [21:36:44] 3MediaWiki-skins-Vector, VisualEditor, VisualEditor-MediaWiki: All links inside jQuery UI dialogs are black since update - https://phabricator.wikimedia.org/T85857#956296 (10Paladox) Found the problem in https://gerrit.wikimedia.org/r/#/c/154024/26/skinStyles/jquery.ui/jquery.ui.theme.css. it was this css code .... [21:36:55] Krinkle: I don't know? I just know that when I look at mw.feedback in test2wiki I don't see a .ui-dialog a { ... } rule applied [22:11:33] (03CR) 10Ori.livneh: "@Krenair: yes, of course." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130543 (owner: 10GWicke) [22:13:33] 3VisualEditor: 'Review your changes' for new pages gives 'Error loading data from server...' - https://phabricator.wikimedia.org/T85871#956404 (10Etonkovidova) 3NEW [22:17:35] Krenair: https://gerrit.wikimedia.org/r/182935 [22:17:59] The docs say you can't have a slash there, but it's been there for 9 months, so I'm not sure if this is the cause (e.g. through a regression in Parsoid) or something else [22:18:02] But it's worth fixing [22:18:18] indeed [22:18:48] do changes that only affect labs need to be arranged on the deployment calendar? [22:29:57] 3VisualEditor: Betalabs: Cannot Save a page - 404: Cannot POST //enwiki/User%3 - https://phabricator.wikimedia.org/T85871#956472 (10Etonkovidova) [22:34:29] TrevorParscal, svgs? [22:36:39] 3VisualEditor: Betalabs: Cannot Save a page - 404: Cannot POST //enwiki/User%3 - https://phabricator.wikimedia.org/T85871#956507 (10Ryasmeen) [22:55:38] 3VisualEditor: the "Done" button doesn't go well with VisualEditor's Find And Replace bar - https://phabricator.wikimedia.org/T85852#956527 (10Esanders) For non-modal dialogs which may or may not modify the document, we've used 'done' instead of 'close' in other situations, such as the link inspector. [22:56:31] (03CR) 10Esanders: [C: 04-1] "See discussion on Phabricator." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/182882 (owner: 10Amire80) [22:58:45] 3VisualEditor: the "Done" button doesn't go well with VisualEditor's Find And Replace bar - https://phabricator.wikimedia.org/T85852#956529 (10Amire80) >>! In T85852#956527, @Esanders wrote: > For non-modal dialogs which may or may not modify the document, we've used 'done' instead of 'close' in other situations... [22:59:09] edsanders: yo [22:59:33] want to talk about Done/Close? [23:00:22] (03Abandoned) 10Esanders: build: Add SVG compression grunt task using 'svgmin' [oojs/ui] - 10https://gerrit.wikimedia.org/r/176634 (owner: 10Prtksxna) [23:10:06] James_F|Away, edsanders - I'd really love to get consensus about the Done/Close issue ASAP [23:15:59] edsanders: svgs? [23:18:30] TrevorParscal, the commit I linked to [23:18:37] background-size [23:19:06] aharoni, sure [23:24:26] (03PS6) 10Alex Monk: WIP Bug 64171: Log Parsoid request timings to eventlogging [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130543 (owner: 10GWicke) [23:25:28] ori, you realise I know nothing about EventLogging right? :P [23:33:26] edsanders: i don't see the link, sorry [23:33:33] i can look at something now if needed? [23:37:27] [23:18] Krenair do changes that only affect labs need to be arranged on the deployment calendar? [23:37:31] Krenair: No, I don't think they do [23:39:51] TrevorParscal, https://gerrit.wikimedia.org/r/#/c/181617/ [23:44:37] edsanders: so, using background-size: contain with 1.9em appears to result in exactly 24px - so that seems to be ok [23:44:55] I'm only concerned about how this affects the PNG version [23:46:01] well, also tbh the SVG versions [23:46:07] so I think the important part of this patch is that you *can* set background-size [23:46:07] because they are pixel-grid aligned [23:46:24] and if they are even slightly differently sized, it will cause them to get blurry [23:46:48] i'm seeing in the demo though [23:47:00] without any tweaking, just running your patch, that the icons are blurry [23:47:13] when i remove background-size: contain it's fixed [23:47:13] so - yes [23:47:17] um [23:47:19] I don't object to using 24px always [23:47:23] what pixel size are they? [23:47:40] the 12px thing isn't really important afaik [23:47:51] the browser claims 24px [23:48:02] but I'm seeing a big difference [23:48:29] which browser? [23:48:34] chrome [23:48:39] weird [23:49:02] which demo page? [23:49:59] http://cl.ly/image/1Q0I352N1Z1o [23:50:18] any ideas? [23:50:26] because it /should/ work fine [23:50:34] and I didn't actually expect this result [23:51:36] interestingly, using background-size: 100% also fails (in the same way) but using background-size: 24px works correctly [23:51:43] so, my inspector is telling me lies [23:51:55] it must be rounding [23:52:06] says 24px but it's actually like 24.4px [23:52:18] that's the problem with using this together with em [23:52:32] thoughts? [23:52:54] I think it would be good to be able to set icon size with font size [23:53:24] do we have a particular use case for this? [23:53:29] not that I think it wouldn't be good [23:53:43] just that I'm curious about what is really being required here [23:53:58] mobile use larger icons [23:54:26] for everything or select controls? [23:55:31] well the toolbar to begin with [23:56:05] although if they have a policy on button size it will probably be everything