[00:00:24] i think for them to special case seems sensible [00:00:39] do they work if you set them to 1.875 instead of 1.9 ? [00:00:40] because they are targeting devices with, most likely, high DPI [00:00:53] checking [00:01:19] yes, that appears to avoid the rounding error [00:02:07] thinking about oo-ui users in general, it seems odd that everything scales in ems but not the icons [00:02:20] I presume that's because 1em = x and 24 / 1.875 = x [00:02:45] i'm not against what you are proposing, I just want to make sure we don't have a degraded experience for the common use case [00:03:02] so, if you bundle this change with switching to 1.875 instead of 1.9 then I think we are in business [00:03:18] will need to double check some other uses to be sure, but I'm pretty confident this is a good idea [00:05:21] Krinkle, hey [00:06:00] (03PS1) 10Mooeypoo: Add param order drag/drop widget to TemplateData dialog [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/182962 [00:06:30] (03Abandoned) 10Mooeypoo: [wip] Adding paramOrder widget to TemplateData editor [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/170655 (owner: 10Mooeypoo) [00:09:12] (03PS2) 10Mooeypoo: Add param order drag/drop widget to TemplateData dialog [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/182962 [00:16:35] Krinkle, can I have your opinion on https://phabricator.wikimedia.org/T64355 when you're around please. thanks [00:21:37] (03PS1) 10Mvolz: ilean up variable definitions and comments [services/citoid] - 10https://gerrit.wikimedia.org/r/182970 [00:23:19] (03Abandoned) 10Mvolz: ilean up variable definitions and comments [services/citoid] - 10https://gerrit.wikimedia.org/r/182970 (owner: 10Mvolz) [00:31:27] 3VisualEditor-MediaWiki, VisualEditor: VisualEditor: When I click the Save button, please take my cursor out of the main text and focus it in the Save dialog - https://phabricator.wikimedia.org/T75675#956763 (10Krenair) The cursor always goes back to the summary field for me, after following those instructions. [00:33:45] 3VisualEditor-MediaWiki, VisualEditor: VisualEditor: When I click the Save button, please take my cursor out of the main text and focus it in the Save dialog - https://phabricator.wikimedia.org/T75675#956764 (10Krenair) Oh I did manage to reproduce what I think is this issue when I tried it on testwiki though -... [00:37:34] (03PS1) 10Mvolz: [WIP] Open Graph support [services/citoid] - 10https://gerrit.wikimedia.org/r/182972 [00:38:54] (03Abandoned) 10Mvolz: [WIP] Open Graph support [services/citoid] - 10https://gerrit.wikimedia.org/r/182972 (owner: 10Mvolz) [00:43:35] (03PS1) 10Mvolz: [WIP] Open graph support [services/citoid] - 10https://gerrit.wikimedia.org/r/182975 [00:45:17] (03PS3) 10Mooeypoo: Add param order drag/drop widget to TemplateData dialog [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/182962 [00:56:12] (03PS1) 10Alex Monk: Re-focus edit summary input when save dialog is ready [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/182976 [01:16:13] (03PS1) 10Mooeypoo: Allow the restoration of a deleted parameter in the edit dialog [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/182980 [01:34:36] 3Mobile-Web, VisualEditor: Mobile VisualEditor won't load (this.getSurface(...) is undefined) - https://phabricator.wikimedia.org/T85897#956855 (10kaldari) 3NEW [02:06:59] 3Mobile-Web, VisualEditor, VisualEditor-MediaWiki-Mobile: [Regression pre-wmf14] Cannot switch from VE to wikitext editor in Mobile Web - https://phabricator.wikimedia.org/T84897#956902 (10matmarex) (That's T85480. That fix got deployed too, but it seems there's a third bug, T85897.) [02:08:00] i was pretty confused for a second there [02:08:25] T84897 and T85897 are apparently both issues about mobile VE not loading. [02:08:46] 3Editing, VisualEditor, Mobile-Web: in MobileFrontend, invoking the editor is incorrect and switching from VisualEditor to wikitext editor does nothing - https://phabricator.wikimedia.org/T85480#956907 (10matmarex) 5Open>3Resolved Thanks. VE on mobile is apparently still broken, tracked as T85897. [02:11:55] 3Mobile-Web, VisualEditor: Mobile VisualEditor won't load (this.getSurface(...) is undefined) - https://phabricator.wikimedia.org/T85897#956924 (10matmarex) Mobile VE loads for me on beta, but not on mediawiki.org. By the way, we've already swatted two fixes for mobile VE today (see the mentions above). [02:14:13] (03PS1) 10Alex Monk: Mark interwiki links as known in LinkTargetInputWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/182988 [02:15:54] (03PS2) 10Alex Monk: Mark interwiki links as known in LinkTargetInputWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/182988 [02:21:21] 3VisualEditor-EditingTools, VisualEditor: VisualEditor: Dialogs should disable "Apply changes" until a change is present - https://phabricator.wikimedia.org/T57976#956940 (10Krenair) A single patch fixes the majority of the issues here, see the subtasks. [02:28:26] 3VisualEditor-MediaWiki, MediaWiki-skins-Vector, MediaWiki-Interface, VisualEditor: All links inside jQuery UI dialogs are black since update - https://phabricator.wikimedia.org/T85857#956949 (10matmarex) The same issue affects all other skins, via the default jQuery UI theme in MediaWiki core. This appears to b... [02:32:22] 3MediaWiki-Interface, VisualEditor-MediaWiki, MediaWiki-skins-Vector, VisualEditor: All links inside jQuery UI dialogs are black since update - https://phabricator.wikimedia.org/T85857#956957 (10matmarex) This was previously fixed as T69851. [03:43:21] (03PS1) 10Alex Monk: Update setupToolbar signature in mobile target [extensions/VisualEditor] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/182993 [03:45:15] 3Mobile-Web, VisualEditor: Mobile VisualEditor won't load (this.getSurface(...) is undefined) - https://phabricator.wikimedia.org/T85897#957002 (10Krenair) Looks like we missed one. See patch above. [03:55:45] greg-g, see above when you have time [03:59:54] we may want to get that deployed before the branch hits group 1 wikis tomorrow [04:07:05] I imagine it'll get put on the 'morning' swat, or something. [04:48:26] (03CR) 10GOIII: "I know squat when comes to sprite (or spiritted?) images never mind basic .svg format but when I down load the file in a .zip then inspect" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (owner: 10Paladox) [07:22:40] 3VisualEditor: VisualEditor reassigns Ctrl-F from the browser's built-in "Find in page" to VE's own Find and Replace - https://phabricator.wikimedia.org/T85904#957033 (10Amire80) 3NEW [09:05:12] 3VisualEditor: the "Done" button doesn't go well with VisualEditor's Find And Replace bar - https://phabricator.wikimedia.org/T85852#957061 (10Esanders) Exactly. We haven't used 'close' on any of our other dialogs and inspectors (e.g. link inspector, keyboard shortcuts dialog), or even used an 'x' button, so wh... [09:39:02] 3VisualEditor: the "Done" button doesn't go well with VisualEditor's Find And Replace bar - https://phabricator.wikimedia.org/T85852#957126 (10Amire80) Because it's neither "Cancel" (I was about to change something, but didn't), nor "Done" (I was doing something and finished it). In the Find And Replace dialog... [10:20:11] (03CR) 10Esanders: [C: 04-1] "Why is the href not updated before the change event is fired? That appears to be the real problem here..." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/182432 (owner: 10Alex Monk) [10:38:28] 3VisualEditor: the "Done" button doesn't go well with VisualEditor's Find And Replace bar - https://phabricator.wikimedia.org/T85852#957209 (10Amire80) [11:27:15] (03CR) 10Paladox: "Hi I am not sure why it is showing blank I will look and see but I doint know how to re produce what you do to get the error. I will remov" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (owner: 10Paladox) [11:42:44] (03CR) 10Paladox: "I can confirm the image does not show in svg looking at it on windows internet explorer. I have fixed problem by removing mask from xml ed" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (owner: 10Paladox) [11:43:06] (03PS15) 10Paladox: Re add svg images [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 [11:47:09] (03PS5) 10Prtksxna: TextInputWidget: Use MutationObserver instead of DOMNodeInsertedIntoDocument [oojs/ui] - 10https://gerrit.wikimedia.org/r/176681 [11:48:15] (03CR) 10jenkins-bot: [V: 04-1] TextInputWidget: Use MutationObserver instead of DOMNodeInsertedIntoDocument [oojs/ui] - 10https://gerrit.wikimedia.org/r/176681 (owner: 10Prtksxna) [11:50:30] (03CR) 10Paladox: "It seems mask is the problem but the image needs mask how would i fix it." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (owner: 10Paladox) [11:59:26] (03CR) 10Paladox: "It seems matrix wont work for insert-ilink.svg either." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (owner: 10Paladox) [12:02:48] (03CR) 10Prtksxna: "Trevor, I've moved the function to OO.ui.Element now. I though I'd setup a single observe in the OO.ui singleton but that seems like a was" [oojs/ui] - 10https://gerrit.wikimedia.org/r/176681 (owner: 10Prtksxna) [12:03:37] (03CR) 10Prtksxna: "( sorry for that formatting, I am not sure what went wrong, adding more line breaks)" [oojs/ui] - 10https://gerrit.wikimedia.org/r/176681 (owner: 10Prtksxna) [12:49:18] 3VisualEditor: the "Done" button doesn't go well with VisualEditor's Find And Replace bar - https://phabricator.wikimedia.org/T85852#957288 (10Amire80) [12:51:09] (03CR) 10Paladox: "Hi maybe the image will have to be set to look like it looks now with out mask. could i have some help to do the image since i doint know " [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (owner: 10Paladox) [12:52:51] (03CR) 10Paladox: "it works in chrome seems mask is not supported in internet explorer. i havent tested firefox or any other browsers to see if it works." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (owner: 10Paladox) [12:55:22] (03CR) 10Catrope: [C: 032] Re-focus edit summary input when save dialog is ready [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/182976 (owner: 10Alex Monk) [12:57:33] (03Merged) 10jenkins-bot: Re-focus edit summary input when save dialog is ready [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/182976 (owner: 10Alex Monk) [12:59:05] Krenair: I've scheduled that mobile VE change for SWAT: https://wikitech.wikimedia.org/wiki/Deployments#deploycal-item-20150106T1600 [13:06:51] 3VisualEditor: the "Done" button doesn't go well with VisualEditor's Find And Replace bar - https://phabricator.wikimedia.org/T85852#957308 (10Esanders) I think it is "I was doing something and finished it" - I don't think 'Done' has to be constructive. I'm not convinced either way though, so I'd be happy to get... [13:08:14] (03CR) 10GOIII: "I wish I knew how; I know near to nothing when it comes graphics." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (owner: 10Paladox) [14:27:15] (03CR) 10Paladox: "Hi I am not sure how to do that." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (owner: 10Paladox) [14:31:31] (03PS2) 10Amire80: Change "Done" to "Close" in Find And Replace [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/182882 [14:43:04] (03PS1) 10TheDJ: Remove reference to magnify-clip.png [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/183034 [15:01:19] 3VisualEditor: [Regression pre-wmf14] The UI of all context menus and inspectors inside Media Settings and Reference dialog is broken - https://phabricator.wikimedia.org/T85842#957378 (10Catrope) This seems to be a weird rendering bug in Chrome. Removing either overflow: hidden; or position: relative; from the P... [15:18:52] 3VisualEditor: [Regression wmf13] After editing the caption field of an image, the image highlight gets shifted few pixels right - https://phabricator.wikimedia.org/T85844#957398 (10Catrope) This happens because of https://gerrit.wikimedia.org/r/#/c/179598/ . The window is made unscrollable when opening the dial... [15:21:23] 3VisualEditor: [Regression wmf13] After editing the caption field of an image, the image highlight gets shifted few pixels right - https://phabricator.wikimedia.org/T85844#957408 (10Catrope) [15:21:40] (03CR) 10Catrope: "Caused https://phabricator.wikimedia.org/T85844" [oojs/ui] - 10https://gerrit.wikimedia.org/r/179598 (owner: 10Esanders) [15:36:29] 3VisualEditor: [Regression pre-wmf14] The UI of all context menus and inspectors inside Media Settings and Reference dialog is broken - https://phabricator.wikimedia.org/T85842#957421 (10Catrope) Seems like it may be partially caused by https://gerrit.wikimedia.org/r/179598 : removing overflow:hidden; on the bod... [15:42:06] * James_F waves. [15:44:25] 3VisualEditor: the "Done" button doesn't go well with VisualEditor's Find And Replace bar - https://phabricator.wikimedia.org/T85852#957458 (10Jdforrester-WMF) 5Open>3declined a:3Jdforrester-WMF Yeah, I fundamentally disagree with the idea that "close" or "cancel" is a good message here. We're using "Done"... [15:44:53] (03Abandoned) 10Jforrester: Change "Done" to "Close" in Find And Replace [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/182882 (owner: 10Amire80) [15:45:01] (03Abandoned) 10Jforrester: Add visualeditor-dialog-action-close message to RL module definition [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/182883 (owner: 10Amire80) [15:47:49] Krenair: https://phabricator.wikimedia.org/T64355 [15:50:38] Krenair: Sounds like a good reason to have our page managed by a composition of embedded data-bound dom-based template objects. This'd be trivial there. [15:50:52] Krenair: But that's still a year or so away, with neccecary pushback.. [15:58:25] 3VisualEditor, VisualEditor-ContentEditable: [Regression wmf13] After editing the caption field of an image, the image highlight gets shifted few pixels right - https://phabricator.wikimedia.org/T85844#957496 (10Jdforrester-WMF) p:5Triage>3Normal [16:08:12] (03CR) 10Jforrester: "At the request of Design I'm (very slowly) working on replacing all the assets with copies of the OOjs UI ones (in advance of actually swi" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (owner: 10Paladox) [16:13:19] (03CR) 10Catrope: [C: 032 V: 032] Update setupToolbar signature in mobile target [extensions/VisualEditor] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/182993 (owner: 10Alex Monk) [16:14:15] RoanKattouw: Oh, are we SWATing? [16:14:23] Yeah [16:14:32] Fixing mobile VE, part trois [16:14:33] Oops, didn't know. [16:14:44] Still 2000 e-mails deep in my e-mail backlog [16:14:57] I'm not sure you would have found out even if you did read all 2k of them [16:15:05] It was just IRC and gchat backscroll I think [16:15:17] Ah. [16:15:21] Been ignoring those [16:18:31] 3VisualEditor, VisualEditor-EditingTools: Changes to extension node attributes are ignored - https://phabricator.wikimedia.org/T85818#957582 (10Jdforrester-WMF) p:5Triage>3Normal a:3Esanders [16:19:48] (03PS1) 10Esanders: Don't attempt to rendered deactivated selections when collapsed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/183043 [16:20:12] 3VisualEditor, VisualEditor-MediaWiki, MediaWiki-Interface, MediaWiki-skins-Vector: All links inside jQuery UI dialogs are black since update - https://phabricator.wikimedia.org/T85857#957590 (10Jdforrester-WMF) p:5Triage>3Normal a:3Paladox [16:22:42] 3VisualEditor: VisualEditor reassigns Ctrl-F from the browser's built-in "Find in page" to VE's own Find and Replace - https://phabricator.wikimedia.org/T85904#957596 (10Jdforrester-WMF) 5Open>3declined a:3Jdforrester-WMF We also re-assign (and do something different from) the browser's built in Ctrl+B, th... [16:24:52] 3VisualEditor: It's not obvious how to get rid of VisualEditor's Search and Replace tool - https://phabricator.wikimedia.org/T85674#957601 (10Jdforrester-WMF) [16:24:54] 3VisualEditor, VisualEditor-EditingTools: Add a cross button to close the Find-Replace panel or clicking on CE may slide it up ? - https://phabricator.wikimedia.org/T77933#957602 (10Jdforrester-WMF) [16:26:35] (03CR) 10Paladox: "Ok." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (owner: 10Paladox) [16:29:18] RoanKattouw: Are you lapsing into team lead rather than working on cool stuff? Tsk. ;-) (Hugely appreciated, of course.) [16:29:29] (03PS16) 10Paladox: Re add svg images [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 [16:30:40] (03CR) 10Paladox: "I removed the s. this patch can be merged. because the problem with one of the images can also be fixed later on. because when the svg ima" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (owner: 10Paladox) [16:31:31] 3VisualEditor-MediaWiki-Mobile, Editing, VisualEditor, MobileFrontend-beta: Back arrow appears before other VE controls in MobileFrontend but does nothing - https://phabricator.wikimedia.org/T85481#957622 (10Catrope) ```Uncaught TypeError: boolean is not a function in Overlay.extend.hide```. It's trying to call... [16:32:25] James_F: I'm taking a break from the cool stuff now that I've realized I need to build new test harness functionality :P [16:32:31] RoanKattouw: :-D [16:32:46] Krinkle: So… now we've got Special:JavaScriptTest/export and the MW-core grunt change landed, what's left to do on https://phabricator.wikimedia.org/T74063 – just configuring the jenkins jobs? Is that mostly done? [16:33:20] I wrote a bunch of DocumentSet infrastructure code to support references "last" week, today I ported MWReferenceNode to it and it seems to be working OK, but the test harness doesn't know about DocumentSets so it either fails to test a bunch of things, or causes crashes, depending on which direction you test in [16:33:49] (03CR) 10Jforrester: "> (The behaviour is to show an error if there's no config messages, but might want to change this for production to just not load in that " [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/168746 (owner: 10Mvolz) [16:34:01] RoanKattouw: Neat! [16:34:19] I also didn't port the CE part of that yet [16:34:40] There's a bunch more work to do, like a bunch of cleanup in the converter [16:34:48] RoanKattouw: BTW, can you fix the rights for mediawiki/services/citoid.git to ban human V+2? [16:35:04] But once I've carefully phased them out, I will be able to destroy ve.dm.InternalList as well as the handlesOwnChildren feature [16:35:18] RoanKattouw: Krinkle|detached was doing it over a month ago but didn't finish. [16:35:27] RoanKattouw: Neat! [16:35:54] But yeah in between all those complex things I unwind by looking at mysterious browser bugs :D [16:36:01] * James_F grins. [16:36:16] James_F: The ACL claims human V+2 is already banned in services/citoid [16:36:20] Will your fancy new test harness allow integrations to over-ride functionality? [16:36:27] RoanKattouw: Hmm. Are "owners" still allowed? [16:36:38] No. But I may have to check "Exclusive" [16:36:49] Oh, or it'll inherit, yeah. [16:36:50] Can you verify that you see a V+2 option now? [16:36:59] (And then standby for the subsequent "what about now?") [16:37:10] I still see V+2. [16:37:19] What about now? [16:37:26] Now I don't. [16:37:27] Success! [16:37:28] Sweet [16:37:31] Thanks. [16:37:37] Just a matter of checking Exclusive, indeed [16:37:44] Yay for inheritance. [16:38:07] Re test harness: no, that's a separate refactor. I'm not refactoring the test harness so much as making relatively minor changes to it [16:38:17] OK. [16:38:20] That's allowed. :-) [16:38:26] But I still have to change the test harness, so I sighed and worked on small things for a little while [16:38:31] :-D [16:38:36] * James_F cracks the whip. [16:39:05] 3VisualEditor, VisualEditor-MediaWiki-Media: The "Apply Changes" button in Media Settings dialog for newly added images does not get enabled after applying/changing the link of the caption, when the cursor is at the beginning index - https://phabricator.wikimedia.org/T85845#957641 (10Jdforrester-WMF) p:5Triage... [16:41:59] 3VisualEditor-MediaWiki-References, VisualEditor, OOjs-UI, VisualEditor-MediaWiki-Media: [Regression pre-wmf14] The top border for context menus and inspectors inside Media Settings and Reference dialog are missing in the MediaWiki theme - https://phabricator.wikimedia.org/T85842#957647 (10Jdforrester-WMF) p:5T... [16:42:49] 3VisualEditor-MediaWiki-Mobile, Editing, VisualEditor, MobileFrontend-beta: Back arrow appears before other VE controls in MobileFrontend but does nothing - https://phabricator.wikimedia.org/T85481#957657 (10Catrope) I stand corrected, this is now fixed in master. The error above is in wmf13, so we seem to have... [16:44:43] (03PS1) 10TheDJ: Toolbar: Reset lineheight for character cells [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/183051 [16:44:47] 3VisualEditor-MediaWiki-Mobile, Editing, VisualEditor, MobileFrontend-beta: Back arrow appears before other VE controls in MobileFrontend but does nothing - https://phabricator.wikimedia.org/T85481#957659 (10Jdlrobson) https://gerrit.wikimedia.org/r/#/c/181698/ also needs to get deployed. [16:45:07] Krenair: Do you have a MobileFrontend testing setup locally? [16:45:39] Krenair: If so, could you verify whether cherry-picking https://gerrit.wikimedia.org/r/#/c/181698/ into MF's wmf13 fixes https://phabricator.wikimedia.org/T85481#957659 and doesn't introduce new errors? [17:04:23] (03CR) 10GOIII: "lines 265 & 266 duplicate the same attribute. one but not the other should be..." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/183051 (owner: 10TheDJ) [17:12:31] (03CR) 10GOIII: "See T33649 for that last tweak for this particular .css file that I could think of." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/183051 (owner: 10TheDJ) [17:13:04] (03CR) 10GOIII: [C: 031] Toolbar: Reset lineheight for character cells [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/183051 (owner: 10TheDJ) [17:15:00] (03CR) 10Paladox: "looking at https://test2.wikipedia.org/w/index.php?title=Test&action=edit it doesent show the icon either in png." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (owner: 10Paladox) [17:19:16] (03PS1) 10Esanders: Set hard limit of results to attempt to render, even with clipping [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/183053 [17:19:44] (03CR) 10Jforrester: "Maybe tag against the task? Otherwise LGTM." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/183053 (owner: 10Esanders) [17:20:16] (03PS2) 10Esanders: Set hard limit of results to attempt to render, even with clipping [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/183053 [17:20:23] RoanKattouw_away, hey [17:21:04] I can test MobileFrontend with useskin=minerva, which is annoying sometimes but works [17:23:16] (03CR) 10GOIII: "Its rendering for me under IE11 as .png just fine. And F12 Developer Tools confirms (background position) that its the sprited variant; no" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (owner: 10Paladox) [17:25:11] 3VisualEditor, VisualEditor-MediaWiki, MediaWiki-General-or-Unknown: returnto and returntoquery in login/signup links doesn't get updated on pushState or popstate - https://phabricator.wikimedia.org/T64355#957704 (10Krenair) [15:50:38] Krenair: Sounds like a good reason to have our page managed by a co... [17:26:42] (03CR) 10Paladox: "Oh ok but mask is not supported in internet explorer it is currently under consideration." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (owner: 10Paladox) [17:27:11] (03CR) 10Paladox: "So we need to convert mask to something else that does same job but supported in all browsers." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (owner: 10Paladox) [17:27:30] (03CR) 10Paladox: "Because png works but I doint know how they did it in png." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (owner: 10Paladox) [17:30:36] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=110622859 [17:30:36] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=110631627 [17:30:36] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=110638401 [17:30:36] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=110655744 [17:30:36] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=33861122 [17:30:37] Corruption alert: visualeditor-needcheck on ukwiki: https://uk.wikipedia.org/?diff=15389703 [17:30:37] Corruption alert: visualeditor-needcheck on hewiki: https://he.wikipedia.org/?diff=16404417 [17:30:37] (03CR) 10Paladox: "I carnt find any way around this." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (owner: 10Paladox) [17:31:24] RoanKattouw_away, yes that appears to fix the bug [17:32:20] although I'm not sure it's a complete patch [17:43:30] (03PS2) 10Jforrester: demo: Destroy the surface when switching away from VE mode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/182813 (owner: 10Esanders) [17:43:37] (03CR) 10Jforrester: [C: 032] demo: Destroy the surface when switching away from VE mode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/182813 (owner: 10Esanders) [17:46:59] Krenair: OK, mind submitting that then? Jon said he got a conflict trying to do that [17:47:45] yeah there is a couple of conflicts [17:47:56] (03Merged) 10jenkins-bot: demo: Destroy the surface when switching away from VE mode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/182813 (owner: 10Esanders) [17:50:55] RoanKattouw, I still see some references to _hasChanged on master... I wonder if they're correct [17:51:07] shouldn't a mobile-web person be doing this? [17:51:15] Yes [17:51:30] But Jon claims there are no references to _hasChanged as a function in master [17:51:35] (it's now apparently a boolean property) [17:51:43] yes [17:52:38] (03CR) 10Mooeypoo: "recheck" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/182962 (owner: 10Mooeypoo) [17:53:03] We're in the lovely situation where this code is in MobileFrontend and we don't understand it, but if it breaks, "VE is broken" and people look at us <_< [17:53:07] (03CR) 10Mooeypoo: "recheck" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/182980 (owner: 10Mooeypoo) [17:53:25] uhm, wtf. Jenkins didn't run on my two commits from yesterday. Que? [17:53:35] Ed, Trevor and I agree that a lot of this MF code should be moved to VE, but wishing for it doesn't make it happen and I don't think it's that high of a priority right now [17:53:54] (03CR) 10jenkins-bot: [V: 04-1] Add param order drag/drop widget to TemplateData dialog [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/182962 (owner: 10Mooeypoo) [17:56:28] mooeypoo: Yeah it was down for a while [17:57:13] RoanKattouw, I just saw. I failed anyways, but at least now I know [17:57:14] :D [17:57:49] RoanKattouw, I cherry-picked it: https://gerrit.wikimedia.org/r/#/c/183059/ [17:58:46] (03CR) 10jenkins-bot: [V: 04-1] Allow the restoration of a deleted parameter in the edit dialog [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/182980 (owner: 10Mooeypoo) [17:59:39] Krenair: Yeah, I saw [17:59:46] I was looking for kaldari but he's not on line [18:12:46] TrevorP|Away, edsanders: So, what I was saying in OOUI and overflow: hidden; in the standup: https://phabricator.wikimedia.org/T85844 [18:15:29] Wow I hadn't seen these errors before [18:15:35] 17:57:33 java.io.IOException: java.util.concurrent.ExecutionException: java.io.IOException: request to write '1855' bytes exceeds size in header of '1802' bytes for entry 'log/mw-debug-www.log' [18:15:44] A whole new way for Jenkins/Zuul to shit itself [18:15:50] Krinkle|detached: https://integration.wikimedia.org/ci/job/mwext-MobileFrontend-qunit-mobile/9008/console :O [18:16:37] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: Documentation for the message Visualeditor-dialog-action-done is misleading - https://phabricator.wikimedia.org/T72281#957758 (10Amire80) After reading @Jdforrester-WMF's reasoning on T85852 I am even more convinced that this is a problem. UI consistency i... [18:16:59] 3VisualEditor: the "Done" button doesn't go well with VisualEditor's Find And Replace bar - https://phabricator.wikimedia.org/T85852#957761 (10Amire80) 5declined>3Open p:5Unbreak!>3Normal [18:18:19] 3VisualEditor: the "Done" button doesn't go well with VisualEditor's Find And Replace bar - https://phabricator.wikimedia.org/T85852#956107 (10Amire80) OK, calling it "unbreak now" may have been an exaggeration, but it's nevertheless an issue, at least in the languages to which I translate. See explanation at T7... [18:18:35] James_F, I think I managed to copy it to my @wikimedia.org google calendar [18:21:04] Krenair: Yup, now I can see them. Thanks! [18:21:44] (03CR) 10Trevor Parscal: [C: 032] Clear windows when destroying window manager [oojs/ui] - 10https://gerrit.wikimedia.org/r/182812 (owner: 10Esanders) [18:22:30] mooeypoo: https://gerrit.wikimedia.org/r/#/c/177946/ [18:23:14] (03PS23) 10Jforrester: Native leftarrow and rightarrow [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177946 (owner: 10Divec) [18:24:09] RoanKattouw: Could you quickly CR https://gerrit.wikimedia.org/r/182795 from Ed? I tested and it seemed to work OK, but I've not been able to replicate the problem it's fixing locally. [18:26:01] (03Merged) 10jenkins-bot: Clear windows when destroying window manager [oojs/ui] - 10https://gerrit.wikimedia.org/r/182812 (owner: 10Esanders) [18:29:44] (03CR) 10Trevor Parscal: [C: 04-1] "My concern about this change is that it causes the icons to be a bit blurry. SVG's are indeed scalable, but they are often designed to fit" [oojs/ui] - 10https://gerrit.wikimedia.org/r/181617 (owner: 10Esanders) [18:33:07] TrevorParscal: It's SVGs, not SVG's. :-) [18:33:16] yeah yeah [18:33:22] old habits man... :( [18:33:35] It's my fantastic public school education hard at work man [18:34:01] I had all of 1 english teacher in my life that wasn't a complete tool... and that was when I was in 3rd grade [18:34:01] :-) [18:34:14] James_F: are you back from the UK yet? [18:34:24] if that is even a real place [18:34:33] somewhere between lapland and narnia [18:34:40] I need to do some kahn academy to drill out my bad spellings and grammar or something [18:35:01] TrevorParscal: khan ;) [18:35:16] (03CR) 10Catrope: [C: 04-1] Fix context comparison on after paste (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/182795 (owner: 10Esanders) [18:35:50] (03CR) 10Trevor Parscal: "Where are we at with this. Is there any serious objection anymore?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174666 (owner: 10Amire80) [18:35:56] Krinkle|detached: https://gerrit.wikimedia.org/r/#/c/174666/ [18:36:04] ori: srsly [18:37:41] so... what's the preferred way to enter a   character in visual editor? [18:38:03] manually copy-pasting an \u00A0 from terminal seems to result in "☀" in VE. [18:38:50] insert > special character doesn't show nbsp [18:40:03] ori: I am. [18:40:16] ideally it would be shift+space [18:40:16] cool, i'm on my wya to the office, let's plot! [18:40:20] manually copy-pasting an   from the existing wikitext from within VE also results in ☀ [18:40:21] but that doesn't appear to be working [18:40:28] ori: See you soon. :-) [18:40:37] shift-space seems to insert \u0020 [18:40:55] that's a normal space [18:41:16] https://en.wikipedia.org/w/index.php?title=User%3ACscott%2Ftask84937&diff=641277731&oldid=641276921 [18:41:19] TrevorParscal: yes, i know. [18:41:23] nbsp is 'night-black sun pattern', hence ☀ [18:41:29] :-D [18:41:34] what? [18:41:37] yeah, so I feel like I recall shift+space and shift+enter inserting   and \n respectively, but I don't know when that died and why [18:41:40] i made that up [18:41:46] ori: got me [18:42:08] ori: yeah, you should work in politics, you clearly know how to fool even very smart people [18:42:29] it was just plausible enough, and wikitext is just broken enough... [18:42:57] i guess I should file a bug. [18:42:58] TrevorParscal: yes, black sun for npbsp - and on Mac it's option+space [18:43:01] cscott: Ys. [18:43:02] phabulous [18:43:23] etonkovidova: does option+space work? or does it insert the night-black sun pattern? [18:44:20] cscott: there are two problems :) copying nbsp -create a black sun - personally I like it... [18:44:47] in Edit source - option+spca creates nbsp - confirmed it yesterday [18:44:57] etonkovidova: That's what Ed's fixing now. [18:45:15] ok [18:45:51] fixing - meaning - option+space won't insert nbsp? [18:45:52] :) [18:46:54] etonkovidova: No, I meant paste-and-nbsp-get-an-nbsp-and-a-black-sun. [18:47:13] yes, yes - just kidding [18:47:34] James_F: wait, is ed fixing this already? [18:48:23] cscott: The black sun thing? Yes. The lack of creating nbsp easily, no. [18:48:41] 3VisualEditor, VisualEditor-CopyPaste: Visual Editor inserts ☀ instead of   - https://phabricator.wikimedia.org/T85941#957828 (10cscott) 3NEW [18:48:56] James_F: hm, well ^ that might be a dup then? [18:49:37] there is somewhere a general bug about black sun with the comment that it can be inserted with nbsp [18:49:46] anyway, what I was really wondering is whether VE would insert a raw (aka invisible to human editors) \u00A0, or whether it would encode that as   [18:49:57] that's partly a parsoid question [18:50:25] but   and \u00A0 behave differently when delimiting urls, which is https://phabricator.wikimedia.org/T84937 [18:50:30] so it matters which one is chosen. [18:52:29] ie, typing "http://cscott.netis the best" will generate either "http://cscott.net<0xA0>is the best" or "http://cscott.net is the best". unless I can get T84937 fixed in the core parser, in which case you won't need the for either. [18:54:24] cscott: Ignoring copy-paste bugs and other input issues, I expect you'd get \u00A0 , never   unless there was   in the source [18:54:59] But that really really should not matter [18:55:08] I'm glad you guys consider the fact that it does a bug [18:55:34] well, anomie doesn't want to accept my patch which fixes the bug. so i have to do some convincing. [18:55:59] Krenair: Sorry, that 'good reason' was future-talk. I meant to answer you still. [18:56:00] note that generating \u00A0 is very unfriendly to old-school editors editing the wikitext, who can't tell that it's a \u00A0 and not a \u0020 [18:56:31] Krenair: So as for hacky workarounds until that, possibly: standardise usage of returnto/returntoquery in mediawiki-core and give those a class name. [18:56:37] Then mw.hook those. [18:57:12] Like Linker::makeReturnto() or someting like that [18:57:22] cscott: I'd be happy for Parsoid to map \u00A0 -->   [18:57:26] (HTML -> wt) [18:57:40] and in core, mw.hook page.link.returnto listener that updates the url using mw.Uri, and ve-mw trigger that hook when it does pusState. [18:58:17] I'd also be happy for VE to write   rather than \u00A0 when hypothetically inserting them, although right now we always insert Unicode characters [18:58:25] RoanKattouw: yeah, it certainly blurs the line of responsibility between Parsoid and VE. [18:58:50] Yeah [18:59:13] RoanKattouw: but it's a bit more consistent for Parsoid to use the to unambiguously indicate when the author wanted an entity in the wikitext. Punting it back over to VE to generate a for this particular case. [18:59:14] RoanKattouw: Isn't that a Parsoid job though? Representation of the DOM contents into wikitext… [18:59:23] Yeah. [18:59:28] or maybe, more generally to insert a for any characters in the \Zs class, which are otherwise invisible. [19:00:01] * James_F nods. [19:00:31] feel free to weigh in on https://gerrit.wikimedia.org/r/180982, btw, which addresses the entity/character issue in the core parser. in a small way, at least. [19:01:10] let's say I open a phab for "use around \Zs" targetted to VE, and then we can bat it around a bit. [19:01:25] i'd like to move on to the thing I was *actually* working on, i just don't want the issue to get lost. [19:01:42] I don't know about s [19:01:47] But we could do entities [19:01:54] i mean [19:02:11] There's a strong case for VE-as-an-HTML-editor to generate   rather than raw \u00A0, but a very weak case for it to generate magic spans [19:02:15] which is the way to indicate to Parsoid that you'd like that character represented as an entity [19:02:42] RoanKattouw: semantically, when parsing the HTML there is no difference between   and \u00A0 [19:02:49] i'm not sure we even see the difference in our DOM [19:02:55] Hmm [19:03:02] Then I'm not sure we can produce the difference either [19:03:16] you can wrap it with ;) [19:04:53] technically, parsoid could play selser games and default to entity representations in wikitext for newly-created content which would otherwise be invisible. but i feel like that's a UX decision which should really be in the editor. you might decide there are other characters which you'd rather see in wikitext. plus I don't really like adding differences between selser and non-selser pathways. [19:07:37] Hmm, and we have to keep entities as the span-wrapped case because there are multiple entities possible for the same raw character [19:08:05] Like  ,   ,   and   for \u00A0 [19:08:34] (03CR) 10Esanders: Fix context comparison on after paste (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/182795 (owner: 10Esanders) [19:08:37] So we couldn't choose to instead wrap raw chars, because they're fundamentally different in that entities have ambiguity and raw chars do not [19:09:04] (03CR) 10Catrope: Fix context comparison on after paste (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/182795 (owner: 10Esanders) [19:09:45] RoanKattouw: well, the entities will already been span-wrapped. [19:10:07] i suppose span-wrapped entities could be added during copy-paste [19:10:11] I know, I was just musing about a hypothetical case where we flip that around, but we can't do that [19:10:31] Yeah existing span-wrapped entities could be duplicated, or be carried over in VE->VE pastes [19:10:40] 3VisualEditor: Wrap invisible characters in new content with - https://phabricator.wikimedia.org/T85943#957875 (10cscott) 3NEW [19:10:49] Or injected by gadgets/etc. [19:10:56] ok, another lazy copy-some-text-from-irc bug. [19:11:11] but existing span-wrapped entities are fine already, they don't need to be tweaked [19:11:19] 3MediaWiki-ResourceLoader, MediaWiki-Vagrant: Possible performance degradation in lessc - Local vagrant super slow - https://phabricator.wikimedia.org/T78733#957883 (10Jdlrobson) Still hitting this issue with a new install. Changed less to 0.4.0. and then sshing into my vagrant instance and ran `composer update`... [19:11:36] We'll have to see if it's possible to do T85943 but not really do it, e.g. if we can distinguish between entities and raw chars in parsing and/or serialization [19:11:49] it's just when you paste or manually input \u00A0 that some magic needs to happen. and after that the internal representation is the same as for span-wrapped entities, which you already support AFAICT. [19:12:06] Cause if we do do the span-wrapping, that's MW-specific, and when editing HTML generically you also want   rather than \u00A0 [19:12:21] Yeah, that's true [19:12:52] it might just be a MW-specific hack in the input pathway, i think there are some of those already? [19:12:55] Hah, I guess with Ed's sequences system this might not even be hard [19:13:00] Nooooo [19:13:03] that's what i like to hear [19:13:03] That's what I was about to say [19:13:14] The input pathway is far away from MW-specific code [19:13:31] But Ed recently introduced an extension hook system ("sequences") near the input pathway [19:13:48] basically it let's you define things like "turn

1." into "