[00:04:08] (03CR) 10Esanders: "Needs pull through" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/183152 (owner: 10Esanders) [00:19:17] 3MediaWiki-Page-editing: Changes lost when submitting an edit after the session has expired - https://phabricator.wikimedia.org/T11749#958579 (10Mattflaschen) I tested, and I do see the "View source" page (so simply previewing after logging in is not an option). However, the changes are preserved in the "view s... [00:20:19] James_F, I finished dealing with the paths and did a bit of testing, waiting for gwicke to return to answer my question about target wikis [00:26:01] 3MediaWiki-Page-editing: Must manually copy edit text when session data is lost on a wiki that requires logging in to edit - https://phabricator.wikimedia.org/T11749#958584 (10Mattflaschen) [00:27:46] 3MediaWiki-Page-editing: Must manually copy edit text when session data is lost on a wiki that requires logging in to edit - https://phabricator.wikimedia.org/T11749#138345 (10Mattflaschen) [00:32:31] (03CR) 10Jforrester: [C: 032] "Dear Jenkins…" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/183151 (owner: 10Esanders) [00:34:42] (03CR) 10Jforrester: [C: 032] "…" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/183143 (owner: 10Esanders) [00:35:18] (03Merged) 10jenkins-bot: Break out theme-specific CSS [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/183151 (owner: 10Esanders) [00:38:00] (03Merged) 10jenkins-bot: dist: Put cssUrlEmbed after cssjanus now this is possible so it works for dist [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/183143 (owner: 10Esanders) [00:43:13] (03PS2) 10Jforrester: Update VE core submodule to master (34acc70) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/183152 (owner: 10Esanders) [00:43:29] (03CR) 10Jforrester: [C: 032] Update VE core submodule to master (34acc70) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/183152 (owner: 10Esanders) [00:44:38] (03CR) 10Jforrester: "recheck" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/182962 (owner: 10Mooeypoo) [00:44:45] (03CR) 10Jforrester: "recheck" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/182980 (owner: 10Mooeypoo) [00:45:22] (03CR) 10Jforrester: "recheck" [oojs/ui] - 10https://gerrit.wikimedia.org/r/183170 (owner: 10Prtksxna) [00:45:29] (03CR) 10Jforrester: "recheck" [services/citoid] - 10https://gerrit.wikimedia.org/r/182975 (owner: 10Mvolz) [00:49:54] Can I create my own dm document from raw text/html ? [00:50:47] (03Merged) 10jenkins-bot: Update VE core submodule to master (34acc70) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/183152 (owner: 10Esanders) [01:10:50] (03PS11) 10Alex Monk: Use ParsoidVirtualRESTService [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/181011 [01:31:58] (03CR) 10GWicke: [C: 04-1] Use ParsoidVirtualRESTService (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/181011 (owner: 10Alex Monk) [01:32:41] (03PS30) 10Mooeypoo: [WIP] Transform the search widget to show image details [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161342 [01:34:55] (03CR) 10GWicke: Use ParsoidVirtualRESTService (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/181011 (owner: 10Alex Monk) [01:35:36] (03CR) 10Alex Monk: Use ParsoidVirtualRESTService (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/181011 (owner: 10Alex Monk) [01:37:27] gwicke, https://phabricator.wikimedia.org/diffusion/EVED/browse/master/ApiVisualEditor.php;HEAD$158,177 [01:38:15] (03CR) 10GWicke: Use ParsoidVirtualRESTService (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/181011 (owner: 10Alex Monk) [01:38:58] Krenair: that smells like 'wt' [01:39:04] (03CR) 10Alex Monk: Use ParsoidVirtualRESTService (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/181011 (owner: 10Alex Monk) [01:39:24] gwicke, yeah I should fix that [01:39:31] 'content' though, what's that? [01:39:52] oh hm [01:40:02] * gwicke checks the parsoid api docs [01:40:32] https://www.mediawiki.org/wiki/Parsoid/API [01:40:51] I think that's deprecated but still supported [01:41:00] so good to update as well [01:41:07] should be 'html' [01:41:32] what's the difference? [01:41:46] (03CR) 10GWicke: Use ParsoidVirtualRESTService (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/181011 (owner: 10Alex Monk) [01:41:59] Krenair: functionally, currently none [01:42:26] but one uses the documented API which will continue to work [01:43:03] so, to be clear: s/content/html/ [01:43:19] too bad that mounting on / doesn't work [01:44:49] (03PS12) 10Alex Monk: Use ParsoidVirtualRESTService [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/181011 [01:47:30] Krenair: I'm happy to merge the VE patch as-is & then follow up with a core & VE patch to remove the /parsoid/ prefix [01:47:43] does that sound good to you? [01:47:55] okay [01:49:01] (03PS31) 10Mooeypoo: [WIP] Transform the search widget to show image details [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161342 [01:49:29] (03CR) 10GWicke: [C: 032] "LGTM. The /parsoid/ prefix can be removed in a follow-up patch (needs a change in core too)." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/181011 (owner: 10Alex Monk) [01:49:59] Krenair: thank you! [01:51:07] (03Merged) 10jenkins-bot: Use ParsoidVirtualRESTService [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/181011 (owner: 10Alex Monk) [01:51:09] mooeypoo: you can, did you figure it out? [01:53:50] TrevorParscal, not really, no. How? I've been trying to create a new document, but failing. [01:54:02] The main issue is that I may have html markup in there too [01:54:21] is that even possible? we'll need to resend to parsoid in that case, no? [01:54:51] so, you need to convert the string to HTML [01:54:54] that's step 1 [01:55:38] ok, sorry, I got confused, I thought for a second we're getting that data with wikitext (hence the parsoid remark) ... Yes, I already have an HTML in this. [01:55:54] it's already html (this is output from the API) [01:58:58] what is the document for? [01:59:48] ok, so when the user selects an image, the image already has a ddescription -- we want to get that description into the Caption document to start [01:59:53] as an initial caption [02:00:26] I'm getting that data as HTML. The user inserts it manually as wikitext. It *should* be clean and safe -- I just need to figure out how to create that caption document already *with* that data [02:03:28] ok, so you can do this... ve.dm.converter.getModelFromDom( domTree ) [02:03:46] to do that you need to convert your HTML string to a dom tree [02:04:48] use ve.createDocumentFromHtml to do that [02:04:51] you should be all set [02:05:00] gotta go, Cadence's swim class starts in 10min [02:05:03] have fun! [02:07:19] gwicke, so are you working on patches to fix this then? [02:07:45] Krenair: not right now, no [02:08:05] Krenair: will you have time to fix https://gerrit.wikimedia.org/r/181706 soon or should it be reverted for now? [02:09:03] it's not functionally broken, so I think reverting is a bit strong [02:09:15] yes it is [02:09:16] I'm fine with improving it in a follow-up [02:09:28] hmm, didn't you say you tested it? [02:09:40] I can do a follow-up [02:09:56] I was mainly concerned by the global which would have been tricky to fix, but it's not even used. [02:10:05] includes/libs/Cookie.php: * @throws MWException [02:10:36] ;) [02:10:37] someone didn't update docs :< [02:10:42] gwicke, I did [02:12:10] I'll make a follow-up, legoktm & gwicke [02:12:23] Thanks Krenair. [02:12:24] Krenair: oops, too late :P https://gerrit.wikimedia.org/r/183194 [02:13:08] +2ed [02:13:20] thanks [02:13:27] legoktm: thanks as well ;) [02:14:38] Krenair: I'm actually (or was before I diverted into code review) in the middle of a restbase patch [02:15:23] so if you have some time left to remove the /parsoid/ prefix that would be great, otherwise I'll put it on my todo for tomorrow [02:16:03] I need to go [02:16:36] okay, noted in todo. [02:19:44] (03PS1) 10Jforrester: Follow-up I2342fa5b: Bump wfUseMW to 1.25wmf14 for ParsoidVirtualRESTService [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/183197 [02:25:45] 3VisualEditor, VisualEditor-MediaWiki-Media: The "Apply Changes" button in Media Settings dialog for newly added images does not get enabled after applying/changing the link of the caption, when the cursor is at the beginning index - https://phabricator.wikimedia.org/T85845#958701 (10Jdforrester-WMF) a:5Catrope... [02:26:16] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: Applying link to the caption of an image does not enable "Apply Changes" button - https://phabricator.wikimedia.org/T73065#958702 (10Jdforrester-WMF) 5Open>3Resolved This apparently is long-ish-fixed? [02:27:19] (03PS2) 10Alex Monk: Follow-up I2342fa5b: Bump wfUseMW to 1.25wmf14 for ParsoidVirtualRESTService [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/183197 (owner: 10Jforrester) [02:28:50] (03CR) 10Alex Monk: [C: 032] Follow-up I2342fa5b: Bump wfUseMW to 1.25wmf14 for ParsoidVirtualRESTService [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/183197 (owner: 10Jforrester) [02:30:28] (03Merged) 10jenkins-bot: Follow-up I2342fa5b: Bump wfUseMW to 1.25wmf14 for ParsoidVirtualRESTService [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/183197 (owner: 10Jforrester) [02:33:07] 3VisualEditor: Image type Basic: Media settings - Caption not preserved with unchecked 'Wrap text around this item' option - https://phabricator.wikimedia.org/T85979#958713 (10Etonkovidova) 3NEW [02:42:43] (03PS1) 10Mooeypoo: Attach a parent document to image caption documents [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/183199 [02:49:56] 3VisualEditor, VisualEditor-MediaWiki, MediaWiki-Interface, MediaWiki-skins-Vector: All links inside jQuery UI dialogs are black since update - https://phabricator.wikimedia.org/T85857#958722 (10Jdforrester-WMF) 5Open>3Resolved [02:56:25] 3VisualEditor, VisualEditor-MediaWiki: Release VisualEditor-MediaWiki as "1.0" - https://phabricator.wikimedia.org/T84936#958727 (10Jdforrester-WMF) [02:56:28] 3VisualEditor, Parsoid, RESTBase, VisualEditor-MediaWiki, MediaWiki-extensions-Flow, Scrum-of-Scrums, MediaWiki-General-or-Unknown: Use PHP Virtual REST Service to access Parsoid - https://phabricator.wikimedia.org/T1218#958725 (10Jdforrester-WMF) 5Open>3Resolved [03:01:00] 3VisualEditor, VisualEditor-EditingTools: Changes to extension node attributes are ignored - https://phabricator.wikimedia.org/T85818#958729 (10Jdforrester-WMF) 5Open>3Resolved [03:01:33] 3VisualEditor, VisualEditor-CopyPaste: Pasting next to an MWEntity adds a ☀ - https://phabricator.wikimedia.org/T76916#958730 (10Jdforrester-WMF) 5Open>3Resolved [03:01:50] 3VisualEditor, VisualEditor-MediaWiki: VisualEditor: When I click the Save button, please take my cursor out of the main text and focus it in the Save dialog - https://phabricator.wikimedia.org/T75675#958732 (10Jdforrester-WMF) 5Open>3Resolved [04:39:39] 3VisualEditor, Editing, VisualEditor-MediaWiki-Mobile, MobileFrontend-beta: Back arrow appears before other VE controls in MobileFrontend but does nothing - https://phabricator.wikimedia.org/T85481#958787 (10Ryasmeen) Verified the fix in Betalabs and test2 [04:40:10] 3VisualEditor, Editing, VisualEditor-MediaWiki-Mobile, MobileFrontend-beta: Back arrow appears before other VE controls in MobileFrontend but does nothing - https://phabricator.wikimedia.org/T85481#958789 (10Ryasmeen) 5Open>3Resolved [08:29:34] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/182980 (owner: 10Mooeypoo) [09:11:46] (03PS2) 10TheDJ: Remove reference to magnify-clip.png [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/183034 [09:11:49] (03CR) 10jenkins-bot: [V: 04-1] Remove reference to magnify-clip.png [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/183034 (owner: 10TheDJ) [09:16:45] (03PS3) 10TheDJ: Remove reference to magnify-clip.png [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/183034 [09:19:44] (03PS4) 10TheDJ: Remove reference to magnify-clip.png [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/183034 [09:20:40] (03CR) 10TheDJ: "The width sounds like a separate issue, so I'd rather see that in a separate patch." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/183034 (owner: 10TheDJ) [09:26:41] (03CR) 10Fomafix: [C: 031] Remove reference to magnify-clip.png [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/183034 (owner: 10TheDJ) [10:24:15] (03CR) 10Catrope: [C: 04-1] "Why are you doing this? Are you sure this is a good idea? The parentDocument parameter is poorly documented and only used by rebuildNodes(" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/183199 (owner: 10Mooeypoo) [11:40:34] 3VisualEditor: MediaWiki theme: toolbar border too strong - https://phabricator.wikimedia.org/T85974#959163 (10Esanders) [11:45:21] 3VisualEditor: MediaWiki theme: toolbar popup widgets have no visible anchor - https://phabricator.wikimedia.org/T85998#959169 (10Esanders) [12:36:50] (03PS1) 10Gerrit Patch Uploader: Use mw.Api() instead of $.ajax() [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/183237 [12:36:53] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/183237 (owner: 10Gerrit Patch Uploader) [12:47:09] 3MediaWiki-skins-Vector, MediaWiki-Interface, VisualEditor, VisualEditor-MediaWiki: All links inside jQuery UI dialogs are black since update - https://phabricator.wikimedia.org/T85857#959223 (10matmarex) (Does !reopen work?) Should be also fixed in MediaWiki core, for skins other than Vector, no? [13:00:19] 3VisualEditor-MediaWiki-Mobile, VisualEditor-Tables, VisualEditor: Editing tables in Mobile - Edit mode displays broken tables - https://phabricator.wikimedia.org/T74819#959235 (10Esanders) Can you provide links to pages. [13:00:35] 3MediaWiki-skins-Vector, MediaWiki-Interface, VisualEditor, VisualEditor-MediaWiki: All links inside jQuery UI dialogs are black since update - https://phabricator.wikimedia.org/T85857#959236 (10matmarex) 5Resolved>3Open [13:02:56] 3VisualEditor-MediaWiki, VisualEditor: If the user only has edited in one section, VisualEditor should insert the name of the edited section into the edit summary - https://phabricator.wikimedia.org/T53903#959238 (10matmarex) > The scope of the bug is bigger than that? Yes: - When the user edits text in othe... [13:56:39] (03CR) 10Bartosz Dziewoński: [C: 031] "Leaving it to TWN people to merge when convenient." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/183034 (owner: 10TheDJ) [14:02:52] (03CR) 10Raimond Spekking: [C: 032] "Changing the translations are generally not a good idea and should be leaved to twn staff after merging." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/183034 (owner: 10TheDJ) [14:02:57] (03Merged) 10jenkins-bot: Remove reference to magnify-clip.png [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/183034 (owner: 10TheDJ) [14:21:29] 3OOjs-UI: MediaWiki theme: Arrow indicators are too large & not vertically centred - https://phabricator.wikimedia.org/T86001#959366 (10Esanders) 3NEW [14:29:26] 3OOjs-UI: MediaWiki theme: Checkboxes and radios look oversized on desktop - https://phabricator.wikimedia.org/T86003#959384 (10Esanders) 3NEW [14:46:21] (03PS1) 10Esanders: Slight reduce size of indicator arrows in MW so they are centred [oojs/ui] - 10https://gerrit.wikimedia.org/r/183252 [15:07:36] (03PS1) 10Gerrit Patch Uploader: Replace 104px by 102px for width of thumbnail div [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/183254 [15:07:39] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/183254 (owner: 10Gerrit Patch Uploader) [15:31:57] 3VisualEditor: Complete and document VisualEditor's integration and plugin system - https://phabricator.wikimedia.org/T52514#959553 (10Aklapper) [15:32:01] 3VisualEditor: API design and documentation - https://phabricator.wikimedia.org/T40855#959556 (10Aklapper) [15:32:32] 3MediaWiki-ResourceLoader: ResourceLoader: Modules should have a built-in list with details on all available modules - https://phabricator.wikimedia.org/T48563#959581 (10Aklapper) [15:37:41] 3VisualEditor-MediaWiki, VisualEditor: VisualEditor: Document what is needed in terms of support for custom MediaWiki skins - https://phabricator.wikimedia.org/T63500#959626 (10Aklapper) [15:37:45] 3VisualEditor: VisualEditor: Hide action=visualeditor from the api.php documentation output, given it's internal and not intended for third party use - https://phabricator.wikimedia.org/T64452#959632 (10Aklapper) [15:37:50] 3MediaWiki-ResourceLoader: ResoureLoader: Add self-explanatory comment to load.php about ResourceLoader - https://phabricator.wikimedia.org/T53503#959635 (10Aklapper) [15:40:21] 3MediaWiki-ResourceLoader: Document ResourceLoaderModule 'loaderScripts' property - https://phabricator.wikimedia.org/T45905#959717 (10Aklapper) [15:40:24] 3MediaWiki-ResourceLoader: RL debug mode CSS docs incorrect - https://phabricator.wikimedia.org/T46374#959720 (10Aklapper) [15:40:42] 3MediaWiki-ResourceLoader: Update ResourceLoader documentation for Flipping functionality and 1.18's new position properties - https://phabricator.wikimedia.org/T35346#959731 (10Aklapper) [15:40:54] 3MediaWiki-ResourceLoader: Documentation not clear about the alias mw - https://phabricator.wikimedia.org/T29215#959746 (10Aklapper) [15:51:07] hi [15:51:10] 3MobileFrontend-beta, VisualEditor, Editing, VisualEditor-MediaWiki-Mobile: Back arrow appears before other VE controls in MobileFrontend but does nothing - https://phabricator.wikimedia.org/T85481#959797 (10Jdforrester-WMF) [15:51:50] 3MediaWiki-Interface, MediaWiki-skins-Vector, VisualEditor-MediaWiki, VisualEditor: All links inside jQuery UI dialogs are black since update - https://phabricator.wikimedia.org/T85857#959798 (10Krinkle) 5Open>3Resolved >>! In T85857#959223, @matmarex wrote: > Should be also fixed in MediaWiki core, for skin... [15:53:45] 3VisualEditor-ContentEditable, VisualEditor: Ad timestamp or signature to main ns - https://phabricator.wikimedia.org/T86013#959805 (10Juandev) 3NEW [16:04:07] (03CR) 10Esanders: [C: 04-1] Native backspace and delete (035 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179223 (owner: 10Divec) [16:04:49] (03CR) 10Esanders: "You have some broken fakeImes tests too" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179223 (owner: 10Divec) [16:06:16] 3MediaWiki-Interface, MediaWiki-skins-MonoBook, MediaWiki-skins-Vector, VisualEditor-MediaWiki, VisualEditor: All links inside jQuery UI dialogs are black since update - https://phabricator.wikimedia.org/T85857#959829 (10Jdforrester-WMF) 5Resolved>3Open Let's not create tasks for no reason. This can be fixed... [16:18:42] 3VisualEditor-Performance, VisualEditor: Combine API requests required to load VE - https://phabricator.wikimedia.org/T78628#959846 (10Jdforrester-WMF) [16:18:44] 3VisualEditor-MediaWiki, VisualEditor: LinkCache prepopulation in ApiVisualEditor should include page being edited - https://phabricator.wikimedia.org/T78642#959844 (10Jdforrester-WMF) 5Open>3Resolved [16:20:11] 3VisualEditor, Mobile-Web, VisualEditor-MediaWiki-Mobile: VisualEditor broken for MobileFrontend - https://phabricator.wikimedia.org/T78710#959848 (10Jdforrester-WMF) [16:20:53] 3VisualEditor, Editing, Mobile-Web: in MobileFrontend, invoking the editor is incorrect and switching from VisualEditor to wikitext editor does nothing - https://phabricator.wikimedia.org/T85480#959849 (10Jdforrester-WMF) [16:21:26] 3Mobile-Web, VisualEditor: Mobile VisualEditor won't load (this.getSurface(...) is undefined) - https://phabricator.wikimedia.org/T85897#959850 (10Jdforrester-WMF) 5Open>3Resolved [16:21:36] 3Mobile-Web, VisualEditor: Mobile VisualEditor won't load (this.getSurface(...) is undefined) - https://phabricator.wikimedia.org/T85897#956855 (10Jdforrester-WMF) [16:22:29] 3VisualEditor-MediaWiki, VisualEditor: LinkCache prepopulation in ApiVisualEditor should include page being edited - https://phabricator.wikimedia.org/T78642#959854 (10Jdforrester-WMF) [16:26:17] 3Continuous-Integration, Citoid, VisualEditor: Set up CI in the mediawiki/services/citoid.git repo - https://phabricator.wikimedia.org/T76069#959860 (10Jdforrester-WMF) [16:26:44] 3Performance-Metrics-Dashboard, VisualEditor: VE performance dashboard broken - https://phabricator.wikimedia.org/T78106#959869 (10Jdforrester-WMF) [16:29:06] 3VisualEditor-ContentEditable, VisualEditor: VisualEditor: Invocations of deleted images don't render at all - https://phabricator.wikimedia.org/T54186#959893 (10Jdforrester-WMF) [16:34:59] 3VisualEditor-EditingTools, VisualEditor: Limit effect of search-and-replace assessment on long documents - https://phabricator.wikimedia.org/T78234#959923 (10Jdforrester-WMF) 5Open>3Resolved [16:37:13] 3VisualEditor-EditingTools, VisualEditor: VisualEditor: Applying link to the caption of an image does not enable "Apply Changes" button - https://phabricator.wikimedia.org/T73065#959930 (10Whatamidoing-WMF) No, this is still broken. I could reproduce this problem at mediawiki.org this morning. [16:37:46] 3VisualEditor-EditingTools, VisualEditor: VisualEditor: Applying link to the caption of an image does not enable "Apply Changes" button - https://phabricator.wikimedia.org/T73065#959932 (10Jdforrester-WMF) >>! In T73065#959930, @Whatamidoing-WMF wrote: > No, this is still broken. I could reproduce this problem... [16:40:56] 3VisualEditor, VisualEditor-ContentLanguage: VisualEditor: CE eats up syllables except a last syllable of a word in Korean IME - https://phabricator.wikimedia.org/T52631#959934 (10Ara) [16:48:29] (03PS2) 10Jforrester: MediaWiki theme: Slightly reduce size of indicator arrows [oojs/ui] - 10https://gerrit.wikimedia.org/r/183252 (https://phabricator.wikimedia.org/T86001) (owner: 10Esanders) [16:50:48] (03CR) 10Jforrester: [C: 032] MediaWiki theme: Slightly reduce size of indicator arrows [oojs/ui] - 10https://gerrit.wikimedia.org/r/183252 (https://phabricator.wikimedia.org/T86001) (owner: 10Esanders) [16:51:23] 3OOjs-UI: MediaWiki theme: Arrow indicators are too large & not vertically centred - https://phabricator.wikimedia.org/T86001#959959 (10Jdforrester-WMF) 5Open>3Resolved a:3Esanders [16:52:21] (03CR) 10GOIII: [C: 031] Use mw.Api() instead of $.ajax() [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/183237 (owner: 10Gerrit Patch Uploader) [16:52:43] (03Merged) 10jenkins-bot: MediaWiki theme: Slightly reduce size of indicator arrows [oojs/ui] - 10https://gerrit.wikimedia.org/r/183252 (https://phabricator.wikimedia.org/T86001) (owner: 10Esanders) [16:56:35] (03CR) 10Krinkle: [C: 04-1] Use mw.Api() instead of $.ajax() (031 comment) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/183237 (owner: 10Gerrit Patch Uploader) [17:03:05] (03CR) 10GOIII: [C: 031] "2px saved is 2px earned I guess ;D" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/183254 (owner: 10Gerrit Patch Uploader) [17:13:17] (03CR) 10Mooeypoo: "Okay, if that's the case, then this might not be needed. The idea behind this attempted fix was to check why the Caption document doesn't " [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/183199 (owner: 10Mooeypoo) [17:13:36] RoanKattouw dearest, heads up, I'm going to tell you to review https://phabricator.wikimedia.org/T85263 and https://phabricator.wikimedia.org/T85262 again in SoS [17:15:24] marktraceur: And I'll redirect you to Krinkle for both of those [17:15:47] Well then heads-up Krinkle! :) [17:15:53] "apart from abusing the loaderScripts option in ways in which it probably should not be abused" [17:16:07] OH MY GOD OH MY GOD OH MY GOD PLEEEAASE NOOOO [17:16:19] loaderScripts is an abomination and should die in a gigantic fire [17:16:43] If you're talking about abusing it in ways in which it probably shouldn't be abused, I don't even wanna know what *that* looks like [17:18:08] Anyway this is all pretty deep RL and JS stuff and I place full trust in Krinkle [17:18:18] I'm leaving a few comments now [17:18:28] Yeah, we're NOT using loaderScripts. [17:27:36] RoanKattouw, heyhey did you see what I wrote in the fix you commented about? I may need help from you and/or ed about that bug. I'm stumped, it's really weird. I thought the bug was about how I create a new caption document, but it makes no sense, especially due to your comment about the parent. [17:28:55] RoanKattouw: Presumably edsanders is going to SoS, not you? [17:28:55] Oh you commented, let me see [17:29:16] James_F: We haven't discussed that because there hasn't been a non-ridiculously-timed SoS recently [17:29:23] As in one that wasn't on Christmas Eve or New Year's Eve [17:29:29] RoanKattouw: True. edsanders? [17:30:37] Corruption alert: visualeditor-needcheck on sqwiki: https://sq.wikipedia.org/?diff=1481063 [17:30:37] Corruption alert: visualeditor-needcheck on nowiki: https://no.wikipedia.org/?diff=13614318 [17:30:37] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=33866691 [17:30:37] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=33866719 [17:30:37] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=67759354 [17:30:37] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=67762101 [17:30:37] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=67762281 [17:30:38] Corruption alert: visualeditor-needcheck on itwiki: https://it.wikipedia.org/?diff=70068404 [17:30:51] :-( [17:33:42] 3Multimedia, MediaWiki-extensions-Sentry, MediaWiki-ResourceLoader: Create ResourceLoader hook to add new startup modules - https://phabricator.wikimedia.org/T85262#960054 (10Krinkle) It doesn't have to be loaded before the rest per se. We can, but we don't have to. That's an implementation detail that has nothi... [17:34:40] 3Multimedia, MediaWiki-extensions-Sentry, MediaWiki-ResourceLoader: Create ResourceLoader hook to wrap module code - https://phabricator.wikimedia.org/T85263#960061 (10Krinkle) See T85262#960054. [17:38:03] mooeypoo: Hmm I don't know why hasBeenChanged() wouldn't be triggered, but I can assure you that has absolutely nothing to do with document parentage [17:38:29] mooeypoo: Wanna debug this together over hangout after the standup? [17:40:10] RoanKattouw, that'll be great [17:40:37] I am really stumped, it's weird how it's only for new images, which is why I thought it was how I created new caption documents :\ [17:46:27] eh? [17:49:04] edsanders: ? [17:49:06] edsanders: Are you representing our team at Scrum of Scrums today or am I? [17:50:26] Do I need to know anything to do that? [17:51:55] Each person tells the group what their team's been doing that other teams might care about, and highlights things (ideally Phabricator tickets) that their team depends on other teams for [17:54:24] (03PS32) 10Mooeypoo: [WIP] Transform the search widget to show image details [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161342 (https://phabricator.wikimedia.org/T78161) [17:54:46] 3operations, MediaWiki-Core-Team, MediaWiki-ResourceLoader: Bad cache stuck due to race condition with scap between different web servers - https://phabricator.wikimedia.org/T47877#960111 (10chasemp) @greg since this involves scap is this a release engineering thing? Would you be willing to kind of shepherd thi... [17:57:52] 3operations, MediaWiki-Core-Team, MediaWiki-ResourceLoader: Bad cache stuck due to race condition with scap between different web servers - https://phabricator.wikimedia.org/T47877#960136 (10bd808) I think this is really a bug about the fact that we don't depool/repool servers during a the rolling update process... [18:14:45] (03PS1) 10Gerrit Patch Uploader: Add missing dependency to module 'jquery.mwExtension' [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/183280 [18:14:48] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/183280 (owner: 10Gerrit Patch Uploader) [18:16:11] RoanKattouw, talk captions to me [18:16:22] RoanKattouw, or in other words, want to do a quick debugging hangout? [18:16:43] mooeypoo: See PM [18:18:25] 3OOjs-UI: MediaWiki theme: Arrow indicators are too large & not vertically centred - https://phabricator.wikimedia.org/T86001#960185 (10KHammerstein) Similar to this https://phabricator.wikimedia.org/T78086 I proposed we scale down so that width is 10 pixels, and change color to #AAA [18:25:47] (03PS2) 10Gerrit Patch Uploader: Use mw.Api() instead of $.ajax() [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/183237 [18:25:50] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/183237 (owner: 10Gerrit Patch Uploader) [18:36:08] 3MediaWiki-Interface, MediaWiki-skins-Vector, VisualEditor-MediaWiki, VisualEditor: All links inside jQuery UI dialogs are black since update - https://phabricator.wikimedia.org/T85857#960226 (10matmarex) [18:36:21] 3MediaWiki-Interface, MediaWiki-skins-Vector, VisualEditor-MediaWiki, VisualEditor: All links inside jQuery UI dialogs are black since update - https://phabricator.wikimedia.org/T85857#960227 (10matmarex) 5Open>3Resolved [18:36:28] James_F, any announcements for SoS? [18:36:39] (other than MW theme) [18:36:41] edsanders: The Parsoid-service-in-core landed. [18:36:48] yup [18:36:58] edsanders: So Mobile should go build their read-HTML-from-Parsoid spike now. [18:37:03] edsanders: Other than that, no. [18:37:24] and Flow? [18:45:46] edsanders: Flow should switch over to it, yes. [18:49:31] 3VisualEditor-MediaWiki-Mobile, Mobile-Web, VisualEditor: Inspector titles clipped in VisualEditor on mobile - https://phabricator.wikimedia.org/T85068#960304 (10kaldari) @Jdlrobson, @Esanders: What's the status on this? If Ed's change isn't going to be merged, we should at least fix this specific bug. [18:50:49] 3operations, MediaWiki-Core-Team, MediaWiki-ResourceLoader: Bad cache stuck due to race condition with scap between different web servers - https://phabricator.wikimedia.org/T47877#960322 (10chasemp) So we think this is inherent to the design of our deploy mechanisms? @Joe, is there a ticket somwhere for revamp... [18:55:03] 3VisualEditor: [Regression pre-wmf14]Safari - 'Add template' is greyed out - https://phabricator.wikimedia.org/T86038#960366 (10Etonkovidova) 3NEW [18:56:57] (03CR) 10GOIII: [C: 031] Add missing dependency to module 'jquery.mwExtension' [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/183280 (owner: 10Gerrit Patch Uploader) [18:58:51] 3VisualEditor: "Add Template" Overlay: Input isn't pre-selected - https://phabricator.wikimedia.org/T86040#960381 (10Florian) 3NEW [18:59:04] hi [18:59:06] 3VisualEditor: [Regression pre-wmf14]Safari - 'Add template' is greyed out - https://phabricator.wikimedia.org/T86038#960387 (10Etonkovidova) Console for betalbs in Safari persistently shows(not sure if it's relevant to the reported issue): [Error] TypeError: 'null' is not an object (evaluating 'contentNodes.le... [18:59:19] how can I shouw list of the task I made in Phabricator? [19:00:07] 3VisualEditor-MediaWiki-Mobile, Mobile-Web, VisualEditor: Inspector titles clipped in VisualEditor on mobile - https://phabricator.wikimedia.org/T85068#960389 (10Esanders) I think my fix is the only sensible way to fix the bug. I'm happy with the patch in its current state, but ideally I'd like someone from mobi... [19:02:03] 3VisualEditor-ContentEditable, VisualEditor: Set background color to table cell - https://phabricator.wikimedia.org/T86042#960402 (10Juandev) 3NEW [19:04:20] 3VisualEditor-ContentEditable, VisualEditor: Drag and drop or position of table using VE - https://phabricator.wikimedia.org/T86044#960418 (10Juandev) 3NEW [19:04:46] 3MediaWiki-Page-editing: Cite button of RefToolbar not working - https://phabricator.wikimedia.org/T86039#960424 (10MKar) [19:08:36] 3VisualEditor-ContentEditable, VisualEditor: Jump with cursor behind the end tag - https://phabricator.wikimedia.org/T86045#960434 (10Juandev) 3NEW [19:08:51] 3OOjs-UI: All icons should use 65% black rather than solid black in the MediaWiki theme - https://phabricator.wikimedia.org/T86047#960447 (10Jdforrester-WMF) 3NEW [19:10:06] 3VisualEditor: [Regression pre-wmf14] While trying to open Re-use Reference dialog immediately after inserting a citation (not basic reference), throws the TypeError: Cannot read property 'length' of null and the newly added citation does not appear in the list - https://phabricator.wikimedia.org/T86048#960453 (1... [19:10:13] 3OOjs-UI, VisualEditor-MediaWiki, VisualEditor: Clash between rounded corners and text content is jarring for the category editor in VisualEditor when using the OOjs UI MediaWiki theme - https://phabricator.wikimedia.org/T78039#960459 (10Jdforrester-WMF) >>! In T78039#942748, @Jay8g wrote: > Why aren't we just u... [19:21:33] 3VisualEditor: Image type Basic: Media settings - Caption not preserved with unchecked 'Wrap text around this item' option - https://phabricator.wikimedia.org/T85979#960507 (10Ryasmeen) This is by design, Images of type "Basic" are not supposed to render caption. [19:23:25] 3VisualEditor: Image type Basic: Media settings - Caption not preserved with unchecked 'Wrap text around this item' option - https://phabricator.wikimedia.org/T85979#960511 (10Catrope) However, we are planning the following feature: - Insert a thumbnail image with a caption - Change it to a basic image, caption... [19:28:23] 3VisualEditor-MediaWiki-Media, VisualEditor: The "Apply Changes" button in Media Settings dialog for newly added images does not get enabled after applying/changing the link of the caption, when the cursor is at the beginning index - https://phabricator.wikimedia.org/T85845#960525 (10Jdforrester-WMF) a:3Mooeypoo [19:28:32] (03PS1) 10Mooeypoo: Check staged changes in surface hasBeenModified [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/183303 (https://phabricator.wikimedia.org/T85845) [19:28:36] 3VisualEditor: Image type Basic: Media settings - Caption not preserved with unchecked 'Wrap text around this item' option - https://phabricator.wikimedia.org/T85979#960528 (10Ryasmeen) Yup, I think we discussed about this earlier in this one:https://phabricator.wikimedia.org/T68808 [19:28:56] edsanders, I submitted a small change to the hasBeenModified method in ve.dm.Surface ^^ [19:29:39] 3VisualEditor-ContentEditable, VisualEditor: Ad timestamp or signature to main ns - https://phabricator.wikimedia.org/T86013#960536 (10Jdforrester-WMF) [19:29:41] 3VisualEditor-EditingTools, VisualEditor: VisualEditor: Provide a tool to insert a talk signature in namespaces that need it - https://phabricator.wikimedia.org/T53154#960537 (10Jdforrester-WMF) [19:29:50] (03CR) 10Catrope: [C: 04-1] Check staged changes in surface hasBeenModified (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/183303 (https://phabricator.wikimedia.org/T85845) (owner: 10Mooeypoo) [19:30:25] 3OOjs-UI, VisualEditor: MediaWiki theme: Toolbar popup widgets have no visible anchor - https://phabricator.wikimedia.org/T85998#960539 (10Jdforrester-WMF) p:5Triage>3High [19:31:20] 3OOjs-UI, VisualEditor: MediaWiki theme: Border radius used inconsistently - https://phabricator.wikimedia.org/T85973#960544 (10Jdforrester-WMF) p:5Triage>3Normal [19:31:43] 3OOjs-UI, VisualEditor: MediaWiki theme: Toolbar border too strong - https://phabricator.wikimedia.org/T85974#960547 (10Jdforrester-WMF) p:5Triage>3Normal [19:32:01] 3OOjs-UI: MediaWiki theme: Checkboxes and radios look oversized on desktop - https://phabricator.wikimedia.org/T86003#960550 (10Jdforrester-WMF) p:5Triage>3Normal [19:32:37] 3VisualEditor-MediaWiki-References, OOjs-UI, VisualEditor-MediaWiki-Media, VisualEditor: [Regression pre-wmf14] The top border for context menus and inspectors inside Media Settings and Reference dialog are missing in the MediaWiki theme - https://phabricator.wikimedia.org/T85842#960555 (10Jdforrester-WMF) a:5C... [19:33:02] 3OOjs-UI: Icon containers should always be the same size so we can use background-size: contain - https://phabricator.wikimedia.org/T85139#960557 (10Jdforrester-WMF) p:5Triage>3Low a:3Esanders [19:33:22] (03CR) 10Mooeypoo: Check staged changes in surface hasBeenModified (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/183303 (https://phabricator.wikimedia.org/T85845) (owner: 10Mooeypoo) [19:33:25] (03CR) 10jenkins-bot: [V: 04-1] Check staged changes in surface hasBeenModified [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/183303 (https://phabricator.wikimedia.org/T85845) (owner: 10Mooeypoo) [19:43:02] 3VisualEditor: [Regression pre-wmf14]Cannot add any template, throws error TypeError: Cannot read property 'length' of null - https://phabricator.wikimedia.org/T86056#960579 (10Ryasmeen) 3NEW [19:44:33] 3VisualEditor: [Regression pre-wmf14]Cannot add any template, throws error TypeError: Cannot read property 'length' of null - https://phabricator.wikimedia.org/T86056#960579 (10Ryasmeen) Screenshot attached {F26889} [19:46:50] Oh FFS [19:47:23] Krinkle: Without checking in a console, can you tell me off the top of your head what $.parseHTML( '' ) (empty string) returns? [19:47:29] Or what it should return? :P [19:47:40] RoanKattouw: an array with one text node [19:47:49] or an empty array if they do a bool check [19:48:12] Hah, array with empty text node was one I hadn't considered [19:48:15] But yeah I expected [] [19:48:22] Now check what it actually returns :D [19:48:24] null? [19:48:28] YES [19:48:30] GRRRR [19:48:35] 3VisualEditor: [Regression pre-wmf14] Safari - VE does not display inserted Formulas - https://phabricator.wikimedia.org/T86046#960591 (10Aklapper) [Adding "VisualEditor" project - feel encouraged to do so when creating tasks. Thanks!] [19:48:39] Hence https://phabricator.wikimedia.org/T86056#960579 [19:49:05] Because we wrote code assuming that $.parseHTML() always returns something that you can check .length on [19:50:36] Reporting upstream :) [19:51:30] Thanks :) [19:51:45] I'll audit our code for other parseHTML uses and put in workarounds for all of them [19:53:02] 3VisualEditor: [Regression pre-wmf14] VE does not display inserted Formulas - https://phabricator.wikimedia.org/T86046#960596 (10Etonkovidova) [19:53:54] 3VisualEditor: [Regression pre-wmf14] VE does not display inserted Formulas - https://phabricator.wikimedia.org/T86046#960602 (10Ryasmeen) Also,happening for gallery [19:53:58] Krinkle: Give me a link to the upstream bug when you have it? [19:54:01] So I can put it in code comments [19:54:12] Yeah, will tell you as soon as I hve it [19:54:24] It's been there since first version [19:54:34] so it's probably not going to have a strong defence [19:54:39] it was just the way it was implemented first time round [19:54:39] https://github.com/jquery/jquery/commit/e2497c682f26b7916d76cb2896c6fe621b376d82 [19:54:40] 3VisualEditor: [Regression pre-wmf14] Safari - misplaced Gallery dialog box - https://phabricator.wikimedia.org/T86051#960605 (10Etonkovidova) [19:56:49] 3VisualEditor: [Regression pre-wmf14] VE does not display inserted Formulas - https://phabricator.wikimedia.org/T86046#960614 (10Ryasmeen) p:5Triage>3Unbreak! [19:57:32] RoanKattouw: https://github.com/jquery/jquery/issues/1997 [19:57:42] (They moved to gh-issues instead of Trac) [19:58:18] Hah, $(null) is the same as $([]) [19:58:19] 3OOjs-UI: MediaWiki theme: Checkboxes and radios look oversized on desktop - https://phabricator.wikimedia.org/T86003#960618 (10KHammerstein) May what do you think? [19:58:32] So if you do $( $.parseHTML( ... ) ) you're not affected by this bug [20:02:24] RoanKattouw: Right [20:02:57] (03PS1) 10Catrope: Work around $.parseHTML( '' ) returning null [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/183309 (https://phabricator.wikimedia.org/T86056) [20:02:59] // HANDLE: $(""), $(null), $(undefined), $(false) [20:03:38] (03CR) 10Krinkle: [C: 032] Work around $.parseHTML( '' ) returning null [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/183309 (https://phabricator.wikimedia.org/T86056) (owner: 10Catrope) [20:03:52] 3VisualEditor: [Regression wmf15] VE does not display inserted Formulas - https://phabricator.wikimedia.org/T86046#960632 (10Ryasmeen) [20:04:12] RoanKattouw: thanks for github referernce parsing and our gerrit/github mirroring, your commit will probably show up on that bug report. [20:04:14] 3VisualEditor: [Regression pre-wmf15] VE does not display inserted Formulas - https://phabricator.wikimedia.org/T86046#960442 (10Ryasmeen) [20:05:00] haha [20:05:29] Thanks for reporting that man [20:06:20] 3VisualEditor: [Regression wmf14]Cannot add any template, throws error TypeError: Cannot read property 'length' of null - https://phabricator.wikimedia.org/T86056#960636 (10Ryasmeen) [20:06:40] (03Merged) 10jenkins-bot: Work around $.parseHTML( '' ) returning null [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/183309 (https://phabricator.wikimedia.org/T86056) (owner: 10Catrope) [20:07:02] (03CR) 10Esanders: Check staged changes in surface hasBeenModified (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/183303 (https://phabricator.wikimedia.org/T85845) (owner: 10Mooeypoo) [20:09:10] (03CR) 10Mooeypoo: Check staged changes in surface hasBeenModified (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/183303 (https://phabricator.wikimedia.org/T85845) (owner: 10Mooeypoo) [20:23:09] 3Multimedia, MediaWiki-extensions-Sentry, MediaWiki-ResourceLoader: Create ResourceLoader hook to add new startup modules - https://phabricator.wikimedia.org/T85262#960660 (10Tgr) >>! In T85262#960054, @Krinkle wrote: > As for the try-catch approach, that doesn't work. JavaScript can detach itself from the root... [20:29:37] 3Multimedia, MediaWiki-extensions-Sentry, MediaWiki-ResourceLoader: Create ResourceLoader hook to add new startup modules - https://phabricator.wikimedia.org/T85262#960680 (10Tgr) > [raven.js] does some things that cannot be in a lazy-loaded way; specifically, it rethrows exceptions and re-catches them via windo... [20:33:02] 3Multimedia, MediaWiki-extensions-Sentry, MediaWiki-ResourceLoader: Find out whether any browser supported by MediaWiki needs TraceKit's "rethrow to window.onerror" logic for stack traces - https://phabricator.wikimedia.org/T86058#960682 (10Tgr) 3NEW a:3Tgr [20:47:19] 3MediaWiki-skins-Vector, MediaWiki-Interface, VisualEditor, VisualEditor-MediaWiki: All links inside jQuery UI dialogs are black since update - https://phabricator.wikimedia.org/T85857#960723 (10Etonkovidova) The links are back to blue in betalabs and test2. [21:01:51] cal [21:02:20] 3MediaWiki-Page-editing: Cite button of RefToolbar not working - https://phabricator.wikimedia.org/T86039#960772 (10Aklapper) Hi @MKar. Exact steps to reproduce are welcome, so anybody could follow without having to interpret. Currently I don't know how to also see that problem. To find the problem, could you... [21:05:43] MatmaRex: meeting? [21:06:08] bah. sure [21:06:39] sorry [21:10:00] 3VisualEditor-MediaWiki-Templates, VisualEditor: Insert/Template inspector should put focus on input text_field when invoked but no longer does - https://phabricator.wikimedia.org/T85484#960794 (10Etonkovidova) Duplicate to https://phabricator.wikimedia.org/T86040 [21:10:43] aharoni, how do you say "nested" in hebrew? :P [21:10:47] like.. nested templates. [21:10:53] * mooeypoo forgot a word and is ashamed [21:11:13] 3VisualEditor-MediaWiki-Templates, VisualEditor: [Regression wmf14] Cannot add any template, throws error TypeError: Cannot read property 'length' of null - https://phabricator.wikimedia.org/T86056#960804 (10Jdforrester-WMF) [21:12:18] mooeypoo: מקונן ? [21:12:46] (Google Translate.) [21:13:21] mooeypoo: nest: קן, nesting: קינון [21:15:02] (03PS14) 10Jforrester: WIP: Record intention in ve.dm.Transaction object [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151777 (owner: 10Cscott) [21:15:13] (03PS12) 10Jforrester: Add ve.dm.Transaction.newNoOp() constructor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151783 (owner: 10Cscott) [21:15:18] (03PS9) 10Jforrester: Add ve.dm.Transaction.newFromIntention() method [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151798 (owner: 10Cscott) [21:15:37] (03CR) 10Jforrester: "(Needs rebase.)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151799 (owner: 10Cscott) [21:16:08] (03PS1) 10Jforrester: Work around $.parseHTML( '' ) returning null [extensions/VisualEditor] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/183330 (https://phabricator.wikimedia.org/T86056) [21:16:50] 3VisualEditor-MediaWiki-Templates, VisualEditor: [Regression wmf14] Cannot add any template, throws error TypeError: Cannot read property 'length' of null - https://phabricator.wikimedia.org/T86056#960829 (10Jdforrester-WMF) 5Open>3Resolved a:3Catrope [21:17:50] 3VisualEditor-MediaWiki-Templates, VisualEditor: [Regression wmf14] Cannot add any template, throws error TypeError: Cannot read property 'length' of null - https://phabricator.wikimedia.org/T86056#960843 (10Ryasmeen) I am not getting the error now after this fix, but still the template is appearing as an empty... [21:19:11] 3Mobile-Web, VisualEditor: Mobile VisualEditor won't load (this.getSurface(...) is undefined) - https://phabricator.wikimedia.org/T85897#960865 (10Jdforrester-WMF) a:3Krenair [21:21:33] 3MobileFrontend-beta, VisualEditor-MediaWiki-Mobile, Editing, VisualEditor: Back arrow appears before other VE controls in MobileFrontend but does nothing - https://phabricator.wikimedia.org/T85481#960883 (10Jdforrester-WMF) a:3Jdlrobson [21:22:54] 3VisualEditor-CopyPaste, VisualEditor: Pasting next to an MWEntity adds a ☀ - https://phabricator.wikimedia.org/T76916#960891 (10Etonkovidova) Checked in betalabs and test2. [21:23:10] 3VisualEditor-CopyPaste, VisualEditor: Pasting next to an MWEntity adds a ☀ - https://phabricator.wikimedia.org/T76916#960892 (10Etonkovidova) [21:25:18] 3OOjs-UI: MediaWiki theme: Arrow indicators are too large & not vertically centred - https://phabricator.wikimedia.org/T86001#960898 (10Jdforrester-WMF) p:5Triage>3Normal [21:25:37] 3VisualEditor-CopyPaste, VisualEditor: Pasting next to an MWEntity adds a ☀ - https://phabricator.wikimedia.org/T76916#960900 (10Jdforrester-WMF) [21:25:39] 3Mobile-Web, Editing, VisualEditor: in MobileFrontend, invoking the editor is incorrect and switching from VisualEditor to wikitext editor does nothing - https://phabricator.wikimedia.org/T85480#960901 (10Jdforrester-WMF) [21:25:41] 3Performance-Metrics-Dashboard, VisualEditor: VE performance dashboard broken - https://phabricator.wikimedia.org/T78106#960903 (10Jdforrester-WMF) [21:25:42] 3VisualEditor-EditingTools, VisualEditor: Limit effect of search-and-replace assessment on long documents - https://phabricator.wikimedia.org/T78234#960904 (10Jdforrester-WMF) [21:25:44] 3MediaWiki-General-or-Unknown, Scrum-of-Scrums, RESTBase, Parsoid, MediaWiki-extensions-Flow, VisualEditor, VisualEditor-MediaWiki: Use PHP Virtual REST Service to access Parsoid - https://phabricator.wikimedia.org/T1218#960905 (10Jdforrester-WMF) [21:25:45] 3MediaWiki-skins-Vector, MediaWiki-Interface, VisualEditor, VisualEditor-MediaWiki: All links inside jQuery UI dialogs are black since update - https://phabricator.wikimedia.org/T85857#960906 (10Jdforrester-WMF) [21:25:47] 3VisualEditor-MediaWiki-Mobile, Mobile-Web, VisualEditor: [Regression pre-wmf14] Cannot switch from VE to wikitext editor in Mobile Web - https://phabricator.wikimedia.org/T84897#960907 (10Jdforrester-WMF) [21:25:50] 3VisualEditor, VisualEditor-MediaWiki: VisualEditor: When I click the Save button, please take my cursor out of the main text and focus it in the Save dialog - https://phabricator.wikimedia.org/T75675#960909 (10Jdforrester-WMF) [21:25:51] 3VisualEditor-MediaWiki-Mobile, Mobile-Web, VisualEditor: VisualEditor broken for MobileFrontend - https://phabricator.wikimedia.org/T78710#960908 (10Jdforrester-WMF) [21:25:52] 3VisualEditor-EditingTools, VisualEditor: Changes to extension node attributes are ignored - https://phabricator.wikimedia.org/T85818#960910 (10Jdforrester-WMF) [21:25:55] 3VisualEditor, VisualEditor-MediaWiki: Update bits of VisualEditor still referring to Bugzilla - https://phabricator.wikimedia.org/T75733#960913 (10Jdforrester-WMF) [21:25:56] 3VisualEditor-EditingTools, VisualEditor: Add a cross button to close the Find-Replace panel or clicking on CE may slide it up ? - https://phabricator.wikimedia.org/T77933#960911 (10Jdforrester-WMF) [21:25:58] 3VisualEditor-MediaWiki-Mobile, VisualEditor: [Regression wmf13] Icons are misaligned in the Cite dropdown menu of the toolbar in mobile VE - https://phabricator.wikimedia.org/T85025#960915 (10Jdforrester-WMF) [21:25:59] 3VisualEditor, VisualEditor-MediaWiki: Edit source link broken after editing the page with VisualEditor - https://phabricator.wikimedia.org/T85552#960914 (10Jdforrester-WMF) [21:26:01] 3OOjs-UI, VisualEditor, VisualEditor-MediaWiki: Dialog section labels are way too big compared to the rest of the contents of a dialog - https://phabricator.wikimedia.org/T78037#960917 (10Jdforrester-WMF) [21:26:03] 3OOjs-UI: PopupToolGroup technical debt is demanding that we pay it - https://phabricator.wikimedia.org/T78499#960919 (10Jdforrester-WMF) [21:26:04] 3OOjs-UI, MediaWiki-Interface, UI-Standardization: Switch MediaWiki core's use of OOjs UI to use the MediaWiki theme, not Apex - https://phabricator.wikimedia.org/T78054#960918 (10Jdforrester-WMF) [21:26:06] 3VisualEditor-EditingTools, VisualEditor, VisualEditor-MediaWiki: [Regression wmf11] Pressing Escape while a dialog is open closes the editor, should only close the dialog - https://phabricator.wikimedia.org/T78201#960920 (10Jdforrester-WMF) [21:26:07] 3VisualEditor-InterfaceLanguage, OOjs-UI, VisualEditor: VisualEditor page options menu goes off-screen in RTL wikis - https://phabricator.wikimedia.org/T76474#960921 (10Jdforrester-WMF) [21:26:09] 3OOjs-UI, VisualEditor, VisualEditor-MediaWiki: Vertical alignment of text in the search-and-replace field is off in VisualEditor - https://phabricator.wikimedia.org/T78041#960922 (10Jdforrester-WMF) [21:26:10] 3OOjs-UI: ClippableElement PopupToolGroup near right side of viewport hilariously broken - https://phabricator.wikimedia.org/T78447#960925 (10Jdforrester-WMF) [21:26:11] 3VisualEditor, VisualEditor-MediaWiki: The (Ctrl+Alt+S) keyboard shortcut opens the Save dialog but should also trigger save when in it - https://phabricator.wikimedia.org/T76161#960924 (10Jdforrester-WMF) [21:26:12] 3OOjs-UI: OOjs UI: [Regression] Menu width isn't working in IE11 any more – see VisualEditor's 'Page options' drop down menu - https://phabricator.wikimedia.org/T74640#960923 (10Jdforrester-WMF) [21:26:14] 3VisualEditor, VisualEditor-MediaWiki: Edit source tab should not hijack middle-click - https://phabricator.wikimedia.org/T78546#960927 (10Jdforrester-WMF) [21:26:15] 3OOjs-UI: OOjs UI: Toolbar menu width isn't working in IE11 any more - https://phabricator.wikimedia.org/T74592#960926 (10Jdforrester-WMF) [21:26:16] 3VisualEditor-EditingTools, VisualEditor-InterfaceLanguage, VisualEditor: Don't text-transform: capitalize; section headers in the special character inserter - https://phabricator.wikimedia.org/T78327#960928 (10Jdforrester-WMF) [21:26:17] 3UI-Standardization, MediaWiki-Interface, OOjs-UI: Decide whether or not to use hover to indicate which item in menus/etc. we're about to select, in the MediaWiki theme - https://phabricator.wikimedia.org/T78082#960931 (10Jdforrester-WMF) [21:26:19] 3OOjs-UI: ButtonGroupWidget in demo pooped in MediaWiki theme - https://phabricator.wikimedia.org/T78326#960932 (10Jdforrester-WMF) [21:26:20] 3OOjs-UI: CheckboxInput doesn't support string value, forces boolean and won't work with many use cases in HTML static forms - https://phabricator.wikimedia.org/T76645#960929 (10Jdforrester-WMF) [21:26:21] 3OOjs-UI: Scrolling elements into view does not work in most cases - https://phabricator.wikimedia.org/T73609#960930 (10Jdforrester-WMF) [21:26:22] 3OOjs-UI: Calling ButtonWidget.setButtonElement crashes inside jQuery - https://phabricator.wikimedia.org/T78270#960934 (10Jdforrester-WMF) [21:26:24] 3OOjs-UI: Multiline checkbox labels broken - https://phabricator.wikimedia.org/T78173#960933 (10Jdforrester-WMF) [21:26:29] 3VisualEditor, VisualEditor-MediaWiki: [Regression pre-wmf13] TypeError: this.toolbar.getSurface(...) is null appears after saving an edit and then cannot reopen that page next time - https://phabricator.wikimedia.org/T78335#960938 (10Jdforrester-WMF) p:5Triage>3Normal [21:28:22] 3VisualEditor, VisualEditor-ContentEditable: Text that was added to a slug immediately vanishes when the cursor is placed in another slug - https://phabricator.wikimedia.org/T85948#960941 (10Jdforrester-WMF) p:5Triage>3Unbreak! [21:33:53] RoanKattouw: Maybe Parsoid on Beta Labs needs restarting or something? Very odd behaviour on Beta Labs but not on MW.org despite being (essentially) identical? [21:35:59] {"visualeditor":{"result":"success","content":""}} is an unhelpful parseFragment response. :-) [21:36:11] Krenair: You around? [21:37:27] (03CR) 10He7d3r: [C: 031] Add missing dependency to module 'jquery.mwExtension' [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/183280 (owner: 10Gerrit Patch Uploader) [21:37:41] 3VisualEditor, VisualEditor-MediaWiki: [Regression wmf14] Response from parseFragment is blank content, meaning newly-inserted or -modified content is blank until saving - https://phabricator.wikimedia.org/T86046#960950 (10Jdforrester-WMF) [21:37:47] yep [21:37:52] hi [21:37:57] Krenair: https://phabricator.wikimedia.org/T86046 looks like a ParsoidRESTService thing. :-( [21:38:18] looking [21:38:22] Thanks! [21:40:10] James_F: Hah that's what triggered the $.parseHTML bug [21:40:29] Yeah I was about to say maybe it's a VRS thing [21:42:36] RoanKattouw: Indeed. [21:42:45] ryasmeen: https://phabricator.wikimedia.org/T78626 – is this still a thing? Can't test. [21:43:26] checking James_F [21:45:18] 3VisualEditor, VisualEditor-EditingTools: [Regression wmf14] Safari - misplaced Gallery dialog box - https://phabricator.wikimedia.org/T86051#960986 (10Jdforrester-WMF) p:5Triage>3Normal [21:46:35] 3VisualEditor, VisualEditor-ContentEditable: Set background color to table cell - https://phabricator.wikimedia.org/T86042#960993 (10Jdforrester-WMF) [21:46:36] 3VisualEditor, VisualEditor-Tables: Be able to set table cell background (and other formatting options) - https://phabricator.wikimedia.org/T54180#960994 (10Jdforrester-WMF) [21:48:05] 3OOjs-UI, UI-Standardization: Our new front-end platform – OOjs UI - https://phabricator.wikimedia.org/T86072#960999 (10Jdforrester-WMF) [21:49:36] 3VisualEditor, VisualEditor-MediaWiki-Templates: [Regression wmf14] Safari - 'Add template' is greyed out - https://phabricator.wikimedia.org/T86038#961005 (10Jdforrester-WMF) p:5Triage>3High [21:52:32] section editing on mw.o is broken? [21:53:14] in my console: http://fpaste.org/166975/6675541/raw/ [21:54:40] legoktm: I was seriously looking for self.fire.killWith [21:55:40] :P [21:57:39] 3VisualEditor, VisualEditor-MediaWiki: [Regression wmf14] Response from parseFragment is blank content, meaning newly-inserted or -modified content is blank until saving - https://phabricator.wikimedia.org/T86046#961020 (10Krenair) a:3Krenair [21:58:58] (03PS1) 10Alex Monk: Fix Parsoid transformation calls [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/183375 (https://phabricator.wikimedia.org/T86046) [22:00:09] RoanKattouw, sooooo the image problem thing? This can only be sanely fixed by Parsoid implementing its 'defaultSize' not by hardcoded 220 but by actually looking at the wiki settings. [22:00:56] (03CR) 10jenkins-bot: [V: 04-1] Fix Parsoid transformation calls [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/183375 (https://phabricator.wikimedia.org/T86046) (owner: 10Alex Monk) [22:01:29] legoktm: Is that a warning or an error? It sounds like an EventLogging validation failure [22:01:39] And a concerning one because I think we're feeding in page.id from a core wg var [22:02:01] 3VisualEditor, Editing: "Future of Editing" plenary session at 2015 MediaWiki Developer Summit - https://phabricator.wikimedia.org/T85152#961032 (10Jdforrester-WMF) p:5Triage>3High [22:03:06] (03PS2) 10Alex Monk: Fix Parsoid transformation calls [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/183375 (https://phabricator.wikimedia.org/T86046) [22:06:44] RoanKattouw: not sure, but it's preventing VE from loading [22:06:49] Ugh [22:06:55] I'll check [22:07:28] 3VisualEditor: Hitting escape should exit from VisualEditor - https://phabricator.wikimedia.org/T86075#961052 (10MarkAHershberger) 3NEW [22:07:33] legoktm: I can't reproduce that [22:07:38] Where did you reproduce it? [22:08:14] 3VisualEditor: Hitting escape should exit from VisualEditor - https://phabricator.wikimedia.org/T86075#961060 (10Krenair) [22:08:19] 3VisualEditor, VisualEditor-MediaWiki: Escape key inside the main editor should cancel VE mode and return to action=view - https://phabricator.wikimedia.org/T52868#961061 (10Krenair) [22:08:30] RoanKattouw: on https://www.mediawiki.org/wiki/Scrum_of_scrums/2015-01-07 I hit "edit" next to "MediaWiki Core" [22:08:51] WFM [22:09:24] hmm, now I have http://fpaste.org/166981/42066852/raw/ [22:10:07] I'm getting a lot of weird errors. [22:10:13] > TypeError: mw.echo is undefined [22:10:40] Firefox 34.0 btw [22:12:37] WFM in Firefox 34.0 [22:12:43] blargh. [22:12:54] I think your computer is on drugs man [22:12:55] ok, I'll play with it more later today [22:12:58] >.> [22:13:34] ok if I log out everything is fine, so it might be some of my JS [22:15:42] TrevorParscal: why doesn't OOUI's Element constructor accept a 'attributes' configuration option, akin to 'classes' and 'content'? [22:16:14] TrevorParscal: by design, or just no one did it yet? because it would be pretty convenient [22:16:42] (especially since bloody PHP doesn't let you do ( new Whatever(…) )->method(), that doesn't parse…) [22:18:33] TrevorParscal: alternatively, do we want every widget to implement the configuration options mapping to all possible attributes of the underlying HTML element? [22:20:29] 3OOjs-UI: MediaWiki theme: Checkboxes and radios look oversized on desktop - https://phabricator.wikimedia.org/T86003#961071 (10violetto) {F26906} Seems like there isn't much space between the radio buttons, I added .5em between the radio buttons. I also noticed that the font size used isn't 1em, so I've change... [22:28:47] MatmaRex: it's just PHP 5.3 that doesn't let you do that :P [22:29:27] php > class Foo { function bar() { echo "hi"; } } [22:29:27] php > ( new Foo() )->bar(); [22:29:27] hi [22:29:34] legoktm: call me back when we drop support for it :P [22:29:46] but 5.4 fixed some awful syntax suckinesses, true [22:29:52] https://phabricator.wikimedia.org/T75901 ! [22:33:56] legoktm: Have suggested we do it now. ;-) [22:34:06] James_F: We're not at 100% HHVM. [22:34:32] legoktm: Really? The Deployments calendar claims we are. [22:35:01] image scalers, job runners, terbium, tin, etc. [22:35:38] Oy. [22:36:13] * Krenair goes to tell James this on the task [22:36:25] legoktm: How long 'til they're switched over? [22:36:55] I think job runners are in progress and image scalers are next? or.i / _joe_ would know. [22:42:24] 3OOjs-UI: MediaWiki theme: Arrow indicators are too large & not vertically centred - https://phabricator.wikimedia.org/T86001#961100 (10KHammerstein) Or by #AAA I mean 35% black [22:44:40] jobrunners are moving to HHVM next week legoktm James_F [22:44:50] chrismcmahon: Cool. [22:44:58] chrismcmahon: Know anything about the other boxes? [22:45:31] James_F: nope. I know about jobrunners because it came up in Scrum of Scrums. We may be waiting for hardware, not sure [22:45:38] * James_F nods. [22:45:42] Thanks! [22:47:11] 3OOjs-UI, VisualEditor: Toolbars should have a heavy shadow on their bottom in the MediaWiki theme - https://phabricator.wikimedia.org/T78085#961105 (10Etonkovidova) [22:56:40] Krenair: ping [22:57:06] gwicke: pong [22:57:38] hey! yesterday as I headed out I realized that it would be good to mention the php5-curl dependency in the release notes [22:57:46] 3VisualEditor-EditingTools, VisualEditor: VisualEditor: Add support for (the equivalent of?) editintro and preload - https://phabricator.wikimedia.org/T51622#961121 (10Spage) [22:57:55] Krenair: could you add that? [22:58:06] I'll look into the /parsoid/ prefix removal in the meantime [22:58:25] I don't think we have release notes in the ve repo? [22:58:28] or did you mean core [22:58:32] core [23:00:21] do you want to add that in the fixes for the /parsoid/ thing? [23:09:35] 3VisualEditor-MediaWiki-Mobile, VisualEditor: Citation dialog not opening in mobile VE for en.wiki - https://phabricator.wikimedia.org/T86077#961137 (10Ryasmeen) 3NEW [23:12:14] this is awful [23:12:28] every time i look at the login/createacc templates, i find a new set of stupid bugs [23:18:36] Krenair: hmm, could do [23:18:49] I'll get the blame then ;) [23:19:09] it was your idea and you did approve it [23:19:20] :p [23:22:07] TrevorParscal: i need you to look at https://gerrit.wikimedia.org/r/183390 and respond to the snags i hit (see angry comments in the code) [23:25:25] James_F|Away: i need you to make TrevorParscal do this ^; i'm mostly leaving for today [23:38:20] RoanKattouw: Could you quickly review https://gerrit.wikimedia.org/r/#/c/183375/ ? Sorry to ask. [23:38:22] Bah. [23:38:27] Well, that's a failure. :-) [23:40:11] ? [23:47:51] Krenair: RoanKattouw became RoanKattouw_away half a second before I asked. [23:47:59] ah :) [23:52:07] (03CR) 10Jforrester: "To be cherry-picked to wmf14 once merged." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/183375 (https://phabricator.wikimedia.org/T86046) (owner: 10Alex Monk) [23:56:17] I'm getting an error in my JS console when I try to run VE. It is "Error: Unknown dependency: schema.Edit" [23:56:29] 3VisualEditor, VisualEditor-MediaWiki-Templates: [Regression wmf14] Cannot add any template, throws error TypeError: Cannot read property 'length' of null - https://phabricator.wikimedia.org/T86056#961238 (10Jdforrester-WMF) >>! In T86056#960843, @Ryasmeen wrote: > I am not getting the error now after this fix,... [23:57:35] (03CR) 10GWicke: [C: 031] Fix Parsoid transformation calls [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/183375 (https://phabricator.wikimedia.org/T86046) (owner: 10Alex Monk) [23:58:25] Krenair: is anybody else going to look too? [23:58:32] if not, then I'm happy to +2 [23:58:46] gwicke: I'm here. I'm the original poster [23:58:54] Negative24, we were discussing something else [23:59:02] gwicke, No we've been trying to get someone to review it [23:59:12] Negative24: probably you don't have the EventLogging extension installed? [23:59:32] Negative24: in my experience thta can be safely ignored… but VE should probably handle this better [23:59:47] MatmaRex, I thought that but we don't require eventlogging. [23:59:49] (i assume the editor does actually load and save pages)