[00:08:17] (03CR) 10Trevor Parscal: [C: 032] "I'm VERY open to better naming. I litterally named it the first thing that came to mind. I worry that menu may be confusing given it's use" [oojs/ui] - 10https://gerrit.wikimedia.org/r/184008 (owner: 10Trevor Parscal) [00:13:13] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Add AsideLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/184008 (owner: 10Trevor Parscal) [00:19:36] TrevorParscal, self+2? [00:23:17] (03CR) 10Esanders: [C: 04-1] "still some unaddressed comments from PS39" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161342 (https://phabricator.wikimedia.org/T78161) (owner: 10Mooeypoo) [00:29:46] (03CR) 10Esanders: "+2ing your own code?" [oojs/ui] - 10https://gerrit.wikimedia.org/r/184008 (owner: 10Trevor Parscal) [00:36:32] (03CR) 10Catrope: "Removed Trevor's +2 because:" [oojs/ui] - 10https://gerrit.wikimedia.org/r/184008 (owner: 10Trevor Parscal) [00:37:56] (03CR) 10Catrope: [C: 032] Update ApiResult handling for mediawiki/core change I7b37295e [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/183605 (owner: 10Anomie) [00:43:58] 3VisualEditor-Tables, VisualEditor: Tables: merged cells become cannot be un-merged via Table - Un-merge menu - https://phabricator.wikimedia.org/T86610#972558 (10Etonkovidova) 3NEW [00:44:39] 3VisualEditor-Tables, VisualEditor: Tables: merged cells cannot be un-merged via Table - Un-merge menu - https://phabricator.wikimedia.org/T86610#972566 (10Etonkovidova) [01:07:30] (03PS2) 10Jforrester: Move contents of VisualEditor.php to extension.json [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/183524 [01:08:53] (03CR) 10jenkins-bot: [V: 04-1] Move contents of VisualEditor.php to extension.json [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/183524 (owner: 10Jforrester) [01:09:05] (03CR) 10Jforrester: [C: 04-1] "Whoops. :-)" [oojs/ui] - 10https://gerrit.wikimedia.org/r/184008 (owner: 10Trevor Parscal) [01:10:16] (03Merged) 10jenkins-bot: Update ApiResult handling for mediawiki/core change I7b37295e [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/183605 (owner: 10Anomie) [01:18:58] 3MediaWiki-API, Wikidata, MediaWiki-Page-editing: ApiStashEdit silently loses custom DataUpdates. - https://phabricator.wikimedia.org/T86305#972630 (10aaron) @daniel: what do you think of https://gerrit.wikimedia.org/r/184463. Would be hard to build off? I'd really like to get stashing on again, since it saves 3... [01:20:35] 3VisualEditor-ContentEditable, VisualEditor: [Regression wmf13] After editing the caption field of an image, the image highlight gets shifted few pixels right - https://phabricator.wikimedia.org/T85844#972633 (10Jdforrester-WMF) a:3Esanders [01:42:38] (03PS43) 10Mooeypoo: Transform the search widget to show image details [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161342 (https://phabricator.wikimedia.org/T78161) [01:42:42] (03CR) 10jenkins-bot: [V: 04-1] Transform the search widget to show image details [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161342 (https://phabricator.wikimedia.org/T78161) (owner: 10Mooeypoo) [01:45:24] (03CR) 10Esanders: [C: 04-1] Add filename to the media dialog (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/183729 (https://phabricator.wikimedia.org/T54459) (owner: 10Mooeypoo) [01:45:54] (03PS44) 10Mooeypoo: Transform the search widget to show image details [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161342 (https://phabricator.wikimedia.org/T78161) [01:47:23] Krenair: sorry, I completely dropped the ball on https://gerrit.wikimedia.org/r/#/c/130543/ . I'm looking now. [01:47:29] Did you just want me to review it or did you have other questions? [01:47:48] 3UI-Standardization, VisualEditor, VisualEditor-MediaWiki: "Save page" on VisualEditor toolbar should be progressive - https://phabricator.wikimedia.org/T86507#972659 (10Jay8g) I think the colors might help with the issue of the multiple save buttons being confusing ({T44138}), especially if MW-UI standards were... [01:51:08] (03PS1) 10Jforrester: Toolbar: Make save button progressive, not constructive [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/184538 (https://phabricator.wikimedia.org/T86507) [01:51:31] 3UI-Standardization, VisualEditor, VisualEditor-MediaWiki: "Save page" on VisualEditor toolbar should be progressive - https://phabricator.wikimedia.org/T86507#972665 (10Jdforrester-WMF) a:5KHammerstein>3Jdforrester-WMF [01:52:45] 3VisualEditor-ContentEditable, VisualEditor, VisualEditor-ContentLanguage: After selecting table cell by single clicking, typing with any IME does not work - https://phabricator.wikimedia.org/T86589#972667 (10Jdforrester-WMF) p:5Triage>3High [01:54:05] 3VisualEditor, VisualEditor-ContentLanguage: In 2-Set Korean IME when typing inside a table cell and pressing space selection and cursor disappear - https://phabricator.wikimedia.org/T86592#972672 (10Jdforrester-WMF) p:5Triage>3Normal [01:54:55] 3VisualEditor-Tables, VisualEditor: Have a table's columnar controls available even when they're offscreen - https://phabricator.wikimedia.org/T86502#972675 (10Jdforrester-WMF) p:5Triage>3Low [01:56:26] 3VisualEditor-Tables, VisualEditor: Tables: merged cells cannot be un-merged via Table - Un-merge menu - https://phabricator.wikimedia.org/T86610#972679 (10Jdforrester-WMF) 5Open>3declined a:3Jdforrester-WMF I think we're OK with this issue. The alternatives are the confusion of having table cells be magic... [01:59:31] 3Math, VisualEditor, VisualEditor-MediaWiki: Document how to enable the Math plugin for VisualEditor - https://phabricator.wikimedia.org/T86449#972685 (10Jdforrester-WMF) 5Open>3Resolved We're actually fixing this through the new `extension.json` registration scheme, but sorry for the confusion. :-( [02:00:46] 3Math, VisualEditor, VisualEditor-MediaWiki: Adding "[[a]]" to formula inserts wikitext, should instead be flagged as invalid - https://phabricator.wikimedia.org/T86450#972688 (10Jdforrester-WMF) p:5Triage>3Normal [02:05:04] (03PS7) 10Mooeypoo: Add an ActionFieldLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/175568 (https://phabricator.wikimedia.org/T76634) [02:06:04] (03CR) 10Mooeypoo: [C: 04-1] "Trevor wanted to go over this and fix a couple of small css issues." [oojs/ui] - 10https://gerrit.wikimedia.org/r/175568 (https://phabricator.wikimedia.org/T76634) (owner: 10Mooeypoo) [02:10:24] (03PS3) 10Mooeypoo: Add filename to the media dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/183729 (https://phabricator.wikimedia.org/T54459) [02:12:48] (03CR) 10Mooeypoo: Add filename to the media dialog (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/183729 (https://phabricator.wikimedia.org/T54459) (owner: 10Mooeypoo) [02:23:51] (03PS3) 10Jforrester: Move contents of VisualEditor.php to extension.json [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/183524 [02:30:11] (03PS4) 10Mooeypoo: Add filename to the media dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/183729 (https://phabricator.wikimedia.org/T54459) [02:48:56] (03CR) 10GOIII: [C: 031] "Hmmm, that is strange. Good catch." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/184289 (owner: 10Gerrit Patch Uploader) [02:50:27] (03PS2) 10Jforrester: build: Bump copyright notices to 2015 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/183736 [02:52:57] (03CR) 10GOIII: [C: 031] Escape messages [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/184300 (owner: 10Gerrit Patch Uploader) [04:16:43] (03CR) 10Jforrester: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/183524 (owner: 10Jforrester) [04:23:34] (03CR) 10Jforrester: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/183524 (owner: 10Jforrester) [04:27:07] (03CR) 10MarkTraceur: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/183524 (owner: 10Jforrester) [04:30:30] (03CR) 10MarkTraceur: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/183524 (owner: 10Jforrester) [04:30:45] That seems to be working [04:31:54] (03CR) 10Jforrester: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/183736 (owner: 10Jforrester) [04:32:09] (03CR) 10jenkins-bot: [V: 04-1] Move contents of VisualEditor.php to extension.json [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/183524 (owner: 10Jforrester) [04:32:26] (03CR) 10Jforrester: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/183729 (https://phabricator.wikimedia.org/T54459) (owner: 10Mooeypoo) [04:34:28] (03PS2) 10Jforrester: build: Bump copyright notices to 2015 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/183740 [04:34:39] (03CR) 10Jforrester: "PS2 is a rebase." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/183740 (owner: 10Jforrester) [04:35:47] 3UI-Standardization, VisualEditor: Save dialog should use OOJS-UI (MW-UI) checkboxes - https://phabricator.wikimedia.org/T86617#972759 (10Jay8g) 3NEW [04:36:10] (03CR) 10jenkins-bot: [V: 04-1] build: Bump copyright notices to 2015 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/183736 (owner: 10Jforrester) [04:36:26] Yay failures [04:36:29] 3UI-Standardization, VisualEditor: Save dialog should use OOJS-UI (MW-UI) checkboxes - https://phabricator.wikimedia.org/T86617#972765 (10Jdforrester-WMF) Depends on the checkboxes being constructed by VisualEditor rather than the current anti-pattern that MediaWiki requires. [04:36:40] Really? [04:37:09] How on Earth did jshint not object to that file before? [04:37:23] And also, no duh, that's why we're running the test. [04:37:31] 04:36:09 tests/ce/imetests/input-chromium-ubuntu-ibus-japanese-anthy--hiraganaonly.js [04:37:32] 04:36:09 291 | {"seq":281,"time":14.18,"action":"changeText","args":["なまむぎ、なまご���、なまた"]}, [04:37:32] 04:36:09 ^ This character may get silently deleted by one or more browsers. [04:37:34] * James_F sighs. [04:37:50] Another thing for me to take up with Krinkle|detached when he gets in tomorrow. [04:38:38] (03CR) 10Jforrester: "recheck" [oojs/ui] - 10https://gerrit.wikimedia.org/r/175568 (https://phabricator.wikimedia.org/T76634) (owner: 10Mooeypoo) [04:40:23] (03CR) 10Jforrester: [C: 032] Add filename to the media dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/183729 (https://phabricator.wikimedia.org/T54459) (owner: 10Mooeypoo) [04:41:17] (03PS1) 10Jforrester: Update VE core submodule to master (d66b55b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/184544 [05:23:54] hi. [05:29:52] hello [07:16:45] 3VisualEditor-ContentEditable, VisualEditor: [Regression wmf13] After editing the caption field of an image, the image highlight gets shifted few pixels right - https://phabricator.wikimedia.org/T85844#972809 (10Ryasmeen) Verified the fix in Betalabs [07:16:55] 3VisualEditor-ContentEditable, VisualEditor: [Regression wmf13] After editing the caption field of an image, the image highlight gets shifted few pixels right - https://phabricator.wikimedia.org/T85844#972810 (10Ryasmeen) 5Open>3Resolved [09:00:56] hi [09:01:27] I am loosing the dialog box for edit summary by the means, of its activity, is that problem known? [09:03:18] 3VisualEditor: Cannot load VE and switching to edit source mode loads the wikitext editor without any CSS intermittently - https://phabricator.wikimedia.org/T86624#972979 (10Ryasmeen) 3NEW [09:04:55] 3VisualEditor: Cannot load VE and switching to edit source mode loads the wikitext editor without any CSS intermittently - https://phabricator.wikimedia.org/T86624#972979 (10Ryasmeen) After I get such error, sometimes even the Edit-Beta button does not appear for VE. {F28322} [09:07:33] umm, I can reproduce it in the different browser [09:12:05] 3VisualEditor: Deactivation of Editu summary dialog - https://phabricator.wikimedia.org/T86626#972996 (10Juandev) 3NEW [09:14:54] (03PS1) 10Gerrit Patch Uploader: Fix whitespaces for JavaScript and CSS [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/184581 [09:14:57] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/184581 (owner: 10Gerrit Patch Uploader) [09:52:17] (03CR) 10GOIII: "Lines 265 & 266 in jquery.wikiEditor.toolbar.css have identical selectors." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/184581 (owner: 10Gerrit Patch Uploader) [10:14:34] 3VisualEditor: VisualEditor language screenshot scenario for page settings is broken - https://phabricator.wikimedia.org/T86634#973109 (10Amire80) 3NEW a:3Amire80 [10:15:02] (03PS1) 10Amire80: [BrowserTest] Remove the page settings scenario from language screenshots test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/184593 (https://phabricator.wikimedia.org/T86634) [10:15:42] (03CR) 10Zfilipin: [C: 032] [BrowserTest] Remove the page settings scenario from language screenshots test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/184593 (https://phabricator.wikimedia.org/T86634) (owner: 10Amire80) [10:17:51] (03Merged) 10jenkins-bot: [BrowserTest] Remove the page settings scenario from language screenshots test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/184593 (https://phabricator.wikimedia.org/T86634) (owner: 10Amire80) [10:20:03] (03PS4) 10Amire80: [BrowserTest] Change the Heading menu item from a to span [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180139 [10:21:19] (03PS5) 10Amire80: [BrowserTest] Change the Heading menu item from a to span [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180139 [10:22:04] (03CR) 10Zfilipin: [C: 032] [BrowserTest] Change the Heading menu item from a to span [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180139 (owner: 10Amire80) [10:25:33] (03Merged) 10jenkins-bot: [BrowserTest] Change the Heading menu item from a to span [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180139 (owner: 10Amire80) [10:41:22] 3VisualEditor: VisualEditor language screenshots come out with pixelated fonts - https://phabricator.wikimedia.org/T78648#973135 (10Amire80) 5Open>3Resolved [10:56:53] 3VisualEditor-ContentEditable, VisualEditor: Quotation marks should go arround text - https://phabricator.wikimedia.org/T86635#973149 (10Juandev) 3NEW [10:59:52] 3VisualEditor-ContentEditable, VisualEditor: Allow insert non-breakable space - https://phabricator.wikimedia.org/T86636#973156 (10Juandev) 3NEW [11:06:11] 3VisualEditor, VisualEditor-ContentEditable: Allow insert non-breakable space - https://phabricator.wikimedia.org/T86636#973165 (10Juandev) And I guess that other pair characters should work on the same principle, such as: »« (and I dont see others in my special character menu - but if they are...). [11:07:39] (03PS1) 10Amire80: [BrowserTest] Make the Save page element language independent [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/184603 [11:09:42] (03CR) 10Esanders: [C: 04-1] "This has broken a few of the CSS fixes I put in PS39" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161342 (https://phabricator.wikimedia.org/T78161) (owner: 10Mooeypoo) [11:09:59] 3VisualEditor, VisualEditor-ContentEditable: Ad timestamp or signature to main ns - https://phabricator.wikimedia.org/T86013#973166 (10Juandev) So there are no plans to use VE on all types of pages (i.e. namespaces)? It does not look to me logic to provide new and feature editor of main pages and push them to st... [11:13:10] (03CR) 10Zfilipin: [C: 032] [BrowserTest] Make the Save page element language independent [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/184603 (owner: 10Amire80) [11:15:08] (03Merged) 10jenkins-bot: [BrowserTest] Make the Save page element language independent [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/184603 (owner: 10Amire80) [11:57:51] (03CR) 10Esanders: "More inline reviews." (0319 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161342 (https://phabricator.wikimedia.org/T78161) (owner: 10Mooeypoo) [12:33:48] (03PS1) 10Gerrit Patch Uploader: Use "obj.hasOwnProperty( prop )" instead of "prop in obj" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/184619 (https://phabricator.wikimedia.org/T86643) [12:33:54] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/184619 (https://phabricator.wikimedia.org/T86643) (owner: 10Gerrit Patch Uploader) [12:39:00] (03PS1) 10Gerrit Patch Uploader: jquery.wikiEditor.toolbar.css: Use .cell-description stead of .description [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/184621 [12:39:03] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/184621 (owner: 10Gerrit Patch Uploader) [12:39:34] (03CR) 10Fomafix: "I filled this into https://gerrit.wikimedia.org/r/184621" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/184581 (owner: 10Gerrit Patch Uploader) [12:48:20] 3MediaWiki-Page-editing, MediaWiki-API, Wikidata: ApiStashEdit silently loses custom DataUpdates. - https://phabricator.wikimedia.org/T86305#973317 (10daniel) @aaron I'm afraid that patch doesn't address the actual problem: yes, you can get around the serialization update if you rely on global state. But if you... [13:32:09] (03PS2) 10Gerrit Patch Uploader: jquery.wikiEditor.toolbar.css: Remove selectors without prefix "cell-" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/184621 [13:32:12] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/184621 (owner: 10Gerrit Patch Uploader) [13:41:29] 3VisualEditor: Visual editor fails to remove last section - https://phabricator.wikimedia.org/T86649#973408 (10Martijn_Hoekstra) 3NEW [15:24:53] (03CR) 10Esanders: [C: 04-1] "Per the comments on the ticket, I think we should take this opportunity to move the 'Change image' button up to join this." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/183729 (https://phabricator.wikimedia.org/T54459) (owner: 10Mooeypoo) [15:33:22] (03CR) 10Esanders: [C: 032] Toolbar: Make save button progressive, not constructive [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/184538 (https://phabricator.wikimedia.org/T86507) (owner: 10Jforrester) [15:35:48] (03Merged) 10jenkins-bot: Toolbar: Make save button progressive, not constructive [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/184538 (https://phabricator.wikimedia.org/T86507) (owner: 10Jforrester) [15:43:46] 3VisualEditor: Heading of template editor is misaligned, possibly fr.wiki only - https://phabricator.wikimedia.org/T76947#973815 (10Elitre) This just became worse with the new design, IMHO. [15:44:40] (03PS1) 10Esanders: Create separate message for find-and-replace-done [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/184642 (https://phabricator.wikimedia.org/T85852) [15:45:26] (03PS2) 10Esanders: Create separate message for find-and-replace-done [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/184642 (https://phabricator.wikimedia.org/T85852) [15:46:38] 3VisualEditor-EditingTools, VisualEditor: VisualEditor: Documentation for the message Visualeditor-dialog-action-done is misleading - https://phabricator.wikimedia.org/T72281#973819 (10Esanders) I think this is just a copy and paste error from visualeditor-dialog-action-cancel [15:47:14] mvolz, did you get my review? [15:49:22] (03CR) 10jenkins-bot: [V: 04-1] Create separate message for find-and-replace-done [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/184642 (https://phabricator.wikimedia.org/T85852) (owner: 10Esanders) [15:55:06] (03CR) 10Jforrester: [C: 04-1] Create separate message for find-and-replace-done (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/184642 (https://phabricator.wikimedia.org/T85852) (owner: 10Esanders) [16:01:00] (03PS3) 10Jforrester: Create separate message for find-and-replace-done [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/184642 (https://phabricator.wikimedia.org/T85852) (owner: 10Esanders) [16:01:28] (03CR) 10Jforrester: Create separate message for find-and-replace-done (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/184642 (https://phabricator.wikimedia.org/T85852) (owner: 10Esanders) [16:01:34] (03CR) 10Jforrester: [C: 032] Create separate message for find-and-replace-done [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/184642 (https://phabricator.wikimedia.org/T85852) (owner: 10Esanders) [16:02:13] 3VisualEditor-EditingTools, VisualEditor: Documentation for the message Visualeditor-dialog-action-done is misleading - https://phabricator.wikimedia.org/T72281#973836 (10Jdforrester-WMF) p:5Triage>3Normal a:3Esanders [16:02:51] 3VisualEditor: The "Done" button doesn't go well with VisualEditor's Find And Replace bar - https://phabricator.wikimedia.org/T85852#973843 (10Jdforrester-WMF) a:5Jdforrester-WMF>3Esanders [16:06:53] (03Merged) 10jenkins-bot: Create separate message for find-and-replace-done [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/184642 (https://phabricator.wikimedia.org/T85852) (owner: 10Esanders) [16:10:16] (03CR) 10Jforrester: "> Per the comments on the ticket, I think we should take this opportunity to move the 'Change image' button up to join this." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/183729 (https://phabricator.wikimedia.org/T54459) (owner: 10Mooeypoo) [16:14:22] (03CR) 10Esanders: "It depends how you define 'control button'. It makes sense to have it contextual to the data is shows (filename). It's similar to the lang" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/183729 (https://phabricator.wikimedia.org/T54459) (owner: 10Mooeypoo) [16:15:01] edsanders: I'm not saying it's a bad idea, it's just a bigger change than I want to do now. [16:15:43] edsanders: I'd really like to get this landed right now. It's been worked on for four months now. [16:15:57] edsanders: Follow-up commits to do this would be nice. [16:17:30] try merging it again then [16:17:45] the patchset is 5 days old [16:17:55] hi [16:17:56] Its parent isn't, which it was broken out of. [16:18:03] Hey MatmaRex. Want to come to the office? :-) [16:19:19] i'm going to, but i just woke up :) [16:19:23] (03CR) 10Esanders: [C: 032] build: Bump copyright notices to 2015 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/183740 (owner: 10Jforrester) [16:19:25] MatmaRex: Excuses. :-) [16:20:07] (03CR) 10Esanders: [C: 04-1] "oops" (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/183736 (owner: 10Jforrester) [16:20:23] James_F, looks like your IDE sucks at unicode [16:20:41] edsanders: I don't use an IDE. That was awk. [16:20:51] * James_F sighs. [16:21:13] (03CR) 10Esanders: [C: 032] build: Bump copyright notices to 2015 [unicodejs] - 10https://gerrit.wikimedia.org/r/183733 (owner: 10Jforrester) [16:21:49] (03Merged) 10jenkins-bot: build: Bump copyright notices to 2015 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/183740 (owner: 10Jforrester) [16:22:31] (03PS3) 10Jforrester: build: Bump copyright notices to 2015 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/183736 [16:22:45] (03CR) 10Jforrester: build: Bump copyright notices to 2015 (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/183736 (owner: 10Jforrester) [16:23:52] (03Merged) 10jenkins-bot: build: Bump copyright notices to 2015 [unicodejs] - 10https://gerrit.wikimedia.org/r/183733 (owner: 10Jforrester) [16:42:54] (03CR) 10Mvolz: "Re: config," [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/168746 (owner: 10Mvolz) [17:17:09] (03CR) 10Esanders: "JSON is up to date, and all API responses are correct. Not a problem there." [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/168746 (owner: 10Mvolz) [17:30:35] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=110874392 [17:30:35] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=33940852 [17:30:35] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=33941348 [17:30:35] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=67899739 [17:30:35] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=67900576 [17:30:36] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=67900645 [17:30:36] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=67900708 [17:30:37] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=67900872 [17:30:37] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=67904125 [17:31:22] (03CR) 10Jforrester: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/183729 (https://phabricator.wikimedia.org/T54459) (owner: 10Mooeypoo) [17:38:20] 3MediaWiki-API, MediaWiki-Page-editing, Wikidata: ApiStashEdit silently loses custom DataUpdates. - https://phabricator.wikimedia.org/T86305#974014 (10ori) @daniel Can you explain why this work needs to be done synchronously, blocking the user? [18:24:04] 3MediaWiki-API, MediaWiki-Page-editing, Wikidata: ApiStashEdit silently loses custom DataUpdates. - https://phabricator.wikimedia.org/T86305#974085 (10daniel) @ori: simply be cause there is currently no mechanism (as far as I know) for extensions to provide deferred updated. Only some specific hard-coded update... [18:25:02] 3MediaWiki-API, MediaWiki-Page-editing, Wikidata: ApiStashEdit silently loses custom DataUpdates. - https://phabricator.wikimedia.org/T86305#974086 (10ori) @daniel, thanks for clarifying. Could you also explain (in practical terms) what are the updates being performed? [18:29:03] edsanders, I have another question about the media dialog regarding the descriptions. When I create the caption surface, I attach the document to it; if I bring the image from search, the document is already created according to the API content. Putting the issue of long/complicated content aside for a minute -- James_F made the point about obeying paste rules and all that. [18:29:38] edsanders, the document is attached to the surface that has the paste rules included -- do those act on existing documents, or only on added-on content that the user types in? We might need to validate that data further? [18:32:34] 3MediaWiki-API, MediaWiki-Page-editing, Wikidata: ApiStashEdit silently loses custom DataUpdates. - https://phabricator.wikimedia.org/T86305#974114 (10daniel) On the client wiki, we are tracking which page uses which data item, by inserting rows into the wbc_entity_usage table. On the repo, we do similar trackin... [18:46:02] 3UI-Standardization, OOjs-UI: "Front-end Standardization" talk for MediaWiki Developer Summit 2015 - https://phabricator.wikimedia.org/T86072#974125 (10TrevorParscal) [19:06:46] 3VisualEditor: Enable VE in namespace 102 (Article Incubator) in RuWP - https://phabricator.wikimedia.org/T86688#974193 (10Sunpriat) 3NEW [19:08:51] 3VisualEditor: Cannot load VE and switching to edit source mode loads the wikitext editor without any CSS intermittently - https://phabricator.wikimedia.org/T86624#974204 (10Ryasmeen) Screenshot of losing CSS {F28486} [19:09:04] 3VisualEditor-EditingTools, VisualEditor: VisualEditor: [Regression wmf1] When the inspector is still open for a selected node, after placing the cursor in a different position, inspector flickers there - https://phabricator.wikimedia.org/T73151#974205 (10Jdforrester-WMF) I'm now not getting any flickering in Be... [19:10:20] 3VisualEditor, VisualEditor-MediaWiki, Beta-Cluster: On Beta Labs, switching from VisualEditor to edit source mode intermittently loads the wikitext editor without any CSS - https://phabricator.wikimedia.org/T86624#974208 (10Jdforrester-WMF) [19:17:25] 3VisualEditor: Heading of template editor is misaligned, possibly fr.wiki only - https://phabricator.wikimedia.org/T76947#974226 (10Sunpriat) https://www.mediawiki.org/wiki/VisualEditor/Feedback#terrible_title_in_the_form_of_saving_the_page_52517 [19:17:58] (03PS1) 10Bartosz Dziewoński: Don't rely on 'user' and 'site' modules working correctly [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/184708 [19:18:27] 3VisualEditor, VisualEditor-MediaWiki: [Regression pre-wmf15] VE busted on beta labs; caused by I3abecacf - https://phabricator.wikimedia.org/T86550#974232 (10matmarex) Redone in https://gerrit.wikimedia.org/r/184708 [19:18:35] (03CR) 10Bartosz Dziewoński: "Redone in https://gerrit.wikimedia.org/r/184708" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/184397 (https://phabricator.wikimedia.org/T86550) (owner: 10Jforrester) [19:18:55] (03PS2) 10Bartosz Dziewoński: Don't rely on 'user' and 'site' modules working correctly [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/184708 [19:22:00] 3VisualEditor, MediaWiki-Core-Team, VisualEditor-MediaWiki, MediaWiki-Configuration: convertExtensionToRegistration.php does not set defaults for globals, so $wgResourceModules += array(...) and similar cause fatals - https://phabricator.wikimedia.org/T86311#974254 (10Legoktm) 5Open>3Resolved [19:22:38] 3VisualEditor: Difference in rendering - https://phabricator.wikimedia.org/T86691#974257 (10max.nordlund) 3NEW [19:24:05] 3VisualEditor: Difference in rendering - https://phabricator.wikimedia.org/T86691#974257 (10max.nordlund) [19:24:34] 3VisualEditor: Difference in rendering - https://phabricator.wikimedia.org/T86691#974257 (10max.nordlund) [19:27:50] 3VisualEditor: Toolbar and dropdown menu design - https://phabricator.wikimedia.org/T86693#974283 (10KHammerstein) 3NEW [19:27:55] 3VisualEditor, VisualEditor-ContentEditable: Ad timestamp or signature to main ns - https://phabricator.wikimedia.org/T86013#974292 (10matmarex) The plan is to push Flow for talk pages instead, which would presumably use a VisualEditor edit area. [19:28:09] 3VisualEditor: Difference in rendering - https://phabricator.wikimedia.org/T86691#974296 (10Jdforrester-WMF) The page: https://en.wikipedia.org/w/index.php?title=Betti_number&oldid=642342702 … and the page in VisualEditor: https://en.wikipedia.org/w/index.php?title=Betti_number&oldid=642342702&veaction=edit …... [19:28:17] 3VisualEditor: Difference in rendering - https://phabricator.wikimedia.org/T86691#974298 (10Jdforrester-WMF) [19:28:38] 3VisualEditor, VisualEditor-ContentEditable: Ad timestamp or signature to main ns - https://phabricator.wikimedia.org/T86013#974301 (10Jdforrester-WMF) Yes. [19:30:32] (03CR) 10Jforrester: "What's done different here that stops this patch from causing VE not to work? ;-)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/184708 (owner: 10Bartosz Dziewoński) [19:31:03] (03CR) 10Bartosz Dziewoński: "I no longer use the wrong 'this'. But please test :)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/184708 (owner: 10Bartosz Dziewoński) [19:31:15] :-) [19:34:36] James_F: https://gerrit.wikimedia.org/r/184712 [19:34:56] legoktm: You're brilliant. [19:42:53] James_F: 'Save page' button is of green/blue in beta, but always green in test - a bug or a new design? [19:44:33] I meant - always green in test2 [19:46:47] etonkovidova: New design. [19:47:02] understood [19:47:49] looks interesting... [19:53:58] 3VisualEditor: Visual editor fails to remove last section - https://phabricator.wikimedia.org/T86649#974373 (10matmarex) [19:53:59] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Deletion across a header caused it to remain without WS, leading Parsoid to output "====" - https://phabricator.wikimedia.org/T52100#974374 (10matmarex) [20:00:56] 3MediaWiki-Page-editing: Live preview does not update page status indicators - https://phabricator.wikimedia.org/T86697#974387 (10Ricordisamoa) 3NEW [20:01:17] 3VisualEditor, OOjs-UI, VisualEditor-MediaWiki: VisualEditor: saveOptions.summary is not updated if the summary is inserted using a tool (InputWidget relies on 'change' events rather than checking the value) - https://phabricator.wikimedia.org/T71749#974393 (10matmarex) Documented how/where? I'd be happy to if y... [20:04:50] 3VisualEditor: Difference in rendering - https://phabricator.wikimedia.org/T86691#974396 (10max.nordlund) In the editor it is shown as a `↵` character, and I assume it is a hard line break, which I changed into a regular line break. The next edit uses two line breaks, which fixes the formatting issue. However in... [20:06:25] 3VisualEditor: Difference in rendering - https://phabricator.wikimedia.org/T86691#974398 (10Jdforrester-WMF) Aha, that's {T50290}. [20:06:34] 3VisualEditor: Difference in rendering - https://phabricator.wikimedia.org/T86691#974400 (10Jdforrester-WMF) [20:06:37] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: ↵ is shown when wikicode contains single newline, which is not very WYSIWYG - https://phabricator.wikimedia.org/T50290#499280 (10Jdforrester-WMF) [20:07:54] [undefined] Missing or empty schema" load.php:36 [20:07:54] load.php:36 [20:07:54] mw.trackSubscribe/<() load.php:154 [20:07:56] jQuery.Callbacks/fire() load.php:45 [20:07:58] 3VisualEditor, Wikimedia-Site-requests, VisualEditor-MediaWiki: Enable VE in namespace 102 (Article Incubator) in RuWP - https://phabricator.wikimedia.org/T86688#974409 (10Jdforrester-WMF) p:5Triage>3Normal a:3Jdforrester-WMF [20:08:16] test2 shows a lot of that Missing or empty schema [20:08:26] should we be concerned? [20:08:34] Hmm. It's irritating. [20:08:38] exactly [20:08:41] Also, it shouldn't be missing on test2. [20:08:47] true too [20:14:56] 3VisualEditor, Wikimedia-Site-requests, VisualEditor-MediaWiki: Enable VE in namespace 102 (Article Incubator) in RuWP - https://phabricator.wikimedia.org/T86688#974429 (10Jdforrester-WMF) Scheduled for deployment in 4 hours' time (16:00 deployment slot). [20:18:35] 3VisualEditor: Difference in rendering - https://phabricator.wikimedia.org/T86691#974438 (10max.nordlund) Hm, kinda right, but then there is the issue of the justified text which doesn't seam to be related to `↵`. [20:19:26] 3VisualEditor: Difference in rendering - https://phabricator.wikimedia.org/T86691#974440 (10max.nordlund) 5duplicate>3Open [20:23:05] 3VisualEditor: Difference in rendering - https://phabricator.wikimedia.org/T86691#974445 (10Jdforrester-WMF) Again, please provide a screenshot. There is no justified text in read or VisualEditor mode for me. [20:32:30] 3VisualEditor: Difference in rendering - https://phabricator.wikimedia.org/T86691#974473 (10max.nordlund) See before and after screenshots above. [20:33:52] 3VisualEditor, VisualEditor-ContentEditable: An image inserted to table cell, break the table - https://phabricator.wikimedia.org/T86501#974480 (10matmarex) I can't reproduce this, but instead I found T86703. [20:34:26] 3VisualEditor, VisualEditor-Tables: Can't place cursor in empty table cells at https://cs.wikipedia.org/wiki/Seznam_židovských_památek_ve_Středočeském_kraji?veaction=edit - https://phabricator.wikimedia.org/T86703#974474 (10matmarex) [20:34:31] 3VisualEditor: Difference in rendering - https://phabricator.wikimedia.org/T86691#974484 (10Jdforrester-WMF) It looks like you have some funky CSS in your user account. This doesn't occur in Chrome, Firefox or Safari for me when logged out or logged in. [20:39:35] 3VisualEditor, OOjs-UI, VisualEditor-MediaWiki: VisualEditor: saveOptions.summary is not updated if the summary is inserted using a tool (InputWidget relies on 'change' events rather than checking the value) - https://phabricator.wikimedia.org/T71749#974492 (10eranroz) Sync of the value to the DOM can be done in... [20:41:43] edsanders|away: Sanity check re. merging https://gerrit.wikimedia.org/r/#/c/172972/ is still advisable [20:41:44] ? [20:44:51] 3VisualEditor: Difference in rendering - https://phabricator.wikimedia.org/T86691#974497 (10max.nordlund) I havn't added any custom CSS/JS, but I do use the "Vector" theme, is that the cause? [20:45:36] 3VisualEditor: Difference in rendering - https://phabricator.wikimedia.org/T86691#974498 (10Jdforrester-WMF) No, Vector is the normal theme. This is very perplexing. [20:46:01] 3VisualEditor: Difference in rendering - https://phabricator.wikimedia.org/T86691#974499 (10max.nordlund) On a related not, is it possible to get uncompressed CSS? I just have this huge pile in a style element which dosen't tell me where it's from. [20:51:33] 3VisualEditor, Wikimedia-Site-requests, VisualEditor-MediaWiki: Enable VE in namespace 102 (Article Incubator) in RuWP - https://phabricator.wikimedia.org/T86688#974514 (10Jdforrester-WMF) 5Open>3Resolved [20:52:37] 3VisualEditor: Difference in rendering - https://phabricator.wikimedia.org/T86691#974516 (10max.nordlund) I found it, I had checked the "Justify Paragraphs" option. It behaves strangely though. This is clearly not a VE issue anymore, but I don't know were it belongs, do you? [20:55:01] 3VisualEditor: Difference in rendering - https://phabricator.wikimedia.org/T86691#974520 (10Jdforrester-WMF) 5Open>3declined a:3Jdforrester-WMF Ah, that would explain it, that's a community gadget. Per community request, those are not meant to be discussed on Phabricator but only on-wiki. The "right" place... [20:59:04] (03CR) 10GOIII: [C: 04-1] "I defer to the "original" designer when it comes to selectors not in use at any given moment so I'm uncomfortable supporting their removal" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/184621 (owner: 10Gerrit Patch Uploader) [21:02:23] (03CR) 10GOIII: [C: 031] "Thanks." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/184581 (owner: 10Gerrit Patch Uploader) [21:04:46] (03CR) 10GOIII: [C: 031] Use "obj.hasOwnProperty( prop )" instead of "prop in obj" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/184619 (https://phabricator.wikimedia.org/T86643) (owner: 10Gerrit Patch Uploader) [21:28:37] hmm: https://fr.wikipedia.org/?diff=110874392 [21:29:27] VE edit, but stuff getting through [21:42:26] 3VisualEditor: Link to doc when template subst - https://phabricator.wikimedia.org/T86705#974606 (10Sunpriat) 3NEW [21:42:55] 3VisualEditor, VisualEditor-MediaWiki: VisualEditor not loading from edit button unless page is refreshed - https://phabricator.wikimedia.org/T86112#974613 (10Negative24) Should this be kept as a bug for EventLogging (and would need to be reassigned to a different project) or be closed as a wontfix? [21:48:45] (03CR) 10TheDJ: [C: 032] Fix whitespaces for JavaScript and CSS [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/184581 (owner: 10Gerrit Patch Uploader) [21:48:51] (03Merged) 10jenkins-bot: Fix whitespaces for JavaScript and CSS [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/184581 (owner: 10Gerrit Patch Uploader) [22:00:23] 3VisualEditor: When invalid input is added to link inspector search open link opens last valid query rather than disabling - https://phabricator.wikimedia.org/T86709#974651 (10Jaredzimmerman-WMF) 3NEW [22:02:32] 3VisualEditor: Done button should be disabled when no text is in link inspector search field - https://phabricator.wikimedia.org/T86710#974661 (10Jaredzimmerman-WMF) 3NEW [22:13:38] (03CR) 10Fomafix: "The classes were never used in the current history on the JavaScript code. Maybe they get imported from a former project. They seams to be" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/184621 (owner: 10Gerrit Patch Uploader) [22:14:30] (03PS1) 10Cmcmahon: [BrowserTest] update Cite test for new Journal fields [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/184785 [22:16:32] (03CR) 10Cmcmahon: [C: 032] "Pairing with Rumanna, she would have merged this but her laptop is broken." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/184785 (owner: 10Cmcmahon) [22:20:11] (03CR) 10GOIII: [C: 031] "I'll have to defer to your judgment as you're one of the few actively addressing WikiEditor issues (as an aside; please take a look at T33" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/184621 (owner: 10Gerrit Patch Uploader) [22:28:39] (03PS1) 10Cmcmahon: [BrowserTest] WIP: add test for missing parameter error msg [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/184788 [22:29:14] https://phabricator.wikimedia.org/T86705#974606 feels dupey [22:33:26] James_F|Away would know [22:34:08] 3VisualEditor: Narrow search templates - https://phabricator.wikimedia.org/T86713#974724 (10Sunpriat) 3NEW [22:53:33] (03PS2) 10Cmcmahon: [BrowserTest] add test for missing parameter error msg [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/184788 [22:58:52] ori, hey, around? [22:59:01] Krenair: hey [22:59:13] looks like you replied after I went to bed [22:59:27] so https://gerrit.wikimedia.org/r/#/c/130543/ [22:59:42] I was wondering how much help I can really be here... [23:00:16] Krinkle: https://gerrit.wikimedia.org/r/#/c/184563/4..5/resources/src/mediawiki/mediawiki.js [23:00:18] (considering I haven't actually touched EventLogging before, I don't imagine it being too difficult to deal with though) [23:00:41] ah but you want this moved to ProfilerSimpleUDP? [23:01:50] Krenair: no, I think the code itself is OK. It's referencing two schema that don't actually exist, so I think the only thing that needs to be done is for the schema to be created. I do think it should be one schema (the current code has it as two). [23:02:30] the name can be 'ParsoidPerformance' and it can have two fields: 'metric' & 'duration' [23:03:11] also, efLogServerSideEvent is gone; that is the old API. It should be EventLogging::logEvent, and if you want to make it safe for environments that don't have EventLogging installed you'll need to enclose it in a class_exists( 'EventLogging' ) [23:03:21] actually considering we want to measure parsoid performance - gwicke, what about putting this into parsoidvirtualrestservice somehow? [23:03:39] making core depend on extensions is a no-no [23:03:57] I know, but you suggested ProfilerSimpleUDP before [23:03:58] but perhaps having hooks pre-/post- requests for the REST client would be good [23:12:30] ori, I reckon this is the kind of thing parsoidvirtualrestservice was added for - we'd like to measure all requests against parsoid, not just ve's ones [23:12:45] so: hooks! :) [23:12:47] it provides a lot of the logic to make parsoid requests in one central place [23:13:07] onBeforeRESTRequest :P [23:15:59] Krenair: restbase measures all requests to parsoid [23:16:31] it also measures all requests against itself, but not including the network latency [23:16:39] ori, ^ [23:17:09] but VisualEditor is not using it right now, right? [23:17:22] not yet, but the plan is to switch asap [23:17:31] when's asap? [23:17:45] likely next month [23:18:01] if things work out in ops then we should have machines by early Feb [23:18:58] in restbase we have fairly generic path-based statsd monitoring [23:19:11] see the restbase hierarchy in graphite [23:19:21] we could add something similar in VRS for good measure [23:20:33] I always thought that our varnishes should have instrumentation, but that never happened [23:21:06] I'll file a task for that; it's eminently doable [23:21:16] in the meantime, having pre-/post- request hooks seems like a good idea [23:22:16] VRS is built around those [23:22:35] you get your hand on each request before it goes out, and on each response as it comes back in [23:22:51] with the option of launching new requests from the response [23:29:11] (03PS4) 10Jforrester: Move contents of VisualEditor.php to extension.json [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/183524 [23:30:33] (03CR) 10jenkins-bot: [V: 04-1] Move contents of VisualEditor.php to extension.json [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/183524 (owner: 10Jforrester) [23:39:14] (03PS1) 10Bartosz Dziewoński: Toolbar: Update #initialize docs [oojs/ui] - 10https://gerrit.wikimedia.org/r/184808 [23:53:47] James_F, Calendar tab becomes unresponsive when I decline your invitation to the 01:30-02:00 stand-up... :) [23:54:02] Oh it's let me do it now. [23:54:04] Krenair: Then clearly you shouldn't. :-) [23:55:00] James_F, does https://phabricator.wikimedia.org/T86705 seem like a dupe to you? [23:55:40] Krenair: Yeah, not sure which though.