[00:03:33] (03CR) 10Cmcmahon: "merging" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/184785 (owner: 10Cmcmahon) [00:03:47] (03CR) 10Cmcmahon: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/184785 (owner: 10Cmcmahon) [00:12:36] 3MediaWiki-ResourceLoader: mw.loader.store should not occupy all of localStorage - https://phabricator.wikimedia.org/T66721#974890 (10Mattflaschen) >>! In T66721#946527, @Technical13 wrote: > Apparently I had 1,772,879 characters in localStorage on test.wikipedia.org. Since this is so large, I've been unable to... [00:16:39] (03PS3) 10TheDJ: jquery.wikiEditor.toolbar.css: Remove selectors without prefix "cell-" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/184621 (owner: 10Gerrit Patch Uploader) [00:16:55] (03CR) 10TheDJ: [C: 032] jquery.wikiEditor.toolbar.css: Remove selectors without prefix "cell-" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/184621 (owner: 10Gerrit Patch Uploader) [00:16:58] (03Merged) 10jenkins-bot: jquery.wikiEditor.toolbar.css: Remove selectors without prefix "cell-" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/184621 (owner: 10Gerrit Patch Uploader) [00:17:47] 3UI-Standardization, OOjs-UI: Get OOUI PHP to be good to go - https://phabricator.wikimedia.org/T74713#974916 (10matmarex) I tihnk this should be closed, or we should define what 'good to do' means here. [00:25:49] 3OOjs-UI, UI-Standardization: Get OOUI PHP to be good to go - https://phabricator.wikimedia.org/T74713#974929 (10Jdforrester-WMF) I was going to add "HTMLForm uses OOjs UI PHP" as a dependent task… [00:32:04] (03CR) 10Jforrester: [C: 031] Toolbar: Update #initialize docs [oojs/ui] - 10https://gerrit.wikimedia.org/r/184808 (owner: 10Bartosz Dziewoński) [00:38:14] 3MediaWiki-ResourceLoader: mw.loader.store should not occupy all of localStorage - https://phabricator.wikimedia.org/T66721#974945 (10Mattflaschen) @Ori plans to look into IndexedDB (which has very different quota rules) as a solution. [00:40:09] 3VisualEditor-Tables, VisualEditor: Table: text in Bullet lists in Caption should not be centered - https://phabricator.wikimedia.org/T86725#974947 (10Etonkovidova) 3NEW [00:41:19] 3VisualEditor-MediaWiki-Templates, VisualEditor: Link to doc when template subst - https://phabricator.wikimedia.org/T86705#974956 (10Krenair) [00:47:22] (03CR) 10Cmcmahon: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/184785 (owner: 10Cmcmahon) [00:51:31] 3VisualEditor: Done button should be disabled when no text is in link inspector search field - https://phabricator.wikimedia.org/T86710#974981 (10Krenair) I looked into using the existing logic we have to disable the 'open' button here for the 'done' button - but it seems that has some issues (i.e. blocks extern... [00:53:45] 3VisualEditor-MediaWiki-Mobile, VisualEditor: VisualEditor Mobile: [Regression pre-wmf10] Dependency on jquery.uls.data not met for mobile so VE does not appear, spins forever - https://phabricator.wikimedia.org/T68594#974993 (10bmansurov) 5Resolved>3Open [00:54:22] 3VisualEditor-MediaWiki-Mobile, VisualEditor: VisualEditor Mobile: [Regression pre-wmf10] Dependency on jquery.uls.data not met for mobile so VE does not appear, spins forever - https://phabricator.wikimedia.org/T68594#715073 (10bmansurov) This is happening to me. I have latest code from master. [01:03:08] (03CR) 10Trevor Parscal: [C: 032] Update VE core submodule to master (d66b55b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/184544 (owner: 10Jforrester) [01:06:10] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (d66b55b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/184544 (owner: 10Jforrester) [01:06:12] (03CR) 10Trevor Parscal: [C: 04-1] Mark interwiki links as known in LinkTargetInputWidget (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/182988 (https://phabricator.wikimedia.org/T72504) (owner: 10Alex Monk) [01:06:33] (03PS4) 10Trevor Parscal: Combine imageinfo requests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180228 (https://phabricator.wikimedia.org/T75822) (owner: 10Alex Monk) [01:08:47] (03CR) 10jenkins-bot: [V: 04-1] Combine imageinfo requests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180228 (https://phabricator.wikimedia.org/T75822) (owner: 10Alex Monk) [01:10:05] 3OOjs-UI: No demo for LookupInputWidget - https://phabricator.wikimedia.org/T85467#975019 (10matmarex) LookupInputWidget is just really messed up. Let's unbreak it, then I'll put some pretty examples somewhere. [01:10:30] (03CR) 10Trevor Parscal: [C: 04-1] "Could we generalize the LinkCache class to ApiCache and either configure instances of it or extend it to server link and imageinfo purpose" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180228 (https://phabricator.wikimedia.org/T75822) (owner: 10Alex Monk) [01:12:38] (03CR) 10Trevor Parscal: [C: 031] "Don't have time to test." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/182336 (https://phabricator.wikimedia.org/T78694) (owner: 10Alex Monk) [01:14:55] (03CR) 10Alex Monk: Mark interwiki links as known in LinkTargetInputWidget (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/182988 (https://phabricator.wikimedia.org/T72504) (owner: 10Alex Monk) [01:15:31] (03PS1) 10Bartosz Dziewoński: [BREAKING CHANGE] LookupInputWidget: Remove the silly 'input' parameter [oojs/ui] - 10https://gerrit.wikimedia.org/r/184828 (https://phabricator.wikimedia.org/T85467) [01:16:22] (03CR) 10Jforrester: [C: 032] [BREAKING CHANGE] LookupInputWidget: Remove the silly 'input' parameter [oojs/ui] - 10https://gerrit.wikimedia.org/r/184828 (https://phabricator.wikimedia.org/T85467) (owner: 10Bartosz Dziewoński) [01:16:30] (03PS1) 10Bartosz Dziewoński: Update for I33c818a2 in OOUI [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/184829 [01:16:34] :o [01:17:17] 01:08:46 >> TypeError: 'undefined' is not an object (evaluating 've.init.platform.imageInfoQueue.get') [01:17:58] when TrevorParscal edited the commit message of https://gerrit.wikimedia.org/r/#/c/180228/ [01:18:37] Krenair: Did we remove that? [01:18:42] do I need to do something separate in tests now? [01:18:57] (03CR) 10jenkins-bot: [V: 04-1] Update for I33c818a2 in OOUI [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/184829 (owner: 10Bartosz Dziewoński) [01:19:01] James_F, no I'm trying to add it [01:19:23] Krenair: Oh, are you using mw.Map or something we just changed in MW-core? [01:19:48] I don't think so... [01:19:58] Hmm. Odd. [01:22:06] well... that test fails on my local install so it's not just jenkins being silly [01:22:44] (03Merged) 10jenkins-bot: [BREAKING CHANGE] LookupInputWidget: Remove the silly 'input' parameter [oojs/ui] - 10https://gerrit.wikimedia.org/r/184828 (https://phabricator.wikimedia.org/T85467) (owner: 10Bartosz Dziewoński) [01:24:24] But it works in normal usage, as far as I can tell... [01:28:35] Krinkle, any ideas whats going wrong there? [01:49:47] ok, got a more useful error from running it locally [01:50:03] Actually useful or just theoretically useful? :-) [01:51:05] (03PS5) 10Alex Monk: Combine imageinfo requests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180228 (https://phabricator.wikimedia.org/T75822) [01:52:16] It says get was undefined and the line number. Then I looked at the line and realised why. [01:52:47] Looking at the code again, I probably shouldn't have needed that. Maybe "it showed a nicer-looking error"? :P [01:53:14] (03CR) 10Alex Monk: [C: 04-1] "Trevor's -1 still applies" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180228 (https://phabricator.wikimedia.org/T75822) (owner: 10Alex Monk) [01:56:34] Krenair: That error is typically caused by code using singletons in the global scope before the singleton is created. [01:56:57] Are you using it to compute the value of a static property? [01:57:17] (regarding ve.init.platform.*) [01:57:26] (it was https://gerrit.wikimedia.org/r/#/c/180228/4..5/modules/ve-mw/dm/nodes/ve.dm.MWImageNode.js ) [02:01:01] Krenair: Yeah, platform is asynchronously initialised. [02:01:08] That's likely the cause [02:03:45] 3OOjs-UI: No demo for LookupInputWidget - https://phabricator.wikimedia.org/T85467#975078 (10matmarex) The patch above isn't really relevant, but it fixes the greatest source of confusion with LookupInputWidget – the fact that you need to pass the input to the constructor (`OO.ui.LookupInputWidget.call( this, th... [02:03:53] (03PS45) 10Mooeypoo: Transform the search widget to show image details [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161342 (https://phabricator.wikimedia.org/T78161) [02:06:51] (03CR) 10Jforrester: [C: 032] "Bzzt, try again, Jenkins." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/184544 (owner: 10Jforrester) [02:07:32] mooeypoo: Can I steal a +2 on https://gerrit.wikimedia.org/r/#/c/183736/ so it's done? :-) [02:07:38] 3VisualEditor-EditingTools, VisualEditor: VisualEditor: Some dialogs are showing with transparent backgrounds in IE11 - https://phabricator.wikimedia.org/T74643#975082 (10Krenair) Cannot reproduce on beta with IE11... @Etonkovidova, is this still an issue for you? [02:08:29] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (d66b55b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/184544 (owner: 10Jforrester) [02:08:50] 3VisualEditor-MediaWiki-Mobile, VisualEditor: [Regression wmf16] Cannot scroll the link suggestions inside link inspector in iOS Safari - https://phabricator.wikimedia.org/T71038#975084 (10Krenair) [02:08:53] James_F: I got you :P [02:09:16] (03CR) 10Mooeypoo: [C: 032] "I checked, and we are in fact in 2015." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/183736 (owner: 10Jforrester) [02:09:20] (03PS2) 10Ori.livneh: Update VE core submodule to master (d66b55b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/184544 (owner: 10Jforrester) [02:09:36] ori: It looks like it's a zuul-cloner issue? [02:09:39] yeah [02:10:02] Fun. :-) [02:10:07] i don't have +2 in the VE repo?! [02:10:15] ori: You don't? Oh, VE-core? [02:10:15] i'll grant myself the right if you don't mind [02:10:20] I'll do it. [02:10:41] too late [02:10:52] Done. [02:10:58] https://gerrit.wikimedia.org/r/#/admin/groups/658,members [02:11:03] (03Merged) 10jenkins-bot: build: Bump copyright notices to 2015 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/183736 (owner: 10Jforrester) [02:11:19] still can't override jenkins [02:11:26] No, that's intentional. [02:11:26] are manual verifieds disable? [02:11:28] *d [02:11:31] Eventually all repos will be this way. [02:11:33] Yeah. [02:11:55] We trust CI more than angsty coders who are 'sure' it works. :-) [02:12:04] Though Krinkle works hard to disabuse our trust. ;-) [02:12:07] "Eventually" meaning "after Jenkins stops regularly breaking", which is crucial [02:12:12] Fair. [02:12:27] We have the ability to disable the restriction if we need to do so. [02:12:44] the rebase test run worked, so perhaps the gate-and-submit will, too. [02:12:53] Probably. :-) [02:13:04] I have trouble trusting Jenkins sometimes... [02:13:32] James_F: so the button is still there, it's just really small and easy to miss? :) [02:13:43] and you have to press it really, really hard, of course. [02:13:44] ori: Pretty much. ;-) [02:13:53] to show that you mean it. [02:15:08] https://gerrit.wikimedia.org/r/#/c/184544/ passed now because it re-ran on a different slave. It'll break again when it runs on integration-slave1006 [02:15:17] Krinkle: Fun. [02:15:29] Because zuul-cloner is shit. [02:18:10] When I press the discard/keep buttons to switch to source editing the other buttons looks weird while it's loading the next page [02:24:37] (03PS3) 10Jforrester: Update VE core submodule to master (65dcbaf) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/184544 [02:25:34] (03PS4) 10Jforrester: Update VE core submodule to master (65dcbaf) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/184544 [02:32:32] 3VisualEditor, VisualEditor-MediaWiki: VisualEditor: Save page dialog's edit summary text box is black in Internet Explorer 11 - https://phabricator.wikimedia.org/T74917#975105 (10Krenair) So I can't reproduce this in IE11 but I assume that's because we auto-focus this now? What shall we do about this task? [02:32:54] 3MediaWiki-Interface, Services, RESTBase, Parsoid, MediaWiki-General-or-Unknown, VisualEditor: Use Parsoid HTML for read-only views too - https://phabricator.wikimedia.org/T55784#975106 (10Jdforrester-WMF) [02:33:33] 3VisualEditor, VisualEditor-Performance: Attempt to optimize / profile VisualEditor's existing load code flow to see what is actually slow? - https://phabricator.wikimedia.org/T86732#975114 (10Jdforrester-WMF) 3NEW [02:34:26] 3VisualEditor, VisualEditor-MediaWiki: VisualEditor: Save page dialog's edit summary text box is black in Internet Explorer 11 - https://phabricator.wikimedia.org/T74917#975122 (10Jdforrester-WMF) Is it black if we don't focus? If so, what other dialogs are affected by this IE bug? [02:35:18] 3Parsoid, VisualEditor, VisualEditor-Performance: Measure how often Parsoid cache misses happen, and what load performance is like in this case - https://phabricator.wikimedia.org/T86733#975123 (10Jdforrester-WMF) 3NEW [02:37:15] (03PS8) 10Bartosz Dziewoński: Add an ActionFieldLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/175568 (https://phabricator.wikimedia.org/T76634) (owner: 10Mooeypoo) [02:37:31] (03CR) 10Bartosz Dziewoński: [C: 032] Update VE core submodule to master (65dcbaf) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/184544 (owner: 10Jforrester) [02:38:19] (03CR) 10Bartosz Dziewoński: [C: 031] "Tweaked the styles." [oojs/ui] - 10https://gerrit.wikimedia.org/r/175568 (https://phabricator.wikimedia.org/T76634) (owner: 10Mooeypoo) [02:39:33] (03Merged) 10jenkins-bot: Update VE core submodule to master (65dcbaf) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/184544 (owner: 10Jforrester) [02:40:19] 3MediaWiki-ResourceLoader: Debug mode causes different rendering of CSS in IE9 - https://phabricator.wikimedia.org/T52830#975138 (10Mattflaschen) >>! In T52830#955117, @Krinkle wrote: > Does the desired rendering happening in debug mode or in production mode? According to {T52516}, the correct rendering happens... [02:43:27] 3VisualEditor, VisualEditor-MediaWiki: VisualEditor: Save page dialog's edit summary text box is black in Internet Explorer 11 - https://phabricator.wikimedia.org/T74917#975141 (10Krenair) Well you said: > When clicked in it - it becomes white. So I assume you focusing it was just hiding the problem, and we now... [02:51:20] 3VisualEditor-DataModel, VisualEditor: VisualEditor: References created by templates numbered alone, not with the rest of the page, and don't show up as references to insert - https://phabricator.wikimedia.org/T52474#975146 (10coldchrist) It doesn't seem to have been mentioned above that this bug can cause the l... [03:54:17] is parsoid code meant to have spaces inside brackets, like MW? [03:54:33] guess I should ask in #mediawiki-parsoid [04:12:15] TimStarling: we are following the most common nodejs style [04:12:41] four spaces, no spaces inside parens or brackets [04:14:39] 3OOjs-UI: No demo for LookupInputWidget - https://phabricator.wikimedia.org/T85467#975188 (10Ricordisamoa) >>! In T85467#975078, @matmarex wrote: > The patch above isn't really relevant, but it fixes the greatest source of confusion with LookupInputWidget – the fact that you need to pass the input to the constru... [07:14:44] (03PS1) 10Gerrit Patch Uploader: Fix whitespaces in JavaScript [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/184840 [07:14:47] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/184840 (owner: 10Gerrit Patch Uploader) [07:21:22] 3VisualEditor: localization parameters insert images - https://phabricator.wikimedia.org/T86740#975304 (10Sunpriat) 3NEW [07:51:25] (03CR) 10GOIII: [C: 031] Fix whitespaces in JavaScript [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/184840 (owner: 10Gerrit Patch Uploader) [07:51:28] (03PS1) 10Gerrit Patch Uploader: Move style from JavaScript to CSS [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/184846 [07:51:31] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/184846 (owner: 10Gerrit Patch Uploader) [07:57:44] (03CR) 10GOIII: [C: 031] Move style from JavaScript to CSS [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/184846 (owner: 10Gerrit Patch Uploader) [08:11:46] 3VisualEditor: Shift- in VisualEditor deletes selected text. - https://phabricator.wikimedia.org/T86742#975328 (10awight) 3NEW [09:45:56] (03PS1) 10Gerrit Patch Uploader: Prevent line wrapping for link syntax help column [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/184860 (https://phabricator.wikimedia.org/T33649) [09:45:59] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/184860 (https://phabricator.wikimedia.org/T33649) (owner: 10Gerrit Patch Uploader) [09:57:38] 3Multimedia, MediaWiki-extensions-Sentry, MediaWiki-ResourceLoader: Create ResourceLoader hook to add new startup modules - https://phabricator.wikimedia.org/T85262#975453 (10Tgr) >>! In T85262#960660, @Tgr wrote: > But after looking at the error logging code in raven.js, it's a bit more involved than I have tho... [10:26:56] (03PS1) 10Gerrit Patch Uploader: Use font-family: monospace, Courier [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/184868 [10:26:59] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/184868 (owner: 10Gerrit Patch Uploader) [11:00:17] 3OOjs-UI, UI-Standardization: "Front-end Standardization" talk for MediaWiki Developer Summit 2015 - https://phabricator.wikimedia.org/T86072#975556 (10Qgil) [11:00:21] 3Editing, VisualEditor: "Future of Editing" session at 2015 MediaWiki Developer Summit - https://phabricator.wikimedia.org/T85152#975560 (10Qgil) [11:57:39] (03CR) 10Esanders: "Almost there." (039 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161342 (https://phabricator.wikimedia.org/T78161) (owner: 10Mooeypoo) [15:41:49] (03CR) 10Cmcmahon: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/184785 (owner: 10Cmcmahon) [15:59:29] Heya. [16:00:11] hi James_F do you know why this patch won't merge? Sorry for the self-+2, Rummana would have done it but her laptop is in the shop https://gerrit.wikimedia.org/r/#/c/184785/ [16:00:59] chrismcmahon: The CI system's been breaking from time to time. I'll +2. [16:01:11] (03CR) 10Jforrester: [C: 032] "C'mon Jenkins." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/184785 (owner: 10Cmcmahon) [16:02:45] James_F: it's odd. the change gets picked up but the merge never happens. I think I rechecked twice [16:03:00] chrismcmahon: Welcome to Jenkins land. :-( [16:03:04] (03Merged) 10jenkins-bot: [BrowserTest] update Cite test for new Journal fields [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/184785 (owner: 10Cmcmahon) [16:03:18] yay [16:03:24] now for the second patch... [16:03:42] https://gerrit.wikimedia.org/r/#/c/184788/ ? [16:04:06] (03CR) 10Cmcmahon: [C: 032] "Paired with Rummana for this test." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/184788 (owner: 10Cmcmahon) [16:04:14] (03PS3) 10Jforrester: [BrowserTest] Add test for missing parameter error msg [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/184788 (owner: 10Cmcmahon) [16:04:16] Oh, whoops. Sorry! [16:04:28] That +2 should still go through. [16:05:20] chrismcmahon: Also, should https://gerrit.wikimedia.org/r/#/c/122400/ be abandoned? It was started 10 months ago… [16:05:57] (03CR) 10jenkins-bot: [V: 04-1] [BrowserTest] Add test for missing parameter error msg [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/184788 (owner: 10Cmcmahon) [16:06:17] …or not. [16:06:26] Eurgh, zuul.cloner again. [16:06:57] (03CR) 10Jforrester: [C: 032] "Try again." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/184788 (owner: 10Cmcmahon) [16:10:53] James_F: I don't know what https://gerrit.wikimedia.org/r/#/c/122400/ is. It was started by a volunteer. I doubt it would rebase today. I'll ask Zeljko when he's around (he is traveling to the US right about now) [16:11:06] Sure. [16:14:44] (03Merged) 10jenkins-bot: [BrowserTest] Add test for missing parameter error msg [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/184788 (owner: 10Cmcmahon) [16:15:41] (03CR) 10Umherirrender: [C: 031] Fix whitespaces in JavaScript [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/184840 (owner: 10Gerrit Patch Uploader) [16:30:34] 3OOjs-UI: MediaWiki theme: Checkboxes and radios look oversized on desktop - https://phabricator.wikimedia.org/T86003#976175 (10Esanders) If you're saying the input should be twice the size of the font size then I think we are in agreement. The base font size we've designed oo-ui against is 0.8em though, so we s... [16:52:41] 3OOjs-UI: MediaWiki theme: Checkboxes and radios look oversized on desktop - https://phabricator.wikimedia.org/T86003#976273 (10Esanders) Actually what I just said is incorrect. The 2em size we had set before was relative to a base font size of 0.8em, so in the first screenshot the controls are indeed twice the... [17:01:45] (03CR) 10Mooeypoo: "The description doesn't show an icon and doesn't need a padding, but I can just make that one the exception." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161342 (https://phabricator.wikimedia.org/T78161) (owner: 10Mooeypoo) [17:12:32] (03CR) 10Esanders: Transform the search widget to show image details (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161342 (https://phabricator.wikimedia.org/T78161) (owner: 10Mooeypoo) [17:23:12] 3UI-Standardization, OOjs-UI: "Front-end Standardization" talk for MediaWiki Developer Summit 2015 - https://phabricator.wikimedia.org/T86072#976407 (10Quiddity) [17:30:41] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=110920986 [17:30:41] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=33942906 [17:30:41] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=67915543 [17:30:41] Corruption alert: visualeditor-needcheck on ptwiki: https://pt.wikipedia.org/?diff=41081611 [17:35:01] 3VisualEditor: Find-Replace: positioning a cursor in one of the fields prevents from closing it with Cmd+F(Ctrl+F) - https://phabricator.wikimedia.org/T86783#976430 (10Etonkovidova) 3NEW [17:50:58] 3VisualEditor: Find-Replace: When 'Regular expression' search evaluates search criteria as invalid - the Find field should be cleared from previous search results count. - https://phabricator.wikimedia.org/T86789#976508 (10Etonkovidova) 3NEW [17:54:36] 3UI-Standardization, VisualEditor, VisualEditor-MediaWiki: "Save page" on VisualEditor toolbar should be progressive - https://phabricator.wikimedia.org/T86507#976529 (10Jdforrester-WMF) 5Open>3Resolved [17:54:50] 3VisualEditor: The "Done" button doesn't go well with VisualEditor's Find And Replace bar - https://phabricator.wikimedia.org/T85852#976533 (10Jdforrester-WMF) 5Open>3Resolved [17:55:05] 3VisualEditor, VisualEditor-EditingTools: Documentation for the message Visualeditor-dialog-action-done is misleading - https://phabricator.wikimedia.org/T72281#976535 (10Jdforrester-WMF) 5Open>3Resolved [17:56:10] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: [Regression wmf1] When the inspector is still open for a selected node, after placing the cursor in a different position, inspector flickers there - https://phabricator.wikimedia.org/T73151#976538 (10Jdforrester-WMF) 5Open>3Resolved [17:56:13] 3VisualEditor: Find-Replace: some parts of the box are still visible after closing. - https://phabricator.wikimedia.org/T86791#976540 (10Etonkovidova) 3NEW [18:04:18] James_F: hi [18:04:38] I am giving a talk about VE in a Wikipedia meetup in Tel-Aviv on Friday. [18:04:47] any special messages you want me to pass on? [18:08:33] 3VisualEditor, Parsoid: Multi-paragraph
results in some paragraphs being alienated content - https://phabricator.wikimedia.org/T86794#976599 (10Whatamidoing-WMF) 3NEW [18:08:53] (03CR) 10Alex Monk: "I think this should be done with hooks in ParsoidVirtualRESTService or via RESTBase or something." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130543 (https://phabricator.wikimedia.org/T66171) (owner: 10GWicke) [18:12:38] 3VisualEditor, Parsoid: Multi-paragraph
results in some paragraphs being alienated content - https://phabricator.wikimedia.org/T86794#976615 (10Whatamidoing-WMF) T53087 might be related. [18:23:13] aharoni: Nothing in particular. "It will be even better next month" is generally true, though… [18:23:19] 3MediaWiki-Page-editing, MediaWiki-Core-Team: ipblocks query from EditPage unconditionally goes to master - https://phabricator.wikimedia.org/T51419#976656 (10aaron) a:5tstarling>3aaron [18:24:46] 3VisualEditor, Parsoid: Multi-paragraph
results in some paragraphs being alienated content - https://phabricator.wikimedia.org/T86794#976665 (10Whatamidoing-WMF) Also T53262 [18:28:42] James_F: what about the magic "[[", "{{", "*" and so on? [18:28:49] Are these supposed to stay? [18:28:58] I added it to the fact, but it was deleted. [18:29:23] https://www.mediawiki.org/w/index.php?title=Help%3AVisualEditor%2FFAQ&diff=1337831&oldid=1336847 [18:31:55] aharoni: They're only there for power-users. The normal keyboard shortcuts are what I'd suggest you talk about to new users. [18:32:05] aharoni: Oh, is this a regular users meetup? [18:32:14] James_F: It's going to be a meetup of power users. [18:32:47] Right. :-) In that case, yeah, those are to stay and might be of interest to them. [18:32:59] Cool. I expect most of them to love this feature. [18:33:06] * James_F nods. [18:33:16] Except those that want an excuse not to use VE? ;-) [18:33:38] That's what the talk's about - eliminating the excuses. [18:34:06] Right. [18:42:34] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/183729 (https://phabricator.wikimedia.org/T54459) (owner: 10Mooeypoo) [18:46:48] (03CR) 10Jforrester: Add filename to the media dialog (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/183729 (https://phabricator.wikimedia.org/T54459) (owner: 10Mooeypoo) [18:48:52] edsanders: when do you land on Monday? [18:51:51] TrevorParscal, 1525 [18:54:54] (03CR) 10Mooeypoo: Transform the search widget to show image details (039 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161342 (https://phabricator.wikimedia.org/T78161) (owner: 10Mooeypoo) [18:55:22] (03PS46) 10Mooeypoo: Transform the search widget to show image details [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161342 (https://phabricator.wikimedia.org/T78161) [19:07:05] edsanders: sweetness [19:08:04] mooeypoo: Hi! Enjoying the fog? [19:08:33] mooeypoo: Same question from me: Any special messages from you to the Israeli Wikipedians? I'm going to give a talk about VE in Tel-Aviv on Friday. [19:08:42] https://he.wikipedia.org/wiki/WP:MEET/2015-winter [19:09:38] hmmmmm [19:10:17] The fog has a name. Did you know? It's Karl. https://twitter.com/karlthefog [19:16:12] 3VisualEditor, VisualEditor-MediaWiki-Media: In the new media dialog, clicking on the last result before more results have time to be fetched from the API causes the result list to be filled with empty rows - https://phabricator.wikimedia.org/T86802#976827 (10Mooeypoo) 3NEW a:3Mooeypoo [19:28:24] 3MediaWiki-Page-editing: Excessive quantity of Edits Conflict in QIC - https://phabricator.wikimedia.org/T86785#976900 (10Tgr) p:5High>3Normal [19:29:01] 3MediaWiki-Page-editing: Edit conflicts (tracking) - https://phabricator.wikimedia.org/T72163#976904 (10Tgr) [19:29:02] 3MediaWiki-Page-editing: Excessive quantity of Edits Conflict in QIC - https://phabricator.wikimedia.org/T86785#976451 (10Tgr) [19:32:15] 3MediaWiki-Page-editing: Excessive quantity of Edits Conflict in QIC - https://phabricator.wikimedia.org/T86785#976911 (10Tgr) This bug is not actionable. You should either specify what change in behavior you are expecting (T6745?) or come up with a different organization for the page (such as subpages) - the pr... [19:41:35] aharoni, I cleaned up the feedback page, but there are a couple of reports that I wasn't sure if we want to keep for tracking, so I left them there even though they're reported in phabricator. [19:42:37] 3VisualEditor: Find-Replace: When 'Regular expression' search evaluates search criteria as invalid - the Find field should be cleared from previous search results count. - https://phabricator.wikimedia.org/T86789#976969 (10Etonkovidova) [19:51:13] James_F: have you gotten a chance to test https://gerrit.wikimedia.org/r/#/c/184712/ ? :) [19:51:48] legoktm: Sorry, have broken my local system so badly I can't. :-( [19:51:51] * James_F retries. [19:58:11] (03CR) 10Umherirrender: [C: 032] Fix whitespaces in JavaScript [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/184840 (owner: 10Gerrit Patch Uploader) [19:58:17] (03Merged) 10jenkins-bot: Fix whitespaces in JavaScript [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/184840 (owner: 10Gerrit Patch Uploader) [20:16:50] 3OOjs-UI: No demo for LookupInputWidget - https://phabricator.wikimedia.org/T85467#977073 (10Jdlrobson) This is great. One suggested improvement - you could make this example even simpler and non-mediawiki specific by just returning a jQuery.Deferred().resolve( { data: } ) Would also be great if you could use th... [20:28:57] 3MediaWiki-Page-editing: Excessive quantity of edits conflict in a busy project page - https://phabricator.wikimedia.org/T86785#977139 (10Nemo_bis) [20:33:58] 3VisualEditor, VisualEditor-ContentEditable: Quotation marks should go arround text - https://phabricator.wikimedia.org/T86635#977187 (10matmarex) This comment was probably meant for this bug: >>! In T86636#973165, @Juandev wrote: > And I guess that other pair characters should work on the same principle, such... [20:37:17] 3MediaWiki-Page-editing: Excessive quantity of edits conflict in a busy project page - https://phabricator.wikimedia.org/T86785#977199 (10Nemo_bis) As far as I can see, there isn't anything special in this page, other than being high traffic, so this would be a duplicate of T72163. However, some things to try:... [20:37:25] 3MediaWiki-Page-editing: Excessive quantity of edits conflict in a busy project page - https://phabricator.wikimedia.org/T86785#977201 (10Nemo_bis) 5Open>3stalled [20:45:33] TrevorParscal: hey. It seems that I should not extend directly ve.ui.Dialog with my own dialogs? but more "specific" subclasses, e.g. FragmentDialog? [20:48:06] 3VisualEditor: STATICREDIRECT should not be set when the user does not tick the box to set it - https://phabricator.wikimedia.org/T86827#977252 (10Whatamidoing-WMF) 3NEW [20:50:09] InezK: that just depends on what functionality you are hoping to get [20:50:52] Ok. We have source dialog - which basically after closed (with apply) reinitialize entire surface [20:50:55] there's nothing wrong with subclassing Dialog directly, but you will be bypassing features so just pay attention to that [20:51:09] you probably just want to use ProcessDialog [20:51:49] FragmentDialog is a special dialog with some extras that are handy when the dialog is working with the contents of a fragment [20:52:18] something more generic, like the setting dialog we have in VE for instance, that affects the document more generally - that's a ProcessDialog [20:52:37] and, by Source you mean, editing Wikitext inside the dialog? [20:52:47] Interesing, we don't have ProcessDialog at all - code is about 2 weeks old [20:52:56] TrevorParscal: yes [20:54:01] oh OO.ui.ProcessDialog [20:55:10] (03CR) 10Esanders: "Lol. James, as you well know the English language has no Académie. Filename is a perfectly acceptable and currently enjoys more usage than" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/183729 (https://phabricator.wikimedia.org/T54459) (owner: 10Mooeypoo) [20:56:42] TrevorParscal: also, dialogs don't have default height anymore? [20:57:08] it's just some sort of auto measurement, don't depend on it if you are doing fancy stuff [21:00:07] TrevorParscal: so your recommendation would be to hardcode some value in getBodyHeight? [21:06:15] 3UI-Standardization, OOjs-UI: "Front-end Standardization" talk for MediaWiki Developer Summit 2015 - https://phabricator.wikimedia.org/T86072#977295 (10matmarex) [21:06:53] 3UI-Standardization, OOjs-UI: "Front-end Standardization" talk for MediaWiki Developer Summit 2015 - https://phabricator.wikimedia.org/T86072#977297 (10TrevorParscal) [21:07:54] 3UI-Standardization, OOjs-UI: "Front-end Standardization" workshop for MediaWiki Developer Summit 2015 - https://phabricator.wikimedia.org/T86072#977300 (10Jdforrester-WMF) [21:09:32] 3UI-Standardization, OOjs-UI: "Front-end Standardization" workshop for MediaWiki Developer Summit 2015 - https://phabricator.wikimedia.org/T86072#977302 (10Qgil) @TrevorPascal, if this is a workshop, do you need the large room? [21:12:26] (03PS6) 10Alex Monk: Combine imageinfo requests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180228 (https://phabricator.wikimedia.org/T75822) [21:14:41] (03CR) 10jenkins-bot: [V: 04-1] Combine imageinfo requests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180228 (https://phabricator.wikimedia.org/T75822) (owner: 10Alex Monk) [21:16:19] TrevorParscal: If you wanted dialog with atypical width, how would do it now? [21:16:29] width that is not in OO.ui.WindowManager.static.sizes [21:21:36] (03PS7) 10Alex Monk: Combine imageinfo requests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180228 (https://phabricator.wikimedia.org/T75822) [21:30:26] hi etonkovidova [21:30:36] hello [21:30:48] will you be at the summit? [21:31:06] hmmm... do not know [21:32:26] I'll ask this in a simpler way: will you be in SF in the next couple of weeks? [21:33:05] this question is simpler - yes, I will be in SF [21:36:39] etonkovidova: great, I look forward to meeting you. [21:36:54] etonkovidova: and did you see https://phabricator.wikimedia.org/T86469 ? [21:37:44] aharoni: looking... [21:37:45] aharoni: Aha, that needs merging. [21:38:25] aharoni: there is dupe bug(for a different language) [21:38:33] OK :) [21:38:48] but will re-check - no worries [22:03:05] InezK, at the moment you'd have to extend the window manager I guess - not very easily done... [22:03:39] I see [22:03:51] edsanders: also, do you know how can I get from the dialog to the surface, or to the target? [22:04:25] I'm trying to port this dialog: https://github.com/Wikia/app/blob/dev/extensions/VisualEditor/wikia/modules/ve/ui/dialogs/ve.ui.WikiaSourceModeDialog.js#L175-L216 [22:04:35] it needs to re-setup the surface, within the same target [22:05:55] it seems that ve.instances is also gone ;/ [22:06:05] InezK: it's renamed [22:06:16] MatmaRex: what's the new name? [22:06:49] (03PS1) 10Jforrester: dialog: Provide a 'larger' size for things for which 'large' isn't enough [oojs/ui] - 10https://gerrit.wikimedia.org/r/185066 (https://phabricator.wikimedia.org/T86396) [22:06:59] ve.init.somethingsomething [22:07:43] InezK: ve.init.target.getSurface() [22:08:12] that's interesting.. so how few targets on the same page are being handled now? [22:08:48] persumably you'd keep track of the Target objects somewhere yourself [22:10:27] so we've been working on this assumption that dialogs only need access to the model [22:11:09] so we don't pass in the full surface, because when we did that it was abused in all sorts of horrible ways [22:11:20] although we may need a more sophisticated way [22:11:33] of dialogs talking back [22:11:55] for example, with the find and replace dialog, we do pass it a surface so it can drag highlights [22:12:01] *draw [22:12:34] although I want to clean that up at some point [22:12:52] If your action only needs to access the target when the dialog closes, you can pass commands via the closing data [22:13:00] how is it done that it gets surface? because it is ToolbarDialog? [22:13:05] and have code in the surface that observes that [22:13:15] yeah - it's a hack in WindowAction [22:13:20] I see [22:13:41] I guess I can hack to always pass surface in data ;/ [22:15:01] edsanders: I don't quite understans the other solution with closing.. however, I need access early on - because I use serialize method of the target [22:15:17] https://github.com/Wikia/app/blob/dev/extensions/VisualEditor/wikia/modules/ve/ui/dialogs/ve.ui.WikiaSourceModeDialog.js#L104-L107 [22:15:29] edsanders: what would you do? hack in WindowAction? [22:16:42] (03CR) 10Mooeypoo: Transform the search widget to show image details (0316 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161342 (https://phabricator.wikimedia.org/T78161) (owner: 10Mooeypoo) [22:16:46] hm [22:16:57] (03CR) 10Mooeypoo: Transform the search widget to show image details (033 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161342 (https://phabricator.wikimedia.org/T78161) (owner: 10Mooeypoo) [22:17:18] (if I get surface - I'm home - because from there I have access to target - in Wikia case) [22:17:56] if you look at LanguageInputWidget.prototype.onFindLanguageButtonClick [22:18:11] we launch a dialog when you click a button [22:18:32] then when you choose a language in that dialog, is passes the chosen language back in the closing data to the widget [22:19:27] if you have a dialog for editing source code, it only needs to take source code in, and output source code when it closes [22:19:39] all the conversion and processing can happen with the caller [22:19:40] yes [22:19:53] I see what you saying [22:20:22] now dialog is also used for showing progress indiciator - while serializing/parsing - but that could be change [22:20:30] so you may want to not use the Window/open action [22:20:30] but still, dialog now is opened for me sort of automatically [22:20:55] maybe create a new action, which actually takes the data from the dialog and does what you want [22:21:11] the action has access to the surface [22:21:27] so now I have Tool and a Command, I don't have an Action [22:21:39] those things are connected via those symbolic links [22:21:44] yeah - as custom action might be a good way of doing it [22:21:53] so I would still keep the Tool, but I don't need a command? [22:22:12] you need a command [22:22:18] but point the command elsewhere [22:22:42] so Tool -> Command -> Action [22:22:45] right [22:22:55] ok, interesting [22:23:02] because you can also have Trigger (keyboard shortcut) -> Command -> Action [22:23:07] I will experiment with that [22:23:25] or event Sequence -> Command -> Action [22:23:35] for things link "typing '* ' makes a list" [22:24:03] *or even [22:24:31] sweet [22:25:02] however, for now I think I will hack around WindowAction - less changes needed... especially that I would have to come up with some new way of showing wait indicator [22:25:24] and showing it now in the dialog is nice because it blocks user from editing content in the surface, while I'm serializing it [23:13:51] 3OOjs-UI: LookupInputWidget is terrible and also sucks - https://phabricator.wikimedia.org/T86851#977653 (10matmarex) 3NEW [23:15:33] 3OOjs-UI: LookupInputWidget is terrible and also sucks - https://phabricator.wikimedia.org/T86851#977653 (10matmarex) I would really like to fix these, but @jdforrester-wmf is already mad at me for making https://gerrit.wikimedia.org/r/184828 breaking ;), so here's a proposal: we revert that, we deprecate Lookup... [23:16:30] 3OOjs-UI: No demo for LookupInputWidget - https://phabricator.wikimedia.org/T85467#977676 (10matmarex) This actually still sucks a lot, with the demo above making a few problems clear, I filed T86851 where we should work out a better solution. [23:22:17] Krenair: thoughts? ^ [23:23:20] on the demo or it being terrible? [23:28:33] So we have a VisualEditor-Performance project and also a Performance column on the workboard? [23:33:33] Krenair: on lookupinputwidget sucking and my proposed solution [23:37:35] hm [23:39:30] (03PS47) 10Mooeypoo: Transform the search widget to show image details [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161342 (https://phabricator.wikimedia.org/T78161) [23:40:55] MatmaRex, where does its $input come from again? [23:41:41] Krenair: input==this. it's supposed to be mixed in into TextInputWidgets. [23:41:50] ah [23:43:23] I think this was one of the classes causing me some confusion when I was new [23:43:50] InputWidgetLookup? :/ [23:45:46] it's causing everyone confusion because it sucks [23:46:06] who here's good at naming things? [23:46:09] *crickets* [23:46:16] :D