[00:00:22] 3VisualEditor, VisualEditor-EditingTools: A number of VisualEditor dialogs do not cover full screen when 'full' size - https://phabricator.wikimedia.org/T76863#977843 (10matmarex) Caused by 5eb7294a748231dca841d49896ccfdd630baef7c (https://gerrit.wikimedia.org/r/#/c/174491/). [00:08:13] Does anyone know how actions in dialogs are supposed to be used? for instance, if I want to disable apply button/action [00:08:22] 3OOjs-UI: LookupInputWidget is terrible and also sucks - https://phabricator.wikimedia.org/T86851#977887 (10Ricordisamoa) Also, `onLookupMenuItemChoose` is not a standard method, it has to be bound with `this.lookupMenu.connect()`. Are there any use cases of LookupInputWidget which don't involve inheriting from... [00:11:28] 3VisualEditor: Load visualeditor modules in a closure mapping $/mw/ve to their globals - https://phabricator.wikimedia.org/T50885#977919 (10Jdforrester-WMF) a:5Krinkle>3None [00:12:00] 3VisualEditor, VisualEditor-ContentLanguage: VisualEditor: Text in Japanese disappears - https://phabricator.wikimedia.org/T74619#977922 (10Jdforrester-WMF) p:5High>3Normal [00:12:09] 3VisualEditor, VisualEditor-ContentEditable, VisualEditor-ContentLanguage: After selecting table cell by single clicking, typing with any IME does not work - https://phabricator.wikimedia.org/T86589#977924 (10Jdforrester-WMF) p:5High>3Normal [00:12:16] 3MediaWiki-extensions-FlaggedRevs, VisualEditor-MediaWiki, VisualEditor: Edit notice saying that changes must be reviewed appears even when the user has autoreview rights - https://phabricator.wikimedia.org/T60057#977925 (10Jdforrester-WMF) p:5High>3Normal [00:13:14] 3OOjs-UI: LookupInputWidget is terrible and also sucks - https://phabricator.wikimedia.org/T86851#977934 (10matmarex) >>! In T86851#977887, @Ricordisamoa wrote: > Are there any use cases of LookupInputWidget which don't involve inheriting from TextInputWidget? Yes, VisualEditor's ve.ui.MWLinkTargetInputWidget (... [00:14:25] (03PS48) 10Mooeypoo: Transform the search widget to show image details [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161342 (https://phabricator.wikimedia.org/T78161) [00:14:48] InezK, hey [00:14:54] hey hey [00:14:56] I think we do this in a couple of places, let me take a look [00:15:05] thx [00:15:27] 3VisualEditor, VisualEditor-MediaWiki: Extra space before the start of the citation/template (not multiple transclusion) dialog contents - https://phabricator.wikimedia.org/T78045#977967 (10Jdforrester-WMF) p:5High>3Low [00:15:35] 3VisualEditor, VisualEditor-MediaWiki-Links, VisualEditor-EditingTools: "Open" button in the Link tool can sometimes lead to a broken or incorrect target - https://phabricator.wikimedia.org/T85619#977972 (10Jdforrester-WMF) p:5High>3Normal [00:15:40] 3VisualEditor, VisualEditor-ContentLanguage: VisualEditor: Text in Japanese disappears - https://phabricator.wikimedia.org/T74619#977974 (10Yukichi99) Why did you change the priority? I recognize this bug is blocked against using by Japanese. If you have a reason, let me know. [00:15:58] 3VisualEditor, VisualEditor-ContentEditable: [Regression wmf4] Link continuation is broken - https://phabricator.wikimedia.org/T74108#977976 (10Jdforrester-WMF) p:5High>3Normal [00:16:03] (03PS1) 10Bartosz Dziewoński: ToolbarDialogWindowManager: Don't pollute parent's .static.sizes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/185094 (https://phabricator.wikimedia.org/T76863) [00:16:06] 3VisualEditor-MediaWiki, VisualEditor: VisualEditor: Where VisualEditor is the primary editor, redlinks in read mode should go to veaction=edit not action=edit - https://phabricator.wikimedia.org/T55441#977977 (10Jdforrester-WMF) p:5High>3Normal [00:16:08] InezK, ve.ui.MWTemplateDialog.prototype.setApplicableStatus [00:16:23] It does things like this.actions.setAbilities( { apply: false, insert: false } ); [00:16:24] 3VisualEditor, VisualEditor-ContentEditable: References in blockquote invisible outside it; reflist outside blockquote invisible inside it - https://phabricator.wikimedia.org/T54398#977982 (10Jdforrester-WMF) p:5High>3Normal [00:16:41] setAbilities, ok [00:16:47] 3VisualEditor, VisualEditor-ContentLanguage: VisualEditor: CE eats up syllables except a last syllable of a word in Korean IME - https://phabricator.wikimedia.org/T52631#977985 (10Jdforrester-WMF) p:5High>3Normal [00:16:55] hmmm, a cancel seems to be somehow special - it does not have an action name [00:18:12] ... hm [00:18:30] yeah so ve.ui.MWMetaDialog.static.actions sets up an action with label: OO.ui.deferMsg( 'visualeditor-dialog-action-cancel' ) [00:18:36] but no action key for the name. [00:18:46] 3VisualEditor, VisualEditor-MediaWiki: [Regression] __STATICREDIRECT__ is set when user sets a redirect, regardless whether the user does ticked the box to set it - https://phabricator.wikimedia.org/T86827#977991 (10Jdforrester-WMF) [00:19:28] 3VisualEditor, VisualEditor-EditingTools: Context menu call-out should always appear at the bottom of a node - https://phabricator.wikimedia.org/T76669#977995 (10Jdforrester-WMF) p:5High>3Normal [00:19:37] 3VisualEditor, VisualEditor-ContentEditable: Provide true nested, inheriting surfaces - https://phabricator.wikimedia.org/T76550#977997 (10Jdforrester-WMF) p:5High>3Normal [00:19:50] 3VisualEditor-Performance, VisualEditor: Internal nodes should eventually be in a separate document ("sub-documents") - https://phabricator.wikimedia.org/T49344#978005 (10Jdforrester-WMF) p:5High>3Normal [00:19:56] 3VisualEditor: Complete and document VisualEditor's integration and plugin system - https://phabricator.wikimedia.org/T52514#978006 (10Jdforrester-WMF) p:5High>3Normal [00:20:12] 3VisualEditor: VisualEditor: Make fakeIme QUnit testing more rigorous - https://phabricator.wikimedia.org/T59538#978007 (10Jdforrester-WMF) p:5High>3Normal [00:20:17] 3VisualEditor, VisualEditor-DataModel: Detect no-op transactions on objects as well as annotations - https://phabricator.wikimedia.org/T64933#978009 (10Jdforrester-WMF) p:5High>3Normal [00:20:25] 3VisualEditor, VisualEditor-MediaWiki: VisualEditor: Error message texts when the Parsoid service is not around aren't very clear, should be improved - https://phabricator.wikimedia.org/T41057#978010 (10Jdforrester-WMF) p:5High>3Normal [00:20:34] 3VisualEditor, VisualEditor-CopyPaste: VisualEditor: Paste of content does not use the context's annotation - https://phabricator.wikimedia.org/T50720#978012 (10Jdforrester-WMF) p:5High>3Normal [00:20:42] 3VisualEditor, Math: Create a visual VisualEditor plugin tool to add/edit maths blocks - https://phabricator.wikimedia.org/T45058#978013 (10Jdforrester-WMF) p:5High>3Normal [00:20:56] 3VisualEditor, VisualEditor-ContentEditable, VisualEditor-EditingTools: When cursoring back onto a link, the context menu appears at the end of the paragraph rather than the correct position. - https://phabricator.wikimedia.org/T76415#978014 (10Jdforrester-WMF) p:5High>3Normal [00:21:03] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Hidden templates should display as an icon in-page so they can be interacted with (e.g. a puzzle piece?) - https://phabricator.wikimedia.org/T51806#978015 (10Jdforrester-WMF) p:5High>3Normal [00:21:18] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Backspace from (or deleteing down) into a DL breaks badly - https://phabricator.wikimedia.org/T52995#978018 (10Jdforrester-WMF) p:5High>3Normal [00:21:36] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Cursoring off the page with left/right doesn't scroll the cursor in to view - https://phabricator.wikimedia.org/T60038#978022 (10Jdforrester-WMF) p:5High>3Normal [00:21:52] 3VisualEditor, VisualEditor-EditingTools: In the template dialog, the boxes for pre-existing, long parameters should be expanded before you click on them in Firefox - https://phabricator.wikimedia.org/T64084#978024 (10Jdforrester-WMF) p:5High>3Normal [00:22:00] 3VisualEditor, VisualEditor-MediaWiki: VisualEditor: Show something (other than a blank page) when editing a page with a redirect - https://phabricator.wikimedia.org/T63861#978025 (10Jdforrester-WMF) p:5High>3Normal [00:24:16] Krenair: Hey [00:24:26] hi [00:29:00] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: in media item caption in a isn't blocked, which means page can get into an uneditable state on load - https://phabricator.wikimedia.org/T60270#978059 (10Jdforrester-WMF) p:5High>3Normal [00:29:08] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: "Use an Existing Reference" option remains disabled for a reference inside Media Settings while there is a reference available to re-use in the page - https://phabricator.wikimedia.org/T62919#978061 (10Jdforrester-WMF) p:5High>3Normal [00:29:18] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Centred images can appear in VE as overlapped by another image, then can't be selected - https://phabricator.wikimedia.org/T64590#978063 (10Jdforrester-WMF) p:5High>3Low [00:29:32] 3VisualEditor, VisualEditor-DataModel: VisualEditor removes a colon from the first existing indented list item when adding another item to the list - https://phabricator.wikimedia.org/T65079#978066 (10Jdforrester-WMF) p:5High>3Normal [00:29:39] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: Citation tool opens if you click the icon, but if you double-click the ref or press the return key, the Reference dialog opens instead - https://phabricator.wikimedia.org/T66712#978068 (10Jdforrester-WMF) p:5High>3Normal [00:29:54] 3VisualEditor, VisualEditor-DataModel: VisualEditor: [Regression] Categories and DEFAULTSORT meta items getting modified to strip default whitespace? - https://phabricator.wikimedia.org/T67647#978070 (10Jdforrester-WMF) p:5High>3Normal [00:30:14] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Pasting invalidly parented
throws "Uncaught TypeError: Cannot read property 'type' of undefined" in ve.dm.LinearData.static.getType - https://phabricator.wikimedia.org/T74385#978074 (10Jdforrester-WMF) p:5High>3Normal [00:30:20] 3VisualEditor, VisualEditor-DataModel: VisualEditor: Be able to serialise the linear model - https://phabricator.wikimedia.org/T74658#978076 (10Jdforrester-WMF) p:5High>3Normal [00:30:33] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Added templates in RTL wikis should float in appropriate direction - https://phabricator.wikimedia.org/T55544#978078 (10Jdforrester-WMF) p:5High>3Normal [00:30:38] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Extending an existing DL-indentation renders correctly in CE, but doesn't come through on save - https://phabricator.wikimedia.org/T54399#978080 (10Jdforrester-WMF) p:5High>3Normal [00:30:44] 3VisualEditor: Done button should be disabled when no text is in link inspector search field - https://phabricator.wikimedia.org/T86710#978082 (10Ryasmeen) p:5Triage>3Normal [00:30:46] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: cutting block level elements changes the type of following element - https://phabricator.wikimedia.org/T54770#978085 (10Jdforrester-WMF) p:5High>3Normal [00:30:57] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Can't cut or copy citation template in Reference dialog - https://phabricator.wikimedia.org/T67593#978088 (10Jdforrester-WMF) p:5High>3Normal [00:31:17] 3VisualEditor: When invalid input is added to link inspector search open link opens last valid query rather than disabling - https://phabricator.wikimedia.org/T86709#978093 (10Ryasmeen) p:5Triage>3Normal [00:31:29] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Ctrl-Space to insert an NBSP, and a way to see the difference - https://phabricator.wikimedia.org/T53045#978095 (10Jdforrester-WMF) p:5High>3Low [00:31:53] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Trigger keys can end up in CE surface, but not in DM - https://phabricator.wikimedia.org/T55682#978100 (10Jdforrester-WMF) p:5High>3Normal [00:32:22] 3VisualEditor, VisualEditor-DataModel: VisualEditor: Edit to a template somehow removing equals signs in markup? - https://phabricator.wikimedia.org/T54752#978102 (10Jdforrester-WMF) 5Open>3Resolved a:3Jdforrester-WMF AFAICT this is fixed; no recurrences in months have been reported. [00:32:35] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Linebreaks not preserved when converting preformatted text to paragraph text. ↵ Displayed in VE but not saved. - https://phabricator.wikimedia.org/T56794#978105 (10Jdforrester-WMF) p:5High>3Normal [00:33:34] 3VisualEditor-Performance, VisualEditor, VisualEditor-DataModel: Explore using SurfaceFragments to track meta items' positions - https://phabricator.wikimedia.org/T76542#978120 (10Jdforrester-WMF) p:5High>3Normal [00:33:47] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: Search results (for links, redirects, categories…) should select the exact match by default - https://phabricator.wikimedia.org/T71716#978121 (10Jdforrester-WMF) p:5High>3Normal [00:33:52] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Changing the format of a block slug between a list and a block template breaks badly - https://phabricator.wikimedia.org/T64475#978123 (10Jdforrester-WMF) p:5High>3Normal [00:35:14] 3VisualEditor, VisualEditor-DataModel: VisualEditor: Mis-nested annotations are cleaned up, leading to a dirty diff - https://phabricator.wikimedia.org/T52052#978131 (10Jdforrester-WMF) p:5High>3Normal [00:35:22] 3VisualEditor, VisualEditor-DataModel: VisualEditor: Can't remove list items immediately after a template - https://phabricator.wikimedia.org/T52250#978136 (10Jdforrester-WMF) p:5High>3Normal [00:35:28] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: Let users relabel (or renumber if auto-numbered) parameters in the transclusion dialog - https://phabricator.wikimedia.org/T52268#978138 (10Jdforrester-WMF) p:5High>3Normal [00:35:39] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: backspacing sometimes inserts a breaking space - https://phabricator.wikimedia.org/T52358#978140 (10Jdforrester-WMF) p:5High>3Normal [00:35:42] 3VisualEditor: When invalid input is added to link inspector search open link opens last valid query rather than disabling - https://phabricator.wikimedia.org/T86709#978145 (10Ryasmeen) I cannot reproduce this issue, it opens the link target page that I edited second time. Reopen if you can still reproduce this... [00:35:52] 3VisualEditor: When invalid input is added to link inspector search open link opens last valid query rather than disabling - https://phabricator.wikimedia.org/T86709#978147 (10Ryasmeen) 5Open>3Invalid [00:35:57] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: Add support for editing templates' parameters as DOM elements, including supporting nested templates - https://phabricator.wikimedia.org/T52355#978148 (10Jdforrester-WMF) p:5High>3Normal [00:36:04] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: Link input widget should suggest section links - https://phabricator.wikimedia.org/T52881#978150 (10Jdforrester-WMF) p:5High>3Low [00:36:30] 3VisualEditor, VisualEditor-DataModel: VisualEditor: nowiki tags thrown right after a template - https://phabricator.wikimedia.org/T55548#978153 (10Jdforrester-WMF) p:5High>3Normal [00:37:04] 3VisualEditor, VisualEditor-DataModel: VisualEditor: Whitespace corruption, HTML-like entities removed, and apparent DSR issues - https://phabricator.wikimedia.org/T53304#978155 (10Jdforrester-WMF) 5Open>3Resolved a:3Jdforrester-WMF No ability to track this down and no recurrence in over a year; closing. [00:39:11] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Alt + any key in a slug introduces a pawn in Firefox on Windows - https://phabricator.wikimedia.org/T60675#978160 (10Jdforrester-WMF) 5Open>3Resolved a:3Jdforrester-WMF Have re-tested; no issue any more. [00:40:25] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: White pawn "♙" appears on Alt+Shift+F in Firefox - https://phabricator.wikimedia.org/T71810#978164 (10Jdforrester-WMF) 5Open>3Resolved a:3Jdforrester-WMF Fixed. [00:41:53] 3VisualEditor: When invalid input is added to link inspector search open link opens last valid query rather than disabling - https://phabricator.wikimedia.org/T86709#978172 (10Jaredzimmerman-WMF) Using the steps listed I was easily able to reproduce, I've included a video. Let me know if you have any other quest... [00:41:55] 3VisualEditor, VisualEditor-ContentEditable: Quotation marks should go arround text - https://phabricator.wikimedia.org/T86635#978173 (10Ryasmeen) p:5Triage>3Normal [00:42:02] 3OOjs-UI: Provide some PHP support for DropdownWidget - https://phabricator.wikimedia.org/T86393#978175 (10matmarex) [00:42:19] 3VisualEditor: When invalid input is added to link inspector search open link opens last valid query rather than disabling - https://phabricator.wikimedia.org/T86709#978177 (10Jaredzimmerman-WMF) 5Invalid>3Open [00:43:36] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Pawn ♙ appears after deleting the text preceding and following a link by "undo" action - https://phabricator.wikimedia.org/T63521#978186 (10Jdforrester-WMF) 5Open>3Resolved a:3Jdforrester-WMF No pawns now. [00:43:43] 3OOjs-UI: Provide some PHP support for DropdownWidget - https://phabricator.wikimedia.org/T86393#967757 (10matmarex) [00:45:01] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Down-arrow in a slug with a
in it puts cursor inside slug rather than moving down or right in Firefox - https://phabricator.wikimedia.org/T58068#978193 (10Jdforrester-WMF) Well, this now doesn't happen because Firefox doesn't get the surface selecte... [00:45:07] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Down-arrow in a slug with a
in it puts cursor inside slug rather than moving down or right in Firefox - https://phabricator.wikimedia.org/T58068#978194 (10Jdforrester-WMF) p:5High>3Low [00:45:15] 3OOjs-UI: LookupInputWidget is terrible and also sucks - https://phabricator.wikimedia.org/T86851#978196 (10matmarex) Talked with @trevorparscal and we probably want to call it… LookupElement. Fits better with other mixins' names. [00:46:58] 3VisualEditor-Performance, VisualEditor, VisualEditor-MediaWiki: For very large pages on slow connections (when a timeout happens?), users get an "Error: Unknown error" on saving changes in VisualEditor (but change is indeed saved) - https://phabricator.wikimedia.org/T55093#978201 (10Jdforrester-WMF) p:5High>... [00:47:15] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Removing last char from paragraph removes entire paragraph and throws in IE - https://phabricator.wikimedia.org/T64333#978203 (10Jdforrester-WMF) p:5High>3Normal [00:47:32] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: After inserting a comment and a link, a cursor is moved at the end of the line, but typed text gets inserted between the comment and the link - https://phabricator.wikimedia.org/T71438#978205 (10Jdforrester-WMF) p:5High>3Normal [00:48:22] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: [Regression] External rich pasting in Firefox inserting newlines again - https://phabricator.wikimedia.org/T62050#978207 (10Jdforrester-WMF) 5Open>3Resolved Whenever we fixed this, it's certainly not a problem now. [00:48:43] 3VisualEditor: Toolbar and dropdown menu design - https://phabricator.wikimedia.org/T86693#978212 (10Ryasmeen) p:5Triage>3Normal [00:48:54] 3VisualEditor, VisualEditor-MediaWiki: Special character inserter width needs adjusting - https://phabricator.wikimedia.org/T78038#978215 (10Jdforrester-WMF) p:5High>3Low [00:48:59] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Tab/Shift-Tab behaviour in other contexts (and tables) - https://phabricator.wikimedia.org/T72665#978216 (10Jdforrester-WMF) p:5High>3Normal [00:49:06] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: [Regression] Ctrl+A no longer working since staging of slugs because a selection starting from a CE=false node in Chrome - https://phabricator.wikimedia.org/T74725#978218 (10Jdforrester-WMF) p:5High>3Normal [00:49:43] 3VisualEditor, VisualEditor-ContentEditable, VisualEditor-Tables: Pressing tab inside a cell when the cursor is active should taking it to the next cell, not to beginning of the document - https://phabricator.wikimedia.org/T74823#978220 (10Jdforrester-WMF) [00:49:46] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Tab/Shift-Tab behaviour in other contexts (and tables) - https://phabricator.wikimedia.org/T72665#755967 (10Jdforrester-WMF) [00:50:00] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Reference & cite tooltips should show content snippets, instead of generic labels - https://phabricator.wikimedia.org/T71474#978223 (10Jdforrester-WMF) p:5High>3Normal [00:50:08] 3VisualEditor, VisualEditor-Tables, VisualEditor-EditingTools: VisualEditor: "Insert table" tool should be (also?) in the "Table" menu, not (or in addition to?) "Insert" menu - https://phabricator.wikimedia.org/T75212#978224 (10Jdforrester-WMF) p:5High>3Normal [00:50:22] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Pasting in text containing a tab character causes VE to scroll to the top - https://phabricator.wikimedia.org/T74390#978226 (10Jdforrester-WMF) p:5High>3Normal [00:50:46] 3VisualEditor-ContentEditable, VisualEditor: VisualEditor: Safari scrolls one line for every character typed - https://phabricator.wikimedia.org/T73561#978229 (10Jdforrester-WMF) p:5High>3Normal [00:51:03] 3VisualEditor, VisualEditor-ContentEditable: Pressing "Backspace" or creating a heading causes the page to abruptly scroll up on Internet Explorer 11 - https://phabricator.wikimedia.org/T73119#978233 (10Jdforrester-WMF) p:5High>3Normal [00:51:14] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: Some dialogs are showing with transparent backgrounds in IE11 - https://phabricator.wikimedia.org/T74643#978235 (10Jdforrester-WMF) p:5High>3Normal [00:53:13] (03PS1) 10Divec: WIP: Word character detection [unicodejs] - 10https://gerrit.wikimedia.org/r/185103 [00:54:01] 3VisualEditor, VisualEditor-MediaWiki: Same Category get added multiple times ,for every change in “Sort this page by default as” value. - https://phabricator.wikimedia.org/T76715#978261 (10Jdforrester-WMF) 5Open>3Resolved a:3Jdforrester-WMF This seems to now be fixed? [00:59:12] 3OOjs-UI: InputWidgets should detect the internal .value property and the 's .value property getting desynchronised and do something smart - https://phabricator.wikimedia.org/T86868#978279 (10matmarex) 3NEW a:3matmarex [00:59:24] 3VisualEditor, VisualEditor-MediaWiki, OOjs-UI: VisualEditor: saveOptions.summary is not updated if the summary is inserted using a tool (InputWidget relies on 'change' events rather than checking the value) - https://phabricator.wikimedia.org/T71749#745532 (10matmarex) Hmm. That is actually a very good point. T... [01:00:05] 3OOjs-UI: Provide some PHP support for DropdownWidget - https://phabricator.wikimedia.org/T86393#978295 (10matmarex) a:3matmarex [01:00:08] 3OOjs-UI: LookupInputWidget is terrible and also sucks - https://phabricator.wikimedia.org/T86851#978296 (10matmarex) a:3matmarex [01:00:19] 3OOjs-UI: No demo for LookupInputWidget - https://phabricator.wikimedia.org/T85467#978297 (10matmarex) a:3matmarex [01:20:24] 3VisualEditor, VisualEditor-MediaWiki: Make the diff screen of the save dialog a larger rather than large size - https://phabricator.wikimedia.org/T78823#978345 (10Jdforrester-WMF) a:3Jdforrester-WMF [01:24:27] (03PS1) 10Bartosz Dziewoński: Revert "[BREAKING CHANGE] LookupInputWidget: Remove the silly 'input' parameter" [oojs/ui] - 10https://gerrit.wikimedia.org/r/185110 [01:24:35] 3VisualEditor, VisualEditor-MediaWiki-Links, VisualEditor-EditingTools: Wordbreak detection is faulty for selection starting just up-page of a link annotation - https://phabricator.wikimedia.org/T86399#978351 (10Jdforrester-WMF) a:3dchan [01:24:42] (03Abandoned) 10Bartosz Dziewoński: Update for I33c818a2 in OOUI [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/184829 (owner: 10Bartosz Dziewoński) [01:24:47] 3VisualEditor, Utilities-UnicodeJS: Wordbreak detection is faulty for selection starting just down-page of a single character - https://phabricator.wikimedia.org/T78202#978354 (10Jdforrester-WMF) a:5Esanders>3dchan [01:25:08] (03CR) 10Jforrester: "This is to fix https://phabricator.wikimedia.org/T86399 and https://phabricator.wikimedia.org/T78202 or maybe just one of them?" [unicodejs] - 10https://gerrit.wikimedia.org/r/185103 (owner: 10Divec) [01:25:52] (03PS2) 10Bartosz Dziewoński: Revert "[BREAKING CHANGE] LookupInputWidget: Remove the silly 'input' parameter" [oojs/ui] - 10https://gerrit.wikimedia.org/r/185110 (https://phabricator.wikimedia.org/T86851) [01:26:16] 3MediaWiki-Page-editing, VisualEditor, Editing: Provide an editing behaviour "report card" for each of some of our big wikis (frwiki, enwiki, dewiki, eswiki, etc.) - https://phabricator.wikimedia.org/T84929#978363 (10Jdforrester-WMF) p:5Triage>3Normal [01:27:34] 3VisualEditor: Shift- in VisualEditor deletes selected text. - https://phabricator.wikimedia.org/T86742#978367 (10Jdforrester-WMF) p:5Triage>3Normal [01:28:54] 3VisualEditor: Deactivation of Editu summary dialog - https://phabricator.wikimedia.org/T86626#978370 (10Ryasmeen) p:5Triage>3Normal [01:30:39] 3VisualEditor, VisualEditor-Tables: Can't place cursor in empty table cells at https://cs.wikipedia.org/wiki/Seznam_židovských_památek_ve_Středočeském_kraji?veaction=edit - https://phabricator.wikimedia.org/T86703#978373 (10Jdforrester-WMF) p:5Triage>3Normal [01:31:11] 3OOjs-UI: No demo for LookupInputWidget - https://phabricator.wikimedia.org/T85467#947534 (10matmarex) Let's fix T86851 and //then// I'll rewrite the demo and put it up somewhere. [01:31:43] 3OOjs-UI: InputWidgets should detect the internal .value property and the 's .value property getting desynchronised and do something smart - https://phabricator.wikimedia.org/T86868#978383 (10matmarex) p:5Triage>3High [01:31:44] 3UI-Standardization, VisualEditor: Save dialog should use OOJS-UI (MW-UI) checkboxes - https://phabricator.wikimedia.org/T86617#978380 (10Ryasmeen) p:5Triage>3Normal [01:31:46] 3OOjs-UI: LookupInputWidget is terrible and also sucks - https://phabricator.wikimedia.org/T86851#978385 (10matmarex) p:5Normal>3High [01:31:53] 3UI-Standardization, OOjs-UI: Shadow at the bottom of buttons, dropdown menus is intentionally vertically mis-aligned by a pixel or two in the MediaWiki theme - https://phabricator.wikimedia.org/T78083#978387 (10matmarex) p:5High>3Normal [01:32:11] 3OOjs-UI: No demo for LookupInputWidget - https://phabricator.wikimedia.org/T85467#978389 (10matmarex) [01:33:53] 3VisualEditor, VisualEditor-ContentEditable: An image inserted to table cell, break the table - https://phabricator.wikimedia.org/T86501#978399 (10Ryasmeen) p:5Triage>3Normal [01:38:58] 3VisualEditor: Long VisualEditor dialog title can be overlapped by the buttons - https://phabricator.wikimedia.org/T86469#978403 (10Ryasmeen) p:5Triage>3Normal [01:39:07] 3VisualEditor, VisualEditor-MediaWiki-Templates: Removing stub template removes too many lines - https://phabricator.wikimedia.org/T57856#978405 (10Jdforrester-WMF) p:5Triage>3Low [01:41:26] (03CR) 10Jforrester: [C: 032] Revert "[BREAKING CHANGE] LookupInputWidget: Remove the silly 'input' parameter" [oojs/ui] - 10https://gerrit.wikimedia.org/r/185110 (https://phabricator.wikimedia.org/T86851) (owner: 10Bartosz Dziewoński) [01:42:12] (03CR) 10Jforrester: [C: 032] ToolbarDialogWindowManager: Don't pollute parent's .static.sizes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/185094 (https://phabricator.wikimedia.org/T76863) (owner: 10Bartosz Dziewoński) [01:42:59] 3VisualEditor, VisualEditor-EditingTools: A number of VisualEditor dialogs do not cover full screen when 'full' size - https://phabricator.wikimedia.org/T76863#978411 (10Jdforrester-WMF) a:3matmarex [01:43:35] (03CR) 10Jforrester: [C: 032] MediaWiki Theme: Adjust toolbar popups' border and shadows [oojs/ui] - 10https://gerrit.wikimedia.org/r/184194 (https://phabricator.wikimedia.org/T78083) (owner: 10Bartosz Dziewoński) [01:43:49] (03CR) 10Jforrester: [C: 032] MediaWiki Theme: Don't use 'box-shadow' to produce thin grey lines in dialogs [oojs/ui] - 10https://gerrit.wikimedia.org/r/184198 (https://phabricator.wikimedia.org/T85226) (owner: 10Bartosz Dziewoński) [01:44:10] 3OOjs-UI: In MediaWiki theme, some thin grey lines in dialogs do not appear in some configurations - https://phabricator.wikimedia.org/T85226#978423 (10Jdforrester-WMF) p:5Normal>3Low [01:44:22] 3OOjs-UI: In MediaWiki theme, some thin grey lines in dialogs do not appear in some configurations - https://phabricator.wikimedia.org/T85226#978424 (10Jdforrester-WMF) 5Open>3Resolved [01:44:39] (03Merged) 10jenkins-bot: Revert "[BREAKING CHANGE] LookupInputWidget: Remove the silly 'input' parameter" [oojs/ui] - 10https://gerrit.wikimedia.org/r/185110 (https://phabricator.wikimedia.org/T86851) (owner: 10Bartosz Dziewoński) [01:44:43] 3UI-Standardization, OOjs-UI: Shadow at the bottom of buttons, dropdown menus is intentionally vertically mis-aligned by a pixel or two in the MediaWiki theme - https://phabricator.wikimedia.org/T78083#978427 (10Jdforrester-WMF) 5Open>3Resolved [01:45:02] 3VisualEditor, OOjs-UI: MediaWiki theme: Border radius used inconsistently - https://phabricator.wikimedia.org/T85973#978431 (10Jdforrester-WMF) 5Open>3Resolved [01:45:49] (03CR) 10Jforrester: [C: 032] Toolbar: Update #initialize docs [oojs/ui] - 10https://gerrit.wikimedia.org/r/184808 (owner: 10Bartosz Dziewoński) [01:46:28] (03CR) 10Bartosz Dziewoński: [C: 032] "I'm not a huge fan of this." [oojs/ui] - 10https://gerrit.wikimedia.org/r/185066 (https://phabricator.wikimedia.org/T86396) (owner: 10Jforrester) [01:46:44] (03CR) 10Bartosz Dziewoński: [C: 032] Add an ActionFieldLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/175568 (https://phabricator.wikimedia.org/T76634) (owner: 10Mooeypoo) [01:46:58] (03Merged) 10jenkins-bot: ToolbarDialogWindowManager: Don't pollute parent's .static.sizes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/185094 (https://phabricator.wikimedia.org/T76863) (owner: 10Bartosz Dziewoński) [01:47:04] (03CR) 10Jforrester: [C: 032] Trim aliases on save [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/184513 (https://phabricator.wikimedia.org/T85330) (owner: 10Mooeypoo) [01:47:43] (03Merged) 10jenkins-bot: MediaWiki Theme: Adjust toolbar popups' border and shadows [oojs/ui] - 10https://gerrit.wikimedia.org/r/184194 (https://phabricator.wikimedia.org/T78083) (owner: 10Bartosz Dziewoński) [01:47:46] (03Merged) 10jenkins-bot: MediaWiki Theme: Don't use 'box-shadow' to produce thin grey lines in dialogs [oojs/ui] - 10https://gerrit.wikimedia.org/r/184198 (https://phabricator.wikimedia.org/T85226) (owner: 10Bartosz Dziewoński) [01:47:55] (03Merged) 10jenkins-bot: Trim aliases on save [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/184513 (https://phabricator.wikimedia.org/T85330) (owner: 10Mooeypoo) [01:48:39] 3OOjs-UI: Create an ActionFieldLayout - https://phabricator.wikimedia.org/T76634#978448 (10Jdforrester-WMF) 5Open>3Resolved [01:51:38] 3VisualEditor: When invalid input is added to link inspector search open link opens last valid query rather than disabling - https://phabricator.wikimedia.org/T86709#978458 (10Ryasmeen) To reproduce, the article that was linked to on first attempt need to be an existing article in that wiki [01:52:08] (03Merged) 10jenkins-bot: Toolbar: Update #initialize docs [oojs/ui] - 10https://gerrit.wikimedia.org/r/184808 (owner: 10Bartosz Dziewoński) [01:55:52] (03Merged) 10jenkins-bot: dialog: Provide a 'larger' size for things for which 'large' isn't enough [oojs/ui] - 10https://gerrit.wikimedia.org/r/185066 (https://phabricator.wikimedia.org/T86396) (owner: 10Jforrester) [01:55:55] (03Merged) 10jenkins-bot: Add an ActionFieldLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/175568 (https://phabricator.wikimedia.org/T76634) (owner: 10Mooeypoo) [02:08:25] 3VisualEditor, VisualEditor-Tables: Highlighting table cells differ before and after entering VEedit - https://phabricator.wikimedia.org/T86164#978484 (10Ryasmeen) p:5Triage>3Normal [02:08:50] 3VisualEditor: VisualEditor find and replace tool gets the page to auto-scroll and moves the button away from the cursor - https://phabricator.wikimedia.org/T86459#978488 (10Ryasmeen) p:5Triage>3Normal [02:11:49] 3VisualEditor, VisualEditor-ContentEditable: Drag and drop or position of table using VE - https://phabricator.wikimedia.org/T86044#978491 (10Ryasmeen) p:5Triage>3Normal [02:12:42] 3VisualEditor, VisualEditor-MediaWiki: Users are requesting a "Cancel and exit without saving" option - https://phabricator.wikimedia.org/T85470#978494 (10Ryasmeen) p:5Triage>3Normal [02:13:15] (03PS1) 10Jforrester: Tag v0.6.3 [oojs/ui] - 10https://gerrit.wikimedia.org/r/185112 [02:19:59] 3OOjs-UI: LookupInputWidget is terrible and also sucks - https://phabricator.wikimedia.org/T86851#978502 (10matmarex) [02:21:44] 3OOjs-UI: Have a larger size of dialog than 'large' - https://phabricator.wikimedia.org/T86396#978507 (10Jdforrester-WMF) 5Open>3Resolved a:3Jdforrester-WMF [02:21:45] 3VisualEditor, VisualEditor-MediaWiki-Media: Make the media dialog bigger when searching for media to insert - https://phabricator.wikimedia.org/T86397#978512 (10Jdforrester-WMF) [02:21:46] 3VisualEditor, VisualEditor-MediaWiki: Make the diff screen of the save dialog a larger rather than large size - https://phabricator.wikimedia.org/T78823#978511 (10Jdforrester-WMF) [02:22:30] 3VisualEditor, VisualEditor-Tables: Cannot scroll down when editing long tables - https://phabricator.wikimedia.org/T76891#978517 (10Ryasmeen) p:5Triage>3Normal [02:35:31] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: Link inspector does not function correctly after closing it using "Done"/"Remove" button in Firefox while the cursor is never active on CE - https://phabricator.wikimedia.org/T75423#978550 (10Ryasmeen) p:5Triage>3Normal [03:36:45] 3VisualEditor, VisualEditor-MediaWiki: Same Category get added multiple times ,for every change in “Sort this page by default as” value. - https://phabricator.wikimedia.org/T76715#978595 (10Swainr) I can still reproduce it,the steps to reproduce are same as above.See screenshot.{F28700} [11:02:33] 3MediaWiki-Page-editing: Excessive quantity of edits conflict in a busy project page - https://phabricator.wikimedia.org/T86785#979133 (10Wilfredor) >>! In T86785#976911, @Tgr wrote: > This bug is not actionable. You should either specify what change in behavior you are expecting (T6745?) or come up with a diffe... [11:06:16] 3MediaWiki-Page-editing: Excessive quantity of edits conflict in a busy project page - https://phabricator.wikimedia.org/T86785#979137 (10Aklapper) p:5Normal>3Low Please provide specific answers - "We have tried to do that" is not a helpful answer to "Check what sort of edit conflict is most common?" or "Doe... [13:34:24] 3VisualEditor, VisualEditor-MediaWiki: Same Category get added multiple times ,for every change in “Sort this page by default as” value. - https://phabricator.wikimedia.org/T76715#979401 (10Krenair) 5Resolved>3Open Yes, I would be surprised if this silently fixed itself. [14:12:32] (03Restored) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163847 (owner: 10Hashar) [14:12:40] (03CR) 10Hashar: "check experimental" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163847 (owner: 10Hashar) [14:13:51] (03CR) 10Hashar: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163847 (owner: 10Hashar) [14:15:53] Good day AzaToth. [14:18:12] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163847 (owner: 10Hashar) [14:22:26] 3VisualEditor, Continuous-Integration, MediaWiki-extensions-Flow: Flow tests fails to run with VisualEditor installed - https://phabricator.wikimedia.org/T86920#979486 (10hashar) 3NEW [14:22:51] 3VisualEditor, Continuous-Integration, MediaWiki-extensions-Flow: Flow tests fails to run with VisualEditor installed - https://phabricator.wikimedia.org/T86920#979494 (10hashar) [14:33:50] 3VisualEditor: Ctrl+C copying of text with template removes text in FF - https://phabricator.wikimedia.org/T86921#979507 (10Lokal_Profil) 3NEW [14:34:38] 3VisualEditor: Ctrl+C copying of text with template removes text in FF - https://phabricator.wikimedia.org/T86921#979514 (10Lokal_Profil) Also tested with the {{!!}} template to ensure that it had nothing to do with the {{@}} inserting an image. [15:33:34] (03PS1) 10Esanders: Increase z-index of page select dropdown in demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/185186 [15:34:40] (03CR) 10Bartosz Dziewoński: [C: 032] Increase z-index of page select dropdown in demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/185186 (owner: 10Esanders) [15:34:46] hi. [15:36:28] (03Merged) 10jenkins-bot: Increase z-index of page select dropdown in demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/185186 (owner: 10Esanders) [15:40:47] 3VisualEditor, VisualEditor-MediaWiki: Same Category get added multiple times ,for every change in “Sort this page by default as” value. - https://phabricator.wikimedia.org/T76715#979587 (10Jdforrester-WMF) OK, I ran through the exact instructions given above in both Chrome 39 and Firefox 35, and couldn't replic... [15:58:13] 3MediaWiki-ResourceLoader, operations, MediaWiki-Core-Team: Bad cache stuck due to race condition with scap between different web servers - https://phabricator.wikimedia.org/T47877#979615 (10Nemo_bis) > So we think this is inherent to the design of our deploy mechanisms? If so, this report should be moved rom M... [15:58:57] 3VisualEditor, VisualEditor-MediaWiki: Same Category get added multiple times ,for every change in “Sort this page by default as” value. - https://phabricator.wikimedia.org/T76715#979617 (10matmarex) I can't reproduce either, but the buttons definitely act funny, visibly disappearing and reappearing when the pop... [15:59:43] 3MediaWiki-ResourceLoader, operations, MediaWiki-Core-Team: Bad cache stuck due to race condition with scap between different web servers - https://phabricator.wikimedia.org/T47877#979621 (10matmarex) [16:00:57] 3MediaWiki-ResourceLoader, operations, MediaWiki-Core-Team: Bad cache stuck due to race condition with scap between different web servers - https://phabricator.wikimedia.org/T47877#979631 (10Jdforrester-WMF) It's an over-optimisation in ResourceLoader which creates a bug exposed by the way we deploy. [16:01:36] 3VisualEditor: Cursor in upper index in the ol - https://phabricator.wikimedia.org/T86928#979633 (10Juandev) 3NEW [16:12:57] (03PS1) 10Esanders: Unwrap slug wrappers when converting to a real paragraph [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/185193 (https://phabricator.wikimedia.org/T85948) [16:17:19] (03CR) 10Esanders: [C: 04-1] "Not sure what you have in mind for this but would rather it was not merged as an orphaned unused file, but with the code you intend to use" (032 comments) [unicodejs] - 10https://gerrit.wikimedia.org/r/185103 (owner: 10Divec) [16:18:15] edsanders: I think that's what David meant by "WIP". :-) [16:21:52] edsanders: He said he wanted you to take a look at it during the stand-up, but he didn't say anything specific about it beyond that. [16:25:54] (03CR) 10Esanders: WIP: Word character detection (031 comment) [unicodejs] - 10https://gerrit.wikimedia.org/r/185103 (owner: 10Divec) [16:28:06] 3VisualEditor, VisualEditor-MediaWiki, MediaWiki-ContentHandler: [Regression 1.25wmf14] JSON content blocks that aren't objects (arrays, literals, …) don't display and can't be saved - https://phabricator.wikimedia.org/T86270#979689 (10Jdforrester-WMF) p:5Normal>3High [16:29:23] (03CR) 10Esanders: "Doesn't look like it this anything to do with those issues. The word break detection is fine, it's just a case of knowing when not to use " [unicodejs] - 10https://gerrit.wikimedia.org/r/185103 (owner: 10Divec) [16:30:47] edsanders: The single-character logic isn't wrong? Moriel and David think it is. [16:31:19] those bugs aren't for single char cases [16:31:27] Err. [16:31:33] The first one is, the second one isn't. [16:31:45] Unless I linked the wrong tasks. :-) [16:32:16] Yeah, T78202 is definitely talking about single-character cases. [16:36:53] well that should be related to the 'Alphabetic' property, links can apply sensibly to anything which isn't whitespace [16:38:55] 3VisualEditor-Performance, VisualEditor, VisualEditor-MediaWiki: Support editing parts of a page in VisualEditor - https://phabricator.wikimedia.org/T50429#979718 (10Salquint) I've been using Semantic Forms for more than 4 years now. It used to support the FCKEditor extension (and branch SMW+ supported the WYSIW... [16:42:40] 3VisualEditor, Utilities-UnicodeJS: Wordbreak detection is faulty for selection starting just down-page of a single character - https://phabricator.wikimedia.org/T78202#979726 (10Esanders) The word break calculation is correct: |Sub| |heading| |1| But our word expansion logic avoids wrapping single length rang... [16:43:15] 3VisualEditor-Performance, VisualEditor, VisualEditor-MediaWiki: Support editing parts of a page in VisualEditor - https://phabricator.wikimedia.org/T50429#979728 (10Jdforrester-WMF) It's entirely do-able for the developers of SemanticMediaWiki to create a VisualEditor integration for each of the fields in a for... [16:44:02] 3VisualEditor, VisualEditor-ContentEditable: Text that was added to a slug immediately vanishes when the cursor is placed in another slug - https://phabricator.wikimedia.org/T85948#979730 (10Jdforrester-WMF) a:3Esanders [16:46:01] edsanders: Right. [16:46:14] edsanders: Just trying to work out what bug David is fixing if it's not either of those two. :-) [17:21:44] 3VisualEditor: Cursor is not visible inside a table cell containing block quote. - https://phabricator.wikimedia.org/T86935#979810 (10Swainr) [17:23:03] 3VisualEditor, VisualEditor-Tables: Cursor is not visible inside a table cell containing block quote. - https://phabricator.wikimedia.org/T86935#979804 (10Swainr) [17:30:39] Corruption alert: visualeditor-needcheck on rowiki: https://ro.wikipedia.org/?diff=9004538 [17:30:39] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=110924459 [17:30:39] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=110941999 [17:30:39] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=110949441 [17:30:39] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=33954083 [17:30:40] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=33954104 [17:30:40] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=33956356 [17:30:41] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=33960610 [17:30:41] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=33963252 [17:30:42] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=67961483 [17:30:42] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=67961947 [17:30:43] Corruption alert: visualeditor-needcheck on cawiki: https://ca.wikipedia.org/?diff=14680483 [17:49:15] I have this very weird error all of a sudden. All of my pages which contain images in local MW has broken images now, and the pages are being categorized as: Pages with broken file links [17:50:26] This has also happened before, then I did get it fixed somehow [17:50:56] It reappeared today, again, after an update [17:53:09] I tried running rebuildall.php [17:53:27] Which doesn't help [18:24:15] 3VisualEditor, VisualEditor-MediaWiki: Same Category get added multiple times ,for every change in “Sort this page by default as” value. - https://phabricator.wikimedia.org/T76715#979976 (10matmarex) Oooh, the big dialog's "Cancel" button. I can reproduce now. [18:41:37] TrevorP|Away, James_F|Away, mooeypoo http://i.imgur.com/Km2FOKG.png [18:43:10] edsanders, doable of course, but that's a different usability feature than what the users seem to have asked. [18:43:28] Also, isn't the multimedia team working on a better way to sort out the data anyways? [18:44:03] so per the email thread, I think that is a nice goal for their team, but in the mean time we should deal with reality [18:44:21] edsanders, (and, lastly, a question) is this a general discussion or a blocker? Can we +2 what we have and then adjust, or do you think this is a blocker and we should fix it before deploying? [18:44:59] I'd rather deploy without the description->caption conversion, considering we don't think its a good idea [18:45:21] otherwise people may get upset when it's gone a week or so later [18:45:26] edsanders, okay, I'll be honest, I'm agnostic about this. For the majority of images that I've seen, the descriptions are short -- I didn't see *many* images with very long robust descriptions -- and those that are robust still have elements that are useful, so ti takes about 2 seconds to mark the excess and delete [18:45:50] As opposed to not giving anything in and hving the user type stuff in manually. [18:46:32] So per my spreadsheet I think that about 50% of descriptions are short, and about 30% make decent captions. I think autofill should be reserved for defaults we expect to be sensible [18:46:48] Whereas here we expect them to change it in 70% of cases [18:47:02] But change in a sensible way -- just take excess and delete [18:47:14] it's not like they'll have to delete all and retype. IT's still useful, isn't it? [18:47:17] and in 10-20% of cases, it will be a massive pile of garbage (I know, media team to fix etc.) which will be overwhelming and confusing for new users [18:47:35] hm. [18:48:11] I think for new users, working out how to edit a large block of text down to something sensible is a lot more complex then having them write a short caption [18:48:34] having seen people who don't even know how to use keyboard copy/paste and ctrl+arrow to jump words [18:48:47] James_F|Away, TrevorP|Away, edsanders, okay, just for the meantime, I can take that specific piece out of the current big gigantic media-search commit and put it in a dependent commit so we can continue discussing how to handle it? Im a little concerned that we're bike-shedding this commit to oblivion. 90% of it might be ready to be deployed, I can just take that piece out of it until we settle on a solution for that part. [18:48:49] copyediting is not as simple for most people as we assume [18:49:25] Right, I think we should proceed with the description->caption conversion omitted, but everything else as is [18:49:51] edsanders, yeah, I see your point. I can also see the point in having something initial to work with. Marking -> deleting -> applying can be better than typing from scratch [18:50:03] which is also, fortunately, the status quo [18:50:20] so we don't have to worry about changing people's workflow too much [18:50:21] But I admit I have less experience editing, hence my somewhat agnosticism in this case. [18:51:15] mooeypoo, and perhaps when the data is better that might be an option - I also proposed a button "Use description as caption" which would get to that point with one extra click [18:54:16] edsanders, hmm. Okay, good point. Okay, I'm going to remove this specific piece out of the big commit and re-add it as a dependent one. We can then continue discussions without holding off on deploying it [18:58:56] edsanders, I'm leaving the back-end support for adding a caption into the image model, but removing the *actual* adding of the caption. That way we can either add automatically, not add at all, or wait until the multimedia team gives us something more sensible and add it in the future. [18:59:58] sounds good [19:01:51] ok the bot didn't announce, but I updated the patch https://gerrit.wikimedia.org/r/#/c/161342/ [19:03:48] did anyone manage to reproduce https://phabricator.wikimedia.org/T86562 ? [19:07:39] edsanders, base - https://gerrit.wikimedia.org/r/#/c/161342/ and caption - https://gerrit.wikimedia.org/r/#/c/185220/ [19:15:41] sweeet [19:15:50] 'Existing image caption text' should say 'html' [19:24:10] just noticed some text/html issues - will review again [19:36:55] 3VisualEditor, Parsoid: Cannot open VE in Betalabs , throwing error Error loading data from server: 503: parsoidserver-http: HTTP 503 - https://phabricator.wikimedia.org/T86951#980108 (10Ryasmeen) 3NEW [19:38:10] edsanders: You keep using the word 'we' when I think you mean 'I' unless you've been promoted to the Royal Family. :-) [19:38:38] well Trevor's last email said you were in agreement [19:39:17] Last e-mail from Trevor says "2. It's probably easier, despite being messier, to cut something down than write something from scratch or even copy paste. " [19:39:20] Which I agreed with. [19:39:28] oh, he didn't reply all [19:39:33] So, no. :-) [19:42:31] resent [19:43:32] 3OOjs-UI: LookupInputWidget is terrible and also sucks - https://phabricator.wikimedia.org/T86851#980120 (10matmarex) Further issues: * The lookup menu doesn't have z-index (?) high enough to display on top of other widgets, unlike the one in DropdownWidget and its kin {F28854} * Should probably call #isValid be... [19:45:18] edsanders: Thanks. [19:45:47] just ignore all the profanities he uses to describe you [19:50:57] * James_F grins. [20:02:20] hm, parsoid does not seem to be running on deployment-parsoid05 [20:26:07] (03CR) 10Divec: "This will help with T78202. Boundary analysis is insufficient to detect whether content is word or non-word. Right now we're effectively u" (031 comment) [unicodejs] - 10https://gerrit.wikimedia.org/r/185103 (owner: 10Divec) [20:29:10] (03PS49) 10Mooeypoo: Transform the search widget to show image details [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161342 (https://phabricator.wikimedia.org/T78161) [20:29:12] (03PS1) 10Mooeypoo: Add image description as an initial caption [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185220 (https://phabricator.wikimedia.org/T53032) [20:29:21] (03PS50) 10Mooeypoo: Transform the search widget to show image details [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161342 (https://phabricator.wikimedia.org/T78161) [20:29:23] (03PS2) 10Mooeypoo: Add image description as an initial caption [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185220 (https://phabricator.wikimedia.org/T53032) [20:30:16] (03PS1) 10Mooeypoo: [wip] Lazy load the media search results [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185225 [20:30:20] (03PS2) 10Mooeypoo: [wip] Lazy load the media search results [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185225 [20:30:32] (03PS2) 10Umherirrender: Add missing dependency to module 'jquery.mwExtension' [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/183280 (owner: 10Gerrit Patch Uploader) [20:30:35] (03CR) 10Umherirrender: [C: 032] Add missing dependency to module 'jquery.mwExtension' [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/183280 (owner: 10Gerrit Patch Uploader) [20:30:38] (03Merged) 10jenkins-bot: Add missing dependency to module 'jquery.mwExtension' [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/183280 (owner: 10Gerrit Patch Uploader) [20:30:59] (03CR) 10Esanders: [C: 04-1] Transform the search widget to show image details (0311 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161342 (https://phabricator.wikimedia.org/T78161) (owner: 10Mooeypoo) [20:34:26] (03CR) 10Esanders: "So to restate myself from IRC:" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185220 (https://phabricator.wikimedia.org/T53032) (owner: 10Mooeypoo) [20:38:37] 3OOjs-UI: LookupInputWidget is terrible and also sucks - https://phabricator.wikimedia.org/T86851#980204 (10Ricordisamoa) >>! In T86851#980120, @matmarex wrote: > Further issues: > * The lookup menu doesn't have z-index (?) high enough to display on top of other widgets, unlike the one in DropdownWidget and its... [20:50:54] 3VisualEditor, VisualEditor-ContentEditable: Linked notes not visible nor editable in edit mode - https://phabricator.wikimedia.org/T86960#980255 (10Juandev) 3NEW [21:04:31] 3VisualEditor, VisualEditor-Performance, VisualEditor-MediaWiki: Support editing parts of a page in VisualEditor - https://phabricator.wikimedia.org/T50429#980318 (10MarkAHershberger) >>! In T50429#979728, @Jdforrester-WMF wrote: > It's entirely do-able for the developers of SemanticMediaWiki to create a VisualE... [21:05:10] 3MediaWiki-Page-editing: Excessive quantity of edits conflict in a busy project page - https://phabricator.wikimedia.org/T86785#980331 (10Nemo_bis) > You can use any methodology for testing client with multiple concurrent users automatically perform measurements on the server to verify I agree that we should h... [21:06:01] (03CR) 10Jforrester: "Let's veto adding any more buttons right now. :-)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185220 (https://phabricator.wikimedia.org/T53032) (owner: 10Mooeypoo) [21:06:47] Hey. [21:10:50] MatmaRex, so, the config changes went live .. and http://parsoid-lb.eqiad.wikimedia.org/plwikimedia/Strona_g%C5%82%C3%B3wna?oldid=51665 now renders [21:10:53] fyi [21:16:06] thanks subbu [21:20:03] 3MediaWiki-ResourceLoader, Mobile-Web, MobileFrontend-Feature-requests: ResourceLoaderImage module css rules should be more configurable - https://phabricator.wikimedia.org/T78215#980435 (10Jdlrobson) [21:24:23] subbu: Thanks! :-) [21:28:01] 3OOjs-UI: LookupInputWidget is terrible and also sucks - https://phabricator.wikimedia.org/T86851#980499 (10matmarex) > I don't think so, for example the validity regex could be /\w{3,}/ and the user might try to type a single letter to get suggestions. Hmm, okay. [21:31:22] (03PS1) 10Bartosz Dziewoński: Synchronize ComboBoxWidget and DropdownWidget styles [oojs/ui] - 10https://gerrit.wikimedia.org/r/185253 [21:31:24] (03PS1) 10Bartosz Dziewoński: Replace old&busted LookupInputWidget with new&hot LookupElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/185254 (https://phabricator.wikimedia.org/T86851) [21:32:25] 3OOjs-UI: LookupInputWidget is terrible and also sucks - https://phabricator.wikimedia.org/T86851#980521 (10matmarex) Thank you for the really useful comments! :D [21:32:58] 3OOjs-UI: No demo for LookupInputWidget - https://phabricator.wikimedia.org/T85467#980525 (10matmarex) I added a simplified version of the demo (not MediaWiki-dependent) to the fix for T86851. [21:36:49] (03PS1) 10Bartosz Dziewoński: [BREAKING CHANGE] Remove deprecated LookupInputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/185257 (https://phabricator.wikimedia.org/T86851) [21:38:18] 3MediaWiki-Page-editing: Excessive quantity of edits conflict in a busy project page - https://phabricator.wikimedia.org/T86785#980539 (10Tgr) I don't see how this is a test issue. Simultaneous edits to the same piece of text resulting in an edit conflict is not caused by lack of performance or robustness; it's... [21:39:55] (03CR) 10Esanders: Transform the search widget to show image details (035 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161342 (https://phabricator.wikimedia.org/T78161) (owner: 10Mooeypoo) [21:40:35] 3MediaWiki-extensions-Flow, VisualEditor, Continuous-Integration: Flow tests fails to run with VisualEditor installed - https://phabricator.wikimedia.org/T86920#980549 (10hashar) 5Open>3Resolved a:3hashar Fixed by Gerrit #185175. The Flow extension is now included in the shared PHPUnit job. Thanks! [21:42:00] (03CR) 10jenkins-bot: [V: 04-1] Synchronize ComboBoxWidget and DropdownWidget styles [oojs/ui] - 10https://gerrit.wikimedia.org/r/185253 (owner: 10Bartosz Dziewoński) [21:42:39] (03CR) 10Esanders: "you may want to advise Jon on how to rebase his commit onto this: https://gerrit.wikimedia.org/r/#/c/181225" [oojs/ui] - 10https://gerrit.wikimedia.org/r/185257 (https://phabricator.wikimedia.org/T86851) (owner: 10Bartosz Dziewoński) [21:53:57] (03CR) 10Bartosz Dziewoński: [C: 04-2] "I know, I'll probably just fix it. We're probably not merging this for a week or two (James?)." [oojs/ui] - 10https://gerrit.wikimedia.org/r/185257 (https://phabricator.wikimedia.org/T86851) (owner: 10Bartosz Dziewoński) [21:56:02] (03PS1) 10Bartosz Dziewoński: Change uses of LookupInputWidget to LookupElement [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185316 [21:56:16] (03CR) 10Bartosz Dziewoński: "Also depends on https://gerrit.wikimedia.org/r/185316 in VE being merged." [oojs/ui] - 10https://gerrit.wikimedia.org/r/185257 (https://phabricator.wikimedia.org/T86851) (owner: 10Bartosz Dziewoński) [21:56:50] (03CR) 10Bartosz Dziewoński: "Depends on https://gerrit.wikimedia.org/r/#/c/185254/" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185316 (owner: 10Bartosz Dziewoński) [21:57:12] (03CR) 10Bartosz Dziewoński: "(Jenkins lies, as always)" [oojs/ui] - 10https://gerrit.wikimedia.org/r/185253 (owner: 10Bartosz Dziewoński) [21:57:14] (03CR) 10jenkins-bot: [V: 04-1] Change uses of LookupInputWidget to LookupElement [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185316 (owner: 10Bartosz Dziewoński) [22:04:49] 3MediaWiki-extensions-Flow, VisualEditor, Continuous-Integration: Flow tests fails to run with VisualEditor installed - https://phabricator.wikimedia.org/T86920#980635 (10Mattflaschen) 5Resolved>3Open That's not merged. We're still discussing how to do it. [22:04:58] (03PS2) 10Bartosz Dziewoński: Replace old&busted LookupInputWidget with new&hot LookupElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/185254 (https://phabricator.wikimedia.org/T86851) [22:05:00] (03PS2) 10Bartosz Dziewoński: [BREAKING CHANGE] Remove deprecated LookupInputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/185257 (https://phabricator.wikimedia.org/T86851) [22:11:17] (03PS2) 10Bartosz Dziewoński: Change uses of LookupInputWidget to LookupElement [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185316 [22:12:34] (03CR) 10jenkins-bot: [V: 04-1] Change uses of LookupInputWidget to LookupElement [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185316 (owner: 10Bartosz Dziewoński) [22:13:47] 3MediaWiki-extensions-Flow, VisualEditor, Continuous-Integration: Flow tests fails to run with VisualEditor installed - https://phabricator.wikimedia.org/T86920#980649 (10hashar) Sorry, I swear I have though it got merged despite Matt -1. I must be tired :-] [22:14:53] o hi Krenair [22:15:12] Krenair: was just looking for you, wanna review the non-lookupinput part of https://gerrit.wikimedia.org/r/#/c/185316/ ? [22:15:57] hey, my vps died for a while [22:17:25] (03PS3) 10Bartosz Dziewoński: Change uses of LookupInputWidget to LookupElement [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185316 [22:19:50] (03CR) 10jenkins-bot: [V: 04-1] Change uses of LookupInputWidget to LookupElement [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185316 (owner: 10Bartosz Dziewoński) [22:19:58] 3VisualEditor: Deactivation of Editu summary dialog - https://phabricator.wikimedia.org/T86626#980665 (10Krenair) Sounds like a duplicate of T75675? [22:22:29] MatmaRex, gerrit is unwilling to show me any diffs [22:23:13] heh [22:24:07] okay [22:28:14] MatmaRex, yep that looks good [22:28:39] thanks [22:28:44] have fun convincing jenkins etc. :p [22:29:17] this depends on https://gerrit.wikimedia.org/r/#/c/185254/ ? [22:33:52] 3VisualEditor: Deactivation of Editu summary dialog - https://phabricator.wikimedia.org/T86626#980737 (10Jdforrester-WMF) Possibly. @Juandev, can you reproduce this now? The code to fix T75675 was deployed to cswiki on Wednesday. [22:35:47] (03CR) 10Trevor Parscal: [C: 032] Synchronize ComboBoxWidget and DropdownWidget styles [oojs/ui] - 10https://gerrit.wikimedia.org/r/185253 (owner: 10Bartosz Dziewoński) [22:36:26] Krenair: yes [22:37:35] (03PS3) 10Bartosz Dziewoński: Replace old&busted LookupInputWidget with new&hot LookupElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/185254 (https://phabricator.wikimedia.org/T86851) [22:41:41] (03CR) 10jenkins-bot: [V: 04-1] Synchronize ComboBoxWidget and DropdownWidget styles [oojs/ui] - 10https://gerrit.wikimedia.org/r/185253 (owner: 10Bartosz Dziewoński) [22:42:10] (03CR) 10Jforrester: [C: 032] "Bzzt. Try again." [oojs/ui] - 10https://gerrit.wikimedia.org/r/185253 (owner: 10Bartosz Dziewoński) [22:45:00] (03CR) 10Trevor Parscal: [C: 032] Replace old&busted LookupInputWidget with new&hot LookupElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/185254 (https://phabricator.wikimedia.org/T86851) (owner: 10Bartosz Dziewoński) [22:47:09] 3VisualEditor: error loading data from server: parsererror , when using new ParsoidVirtualRESTService - https://phabricator.wikimedia.org/T86447#980758 (10Krenair) Yes, if you check the network response via dev tools you should have seen the error about curl functions not being defined. [22:47:31] (03Merged) 10jenkins-bot: Synchronize ComboBoxWidget and DropdownWidget styles [oojs/ui] - 10https://gerrit.wikimedia.org/r/185253 (owner: 10Bartosz Dziewoński) [22:48:15] (03PS3) 10Bartosz Dziewoński: [BREAKING CHANGE] Remove deprecated LookupInputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/185257 (https://phabricator.wikimedia.org/T86851) [22:49:08] 3VisualEditor, VisualEditor-MediaWiki-Templates: [Regression wmf14] Cannot add any template, throws error TypeError: Cannot read property 'length' of null - https://phabricator.wikimedia.org/T86056#980759 (10Ryasmeen) Verified in en.wiki [22:49:11] 3VisualEditor: error loading data from server: parsererror , when using new ParsoidVirtualRESTService - https://phabricator.wikimedia.org/T86447#980760 (10Krenair) @Mooeypoo also had this problem. I mentioned it in editing-kit a couple of times. [22:49:30] 3VisualEditor, VisualEditor-MediaWiki-Templates: [Regression wmf14] Cannot add any template, throws error TypeError: Cannot read property 'length' of null - https://phabricator.wikimedia.org/T86056#980762 (10Ryasmeen) [22:52:34] 3VisualEditor, UI-Standardization: Save dialog should use OOJS-UI (MW-UI) checkboxes - https://phabricator.wikimedia.org/T86617#980772 (10Krenair) So we get the HTML for these checkboxes from the server at the moment - they come from EditPage (in MW core) and rely on hooks being run (e.g. to add FlaggedRev's che... [22:53:39] 3Mobile-Web, VisualEditor, Editing: in MobileFrontend, invoking the editor is incorrect and switching from VisualEditor to wikitext editor does nothing - https://phabricator.wikimedia.org/T85480#980774 (10Ryasmeen) Verified in en.wiki [22:53:56] 3Mobile-Web, VisualEditor, Editing: in MobileFrontend, invoking the editor is incorrect and switching from VisualEditor to wikitext editor does nothing - https://phabricator.wikimedia.org/T85480#980775 (10Ryasmeen) [23:14:41] (03PS2) 10Jforrester: Tag v0.6.3 [oojs/ui] - 10https://gerrit.wikimedia.org/r/185112 [23:16:24] (03PS3) 10Jforrester: Tag v0.6.3 [oojs/ui] - 10https://gerrit.wikimedia.org/r/185112 [23:20:58] (03PS1) 10Bartosz Dziewoński: InputWidget: Resynchronize our internal .value with DOM .value in #getValue [oojs/ui] - 10https://gerrit.wikimedia.org/r/185335 (https://phabricator.wikimedia.org/T86868) [23:22:03] (03CR) 10Bartosz Dziewoński: "Eranroz, I tweaked your patch and submitted it, with you as the author. Please confirm that you're okay with my changes. :)" [oojs/ui] - 10https://gerrit.wikimedia.org/r/185335 (https://phabricator.wikimedia.org/T86868) (owner: 10Bartosz Dziewoński) [23:22:20] (03CR) 10Bartosz Dziewoński: "(I didn't test this very much, but it should work.)" [oojs/ui] - 10https://gerrit.wikimedia.org/r/185335 (https://phabricator.wikimedia.org/T86868) (owner: 10Bartosz Dziewoński) [23:27:14] (03CR) 10Eranroz: [C: 031] "10x" [oojs/ui] - 10https://gerrit.wikimedia.org/r/185335 (https://phabricator.wikimedia.org/T86868) (owner: 10Bartosz Dziewoński) [23:48:16] (03CR) 10Trevor Parscal: [C: 032] Tag v0.6.3 [oojs/ui] - 10https://gerrit.wikimedia.org/r/185112 (owner: 10Jforrester) [23:52:22] (03Merged) 10jenkins-bot: Tag v0.6.3 [oojs/ui] - 10https://gerrit.wikimedia.org/r/185112 (owner: 10Jforrester)