[00:02:06] (03PS1) 10Jforrester: AUTHORS: Update for the last six months' work [oojs/ui] - 10https://gerrit.wikimedia.org/r/185343 [00:05:48] (03CR) 10Bartosz Dziewoński: [C: 031] AUTHORS: Update for the last six months' work [oojs/ui] - 10https://gerrit.wikimedia.org/r/185343 (owner: 10Jforrester) [00:06:16] (03PS1) 10Jforrester: Update OOjs UI to v0.6.3 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/185345 [00:09:24] TrevorParscal: Can I steal +2x3? https://gerrit.wikimedia.org/r/#/q/If0fc682b3a7f186d53ca70fdb66dded66a7f4814,n,z [00:10:25] (03CR) 10Trevor Parscal: [C: 032] Update OOjs UI to v0.6.3 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/185345 (owner: 10Jforrester) [00:10:53] (03CR) 10Trevor Parscal: [C: 04-1] InputWidget: Resynchronize our internal .value with DOM .value in #getValue (032 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/185335 (https://phabricator.wikimedia.org/T86868) (owner: 10Bartosz Dziewoński) [00:14:12] (03Merged) 10jenkins-bot: Update OOjs UI to v0.6.3 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/185345 (owner: 10Jforrester) [00:14:50] (03PS2) 10Bartosz Dziewoński: InputWidget: Resynchronize our internal .value with DOM .value in #getValue [oojs/ui] - 10https://gerrit.wikimedia.org/r/185335 (https://phabricator.wikimedia.org/T86868) [00:21:02] Krinkle: The link for the JSON isValid() issue is https://phabricator.wikimedia.org/T86270 BTW. [00:21:36] (03CR) 10Bartosz Dziewoński: InputWidget: Resynchronize our internal .value with DOM .value in #getValue (032 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/185335 (https://phabricator.wikimedia.org/T86868) (owner: 10Bartosz Dziewoński) [00:38:19] (03CR) 10Legoktm: [C: 031] AUTHORS: Update for the last six months' work [oojs/ui] - 10https://gerrit.wikimedia.org/r/185343 (owner: 10Jforrester) [00:47:39] (03CR) 10Ricordisamoa: "I don't think we have to wait for all listed contributors :)" [oojs/ui] - 10https://gerrit.wikimedia.org/r/185343 (owner: 10Jforrester) [01:11:21] (03PS1) 10Ricordisamoa: Fix 'license-name' to match SPDX conventions [extensions/Cite] - 10https://gerrit.wikimedia.org/r/185356 [01:27:40] (03CR) 10Krinkle: [C: 032] Fix 'license-name' to match SPDX conventions [extensions/Cite] - 10https://gerrit.wikimedia.org/r/185356 (owner: 10Ricordisamoa) [01:27:56] (03Merged) 10jenkins-bot: Fix 'license-name' to match SPDX conventions [extensions/Cite] - 10https://gerrit.wikimedia.org/r/185356 (owner: 10Ricordisamoa) [01:33:08] (03PS3) 10Mooeypoo: [wip] Lazy load the media search results [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185225 [01:44:24] (03PS4) 10Jforrester: Change uses of LookupInputWidget to LookupElement [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185316 (owner: 10Bartosz Dziewoński) [01:46:23] (03CR) 10jenkins-bot: [V: 04-1] Change uses of LookupInputWidget to LookupElement [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185316 (owner: 10Bartosz Dziewoński) [01:52:43] (03CR) 10Mooeypoo: Transform the search widget to show image details (0315 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161342 (https://phabricator.wikimedia.org/T78161) (owner: 10Mooeypoo) [01:53:10] (03PS51) 10Mooeypoo: Transform the search widget to show image details [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161342 (https://phabricator.wikimedia.org/T78161) [01:53:22] (03PS4) 10Mooeypoo: [wip] Lazy load the media search results [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185225 [01:56:30] (03PS5) 10Mooeypoo: Add filename to the media dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/183729 (https://phabricator.wikimedia.org/T54459) [02:00:30] (03PS1) 10Bartosz Dziewoński: demo: Remove nonexistent 'align' config option for a DropdownWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/185375 [02:00:32] (03PS1) 10Bartosz Dziewoński: [WIP] Introduce DropdownInputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/185376 (https://phabricator.wikimedia.org/T86393) [02:00:39] whoo [02:08:36] (03CR) 10Jforrester: [C: 032] demo: Remove nonexistent 'align' config option for a DropdownWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/185375 (owner: 10Bartosz Dziewoński) [02:12:19] (03Merged) 10jenkins-bot: demo: Remove nonexistent 'align' config option for a DropdownWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/185375 (owner: 10Bartosz Dziewoński) [02:19:56] (03PS1) 10Jforrester: Temporarily disable JSON content type on visualeditor-cite-tool-definition.json [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185378 [02:21:37] (03PS1) 10Jforrester: Update VE core submodule to master (8b28b37) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185379 [02:23:04] (03PS5) 10Jforrester: Change uses of LookupInputWidget to LookupElement [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185316 (owner: 10Bartosz Dziewoński) [02:24:11] Krinkle: https://phabricator.wikimedia.org/T86989 [02:24:16] if you are bored :P [02:24:47] Whoops. [02:25:31] (03CR) 10Bartosz Dziewoński: "Needs matching PHP implementation, a sanity check would be welcome." [oojs/ui] - 10https://gerrit.wikimedia.org/r/185376 (https://phabricator.wikimedia.org/T86393) (owner: 10Bartosz Dziewoński) [02:25:52] (03CR) 10Jforrester: [C: 04-1] "Should bump the wfUseMW to 1.25wmf16 as it uses LookupElement new in OOjs UI 0.6.3 which that pulls in." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185316 (owner: 10Bartosz Dziewoński) [02:26:37] (03PS6) 10Jforrester: Change uses of LookupInputWidget to LookupElement [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185316 (owner: 10Bartosz Dziewoński) [02:28:37] (03CR) 10Jforrester: [C: 031] Change uses of LookupInputWidget to LookupElement [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185316 (owner: 10Bartosz Dziewoński) [02:31:55] (03CR) 10Jforrester: [C: 04-1] "A tiny minor documentation fix, otherwise AFAICS this is good to go." (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161342 (https://phabricator.wikimedia.org/T78161) (owner: 10Mooeypoo) [02:33:29] (03CR) 10Jforrester: "Let's vaguely schedule this for release in February some time (a month to switch over should be sufficient?)." [oojs/ui] - 10https://gerrit.wikimedia.org/r/185257 (https://phabricator.wikimedia.org/T86851) (owner: 10Bartosz Dziewoński) [02:35:42] (03CR) 10Bartosz Dziewoński: "For Wikimedia we can merge this whenever, not sure what the imaginary third-party users would expect. :)" [oojs/ui] - 10https://gerrit.wikimedia.org/r/185257 (https://phabricator.wikimedia.org/T86851) (owner: 10Bartosz Dziewoński) [02:35:59] (03PS1) 10Alex Monk: MWLinkTargetInputWidget: Check WM title validity [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185381 (https://phabricator.wikimedia.org/T86709) [02:37:47] (03CR) 10jenkins-bot: [V: 04-1] MWLinkTargetInputWidget: Check WM title validity [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185381 (https://phabricator.wikimedia.org/T86709) (owner: 10Alex Monk) [02:41:32] ori: I think that got fixed already https://gerrit.wikimedia.org/r/#/c/184111/ [02:43:04] (03PS2) 10Alex Monk: MWLinkTargetInputWidget: Check WM title validity [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185381 (https://phabricator.wikimedia.org/T86709) [02:43:20] ori: https://gerrit.wikimedia.org/r/#/c/184111/ is in wmf15 but not wmf14 (which is what Meta is running). [02:43:40] Krenair: WM? [02:43:50] sigh [02:43:53] Krenair: Acronyms that fail the Timo test. :-) [02:43:56] Oh, MW? [02:44:06] (03PS3) 10Alex Monk: MWLinkTargetInputWidget: Check MW title validity [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185381 (https://phabricator.wikimedia.org/T86709) [02:44:21] "MWLinkTargetInputWidget: Check title is valid in MediaWiki"? [02:44:35] * James_F shrugs. [02:45:47] {{sfi}} [02:46:04] Krenair: I don't know how many more patches you're going to make. ;-) [02:46:07] Sure. [02:46:23] (03PS4) 10Jforrester: MWLinkTargetInputWidget: Check title is valid in MediaWiki [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185381 (https://phabricator.wikimedia.org/T86709) (owner: 10Alex Monk) [02:46:35] What I found on https://phabricator.wikimedia.org/T86710 is weird [02:47:31] Krinkle: ah, thanks [02:47:38] James_F thanks likewise [02:47:50] 3VisualEditor: Done button should be disabled when no text is in link inspector search field - https://phabricator.wikimedia.org/T86710#981103 (10Jdforrester-WMF) Eurgh. Probably an attempt to fix user behaviour? [03:00:23] 3VisualEditor, VisualEditor-ContentEditable: em and nowiki tags inserted incorrectly by VisualEditor - https://phabricator.wikimedia.org/T85377#981106 (10Jdforrester-WMF) > The use of "em" and "nowiki" tags is not normal here: https://fr.wiktionary.org/w/index.php?title=F%C3%A9tider&diff=prev&oldid=18811193 The... [03:01:08] 3VisualEditor, VisualEditor-CopyPaste: When the user pastes in an , we should probably convert it to an ? - https://phabricator.wikimedia.org/T85377#981107 (10Jdforrester-WMF) p:5Triage>3Low [03:03:13] 3VisualEditor-MediaWiki, VisualEditor: At nowiki the nowiki-tag shows up in some edits done with VisualEditor - https://phabricator.wikimedia.org/T74442#981111 (10Jdforrester-WMF) 5Open>3declined a:3Jdforrester-WMF @Elitre is correct that the two bugs look like they are due to pasting wikitext into a place... [03:05:32] 3VisualEditor: Closing welcome dialog also hides important edit notices - https://phabricator.wikimedia.org/T86987#981114 (10Krenair) [03:06:41] 3VisualEditor-MediaWiki, VisualEditor, VisualEditor-EditingTools: VisualEditor: Handle invalid input for redirect title in meta dialog - https://phabricator.wikimedia.org/T74971#981116 (10Krenair) [03:09:45] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: References inside galleries being displayed separately, inside the gallery, instead of in the correct block at the end of the page - https://phabricator.wikimedia.org/T74865#981120 (10Krenair) Blocked by T49344? [03:15:45] 3VisualEditor, VisualEditor-MediaWiki-Links: When invalid input is added to link inspector search open link opens last valid query rather than disabling - https://phabricator.wikimedia.org/T86709#981124 (10Jdforrester-WMF) a:3Krenair [03:20:07] 3VisualEditor, Parsoid: VisualEditor: Adding nowiki tags in unrelated edit - https://phabricator.wikimedia.org/T70511#981128 (10Jdforrester-WMF) This is slightly aggressive ing by #Parsoid – looks to still be an issue. Is it a part of a wider task? [03:20:48] 3VisualEditor, Parsoid: VisualEditor: Adding nowiki tags in unrelated edit - https://phabricator.wikimedia.org/T70511#981131 (10Jdforrester-WMF) p:5Triage>3Normal [03:23:56] (03CR) 10Bartosz Dziewoński: [C: 032] Update VE core submodule to master (8b28b37) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185379 (owner: 10Jforrester) [03:25:47] (03Merged) 10jenkins-bot: Update VE core submodule to master (8b28b37) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185379 (owner: 10Jforrester) [03:32:37] (03CR) 10Krinkle: [C: 032] Temporarily disable JSON content type on visualeditor-cite-tool-definition.json [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185378 (owner: 10Jforrester) [03:34:33] (03Merged) 10jenkins-bot: Temporarily disable JSON content type on visualeditor-cite-tool-definition.json [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185378 (owner: 10Jforrester) [06:18:56] 3MediaWiki-ResourceLoader: jquery dialog with auto size are broken in RTL languages - https://phabricator.wikimedia.org/T86979#981220 (10eranroz) Added local fix for hewiki common.css: .ui-dialog { right: auto; } (e.g to get rid of the wrong right style rule) [06:41:00] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: Citation tool opens if you click the icon, but if you double-click the ref or press the return key, the Reference dialog opens instead - https://phabricator.wikimedia.org/T66712#981239 (10Eloquence) @jdforrester-WMF If that sounds reasonable to you, I'd li... [06:49:39] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: Citation tool opens if you click the icon, but if you double-click the ref or press the return key, the Reference dialog opens instead - https://phabricator.wikimedia.org/T66712#981248 (10matmarex) [07:35:16] (03PS1) 10Bartosz Dziewoński: Wait with showing edit notices until after the welcome dialog is closed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185393 (https://phabricator.wikimedia.org/T86987) [07:37:09] (03CR) 10jenkins-bot: [V: 04-1] Wait with showing edit notices until after the welcome dialog is closed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185393 (https://phabricator.wikimedia.org/T86987) (owner: 10Bartosz Dziewoński) [07:38:08] (03PS2) 10Bartosz Dziewoński: Wait with showing edit notices until after the welcome dialog is closed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185393 (https://phabricator.wikimedia.org/T86987) [07:43:56] (03CR) 10Bartosz Dziewoński: Wait with showing edit notices until after the welcome dialog is closed (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185393 (https://phabricator.wikimedia.org/T86987) (owner: 10Bartosz Dziewoński) [07:49:37] 3VisualEditor: Closing welcome dialog also hides important edit notices - https://phabricator.wikimedia.org/T86987#981273 (10matmarex) a:3matmarex [08:09:44] (03CR) 10Gilles: "Such glory, such pride" [oojs/ui] - 10https://gerrit.wikimedia.org/r/185343 (owner: 10Jforrester) [09:09:49] 3MediaWiki-Page-editing: In edit preview, show categories in their standard position relative to the parsed page - https://phabricator.wikimedia.org/T4679#981322 (10Kozuch) @Qgil: sorry, I am out of time unfortunately... I will be happy for anyone else participating here... [09:14:52] (03CR) 10Ricordisamoa: [C: 04-1] "Per Esanders." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185220 (https://phabricator.wikimedia.org/T53032) (owner: 10Mooeypoo) [09:16:05] (03CR) 10Hashar: [C: 031] "Thanks!" [oojs/ui] - 10https://gerrit.wikimedia.org/r/185343 (owner: 10Jforrester) [09:22:00] (03CR) 10Rillke: [C: 031] AUTHORS: Update for the last six months' work [oojs/ui] - 10https://gerrit.wikimedia.org/r/185343 (owner: 10Jforrester) [09:48:59] qq, I can't find quite the answer...Does the table functionality work with VE 0.1 and MW 1.24.1 (the rel1_24 brach)? [10:53:26] (03PS1) 10Esanders: Reduce size of checkboxes and radio buttons by 20% [oojs/ui] - 10https://gerrit.wikimedia.org/r/185415 (https://phabricator.wikimedia.org/T86003) [11:34:02] 3VisualEditor, Math: VE renders incorrect highlights on Math tag in MathJax mode - https://phabricator.wikimedia.org/T87007#981547 (10Esanders) 3NEW [13:04:54] (03PS2) 10Divec: Word character class regex [unicodejs] - 10https://gerrit.wikimedia.org/r/185103 [13:23:29] (03PS52) 10Esanders: Transform the search widget to show image details [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161342 (https://phabricator.wikimedia.org/T78161) (owner: 10Mooeypoo) [13:24:38] (03CR) 10Esanders: [C: 032] Transform the search widget to show image details [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161342 (https://phabricator.wikimedia.org/T78161) (owner: 10Mooeypoo) [13:25:10] (03PS6) 10Esanders: Add filename to the media dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/183729 (https://phabricator.wikimedia.org/T54459) (owner: 10Mooeypoo) [13:26:27] (03Merged) 10jenkins-bot: Transform the search widget to show image details [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161342 (https://phabricator.wikimedia.org/T78161) (owner: 10Mooeypoo) [13:34:42] (03PS1) 10Esanders: Tweak margins on media info page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185431 [13:51:55] 3VisualEditor: Image results panel breaks if image is selected while loading - https://phabricator.wikimedia.org/T87022#981813 (10Esanders) 3NEW a:3MSchottlender-WMF [14:02:03] 3MediaWiki-Page-editing: jquery dialog with auto size takes 50% screen width in RTL language wikis - https://phabricator.wikimedia.org/T86979#980807 (10Aklapper) [15:28:58] 3VisualEditor, Math: VE renders incorrect highlights on Math tag in MathJax mode - https://phabricator.wikimedia.org/T87007#981963 (10Physikerwelt) {F29103}, shows that it works fine with Firefox. It seems to be a Chrome (and similar browsers) specific problem. So we need to fix this browser dependent. (cf. http... [15:37:23] 3MediaWiki-extensions-ProofreadPage, MediaWiki-Page-editing: Implement a rotate page image view function for pages being viewed when editing in the Page Namespace. - https://phabricator.wikimedia.org/T87017#981973 (10ShakespeareFan00) [16:26:41] (03PS5) 10Mooeypoo: [wip] Lazy load the media search results [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185225 [16:37:22] 3Wikimedia-Site-requests, VisualEditor: please enable visual editor in "Draft" namespace - https://phabricator.wikimedia.org/T87027#982012 (10Kipod) 3NEW [16:42:25] 3Wikimedia-Site-requests, VisualEditor: please enable visual editor in "Draft" namespace - https://phabricator.wikimedia.org/T87027#982020 (10IKhitron) [16:56:33] 3Wikimedia-Site-requests, VisualEditor: please enable visual editor in "Draft" namespace - https://phabricator.wikimedia.org/T87027#982100 (10Glaisher) It's already enabled on Draft ns at enwiki. I didn't enable it initially because it wasn't requested in the original task (T86329) for ns creation. [17:02:01] 3VisualEditor: Regression wmf15- Cite Menu has just the Basic and Re-use options(missing book, web.. options) - https://phabricator.wikimedia.org/T87034#982119 (10Swainr) 3NEW [17:02:57] (03PS6) 10Mooeypoo: Lazy load the media search results [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185225 [17:07:38] 3VisualEditor, VisualEditor-EditingTools: Regression wmf15- Cite Menu has just the Basic and Re-use options(missing book, web.. options) - https://phabricator.wikimedia.org/T87034#982132 (10Swainr) [17:09:56] 3VisualEditor: Image results panel breaks if image is selected while loading - https://phabricator.wikimedia.org/T87022#982145 (10Mooeypoo) [17:09:57] 3VisualEditor, VisualEditor-MediaWiki-Media: In the new media dialog, clicking on the last result before more results have time to be fetched from the API causes the result list to be filled with empty rows - https://phabricator.wikimedia.org/T86802#982146 (10Mooeypoo) [17:17:29] 3VisualEditor, VisualEditor-EditingTools: A number of VisualEditor dialogs do not cover full screen when 'full' size - https://phabricator.wikimedia.org/T76863#982161 (10Jdforrester-WMF) 5Open>3Resolved [17:17:44] 3VisualEditor, VisualEditor-MediaWiki-Media: Show media search results more pleasingly, with meta-data details available - https://phabricator.wikimedia.org/T78161#982162 (10Jdforrester-WMF) 5Open>3Resolved [17:17:44] (03PS1) 10Mooeypoo: Use z-index instead of show/hide in the panels in media dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185453 (https://phabricator.wikimedia.org/T86802) [17:17:54] 3VisualEditor, VisualEditor-EditingTools: Make it easy to identify the file type (e.g., .png versus .svg) when adding an image - https://phabricator.wikimedia.org/T74061#982167 (10Jdforrester-WMF) 5Open>3Resolved [17:18:06] We should probably find a better way to deal with panels in ooui in general, but this fixes the bug. [17:19:39] (03CR) 10jenkins-bot: [V: 04-1] Use z-index instead of show/hide in the panels in media dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185453 (https://phabricator.wikimedia.org/T86802) (owner: 10Mooeypoo) [17:22:28] 3VisualEditor, VisualEditor-EditingTools: Test2wiki's was deleted and needs to be undeleted - https://phabricator.wikimedia.org/T87034#982171 (10Jdforrester-WMF) p:5Triage>3Low a:3Jdforrester-WMF [17:30:32] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=110970169 [17:30:32] Corruption alert: visualeditor-needcheck on hewiki: https://he.wikipedia.org/?diff=16446396 [17:30:32] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=67971500 [17:30:32] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=67978740 [17:30:32] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=67979281 [17:32:16] (03CR) 10Jforrester: [C: 032] Tweak margins on media info page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185431 (owner: 10Esanders) [17:34:11] (03Merged) 10jenkins-bot: Tweak margins on media info page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185431 (owner: 10Esanders) [17:39:33] (03CR) 10Jforrester: "> Note also that long descriptions may be eligible for copyright, and users who are unaware of that might end up making the file non-linki" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185220 (https://phabricator.wikimedia.org/T53032) (owner: 10Mooeypoo) [17:40:44] (03PS7) 10Jforrester: Add filename to the media dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/183729 (https://phabricator.wikimedia.org/T54459) (owner: 10Mooeypoo) [17:41:14] (03CR) 10Jforrester: [C: 032] "Ed's concerns met, Siebrand's suggestion considered and decided against." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/183729 (https://phabricator.wikimedia.org/T54459) (owner: 10Mooeypoo) [17:43:22] (03Merged) 10jenkins-bot: Add filename to the media dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/183729 (https://phabricator.wikimedia.org/T54459) (owner: 10Mooeypoo) [17:59:29] (03CR) 10Esanders: "this will detect word characters yes, but surely any non-whitespace char is linkable, not just words?" (032 comments) [unicodejs] - 10https://gerrit.wikimedia.org/r/185103 (owner: 10Divec) [17:59:55] (03PS2) 10Mooeypoo: Use z-index instead of show/hide in the panels in media dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185453 (https://phabricator.wikimedia.org/T86802) [18:21:10] James_F, 'State of the merges'? [18:23:59] (03CR) 10Esanders: "Interesting approach, not sure how I feel about it though - z-index makes me nervous, would like to get some more opinions." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185453 (https://phabricator.wikimedia.org/T86802) (owner: 10Mooeypoo) [18:28:44] edsanders: Yeah, joining now. [18:29:32] there's no hangout [18:29:41] There is now. [18:34:44] mooeypoo: CR https://gerrit.wikimedia.org/r/#/c/184440/ please? [18:38:59] Krenair: Update on https://gerrit.wikimedia.org/r/#/c/182432/ please? [18:40:15] (03CR) 10Jforrester: "Ping, needs tests fixing." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179223 (owner: 10Divec) [18:40:40] (03CR) 10Esanders: [C: 031] "Code looks good, tests broken." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179223 (owner: 10Divec) [18:40:47] (03CR) 10Jforrester: "Ping here too. :-)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177946 (owner: 10Divec) [18:44:41] TrevorParscal: Please re-review https://gerrit.wikimedia.org/r/#/c/182988/ [18:46:22] 3VisualEditor, MediaWiki-extensions-Flow, Continuous-Integration: Flow tests fails to run with VisualEditor installed - https://phabricator.wikimedia.org/T86920#982507 (10Mattflaschen) p:5Triage>3Normal [18:47:16] Krenair: And then https://phabricator.wikimedia.org/T86827 and https://phabricator.wikimedia.org/T74461 [18:50:52] TrevorParscal: And https://gerrit.wikimedia.org/r/#/c/185193/ right? [18:52:37] James_F, had forgotten about that change, back on the list now [18:52:39] IIRC I was hoping to make something more general for T86827, there was another similar task... [18:52:43] urgh, I mean T74461 [18:52:43] Krenair: Thanks. [18:52:44] Haven't looked at T86827 before [18:52:56] * James_F nods. [18:56:56] (03PS1) 10Mooeypoo: Add deprecated switch to the editor [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/185480 [18:57:59] (03CR) 10jenkins-bot: [V: 04-1] Add deprecated switch to the editor [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/185480 (owner: 10Mooeypoo) [19:00:37] (03PS2) 10Mooeypoo: Add deprecated switch to the editor [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/185480 [19:10:24] 3OOjs-UI: MediaWiki theme: Checkboxes and radios look oversized on desktop - https://phabricator.wikimedia.org/T86003#982622 (10Jdforrester-WMF) Effect of this patch (before on the left, after on the right): {F29128} [19:11:49] (03PS2) 10Jforrester: MediaWiki theme: Reduce size of checkboxes and radio buttons by 20% [oojs/ui] - 10https://gerrit.wikimedia.org/r/185415 (https://phabricator.wikimedia.org/T86003) (owner: 10Esanders) [19:11:58] (03CR) 10Jforrester: [C: 032] "Thanks, Ed." [oojs/ui] - 10https://gerrit.wikimedia.org/r/185415 (https://phabricator.wikimedia.org/T86003) (owner: 10Esanders) [19:12:29] Krenair: so.. https://gerrit.wikimedia.org/r/#/c/182988 [19:12:56] my concern is that the data is updated async, but no event is emitted or promise resolved [19:13:03] 3OOjs-UI: MediaWiki theme: Checkboxes and radios look oversized on desktop - https://phabricator.wikimedia.org/T86003#982625 (10Jdforrester-WMF) a:3Esanders [19:13:13] 3OOjs-UI: MediaWiki theme: Checkboxes and radios look oversized on desktop - https://phabricator.wikimedia.org/T86003#982627 (10Jdforrester-WMF) 5Open>3Resolved [19:13:21] (03CR) 10Mooeypoo: [C: 04-1] "Actually, from my tests, you seem to have landed onto something a little more complicated than what you're trying to fix." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/184440 (https://phabricator.wikimedia.org/T69794) (owner: 10Ricordisamoa) [19:13:26] so, callers of getLookupRequest won't be able to know when is a good time to call that method [19:14:18] Krenair: now that I look at the whole file, I'm thinking you are right [19:15:52] because the interwikiPrefixesPromise is being used to ensure this [19:16:46] (03CR) 10Trevor Parscal: [C: 032] Mark interwiki links as known in LinkTargetInputWidget (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/182988 (https://phabricator.wikimedia.org/T72504) (owner: 10Alex Monk) [19:17:26] (03Merged) 10jenkins-bot: MediaWiki theme: Reduce size of checkboxes and radio buttons by 20% [oojs/ui] - 10https://gerrit.wikimedia.org/r/185415 (https://phabricator.wikimedia.org/T86003) (owner: 10Esanders) [19:18:49] (03Merged) 10jenkins-bot: Mark interwiki links as known in LinkTargetInputWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/182988 (https://phabricator.wikimedia.org/T72504) (owner: 10Alex Monk) [19:21:29] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: [Regression wmf1] When the inspector is still open for a selected node, after placing the cursor in a different position, inspector flickers there - https://phabricator.wikimedia.org/T73151#982645 (10Jdforrester-WMF) 5Resolved>3declined [19:21:53] 3VisualEditor-MediaWiki, VisualEditor, Math: Document how to enable the Math plugin for VisualEditor - https://phabricator.wikimedia.org/T86449#982646 (10Jdforrester-WMF) [19:22:20] 3VisualEditor, VisualEditor-ContentEditable: [Regression wmf13] After editing the caption field of an image, the image highlight gets shifted few pixels right - https://phabricator.wikimedia.org/T85844#982647 (10Jdforrester-WMF) [19:23:57] 3VisualEditor-MediaWiki, VisualEditor: [Regression wmf14] Response from parseFragment is blank content, meaning newly-inserted or -modified content is blank until saving - https://phabricator.wikimedia.org/T86046#982649 (10Jdforrester-WMF) [19:24:21] 3VisualEditor-MediaWiki, VisualEditor, VisualEditor-MediaWiki-References: [Regression pre-wmf14] While trying to open Re-use Reference dialog immediately after inserting a citation (not basic reference), throws the TypeError: Cannot read property 'length' of null and the newly added citation does not appear in the... [19:24:24] (03CR) 10Trevor Parscal: [C: 032] Unwrap slug wrappers when converting to a real paragraph [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/185193 (https://phabricator.wikimedia.org/T85948) (owner: 10Esanders) [19:24:49] 3VisualEditor-MediaWiki, VisualEditor: In category input field, typing invalid category name doesn't clear suggestions - https://phabricator.wikimedia.org/T76868#982653 (10Jdforrester-WMF) [19:25:12] 3VisualEditor, VisualEditor-ContentEditable: [Regression pre-wmf12] Pressing return on CE is not adding newline in Firefox - https://phabricator.wikimedia.org/T77905#982654 (10Jdforrester-WMF) [19:25:19] (03CR) 10Trevor Parscal: [C: 032] Add ve.dm.Transaction.newNoOp() constructor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151783 (owner: 10Cscott) [19:25:48] 3VisualEditor-MediaWiki-Mobile, VisualEditor: [Regression wmf5] The wikitext editor does not show any wikitext for any page when switching from mobile VE in test2 and Beta Labs - https://phabricator.wikimedia.org/T74571#982655 (10Jdforrester-WMF) [19:26:05] 3VisualEditor-MediaWiki, VisualEditor, VisualEditor-Performance: LinkCache sends API requests for URL-encoded page names, gets "invalid" responses back when descending into template contents - https://phabricator.wikimedia.org/T75823#982658 (10Jdforrester-WMF) [19:26:34] (03CR) 10Jaredzimmerman: "Uh, hey, folks, does this affect the visual size of the component or only its margins? if it is the visual size…" [oojs/ui] - 10https://gerrit.wikimedia.org/r/185415 (https://phabricator.wikimedia.org/T86003) (owner: 10Esanders) [19:29:18] (03CR) 10jenkins-bot: [V: 04-1] Unwrap slug wrappers when converting to a real paragraph [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/185193 (https://phabricator.wikimedia.org/T85948) (owner: 10Esanders) [19:32:26] 3OOjs-UI: MediaWiki theme: Checkboxes and radios look oversized on desktop - https://phabricator.wikimedia.org/T86003#982674 (10violetto) I can see the difference in relative to the "before" image. However, I'd argue it's not big enough of a difference to have height inconsistency. The "before" image has a few p... [19:47:51] (03PS2) 10Jforrester: Unwrap slug wrappers when converting to a real paragraph [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/185193 (https://phabricator.wikimedia.org/T85948) (owner: 10Esanders) [19:47:59] (03CR) 10Jforrester: [C: 032] "Cue Jenkins." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/185193 (https://phabricator.wikimedia.org/T85948) (owner: 10Esanders) [19:52:11] (03CR) 10jenkins-bot: [V: 04-1] Unwrap slug wrappers when converting to a real paragraph [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/185193 (https://phabricator.wikimedia.org/T85948) (owner: 10Esanders) [19:53:27] 3Wikimedia-Site-requests, VisualEditor: Please enable VisualEditor in hewiki's "Draft" namespace - https://phabricator.wikimedia.org/T87027#982760 (10Jdforrester-WMF) p:5Triage>3Normal a:3Glaisher [19:53:50] 3VisualEditor-MediaWiki, VisualEditor: Closing welcome dialog also hides important edit notices - https://phabricator.wikimedia.org/T86987#982765 (10Jdforrester-WMF) p:5Triage>3Normal [19:54:53] 3VisualEditor-MediaWiki, VisualEditor: No php-curl => no VisualEditor – error loading data from server: parsererror , when using new ParsoidVirtualRESTService - https://phabricator.wikimedia.org/T86447#982771 (10Jdforrester-WMF) 5Open>3Resolved p:5Triage>3Normal [19:56:04] 3VisualEditor: Template parameters without values cannot be added - https://phabricator.wikimedia.org/T86421#982776 (10Jdforrester-WMF) 5Open>3Resolved a:3Jdforrester-WMF [19:56:34] 3VisualEditor, VisualEditor-ContentEditable: [Regression wmf13] After editing the caption field of an image, the image highlight gets shifted few pixels right - https://phabricator.wikimedia.org/T85844#982783 (10Ryasmeen) Verified the fix in test2 [19:58:39] 3OOjs-UI: MediaWiki theme: Checkboxes and radios look oversized on desktop - https://phabricator.wikimedia.org/T86003#982802 (10violetto) I want to point out that monitor screens aren't restricted to interactions with mouse and keyboards anymore. It's true that traditionally radio buttons and checkboxes are smal... [20:12:52] 3VisualEditor, VisualEditor-ContentEditable: [Regression pre-wmf12] Pressing return on CE is not adding newline in Firefox - https://phabricator.wikimedia.org/T77905#982845 (10Ryasmeen) Verified in test2 and en.wiki [20:13:13] 3VisualEditor, VisualEditor-ContentEditable: [Regression pre-wmf12] Pressing return on CE is not adding newline in Firefox - https://phabricator.wikimedia.org/T77905#982846 (10Ryasmeen) [20:28:13] 3VisualEditor-MediaWiki-Mobile, VisualEditor: [Regression wmf5] The wikitext editor does not show any wikitext for any page when switching from mobile VE in test2 and Beta Labs - https://phabricator.wikimedia.org/T74571#982883 (10Ryasmeen) 5Resolved>3Open [20:35:17] (03PS2) 10Bartosz Dziewoński: Introduce DropdownInputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/185376 (https://phabricator.wikimedia.org/T86393) [20:36:17] (03CR) 10jenkins-bot: [V: 04-1] Introduce DropdownInputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/185376 (https://phabricator.wikimedia.org/T86393) (owner: 10Bartosz Dziewoński) [20:39:09] 3VisualEditor-MediaWiki-Mobile, VisualEditor: [Regression wmf5] The wikitext editor does not show any wikitext for any page when switching from mobile VE in test2 and Beta Labs - https://phabricator.wikimedia.org/T74571#982901 (10Krenair) I wonder if this is just T86951 [20:41:54] (03PS3) 10Bartosz Dziewoński: Introduce DropdownInputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/185376 (https://phabricator.wikimedia.org/T86393) [20:45:37] (03CR) 10jenkins-bot: [V: 04-1] Introduce DropdownInputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/185376 (https://phabricator.wikimedia.org/T86393) (owner: 10Bartosz Dziewoński) [21:36:07] 3VisualEditor-MediaWiki-Mobile, VisualEditor: [Regression wmf5] The wikitext editor does not show any wikitext for any page when switching from mobile VE in test2 and Beta Labs - https://phabricator.wikimedia.org/T74571#983047 (10Ryasmeen) No I tried it on en.wiki, could not test in Betalabs since it is down [21:37:26] 3VisualEditor-MediaWiki, VisualEditor, MediaWiki-ContentHandler: Add support in JsonContent for non-object structures (e.g. array) - https://phabricator.wikimedia.org/T86270#983055 (10Jdforrester-WMF) [21:38:19] (03PS4) 10Bartosz Dziewoński: Introduce DropdownInputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/185376 (https://phabricator.wikimedia.org/T86393) [21:46:56] (03PS5) 10Bartosz Dziewoński: Introduce DropdownInputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/185376 (https://phabricator.wikimedia.org/T86393) [21:49:50] 3OOjs-UI: MediaWiki theme: Checkboxes and radios look oversized on desktop - https://phabricator.wikimedia.org/T86003#983087 (10Esanders) 1em is relative to the browser default (16px) - we just choose our default to be smaller than the browser default, but that is applied to the wrapper so everything scale relat... [21:54:01] (03PS6) 10Bartosz Dziewoński: Introduce DropdownInputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/185376 (https://phabricator.wikimedia.org/T86393) [22:01:44] (03PS7) 10Bartosz Dziewoński: Introduce DropdownInputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/185376 (https://phabricator.wikimedia.org/T86393) [22:02:48] (03PS1) 10Krinkle: Temporarily disable JSON content type on visualeditor-cite-tool-definition.json [extensions/VisualEditor] (wmf/1.25wmf15) - 10https://gerrit.wikimedia.org/r/185556 [22:04:08] 3VisualEditor-MediaWiki, VisualEditor, MediaWiki-ContentHandler: Add support in JsonContent for non-object structures (e.g. array) - https://phabricator.wikimedia.org/T86270#983117 (10Ryasmeen) [22:04:10] (03PS1) 10Jforrester: Revert "Temporarily disable JSON content type on visualeditor-cite-tool-definition.json" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185557 [22:06:40] 3OOjs-UI, UI-Standardization: OOjs UI: Be able to resurrect OOUI PHP widgets into OOjs UI widgets - https://phabricator.wikimedia.org/T74716#983126 (10matmarex) I don't like the word "resurrect" for this, the widgets ain't dead. Better words include "reconstitute" or "infuse" (as in, //infuse with JavaScript beh... [22:07:29] reverting things that aren't even merged? :P [22:08:03] legoktm: clearly you're not agile enough [22:08:12] to understand [22:08:12] :> [22:09:26] oh different branches [22:17:22] (03CR) 10Ricordisamoa: "> Not in VisualEditor they won't; we don't support that feature, and won't for a long while." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185220 (https://phabricator.wikimedia.org/T53032) (owner: 10Mooeypoo) [22:20:46] 3MediaWiki-Page-editing: Automatical merge of conflicting non-section edits to unintersecting sets of sections - https://phabricator.wikimedia.org/T2980#983168 (10Nemo_bis) [22:22:17] 3MediaWiki-Page-editing: Edit conflicts (tracking) - https://phabricator.wikimedia.org/T72163#983182 (10Nemo_bis) [22:22:18] 3MediaWiki-Page-editing: Automatical merge of conflicting non-section edits to unintersecting sets of sections - https://phabricator.wikimedia.org/T2980#36693 (10Nemo_bis) [22:26:36] (03PS20) 10Paladox: Re add svg images [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (https://phabricator.wikimedia.org/T37342) [22:28:52] (03CR) 10MarkTraceur: "Why do you persist in rebasing every patch every week? You have been told, over and over again, that it is disruptive and unnecessary." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (https://phabricator.wikimedia.org/T37342) (owner: 10Paladox) [22:34:15] (03CR) 10Ricordisamoa: "@Mooeypoo: have you tried to null-edit the template page to purge the server cache? It worked for me." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/184440 (https://phabricator.wikimedia.org/T69794) (owner: 10Ricordisamoa) [22:34:24] (03PS1) 10Bartosz Dziewoński: TextInputWidget: Accept 'maxLength' configuration option [oojs/ui] - 10https://gerrit.wikimedia.org/r/185563 [22:37:11] (03CR) 10Ricordisamoa: TextInputWidget: Accept 'maxLength' configuration option (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/185563 (owner: 10Bartosz Dziewoński) [22:42:25] (03CR) 10jenkins-bot: [V: 04-1] TextInputWidget: Accept 'maxLength' configuration option [oojs/ui] - 10https://gerrit.wikimedia.org/r/185563 (owner: 10Bartosz Dziewoński) [22:44:16] (03CR) 10Mooeypoo: "That did it, apologies. Apparently my local server caches a bit too aggressively." (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/184440 (https://phabricator.wikimedia.org/T69794) (owner: 10Ricordisamoa) [22:58:13] (03PS2) 10Ricordisamoa: Show "no description" in italic grey also for deprecated parameters [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/184440 (https://phabricator.wikimedia.org/T69794) [22:58:18] (03CR) 10Ricordisamoa: Show "no description" in italic grey also for deprecated parameters (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/184440 (https://phabricator.wikimedia.org/T69794) (owner: 10Ricordisamoa) [23:00:28] 3OOjs-UI: MediaWiki theme: Checkboxes and radios look oversized on desktop - https://phabricator.wikimedia.org/T86003#983266 (10violetto) I see. What do you think is the blocker or issue if we used 16px (1em) for the labels instead of 12.8 (.8em)? [23:07:53] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: If you click out of a link inspector to somewhere else in the document, the link gets inserted and selected, moving your cursor away from where you clicked - https://phabricator.wikimedia.org/T70590#983275 (10Etonkovidova) Re-tested the original scenario(pr... [23:20:33] 3MediaWiki-Internationalization, MediaWiki-Page-editing: Vertical writing support in MediaWiki - https://phabricator.wikimedia.org/T11436#983282 (10Nemo_bis) [23:21:29] 3OOjs-UI: MediaWiki theme: Checkboxes and radios look oversized on desktop - https://phabricator.wikimedia.org/T86003#983284 (10Esanders) Then the labels would have a different font size to all the other text on the page. [23:27:24] (03PS3) 10Mooeypoo: Add a layout queue to media result widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185453 (https://phabricator.wikimedia.org/T86802) [23:32:44] 3VisualEditor: Possibly unintended splitting of a table into two tables using VE - https://phabricator.wikimedia.org/T64510#983308 (10Etonkovidova) Any specific steps that resulted in a broken table? And the table was edited **only** in VE? [23:35:37] 3OOjs-UI: MediaWiki theme: Checkboxes and radios look oversized on desktop - https://phabricator.wikimedia.org/T86003#983309 (10violetto) Gotcha. I hear @jdlrobson might know the rationale or reason why we've been using 0.8em instead of 1em on body text size. I would think using 1em is a better idea, gives us... [23:46:53] (03PS4) 10Mooeypoo: Add a layout queue to media result widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185453 (https://phabricator.wikimedia.org/T86802) [23:55:22] 3VisualEditor: VisualEditor: Hatnote cleanup problem - https://phabricator.wikimedia.org/T58234#983328 (10Etonkovidova) Re-checked: seems that it's not happening anymore - look at the screenshots {F29287} {F29290}. Closing as Invalid. [23:55:40] 3VisualEditor: VisualEditor: Hatnote cleanup problem - https://phabricator.wikimedia.org/T58234#983329 (10Etonkovidova) 5Open>3Invalid [23:59:48] TrevorParscal: https://phabricator.wikimedia.org/T86867 OK?