[00:29:56] (03PS5) 10Anishvisa: new file: test_files/ID_training_data.json IDs for tests [services/citoid] - 10https://gerrit.wikimedia.org/r/185837 [01:02:07] (03CR) 10Jforrester: [C: 032] Actually perform interwiki check in MWLinkTargetInputWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185925 (https://phabricator.wikimedia.org/T72504) (owner: 10Alex Monk) [01:04:04] (03Merged) 10jenkins-bot: Actually perform interwiki check in MWLinkTargetInputWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185925 (https://phabricator.wikimedia.org/T72504) (owner: 10Alex Monk) [01:08:06] (03CR) 10Bartosz Dziewoński: [C: 032] "Bah, didn't I fix these?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185930 (https://phabricator.wikimedia.org/T86827) (owner: 10Alex Monk) [01:09:54] (03Merged) 10jenkins-bot: Don't add __STATICREDIRECT__ whenever the user sets up redirect details [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185930 (https://phabricator.wikimedia.org/T86827) (owner: 10Alex Monk) [02:50:30] 3MediaWiki-extensions-ProofreadPage, MediaWiki-Page-editing: Implement a rotate page image view function for pages being viewed when editing in the Page Namespace. - https://phabricator.wikimedia.org/T87017#986311 (10ShakespeareFan00) 5Open>3declined a:3ShakespeareFan00 I'm closing this (for now) on the ba... [04:37:59] (03PS1) 10Esanders: Create InlineLabelTextInputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/185956 [06:11:06] (03PS1) 10Bartosz Dziewoński: Kill grey dialog on find-and-replace dialog in MediaWiki theme [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/185960 (https://phabricator.wikimedia.org/T87125) [06:15:40] 3VisualEditor: Expand cryptic two-character directory names in the source tree - https://phabricator.wikimedia.org/T87158#986372 (10matmarex) I'm feeling somewhat meh about this. [06:16:42] 3VisualEditor: Expand cryptic two-character directory names in the source tree - https://phabricator.wikimedia.org/T87158#986374 (10ori) >>! In T87158#986372, @matmarex wrote: > I'm feeling somewhat meh about this. Surely you mean "me". [06:17:01] heh [07:00:48] oh gods, this is some evil code [07:01:39] we basically pass data between places using mw.messages.set D: [07:05:19] 3VisualEditor: ve.init.mw.ViewPageTarget.prototype.onSaveErrorNewUser is evil - https://phabricator.wikimedia.org/T87219#986381 (10matmarex) 3NEW [07:10:07] 3VisualEditor: ve.init.mw.ViewPageTarget.prototype.onSaveErrorNewUser is evil - https://phabricator.wikimedia.org/T87219#986392 (10matmarex) [08:52:12] 3VisualEditor-MediaWiki-Templates, VisualEditor: Link to doc when template subst - https://phabricator.wikimedia.org/T86705#986479 (10Sunpriat) [09:13:18] 3VisualEditor, VisualEditor-ContentEditable: Sometimes linebreaks added when adding a file - https://phabricator.wikimedia.org/T87227#986508 (10Raymond) 3NEW [11:50:01] * ori yawns [12:45:37] (03CR) 10Mvolz: [C: 04-1] new file: test_files/ID_training_data.json IDs for tests (031 comment) [services/citoid] - 10https://gerrit.wikimedia.org/r/185837 (owner: 10Anishvisa) [14:02:17] 3VisualEditor, VisualEditor-Tables: "Delete row"/"Delete column" are not pluralized when multiple rows/columns are selected - https://phabricator.wikimedia.org/T87234#986652 (10Yair_rand) 3NEW [16:09:36] Morning. [16:40:13] 3OOjs-UI: Create a text input widget that can have a label within the input area - https://phabricator.wikimedia.org/T87239#986722 (10Esanders) 3NEW a:3Esanders [16:41:10] (03PS2) 10Esanders: Create InlineLabelTextInputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/185956 (https://phabricator.wikimedia.org/T87239) [16:45:10] (03CR) 10Jforrester: [C: 031] Add keyboard commands for find next/replace [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/185688 (https://phabricator.wikimedia.org/T87113) (owner: 10Esanders) [16:46:13] edsanders: https://gerrit.wikimedia.org/r/#/c/185960/ https://gerrit.wikimedia.org/r/#/c/179002/ https://gerrit.wikimedia.org/r/#/c/184379/ https://gerrit.wikimedia.org/r/#/c/185225/ [16:47:45] (03CR) 10Esanders: [C: 04-1] Kill grey dialog on find-and-replace dialog in MediaWiki theme (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/185960 (https://phabricator.wikimedia.org/T87125) (owner: 10Bartosz Dziewoński) [16:49:00] (03PS1) 10Jforrester: Don't add __STATICREDIRECT__ whenever the user sets up redirect details [extensions/VisualEditor] (wmf/1.25wmf15) - 10https://gerrit.wikimedia.org/r/185991 (https://phabricator.wikimedia.org/T86827) [16:49:12] (03PS1) 10Jforrester: Don't add __STATICREDIRECT__ whenever the user sets up redirect details [extensions/VisualEditor] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/185992 (https://phabricator.wikimedia.org/T86827) [16:49:36] (03PS1) 10Esanders: Remove border from mw searchwidget now dialogs have outline [oojs/ui] - 10https://gerrit.wikimedia.org/r/185993 [16:49:45] 3VisualEditor-MediaWiki, VisualEditor: [Regression] __STATICREDIRECT__ is set when user sets a redirect, regardless whether the user ticks the box to set it - https://phabricator.wikimedia.org/T86827#986751 (10Jdforrester-WMF) [16:51:01] (03PS2) 10Jforrester: MediaWiki theme: Remove SearchWidget's border now dialogs have outline [oojs/ui] - 10https://gerrit.wikimedia.org/r/185993 (owner: 10Esanders) [16:51:12] (03CR) 10Jforrester: [C: 032] MediaWiki theme: Remove SearchWidget's border now dialogs have outline [oojs/ui] - 10https://gerrit.wikimedia.org/r/185993 (owner: 10Esanders) [16:52:05] (03CR) 10Esanders: "Would like Roan to check the promises" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/179002 (https://phabricator.wikimedia.org/T76926) (owner: 10Alex Monk) [16:52:45] (03CR) 10Esanders: [C: 032] Don't load OOjs UI i18n strings as core does this already [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/184379 (owner: 10Jforrester) [16:52:57] (03Merged) 10jenkins-bot: MediaWiki theme: Remove SearchWidget's border now dialogs have outline [oojs/ui] - 10https://gerrit.wikimedia.org/r/185993 (owner: 10Esanders) [16:54:33] (03Merged) 10jenkins-bot: Don't load OOjs UI i18n strings as core does this already [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/184379 (owner: 10Jforrester) [17:03:38] 3VisualEditor-MediaWiki, VisualEditor: [Regression] __STATICREDIRECT__ is set when user sets a redirect, regardless whether the user ticks the box to set it - https://phabricator.wikimedia.org/T86827#986762 (10Jdforrester-WMF) a:3Krenair [17:06:28] (03CR) 10Esanders: [C: 04-1] Lazy load the media search results (036 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185225 (owner: 10Mooeypoo) [17:19:41] (03PS2) 10Jforrester: Adapt the type input to work with the new ooui getMenu() [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/185693 (https://phabricator.wikimedia.org/T86922) (owner: 10Mooeypoo) [17:19:54] edsanders: And https://gerrit.wikimedia.org/r/#/c/185693/ please. :-) [17:20:56] (03PS3) 10Jforrester: Allow the restoration of a deleted parameter in the edit dialog [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/182980 (https://phabricator.wikimedia.org/T86916) (owner: 10Mooeypoo) [17:30:38] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=34020917 [17:30:38] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=34022377 [17:30:38] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=68057840 [17:30:38] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=68066370 [17:30:38] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=68066481 [17:30:38] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=68066540 [17:30:39] Corruption alert: visualeditor-needcheck on trwiki: https://tr.wikipedia.org/?diff=15030607 [17:31:58] (03CR) 10Esanders: [C: 032] Adapt the type input to work with the new ooui getMenu() [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/185693 (https://phabricator.wikimedia.org/T86922) (owner: 10Mooeypoo) [17:32:39] (03Merged) 10jenkins-bot: Adapt the type input to work with the new ooui getMenu() [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/185693 (https://phabricator.wikimedia.org/T86922) (owner: 10Mooeypoo) [17:33:11] (03PS1) 10Jforrester: Adapt the type input to work with the new ooui getMenu() [extensions/TemplateData] (wmf/1.25wmf15) - 10https://gerrit.wikimedia.org/r/185998 (https://phabricator.wikimedia.org/T86922) [17:33:20] (03PS1) 10Jforrester: Adapt the type input to work with the new ooui getMenu() [extensions/TemplateData] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/185999 (https://phabricator.wikimedia.org/T86922) [17:33:39] (03PS2) 10Esanders: Add keyboard commands for find next/replace [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/185688 (https://phabricator.wikimedia.org/T87113) [17:46:17] 3VisualEditor: “Uncaught Error: ve.dm.Document.getBranchNodeFromOffset(): offset 14 is out of bounds”, when inserting a media with caption , keeping Gallery inspector open. - https://phabricator.wikimedia.org/T87243#986820 (10Swainr) 3NEW [17:46:44] edsanders: https://gerrit.wikimedia.org/r/#/c/185335/ https://gerrit.wikimedia.org/r/#/c/185576/ https://gerrit.wikimedia.org/r/#/c/185376/ https://gerrit.wikimedia.org/r/#/c/185563/ [17:49:09] 3VisualEditor, VisualEditor-Tables, VisualEditor-ContentEditable: It's possible to delete a table's rows and columns but not the table, which is now invisible in VE but retains the wikitext - https://phabricator.wikimedia.org/T71706#986828 (10Jdforrester-WMF) 5Open>3Resolved a:3Esanders [17:49:11] 3VisualEditor, VisualEditor-EditingTools, VisualEditor-Tables: Support tables (tracking) - https://phabricator.wikimedia.org/T41596#986831 (10Jdforrester-WMF) [17:50:54] 3VisualEditor, VisualEditor-Tables: "Delete row"/"Delete column" messages are not pluralized when multiple rows/columns are selected (but they do delete multiple rows/columns) - https://phabricator.wikimedia.org/T87234#986832 (10Jdforrester-WMF) p:5Triage>3Normal [17:54:00] 3VisualEditor, VisualEditor-Tables: "Delete row"/"Delete column" messages are not pluralized when multiple rows/columns are selected (but they do delete multiple rows/columns) - https://phabricator.wikimedia.org/T87234#986839 (10Jdforrester-WMF) p:5Normal>3Triage [17:54:18] 3VisualEditor, VisualEditor-Tables: "Delete row"/"Delete column" messages do not use the plural when multiple rows/columns are selected (but they do delete multiple rows/columns) - https://phabricator.wikimedia.org/T87234#986840 (10Jdforrester-WMF) p:5Triage>3Normal [17:56:17] (03PS1) 10Legoktm: Fix spacing [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/186002 [17:56:19] (03PS1) 10Legoktm: Add dependency upon JSON polyfill [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/186003 [17:56:21] (03PS1) 10Legoktm: Use JSON content model for "citoid-template-type-map.json" message [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/186004 [17:57:42] (03CR) 10Jforrester: [C: 032] Fix spacing [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/186002 (owner: 10Legoktm) [17:57:49] (03Merged) 10jenkins-bot: Fix spacing [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/186002 (owner: 10Legoktm) [17:57:58] (03CR) 10Jforrester: [C: 032] Add dependency upon JSON polyfill [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/186003 (owner: 10Legoktm) [17:58:07] (03Merged) 10jenkins-bot: Add dependency upon JSON polyfill [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/186003 (owner: 10Legoktm) [17:58:32] (03CR) 10Jforrester: [C: 031] Use JSON content model for "citoid-template-type-map.json" message [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/186004 (owner: 10Legoktm) [17:58:44] that was fast :> [17:59:46] (03CR) 10Legoktm: "I didn't test this one, just took the code from VE. I'm not sure if anything will be different since the message doesn't exist by default." [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/186004 (owner: 10Legoktm) [18:00:05] (03PS2) 10Bartosz Dziewoński: Kill grey border on find-and-replace dialog in MediaWiki theme [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/185960 (https://phabricator.wikimedia.org/T87125) [18:00:07] 3VisualEditor-MediaWiki-Templates, VisualEditor: Link to doc when template subst - https://phabricator.wikimedia.org/T86705#986849 (10Krenair) I think that we have a task somewhere else to allow users to determine substitution status properly (i.e. with an actual input control), rather than having to append 'sub... [18:00:11] (03CR) 10Bartosz Dziewoński: Kill grey border on find-and-replace dialog in MediaWiki theme (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/185960 (https://phabricator.wikimedia.org/T87125) (owner: 10Bartosz Dziewoński) [18:06:30] (03CR) 10Esanders: [C: 032] Kill grey border on find-and-replace dialog in MediaWiki theme [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/185960 (https://phabricator.wikimedia.org/T87125) (owner: 10Bartosz Dziewoński) [18:09:23] (03Merged) 10jenkins-bot: Kill grey border on find-and-replace dialog in MediaWiki theme [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/185960 (https://phabricator.wikimedia.org/T87125) (owner: 10Bartosz Dziewoński) [18:17:09] 3VisualEditor-EditingTools, VisualEditor: Add some more keyboard shortcuts for VisualEditor's built-in Search and Replace system - https://phabricator.wikimedia.org/T87113#986874 (10Jdforrester-WMF) a:3Esanders [18:17:59] 3VisualEditor, VisualEditor-CopyPaste: When the user pastes in an , we should probably convert it to an ? - https://phabricator.wikimedia.org/T85377#986882 (10Jdforrester-WMF) p:5Low>3Normal [18:18:02] 3VisualEditor-MediaWiki-Templates, VisualEditor: Removing stub template removes too many lines - https://phabricator.wikimedia.org/T57856#986885 (10Jdforrester-WMF) p:5Low>3Normal [18:24:00] 3VisualEditor, MediaWiki-Templates, VisualEditor-Tables: Support editing table cells whose formatting is defined by a template - https://phabricator.wikimedia.org/T85648#986897 (10Jdforrester-WMF) [18:24:48] 3VisualEditor-MediaWiki-Templates, VisualEditor, VisualEditor-Tables: Support the editing of "tables" that are composed of templates - https://phabricator.wikimedia.org/T85462#986899 (10Jdforrester-WMF) p:5Triage>3Low [18:25:28] (03CR) 10Jforrester: [C: 031] MWMediaDialog: Make the dialog bigger when searching for media to insert [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185575 (https://phabricator.wikimedia.org/T86397) (owner: 10Jforrester) [18:28:09] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Initial (PHP-rendered) template display misaligned in Firefox - https://phabricator.wikimedia.org/T53252#986905 (10Jdforrester-WMF) 5Open>3Resolved a:3Jdforrester-WMF Looks fine to me now? [18:31:24] (03CR) 10Mvolz: [C: 031 V: 031] "I tested this and can confirm this does not break anything." [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/186004 (owner: 10Legoktm) [18:37:35] (03PS1) 10Gerrit Patch Uploader: Support fallback languages for icons [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/186006 (https://phabricator.wikimedia.org/T87247) [18:37:38] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/186006 (https://phabricator.wikimedia.org/T87247) (owner: 10Gerrit Patch Uploader) [18:42:24] (03CR) 10Jforrester: [C: 032] "No need to "vote" on Verified; that's jenkins-bot's job." [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/186004 (owner: 10Legoktm) [18:42:26] (03PS7) 10Bartosz Dziewoński: Introduce and use TabIndexedElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/183718 [18:42:33] (03Merged) 10jenkins-bot: Use JSON content model for "citoid-template-type-map.json" message [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/186004 (owner: 10Legoktm) [18:42:46] 3VisualEditor: Media Settings images in the first row are displayed without upper borders - https://phabricator.wikimedia.org/T87249#986958 (10Etonkovidova) 3NEW [18:43:55] (03CR) 10jenkins-bot: [V: 04-1] Introduce and use TabIndexedElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/183718 (owner: 10Bartosz Dziewoński) [18:44:39] for mooeypoo: the bug we were talking about - is filed: 87249 [18:44:42] (03CR) 10Fomafix: "The 'default' icons for bold and italic (**A** and //A//) get never used for LTR languages because all languages fallback to 'en' and show" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/186006 (https://phabricator.wikimedia.org/T87247) (owner: 10Gerrit Patch Uploader) [18:45:40] (03CR) 10Nemo bis: Support fallback languages for icons (031 comment) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/186006 (https://phabricator.wikimedia.org/T87247) (owner: 10Gerrit Patch Uploader) [18:52:44] (03CR) 10Bartosz Dziewoński: "Why not just do this in TextInputWidget?" [oojs/ui] - 10https://gerrit.wikimedia.org/r/185956 (https://phabricator.wikimedia.org/T87239) (owner: 10Esanders) [18:56:26] James_F: Jenkins inteface language was Turkish and 'gallium' slave was down. Both resolved. [18:56:29] edsanders: https://www.mediawiki.org/wiki/VisualEditor/Design/Reference_Dialog#mediaviewer/File:Magic_cite2-02.png etc. [18:56:32] what issue were you seeing exactly? [18:56:34] Krinkle: I know. Thanks. [18:56:52] Krinkle: It was MatmaRex who was asking for you. I just have a louder voice so echoed him so you'd hear. [18:57:12] Krinkle: Where are my unit tests? :-) [18:57:12] James_F: On wikitech (could be outdated) editing a table cell and pressing "Tab" key bring me to "Krinkle" (personal portlet link). That's wrong. [18:57:25] Thx [18:58:28] Krinkle: Ed knows. [19:01:10] James_F: VE should be hard-disabled on wikitech or fixed... [19:01:25] Krinkle: Roan knows. [19:01:26] I've already lost like 3 different edits over the past week and re-doing them in wikitext.. [19:01:36] Why would anyone need it on wikitech? [19:01:46] config change takes 1 minute. Clearly fixing is not a priority. [19:05:55] Krinkle: Because no-one will answer questions about it. [19:10:24] James_F: https://phabricator.wikimedia.org/T78161 - Show media search results more pleasingly, with meta-data details available- really closed? the final design is somewhat different... [19:10:33] etonkovidova: Yes. [19:10:38] etonkovidova: Designs change. :-) [19:10:50] great.tahnks. [19:16:03] 3VisualEditor, VisualEditor-Performance: ve.init.mw.Target.startSanityCheck needs a sanity-check - https://phabricator.wikimedia.org/T87161#987065 (10ori) Notes from discussing this w/Roan: * The reason we call oo.copy as part of ve.init.mw.Target.startSanityCheck is that we can't perform a sanity-check once th... [19:16:15] 3VisualEditor, VisualEditor-Performance: ve.init.mw.Target.startSanityCheck needs a sanity-check - https://phabricator.wikimedia.org/T87161#987066 (10ori) a:3Catrope [19:17:12] 3VisualEditor, VisualEditor-Performance: ~200ms spent on CSSStyleDeclaration.getPropertyValue() - https://phabricator.wikimedia.org/T87160#987068 (10ori) a:3Krinkle [19:18:22] 3VisualEditor, VisualEditor-Performance: ve.init.mw.Target.startSanityCheck needs a sanity-check - https://phabricator.wikimedia.org/T87161#987070 (10Jdforrester-WMF) p:5Triage>3High [19:20:35] (03CR) 10Catrope: [C: 04-1] Add keyboard commands for find next/replace (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/185688 (https://phabricator.wikimedia.org/T87113) (owner: 10Esanders) [19:29:06] (03CR) 10Mooeypoo: Lazy load the media search results (035 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185225 (owner: 10Mooeypoo) [19:30:09] (03PS8) 10Mooeypoo: Lazy load the media search results [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185225 [19:35:40] (03PS3) 10Mooeypoo: When changing image source, use already-available API info [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185589 [19:36:24] James_F, shall we schedule https://gerrit.wikimedia.org/r/#/c/185991/ and https://gerrit.wikimedia.org/r/#/c/185992/ for the midnight SWAT then? [19:38:46] 3OOjs-UI, UI-Standardization: Shadow at the bottom of buttons, dropdown menus is intentionally vertically mis-aligned by a pixel or two in the MediaWiki theme - https://phabricator.wikimedia.org/T78083#987160 (10Etonkovidova) Verified in betalabs - shadow does not overlap the border; the corners are rounded. [19:40:43] (03PS4) 10Mooeypoo: When changing image source, use already-available API info [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185589 [19:41:52] (03CR) 10Catrope: "Ctrl+G, Shift+Ctrl+G, F3 and Shift+F3 do not appear to be captured from within the find&replace area in VE-MW (works in VE core though)." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/185688 (https://phabricator.wikimedia.org/T87113) (owner: 10Esanders) [19:46:32] Krenair: I was just going to get Reedy or whoever to do them when needed. [19:49:46] Krenair: Would you be prepared to do them now? :-) [19:49:57] James_F: https://phabricator.wikimedia.org/T78083 Shadow at the bottom of buttons, dropdown menus is intentionally vertically mis-aligned by a pixel or two in the MediaWiki theme - seems to still be present in FF :( [19:50:01] I can do it now if necessary [19:50:11] what's this templatedata one? [19:50:16] Krenair: Cool; let's get a 'go' from DevOps though. :-) [19:50:17] (03CR) 10Mooeypoo: [C: 032] "WFM and looks good" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185575 (https://phabricator.wikimedia.org/T86397) (owner: 10Jforrester) [19:51:01] Krenair: Re-adding a parameter that you've deleted in the middle of an edit. [19:52:13] (03Merged) 10jenkins-bot: MWMediaDialog: Make the dialog bigger when searching for media to insert [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185575 (https://phabricator.wikimedia.org/T86397) (owner: 10Jforrester) [19:53:13] 3VisualEditor-MediaWiki-Templates, VisualEditor: Link to doc when template subst - https://phabricator.wikimedia.org/T86705#987214 (10Jdforrester-WMF) [19:53:15] 3VisualEditor-EditingTools, VisualEditor: Support "substituting" templates in transclusion dialog - https://phabricator.wikimedia.org/T51904#987213 (10Jdforrester-WMF) [19:54:01] 3VisualEditor-MediaWiki-Templates, VisualEditor: Make the TemplateData fetch and fallback link work when the template is being substituted - https://phabricator.wikimedia.org/T86705#987225 (10Jdforrester-WMF) p:5Triage>3Low [19:54:09] 3VisualEditor-MediaWiki-Templates, VisualEditor: Make the TemplateData fetch and fallback link work when the template is being substituted - https://phabricator.wikimedia.org/T86705#974606 (10Jdforrester-WMF) p:5Low>3Triage [19:54:25] 3VisualEditor-MediaWiki-Templates, VisualEditor: Make the TemplateData fetch and fallback link work when the template is being substituted - https://phabricator.wikimedia.org/T86705#974606 (10Jdforrester-WMF) p:5Triage>3Low [19:55:35] (03CR) 10Alex Monk: [C: 032] Don't add __STATICREDIRECT__ whenever the user sets up redirect details [extensions/VisualEditor] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/185992 (https://phabricator.wikimedia.org/T86827) (owner: 10Jforrester) [19:55:57] (03CR) 10Alex Monk: [C: 032] Don't add __STATICREDIRECT__ whenever the user sets up redirect details [extensions/VisualEditor] (wmf/1.25wmf15) - 10https://gerrit.wikimedia.org/r/185991 (https://phabricator.wikimedia.org/T86827) (owner: 10Jforrester) [19:57:46] (03Merged) 10jenkins-bot: Don't add __STATICREDIRECT__ whenever the user sets up redirect details [extensions/VisualEditor] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/185992 (https://phabricator.wikimedia.org/T86827) (owner: 10Jforrester) [19:58:18] (03CR) 10Trevor Parscal: "I also feel like this might be better as a config option since it may want to be combined with other text input widget uses like combo box" [oojs/ui] - 10https://gerrit.wikimedia.org/r/185956 (https://phabricator.wikimedia.org/T87239) (owner: 10Esanders) [19:58:35] (03Merged) 10jenkins-bot: Don't add __STATICREDIRECT__ whenever the user sets up redirect details [extensions/VisualEditor] (wmf/1.25wmf15) - 10https://gerrit.wikimedia.org/r/185991 (https://phabricator.wikimedia.org/T86827) (owner: 10Jforrester) [19:59:48] (03CR) 10Trevor Parscal: [C: 032] TextInputWidget: Accept 'maxLength' configuration option [oojs/ui] - 10https://gerrit.wikimedia.org/r/185563 (owner: 10Bartosz Dziewoński) [20:02:02] Krinkle: You actually working on https://phabricator.wikimedia.org/T87160 "~200ms spent on CSSStyleDeclaration.getPropertyValue()"? [20:07:03] 3VisualEditor, VisualEditor-Performance: ~200ms spent on CSSStyleDeclaration.getPropertyValue() - https://phabricator.wikimedia.org/T87160#987273 (10Jdforrester-WMF) p:5Triage>3Unbreak! [20:07:39] mooeypoo: Plafond petit foyer GTG [20:07:47] 3VisualEditor: ve.init.mw.ViewPageTarget.prototype.onSaveErrorNewUser is evil - https://phabricator.wikimedia.org/T87219#987275 (10Jdforrester-WMF) p:5Triage>3Low [20:08:46] 3VisualEditor, VisualEditor-ContentEditable: Sometimes linebreaks added when adding a file - https://phabricator.wikimedia.org/T87227#987284 (10Jdforrester-WMF) It's very easy to do this, by making the caption be: " caption " Otherwise, I can't reproduce. Probably user error? [20:09:08] 3VisualEditor: ve.init.mw.ViewPageTarget.prototype.onSaveErrorNewUser is evil - https://phabricator.wikimedia.org/T87219#986381 (10Jdforrester-WMF) p:5Low>3Normal [20:09:55] 3VisualEditor, VisualEditor-ContentEditable: Allow to edit inputbox - https://phabricator.wikimedia.org/T78542#987292 (10Jdforrester-WMF) [20:09:58] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: Add support for (the equivalent of?) editintro and preload - https://phabricator.wikimedia.org/T51622#987293 (10Jdforrester-WMF) [20:11:37] 3VisualEditor, VisualEditor-ContentEditable: Sometimes linebreaks added when adding a file - https://phabricator.wikimedia.org/T87227#987295 (10Raymond) I would swear that I have not make this user error.... If no one else can reproduce it, please close this task. [20:12:30] 3VisualEditor, VisualEditor-EditingTools, VisualEditor-MediaWiki-References: VisualEditor: References inside galleries being displayed separately, inside the gallery, instead of in the correct block at the end of the page - https://phabricator.wikimedia.org/T74865#987296 (10Jdforrester-WMF) p:5T... [20:13:15] 3VisualEditor, VisualEditor-EditingTools: A number of VisualEditor dialogs do not cover full screen when 'full' size - https://phabricator.wikimedia.org/T76863#987302 (10Etonkovidova) Checked in beta(Chrome, Safari) - VE dialogs fill up the reduced browser window. [20:13:53] 3VisualEditor-MediaWiki, VisualEditor: Message 'visualeditor-dialog-transclusion-no-template-description' uses raw HTML - https://phabricator.wikimedia.org/T87131#987303 (10Jdforrester-WMF) p:5Triage>3Normal [20:14:52] 3VisualEditor, VisualEditor-EditingTools, VisualEditor-MediaWiki-References: VisualEditor: References inside galleries being displayed separately, inside the gallery, instead of in the correct block at the end of the page - https://phabricator.wikimedia.org/T74865#987309 (10Jdforrester-WMF) p:5L... [20:15:05] 3VisualEditor, VisualEditor-EditingTools, VisualEditor-MediaWiki-References: VisualEditor: References inside galleries being displayed separately, inside the gallery, instead of in the correct block at the end of the page - https://phabricator.wikimedia.org/T74865#770140 (10Jdforrester-WMF) p:5N... [20:15:26] James_F: Yes, I'll work on the CSS getPropertyValue issue [20:15:36] Krinkle: When? :-) [20:16:26] 3VisualEditor-MediaWiki-Templates, VisualEditor: [Regression?] In Multi-Template Transclusion dialog, a Template can take in two empty parameter fields. - https://phabricator.wikimedia.org/T87185#987312 (10Jdforrester-WMF) p:5Triage>3Normal [20:17:00] 3VisualEditor, VisualEditor-MediaWiki-Media, VisualEditor-MediaWiki-References: References in media captions do not appear in Re-Use Reference list - https://phabricator.wikimedia.org/T87134#987317 (10Jdforrester-WMF) [20:17:32] 3VisualEditor, VisualEditor-MediaWiki-Media, VisualEditor-MediaWiki-References: References in media captions do not appear in Re-Use Reference list - https://phabricator.wikimedia.org/T87134#984484 (10Jdforrester-WMF) p:5Triage>3Low [20:24:23] 3VisualEditor, Parsoid: Multi-paragraph
results in some paragraphs being alienated content - https://phabricator.wikimedia.org/T86794#987337 (10Jdforrester-WMF) [20:24:24] 3VisualEditor, VisualEditor-EditingTools: Blockquotes aren't ContentBranchNodes in reality, and our code shouldn't try to insist that they are - https://phabricator.wikimedia.org/T76426#987336 (10Jdforrester-WMF) [20:24:39] (03CR) 10Trevor Parscal: [C: 04-1] "Add a way to add/remove/clear items (all plural interfaces please) and address the comment I left and we're good." (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/185376 (https://phabricator.wikimedia.org/T86393) (owner: 10Bartosz Dziewoński) [20:24:47] 3VisualEditor, VisualEditor-EditingTools: Multi-paragraph
results in some paragraphs being alienated content - https://phabricator.wikimedia.org/T86794#987342 (10Jdforrester-WMF) p:5Triage>3Normal [20:26:36] 3VisualEditor: "Read more" link is appearing even if the last line if the description of the image fits in the visible area - https://phabricator.wikimedia.org/T87265#987346 (10Ryasmeen) 3NEW [20:27:20] 3VisualEditor: "Read more" link is appearing even if the last line if the description of the image fits in the visible area - https://phabricator.wikimedia.org/T87265#987360 (10Ryasmeen) a:3Mooeypoo [20:31:08] edsanders, probably this first -- https://gerrit.wikimedia.org/r/#/c/185225/ then https://gerrit.wikimedia.org/r/#/c/185589/ and https://gerrit.wikimedia.org/r/#/c/185589/ are the three more pressing ones that change behavior and fix bugs in the media dialog [20:31:48] edsanders, sorry, the third is https://gerrit.wikimedia.org/r/#/c/185453/ (wrote the second one twice) [20:33:14] (03CR) 10Trevor Parscal: [C: 04-1] "I may be able to be convinced, but this will cause further divergence from the hypothetical future where we support IE8[1]." [oojs/ui] - 10https://gerrit.wikimedia.org/r/185576 (https://phabricator.wikimedia.org/T76643) (owner: 10Bartosz Dziewoński) [20:33:27] (03CR) 10Trevor Parscal: [C: 04-1] Create InlineLabelTextInputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/185956 (https://phabricator.wikimedia.org/T87239) (owner: 10Esanders) [20:34:09] (03CR) 10Trevor Parscal: [C: 032] InputWidget: Resynchronize our internal .value with DOM .value in #getValue [oojs/ui] - 10https://gerrit.wikimedia.org/r/185335 (https://phabricator.wikimedia.org/T86868) (owner: 10Bartosz Dziewoński) [20:38:41] (03Merged) 10jenkins-bot: InputWidget: Resynchronize our internal .value with DOM .value in #getValue [oojs/ui] - 10https://gerrit.wikimedia.org/r/185335 (https://phabricator.wikimedia.org/T86868) (owner: 10Bartosz Dziewoński) [20:41:54] 3VisualEditor-EditingTools, VisualEditor: Make it easy to identify the file type (e.g., .png versus .svg) when adding an image - https://phabricator.wikimedia.org/T74061#987375 (10Etonkovidova) Checked in beta - Re-designed Media settings dialog box for a selected image displays a file's type. [20:42:41] 3OOjs-UI, VisualEditor: MediaWiki theme: Border radius used inconsistently - https://phabricator.wikimedia.org/T85973#987378 (10matmarex) 5Resolved>3Open Needs more tweaking. [20:47:57] 3VisualEditor: It shows the previously selected image's name inside the Media Settings dialog - https://phabricator.wikimedia.org/T87267#987393 (10Ryasmeen) 3NEW [20:48:44] (03PS6) 10Anishvisa: new file: test_files/ID_training_data.json IDs for tests [services/citoid] - 10https://gerrit.wikimedia.org/r/185837 [20:49:16] 3VisualEditor: It shows the previously selected image's name inside the Media Settings dialog - https://phabricator.wikimedia.org/T87267#987403 (10Ryasmeen) a:3Mooeypoo [20:49:47] 3VisualEditor: Visual Editor: editing an existing internal link sometimes result in wrong link - https://phabricator.wikimedia.org/T86326#987405 (10Kipod) just to clarify, here are 2 examples (the first is from real life): Example #1: tables with many links, esp. in lists (i.e.' "list" articles) inevitable, som... [20:53:16] 3OOjs-UI: InputWidgets should detect the internal .value property and the 's .value property getting desynchronised and do something smart - https://phabricator.wikimedia.org/T86868#987410 (10Jdforrester-WMF) p:5High>3Normal [20:53:25] 3OOjs-UI: InputWidgets should detect the internal .value property and the 's .value property getting desynchronised and do something smart - https://phabricator.wikimedia.org/T86868#978279 (10Jdforrester-WMF) p:5Normal>3High [20:53:45] 3OOjs-UI: InputWidgets should detect the internal .value property and the 's .value property getting desynchronised and do something smart - https://phabricator.wikimedia.org/T86868#987414 (10Jdforrester-WMF) 5Open>3Resolved [20:54:58] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/176681/ [20:55:59] 3VisualEditor, VisualEditor-MediaWiki-Media: The media dialog shows the previously selected image's name when you change which image is being used - https://phabricator.wikimedia.org/T87267#987417 (10Jdforrester-WMF) p:5Triage>3Normal [20:56:49] 3VisualEditor: "Read more" link is appearing even if the last line if the description of the image fits in the visible area - https://phabricator.wikimedia.org/T87265#987423 (10Jdforrester-WMF) p:5Triage>3Normal [20:58:07] (03PS5) 10Mooeypoo: When changing image source, use already-available API info [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185589 (https://phabricator.wikimedia.org/T87267) [20:58:11] (03CR) 10jenkins-bot: [V: 04-1] When changing image source, use already-available API info [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185589 (https://phabricator.wikimedia.org/T87267) (owner: 10Mooeypoo) [21:04:53] (03PS1) 10Bartosz Dziewoński: MediaWiki theme: Tweak some more border-radiuses [oojs/ui] - 10https://gerrit.wikimedia.org/r/186080 (https://phabricator.wikimedia.org/T85973) [21:05:12] (03PS9) 10Mooeypoo: Lazy load the media search results [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185225 [21:05:27] (03PS6) 10Mooeypoo: When changing image source, use already-available API info [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185589 (https://phabricator.wikimedia.org/T87267) [21:06:08] (03PS5) 10Mooeypoo: Add a layout queue to media result widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185453 (https://phabricator.wikimedia.org/T86802) [21:10:37] 3VisualEditor, VisualEditor-EditingTools: VisualEditor:[Regression wmf7] Inconsistent behavior in Chrome compared to FF, on applying a link or language annotation to a gallery. - https://phabricator.wikimedia.org/T75233#987439 (10Jdforrester-WMF) p:5Triage>3Low [21:11:00] 3VisualEditor, VisualEditor-Performance: ve.init.mw.Target.startSanityCheck needs a sanity-check - https://phabricator.wikimedia.org/T87161#987442 (10Jdforrester-WMF) p:5High>3Unbreak! [21:21:02] (03CR) 10Alex Monk: [C: 032] Adapt the type input to work with the new ooui getMenu() [extensions/TemplateData] (wmf/1.25wmf15) - 10https://gerrit.wikimedia.org/r/185998 (https://phabricator.wikimedia.org/T86922) (owner: 10Jforrester) [21:21:46] (03Merged) 10jenkins-bot: Adapt the type input to work with the new ooui getMenu() [extensions/TemplateData] (wmf/1.25wmf15) - 10https://gerrit.wikimedia.org/r/185998 (https://phabricator.wikimedia.org/T86922) (owner: 10Jforrester) [21:26:13] (03CR) 10Alex Monk: [C: 032] Adapt the type input to work with the new ooui getMenu() [extensions/TemplateData] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/185999 (https://phabricator.wikimedia.org/T86922) (owner: 10Jforrester) [21:31:21] (03Merged) 10jenkins-bot: Adapt the type input to work with the new ooui getMenu() [extensions/TemplateData] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/185999 (https://phabricator.wikimedia.org/T86922) (owner: 10Jforrester) [21:36:39] 3VisualEditor: VisualEditor: Unable to select empty section heading (e.g., to remove it) at the end of a page - https://phabricator.wikimedia.org/T61651#987488 (10Etonkovidova) The bug confirmed - cannot be deleted from VE. [21:36:48] 3VisualEditor: VisualEditor: Unable to select empty section heading (e.g., to remove it) at the end of a page - https://phabricator.wikimedia.org/T61651#987489 (10Etonkovidova) p:5Triage>3Volunteer? [21:43:07] mooeypoo, you there? [21:43:08] 3VisualEditor: Cursor wobbles in inline slug and allows me to select into the internal list - https://phabricator.wikimedia.org/T86762#987497 (10Aklapper) I //assume// this is about VE hence associating project. Please associate a project when creating tasks; thank you! [21:43:34] 3VisualEditor: VisualEditor Q3 Domination Criteria - https://phabricator.wikimedia.org/T86867#987502 (10Aklapper) [21:43:56] 3VisualEditor, VisualEditor-MediaWiki-Media: Make the media dialog bigger when searching for media to insert - https://phabricator.wikimedia.org/T86397#987503 (10Jdforrester-WMF) 5Open>3Resolved [21:48:50] (03CR) 10Mvolz: [C: 04-1] new file: test_files/ID_training_data.json IDs for tests (033 comments) [services/citoid] - 10https://gerrit.wikimedia.org/r/185837 (owner: 10Anishvisa) [21:48:52] 3VisualEditor: VE automatically cuts off certain characters - https://phabricator.wikimedia.org/T61628#987524 (10Etonkovidova) Non-reproducible - most likely fixed. [21:54:56] 3MediaWiki-Page-editing: Preview page always displays limit report in version 1.24.1 - https://phabricator.wikimedia.org/T87166#985264 (10Aklapper) [21:55:28] 3VisualEditor: VE automatically cuts off certain characters - https://phabricator.wikimedia.org/T61628#987540 (10Etonkovidova) 5Open>3Resolved [22:03:14] 3VisualEditor: VisualEditor: copying and pasting header results in non-breaking space being inserted - https://phabricator.wikimedia.org/T60563#987553 (10Etonkovidova) 5Open>3Resolved [22:04:34] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: Information fields in template dialogs are sometimes very large - https://phabricator.wikimedia.org/T71508#987555 (10Etonkovidova) 5Open>3Resolved [22:05:31] 3MediaWiki-ResourceLoader: ResourceLoader should return Status 500 when catching an Exception - https://phabricator.wikimedia.org/T87175#987557 (10Aklapper) p:5Triage>3Low [22:06:24] 3VisualEditor: There should be a "magazine" option in the VisualEditor citation dropdown - https://phabricator.wikimedia.org/T86117#987559 (10Whatamidoing-WMF) If you wanted to merge them, then labeling it "periodical" might make more sense than "magazine", because academic journals aren't exactly magazines. Ho... [22:18:21] 3MediaWiki-Database, MediaWiki-ContentHandler, MediaWiki-Page-editing: MediaWiki allows saving an identical revision on top of another (due to content model?) - https://phabricator.wikimedia.org/T87152#987602 (10Aklapper) p:5Triage>3Normal [22:22:45] 3VisualEditor, Citoid: Changing re-used citation templates - https://phabricator.wikimedia.org/T87271#987616 (10Whatamidoing-WMF) 3NEW [22:28:52] 3VisualEditor, VisualEditor-Tables: Missing cells look like they're present in Firefox - https://phabricator.wikimedia.org/T85463#987633 (10Etonkovidova) p:5Triage>3Low [22:45:36] 3VisualEditor, VisualEditor-MediaWiki-Media: Make the media dialog bigger when searching for media to insert - https://phabricator.wikimedia.org/T86397#987676 (10Etonkovidova) Checked in betalabs. [23:12:29] (03PS4) 10Bartosz Dziewoński: TextInputWidget: Accept 'maxLength' configuration option [oojs/ui] - 10https://gerrit.wikimedia.org/r/185563 [23:25:32] (03CR) 10Trevor Parscal: [C: 032] TextInputWidget: Accept 'maxLength' configuration option [oojs/ui] - 10https://gerrit.wikimedia.org/r/185563 (owner: 10Bartosz Dziewoński) [23:27:41] (03PS1) 10Catrope: [WIP] Make sanity check synchronous [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186100 (https://phabricator.wikimedia.org/T87161) [23:28:11] ori: https://gerrit.wikimedia.org/r/186100 [23:29:52] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Make sanity check synchronous [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186100 (https://phabricator.wikimedia.org/T87161) (owner: 10Catrope) [23:32:28] (03Merged) 10jenkins-bot: TextInputWidget: Accept 'maxLength' configuration option [oojs/ui] - 10https://gerrit.wikimedia.org/r/185563 (owner: 10Bartosz Dziewoński) [23:38:32] (03CR) 10Esanders: [C: 04-1] Lazy load the media search results (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185225 (owner: 10Mooeypoo) [23:47:02] anyone else getting "Uncaught Error: script must be of type function or array, not undefined" trying to load VE? [23:47:14] originating in "mw.loader.implement" [23:47:39] locally? [23:47:44] does this happen on beta? [23:50:07] It's debug mode only [23:50:17] It's because of an edge case of an edge case in Krinkle's commit [23:55:46] (03PS1) 10Jforrester: MWMediaDialog: Add contextual help for controls [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186108 (https://phabricator.wikimedia.org/T53798) [23:58:35] 3VisualEditor, VisualEditor-MediaWiki-References: Be able to easily change which citation template is being used in a repeated reference - https://phabricator.wikimedia.org/T87271#987857 (10Jdforrester-WMF) p:5Triage>3Volunteer? [23:59:05] 3VisualEditor, VisualEditor-MediaWiki-References: Be able to easily change which citation template is being used in a repeated reference - https://phabricator.wikimedia.org/T87271#987616 (10Jdforrester-WMF) This is essentially impossible to do without the "future citation system" mythical vapourware project, sadly. [23:59:47] 3VisualEditor, VisualEditor-ContentEditable: Cursor wobbles in inline slug and allows me to select into the internal list - https://phabricator.wikimedia.org/T86762#987868 (10Jdforrester-WMF) p:5Triage>3Normal a:5dchan>3None