[00:01:05] 3VisualEditor, VisualEditor-Tables: Missing cells look like they're present in Firefox - https://phabricator.wikimedia.org/T85463#947421 (10Jdforrester-WMF) [00:02:42] ryasmeen: I'd appreciate your thoughts on the language in https://gerrit.wikimedia.org/r/#/c/186108/ [00:07:58] 3VisualEditor, VisualEditor-Performance: ~200ms spent on CSSStyleDeclaration.getPropertyValue() - https://phabricator.wikimedia.org/T87160#987917 (10Catrope) a:5Krinkle>3Catrope [00:09:55] (03PS8) 10Bartosz Dziewoński: Introduce and use TabIndexedElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/183718 [00:10:33] (03CR) 10Bartosz Dziewoński: "I think this works, but please double-check because it's funky." [oojs/ui] - 10https://gerrit.wikimedia.org/r/183718 (owner: 10Bartosz Dziewoński) [00:13:41] (03PS10) 10Mooeypoo: Lazy load the media search results [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185225 [00:15:52] (03CR) 10Bartosz Dziewoński: "Right, in that case let's apply to margin to '&' and cancel it out in &:last-child? Or use the + selector cleverly?" [oojs/ui] - 10https://gerrit.wikimedia.org/r/185576 (https://phabricator.wikimedia.org/T76643) (owner: 10Bartosz Dziewoński) [00:28:46] RoanKattouw: I'd like to add some debug functionality to VisualEditor. I see a 'debug bar' thing. Is there a pattern for how to do this? Do you enable debug functionality via a query param, keystroke, etc? [00:29:42] The debug bar listens to debug=true [00:29:47] And it's all in VE core [00:29:54] It's also visible in the standalone demo [00:30:11] The debug bar stuff is in ve.something.DebugBar.js IIRC, and it's all built by edsanders [00:30:52] (03PS3) 10Trevor Parscal: [WIP] Add MenuLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/184008 [00:33:17] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Add MenuLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/184008 (owner: 10Trevor Parscal) [00:33:48] 3VisualEditor, VisualEditor-EditingTools: Multi-paragraph
results in some paragraphs being alienated content - https://phabricator.wikimedia.org/T86794#987993 (10Etonkovidova) In VE, when hovering over second and third paragraphs in the given blockquote, there is a warning " This content is editabl... [00:39:40] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: We need a representation of red-linked images - https://phabricator.wikimedia.org/T52788#988002 (10Aklapper) This task is open but has two "verified-in-phaseX" projects associated. Could someone clarify? [00:39:49] (03PS11) 10Mooeypoo: Lazy load the media search results [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185225 [00:46:10] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: We need a representation of red-linked images - https://phabricator.wikimedia.org/T52788#988024 (10Etonkovidova) Marking as Resolved. [00:46:19] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: Support media (tracking) - https://phabricator.wikimedia.org/T39870#988026 (10Etonkovidova) [00:46:21] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: We need a representation of red-linked images - https://phabricator.wikimedia.org/T52788#988025 (10Etonkovidova) 5Open>3Resolved [01:03:12] (03PS9) 10Bartosz Dziewoński: Introduce DropdownInputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/185376 (https://phabricator.wikimedia.org/T86393) [01:03:31] (03PS4) 10Bartosz Dziewoński: Provide default margins for buttons and other widgets [oojs/ui] - 10https://gerrit.wikimedia.org/r/185576 (https://phabricator.wikimedia.org/T76643) [01:05:39] (03CR) 10Bartosz Dziewoński: "(Rebased.)" [oojs/ui] - 10https://gerrit.wikimedia.org/r/185576 (https://phabricator.wikimedia.org/T76643) (owner: 10Bartosz Dziewoński) [01:06:59] (03CR) 10Bartosz Dziewoński: "I went with a single #setOptions. This is both very convenient to implement, very simple to use (no need to keep track of internal stuff t" [oojs/ui] - 10https://gerrit.wikimedia.org/r/185376 (https://phabricator.wikimedia.org/T86393) (owner: 10Bartosz Dziewoński) [01:07:31] (03CR) 10jenkins-bot: [V: 04-1] Introduce DropdownInputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/185376 (https://phabricator.wikimedia.org/T86393) (owner: 10Bartosz Dziewoński) [01:08:49] (03CR) 10Bartosz Dziewoński: "(Looks like a bogus test failure.)" [oojs/ui] - 10https://gerrit.wikimedia.org/r/185376 (https://phabricator.wikimedia.org/T86393) (owner: 10Bartosz Dziewoński) [01:08:52] Krinkle: ^ [01:15:31] 3VisualEditor-MediaWiki, VisualEditor: [Regression] __STATICREDIRECT__ is set when user sets a redirect, regardless whether the user ticks the box to set it - https://phabricator.wikimedia.org/T86827#988061 (10Krenair) 5Open>3Resolved This was merged to master, deployed, etc. [01:21:12] 3VisualEditor, VisualEditor-EditingTools: VisualEditor:Link inspector opens with an animation from top while trying to open it for the first time in an edit session - https://phabricator.wikimedia.org/T74495#988069 (10Krenair) There's an animation? [01:38:33] 3VisualEditor-MediaWiki, VisualEditor-MediaWiki-Templates, VisualEditor: When I changed the website link in an infobox all other links got redlinks - https://phabricator.wikimedia.org/T78472#988115 (10Krenair) James, did you confirm this? [01:41:48] 3VisualEditor-MediaWiki, VisualEditor, VisualEditor-EditingTools: VisualEditor: Handle invalid input for redirect title in meta dialog - https://phabricator.wikimedia.org/T74971#988118 (10Krenair) ```#REDIRECT [[MediaWiki:Badtitletext]]``` [01:43:58] 3VisualEditor-MediaWiki, VisualEditor, VisualEditor-EditingTools: VisualEditor: Handle invalid input for redirect title in meta dialog - https://phabricator.wikimedia.org/T74971#988132 (10Krenair) I was testing with characters like <>, pipes, etc. ```#REDIRECT [[Talk:]]``` comes up for "Talk:", but gets render... [01:44:50] (03PS7) 10Mooeypoo: When changing image source, use already-available API info [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185589 (https://phabricator.wikimedia.org/T87267) [01:46:36] hm, MWTitleInputWidget vs. MWLinkTargetInputWidget [01:47:43] request/response handling code should probably be shared, would probably resolve https://phabricator.wikimedia.org/T74971 [01:48:11] (03PS5) 10Bartosz Dziewoński: Provide default margins for buttons and other widgets [oojs/ui] - 10https://gerrit.wikimedia.org/r/185576 (https://phabricator.wikimedia.org/T76643) [01:48:38] (03CR) 10Bartosz Dziewoński: "So I did this without :not() and it got a lot poopier :(" [oojs/ui] - 10https://gerrit.wikimedia.org/r/185576 (https://phabricator.wikimedia.org/T76643) (owner: 10Bartosz Dziewoński) [01:49:46] (03PS6) 10Mooeypoo: Add a layout queue to media result widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185453 (https://phabricator.wikimedia.org/T86802) [01:51:50] MWTitleInputWidget is used for redirects and templates, but doesn't handle a lot of the things like existence, validity, redirects, disambig, etc. [01:54:45] 3VisualEditor-MediaWiki, VisualEditor, VisualEditor-EditingTools: VisualEditor: Handle invalid input for redirect title in meta dialog - https://phabricator.wikimedia.org/T74971#988156 (10Krenair) So I looked into the code - MWTitleInputWidget (used for redirects and templates) vs. MWLinkTargetInputWidget (links... [01:56:27] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: redirect option works badly if pointing to category pages - https://phabricator.wikimedia.org/T73708#988158 (10Krenair) I wonder if there is any use case for allowing the version without ":" with these namespaces, even if it should clearly not be the defaul... [01:59:01] MatmaRex, around? [02:01:15] yeah [02:01:18] Krenair: [02:01:33] am I missing something on https://phabricator.wikimedia.org/T86566 ? [02:03:06] Krenair: hmm. i don't get it either. [02:03:24] https://phabricator.wikimedia.org/T86562 - can you reproduce? [02:03:26] it's probably not related to VE, but rummana and elena just file everything there [02:03:33] but regardless of that, i just don't understand the report [02:05:14] Krenair: WFM [02:05:41] 3VisualEditor: [Regression pre-wmf15] Switch to source editing while keeping changes is not retaining the edits - https://phabricator.wikimedia.org/T86562#988168 (10matmarex) Works for me too. [02:05:54] 3VisualEditor: [Regression pre-wmf15] New section is not getting added while trying to attempt add one for the first time in a page - https://phabricator.wikimedia.org/T86566#988170 (10matmarex) I don't understand this report, but it's probably not VE? [02:06:14] 3VisualEditor, VisualEditor-Performance: ve.init.mw.Target.startSanityCheck needs a sanity-check - https://phabricator.wikimedia.org/T87161#988171 (10ori) [02:07:07] (03CR) 10Ori.livneh: "Blocked on T87215. I need a consistent test environment to be able to gauge the impact of this." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186100 (https://phabricator.wikimedia.org/T87161) (owner: 10Catrope) [02:11:55] (03PS1) 10Prtksxna: Fix the highlight color for ButtonSelectWidget and ButtonGroupWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/186134 (https://phabricator.wikimedia.org/T78032) [02:14:32] (03CR) 10jenkins-bot: [V: 04-1] Fix the highlight color for ButtonSelectWidget and ButtonGroupWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/186134 (https://phabricator.wikimedia.org/T78032) (owner: 10Prtksxna) [02:18:35] (03PS2) 10Jforrester: Fix the highlight color for ButtonSelectWidget and ButtonGroupWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/186134 (https://phabricator.wikimedia.org/T78032) (owner: 10Prtksxna) [02:50:28] (03PS3) 10Jforrester: MediaWiki theme: Adjust ButtonSelectWidget, ButtonGroupWidget highlights [oojs/ui] - 10https://gerrit.wikimedia.org/r/186134 (https://phabricator.wikimedia.org/T78032) (owner: 10Prtksxna) [02:54:32] (03CR) 10Jforrester: [C: 031] "Comparative version in https://phabricator.wikimedia.org/M35/65/ – LGTM. Thoughts?" [oojs/ui] - 10https://gerrit.wikimedia.org/r/186134 (https://phabricator.wikimedia.org/T78032) (owner: 10Prtksxna) [02:56:47] (03PS1) 10Prtksxna: Update colors for the selected state in ComboBox and Dropdown [oojs/ui] - 10https://gerrit.wikimedia.org/r/186140 [02:58:29] (03PS2) 10Jforrester: Update colors for the selected state in ComboBox and Dropdown [oojs/ui] - 10https://gerrit.wikimedia.org/r/186140 (owner: 10Prtksxna) [02:58:53] (03PS3) 10Jforrester: MediaWiki theme: Adjust ComboBoxWidget, DropdownWidget selected state [oojs/ui] - 10https://gerrit.wikimedia.org/r/186140 (owner: 10Prtksxna) [02:59:17] (03PS4) 10Prtksxna: MediaWiki Theme: Update colors for the selected state in ComboBox and Dropdown [oojs/ui] - 10https://gerrit.wikimedia.org/r/186140 [03:02:02] (03CR) 10jenkins-bot: [V: 04-1] MediaWiki Theme: Update colors for the selected state in ComboBox and Dropdown [oojs/ui] - 10https://gerrit.wikimedia.org/r/186140 (owner: 10Prtksxna) [04:36:33] 3VisualEditor-MediaWiki, VisualEditor: VisualEditor: Where VisualEditor is the primary editor, redlinks in read mode should go to veaction=edit not action=edit - https://phabricator.wikimedia.org/T55441#988333 (10Ricordisamoa) a:5Ricordisamoa>3None This has to be discussed further. [04:52:00] 3VisualEditor, VisualEditor-ContentEditable: Regression pre-wmf16: Entire line of text gets highlighted , when applying link or language to a text in Heading or Page Title format. - https://phabricator.wikimedia.org/T87297#988339 (10Swainr) 3NEW [05:04:13] 3VisualEditor, VisualEditor-ContentEditable: Regression pre-wmf16: Language context menu lags behind the cursor position and typed text , if text format is Heading or Page title. - https://phabricator.wikimedia.org/T87298#988348 (10Swainr) 3NEW [05:24:18] 3VisualEditor, VisualEditor-ContentEditable: Regression pre-wmf16: Entire line of text gets highlighted , when applying link or language to a text in Heading or Page Title format. - https://phabricator.wikimedia.org/T87297#988385 (10Swainr) [05:33:26] (03CR) 10Esanders: [C: 04-1] "rename only half done" [oojs/ui] - 10https://gerrit.wikimedia.org/r/184008 (owner: 10Trevor Parscal) [05:57:58] (03PS3) 10Esanders: Create InlineLabelTextInputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/185956 (https://phabricator.wikimedia.org/T87239) [06:03:51] (03PS4) 10Esanders: Create InlineLabelTextInputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/185956 (https://phabricator.wikimedia.org/T87239) [06:06:13] (03PS3) 10Esanders: Add keyboard commands for find next/replace [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/185688 (https://phabricator.wikimedia.org/T87113) [07:41:00] 3MediaWiki-Database, MediaWiki-ContentHandler, MediaWiki-Page-editing: MediaWiki allows saving an identical revision on top of another (due to content model?) - https://phabricator.wikimedia.org/T87152#988579 (10Nemo_bis) It would be nice to solve this before we have millions of revisions to cleanup in the datab... [07:53:28] 3MediaWiki-Database, MediaWiki-ContentHandler, MediaWiki-Page-editing: MediaWiki allows saving an identical revision on top of another (due to content model?) - https://phabricator.wikimedia.org/T87152#988585 (10matmarex) * Does this happen on production wikis? Could be caused by incomplete/botched database sche... [11:33:35] (03CR) 10Fomafix: [C: 04-1] "Automatic fallback to 'en' must be removed." (031 comment) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/186006 (https://phabricator.wikimedia.org/T87247) (owner: 10Gerrit Patch Uploader) [12:04:22] (03PS2) 10Gerrit Patch Uploader: Support fallback languages for icons [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/186006 (https://phabricator.wikimedia.org/T87247) [12:04:25] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/186006 (https://phabricator.wikimedia.org/T87247) (owner: 10Gerrit Patch Uploader) [12:42:16] 3MediaWiki-Database, MediaWiki-ContentHandler, MediaWiki-Page-editing: MediaWiki allows saving an identical revision on top of another (due to content model?) - https://phabricator.wikimedia.org/T87152#988768 (10Nemo_bis) >>! In T87152#988585, @matmarex wrote: > * Does this happen on production wikis? Didn't t... [13:16:30] (03CR) 10Fomafix: [C: 04-1] "The fallback chain is static for the page. Generate this only once." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/186006 (https://phabricator.wikimedia.org/T87247) (owner: 10Gerrit Patch Uploader) [13:16:47] (03PS3) 10Gerrit Patch Uploader: Support fallback languages for icons [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/186006 (https://phabricator.wikimedia.org/T87247) [13:16:50] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/186006 (https://phabricator.wikimedia.org/T87247) (owner: 10Gerrit Patch Uploader) [16:17:12] (03PS1) 10Esanders: Fix DOM structure on setup/teardown [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186171 [16:32:23] (03CR) 10Esanders: "VE-MW issue fixed in https://gerrit.wikimedia.org/r/186171" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/185688 (https://phabricator.wikimedia.org/T87113) (owner: 10Esanders) [16:32:34] (03Abandoned) 10Zfilipin: WIP: [BrowserTest] Rework long external link code [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/122400 (owner: 10Jagori79) [16:50:36] (03PS4) 10Prtksxna: MediaWiki Theme: Adjust ButtonSelectWidget, ButtonGroupWidget highlights [oojs/ui] - 10https://gerrit.wikimedia.org/r/186134 (https://phabricator.wikimedia.org/T78032) [16:50:38] (03PS5) 10Prtksxna: MediaWiki Theme: Update colors for the selected state in ComboBox and Dropdown [oojs/ui] - 10https://gerrit.wikimedia.org/r/186140 [18:26:56] 3VisualEditor, VisualEditor-EditingTools: VisualEditor:Link inspector opens with an animation from top while trying to open it for the first time in an edit session - https://phabricator.wikimedia.org/T74495#989236 (10matmarex) 5Open>3Resolved a:3matmarex This is no longer happening. [18:31:34] (03PS1) 10Gerrit Patch Uploader: Use sprite as button icon where possible [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/186177 [18:31:37] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/186177 (owner: 10Gerrit Patch Uploader) [19:18:10] (03CR) 10Bartosz Dziewoński: [C: 032] MediaWiki Theme: Adjust ButtonSelectWidget, ButtonGroupWidget highlights [oojs/ui] - 10https://gerrit.wikimedia.org/r/186134 (https://phabricator.wikimedia.org/T78032) (owner: 10Prtksxna) [19:21:18] (03Merged) 10jenkins-bot: MediaWiki Theme: Adjust ButtonSelectWidget, ButtonGroupWidget highlights [oojs/ui] - 10https://gerrit.wikimedia.org/r/186134 (https://phabricator.wikimedia.org/T78032) (owner: 10Prtksxna)