[00:06:18] (03CR) 10GOIII: "err... my previous should have pointed to:" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/184301 (owner: 10Gerrit Patch Uploader) [00:08:56] (03CR) 10GOIII: "damn it. scratch the above gerrit link; use instead..." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/184301 (owner: 10Gerrit Patch Uploader) [02:16:13] 3VisualEditor, MediaWiki-ResourceLoader: Devise a means of testing local code on production wikis - https://phabricator.wikimedia.org/T87384#990537 (10matmarex) Yeah, I used Fiddler , which acts like a local proxy server to onspect and modify outgoing traffic. Turn it on, use debu... [04:38:53] 3VisualEditor: VisualEditor language screenshot scenario for page settings is broken - https://phabricator.wikimedia.org/T86634#990598 (10Amire80) p:5Triage>3Normal [04:40:06] 3OOjs-UI, VisualEditor: Tools in the toolbar do not have unique attributes - https://phabricator.wikimedia.org/T76143#990603 (10Amire80) 5Open>3Resolved [05:17:58] (03PS24) 10Divec: Native leftarrow and rightarrow [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177946 [06:27:20] 3VisualEditor-MediaWiki, VisualEditor, VisualEditor-Performance: VisualEditor: Deal with en.wikipedia.org's edit notice system - https://phabricator.wikimedia.org/T45013#990661 (10ori) [06:34:01] 3VisualEditor, VisualEditor-Performance: Eliminate call to $.getVisibleText() in ve.init.mw.Target.prototype.onNoticesReady - https://phabricator.wikimedia.org/T87412#990665 (10ori) 3NEW [07:29:38] 3VisualEditor, VisualEditor-Performance: Investigate jQuery.filter call with ve.dm.MWBlockImageNode.static.toDataElement in call stack - https://phabricator.wikimedia.org/T87416#990725 (10ori) 3NEW [07:31:44] 3VisualEditor, VisualEditor-Performance: Investigate jQuery.filter call with ve.dm.MWBlockImageNode.static.toDataElement in call stack - https://phabricator.wikimedia.org/T87416#990734 (10ori) p:5Triage>3High [07:33:38] 3VisualEditor, VisualEditor-Performance: Get rid of unnecessary jQuery.html call in ve.dm.InternalList.convertToData - https://phabricator.wikimedia.org/T87417#990736 (10ori) 3NEW [07:37:51] 3VisualEditor, VisualEditor-Performance: Batch DOM insertions in ve.dm.InternalList.convertToData - https://phabricator.wikimedia.org/T87418#990744 (10ori) 3NEW [07:39:58] 3VisualEditor, VisualEditor-Performance: ve.ce.Surface.showSelection forces a style recalc - https://phabricator.wikimedia.org/T87419#990750 (10ori) 3NEW [07:41:02] 3VisualEditor, VisualEditor-Performance: Get rid of unnecessary jQuery.html call in ve.dm.InternalList.convertToData and ve.dm.MWReferenceNode.static.toDomElements - https://phabricator.wikimedia.org/T87417#990759 (10ori) [07:43:39] 3OOjs-UI, VisualEditor, VisualEditor-Performance: OO.ui.PopupWidget.toggle triggers recalc style - https://phabricator.wikimedia.org/T87420#990764 (10ori) 3NEW [07:51:14] 3VisualEditor-MediaWiki, VisualEditor-InterfaceLanguage, VisualEditor-Performance, VisualEditor-MediaWiki-Media, VisualEditor-Tables, VisualEditor-MediaWiki-Templates, VisualEditor, VisualEditor-ContentEditable, VisualEditor-CopyPaste, VisualEditor-MediaWiki-Mobile, Project-Creators, VisualEditor-MediaWiki-Links, V... [09:57:01] 3VisualEditor: Deleting section heading leaves "====" - https://phabricator.wikimedia.org/T87424#990837 (10Tbayer) 3NEW [11:27:58] (03CR) 10Fomafix: "The text should not be shown as before. Title is enough." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/184301 (owner: 10Gerrit Patch Uploader) [17:25:26] (03CR) 10Fomafix: "This patch is superseded by https://gerrit.wikimedia.org/r/186006" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/184619 (https://phabricator.wikimedia.org/T86643) (owner: 10Gerrit Patch Uploader) [17:30:43] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=111192811 [17:30:43] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=111195974 [17:30:43] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=68125392 [18:32:29] MatmaRex: https://gerrit.wikimedia.org/r/#/c/186244/ -- easy peasy [18:32:54] ori, where were we on https://gerrit.wikimedia.org/r/#/c/130543/ ? [18:33:37] Was I going to just add some hooks to ParsoidVirtualRESTService so EventLogging can monitor it? [18:33:52] or were you going to do something? [18:35:48] (03CR) 10Bartosz Dziewoński: [C: 032] "Shouldn't hurt I suppose." [oojs/core] - 10https://gerrit.wikimedia.org/r/186244 (https://phabricator.wikimedia.org/T74933) (owner: 10Ori.livneh) [18:37:14] 3VisualEditor: Default text for Media should disappear upon clicking - https://phabricator.wikimedia.org/T78821#991303 (10Cmcmahon) [18:38:10] 3VisualEditor: Default text for Media should disappear upon clicking - https://phabricator.wikimedia.org/T78821#854040 (10Cmcmahon) Also seen in Chrome as of 23 January [18:39:11] MatmaRex: thanks! [18:41:08] (03Merged) 10jenkins-bot: v8 opt: Copy arguments into new array rather than use [].slice [oojs/core] - 10https://gerrit.wikimedia.org/r/186244 (https://phabricator.wikimedia.org/T74933) (owner: 10Ori.livneh) [18:41:18] 3VisualEditor, MediaWiki-Core-Team, VisualEditor-Performance: Parsoid performance analysis - https://phabricator.wikimedia.org/T85870#991335 (10ori) [18:43:32] 3VisualEditor-Performance, VisualEditor, Parsoid: Batch API requests - https://phabricator.wikimedia.org/T45888#991344 (10ori) [18:46:23] RoanKattouw_away: bugs for triage @ https://phabricator.wikimedia.org/project/board/831/ [18:46:44] 3VisualEditor, VisualEditor-ContentEditable: Get JQuery error "a is undefined" running browser tests locally for Firefox - https://phabricator.wikimedia.org/T87446#991347 (10Cmcmahon) 3NEW [18:47:35] ori: In the "Next up" section? [18:48:29] 3RESTBase, VisualEditor-Performance, VisualEditor, MediaWiki-Interface, Parsoid, Services, MediaWiki-General-or-Unknown: Use Parsoid HTML for read-only views too - https://phabricator.wikimedia.org/T55784#991361 (10Jdforrester-WMF) [18:48:35] RoanKattouw: James_F moved them; I'm not up-to-speed on VE workboard management practices, so I'm not sure. [18:48:44] OK [18:48:49] I'm looking at the .filter() one [18:49:08] 3VisualEditor, RESTBase, Parsoid, VisualEditor-Performance: Store & load data-mw separately - https://phabricator.wikimedia.org/T78676#991362 (10Jdforrester-WMF) [18:49:15] I'm somewhat surprised MWBlockImageNode of all places is filtering a huge DOM. Maybe there was a particularly complex caption? [18:49:31] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: All inspectors get broken after VE tab is idle for a while - https://phabricator.wikimedia.org/T63078#991365 (10Jdforrester-WMF) p:5Normal>3Low [18:50:30] (03PS1) 10Esanders: Fix resizeable CSS layers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/186362 [18:52:46] (03CR) 10Prtksxna: "James, does this change seem better now with updated select states on the drop downs?" [oojs/ui] - 10https://gerrit.wikimedia.org/r/183811 (owner: 10Prtksxna) [18:54:57] RoanKattouw: this was on en:Barack Obama, btw. I actually have the profile file; I'll upload it somewhere in a sec. [18:55:44] (03CR) 10Prtksxna: [C: 04-1] "Also, this is a test patch so we shouldn't be merging it anyway." [oojs/ui] - 10https://gerrit.wikimedia.org/r/183811 (owner: 10Prtksxna) [18:56:16] (03CR) 10Jforrester: [C: 031] "It looks good now, yeah. Thank you! :-)" [oojs/ui] - 10https://gerrit.wikimedia.org/r/183811 (owner: 10Prtksxna) [19:02:58] (03PS5) 10Bartosz Dziewoński: Add param order drag/drop widget to TemplateData dialog [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/182962 (owner: 10Mooeypoo) [19:03:06] (03PS4) 10Bartosz Dziewoński: Allow the restoration of a deleted parameter in the edit dialog [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/182980 (https://phabricator.wikimedia.org/T86916) (owner: 10Mooeypoo) [19:12:23] 3OOjs: OOjs: v8 warns it won't optimize oo.Factory.create or oo.EventEmitter.emit - https://phabricator.wikimedia.org/T74933#991407 (10Jdforrester-WMF) 5Open>3Resolved [19:19:17] (03PS1) 10Ori.livneh: v8 opt: enable optimisation for EventEmitter.emit [oojs/core] - 10https://gerrit.wikimedia.org/r/186379 [19:19:23] MatmaRex, James_F: T74933 actually needs ^^ as well before it can be resolved [19:19:30] ori: Oh, point. [19:19:42] MatmaRex: Want to +2? [19:19:50] (03PS2) 10Catrope: v8 opt: enable optimisation for EventEmitter.emit [oojs/core] - 10https://gerrit.wikimedia.org/r/186379 (owner: 10Ori.livneh) [19:19:55] (03CR) 10Catrope: [C: 032] v8 opt: enable optimisation for EventEmitter.emit [oojs/core] - 10https://gerrit.wikimedia.org/r/186379 (owner: 10Ori.livneh) [19:19:59] Thanks RoanKattouw. [19:20:07] thanks [19:20:57] RoanKattouw: heh, paul's link to his profile was just a screenshot: http://gyazo.com/504b33651228d18d07e1fcce1bd895ab [19:21:04] they really should make the HTML easily exportable [19:21:12] ori: So, you mentioned a Sizzle bug? [19:21:21] 3VisualEditor, VisualEditor-Performance: Investigate jQuery.filter call with ve.dm.MWBlockImageNode.static.toDataElement in call stack - https://phabricator.wikimedia.org/T87416#991440 (10Catrope) There are severa; code This seems to be due to several `.children()` calls: ``` $imgWrapper = $figure.children( 'a... [19:21:34] I wonder if https://phabricator.wikimedia.org/T87416#991440 is that Sizzle bug? [19:21:36] RoanKattouw: yeah, I'm still filing that. There are some length emails to copy/paste [19:21:41] (03CR) 10jenkins-bot: [V: 04-1] v8 opt: enable optimisation for EventEmitter.emit [oojs/core] - 10https://gerrit.wikimedia.org/r/186379 (owner: 10Ori.livneh) [19:21:47] oh, yes, it is! [19:21:54] OK, good [19:22:58] ori? [19:23:52] (03CR) 10Bartosz Dziewoński: [C: 04-1] "No workee!" [oojs/core] - 10https://gerrit.wikimedia.org/r/186379 (owner: 10Ori.livneh) [19:24:33] (03CR) 10Jforrester: "recheck" [oojs/core] - 10https://gerrit.wikimedia.org/r/186379 (owner: 10Ori.livneh) [19:25:11] (03PS3) 10Bartosz Dziewoński: v8 opt: enable optimisation for EventEmitter.emit [oojs/core] - 10https://gerrit.wikimedia.org/r/186379 (owner: 10Ori.livneh) [19:25:26] (03CR) 10Bartosz Dziewoński: [C: 031] v8 opt: enable optimisation for EventEmitter.emit [oojs/core] - 10https://gerrit.wikimedia.org/r/186379 (owner: 10Ori.livneh) [19:30:47] 3VisualEditor-MediaWiki, VisualEditor: [Regression] __STATICREDIRECT__ is set when user sets a redirect, regardless whether the user ticks the box to set it - https://phabricator.wikimedia.org/T86827#991481 (10Jdforrester-WMF) [19:33:44] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Deletion across a header caused it to remain without WS, leading Parsoid to output "====" - https://phabricator.wikimedia.org/T52100#991494 (10Jdforrester-WMF) [19:33:45] 3VisualEditor: Deleting section heading leaves "====" - https://phabricator.wikimedia.org/T87424#991493 (10Jdforrester-WMF) [19:34:09] 3VisualEditor-MediaWiki, VisualEditor, MediaWiki-extensions-FlaggedRevs: VisualEditor: The on-page Flagged Revisions notice about transcluded files or templates having outstanding changes doesn't appear in the edit notices - https://phabricator.wikimedia.org/T54280#991502 (10Umherirrender) [19:36:38] 3VisualEditor, VisualEditor-Performance: Eliminate call to $.getVisibleText() in ve.init.mw.Target.prototype.onNoticesReady - https://phabricator.wikimedia.org/T87412#991506 (10Jdforrester-WMF) > Can enwiki's system be reformed? Sure. But we've been ignoring it because it's a large piece of work without high-pr... [19:37:32] 3VisualEditor: [Regression pre-wmf15] Switch to source editing while keeping changes is not retaining the edits - https://phabricator.wikimedia.org/T86562#991515 (10Jdforrester-WMF) 5Invalid>3Resolved How did this get fixed? It was a pretty serious bug and it'd be nice to know how it was resolved so that we... [19:37:50] (03CR) 10Jforrester: [C: 032] v8 opt: enable optimisation for EventEmitter.emit [oojs/core] - 10https://gerrit.wikimedia.org/r/186379 (owner: 10Ori.livneh) [19:38:56] 3VisualEditor-MediaWiki, VisualEditor, MediaWiki-extensions-FlaggedRevs: The on-page Flagged Revisions notice about transcluded files or templates having outstanding changes doesn't appear in the edit notices - https://phabricator.wikimedia.org/T54280#991520 (10Jdforrester-WMF) [19:40:19] (03CR) 10Jforrester: [C: 032] Check for venotify on page load, not when VPT is created [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186318 (https://phabricator.wikimedia.org/T58921) (owner: 10Alex Monk) [19:40:42] 3VisualEditor-MediaWiki, VisualEditor: Page created/restored confirmation message appears after clicking on Edit for a new page - https://phabricator.wikimedia.org/T58921#991524 (10Jdforrester-WMF) a:3Krenair [19:41:01] 3VisualEditor-MediaWiki, VisualEditor: Page created/restored confirmation message appears after clicking on Edit for a new page - https://phabricator.wikimedia.org/T58921#625428 (10Jdforrester-WMF) p:5Triage>3High [19:41:51] 3VisualEditor: Deleting section heading leaves "====" - https://phabricator.wikimedia.org/T87424#991534 (10Etonkovidova) Could not reproduce it in production - If an** entire **section is deleted via VE, the output will be : ```

(03Merged) 10jenkins-bot: Add param order drag/drop widget to TemplateData dialog [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/182962 (owner: 10Mooeypoo) [19:45:31] MatmaRex: https://gerrit.wikimedia.org/r/#/c/140445/ look sane to you? [19:46:50] (03Merged) 10jenkins-bot: v8 opt: enable optimisation for EventEmitter.emit [oojs/core] - 10https://gerrit.wikimedia.org/r/186379 (owner: 10Ori.livneh) [19:47:22] will look [19:47:44] (03PS3) 10Bartosz Dziewoński: [WIP] Allow TemplateData to output information about magic words [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/140445 (https://bugzilla.wikimedia.org/49996) (owner: 10Alex Monk) [19:47:52] MatmaRex: Thanks. :-) [19:48:07] (03PS1) 10Jforrester: Tag v1.1.4 [oojs/core] - 10https://gerrit.wikimedia.org/r/186390 [19:48:25] (03CR) 10Catrope: [C: 032] Tag v1.1.4 [oojs/core] - 10https://gerrit.wikimedia.org/r/186390 (owner: 10Jforrester) [19:49:14] James_F, re https://phabricator.wikimedia.org/T86562 - well, considering I tested it about half an hour after it was posted... [19:49:41] Krenair: Did you test in Beta Labs, or locally? It was catastrophically broken. [19:50:01] I don't remember. [19:50:13] Krenair: As in, EditPage.php loading without CSS or JS, half the contents of the page not present. You'd have noticed. :-) [19:50:32] (03CR) 10jenkins-bot: [V: 04-1] Tag v1.1.4 [oojs/core] - 10https://gerrit.wikimedia.org/r/186390 (owner: 10Jforrester) [19:51:08] (03CR) 10Jforrester: [C: 032] "C'mon." [oojs/core] - 10https://gerrit.wikimedia.org/r/186390 (owner: 10Jforrester) [19:54:19] Hi guys [19:54:26] 3VisualEditor, VisualEditor-Performance: Investigate jQuery.filter call with ve.dm.MWBlockImageNode.static.toDataElement in call stack - https://phabricator.wikimedia.org/T87416#991554 (10Catrope) Ori tells me this is due to a bug in Sizzle where `setDocument` is called and expensive processing is performed pret... [19:54:32] Today is my last day as a Wikian. [19:54:32] Hey BladeBronson. [19:54:37] * James_F hugs. [19:55:01] 7.5 years [19:55:12] Hey man [19:55:19] (03CR) 10jenkins-bot: [V: 04-1] Tag v1.1.4 [oojs/core] - 10https://gerrit.wikimedia.org/r/186390 (owner: 10Jforrester) [19:55:24] We came to see you yesterday but you weren't there [19:55:27] Sweet new office though [19:55:34] Really? What time? [19:55:43] 3MediaWiki-extensions-Echo, VisualEditor, VisualEditor-ContentEditable: Get JQuery error "a is undefined" running browser tests locally for Firefox - https://phabricator.wikimedia.org/T87446#991569 (10Cmcmahon) [19:56:22] James_F: Do you mind if we rephrase those release notes to relate to a component instead of the type of commit (v8 opt) [19:56:46] Krinkle: Well, given jenkins is refusing to merge… [19:57:00] I'm hearing from some people at Wikia that strangers in VE shirts were seen around the office :) [19:57:08] Yeah :D [19:57:20] core and EventEmitter respectively I think [19:57:29] We just wandered straight in, and at some point your IT guy went "hey, are you guys with the Foundation?" [19:57:30] Anyway, working with you all on VE was one of the best times in my wiki career. [19:57:40] It was great man~ [19:57:42] *! [19:57:55] Everyone on the team was an A-player. [19:57:56] Krinkle: Could you alter it and get it merged? [19:58:09] We actually showed up at the old office first and I was sad when I saw the moving notice. My first work with Trevor was in that office [19:58:15] I really hope that we find ourselves working together again in the future. [19:58:18] In the conference room in the corner that we rented from you [19:58:21] Yeah man [19:58:31] What's your new gig again? [19:58:35] ChangeTip [19:58:43] micropayments using bitcoin [19:59:09] Aha, cool [19:59:11] 3MediaWiki-extensions-Echo, VisualEditor, VisualEditor-ContentEditable: Get JQuery error "a is undefined" running browser tests locally for Firefox - https://phabricator.wikimedia.org/T87446#991586 (10Cmcmahon) Here is the stack track from trying to run an Echo test: a is undefined (Selenium::WebDriver::Error:... [19:59:18] Very different from editing :P [19:59:19] Check Facebook. I just bought you lunch. [19:59:37] lol that's awesome [19:59:40] 3MediaWiki-extensions-Echo, MediaWiki-General-or-Unknown, VisualEditor, VisualEditor-ContentEditable: Get JQuery error "a is undefined" running browser tests locally for Firefox - https://phabricator.wikimedia.org/T87446#991589 (10Jdforrester-WMF) [19:59:49] :) [19:59:53] 3MediaWiki-extensions-Echo, MediaWiki-General-or-Unknown, VisualEditor, VisualEditor-ContentEditable: Get JQuery error "a is undefined" running browser tests locally for Firefox - https://phabricator.wikimedia.org/T87446#991592 (10Jdforrester-WMF) p:5Triage>3High [19:59:59] I'll still be in SF, so I'll be seeing you guys. [20:00:10] Thanks for making me feel so welcome working in your office for all that time. [20:00:23] BladeBronson: It was our pleasure. [20:00:38] Is ori there? [20:00:41] Alright, well, i'm outta here [20:00:42] XO [20:00:55] 3VisualEditor: Increasing the spacing between Media Title and description as much as it is between the description and meta-data - https://phabricator.wikimedia.org/T87451#991597 (10Ryasmeen) 3NEW a:3Mooeypoo [20:01:12] 3VisualEditor: Increase the spacing between Media Title and description as much as it is between the description and meta-data - https://phabricator.wikimedia.org/T87451#991605 (10Ryasmeen) [20:02:00] 3VisualEditor, VisualEditor-MediaWiki-Media: Increase the spacing between Media Title and description as much as it is between the description and meta-data - https://phabricator.wikimedia.org/T87451#991615 (10Jdforrester-WMF) p:5Triage>3Normal [20:03:30] (03PS2) 10Krinkle: Tag v1.1.4 [oojs/core] - 10https://gerrit.wikimedia.org/r/186390 (owner: 10Jforrester) [20:03:57] (03CR) 10Krinkle: [C: 032] Tag v1.1.4 [oojs/core] - 10https://gerrit.wikimedia.org/r/186390 (owner: 10Jforrester) [20:04:19] RoanKattouw: You working on https://phabricator.wikimedia.org/T87160? [20:04:32] Krinkle: I have some half-finished code for it [20:04:37] k [20:04:49] It's more or less a duplicate of https://phabricator.wikimedia.org/T87420 [20:04:55] Krinkle: Hey, random question [20:05:06] Is there a way I can access the Sizzle object through the global jQuery object? [20:05:11] I want to monkey patch Sizzle.setDocument [20:05:48] (03CR) 10Bartosz Dziewoński: [C: 04-1] "We shouldn't re-use the 'titles' parameter to list magic words? Let's turn 'magicwords' into a list parameter rather than boolean? Looks s" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/140445 (https://bugzilla.wikimedia.org/49996) (owner: 10Alex Monk) [20:07:22] (03Merged) 10jenkins-bot: Tag v1.1.4 [oojs/core] - 10https://gerrit.wikimedia.org/r/186390 (owner: 10Jforrester) [20:07:32] RoanKattouw: It should be exposed as jQuery.find.setDocument [20:07:36] find = Sizzle [20:08:00] RoanKattouw: But monkey-patching it, for debugging purposes right? [20:08:54] Only for counting purposes yes [20:13:59] (03PS5) 10Mooeypoo: Allow adding a deleted parameter in the templatedata dialog [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/182980 (https://phabricator.wikimedia.org/T86916) [20:15:19] [13oojs.github.io] 15jdforrester created 06oojs-1.1.4 (+1 new commit): 02https://github.com/oojs/oojs.github.io/commit/caeaa8cc2302 [20:15:20] 13oojs.github.io/06oojs-1.1.4 14caeaa8c 15James D. Forrester: Publish v1.1.4 release from npm [20:15:59] [13oojs.github.io] 15jdforrester opened pull request #7: Publish v1.1.4 release from npm (06master...06oojs-1.1.4) 02https://github.com/oojs/oojs.github.io/pull/7 [20:16:40] (03PS6) 10Mooeypoo: Allow adding a deleted parameter in the templatedata dialog [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/182980 (https://phabricator.wikimedia.org/T86916) [20:17:40] (03PS1) 10Jforrester: Update OOjs to v1.1.4 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/186397 [20:18:57] (03CR) 10Catrope: [C: 032] Update OOjs to v1.1.4 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/186397 (owner: 10Jforrester) [20:20:47] (03Merged) 10jenkins-bot: Update OOjs to v1.1.4 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/186397 (owner: 10Jforrester) [20:20:59] (03PS1) 10Mooeypoo: Increase the space between the title and text in media dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186400 (https://phabricator.wikimedia.org/T87451) [20:22:59] Krinkle: Argh, Sizzle caches a local reference to setDocument, so it's not monkey-patchable :( [20:23:11] ( ori ---^^ ) [20:23:29] RoanKattouw: What're you trying to do anyway? (/me walks over) [20:23:32] (03PS1) 10Jforrester: Update OOjs to v1.1.4 and switch to the jQuery-optimised version [oojs/ui] - 10https://gerrit.wikimedia.org/r/186401 [20:24:48] mooeypoo: Can I get C+2s on the others of https://gerrit.wikimedia.org/r/#/q/Ib8736816e4e93306766c56cefee4b7d380944a99,n,z if you've a second? [20:27:34] (03CR) 10Bartosz Dziewoński: [C: 032] Update OOjs to v1.1.4 and switch to the jQuery-optimised version [oojs/ui] - 10https://gerrit.wikimedia.org/r/186401 (owner: 10Jforrester) [20:29:10] (03Merged) 10jenkins-bot: Update OOjs to v1.1.4 and switch to the jQuery-optimised version [oojs/ui] - 10https://gerrit.wikimedia.org/r/186401 (owner: 10Jforrester) [20:33:41] (03CR) 10Jforrester: [C: 032] Increase the space between the title and text in media dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186400 (https://phabricator.wikimedia.org/T87451) (owner: 10Mooeypoo) [20:35:35] (03Merged) 10jenkins-bot: Increase the space between the title and text in media dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186400 (https://phabricator.wikimedia.org/T87451) (owner: 10Mooeypoo) [20:36:28] (03PS1) 10Jforrester: Update VE core submodule to master (8b83816) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186403 [20:46:55] (03CR) 10Mooeypoo: [C: 032] Update VE core submodule to master (8b83816) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186403 (owner: 10Jforrester) [20:47:41] ori: Can I get the link to that Sizzle bug? [20:47:45] ori: (and also the chat log) [20:48:59] mooeypoo: https://gerrit.wikimedia.org/r/#/c/177946/ :-) [20:49:27] (03Merged) 10jenkins-bot: Update VE core submodule to master (8b83816) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186403 (owner: 10Jforrester) [20:49:36] RoanKattouw: domino includes sizzle, IIRC. what's the sizzle bug? do i need to update domino? [20:49:55] cscott: It's a performance bug, not a functionality bug [20:49:59] actually, i think i've already patched domino's sizzle to add some additional features. [20:50:11] RoanKattouw: ah, performance. [20:51:02] cscott: Basically if you use Sizzle to work with a document2 that !== window.document , then it'll 1) perform a bunch of expensive computation every time you switch which document you're using and 2) switch gratuitously if you use .children() on something that has >1 children [20:51:34] Loading my personal [[Main Page]] in VE causes 79 such context switches [20:51:47] On [[Barack Obama]], I haven't measured it but it's probably a ridiculous number [21:05:03] 3VisualEditor, VisualEditor-Performance: Eliminate call to $.getVisibleText() in ve.init.mw.Target.prototype.onNoticesReady - https://phabricator.wikimedia.org/T87412#991753 (10Krinkle) Brief backstory: MediaWiki core has an edit notice system. It's configurable by local wikis using the namespace prefix "Editno... [21:05:30] RoanKattouw_away: oh, i was wrong: domino uses Zest (https://github.com/chjj/zest) [21:06:23] RoanKattouw_away: Could I get a sanity-check on https://gerrit.wikimedia.org/r/#/c/186001/ from you at some point? [21:12:58] ori, I tried poking ori on IRC earlier with no luck [21:13:08] I don't think he's available [21:32:42] RoanKattouw, Krenair here now [21:32:51] updating the task sorry [21:38:03] ori, where were we on https://gerrit.wikimedia.org/r/#/c/130543/ ? [21:38:04] Was I going to just add some hooks to ParsoidVirtualRESTService so EventLogging can monitor it? [21:38:05] or were you going to do something? [21:44:31] 3VisualEditor, VisualEditor-EditingTools, VisualEditor-Performance: On VisualEditor load, async pre-load all the TemplateData for the page to make editing templates speedier - https://phabricator.wikimedia.org/T66772#991841 (10Krenair) Might be something that could take advantage of code in https://gerrit.wikime... [21:51:59] 3VisualEditor, VisualEditor-MediaWiki-Media: Increase the spacing between Media Title and description as much as it is between the description and meta-data - https://phabricator.wikimedia.org/T87451#991868 (10Jdforrester-WMF) 5Open>3Resolved [21:52:42] 3VisualEditor: Find-and-replace dialog has ugly grey border on betalabs - https://phabricator.wikimedia.org/T87125#991870 (10Jdforrester-WMF) 5Open>3Resolved [21:55:27] 3VisualEditor-MediaWiki, VisualEditor: Release VisualEditor-MediaWiki as "1.0" - https://phabricator.wikimedia.org/T84936#991879 (10Jdforrester-WMF) [21:55:29] 3VisualEditor-MediaWiki, VisualEditor: Link existence checker in LinkTargetInputWidget doesn't work for interwikis, language links - https://phabricator.wikimedia.org/T72504#991877 (10Jdforrester-WMF) 5Open>3Resolved [21:55:37] 3VisualEditor-MediaWiki, VisualEditor: Page created/restored confirmation message appears after clicking on Edit for a new page - https://phabricator.wikimedia.org/T58921#991880 (10Jdforrester-WMF) 5Open>3Resolved [21:56:04] 3OOjs-UI, VisualEditor, VisualEditor-Performance: OO.ui.PopupWidget.toggle triggers recalc style - https://phabricator.wikimedia.org/T87420#991886 (10Jdforrester-WMF) p:5Triage>3High [21:56:05] ori: So can I have that chat log? [21:56:08] 3VisualEditor, VisualEditor-Performance: Get rid of unnecessary jQuery.html call in ve.dm.InternalList.convertToData and ve.dm.MWReferenceNode.static.toDomElements - https://phabricator.wikimedia.org/T87417#991889 (10Jdforrester-WMF) p:5Triage>3Normal [21:56:15] 3VisualEditor, VisualEditor-Performance: ve.ce.Surface.showSelection forces a style recalc - https://phabricator.wikimedia.org/T87419#991892 (10Jdforrester-WMF) p:5Triage>3High [21:58:20] ryasmeen: Could you sanity-check https://phabricator.wikimedia.org/T74571 – I think it's fixed? [22:00:56] James_F: sure [22:04:14] 3VisualEditor-MediaWiki-Templates, VisualEditor: Insert/Template inspector should put focus on input text_field when invoked but no longer does - https://phabricator.wikimedia.org/T85484#991899 (10Jdforrester-WMF) a:5Cmcmahon>3Mooeypoo [22:05:36] 3VisualEditor-EditingTools, VisualEditor: When inserting an image, set its caption by default to be the Commons image description - https://phabricator.wikimedia.org/T53032#991902 (10Jdforrester-WMF) [22:07:04] (03PS1) 10Mooeypoo: Focus the add template input in the template dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186505 (https://phabricator.wikimedia.org/T85484) [22:14:45] James_F: Re:https://phabricator.wikimedia.org/T74571 did we fix it? [22:15:30] I dont see any patch tagged with it [22:18:05] (03PS25) 10Mooeypoo: Native leftarrow and rightarrow [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177946 (owner: 10Divec) [22:18:08] 3VisualEditor-MediaWiki-Mobile, VisualEditor: [Regression wmf5] The wikitext editor does not show any wikitext for any page when switching from mobile VE in test2 and Beta Labs - https://phabricator.wikimedia.org/T74571#991938 (10Jdforrester-WMF) 5Open>3Resolved [22:20:00] 3VisualEditor-MediaWiki, VisualEditor: VisualEditor: Suggest case insensitive results when searching for categories to add - https://phabricator.wikimedia.org/T59302#991941 (10Jdforrester-WMF) p:5Low>3Volunteer? [22:20:08] 3VisualEditor-MediaWiki, VisualEditor: Suggest case insensitive results when searching for categories to add - https://phabricator.wikimedia.org/T59302#991942 (10Jdforrester-WMF) a:5Krenair>3None [22:21:50] 3VisualEditor, VisualEditor-Performance: Combine API requests required to load VE - https://phabricator.wikimedia.org/T78628#991948 (10Jdforrester-WMF) p:5Triage>3High [22:22:02] RoanKattouw: sent [22:36:20] (03CR) 10Bartosz Dziewoński: "I was reviewing this and poking around and discovered that these widgets ARE SO HORRIBLY BROKEN, GODS. There are so many behaviors written" [oojs/ui] - 10https://gerrit.wikimedia.org/r/186140 (owner: 10Prtksxna) [22:42:29] (03CR) 10Bartosz Dziewoński: "As for this change itself, I thin the real problem is that we hard-code the 'check' icon, because that's how we want Apex to look… Not sur" [oojs/ui] - 10https://gerrit.wikimedia.org/r/186140 (owner: 10Prtksxna) [22:44:12] (03CR) 10Mooeypoo: [C: 04-1] "Okay, everything seems to work browser-like now (moving the arrows is visual, marking is logical) except for one bug --" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177946 (owner: 10Divec) [22:44:18] (03PS2) 10Esanders: Fix resizeable CSS layers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/186362 [23:04:42] (03PS1) 10Catrope: Don't use .hide() in ve.ui.Context constructor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/186524 (https://phabricator.wikimedia.org/T87160) [23:08:36] (03PS1) 10Catrope: Re-implement ve.ce.ResizableNode#showHandles using CSS [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/186527 (https://phabricator.wikimedia.org/T87160) [23:10:05] (03PS1) 10Catrope: ce.MWReferencesListNode: Remove unnecessary .show() call [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186528 (https://phabricator.wikimedia.org/T87160) [23:12:05] (03CR) 10Catrope: [C: 032] Fix resizeable CSS layers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/186362 (owner: 10Esanders) [23:13:35] (03CR) 10Catrope: [C: 032] Add keyboard commands for find next/replace [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/185688 (https://phabricator.wikimedia.org/T87113) (owner: 10Esanders) [23:13:43] (03Merged) 10jenkins-bot: Fix resizeable CSS layers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/186362 (owner: 10Esanders) [23:15:14] (03Merged) 10jenkins-bot: Add keyboard commands for find next/replace [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/185688 (https://phabricator.wikimedia.org/T87113) (owner: 10Esanders) [23:44:25] (03PS1) 10Bartosz Dziewoński: MediaWiki theme: Correctly render ComboBoxWidget's indicator as disabled [oojs/ui] - 10https://gerrit.wikimedia.org/r/186536 [23:44:27] (03PS1) 10Bartosz Dziewoński: Remove the 'flashing' feature on MenuSelectWidget/OptionWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/186537