[02:48:24] 3VisualEditor: Exact match is not always first in VisualEditor link widget autocomplete - https://phabricator.wikimedia.org/T87731#997469 (10Tgr) 3NEW [03:19:19] (03CR) 10Esanders: "yes - there should be" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/186830 (owner: 10Esanders) [03:57:00] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed. Per PS2 review." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/186830 (owner: 10Esanders) [04:00:00] (03CR) 10Amire80: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186925 (owner: 10Amire80) [04:04:34] (03CR) 10Amire80: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186926 (owner: 10Amire80) [04:10:02] (03CR) 10Amire80: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186927 (owner: 10Amire80) [04:12:12] (03CR) 10Amire80: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186935 (owner: 10Amire80) [04:14:48] (03CR) 10Amire80: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186925 (owner: 10Amire80) [04:17:59] (03CR) 10Amire80: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186937 (owner: 10Amire80) [04:19:56] (03CR) 10Amire80: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186936 (owner: 10Amire80) [04:21:54] (03CR) 10Amire80: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186935 (owner: 10Amire80) [04:23:21] (03CR) 10jenkins-bot: [V: 04-1] [BrowserTest] Restore the indentation list screenshot scenario [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186935 (owner: 10Amire80) [04:28:32] (03CR) 10Zfilipin: [C: 031] "Recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186935 (owner: 10Amire80) [04:33:56] (03PS1) 10Jforrester: test: Rebuild .rubocop_todo.yml [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187084 [04:35:30] (03CR) 10jenkins-bot: [V: 04-1] test: Rebuild .rubocop_todo.yml [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187084 (owner: 10Jforrester) [04:39:19] (03CR) 10Jforrester: "Should this be rebased onto Id2170f8d to 'prove' the Rubocop improvements?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186985 (owner: 10Amire80) [04:40:14] (03CR) 10Jforrester: [C: 032] Add generic support of alignable nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/186830 (owner: 10Esanders) [04:43:10] (03Merged) 10jenkins-bot: Add generic support of alignable nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/186830 (owner: 10Esanders) [04:49:06] (03PS1) 10Amire80: [BrowserTest] Restore page settings language screenshots [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187086 [04:50:36] (03CR) 10jenkins-bot: [V: 04-1] [BrowserTest] Restore page settings language screenshots [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187086 (owner: 10Amire80) [04:51:19] (03CR) 10Jforrester: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187084 (owner: 10Jforrester) [05:04:53] Krenair: https://gerrit.wikimedia.org/r/#/c/185343/ [05:06:27] (03CR) 10Alex Monk: [C: 032] AUTHORS: Update for the last six months' work [oojs/ui] - 10https://gerrit.wikimedia.org/r/185343 (owner: 10Jforrester) [05:07:34] (03Merged) 10jenkins-bot: AUTHORS: Update for the last six months' work [oojs/ui] - 10https://gerrit.wikimedia.org/r/185343 (owner: 10Jforrester) [05:29:27] 3MediaWiki-extensions-FlaggedRevs, VisualEditor, VisualEditor-MediaWiki: The on-page Flagged Revisions notice about transcluded files or templates having outstanding changes doesn't appear in the edit notices - https://phabricator.wikimedia.org/T54280#997699 (10Jdforrester-WMF) 5Open>3Resolved [05:58:36] 3VisualEditor-EditingTools, VisualEditor, VisualEditor-MediaWiki-Plugins: VisualEditor: Support media (tracking) - https://phabricator.wikimedia.org/T39870#997719 (10Jdforrester-WMF) [05:58:37] 3VisualEditor-MediaWiki-Plugins, MediaWiki-extensions-Translate: Create a VisualEditor plugin tool to add/edit translations and translation variables (Translate extension) - https://phabricator.wikimedia.org/T55974#997720 (10Jdforrester-WMF) [05:58:40] 3MediaWiki-extensions-SyntaxHighlight-(GeSHi), VisualEditor, VisualEditor-MediaWiki-Plugins: Create a VisualEditor plugin tool to add/edit SyntaxHighlight blocks - https://phabricator.wikimedia.org/T45126#997723 (10Jdforrester-WMF) [05:58:42] 3VisualEditor, VisualEditor-MediaWiki-Plugins, Math: Create a visual VisualEditor plugin tool to add/edit maths blocks - https://phabricator.wikimedia.org/T45058#997722 (10Jdforrester-WMF) [05:58:43] 3MediaWiki-extensions-ImageMap, Multimedia, VisualEditor-MediaWiki-Plugins: Create a VisualEditor plugin tool to add/edit imagemaps - https://phabricator.wikimedia.org/T45127#997725 (10Jdforrester-WMF) [05:58:44] 3VisualEditor-EditingTools, VisualEditor, VisualEditor-MediaWiki-Plugins: VisualEditor: Support galleries - https://phabricator.wikimedia.org/T45037#997724 (10Jdforrester-WMF) [05:58:45] 3Wikidata, VisualEditor-MediaWiki-Plugins, MediaWiki-extensions-WikibaseClient: Create a VisualEditor plugin tool to insert/edit references to Wikidata queries - https://phabricator.wikimedia.org/T48521#997726 (10Jdforrester-WMF) [05:58:47] 3VisualEditor-EditingTools, VisualEditor, VisualEditor-MediaWiki-Plugins: VisualEditor: Extend the rich TemplateData editor to be used inside VE - https://phabricator.wikimedia.org/T52169#997727 (10Jdforrester-WMF) [05:58:48] 3VisualEditor-EditingTools, VisualEditor, VisualEditor-MediaWiki-Plugins: VisualEditor: Please add an "Add wikicode" tool - https://phabricator.wikimedia.org/T53899#997728 (10Jdforrester-WMF) [05:58:49] 3MediaWiki-extensions-Score, VisualEditor-MediaWiki-Plugins, Multimedia: Create a VisualEditor plugin tool to add/edit musical scores (Score extension) - https://phabricator.wikimedia.org/T49528#997729 (10Jdforrester-WMF) [05:58:52] 3MediaWiki-extensions-Poem, VisualEditor-MediaWiki-Plugins: Create a VisualEditor plugin tool to add/edit Poem blocks - https://phabricator.wikimedia.org/T45120#997730 (10Jdforrester-WMF) [05:58:53] 3MediaWiki-extensions-EasyTimeline, VisualEditor-MediaWiki-Plugins: Create a VisualEditor plugin tool to add/edit Timelines - https://phabricator.wikimedia.org/T45115#997733 (10Jdforrester-WMF) [05:58:55] 3VisualEditor-MediaWiki-Plugins, Cite: Cite: Refactor VisualEditor editing plugin for Cite back into the Cite extension - https://phabricator.wikimedia.org/T41621#997732 (10Jdforrester-WMF) [05:58:56] 3MediaWiki-extensions-LabeledSectionTransclusion, VisualEditor-MediaWiki-Plugins: Create a VisualEditor plugin tool to add/edit LabelledSectionTransclusion markers - https://phabricator.wikimedia.org/T72581#997731 (10Jdforrester-WMF) [05:58:57] 3VisualEditor, VisualEditor-MediaWiki-Plugins: VisualEditor: Support templates - https://phabricator.wikimedia.org/T41598#997735 (10Jdforrester-WMF) [05:58:58] 3MediaWiki-extensions-Listings, VisualEditor-MediaWiki-Plugins: Create a VisualEditor plugin tool to add/edit Listings - https://phabricator.wikimedia.org/T48225#997734 (10Jdforrester-WMF) [05:59:00] 3MediaWiki-extensions-WikiHiero, VisualEditor-MediaWiki-Plugins: Create a VisualEditor plugin tool to add/edit Hieroglyphics blocks - https://phabricator.wikimedia.org/T45118#997736 (10Jdforrester-WMF) [05:59:01] 3MediaWiki-extensions-ProofreadPage, VisualEditor-MediaWiki-Plugins: Create a VisualEditor plugin to integrate with ProofreadPage - https://phabricator.wikimedia.org/T48580#997737 (10Jdforrester-WMF) [05:59:02] 3VisualEditor, VisualEditor-MediaWiki-Plugins: VisualEditor: Support references - https://phabricator.wikimedia.org/T41599#997738 (10Jdforrester-WMF) [05:59:03] 3VisualEditor, VisualEditor-MediaWiki-Plugins: VisualEditor: Support categories - https://phabricator.wikimedia.org/T41597#997739 (10Jdforrester-WMF) [05:59:22] 3VisualEditor, VisualEditor-MediaWiki-Plugins: VisualEditor: Support references - https://phabricator.wikimedia.org/T41599#465304 (10Jdforrester-WMF) [05:59:23] 3VisualEditor, VisualEditor-MediaWiki-Plugins: VisualEditor: Support categories - https://phabricator.wikimedia.org/T41597#464978 (10Jdforrester-WMF) [05:59:25] 3MediaWiki-extensions-Listings, VisualEditor-MediaWiki-Plugins: Create a VisualEditor plugin tool to add/edit Listings - https://phabricator.wikimedia.org/T48225#499404 (10Jdforrester-WMF) [05:59:26] 3MediaWiki-extensions-WikiHiero, VisualEditor-MediaWiki-Plugins: Create a VisualEditor plugin tool to add/edit Hieroglyphics blocks - https://phabricator.wikimedia.org/T45118#428449 (10Jdforrester-WMF) [05:59:27] 3MediaWiki-extensions-ProofreadPage, VisualEditor-MediaWiki-Plugins: Create a VisualEditor plugin to integrate with ProofreadPage - https://phabricator.wikimedia.org/T48580#493794 (10Jdforrester-WMF) [05:59:28] 3VisualEditor, VisualEditor-MediaWiki-Plugins: VisualEditor: Support templates - https://phabricator.wikimedia.org/T41598#465124 (10Jdforrester-WMF) [05:59:30] 3VisualEditor-MediaWiki-Plugins, Cite: Cite: Refactor VisualEditor editing plugin for Cite back into the Cite extension - https://phabricator.wikimedia.org/T41621#469079 (10Jdforrester-WMF) [05:59:31] 3MediaWiki-extensions-LabeledSectionTransclusion, VisualEditor-MediaWiki-Plugins: Create a VisualEditor plugin tool to add/edit LabelledSectionTransclusion markers - https://phabricator.wikimedia.org/T72581#746026 (10Jdforrester-WMF) [05:59:32] 3MediaWiki-extensions-Poem, VisualEditor-MediaWiki-Plugins: Create a VisualEditor plugin tool to add/edit Poem blocks - https://phabricator.wikimedia.org/T45120#428640 (10Jdforrester-WMF) [05:59:33] 3MediaWiki-extensions-EasyTimeline, VisualEditor-MediaWiki-Plugins: Create a VisualEditor plugin tool to add/edit Timelines - https://phabricator.wikimedia.org/T45115#428056 (10Jdforrester-WMF) [05:59:35] 3VisualEditor-EditingTools, VisualEditor, VisualEditor-MediaWiki-Plugins: VisualEditor: Please add an "Add wikicode" tool - https://phabricator.wikimedia.org/T53899#577053 (10Jdforrester-WMF) [05:59:36] 3MediaWiki-extensions-Score, VisualEditor-MediaWiki-Plugins, Multimedia: Create a VisualEditor plugin tool to add/edit musical scores (Score extension) - https://phabricator.wikimedia.org/T49528#508712 (10Jdforrester-WMF) [05:59:37] 3MediaWiki-extensions-ImageMap, Multimedia, VisualEditor-MediaWiki-Plugins: Create a VisualEditor plugin tool to add/edit imagemaps - https://phabricator.wikimedia.org/T45127#429510 (10Jdforrester-WMF) [05:59:38] 3VisualEditor-EditingTools, VisualEditor, VisualEditor-MediaWiki-Plugins: VisualEditor: Extend the rich TemplateData editor to be used inside VE - https://phabricator.wikimedia.org/T52169#574486 (10Jdforrester-WMF) [05:59:40] 3Wikidata, VisualEditor-MediaWiki-Plugins, MediaWiki-extensions-WikibaseClient: Create a VisualEditor plugin tool to insert/edit references to Wikidata queries - https://phabricator.wikimedia.org/T48521#485326 (10Jdforrester-WMF) [05:59:41] 3MediaWiki-extensions-SyntaxHighlight-(GeSHi), VisualEditor, VisualEditor-MediaWiki-Plugins: Create a VisualEditor plugin tool to add/edit SyntaxHighlight blocks - https://phabricator.wikimedia.org/T45126#429395 (10Jdforrester-WMF) [05:59:43] 3VisualEditor-EditingTools, VisualEditor, VisualEditor-MediaWiki-Plugins: VisualEditor: Support galleries - https://phabricator.wikimedia.org/T45037#472832 (10Jdforrester-WMF) [05:59:44] 3VisualEditor-MediaWiki-Plugins, MediaWiki-extensions-Translate: Create a VisualEditor plugin tool to add/edit translations and translation variables (Translate extension) - https://phabricator.wikimedia.org/T55974#578193 (10Jdforrester-WMF) [05:59:45] 3VisualEditor, VisualEditor-MediaWiki-Plugins, Math: Create a visual VisualEditor plugin tool to add/edit maths blocks - https://phabricator.wikimedia.org/T45058#475322 (10Jdforrester-WMF) [05:59:46] 3VisualEditor-Tables, VisualEditor-EditingTools, VisualEditor, VisualEditor-MediaWiki-Plugins: Support tables (tracking) - https://phabricator.wikimedia.org/T41596#464872 (10Jdforrester-WMF) [05:59:48] 3VisualEditor-EditingTools, VisualEditor, VisualEditor-MediaWiki-Plugins: VisualEditor: Support media (tracking) - https://phabricator.wikimedia.org/T39870#409537 (10Jdforrester-WMF) [05:59:49] 3VisualEditor-EditingTools, VisualEditor, VisualEditor-MediaWiki-Plugins: VisualEditor: Plugin editors to be created (tracking) - https://phabricator.wikimedia.org/T48803#524588 (10Jdforrester-WMF) [05:59:52] 3VisualEditor-EditingTools, VisualEditor, VisualEditor-MediaWiki-Plugins: VisualEditor: Plugin editors to be created (tracking) - https://phabricator.wikimedia.org/T48803#997764 (10Jdforrester-WMF) 5Open>3Resolved a:3Jdforrester-WMF Replaced by the #VisualEditor-MediaWiki-Plugins project. [06:00:23] 3VisualEditor, VisualEditor-MediaWiki, VisualEditor-Initialisation: VisualEditor: Samsung browser fails the blacklist - https://phabricator.wikimedia.org/T53274#997769 (10Jdforrester-WMF) [06:00:53] 3VisualEditor, VisualEditor-Initialisation: VisualEditor: Browser blacklist issues (tracking) - https://phabricator.wikimedia.org/T52781#997771 (10Jdforrester-WMF) 5Open>3Resolved a:3Jdforrester-WMF Replaced by #VisualEditor-Initialisation. [06:02:16] 3VisualEditor-MediaWiki-Mobile, VisualEditor-ContentEditable, VisualEditor: VisualEditor: Safari on iPad converts numbers that resemble phone numbers to href=tel: links - https://phabricator.wikimedia.org/T55315#997775 (10Jdforrester-WMF) [06:02:57] 3VisualEditor-ContentEditable, VisualEditor, VisualEditor-MediaWiki: VisualEditor: Broken DivX browser plugin causes "myEventWatcherDiv" to be injected into the page - https://phabricator.wikimedia.org/T53423#997777 (10Jdforrester-WMF) [06:03:29] 3VisualEditor: VisualEditor: Non-English Wikipedia issues (tracking) - https://phabricator.wikimedia.org/T53792#997779 (10Jdforrester-WMF) 5Open>3Resolved Replaced with projects. [06:04:01] 3VisualEditor: VisualEditor: Non-English Wikipedia issues (tracking) - https://phabricator.wikimedia.org/T53792#997785 (10Jdforrester-WMF) [06:04:05] 3VisualEditor-ContentLanguage, VisualEditor: VisualEditor multilingual input / i18n issues (tracking) - https://phabricator.wikimedia.org/T35077#997788 (10Jdforrester-WMF) [06:04:07] 3VisualEditor-ContentLanguage, VisualEditor-InterfaceLanguage, VisualEditor: VisualEditor: Support for right-to-left (rtl) / bidirectional content (tracking) - https://phabricator.wikimedia.org/T35126#997782 (10Jdforrester-WMF) 5Open>3Resolved a:3Jdforrester-WMF Replaced with projects. [06:04:22] 3VisualEditor-ContentLanguage, VisualEditor: VisualEditor multilingual input / i18n issues (tracking) - https://phabricator.wikimedia.org/T35077#997791 (10Jdforrester-WMF) 5Open>3Resolved a:3Jdforrester-WMF Replaced with projects. [06:04:57] 3VisualEditor-EditingTools, VisualEditor, VisualEditor-MediaWiki-Plugins: VisualEditor: Support media (tracking) - https://phabricator.wikimedia.org/T39870#997795 (10Jdforrester-WMF) 5Open>3Resolved a:3Jdforrester-WMF Replaced with projects. [06:20:57] (03PS4) 10Amire80: [BrowserTest] WIP: Restore the formula screenshot scenario [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186937 [06:22:31] (03CR) 10jenkins-bot: [V: 04-1] [BrowserTest] WIP: Restore the formula screenshot scenario [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186937 (owner: 10Amire80) [06:24:36] (03CR) 10Amire80: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186935 (owner: 10Amire80) [06:25:57] (03CR) 10Amire80: "I think that it's not really related. This can be safely merged by itself. Zeljko?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186985 (owner: 10Amire80) [06:35:19] 3Cite, VisualEditor-MediaWiki-Plugins: Cite: Refactor VisualEditor editing plugin for Cite back into the Cite extension - https://phabricator.wikimedia.org/T41621#997829 (10John_Broughton) [06:35:20] 3VisualEditor, VisualEditor-MediaWiki: VisualEditor: Support most common citation templates (special-case) - https://phabricator.wikimedia.org/T41600#997830 (10John_Broughton) [06:35:22] 3VisualEditor, VisualEditor-MediaWiki-Plugins: VisualEditor: Support references - https://phabricator.wikimedia.org/T41599#997827 (10John_Broughton) 5Resolved>3Open I'm not clear as to why this is shown as "Closed, Resolved". VE still won't edit citations/footnotes where the body of the citation is in the Re... [06:35:23] 3VisualEditor-EditingTools, VisualEditor: VisualEditor: Warn user when saving page with s but not - https://phabricator.wikimedia.org/T47132#997831 (10John_Broughton) [06:35:24] 3VisualEditor: VisualEditor: Pre-beta needs (tracker) - https://phabricator.wikimedia.org/T50426#997832 (10John_Broughton) [06:57:29] 3VisualEditor, VisualEditor-Performance: Get rid of unnecessary jQuery.html call in ve.dm.MWReferenceNode.static.toDomElements - https://phabricator.wikimedia.org/T87417#997841 (10Krenair) a:3Catrope [06:57:45] 3VisualEditor-MediaWiki-Plugins, MediaWiki-extensions-Translate: Create a VisualEditor plugin tool to add/edit translations and translation variables (Translate extension) - https://phabricator.wikimedia.org/T55974#997845 (10Nemo_bis) [06:57:46] 3VisualEditor-EditingTools, VisualEditor: VisualEditor: Content inside templates for translation of templates does not render in friendly ways - https://phabricator.wikimedia.org/T73730#997846 (10Nemo_bis) [07:26:47] 3VisualEditor-EditingTools, VisualEditor, VisualEditor-MediaWiki-Plugins: VisualEditor: Support media (tracking) - https://phabricator.wikimedia.org/T39870#997892 (10Nemo_bis) >>! In T39870#997795, @Jdforrester-WMF wrote: > Replaced with projects. Which ones? I definitely can't watch the entire VisualEditor-Med... [07:29:32] (03CR) 10Fomafix: "@Nemo bis: This bug is not related to bug 24763." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/183254 (owner: 10Gerrit Patch Uploader) [09:55:21] (03PS1) 10Amire80: [BrowserTest] Rename iframe to window_frame [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187099 [09:55:23] (03PS1) 10Amire80: [BrowserTest] Refactor offset_element and browser_zoom [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187100 [09:56:59] (03CR) 10jenkins-bot: [V: 04-1] [BrowserTest] Refactor offset_element and browser_zoom [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187100 (owner: 10Amire80) [09:57:52] (03CR) 10jenkins-bot: [V: 04-1] [BrowserTest] Rename iframe to window_frame [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187099 (owner: 10Amire80) [10:49:12] 3OOjs-UI: OO.ui.InputWidget() passes config to OO.ui.CheckboxInputWidget.prototype.getInputElement(), and this parameter is ignored - https://phabricator.wikimedia.org/T87648#997980 (10matmarex) a:3matmarex [10:49:16] 3OOjs-UI: OO.ui.InputWidget.prototype.getInputElement has a config parameter in its documentation, but not in its implementation - https://phabricator.wikimedia.org/T87649#997981 (10matmarex) a:3matmarex [13:17:50] (03PS5) 10Mvolz: [WIP] Use html-metadata library [services/citoid] - 10https://gerrit.wikimedia.org/r/182975 [13:20:54] so i have a node library that I've put some general use code in that I'm developing as a part of citoid [13:21:10] should this be in the wikimedia github group? [13:21:26] didn't occur to me until that email to wikitech went out from someone asking for access :) [16:24:08] Hey mvolz. :-) [16:24:10] mvolz: Moving to wikimedia/ is pretty eaesy. [16:24:12] Err. Easy. [16:27:12] (03PS12) 10Jforrester: Lazy load the media search results [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185225 (owner: 10Mooeypoo) [16:32:57] mvolz: Also, we need to work out why the Zotero service isn't running in production. :-( [16:36:27] mvolz: And for that matter, http://citoid.wmflabs.org/ is down too. :-( [16:42:46] blast [16:42:53] yes, service monitoring would be good [16:43:45] ok can you add me to the girhub group or should i ask brion? [16:48:25] citoid.wmflabs was being kept up by forever, guess forever wasn't really for forever. I kicked it, it's alive now. [16:49:35] mvolz: I can do it. [16:49:48] Yeah, all of Labs had to restart yesterday (security bug). [16:49:56] Some things didn't come back up. [16:50:19] Confirming that https://github.com/mvolz is you? :-) [16:51:19] Yup! [16:51:44] weird, I'm missing all my logs from that machine :/ [16:52:07] Helpful. [16:52:16] You are now invited. :-) [16:55:31] apparently I need admin rights to transfer a repo to wikimedia [16:58:00] mvolz: Which repo? [16:58:35] https://github.com/mvolz/html-metadata [16:58:47] Hmm. Can't you "propose a move" for an admin to accept? [17:00:07] nope. When I try to transfer ownership, it just gives me a nice read error complaining I don't have admin rights to wikimedia [17:00:12] red* [17:00:14] * James_F sighs. [17:00:25] I guess I could fork it into Wikimedia, but… [17:01:37] I've given you temporary admin rights. [17:03:58] Aha, success. [17:04:28] done [17:04:34] you can make me a pleb again now :) [17:04:39] Done. :-) [17:04:48] I've made you a member of the Services group there. [17:04:57] And put that repo there. [17:05:16] Ok, I just gave staff group access when I moved it [17:05:30] That's useful too. [17:06:30] * James_F files an issue. ;-) [17:09:08] Yeah they should have a request - confirm option for transferring things [17:09:47] oh, an issue to the library [17:09:48] :) [17:10:57] * James_F grins. [17:15:19] (03CR) 10Jforrester: [C: 031] Lazy load the media search results [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185225 (owner: 10Mooeypoo) [17:15:51] (03CR) 10Jforrester: [C: 031] When changing image source, use already-available API info [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185589 (https://phabricator.wikimedia.org/T87267) (owner: 10Mooeypoo) [17:16:29] (03CR) 10Jforrester: [C: 031] Add a layout queue to media result widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185453 (https://phabricator.wikimedia.org/T86802) (owner: 10Mooeypoo) [17:21:45] 3VisualEditor-CopyPaste, VisualEditor: Ctrl+C copying of text with template removes text in FF - https://phabricator.wikimedia.org/T86921#998468 (10Etonkovidova) p:5Triage>3Normal [17:30:31] Corruption alert: visualeditor-needcheck on nowiki: https://no.wikipedia.org/?diff=13655998 [17:30:31] Corruption alert: visualeditor-needcheck on nowiki: https://no.wikipedia.org/?diff=13656030 [17:30:31] Corruption alert: visualeditor-needcheck on nowiki: https://no.wikipedia.org/?diff=13656033 [17:30:31] Corruption alert: visualeditor-needcheck on nowiki: https://no.wikipedia.org/?diff=13656035 [17:30:31] Corruption alert: visualeditor-needcheck on nowiki: https://no.wikipedia.org/?diff=13656037 [17:46:07] mvolz, James_F: There are two primary reasons Zotero is down in prod [17:46:27] #1 is that Alexandros is working on installing it via a Debian package instead of the ugly way I did it [17:46:40] #2 is that that machine can't actually access the internet and needs to do so through a proxy [17:46:56] Whereas the Labs install is done differently? [17:47:12] #2b is that before they're gonna bother to fix that, we need to implement URL whitelisting [17:47:31] Because having the WMF cluster send requests to arbitrary URLs is something Chris wasn't exactly enamored with [17:47:50] I think labs also uses the ugly thing [17:47:51] Wait, what? [17:49:52] (From IRL conversation: James_F to clear up #2b with Chris and Alexandros) [18:01:16] 3OOjs-UI: PopupButtonWidget should probably open when focused and should close when blur - https://phabricator.wikimedia.org/T87698#998619 (10TheDJ) [18:03:54] RoanKattouw, James_F: just a random comment but the translators need to be kept up to date pretty regularily [18:04:02] they tend to move faster than anything else [18:04:39] would it make sense for them to be a submodule? or just do it manually, frequently? [18:04:53] submodule of the deploy repo* [18:12:52] RoanKattouw: https://gerrit.wikimedia.org/r/187131 [18:13:07] I'm not sure how Alexandros's deb package solution addresses that [18:13:08] mvolz: A submodule could work. [18:13:30] A .deb is going to be frighteningly slow to update, isn't it? [18:14:02] I don't know whether the translators are part of the .deb or not [18:16:04] We should work that out. :-) [18:17:39] I'll ask Alexandros when he has time to talk [18:19:37] 3VisualEditor: Focus should be on input field when opening template dialog with {{ key combo - https://phabricator.wikimedia.org/T87777#998691 (10TheDJ) 3NEW [18:22:47] this ^^ should be fixed on master with my previous patch, James_F [18:23:00] (okay, movers are back with another batch, bbs) [18:23:58] Yes it is [18:24:09] 3VisualEditor-ContentEditable, VisualEditor: Infobox of "en:Medway SLA100 Executive" not visible in edit mode - https://phabricator.wikimedia.org/T87779#998733 (10Raymond) 3NEW [18:24:15] 3VisualEditor: Focus should be on input field when opening template dialog with {{ key combo - https://phabricator.wikimedia.org/T87777#998742 (10Catrope) This was fixed recently by https://gerrit.wikimedia.org/r/#/c/186505/ [18:27:03] RoanKattouw: perf testing on osmium reaallllllly close now [18:27:22] should have a working rig by the end of today [18:29:11] ori: Awesome. Let me know when it's ready, James wants numbers for his QR slide [18:29:12] s [18:34:14] (03CR) 10Esanders: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186171 (owner: 10Esanders) [18:40:08] Krenair: In MWCategoryWidget this.items[index].metaItem should give you the meta item of the next thing [18:40:10] Or index + 1 or whatever [18:42:11] >> 1 && 2 [18:42:12] RoanKattouw: (number) 2 [18:42:18] >> undefined && 2 [18:42:18] RoanKattouw: undefined [18:42:26] >> '' && 2 [18:42:26] RoanKattouw: (string) '' [18:43:01] >> undefined || 3 [18:43:02] RoanKattouw: (number) 3 [18:43:05] >> false || 3 [18:43:05] RoanKattouw: (number) 3 [18:43:11] >> 'x' || 3 [18:43:12] RoanKattouw: (string) 'x' [18:53:21] (03PS8) 10Alex Monk: Make category widget items draggable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173360 (https://bugzilla.wikimedia.org/50809) [18:53:26] (03CR) 10jenkins-bot: [V: 04-1] Make category widget items draggable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173360 (https://bugzilla.wikimedia.org/50809) (owner: 10Alex Monk) [18:55:36] (03PS9) 10Alex Monk: Make category widget items draggable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173360 (https://bugzilla.wikimedia.org/50809) [18:57:06] (03CR) 10jenkins-bot: [V: 04-1] Make category widget items draggable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173360 (https://bugzilla.wikimedia.org/50809) (owner: 10Alex Monk) [19:01:09] (03PS10) 10Alex Monk: Make category widget items draggable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173360 (https://bugzilla.wikimedia.org/50809) [19:08:31] 3VisualEditor: in language screenshots there must be a way to add more margins around the element that is being cropped - https://phabricator.wikimedia.org/T87786#998863 (10Amire80) 3NEW [19:11:16] 3OOjs-UI: Elements of ButtonWidget, ButtonSelectWidget etc do not have accessible attributes that indicate the disabled state - https://phabricator.wikimedia.org/T87690#998876 (10TheDJ) Summary: - We will add aria-disabled to the setDisabled of widget. (This fixes most screenreaders and will work for any type of... [19:12:24] 3VisualEditor: [Regression wmf16] Cannot close citation dialog getting error:TypeError: Cannot read property '$element' of null - https://phabricator.wikimedia.org/T87787#998887 (10Ryasmeen) 3NEW [19:12:27] (03PS11) 10Alex Monk: Make category widget items draggable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173360 (https://bugzilla.wikimedia.org/50809) [19:13:56] (03PS1) 10Esanders: Provide Platform#getConfig and shortcut ve#config [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187143 [19:14:01] (03CR) 10Alex Monk: "Also needs a Phabricator ticket link instead of BZ, I guess" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173360 (https://bugzilla.wikimedia.org/50809) (owner: 10Alex Monk) [19:14:24] (03PS1) 10Esanders: Migrate to ve.config (except in init where it doesn't exist) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187144 [19:15:37] (03CR) 10jenkins-bot: [V: 04-1] Migrate to ve.config (except in init where it doesn't exist) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187144 (owner: 10Esanders) [19:16:50] (03CR) 10Krinkle: [C: 04-1] "jQuery objects don't have a "then" method. Call .promise() to get the promise. Then call either "done" or "then" (You'll want "then" in th" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186171 (owner: 10Esanders) [19:18:49] (03CR) 10Krinkle: "@Catrope: In that case, can't we simply listen on both? I agree our current DOM structure is messy, and having the toolbar inside the targ" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186171 (owner: 10Esanders) [19:19:24] (03CR) 10Alex Monk: "Might be able to do something here when If10cbbd6 goes through" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/153934 (https://bugzilla.wikimedia.org/49904) (owner: 10Alex Monk) [19:21:43] (03CR) 10Krinkle: "There is no usage of config() and no example of what the intended purpose is for SA or MW platforms. Please provide intended purpose in co" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187143 (owner: 10Esanders) [19:22:25] 3VisualEditor: [Regression wmf16] Cannot close citation dialog getting error:TypeError: Cannot read property '$element' of null - https://phabricator.wikimedia.org/T87787#998936 (10Krenair) That error occurs when opening the dialog, and comes from OO.ui.BookLayout.focus which gets run when the Window is ready. [19:24:42] (03CR) 10Esanders: "@Krinkle I don't think we should start adding listeners to children of the target because the end user may or may not move them around. I'" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186171 (owner: 10Esanders) [19:26:01] (03PS3) 10Esanders: Fix DOM structure on setup/teardown [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186171 [19:26:51] (03CR) 10Esanders: "Ib7c0c83a7" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187143 (owner: 10Esanders) [19:41:08] 3VisualEditor, OOjs-UI: MediaWiki theme: Toolbar popup widgets have no visible anchor - https://phabricator.wikimedia.org/T85998#999099 (10Esanders) Can we get an update on this? [19:41:26] 3VisualEditor, OOjs-UI: MediaWiki theme: Toolbar border too strong - https://phabricator.wikimedia.org/T85974#999105 (10Esanders) Can we get an update on this? [19:43:49] (03PS1) 10TheDJ: Set aria-disabled on the Widget [oojs/ui] - 10https://gerrit.wikimedia.org/r/187163 (https://phabricator.wikimedia.org/T87690) [19:53:17] (03PS1) 10Etonkovidova: [BrowserTest] Add basic test for table creation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187166 [19:59:19] 3VisualEditor-MediaWiki-Templates, VisualEditor: Insert/Template inspector should put focus on input text_field when invoked but no longer does - https://phabricator.wikimedia.org/T85484#999200 (10Jdforrester-WMF) [19:59:20] 3VisualEditor: Focus should be on input field when opening template dialog with {{ key combo - https://phabricator.wikimedia.org/T87777#999199 (10Jdforrester-WMF) [20:11:37] (03PS1) 10Ryasmeen: [BrowserTest] [WIP] Updating test for Media Settings interface [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187171 [20:24:39] (03CR) 10Krinkle: "Note that .bind and .apply make this path considerably slower (10-30x). We may want to start caching the values. Eg. avoid patterns like v" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187144 (owner: 10Esanders) [20:29:54] ori: When you're around, could you use vbench for VE as of 1 September 2014, 31 December 2014, and today? [20:30:32] ori: 1f136f9d1d67fcb7006e68727450f1280d45e068 for the first, 9600d28ebc8eacf02a5ae0bbf04f113e32947d84 for the second and HEAD for the third? [20:51:54] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186108 (https://phabricator.wikimedia.org/T53798) (owner: 10Jforrester) [20:54:57] (03CR) 10Mooeypoo: "recheck" [oojs/ui] - 10https://gerrit.wikimedia.org/r/187052 (https://phabricator.wikimedia.org/T87637) (owner: 10Mooeypoo) [20:58:42] (03PS8) 10Mooeypoo: When changing image source, use already-available API info [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185589 (https://phabricator.wikimedia.org/T87267) [20:58:48] (03PS7) 10Mooeypoo: Add a layout queue to media result widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185453 (https://phabricator.wikimedia.org/T86802) [21:00:40] (03CR) 10jenkins-bot: [V: 04-1] When changing image source, use already-available API info [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185589 (https://phabricator.wikimedia.org/T87267) (owner: 10Mooeypoo) [21:11:36] (03PS1) 10Alex Monk: Update permanent link and PDF download link oldids on save [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187179 (https://phabricator.wikimedia.org/T74461) [21:12:05] 3VisualEditor: [Regression wmf16] Cannot close citation dialog getting error:TypeError: Cannot read property '$element' of null - https://phabricator.wikimedia.org/T87787#999327 (10Catrope) I think this might be because the focus function doesn't account for the `!page && !this.outlined` case correctly? [21:13:07] 3VisualEditor-ContentEditable, VisualEditor: Clean up mixed use of getters, attributes and properties around rowspan/colspan in TableCellNode - https://phabricator.wikimedia.org/T87798#999337 (10Krinkle) 3NEW [21:16:16] (03PS2) 10Alex Monk: Update permanent link and PDF download link oldids on save [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187179 (https://phabricator.wikimedia.org/T74461) [21:16:48] 3VisualEditor-ContentEditable, VisualEditor: ve.ce.TableCellNode should not add rowspan="1" / colspan="1" to every cell in the editor - https://phabricator.wikimedia.org/T87799#999353 (10Krinkle) 3NEW [21:16:58] 3VisualEditor-ContentEditable, VisualEditor: ve.ce.TableCellNode should not add rowspan="1" / colspan="1" to every cell in the editor - https://phabricator.wikimedia.org/T87799#999363 (10Krinkle) [21:18:26] James_F: could I? no -- I have the MW-Core quarterly review coming up. Could someone? Yes, it's ready for use (finally!) [21:18:35] I was going to send out a quick e-mail about that now [21:18:57] ori: Awesome. If I can run the numbers myself, even better. :-) [21:18:59] RoanKattouw: got a minute? [21:19:49] ori: On IRC yes, in person not right now [21:20:44] ori: Please do tell me how to use osmium [21:20:51] In the 10 mins you still have before your meeting [21:20:58] Because I don't think James_F has access to it but I sure do [21:21:05] RoanKattouw: But you're not here. [21:21:16] RoanKattouw: Yet another reason not to have a pointless meeting. [21:21:22] James_F: There's this thing called IRC [21:21:32] RoanKattouw: There's this thing called respect for people's time. [21:25:42] RoanKattouw: (1) decide on a page to use for the benchmark. at the moment, the osmium chrome instance isn't logged in, so it has to be on a wiki where VE is available for anons, like frwiki. [21:25:58] (2) get the URL of that page. be sure to get the http and not https URL. [21:26:54] (3) run: vbench --reps [21:26:56] for example: [21:27:10] https://dpaste.de/QetJ/raw [21:27:15] (03CR) 10Mooeypoo: [C: 04-1] "Code looks good and works. Only one comment regarding the naming -- I think that both link and image info need to be consistent with their" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180228 (https://phabricator.wikimedia.org/T75822) (owner: 10Alex Monk) [21:27:23] OK [21:27:48] the requests are handled by localhost. mediawiki is checked out on /srv/mediawiki. the VisualEditor extension folder has .git and a remote configured, so you can git-fetch / git-checkout a specific commit. [21:28:17] run sync-common to reset the host to production code [21:28:21] that's it [21:28:25] What we really need is a hack to make the edit button available for enwiki [21:28:32] through a query string param or something [21:28:54] I'll write something up for that and try to get it into today's SWAT [21:28:55] nah, it's not too hard to just set a cookie and make it logged in [21:29:00] Oh OK [21:29:01] That's also good [21:29:11] 3VisualEditor: VisualEditor: histograms are duplicated while editing - https://phabricator.wikimedia.org/T55583#999405 (10NemesisIII) I discovered the bug in August 2013 and it was said to be fine from November 2013 at fr.wp. It must have been fixed by chance. [21:29:14] I'll have you do that later then [21:29:20] * ori nods [21:29:26] And run benchmarks on frwiki or whatever in the meantime [21:29:48] oh and you'll likely have to sudo -u mwdeploy to perform git operations on the local VisualEditor repos [21:29:53] Right [21:29:55] Makes sense [21:30:00] ori: Thanks! [21:30:08] OK thanks man, I'll go and get some data, see you after your QR at some point [21:30:24] (03CR) 10Esanders: "Does this break the array sig, or just not document it?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187144 (owner: 10Esanders) [21:31:07] cool [21:33:22] RoanKattouw: also for the moment only you should use it, since vbench targets the active chrome tab, and doesn't currently have any safeguard to prevent concurrent runs [21:33:30] OK [21:33:41] Thanks for mentioning that cause I'd already fired up screen [21:33:43] I can write this down on-wiki somewhere [21:33:55] RoanKattouw: you can use it, i logged off [21:34:43] James_F: should I put it on a sub-page of mw:VisualEditor? [21:36:38] (03PS1) 10Ricordisamoa: Add 'license-name' matching SPDX conventions [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/187203 [21:38:15] (03CR) 10Nemo bis: [C: 031] Add 'license-name' matching SPDX conventions [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/187203 (owner: 10Ricordisamoa) [21:40:05] ori: It doesn't work. It just sits there and hangs and prints nothing [21:40:19] [09:36:51] Loading http://fr.wikipedia.org/wiki/François_Hollande [21:40:23] Couple minutes of silence [21:40:25] ^C [21:40:33] RoanKattouw: it's protected [21:40:35] Tried Barack Obama too, to exclude the ç being the problem, but same result [21:40:36] so not editable by anon [21:40:40] Ugh [21:40:43] OK [21:40:54] I'll go find a non-protected page [21:41:03] RoanKattouw: http://fr.wikipedia.org/wiki/Geganii [21:41:15] But that's such a short page [21:41:29] http://fr.wikipedia.org/wiki/Bassin_minier_de_Ronchamp_et_Champagney ? [21:41:55] Mwahahahah https://fr.wikipedia.org/wiki/%C3%89tats-Unis [21:42:07] heh [21:42:18] RoanKattouw: http, not https! [21:42:26] Yes, sorry [21:42:29] * RoanKattouw blames HTTPSEverywhere [21:43:08] TODOs for me: make vbench log in; make logging more useful / verbose; automatically convert https:// to http://. [21:43:24] OK États-Unis is working [21:43:29] It's using the code in php-1.25wmf14, right? [21:43:32] (Given that I'm hitting frwiki) [21:43:35] yep. [21:43:38] OK [21:43:54] That page takes 6-7 seconds [21:44:00] Which is a nice example of a big, slow page [21:45:09] RoanKattouw: keep in mind that HHVM on osmium is not warmed up thoroughly since it's not handling real traffic, only vbench requests. so doing a throwaway warmup run with --reps 10 might be good. (Chrome's cache is reset on each load) [21:45:50] last but not least, if you run vbench with --write it will generate .cpuprofile files that you can scp to your laptop and open up in chrome's dev tools [21:45:57] oooh nice [21:56:20] (03CR) 10Legoktm: [C: 032] Add 'license-name' matching SPDX conventions [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/187203 (owner: 10Ricordisamoa) [21:56:23] (03Merged) 10jenkins-bot: Add 'license-name' matching SPDX conventions [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/187203 (owner: 10Ricordisamoa) [22:00:57] RoanKattouw: any findings? [22:01:08] Just getting a spreadsheet going here [22:01:13] coooool [22:01:19] Doing some base measurements in wmf14 before switching versions [22:01:20] So none yet [22:03:42] Krenair: https://gerrit.wikimedia.org/r/#/c/186883/ https://gerrit.wikimedia.org/r/#/c/186645/ [22:03:56] Krenair: https://gerrit.wikimedia.org/r/#/c/187143/ [22:05:37] Krenair: https://gerrit.wikimedia.org/r/#/c/186108/ https://gerrit.wikimedia.org/r/#/c/185589/ https://gerrit.wikimedia.org/r/#/c/185453/ https://gerrit.wikimedia.org/r/#/c/187084/ https://gerrit.wikimedia.org/r/#/c/186887/ [22:06:01] ori: Hmm, .git is not populated so this is going to be interesting [22:19:18] (03CR) 10Alex Monk: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185589 (https://phabricator.wikimedia.org/T87267) (owner: 10Mooeypoo) [22:19:54] (03CR) 10Catrope: [C: 032] Update permanent link and PDF download link oldids on save [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187179 (https://phabricator.wikimedia.org/T74461) (owner: 10Alex Monk) [22:20:34] (03CR) 10Alex Monk: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187084 (owner: 10Jforrester) [22:21:03] (03CR) 10jenkins-bot: [V: 04-1] Update permanent link and PDF download link oldids on save [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187179 (https://phabricator.wikimedia.org/T74461) (owner: 10Alex Monk) [22:27:27] 3OOjs-UI: OO.ui.InputWidget.prototype.getInputElement has a config parameter in its documentation, but not in its implementation - https://phabricator.wikimedia.org/T87649#999624 (10matmarex) Yes, this is expected. We do use the `config` parameter in two `InputWidget` subclasses: `ButtonInputWidget` and `TextIn... [22:28:24] 3OOjs-UI: OO.ui.InputWidget() passes config to OO.ui.CheckboxInputWidget.prototype.getInputElement(), and this parameter is ignored - https://phabricator.wikimedia.org/T87648#999625 (10matmarex) [22:28:27] 3OOjs-UI: OO.ui.InputWidget.prototype.getInputElement has a config parameter in its documentation, but not in its implementation - https://phabricator.wikimedia.org/T87649#999627 (10matmarex) [22:28:41] 3OOjs-UI: OO.ui.InputWidget() passes config to OO.ui.CheckboxInputWidget.prototype.getInputElement(), and this parameter is ignored - https://phabricator.wikimedia.org/T87648#996073 (10matmarex) This really is the same thing as T87649, let's discuss there. [22:29:03] 3OOjs-UI: OO.ui.InputWidget.prototype.getInputElement has a config parameter in its documentation, but not in its implementation - https://phabricator.wikimedia.org/T87649#999631 (10matmarex) p:5Triage>3Normal [22:29:10] (03CR) 10Alex Monk: [C: 032] Use DOM methods instead of jQuery .html() in references DM code [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186887 (https://phabricator.wikimedia.org/T87417) (owner: 10Catrope) [22:29:56] RoanKattouw: HHVM on osmium is 500ing, are you doing anything funky? [22:30:01] Yes [22:30:06] I rolled VE back to the September 1st version [22:30:16] (03CR) 10jenkins-bot: [V: 04-1] Use DOM methods instead of jQuery .html() in references DM code [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186887 (https://phabricator.wikimedia.org/T87417) (owner: 10Catrope) [22:30:28] And now it's not working anymore, I'm just starting to look at why [22:30:29] RoanKattouw: OK, no problem. I'll disable alerting for that host. [22:30:36] Oh yes [22:30:37] Sorry [22:30:57] no worries, not your fault [22:37:29] RoanKattouw, uhm, so, Alex and I ran into the weirdest bug [22:37:34] ori: How can I read Apache's error.log? [22:37:47] RoanKattouw, we could use your help when you're done with your meeting. [22:37:51] mooeypoo: OK [22:38:41] RoanKattouw: at the moment your best bet is probably to grep for osmium in fluorine:/a/mw-log/{fatal.log,exception.log,apache2.log} [22:38:46] Aha OK [22:39:56] (03PS1) 10Bartosz Dziewoński: InputWidget: Clarify documentation of #getInputElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/187256 (https://phabricator.wikimedia.org/T87649) [22:40:41] 3OOjs-UI: OO.ui.InputWidget.prototype.getInputElement has a config parameter in its documentation, but not in its implementation (because it's only used in subclasses) - https://phabricator.wikimedia.org/T87649#999681 (10matmarex) [22:41:40] (03CR) 10jenkins-bot: [V: 04-1] InputWidget: Clarify documentation of #getInputElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/187256 (https://phabricator.wikimedia.org/T87649) (owner: 10Bartosz Dziewoński) [22:41:44] Krinkle: Where are you? CI system issues. :-( [22:41:52] James_F: mwcore q [22:41:58] 3OOjs-UI: Create a simpler API into SelectWidget - https://phabricator.wikimedia.org/T87602#999689 (10matmarex) Hmm. I am not entirely convinced of that usefulness and goodness of that. [22:42:02] Krinkle: Ick. [22:42:12] James_F: looking into it [22:42:12] now [22:42:13] 3OOjs-UI: Create a simpler API into SelectWidget - https://phabricator.wikimedia.org/T87602#999690 (10matmarex) p:5Triage>3Volunteer? [22:42:15] Krinkle: https://integration.wikimedia.org/ci/job/mediawiki-extensions-hhvm/1437/console etc. [22:42:17] Krinkle: Thanks. [22:42:35] 22:29:23 /srv/deployment/integration/slave-scripts/bin/mw-install-sqlite.sh: line 3: /srv/deployment/integration/slave-scripts/bin/mw-set-env.sh: Permission denied [22:43:44] Yeah. [22:43:50] (03CR) 10Bartosz Dziewoński: "Test failure appears to be false." [oojs/ui] - 10https://gerrit.wikimedia.org/r/187256 (https://phabricator.wikimedia.org/T87649) (owner: 10Bartosz Dziewoński) [22:49:05] (03PS1) 10Mooeypoo: [untested] Make sure there is a page before focusing in BookletLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/187264 (https://phabricator.wikimedia.org/T87787) [22:50:12] (03CR) 10jenkins-bot: [V: 04-1] [untested] Make sure there is a page before focusing in BookletLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/187264 (https://phabricator.wikimedia.org/T87787) (owner: 10Mooeypoo) [22:59:59] (03CR) 10Alex Monk: [C: 032] MWMediaDialog: Add contextual help for controls [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186108 (https://phabricator.wikimedia.org/T53798) (owner: 10Jforrester) [23:01:06] (03CR) 10jenkins-bot: [V: 04-1] MWMediaDialog: Add contextual help for controls [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186108 (https://phabricator.wikimedia.org/T53798) (owner: 10Jforrester) [23:02:41] 3OOjs-UI: Toolbar menus don't disappear when another menu is opened on touch devices - https://phabricator.wikimedia.org/T87818#999774 (10matmarex) 3NEW [23:03:45] 3OOjs-UI: Toolbar menus don't disappear when another menu is opened on touch devices - https://phabricator.wikimedia.org/T87818#999782 (10matmarex) http://tools.wmflabs.org/oojs-ui/oojs-ui/demos/index.html#toolbars-apex-vector-ltr {F32689} [23:03:57] RoanKattouw, so I read https://phabricator.wikimedia.org/T87418 as being about setting HTML once instead of many times in a loop [23:04:16] Krenair: Yeah, but I think the reporter didn't know what they were talking about [23:04:44] Yes there is a loop, but all those things are going to completely different places [23:04:50] It's not appending them right below each other [23:04:58] your commit is just changing jQuery.html to just use innerHTML [23:04:58] from jQuery.html* [23:05:23] right [23:06:05] (03CR) 10Alex Monk: [C: 032] dm.InternalList: Use DOM methods instead of jQuery .html() [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/186883 (https://phabricator.wikimedia.org/T87418) (owner: 10Catrope) [23:06:16] (03PS2) 10Jforrester: Widget#setDisabled: Set aria-disabled too. [oojs/ui] - 10https://gerrit.wikimedia.org/r/187163 (https://phabricator.wikimedia.org/T87690) (owner: 10TheDJ) [23:06:42] Yeah I think the bug as reported is probably misguided [23:08:02] 3VisualEditor-MediaWiki-References, VisualEditor: [Regression wmf13] Creating a citation without filling in a required field throws "Cannot read property 'createElement' of null" - https://phabricator.wikimedia.org/T78626#999794 (10Mooeypoo) This doesn't happen anymore in master. [23:08:49] (03Merged) 10jenkins-bot: dm.InternalList: Use DOM methods instead of jQuery .html() [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/186883 (https://phabricator.wikimedia.org/T87418) (owner: 10Catrope) [23:14:24] edsanders|away, https://gerrit.wikimedia.org/r/#/c/159006/ [23:14:29] edsanders|away, what is https://gerrit.wikimedia.org/r/#/c/186645/1 for? [23:25:36] 3VisualEditor-ContentEditable, Parsoid, VisualEditor: Infobox of "en:Medway SLA100 Executive" not visible in edit mode - https://phabricator.wikimedia.org/T87779#999872 (10Etonkovidova) p:5Triage>3High [23:25:50] (03PS3) 10Jforrester: Widget#setDisabled: Set aria-disabled too [oojs/ui] - 10https://gerrit.wikimedia.org/r/187163 (https://phabricator.wikimedia.org/T87690) (owner: 10TheDJ) [23:26:00] (03CR) 10Jforrester: [C: 031] Widget#setDisabled: Set aria-disabled too [oojs/ui] - 10https://gerrit.wikimedia.org/r/187163 (https://phabricator.wikimedia.org/T87690) (owner: 10TheDJ) [23:26:54] (03CR) 10Jforrester: "recheck" [oojs/ui] - 10https://gerrit.wikimedia.org/r/187256 (https://phabricator.wikimedia.org/T87649) (owner: 10Bartosz Dziewoński) [23:26:59] (03CR) 10jenkins-bot: [V: 04-1] Widget#setDisabled: Set aria-disabled too [oojs/ui] - 10https://gerrit.wikimedia.org/r/187163 (https://phabricator.wikimedia.org/T87690) (owner: 10TheDJ) [23:27:05] (03CR) 10Jforrester: "recheck" [oojs/ui] - 10https://gerrit.wikimedia.org/r/187264 (https://phabricator.wikimedia.org/T87787) (owner: 10Mooeypoo) [23:28:19] (03CR) 10Jforrester: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186887 (https://phabricator.wikimedia.org/T87417) (owner: 10Catrope) [23:28:26] (03CR) 10Jforrester: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186108 (https://phabricator.wikimedia.org/T53798) (owner: 10Jforrester) [23:29:13] (03CR) 10Jforrester: [C: 032] Update permanent link and PDF download link oldids on save [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187179 (https://phabricator.wikimedia.org/T74461) (owner: 10Alex Monk) [23:29:19] (03CR) 10Jforrester: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187084 (owner: 10Jforrester) [23:29:27] (03CR) 10Jforrester: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185589 (https://phabricator.wikimedia.org/T87267) (owner: 10Mooeypoo) [23:29:47] RoanKattouw, can you take a look at this ? https://gerrit.wikimedia.org/r/#/c/187264/1 [23:30:48] RoanKattouw, actually, that's probably for TrevorP|Away [23:30:57] 3VisualEditor-ContentEditable, Parsoid, VisualEditor: Infobox of "en:Medway SLA100 Executive" not visible in edit mode - https://phabricator.wikimedia.org/T87779#999878 (10matmarex) Parsoid rendering at http://parsoid.wmflabs.org/enwiki/Medway_SLA100_Executive?oldid=644591209 indeed doesn't include the infobox (... [23:31:01] It's a fairly serious regression bug, though :\ [23:31:34] (03CR) 10Jforrester: [C: 032] "Push this over the line." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186887 (https://phabricator.wikimedia.org/T87417) (owner: 10Catrope) [23:31:52] (03CR) 10Jforrester: [C: 032] "Push this over the line. (Alex's +2.)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186108 (https://phabricator.wikimedia.org/T53798) (owner: 10Jforrester) [23:32:01] (03PS1) 10TheDJ: Remove disabled buttons from keyboard navigation flow [oojs/ui] - 10https://gerrit.wikimedia.org/r/187274 (https://phabricator.wikimedia.org/T87690) [23:33:41] 3VisualEditor: [Regression wmf16] Cannot close citation dialog getting error:TypeError: Cannot read property '$element' of null - https://phabricator.wikimedia.org/T87787#999894 (10Mooeypoo) >>! In T87787#999327, @Catrope wrote: > I think this might be because the focus function doesn't account for the `!page &&... [23:33:41] (03CR) 10Bartosz Dziewoński: Widget#setDisabled: Set aria-disabled too (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/187163 (https://phabricator.wikimedia.org/T87690) (owner: 10TheDJ) [23:33:55] (03Merged) 10jenkins-bot: Update permanent link and PDF download link oldids on save [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187179 (https://phabricator.wikimedia.org/T74461) (owner: 10Alex Monk) [23:34:17] (03CR) 10jenkins-bot: [V: 04-1] Remove disabled buttons from keyboard navigation flow [oojs/ui] - 10https://gerrit.wikimedia.org/r/187274 (https://phabricator.wikimedia.org/T87690) (owner: 10TheDJ) [23:34:36] (03CR) 10Bartosz Dziewoński: "(This will conflict with https://gerrit.wikimedia.org/r/#/c/183718/)" [oojs/ui] - 10https://gerrit.wikimedia.org/r/187274 (https://phabricator.wikimedia.org/T87690) (owner: 10TheDJ) [23:34:45] 3VisualEditor-EditingTools, VisualEditor: Add some more keyboard shortcuts for VisualEditor's built-in Search and Replace system - https://phabricator.wikimedia.org/T87113#999901 (10Jdforrester-WMF) 5Open>3Resolved [23:35:11] 3VisualEditor, VisualEditor-Performance: Batch DOM insertions in ve.dm.InternalList.convertToData - https://phabricator.wikimedia.org/T87418#999907 (10Jdforrester-WMF) 5Open>3Resolved [23:35:29] 3VisualEditor, VisualEditor-MediaWiki: Oldid in navigation links isn't updated after saving - https://phabricator.wikimedia.org/T74461#999910 (10Jdforrester-WMF) 5Open>3Resolved [23:36:25] 3UI-Standardization, MediaWiki-Interface, OOjs-UI: Provide the OOUI PHP module inside MW core - https://phabricator.wikimedia.org/T74714#999923 (10Jdforrester-WMF) [23:37:41] (03CR) 10Jforrester: "I56e7802 is now merged." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175488 (owner: 10Esanders) [23:38:03] (03Merged) 10jenkins-bot: Use DOM methods instead of jQuery .html() in references DM code [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186887 (https://phabricator.wikimedia.org/T87417) (owner: 10Catrope) [23:38:05] (03CR) 10jenkins-bot: [V: 04-1] MWMediaDialog: Add contextual help for controls [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186108 (https://phabricator.wikimedia.org/T53798) (owner: 10Jforrester) [23:39:24] (03CR) 10Jforrester: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186108 (https://phabricator.wikimedia.org/T53798) (owner: 10Jforrester) [23:39:41] (03CR) 10Jforrester: [C: 032] MWMediaDialog: Add contextual help for controls [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186108 (https://phabricator.wikimedia.org/T53798) (owner: 10Jforrester) [23:39:59] * aude waves to James_F :) [23:40:06] Hey aude. [23:40:17] someone want to show me the citoid stuff or [23:40:34] ask/talk about wikidata stuff? [23:40:42] aude: Given that bits of Beta Labs are still flakey, now may not be ideal. [23:40:46] :/ [23:41:25] possibly our work on references might be able to integrate with citoid, or at least some gadget [23:41:38] Your work for structured references? [23:41:43] I thought that was on ice? [23:41:44] Krinkle, does https://gerrit.wikimedia.org/r/#/c/187144/ break the array signature? [23:41:49] i think [23:42:01] might not be fully structured, but we want them easier [23:42:03] (03Merged) 10jenkins-bot: MWMediaDialog: Add contextual help for controls [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186108 (https://phabricator.wikimedia.org/T53798) (owner: 10Jforrester) [23:42:09] aude: Ah. Hmm. [23:42:11] like add isbn and then fetch the other parts of a reference [23:42:37] Hmm. In that case, yes, you should totally talk to mvolz who's the expert in citoid (she built the service). [23:42:37] might be a gadget at first.... not sure [23:42:43] ok [23:42:47] This is to add to Wikidata? [23:42:56] i think so [23:43:00] … [23:43:12] really a lydia question, but we want references easier and are thinking about it [23:43:21] Well, if you're adding to wikitext or to VisualEditor that's what's mvolz has done already. [23:43:32] hm [23:43:47] or my idea.... if i am transferring data from wikipedia to wikidata [23:43:54] i want a list of references from the wikipedia page [23:43:55] 3VisualEditor: Autofill from URL option changes its position in the menu for newly created page - https://phabricator.wikimedia.org/T87822#999982 (10Ryasmeen) 3NEW [23:43:59] be able to choose one [23:44:03] and add it to the statement [23:44:11] also a gadget probably [23:44:18] Hmm. [23:44:30] rather than "stated in" : "wikipedia" [23:44:46] Right. [23:45:03] where is mvolz? [23:45:16] in the office? [23:45:29] aude: UK. [23:45:33] hm [23:45:34] ok [23:45:46] can email [23:46:21] 3VisualEditor: in language screenshots there must be a way to add more margins around the element that is being cropped - https://phabricator.wikimedia.org/T87786#1000000 (10Jdforrester-WMF) p:5Triage>3Normal [23:46:55] 3VisualEditor-ContentEditable, VisualEditor: Clean up mixed use of getters, attributes and properties around rowspan/colspan in TableCellNode - https://phabricator.wikimedia.org/T87798#1000003 (10Jdforrester-WMF) p:5Triage>3Low [23:47:53] 3VisualEditor-MediaWiki-References, VisualEditor, Citoid: "Autofill from URL" option changes its position in the menu for newly created page - https://phabricator.wikimedia.org/T87822#1000008 (10Jdforrester-WMF) p:5Triage>3Normal [23:48:56] 3VisualEditor: Entering a page name as full URL in the VisualEditor link widget should offer converting it to an internal link - https://phabricator.wikimedia.org/T87728#1000018 (10Jdforrester-WMF) 5Open>3declined a:3Jdforrester-WMF We're actually splitting the ability to insert external links from the int... [23:49:16] aude: Please CC me so I can help. :-) [23:50:37] (03PS10) 10Alex Monk: Combine imageinfo requests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180228 (https://phabricator.wikimedia.org/T75822) [23:52:22] edsanders, please see https://gerrit.wikimedia.org/r/#/c/159006/ [23:52:22] edsanders, what is https://gerrit.wikimedia.org/r/#/c/186645/1 for? [23:55:20] James_F: ok :) [23:59:56] (03CR) 10TheDJ: Widget#setDisabled: Set aria-disabled too (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/187163 (https://phabricator.wikimedia.org/T87690) (owner: 10TheDJ)